[Qemu-devel] [PATCH v8 29/34] target/riscv: Remove decode_RV32_64G()

2019-02-22 Thread Bastian Koppelmann
decodetree handles all instructions now so the fallback is not necessary anymore. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/translate.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/ta

[Qemu-devel] [PATCH v8 12/34] target/riscv: Convert RV64F insns to decodetree

2019-02-22 Thread Bastian Koppelmann
Acked-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- v7 -> v8: - add missing RVF checks target/riscv/insn32-64.decode | 6 +++ target/riscv/insn_trans/trans_rvf.inc.c | 60 + 2 files ch

[Qemu-devel] [PATCH v8 15/34] target/riscv: Convert RV priv insns to decodetree

2019-02-22 Thread Bastian Koppelmann
Acked-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- v7 -> v8: - riscv_has_ext -> has_ext - env->ctx->priv_version -> ctx->priv_version target/riscv/insn32.decode| 15 +++ .../riscv/insn_trans/tr

[Qemu-devel] [PATCH v8 18/34] target/riscv: Convert quadrant 2 of RVXC insns to decodetree

2019-02-22 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- v7 -> v8: - fixed wrongly inserted #ifdef TARGET_RISCV64 that lead to a compile error target/riscv/insn16.decode | 31 target/riscv/insn_trans/trans_rvc.inc.c | 101 +++

[Qemu-devel] [PATCH v8 28/34] target/riscv: Remove gen_system()

2019-02-22 Thread Bastian Koppelmann
with all 16 bit insns moved to decodetree no path is falling back to gen_system(), so we can remove it. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/translate.c | 34 -- 1 file changed, 34 deletions(

[Qemu-devel] [PATCH v8 34/34] target/riscv: Remaining rvc insn reuse 32 bit translators

2019-02-22 Thread Bastian Koppelmann
only one translate functions of rvc needs to handle special cases. For the other rvc insns we can remove the extra layer of indirection. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann --- target/riscv/insn16.decode | 37 +-- target/riscv/insn_trans

[Qemu-devel] [PATCH v8 03/34] target/riscv: Convert RV32I load/store insns to decodetree

2019-02-22 Thread Bastian Koppelmann
Acked-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/insn32.decode | 10 ++ target/riscv/insn_trans/trans_rvi.inc.c | 48 + 2 files changed, 58 insertions(+) diff --git a

[Qemu-devel] [PATCH v8 01/34] target/riscv: Activate decodetree and implemnt LUI & AUIPC

2019-02-22 Thread Bastian Koppelmann
for now only LUI & AUIPC are decoded and translated. If decodetree fails, we fall back to the old decoder. Reviewed-by: Richard Henderson Acked-by: Alistair Francis Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/Makefile.objs | 10 +++ target/ris

[Qemu-devel] [PATCH v8 25/34] target/riscv: Remove shift and slt insn manual decoding

2019-02-22 Thread Bastian Koppelmann
Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/insn_trans/trans_rvi.inc.c | 93 + target/riscv/translate.c| 59 +--- 2 files changed, 81 insertions(+), 71 deletions(-) diff --git a/

[Qemu-devel] [PATCH v8 14/34] target/riscv: Convert RV64D insns to decodetree

2019-02-22 Thread Bastian Koppelmann
Acked-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- v7 -> v8: - add missing RVD checks target/riscv/insn32-64.decode | 8 + target/riscv/insn_trans/trans_rvd.inc.c | 82 target/riscv/translate.c

[Qemu-devel] [PATCH v8 10/34] target/riscv: Convert RV64A insns to decodetree

2019-02-22 Thread Bastian Koppelmann
Acked-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/insn32-64.decode | 13 +++ target/riscv/insn_trans/trans_rva.inc.c | 58 ++ target/riscv/translate.c| 144 -

[Qemu-devel] [PATCH v8 11/34] target/riscv: Convert RV32F insns to decodetree

2019-02-22 Thread Bastian Koppelmann
Acked-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- v7 -> v8: - fix REQUIRE_FPU macro here - add missing RVF checks target/riscv/insn32.decode | 35 +++ target/riscv/insn_trans/trans_rvf.inc.c | 379 +

[Qemu-devel] [PULL 27/27] tests/virtio-blk: add test for DISCARD command

2019-02-22 Thread Stefan Hajnoczi
From: Stefano Garzarella If the DISCARD feature is enabled, we try this command in the test_basic(), checking only the status returned by the request. Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella Message-id: 20190221103314.58500-11-sgarz...@redhat.com Message-Id: <20190221103

[Qemu-devel] [PULL 24/27] tests/virtio-blk: change assert on data_size in virtio_blk_request()

2019-02-22 Thread Stefan Hajnoczi
From: Stefano Garzarella The size of data in the virtio_blk_request must be a multiple of 512 bytes for IN and OUT requests, or a multiple of the size of struct virtio_blk_discard_write_zeroes for DISCARD and WRITE_ZEROES requests. Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi R

[Qemu-devel] [PATCH v8 21/34] target/riscv: Remove manual decoding from gen_load()

2019-02-22 Thread Bastian Koppelmann
With decodetree we don't need to convert RISC-V opcodes into to MemOps as the old gen_load() did. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/insn_trans/trans_rvi.inc.c | 35 +++-- target/riscv/translate.c

Re: [Qemu-devel] [RFC PATCH 06/11] qcow2: Don't assume 0 is an invalid cluster offset

2019-02-22 Thread Max Reitz
On 19.02.19 09:45, Kevin Wolf wrote: > Am 19.02.2019 um 00:13 hat Max Reitz geschrieben: >> On 31.01.19 18:55, Kevin Wolf wrote: >>> The cluster allocation code uses 0 as an invalid offset that is used in >>> case of errors or as "offset not yet determined". With external data >>> files, a host clu

[Qemu-devel] [PATCH v8 07/34] target/riscv: Convert RVXI csr insns to decodetree

2019-02-22 Thread Bastian Koppelmann
Acked-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/insn32.decode | 8 +++ target/riscv/insn_trans/trans_rvi.inc.c | 79 + target/riscv/translate.c| 43 +

[Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

2019-02-22 Thread Bastian Koppelmann
Hi, this patchset converts the RISC-V decoder to decodetree in four major steps: 1) Convert 32-bit instructions to decodetree [Patch 1-15]: Many of the gen_* functions are called by the decode functions for 16-bit and 32-bit functions. If we move translation code from the gen_* functi

[Qemu-devel] [PULL 19/27] virtio-blk: add host_features field in VirtIOBlock

2019-02-22 Thread Stefan Hajnoczi
From: Stefano Garzarella Since configurable features for virtio-blk are growing, this patch adds host_features field in the struct VirtIOBlock. (as in virtio-net) In this way, we can avoid to add new fields for new properties and we can directly set VIRTIO_BLK_F* flags in the host_features. We u

[Qemu-devel] [PULL 21/27] virtio-net: make VirtIOFeature usable for other virtio devices

2019-02-22 Thread Stefan Hajnoczi
From: Stefano Garzarella In order to use VirtIOFeature also in other virtio devices, we move its declaration and the endof() macro (renamed in virtio_endof()) in virtio.h. We add virtio_feature_get_config_size() function to iterate the array of VirtIOFeature and to return the config size dependin

[Qemu-devel] [PATCH v8 09/34] target/riscv: Convert RV32A insns to decodetree

2019-02-22 Thread Bastian Koppelmann
Acked-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- v7 -> v8: -add missing RVA checks target/riscv/insn32.decode | 17 +++ target/riscv/insn_trans/trans_rva.inc.c | 160 target/ris

[Qemu-devel] [PULL 18/27] virtio-blk: add acct_failed param to virtio_blk_handle_rw_error()

2019-02-22 Thread Stefan Hajnoczi
From: Stefano Garzarella We add acct_failed param in order to use virtio_blk_handle_rw_error() also when is not required to call block_acct_failed(). (eg. a discard operation is failed) Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella Message-id:

[Qemu-devel] [PATCH v8 04/34] target/riscv: Convert RV64I load/store insns to decodetree

2019-02-22 Thread Bastian Koppelmann
this splits the 64-bit only instructions into its own decode file such that we generate the decoder for these instructions only for the RISC-V 64 bit target. Acked-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/

[Qemu-devel] [PULL 20/27] virtio-blk: add "discard" and "write-zeroes" properties

2019-02-22 Thread Stefan Hajnoczi
From: Stefano Garzarella In order to avoid migration issues, we enable DISCARD and WRITE_ZEROES features only for machine type >= 4.0 As discussed with Michael S. Tsirkin and Stefan Hajnoczi on the list [1], DISCARD operation should not have security implications (eg. page cache attacks), so we

[Qemu-devel] [PULL 23/27] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-22 Thread Stefan Hajnoczi
From: Stefano Garzarella This patch adds the support of DISCARD and WRITE_ZEROES commands, that have been introduced in the virtio-blk protocol to have better performance when using SSD backend. We support only one segment per request since multiple segments are not widely used and there are no

[Qemu-devel] [PULL 25/27] tests/virtio-blk: add virtio_blk_fix_dwz_hdr() function

2019-02-22 Thread Stefan Hajnoczi
From: Stefano Garzarella This function is useful to fix the endianness of struct virtio_blk_discard_write_zeroes headers. Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella Message-id: 20190221103314.58500-9-sgarz...@redhat.com Message-Id: <20190221103314.58500-9-sgarz...@redhat.co

[Qemu-devel] [PULL 26/27] tests/virtio-blk: add test for WRITE_ZEROES command

2019-02-22 Thread Stefan Hajnoczi
From: Stefano Garzarella If the WRITE_ZEROES feature is enabled, we check this command in the test_basic(). Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Acked-by: Thomas Huth Signed-off-by: Stefano Garzarella Message-id: 20190221103314.58500-10-sgarz...@redhat.com Message-Id:

[Qemu-devel] [PULL 15/27] hw/ide: drop iov field from IDEState

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy @iov is used only to initialize @qiov. Let's use new qemu_iovec_init_buf() instead, which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-16-vsement...@vi

[Qemu-devel] [PULL 16/27] hw/ide: drop iov field from IDEBufferedRequest

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy @iov is used only to initialize @qiov. Let's use new qemu_iovec_init_buf() instead, which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-17-vsement...@vi

[Qemu-devel] [PULL 22/27] virtio-blk: set config size depending on the features enabled

2019-02-22 Thread Stefan Hajnoczi
From: Stefano Garzarella Starting from DISABLE and WRITE_ZEROES features, we use an array of VirtIOFeature (as virtio-net) to properly set the config size depending on the features enabled. Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella Message-id: 20190221103314.58500-6-sgarz.

[Qemu-devel] [PULL 17/27] hw/ide: drop iov field from IDEDMA

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy @iov is used only to initialize @qiov. Let's use new qemu_iovec_init_buf() instead, which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-18-vsement...@vi

[Qemu-devel] [PULL 14/27] tests/test-bdrv-drain: use QEMU_IOVEC_INIT_BUF

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use new QEMU_IOVEC_INIT_BUF() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-15-vsement...@virtuozzo

[Qemu-devel] [PULL 08/27] block/qcow: use qemu_iovec_init_buf

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-9-vsement...@virtuozzo.

[Qemu-devel] [PULL 12/27] qemu-img: use qemu_iovec_init_buf

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-13-vsement...@virtuozzo

[Qemu-devel] [PULL 03/27] block/block-backend: use QEMU_IOVEC_INIT_BUF

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use new QEMU_IOVEC_INIT_BUF() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-4-vsement...@virtuozzo.

[Qemu-devel] [PULL 10/27] block/qed: use qemu_iovec_init_buf

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-11-vsement...@virtuozzo

[Qemu-devel] [PULL 09/27] block/qcow2: use qemu_iovec_init_buf

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-10-vsement...@virtuozzo

[Qemu-devel] [PULL 01/27] block: enhance QEMUIOVector structure

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Add a possibility of embedded iovec, for cases when we need only one local iov. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-id: 20190218140926.333779-2-vsement...@virtuozzo.com Message-Id: <20190218140926.333779-2-vsement...@vi

[Qemu-devel] [PULL 13/27] migration/block: use qemu_iovec_init_buf

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-14-vsement...@virtuozzo

[Qemu-devel] [PULL 05/27] block/commit: use QEMU_IOVEC_INIT_BUF

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use new QEMU_IOVEC_INIT_BUF() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-6-vsement...@virtuozzo.

[Qemu-devel] [PULL 07/27] block/parallels: use QEMU_IOVEC_INIT_BUF

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use new QEMU_IOVEC_INIT_BUF() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-8-vsement...@virtuozzo.

[Qemu-devel] [PULL 11/27] block/vmdk: use qemu_iovec_init_buf

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-12-vsement...@virtuozzo

[Qemu-devel] [PULL 00/27] Block patches

2019-02-22 Thread Stefan Hajnoczi
The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-02-21 13:09:33 +) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request f

[Qemu-devel] [PULL 06/27] block/stream: use QEMU_IOVEC_INIT_BUF

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use new QEMU_IOVEC_INIT_BUF() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-7-vsement...@virtuozzo.

[Qemu-devel] [PULL 04/27] block/backup: use qemu_iovec_init_buf

2019-02-22 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-id: 20190218140926.333779-5-vsement...@virtuozzo.

Re: [Qemu-devel] [PATCH v7 07/17] hw/arm/virt: Dynamic memory map depending on RAM requirements

2019-02-22 Thread Auger Eric
Hi Igor, On 2/22/19 1:57 PM, Igor Mammedov wrote: > On Wed, 20 Feb 2019 23:39:53 +0100 > Eric Auger wrote: > >> Up to now the memory map has been static and the high IO region >> base has always been 256GiB. >> >> This patch modifies the virt_set_memmap() function, which freezes >> the memory ma

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-22 Thread Stefan Hajnoczi
On Fri, Feb 22, 2019 at 12:57 PM Fernando Casas Schössow wrote: I have CCed Natanael Copa, qemu package maintainer in Alpine Linux. Fernando: Can you confirm that the bug occurs with an unmodified Alpine Linux qemu binary? Richard: Commit 7db2145a6826b14efceb8dd64bfe6ad8647072eb ("bswap: Add ho

Re: [Qemu-devel] [PATCH v3 0/3] target/arm: Reduce overhead of cpu_get_tb_cpu_state

2019-02-22 Thread Alex Bennée
Richard Henderson writes: > Changes since v2: > * Do not cache VECLEN, VECSTRIDE, VFPEN. > These variables come from VFP_FPSCR and VFP_FPEXC, not from > system control registers. > * Move HANDLER and STACKCHECK to rebuild_hflags_a32, > instead of building them in rebuild_hflags_

Re: [Qemu-devel] [PATCH v7 08/17] hw/arm/virt: Implement kvm_type function for 4.0 machine

2019-02-22 Thread Auger Eric
Hi Igor, On 2/22/19 1:45 PM, Igor Mammedov wrote: > On Wed, 20 Feb 2019 23:39:54 +0100 > Eric Auger wrote: > >> This patch implements the machine class kvm_type() callback. >> It returns the number of bits requested to implement the whole GPA >> range including the RAM and IO regions located bey

[Qemu-devel] [Bug 1805697] Re: egl-headless crashes

2019-02-22 Thread Ryan Press
I have the same issue. The patch (which is already included in my git source) did not help. I can use the command line solution but it's not ideal as I connect to the VM from multiple computers with different resolutions. Also if I use "Auto resize VM to window" the VM immediately crashes with t

Re: [Qemu-devel] [RFC PATCH 11/11] qcow2: Add data file to ImageInfoSpecificQCow2

2019-02-22 Thread Max Reitz
On 19.02.19 10:17, Kevin Wolf wrote: > Am 19.02.2019 um 01:47 hat Max Reitz geschrieben: >> On 31.01.19 18:55, Kevin Wolf wrote: >>> Signed-off-by: Kevin Wolf >>> --- >>> qapi/block-core.json | 1 + >>> block/qcow2.c| 6 +- >>> 2 files changed, 6 insertions(+), 1 deletion(-) >> >> [..

Re: [Qemu-devel] [PULL 0/2] tcg patch queue

2019-02-22 Thread Peter Maydell
On Thu, 21 Feb 2019 at 19:02, Richard Henderson wrote: > > The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9: > > Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' > into staging (2019-02-21 13:09:33 +) > > are available in the Git repository

Re: [Qemu-devel] [PATCH v3 3/3] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()

2019-02-22 Thread Daniel P . Berrangé
On Fri, Feb 22, 2019 at 03:46:26PM +0200, Alberto Garcia wrote: > There's a race condition in which the tcp_chr_read() ioc handler can > close a connection that is being written to from another thread. > > Running iotest 136 in a loop triggers this problem and crashes QEMU. > > (gdb) bt > #0 0

Re: [Qemu-devel] [PATCH v7 13/17] hw/arm/virt: Allocate device_memory

2019-02-22 Thread Igor Mammedov
On Wed, 20 Feb 2019 23:39:59 +0100 Eric Auger wrote: > The device memory region is located after the initial RAM. > its start/size are 1GB aligned. > > Signed-off-by: Eric Auger > Signed-off-by: Kwangwoo Lee > > --- > v6 -> v7: > - check the device memory top does not wrap > - check the devic

[Qemu-devel] [PATCH v3 2/3] main-loop: Add qemu_idle_add()

2019-02-22 Thread Alberto Garcia
This works like g_idle_add() but allows specifying a different GMainContext. It also returns the GSource directly instead of its ID number for convenience. qio_task_thread_worker() is modified to make use of this new function. Signed-off-by: Alberto Garcia Reviewed-by: Daniel P. Berrangé --- i

[Qemu-devel] [PATCH v3 3/3] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()

2019-02-22 Thread Alberto Garcia
There's a race condition in which the tcp_chr_read() ioc handler can close a connection that is being written to from another thread. Running iotest 136 in a loop triggers this problem and crashes QEMU. (gdb) bt #0 0x5558b842902d in object_get_class (obj=0x0) at qom/object.c:860 #1 0x000

Re: [Qemu-devel] Testing sysbus devices

2019-02-22 Thread Stephen Checkoway
> On Feb 22, 2019, at 02:42, Markus Armbruster wrote: > > Awesome. The magic setup code in hw/i386/pc_sysfw.c will happily create > any size that's a multiple of 4KiB. The current sizes are 128KiB > writable (power of two, good) and 2MiB - 128KiB for read-only (very much > not a power of two

Re: [Qemu-devel] [PATCH v7 11/17] hw/arm/boot: Expose the PC-DIMM nodes in the DT

2019-02-22 Thread Igor Mammedov
On Wed, 20 Feb 2019 23:39:57 +0100 Eric Auger wrote: > From: Shameer Kolothum > > This patch adds memory nodes corresponding to PC-DIMM regions. > > NV_DIMM and ACPI_NVDIMM configs are not yet set for ARM so we ^^^ git grep says it doesn't exists > don't need to care about NV-DIMM at this s

[Qemu-devel] [PATCH v3 0/3] char-socket: Fix race condition

2019-02-22 Thread Alberto Garcia
This fixes a race condition in which the tcp_chr_read() ioc handler can close a connection that is being written to from another thread. Note: vhost-user-test still fails if QTEST_VHOST_USER_FIXME is set. Berto RFC: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01510.html v1: https:/

[Qemu-devel] [PATCH v3 1/3] main-loop: Fix GSource leak in qio_task_thread_worker()

2019-02-22 Thread Alberto Garcia
After g_source_attach() the GMainContext holds a reference to the GSource, so the caller does not need to keep it. qio_task_thread_worker() is not releasing its reference so the GSource is being leaked since a17536c594bfed94d05667b419f747b692f5fc7f. Signed-off-by: Alberto Garcia Reviewed-by: Dan

Re: [Qemu-devel] Testing sysbus devices

2019-02-22 Thread Stephen Checkoway
> On Feb 22, 2019, at 02:55, Laszlo Ersek wrote: > > OVMF and the q35/i440fx boards use cfi01. The 4KB sector size is assumed > by both QEMU board code and OVMF. The 4KB sector size is not assumed (to > my knowledge) by cfi01.pflash device model code. > > Regarding the full size of each cfi01

Re: [Qemu-devel] [libvirt] [PATCH v5 03/14] audio: -audiodev command line option: documentation

2019-02-22 Thread Daniel P . Berrangé
On Wed, Feb 20, 2019 at 10:37:32PM +0100, Kővágó, Zoltán wrote: > This patch adds documentation of an -audiodev command line option, that > deprecates the old QEMU_* environment variables for audio backend > configuration. It's syntax is similar to existing options (-netdev, > -device, etc): > >

Re: [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-02-22 Thread Markus Armbruster
The other day, I described how my attempt to implement Paolo's suggestion to add block properties to the machine ran into difficulties. To recap briefly, creating devices within a machine's .instance_init() crashes. Turns out device_post_init() calls qdev_get_machine(), which calls container_get()

Re: [Qemu-devel] [PATCH v8 10/11] authz: add QAuthZPAM object type for authorizing using PAM

2019-02-22 Thread Philippe Mathieu-Daudé
Hi Daniel, On 2/22/19 1:24 PM, Daniel P. Berrangé wrote: > On Fri, Feb 22, 2019 at 01:34:12AM +0100, Philippe Mathieu-Daudé wrote: >> Hi Daniel, >> >> On 2/15/19 4:57 PM, Daniel P. Berrangé wrote: >>> From: "Daniel P. Berrange" >>> >>> Add an authorization backend that talks to PAM to check wheth

Re: [Qemu-devel] [PATCH v7 10/17] hw/arm/virt: Add memory hotplug framework

2019-02-22 Thread Igor Mammedov
On Wed, 20 Feb 2019 23:39:56 +0100 Eric Auger wrote: > This patch adds the the memory hot-plug/hot-unplug infrastructure > in machvirt. It is still not enabled as no device memory is allocated. > > Signed-off-by: Eric Auger > Signed-off-by: Shameer Kolothum > Signed-off-by: Kwangwoo Lee with

[Qemu-devel] [PATCH v2 10/13] spapr: introduce routines to delete the KVM IRQ device

2019-02-22 Thread Cédric Le Goater
If a new interrupt mode is chosen by CAS, the machine generates a reset to reconfigure. At this point, the connection with the previous KVM device needs to be closed and a new connection needs to opened with the KVM device operating the chosen interrupt mode. New routines are introduced to destroy

[Qemu-devel] [PATCH v2 12/13] spapr: add KVM support to the 'dual' machine

2019-02-22 Thread Cédric Le Goater
The interrupt mode is chosen by the CAS negotiation process and activated after a reset to take into account the required changes in the machine. This brings new constraints on how the associated KVM IRQ device is initialized. Currently, each model takes care of the initialization of the KVM devic

[Qemu-devel] [PATCH v2 04/13] spapr/xive: add state synchronization with KVM

2019-02-22 Thread Cédric Le Goater
This extends the KVM XIVE device backend with 'synchronize_state' methods used to retrieve the state from KVM. The HW state of the sources, the KVM device and the thread interrupt contexts are collected for the monitor usage and also migration. These get operations rely on their KVM counterpart in

[Qemu-devel] [PATCH v2 07/13] spapr/xive: fix migration of the XiveTCTX under TCG

2019-02-22 Thread Cédric Le Goater
When the thread interrupt management state is retrieved from the KVM VCPU, word2 is saved under the QEMU XIVE thread context to print out the OS CAM line under the QEMU monitor. This breaks the migration of a TCG guest (and with KVM when kernel_irqchip=off) because the matching algorithm of the pr

[Qemu-devel] [PATCH v2 02/13] spapr/xive: add hcall support when under KVM

2019-02-22 Thread Cédric Le Goater
XIVE hcalls are all redirected to QEMU as none are on a fast path. When necessary, QEMU invokes KVM through specific ioctls to perform host operations. QEMU should have done the necessary checks before calling KVM and, in case of failure, H_HARDWARE is simply returned. H_INT_ESB is a special case

[Qemu-devel] [PATCH v2 00/13] spapr: add KVM support to the XIVE interrupt mode

2019-02-22 Thread Cédric Le Goater
Hello, This is the v2 of the QEMU/KVM patchset taking into account the remarks on the interface with Linux/KVM. The first patches introduce the XIVE KVM device, state synchronization and migration support under KVM. The second part of the patchset modifies the XICS and XIVE interrupt models to ad

[Qemu-devel] [PATCH v2 09/13] sysbus: add a sysbus_mmio_unmap() helper

2019-02-22 Thread Cédric Le Goater
This will be used to remove the MMIO regions of the POWER9 XIVE interrupt controller when the sPAPR machine is reseted. Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson --- include/hw/sysbus.h | 1 + hw/core/sysbus.c| 10 ++ 2 files changed, 11 insertions(+) diff --git a/

[Qemu-devel] [PATCH v2 13/13] spapr/xive: fix device hotplug when VM is stopped

2019-02-22 Thread Cédric Le Goater
Instead of switching off the sources, set their state to PENDING to possibly catch a hotplug event occuring while the VM is stopped. At resume, check the previous state and if an interrupt was queued, generate a trigger. Signed-off-by: Cédric Le Goater --- hw/intc/spapr_xive_kvm.c | 22 +

[Qemu-devel] [PATCH v2 05/13] spapr/xive: introduce a VM state change handler

2019-02-22 Thread Cédric Le Goater
This handler is in charge of stabilizing the flow of event notifications in the XIVE controller before migrating a guest. This is a requirement before transferring the guest EQ pages to a destination. When the VM is stopped, the handler masks the sources (PQ=01) to stop the flow of events and save

[Qemu-devel] [PATCH v2 06/13] spapr/xive: add migration support for KVM

2019-02-22 Thread Cédric Le Goater
When the VM is stopped, the VM state handler stabilizes the XIVE IC and marks the EQ pages dirty. These are then transferred to destination before the transfer of the device vmstates starts. The sPAPRXive interrupt controller model captures the XIVE internal tables, EAT and ENDT and the XiveTCTX m

[Qemu-devel] [PATCH v2 01/13] spapr/xive: add KVM support

2019-02-22 Thread Cédric Le Goater
This introduces a set of helpers when KVM is in use, which create the KVM XIVE device, initialize the interrupt sources at a KVM level and connect the interrupt presenters to the vCPU. They also handle the initialization of the TIMA and the source ESB memory regions of the controller. These have a

[Qemu-devel] [PATCH v2 03/13] spapr/xive: activate KVM support

2019-02-22 Thread Cédric Le Goater
All is in place for KVM now. State synchronization and migration will come next. Signed-off-by: Cédric Le Goater --- hw/ppc/spapr_irq.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c index 6e1c36dc62ca..1ad57582a403 100644 --- a/hw/ppc/spapr_i

[Qemu-devel] [PATCH v2 11/13] spapr: check for the activation of the KVM IRQ device

2019-02-22 Thread Cédric Le Goater
The activation of the KVM IRQ device depends on the interrupt mode chosen at CAS time by the machine and some methods used at reset or by the migration need to be protected. Signed-off-by: Cédric Le Goater --- hw/intc/spapr_xive_kvm.c | 28 hw/intc/xics_kvm.c |

[Qemu-devel] [PATCH v2 08/13] spapr/rtas: modify spapr_rtas_register() to remove RTAS handlers

2019-02-22 Thread Cédric Le Goater
Removing RTAS handlers will become necessary when the new pseries machine supporting multiple interrupt mode is introduced. Signed-off-by: Cédric Le Goater --- include/hw/ppc/spapr.h | 4 hw/ppc/spapr_rtas.c| 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/include/hw

Re: [Qemu-devel] [PULL v2 0/8] MIPS queue for February 21st, 2019, v2

2019-02-22 Thread Peter Maydell
On Thu, 21 Feb 2019 at 18:53, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' > into staging (2019-02-21 13:09:33 +) > > are available in the git repository at: > > https://github.com/AMarkovic/qemu tags

Re: [Qemu-devel] [PATCH v7 07/17] hw/arm/virt: Dynamic memory map depending on RAM requirements

2019-02-22 Thread Igor Mammedov
On Wed, 20 Feb 2019 23:39:53 +0100 Eric Auger wrote: > Up to now the memory map has been static and the high IO region > base has always been 256GiB. > > This patch modifies the virt_set_memmap() function, which freezes > the memory map, so that the high IO range base becomes floating, > located

Re: [Qemu-devel] [PATCH v7 08/17] hw/arm/virt: Implement kvm_type function for 4.0 machine

2019-02-22 Thread Igor Mammedov
On Wed, 20 Feb 2019 23:39:54 +0100 Eric Auger wrote: > This patch implements the machine class kvm_type() callback. > It returns the number of bits requested to implement the whole GPA > range including the RAM and IO regions located beyond. > The returned value in passed though the KVM_CREATE_VM

[Qemu-devel] [Bug 1817268] Re: Input/output error during migration

2019-02-22 Thread Dr. David Alan Gilbert
Yes, I think so; although old-style block migration doesn't get much work on it now; so probably the fix I'd recommend for most cases now would be to pad the var file. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

Re: [Qemu-devel] [PATCH 13/13] spapr: add KVM support to the 'dual' machine

2019-02-22 Thread Cédric Le Goater
On 2/13/19 2:32 AM, David Gibson wrote: > On Tue, Feb 12, 2019 at 08:18:19AM +0100, Cédric Le Goater wrote: >> On 2/12/19 2:11 AM, David Gibson wrote: >>> On Mon, Jan 07, 2019 at 07:39:46PM +0100, Cédric Le Goater wrote: The interrupt mode is chosen by the CAS negotiation process and acti

Re: [Qemu-devel] [PATCH v2 0/3] char-socket: Fix race condition

2019-02-22 Thread Paolo Bonzini
On 22/02/19 12:59, Alberto Garcia wrote: > This fixes a race condition in which the tcp_chr_read() ioc handler > can close a connection that is being written to from another thread. > > This is essentially v1 rebased on top of the current master, after > Daniel and Marc-André's chardev series have

Re: [Qemu-devel] [PATCH v2 3/3] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()

2019-02-22 Thread Alberto Garcia
On Fri 22 Feb 2019 01:16:57 PM CET, Daniel P. Berrangé wrote: > On Fri, Feb 22, 2019 at 01:59:12PM +0200, Alberto Garcia wrote: >> There's a race condition in which the tcp_chr_read() ioc handler can >> close a connection that is being written to from another thread. >> >> Running iotest 136 in a

Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-22 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> Alex Bennée writes: >> >>> It looks like there was going to be code to check we had some sort of >>> alignment so lets replace it with an actual check. This is a bit more >>> useful than the enigmatic "failed to read the initial flash content

Re: [Qemu-devel] [PATCH v8 10/11] authz: add QAuthZPAM object type for authorizing using PAM

2019-02-22 Thread Daniel P . Berrangé
On Fri, Feb 22, 2019 at 01:34:12AM +0100, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 2/15/19 4:57 PM, Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > > > Add an authorization backend that talks to PAM to check whether the user > > identity is allowed. This only uses the PAM a

Re: [Qemu-devel] [PATCH v2 3/3] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()

2019-02-22 Thread Daniel P . Berrangé
On Fri, Feb 22, 2019 at 01:59:12PM +0200, Alberto Garcia wrote: > There's a race condition in which the tcp_chr_read() ioc handler can > close a connection that is being written to from another thread. > > Running iotest 136 in a loop triggers this problem and crashes QEMU. > > (gdb) bt > #0 0

Re: [Qemu-devel] [PATCH v2 2/3] main-loop: Add qemu_idle_add()

2019-02-22 Thread Daniel P . Berrangé
On Fri, Feb 22, 2019 at 01:59:11PM +0200, Alberto Garcia wrote: > This works like g_idle_add() but allows specifying a different > GMainContext. It also returns the GSource directly instead of its ID > number for convenience. > > qio_task_thread_worker() is modified to make use of this new functio

[Qemu-devel] [Bug 1817268] Re: Input/output error during migration

2019-02-22 Thread Mathieu Corbin
Thanks you, so it is a bug and not the expected behavior right ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1817268 Title: Input/output error during migration Status in QEMU: New Bug descrip

Re: [Qemu-devel] [PATCH v2 1/3] main-loop: Fix GSource leak in qio_task_thread_worker()

2019-02-22 Thread Daniel P . Berrangé
In $SUBJECT s/main-loop/io/ On Fri, Feb 22, 2019 at 01:59:10PM +0200, Alberto Garcia wrote: > After g_source_attach() the GMainContext holds a reference to the > GSource, so the caller does not need to keep it. > > qio_task_thread_worker() is not releasing its reference so the GSource > is being

[Qemu-devel] [PATCH v2 3/3] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()

2019-02-22 Thread Alberto Garcia
There's a race condition in which the tcp_chr_read() ioc handler can close a connection that is being written to from another thread. Running iotest 136 in a loop triggers this problem and crashes QEMU. (gdb) bt #0 0x5558b842902d in object_get_class (obj=0x0) at qom/object.c:860 #1 0x000

[Qemu-devel] [PATCH v2 0/3] char-socket: Fix race condition

2019-02-22 Thread Alberto Garcia
This fixes a race condition in which the tcp_chr_read() ioc handler can close a connection that is being written to from another thread. This is essentially v1 rebased on top of the current master, after Daniel and Marc-André's chardev series have been merged. Note: vhost-user-test still fails if

[Qemu-devel] [PATCH v2 2/3] main-loop: Add qemu_idle_add()

2019-02-22 Thread Alberto Garcia
This works like g_idle_add() but allows specifying a different GMainContext. It also returns the GSource directly instead of its ID number for convenience. qio_task_thread_worker() is modified to make use of this new function. Signed-off-by: Alberto Garcia --- include/qemu/main-loop.h | 12

[Qemu-devel] [PATCH v2 1/3] main-loop: Fix GSource leak in qio_task_thread_worker()

2019-02-22 Thread Alberto Garcia
After g_source_attach() the GMainContext holds a reference to the GSource, so the caller does not need to keep it. qio_task_thread_worker() is not releasing its reference so the GSource is being leaked since a17536c594bfed94d05667b419f747b692f5fc7f. Signed-off-by: Alberto Garcia --- io/task.c |

Re: [Qemu-devel] [PATCH v3] hw/display: Add basic ATI VGA emulation

2019-02-22 Thread Gerd Hoffmann
On Thu, Feb 21, 2019 at 03:55:14PM +0100, BALATON Zoltan wrote: > At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI > gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and > guests running on these and the PMON2000 firmware of the fulong2e > expect this to be available.

[Qemu-devel] [PATCH v2] iotests: handle TypeError for Python3 in test 242

2019-02-22 Thread Andrey Shinkevich
The data type for bytes in Python3 differs from the one in Python2. Those cases should be managed separately. v1: In the first version, the TypeError in Python3 was handled as the exception. Discussed in the e-mail thread with the Message ID: <1550519997-253534-1-git-send-email-andrey.shinkev...@v

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 2/3] s390x: use a QEMU-style typedef + name for SIGP save area struct

2019-02-22 Thread Christian Borntraeger
On 22.02.2019 09:11, David Hildenbrand wrote: > Convert this to QEMU style. > > Signed-off-by: David Hildenbrand Acked-by: Christian Borntraeger > --- > target/s390x/helper.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/target/s390x/helper.c b/target/s3

Re: [Qemu-devel] [PULL 00/21] target-arm queue

2019-02-22 Thread Peter Maydell
On Thu, 21 Feb 2019 at 18:57, Peter Maydell wrote: > > Arm queue -- mostly the first slice of my Musca patches. > > thanks > -- PMM > > The following changes since commit fc3dbb90f2eb069801bfb4cfe9cbc83cf9c5f4a9: > > Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' > into

<    1   2   3   4   >