[Qemu-devel] [PATCH] ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input device

In fullscreen mode, the window property of cocoaView may not be the key window, and the current implementation would not grab mouse in fullscreen mode after left clicks on relative input devices. This patch used isFullscreen value as a short-cirtuit condition for relative input device grabbing. N

Re: [Qemu-devel] [PATCH] ui/cocoa: Fix mouse grabbing in fullscreen mode for relative input device

Patchew URL: https://patchew.org/QEMU/176e53d9-50b8-405c-82ff-524734226...@me.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 176e53d9-50b8-405c-82ff-524734226...@me.com Subject: [Qemu-devel] [PATCH] ui/cocoa: Fix mouse grabbin

Re: [Qemu-devel] [PATCH 0/2] make docker-travis work again

Wainer dos Santos Moschetta writes: > The `make docker-travis@IMAGE` is broken because: > 1) travis.py fails to parse the current .travis.yml > 2) The travis script does not get the correct reference > to the source directory. It is a regression introduced on > commit 05790dafef1. > > Tested wi

Re: [Qemu-devel] [PATCH 1/2] docker: Fix travis.py parser and misc change

Wainer dos Santos Moschetta writes: > Fixed the travis.py script that has failed to parse the current > QEMU_SRC/.travis.yml file. It no longer makes combinations from > env/matrix, instead it uses explicit includes. Also the compiler > can be omitted from matrix/include, so that Travis chooses

Re: [Qemu-devel] [PATCH 2/2] docker: Fix travis script unable to find source dir

Wainer dos Santos Moschetta writes: > The script generated from QEMU_SRC/.travis.yml uses BUILD_DIR and > SRC_DIR path relative to the current dir, unless these variables > are exported in environment. > > Since commit 05790dafef1 BUILD_DIR is exported in the runner script, > although SRC_DIR i

Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms

On Wed, 20 Mar 2019 at 19:42, Laszlo Ersek wrote: > An alternative to rebasing / reworking the series in-place (for > xz-->bz2) and to missing the 4.0 bus consequently, would be to merge the > PULL req as is, and for me to submit an incremental update, for the > xz-->bz2 replacement. I think that

[Qemu-devel] [PATCH 2/3] vhost-scsi: Add vmstate descriptor

As preparation of enabling migration of vhost-scsi device, define it’s VMState. Note, we keep the convention of verifying in the pre_save() method that the vhost backend must be stopped before attempting to save the device state. Similar to how it is done for vhost-vsock. Reviewed-by: Bijan Mottah

[Qemu-devel] [PATCH 0/3] vhost-scsi: Support live migration

Originally migration was not possible with vhost-scsi because as part of migration, the source host target SCSI device state needs to be saved and loaded into the destination host target SCSI device. This cannot be done by QEMU. As this can be handled either by external orchestrator or by having s

[Qemu-devel] [PATCH 1/3] vhost-scsi: The vhost device should be stopped when the VM is not running

vhost-scsi doesn’t takes into account whether the vm is running or not in order to decide if it should start/stop vhost processing. This would lead to vhost processing still being active when VM the RunState suddenly change to stopped. An example of when this issue is encountered is when Live-Migr

[Qemu-devel] [PATCH 3/3] vhost-scsi: Allow user to enable migration

From: Liran Alon Originally migration was not possible with vhost-scsi because as part of migration, the source host target SCSI device state needs to be saved and loaded into the destination host target SCSI device. This cannot be done by QEMU. As this can be handled either by external orchestr

Re: [Qemu-devel] [Qemu-block] [PATCH] tests/qemu-iotests/235: Allow fallback to tcg and remove it from quick group

On 20/03/2019 18.32, John Snow wrote: > > > On 3/1/19 7:20 AM, Thomas Huth wrote: >> iotest 235 currently only works with KVM - this is bad for systems where >> it is not available, e.g. CI pipelines. The test also works when using >> "tcg" as accelerator, so we can simply add that to the list of

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

On 20/03/2019 16.11, Jason J. Herne wrote: > On 3/13/19 12:31 PM, Jason J. Herne wrote: >> This is to support booting from vfio-ccw dasd devices. We basically >> implement >> the real hardware ipl procedure. This allows for booting Linux guests on >> vfio-ccw devices. >> >> vfio-ccw's channel progr

[Qemu-devel] [PATCH 2/6] exec.c: remove an unnecessary assert on PHYS_MAP_NODE_NIL in phys_map_node_alloc()

PHYS_MAP_NODE_NIL is assigned to PhysPageEntry.ptr in case this is not a leaf entry, while map->nodes_nb range in [0, nodes_nb_alloc). Seems we are asserting on two different things, just remove it. Signed-off-by: Wei Yang --- exec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/exec.c b/e

[Qemu-devel] [PATCH 3/6] exec.c: get nodes_nb_alloc with one MAX calculation

The purpose of these two MAX here is to get the maximum of these three variables: A: map->nodes_nb + nodes B: map->nodes_nb_alloc C: alloc_hint We can write it like MAX(A, B, C). Since the if condition says A > B, this means MAX(A, B, C) = MAX(A, C). This patch just simplify the calc

[Qemu-devel] [PATCH 1/6] exec.c: replace hwaddr with uint64_t for better understanding

Function phys_page_set() and phys_page_set_level() 's argument *nb* stands for number of pages to set instead of hardware address. This would be more proper to use uint64_t instead of hwaddr for its type. Signed-off-by: Wei Yang --- exec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[Qemu-devel] [PATCH 0/6] Refine exec

This serial refine exec a little. Wei Yang (6): exec.c: replace hwaddr with uint64_t for better understanding exec.c: remove an unnecessary assert on PHYS_MAP_NODE_NIL in phys_map_node_alloc() exec.c: get nodes_nb_alloc with one MAX calculation exec.c: subpage->sub_section is already i

[Qemu-devel] [PATCH 5/6] exec.c: correct the maximum skip value during compact

skip is defined with 6 bits. So the maximum value should be (1 << 6). Signed-off-by: Wei Yang --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 788a8c3f69..6c660f656c 100644 --- a/exec.c +++ b/exec.c @@ -322,7 +322,7 @@ static void phys_page_com

[Qemu-devel] [PATCH 4/6] exec.c: subpage->sub_section is already initialized to 0

In subpage_init(), we will set subpage->sub_section to PHYS_SECTION_UNASSIGNED by subpage_register. Since PHYS_SECTION_UNASSIGNED is defined to be 0, and we allocate subpage with g_malloc0, this means subpage->sub_section is already initialized to 0. This patch removes the redundant setup for a ne

[Qemu-devel] [PATCH 6/6] exec.c: add a check between constants to see whether we could skip

The maximum level is defined as P_L2_LEVELS and skip is defined with 6 bits, which means if P_L2_LEVELS < (1 << 6), skip never exceeds the boundary. Since this check is between two constants, which leverages compiler to optimize the code based on different configuration. Signed-off-by: Wei Yang

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

20.03.2019 20:25, Alberto Garcia wrote: > On Wed 20 Mar 2019 10:35:27 AM CET, Vladimir Sementsov-Ogievskiy wrote: >>> Maybe at least this kind of freezing isn't the right tool for block >>> jobs, after all. >> >> I think, the correct way, which will support these correct cases >> (which however don

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

On Thu, Mar 14, 2019 at 10:45:25PM +0800, Jason Wang wrote: > > On 2019/2/25 下午8:33, Michael S. Tsirkin wrote: > > On Mon, Feb 25, 2019 at 03:47:48PM +0800, Jason Wang wrote: > > > On 2019/2/22 下午12:22, Michael S. Tsirkin wrote: > > > > On Thu, Feb 21, 2019 at 10:10:08PM -0500, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH v3 1/8] slirp: update COPYRIGHT to use full 3-Clause BSD License

On 14/03/2019 14.34, Eric Blake wrote: > On 3/14/19 8:10 AM, Marc-André Lureau wrote: >> According to commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove >> the advertising clause from the slirp license"), Danny Gasparovski >> gave permission to license slirp code under 3-clause BSD license: >

Re: [Qemu-devel] [PATCH v3 2/8] slirp: relicense GPL files to BSD-3

On 14/03/2019 14.10, Marc-André Lureau wrote: > In order to make slirp a standalone project, the project must have a > clear license, and be compatible with the GPL or LGPL. > > Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the > advertising clause from the slirp license"), slirp

[Qemu-devel] [PATCH] ohci: don't die on ED_LINK_LIMIT overflow

Stop processing the descriptor list instead. The next frame timer tick will resume the work Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1686705 Suggested-by: Gerd Hoffmann Signed-off-by: Laurent Vivier --- hw/usb/hcd-ohci.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) d

Re: [Qemu-devel] [PATCH v8 1/2] pflash: Require backend size to match device, improve errors

Markus Armbruster writes: > We reject undersized backends with a rather enigmatic "failed to read > the initial flash content" error. For instance: > > $ qemu-system-ppc64 -S -display none -M sam460ex -drive > if=pflash,format=raw,file=eins.img > qemu-system-ppc64: Initialization of d

Re: [Qemu-devel] [PATCH] Clean up includes

On 13/03/2019 17.28, Markus Armbruster wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes, with the changes > to the following files manually reverted: > > contrib/libvh

Re: [Qemu-devel] [PATCH] qemu-pr-helper: check the return value of fcntl in do_pr_out

Hi Zhengui, thanks for this patch! For the next patches, please add a version tag when resending. "git format-patch" and "git send-email" both understand the "-v2" option. On Wed, Mar 20, 2019 at 10:07:27PM +0800, Zhengui li wrote: > The function fcntl maybe return -1, which is not a unsigned typ

Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

On Wed, 20 Mar 2019 at 15:11, Eduardo Otubo wrote: > > The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: > > Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) > > are available in the Git repository at: > > https://github.com/otubo/qemu.git tags/pull-

[Qemu-devel] 答复: [PATCH] qemu-pr-helper: check the return value of fcntl in do_pr_out

Ok！ -邮件原件- 发件人: Stefano Garzarella [mailto:sgarz...@redhat.com] 发送时间: 2019年3月21日 17:28 收件人: lizhengui 抄送: pbonz...@redhat.com; stefa...@redhat.com; mre...@redhat.com; kw...@redhat.com; wangjie (P); qemu-devel@nongnu.org; qemu-bl...@nongnu.org; Fangyi (C) 主题: Re: [Qemu-devel] [PATCH] qem

Re: [Qemu-devel] [PATCH v8 1/2] pflash: Require backend size to match device, improve errors

Le mar. 19 mars 2019 17:35, Markus Armbruster a écrit : > We reject undersized backends with a rather enigmatic "failed to read > the initial flash content" error. For instance: > > $ qemu-system-ppc64 -S -display none -M sam460ex -drive > if=pflash,format=raw,file=eins.img > qemu-system

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

Cleber Rosa writes: > On Thu, Mar 14, 2019 at 03:57:06PM +, Alex Bennée wrote: >> >> Hi, >> >> As we approach stabilisation for 4.0 I thought it would be worth doing a >> review of the current state of CI and stimulate some discussion of where >> it is working for us and what could be impro

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

Wainer dos Santos Moschetta writes: > Hi all, >> Conclusion >> == >> >> I think generally the state of QEMU's CI has improved over the last few >> years but we still have a number of challenges caused by its distributed >> nature and test stability. We are still re-active to failures r

[Qemu-devel] [PATCH] block/vhdx: Use IEC binary prefixes from "qemu/units.h"

IEC binary prefixes are defined in "qemu/units.h", so we can remove redundant definitions in "block/vhdx.h". Signed-off-by: Stefano Garzarella --- block/vhdx-log.c | 1 + block/vhdx.c | 4 +++- block/vhdx.h | 5 - 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/block/v

Re: [Qemu-devel] [PULL 0/3] Filemon next patches

Obviously NACK to applying this PULL given the patchew reported mess up I did with tests. Not sure why patchew never gave any complaint when the original patch was posted & reviewed :-( On Wed, Mar 20, 2019 at 05:41:47PM +, Daniel P. Berrangé wrote: > The following changes since commit 62a172

Re: [Qemu-devel] [PATCH] ohci: don't die on ED_LINK_LIMIT overflow

On 21/03/2019 11:15, BALATON Zoltan wrote: > On Thu, 21 Mar 2019, Laurent Vivier wrote: >> Stop processing the descriptor list instead. The next frame timer tick >> will >> resume the work > > Shoud this log something when the limit is reached to let the user know > why USB stopped working instead

Re: [Qemu-devel] [PATCH] ohci: don't die on ED_LINK_LIMIT overflow

On Thu, 21 Mar 2019, Laurent Vivier wrote: Stop processing the descriptor list instead. The next frame timer tick will resume the work Shoud this log something when the limit is reached to let the user know why USB stopped working instead of silently ignoring frames? Regards, BALATON Zoltan

Re: [Qemu-devel] [PULL 0/1] seccomp branch queue

On 21/03/2019 - 09:30:24, Peter Maydell wrote: > On Wed, 20 Mar 2019 at 15:11, Eduardo Otubo wrote: > > > > The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: > > > > Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) > > > > are available in the Git repo

Re: [Qemu-devel] [PATCH] ohci: don't die on ED_LINK_LIMIT overflow

On Thu, 21 Mar 2019, Laurent Vivier wrote: On 21/03/2019 11:15, BALATON Zoltan wrote: On Thu, 21 Mar 2019, Laurent Vivier wrote: Stop processing the descriptor list instead. The next frame timer tick will resume the work Shoud this log something when the limit is reached to let the user know

[Qemu-devel] [PATCH v3 10/10] hw/arm/virt: Init GED device and enable memory hotplug

This initializes the GED device with base memory and irq, configures ged memory hotplug event and builds the corresponding aml code. GED irq routing to Guest is also enabled. Memory hotplug should now work. Signed-off-by: Shameer Kolothum --- hw/acpi/generic_event_device.c | 18

[Qemu-devel] [PATCH v3 06/10] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT

Generate Memory Affinity Structures for PC-DIMM ranges. Signed-off-by: Shameer Kolothum Signed-off-by: Eric Auger Reviewed-by: Igor Mammedov --- hw/arm/virt-acpi-build.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 20d3c

[Qemu-devel] [PATCH v3 08/10] hw/arm/boot: Expose the PC-DIMM nodes in the DT

This patch adds memory nodes corresponding to PC-DIMM regions. This is an opt-in feature and needs to be enabled("fdt=on") when Guest is booted with DT. NVDIMM and ACPI_NVDIMM configs are not yet set for ARM so we don't need to care about NVDIMM at this stage. Signed-off-by: Shameer Kolothum Sig

[Qemu-devel] [PATCH v3 09/10] hw/acpi: Add ACPI Generic Event Device Support

From: Samuel Ortiz The ACPI Generic Event Device (GED) is a hardware-reduced specific device that handles all platform events, including the hotplug ones. This patch generates the AML code that defines GEDs. Platforms need to specify their own GedEvent array to describe what kind of events they

[Qemu-devel] [PATCH v3 02/10] hw/acpi: Do not create memory hotplug method when handler is not defined

From: Samuel Ortiz With Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, make the memory specific events AML generation optional. The code will only be added when the method name is not NULL. Signed-off-by: Samuel Ortiz Signed-off-by: Shameer Kolothum

[Qemu-devel] [PATCH v3 05/10] hw/arm/virt: Add ACPI support for device memory cold-plug

This adds support to build the aml code so that Guest(ACPI boot) can see the cold-plugged device memory. Memory cold plug support with DT boot is not yet enabled. Signed-off-by: Shameer Kolothum --- default-configs/arm-softmmu.mak| 2 ++ hw/acpi/generic_event_device.c | 23 +

[Qemu-devel] [PATCH v3 01/10] hw/acpi: Make ACPI IO address space configurable

This is in preparation for adding support for ARM64 platforms where it doesn't use port mapped IO for ACPI IO space. Also move the MEMORY_SLOT_SCAN_METHOD/MEMORY_DEVICES_CONTAINER definitions to header so that other memory hotplug event signalling mechanisms (eg. Generic Event Device on HW-reduced

Re: [Qemu-devel] [PULL 0/1] qio next patches

On Wed, 20 Mar 2019 at 16:58, Daniel P. Berrangé wrote: > > The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: > > Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) > > are available in the Git repository at: > > https://github.com/berrange/qemu tags/q

[Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

This is to disable/enable populating DT nodes in case any conflict with acpi tables. The default is "off". This will be used in subsequent patch where cold plug device-memory support is added for DT boot. If DT memory node support is added for cold-plugged device memory, those memory will be visi

Re: [Qemu-devel] [PATCH] qemu-pr-helper: check the return value of fcntl in do_pr_out

On 20/03/19 15:07, Zhengui li wrote: > The function fcntl maybe return -1, which is not a unsigned type. > Unsigned type or Negative values should not do bitwise operator with > O_ACCMODE. Did you actually find a case in which the fcntl can fail? Paolo > Signed-off-by: Zhengui li > --- > scsi/

[Qemu-devel] [PATCH v3 00/10] ARM virt: ACPI memory hotplug support

This series is an attempt to provide device memory hotplug support on ARM virt platform. This is based on Eric's recent works here[1] and carries some of the pc-dimm related patches dropped from his series. The kernel support for arm64 memory hot add was added recently by Robin and hence the gues

[Qemu-devel] [PATCH v3 03/10] hw/arm/virt: Add virtual ACPI device

From: Samuel Ortiz This adds the skeleton to support an acpi device interface for HW-reduced acpi platforms via ACPI GED - Generic Event Device (ACPI v6.1 5.6.9). This will be used by Arm/Virt to add hotplug support. Signed-off-by: Samuel Ortiz Signed-off-by: Shameer Kolothum --- hw/acpi/Kco

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

Am 20.03.2019 um 18:02 hat Alberto Garcia geschrieben: > On Wed 20 Mar 2019 10:16:10 AM CET, Kevin Wolf wrote: > >> Oh, I see. Let's use a shorter chain for simplicity: > >> > >>A <- B <- C <- D <- E > > > > Written from right to left, i.e. E being the base and A the top layer? > > We usually

[Qemu-devel] [PATCH v3 04/10] hw/arm/virt: Add memory hotplug framework

From: Eric Auger This patch adds the the memory hot-plug/hot-unplug infrastructure in machvirt. It is still not enabled as device memory is not yet reported to guest. Signed-off-by: Eric Auger Signed-off-by: Kwangwoo Lee Signed-off-by: Shameer Kolothum --- default-configs/arm-softmmu.mak |

Re: [Qemu-devel] [PATCH v3 00/10] ARM virt: ACPI memory hotplug support

Patchew URL: https://patchew.org/QEMU/20190321104745.28068-1-shameerali.kolothum.th...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190321104745.28068-1-shameerali.kolothum.th...@huawei.com Subject: [Qemu-devel] [PA

[Qemu-devel] [PATCH for-4.1 v3 09/12] pc-bios: document the edk2 firmware images; add firmware descriptors

Update the README file with information on the images added previously, and provide firmware descriptor documents that conform to "docs/interop/firmware.json". Signed-off-by: Laszlo Ersek Reviewed-by: Michal Privoznik Reviewed-by: Michael S. Tsirkin Tested-by: Igor Mammedov --- Notes: v3:

[Qemu-devel] [PATCH for-4.1 v3 12/12] MAINTAINERS: add the "EDK2 Firmware" subsystem

We now have the edk2 submodule, somewhat elaborate build helpers for it, and even a UEFI application written against edk2 whose genuine home is the QEMU repository. Add the "EDK2 Firmware" subsystem such that all relevant pathnames be covered. Suggested-by: Daniel P. Berrangé Suggested-by: Michae

[Qemu-devel] [PATCH for-4.1 v3 10/12] tests: add missing dependency to build QTEST_QEMU_BINARY, round 2

In commit b94b330e2333 ("tests: add missing dependency to build QTEST_QEMU_BINARY", 2017-07-31), Phil fixed the dependency list of make target "check-qtest-%". Namely, the recipe would set QTEST_QEMU_BINARY to the softmmu emulator for the emulation target, but the prerequisites didn't include the e

[Qemu-devel] [PATCH for-4.1 v3 07/12] roms: build edk2 firmware binaries and variable store templates

Add the "efi" target to "Makefile". Introduce "Makefile.edk2" for building and cleaning the firmware images and varstore templates. Collect the common bits from the recipes in the helper script "edk2-build.sh". Signed-off-by: Laszlo Ersek Reviewed-by: Michal Privoznik Reviewed-by: Philippe Mat

[Qemu-devel] [PATCH for-4.1 v3 11/12] Makefile: install the edk2 firmware images and their descriptors

Decompress and install the edk2 firmware blobs as part of "make install", unless blob installation was disabled with configure's "--disable-blobs" option. Additionally, decompress the blobs as a pre-requisite for building softmmu binaries -- this is helpful for both "make check" and other ad-hoc t

[Qemu-devel] [PATCH for-4.1 v3 06/12] roms/Makefile: replace the $(EFIROM) target with "edk2-basetools"

We don't (can't) have a recipe for building just $(EFIROM); therefore, while we call the target $(EFIROM), we actually build all of the edk2 BaseTools. Rename the target to edk2-basetools, and update the iPXE prerequisite accordingly. This will let other targets depend on "edk2-basetools", where an

[Qemu-devel] [PATCH for-4.1 v3 08/12] pc-bios: add edk2 firmware binaries and variable store templates

Add the files built by the last patch: (compressed) binaries, and the cumulative license text that covers them. Signed-off-by: Laszlo Ersek Reviewed-by: Michal Privoznik Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin --- Notes: v3: - pick up Michal's R-b

[Qemu-devel] [PATCH for-4.1 v3 05/12] roms/edk2-funcs.sh: add the qemu_edk2_get_thread_count() function

The edk2 "build" utility natively supports building modules (that is, INF files) in parallel. The feature is not useful when building a single module (with the "-m" option), but it is useful for platform firmware builds (which include many modules). Add a function that determines the "-n" option ar

[Qemu-devel] [PATCH for-4.1 v3 03/12] tests/uefi-test-tools/build.sh: work around TianoCore#1607

The edk2-stabe201903 release introduced Python3 support to edk2's BaseTools; however the Python3 enablement breaks in a corner case (which is nevertheless supported by the edk2 community), namely the in-module parallelization that we utilize. This is tracked under

[Qemu-devel] [PATCH for-4.1 v3 02/12] roms/edk2-funcs.sh: require gcc-4.8+ for building i386 and x86_64

Adapt the qemu_edk2_get_toolchain() function in "roms/edk2-funcs.sh" in advance to edk2 commit 8d7cdfae8cb8 ("OvmfPkg: require GCC48 or later", 2019-01-08), which is part of the "edk2-stable201903" tag. Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-D

[Qemu-devel] [PATCH for-4.1 v3 04/12] roms/edk2: advance to tag edk2-stable201903

Update the roms/edk2 submodule hash from edk2-stable201811 to edk2-stable201903. The release notes are available at . $ git shortlog edk2-stable201811..edk2-stable201903 Achin Gupta (9): ArmPkg: Add PCDs needed for MM communi

[Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

Repo: https://github.com/lersek/qemu.git Branch: edk2_build_v3 Version 2, that is: [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEMU was posted at: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04670.html 20190313210057.32584-1-lersek@redhat.com">http://mi

[Qemu-devel] [PATCH for-4.1 v3 01/12] roms: lift "edk2-funcs.sh" from "tests/uefi-test-tools/build.sh"

Extract the dense logic for architecture and toolchain massaging from "tests/uefi-test-tools/build.sh", to a set of small functions. We'll reuse these functions for building full platform firmware images. Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu

Re: [Qemu-devel] [PATCH] xen-block: only advertize discard to the frontend when it is enabled...

On Wed, Mar 20, 2019 at 02:28:25PM +, Paul Durrant wrote: > ...and properly enable it when synthesizing a drive. > > The Xen toolstack sets 'discard-enable' to '1' in xenstore when it wants > to enable discard on a specified image. The code in > xen_block_driver_create() correctly parses this

[Qemu-devel] [PATCH] json: Fix off-by-one assert check in next_state()

The assert checking if the value of lexer->state in next_state(), which is used as an index to the 'json_lexer' array, incorrectly checks for an index value less than or equal to ARRAY_SIZE(json_lexer). Fix assert so that it just checks for an index less than the array size. Signed-off-by: Liam Me

[Qemu-devel] [PULL 1/1] crypto/block: remove redundant struct packing to fix build with gcc 9

From: Greg Kurz Build fails with gcc 9: crypto/block-luks.c:689:18: error: taking address of packed member of ‘struct QCryptoBlockLUKSHeader’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 689 | be32_to_cpus(&luks->header.payload_offset); |

Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

On Thu, 21 Mar 2019 at 11:34, Laszlo Ersek wrote: > > Repo: https://github.com/lersek/qemu.git > Branch: edk2_build_v3 > > Version 2, that is: > > [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEMU > > was posted at: > > https://lists.gnu.org/archive/html/qemu-devel/2019-0

[Qemu-devel] [PULL 0/1] Qcrypto next patches

The following changes since commit 6532dcebb6160f94b6b278af5e73784164c669f6: Merge remote-tracking branch 'remotes/berrange/tags/qio-next-pull-request' into staging (2019-03-21 09:33:11 +) are available in the Git repository at: https://github.com/berrange/qemu tags/qcrypto-next-pull-re

[Qemu-devel] [PULL 1/1] authz: Use OBJECT_CHECK() on objects

From: Philippe Mathieu-Daudé TYPE_QAUTHZ is an abstract object of type TYPE_OBJECT. All other are children of TYPE_QAUTHZ, thus also objects. Keep INTERFACE_CHECK() for interfaces, and use OBJECT_CHECK() on objects. Reported-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé Signed-o

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

21.03.2019 13:53, Kevin Wolf wrote: > Am 20.03.2019 um 18:02 hat Alberto Garcia geschrieben: >> On Wed 20 Mar 2019 10:16:10 AM CET, Kevin Wolf wrote: Oh, I see. Let's use a shorter chain for simplicity: A <- B <- C <- D <- E >>> >>> Written from right to left, i.e. E being the ba

[Qemu-devel] [PULL 0/1] Authz next patches

The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) are available in the Git repository at: https://github.com/berrange/qemu tags/authz-next-pull-request for you to fetch changes up to 063603d43ec428c

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

On Mon, 2019-03-18 at 02:31 -0700, Palmer Dabbelt wrote: > On Mon, 18 Mar 2019 01:39:46 PDT (-0700), pbonz...@redhat.com wrote: > > On 15/03/19 21:05, Alistair Francis wrote: > > > Set msi_nonbroken as true for the PLIC. > > > > > > According to the comment located here: > > > https://git.qemu.org

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

On 21/03/19 12:56, Andrea Bolognani wrote: > Just so we're on the same page, are you targeting this at 4.0.0? > If it gets merged in the next few days I can probably get the > corresponding libvirt patches in before our own freeze starts. > > It would be great if we could make it so guests created

Re: [Qemu-devel] [PATCH] xen-block: only advertize discard to the frontend when it is enabled...

> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 21 March 2019 11:42 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; qemu-bl...@nongnu.org; > qemu-devel@nongnu.org; Stefano Stabellini > ; Kevin Wolf ; Max Reitz > > Subject: Re: [PATCH] xen-

Re: [Qemu-devel] [PATCH v1 3/3] .travis.yml: --disable-user for --without-default-devices

On 19/03/2019 13.48, Alex Bennée wrote: > This is essentially a softmmu tweak so don't bother building > linux-user builds as well. > > Signed-off-by: Alex Bennée > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index 407fc

Re: [Qemu-devel] [PULL v3 00/54] Kconfig conversion, excluding ARM and MIPS

On 03/21/19 01:53, Laszlo Ersek wrote: > Hi Paolo, > > (+libvir-list) > > I'd like to report a regression introduced by this patch set: > > On 03/07/19 21:58, Paolo Bonzini wrote: >> The following changes since commit >> 6cb4f6db4f4367faa33da85b15f75bbbd2bed2a6: >> >> Merge remote-tracking bra

Re: [Qemu-devel] [PATCH v1 1/3] configure: add --target-list-exclude

On 19/03/2019 13.47, Alex Bennée wrote: > This is an inverse selection which excludes a selected set of targets > from the default target list. It will mostly be useful for CI > configurations but it might be useful for some users as well. This will be useful for me, too! For my local builds, I no

[Qemu-devel] [PATCH 0/4] build: cleanup in Makefile.objs

This cleanup removes hardware objects from the list of files to be built for linux-user only targets. It also builds traces files only when the related file is built. Tested with: configure --enable-user --disable-system configure --disable-user --disable-system configure --disable-user

[Qemu-devel] [PATCH 1/4] trace: only include trace-event-subdirs when they are needed

Some directories are built only for softmmu targets, and the related trace-event-subdirs must do the same Signed-off-by: Laurent Vivier --- Makefile.objs | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index cf065de5ed44..d90123f1d0a3

[Qemu-devel] [PATCH 2/4] ui: build keymap only with softmmu targets

we don't need to generate the files for linux-user or for the tools Signed-off-by: Laurent Vivier --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index d8dad39c5db1..609fac844637 100644 --- a/Makefile +++ b/Makefile @@ -261,6 +261,7 @@ trace-dtrace-root.o:

[Qemu-devel] [PATCH 3/4] tools: edid-generate.c is part of the tools

We don't need it for softmmu targets. This is needed for next patch that will build hw/ directory only for softmmu and not for tools. Signed-off-by: Laurent Vivier --- Makefile.objs | 5 + 1 file changed, 5 insertions(+) diff --git a/Makefile.objs b/Makefile.objs index d90123f1d0a3..3538789

[Qemu-devel] [PATCH 4/4] build: don't build hardware objects with linux-user

Some objects are only needed for system emulation and tools. We can ignore them for the user mode case Update tests to run accordingly. Signed-off-by: Laurent Vivier --- Makefile.objs | 33 - tests/Makefile.include | 26 +++--- 2 file

[Qemu-devel] [PATCH] .travis.yml: reduce number of targets built while disabling things

This build keeps timing out on Travis and it's unlikely including the additional guest front-ends will catch any failures in the fallback code. Signed-off-by: Alex Bennée --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 3fb3dab46

Re: [Qemu-devel] [PATCH 4/4] build: don't build hardware objects with linux-user

On Thu, Mar 21, 2019 at 01:46:24PM +0100, Laurent Vivier wrote: > Some objects are only needed for system emulation and tools. > We can ignore them for the user mode case > > Update tests to run accordingly. > > Signed-off-by: Laurent Vivier > --- > Makefile.objs | 33 -

Re: [Qemu-devel] [PATCH 4/4] build: don't build hardware objects with linux-user

Le jeu. 21 mars 2019 13:53, Laurent Vivier a écrit : > Some objects are only needed for system emulation and tools. > We can ignore them for the user mode case > Finally! > Update tests to run accordingly. > > Signed-off-by: Laurent Vivier > --- > Makefile.objs | 33

Re: [Qemu-devel] [PATCH 2/4] ui: build keymap only with softmmu targets

Le jeu. 21 mars 2019 13:50, Laurent Vivier a écrit : > we don't need to generate the files for linux-user or for the tools > > Signed-off-by: Laurent Vivier > --- > Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index d8dad39c5db1..609fac844637 100644

Re: [Qemu-devel] [PULL 0/1] Qcrypto next patches

On Thu, 21 Mar 2019 at 12:07, Daniel P. Berrangé wrote: > > The following changes since commit 6532dcebb6160f94b6b278af5e73784164c669f6: > > Merge remote-tracking branch 'remotes/berrange/tags/qio-next-pull-request' > into staging (2019-03-21 09:33:11 +) > > are available in the Git reposit

Re: [Qemu-devel] [PULL v3 00/54] Kconfig conversion, excluding ARM and MIPS

On Thu, 21 Mar 2019 at 12:40, Laszlo Ersek wrote: > In brief, the regression is that the aarch64 system emulator now lists > the "virtio-vga" device for the "virt" machine type: > > $ qemu-system-aarch64 -M virt -device \? | grep virtio-vga > name "virtio-vga", bus PCI > > Here's where I think the

Re: [Qemu-devel] [PATCH 6/8] hw/acpi/Kconfig: Introduce the ACPI_PIIX4 config

On Tue, 19 Mar 2019 23:47:22 +0100 (CET) BALATON Zoltan wrote: > On Tue, 19 Mar 2019, Igor Mammedov wrote: > > On Sun, 17 Mar 2019 01:22:57 +0100 > > Philippe Mathieu-Daudé wrote: > > > >> The PIIX4 chipset is a generic southbridge and can be used by > >> non-X86 hardware. Introduce the ACPI_P

Re: [Qemu-devel] [PATCH] json: Fix off-by-one assert check in next_state()

Liam Merwick 于2019年3月21日周四 下午8:04写道： > The assert checking if the value of lexer->state in next_state(), > which is used as an index to the 'json_lexer' array, incorrectly > checks for an index value less than or equal to ARRAY_SIZE(json_lexer). > Fix assert so that it just checks for an index le

Re: [Qemu-devel] [PATCH v4] hw/acpi: extract acpi_add_rom_blob()

On Thu, 21 Mar 2019 08:21:53 +0800 Wei Yang wrote: > arm and i386 has almost the same function acpi_add_rom_blob(), except > giving different FWCfgCallback function. > > This patch moves acpi_add_rom_blob() to utils.c by passing > FWCfgCallback to it. > > Signed-off-by: Wei Yang > > --- > v4:

Re: [Qemu-devel] [PATCH v1 1/3] configure: add --target-list-exclude

Thomas Huth writes: > On 19/03/2019 13.47, Alex Bennée wrote: >> This is an inverse selection which excludes a selected set of targets >> from the default target list. It will mostly be useful for CI >> configurations but it might be useful for some users as well. > > This will be useful for me

Re: [Qemu-devel] [PULL 0/1] Authz next patches

On Thu, 21 Mar 2019 at 12:11, Daniel P. Berrangé wrote: > > The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: > > Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) > > are available in the Git repository at: > > https://github.com/berrange/qemu tags/a

Re: [Qemu-devel] [PATCH] json: Fix off-by-one assert check in next_state()

Liam Merwick writes: > The assert checking if the value of lexer->state in next_state(), > which is used as an index to the 'json_lexer' array, incorrectly > checks for an index value less than or equal to ARRAY_SIZE(json_lexer). > Fix assert so that it just checks for an index less than the arra

Re: [Qemu-devel] [PATCH] json: Fix off-by-one assert check in next_state()

On Thu, Mar 21, 2019 at 11:57:52AM +, Liam Merwick wrote: > The assert checking if the value of lexer->state in next_state(), > which is used as an index to the 'json_lexer' array, incorrectly > checks for an index value less than or equal to ARRAY_SIZE(json_lexer). > Fix assert so that it just

Re: [Qemu-devel] [PATCH 6/8] hw/acpi/Kconfig: Introduce the ACPI_PIIX4 config

Hi Igor, Le jeu. 21 mars 2019 14:36, Igor Mammedov a écrit : > On Tue, 19 Mar 2019 23:47:22 +0100 (CET) > BALATON Zoltan wrote: > > > On Tue, 19 Mar 2019, Igor Mammedov wrote: > > > On Sun, 17 Mar 2019 01:22:57 +0100 > > > Philippe Mathieu-Daudé wrote: > > > > > >> The PIIX4 chipset is a gener

Re: [Qemu-devel] [PULL v3 00/54] Kconfig conversion, excluding ARM and MIPS

Le jeu. 21 mars 2019 13:39, Laszlo Ersek a écrit : > On 03/21/19 01:53, Laszlo Ersek wrote: > > Hi Paolo, > > > > (+libvir-list) > > > > I'd like to report a regression introduced by this patch set: > > > > On 03/07/19 21:58, Paolo Bonzini wrote: > >> The following changes since commit > >> 6cb4f

  1   2   3   >