Re: [Qemu-devel] [PATCH] RFC: build-sys: move slirp as git submodule project

2019-03-25 Thread Peter Maydell
On Mon, 25 Mar 2019 at 18:51, Eric Blake wrote: > On 3/25/19 1:04 PM, Marc-André Lureau wrote: > > RFC: is this acceptable during freeze? (not a feature or code change) > > It's a big enough change that I'd personally feel more comfortable with > doing it in 4.1, but I'm not opposed if others want

Re: [Qemu-devel] [PATCH v2 0/7] target/mips: Add support for MSA instructions on a big endian host

2019-03-25 Thread Mateja Marjanovic
On 25.3.19. 22:33, Aleksandar Markovic wrote: From: Mateja Marjanovic Subject: [PATCH v2 0/7] target/mips: Add support for MSA instructions on a big endian host From: Mateja Marjanovic While working on adding support for big endian hosts on QEMU for the MSA instructions copy_u, copy_s and

Re: [Qemu-devel] [PATCH v2 5/7] target/mips: Eliminate unreachable case for MSA instructions copy_u

2019-03-25 Thread Mateja Marjanovic
On 25.3.19. 22:16, Aleksandar Markovic wrote: From: Mateja Marjanovic Sent: Monday, March 25, 2019 3:52 PM To: qemu-devel@nongnu.org Cc: aurel...@aurel32.net; Aleksandar Markovic; Aleksandar Rikalo Subject: [PATCH v2 5/7] target/mips: Eliminate unreachable case for MSA instructions copy_u Fr

Re: [Qemu-devel] [PATCH v2 1/7] target/mips: Fix . MSA instructions for MIPS big endian host

2019-03-25 Thread Mateja Marjanovic
On 25.3.19. 22:21, Aleksandar Markovic wrote: From: Mateja Marjanovic Subject: [PATCH v2 1/7] target/mips: Fix . MSA instructions for MIPS big endian host Please split this patch into one for load instructions and another for store instructions. I will do that. I don't think the variable

Re: [Qemu-devel] [PATCH v7 5/6] ppc: spapr: Enable FWNMI capability

2019-03-25 Thread Aravinda Prasad
On Tuesday 26 March 2019 05:03 AM, David Gibson wrote: > On Mon, Mar 25, 2019 at 02:27:45PM +0530, Aravinda Prasad wrote: >> >> >> On Monday 25 March 2019 12:02 PM, David Gibson wrote: >>> On Fri, Mar 22, 2019 at 12:04:16PM +0530, Aravinda Prasad wrote: Enable the KVM capability KVM_CAP_PPC

Re: [Qemu-devel] [PATCH v7 3/6] target/ppc: Handle NMI guest exit

2019-03-25 Thread Aravinda Prasad
On Tuesday 26 March 2019 05:01 AM, David Gibson wrote: > On Mon, Mar 25, 2019 at 01:31:12PM +0530, Aravinda Prasad wrote: >> >> >> On Monday 25 March 2019 11:52 AM, David Gibson wrote: >>> On Fri, Mar 22, 2019 at 12:03:58PM +0530, Aravinda Prasad wrote: Memory error such as bit flips that c

Re: [Qemu-devel] [PATCH v7 2/6] Wrapper function to wait on condition for the main loop mutex

2019-03-25 Thread Aravinda Prasad
On Tuesday 26 March 2019 09:50 AM, David Gibson wrote: > On Mon, Mar 25, 2019 at 01:06:08PM +0530, Aravinda Prasad wrote: >> >> >> On Monday 25 March 2019 11:47 AM, David Gibson wrote: >>> On Fri, Mar 22, 2019 at 12:03:49PM +0530, Aravinda Prasad wrote: Introduce a wrapper function to wait

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

2019-03-25 Thread Markus Armbruster
Zheng Xiang writes: > Hi Peter, > > Thanks for your reply! > > On 2019/3/25 21:11, Peter Maydell wrote: >> On Mon, 25 Mar 2019 at 12:53, Xiang Zheng wrote: >>> >>> Currently we fill the VIRT_FLASH space with two 64MB NOR images when >>> using persistent UEFI variables on QEMU. Actually we only u

[Qemu-devel] Query regarding transparent passing of L2 headers with QEMU sessions

2019-03-25 Thread Ramadoss, Kumar 1. (Nokia - IN/Chennai)
Hi *, This query is regarding transparent passing of L2 headers with QEMU session. I have started a QEMU session from my Centos Linux to start a virtual machine. Guest environment is started and running. Typically, QEMU creates a tap interface (say tap0) in the Centos Linux for which there wo

Re: [Qemu-devel] [PATCH 0/4] pvrdma: Add support for SRQ

2019-03-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190326055252.15138-1-kamalhe...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190326055252.15138-1-kamalhe...@gmail.com Subject: [Qemu-devel] [PATCH 0/4] pvrdma: Add support for

[Qemu-devel] [PATCH] migration: remove not used field xfer_limit

2019-03-25 Thread Wei Yang
MigrationState->xfer_limit is only set to 0 in migrate_init(). Remove this unnecessary field. Signed-off-by: Wei Yang --- migration/migration.c | 1 - migration/migration.h | 1 - 2 files changed, 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index e88acab53b..533c2

[Qemu-devel] [PATCH 3/4] hw/rdma: Modify create/destroy QP to support SRQ

2019-03-25 Thread Kamal Heib
Modify create/destroy QP to support shared receive queue. Signed-off-by: Kamal Heib --- hw/rdma/rdma_backend.c | 9 -- hw/rdma/rdma_backend.h | 6 ++-- hw/rdma/rdma_rm.c| 23 +-- hw/rdma/rdma_rm.h| 3 +- hw/rdma/rdma_rm_defs.h | 1 + hw/rdma/vmw/pvrdma_c

[Qemu-devel] [PATCH 0/4] pvrdma: Add support for SRQ

2019-03-25 Thread Kamal Heib
This series implements the SRQ (Shared Receive Queue) for the pvrdma device, It also includes all the needed functions and definitions for support SRQ in the backend and resource management layers. Kamal Heib (4): hw/rdma: Add SRQ support to backend layer hw/rdma: Add support for managing SRQ

[Qemu-devel] [PATCH 1/4] hw/rdma: Add SRQ support to backend layer

2019-03-25 Thread Kamal Heib
Add the required function and definitions for support shared receive queues (SRQs) in the backend layer. Signed-off-by: Kamal Heib --- hw/rdma/rdma_backend.c | 115 +++- hw/rdma/rdma_backend.h | 12 hw/rdma/rdma_backend_defs.h | 5 ++ 3 files cha

[Qemu-devel] [PATCH 2/4] hw/rdma: Add support for managing SRQ resource

2019-03-25 Thread Kamal Heib
Adding the required functions and definitions for support managing the shared receive queues (SRQs). Signed-off-by: Kamal Heib --- hw/rdma/rdma_rm.c | 83 ++ hw/rdma/rdma_rm.h | 10 + hw/rdma/rdma_rm_defs.h | 8 3 files changed, 101 ins

[Qemu-devel] [PATCH 4/4] hw/pvrdma: Add support for SRQ

2019-03-25 Thread Kamal Heib
Implement the pvrdma device commands for supporting SRQ Signed-off-by: Kamal Heib --- hw/rdma/vmw/pvrdma_cmd.c| 147 hw/rdma/vmw/pvrdma_main.c | 16 hw/rdma/vmw/pvrdma_qp_ops.c | 46 ++- hw/rdma/vmw/pvrdma_qp_ops.h | 1 + 4 files change

Re: [Qemu-devel] [PATCH v7 6/6] migration: Block migration while handling machine check

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 02:31:10PM +0530, Aravinda Prasad wrote: > > > On Monday 25 March 2019 12:03 PM, David Gibson wrote: > > On Fri, Mar 22, 2019 at 12:04:25PM +0530, Aravinda Prasad wrote: > >> Block VM migration requests until the machine check > >> error handling is complete as (i) these e

Re: [Qemu-devel] [PATCH v7 2/6] Wrapper function to wait on condition for the main loop mutex

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 01:06:08PM +0530, Aravinda Prasad wrote: > > > On Monday 25 March 2019 11:47 AM, David Gibson wrote: > > On Fri, Mar 22, 2019 at 12:03:49PM +0530, Aravinda Prasad wrote: > >> Introduce a wrapper function to wait on condition for > >> the main loop mutex. This function atom

Re: [Qemu-devel] [PATCH v3 04/15] spapr/xive: add state synchronization with KVM

2019-03-25 Thread David Gibson
On Fri, Mar 22, 2019 at 08:53:21AM +0100, Cédric Le Goater wrote: > On 3/22/19 2:00 AM, David Gibson wrote: > > On Thu, Mar 21, 2019 at 03:49:03PM +0100, Cédric Le Goater wrote: > >> This extends the KVM XIVE device backend with 'synchronize_state' > >> methods used to retrieve the state from KVM.

Re: [Qemu-devel] [PATCH v3 14/15] spapr/irq: initialize the IRQ device only once

2019-03-25 Thread David Gibson
On Fri, Mar 22, 2019 at 08:07:23AM +0100, Cédric Le Goater wrote: > On 3/22/19 3:15 AM, David Gibson wrote: > > On Thu, Mar 21, 2019 at 03:49:13PM +0100, Cédric Le Goater wrote: > >> Add a check to make sure that the routine initializing the emulated > >> IRQ device is called once. We don't have mu

Re: [Qemu-devel] [PATCH for-4.0 2/3] target/ppc: Enable "decrement and test CTR" version of bcctr

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 12:25:15PM +0100, Greg Kurz wrote: > On Mon, 25 Mar 2019 17:38:49 +1100 > David Gibson wrote: > > > On Fri, Mar 22, 2019 at 07:03:46PM +0100, Greg Kurz wrote: > > > Even if all ISAs up to v3 indeed mention: > > > > > > If the "decrement and test CTR" option is specifi

Re: [Qemu-devel] [PATCH for-4.0 2/3] target/ppc: Enable "decrement and test CTR" version of bcctr

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 12:25:15PM +0100, Greg Kurz wrote: > On Mon, 25 Mar 2019 17:38:49 +1100 > David Gibson wrote: > > > On Fri, Mar 22, 2019 at 07:03:46PM +0100, Greg Kurz wrote: > > > Even if all ISAs up to v3 indeed mention: > > > > > > If the "decrement and test CTR" option is specifi

[Qemu-devel] [PATCH for-4.0?] exec: Only count mapped memory backends for qemu_getrampagesize()

2019-03-25 Thread David Gibson
qemu_getrampagesize() works out the minimum host page size backing any of guest RAM. This is required in a few places, such as for POWER8 PAPR KVM guests, because limitations of the hardware virtualization mean the guest can't use pagesizes larger than the host pages backing its memory. However,

Re: [Qemu-devel] [PATCH for-4.0] gdbstub: fix vCont packet handling when no thread is specified

2019-03-25 Thread Richard Henderson
On 3/25/19 4:04 AM, Luc Michel wrote: > The vCont packet accepts a series of actions, each being applied on a > given thread ID. Giving no thread ID for an action is valid and means > "all threads". > > This commit fixes vCont packets being incorrectly rejected when no > thread ID was given for an

[Qemu-devel] [PATCH v6] hw/acpi: extract acpi_add_rom_blob()

2019-03-25 Thread Wei Yang
arm and i386 has almost the same function acpi_add_rom_blob(), except giving different FWCfgCallback function. This patch moves acpi_add_rom_blob() to utils.c by passing FWCfgCallback to it. Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov --- v6: * change author from Igor to Michael v5:

Re: [Qemu-devel] [PATCH v5] hw/acpi: extract acpi_add_rom_blob()

2019-03-25 Thread Wei Yang
On Mon, Mar 25, 2019 at 10:55:04AM +0100, Igor Mammedov wrote: >On Mon, 25 Mar 2019 13:59:10 +0800 >Wei Yang wrote: > >> arm and i386 has almost the same function acpi_add_rom_blob(), except >> giving different FWCfgCallback function. >> >> This patch moves acpi_add_rom_blob() to utils.c by passi

Re: [Qemu-devel] [PATCH v2 for-4.0] hardfloat: fix float32/64 fused multiply-add

2019-03-25 Thread Palmer Dabbelt
On Fri, 22 Mar 2019 13:43:20 PDT (-0700), c...@braap.org wrote: From: Kito Cheng Before falling back to softfloat FMA, we do not restore the original values of inputs A and C. Fix it. This bug was caught by running gcc's testsuite on RISC-V qemu. Note that this change gives a small perf incre

Re: [Qemu-devel] [PATCH v7 3/6] target/ppc: Handle NMI guest exit

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 01:31:12PM +0530, Aravinda Prasad wrote: > > > On Monday 25 March 2019 11:52 AM, David Gibson wrote: > > On Fri, Mar 22, 2019 at 12:03:58PM +0530, Aravinda Prasad wrote: > >> Memory error such as bit flips that cannot be corrected > >> by hardware are passed on to the kern

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 16/25] target/ppc: Style fixes for mmu-hash32.[ch]

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 09:45:11AM +0100, Greg Kurz wrote: > On Fri, 22 Mar 2019 11:15:35 +1100 > David Gibson wrote: > > > Signed-off-by: David Gibson > > --- > > target/ppc/mmu-hash32.c | 19 --- > > 1 file changed, 12 insertions(+), 7 deletions(-) > > > > diff --git a/target

Re: [Qemu-devel] [PULL 02/29] ppc/spapr: Receive and store device tree blob from SLOF

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 05:33:21PM +0100, Greg Kurz wrote: > On Mon, 25 Mar 2019 11:53:47 +1100 > David Gibson wrote: > > > On Sun, Mar 24, 2019 at 12:03:54AM -0400, Brad Smith wrote: > > > Now that I am checking out 4.0.0 rc's I see this diff is broken and > > > depends on a function libfdt does

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 21/25] target/ppc: Style fixes for translate.c

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 10:56:34AM +0100, Greg Kurz wrote: > On Fri, 22 Mar 2019 11:15:40 +1100 > David Gibson wrote: > > > Signed-off-by: David Gibson [snip] > > @@ -2916,10 +2955,11 @@ static void gen_stmw(DisasContext *ctx) > > /***Integer load and store strings

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 18/25] target/ppc: Style fixes for mmu_helper.c

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 10:31:39AM +0100, Greg Kurz wrote: > On Fri, 22 Mar 2019 11:15:37 +1100 > David Gibson wrote: > > > Signed-off-by: David Gibson > > --- > > target/ppc/mmu_helper.c | 131 > > 1 file changed, 80 insertions(+), 51 deletions(-) > >

Re: [Qemu-devel] [PATCH v7 4/6] target/ppc: Build rtas error log

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 01:56:50PM +0530, Aravinda Prasad wrote: > > > On Monday 25 March 2019 12:00 PM, David Gibson wrote: > > On Fri, Mar 22, 2019 at 12:04:07PM +0530, Aravinda Prasad wrote: > >> This patch builds the rtas error log, copies it to the > >> rtas_addr and then invokes the guest r

Re: [Qemu-devel] [PATCH v7 5/6] ppc: spapr: Enable FWNMI capability

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 02:27:45PM +0530, Aravinda Prasad wrote: > > > On Monday 25 March 2019 12:02 PM, David Gibson wrote: > > On Fri, Mar 22, 2019 at 12:04:16PM +0530, Aravinda Prasad wrote: > >> Enable the KVM capability KVM_CAP_PPC_FWNMI so that > >> the KVM causes guest exit with NMI as exi

Re: [Qemu-devel] [Qemu-ppc] [RFC for-4.1 17/25] target/ppc: Style fixes for mmu-hash64.[ch]

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 10:09:53AM +0100, Greg Kurz wrote: > On Fri, 22 Mar 2019 11:15:36 +1100 > David Gibson wrote: > > > Signed-off-by: David Gibson > > --- > > Maybe you can fold the following in this patch: Done, or something close enough at any rate. > > ---

Re: [Qemu-devel] [PATCH] device_tree: check device tree blob file size

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 04:04:33PM +0530, P J P wrote: > Hello David, > > +-- On Mon, 25 Mar 2019, David Gibson wrote --+ > | The only inherent limit to dtb size should be 2^31-1 bytes (the format > | uses signed 32-bit ints as offsets). > > ~2GB of dtb?! Seems quite big to specify the h/w th

Re: [Qemu-devel] [PATCH] Categorize devices

2019-03-25 Thread Corey Minyard
On Sun, Mar 24, 2019 at 07:05:23PM +0100, Ernest Esene wrote: > Categorize devices in "uncategorised devices" section > This patch is based on BiteSizedTask. > > Signed-off-by: Ernest Esene I'm not 100% sure the use of this field. A couple of comments on the IPMI one inline. > --- > hw/dma/i8

Re: [Qemu-devel] [PATCH v1] cpus: move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-03-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190326001535.19439-1-skrtbht...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash ti

Re: [Qemu-devel] [PATCH v1] cpus: move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-03-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190326001535.19439-1-skrtbht...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

[Qemu-devel] [PATCH v1] cpus: move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-03-25 Thread Sukrit Bhatnagar
Keep the calls made to synchronize cpu by all hypervisors in one place inside cpu_synchronize_* functions in include/sysemu/hw_accel.h Cc: Richard Henderson Cc: Paolo Bonzini Signed-off-by: Sukrit Bhatnagar --- cpus.c| 12 include/sysemu/hw_accel.h | 9 +++

[Qemu-devel] [PULL for-4.0 1/1] pc-bios: Update palcode-clipper

2019-03-25 Thread Richard Henderson
Report machine checks to the kernel. It is now using these for probing missing devices. Signed-off-by: Richard Henderson --- pc-bios/palcode-clipper | Bin 155968 -> 156328 bytes roms/qemu-palcode | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/palcode-clippe

[Qemu-devel] [PULL for-4.0 0/1] target/alpha: Update firmware image

2019-03-25 Thread Richard Henderson
Fixes for the current gentoo installer. r~ Richard Henderson (1): pc-bios: Update palcode-clipper pc-bios/palcode-clipper | Bin 155968 -> 156328 bytes roms/qemu-palcode | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) -- 2.17.1

Re: [Qemu-devel] About making QEMU to LIBs!

2019-03-25 Thread Paolo Bonzini
On 25/03/19 12:46, Yang Zhong wrote: > Hello all, > > Rust-VMM has started to make all features and common modules to crates, and > CSP can > deploy their VMM on demand. This afternoon, Xiao guangrong and i talked about > the light > weight VM solitions,and we thought QEMU can do same thing lik

Re: [Qemu-devel] [PATCH] RFC: build-sys: move slirp as git submodule project

2019-03-25 Thread Marc-André Lureau
Hi On Mon, Mar 25, 2019 at 7:58 PM Eric Blake wrote: > > On 3/25/19 1:50 PM, Eric Blake wrote: > > On 3/25/19 1:04 PM, Marc-André Lureau wrote: > >> The slirp project is now hosted on freedesktop at: > >> https://gitlab.freedesktop.org/slirp. > >> > >> The libslirp source tree there is based on c

Re: [Qemu-devel] [Qemu-block] [PATCH] block/vhdx: Use IEC binary prefixes from "qemu/units.h"

2019-03-25 Thread Philippe Mathieu-Daudé
Le lun. 25 mars 2019 21:53, John Snow a écrit : > > > On 3/21/19 5:40 AM, Stefano Garzarella wrote: > > IEC binary prefixes are defined in "qemu/units.h", so we > > can remove redundant definitions in "block/vhdx.h". > > > > Signed-off-by: Stefano Garzarella > > --- > > block/vhdx-log.c | 1 + >

Re: [Qemu-devel] [PATCH v2 0/7] target/mips: Add support for MSA instructions on a big endian host

2019-03-25 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: [PATCH v2 0/7] target/mips: Add support for MSA instructions on a > big endian host > > From: Mateja Marjanovic > > While working on adding support for big endian hosts on QEMU for the > MSA instructions copy_u, copy_s and insert, I noticed there was some >

Re: [Qemu-devel] [PATCH v2 1/7] target/mips: Fix . MSA instructions for MIPS big endian host

2019-03-25 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: [PATCH v2 1/7] target/mips: Fix . MSA instructions > for MIPS big endian host Please split this patch into one for load instructions and another for store instructions. I don't think the variable "big_endian" is needed, you should better resolve all differen

Re: [Qemu-devel] [PATCH v2 5/7] target/mips: Eliminate unreachable case for MSA instructions copy_u

2019-03-25 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Sent: Monday, March 25, 2019 3:52 PM > To: qemu-devel@nongnu.org > Cc: aurel...@aurel32.net; Aleksandar Markovic; Aleksandar Rikalo > Subject: [PATCH v2 5/7] target/mips: Eliminate unreachable case for MSA > instructions copy_u > > From: Mateja Marjanovic > > The co

Re: [Qemu-devel] [Qemu-block] [PATCH] block/vhdx: Use IEC binary prefixes from "qemu/units.h"

2019-03-25 Thread John Snow
On 3/21/19 5:40 AM, Stefano Garzarella wrote: > IEC binary prefixes are defined in "qemu/units.h", so we > can remove redundant definitions in "block/vhdx.h". > > Signed-off-by: Stefano Garzarella > --- > block/vhdx-log.c | 1 + > block/vhdx.c | 4 +++- > block/vhdx.h | 5 - > 3 f

Re: [Qemu-devel] [PATCH] target/arm: Set SIMDMISC and FPMISC for 32-bit -cpu max

2019-03-25 Thread Philippe Mathieu-Daudé
Le lun. 25 mars 2019 17:17, Richard Henderson a écrit : > Fixes: https://bugs.launchpad.net/bugs/1821430 > Signed-off-by: Richard Henderson > --- > target/arm/cpu.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index 96f0ff0ec7..d9b8658921 1

[Qemu-devel] [Bug 1805913] Re: readdir() returns NULL (errno=EOVERFLOW) for 32-bit user-static qemu on 64-bit host

2019-03-25 Thread diddly
I was also hit by this on Gentoo with a 64bit host running 32bit static chroot (arm). If it matters at all, I saw it after upgrading the 32bit arm chroot to glibc-2.28, while the host was still on 2.27. Downgrading again hides the issue. Upgrading the host to glibc 2.28, but keeping the chroot a

[Qemu-devel] [PATCH for-4.0 v2 1/2] nbd: Don't lose server's error to NBD_CMD_BLOCK_STATUS

2019-03-25 Thread Eric Blake
When the server replies with a (structured [*]) error to NBD_CMD_BLOCK_STATUS, without any extent information sent first, the client code was blindly throwing away the server's error code and instead telling the caller that EIO occurred. This has been broken since its introduction in 78a33ab5 (v2.

[Qemu-devel] [PATCH for-4.0 v2 0/2] nbd: simple errors to BLOCK_STATUS

2019-03-25 Thread Eric Blake
While resolving a qemu NBD client error reported by nbdkit, I found another client oddity by code inspection, in relation to what the protocol states about simple errors to NBD_CMD_BLOCK_STATUS vs. what our client enforced. It turns out that nbdkit didn't actually provoke this case, but since I wa

[Qemu-devel] [PATCH for-4.0 v2 2/2] nbd: Permit simple error to NBD_CMD_BLOCK_STATUS

2019-03-25 Thread Eric Blake
The NBD spec is clear that when structured replies are active, a simple error reply is acceptable to any command except for NBD_CMD_READ. However, we were mistakenly requiring structured errors for NBD_CMD_BLOCK_STATUS, and hanging up on a server that gave a simple error (since qemu does not behav

Re: [Qemu-devel] [PATCH] RFC: build-sys: move slirp as git submodule project

2019-03-25 Thread Eric Blake
On 3/25/19 1:50 PM, Eric Blake wrote: > On 3/25/19 1:04 PM, Marc-André Lureau wrote: >> The slirp project is now hosted on freedesktop at: >> https://gitlab.freedesktop.org/slirp. >> >> The libslirp source tree there is based on current qemu/slirp filtered >> through clang-format, and can thus be d

Re: [Qemu-devel] [PATCH] RFC: build-sys: move slirp as git submodule project

2019-03-25 Thread Eric Blake
On 3/25/19 1:04 PM, Marc-André Lureau wrote: > The slirp project is now hosted on freedesktop at: > https://gitlab.freedesktop.org/slirp. > > The libslirp source tree there is based on current qemu/slirp filtered > through clang-format, and can thus be directly used through a > git submodule. Ind

[Qemu-devel] [PULL 04/15] multifd: Drop x-multifd-page-count parameter

2019-03-25 Thread Juan Quintela
Libvirt don't want to expose (and explain it). From now on we measure the number of packages in bytes instead of pages, so it is the same independently of architecture. We choose the page size of x86. Notice that in the following patch we make this variable. Signed-off-by: Juan Quintela Reviewe

Re: [Qemu-devel] [PULL 0/7] Tracing patches

2019-03-25 Thread Peter Maydell
On Mon, 25 Mar 2019 at 15:59, Stefan Hajnoczi wrote: > > The following changes since commit d97a39d903fe33c45be83ac6943a2f82a3649a11: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2019-03-22 09:37:38 +) > > are available in the Git repository

[Qemu-devel] [PULL 02/15] multifd: Rename "size" member to pages_alloc

2019-03-25 Thread Juan Quintela
It really indicates what is the number of allocated pages for one packet. Once there rename "used" to "pages_used". Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- migration/ram.c | 23 --- 1 file changed, 12 insertions(+),

[Qemu-devel] [PULL 00/15] Migration patches

2019-03-25 Thread Juan Quintela
The following changes since commit 50ccc488b0d4c3b8e2790c18bcd7329fc609a1c6: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190325' into staging (2019-03-25 15:58:49 +) are available in the Git repository at: https://github.com/juanquintela/qem

[Qemu-devel] [PULL 05/15] multifd: Be flexible about packet size

2019-03-25 Thread Juan Quintela
This way we can change the packet size in the future and everything will work. We choose an arbitrary big number (100 times configured size) as a limit about how big we will reallocate. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- migration

[Qemu-devel] [PULL 06/15] multifd: Change default packet size

2019-03-25 Thread Juan Quintela
We moved from 64KB to 512KB, as it makes less locking contention without any downside in testing. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.

[Qemu-devel] [PULL 11/15] Migration/colo.c: Fix COLO failover status error

2019-03-25 Thread Juan Quintela
From: Zhang Chen When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED. The origin codes misunderstand the FAILOVER_STATUS_REQUIRE. Signed-off-by: Zhang Chen Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/colo.c | 7 +

[Qemu-devel] [PULL 09/15] migration: add support for a "tls-authz" migration parameter

2019-03-25 Thread Juan Quintela
From: "Daniel P. Berrange" The QEMU instance that runs as the server for the migration data transport (ie the target QEMU) needs to be able to configure access control so it can prevent unauthorized clients initiating an incoming migration. This adds a new 'tls-authz' migration parameter that is

[Qemu-devel] [PULL 08/15] multifd: Drop x-

2019-03-25 Thread Juan Quintela
We make it supported from now on. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela --- hmp.c | 10 +- migration/migration.c | 26 +- qapi/migration.json | 34 +- 3 f

[Qemu-devel] [PULL 12/15] Migration/colo.c: Add new COLOExitReason to handle all failover state

2019-03-25 Thread Juan Quintela
From: Zhang Chen In this patch we add the processing state for COLOExitReason, because we have to identify COLO in the failover processing state or failover error state. In the way, we can handle all the failover state. We have improved the description of the COLOExitReason by the way. Signed-of

[Qemu-devel] [PULL 01/15] multifd: Only send pages when packet are not empty

2019-03-25 Thread Juan Quintela
We send packages without pages sometimes for sysnchronizanion. The iov functions do the right thing, but we will be changing this code in future patches. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- migration/ram.c | 18 --

[Qemu-devel] [PULL 13/15] Migration/colo.c: Add the necessary checks for colo_do_failover

2019-03-25 Thread Juan Quintela
From: Zhang Chen Signed-off-by: Zhang Chen Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/colo.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/migration/colo.c b/migration/colo.c index dbe2b88807..d1a

[Qemu-devel] [PULL 10/15] migration/rdma: Check qemu_rdma_init_one_block

2019-03-25 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Actually it can't fail at the moment, but Coverity moans that it's the only place it's not checked, and it's an easy check. Reported-by: Coverity (CID 1399413) Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- mig

[Qemu-devel] [PULL 14/15] Migration/colo.c: Make user obtain the last COLO mode info after failover

2019-03-25 Thread Juan Quintela
From: Zhang Chen Add the last_colo_mode to save the status after failover. This patch can solve the issue that user want to get last colo mode use query_colo_status after failover. Signed-off-by: Zhang Chen Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/colo.c| 16

[Qemu-devel] [PULL 03/15] multifd: Create new next_packet_size field

2019-03-25 Thread Juan Quintela
We need to send this field when we add compression support. As we are still on x- stage, we can do this kind of changes. Signed-off-by: Juan Quintela --- migration/ram.c| 15 +-- migration/trace-events | 4 ++-- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL 07/15] multifd: Add some padding

2019-03-25 Thread Juan Quintela
Add some padding. MultifdInit_t is padded to 64 bytes. MultiFDPacket_t is padded to 320bytes (64 * 5). Signed-off-by: Juan Quintela --- migration/ram.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 700c345ec5..d7f8fe45a8 100644 --- a/migration/ram

[Qemu-devel] [PULL 15/15] migration/postcopy: Update the bandwidth during postcopy

2019-03-25 Thread Juan Quintela
From: "Dr. David Alan Gilbert" The recently added max-postcopy-bandwidth parameter is only read at the transition from precopy->postcopy where as the older max-bandwidth parameter updates the migration bandwidth when changed even if the migration is already running. Fix this discrepency so that:

Re: [Qemu-devel] [PATCH 31/35] cpu: Move icount_decr to CPUNegativeOffsetState

2019-03-25 Thread Richard Henderson
On 3/25/19 10:23 AM, Paolo Bonzini wrote: >> RFC: I had problems with the build system moving qom/cpu.c >> from common-obj-y to obj-y. Then I tried just splitting out >> a piece of it, and ran into odder build system issues. Then >> I hacked Makefile.target in a way that doesn't look right, >> bu

Re: [Qemu-devel] [PATCH 31/35] cpu: Move icount_decr to CPUNegativeOffsetState

2019-03-25 Thread Paolo Bonzini
On 23/03/19 20:09, Richard Henderson wrote: > Amusingly, we had already ignored the comment to keep this > value at the end of CPUState. This restores the minimum > negative offset from TCG_AREG0 for code generation. > > This is slightly complicated for qom/cpu.c and tcg-all.c, > in that they are

Re: [Qemu-devel] [PATCH for-4.0] nbd: Permit simple error to NBD_CMD_BLOCK_STATUS

2019-03-25 Thread Eric Blake
On 3/25/19 11:21 AM, Eric Blake wrote: > -if (!extent->length && !iter.err) { > -error_setg(&iter.err, > - "Server did not reply with any status extents"); > +if (!extent->length && !iter.request_ret) { Hmm, I don't see, what is changed.

Re: [Qemu-devel] [PULL 0/6] target-arm queue

2019-03-25 Thread Peter Maydell
rp-pull-request' into > staging (2019-03-25 07:59:40 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20190325 > > for you to fetch changes up to f2b2f53f6429b5abd7cd86bd65747f5f13e195eb: &

Re: [Qemu-devel] [PATCH V2] RISC-V: fix single stepping over ret and other branching instructions

2019-03-25 Thread Richard Henderson
On 3/25/19 4:45 AM, Fabien Chouteau wrote: > This patch introduces wrappers around the tcg_gen_exit_tb() and > tcg_gen_lookup_and_goto_ptr() functions that handle single stepping, > i.e. call gen_exception_debug() when single stepping is enabled. > > Theses functions are then used instead of the o

Re: [Qemu-devel] [PATCH for-4.0] nbd: Permit simple error to NBD_CMD_BLOCK_STATUS

2019-03-25 Thread Eric Blake
On 3/25/19 11:05 AM, Eric Blake wrote: > More to the point, the behavior of qemu for a (structured) error reply > to NBD_CMD_BLOCK_STATUS with no extent->length was to keep the > connection alive (both before and after commit 7f86068d) - the > difference in behavior for this hunk of the patch is o

Re: [Qemu-devel] [PATCH for-4.0] nbd: Permit simple error to NBD_CMD_BLOCK_STATUS

2019-03-25 Thread Eric Blake
On 3/25/19 11:21 AM, Eric Blake wrote: > When you fix the first bug (the client setting iter.err on a simple > error reply from the server because the server's reply wasn't > structured, to now the client setting just iter.request_ret because it > successfully parsed an error out of the server's r

Re: [Qemu-devel] [PATCH] i2c-ddc: move it to hw/display

2019-03-25 Thread Philippe Mathieu-Daudé
Le lun. 25 mars 2019 17:33, Paolo Bonzini a écrit : > Move it together with the other EDID code. hw/i2c should only > include the core and the adapters, not the slaves. > > Signed-off-by: Paolo Bonzini > --- > hw/display/Kconfig| 5 + > hw/display/Makefile.objs

Re: [Qemu-devel] [qemu-s390x] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-25 Thread Halil Pasic
On Sun, 24 Mar 2019 09:09:05 +0200 Marcel Apfelbaum wrote: > Appreciated. Let me know if you prefer me to send a V2 using the cast. Yes, I would prefer a V2 using the cast. I think Connie should be back next week, and can then pick your patch. > > Thanks for looking into it, Thank you! Regar

Re: [Qemu-devel] [PATCH for-4.0] nbd: Permit simple error to NBD_CMD_BLOCK_STATUS

2019-03-25 Thread Eric Blake
On 3/25/19 11:04 AM, Vladimir Sementsov-Ogievskiy wrote: +++ b/block/nbd-client.c @@ -718,9 +718,7 @@ static int nbd_co_receive_blockstatus_reply(NBDClientSession *s, bool received = false; assert(!extent->length); -NBD_FOREACH_REPLY_CHUNK(s, i

Re: [Qemu-devel] [PATCH] device_tree: check device tree blob file size

2019-03-25 Thread Peter Maydell
On Mon, 25 Mar 2019 at 16:11, P J P wrote: > > +-- On Mon, 25 Mar 2019, Peter Maydell wrote --+ > | Noone has complained that it's too small because right now *we do not check > | against it* for the common case of "just load an external dtb". > | > | We should not be imposing an arbitrary limit w

Re: [Qemu-devel] [PULL 02/29] ppc/spapr: Receive and store device tree blob from SLOF

2019-03-25 Thread Greg Kurz
On Mon, 25 Mar 2019 11:53:47 +1100 David Gibson wrote: > On Sun, Mar 24, 2019 at 12:03:54AM -0400, Brad Smith wrote: > > Now that I am checking out 4.0.0 rc's I see this diff is broken and > > depends on a function libfdt does not expose. The breakage is > > hidden by the fallback check in the co

Re: [Qemu-devel] [PULL 0/9 for 4.0] fpu and testing fixes

2019-03-25 Thread Peter Maydell
On Mon, 25 Mar 2019 at 13:20, Alex Bennée wrote: > > The following changes since commit d97a39d903fe33c45be83ac6943a2f82a3649a11: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' > into staging (2019-03-22 09:37:38 +) > > are available in the Git repository at:

[Qemu-devel] [PATCH] i2c-ddc: move it to hw/display

2019-03-25 Thread Paolo Bonzini
Move it together with the other EDID code. hw/i2c should only include the core and the adapters, not the slaves. Signed-off-by: Paolo Bonzini --- hw/display/Kconfig| 5 + hw/display/Makefile.objs | 1 + hw/{i2c => display}/i2c-ddc.c | 2 +- hw/displa

[Qemu-devel] [PULL 2/7] trace: avoid SystemTap dtrace(1) warnings on empty files

2019-03-25 Thread Stefan Hajnoczi
target/hppa/trace-events only contains disabled events, resulting in a trace-dtrace.dtrace file that says "provider qemu {}". SystemTap's dtrace(1) tool prints a warning when processing this input file. This patch avoids the error by emitting an empty file instead of "provider qemu {}" when there

[Qemu-devel] [PULL 0/7] Tracing patches

2019-03-25 Thread Stefan Hajnoczi
The following changes since commit d97a39d903fe33c45be83ac6943a2f82a3649a11: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2019-03-22 09:37:38 +) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-reque

[Qemu-devel] [PULL 7/7] trace-events: Fix attribution of trace points to source

2019-03-25 Thread Stefan Hajnoczi
From: Markus Armbruster Some trace points are attributed to the wrong source file. Happens when we neglect to update trace-events for code motion, or add events in the wrong place, or misspell the file name. Clean up with help of cleanup-trace-events.pl. Same funnies as in the previous commit,

[Qemu-devel] [PULL 5/7] scripts/cleanup-trace-events: Update for current practice

2019-03-25 Thread Stefan Hajnoczi
From: Markus Armbruster Emit comments with shortened file names (previous commit). Limit search to the input file's directory. Cope with properties tcg (commit b2b36c22bd8) and vcpu (commit 3d211d9f4db). Cope with capital letters in function names. Signed-off-by: Markus Armbruster Message-id

[Qemu-devel] [PULL 6/7] trace-events: Delete unused trace points

2019-03-25 Thread Stefan Hajnoczi
From: Markus Armbruster Tracked down with cleanup-trace-events.pl. Funnies requiring manual post-processing: * block.c and blockdev.c trace points are in block/trace-events. * hw/block/nvme.c uses the preprocessor to hide its trace point use from cleanup-trace-events.pl. * include/hw/xen/xe

[Qemu-devel] [PULL 1/7] trace: handle tracefs path truncation

2019-03-25 Thread Stefan Hajnoczi
If the tracefs mountpoint has a very long path we may exceed PATH_MAX. This is a system misconfiguration and the user must resolve it so that applications can perform path-based system calls successfully. This issue does not occur on real-world systems since tracefs is mounted on /sys/kernel/debug

Re: [Qemu-devel] [PATCH for-4.0] nbd: Permit simple error to NBD_CMD_BLOCK_STATUS

2019-03-25 Thread Vladimir Sementsov-Ogievskiy
25.03.2019 17:44, Eric Blake wrote: > On 3/25/19 5:12 AM, Vladimir Sementsov-Ogievskiy wrote: >> 23.03.2019 17:24, Eric Blake wrote: >>> The NBD spec is clear that when structured replies are active, a >>> simple error reply is acceptable to any command except for >>> NBD_CMD_READ. However, we wer

Re: [Qemu-devel] [PATCH] qcow2: avoid lseek on block_status if possible

2019-03-25 Thread Vladimir Sementsov-Ogievskiy
25.03.2019 17:56, Kevin Wolf wrote: > Am 25.01.2019 um 15:36 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 25.01.2019 17:21, Vladimir Sementsov-Ogievskiy wrote: >>> Results on tmpfs: >>> cached is lseek cache by Kevin >>> detect is this patch >>> no lseek is just remove block_status query on bs-

[Qemu-devel] [PULL 3/7] trace-events: Consistently point to docs/devel/tracing.txt

2019-03-25 Thread Stefan Hajnoczi
From: Markus Armbruster Almost all trace-events point to docs/devel/tracing.txt in a comment right at the beginning. Touch up the ones that don't. [Updated with Markus' new commit description wording. --Stefan] Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Message-id:

Re: [Qemu-devel] [PATCH for-4.0] nbd: Permit simple error to NBD_CMD_BLOCK_STATUS

2019-03-25 Thread Eric Blake
On 3/25/19 9:44 AM, Eric Blake wrote: >>> >>> @@ -758,9 +756,11 @@ static int >>> nbd_co_receive_blockstatus_reply(NBDClientSession *s, >>> payload = NULL; >>> } >>> >>> -if (!extent->length && !iter.err) { >>> -error_setg(&iter.err, >>> - "Server did

Re: [Qemu-devel] [PATCH] device_tree: check device tree blob file size

2019-03-25 Thread P J P
+-- On Mon, 25 Mar 2019, Peter Maydell wrote --+ | Noone has complained that it's too small because right now *we do not check | against it* for the common case of "just load an external dtb". | | We should not be imposing an arbitrary limit within QEMU if we don't need | to. Here, we do not nee

[Qemu-devel] [PATCH] target/arm: Set SIMDMISC and FPMISC for 32-bit -cpu max

2019-03-25 Thread Richard Henderson
Fixes: https://bugs.launchpad.net/bugs/1821430 Signed-off-by: Richard Henderson --- target/arm/cpu.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 96f0ff0ec7..d9b8658921 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -2025,6 +2025,11 @

Re: [Qemu-devel] [PATCH] seccomp: report more useful errors from seccomp

2019-03-25 Thread Daniel P . Berrangé
On Mon, Mar 25, 2019 at 04:25:19PM +0100, Marc-André Lureau wrote: > Hi > > On Mon, Mar 25, 2019 at 3:07 PM Daniel P. Berrangé > wrote: > > > > Most of the seccomp functions return errnos as a negative return > > value. The code is currently ignoring these and reporting a generic > > error messa

  1   2   3   >