Re: [Qemu-devel] [Qemu-ppc] [PATCH for-4.1] hw: add compat machines for 4.1

2019-04-11 Thread David Gibson
On Thu, Apr 11, 2019 at 09:24:05PM +0200, Greg Kurz wrote: > On Thu, 11 Apr 2019 12:20:25 +0200 > Cornelia Huck wrote: > > > Add 4.1 machine types for arm/i440fx/q35/s390x/spapr. > > > > Signed-off-by: Cornelia Huck > > --- > > > > For spapr part: > > Acked-by: Greg Kurz and Acked-by: Dav

Re: [Qemu-devel] [PATCH 1/6] target/ppc: Don't check UPRT in radix mode when in HV real mode

2019-04-11 Thread David Gibson
On Thu, Apr 11, 2019 at 09:59:59AM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > It appears that during kexec, we run for a while in hypervisor > real mode with LPCR:HR set and LPCR:UPRT clear, which trips > the assertion in ppc_radix64_handle_mmu_fault(). > > First this shou

Re: [Qemu-devel] [PATCH 2/6] ppc/spapr: Use proper HPTE accessors for H_READ

2019-04-11 Thread David Gibson
On Thu, Apr 11, 2019 at 10:00:00AM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Cédric Le Goater Applied, thanks. > --- > hw/ppc/spapr_hcall.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > >

Re: [Qemu-devel] [PATCH 3/6] ppc/hash64: Rework R and C bit updates

2019-04-11 Thread David Gibson
On Thu, Apr 11, 2019 at 10:00:01AM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > With MT-TCG, we are now running translation in a racy way, thus > we need to mimic hardware when it comes to updating the R and > C bits, by doing byte stores. > > The current "store_hpte" abstra

Re: [Qemu-devel] [PATCH 4/6] ppc/hash32: Rework R and C bit updates

2019-04-11 Thread David Gibson
On Thu, Apr 11, 2019 at 10:00:02AM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > With MT-TCG, we are now running translation in a racy way, thus > we need to mimic hardware when it comes to updating the R and > C bits, by doing byte stores. > > Signed-off-by: Benjamin Herrens

Re: [Qemu-devel] [PATCH] spapr: add splpar hcalls H_JOIN, H_PROD, H_CONFER

2019-04-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190412054214.707-1-npig...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190412054214.707-1-npig...@gmail.com Subject: [Qemu-devel] [PATCH] spapr: add splpar hcalls H_JOIN, H_PRO

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-04-11 Thread Wei Yang
On Tue, Apr 09, 2019 at 04:54:15PM +0200, Igor Mammedov wrote: >> >> Let's see a normal hotplug case first. >> >> I did one test to see the how a guest with hot-plug cpu migrate to >> destination. It looks the migration fails if I just do hot-plug at >> source. So I have to do hot-p

[Qemu-devel] [PATCH] spapr: add splpar hcalls H_JOIN, H_PROD, H_CONFER

2019-04-11 Thread Nicholas Piggin
These implementations have a few deficiencies that are noted, but are good enough for Linux to use. Signed-off-by: Nicholas Piggin --- This has been tested with TCG with some Linux hacks to use H_JOIN/H_PROD for suspend and CPU unplug (plus an implementation of ibm,suspend-me to do the suspend).

[Qemu-devel] [PATCH v2 1/2] hw: timer: Add ASPEED RTC device

2019-04-11 Thread Joel Stanley
Signed-off-by: Joel Stanley Signed-off-by: Cédric Le Goater --- v2: Use g_assert_not_reached Add vmstate Add reset callback Annotate fall through cases hw/timer/Makefile.objs| 2 +- hw/timer/aspeed_rtc.c | 180 ++ hw/timer/trace-events

Re: [Qemu-devel] [PATCH 2/3] aspeed: add a per SoC mapping for the memory space

2019-04-11 Thread Cédric Le Goater
On 4/12/19 5:24 AM, Andrew Jeffery wrote: > > > On Fri, 12 Apr 2019, at 11:48, Joel Stanley wrote: >> On Thu, 11 Apr 2019 at 16:10, Cédric Le Goater wrote: >>> >>> This will simplify the definition of new SoCs, like the AST2600 which >>> should use a slightly different address space and have a d

Re: [Qemu-devel] [PATCH] ppc/spapr: Add H_PROD and H_CONFER

2019-04-11 Thread Cédric Le Goater
On 4/12/19 5:28 AM, Nicholas Piggin wrote: > Cédric Le Goater's on April 11, 2019 4:34 pm: >> From: Benjamin Herrenschmidt >> >> H_PROD should be fully functional, H_CEDE is modified to >> ignore a proded CPU. H_CONFER is a stub to avoid returning >> an error. > > Huh, I just implemented these a

[Qemu-devel] [PATCH v2 0/2] arm: aspeed: Add RTC Model

2019-04-11 Thread Joel Stanley
v2: Minor fixes, added vmstate and reset, and rebased on Cédric's series Based-on: 20190411161013.4514-4-...@kaod.org [PATCH 3/3] aspeed: use sysbus_init_child_obj() to initialize children A model for the ASPEED BMC real time clock (RTC). The model is sufficient for running the guest Linux kernel

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] Header cleanups

2019-04-11 Thread Aruna Jayasena
Thanks! On Fri, Apr 12, 2019 at 1:50 AM, Laurent Vivier wrote: > On 10/04/2019 07:17, Markus Armbruster wrote: > > Peter Maydell writes: > > > >> On Tue, 9 Apr 2019 at 17:42, Aruna Jayasena > wrote: > >>> > >>> Yeah this is a stand alone patch. > >> > >> OK, thanks -- just wanted to check ther

Re: [Qemu-devel] [PATCH] ppc/spapr: Add H_PROD and H_CONFER

2019-04-11 Thread Nicholas Piggin
Cédric Le Goater's on April 11, 2019 4:34 pm: > From: Benjamin Herrenschmidt > > H_PROD should be fully functional, H_CEDE is modified to > ignore a proded CPU. H_CONFER is a stub to avoid returning > an error. Huh, I just implemented these a couple of days ago to test pseries suspend, also H_JO

Re: [Qemu-devel] [PATCH 2/3] aspeed: add a per SoC mapping for the memory space

2019-04-11 Thread Andrew Jeffery
On Fri, 12 Apr 2019, at 11:48, Joel Stanley wrote: > On Thu, 11 Apr 2019 at 16:10, Cédric Le Goater wrote: > > > > This will simplify the definition of new SoCs, like the AST2600 which > > should use a slightly different address space and have a different set > > of controllers. > > > > Signed-

Re: [Qemu-devel] [PATCH 1/2] hw: timer: Add ASPEED RTC device

2019-04-11 Thread Joel Stanley
Thanks for the review Peter and Cedric. On Thu, 11 Apr 2019 at 15:30, Cédric Le Goater wrote: > > On 4/11/19 5:25 PM, Peter Maydell wrote: > >> + > >> +#define COUNTER1(0x00 / 4) > >> +#define COUNTER2(0x04 / 4) > >> +#define ALARM (0x08 / 4) > >> +#define CONTROL

Re: [Qemu-devel] [PATCH 3/3] aspeed: use sysbus_init_child_obj() to initialize children

2019-04-11 Thread Andrew Jeffery
On Fri, 12 Apr 2019, at 01:40, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater Reviewed-by: Andrew Jeffery > --- > hw/arm/aspeed_soc.c | 50 ++--- > 1 file changed, 20 insertions(+), 30 deletions(-) > > diff --git a/hw/arm/aspeed_soc.c b/hw

Re: [Qemu-devel] [PATCH 1/3] aspeed: add a per SoC mapping for the interrupt space

2019-04-11 Thread Andrew Jeffery
On Fri, 12 Apr 2019, at 02:13, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > On 4/11/19 6:10 PM, Cédric Le Goater wrote: > > This will simplify the definition of new SoCs, like the AST2600 which > > should use a different CPU and a different IRQ number layout. > > > > Signed-off-by: Cédric Le

Re: [Qemu-devel] [PATCH for-4.0] spapr_pci: Fix broken naming of PCI bus

2019-04-11 Thread David Gibson
On Thu, Apr 11, 2019 at 06:32:24PM +0200, Greg Kurz wrote: > Recent commit 5cf0d326a0fe fixed a regression which was preventing the > guest to access the extended config space of a PCIe device. This was > done by introducing a new PCI bus subtype for PAPR. The original fix > was causing PCI busses

Re: [Qemu-devel] [PATCH 2/3] aspeed: add a per SoC mapping for the memory space

2019-04-11 Thread Joel Stanley
On Thu, 11 Apr 2019 at 16:10, Cédric Le Goater wrote: > > This will simplify the definition of new SoCs, like the AST2600 which > should use a slightly different address space and have a different set > of controllers. > > Signed-off-by: Cédric Le Goater > diff --git a/hw/arm/aspeed_soc.c b/hw/a

Re: [Qemu-devel] [PATCH 3/3] aspeed: use sysbus_init_child_obj() to initialize children

2019-04-11 Thread Joel Stanley
On Thu, 11 Apr 2019 at 16:10, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley

Re: [Qemu-devel] [PATCH 1/3] aspeed: add a per SoC mapping for the interrupt space

2019-04-11 Thread Joel Stanley
On Thu, 11 Apr 2019 at 16:10, Cédric Le Goater wrote: > > This will simplify the definition of new SoCs, like the AST2600 which > should use a different CPU and a different IRQ number layout. > > Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley

Re: [Qemu-devel] [RISU v2] i386: Add avx512 state to reginfo_t

2019-04-11 Thread Jan Bobek
Looks fine to me. I suppose if I had written it, I would have included more comments and/or #define's to make some bits more obvious (all the magic constants look a bit scary until you read the Intel manual), but nevermind that. I guess the other remaining part now is extending risugen to actually

Re: [Qemu-devel] Question: can we hot plug a PCIe switch on machine "virt"

2019-04-11 Thread Heyi Guo
Hi Eric and Michael, Appreciate your sharing of this information. But sorry I'm still a little confused due to my poor English... On 2019/4/11 20:19, Auger Eric wrote: Hi Heyi, On 4/11/19 1:30 PM, Heyi Guo wrote: Hi Eric, Could you help to confirm? Practically I have not tried anything el

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

2019-04-11 Thread Xiang Zheng
On 2019/4/11 20:22, Kevin Wolf wrote: > Okay, so your problem is that blk_pread() writes to the whole buffer, > writing explicit zeroes for unallocated parts of the image, while you > would like to leave those parts of the buffer untouched so that we don't > actually allocate the memory, but can ju

Re: [Qemu-devel] [RISU PATCH 0/5] Fix RISU build for i386

2019-04-11 Thread Jan Bobek
Sorry for the delayed reply, the U.S. tax deadline has caught up with me, so I spent the last two evenings doing my taxes. (Yuck!) Anyway... On 4/8/19 6:18 PM, Richard Henderson wrote: > On 4/8/19 8:27 AM, Jan Bobek wrote: >> 2. Note the '-std=c99' switch in the command-line above; without it, >>

[Qemu-devel] [PATCH v2] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities'

2019-04-11 Thread Singh, Brijesh
There are limited numbers of the SEV guests that can be run concurrently. A management applications may need to know this limit so that it can place SEV VMs on hosts which have suitable resources available. Currently, this limit is not exposed to the application. Add a new 'sev-max-guest' field in

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-11 Thread Wei Yang
On Tue, Apr 09, 2019 at 05:00:37PM +0200, Igor Mammedov wrote: >Dummy table (with signature "QEMU") creation came from original SeaBIOS >codebase. And QEMU would have to keep it around if there were Q35 machine >that depended on keeping ACPI tables blob constant size. Luckily there >were no version

Re: [Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-11 Thread Wei Yang
On Thu, Apr 11, 2019 at 01:46:27PM +0200, Igor Mammedov wrote: >On Thu, 11 Apr 2019 09:32:11 +0800 >Wei Yang wrote: > [...] >> To be honest, this is what I feel confused in your previous reply. >> >> First I want to confirm both fields in RAMBlock affects the migration: >> >> * used_length >>

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-04-11 Thread Dan Streetman
test builds in https://launchpad.net/~ddstreet/+archive/ubuntu/lp1823458 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1823458 Title: race condition between vhost_net_stop and CHR_EVENT_CLOSED on s

Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-11 Thread Eric Farman
On 4/10/19 10:59 PM, Eric Farman wrote: On 4/9/19 7:34 PM, Halil Pasic wrote: On Mon, 8 Apr 2019 19:07:47 +0200 ...snip... I'm just running fio on a pass-through DASD and on some virto-blk disks in parallel. My QEMU is today's vfio-ccw-caps from your repo. I see stuff like this: qemu-g

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-04-11 Thread Dan Streetman
** Description changed: [impact] on shutdown of a guest, there is a race condition that results in qemu crashing instead of normally shutting down. The bt looks similar to this (depending on the specific version of qemu, of course; this is taken from 2.5 version of qemu): (gdb)

[Qemu-devel] [Bug 1823790] Re: QEMU mishandling of SO_PEERSEC forces systemd into tight loop

2019-04-11 Thread Matthias Lüscher
I have just studied a bit the systemd code and this brought me to the following idea/temporary workaround: What about returning -1 (error) and setting errno when getsockopt(fd, SOL_SOCKET, SO_PEERSEC, ...) gets called? This would then let systemd know that SO_PEERSEC is not (yet) implemented. --

[Qemu-devel] [Bug 1823790] Re: QEMU mishandling of SO_PEERSEC forces systemd into tight loop

2019-04-11 Thread Matthias Lüscher
This is probably the tight loop that gets triggered: https://github.com/systemd/systemd/commit/217d89678269334f461e9abeeffed57077b21454 It looks like the previous implementation was just a bit more "tolerant". -- You received this bug notification because you are a member of qemu- devel-ml, whic

Re: [Qemu-devel] [PATCH for 4.1 v3 2/6] target/riscv: Fall back to generating a RISC-V CPU

2019-04-11 Thread Alistair Francis
On Thu, Apr 11, 2019 at 5:18 AM Igor Mammedov wrote: > > On Wed, 10 Apr 2019 23:10:25 + > Alistair Francis wrote: > > > If a user specifies a CPU that we don't understand then we want to fall > > back to a CPU generated from the ISA string. > It might look like a nice thing to do at the begin

Re: [Qemu-devel] [PATCH for 4.1 v3 6/6] riscv: Add a generic spike machine

2019-04-11 Thread Alistair Francis
On Thu, Apr 11, 2019 at 5:18 AM Peter Maydell wrote: > > On Thu, 11 Apr 2019 at 13:07, Igor Mammedov wrote: > > > > On Wed, 10 Apr 2019 23:11:00 + > > Alistair Francis wrote: > > > +/* register system main memory (actual RAM) */ > > > +memory_region_init_ram(main_mem, NULL, "riscv.sp

Re: [Qemu-devel] [PATCH for 4.1 v3 6/6] riscv: Add a generic spike machine

2019-04-11 Thread Alistair Francis
On Thu, Apr 11, 2019 at 5:06 AM Igor Mammedov wrote: > > On Wed, 10 Apr 2019 23:11:00 + > Alistair Francis wrote: > > > Add a generic spike machine (not tied to a version) and deprecate the > > spike mahines that are tied to a specific version. As we can now specify > > the CPU via the comman

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] Header cleanups

2019-04-11 Thread Laurent Vivier
On 10/04/2019 07:17, Markus Armbruster wrote: > Peter Maydell writes: > >> On Tue, 9 Apr 2019 at 17:42, Aruna Jayasena wrote: >>> >>> Yeah this is a stand alone patch. >> >> OK, thanks -- just wanted to check there wasn't a missing >> bit. I think this could go in via the qemu-trivial tree >> so

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Update configure

2019-04-11 Thread Laurent Vivier
On 09/04/2019 07:33, Stefan Weil wrote: > The last *.aml file was removed in commit > 13b1881aacc7e5018773bd545bbaf8d5476699ee. > > Signed-off-by: Stefan Weil > --- > configure | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configure b/configure > index 1c563a7027..9c5d9a8c96 100755 >

Re: [Qemu-devel] [PATCH v3 2/4] target/mips: add or remove space to fix checkpatch errors

2019-04-11 Thread Aleksandar Markovic
> From: Jules Irenge > Subject: [PATCH v3 2/4] target/mips: add or remove space to fix checkpatch > errors > > Add or remove space to fix errors issued by checkpatch.pl tool > "ERROR: spaces required around ..." > "ERROR: space required after that" > "ERROR: space required before the open parenth

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qom: use object_new_with_type in object_new_with_propv

2019-04-11 Thread Laurent Vivier
On 02/04/2019 08:27, Markus Armbruster wrote: > Stefano Garzarella writes: > >> On Mon, Mar 11, 2019 at 04:32:34PM +0800, Wei Yang wrote: >>> Function object_new_with_propv already get the Type of the object, so we >>> could leverage object_new_with_type here. >>> >>> [make check test pass] >>> >

Re: [Qemu-devel] [PATCH 1/2] pflash_cfi01: New pflash_cfi01_legacy_drive()

2019-04-11 Thread Laszlo Ersek
On 04/11/19 21:50, Laszlo Ersek wrote: > On 04/11/19 21:35, Laszlo Ersek wrote: >> On 04/11/19 15:56, Markus Armbruster wrote: >>> Factored out of pc_system_firmware_init() so the next commit can reuse >>> it in hw/arm/virt.c. >>> >>> Signed-off-by: Markus Armbruster >>> --- >>> hw/block/pflash_c

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: fix pam test warning

2019-04-11 Thread Laurent Vivier
On 04/04/2019 11:19, Daniel P. Berrangé wrote: > CC trivial > > On Thu, Apr 04, 2019 at 10:17:25AM +0100, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> The pam test generates a warning on Fedora 29 with -O3 compilation >> because the headers declare that the pam_conv

Re: [Qemu-devel] [PATCH RFC 2/3] pxtool: Add new qemu-img command info generation tool

2019-04-11 Thread John Snow
On 4/11/19 2:22 AM, Markus Armbruster wrote: > John Snow writes: > >> On 4/10/19 1:54 AM, Markus Armbruster wrote: >>> John Snow writes: >>> Presently we use hxtool and a .hx format to generate a few things like the qemu_img subcommand dispatch table, the qemu_img help() display out

Re: [Qemu-devel] [Qemu-trivial] [PATCH] doc: fix the configuration path

2019-04-11 Thread Laurent Vivier
On 30/03/2019 17:30, Thomas Huth wrote: > On 07/02/2019 17.31, Philippe Mathieu-Daudé wrote: >> On 11/26/18 11:51 AM, Marc-André Lureau wrote: >>> Use a CONFDIR variable to show the configured sysconf path in the >>> generated documentations (html, man pages etc). >>> >>> Related to: >>> https://bu

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 1/2] block/vhdx: Remove redundant IEC binary prefixes definition

2019-04-11 Thread Laurent Vivier
On 11/04/2019 21:54, Laurent Vivier wrote: > On 27/03/2019 10:56, Stefano Garzarella wrote: >> IEC binary prefixes are already defined in "qemu/units.h", >> so we can remove redundant definitions in "block/vhdx.h". >> >> Signed-off-by: Stefano Garzarella >> --- >> block/vhdx.c | 3 ++- >> block/v

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 1/2] block/vhdx: Remove redundant IEC binary prefixes definition

2019-04-11 Thread Laurent Vivier
On 27/03/2019 10:56, Stefano Garzarella wrote: > IEC binary prefixes are already defined in "qemu/units.h", > so we can remove redundant definitions in "block/vhdx.h". > > Signed-off-by: Stefano Garzarella > --- > block/vhdx.c | 3 ++- > block/vhdx.h | 6 +- > 2 files changed, 3 insertions(+

Re: [Qemu-devel] [PATCH 1/2] pflash_cfi01: New pflash_cfi01_legacy_drive()

2019-04-11 Thread Laszlo Ersek
On 04/11/19 21:35, Laszlo Ersek wrote: > On 04/11/19 15:56, Markus Armbruster wrote: >> Factored out of pc_system_firmware_init() so the next commit can reuse >> it in hw/arm/virt.c. >> >> Signed-off-by: Markus Armbruster >> --- >> hw/block/pflash_cfi01.c | 30 ++ >>

Re: [Qemu-devel] [Qemu-trivial] [PATCH v6 2/2] CODING_STYLE: indent example code as all others

2019-04-11 Thread Laurent Vivier
On 04/03/2019 08:16, Wei Yang wrote: > All the example code are indented with four spaces except this one. > > Fix this by adding four spaces here. > > Signed-off-by: Wei Yang > Reviewed-by: Eric Blake > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Igor Mammedov > --- > CODING_STYLE |

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Clean up includes

2019-04-11 Thread Laurent Vivier
On 21/03/2019 10:21, Thomas Huth wrote: > On 13/03/2019 17.28, Markus Armbruster wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes, with the changes >> to the following f

Re: [Qemu-devel] [PATCH for-4.1] hw/input: Add a CONFIG_PS2 switch for the ps2.c file

2019-04-11 Thread Philippe Mathieu-Daudé
On 4/11/19 8:22 PM, Thomas Huth wrote: > ps2.c only needs to be compiled if we are building pckbd.c or pl050.c. Hehe I have the same patch staged locally =) > Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > hw/input/Kconfig | 5

Re: [Qemu-devel] [Qemu-trivial] [PATCH v6 1/2] CODING_STYLE: specify the indent rule for multiline code

2019-04-11 Thread Laurent Vivier
On 04/03/2019 08:16, Wei Yang wrote: > We didn't specify the indent rule for multiline code here, which may > mislead users. And in current code, the code use various styles. > > Add this rule in CODING_STYLE to make sure this is clear to every one. > > Signed-off-by: Wei Yang > Suggested-by: Ig

Re: [Qemu-devel] [PATCH 1/2] pflash_cfi01: New pflash_cfi01_legacy_drive()

2019-04-11 Thread Laszlo Ersek
On 04/11/19 15:56, Markus Armbruster wrote: > Factored out of pc_system_firmware_init() so the next commit can reuse > it in hw/arm/virt.c. > > Signed-off-by: Markus Armbruster > --- > hw/block/pflash_cfi01.c | 30 ++ > hw/i386/pc_sysfw.c | 19 ++---

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-4.1] hw: add compat machines for 4.1

2019-04-11 Thread Greg Kurz
On Thu, 11 Apr 2019 12:20:25 +0200 Cornelia Huck wrote: > Add 4.1 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck > --- > For spapr part: Acked-by: Greg Kurz > IIRC, we agreed last time that we want to merge a patch introducing > the new compat machines first

Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities'

2019-04-11 Thread Singh, Brijesh
On 4/11/19 1:10 PM, Laszlo Ersek wrote: > On 04/11/19 19:59, Singh, Brijesh wrote: >> There are limited numbers of the SEV guests that can be run concurrently. >> A management applications may need to know this limit so that it can place >> SEV VMs on hosts which have suitable resources available

Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities'

2019-04-11 Thread Laszlo Ersek
On 04/11/19 20:10, Laszlo Ersek wrote: > On 04/11/19 19:59, Singh, Brijesh wrote: >> There are limited numbers of the SEV guests that can be run concurrently. >> A management applications may need to know this limit so that it can place >> SEV VMs on hosts which have suitable resources available. >

Re: [Qemu-devel] [PATCH] slirp: Gcc 9 -O3 fix

2019-04-11 Thread Samuel Thibault
Hello, Dr. David Alan Gilbert, le lun. 08 avril 2019 09:46:53 +0100, a ecrit: > 'soread' has the comment: > > /* > * No need to check if there's enough room to read. > * soread wouldn't have been called if there weren't > */ > sopreprbuf(so, iov, &n); >

[Qemu-devel] [PATCH for-4.1] hw/input: Add a CONFIG_PS2 switch for the ps2.c file

2019-04-11 Thread Thomas Huth
ps2.c only needs to be compiled if we are building pckbd.c or pl050.c. Signed-off-by: Thomas Huth --- hw/input/Kconfig | 5 + hw/input/Makefile.objs | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/input/Kconfig b/hw/input/Kconfig index e2e66f0858..316573f782 10

Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities'

2019-04-11 Thread Singh, Brijesh
On 4/11/19 1:05 PM, Daniel P. Berrangé wrote: > On Thu, Apr 11, 2019 at 05:59:50PM +, Singh, Brijesh wrote: >> There are limited numbers of the SEV guests that can be run concurrently. >> A management applications may need to know this limit so that it can place >> SEV VMs on hosts which have

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of fprintf

2019-04-11 Thread Laurent Vivier
On 11/03/2019 11:27, Philippe Mathieu-Daudé wrote: > Avoid to clutter stdout until explicitly requested > (with -d guest_errors): > > $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta > Bad SWSTYLE=0x04 > > Signed-off-by: Philippe Mathieu-Daudé > --- > Helge patch "pcnet:

Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities'

2019-04-11 Thread Laszlo Ersek
On 04/11/19 19:59, Singh, Brijesh wrote: > There are limited numbers of the SEV guests that can be run concurrently. > A management applications may need to know this limit so that it can place > SEV VMs on hosts which have suitable resources available. > > Currently, this limit is not exposed to

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-11 Thread Halil Pasic
On Thu, 11 Apr 2019 18:36:48 +0200 Cornelia Huck wrote: > On Thu, 11 Apr 2019 12:25:38 -0400 > Eric Farman wrote: > > > On 4/11/19 11:58 AM, Halil Pasic wrote: > > > On Wed, 10 Apr 2019 22:59:41 -0400 > > > Eric Farman wrote: > > > > > >> r the next release :) It would be one thing less on

Re: [Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities'

2019-04-11 Thread Daniel P . Berrangé
On Thu, Apr 11, 2019 at 05:59:50PM +, Singh, Brijesh wrote: > There are limited numbers of the SEV guests that can be run concurrently. > A management applications may need to know this limit so that it can place > SEV VMs on hosts which have suitable resources available. > > Currently, this l

Re: [Qemu-devel] [libvirt] [PATCH for-QEMU-4.1] Declare -realtime as deprecated

2019-04-11 Thread Daniel P . Berrangé
On Thu, Apr 11, 2019 at 07:53:45PM +0200, Thomas Huth wrote: > The old -realtime mlock=on|off parameter does exactly the same as the > new -overcommit mem-lock=on|off parameter. Additionally, "-realtime" > does not activate any additional "realtime" capabilities as the name > might indicate. We sho

[Qemu-devel] [PATCH] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities'

2019-04-11 Thread Singh, Brijesh
There are limited numbers of the SEV guests that can be run concurrently. A management applications may need to know this limit so that it can place SEV VMs on hosts which have suitable resources available. Currently, this limit is not exposed to the application. Add a new 'sev-max-guest' field in

[Qemu-devel] [PATCH for-QEMU-4.1] Declare -realtime as deprecated

2019-04-11 Thread Thomas Huth
The old -realtime mlock=on|off parameter does exactly the same as the new -overcommit mem-lock=on|off parameter. Additionally, "-realtime" does not activate any additional "realtime" capabilities as the name might indicate. We should avoid to confuse the users this way, so let's deprecate the old -

[Qemu-devel] [PATCH] hw/smbios: handle both file formats regardless of machine type

2019-04-11 Thread Bruce Rogers
It's easy enough to handle either per-spec or legacy smbios structures in the smbios file input without regard to the machine type used, by simply applying the basic smbios formatting rules. then depending on what is detected. terminal numm bytes are added or removed for machine type specific proce

Re: [Qemu-devel] [PATCH v2] target/riscv: Remove unused include of riscv_htif.h for virt board riscv

2019-04-11 Thread Alistair Francis
On Thu, Apr 11, 2019 at 8:10 AM Jonathan Behrens wrote: > > Signed-off-by: Jonathan Behrens Awesome! Thanks for the patch. Reviewed-by: Alistair Francis Alistair > --- > hw/riscv/virt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > index fc4c6b3

Re: [Qemu-devel] [RFC 0/3] VirtIO RDMA

2019-04-11 Thread Yuval Shaia
On Thu, Apr 11, 2019 at 08:34:20PM +0300, Yuval Shaia wrote: > On Thu, Apr 11, 2019 at 05:24:08PM +, Jason Gunthorpe wrote: > > On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote: > > > On Thu, 11 Apr 2019 14:01:54 +0300 > > > Yuval Shaia wrote: > > > > > > > Data center backends u

Re: [Qemu-devel] [RFC 0/3] VirtIO RDMA

2019-04-11 Thread Jason Gunthorpe
On Thu, Apr 11, 2019 at 08:34:20PM +0300, Yuval Shaia wrote: > On Thu, Apr 11, 2019 at 05:24:08PM +, Jason Gunthorpe wrote: > > On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote: > > > On Thu, 11 Apr 2019 14:01:54 +0300 > > > Yuval Shaia wrote: > > > > > > > Data center backends u

Re: [Qemu-devel] [RFC 0/3] VirtIO RDMA

2019-04-11 Thread Yuval Shaia
On Thu, Apr 11, 2019 at 05:24:08PM +, Jason Gunthorpe wrote: > On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote: > > On Thu, 11 Apr 2019 14:01:54 +0300 > > Yuval Shaia wrote: > > > > > Data center backends use more and more RDMA or RoCE devices and more and > > > more software ru

Re: [Qemu-devel] [RFC 0/3] VirtIO RDMA

2019-04-11 Thread Jason Gunthorpe
On Thu, Apr 11, 2019 at 07:02:15PM +0200, Cornelia Huck wrote: > On Thu, 11 Apr 2019 14:01:54 +0300 > Yuval Shaia wrote: > > > Data center backends use more and more RDMA or RoCE devices and more and > > more software runs in virtualized environment. > > There is a need for a standard to enable R

[Qemu-devel] [PATCH v6 7/7] iotests: test nbd reconnect

2019-04-11 Thread Vladimir Sementsov-Ogievskiy
Add test, which starts backup to nbd target and restarts nbd server during backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/249| 63 +++ tests/qemu-iotests/249.out| 10 ++ tests/qemu-iotests/group | 1 + tests/qemu-i

[Qemu-devel] [PATCH v6 2/7] block/nbd-client: use non-blocking io channel for nbd negotiation

2019-04-11 Thread Vladimir Sementsov-Ogievskiy
No reason to use blocking channel for negotiation and we'll benefit in further reconnect feature, as qio_channel reads and writes will do qemu_coroutine_yield while waiting for io completion. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 3 ++- block/nbd-client.c | 16 +

[Qemu-devel] [PATCH v6 4/7] block/nbd: add cmdline and qapi parameter reconnect-delay

2019-04-11 Thread Vladimir Sementsov-Ogievskiy
Reconnect will be implemented in the following commit, so for now, in semantics below, disconnect itself is a "serious error". Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 12 +++- block/nbd-client.h | 1 + block/nbd-client.c | 1 + block/nbd.c |

[Qemu-devel] [PATCH v6 3/7] block/nbd-client: move from quit to state

2019-04-11 Thread Vladimir Sementsov-Ogievskiy
To implement reconnect we need several states for the client: CONNECTED, QUIT and two different CONNECTING states. CONNECTING states will be added in the following patches. This patch implements CONNECTED and QUIT. QUIT means, that we should close the connection and fail all current and further re

[Qemu-devel] [PATCH v6 6/7] block/nbd-client: nbd reconnect

2019-04-11 Thread Vladimir Sementsov-Ogievskiy
Implement reconnect. To achieve this: 1. add new modes: connecting-wait: means, that reconnecting is in progress, and there were small number of reconnect attempts, so all requests are waiting for the connection. connecting-nowait: reconnecting is in progress, there were a lot of

[Qemu-devel] [PATCH v6 5/7] qemu-coroutine-sleep: introduce qemu_co_sleep_wake

2019-04-11 Thread Vladimir Sementsov-Ogievskiy
Introduce a function to gracefully wake-up a coroutine, sleeping in qemu_co_sleep_ns() sleep. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/coroutine.h| 6 ++ util/qemu-coroutine-sleep.c | 20 2 files changed, 22 insertions(+), 4 deletions(-) diff --

[Qemu-devel] [PATCH v6 1/7] block/nbd-client: split connection_co start out of nbd_client_connect

2019-04-11 Thread Vladimir Sementsov-Ogievskiy
nbd_client_connect is going to be used from connection_co, so, let's refactor nbd_client_connect in advance, leaving io channel configuration all in nbd_client_connect. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 20 +--- 1 file changed, 13 insertions(+),

[Qemu-devel] [PATCH v6 0/7] NBD reconnect

2019-04-11 Thread Vladimir Sementsov-Ogievskiy
Here is NBD reconnect. Previously, if connection failed all current and future requests will fail. After the series, nbd-client driver will try to reconnect unlimited times. During first @reconnect-delay seconds of reconnecting all requests will wait for the connection, and if it is established req

Re: [Qemu-devel] [PULL 16/71] nbd: Increase bs->in_flight during AioContext switch

2019-04-11 Thread Vladimir Sementsov-Ogievskiy
11.04.2019 20:13, Vladimir Sementsov-Ogievskiy wrote: > 11.04.2019 19:48, Kevin Wolf wrote: >> Am 11.04.2019 um 16:48 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> 11.04.2019 17:15, Kevin Wolf wrote: Am 11.04.2019 um 15:40 hat Vladimir Sementsov-Ogievskiy geschrieben: > 25.02.2019 18:1

Re: [Qemu-devel] [PULL 16/71] nbd: Increase bs->in_flight during AioContext switch

2019-04-11 Thread Vladimir Sementsov-Ogievskiy
11.04.2019 19:48, Kevin Wolf wrote: > Am 11.04.2019 um 16:48 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 11.04.2019 17:15, Kevin Wolf wrote: >>> Am 11.04.2019 um 15:40 hat Vladimir Sementsov-Ogievskiy geschrieben: 25.02.2019 18:19, Kevin Wolf wrote: > bdrv_drain() must not leave conne

Re: [Qemu-devel] [PATCH RFC 1/1] block/rbd: increase dynamically the image size

2019-04-11 Thread Jason Dillaman
On Thu, Apr 11, 2019 at 9:02 AM Stefano Garzarella wrote: > > On Thu, Apr 11, 2019 at 08:35:44AM -0400, Jason Dillaman wrote: > > On Thu, Apr 11, 2019 at 7:00 AM Stefano Garzarella > > wrote: > > > > > > RBD APIs don't allow us to write more than the size set with rbd_create() > > > or rbd_resiz

Re: [Qemu-devel] [RFC 0/3] VirtIO RDMA

2019-04-11 Thread Cornelia Huck
On Thu, 11 Apr 2019 14:01:54 +0300 Yuval Shaia wrote: > Data center backends use more and more RDMA or RoCE devices and more and > more software runs in virtualized environment. > There is a need for a standard to enable RDMA/RoCE on Virtual Machines. > > Virtio is the optimal solution since is

Re: [Qemu-devel] [PATCH 1/2] hw: timer: Add ASPEED RTC device

2019-04-11 Thread Peter Maydell
On Thu, 11 Apr 2019 at 17:37, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 4/11/19 5:30 PM, Cédric Le Goater wrote: > > On 4/11/19 5:25 PM, Peter Maydell wrote: > >> This is missing a reset function and vmstate. > > Is vmstate mandatory for new devices. Yes, I think so. You can have vmstate

Re: [Qemu-devel] [PULL 16/71] nbd: Increase bs->in_flight during AioContext switch

2019-04-11 Thread Kevin Wolf
Am 11.04.2019 um 16:48 hat Vladimir Sementsov-Ogievskiy geschrieben: > 11.04.2019 17:15, Kevin Wolf wrote: > > Am 11.04.2019 um 15:40 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 25.02.2019 18:19, Kevin Wolf wrote: > >>> bdrv_drain() must not leave connection_co scheduled, so bs->in_flight >

Re: [Qemu-devel] [PATCH 1/3] aspeed: add a per SoC mapping for the interrupt space

2019-04-11 Thread Philippe Mathieu-Daudé
Hi Cédric, On 4/11/19 6:10 PM, Cédric Le Goater wrote: > This will simplify the definition of new SoCs, like the AST2600 which > should use a different CPU and a different IRQ number layout. > > Signed-off-by: Cédric Le Goater > --- > include/hw/arm/aspeed_soc.h | 1 + > hw/arm/aspeed_soc.c

Re: [Qemu-devel] [PATCH 1/2] hw: timer: Add ASPEED RTC device

2019-04-11 Thread Philippe Mathieu-Daudé
Hi Peter, On 4/11/19 5:30 PM, Cédric Le Goater wrote: > On 4/11/19 5:25 PM, Peter Maydell wrote: >> On Thu, 28 Mar 2019 at 06:22, Joel Stanley wrote: >>> >>> Signed-off-by: Joel Stanley >>> Signed-off-by: Cédric Le Goater >>> --- >>> hw/timer/Makefile.objs| 2 +- >>> hw/timer/aspeed_

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-11 Thread Cornelia Huck
On Thu, 11 Apr 2019 12:25:38 -0400 Eric Farman wrote: > On 4/11/19 11:58 AM, Halil Pasic wrote: > > On Wed, 10 Apr 2019 22:59:41 -0400 > > Eric Farman wrote: > > > >> r the next release :) It would be one thing less on my plate... > > >>> > >>> Sorry I was not able to spend any si

[Qemu-devel] [PATCH for-4.0] spapr_pci: Fix broken naming of PCI bus

2019-04-11 Thread Greg Kurz
Recent commit 5cf0d326a0fe fixed a regression which was preventing the guest to access the extended config space of a PCIe device. This was done by introducing a new PCI bus subtype for PAPR. The original fix was causing PCI busses to be named "spapr-pci-host-bridge-root-bus.N" instead of "pci.N",

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-11 Thread Eric Farman
On 4/11/19 11:58 AM, Halil Pasic wrote: On Wed, 10 Apr 2019 22:59:41 -0400 Eric Farman wrote: r the next release :) It would be one thing less on my plate... Sorry I was not able to spend any significant amount of time on this lately. Gave the combined set (this + Farhans fio-ccw fixe

Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support

2019-04-11 Thread Pankaj Gupta
> > > > This patch adds functionality to perform flush from guest > > > > to host over VIRTIO. We are registering a callback based > > > > on 'nd_region' type. virtio_pmem driver requires this special > > > > flush function. For rest of the region types we are registering > > > > existing flush f

[Qemu-devel] [PATCH 2/3] aspeed: add a per SoC mapping for the memory space

2019-04-11 Thread Cédric Le Goater
This will simplify the definition of new SoCs, like the AST2600 which should use a slightly different address space and have a different set of controllers. Signed-off-by: Cédric Le Goater --- include/hw/arm/aspeed_soc.h | 2 +- hw/arm/aspeed_soc.c | 121 ++-

[Qemu-devel] [PATCH 3/3] aspeed: use sysbus_init_child_obj() to initialize children

2019-04-11 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/arm/aspeed_soc.c | 50 ++--- 1 file changed, 20 insertions(+), 30 deletions(-) diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index 9b601709e93c..110956828c44 100644 --- a/hw/arm/aspeed_soc.c +++ b/hw/arm/aspe

[Qemu-devel] [PATCH 1/3] aspeed: add a per SoC mapping for the interrupt space

2019-04-11 Thread Cédric Le Goater
This will simplify the definition of new SoCs, like the AST2600 which should use a different CPU and a different IRQ number layout. Signed-off-by: Cédric Le Goater --- include/hw/arm/aspeed_soc.h | 1 + hw/arm/aspeed_soc.c | 93 + 2 files changed, 86

[Qemu-devel] [PATCH 0/3] aspeed: cleanups and extenstions

2019-04-11 Thread Cédric Le Goater
Hello, Here is a series adding a couple of cleanups to the Aspeed SoCs to prepare ground for extensions and new SoCs. Thanks, C. Cédric Le Goater (3): aspeed: add a per SoC mapping for the interrupt space aspeed: add a per SoC mapping for the memory space aspeed: use sysbus_init_child_obj

Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support

2019-04-11 Thread Dan Williams
On Thu, Apr 11, 2019 at 9:02 AM Pankaj Gupta wrote: > > > > > > > > > This patch adds functionality to perform flush from guest > > > to host over VIRTIO. We are registering a callback based > > > on 'nd_region' type. virtio_pmem driver requires this special > > > flush function. For rest of the r

Re: [Qemu-devel] [PATCH v4 10/10] iotests: test nbd reconnect

2019-04-11 Thread Vladimir Sementsov-Ogievskiy
16.01.2019 20:11, Eric Blake wrote: > On 7/31/18 12:30 PM, Vladimir Sementsov-Ogievskiy wrote: >> Add test, which starts backup to nbd target and restarts nbd server >> during backup. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> tests/qemu-iotests/220| 67 >> +

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-11 Thread Halil Pasic
On Wed, 10 Apr 2019 22:59:41 -0400 Eric Farman wrote: > r the next release :) It would be one thing less on my plate... > >> > > > > Sorry I was not able to spend any significant amount of time on this > > lately. > > > > Gave the combined set (this + Farhans fio-ccw fixes for kernel > > stac

Re: [Qemu-devel] [PATCH v5 1/6] libnvdimm: nd_region flush callback support

2019-04-11 Thread Pankaj Gupta
> > > > This patch adds functionality to perform flush from guest > > to host over VIRTIO. We are registering a callback based > > on 'nd_region' type. virtio_pmem driver requires this special > > flush function. For rest of the region types we are registering > > existing flush function. Report

  1   2   3   >