[Qemu-devel] [PATCH 2/2] ppc: Add dump-stack implementation

2019-04-30 Thread Suraj Jitindar Singh
The monitor function dump-stack is used to dump the stack for a cpu. This can be useful for debugging purposes when the stack cannot be dumped by another means. Add a ppc implementation ppc_cpu_dump_stack(). The stack pointer is stored in R1 with the back pointer at offset 0 and the link register

[Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-04-30 Thread Suraj Jitindar Singh
Add a monitor command "dump-stack" to be used to dump the stack for the current cpu. Signed-off-by: Suraj Jitindar Singh --- hmp-commands.hx | 13 + hmp.h | 1 + include/qom/cpu.h | 10 ++ monitor.c | 12 qom/cpu.c | 10 ++

[Qemu-devel] [PATCH v2 29/29] target/xtensa: Use tcg_gen_abs_i32

2019-04-30 Thread Richard Henderson
Cc: Max Filippov Signed-off-by: Richard Henderson --- target/xtensa/translate.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index 301c8e3161..b063fa85f2 100644 --- a/target/xtensa/translate.c +++

[Qemu-devel] [PATCH v2 28/29] target/tricore: Use tcg_gen_abs_tl

2019-04-30 Thread Richard Henderson
From: Philippe Mathieu-Daudé Reviewed-by: Bastian Koppelmann Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190423102145.14812-3-f4...@amsat.org> Signed-off-by: Richard Henderson --- target/tricore/translate.c | 27 +-- 1 file changed, 5 insertions(+), 22

[Qemu-devel] [PATCH v2 22/29] tcg/aarch64: Support vector absolute value

2019-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 +- tcg/aarch64/tcg-target.inc.c | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h index 21d06d928c..e43554c3c7 100644 --- a/tcg/aarch64/tcg-target.h

[Qemu-devel] [PATCH v2 17/29] tcg: Add gvec expanders for vector shift by scalar

2019-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg-op-gvec.h | 7 ++ tcg/tcg-op.h | 4 + tcg/tcg-op-gvec.c | 204 ++ tcg/tcg-op-vec.c | 54 4 files changed, 269 insertions(+) diff --git a/tcg/tcg-op-gvec.h b/tcg/tcg-op-gvec.h index

[Qemu-devel] [PATCH v2 24/29] target/cris: Use tcg_gen_abs_tl

2019-04-30 Thread Richard Henderson
Cc: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/cris/translate.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index b005a5c20e..31b40a57f9 100644 --- a/target/cris/translate.c +++

[Qemu-devel] [PATCH v2 26/29] target/ppc: Use tcg_gen_abs_tl

2019-04-30 Thread Richard Henderson
Cc: David Gibson Signed-off-by: Richard Henderson --- target/ppc/translate.c | 68 +++--- 1 file changed, 24 insertions(+), 44 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 8d08625c33..b5217f632f 100644 ---

[Qemu-devel] [PATCH v2 15/29] tcg/i386: Support vector variable shift opcodes

2019-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 2 +- tcg/i386/tcg-target.inc.c | 35 +++ 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h index 241bf19413..b240633455 100644 ---

[Qemu-devel] [PATCH v2 21/29] tcg/i386: Support vector absolute value

2019-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 2 +- tcg/i386/tcg-target.inc.c | 15 +++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h index 7445f05885..66f16fbe3c 100644 --- a/tcg/i386/tcg-target.h +++

[Qemu-devel] [PATCH v2 27/29] target/s390x: Use tcg_gen_abs_i64

2019-04-30 Thread Richard Henderson
Cc: David Hildenbrand Signed-off-by: Richard Henderson --- target/s390x/translate.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index d4951836ad..e8e8a79b7d 100644 --- a/target/s390x/translate.c +++

[Qemu-devel] [PATCH v2 23/29] target/arm: Use tcg_gen_abs_i64 and tcg_gen_gvec_abs

2019-04-30 Thread Richard Henderson
Cc: qemu-...@nongnu.org Cc: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper.h| 2 -- target/arm/neon_helper.c | 5 - target/arm/translate-a64.c | 41 +- target/arm/translate.c | 11 +++--- 4 files changed, 8

[Qemu-devel] [PATCH v2 13/29] tcg: Add INDEX_op_dup_mem_vec

2019-04-30 Thread Richard Henderson
Allow the backend to expand dup from memory directly, instead of forcing the value into a temp first. This is especially important if integer/vector register moves do not exist. Note that officially tcg_out_dupm_vec is allowed to fail. If it did, we could fix this up relatively easily: VECE

[Qemu-devel] [PATCH v2 19/29] tcg: Add support for integer absolute value

2019-04-30 Thread Richard Henderson
Remove a function of the same name from target/arm/. Use a branchless implementation of abs gleaned from gcc. Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 5 + target/arm/translate.c | 10 --

[Qemu-devel] [PATCH v2 14/29] tcg: Add gvec expanders for variable shift

2019-04-30 Thread Richard Henderson
The gvec expanders perform a modulo on the shift count. If the target requires alternate behaviour, then it cannot use the generic gvec expanders anyway, and will have to have its own custom code. Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime.h | 15 +++ tcg/tcg-op-gvec.h

[Qemu-devel] [PATCH v2 25/29] target/ppc: Use tcg_gen_abs_i32

2019-04-30 Thread Richard Henderson
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190423102145.14812-2-f4...@amsat.org> Signed-off-by: Richard Henderson --- target/ppc/translate/spe-impl.inc.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git

[Qemu-devel] [PATCH v2 10/29] tcg: Add tcg_out_dupm_vec to the backend interface

2019-04-30 Thread Richard Henderson
Currently stubbed out in all backends that support vectors. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 6 ++ tcg/i386/tcg-target.inc.c| 7 +++ tcg/tcg.c| 19 ++- 3 files changed, 31 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v2 11/29] tcg/i386: Implement tcg_out_dupm_vec

2019-04-30 Thread Richard Henderson
At the same time, improve tcg_out_dupi_vec wrt broadcast from the constant pool. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 57 +-- 1 file changed, 43 insertions(+), 14 deletions(-) diff --git a/tcg/i386/tcg-target.inc.c

[Qemu-devel] [PATCH v2 12/29] tcg/aarch64: Implement tcg_out_dupm_vec

2019-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 38 ++-- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index 4a3cfa778a..411fb463ac 100644 ---

[Qemu-devel] [PATCH v2 20/29] tcg: Add support for vector absolute value

2019-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime.h | 5 +++ tcg/aarch64/tcg-target.h | 1 + tcg/i386/tcg-target.h| 1 + tcg/tcg-op-gvec.h| 2 ++ tcg/tcg-opc.h| 1 + tcg/tcg.h| 1 + accel/tcg/tcg-runtime-gvec.c | 48

[Qemu-devel] [PATCH v2 18/29] tcg/i386: Support vector scalar shift opcodes

2019-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 2 +- tcg/i386/tcg-target.inc.c | 35 +++ 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h index b240633455..618aa520d2 100644 ---

[Qemu-devel] [PATCH v2 09/29] tcg: Manually expand INDEX_op_dup_vec

2019-04-30 Thread Richard Henderson
This case is similar to INDEX_op_mov_* in that we need to do different things depending on the current location of the source. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 9 ++-- tcg/i386/tcg-target.inc.c| 8 ++- tcg/tcg.c| 102

[Qemu-devel] [PATCH v2 05/29] tcg: Assert fixed_reg is read-only

2019-04-30 Thread Richard Henderson
The only fixed_reg is cpu_env, and it should not be modified during any TB. Therefore code that tries to special-case moves into a fixed_reg is dead. Remove it. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- tcg/tcg.c | 87

[Qemu-devel] [PATCH v2 03/29] tcg: Allow add_vec, sub_vec, neg_vec, not_vec to be expanded

2019-04-30 Thread Richard Henderson
Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- tcg/tcg-op-vec.c | 49 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c index 27f65600c3..cfb18682b1 100644 ---

[Qemu-devel] [PATCH v2 08/29] tcg: Promote tcg_out_{dup, dupi}_vec to backend interface

2019-04-30 Thread Richard Henderson
The i386 backend already has these functions, and the aarch64 backend could easily split out one. Nothing is done with these functions yet, but this will aid register allocation of INDEX_op_dup_vec in a later patch. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 12

[Qemu-devel] [PATCH v2 16/29] tcg/aarch64: Support vector variable shift opcodes

2019-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 +- tcg/aarch64/tcg-target.opc.h | 2 ++ tcg/aarch64/tcg-target.inc.c | 42 3 files changed, 45 insertions(+), 1 deletion(-) diff --git a/tcg/aarch64/tcg-target.h

[Qemu-devel] [PATCH v2 02/29] tcg: Do not recreate INDEX_op_neg_vec unless supported

2019-04-30 Thread Richard Henderson
Use tcg_can_emit_vec_op instead of just TCG_TARGET_HAS_neg_vec, so that we check the type and vece for the actual operation. Signed-off-by: Richard Henderson --- tcg/optimize.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index

[Qemu-devel] [PATCH v2 04/29] tcg: Specify optional vector requirements with a list

2019-04-30 Thread Richard Henderson
Replace the single opcode in .opc with a null-terminated array in .opt_opc. We still require that all opcodes be used with the same .vece. Validate the contents of this list with CONFIG_DEBUG_TCG. All tcg_gen_*_vec functions will check any list active during .fniv expansion. Swap the active

[Qemu-devel] [PATCH v2 01/29] tcg: Implement tcg_gen_gvec_3i()

2019-04-30 Thread Richard Henderson
From: David Hildenbrand Let's add tcg_gen_gvec_3i(), similar to tcg_gen_gvec_2i(), however without introducing "gen_helper_gvec_3i *fnoi", as it isn't needed for now. Signed-off-by: David Hildenbrand Message-Id: <20190416185301.25344-2-da...@redhat.com> Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH v2 00/29] tcg vector improvements

2019-04-30 Thread Richard Henderson
Changes since v1: * Postponing vector select. I plan to re-work that. * Postponing some of the target/* changes. I plan to submit most of those separately via the appropriate trees. The exception is abs(), which I'm still doing here. r~ David Hildenbrand (1): tcg: Implement

[Qemu-devel] [PATCH v2 07/29] tcg: Support cross-class moves without instruction support

2019-04-30 Thread Richard Henderson
PowerPC Altivec does not support direct moves between vector registers and general registers. So when tcg_out_mov fails, we can use the backing memory for the temporary to perform the move. Acked-by: David Hildenbrand Signed-off-by: Richard Henderson --- tcg/tcg.c | 31

[Qemu-devel] [PATCH v2 06/29] tcg: Return bool success from tcg_out_mov

2019-04-30 Thread Richard Henderson
This patch merely changes the interface, aborting on all failures, of which there are currently none. Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Gibson Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 5 +++--

Re: [Qemu-devel] [PULL 0/1] Tracing patches

2019-04-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190429161046.10527-1-stefa...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time

[Qemu-devel] [Bug 1826393] Re: QEMU 3.1.0 stuck waiting for 800ms (5 times slower) in pre-bios phase

2019-04-30 Thread Waldemar Kozaczuk
I tried with the bios https://github.com/qemu/qemu/blob/v4.0.0/pc-bios/bios-256k.bin and it failed like so: ``` qemu: could not load PC BIOS 'bios-256k.bin' qemu failed. ``` Have not had chance to try with QEMU 4 yet. -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH v1 1/5] armv7m: Allow entry information to be returned

2019-04-30 Thread Alistair Francis
On Tue, Apr 30, 2019 at 9:04 AM Peter Maydell wrote: > > On Mon, 29 Apr 2019 at 06:34, Alistair Francis wrote: > > > > Allow the kernel's entry point information to be returned when loading a > > kernel. > > > > Signed-off-by: Alistair Francis > > --- > > hw/arm/armv7m.c | 6 +++--- > >

Re: [Qemu-devel] [PATCH] virtio-mmio: Always compile debug prints

2019-04-30 Thread LI, BO XUAN
Hi Eric and Phil, Thanks for your reviews. I am looking into trace events and I'll send a patch v2 soon. Eric Blake 於 2019年4月30日週二 下午11:03寫道: > On 4/30/19 5:15 AM, Philippe Mathieu-Daudé wrote: > > Hi Li, > > > > On 4/28/19 1:02 PM, Boxuan Li wrote: > >> Wrap printf calls inside debug macros

Re: [Qemu-devel] [PATCH] target/ppc/kvm: Fix trace typo

2019-04-30 Thread David Gibson
On Wed, May 01, 2019 at 01:28:42AM +0800, Boxuan Li wrote: > Signed-off-by: Boxuan Li Applied to ppc-for-4.1, thanks. > --- > target/ppc/kvm.c| 2 +- > target/ppc/trace-events | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/ppc/kvm.c

Re: [Qemu-devel] [PATCH v1] target/arm/arm-powerctl: mask the cpuid with affinity bits when get cpu

2019-04-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190429064830.12213-1-yangchuanl...@huawei.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH for-4.1 4/8] target/riscv: Merge argument decode for RVC shifti

2019-04-30 Thread Palmer Dabbelt
On Thu, 25 Apr 2019 09:50:41 PDT (-0700), richard.hender...@linaro.org wrote: On 4/25/19 9:04 AM, Palmer Dabbelt wrote:  # *** RV64C Standard Extension (Quadrant 2) *** -c_slli    000 .  .  . 10 @c_shift2 +slli  000 .  .  . 10 @c_shift2 This is another one

Re: [Qemu-devel] [PATCH for-4.1 0/8] target/riscv: decodetree improvments

2019-04-30 Thread Palmer Dabbelt
On Thu, 25 Apr 2019 09:23:56 PDT (-0700), richard.hender...@linaro.org wrote: On 4/25/19 9:04 AM, Palmer Dabbelt wrote: Thanks!  I'm happy taking this as it stands, since all those decode issues I pointed out aren't regressions in this patch set.  Let me know if you want to fix those or if you

Re: [Qemu-devel] [PATCH v2 1/3] q35: set split kernel irqchip as default

2019-04-30 Thread Alex Williamson
On Wed, 1 May 2019 01:09:48 +0200 Paolo Bonzini wrote: > On 01/05/19 01:01, Alex Williamson wrote: > > Poking at this a bit, we can add kvm_irqchip_is_split() to the set of > > things we test for in hw/vfio/pci.c:vfio_intx_enable_kvm() to avoid the > > KVM INTx bypass when using split IRQ chip.

Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-04-30 Thread Michael S. Tsirkin
On Wed, May 01, 2019 at 01:11:34AM +0200, Paolo Bonzini wrote: > On 01/05/19 00:50, Michael S. Tsirkin wrote: > >> Stefan, did you hit a build failure, or it was just theoretical? > >> > >> linux-headers/*/mman.h is updated by "linux-headers: add > >> linux/mman.h" (commit 8cf108c5d159). If the

[Qemu-devel] [PATCH v2 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning

2019-04-30 Thread Alistair Francis
Fix this warning with GCC 9 on Fedora 30: hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of ‘struct ’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 1715 | dataset->filename); |

[Qemu-devel] [PATCH v2 4/5] linux-user/uname: Fix GCC 9 build warnings

2019-04-30 Thread Alistair Francis
Fix this warning when building with GCC9 on Fedora 30: In function ‘strncpy’, inlined from ‘sys_uname’ at /home/alistair/qemu/linux-user/uname.c:94:3: /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ output may be truncated copying 64 bytes from a string of length 64

Re: [Qemu-devel] [PATCH RFC] migration/dirty-bitmaps: change bitmap enumeration method

2019-04-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190430231536.25353-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190430231536.25353-1-js...@redhat.com Subject: [Qemu-devel] [PATCH RFC]

[Qemu-devel] [PATCH v2 2/5] hw/usb/hcd-xhci: Fix GCC 9 build warning

2019-04-30 Thread Alistair Francis
Fix this build warning with GCC 9 on Fedora 30: hw/usb/hcd-xhci.c:3339:66: error: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 5 [-Werror=format-truncation=] 3339 | snprintf(port->name, sizeof(port->name), "usb2 port #%d", i+1);

[Qemu-devel] [PATCH v2 5/5] linux-user/elfload: Fix GCC 9 build warnings

2019-04-30 Thread Alistair Francis
Fix this warning when building with GCC9 on Fedora 30: In function ‘strncpy’, inlined from ‘fill_psinfo’ at /home/alistair/qemu/linux-user/elfload.c:3208:12, inlined from ‘fill_note_info’ at /home/alistair/qemu/linux-user/elfload.c:3390:5, inlined from ‘elf_core_dump’ at

[Qemu-devel] [PATCH v2 1/5] util/qemu-sockets: Fix GCC 9 build warnings

2019-04-30 Thread Alistair Francis
Fix this warning when building with GCC9 on Fedora 30: In function ‘strncpy’, inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5: /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 108 equals destination size

[Qemu-devel] [PATCH RFC] migration/dirty-bitmaps: change bitmap enumeration method

2019-04-30 Thread John Snow
Shift from looking at every root BDS to *every* BDS. Tested only lightly via iotests. Counter-examples that break this approach welcome. --- migration/block-dirty-bitmap.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/migration/block-dirty-bitmap.c

[Qemu-devel] [PATCH v2 0/5] Fix some GCC 9 build warnings

2019-04-30 Thread Alistair Francis
v2: - Rewrite most patches based on the feedback from v1 Alistair Francis (5): util/qemu-sockets: Fix GCC 9 build warnings hw/usb/hcd-xhci: Fix GCC 9 build warning hw/usb/dev-mtp: Fix GCC 9 build warning linux-user/uname: Fix GCC 9 build warnings linux-user/elfload: Fix GCC 9 build

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2019-04-30 Thread John Snow
On 11/20/18 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.11.2018 21:43, John Snow wrote: >> Coverity warns that backing_bs() could give us a NULL pointer, which >> we then use without checking that it isn't. >> >> In our loop condition, we check bs && bs->drv as a point of habit, but >>

Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-04-30 Thread Paolo Bonzini
On 01/05/19 00:50, Michael S. Tsirkin wrote: >> Stefan, did you hit a build failure, or it was just theoretical? >> >> linux-headers/*/mman.h is updated by "linux-headers: add >> linux/mman.h" (commit 8cf108c5d159). If the build really fails, >> something else is broken in our build system. > I

Re: [Qemu-devel] [PATCH v2 1/3] q35: set split kernel irqchip as default

2019-04-30 Thread Paolo Bonzini
On 01/05/19 01:01, Alex Williamson wrote: > Poking at this a bit, we can add kvm_irqchip_is_split() to the set of > things we test for in hw/vfio/pci.c:vfio_intx_enable_kvm() to avoid the > KVM INTx bypass when using split IRQ chip. Yes, this should be enough. > The only way I can get the

Re: [Qemu-devel] [PULL 0/1] Tracing patches

2019-04-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190429161046.10527-1-stefa...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v2 1/3] q35: set split kernel irqchip as default

2019-04-30 Thread Alex Williamson
On Mon, 29 Apr 2019 08:21:06 -0600 Alex Williamson wrote: > On Sat, 27 Apr 2019 10:09:51 +0200 > Paolo Bonzini wrote: > > > On 27/04/19 07:29, Paolo Bonzini wrote: > > > > > >>> In my testing it looks like KVM advertises supporting the KVM_IRQFD > > >>> resample feature, but vfio never

Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-04-30 Thread Eduardo Habkost
On Tue, Apr 30, 2019 at 10:36:18PM +, Wei Yang wrote: [...] > >> +#ifdef CONFIG_LINUX > >> +#include > >> +#endif /* CONFIG_LINUX */ > >> + > >> +#ifndef MAP_SYNC > >> +#define MAP_SYNC 0 > >> +#endif > >> +#ifndef MAP_SHARED_VALIDATE > >> +#define MAP_SHARED_VALIDATE 0 > >> +#endif > > >

Re: [Qemu-devel] [PATCH v3 2/2] docs/interop/bitmaps: rewrite and modernize doc

2019-04-30 Thread John Snow
On 4/29/19 9:44 AM, Kashyap Chamarthy wrote: > On Fri, Apr 26, 2019 at 06:15:28PM -0400, John Snow wrote: >> This just about rewrites the entirety of the bitmaps.rst document to >> make it consistent with the 4.0 release. I have added new features seen >> in the 4.0 release, as well as tried to

Re: [Qemu-devel] [PATCH v3 1/2] Makefile: add nit-picky mode to sphinx-build

2019-04-30 Thread John Snow
On 4/29/19 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: > 27.04.2019 1:15, John Snow wrote: >> If we add references that don't resolve (or accidentally remove them), >> it will be helpful to have an error message alerting us to that. > > the wording still a bit in conflict with the fact that

Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-04-30 Thread Michael S. Tsirkin
On Tue, Apr 30, 2019 at 07:48:16PM -0300, Eduardo Habkost wrote: > On Tue, Apr 30, 2019 at 10:36:18PM +, Wei Yang wrote: > [...] > > >> +#ifdef CONFIG_LINUX > > >> +#include > > >> +#endif /* CONFIG_LINUX */ > > >> + > > >> +#ifndef MAP_SYNC > > >> +#define MAP_SYNC 0 > > >> +#endif > > >>

Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-04-30 Thread Wei Yang
On Tue, Apr 30, 2019 at 05:46:36PM -0300, Eduardo Habkost wrote: >Hi, > >On Fri, Apr 26, 2019 at 08:36:51AM +0800, Wei Yang wrote: >> From: Zhang Yi >> >> When a file supporting DAX is used as vNVDIMM backend, mmap it with >> MAP_SYNC flag in addition which can ensure file system metadata >>

Re: [Qemu-devel] [PATCH v2 5/8] cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD

2019-04-30 Thread Li-Wen Hsu
On Mon, Apr 29, 2019 at 12:55 AM Thomas Huth wrote: > > We are going to enable the qemu-iotests during "make check" again, > and for running the iotests, we need bash and gnu-sed. > > Signed-off-by: Thomas Huth Reviewed-by: Li-Wen Hsu

Re: [Qemu-devel] [PATCH v1 1/5] util/qemu-sockets: Fix GCC 9 build warnings

2019-04-30 Thread Alistair Francis
On Tue, Apr 30, 2019 at 2:16 PM Eric Blake wrote: > > On 4/30/19 3:25 PM, Eric Blake wrote: > > On 4/30/19 3:08 PM, Alistair Francis wrote: > >> Fix this warning when building with GCC9 on Fedora 30: > >> In function ‘strncpy’, > >> inlined from ‘unix_connect_saddr.isra.0’ at

Re: [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash

2019-04-30 Thread Alex Bennée
Thomas Huth writes: > bash is installed in a different directory on non-Linux systems like > FreeBSD. Do not hard-code /bin/bash here so that the tests can run > there, too. > > Signed-off-by: Thomas Huth Reviewed-by: Alex Bennée > --- > tests/qemu-iotests/239 | 2 +- >

Re: [Qemu-devel] [PATCH 1/6] tests/qemu-iotests/check: Pick a default machine if necessary

2019-04-30 Thread Alex Bennée
Thomas Huth writes: > qemu-system-arm, qemu-system-aarch64 and qemu-system-tricore do not have > a default machine, so when running the qemu-iotests with such a binary, > lots of tests are failing. Fix it by picking a default machine in the > "check" script instead. > > Signed-off-by: Thomas

Re: [Qemu-devel] [PATCH v1 1/5] util/qemu-sockets: Fix GCC 9 build warnings

2019-04-30 Thread Eric Blake
On 4/30/19 3:25 PM, Eric Blake wrote: > On 4/30/19 3:08 PM, Alistair Francis wrote: >> Fix this warning when building with GCC9 on Fedora 30: >> In function ‘strncpy’, >> inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5: >> /usr/include/bits/string_fortified.h:106:10:

Re: [Qemu-devel] [PATCH v1 5/5] linux-user/elfload: Fix GCC 9 build warnings

2019-04-30 Thread Alistair Francis
On Tue, Apr 30, 2019 at 2:10 PM Eric Blake wrote: > > On 4/30/19 4:01 PM, Alistair Francis wrote: > > On Tue, Apr 30, 2019 at 1:36 PM Laurent Vivier wrote: > >> > >> Le 30/04/2019 à 22:09, Alistair Francis a écrit : > >>> Fix this warning when building with GCC9 on Fedora 30: > >>> In function

Re: [Qemu-devel] [PATCH v1 5/5] linux-user/elfload: Fix GCC 9 build warnings

2019-04-30 Thread Eric Blake
On 4/30/19 4:01 PM, Alistair Francis wrote: > On Tue, Apr 30, 2019 at 1:36 PM Laurent Vivier wrote: >> >> Le 30/04/2019 à 22:09, Alistair Francis a écrit : >>> Fix this warning when building with GCC9 on Fedora 30: >>> In function ‘strncpy’, >>> inlined from ‘fill_psinfo’ at >>>

Re: [Qemu-devel] [PATCH v1 5/5] linux-user/elfload: Fix GCC 9 build warnings

2019-04-30 Thread Laurent Vivier
Le 30/04/2019 à 23:01, Alistair Francis a écrit : > On Tue, Apr 30, 2019 at 1:36 PM Laurent Vivier wrote: >> >> Le 30/04/2019 à 22:09, Alistair Francis a écrit : >>> Fix this warning when building with GCC9 on Fedora 30: >>> In function ‘strncpy’, >>> inlined from ‘fill_psinfo’ at >>>

Re: [Qemu-devel] [PATCH 23/26] target/xtensa: Convert to CPUClass::tlb_fill

2019-04-30 Thread Max Filippov
On Tue, Apr 30, 2019 at 11:14 AM Max Filippov wrote: > On Tue, Apr 30, 2019 at 10:44 AM Richard Henderson > > And Peter's right that I should have kept EXC_USER. It appears to work as is: the EXC_USER is set up by the exception_cause helper because there's always PS_U in the PS, PS_EXCM is

Re: [Qemu-devel] [PATCH v1 4/5] linux-user/uname: Fix GCC 9 build warnings

2019-04-30 Thread Alistair Francis
On Tue, Apr 30, 2019 at 1:40 PM Eric Blake wrote: > > On 4/30/19 3:09 PM, Alistair Francis wrote: > > Fix this warning when building with GCC9 on Fedora 30: > > In function ‘strncpy’, > > inlined from ‘sys_uname’ at /home/alistair/qemu/linux-user/uname.c:94:3: > >

Re: [Qemu-devel] [PATCH v1 4/5] linux-user/uname: Fix GCC 9 build warnings

2019-04-30 Thread Laurent Vivier
Le 30/04/2019 à 22:40, Eric Blake a écrit : > On 4/30/19 3:09 PM, Alistair Francis wrote: >> Fix this warning when building with GCC9 on Fedora 30: >> In function ‘strncpy’, >> inlined from ‘sys_uname’ at /home/alistair/qemu/linux-user/uname.c:94:3: >>

Re: [Qemu-devel] [PATCH v1 2/5] hw/usb/hcd-xhci: Fix GCC 9 build warning

2019-04-30 Thread Alistair Francis
On Tue, Apr 30, 2019 at 1:24 PM Laurent Vivier wrote: > > Le 30/04/2019 à 22:09, Alistair Francis a écrit : > > Fix this build warning with GCC 9 on Fedora 30: > > hw/usb/hcd-xhci.c:3339:66: error: ‘%d’ directive output may be truncated > > writing between 1 and 10 bytes into a region of size 5

Re: [Qemu-devel] [PATCH v1 5/5] linux-user/elfload: Fix GCC 9 build warnings

2019-04-30 Thread Alistair Francis
On Tue, Apr 30, 2019 at 1:36 PM Laurent Vivier wrote: > > Le 30/04/2019 à 22:09, Alistair Francis a écrit : > > Fix this warning when building with GCC9 on Fedora 30: > > In function ‘strncpy’, > > inlined from ‘fill_psinfo’ at > > /home/alistair/qemu/linux-user/elfload.c:3208:12, > >

Re: [Qemu-devel] [PATCH v1 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning

2019-04-30 Thread Alistair Francis
On Tue, Apr 30, 2019 at 1:37 PM Eric Blake wrote: > > On 4/30/19 3:09 PM, Alistair Francis wrote: > > Fix this warning with GCC 9 on Fedora 30: > > hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of ‘struct > > ’ may result in an unaligned pointer value > >

Re: [Qemu-devel] [PATCH v1 4/5] linux-user/uname: Fix GCC 9 build warnings

2019-04-30 Thread Laurent Vivier
Le 30/04/2019 à 22:30, Laurent Vivier a écrit : > Le 30/04/2019 à 22:09, Alistair Francis a écrit : >> Fix this warning when building with GCC9 on Fedora 30: >> In function ‘strncpy’, >> inlined from ‘sys_uname’ at /home/alistair/qemu/linux-user/uname.c:94:3: >>

Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-04-30 Thread Eduardo Habkost
Hi, On Fri, Apr 26, 2019 at 08:36:51AM +0800, Wei Yang wrote: > From: Zhang Yi > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > MAP_SYNC flag in addition which can ensure file system metadata > synced in each guest writes to the backend file, without other QEMU >

Re: [Qemu-devel] [PATCH v1 4/5] linux-user/uname: Fix GCC 9 build warnings

2019-04-30 Thread Eric Blake
On 4/30/19 3:09 PM, Alistair Francis wrote: > Fix this warning when building with GCC9 on Fedora 30: > In function ‘strncpy’, > inlined from ‘sys_uname’ at /home/alistair/qemu/linux-user/uname.c:94:3: > /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ > output may be

Re: [Qemu-devel] [PATCH v2] scsi-disk: handle invalid cdb length

2019-04-30 Thread John Snow
On 4/30/19 9:19 AM, Bruce Rogers wrote: > While investigating link-time-optimization, the compiler flagged this > case of not handling the error return from scsi_cdb_length(). Handle > this error case with a trace report. > > Signed-off-by: Bruce Rogers > --- > hw/scsi/scsi-disk.c | 4 >

Re: [Qemu-devel] [PATCH v1 1/5] util/qemu-sockets: Fix GCC 9 build warnings

2019-04-30 Thread Eric Blake
On 4/30/19 3:08 PM, Alistair Francis wrote: > Fix this warning when building with GCC9 on Fedora 30: > In function ‘strncpy’, > inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5: > /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ > specified bound

Re: [Qemu-devel] [PATCH v1 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning

2019-04-30 Thread Laurent Vivier
Le 30/04/2019 à 22:09, Alistair Francis a écrit : > Fix this warning with GCC 9 on Fedora 30: > hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of ‘struct > ’ may result in an unaligned pointer value > [-Werror=address-of-packed-member] > 1715 |

Re: [Qemu-devel] [PATCH v1 1/5] util/qemu-sockets: Fix GCC 9 build warnings

2019-04-30 Thread Laurent Vivier
Le 30/04/2019 à 22:08, Alistair Francis a écrit : > Fix this warning when building with GCC9 on Fedora 30: > In function ‘strncpy’, > inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5: > /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ > specified

Re: [Qemu-devel] [PATCH v1 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning

2019-04-30 Thread Laurent Vivier
Le 30/04/2019 à 22:28, Laurent Vivier a écrit : > Le 30/04/2019 à 22:09, Alistair Francis a écrit : >> Fix this warning with GCC 9 on Fedora 30: >> hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of ‘struct >> ’ may result in an unaligned pointer value >>

Re: [Qemu-devel] [PATCH v1 2/5] hw/usb/hcd-xhci: Fix GCC 9 build warning

2019-04-30 Thread Laurent Vivier
Le 30/04/2019 à 22:09, Alistair Francis a écrit : > Fix this build warning with GCC 9 on Fedora 30: > hw/usb/hcd-xhci.c:3339:66: error: ‘%d’ directive output may be truncated > writing between 1 and 10 bytes into a region of size 5 > [-Werror=format-truncation=] > 3339 |

Re: [Qemu-devel] [PATCH v1 4/5] linux-user/uname: Fix GCC 9 build warnings

2019-04-30 Thread Laurent Vivier
Le 30/04/2019 à 22:09, Alistair Francis a écrit : > Fix this warning when building with GCC9 on Fedora 30: > In function ‘strncpy’, > inlined from ‘sys_uname’ at /home/alistair/qemu/linux-user/uname.c:94:3: > /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ > output may

Re: [Qemu-devel] [PULL 01/19] s390 vfio-ccw: Add bootindex property and IPLB data

2019-04-30 Thread Eduardo Habkost
On Tue, Apr 30, 2019 at 05:54:49PM +0100, Peter Maydell wrote: > On Thu, 25 Apr 2019 at 14:21, Cornelia Huck wrote: [...] > > -SCSIDevice *sd = (SCSIDevice *) object_dynamic_cast(OBJECT(dev_st), > > - > > TYPE_SCSI_DEVICE); > > -

Re: [Qemu-devel] [PATCH v1 5/5] hw/arm: Add the Netduino Plus 2

2019-04-30 Thread Alistair Francis
On Tue, Apr 30, 2019 at 9:02 AM Peter Maydell wrote: > > On Mon, 29 Apr 2019 at 06:39, Alistair Francis wrote: > > > > Signed-off-by: Alistair Francis > > --- > > MAINTAINERS | 6 +++ > > default-configs/arm-softmmu.mak | 1 + > > hw/arm/Kconfig | 3 ++ >

Re: [Qemu-devel] [PATCH v1 5/5] linux-user/elfload: Fix GCC 9 build warnings

2019-04-30 Thread Laurent Vivier
Le 30/04/2019 à 22:09, Alistair Francis a écrit : > Fix this warning when building with GCC9 on Fedora 30: > In function ‘strncpy’, > inlined from ‘fill_psinfo’ at > /home/alistair/qemu/linux-user/elfload.c:3208:12, > inlined from ‘fill_note_info’ at >

Re: [Qemu-devel] [PATCH v1 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning

2019-04-30 Thread Eric Blake
On 4/30/19 3:09 PM, Alistair Francis wrote: > Fix this warning with GCC 9 on Fedora 30: > hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of ‘struct > ’ may result in an unaligned pointer value > [-Werror=address-of-packed-member] > 1715 |

[Qemu-devel] [PATCH v1 2/5] hw/usb/hcd-xhci: Fix GCC 9 build warning

2019-04-30 Thread Alistair Francis
Fix this build warning with GCC 9 on Fedora 30: hw/usb/hcd-xhci.c:3339:66: error: ‘%d’ directive output may be truncated writing between 1 and 10 bytes into a region of size 5 [-Werror=format-truncation=] 3339 | snprintf(port->name, sizeof(port->name), "usb2 port #%d", i+1);

[Qemu-devel] [PATCH v1 1/5] util/qemu-sockets: Fix GCC 9 build warnings

2019-04-30 Thread Alistair Francis
Fix this warning when building with GCC9 on Fedora 30: In function ‘strncpy’, inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5: /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 108 equals destination size

[Qemu-devel] [PATCH v1 4/5] linux-user/uname: Fix GCC 9 build warnings

2019-04-30 Thread Alistair Francis
Fix this warning when building with GCC9 on Fedora 30: In function ‘strncpy’, inlined from ‘sys_uname’ at /home/alistair/qemu/linux-user/uname.c:94:3: /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ output may be truncated copying 64 bytes from a string of length 64

[Qemu-devel] [PATCH v1 5/5] linux-user/elfload: Fix GCC 9 build warnings

2019-04-30 Thread Alistair Francis
Fix this warning when building with GCC9 on Fedora 30: In function ‘strncpy’, inlined from ‘fill_psinfo’ at /home/alistair/qemu/linux-user/elfload.c:3208:12, inlined from ‘fill_note_info’ at /home/alistair/qemu/linux-user/elfload.c:3390:5, inlined from ‘elf_core_dump’ at

[Qemu-devel] [PATCH v1 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning

2019-04-30 Thread Alistair Francis
Fix this warning with GCC 9 on Fedora 30: hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of ‘struct ’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 1715 | dataset->filename); |

[Qemu-devel] [PATCH v1 0/5] Fix some GCC 9 build warnings

2019-04-30 Thread Alistair Francis
Alistair Francis (5): util/qemu-sockets: Fix GCC 9 build warnings hw/usb/hcd-xhci: Fix GCC 9 build warning hw/usb/dev-mtp: Fix GCC 9 build warning linux-user/uname: Fix GCC 9 build warnings linux-user/elfload: Fix GCC 9 build warnings hw/usb/dev-mtp.c | 13 +

[Qemu-devel] [Bug 1618301] Re: qemu-input: Mouse stops working in Windows guest

2019-04-30 Thread kjonca
The same with: 4.19.0-4-amd64 #1 SMP Debian 4.19.28-2 (2019-03-15) x86_64 GNU/Linux QEMU emulator version 3.1.0 (Debian 1:3.1+dfsg-7) and Windows 4.0 sp6 workstation. This guest worked in virtualbox without issues. -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH 0/3] hw/microblaze: Kconfig cleanup

2019-04-30 Thread Paolo Bonzini
On 27/04/19 16:14, Philippe Mathieu-Daudé wrote: > Hi Edgar, Peter, > > Few fixes while cleaning Kconfig, trying to optimize builds. > > Regards, > > Phil. > > Philippe Mathieu-Daudé (3): > hw/Kconfig: Move the generic XLNX_ZYNQMP to the root hw/Kconfig > hw/intc: Only build the

[Qemu-devel] [Bug 1634726] Re: qemu "make test" fails in iov.c with "undefined reference" on aarch64 on Ubuntu 16.04

2019-04-30 Thread Thomas Huth
"make test" has been removed, so I'll mark this as fixed now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1634726 Title: qemu "make test"

Re: [Qemu-devel] [PATCH v2 3/4] util/cacheinfo.c: Use uintptr_t instead of unsigned long in AArch64 arch_cache_info()

2019-04-30 Thread Philippe Mathieu-Daudé
On 4/30/19 8:13 PM, Cao Jiaxi wrote: > Windows ARM64 uses LLP64 model, which breaks current assumptions. > > Signed-off-by: Cao Jiaxi > --- > util/cacheinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/cacheinfo.c b/util/cacheinfo.c > index

Re: [Qemu-devel] [PATCH 0/3] hw/i386/acpi: Improve build modularity (isapc/q35/...)

2019-04-30 Thread Paolo Bonzini
On 27/04/19 16:43, Philippe Mathieu-Daudé wrote: > On 4/27/19 4:40 PM, Philippe Mathieu-Daudé wrote: >> This series allow to build the ISAPC/Q35 machines independently. > > Oops I guess I forgot: > Based-on: 20190427141905.20393-1-phi...@redhat.com > (i440fx is not a machine) >

[Qemu-devel] [PATCH v2] hw/pci-host: Use object_initialize_child for correct reference counting

2019-04-30 Thread Thomas Huth
Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise the child object might not be properly cleaned up when the parent gets

  1   2   3   4   >