On 01/05/2019 01.28, Alistair Francis wrote:
> Fix this warning with GCC 9 on Fedora 30:
> hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of ‘struct
> ’ may result in an unaligned pointer value
> [-Werror=address-of-packed-member]
> 1715 | dataset->f
Patchew URL: https://patchew.org/QEMU/cover.1556562150.git.be...@igalia.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bi
Patchew URL: https://patchew.org/QEMU/20190501061827.23080-1-j...@jms.id.au/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190501061827.23080-1-j...@jms.id.au
Subject: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size
Signed-off-by: Boxuan Li
---
v2: Instead of using conditional debugs, convert DPRINTF to traces
---
hw/virtio/trace-events | 13 +
hw/virtio/virtio-mmio.c | 35 ---
2 files changed, 25 insertions(+), 23 deletions(-)
diff --git a/hw/virtio/trace-events
Thomas Huth writes:
> qemu-system-arm, qemu-system-aarch64 and qemu-system-tricore do not have
> a default machine, so when running the qemu-iotests with such a binary,
> lots of tests are failing. Fix it by picking a default machine in the
> "check" script instead.
>
> Signed-off-by: Thomas Hu
Thomas Huth writes:
> bash is installed in a different directory on non-Linux systems like
> FreeBSD. Do not hard-code /bin/bash here so that the tests can run
> there, too.
>
> Reviewed-by: Eric Blake
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Thomas Huth
Reviewed-by: Alex Benn
Thomas Huth writes:
> On 29/04/2019 05.47, no-re...@patchew.org wrote:
>> Patchew URL:
>> https://patchew.org/QEMU/20190428155451.15653-1-th...@redhat.com/
>>
>> This series failed the asan build test. Please find the testing commands and
>> their output below. If you have Docker installed, yo
Thomas Huth writes:
> People often forget to run the iotests before submitting patches or
> pull requests - this is likely due to the fact that we do not run the
> tests during our mandatory "make check" tests yet.
> This patch series now changes the "auto" group to only include tests
> that sh
On Wed, May 01, 2019 at 04:10:39PM +0800, Boxuan Li wrote:
> Signed-off-by: Boxuan Li
> ---
> v2: Instead of using conditional debugs, convert DPRINTF to traces
> ---
> hw/virtio/trace-events | 13 +
> hw/virtio/virtio-mmio.c | 35 ---
> 2 files change
Le 01/05/2019 à 01:28, Alistair Francis a écrit :
> Fix this warning when building with GCC9 on Fedora 30:
> In function ‘strncpy’,
> inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5:
> /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’
> specified bou
Le 01/05/2019 à 01:28, Alistair Francis a écrit :
> Fix this build warning with GCC 9 on Fedora 30:
> hw/usb/hcd-xhci.c:3339:66: error: ‘%d’ directive output may be truncated
> writing between 1 and 10 bytes into a region of size 5
> [-Werror=format-truncation=]
> 3339 | snprintf(por
On Tue, Apr 30, 2019 at 11:28:41PM +, Alistair Francis wrote:
> Fix this warning with GCC 9 on Fedora 30:
> hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of ‘struct
> ’ may result in an unaligned pointer value
> [-Werror=address-of-packed-member]
> 1715 |
Patchew URL: https://patchew.org/QEMU/cover.1556562150.git.be...@igalia.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make
On 01/05/2019 01:28, Alistair Francis wrote:
> Fix this warning when building with GCC9 on Fedora 30:
> In function ‘strncpy’,
> inlined from ‘sys_uname’ at /home/alistair/qemu/linux-user/uname.c:94:3:
> /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’
> output may be tr
On 01/05/2019 01:29, Alistair Francis wrote:
> Fix this warning when building with GCC9 on Fedora 30:
> In function ‘strncpy’,
> inlined from ‘fill_psinfo’ at
> /home/alistair/qemu/linux-user/elfload.c:3208:12,
> inlined from ‘fill_note_info’ at
> /home/alistair/qemu/linux-user/elfload.c:
* Cole Robinson (crobi...@redhat.com) wrote:
> This gives us the consistent 'Error:' prefix added in 66363e9a43f,
> which helps users like libvirt who still need to scrape hmp error
> messages to detect failure.
>
> Reviewed-by: Eric Blake
> Signed-off-by: Cole Robinson
Queued
> ---
> v2:
>
On Tue, Apr 30, 2019 at 11:28:31PM +, Alistair Francis wrote:
> Fix this build warning with GCC 9 on Fedora 30:
> hw/usb/hcd-xhci.c:3339:66: error: ‘%d’ directive output may be truncated
> writing between 1 and 10 bytes into a region of size 5
> [-Werror=format-truncation=]
> 3339 |
On Tue, Apr 30, 2019 at 11:28:22PM +, Alistair Francis wrote:
> Fix this warning when building with GCC9 on Fedora 30:
> In function ‘strncpy’,
> inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5:
> /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’
On 01/05/2019 11:44, Daniel P. Berrangé wrote:
> On Wed, May 01, 2019 at 11:40:13AM +0200, Laurent Vivier wrote:
>> On 01/05/2019 01:28, Alistair Francis wrote:
>>> Fix this warning when building with GCC9 on Fedora 30:
>>> In function ‘strncpy’,
>>> inlined from ‘sys_uname’ at /home/alistair/q
On Wed, May 01, 2019 at 11:40:13AM +0200, Laurent Vivier wrote:
> On 01/05/2019 01:28, Alistair Francis wrote:
> > Fix this warning when building with GCC9 on Fedora 30:
> > In function ‘strncpy’,
> > inlined from ‘sys_uname’ at /home/alistair/qemu/linux-user/uname.c:94:3:
> > /usr/include/bits
On 01/05/2019 15:35, Suraj Jitindar Singh wrote:
> The monitor function dump-stack is used to dump the stack for a cpu.
> This can be useful for debugging purposes when the stack cannot be
> dumped by another means.
>
> Add a ppc implementation ppc_cpu_dump_stack().
> The stack pointer is store
* Stefan Hajnoczi (stefa...@gmail.com) wrote:
> On Fri, Apr 12, 2019 at 04:26:52PM +0100, Dr. David Alan Gilbert (git) wrote:
> > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > index d3bad2fc27..ba4690b9ac 100644
> > --- a/hmp-commands.hx
> > +++ b/hmp-commands.hx
> > @@ -585,6 +585,21 @@ STEXI
On 01/05/2019 10.30, Alex Bennée wrote:
>
> Thomas Huth writes:
>
>> On 29/04/2019 05.47, no-re...@patchew.org wrote:
>>> Patchew URL:
>>> https://patchew.org/QEMU/20190428155451.15653-1-th...@redhat.com/
>>>
>>> This series failed the asan build test. Please find the testing commands and
>>> t
Thomas Huth writes:
> One of the recent commits changed the way qemu-io prints out its
> errors and warnings - they are now prefixed with the program name.
> We've got to adapt the iotests accordingly to prevent that they
> are failing.
>
> Fixes: 99e98d7c9fc1a1639fad ("qemu-io: Use error_[gs]e
Hi Eric,
> -Original Message-
> From: Auger Eric [mailto:eric.au...@redhat.com]
> Sent: 30 April 2019 16:50
> To: Shameerali Kolothum Thodi ;
> qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com
> Cc: peter.mayd...@linaro.org; shannon.zha...@gmail.com;
> sa...@linux.intel.com;
* Suraj Jitindar Singh (sjitindarsi...@gmail.com) wrote:
> Add a monitor command "dump-stack" to be used to dump the stack for the
> current cpu.
>
> Signed-off-by: Suraj Jitindar Singh
OK, and for a debug-only command that's OK for HMP.
> ---
> hmp-commands.hx | 13 +
> hmp.h
Hi Eric,
> -Original Message-
> From: Auger Eric [mailto:eric.au...@redhat.com]
> Sent: 30 April 2019 17:34
> To: Shameerali Kolothum Thodi ;
> qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com
> Cc: peter.mayd...@linaro.org; shannon.zha...@gmail.com;
> sa...@linux.intel.com;
Patchew URL:
https://patchew.org/QEMU/20190429134757.13570-1-marcandre.lur...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT B
From: "Dr. David Alan Gilbert"
Add a gva2gpa command purely for debug which performs
address translation on the gva, the existing gpa2hva
command can then also be used to find it in the qemu
userspace; e.g.
(qemu) info registers
RSP=81c03e98
(qemu) gva2gpa 0x81c03e98
gp
/dagrh/qemu.git tags/pull-hmp-20190501
for you to fetch changes up to 574d96933ceff60b2d13fe97602572fc7e95f7c6:
hmp: gva2gpa debug command (2019-05-01 10:46:59 +0100)
HMP pull
New gva2gpa command
delvm now uses hmp_handle_error s
From: Cole Robinson
This gives us the consistent 'Error:' prefix added in 66363e9a43f,
which helps users like libvirt who still need to scrape hmp error
messages to detect failure.
Reviewed-by: Eric Blake
Signed-off-by: Cole Robinson
Message-Id:
<984634226fa14316641f31f84e7dd0bb770bd94c.15561
Thomas Huth writes:
> "check -raw 005" fails when running on ext4 filesystems - these do not
> support such large sparse files. Use the same check as in test 220 to
> skip the test in this case.
>
> Suggested-by: Eric Blake
> Signed-off-by: Thomas Huth
> ---
> tests/qemu-iotests/005 | 9
Thomas Huth writes:
> We are going to enable the qemu-iotests during "make check" again,
> and for running the iotests, we need bash and gnu-sed.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Alex Bennée
> ---
> .cirrus.yml | 4 ++--
> .travis.yml | 1 +
> 2 files changed, 3 insertions(+), 2
Thomas Huth writes:
> A lot of tests run fine on FreeBSD and macOS, too - the limitation
> to Linux here was likely just copied-and-pasted from other tests.
> Thus remove the "_supported_os Linux" line from tests that run
> successful in our CI pipelines on FreeBSD and macOS.
>
> Signed-off-by:
On Tue, 9 Apr 2019 at 12:31, Shameer Kolothum
wrote:
>
> From: Samuel Ortiz
>
> The ACPI Generic Event Device (GED) is a hardware-reduced specific
> device[ACPI v6.1 Section 5.6.9] that handles all platform events,
> including the hotplug ones.This patch generates the AML code that
> defines GEDs
Hi Ard,
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: 01 May 2019 12:10
> To: Shameerali Kolothum Thodi
> Cc: QEMU Developers ; qemu-arm
> ; Auger Eric ; Igor
> Mammedov ; Peter Maydell
> ; shannon.zha...@gmail.com;
> sa...@linux.intel.com; sebasti
On 5/1/19 4:40 AM, Laurent Vivier wrote:
> On 01/05/2019 01:28, Alistair Francis wrote:
>> Fix this warning when building with GCC9 on Fedora 30:
>> In function ‘strncpy’,
>> inlined from ‘sys_uname’ at /home/alistair/qemu/linux-user/uname.c:94:3:
>> /usr/include/bits/string_fortified.h:106:10:
On 5/1/19 6:08 AM, Alex Bennée wrote:
>
> Thomas Huth writes:
>
>> "check -raw 005" fails when running on ext4 filesystems - these do not
>> support such large sparse files. Use the same check as in test 220 to
>> skip the test in this case.
>>
>> Suggested-by: Eric Blake
>> Signed-off-by: Thom
On Wed, May 1, 2019 at 4:58 PM Yuval Shaia wrote:
> On Wed, May 01, 2019 at 04:10:39PM +0800, Boxuan Li wrote:
> > Signed-off-by: Boxuan Li
> > ---
> > v2: Instead of using conditional debugs, convert DPRINTF to traces
> > ---
> > hw/virtio/trace-events | 13 +
> > hw/virtio/virtio
On 01/05/2019 13.08, Alex Bennée wrote:
>
> Thomas Huth writes:
>
>> "check -raw 005" fails when running on ext4 filesystems - these do not
>> support such large sparse files. Use the same check as in test 220 to
>> skip the test in this case.
>>
>> Suggested-by: Eric Blake
>> Signed-off-by: Th
Patchew URL:
https://patchew.org/QEMU/20190429090250.7648-1-borntrae...@de.ibm.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN =
On 01/05/2019 14.06, Eric Blake wrote:
> On 5/1/19 6:08 AM, Alex Bennée wrote:
>>
>> Thomas Huth writes:
>>
>>> "check -raw 005" fails when running on ext4 filesystems - these do not
>>> support such large sparse files. Use the same check as in test 220 to
>>> skip the test in this case.
>>>
>>> S
The output of qemu-io changed recently - most tests have been fixed in
commit 36b9986b08787019ef42 ("tests/qemu-iotests: Fix output of qemu-io
related tests") already, but the qcow1 and the vmdk test was still missing.
Fixes: 99e98d7c9fc1a1639fad ("qemu-io: Use error_[gs]et_progname()")
Signed-off
On Wed, May 01, 2019 at 08:42:35PM +0800, LI, BO XUAN wrote:
>On Wed, May 1, 2019 at 4:58 PM Yuval Shaia <[1]yuval.sh...@oracle.com>
>wrote:
>
> On Wed, May 01, 2019 at 04:10:39PM +0800, Boxuan Li wrote:
> > Signed-off-by: Boxuan Li <[2]libox...@connect.hku.hk>
> > ---
>
Patchew URL:
https://patchew.org/QEMU/20190429090250.7648-1-borntrae...@de.ibm.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
t
On 4/30/19 11:18 PM, Joel Stanley wrote:
> mc->no_parallel = 1;
> +if (board->ram)
> +mc->default_ram_size = board->ram;
In addition to the braces, for which patchew will have sent you nag mail...
> +.ram = 256 << 20,
In there are some defines to make this more re
Patchew URL: https://patchew.org/QEMU/20190501061827.23080-1-j...@jms.id.au/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190501061827.23080-1-j...@jms.id.au
Subject: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size
On 4/30/19 4:28 PM, Alistair Francis wrote:
> for (i = 0; i < usbports; i++) {
> +g_assert(i < MAX(MAXPORTS_2, MAXPORTS_3));
I would hope that it works to move this out of the loop:
g_assert(usbports <= MAX(MAXPORTS_2, MAXPORTS_3));
r~
On 4/30/19 4:29 PM, Alistair Francis wrote:
> @@ -2872,7 +2872,7 @@ struct target_elf_prpsinfo {
> target_gid_t pr_gid;
> target_pid_t pr_pid, pr_ppid, pr_pgrp, pr_sid;
> /* Lots missing */
> -charpr_fname[16]; /* filename of executable */
> +charpr_fname[16
Thomas Huth writes:
> On 01/05/2019 13.08, Alex Bennée wrote:
>>
>> Thomas Huth writes:
>>
>>> "check -raw 005" fails when running on ext4 filesystems - these do not
>>> support such large sparse files. Use the same check as in test 220 to
>>> skip the test in this case.
>>>
>>> Suggested-by:
On 4/30/19 9:52 AM, Alex Bennée wrote:
> +.error:
> + .string "Terminated by exception.\n"
Put it in .rodata just because we can?
> +/* Page table setup (identity mapping). */
> + adrpx0, ttb
> + add x0, x0, :lo12:ttb
You are in control of the layout of the executabl
On 4/30/19 9:52 AM, Alex Bennée wrote:
> @@ -119,6 +119,10 @@ void ml_printf(const char *fmt, ...)
> str = va_arg(ap, char*);
> print_str(str);
> break;
> +case 'c':
> +c = (char) va_arg(ap, int);
> +__sys_outc(c);
> +
On 4/30/19 9:52 AM, Alex Bennée wrote:
> +int do_signed_reads(bool neg_first)
> +{
> +int r = 0;
> +int off = 0;
> +
> +while (r == 0 && off < 8) {
> +r = read_test_data_s8(off, neg_first ^ (off & 1));
> +r |= read_test_data_s16(off, !(neg_first ^ (off & 1)));
> +
In file included from /usr/include/string.h:494,
from include/qemu/osdep.h:101,
from linux-user/uname.c:20:
In function ‘strncpy’,
inlined from ‘sys_uname’ at linux-user/uname.c:94:3:
/usr/include/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’
ou
On 4/30/19 9:52 AM, Alex Bennée wrote:
> Signed-off-by: Alex Bennée
> ---
> accel/tcg/softmmu_template.h | 454 ---
> 1 file changed, 454 deletions(-)
> delete mode 100644 accel/tcg/softmmu_template.h
Why is this separate from patch 7?
r~
On 4/30/19 9:52 AM, Alex Bennée wrote:
> Commit 337f2311f actually claimed to do this in the commit log but
> didn't actually. Oops.
>
> Signed-off-by: Alex Bennée
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 4/30/19 9:52 AM, Alex Bennée wrote:
> Signed-off-by: Alex Bennée
> ---
> Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 4/30/19 9:52 AM, Alex Bennée wrote:
> Add support for generating a single targets coverage report. Execute:
>
> make coverage-report
>
> In the target build directory. This coverage report only cares about
> target specific blobs so only searches the target build subdirectory.
>
> Signed-of
In file included from /usr/include/string.h:494,
from include/qemu/osdep.h:101,
from util/qemu-sockets.c:18:
In function ‘strncpy’,
inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5:
/usr/include/bits/string_fortified.h:106:10: warning: ‘__b
Patchew URL: https://patchew.org/QEMU/20190501144646.4851-1-berra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190501144646.4851-1-berra...@redhat.com
Subject: [Qemu-devel] [PATCH v2] linux-user: avoi
Richard Henderson writes:
> On 4/30/19 9:52 AM, Alex Bennée wrote:
>> +.error:
>> +.string "Terminated by exception.\n"
>
> Put it in .rodata just because we can?
Sure.
>
>> +/* Page table setup (identity mapping). */
>> +adrpx0, ttb
>> +add x0, x0, :lo12:ttb
>
>
On Mon, Apr 29, 2019 at 12:57:41PM +0200, Kevin Wolf wrote:
> make_completely_empty() is an optimisated path for bdrv_make_empty()
> where completely new metadata is created inside the image file instead
> of going through all clusters and discarding them. For an external data
> file, however, we a
Richard Henderson writes:
> On 4/30/19 9:52 AM, Alex Bennée wrote:
>> Signed-off-by: Alex Bennée
>> ---
>> accel/tcg/softmmu_template.h | 454 ---
>> 1 file changed, 454 deletions(-)
>> delete mode 100644 accel/tcg/softmmu_template.h
>
> Why is this separate f
On Tue, Apr 30, 2019 at 10:06 PM Richard Henderson
wrote:
>
> Cc: Max Filippov
> Signed-off-by: Richard Henderson
> ---
> target/xtensa/translate.c | 9 +
> 1 file changed, 1 insertion(+), 8 deletions(-)
Acked-by: Max Filippov
--
Thanks.
-- Max
Yuval Shaia writes:
> On Wed, May 01, 2019 at 08:42:35PM +0800, LI, BO XUAN wrote:
>>On Wed, May 1, 2019 at 4:58 PM Yuval Shaia <[1]yuval.sh...@oracle.com>
>>wrote:
>>
>> On Wed, May 01, 2019 at 04:10:39PM +0800, Boxuan Li wrote:
>> > Signed-off-by: Boxuan Li <[2]libox...@conn
On 4/28/19 5:54 PM, Thomas Huth wrote:
> We are going to enable the qemu-iotests during "make check" again,
> and for running the iotests, we need bash and gnu-sed.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
> ---
> .cirrus.yml | 4 ++--
> .travis.yml | 1 +
> 2 files
On 4/28/19 5:54 PM, Thomas Huth wrote:
> qemu-system-arm, qemu-system-aarch64 and qemu-system-tricore do not have
> a default machine, so when running the qemu-iotests with such a binary,
> lots of tests are failing. Fix it by picking a default machine in the
> "check" script instead.
>
> Signed-o
On 5/1/19 4:12 PM, Richard Henderson wrote:
> On 4/30/19 4:28 PM, Alistair Francis wrote:
>> for (i = 0; i < usbports; i++) {
>> +g_assert(i < MAX(MAXPORTS_2, MAXPORTS_3));
>
> I would hope that it works to move this out of the loop:
>
> g_assert(usbports <= MAX(MAXPORTS_2, MAXPORT
Richard Henderson writes:
> From: David Hildenbrand
>
> Let's add tcg_gen_gvec_3i(), similar to tcg_gen_gvec_2i(), however
> without introducing "gen_helper_gvec_3i *fnoi", as it isn't needed
> for now.
>
> Signed-off-by: David Hildenbrand
> Message-Id: <20190416185301.25344-2-da...@redhat.co
On 5/1/19 4:46 PM, Daniel P. Berrangé wrote:
> In file included from /usr/include/string.h:494,
> from include/qemu/osdep.h:101,
> from linux-user/uname.c:20:
> In function ‘strncpy’,
> inlined from ‘sys_uname’ at linux-user/uname.c:94:3:
> /usr/include/bits/st
On 4/30/19 6:08 PM, John Snow wrote:
>
>
> On 11/20/18 10:15 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 16.11.2018 21:43, John Snow wrote:
>>> Coverity warns that backing_bs() could give us a NULL pointer, which
>>> we then use without checking that it isn't.
>>>
>>> In our loop condition, we che
Richard Henderson writes:
> Use tcg_can_emit_vec_op instead of just TCG_TARGET_HAS_neg_vec,
> so that we check the type and vece for the actual operation.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> tcg/optimize.c | 8 ++--
> 1 file changed, 6 insertions(+), 2
On 5/1/19 8:18 AM, Joel Stanley wrote:
> We currently use Qemu's default of 128MB. As we know how much ram each
> machine ships with, make it easier on users by setting a default.
>
> It can still be overridden with -m on the command line.
>
> Signed-off-by: Joel Stanley
> ---
> hw/arm/aspeed.c
Patchew URL: https://patchew.org/QEMU/20190501144646.4851-1-berra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190501144646.4851-1-berra...@redhat.com
Subject: [Qemu-devel] [PATCH v2] linux-user: avoi
Patchew URL: https://patchew.org/QEMU/20190501061827.23080-1-j...@jms.id.au/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190501061827.23080-1-j...@jms.id.au
Subject: [Qemu-devel] [PATCH] arm: aspeed: Set SDRAM size
On 4/30/19 9:12 PM, Philippe Mathieu-Daudé wrote:
> On 4/30/19 8:13 PM, Cao Jiaxi wrote:
>> Windows ARM64 uses LLP64 model, which breaks current assumptions.
>>
>> Signed-off-by: Cao Jiaxi
>> ---
>> util/cacheinfo.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/util/
On 5/1/19 9:50 AM, Daniel P. Berrangé wrote:
> In file included from /usr/include/string.h:494,
> from include/qemu/osdep.h:101,
> from util/qemu-sockets.c:18:
> In function ‘strncpy’,
> inlined from ‘unix_connect_saddr.isra.0’ at util/qemu-sockets.c:925:5:
> /
Richard Henderson writes:
> Reviewed-by: David Hildenbrand
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> tcg/tcg-op-vec.c | 49
> 1 file changed, 33 insertions(+), 16 deletions(-)
>
> diff --git a/tcg/tcg-op-vec.c b/tc
>>> On 4/30/2019 at 2:40 PM, John Snow wrote:
>
> On 4/30/19 9:19 AM, Bruce Rogers wrote:
>> While investigating link-time-optimization, the compiler flagged this
>> case of not handling the error return from scsi_cdb_length(). Handle
>> this error case with a trace report.
>>
>> Signed-off-by:
On Thu, Apr 25, 2019 at 02:35:03PM +0100, Stefan Hajnoczi wrote:
> At KVM Forum 2018 I gave a presentation on security in QEMU:
> https://www.youtube.com/watch?v=YAdRf_hwxU8 (video)
> https://vmsplice.net/~stefan/stefanha-kvm-forum-2018.pdf (slides)
>
> This patch adds a security guide to the deve
On Thu, Apr 25, 2019 at 02:09:39PM +0100, Stefan Hajnoczi wrote:
> How to use .base_name, .generic_name, .transitional_name, and
> .non_transitional_name can be confusing.
>
> Existing devices have .generic_name but its behavior is somewhat magic.
>
> Devices added to new versions of the VIRTIO s
On Thu, Apr 25, 2019 at 03:54:20PM +0100, Stefan Hajnoczi wrote:
> qemu.org hosts git repository mirrors of all submodules. Update
> .gitmodules to use the mirrors and not the upstream repositories.
>
> Mirroring upstream repositories ensures that QEMU continues to build
> even when upstream repo
On Mon, Apr 29, 2019 at 12:53:48PM +, Joel Stanley wrote:
> On Fri, 26 Apr 2019 at 09:17, Stefan Hajnoczi wrote:
> >
> > A user-friendly error message is needed here. The check for -kernel was
> > too specific and is not desirable for microbit where we use -device
> > loader.
> >
> > Old boar
On Mon, Apr 29, 2019 at 01:58:46PM +0100, Peter Maydell wrote:
> On Mon, 29 Apr 2019 at 13:28, Stefan Hajnoczi wrote:
> >
> > On Fri, Apr 26, 2019 at 12:45:37PM +0100, Peter Maydell wrote:
> > I was going to add a function to check kernel_filename and the presence
> > of -device loader. Then each
On 5/1/19 11:24 AM, Eric Blake wrote:
> On 4/30/19 6:08 PM, John Snow wrote:
>>
>>
>> On 11/20/18 10:15 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> 16.11.2018 21:43, John Snow wrote:
Coverity warns that backing_bs() could give us a NULL pointer, which
we then use without checking that
On Mon, Apr 29, 2019 at 10:56:31AM -0700, Wei Li wrote:
> Does this mean the performance could be improved via adding Batch I/O
> submission support in Guest driver side which will be able to reduce the
> number of virtqueue kicks?
Yes, I think so. It's not obvious to me how a Linux SCSI driver
Thomas Huth writes:
> Currently, all tests are in the "auto" group. This is a little bit pointless.
> OTOH, we need a group for the tests that we can automatically run during
> "make check" each time, too. Tests in this new group are supposed to run
> with every possible QEMU configuration, for
On Tue, Apr 30, 2019 at 02:10:14PM +0800, Jie Wang wrote:
> remove the dead code
>
> Signed-off-by: Jie Wang
> ---
> hw/virtio/vhost.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On Tue, Apr 30, 2019 at 03:15:00PM +0800, Jie Wang wrote:
> fix memory leak in vhost_user_scsi_realize
>
> Signed-off-by: Jie Wang
> ---
> hw/scsi/vhost-user-scsi.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On Tue, Apr 30, 2019 at 07:38:59PM -0400, Michael S. Tsirkin wrote:
> On Wed, May 01, 2019 at 01:11:34AM +0200, Paolo Bonzini wrote:
> > On 01/05/19 00:50, Michael S. Tsirkin wrote:
> > >> Stefan, did you hit a build failure, or it was just theoretical?
> > >>
> > >> linux-headers/*/mman.h is updat
While investigating link-time-optimization, the compiler complained as
follows:
In function ‘scsi_disk_new_request_dump’,
inlined from ‘scsi_new_request.part.24’ at hw/scsi/scsi-disk.c:2549:9,
inlined from ‘scsi_new_request’ at hw/scsi/scsi-disk.c:2533:21:
hw/scsi/scsi-disk.c:2523:19: error
On 5/1/19 1:01 PM, Bruce Rogers wrote:
> While investigating link-time-optimization, the compiler complained as
> follows:
> In function ‘scsi_disk_new_request_dump’,
> inlined from ‘scsi_new_request.part.24’ at hw/scsi/scsi-disk.c:2549:9,
> inlined from ‘scsi_new_request’ at hw/scsi/scs
On Tue, Apr 30, 2019 at 04:53:08PM +0200, Marc-André Lureau wrote:
> Hi
>
> On Thu, Apr 25, 2019 at 4:54 PM Stefan Hajnoczi wrote:
> >
> > qemu.org hosts git repository mirrors of all submodules. Update
> > .gitmodules to use the mirrors and not the upstream repositories.
> >
> > Mirroring upstr
On Thu, 25 Apr 2019 10:32:43 PDT (-0700), richard.hender...@linaro.org wrote:
On 4/25/19 10:26 AM, Richard Henderson wrote:
{
+ illegal 011 0 - 0 01 # c.addi16sp, RES nzimm=0
addi011 . 00010 . 01 @c_addi16sp
lui 011 . . . 01 @c_lu
On Thu, 25 Apr 2019 10:26:35 PDT (-0700), richard.hender...@linaro.org wrote:
---
target/riscv/translate.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/target/riscv/translate.c b/target/riscv/translate.c
index d1f599a92d..009c146e8f 100644
--- a/target/riscv
On Tue, Apr 30, 2019 at 06:27:03PM +0100, Peter Maydell wrote:
> For the moment I'd like to ask for in-principle volunteers
> to be on the release-handling rota.
I am willing to handle one release per year.
Stefan
signature.asc
Description: PGP signature
Richard Henderson writes:
> Replace the single opcode in .opc with a null-terminated
> array in .opt_opc. We still require that all opcodes be
> used with the same .vece.
>
> Validate the contents of this list with CONFIG_DEBUG_TCG.
> All tcg_gen_*_vec functions will check any list active
> du
On Tue, Apr 30, 2019 at 07:48:16PM -0300, Eduardo Habkost wrote:
> On Tue, Apr 30, 2019 at 10:36:18PM +, Wei Yang wrote:
> [...]
> > >> +#ifdef CONFIG_LINUX
> > >> +#include
> > >> +#endif /* CONFIG_LINUX */
> > >> +
> > >> +#ifndef MAP_SYNC
> > >> +#define MAP_SYNC 0
> > >> +#endif
> > >> +#i
Richard Henderson writes:
> The only fixed_reg is cpu_env, and it should not be modified
> during any TB. Therefore code that tries to special-case moves
> into a fixed_reg is dead. Remove it.
>
> Reviewed-by: David Hildenbrand
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Richard Henderson writes:
> This patch merely changes the interface, aborting on all failures,
You say this but...
>
> -static inline void tcg_out_mov(TCGContext *s, TCGType type,
> +static inline bool tcg_out_mov(TCGContext *s, TCGType type,
> TCGReg ret, TCG
1 - 100 of 158 matches
Mail list logo
