[Qemu-devel] [PULL 15/15] tests: fw_cfg: add 'splash-time' test case

2019-05-23 Thread Philippe Mathieu-Daudé
From: Li Qiang Signed-off-by: Li Qiang Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20190424140643.62457-6-liq...@163.com> Signed-off-by: Philippe Mathieu-Daudé --- tests/fw_cfg-test.c | 20 1 file changed, 20

[Qemu-devel] [PULL 13/15] hw/nvram/fw_cfg: Store 'reboot-timeout' as little endian

2019-05-23 Thread Philippe Mathieu-Daudé
From: Li Qiang The current codebase is not specific about the endianess of the fw_cfg 'file' entry 'reboot-timeout'. Per docs/specs/fw_cfg.txt: === All Other Data Items === Please consult the QEMU source for the most up-to-date and authoritative list of selector keys and their respective

Re: [Qemu-devel] [PATCH 2/2] target/arm: Use tcg_gen_gvec_bitsel

2019-05-23 Thread Peter Maydell
On Sat, 18 May 2019 at 20:19, Richard Henderson wrote: > > This replaces 3 target-specific implementations for BIT, BIF, and BSL. > > Signed-off-by: Richard Henderson > @@ -10916,13 +10925,13 @@ static void disas_simd_3same_logic(DisasContext *s, > uint32_t insn) > return; > > case

[Qemu-devel] [PULL 10/15] tests/fw_cfg: Free QFWCFG object after qtest has run

2019-05-23 Thread Philippe Mathieu-Daudé
We allocate the QFWCFG object previous to run the qtests, free it once we are finished. Signed-off-by: Li Qiang Message-Id: <20190424140643.62457-2-liq...@163.com> Reviewed-by: Philippe Mathieu-Daudé [PMD: Split patch, fill commit description] Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

Re: [Qemu-devel] [PATCH v14 1/1] qcow2: skip writing zero buffers to empty COW areas

2019-05-23 Thread Anton Nefedov
On 22/5/2019 11:40 PM, Max Reitz wrote: > On 16.05.19 16:27, Anton Nefedov wrote: >> If COW areas of the newly allocated clusters are zeroes on the backing >> image, efficient bdrv_write_zeroes(flags=BDRV_REQ_NO_FALLBACK) can be >> used on the whole cluster instead of writing explicit zero buffers

Re: [Qemu-devel] [PATCH v2 0/3] aspeed: cleanups and extensions

2019-05-23 Thread Peter Maydell
On Mon, 20 May 2019 at 17:32, Philippe Mathieu-Daudé wrote: > > On 5/20/19 3:32 PM, Cédric Le Goater wrote: > >> Peter, > >> > >> do you want me to resend with only the two first patches and include > >> Joel's in the same series ? I would leave out the part Philippe is > >> covering in his object

Re: [Qemu-devel] [PATCH v2 3/4] iotests.py: rewrite run_job to be pickier

2019-05-23 Thread Max Reitz
On 10.05.19 21:03, John Snow wrote: > Don't pull events out of the queue that don't belong to us; > be choosier so that we can use this method to drive jobs that > were launched by transactions that may have more jobs. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/iotests.py | 32 +

Re: [Qemu-devel] [PATCH 3/3] capstone: Enable disassembly for s390x

2019-05-23 Thread Richard Henderson
On 5/23/19 4:27 AM, David Hildenbrand wrote: > On 23.05.19 04:42, Richard Henderson wrote: >> Enable s390x, aka SYSZ, in the git submodule build. >> Set the capstone parameters for both s390x host and guest. >> Install a skipdata hook to keep capstone in sync with the >> instruction stream for unkn

Re: [Qemu-devel] [PATCH v1 1/5] s390x/tcg: Implement VECTOR FIND ANY ELEMENT EQUAL

2019-05-23 Thread David Hildenbrand
On 23.05.19 14:27, Richard Henderson wrote: > On 5/23/19 3:50 AM, David Hildenbrand wrote: >> /* >> * Returns the number of bits composing one element. >> */ >> static uint8_t get_element_bits(uint8_t es) >> { >> return (1 << es) * BITS_PER_BYTE; >> } >> >> /* >> * Returns the bitmask for a

Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1

2019-05-23 Thread Laurent Vivier
On 23/05/2019 13:56, Cornelia Huck wrote: > On Wed, 22 May 2019 15:22:23 +0200 > Aleksandar Markovic wrote: > >> The alternative way of invoking via IPCV6 (else part of “ifdef >> __NR_MSGSND”) should work for MIPS in the present stage of headers and >> kernel. > > I tried to do that so that we h

Re: [Qemu-devel] [PATCH v1 1/5] s390x/tcg: Implement VECTOR FIND ANY ELEMENT EQUAL

2019-05-23 Thread Richard Henderson
On 5/23/19 3:50 AM, David Hildenbrand wrote: > /* > * Returns the number of bits composing one element. > */ > static uint8_t get_element_bits(uint8_t es) > { > return (1 << es) * BITS_PER_BYTE; > } > > /* > * Returns the bitmask for a single element. > */ > static uint64_t get_single_elem

[Qemu-devel] [PATCH v2 4/5] s390: vfio_pci: Use a PCI Function structure

2019-05-23 Thread Pierre Morel
We use a ClpRspQueryPci structure to hold the information related to zPCI Function. This allows us to be ready to support different zPCI functions and to retrieve the zPCI function information from the host. Signed-off-by: Pierre Morel --- hw/s390x/s390-pci-bus.c | 22 +- h

[Qemu-devel] [PATCH v2 3/5] s390: vfio_pci: Use a PCI Group structure

2019-05-23 Thread Pierre Morel
We use a S390PCIGroup structure to hold the information related to zPCI Function group. This allows us to be ready to support multiple groups and to retrieve the group information from the host. Signed-off-by: Pierre Morel --- hw/s390x/s390-pci-bus.c | 42 ++

[Qemu-devel] [PATCH v2 1/5] vfio: vfio_iommu_type1: linux header place holder

2019-05-23 Thread Pierre Morel
This should be copied from Linux kernel UAPI includes. The version used here is Linux 5.1.0 We define a new device region in vfio.h to be able to get the ZPCI CLP information by reading this region from userland. We create a new file, vfio_zdev.h to define the structure of the new region we defin

[Qemu-devel] [PATCH v2 0/5] Retrieving zPCI specific info from QEMU

2019-05-23 Thread Pierre Morel
This patch implement the QEMU part to retrieve ZPCI specific information from the host. The Linux part has been posted on a separate patch on the LKML. Subject: [PATCH 0/4] Retrieving zPCI specific info with VFIO Message-Id: <1557476555-20256-1-git-send-email-pmo...@linux.ibm.com> We use the

[Qemu-devel] [PATCH v2 5/5] s390: vfio_pci: Get zPCI function info from host

2019-05-23 Thread Pierre Morel
We use the VFIO_REGION_SUBTYPE_ZDEV_CLP subregion of PCI_VENDOR_ID_IBM to retrieve the CLP information the kernel exports. To be compatible with previous kernel versions we fall back on previous predefined values, same as the emulation values, when the region is not found or when any problem happe

[Qemu-devel] [PATCH v2 2/5] s390: PCI: Creation a header dedicated to PCI CLP

2019-05-23 Thread Pierre Morel
To have a clean separation between s390-pci-bus.h and s390-pci-inst.h headers we export the PCI CLP instructions in a dedicated header. Signed-off-by: Pierre Morel Reviewed-by: Collin Walling --- hw/s390x/s390-pci-bus.h | 1 + hw/s390x/s390-pci-clp.h | 211 ++

Re: [Qemu-devel] Introducing GSoC project: API Documentation Generation

2019-05-23 Thread John Snow
On 5/22/19 4:20 AM, Paolo Bonzini wrote: > On 21/05/19 22:37, Eduardo Habkost wrote: >>> But this is the one we're going with? Do we have a plan for teaching it >>> not to panic for our use of named custom types? >> >> If I understood correctly, the patch from Paolo that I have >> forwarded to t

[Qemu-devel] [PATCH v2 1/2] sphinx: add qmp_lexer

2019-05-23 Thread John Snow
Sphinx, through Pygments, does not like annotated json examples very much. In some versions of Sphinx (1.7), it will render the non-json portions of code blocks in red, but in newer versions (2.0) it will throw an exception and not highlight the block at all. Though we can suppress this warning, it

[Qemu-devel] [PATCH v2 0/2] Add QMP lexer for annotated JSON to Sphinx

2019-05-23 Thread John Snow
QMP isn't json. It turns out Pygments cares about this. Teach Pygments to go with the annotated flow. V2: - Change GPL2 to GPLv2+ (Peter Maydell) - Change "highlights" to "lexes" in docstrings - Fix typo ("Sphinx()" => "Sphinx") in docstring Reported-by: Aarushi Mehta John Snow (2): sphinx

[Qemu-devel] [PATCH v2 2/2] docs/bitmaps: use QMP lexer instead of json

2019-05-23 Thread John Snow
The annotated style json we use in QMP documentation is not strict json and depending on the version of Sphinx (2.0+) or Pygments installed, might cause the build to fail. Use the new QMP lexer. Further, some versions of Sphinx can not apply custom lexers to "code" directives and require the use

Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent

2019-05-23 Thread Peter Maydell
On Thu, 23 May 2019 at 13:09, Markus Armbruster wrote: > Registering qbus_reset_all_fn() in main() is kind of ugly, but it works. > There's a comment pointing out it's ugly. Right now it's a TODO > comment, which maybe expresses more hope for cleanup than there really > is. I'd leave it alone an

Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent

2019-05-23 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 23 May 2019 at 07:39, Markus Armbruster wrote: >> >> Peter Maydell writes: >> > It's a well-defined order, but it doesn't actually help in a >> > lot of cases, because often the thing you care about ordering >> > on is not a device or is not in the same tree as t

Re: [Qemu-devel] [PATCH v2] qga: check length of command-line & environment variables

2019-05-23 Thread Marc-André Lureau
Hi On Thu, May 23, 2019 at 9:54 AM P J P wrote: > > +-- On Wed, 22 May 2019, Marc-André Lureau wrote --+ > | On Sun, May 19, 2019 at 10:55 AM P J P wrote: > | > Qemu guest agent while executing user commands does not seem to > | > check length of argument list and/or environment variables passed

Re: [Qemu-devel] Running linux on qemu omap

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 1:27 PM, Thomas Huth wrote: > On 22/05/2019 20.19, Aaro Koskinen wrote: >> Hi, >> >> On Wed, May 22, 2019 at 11:33:41AM +0200, Corentin Labbe wrote: >>> qemu-system-arm -M help |grep OMAP >>> cheetah Palm Tungsten|E aka. Cheetah PDA (OMAP310) >>> n800 Nokia N

Re: [Qemu-devel] custom virt-io support (in user-mode-linux)

2019-05-23 Thread Stefan Hajnoczi
On Wed, May 22, 2019 at 03:02:38PM +0200, Johannes Berg wrote: > Hi, > > While my main interest is mostly in UML right now [1] I've CC'ed the > qemu and virtualization lists because something similar might actually > apply to other types of virtualization. > > I'm thinking about adding virt-io su

Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1

2019-05-23 Thread Cornelia Huck
On Wed, 22 May 2019 15:22:23 +0200 Aleksandar Markovic wrote: > The alternative way of invoking via IPCV6 (else part of “ifdef > __NR_MSGSND”) should work for MIPS in the present stage of headers and > kernel. I tried to do that so that we have at least a workaround for now; but this fails build

Re: [Qemu-devel] [PULL 0/9] Trivial branch patches

2019-05-23 Thread Peter Maydell
On Wed, 22 May 2019 at 17:13, Laurent Vivier wrote: > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into > staging (2019-05-21 16:30:13 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] aspeed qemu question

2019-05-23 Thread Wim Vervoorn
Hello Cédric, How stupid of me. I overlooked that the SPI is for the host flash device. The remainder of the solution was clear and understood. Best regards and thanks for the quick response, Wim -Original Message- From: Cédric Le Goater [mailto:c...@kaod.org] Sent: Thursday, May 23,

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-05-23 Thread Stefan Hajnoczi
On Tue, May 07, 2019 at 02:00:59PM -0700, Elena Ufimtseva wrote: > On Mon, Mar 11, 2019 at 10:20:06AM +, Daniel P. Berrangé wrote: > > On Thu, Mar 07, 2019 at 03:29:41PM -0800, John G Johnson wrote: > > > > > > > > Hi Daniel, Stefan > > We have not replied in a while as we were trying to fi

Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes

2019-05-23 Thread Laszlo Ersek
Hi Peter, On 05/22/19 23:15, Peter Maydell wrote: > On Wed, 22 May 2019 at 15:22, Laszlo Ersek wrote: >> This is very interesting. I had obviously tested booting >> "bios-tables-test.aarch64.iso.qcow2" against "edk2-aarch64-code.fd", >> using TCG, on my x86_64 laptop. (And, I've run the above exa

Re: [Qemu-devel] [PATCH 1/3] capstone: Adjust include of capstone.h

2019-05-23 Thread Alex Bennée
Daniel P. Berrangé writes: > On Wed, May 22, 2019 at 10:42:27PM -0400, Richard Henderson wrote: >> Since v4.0, capstone.h has moved to . > > NB this was a regression bug in capstone pkg-config file which has been > fixed upstream > >https://github.com/aquynh/capstone/pull/1276 > > In Fedora

Re: [Qemu-devel] [PATCH 1/3] capstone: Adjust include of capstone.h

2019-05-23 Thread Daniel P . Berrangé
On Thu, May 23, 2019 at 01:17:40PM +0200, Philippe Mathieu-Daudé wrote: > On 5/23/19 1:07 PM, Daniel P. Berrangé wrote: > > On Wed, May 22, 2019 at 10:42:27PM -0400, Richard Henderson wrote: > >> Since v4.0, capstone.h has moved to . > > > > NB this was a regression bug in capstone pkg-config file

Re: [Qemu-devel] Running linux on qemu omap

2019-05-23 Thread Thomas Huth
On 22/05/2019 20.19, Aaro Koskinen wrote: > Hi, > > On Wed, May 22, 2019 at 11:33:41AM +0200, Corentin Labbe wrote: >> qemu-system-arm -M help |grep OMAP >> cheetah Palm Tungsten|E aka. Cheetah PDA (OMAP310) >> n800 Nokia N800 tablet aka. RX-34 (OMAP2420) >> n810

Re: [Qemu-devel] [RFC PATCH 0/2] establish nesting rule of BQL vs cpu-exclusive

2019-05-23 Thread Alex Bennée
Roman Kagan writes: > I came across the following AB-BA deadlock: > > vCPU thread main thread > --- --- > async_safe_run_on_cpu(self, > async_synic_update) > ...

Re: [Qemu-devel] [PATCH 1/3] capstone: Adjust include of capstone.h

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 1:07 PM, Daniel P. Berrangé wrote: > On Wed, May 22, 2019 at 10:42:27PM -0400, Richard Henderson wrote: >> Since v4.0, capstone.h has moved to . > > NB this was a regression bug in capstone pkg-config file which has been > fixed upstream > >https://github.com/aquynh/capstone/pull/1

Re: [Qemu-devel] [PATCH 2/3] capstone: Update to master

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 4:42 AM, Richard Henderson wrote: > Update to fbb20ea83c5a. Choose this over the 4.0.1 tag because > master now includes the s390x z13 vector opcodes. Cool! I was watching few fixed issues on the capstone repo, which are now fixed in QEMU too :) Various riscv/arm64 improvement too. >

Re: [Qemu-devel] aspeed qemu question

2019-05-23 Thread Cédric Le Goater
On 5/23/19 12:05 PM, Wim Vervoorn wrote: > Hello Cédric, > > I have another question regarding the ASPEED Qemu support. This is regarding > the SPI support. > > I noticed that in general the fmc_model and the spi_model for the flash device > are different even though there is only one flash devi

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-05-23 Thread Stefan Hajnoczi
Hi Jag and Elena, Do you think a call would help to move discussion along more quickly? We could use the next KVM Community Call on June 4th to discuss remaining concerns and the next steps: https://calendar.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZXZwNzRoMHE4a3BqcXNAZ3JvdXAuY2FsZW5kYXIuZ29v

Re: [Qemu-devel] [PATCH 1/3] capstone: Adjust include of capstone.h

2019-05-23 Thread Daniel P . Berrangé
On Wed, May 22, 2019 at 10:42:27PM -0400, Richard Henderson wrote: > Since v4.0, capstone.h has moved to . NB this was a regression bug in capstone pkg-config file which has been fixed upstream https://github.com/aquynh/capstone/pull/1276 In Fedora we pulled in the fix to our v4.0 builds and

Re: [Qemu-devel] [PULL 0/5] Miscellaneous patches for 2019-05-22

2019-05-23 Thread Peter Maydell
On Wed, 22 May 2019 at 14:51, Markus Armbruster wrote: > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into > staging (2019-05-21 16:30:13 +0100) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH 1/3] capstone: Adjust include of capstone.h

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 4:42 AM, Richard Henderson wrote: > Since v4.0, capstone.h has moved to . > > Signed-off-by: Richard Henderson > --- > include/disas/capstone.h | 4 > configure| 6 ++ > 2 files changed, 10 insertions(+) > > diff --git a/include/disas/capstone.h b/include/dis

Re: [Qemu-devel] [PATCH v1 1/5] s390x/tcg: Implement VECTOR FIND ANY ELEMENT EQUAL

2019-05-23 Thread Alex Bennée
David Hildenbrand writes: > On 22.05.19 13:09, Richard Henderson wrote: >> On 5/22/19 7:01 AM, David Hildenbrand wrote: >>> I also think that, if we create a bunch more of these wrappers: > +DEF_VFAE_HELPER(8) > +DEF_VFAE_HELPER(16) > +DEF_VFAE_HELPER(32) then RT

[Qemu-devel] [RFC PATCH 2/2] cpus-common: assert BQL nesting within cpu-exclusive sections

2019-05-23 Thread Roman Kagan
Assert that the cpu-exclusive sections are never entered/left with the BQL taken. Signed-off-by: Roman Kagan --- cpus-common.c | 4 1 file changed, 4 insertions(+) diff --git a/cpus-common.c b/cpus-common.c index 023cfebfa3..9aa75fe1ba 100644 --- a/cpus-common.c +++ b/cpus-common.c @@ -174

Re: [Qemu-devel] [PATCH v10 00/20] gdbstub: Refactor command packets handler

2019-05-23 Thread Alex Bennée
Jon Doron writes: > This patch series refactors the old gdbstub command packets handler > with a new infrastructure which should ease extending and adding new > and missing gdb command packets. > > version 10 changes: > - Remove kvm added API as this is not really required and can be > accomp

[Qemu-devel] [RFC PATCH 1/2] cpus-common: nuke finish_safe_work

2019-05-23 Thread Roman Kagan
It was introduced in commit b129972c8b41e15b0521895a46fd9c752b68a5e, with the following motivation: Because start_exclusive uses CPU_FOREACH, merge exclusive_lock with qemu_cpu_list_lock: together with a call to exclusive_idle (via cpu_exec_start/end) in cpu_list_add, this protects exclusive

[Qemu-devel] [PATCH v2 21/28] tests/tcg/alpha: add system boot.S

2019-05-23 Thread Alex Bennée
From: Richard Henderson This provides the bootstrap and low level helper functions for an alpha kernel. We use direct access to the DP264 serial port for test output, and hard machine halt to exit the emulation. Signed-off-by: Richard Henderson Message-Id: <20190501184306.15208-1-richard.hende

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-05-23 Thread Stefan Hajnoczi
On Tue, May 07, 2019 at 03:00:52PM -0400, Jag Raman wrote: > Hi Stefan, > > Thank you very much for your feedback. Following is a summary of the > discussions our team had regarding your feedback. > > On 4/25/2019 11:44 AM, Stefan Hajnoczi wrote: > > > > Can multiple LSI SCSI controllers be laun

[Qemu-devel] [RFC PATCH 0/2] establish nesting rule of BQL vs cpu-exclusive

2019-05-23 Thread Roman Kagan
I came across the following AB-BA deadlock: vCPU thread main thread --- --- async_safe_run_on_cpu(self, async_synic_update) ... [cpu hot-add] process_queued

[Qemu-devel] [PATCH v2 26/28] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

2019-05-23 Thread Alex Bennée
From: Thomas Huth Currently, all tests are in the "auto" group. This is a little bit pointless. OTOH, we need a group for the tests that we can automatically run during "make check" each time, too. Tests in this new group are supposed to run with every possible QEMU configuration, for example the

[Qemu-devel] [PATCH v2 12/28] tests/docker: add ubuntu 18.04

2019-05-23 Thread Alex Bennée
From: Gerd Hoffmann Based on the ubuntu.docker file. Used to reproduce the build failure Peter was seeing. Others might find this useful too ;) Signed-off-by: Gerd Hoffmann Message-Id: <20190503070241.24786-1-kra...@redhat.com> Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé Revi

[Qemu-devel] [PATCH v2 19/28] tests/tcg/minilib: support %c format char

2019-05-23 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- tests/tcg/minilib/printf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/tcg/minilib/printf.c b/tests/tcg/minilib/printf.c index 121620cb162..10472b4f585 100644 --- a/tests/tcg/minilib/printf.c +++ b/tests/tcg/minilib/p

[Qemu-devel] [PATCH v2 28/28] tests: Run the iotests during "make check" again

2019-05-23 Thread Alex Bennée
From: Thomas Huth People often forget to run the iotests before submitting patches or pull requests - this is likely due to the fact that we do not run the tests during our mandatory "make check" tests yet. Now that we've got a proper "auto" group of iotests that should be fine to run in every en

[Qemu-devel] [PATCH v2 23/28] Makefile: fix coverage-report reference to BUILD_DIR

2019-05-23 Thread Alex Bennée
Commit 337f2311f actually claimed to do this in the commit log but didn't actually. Oops. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 155f066a206..40561993c40 100644 --- a/Ma

[Qemu-devel] [PATCH v2 24/28] Makefile: include per-target build directories in coverage report

2019-05-23 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 40561993c40..e8a886aac79 100644 --- a/Makefile +++ b/Makefile @@ -998,7 +998,9 @@ $(filter %.1 %.7 %.8,$(DOCS)): scripts/texi2po

[Qemu-devel] [PATCH v2 25/28] Makefile.target: support per-target coverage reports

2019-05-23 Thread Alex Bennée
Add support for generating a single targets coverage report. Execute: make coverage-report In the target build directory. This coverage report only cares about target specific blobs so only searches the target build subdirectory. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson ---

[Qemu-devel] [PATCH v2 27/28] tests/qemu-iotests: re-format output to for make check-block

2019-05-23 Thread Alex Bennée
This attempts to clean-up the output to better match the output of the rest of the QEMU check system when called with -makecheck. This includes: - formatting as " TESTiotest-FMT: nnn" - only dumping config on failure (when -makecheck enabled) The non-make check output has been cleaned up

[Qemu-devel] [PATCH 5/7] hmp: Handle virtio-pmem when printing memory device infos

2019-05-23 Thread Pankaj Gupta
From: David Hildenbrand Print the memory device info just like for PCDIMM/NVDIMM. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: David Hildenbrand --- hmp.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/hmp.c b/hmp.c index 92941142af..e1

[Qemu-devel] [PATCH 4/7] virtio-pci: Proxy for virtio-pmem

2019-05-23 Thread Pankaj Gupta
We need a proxy device for virtio-pmem, and this device has to be the actual memory device so we can cleanly hotplug it. Forward memory device class functions either to the actual device or use properties of the virtio-pmem device to implement these in the proxy. virtio-pmem will only be compiled

[Qemu-devel] [PATCH 3/7] virtio-pmem: sync linux headers

2019-05-23 Thread Pankaj Gupta
Sync linux headers for virtio pmem. Signed-off-by: Pankaj Gupta --- include/standard-headers/linux/virtio_ids.h | 1 + include/standard-headers/linux/virtio_pmem.h | 35 2 files changed, 36 insertions(+) create mode 100644 include/standard-headers/linux/virtio_pme

[Qemu-devel] [PATCH v2 22/28] .travis.yml: enable aarch64-softmmu and alpha-softmmu tcg tests

2019-05-23 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 6fd89b3d915..b053a836a32 100644 --- a/.travis.yml +++ b/.travis.yml @@ -284,5 +284,5 @@ matrix: # Run check-tcg aga

[Qemu-devel] [PATCH v2 20/28] tests/tcg/multiarch: expand system memory test to cover more

2019-05-23 Thread Alex Bennée
Expand the memory test to cover move of the softmmu code. Specifically we: - improve commentary - add some helpers (for later BE support) - reduce boiler plate into helpers - add signed reads at various sizes/offsets - required -DCHECK_UNALIGNED Signed-off-by: Alex Bennée Reviewed-by:

[Qemu-devel] [PATCH v2 18/28] tests/tcg/multiarch: move the system memory test

2019-05-23 Thread Alex Bennée
There is nothing inherently architecture specific about the memory test although we may have to manage different restrictions of unaligned access across architectures. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- tests/tcg/{i386 => multiarch}/system/memory.c | 0 1 file changed

[Qemu-devel] [PATCH 6/7] numa: Handle virtio-pmem in NUMA stats

2019-05-23 Thread Pankaj Gupta
From: David Hildenbrand Account the memory to node 0 for now. Once (if ever) virtio-pmem supports NUMA, we can account it to the right node. Signed-off-by: David Hildenbrand --- numa.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/numa.c b/numa.

[Qemu-devel] [PATCH v2 14/28] tests/tcg/multiarch: add support for multiarch system tests

2019-05-23 Thread Alex Bennée
We can certainly support some common tests for system emulation that make use of our minimal defined boot.S support. It will still be up to individual architectures to ensure they build so we provide a MULTIARCH_TESTS variable that they can tack onto TESTS themselves. Signed-off-by: Alex Bennée R

[Qemu-devel] [PATCH v2 05/28] target/arm: fixup some of the commentary for arm-semi

2019-05-23 Thread Alex Bennée
This cleans up a number of the block comments to fit the proper style. While we are at it we also reference the official specification and document what the return register value can be. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- target/arm/arm-semi.c | 40 ++

[Qemu-devel] [PATCH 1/7] virtio-pmem: add virtio device

2019-05-23 Thread Pankaj Gupta
This is the implementation of virtio-pmem device. Support will require machine changes for the architectures that will support it, so it will not yet be compiled. It can be unlocked with VIRTIO_PMEM_SUPPORTED per machine and disabled globally via VIRTIO_PMEM. We cannot use the "addr" property as t

[Qemu-devel] [PATCH 7/7] pc: Support for virtio-pmem-pci

2019-05-23 Thread Pankaj Gupta
From: David Hildenbrand Override the device hotplug handler to properly handle the memory device part via virtio-pmem-pci callbacks from the machine hotplug handler and forward to the actual PCI bus hotplug handler. As PCI hotplug has not been properly factored out into hotplug handlers, most ma

[Qemu-devel] [PATCH 2/7] virtio-pci: Allow to specify additional interfaces for the base type

2019-05-23 Thread Pankaj Gupta
From: David Hildenbrand Let's allow to specify additional interfaces for the base type (e.g. later TYPE_MEMORY_DEVICE), something that was possible before the rework of virtio PCI device instantiation. Reviewed-by: Cornelia Huck Signed-off-by: David Hildenbrand --- hw/virtio/virtio-pci.c | 1

[Qemu-devel] [PATCH v2 03/28] semihosting: implement a semihosting console

2019-05-23 Thread Alex Bennée
This provides two functions for handling console output that handle the common backend behaviour for semihosting. Signed-off-by: Alex Bennée --- gdbstub.c| 5 +++ hw/semihosting/Makefile.objs | 1 + hw/semihosting/console.c | 70 +

[Qemu-devel] [PATCH v2 16/28] editorconfig: add settings for .s/.S files

2019-05-23 Thread Alex Bennée
We are starting to add assembler foe tests/tcg so lets make sure we get the mode right. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- .editorconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/.editorconfig b/.editorconfig index 15828833938..df6db65531d 100644 --- a/

[Qemu-devel] [PATCH v2 13/28] tests/docker: Test more components on the Fedora default image

2019-05-23 Thread Alex Bennée
From: Philippe Mathieu-Daudé Install optional dependencies of QEMU to get better coverage. The following components are now enabled: $ ./configure ... Multipath support yes VNC SASL support yes RDMA support yes PVRDMA supportyes libiscsi support yes seccomp support

[Qemu-devel] [PATCH v2 09/28] target/mips: only build mips-semi for softmmu

2019-05-23 Thread Alex Bennée
The is_uhi gates all semihosting calls and always returns false for CONFIG_USER_ONLY builds. There is no reason to build and link mips-semi for these builds so lets fix that. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic --- target/mips/Makefil

[Qemu-devel] [PATCH v2 07/28] target/arm: add LOG_UNIMP messages to arm-semi

2019-05-23 Thread Alex Bennée
Clean-up our unimplemented bits with a proper message. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- target/arm/arm-semi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/arm/arm-semi.c b/target/arm/arm-semi.c index 253c66b172a..a3bbef18ef7 1

[Qemu-devel] [PATCH v2 15/28] tests/tcg/multiarch: add hello world system test

2019-05-23 Thread Alex Bennée
This is not really i386 only, we can have the same test for all architectures supporting system tests. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- tests/tcg/i386/Makefile.softmmu-target | 2 +- tests/tcg/{i386 => multiarch}/system/hello.c | 0 2 files changed, 1 insertio

[Qemu-devel] [PATCH v2 11/28] MAINTAINERS: update for semihostings new home

2019-05-23 Thread Alex Bennée
Seeing as I touched it I should at least keep an eye on it. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a6948ebc63b..c4f209898a9 100644 --- a/MAINTAINERS +++ b/MAINTAINE

[Qemu-devel] [PATCH v2 08/28] target/arm: correct return values for WRITE/READ in arm-semi

2019-05-23 Thread Alex Bennée
The documentation says the write should return the number of bytes not written on an error (0 means everything was written). Read provides a buffer length and the return value should be the buffer length - bytes actually read. Remove the incorrect FIXME's and return the correct values. Signed-off-

[Qemu-devel] [PATCH v2 04/28] semihosting: enable chardev backed output for console

2019-05-23 Thread Alex Bennée
It will be useful for a number of use-cases to be able to re-direct output to a file like we do with serial output. This does the wiring to allow us to treat then semihosting console like just another character output device. Signed-off-by: Alex Bennée --- hw/semihosting/config.c | 26

[Qemu-devel] [PATCH v2 10/28] target/mips: convert UHI_plog to use common semihosting code

2019-05-23 Thread Alex Bennée
Rather than printing directly to stdout lets use our common semihosting code. There is one minor difference in that the output currently defaults to stderr instead of stdout however this can be controlled by connecting semihosting to a chardev. Signed-off-by: Alex Bennée Reviewed-by: Aleksandar M

[Qemu-devel] [PATCH v2 06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi

2019-05-23 Thread Alex Bennée
Now we have a common semihosting console interface use that for our string output. However ARM is currently unique in also supporting semihosting for linux-user so we need to replicate the API in linux-user. If other architectures gain this support we can move the file later. Signed-off-by: Alex B

[Qemu-devel] [PATCH 0/7] Qemu virtio pmem device

2019-05-23 Thread Pankaj Gupta
This patch series has implementation for "virtio pmem" device. "virtio pmem" is persistent memory(nvdimm) device in guest which allows to bypass the guest page cache. This also implements a VIRTIO based asynchronous flush mechanism. Details of project idea for 'virtio pmem' flushing interfa

[Qemu-devel] [PATCH v2 01/28] semihosting: move semihosting configuration into its own directory

2019-05-23 Thread Alex Bennée
In preparation for having some more common semihosting code let's excise the current config magic from vl.c into its own file. We shall later add more conditionals to the build configurations so we can avoid building this if we don't need it. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathi

[Qemu-devel] [PATCH v2 17/28] tests/tcg/aarch64: add system boot.S

2019-05-23 Thread Alex Bennée
This provides the bootstrap and low level helper functions for an aarch64 kernel. We use semihosting to handle test output and exiting the emulation. semihosting's parameter passing is a little funky so we end up using the stack and pointing to that as the parameter block. Signed-off-by: Alex Benn

[Qemu-devel] [PATCH v2 00/28] current testing/next queue

2019-05-23 Thread Alex Bennée
Hi, This is the current status of my testing/next tree. I had to delay sending a PR as I refactored the semihosting changes (used by softmmu tests) to be more generic. I've also addressed comments and merged in Kevin's tweaks to the iotest check script. The following patches still need review

[Qemu-devel] [PATCH v2 02/28] semihosting: introduce CONFIG_SEMIHOSTING

2019-05-23 Thread Alex Bennée
There isn't much point building semihosting for platforms that don't support it. Introduce a new symbol and enable it only for the softmmu targets that need it. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- default-configs/arm-softmmu.mak

Re: [Qemu-devel] [PATCH] vmstate: Add VMSTATE_OPAQUE to save/load complex data structures

2019-05-23 Thread Dr. David Alan Gilbert
* rkir--- via Qemu-devel (qemu-devel@nongnu.org) wrote: > From: Roman Kiryanov > > VMSTATE_OPAQUE allows passing user defined functions to save > and load vmstate for cases when data structures do not fit > into int/struct/array terms. > > Signed-off-by: Roman Kiryanov Hi Roman, Thanks for t

Re: [Qemu-devel] [PULL 0/3] Input 20190522 patches

2019-05-23 Thread Peter Maydell
On Wed, 22 May 2019 at 09:32, Gerd Hoffmann wrote: > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into > staging (2019-05-21 16:30:13 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] aspeed qemu question

2019-05-23 Thread Wim Vervoorn
Hello Cédric, I have another question regarding the ASPEED Qemu support. This is regarding the SPI support. I noticed that in general the fmc_model and the spi_model for the flash device are different even though there is only one flash device connected. I would expect that in this case the mo

[Qemu-devel] [PATCH v3] monitor: Fix return type of monitor_fdset_dup_fd_find

2019-05-23 Thread Yury Kotov
monitor_fdset_dup_fd_find_remove() and monitor_fdset_dup_fd_find() return mon_fdset->id which is int64_t. Downcasting from int64_t to int leads to a bug with removing fd from fdset with id >= 2^32. So, fix return types for these function. Signed-off-by: Yury Kotov Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [RFC PATCH 0/3] block: qiov_offset parameter for io

2019-05-23 Thread Stefan Hajnoczi
On Tue, May 21, 2019 at 11:45:19AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is idea of adding qiov_offset parameter to io path, to avoid > a lot of places with same pattern of creating local_qiov or hd_qiov > variables. Here is only read path for qcow2, if we like it, I'll > m

Re: [Qemu-devel] [PATCH 0/4] mips: Add more Avocado tests

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/23/19 1:07 AM, Eduardo Habkost wrote: > On Wed, May 22, 2019 at 05:46:06PM -0400, Cleber Rosa wrote: >> - Original Message - >>> From: "Eduardo Habkost" >>> On Tue, May 21, 2019 at 01:19:06AM +0200, Philippe Mathieu-Daudé wrote: Hi, It was a rainy week-end here, so I in

Re: [Qemu-devel] [PATCH v2] monitor: Fix fdset_id & fd types for corresponding QMP commands

2019-05-23 Thread Yury Kotov
22.05.2019, 19:40, "Markus Armbruster" : > Yury Kotov writes: > >>  Now, fdset_id is int64, but in some places we work with it as int. >>  It seems that there is no sense to use int64 for fdset_id, so it's >>  better to fix inconsistency by changing fdset_id type to int and by >>  fixing the refer

Re: [Qemu-devel] [PATCH v2] numa: improve cpu hotplug error message with a wrong node-id

2019-05-23 Thread Igor Mammedov
On Tue, 21 May 2019 09:33:48 +0200 Laurent Vivier wrote: > On pseries, core-ids are strongly binded to a node-id by the command > line option. If an user tries to add a CPU to the wrong node, he has > an error but it is not really helpful: > > qemu-system-ppc64 ... -smp 1,maxcpus=64,cores=1,th

Re: [Qemu-devel] [PULL 00/38] ppc-for-4.1 queue 20190522

2019-05-23 Thread Peter Maydell
On Wed, 22 May 2019 at 05:46, David Gibson wrote: > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into > staging (2019-05-21 16:30:13 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v2 2/2] Boot Linux Console Test: add a test for the Raspberry Pi 2

2019-05-23 Thread Philippe Mathieu-Daudé
On 5/22/19 11:05 PM, Cleber Rosa wrote: > - Original Message - >> From: "Eduardo Habkost" >> On Wed, Mar 13, 2019 at 12:45:41AM +0100, Philippe Mathieu-Daudé wrote: >>> From: Philippe Mathieu-Daudé >>> >>> Similar to the x86_64/pc test, it boots a Linux kernel on a raspi2 >>> board and ve

Re: [Qemu-devel] [PATCH v3] linux-user: Pass through nanosecond timestamp components for stat syscalls

2019-05-23 Thread Laurent Vivier
On 22/05/2019 18:21, Chen-Yu Tsai wrote: From: Chen-Yu Tsai Since Linux 2.6 the stat syscalls have mostly supported nanosecond components for each of the file-related timestamps. QEMU user mode emulation currently does not pass through the nanosecond portion of the timestamp, even when the hos

Re: [Qemu-devel] [PULL 0/3] x86 MDS feature flags

2019-05-23 Thread Peter Maydell
On Tue, 21 May 2019 at 19:51, Eduardo Habkost wrote: > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into > staging (2019-05-21 16:30:13 +0100) > > are available in the Git repository at: >

Re: [Qemu-devel] [RFC] hw/core/bus.c: Only the main system bus can have no parent

2019-05-23 Thread Peter Maydell
On Thu, 23 May 2019 at 07:39, Markus Armbruster wrote: > > Peter Maydell writes: > > It's a well-defined order, but it doesn't actually help in a > > lot of cases, because often the thing you care about ordering > > on is not a device or is not in the same tree as the thing > > it depends on. > >

Re: [Qemu-devel] How do we do user input bitmap properties?

2019-05-23 Thread Andrea Bolognani
On Wed, 2019-05-15 at 13:54 +0200, Andrew Jones wrote: > On Wed, May 15, 2019 at 12:52:29PM +0200, Igor Mammedov wrote: > > since using magic numbers is not very descriptive > > (but if there is some spec where they come from that we could point users to > > it might be acceptable too, but I'd rese

Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes

2019-05-23 Thread Peter Maydell
On Thu, 23 May 2019 at 01:51, Laszlo Ersek wrote: > I have narrowed down the issue sufficiently that I think I can hand it > over to Peter and Ard now -- because they know AARCH32 and AARCH64 > assembly, and "target/arm/translate-a64.c" and "tcg/arm/*" too. > > The summarize the issue for Ard, the

<    1   2   3   4   5   >