Re: [Qemu-devel] [PATCH] spapr_pci: Improve error message

On Thu, May 30, 2019 at 09:40:27AM +0200, Greg Kurz wrote: > On Thu, 30 May 2019 10:40:49 +1000 > David Gibson wrote: > > > On Wed, May 29, 2019 at 07:15:09PM +0200, Greg Kurz wrote: > > > Every PHB must have a unique index. This is checked at realize but when > > > a duplicate index is

Re: [Qemu-devel] [PATCH v2 3/8] spapr: Clean up dt creation for PCI buses

On 30/05/2019 15:38, David Gibson wrote: > Device nodes for PCI bridges (both host and P2P) describe both the bridge > device itself and the bus hanging off it, handling of this is a bit of a > mess. > > spapr_dt_pci_device() has a few things it only adds for non-bridges, but > always adds

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

On Wed, May 29, 2019 at 05:08:52PM +0200, Markus Armbruster wrote: > When scripts/get_maintainer.pl reports something like > > John Doe (maintainer:Overall) > > the user is left to wonder *which* of our three "Overall" sections > applies. We have three, one each under "Guest CPU cores

Re: [Qemu-devel] [PATCH v3 12/12] migration: Split log_clear() into smaller chunks

On Thu, May 30, 2019 at 07:58:55PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Currently we are doing log_clear() right after log_sync() which mostly > > keeps the old behavior when log_clear() was still part of log_sync(). > > > > This patch tries to further

Re: [Qemu-devel] [PATCH v3 10/12] kvm: Introduce slots lock for memory listener

On Thu, May 30, 2019 at 05:40:38PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Introduce KVMMemoryListener.slots_lock to protect the slots inside the > > kvm memory listener. Currently it is close to useless because all the > > KVM code path now is always

Re: [Qemu-devel] [PATCH v3 09/12] kvm: Persistent per kvmslot dirty bitmap

On Thu, May 30, 2019 at 02:53:30PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > When synchronizing dirty bitmap from kernel KVM we do it in a > > per-kvmslot fashion and we allocate the userspace bitmap for each of > > the ioctl. This patch instead make the

Re: [Qemu-devel] [PATCH v3 06/12] memory: Pass mr into snapshot_and_clear_dirty

On Thu, May 30, 2019 at 12:22:00PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Also we change the 2nd parameter of it to be the relative offset > > within the memory region. This is to be used in follow up patches. > > > > Signed-off-by: Peter Xu > > --- > >

Re: [Qemu-devel] [PATCH v3 05/12] bitmap: Add bitmap_copy_with_{src|dst}_offset()

On Thu, May 30, 2019 at 12:05:27PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > These helpers copy the source bitmap to destination bitmap with a > > shift either on the src or dst bitmap. > > > > Meanwhile, we never have bitmap tests but we should. > > > >

Re: [Qemu-devel] [PATCH] target/i386: save EFER for 32-bit targets

On Wed, May 29, 2019 at 03:41:56PM +0300, Pavel Dovgalyuk wrote: > +static const VMStateDescription vmstate_efer32 = { > +.name = "cpu/efer32", > +.version_id = 1, > +.minimum_version_id = 1, > + .needed = intel_efer32_needed, Indent might need a touchup. Other than that:

Re: [Qemu-devel] [PATCH 2/3] migration/ram.c: start of cpu_physical_memory_sync_dirty_bitmap is always 0

On Tue, May 14, 2019 at 03:21:08PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> Since start of cpu_physical_memory_sync_dirty_bitmap is always 0, we can >> remove this parameter and simplify the calculation a bit. >> >> Signed-off-by: Wei Yang > >So

[Qemu-devel] [PATCH v4 2/2] drm/i915/gvt: export migration_version to mdev sysfs for Intel vGPU

This feature implements the migration_version attribute for Intel's vGPU mdev devices. migration_version attribute is rw. It's used to check migration compatibility for two mdev devices of the same mdev type. migration_version string is defined by vendor driver and opaque to userspace. For Intel

[Qemu-devel] [PATCH v4 1/2] vfio/mdev: add migration_version attribute for mdev device

migration_version attribute is used to check migration compatibility between two mdev devices of the same mdev type. The key is that it's rw and its data is opaque to userspace. Userspace reads migration_version of mdev device at source side and writes the value to migration_version attribute of

[Qemu-devel] [PATCH v4 0/2] introduction of migration_version attribute for VFIO live migration

This patchset introduces a migration_version attribute under sysfs of VFIO Mediated devices. This migration_version attribute is used to check migration compatibility between two mdev devices of the same mdev type. Patch 1 defines migration_version attribute in

Re: [Qemu-devel] [PULL 08/16] tcg/i386: Support vector comparison select value

On May 30, 2019 7:45 PM, "Richard Henderson" wrote: > > On 5/30/19 9:54 AM, Aleksandar Markovic wrote: > > > > On May 30, 2019 2:50 PM, "Richard Henderson" < richard.hender...@linaro.org > > > wrote: > >> > >> On 5/30/19 6:26 AM, Peter Maydell wrote: > >> >>

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

On Thu, May 30, 2019 at 03:22:10PM -0300, Eduardo Habkost wrote: > On Thu, May 30, 2019 at 02:09:42PM -0400, Michael S. Tsirkin wrote: > > On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > On Thu, May 30, 2019 at

Re: [Qemu-devel] [PATCH 2/3] MAINTAINERS: Improve section headlines

On May 29, 2019 5:09 PM, "Markus Armbruster" wrote: > > When scripts/get_maintainer.pl reports something like > > John Doe (maintainer:Overall) > > the user is left to wonder *which* of our three "Overall" sections > applies. We have three, one each under "Guest CPU cores (TCG)", > "Guest

[Qemu-devel] [PATCH 1/1] vl: make -accel help to list enabled accelerators only

Currently, -accel help shows all possible accelerators regardless if they are enabled in the binary or not. That is a different semantic from -cpu and -machine helps, for example. So this change makes it to list only the accelerators which support is compiled in the binary target. Note that it

[Qemu-devel] [PATCH 0/1] -accel should list enabled accelerators

On this series I changed the semantics of -accel help so that it shows only the accelerators enabled in the QEMU target binary. This behavior is now alike -cpu and -machine helps. Another reason for this proposal is that I am working on an improvement of Avocado QEMU framework which should skip

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

On Tue, May 28, 2019 at 08:18:20AM -0700, Elena Ufimtseva wrote: > On Thu, May 23, 2019 at 12:11:30PM +0100, Stefan Hajnoczi wrote: > > Hi Jag and Elena, > > Do you think a call would help to move discussion along more quickly? > > > > Hi Stefan, > > We would like to join this call. > And thank

Re: [Qemu-devel] [RFC PATCH] qemu-io-cmds: use clock_gettime for benchmarking

Patchew URL: https://patchew.org/QEMU/20190529162438.22653-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH] qemu-io-cmds: use clock_gettime for benchmarking Type: series Message-id:

Re: [Qemu-devel] [PATCH RFC v20 0/8] QEMU AVR 8 bit cores

Patchew URL: https://patchew.org/QEMU/20190530190738.22713-1-mrol...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time

Re: [Qemu-devel] [PATCH] Avoid crash in epoll_ctl with EPOLL_CTL_DEL

Yes, that's much better if compatibility with such an old kernel version is wanted. I suppose there's no need for me to re-send the patch. On 30/05/19 18:12, Laurent Vivier wrote: Le 30/05/2019 à 18:00, Laurent Vivier a écrit : Le 30/05/2019 à 17:25, Giuseppe Musacchio a écrit : The `event`

[Qemu-devel] [PATCH v1] Makefile: remove DESTDIR from firmware file content

The resulting firmware files should only contain the runtime path. Fixes commit 26ce90fde5c ("Makefile: install the edk2 firmware images and their descriptors") Signed-off-by: Olaf Hering --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

On Thu, May 30, 2019 at 08:08:23PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > On Thu, May 30, 2019 at 04:56:45PM +0200,

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

* Jens Freimann (jfreim...@redhat.com) wrote: > Hi David, > > sorry for the delayed reply. > > On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: > > On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David Alan Gilbert wrote: > > > * Jens Freimann (jfreim...@redhat.com) wrote: > >

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > > > > Hi David, > > > > > > > > sorry for the delayed

[Qemu-devel] [PATCH RFC v20 5/8] target/avr: Add instruction translation

From: Sarah Harris This includes: - TCG translations for each instruction Signed-off-by: Sarah Harris Signed-off-by: Michael Rolnik --- target/avr/translate.c | 2981 1 file changed, 2981 insertions(+) create mode 100644 target/avr/translate.c diff

[Qemu-devel] [PATCH RFC v20 6/8] target/avr: Add limited support for USART and 16 bit timer peripherals

From: Sarah Harris These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins).

[Qemu-devel] [PATCH RFC v20 8/8] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file

From: Sarah Harris Signed-off-by: Sarah Harris Signed-off-by: Michael Rolnik --- MAINTAINERS | 6 + arch_init.c | 2 ++ configure | 6 + default-configs/avr-softmmu.mak | 5 + include/disas/dis-asm.h | 6

[Qemu-devel] [PATCH RFC v20 7/8] target/avr: Add example board configuration

From: Sarah Harris A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AVR CPUs include a lot of on-board peripherals. Signed-off-by: Sarah Harris Signed-off-by: Michael Rolnik --- hw/Kconfig

[Qemu-devel] [PATCH RFC v20 1/8] target/avr: Add outward facing interfaces and core CPU logic

From: Sarah Harris This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Signed-off-by: Sarah Harris Signed-off-by: Michael Rolnik --- target/avr/cpu-qom.h | 83 +++ target/avr/cpu.c | 571

[Qemu-devel] [PATCH RFC v20 4/8] target-avr: Add instruction decoding

This includes: - encoding of all 16 bit instructions - encoding of all 32 bit instructions Signed-off-by: Michael Rolnik --- target/avr/insn16.decode | 160 +++ target/avr/insn32.decode | 10 +++ 2 files changed, 170 insertions(+) create mode 100644

[Qemu-devel] [PATCH RFC v20 0/8] QEMU AVR 8 bit cores

This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support

[Qemu-devel] [PATCH RFC v20 2/8] target/avr: Add instruction helpers

From: Sarah Harris Stubs for unimplemented instructions and helpers for instructions that need to interact with QEMU. SPM and WDR are unimplemented because they require emulation of complex peripherals. The implementation of SLEEP is very limited due to the lack of peripherals to generate

[Qemu-devel] [PATCH RFC v20 3/8] target/avr: Add mechanism to check for active debugger connection

From: Sarah Harris AVR CPUs have a BREAK instruction which behaves differently depending on whether debugging is enabled. Since the hardware fuses that normally control this are difficult to emulate, and the BREAK instruction is useful for testing, the BREAK instruction is instead

Re: [Qemu-devel] [PATCH v3 12/12] migration: Split log_clear() into smaller chunks

* Peter Xu (pet...@redhat.com) wrote: > Currently we are doing log_clear() right after log_sync() which mostly > keeps the old behavior when log_clear() was still part of log_sync(). > > This patch tries to further optimize the migration log_clear() code > path to split huge log_clear()s into

Re: [Qemu-devel] [PATCH v1 06/26] tests/docker: Update the Ubuntu image to 19.04

On 5/30/19 5:15 AM, Alex Bennée wrote: > This has aged a little and we have a separate LTS image for testing on > the older distros. Update it to a more recent release like its Fedora > cousin. > > Besides it is useful to have something with gcc-9 on it for squashing > those stringop truncation

Re: [Qemu-devel] [PATCH v1 05/26] tests/docker: Update the Fedora cross compile images to 30

On 5/30/19 5:15 AM, Alex Bennée wrote: > While at it remove the bogus :latest tag for cris cross compiler. It > tends to break caching and cause confusion. > > Signed-off-by: Alex Bennée > --- > tests/docker/dockerfiles/fedora-cris-cross.docker | 2 +- >

Re: [Qemu-devel] [PATCH v1 02/26] qemu-io-cmds: use clock_gettime for benchmarking

On 5/30/19 5:15 AM, Alex Bennée wrote: > -static struct timeval tsub(struct timeval t1, struct timeval t2) > +static struct timespec tsub(struct timespec t1, struct timespec t2) > { > -t1.tv_usec -= t2.tv_usec; > -if (t1.tv_usec < 0) { > -t1.tv_usec += 100; > +t1.tv_nsec

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

On Thu, May 30, 2019 at 02:09:42PM -0400, Michael S. Tsirkin wrote: > On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > > > > Hi David, > > > > > > > >

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

On Thu, Dec 06, 2018 at 10:01:46AM +, Daniel P. Berrangé wrote: > Users absolutely *do* care why migration is not finishing. A migration that > does not finish is a major problem for mgmt apps in many case of the use > cases for migration. Especially important when evacuating VMs from a host >

Re: [Qemu-devel] [PATCH v1 01/26] editorconfig: add setting for shell scripts

On 5/30/19 5:15 AM, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > .editorconfig | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 0/4] add failover feature for assigned network devices

On Wed, May 29, 2019 at 09:48:02AM +0200, Jens Freimann wrote: > On Tue, May 28, 2019 at 10:40:42PM -0400, Michael S. Tsirkin wrote: > > On Tue, May 21, 2019 at 08:49:18PM +0200, Jens Freimann wrote: > > > On Tue, May 21, 2019 at 07:37:19AM -0400, Michael S. Tsirkin wrote: > > > > On Tue, May 21,

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > > > Hi David, > > > > > > sorry for the delayed reply. > > > > > > On Tue, May 28, 2019 at 11:04:15AM

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > > Hi David, > > > > sorry for the delayed reply. > > > > On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: > > > On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David

Re: [Qemu-devel] [PATCH v3 11/12] kvm: Support KVM_CLEAR_DIRTY_LOG

* Peter Xu (pet...@redhat.com) wrote: > Firstly detect the interface using KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 > and mark it. When failed to enable the new feature we'll fall back to > the old sync. > > Provide the log_clear() hook for the memory listeners for both address > spaces of KVM (normal

Re: [Qemu-devel] [PATCH v2 2/9] i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID

On Mon, May 27, 2019 at 06:39:53PM +0200, Vitaly Kuznetsov wrote: > Roman Kagan writes: > > On Fri, May 17, 2019 at 04:19:17PM +0200, Vitaly Kuznetsov wrote: > >> +static struct kvm_cpuid2 *try_get_hv_cpuid(CPUState *cs, int max) > >> +{ > >> +struct kvm_cpuid2 *cpuid; > >> +int r, size;

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > Hi David, > > sorry for the delayed reply. > > On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: > > On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David Alan Gilbert wrote: > > > * Jens Freimann

Re: [Qemu-devel] [PULL 08/16] tcg/i386: Support vector comparison select value

On 5/30/19 9:54 AM, Aleksandar Markovic wrote: > > On May 30, 2019 2:50 PM, "Richard Henderson" > wrote: >> >> On 5/30/19 6:26 AM, Peter Maydell wrote: >> >> -#define TCG_TARGET_HAS_cmpsel_vec       0 >> >> +#define TCG_TARGET_HAS_cmpsel_vec       -1 >> > >>

Re: [Qemu-devel] [PATCH] block/linux-aio: explictly clear laiocb->co

On 30.05.2019 17:07, Paolo Bonzini wrote: On 30/05/19 10:42, Kevin Wolf wrote: Am 27.05.2019 um 11:23 hat Stefan Hajnoczi geschrieben: qemu_aio_get() does not zero allocated memory. Explicitly initialize laiocb->co to prevent an uninitialized memory access in qemu_laio_process_completion().

[Qemu-devel] [PATCH] util: Adjust qemu_guest_getrandom_nofail for Coverity

Explicitly ignore the return value of qemu_guest_getrandom. Because we use error_fatal, all errors are already caught. Fixes: CID 1401701 Signed-off-by: Richard Henderson --- util/guest-random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/guest-random.c

Re: [Qemu-devel] [PATCH v3 10/12] kvm: Introduce slots lock for memory listener

* Peter Xu (pet...@redhat.com) wrote: > Introduce KVMMemoryListener.slots_lock to protect the slots inside the > kvm memory listener. Currently it is close to useless because all the > KVM code path now is always protected by the BQL. But it'll start to > make sense in follow up patches where we

[Qemu-devel] [Bug 1831115] [NEW] qemu 4.0.0 on aarch64: uefi firmware oversize

Public bug reported: I'd like to enable uefi in my virtual machine, however qemu is always showing the same error: qemu-system-aarch64: Initialization of device cfi.pflash01 failed: device requires 67108864 bytes, block backend provides 786432 bytes It's clearly impossible to fit a uefi

Re: [Qemu-devel] [PATCH 04/20] hw/i386/pc: Add the E820Type enum type

Hi Li, On 5/24/19 2:33 PM, Li Qiang wrote: > Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于 > 2019年5月24日周五 下午2:45写道： > > This ensure we won't use an incorrect value. > > Signed-off-by: Philippe Mathieu-Daudé > > --- >  hw/i386/pc.c         |

Re: [Qemu-devel] [RFC PATCH] semihosting: split console_out intro string and char versions

Le 30/05/2019 à 16:39, Alex Bennée a écrit : > This is ostensibly to avoid the weirdness of len looking like it might > come from a guest and sometimes being used. While we are at it fix up > the error checking for the arm-linux-user implementation of the API > which got flagged up by Coverity

Re: [Qemu-devel] [PATCH] qapi: add dirty-bitmaps to query-named-block-nodes result

On 5/30/19 10:39 AM, Vladimir Sementsov-Ogievskiy wrote: > Let's add a possibility to query dirty-bitmaps not only on root nodes. > It is useful when dealing both with snapshots and incremental backups. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 5 - >

Re: [Qemu-devel] [RFC PATCH] semihosting: split console_out intro string and char versions

Patchew URL: https://patchew.org/QEMU/20190530143916.20255-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH] semihosting: split console_out intro string and char versions Type: series

Re: [Qemu-devel] [PATCH] Avoid crash in epoll_ctl with EPOLL_CTL_DEL

Le 30/05/2019 à 18:00, Laurent Vivier a écrit : > Le 30/05/2019 à 17:25, Giuseppe Musacchio a écrit : >> The `event` parameter is ignored by the kernel if `op` is EPOLL_CTL_DEL, >> do the same and avoid returning EFAULT if garbage is passed instead of a >> valid pointer. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH] Avoid crash in epoll_ctl with EPOLL_CTL_DEL

Le 30/05/2019 à 17:25, Giuseppe Musacchio a écrit : > The `event` parameter is ignored by the kernel if `op` is EPOLL_CTL_DEL, > do the same and avoid returning EFAULT if garbage is passed instead of a > valid pointer. > > Signed-off-by: Giuseppe Musacchio > --- >  linux-user/syscall.c | 2 +- >  

Re: [Qemu-devel] [PULL 00/44] ppc-for-4.1 queue 20190529

On Wed, 29 May 2019 at 07:50, David Gibson wrote: > > The following changes since commit 8c1ecb590497b0349c550607db923972b37f6963: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-next-280519-2' into staging (2019-05-28 > 17:38:32 +0100) > > are available in the Git

[Qemu-devel] [PATCH] Avoid crash in epoll_ctl with EPOLL_CTL_DEL

The `event` parameter is ignored by the kernel if `op` is EPOLL_CTL_DEL, do the same and avoid returning EFAULT if garbage is passed instead of a valid pointer. Signed-off-by: Giuseppe Musacchio --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH 10/20] hw/i386/pc: Pass the boot_cpus value by argument

On 5/24/19 5:30 PM, Li Qiang wrote: > Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于 > 2019年5月24日周五 下午2:50写道： > > The boot_cpus is used once. Pass it by argument, this will > allow us to remove the PCMachineState argument later. > > Suggested-by: Samuel Ortiz

Re: [Qemu-devel] [PULL 00/28] testing/next (system tests, docker, iotests)

On 28/05/19 16:02, Peter Maydell wrote: > On Tue, 28 May 2019 at 14:47, Alex Bennée wrote: >> Sounds like we should include the sanitizer build in our normal setup. >> We currently only do: >> >> ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread >> -fuse-ld=gold" >> >> with

Re: [Qemu-devel] [PATCH] qapi: add dirty-bitmaps to query-named-block-nodes result

On 5/30/19 9:39 AM, Vladimir Sementsov-Ogievskiy wrote: > Let's add a possibility to query dirty-bitmaps not only on root nodes. > It is useful when dealing both with snapshots and incremental backups. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 5 - >

Re: [Qemu-devel] [PATCH v17 02/10] ACPI: add some GHES structures and macros definition

On 2019/5/29 11:40, Michael S. Tsirkin wrote: > On Tue, May 14, 2019 at 04:18:15AM -0700, Dongjiu Geng wrote: >> Add Generic Error Status Block structures and some macros >> definitions, which is referred to the ACPI 4.0 or ACPI 6.2. The >> HEST table generation and CPER record will use them. >>

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

Hi David, sorry for the delayed reply. On Tue, May 28, 2019 at 11:04:15AM -0400, Michael S. Tsirkin wrote: On Tue, May 21, 2019 at 10:45:05AM +0100, Dr. David Alan Gilbert wrote: * Jens Freimann (jfreim...@redhat.com) wrote: > +static void virtio_net_primary_plug_timer(void *opaque); > + >

Re: [Qemu-devel] [PULL 08/16] tcg/i386: Support vector comparison select value

On May 30, 2019 2:50 PM, "Richard Henderson" wrote: > > On 5/30/19 6:26 AM, Peter Maydell wrote: > >> -#define TCG_TARGET_HAS_cmpsel_vec 0 > >> +#define TCG_TARGET_HAS_cmpsel_vec -1 > > > > This is the only place where we define a TCG_TARGET_HAS_* macro > > to something other than 0

Re: [Qemu-devel] [PATCH v17 07/10] ACPI: Add APEI GHES table generation support

Hi Michael, Thanks for the review. On 2019/5/29 11:37, Michael S. Tsirkin wrote: > On Tue, May 14, 2019 at 04:18:20AM -0700, Dongjiu Geng wrote: >> This implements APEI GHES Table generation via fw_cfg blobs. >> Now it only support GPIO-Signal and ARMv8 SEA two types of GHESv2 error >> source.

[Qemu-devel] [RFC PATCH] semihosting: split console_out intro string and char versions

This is ostensibly to avoid the weirdness of len looking like it might come from a guest and sometimes being used. While we are at it fix up the error checking for the arm-linux-user implementation of the API which got flagged up by Coverity (CID 1401700). Signed-off-by: Alex Bennée ---

[Qemu-devel] [PATCH] qapi: add dirty-bitmaps to query-named-block-nodes result

Let's add a possibility to query dirty-bitmaps not only on root nodes. It is useful when dealing both with snapshots and incremental backups. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 5 - block/qapi.c | 5 + 2 files changed, 9 insertions(+), 1

Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

30.05.2019 17:20, John Snow wrote: > > On 5/30/19 4:23 AM, Vladimir Sementsov-Ogievskiy wrote: >> 29.05.2019 21:08, John Snow wrote: >>> On 5/29/19 5:10 AM, Vladimir Sementsov-Ogievskiy wrote: 29.05.2019 2:24, John Snow wrote: > On 5/23/19 11:47 AM, Vladimir Sementsov-Ogievskiy wrote: >

Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

On 5/30/19 4:23 AM, Vladimir Sementsov-Ogievskiy wrote: > 29.05.2019 21:08, John Snow wrote: >> On 5/29/19 5:10 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 29.05.2019 2:24, John Snow wrote: On 5/23/19 11:47 AM, Vladimir Sementsov-Ogievskiy wrote: [...] >> >> Right, we've not really used

Re: [Qemu-devel] [PULL 0/9] Usb 20190529 patches

On Wed, 29 May 2019 at 07:33, Gerd Hoffmann wrote: > > The following changes since commit da35f7f1eeff9f249a9597400fc514c83fd3a0f8: > > virtio-gpu: add sanity check (2019-05-28 08:14:44 +0200) > > are available in the Git repository at: > > git://git.kraxel.org/qemu

Re: [Qemu-devel] [PATCH] block/linux-aio: explictly clear laiocb->co

On 30/05/19 10:42, Kevin Wolf wrote: > Am 27.05.2019 um 11:23 hat Stefan Hajnoczi geschrieben: >> qemu_aio_get() does not zero allocated memory. Explicitly initialize >> laiocb->co to prevent an uninitialized memory access in >> qemu_laio_process_completion(). >> >> Note that this bug has never

Re: [Qemu-devel] [PATCH v3 09/12] kvm: Persistent per kvmslot dirty bitmap

* Peter Xu (pet...@redhat.com) wrote: > When synchronizing dirty bitmap from kernel KVM we do it in a > per-kvmslot fashion and we allocate the userspace bitmap for each of > the ioctl. This patch instead make the bitmap cache be persistent > then we don't need to g_malloc0() every time. > >

[Qemu-devel] [PATCHv4 6/6] RISC-V: Fix a PMP check with the correct access size

The PMP check should be of the memory access size rather than TARGET_PAGE_SIZE. Signed-off-by: Hesham Almatary Reviewed-by: Alistair Francis --- target/riscv/cpu_helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c

[Qemu-devel] [PATCHv4 5/6] RISC-V: Fix a PMP bug where it succeeds even if PMP entry is off

The current implementation returns 1 (PMP check success) if the address is in range even if the PMP entry is off. This is a bug. For example, if there is a PMP check in S-Mode which is in range, but its PMP entry is off, this will succeed, which it should not. The patch fixes this bug by only

[Qemu-devel] [PATCHv4 1/6] RISC-V: Only Check PMP if MMU translation succeeds

The current implementation unnecessarily checks for PMP even if MMU translation failed. This may trigger a wrong PMP access exception instead of a page exception. For example, the very first instruction fetched after the first satp write in S-Mode will trigger a PMP access fault instead of an

[Qemu-devel] [PATCHv4 2/6] RISC-V: Raise access fault exceptions on PMP violations

Section 3.6 in RISC-V v1.10 privilege specification states that PMP violations report "access exceptions." The current PMP implementation has a bug which wrongly reports "page exceptions" on PMP violations. This patch fixes this bug by reporting the correct PMP access exceptions trap values.

[Qemu-devel] [PATCHv4 4/6] RISC-V: Check PMP during Page Table Walks

The PMP should be checked when doing a page table walk, and report access fault exception if the to-be-read PTE failed the PMP check. Suggested-by: Jonathan Behrens Signed-off-by: Hesham Almatary --- target/riscv/cpu.h| 1 + target/riscv/cpu_helper.c | 10 +- 2 files changed,

[Qemu-devel] [PATCHv4 3/6] RISC-V: Check for the effective memory privilege mode during PMP checks

The current PMP check function checks for env->priv which is not the effective memory privilege mode. For example, mstatus.MPRV could be set while executing in M-Mode, and in that case the privilege mode for the PMP check should be S-Mode rather than M-Mode (in env->priv) if mstatus.MPP == PRV_S.

Re: [Qemu-devel] [PULL 10/25] util: Add qemu_guest_getrandom and associated routines

On Thu, 30 May 2019 at 14:41, Richard Henderson wrote: > > On 5/30/19 6:29 AM, Peter Maydell wrote: > > On Wed, 22 May 2019 at 19:42, Richard Henderson > > wrote: > >> > >> This routine is intended to produce high-quality random numbers to the > >> guest. Normally, such numbers are crypto

Re: [Qemu-devel] [PULL 10/25] util: Add qemu_guest_getrandom and associated routines

On 5/30/19 6:29 AM, Peter Maydell wrote: > On Wed, 22 May 2019 at 19:42, Richard Henderson > wrote: >> >> This routine is intended to produce high-quality random numbers to the >> guest. Normally, such numbers are crypto quality from the host, but a >> command-line option can force the use of a

Re: [Qemu-devel] [PATCH v8 0/7] backup-top filter driver for backup

29.05.2019 18:46, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > These series introduce backup-top driver. It's a filter-node, which > do copy-before-write operation. Mirror uses filter-node for handling > guest writes, let's move to filter-node (from write-notifiers) for > backup too > > v8:

Re: [Qemu-devel] [PATCH v3 07/12] memory: Introduce memory listener hook log_clear()

* Peter Xu (pet...@redhat.com) wrote: > Introduce a new memory region listener hook log_clear() to allow the > listeners to hook onto the points where the dirty bitmap is cleared by > the bitmap users. > > Previously log_sync() contains two operations: > > - dirty bitmap collection, and, > -

Re: [Qemu-devel] [PATCHv3 3/5] RISC-V: Check PMP during Page Table Walks

On Thu, 30 May 2019 at 05:07, Alistair Francis wrote: > > On Wed, May 22, 2019 at 2:27 AM Hesham Almatary > wrote: > > > > On Tue, 21 May 2019 at 23:40, Alistair Francis wrote: > > > > > > On Tue, May 21, 2019 at 3:44 AM Hesham Almatary > > > wrote: > > > > > > > > The PMP should be checked

Re: [Qemu-devel] [PULL 0/9] Vga 20190529 patches

On Wed, 29 May 2019 at 05:42, Gerd Hoffmann wrote: > > The following changes since commit da35f7f1eeff9f249a9597400fc514c83fd3a0f8: > > virtio-gpu: add sanity check (2019-05-28 08:14:44 +0200) > > are available in the Git repository at: > > git://git.kraxel.org/qemu

Re: [Qemu-devel] [PATCH v3 4/4] egl-helpers: add modifier support to egl_dmabuf_import_texture()

Hi On Wed, May 29, 2019 at 9:24 AM Gerd Hoffmann wrote: > > Check and use QemuDmaBuf->modifier in egl_dmabuf_import_texture() > for dmabuf imports. > > Signed-off-by: Gerd Hoffmann > --- > ui/egl-helpers.c | 34 +- > 1 file changed, 25 insertions(+), 9

Re: [Qemu-devel] [PULL 08/16] tcg/i386: Support vector comparison select value

On 5/30/19 6:26 AM, Peter Maydell wrote: >> -#define TCG_TARGET_HAS_cmpsel_vec 0 >> +#define TCG_TARGET_HAS_cmpsel_vec -1 > > This is the only place where we define a TCG_TARGET_HAS_* macro > to something other than 0 or 1, which means that Coverity > complains (CID 1401702) when we

Re: [Qemu-devel] [PULL 06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi

On Thu, 30 May 2019 at 13:35, Alex Bennée wrote: > > > Peter Maydell writes: > > > Also it looks a bit dodgy that we are passed in a > > specific length value but we then go and look at the length > > of the string, but we trust the specific length value over > > the length of the string. If len

Re: [Qemu-devel] [PULL 06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi

Peter Maydell writes: > On Tue, 28 May 2019 at 10:49, Alex Bennée wrote: >> >> Now we have a common semihosting console interface use that for our >> string output. However ARM is currently unique in also supporting >> semihosting for linux-user so we need to replicate the API in >>

Re: [Qemu-devel] [PULL 0/3] Bitmaps patches

On Wed, 29 May 2019 at 00:58, John Snow wrote: > > The following changes since commit 8c1ecb590497b0349c550607db923972b37f6963: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-next-280519-2' into staging (2019-05-28 > 17:38:32 +0100) > > are available in the Git

Re: [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: rewrite bitmap reopening logic

30.05.2019 11:23, Vladimir Sementsov-Ogievskiy wrote: > 29.05.2019 21:08, John Snow wrote: >> Max has picked this thread up for block discussion, so I'm going to >> stick to slightly more bitmap related discussion here; we'll resume >> block discussion in the other tail of this thread. >> [..]

Re: [Qemu-devel] [PATCH v3] qemu-io: add pattern file for write command

Patchew URL: https://patchew.org/QEMU/20190529140217.12841-1-dplotni...@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3] qemu-io: add pattern file for write command Type: series Message-id:

Re: [Qemu-devel] [PULL 06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi

On Tue, 28 May 2019 at 10:49, Alex Bennée wrote: > > Now we have a common semihosting console interface use that for our > string output. However ARM is currently unique in also supporting > semihosting for linux-user so we need to replicate the API in > linux-user. If other architectures gain

Re: [Qemu-devel] [PULL 10/25] util: Add qemu_guest_getrandom and associated routines

On Wed, 22 May 2019 at 19:42, Richard Henderson wrote: > > This routine is intended to produce high-quality random numbers to the > guest. Normally, such numbers are crypto quality from the host, but a > command-line option can force the use of a fully deterministic sequence > for use while

Re: [Qemu-devel] [PULL 08/16] tcg/i386: Support vector comparison select value

On Wed, 22 May 2019 at 23:28, Richard Henderson wrote: > > We already had backend support for this feature. Expand the new > cmpsel opcode using vpblendb. The combination allows us to avoid > an extra NOT for some comparison codes. > > Signed-off-by: Richard Henderson > --- >

Re: [Qemu-devel] [PULL 19/54] s390x/tcg: Implement VECTOR GALOIS FIELD MULTIPLY SUM (AND ACCUMULATE)

On Mon, 20 May 2019 at 18:06, Cornelia Huck wrote: > > From: David Hildenbrand > > A galois field multiplication in field 2 is like binary multiplication, > however instead of doing ordinary binary additions, xor's are performed. > So no carries are considered. > > Implement all variants via

Re: [Qemu-devel] [PATCH v3 06/12] memory: Pass mr into snapshot_and_clear_dirty

* Peter Xu (pet...@redhat.com) wrote: > Also we change the 2nd parameter of it to be the relative offset > within the memory region. This is to be used in follow up patches. > > Signed-off-by: Peter Xu > --- > exec.c | 3 ++- > include/exec/ram_addr.h | 2 +- > memory.c

Re: [Qemu-devel] [PULL 3/3] contrib: add vhost-user-input

On Wed, 22 May 2019 at 09:29, Gerd Hoffmann wrote: > > From: Marc-André Lureau > > Add a vhost-user input backend example, based on virtio-input-host > device. It takes an evdev path as argument, and can be associated with > a vhost-user-input device via a UNIX socket: > > $ vhost-user-input -p

  1   2   >