[Qemu-devel] [PATCH 15/26] target/mips: Clean up handling of CP0 register 18

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 18. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 20 +--- target/mips/translate.c | 64 - 2 files changed, 44 insertions(+), 40 deletions(-) diff --git a

[Qemu-devel] [PATCH 26/26] target/mips: Clean up handling of CP0 register 31

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 31. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 2 +- target/mips/translate.c | 56 - 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/target/mips/c

[Qemu-devel] [PATCH 17/26] target/mips: Clean up handling of CP0 register 20

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 20. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 40df031..175f6dc 100644 --- a/targe

Re: [Qemu-devel] [PATCH v2 2/2] Add dbus-vmstate object

2019-08-22 Thread Marc-André Lureau
Hi On Thu, Aug 22, 2019 at 3:41 PM Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > Hi > > > > On Thu, Aug 22, 2019 at 2:56 PM Dr. David Alan Gilbert > > wrote: > > > > > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > > > When instanc

[Qemu-devel] [PATCH 11/26] target/mips: Clean up handling of CP0 register 12

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 12. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 3 +++ target/mips/translate.c | 32 2 files changed, 19 insertions(+), 16 deletions(-) diff --git a/target/mips/cpu.h b/target/mi

[Qemu-devel] [PATCH 24/26] target/mips: Clean up handling of CP0 register 29

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 29. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 22 ++--- target/mips/translate.c | 64 - 2 files changed, 46 insertions(+), 40 deletions(-) diff --git

[Qemu-devel] [PATCH 25/26] target/mips: Clean up handling of CP0 register 30

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 30. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 95cb473..808d046 100644 --- a/targe

[Qemu-devel] [PATCH 20/26] target/mips: Clean up handling of CP0 register 25

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 25. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 64 - 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate

[Qemu-devel] [PATCH 18/26] target/mips: Clean up handling of CP0 register 23

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 23. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 6 +++ target/mips/translate.c | 126 +++- 2 files changed, 89 insertions(+), 43 deletions(-) diff --git a/target/mips

[Qemu-devel] [PATCH 23/26] target/mips: Clean up handling of CP0 register 28

2019-08-22 Thread Aleksandar Markovic
From: Aleksandar Markovic Clean up handling of CP0 register 28. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 24 +++ target/mips/translate.c | 64 - 2 files changed, 46 insertions(+), 42 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH 08/13] qcrypto: add the plumbing for encryption management

2019-08-22 Thread Daniel P . Berrangé
On Thu, Aug 22, 2019 at 02:47:03PM +0300, Maxim Levitsky wrote: > On Thu, 2019-08-22 at 12:16 +0100, Daniel P. Berrangé wrote: > > On Wed, Aug 14, 2019 at 11:22:14PM +0300, Maxim Levitsky wrote: > > > This adds qcrypto_block_manage_encryption, which > > > is thin wrapper around manage_encryption o

Re: [Qemu-devel] [PATCH v2 2/2] Add dbus-vmstate object

2019-08-22 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Hi > > On Thu, Aug 22, 2019 at 2:56 PM Dr. David Alan Gilbert > wrote: > > > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > > When instanciated, this object will connect to the given D-Bus > > > bus. During migration, it w

[Qemu-devel] [PATCH] migration: register_savevm_live doesn't need dev

2019-08-22 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Commit 78dd48df3 removed the last caller of register_savevm_live for an instantiable device (rather than a single system wide device); so trim out the parameter. Signed-off-by: Dr. David Alan Gilbert --- docs/devel/migration.rst | 3 +-- hw/ppc/spapr.c

Re: [Qemu-devel] Broken aarch64 by qcow2: skip writing zero buffers to empty COW areas [v2]

2019-08-22 Thread Max Reitz
(CC-ing Paolo because of the XFS connection, and Stefan because why not.) On 22.08.19 13:27, Lukáš Doktor wrote: > Dne 21. 08. 19 v 19:51 Max Reitz napsal(a): >> On 21.08.19 16:14, Lukáš Doktor wrote: >>> Hello guys, >>> >>> First attempt was rejected due to zip attachment, let's try it again with

Re: [Qemu-devel] more automated/public CI for QEMU pullreqs

2019-08-22 Thread Daniel P . Berrangé
On Fri, Aug 16, 2019 at 07:16:55PM +0100, Peter Maydell wrote: > The two major contenders suggested were: > > (1) GitLab CI, which supports custom 'runners' which we can set > up to run builds and tests on machines we have project access to > > (2) Patchew, which can handle running tests on multi

Re: [Qemu-devel] [PATCH v8 2/3] block/nbd: nbd reconnect

2019-08-22 Thread Vladimir Sementsov-Ogievskiy
21.08.2019 20:35, Eric Blake wrote: > On 8/21/19 11:52 AM, Vladimir Sementsov-Ogievskiy wrote: >> Implement reconnect. To achieve this: >> >> 1. add new modes: >> connecting-wait: means, that reconnecting is in progress, and there >> were small number of reconnect attempts, so all request

Re: [Qemu-devel] [PULL 0/4] Monitor patches for 2019-08-21

2019-08-22 Thread Peter Maydell
On Wed, 21 Aug 2019 at 17:11, Markus Armbruster wrote: > > The following changes since commit 17dc57990320edaad52ac9ea808be9719c91cea6: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-08-20' into staging (2019-08-20 > 14:14:20 +0100) > > are available in the Git

Re: [Qemu-devel] [PATCH v2 2/2] Add dbus-vmstate object

2019-08-22 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Hi > > On Thu, Aug 22, 2019 at 3:41 PM Dr. David Alan Gilbert > wrote: > > > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > > Hi > > > > > > On Thu, Aug 22, 2019 at 2:56 PM Dr. David Alan Gilbert > > > wrote: > > > > > >

[Qemu-devel] [PATCH 1/2] contrib/gitdm: filetype interface is not in order, fix

2019-08-22 Thread Markus Armbruster
gitm prints the rather cryptic message "interface not found, appended to the last order". This is because filetypes.txt has filetype interface, but neglects to mention it in order. Fix that. Fixes: 2f28271d807edfcdc47a280c06999dd866dcae10 Signed-off-by: Markus Armbruster --- contrib/gitdm/file

[Qemu-devel] [PATCH 0/2] contrib/gitdm: Minor adjustments

2019-08-22 Thread Markus Armbruster
Markus Armbruster (2): contrib/gitdm: filetype interface is not in order, fix contrib/gitdm: Add arm...@pond.sub.org to group-map-redhat contrib/gitdm/filetypes.txt| 2 +- contrib/gitdm/group-map-redhat | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) -- 2.21.0

[Qemu-devel] [PATCH 2/2] contrib/gitdm: Add arm...@pond.sub.org to group-map-redhat

2019-08-22 Thread Markus Armbruster
Just to get the (few) accidental uses of my private e-mail address attributed correctly. Signed-off-by: Markus Armbruster --- contrib/gitdm/group-map-redhat | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/group-map-redhat b/contrib/gitdm/group-map-redhat index 6d05c6b54f..d15db

Re: [Qemu-devel] [PATCH v2 2/2] Add dbus-vmstate object

2019-08-22 Thread Marc-André Lureau
Hi On Thu, Aug 22, 2019 at 4:20 PM Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > Hi > > > > On Thu, Aug 22, 2019 at 3:41 PM Dr. David Alan Gilbert > > wrote: > > > > > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > > > Hi > > > > >

Re: [Qemu-devel] [PATCH v2 2/2] Add dbus-vmstate object

2019-08-22 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Thu, Aug 22, 2019 at 4:20 PM Dr. David Alan Gilbert > wrote: > > > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > > Hi > > > > > > On Thu, Aug 22, 2019 at 3:41 PM Dr. David Alan Gilbert > > > wrote: > > > > > > >

Re: [Qemu-devel] [PATCH] virtio-blk: Cancel the pending BH when the dataplane is reset

2019-08-22 Thread Stefan Hajnoczi
On Fri, Aug 16, 2019 at 07:15:03PM +0200, Philippe Mathieu-Daudé wrote: > When 'system_reset' is called, the main loop clear the memory > region cache before the BH has a chance to execute. Later when > the deferred function is called, some assumptions that were > made when scheduling them are no l

Re: [Qemu-devel] [Qemu-block] [PATCH] virtio-blk: Cancel the pending BH when the dataplane is reset

2019-08-22 Thread Stefan Hajnoczi
On Fri, Aug 16, 2019 at 02:35:56PM -0400, John Snow wrote: > > > On 8/16/19 1:15 PM, Philippe Mathieu-Daudé wrote: > > When 'system_reset' is called, the main loop clear the memory > > region cache before the BH has a chance to execute. Later when > > the deferred function is called, some assumpt

[Qemu-devel] [PATCH] target/arm: Don't abort on M-profile exception return in linux-user mode

2019-08-22 Thread Peter Maydell
An attempt to do an exception-return (branch to one of the magic addresses) in linux-user mode for M-profile should behave like a normal branch, because linux-user mode is always going to be in 'handler' mode. This used to work, but we broke it when we added support for the M-profile security exten

Re: [Qemu-devel] [PATCH 2/2] xen-bus: Avoid rewriting identical values to xenstore

2019-08-22 Thread Anthony PERARD
On Thu, Aug 22, 2019 at 12:25:44PM +0100, Paul Durrant wrote: > > From: Anthony PERARD > > Sent: 22 August 2019 12:18 > > > > On Thu, Aug 22, 2019 at 11:36:32AM +0100, Paul Durrant wrote: > > > But, now I look at the code again without your patch applied I don't > > > actually see the problem it

Re: [Qemu-devel] [PULL 00/13] Misc patches for 2019-08-21

2019-08-22 Thread Peter Maydell
On Wed, 21 Aug 2019 at 18:40, Paolo Bonzini wrote: > > The following changes since commit e65472c7bc413d79faa61eb1d05c540b03945894: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.2-20190821' > into staging (2019-08-21 14:04:17 +0100) > > are available in the git repository at:

Re: [Qemu-devel] [PATCH 16/16] nvme: support multiple namespaces

2019-08-22 Thread Ross Lagerwall
On 7/5/19 8:23 AM, Klaus Birkelund Jensen wrote: This adds support for multiple namespaces by introducing a new 'nvme-ns' device model. The nvme device creates a bus named from the device name ('id'). The nvme-ns devices then connect to this and registers themselves with the nvme device. This ch

Re: [Qemu-devel] [PATCH 2/2] xen-bus: Avoid rewriting identical values to xenstore

2019-08-22 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD > Sent: 22 August 2019 14:18 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; Stefano Stabellini ; > xen-de...@lists.xenproject.org > Subject: Re: [PATCH 2/2] xen-bus: Avoid rewriting identical values to xenstore > > On Thu, Aug 22, 2019 at 12:

[Qemu-devel] [PATCH] pr-manager: Fix invalid g_free() crash bug

2019-08-22 Thread Markus Armbruster
pr_manager_worker() passes its @opaque argument to g_free(). Wrong; it points to pr_manager_worker()'s automatic @data. Broken when commit 2f3a7ab39be converted @data from heap- to stack-allocated. Fix by deleting the g_free(). Fixes: 2f3a7ab39bec4ba8022dc4d42ea641165b004e3e Cc: qemu-sta...@non

[Qemu-devel] [PULL 0/6] Podman patches

2019-08-22 Thread Marc-André Lureau
The following changes since commit 810923480863c43ecb22ae124156298385439339: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2019-08-22 13:13:35 +0100) are available in the Git repository at: https://github.com/elmarco/qemu.git tags/podman-pull-request for yo

[Qemu-devel] [PULL 1/6] docker.py: add --run-as-current-user

2019-08-22 Thread Marc-André Lureau
(podman will need further tweaks) Suggested-by: Paolo Bonzini Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Daniel P. Berrangé --- tests/docker/Makefile.include | 2 +- tests/docker/docker.py| 5 + 2 files changed, 6 in

[Qemu-devel] [PULL 4/6] tests: specify the address family when checking bind

2019-08-22 Thread Marc-André Lureau
getaddrinfo() may succeed with PF_UNSPEC, but fail when more specific. (this allows to skip some tests that would fail under podman) Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- tests/socket-helpers.c | 17 + tests/socket-helpers.h | 11 --- 2 fi

[Qemu-devel] [PULL 3/6] tests/docker: add podman support

2019-08-22 Thread Marc-André Lureau
Allow to specify the container engine to run with ENGINE variable. By default, ENGINE=auto and will select either podman or docker. Signed-off-by: Marc-André Lureau Reviewed-by: Alex Bennée Reviewed-by: Daniel P. Berrangé --- Makefile | 2 +- tests/docker/Makefile.include

[Qemu-devel] [PULL 2/6] docker.py: add podman support

2019-08-22 Thread Marc-André Lureau
Add a --engine option to select either docker, podman or auto. Among other advantages, podman allows to run rootless & daemonless containers, fortunately sharing compatible CLI with docker. With current podman, we have to use a uidmap trick in order to be able to rw-share the ccache directory wit

[Qemu-devel] [PULL 6/6] test: skip tests if socket_check_protocol_support() failed

2019-08-22 Thread Marc-André Lureau
Skip the tests if socket_check_protocol_support() failed, but do run g_test_run() to keep TAP harness happy. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- tests/test-char.c | 4 +++- tests/test-io-channel-socket.c | 4 +++- tests/test-util-sockets.c | 4

[Qemu-devel] [PULL 5/6] test-char: skip tcp tests if ipv4 check failed

2019-08-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- tests/Makefile.include | 2 +- tests/test-char.c | 17 + 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 39bed753b3..49684fd4f4 100644

[Qemu-devel] [PULL 1/7] s390x/tcg: Fix VERIM with 32/64 bit elements

2019-08-22 Thread Cornelia Huck
From: David Hildenbrand Wrong order of operands. The constant always comes last. Makes QEMU crash reliably on specific git fetch invocations. Reported-by: Stefano Brivio Signed-off-by: David Hildenbrand Message-Id: <20190814151242.27199-1-da...@redhat.com> Reviewed-by: Cornelia Huck Fixes: 5c

[Qemu-devel] [PATCH for-4.1?] compat: disable edid on virtio-gpu base device

2019-08-22 Thread Cornelia Huck
'edid' is a property of the virtio-gpu base device, so turning it off on virtio-gpu-pci is not enough (it misses -ccw). Turn it off on the base device instead. Fixes: 0a71966253c8 ("edid: flip the default to enabled") Signed-off-by: Cornelia Huck --- Only just noticed this... should we still sho

[Qemu-devel] [PULL 0/7] First batch of s390x changes for 4.2

2019-08-22 Thread Cornelia Huck
The following changes since commit f3b8f18ebf344ab359e8f79f6ed777e740dae77c: Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2019-08-21' into staging (2019-08-22 10:31:21 +0100) are available in the Git repository at: https://github.com/cohuck/qemu tags/s390x-201

[Qemu-devel] [PULL 5/7] s390x/tcg: Flush the TLB of all CPUs on SSKE and RRBE

2019-08-22 Thread Cornelia Huck
From: David Hildenbrand Whenever we modify a storage key, we should flush the TLBs of all CPUs, so the MMU fault handling code can properly consider the changed storage key (to e.g., properly set the reference and change bit on the next accesses). These functions are barely used in modern Linux

[Qemu-devel] [PULL 2/7] s390x/mmu: Trace the right value if setting/getting the storage key fails

2019-08-22 Thread Cornelia Huck
From: David Hildenbrand We want to trace the actual return value, not "0". Fixes: 0f5f669147b5 ("s390x: Enable new s390-storage-keys device") Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand Message-Id: <20190816084708.602-2-da...@redhat.com> Signed-off-by:

[Qemu-devel] [PULL 6/7] s390x/mmu: Better storage key reference and change bit handling

2019-08-22 Thread Cornelia Huck
From: David Hildenbrand Any access sets the reference bit. In case we have a read-fault, we should not allow writes to the TLB entry if the change bit was not already set. This is a preparation for proper storage-key reference/change bit handling in TCG and a fix for KVM whereby read accesses wo

Re: [Qemu-devel] [PATCH for-4.1?] compat: disable edid on virtio-gpu base device

2019-08-22 Thread Cornelia Huck
On Thu, 22 Aug 2019 15:58:32 +0200 Cornelia Huck wrote: > 'edid' is a property of the virtio-gpu base device, so turning > it off on virtio-gpu-pci is not enough (it misses -ccw). Turn > it off on the base device instead. > > Fixes: 0a71966253c8 ("edid: flip the default to enabled") > Signed-off

[Qemu-devel] [PULL 3/7] s390x/mmu: ASC selection in s390_cpu_get_phys_page_debug()

2019-08-22 Thread Cornelia Huck
From: David Hildenbrand Let's select the ASC before calling the function. This is a prepararion to remove the ASC magic depending on the access mode from mmu_translate. There is currently no way to distinguish if we have code or data access. For now, we were using code access, because especially

[Qemu-devel] [PULL 7/7] s390x/mmu: Factor out storage key handling

2019-08-22 Thread Cornelia Huck
From: David Hildenbrand Factor it out, add a comment how it all works, and also use it in the REAL MMU. Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand Message-Id: <20190816084708.602-7-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/mmu_

[Qemu-devel] [PULL 4/7] s390x/tcg: Rework MMU selection for instruction fetches

2019-08-22 Thread Cornelia Huck
From: David Hildenbrand Instructions are always fetched from primary address space, except when in home address mode. Perform the selection directly in cpu_mmu_index(). get_mem_index() is only used to perform data access, instructions are fetched via cpu_lduw_code(), which translates to cpu_mmu_

Re: [Qemu-devel] [PATCH 07/13] block: add manage-encryption command (qmp and blockdev)

2019-08-22 Thread Markus Armbruster
Maxim Levitsky writes: > On Wed, 2019-08-21 at 13:47 +0200, Markus Armbruster wrote: >> Maxim Levitsky writes: >> >> > This adds: >> > >> > * x-blockdev-update-encryption and x-blockdev-erase-encryption qmp commands >> > Both commands take the QCryptoKeyManageOptions >> > the x-blockdev-up

[Qemu-devel] [Bug 1840922] Re: qemu-arm for cortex-m33 aborts with unhandled CPU exception 0x8

2019-08-22 Thread Peter Maydell
Just posted https://patchew.org/QEMU/20190822131534.16602-1-peter.mayd...@linaro.org/ which is basically RTH's hack from #8 with a big pile of commentary and commit message... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://

Re: [Qemu-devel] [RFC PATCH qemu] qapi: Add query-memory-checksum

2019-08-22 Thread Markus Armbruster
Alexey Kardashevskiy writes: > This returns MD5 checksum of all RAM blocks for migration debugging > as this is way faster than saving the entire RAM to a file and checking > that. > > Signed-off-by: Alexey Kardashevskiy Any particular reason for MD5? Have you measured the other choices offere

Re: [Qemu-devel] [PULL 0/2] Ui 20190822 patches

2019-08-22 Thread Peter Maydell
> > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/ui-20190822-pull-request > > for you to fetch changes up to a923b471fc59389e49575f38f4db3cd622619bf5: > > input-linux: add shi

Re: [Qemu-devel] [PATCH v3 1/5] socket: Add backlog parameter to socket_listen

2019-08-22 Thread Daniel P . Berrangé
On Tue, Aug 20, 2019 at 01:17:59PM +0200, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > On Tue, Aug 20, 2019 at 12:48:32PM +0200, Juan Quintela wrote: > >> Current parameter was always one. We continue with that value for now > >> in all callers. > >> > >> Signed-off-by: Juan Quintela >

Re: [Qemu-devel] [PATCH v3] qapi: report the default CPU type for each machine

2019-08-22 Thread Eduardo Habkost
On Thu, Aug 22, 2019 at 11:04:12AM +0100, Daniel P. Berrangé wrote: > When user doesn't request any explicit CPU model with libvirt or QEMU, > a machine type specific CPU model is picked. Currently there is no way > to determine what this QEMU built-in default is, so libvirt cannot > report this ba

Re: [Qemu-devel] [PATCH] block: posix: Always allocate the first block

2019-08-22 Thread Max Reitz
On 16.08.19 23:21, Nir Soffer wrote: > When creating an image with preallocation "off" or "falloc", the first > block of the image is typically not allocated. When using Gluster > storage backed by XFS filesystem, reading this block using direct I/O > succeeds regardless of request length, fooling

Re: [Qemu-devel] [Webpage PATCH] add support page

2019-08-22 Thread Stefan Hajnoczi
On Mon, Aug 19, 2019 at 11:57:53AM +0100, Alex Bennée wrote: Good idea! > +If you have a support question that is not answered by our > +[documentation](/documentation) you have a number of options available > +to you. > + > +If the question is specifically about the integration of QEMU with the

Re: [Qemu-devel] [PATCH 02/13] qcrypto-luks: misc refactoring

2019-08-22 Thread Max Reitz
On 22.08.19 01:59, Maxim Levitsky wrote: > On Tue, 2019-08-20 at 19:36 +0200, Max Reitz wrote: >> On 14.08.19 22:22, Maxim Levitsky wrote: >>> This is also a preparation for key read/write/erase functions >>> >>> * use master key len from the header >>> * prefer to use crypto params in the QCryptoB

Re: [Qemu-devel] [PATCH 01/13] block-crypto: misc refactoring

2019-08-22 Thread Max Reitz
On 22.08.19 02:05, Maxim Levitsky wrote: > On Tue, 2019-08-20 at 18:38 +0200, Max Reitz wrote: >> On 14.08.19 22:22, Maxim Levitsky wrote: >>> * rename the write_func to create_write_func, >>> and init_func to create_init_func >>> this is preparation for other write_func that will >>> be use

[Qemu-devel] [Bug 1840922] Re: qemu-arm for cortex-m33 aborts with unhandled CPU exception 0x8

2019-08-22 Thread Christophe Lyon
Thanks Peter and Richard for the quick patch. It works for me. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1840922 Title: qemu-arm for cortex-m33 aborts with unhandled CPU exception 0x8 Status i

[Qemu-devel] [RFC PATCH 2/2] Delay crash when mbufs are corrupted

2019-08-22 Thread Philippe Mathieu-Daudé
If the mbufs linked list is corrupted, give the application a chance to properly shutdown itself without causing dataloss. For now, this means slowly leaking the heap. Signed-off-by: Philippe Mathieu-Daudé --- src/ip_input.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/ip_in

Re: [Qemu-devel] [PATCH v1 1/2] accel/tcg: adding integration with linux perf

2019-08-22 Thread Stefan Hajnoczi
On Thu, Aug 15, 2019 at 05:17:49PM +0100, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > On Wed, Aug 14, 2019 at 11:37:24PM -0300, vandersonmr wrote: > >> This commit adds support to Linux Perf in order > >> to be able to analyze qemu jitted code and > >> also to able to see the TBs PC in

Re: [Qemu-devel] [PATCH 12/13] qemu-img: implement key management

2019-08-22 Thread Max Reitz
On 22.08.19 13:32, Daniel P. Berrangé wrote: > On Tue, Aug 20, 2019 at 08:29:55PM +0200, Max Reitz wrote: >> On 14.08.19 22:22, Maxim Levitsky wrote: >>> Signed-off-by: Maxim Levitsky >>> --- >>> block/crypto.c | 16 ++ >>> block/crypto.h | 3 + >>> qemu-img-cmds.hx | 13 + >>> qe

Re: [Qemu-devel] [PATCH v1 1/2] accel/tcg: adding integration with linux perf

2019-08-22 Thread Stefan Hajnoczi
On Wed, Aug 21, 2019 at 04:01:48PM -0300, Vanderson Martins do Rosario wrote: > On Thu, Aug 15, 2019 at 11:40 AM Stefan Hajnoczi wrote: > > On Wed, Aug 14, 2019 at 11:37:24PM -0300, vandersonmr wrote: > > > +void start_jitdump_file(void) > > > +{ > > > +GString *dumpfile_name = g_string_new(NU

[Qemu-devel] [PATCH 0/2] slirp: Fix heap buffer overflow during packet reassembly (CVE-2019-14378)

2019-08-22 Thread Philippe Mathieu-Daudé
Hi, this is a SLiRP bug, however as QEMU comsumes the library, it is directly concerned, so I'm cross-posting both QEMU and SLiRP lists for a stricter review. The 2nd patch is a PoC, to give QEMU a chance to shutdown properly if SLiRP internals get corrupted. Simply sent as RFC. The vulnerability

Re: [Qemu-devel] [Qemu-block] [PATCH v2 00/12] block: qiov_offset parameter for io

2019-08-22 Thread Stefan Hajnoczi
On Thu, Aug 15, 2019 at 11:12:35AM +, Vladimir Sementsov-Ogievskiy wrote: > 29.07.2019 18:24, Stefan Hajnoczi wrote: > > On Tue, Jun 04, 2019 at 07:15:02PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > >> Hi all! > >> > >> Here is new parameter qiov_offset for io path, to avoid > >> a lot o

[Qemu-devel] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-22 Thread Philippe Mathieu-Daudé
The vulnerability CVE-2019-14378 is well explained in [1]: The bug is triggered when large IPv4 fragmented packets are reassembled for processing. For the NAT translation if the incoming packets are fragmented they should be reassembled before they are edited and re-transmitted. This

Re: [Qemu-devel] [RFC PATCH qemu] qapi: Add query-memory-checksum

2019-08-22 Thread Daniel P . Berrangé
On Thu, Aug 22, 2019 at 04:16:53PM +0200, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > > > This returns MD5 checksum of all RAM blocks for migration debugging > > as this is way faster than saving the entire RAM to a file and checking > > that. > > > > Signed-off-by: Alexey Kardashev

Re: [Qemu-devel] [PATCH for-4.1?] compat: disable edid on virtio-gpu base device

2019-08-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190822135839.32340-2-coh...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH for-4.1?] compat: disable edid on virtio-gpu base device Message-id: 20190

Re: [Qemu-devel] [PATCH] pr-manager: Fix invalid g_free() crash bug

2019-08-22 Thread Philippe Mathieu-Daudé
On 8/22/19 3:38 PM, Markus Armbruster wrote: > pr_manager_worker() passes its @opaque argument to g_free(). Wrong; > it points to pr_manager_worker()'s automatic @data. Broken when > commit 2f3a7ab39be converted @data from heap- to stack-allocated. Fix > by deleting the g_free(). > > Fixes: 2f3

Re: [Qemu-devel] [PATCH] virtio-blk: Cancel the pending BH when the dataplane is reset

2019-08-22 Thread Philippe Mathieu-Daudé
On 8/22/19 3:01 PM, Stefan Hajnoczi wrote: > On Fri, Aug 16, 2019 at 07:15:03PM +0200, Philippe Mathieu-Daudé wrote: >> When 'system_reset' is called, the main loop clear the memory >> region cache before the BH has a chance to execute. Later when >> the deferred function is called, some assumption

Re: [Qemu-devel] [PATCH 1/2] xen-bus: Fix backend state transition on device reset

2019-08-22 Thread Anthony PERARD
On Thu, Aug 22, 2019 at 10:59:38AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Anthony PERARD > > Sent: 22 August 2019 10:51 > > To: Paul Durrant > > Cc: qemu-devel@nongnu.org; qemu-sta...@nongnu.org; Stefano Stabellini > > ; xen- > > de...@lists.xenproject.org > > Subjec

Re: [Qemu-devel] [PATCH 01/13] block-crypto: misc refactoring

2019-08-22 Thread Maxim Levitsky
On Thu, 2019-08-22 at 16:34 +0200, Max Reitz wrote: > On 22.08.19 02:05, Maxim Levitsky wrote: > > On Tue, 2019-08-20 at 18:38 +0200, Max Reitz wrote: > > > On 14.08.19 22:22, Maxim Levitsky wrote: > > > > * rename the write_func to create_write_func, > > > > and init_func to create_init_func > >

Re: [Qemu-devel] [PULL 0/5] Usb 20190822 patches

2019-08-22 Thread Peter Maydell
> > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/usb-20190822-pull-request > > for you to fetch changes up to 1be344b7ad25d572dadeee46d80f0103354352b2: > > ehci: fix queue-

Re: [Qemu-devel] [PATCH-for-4.2 v3 5/5] hw/arm/smmuv3: Remove spurious error messages on IOVA invalidations

2019-08-22 Thread Auger Eric
Hi Peter, On 8/5/19 4:39 PM, Peter Maydell wrote: > On Thu, 11 Jul 2019 at 07:19, Eric Auger wrote: >> >> An IOVA/ASID invalidation is notified to all IOMMU Memory Regions >> through smmuv3_inv_notifiers_iova/smmuv3_notify_iova. >> >> When the notification occurs it is possible that some of the >

Re: [Qemu-devel] [PATCH-for-4.2 v3 3/5] hw/vfio/common: Assert in case of nested mode

2019-08-22 Thread Auger Eric
Hi Peter, On 8/5/19 4:41 PM, Peter Maydell wrote: > On Thu, 11 Jul 2019 at 07:19, Eric Auger wrote: >> >> As of today, VFIO only works along with vIOMMU supporting >> caching mode. The SMMUv3 does not support this mode and >> requires HW nested paging to work properly with VFIO. >> >> So any attem

Re: [Qemu-devel] [PATCH-for-4.2 v3 2/5] memory: Add IOMMU_ATTR_VFIO_NESTED IOMMU memory region attribute

2019-08-22 Thread Auger Eric
Hi Alex, Peter, On 8/8/19 5:07 AM, Alex Williamson wrote: > On Thu, 11 Jul 2019 08:18:54 +0200 > Eric Auger wrote: > >> We introduce a new IOMMU Memory Region attribute, >> IOMMU_ATTR_VFIO_NESTED that tells whether the virtual IOMMU >> requires HW nested paging for VFIO integration. >> >> Curren

Re: [Qemu-devel] [QEMU] [PATCH v5 3/8] bootdevice: Add interface to gather LCHS

2019-08-22 Thread Sam Eiderman via Qemu-devel
> I’ve got a couple of “undelivered mail returned to sender” mails for Sam > recently, but anyway... - shmuel.eider...@oracle.com + sam...@google.com > It doesn’t look like any caller actually passes a NULL @dev, so why not > drop the @suffix part? Just copied it from the bootindex implementatio

Re: [Qemu-devel] Broken aarch64 by qcow2: skip writing zero buffers to empty COW areas [v2]

2019-08-22 Thread Max Reitz
On 22.08.19 14:09, Max Reitz wrote: > (CC-ing Paolo because of the XFS connection, and Stefan because why not.) > > On 22.08.19 13:27, Lukáš Doktor wrote: >> Dne 21. 08. 19 v 19:51 Max Reitz napsal(a): >>> On 21.08.19 16:14, Lukáš Doktor wrote: Hello guys, First attempt was rejected

Re: [Qemu-devel] Broken aarch64 by qcow2: skip writing zero buffers to empty COW areas [v2]

2019-08-22 Thread Max Reitz
On 22.08.19 17:25, Max Reitz wrote: > On 22.08.19 14:09, Max Reitz wrote: >> (CC-ing Paolo because of the XFS connection, and Stefan because why not.) >> >> On 22.08.19 13:27, Lukáš Doktor wrote: >>> Dne 21. 08. 19 v 19:51 Max Reitz napsal(a): On 21.08.19 16:14, Lukáš Doktor wrote: > Hello

[Qemu-devel] 'make check-unit' breakage on s390x host

2019-08-22 Thread Cornelia Huck
I just noticed a breakage with 'make check-unit' when running on an s390x host (on my laptop, it runs fine; haven't tried other architectures). This happens with current master, but I managed to track the original breakage down to commit ff3dc8fefe953fd3650279e064bf63b212c5699a Author: Daniel P. B

Re: [Qemu-devel] [PATCH v2 00/12] block: qiov_offset parameter for io

2019-08-22 Thread Stefan Hajnoczi
On Tue, Jun 04, 2019 at 07:15:02PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is new parameter qiov_offset for io path, to avoid > a lot of places with same pattern of creating local_qiov or hd_qiov > variables. > > These series also includes my > "[Qemu-devel] [PATCH 0/2] bloc

Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs

2019-08-22 Thread Stefan Hajnoczi
On Wed, Aug 21, 2019 at 09:07:25PM -0700, Raphael Norwitz wrote: > On Fri, Jun 14, 2019 at 10:18:41AM +0100, Stefan Hajnoczi wrote: > > On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote: > > > Of the 3 virtqueues, seabios only sets cmd, leaving ctrl > > > and event without a physical

[Qemu-devel] [PULL 0/2] Block patches

2019-08-22 Thread Stefan Hajnoczi
The following changes since commit 33f18cf7dca7741d3647d514040904ce83edd73d: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20190821-pull-request' into staging (2019-08-21 15:18:50 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/block-pull-

[Qemu-devel] [PULL 1/2] util/async: hold AioContext ref to prevent use-after-free

2019-08-22 Thread Stefan Hajnoczi
The tests/test-bdrv-drain /bdrv-drain/iothread/drain test case does the following: 1. The preadv coroutine calls aio_bh_schedule_oneshot() and then yields. 2. The one-shot BH executes in another AioContext. All it does is call aio_co_wakeup(preadv_co). 3. The preadv coroutine is re-entered and

Re: [Qemu-devel] 'make check-unit' breakage on s390x host

2019-08-22 Thread Daniel P . Berrangé
On Thu, Aug 22, 2019 at 05:44:47PM +0200, Cornelia Huck wrote: > I just noticed a breakage with 'make check-unit' when running on an > s390x host (on my laptop, it runs fine; haven't tried other > architectures). This happens with current master, but I managed to > track the original breakage down

[Qemu-devel] [PULL 2/2] vhost-user-scsi: prevent using uninitialized vqs

2019-08-22 Thread Stefan Hajnoczi
From: Raphael Norwitz Of the 3 virtqueues, seabios only sets cmd, leaving ctrl and event without a physical address. This can cause vhost_verify_ring_part_mapping to return ENOMEM, causing the following logs: qemu-system-x86_64: Unable to map available ring for ring 0 qemu-system-x86_64: Verify

Re: [Qemu-devel] 'make check-unit' breakage on s390x host

2019-08-22 Thread Cornelia Huck
On Thu, 22 Aug 2019 16:55:13 +0100 Daniel P. Berrangé wrote: > On Thu, Aug 22, 2019 at 05:44:47PM +0200, Cornelia Huck wrote: > > I just noticed a breakage with 'make check-unit' when running on an > > s390x host (on my laptop, it runs fine; haven't tried other > > architectures). This happens wi

Re: [Qemu-devel] [PATCH v2 03/68] target/arm: Convert Data Processing (register)

2019-08-22 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Convert the register shifted by immediate form of the data > processing insns. For A32, we cannot yet remove any code > because the legacy decoder intertwines the reg-shifted-reg > and immediate forms. > > Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PULL 0/8] Vga 20190822 patches

2019-08-22 Thread Peter Maydell
> > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/vga-20190822-pull-request > > for you to fetch changes up to b7105d280cab053465de79ff1766d2f7e1ea7554: > > ati-vga: Implement dummy VBlank IRQ (2019-08-22 10:04:20 +0200) > > ---

Re: [Qemu-devel] [PATCH] tests: make filemonitor test more robust to event ordering

2019-08-22 Thread Cornelia Huck
On Wed, 21 Aug 2019 16:53:27 +0100 Daniel P. Berrangé wrote: > The ordering of events that are emitted during the rmdir > test have changed with kernel >= 5.3. Semantically both > new & old orderings are correct, so we must be able to > cope with either. > > To cope with this, when we see an une

[Qemu-devel] [PATCH 1/2] block/file-posix: Fix xfs_write_zeroes()

2019-08-22 Thread Max Reitz
Calling ftruncate() in xfs_write_zeroes() is dangerous because it may yield and then discard data that parallel write requests have written past the old EOF in the meantime. We must not use it here. Instead, return -ENOTSUP and let the more generic fallocate code handle writing zeroes past the EO

[Qemu-devel] [PATCH 0/2] block/file-posix: Fix xfs_write_zeroes()

2019-08-22 Thread Max Reitz
Lukàš ran over a nasty regression in our xfs_write_zeroes() function (sorry, my fault) made apparent by a recent patch from Anton that makes qcow2 images heavily exercise the offending code path. This series fixes the bug and adds a test to prevent it from reoccurring. Max Reitz (2): block/fil

[Qemu-devel] [PATCH 2/2] iotests: Test reverse sub-cluster qcow2 writes

2019-08-22 Thread Max Reitz
This exercises the regression introduced in commit 50ba5b2d994853b38fed10e0841b119da0f8b8e5. On my machine, it has close to a 50 % false-negative rate, but that should still be sufficient to test the fix. Signed-off-by: Max Reitz --- tests/qemu-iotests/265 | 67 +

Re: [Qemu-devel] more automated/public CI for QEMU pullreqs

2019-08-22 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Aug 16, 2019 at 07:16:55PM +0100, Peter Maydell wrote: > > The two major contenders suggested were: > > > > (1) GitLab CI, which supports custom 'runners' which we can set > > up to run builds and tests on machines we have project access

Re: [Qemu-devel] Broken aarch64 by qcow2: skip writing zero buffers to empty COW areas [v2]

2019-08-22 Thread Max Reitz
On 22.08.19 17:40, Max Reitz wrote: > On 22.08.19 17:25, Max Reitz wrote: >> On 22.08.19 14:09, Max Reitz wrote: >>> (CC-ing Paolo because of the XFS connection, and Stefan because why not.) >>> >>> On 22.08.19 13:27, Lukáš Doktor wrote: Dne 21. 08. 19 v 19:51 Max Reitz napsal(a): > On 21.

Re: [Qemu-devel] [PATCH] pr-manager: Fix invalid g_free() crash bug

2019-08-22 Thread Paolo Bonzini
On 22/08/19 15:38, Markus Armbruster wrote: > pr_manager_worker() passes its @opaque argument to g_free(). Wrong; > it points to pr_manager_worker()'s automatic @data. Broken when > commit 2f3a7ab39be converted @data from heap- to stack-allocated. Fix > by deleting the g_free(). > > Fixes: 2f3a

Re: [Qemu-devel] [PATCH] block: posix: Always allocate the first block

2019-08-22 Thread Nir Soffer
On Thu, Aug 22, 2019 at 5:28 PM Max Reitz wrote: > On 16.08.19 23:21, Nir Soffer wrote: > > When creating an image with preallocation "off" or "falloc", the first > > block of the image is typically not allocated. When using Gluster > > storage backed by XFS filesystem, reading this block using d

Re: [Qemu-devel] more automated/public CI for QEMU pullreqs

2019-08-22 Thread Paolo Bonzini
On 22/08/19 18:31, Dr. David Alan Gilbert wrote: >> With both these points in mind, I think it is pretty hard sell to >> say we should write & maintain a custom CI system just for QEMU >> unless it is offering major compelling functionality we can't do >> without. In theory I agree. In practice,

Re: [Qemu-devel] [PATCH 1/4] configure: keep track of Python version

2019-08-22 Thread Peter Maydell
On Fri, 9 Nov 2018 at 15:09, Cleber Rosa wrote: > > Some functionality is dependent on the Python version > detected/configured on configure. While it's possible to run the > Python version later and check for the version, doing it once is > preferable. Also, it's a relevant information to keep

Re: [Qemu-devel] more automated/public CI for QEMU pullreqs

2019-08-22 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 22/08/19 18:31, Dr. David Alan Gilbert wrote: > >> With both these points in mind, I think it is pretty hard sell to > >> say we should write & maintain a custom CI system just for QEMU > >> unless it is offering major compelling functionality we c

<    1   2   3   4   >