Re: [PATCH v1 2/4] virtio: make seg_max virtqueue size dependent

2019-11-07 Thread Denis Plotnikov
The 1st patch from the series seems to be useless. The patch extending queue length by adding machine type may break vm-s which use seabios with max queue size = 128. Looks like only this patch doesn't break anything and helps to express queue size and seg max dependency (the specification

Re: guest / host buffer sharing ...

2019-11-07 Thread Stefan Hajnoczi
On Fri, Nov 8, 2019 at 8:22 AM Gerd Hoffmann wrote: > > > Adding a list of common properties to the spec certainly makes sense, > > > so everybody uses the same names. Adding struct-ed properties for > > > common use cases might be useful too. > > > > Why not define VIRTIO devices for wayland

Re: guest / host buffer sharing ...

2019-11-07 Thread Gerd Hoffmann
Hi, > > Adding a list of common properties to the spec certainly makes sense, > > so everybody uses the same names. Adding struct-ed properties for > > common use cases might be useful too. > > Why not define VIRTIO devices for wayland and friends? There is an out-of-tree implementation of

Re: [PATCH v1 4/4] iotests: add test for virtio-scsi and virtio-blk machine type settings

2019-11-07 Thread Denis Plotnikov
On 07.11.2019 19:30, Cleber Rosa wrote: > On Wed, Nov 06, 2019 at 04:26:41PM -0300, Eduardo Habkost wrote: >> On Wed, Nov 06, 2019 at 11:04:16AM +0100, Max Reitz wrote: >>> On 06.11.19 10:24, Stefan Hajnoczi wrote: On Tue, Nov 05, 2019 at 07:11:05PM +0300, Denis Plotnikov wrote: > It

Re: [virtio-dev] Re: guest / host buffer sharing ...

2019-11-07 Thread Gerd Hoffmann
On Thu, Nov 07, 2019 at 11:16:18AM +, Dr. David Alan Gilbert wrote: > * Gerd Hoffmann (kra...@redhat.com) wrote: > > Hi, > > > > > > This is not about host memory, buffers are in guest ram, everything else > > > > would make sharing those buffers between drivers inside the guest (as > > > >

Deprecating stuff for 4.2 (was: [Qemu-devel] Exposing feature deprecation to machine clients)

2019-11-07 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 07.11.2019 21:52, Philippe Mathieu-Daudé wrote: [...] >> Pre-release period, time to deprecate some stuffs :) >> >> How should we proceed? Do you have something in mind? >> >> There are older threads about this. Should we start a new thread? Gather the

Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time

2019-11-07 Thread Tao Xu
On 11/7/2019 9:31 PM, Eduardo Habkost wrote: On Thu, Nov 07, 2019 at 02:24:52PM +0800, Tao Xu wrote: On 11/7/2019 4:53 AM, Eduardo Habkost wrote: On Mon, Oct 28, 2019 at 03:52:12PM +0800, Tao Xu wrote: Add tests for time input such as zero, around limit of precision, signed upper limit,

Re: The problems about COLO

2019-11-07 Thread Daniel Cho
Lukas Straub 於 2019年11月7日 週四 下午9:34寫道: > On Thu, 7 Nov 2019 16:14:43 +0800 > Daniel Cho wrote: > > > Hi Lukas, > > Thanks for your reply. > > > > However, we test the question 1 with steps below the error message, we > > notice the secondary VM's image > > will break while it reboots. > >

RE: [PATCH V2 0/4] Introduce Advanced Watch Dog module

2019-11-07 Thread Zhang, Chen
Hi~ All~ Ping Anyone have time to review this series? I need more comments~ Thanks Zhang Chen > -Original Message- > From: Zhang, Chen > Sent: Friday, November 1, 2019 10:49 AM > To: Jason Wang ; Paolo Bonzini > ; Philippe Mathieu-Daudé ; > qemu-dev > Cc: Zhang Chen ; Zhang, Chen

Re: Looking for issues/features for my first contribution

2019-11-07 Thread Rajath Shashidhara
On 07-11-2019 07:33, Aleksandar Markovic wrote: I did a quick Google search on datasheets of existing RTC implemtations, and the result is: DS1338: https://datasheets.maximintegrated.com/en/ds/DS1338-DS1338Z.pdf M41T80: https://www.st.com/resource/en/datasheet/m41t80.pdf M48T59:

Re: [RFC v2 11/14] linux-headers/kvm.h: add capability to forward hypercall

2019-11-07 Thread Guoheyi
On 2019/11/7 20:12, Cornelia Huck wrote: On Thu, 7 Nov 2019 19:57:22 +0800 Guoheyi wrote: On 2019/11/7 16:57, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 09:44:36AM +0800, Guoheyi wrote: On 2019/11/7 1:55, Cornelia Huck wrote: On Tue, 5 Nov 2019 17:10:53 +0800 Heyi Guo wrote:

Re: [PATCH v15 00/12] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-11-07 Thread Tao Xu
On 11/7/2019 5:03 PM, Michael S. Tsirkin wrote: On Thu, Nov 07, 2019 at 03:44:59PM +0800, Tao Xu wrote: This series of patches will build Heterogeneous Memory Attribute Table (HMAT) according to the command line. The ACPI HMAT describes the memory attributes, such as memory side cache

Re: [Patch v2 5/6] migration/postcopy: enable random order target page arrival

2019-11-07 Thread Wei Yang
On Thu, Nov 07, 2019 at 02:30:25PM +, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> After using number of target page received to track one host page, we >> could have the capability to handle random order target page arrival in >> one host page. >> >>

[ANNOUNCE] QEMU 4.2.0-rc0 is now available

2019-11-07 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 4.2 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-4.2.0-rc0.tar.xz

RE: [PATCH v2] WHPX: support for xcr0

2019-11-07 Thread Sunil Muthuswamy
> > You will need the Windows 10 SDK for RS5 (build 17763) or above to > > to be able to compile this patch because of the definition of the > > XCR0 register. > > > > Changes since v1: > > - Added a sign-off line in the patch. > > > I am not very happy with the current situation which suggests

Re: [PATCH 4/4] Added tests for close and change of logfile.

2019-11-07 Thread Robert Foley
On Thu, 7 Nov 2019 at 15:12, Alex Bennée wrote: > > > > For a fix, we could put this at the beginning of qemu_set_log_filename(). > > if (logfilename) { > > g_free(logfilename); > > logfilename = NULL; > > } > > g_free(logfilename) should be safe against NULL. However we need to > ensure

Re: [PATCH 0/3] Some memory leak fixes

2019-11-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191107192731.17330-1-marcandre.lur...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH 1/4] Add a mutex to guarantee single writer to qemu_logfile handle.

2019-11-07 Thread Robert Foley
On Thu, 7 Nov 2019 at 11:53, Alex Bennée wrote: > > It wouldn't be the worst thing in the world to expose: > > qemu_logfile_init() > > and make vl.c and main.c call it before the setup. Then you can drop the > flag or even just g_assert(qemu_log_mutex_initialised) in qemu_set_log > and

Re: [PATCH 4/4] Added tests for close and change of logfile.

2019-11-07 Thread Robert Foley
Agree with all the suggestions below. These are great ideas. Will make the changes. Thanks, -Rob Foley On Thu, 7 Nov 2019 at 11:32, Alex Bennée wrote: > > > Robert Foley writes: > > > One test ensures that the logfile handle is still valid even if > > the logfile is changed during logging. >

Re: [PATCH 3/4] qemu_log_lock/unlock now preserves the qemu_logfile handle.

2019-11-07 Thread Robert Foley
On Thu, 7 Nov 2019 at 11:25, Alex Bennée wrote: > > Ahh there it is! > > We probably want to put the API change through before we add the RCU > support - so swap the patch order around. > Absolutely, we will swap around the order of the patch. -Rob Foley On Thu, 7 Nov 2019 at 11:25, Alex

Re: [PATCH 2/4] Add use of RCU for qemu_logfile.

2019-11-07 Thread Robert Foley
On Thu, 7 Nov 2019 at 11:24, Alex Bennée wrote: > > Robert Foley writes: > > diff --git a/include/qemu/log.h b/include/qemu/log.h > > index a91105b2ad..975de18e23 100644 > > --- a/include/qemu/log.h > > +++ b/include/qemu/log.h > > @@ -3,9 +3,17 @@ > > > > /* A small part of this API is split

Re: [PATCH v3 00/22] iotests: Allow ./check -o data_file

2019-11-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191107163708.833192-1-mre...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v3 00/22] iotests: Allow ./check -o data_file Type: series Message-id:

Re: [PATCH 2/3] qtest: fix qtest_qmp_device_add leak

2019-11-07 Thread Marc-André Lureau
Hi On Fri, Nov 8, 2019 at 12:31 AM Laurent Vivier wrote: > > On 07/11/2019 20:27, Marc-André Lureau wrote: > > Spotted by ASAN. > > > > Signed-off-by: Marc-André Lureau > > --- > > tests/libqtest.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/libqtest.c

Re: [RFC PATCH 02/18] qemu-storage-daemon: Add --object option

2019-11-07 Thread Markus Armbruster
Kevin Wolf writes: > Add a command line option to create user-creatable QOM objects. > > Signed-off-by: Kevin Wolf > --- > qemu-storage-daemon.c | 35 +++ > 1 file changed, 35 insertions(+) > > diff --git a/qemu-storage-daemon.c b/qemu-storage-daemon.c > index

Re: [PATCH v7 7/8] Acceptance tests: depend on qemu-img

2019-11-07 Thread Wainer dos Santos Moschetta
On 11/4/19 1:13 PM, Cleber Rosa wrote: Tests using the avocado.utils.vmimage library make use of qemu-img, and because it makes sense to use the version matching the rest of the source code, let's make sure it gets built. Its selection, instead of a possible qemu-img binary installed system

Re: [PATCH 2/3] qtest: fix qtest_qmp_device_add leak

2019-11-07 Thread Laurent Vivier
On 07/11/2019 20:27, Marc-André Lureau wrote: > Spotted by ASAN. > > Signed-off-by: Marc-André Lureau > --- > tests/libqtest.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/libqtest.c b/tests/libqtest.c > index 3706bccd8d..91e9cb220c 100644 > --- a/tests/libqtest.c > +++

Re: [PATCH 4/4] Added tests for close and change of logfile.

2019-11-07 Thread Alex Bennée
Robert Foley writes: > Thanks for providing the stack trace. > > We debugged this and it seems to come about because of an interesting > circumstance. We added our new tests after a pre-existing test, > parse_path(), which runs into an issue, a dangling pointer, which > could lead to a double

Re: [PATCH v2] WHPX: support for xcr0

2019-11-07 Thread Stefan Weil
Am 07.11.19 um 20:48 schrieb Sunil Muthuswamy: > Support for xcr0 to be able to enable xsave/xrstor. This by itself > is not sufficient to enable xsave/xrstor. WHPX XSAVE API's also > needs to be hooked up. > > Signed-off-by: Sunil Muthuswamy > --- > You will need the Windows 10 SDK for RS5

Re: Should QEMU's configure script check for bzip2 ?

2019-11-07 Thread Wainer dos Santos Moschetta
On 11/7/19 5:43 PM, Thomas Huth wrote:  Hi, I just tried to compile QEMU on a freshly installed system. "configure" finished without problems, but during "make" I hit this error:   BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2: command not found make: *** [Makefile:305:

[PATCH v2] WHPX: support for xcr0

2019-11-07 Thread Sunil Muthuswamy
Support for xcr0 to be able to enable xsave/xrstor. This by itself is not sufficient to enable xsave/xrstor. WHPX XSAVE API's also needs to be hooked up. Signed-off-by: Sunil Muthuswamy --- You will need the Windows 10 SDK for RS5 (build 17763) or above to to be able to compile this patch

Re: [PATCH v7 6/8] Acceptance tests: add the build directory to the system PATH

2019-11-07 Thread Wainer dos Santos Moschetta
On 11/4/19 1:13 PM, Cleber Rosa wrote: So that when binaries such as qemu-img are searched for, those in the build tree will be favored. As a clarification, SRC_ROOT_DIR is dependent on the location from where tests are executed, so they are equal to the build directory if one is being used.

Should QEMU's configure script check for bzip2 ?

2019-11-07 Thread Thomas Huth
Hi, I just tried to compile QEMU on a freshly installed system. "configure" finished without problems, but during "make" I hit this error: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2: command not found make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127

Re: [PATCH 4/4] Added tests for close and change of logfile.

2019-11-07 Thread Robert Foley
Thanks for providing the stack trace. We debugged this and it seems to come about because of an interesting circumstance. We added our new tests after a pre-existing test, parse_path(), which runs into an issue, a dangling pointer, which could lead to a double free. There were no other tests

Re: [PATCH-for-4.1? 0/7] vl: Allow building with CONFIG_BLUETOOTH disabled

2019-11-07 Thread Thomas Huth
On 07/11/2019 20.09, Philippe Mathieu-Daudé wrote: [...] Bluetooth is dead, long live BT! v4.2.0-rc0 just got tagged. We should stop linking unmaintained dead code. If nobody step in to nuke BT, we should consider applying this series before we release QEMU 5.0 with dead Bluetooth. This

[PATCH 2/3] qtest: fix qtest_qmp_device_add leak

2019-11-07 Thread Marc-André Lureau
Spotted by ASAN. Signed-off-by: Marc-André Lureau --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 3706bccd8d..91e9cb220c 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -1274,6 +1274,7 @@ void

[PATCH 1/3] virtio-input: fix memory leak on unrealize

2019-11-07 Thread Marc-André Lureau
Spotted by ASAN + minor stylistic change. Signed-off-by: Marc-André Lureau --- hw/input/virtio-input.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/input/virtio-input.c b/hw/input/virtio-input.c index 51617a5885..ec54e46ad6 100644 --- a/hw/input/virtio-input.c +++

[PATCH 0/3] Some memory leak fixes

2019-11-07 Thread Marc-André Lureau
Hi, Another bunch of fixes spotted by ASAN when running check-qtest-x86_64. Marc-André Lureau (3): virtio-input: fix memory leak on unrealize qtest: fix qtest_qmp_device_add leak cpu-plug-test: fix leaks hw/input/virtio-input.c | 3 +++ tests/cpu-plug-test.c | 2 ++ tests/libqtest.c

[PATCH 3/3] cpu-plug-test: fix leaks

2019-11-07 Thread Marc-André Lureau
Spotted by ASAN. Signed-off-by: Marc-André Lureau --- tests/cpu-plug-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cpu-plug-test.c b/tests/cpu-plug-test.c index 058cef5ac1..30e514bbfb 100644 --- a/tests/cpu-plug-test.c +++ b/tests/cpu-plug-test.c @@ -99,6 +99,7 @@ static

Re: [PATCH v7 5/8] Acceptance tests: keep a stable reference to the QEMU build dir

2019-11-07 Thread Wainer dos Santos Moschetta
On 11/4/19 1:13 PM, Cleber Rosa wrote: This is related to the the differences in in-tree and out-of-tree builds in QEMU. For simplification, means my build directory. Currently, by running a `make check-acceptance` one gets (in tests/acceptance/avocado_qemu/__init__.py): SRC_ROOT_DIR:

Re: [PATCH v1 Resend] target/i386: set the CPUID level to 0x14 on old machine-type

2019-11-07 Thread Eduardo Habkost
On Wed, Nov 06, 2019 at 12:55:32AM +, Kang, Luwei wrote: > > > The CPUID level need to be set to 0x14 manually on old machine-type if > > > Intel PT is enabled in guest. e.g. in Qemu 3.1 -machine pc-i440fx-3.1 > > > -cpu qemu64,+intel-pt will be CPUID[0].EAX(level)=7 and > > >

Re: [Qemu-devel] Exposing feature deprecation to machine clients

2019-11-07 Thread Vladimir Sementsov-Ogievskiy
07.11.2019 21:52, Philippe Mathieu-Daudé wrote: > Hi Markus, > > On 8/15/19 7:40 PM, John Snow wrote: >> On 8/15/19 10:16 AM, Markus Armbruster wrote: >>> John Snow writes: > [...] I asked Markus this not too long ago; do we want to amend the QAPI schema specification to allow commands

Re: [PATCH-for-4.1? 0/7] vl: Allow building with CONFIG_BLUETOOTH disabled

2019-11-07 Thread Philippe Mathieu-Daudé
On 8/14/19 2:45 PM, Philippe Mathieu-Daudé wrote: On 8/13/19 4:04 PM, Peter Maydell wrote: On Tue, 13 Aug 2019 at 15:01, Philippe Mathieu-Daudé wrote: On 7/15/19 3:13 PM, Thomas Huth wrote: On 12/07/2019 15.39, Philippe Mathieu-Daudé wrote: A series of obvious patches to build without the

Re: [PATCH v2] virtio: notify virtqueue via host notifier when available

2019-11-07 Thread Felipe Franciosi
Thanks Stefan for the quick fix! Sorry for not adding a Tested-by. It's implicit. :) F. > On Nov 6, 2019, at 11:33 AM, Michael S. Tsirkin wrote: > > On Tue, Nov 05, 2019 at 03:09:46PM +0100, Stefan Hajnoczi wrote: >> Host notifiers are used in several cases: >> 1. Traditional ioeventfd where

Re: [PULL 0/1] Usb 20191107 patches

2019-11-07 Thread Peter Maydell
acb28c4544858c66a3: > >> > >>Merge remote-tracking branch > >> 'remotes/philmd-gitlab/tags/fw_cfg-next-pull-request' into staging > >> (2019-11-05 20:17:11 +) > >> > >> are available in the Git repository at: > >

Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size

2019-11-07 Thread Alex Bennée
Alistair Francis writes: > On Thu, Nov 7, 2019 at 10:01 AM Peter Maydell > wrote: >> >> On Thu, 7 Nov 2019 at 17:09, Palmer Dabbelt wrote: >> > >> > On Wed, 06 Nov 2019 16:47:20 PST (-0800), Alistair Francis wrote: >> > > Coreboot developers have requested that they have at least 32MB of

Re: [PULL 0/1] Usb 20191107 patches

2019-11-07 Thread Philippe Mathieu-Daudé
20:17:11 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20191107-pull-request for you to fetch changes up to 1dfe2b91dcb1633d0ba450a8139d53006e700a9b: usb-host: add option to allow all resets. (2019-11-06 13:26:04 +0100

Re: [PATCH v7 4/8] Acceptance tests: use relative location for tests

2019-11-07 Thread Wainer dos Santos Moschetta
On 11/4/19 1:13 PM, Cleber Rosa wrote: An Avocado Test ID[1] is composed by a number of components, but it starts with the Test Name, usually a file system location that was given to the loader. Because the source directory is being given as a prefix to the "tests/acceptance" directory

Re: Looking for issues/features for my first contribution

2019-11-07 Thread Rajath Shashidhara
Hi, Thanks Stefan ! I spoke to Dinah and this issue is still up for grabs. I would be working on both SeaBIOS MMConfig task and the DS3231 RTC emulation feature. Thanks for your help! Regards, Rajath Shashidhara On 07-11-2019 07:54, Stefan Hajnoczi wrote: On Wed, Nov 06, 2019 at 05:50:44PM

Re: [Qemu-devel] Exposing feature deprecation to machine clients

2019-11-07 Thread Philippe Mathieu-Daudé
Hi Markus, On 8/15/19 7:40 PM, John Snow wrote: On 8/15/19 10:16 AM, Markus Armbruster wrote: John Snow writes: [...] I asked Markus this not too long ago; do we want to amend the QAPI schema specification to allow commands to return with "Warning" strings, or "Deprecated" stings to allow

Re: Looking for issues/features for my first contribution

2019-11-07 Thread Rajath Shashidhara
Thank you Aleksandar ! This is really helpful. Rajath Shashidhara On 07-11-2019 07:33, Aleksandar Markovic wrote: On Thu, Nov 7, 2019 at 11:37 AM Aleksandar Markovic wrote: On Thursday, November 7, 2019, Rajath Shashidhara wrote: Hi all, I am a Computer Science graduate student at The

Re: [PATCH v7 0/8] Acceptance test: Add "boot_linux" acceptance test

2019-11-07 Thread Wainer dos Santos Moschetta
Hi Cleber, On 11/4/19 1:13 PM, Cleber Rosa wrote: This acceptance test, validates that a full blown Linux guest can successfully boot in QEMU. In this specific case, the guest chosen is Fedora version 31. * x86_64, pc and q35 machine types, with and without kvm as an accellerator *

Re: [PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test

2019-11-07 Thread Laurent Vivier
Le 07/11/2019 à 19:00, Philippe Mathieu-Daudé a écrit : > On 11/7/19 6:18 PM, Laurent Vivier wrote: >> Le 07/11/2019 à 17:38, Cleber Rosa a écrit : >>> - Original Message - From: "Eric Blake" To: "Cleber Rosa" , qemu-devel@nongnu.org Cc: "Peter Maydell" , "Eduardo Habkost"

Re: [PATCH 2/3] Acceptance tests: introduce utility method for tags unique vals

2019-11-07 Thread Wainer dos Santos Moschetta
On 10/28/19 8:02 PM, Cleber Rosa wrote: On Thu, Oct 24, 2019 at 06:12:25PM -0300, Wainer dos Santos Moschetta wrote: Hi Cleber, On 9/24/19 4:45 PM, Cleber Rosa wrote: Currently a test can describe the target architecture binary that it should primarily be run with, be setting a single tag

Re: [PULL 0/1] Usb 20191107 patches

2019-11-07 Thread Peter Maydell
are available in the Git repository at: > > git://git.kraxel.org/qemu tags/usb-20191107-pull-request > > for you to fetch changes up to 1dfe2b91dcb1633d0ba450a8139d53006e700a9b: > > usb-host: add option to al

Re: [PULL 0/3] Block patches for 4.2.0-rc0/4.1.1

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 14:34, Max Reitz wrote: > > The following changes since commit d0f90e1423b4f412adc620eee93e8bfef8af4117: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20191106-pull-request' into staging (2019-11-07 > 09:21:52 +) > > are available in the Git

Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 17:09, Palmer Dabbelt wrote: > > On Wed, 06 Nov 2019 16:47:20 PST (-0800), Alistair Francis wrote: > > Coreboot developers have requested that they have at least 32MB of flash > > to load binaries. We currently have 32MB of flash, but it is split in > > two to allow loading

[PATCH v2 2/2] i386: Add 2nd Generation AMD EPYC processors

2019-11-07 Thread Moger, Babu
Adds the support for 2nd Gen AMD EPYC Processors. The model display name will be EPYC-Rome. Adds the following new feature bits on top of the feature bits from the first generation EPYC models. perfctr-core : core performance counter extensions support. Enables the VM to use

[PATCH v2 1/2] i386: Add missing cpu feature bits in EPYC model

2019-11-07 Thread Moger, Babu
Adds the following missing CPUID bits: perfctr-core : core performance counter extensions support. Enables the VM to use extended performance counter support. It enables six programmable counters instead of 4 counters. clzero : instruction zeroes out the 64 byte

Re: [PATCH v8 0/3] RTC support for QEMU RISC-V virt machine

2019-11-07 Thread Philippe Mathieu-Daudé
On 11/7/19 5:52 PM, Palmer Dabbelt wrote: On Wed, 06 Nov 2019 03:56:29 PST (-0800), Anup Patel wrote: This series adds RTC device to QEMU RISC-V virt machine. We have selected Goldfish RTC device model for this. It's a pretty simple synthetic device with few MMIO registers and no dependency

Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size

2019-11-07 Thread Alistair Francis
On Thu, Nov 7, 2019 at 10:01 AM Peter Maydell wrote: > > On Thu, 7 Nov 2019 at 17:09, Palmer Dabbelt wrote: > > > > On Wed, 06 Nov 2019 16:47:20 PST (-0800), Alistair Francis wrote: > > > Coreboot developers have requested that they have at least 32MB of flash > > > to load binaries. We

[PATCH v2 0/2] Add support for 2nd generation AMD EPYC processors

2019-11-07 Thread Moger, Babu
The following series adds the support for 2nd generation AMD EPYC Processors on qemu guests. The model display name for 2nd generation will be EPYC-Rome. Also fixes few missed cpu feature bits in 1st generation EPYC models. The Reference documents are available at

[Bug 1851664] Re: qemu-system-x86_64: "VFIO_MAP_DMA : -28" error when we attache 6 VF's to guest machine

2019-11-07 Thread Alex Williamson
Presumably w-bits (aw-bits?) implies using intel-iommu, there's a opportunity for the vfio iommu backend to return -ENOSPC (-28) if we exceed the default number of in-flight DMA mappings per container. The default limit is 65535. You can try increasing this by changing the dma_entry_limit module

Re: [PATCH v3 01/22] iotests: s/qocw2/qcow2/

2019-11-07 Thread Eric Blake
On 11/7/19 10:36 AM, Max Reitz wrote: Probably due to blind copy-pasting, we have several instances of "qocw2" in our iotests. Fix them. Reported-by: Maxim Levitsky Signed-off-by: Max Reitz --- tests/qemu-iotests/060 | 2 +- Reviewed-by: Eric Blake -- Eric Blake, Principal Software

[Bug 1851664] Re: qemu-system-x86_64: "VFIO_MAP_DMA : -28" error when we attache 6 VF's to guest machine

2019-11-07 Thread IndrasenaReddy Gali
qemu-system-x86_64 -name guest=fedora24 -machine q35,accel=kvm,kernel-irqchip=split \ -enable-kvm \ -m 4G \ -smp 8,sockets=1,cores=8,threads=1 \ -device intel-iommu,intremap=on,caching-mode=on,aw-bits=48 \ -drive file=,format=raw \ -device

[Bug 1851664] Re: qemu-system-x86_64: "VFIO_MAP_DMA : -28" error when we attache 6 VF's to guest machine

2019-11-07 Thread IndrasenaReddy Gali
Please find the above qemu command to lunch guest machine -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1851664 Title: qemu-system-x86_64: "VFIO_MAP_DMA : -28" error when we attache 6 VF's to

Re: [PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test

2019-11-07 Thread Philippe Mathieu-Daudé
On 11/7/19 6:18 PM, Laurent Vivier wrote: Le 07/11/2019 à 17:38, Cleber Rosa a écrit : - Original Message - From: "Eric Blake" To: "Cleber Rosa" , qemu-devel@nongnu.org Cc: "Peter Maydell" , "Eduardo Habkost" , "Philippe Mathieu-Daudé" , "Wainer dos Santos Moschetta" , "Laurent

Re: [PATCH v1 0/6] testing/next (netbsd stuff)

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 17:54, Kamil Rytarowski wrote: > > On 07.11.2019 18:46, Peter Maydell wrote: > > On Mon, 4 Nov 2019 at 17:39, Alex Bennée wrote: > >> > >> Hi, > >> > >> As we approach hard-freeze I'm trying to temper what comes in through > >> the testing/next tree. However it would be

Re: [PATCH v15 02/12] util/cutils: Add qemu_strtotime_ns()

2019-11-07 Thread Eduardo Habkost
On Thu, Nov 07, 2019 at 03:45:01PM +0800, Tao Xu wrote: > To convert strings with time suffixes to numbers, support time unit are > "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" > for second. Add test for qemu_strtotime_ns, test the input of basic, > time suffixes, float,

Re: [PATCH v1 0/6] testing/next (netbsd stuff)

2019-11-07 Thread Kamil Rytarowski
On 07.11.2019 18:46, Peter Maydell wrote: > On Mon, 4 Nov 2019 at 17:39, Alex Bennée wrote: >> >> Hi, >> >> As we approach hard-freeze I'm trying to temper what comes in through >> the testing/next tree. However it would be nice to get the NetBSD upto >> speed with the other NetBSDs. Although the

Re: [PATCH v15 01/12] util/cutils: refactor do_strtosz() to support suffixes list

2019-11-07 Thread Eduardo Habkost
On Thu, Nov 07, 2019 at 03:45:00PM +0800, Tao Xu wrote: > Add do_strtomul() to convert string according to different suffixes. > > Signed-off-by: Tao Xu Reviewed-by: Eduardo Habkost -- Eduardo

[Bug 1810105] Re: Hint showing volume never disappears, blocking buttons to minimize, maximize and close

2019-11-07 Thread Leonardo Müller
I finally found a real computer on which this bug is present. The computer in question is a netbook manufactured by Positivo, the Mobo 5900, which is common on schools. It has a touchscreen with a pen which is compatible with evdev but that doesn't work with libinput. Its touchscreen is: Bus 004

Re: [PATCH v1 0/6] testing/next (netbsd stuff)

2019-11-07 Thread Peter Maydell
On Mon, 4 Nov 2019 at 17:39, Alex Bennée wrote: > > Hi, > > As we approach hard-freeze I'm trying to temper what comes in through > the testing/next tree. However it would be nice to get the NetBSD upto > speed with the other NetBSDs. Although the serial install is working > well for me this has

Re: [PATCH 2/5] ipmi: Add support to customize OEM functions

2019-11-07 Thread Cédric Le Goater
On 07/11/2019 18:25, Corey Minyard wrote: > On Thu, Nov 07, 2019 at 06:14:58PM +0100, Cédric Le Goater wrote: > What's the plan for merging this, once it's ready? Is there an IPMI > tree for it to be staged in? If not I could take it through the ppc > tree, but I'd need some

Re: [PATCH 4/4] Added tests for close and change of logfile.

2019-11-07 Thread Alex Bennée
Alex Bennée writes: > Robert Foley writes: > >> One test ensures that the logfile handle is still valid even if >> the logfile is changed during logging. >> The other test validates that the logfile handle remains valid under >> the logfile lock even if the logfile is closed. Also this

Re: [PATCH 2/5] ipmi: Add support to customize OEM functions

2019-11-07 Thread Corey Minyard
On Thu, Nov 07, 2019 at 06:14:58PM +0100, Cédric Le Goater wrote: > >>> What's the plan for merging this, once it's ready? Is there an IPMI > >>> tree for it to be staged in? If not I could take it through the ppc > >>> tree, but I'd need some Acked-bys in that case. > >> > >> I have an IPMI

Re: [PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test

2019-11-07 Thread Laurent Vivier
Le 07/11/2019 à 17:38, Cleber Rosa a écrit : > > > - Original Message - >> From: "Eric Blake" >> To: "Cleber Rosa" , qemu-devel@nongnu.org >> Cc: "Peter Maydell" , "Eduardo Habkost" >> , "Philippe Mathieu-Daudé" >> , "Wainer dos Santos Moschetta" , >> "Laurent Vivier" , >> "Willian

Re: [PATCH 2/5] ipmi: Add support to customize OEM functions

2019-11-07 Thread Cédric Le Goater
>>> What's the plan for merging this, once it's ready? Is there an IPMI >>> tree for it to be staged in? If not I could take it through the ppc >>> tree, but I'd need some Acked-bys in that case. >> >> I have an IPMI tree for this. I was assuming it was going in to the PPC >> tree, but it's not

Re: [PULL v3 0/3] Trivial branch patches

2019-11-07 Thread Peter Maydell
On Wed, 6 Nov 2019 at 16:26, Laurent Vivier wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git

Re: [PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size

2019-11-07 Thread Palmer Dabbelt
On Wed, 06 Nov 2019 16:47:20 PST (-0800), Alistair Francis wrote: Coreboot developers have requested that they have at least 32MB of flash to load binaries. We currently have 32MB of flash, but it is split in two to allow loading two flash binaries. Let's increase the flash size from 32MB to

Re: [PATCH 2/5] ipmi: Add support to customize OEM functions

2019-11-07 Thread David Gibson
On Sun, Oct 27, 2019 at 01:33:47PM -0500, Corey Minyard wrote: > On Sun, Oct 27, 2019 at 06:47:39PM +0100, David Gibson wrote: > > On Mon, Oct 21, 2019 at 09:30:17AM -0500, Corey Minyard wrote: > > > On Mon, Oct 21, 2019 at 03:12:12PM +0200, Cédric Le Goater wrote: > > > > The routine

Re: [PATCH 1/4] Add a mutex to guarantee single writer to qemu_logfile handle.

2019-11-07 Thread Alex Bennée
Robert Foley writes: > This is being added in preparation for using RCU with the logfile handle. > Also added qemu_logfile_init() for initializing the logfile mutex. > > Signed-off-by: Robert Foley > --- > util/log.c | 23 +++ > 1 file changed, 23 insertions(+) > > diff

Re: [PATCH v2 2/4] Memory: Enable writeback for given memory region

2019-11-07 Thread Peter Maydell
On Thu, 7 Nov 2019 at 16:57, Alex Bennée wrote: > > > Beata Michalska writes: > > > On Wed, 6 Nov 2019 at 12:20, Richard Henderson > > wrote: > >> qemu_log_mask w/ GUEST_ERROR? How do we expect the length to overflow? > > > > In theory it shouldn't, at least with current usage. > > I guess the

Re: [PATCH] ppc/pnv: Add a "/qemu" device tree node

2019-11-07 Thread David Gibson
On Wed, Nov 06, 2019 at 03:21:29PM +0100, Cédric Le Goater wrote: > It helps skiboot identifying that is running on a QEMU platform. The > compatible string will define the POWERPC processor version. > > Signed-off-by: Cédric Le Goater Applied to ppc-for-4.3. > --- > hw/ppc/pnv.c | 3 +++ > 1

[Bug 1851664] Re: qemu-system-x86_64: "VFIO_MAP_DMA : -28" error when we attache 6 VF's to guest machine

2019-11-07 Thread Thomas Huth
Please provide information how you started QEMU, and some information about your PCI device (e.g. the output of lspci). ** Information type changed from Private Security to Public ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a

Re: [PATCH v2 2/4] Memory: Enable writeback for given memory region

2019-11-07 Thread Alex Bennée
Beata Michalska writes: > On Wed, 6 Nov 2019 at 12:20, Richard Henderson > wrote: >> >> On 11/6/19 12:40 AM, Beata Michalska wrote: >> > +void qemu_ram_writeback(RAMBlock *block, ram_addr_t start, ram_addr_t >> > length) >> > +{ >> > +void *addr = ramblock_ptr(block, start); >> > + >> >

Re: [PATCH v3 21/22] iotests: Disable data_file where it cannot be used

2019-11-07 Thread Max Reitz
On 07.11.19 17:37, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/007 | 5 +++-- > tests/qemu-iotests/014 | 2 ++ > tests/qemu-iotests/015 | 5 +++-- > tests/qemu-iotests/026 | 5 - > tests/qemu-iotests/029 | 5 +++-- > tests/qemu-iotests/031 | 6 +++--- >

[PATCH v3 18/22] iotests: Make 110 work with data_file

2019-11-07 Thread Max Reitz
The only difference is that the json:{} filename of the image looks different. We actually do not care about that filename in this test, we are only interested in (1) that there is a json:{} filename, and (2) whether the backing filename can be constructed. So just filter out the json:{} data,

Re: [PATCH v2 20/21] iotests: Disable data_file where it cannot be used

2019-11-07 Thread Max Reitz
On 07.11.19 16:19, Maxim Levitsky wrote: > On Thu, 2019-11-07 at 12:36 +0100, Max Reitz wrote: >> On 06.11.19 16:52, Maxim Levitsky wrote: >>> On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/007 | 5 +++--

Re: [PATCH 0/2] Acceptance test: update kernel used on m68k/q800 test

2019-11-07 Thread Cleber Rosa
- Original Message - > From: "Eric Blake" > To: "Cleber Rosa" , qemu-devel@nongnu.org > Cc: "Peter Maydell" , "Eduardo Habkost" > , "Philippe Mathieu-Daudé" > , "Wainer dos Santos Moschetta" , > "Laurent Vivier" , > "Willian Rampazzo" , "Philippe Mathieu-Daudé" > > Sent: Thursday,

[PATCH v3 22/22] iotests: Allow check -o data_file

2019-11-07 Thread Max Reitz
The problem with allowing the data_file option is that you want to use a different data file per image used in the test. Therefore, we need to allow patterns like -o data_file='$TEST_IMG.data_file'. Then, we need to filter it out from qemu-img map, qemu-img create, and remove the data file in

Re: [PATCH v8 0/3] RTC support for QEMU RISC-V virt machine

2019-11-07 Thread Palmer Dabbelt
On Wed, 06 Nov 2019 03:56:29 PST (-0800), Anup Patel wrote: This series adds RTC device to QEMU RISC-V virt machine. We have selected Goldfish RTC device model for this. It's a pretty simple synthetic device with few MMIO registers and no dependency external clock. The driver for Goldfish RTC is

[PATCH v3 14/22] iotests: Avoid qemu-img create

2019-11-07 Thread Max Reitz
Use _make_test_img whenever possible. This way, we will not ignore user-specified image options. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/094 | 2 +- tests/qemu-iotests/111 | 3 +-- tests/qemu-iotests/123 | 2 +- tests/qemu-iotests/153 | 2 +-

[PATCH v3 21/22] iotests: Disable data_file where it cannot be used

2019-11-07 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/007 | 5 +++-- tests/qemu-iotests/014 | 2 ++ tests/qemu-iotests/015 | 5 +++-- tests/qemu-iotests/026 | 5 - tests/qemu-iotests/029 | 5 +++-- tests/qemu-iotests/031 | 6 +++--- tests/qemu-iotests/036 | 5 +++-- tests/qemu-iotests/039 | 3 +++

[PATCH v3 17/22] iotests: Make 091 work with data_file

2019-11-07 Thread Max Reitz
The image end offset as reported by qemu-img check is different when using an external data file; we do not care about its value here, so we can just filter it. Incidentally, common.rc already has _check_test_img for us which does exactly that. Signed-off-by: Max Reitz Reviewed-by: Maxim

[PATCH v3 11/22] iotests: Replace IMGOPTS= by -o

2019-11-07 Thread Max Reitz
Tests should not overwrite all user-supplied image options, but only add to it (which will effectively overwrite conflicting values). Accomplish this by passing options to _make_test_img via -o instead of $IMGOPTS. For some tests, there is no functional change because they already only appended

[PATCH v3 20/22] iotests: Make 198 work with data_file

2019-11-07 Thread Max Reitz
We do not care about the json:{} filenames here, so we can just filter them out and thus make the test work both with and without external data files. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/198 | 6 -- tests/qemu-iotests/198.out | 4 ++-- 2 files

[PATCH v3 13/22] iotests: Drop IMGOPTS use in 267

2019-11-07 Thread Max Reitz
Overwriting IMGOPTS means ignoring all user-supplied options, which is not what we want. Replace the current IMGOPTS use by a new BACKING_FILE variable. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/267 | 12 1 file changed, 8 insertions(+), 4

[PATCH v3 19/22] iotests: Make 137 work with data_file

2019-11-07 Thread Max Reitz
When using an external data file, there are no refcounts for data clusters. We thus have to adjust the corruption test in this patch to not be based around a data cluster allocation, but the L2 table allocation (L2 tables are still refcounted with external data files). Furthermore, we should not

[PATCH v3 10/22] iotests: Inject space into -ocompat=0.10 in 051

2019-11-07 Thread Max Reitz
It did not matter before, but now that _make_test_img understands -o, we should use it properly here. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/051 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/051

[PATCH v3 16/22] iotests: Avoid cp/mv of test images

2019-11-07 Thread Max Reitz
This will not work with external data files, so try to get tests working without it as far as possible. Signed-off-by: Max Reitz Reviewed-by: Maxim Levitsky --- tests/qemu-iotests/063 | 12 tests/qemu-iotests/063.out | 3 ++- tests/qemu-iotests/085 | 9 +++--

  1   2   3   >