Re: [PATCH 02/16] vl: extract accelerator option processing to a separate function

2019-11-13 Thread Marc-André Lureau
Hi On Wed, Nov 13, 2019 at 6:39 PM Paolo Bonzini wrote: > > As a first step towards supporting multiple "-accel" options, push -icount > and -accel semantics into a new function, and use qemu_opts_foreach to > retrieve the key/value lists instead of stashing them into globals. > > Signed-off-by:

Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

2019-11-13 Thread Gerd Hoffmann
On Wed, Nov 13, 2019 at 05:03:58PM +0200, Sam Eiderman wrote: > Hi, > > Does this fix a bug that actually happened? Yes, "make check-qtest" may fail. It's kind of random though. > I just noticed that in my lchs patches I assumed that lchs struct is > zeroed out in all devices (not only ahci):

Re: [PATCH] tests: fix modules-test 'duplicate test case' error

2019-11-13 Thread Marc-André Lureau
On Thu, Nov 14, 2019 at 1:09 AM Cole Robinson wrote: > > ./configure --enable-sdl --audio-drv-list=sdl --enable-modules > > Will generate two identical test names: /$arch/module/load/sdl > Which generates an error like: > > (tests/modules-test:23814): GLib-ERROR **: 18:23:06.359: duplicate test ca

Re: [PATCH v9 QEMU 14/15] vfio: Add ioctl to get dirty pages bitmap during dma unmap.

2019-11-13 Thread Alex Williamson
On Tue, 12 Nov 2019 22:35:23 +0530 Kirti Wankhede wrote: > With vIOMMU, IO virtual address range can get unmapped while in pre-copy phase > of migration. In that case, unmap ioctl should return pages pinned in that > range > and QEMU should find its correcponding guest physical addresses and rep

Re: [PATCH v9 QEMU 15/15] vfio: Make vfio-pci device migration capable.

2019-11-13 Thread Alex Williamson
On Tue, 12 Nov 2019 22:35:24 +0530 Kirti Wankhede wrote: > If device is not failover primary device call vfio_migration_probe() > and vfio_migration_finalize() functions for vfio-pci device to enable > migration for vfio PCI device which support migration. > Removed vfio_pci_vmstate structure. >

Re: [PATCH v9 QEMU 13/15] vfio: Add vfio_listener_log_sync to mark dirty pages

2019-11-13 Thread Alex Williamson
On Tue, 12 Nov 2019 22:35:22 +0530 Kirti Wankhede wrote: > vfio_listener_log_sync gets list of dirty pages from container using > VFIO_IOMMU_GET_DIRTY_BITMAP ioctl and mark those pages dirty when all > devices are stopped and saving state. > Return early for the RAM block section of mapped MMIO r

Re: [PATCH v9 QEMU 12/15] vfio: Add load state functions to SaveVMHandlers

2019-11-13 Thread Alex Williamson
On Tue, 12 Nov 2019 22:35:21 +0530 Kirti Wankhede wrote: > Sequence during _RESUMING device state: > While data for this device is available, repeat below steps: > a. read data_offset from where user application should write data. > b. write data of data_size to migration region from data_offset

Re: [PATCH v9 QEMU 10/15] vfio: Register SaveVMHandlers for VFIO device

2019-11-13 Thread Alex Williamson
On Tue, 12 Nov 2019 22:35:19 +0530 Kirti Wankhede wrote: > Define flags to be used as delimeter in migration file stream. > Added .save_setup and .save_cleanup functions. Mapped & unmapped migration > region from these functions at source during saving or pre-copy phase. > Set VFIO device state d

Re: [PATCH v9 QEMU 11/15] vfio: Add save state functions to SaveVMHandlers

2019-11-13 Thread Alex Williamson
On Tue, 12 Nov 2019 22:35:20 +0530 Kirti Wankhede wrote: > Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy > functions. These functions handles pre-copy and stop-and-copy phase. > > In _SAVING|_RUNNING device state or pre-copy phase: > - read pending_bytes. If pendin

Re: [PATCH v9 QEMU 08/15] vfio: Add VM state change handler to know state of VM

2019-11-13 Thread Alex Williamson
On Tue, 12 Nov 2019 22:35:17 +0530 Kirti Wankhede wrote: > VM state change handler gets called on change in VM's state. This is used to > set > VFIO device state to _RUNNING. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > --- > hw/vfio/migration.c | 69 > ++

Re: [PATCH v9 QEMU 07/15] vfio: Add migration region initialization and finalize function

2019-11-13 Thread Alex Williamson
On Tue, 12 Nov 2019 22:35:16 +0530 Kirti Wankhede wrote: > - Migration functions are implemented for VFIO_DEVICE_TYPE_PCI device in this > patch series. > - VFIO device supports migration or not is decided based of migration region > query. If migration region query is successful and migratio

Re: [PATCH v9 QEMU 06/15] vfio: Add save and load functions for VFIO PCI devices

2019-11-13 Thread Alex Williamson
On Tue, 12 Nov 2019 22:35:15 +0530 Kirti Wankhede wrote: > These functions save and restore PCI device specific data - config > space of PCI device. > Tested save and restore with MSI and MSIX type. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > --- > hw/vfio/pci.c

[Bug 1841592] Re: ppc: softfloat float implementation issues

2019-11-13 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1841592 Title: ppc: softfl

Re: [PATCH] tests/vm: update openbsd to release 6.6

2019-11-13 Thread Brad Smith
Thanks. Reviewed-by: Brad Smith On 10/18/2019 6:24 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- tests/vm/openbsd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index b92c39f89a6f..9f82cd459fde 100755 --- a/tests/vm/o

Re: [PATCH v3 for-4.2 0/4] Better NBD string length handling

2019-11-13 Thread Eric Blake
On 11/13/19 9:00 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20191114024635.11363-1-ebl...@redhat.com/ from /tmp/qemu-test/src/include/qemu/osdep.h:140, from /tmp/qemu-test/src/nbd/server.c:20: /tmp/qemu-test/src/nbd/server.c: In

Re: [PATCH v3 for-4.2 0/4] Better NBD string length handling

2019-11-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191114024635.11363-1-ebl...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names

2019-11-13 Thread Eric Blake
On 11/13/19 8:46 PM, Eric Blake wrote: As long as we limit NBD names to 256 bytes (the bare minimum permitted by the standard), stack-allocation works for parsing a name received from the client. But as mentioned in a comment, we eventually want to permit up to the 4k maximum of the NBD standard

Re: [PATCH v3 for-4.2 0/4] Better NBD string length handling

2019-11-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191114024635.11363-1-ebl...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

[PATCH v3 2/4] bitmap: Enforce maximum bitmap name length

2019-11-13 Thread Eric Blake
We document that for qcow2 persistent bitmaps, the name cannot exceed 1023 bytes. It is inconsistent if transient bitmaps do not have to abide by the same limit, and it is unlikely that any existing client even cares about using bitmap names this long. It's time to codify that ALL bitmaps managed

[PATCH v3 3/4] nbd: Don't send oversize strings

2019-11-13 Thread Eric Blake
Qemu as server currently won't accept export names larger than 256 bytes, nor create dirty bitmap names longer than 1023 bytes, so most uses of qemu as client or server have no reason to get anywhere near the NBD spec maximum of a 4k limit per string. However, we weren't actually enforcing things,

[PATCH v3 for-5.0 4/4] nbd: Allow description when creating NBD blockdev

2019-11-13 Thread Eric Blake
Allow blockdevs to match the feature already present in qemu-nbd -D. Enhance iotest 223 to cover it. Signed-off-by: Eric Blake Reviewed-by: Maxim Levitsky Reviewed-by: Vladimir Sementsov-Ogievskiy --- qapi/block.json| 9 ++--- blockdev-nbd.c | 9 - monitor/h

[PATCH v3 for-4.2 0/4] Better NBD string length handling

2019-11-13 Thread Eric Blake
This series was originally posted before soft freeze, but then KVM Forum interfered. I think that patches 1-3 are bug fixes still appropriate for -rc2 if they get good reviews, but patch 4 is a new feature and now only appropriate for 5.0. Since v2: - Patch 1, 2: new [Vladimir] - Patch 3: improve

[PATCH v3 1/4] nbd/server: Prefer heap over stack for parsing client names

2019-11-13 Thread Eric Blake
As long as we limit NBD names to 256 bytes (the bare minimum permitted by the standard), stack-allocation works for parsing a name received from the client. But as mentioned in a comment, we eventually want to permit up to the 4k maximum of the NBD standard, which is too large for stack allocation

Re: [PATCH RFC] virtio-pci: disable vring processing when bus-mastering is disabled

2019-11-13 Thread Michael Roth
Quoting Michael S. Tsirkin (2019-11-13 04:09:02) > On Tue, Nov 12, 2019 at 11:43:01PM -0600, Michael Roth wrote: > > Currently the SLOF firmware for pseries guests will disable/re-enable > > a PCI device multiple times via IO/MEM/MASTER bits of PCI_COMMAND > > register after the initial probe/featu

Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time

2019-11-13 Thread Tao Xu
On 11/14/2019 6:06 AM, Eduardo Habkost wrote: On Wed, Nov 13, 2019 at 09:01:29AM +0800, Tao Xu wrote: On 11/13/2019 4:15 AM, Eduardo Habkost wrote: On Fri, Nov 08, 2019 at 09:05:52AM +0100, Markus Armbruster wrote: Tao Xu writes: On 11/7/2019 9:31 PM, Eduardo Habkost wrote: On Thu, Nov 07,

Re: About MONITOR/MWAIT in i386 CPU model

2019-11-13 Thread Tao Xu
On 11/14/2019 6:47 AM, Eduardo Habkost wrote: On Wed, Nov 13, 2019 at 04:42:25PM +0800, Tao Xu wrote: Hi Eduardo, After kvm use "-overcommit cpu-pm=on" to expose MONITOR/MWAIT (commit id 6f131f13e68d648a8e4f083c667ab1acd88ce4cd), the MONITOR/MWAIT feature in CPU model (phenom core2duo coreduo n

Re: [PATCH v9 Kernel 1/5] vfio: KABI for migration interface for device state

2019-11-13 Thread Yan Zhao
On Thu, Nov 14, 2019 at 03:02:55AM +0800, Kirti Wankhede wrote: > > > On 11/13/2019 8:53 AM, Yan Zhao wrote: > > On Wed, Nov 13, 2019 at 06:30:05AM +0800, Alex Williamson wrote: > >> On Tue, 12 Nov 2019 22:33:36 +0530 > >> Kirti Wankhede wrote: > >> > >>> - Defined MIGRATION region type and sub-

[PATCH v5 17/20] fuzz: add support for qos-assisted fuzz targets

2019-11-13 Thread Oleinik, Alexander
Signed-off-by: Alexander Bulekov --- tests/fuzz/qos_fuzz.c | 232 ++ tests/fuzz/qos_fuzz.h | 33 ++ 2 files changed, 265 insertions(+) create mode 100644 tests/fuzz/qos_fuzz.c create mode 100644 tests/fuzz/qos_fuzz.h diff --git a/tests/fuzz/qos_fuzz

[PATCH v5 15/20] fuzz: add fuzzer skeleton

2019-11-13 Thread Oleinik, Alexander
tests/fuzz/fuzz.c serves as the entry point for the virtual-device fuzzer. Namely, libfuzzer invokes the LLVMFuzzerInitialize and LLVMFuzzerTestOneInput functions, both of which are defined in this file. This change adds a "FuzzTarget" struct, along with the fuzz_add_target function, which should b

[PATCH v5 18/20] fuzz: add i440fx fuzz targets

2019-11-13 Thread Oleinik, Alexander
These three targets should simply fuzz reads/writes to a couple ioports, but they mostly serve as examples of different ways to write targets. They demonstrate using qtest and qos for fuzzing, as well as using rebooting and forking to reset state, or not resetting it at all. Signed-off-by: Alexand

[PATCH v5 14/20] fuzz: Add target/fuzz makefile rules

2019-11-13 Thread Oleinik, Alexander
Signed-off-by: Alexander Bulekov --- Makefile| 15 ++- Makefile.objs | 4 +++- Makefile.target | 18 +- tests/fuzz/Makefile.include | 4 4 files changed, 38 insertions(+), 3 deletions(-) create mode 100644 tests/fuz

[PATCH v5 16/20] fuzz: add support for fork-based fuzzing.

2019-11-13 Thread Oleinik, Alexander
fork() is a simple way to ensure that state does not leak in between fuzzing runs. Unfortunately, the fuzzer mutation engine relies on bitmaps which contain coverage information for each fuzzing run, and these bitmaps should be copied from the child to the parent(where the mutation occurs). These b

[PATCH v5 09/20] libqos: split qos-test and libqos makefile vars

2019-11-13 Thread Oleinik, Alexander
Most qos-related objects were specified in the qos-test-obj-y variable. qos-test-obj-y also included qos-test.o which defines a main(). This made it difficult to repurpose qos-test-obj-y to link anything beside tests/qos-test against libqos. This change separates objects that are libqos-specific an

[PATCH v5 10/20] libqos: move useful qos-test funcs to qos_external

2019-11-13 Thread Oleinik, Alexander
The moved functions are not specific to qos-test and might be useful elsewhere. For example the virtual-device fuzzer makes use of them for qos-assisted fuzz-targets. Signed-off-by: Alexander Bulekov --- tests/Makefile.include | 1 + tests/libqos/qos_external.c | 168 +

[PATCH v5 20/20] fuzz: add documentation to docs/devel/

2019-11-13 Thread Oleinik, Alexander
Signed-off-by: Alexander Bulekov --- docs/devel/fuzzing.txt | 119 + 1 file changed, 119 insertions(+) create mode 100644 docs/devel/fuzzing.txt diff --git a/docs/devel/fuzzing.txt b/docs/devel/fuzzing.txt new file mode 100644 index 00..b0cceb2a6b

[PATCH v5 11/20] libqtest: make bufwrite rely on the TransportOps

2019-11-13 Thread Oleinik, Alexander
When using qtest "in-process" communication, qtest_sendf directly calls a function in the server (qtest.c). Previously, bufwrite used socket_send, which bypasses the TransportOps enabling the call into qtest.c. This change replaces the socket_send calls with ops->send, maintaining the benefits of t

[PATCH v5 12/20] libqtest: add in-process qtest.c tx/rx handlers

2019-11-13 Thread Oleinik, Alexander
Signed-off-by: Alexander Bulekov --- tests/libqtest.c | 54 tests/libqtest.h | 3 ++- 2 files changed, 56 insertions(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 6d3bcb6766..da0e5c7ef8 100644 --- a/tests/libqtest.c +++

[PATCH v5 01/20] softmmu: split off vl.c:main() into main.c

2019-11-13 Thread Oleinik, Alexander
A program might rely on functions implemented in vl.c, but implement its own main(). By placing main into a separate source file, there are no complaints about duplicate main()s when linking against vl.o. For example, the virtual-device fuzzer uses a main() provided by libfuzzer, and needs to perfo

Re: virtio,iommu_platform=on

2019-11-13 Thread Alexey Kardashevskiy
On 13/11/2019 21:00, Michael S. Tsirkin wrote: > On Wed, Nov 13, 2019 at 03:44:28PM +1100, Alexey Kardashevskiy wrote: >> >> >> On 12/11/2019 18:08, Michael S. Tsirkin wrote: >>> On Tue, Nov 12, 2019 at 02:53:49PM +1100, Alexey Kardashevskiy wrote: Hi! I am enabling IOMMU for virt

[PATCH v5 19/20] fuzz: add virtio-net fuzz target

2019-11-13 Thread Oleinik, Alexander
The virtio-net fuzz target feeds inputs to all three virtio-net virtqueues, and uses forking to avoid leaking state between fuzz runs. Signed-off-by: Alexander Bulekov --- tests/fuzz/Makefile.include | 1 + tests/fuzz/virtio_net_fuzz.c | 100 +++ 2 files change

[PATCH v5 02/20] libqos: Rename i2c_send and i2c_recv

2019-11-13 Thread Oleinik, Alexander
The names i2c_send and i2c_recv collide with functions defined in hw/i2c/core.c. This causes an error when linking against libqos and softmmu simultaneously (for example when using qtest inproc). Rename the libqos functions to avoid this. Signed-off-by: Alexander Bulekov --- tests/libqos/i2c.c

[PATCH v5 03/20] fuzz: Add FUZZ_TARGET module type

2019-11-13 Thread Oleinik, Alexander
Signed-off-by: Alexander Bulekov --- include/qemu/module.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/qemu/module.h b/include/qemu/module.h index 65ba596e46..684753d808 100644 --- a/include/qemu/module.h +++ b/include/qemu/module.h @@ -46,6 +46,7 @@ typedef enu

[PATCH v5 08/20] tests: provide test variables to other targets

2019-11-13 Thread Oleinik, Alexander
Before, when tests/Makefile.include was included, the contents would be ignored if config-host.mak was defined. Moving the ifneq responsible for this allows a target to depend on both testing-related and host-related objects. For example the virtual-device fuzzer relies on both libqtest/libqos obje

[PATCH v5 07/20] qtest: add in-process incoming command handler

2019-11-13 Thread Oleinik, Alexander
The handler allows a qtest client to send commands to the server by directly calling a function, rather than using a file/CharBackend Signed-off-by: Alexander Bulekov --- include/sysemu/qtest.h | 1 + qtest.c| 13 + 2 files changed, 14 insertions(+) diff --git a/inc

[PATCH v5 13/20] fuzz: add configure flag --enable-fuzzing

2019-11-13 Thread Oleinik, Alexander
Signed-off-by: Alexander Bulekov --- configure | 39 +++ 1 file changed, 39 insertions(+) diff --git a/configure b/configure index 3be9e92a24..aeca632dd9 100755 --- a/configure +++ b/configure @@ -501,6 +501,7 @@ libxml2="" debug_mutex="no" libpmem="" defau

[PATCH v5 00/20] Add virtual device fuzzing support

2019-11-13 Thread Oleinik, Alexander
This series adds a framework for coverage-guided fuzzing of virtual-devices. Fuzzing targets are based on qtest and can make use of the libqos abstractions. V5: * misc fixes addressing V4 comments * cleanup in-process handlers/globals in libqtest.c * small fixes to fork-based fuzzing and suppor

[PATCH v5 05/20] libqtest: Add a layer of abstraciton to send/recv

2019-11-13 Thread Oleinik, Alexander
This makes it simple to swap the transport functions for qtest commands to and from the qtest client. For example, now it is possible to directly pass qtest commands to a server handler that exists within the same process, without the standard way of writing to a file descriptor. Signed-off-by: Al

[PATCH v5 04/20] qtest: add qtest_server_send abstraction

2019-11-13 Thread Oleinik, Alexander
qtest_server_send is a function pointer specifying the handler used to transmit data to the qtest client. In the standard configuration, this calls the CharBackend handler, but now it is possible for other types of handlers, e.g direct-function calls if the qtest client and server exist within the

[PATCH v5 06/20] module: check module wasn't already initialized

2019-11-13 Thread Oleinik, Alexander
The virtual-device fuzzer must initialize QOM, prior to running vl:qemu_init, so that it can use the qos_graph to identify the arguments required to initialize a guest for libqos-assisted fuzzing. This change prevents errors when vl:qemu_init tries to (re)initialize the previously initialized QOM m

Re: About MONITOR/MWAIT in i386 CPU model

2019-11-13 Thread Eduardo Habkost
On Wed, Nov 13, 2019 at 04:42:25PM +0800, Tao Xu wrote: > Hi Eduardo, > > After kvm use "-overcommit cpu-pm=on" to expose MONITOR/MWAIT > (commit id 6f131f13e68d648a8e4f083c667ab1acd88ce4cd), the MONITOR/MWAIT > feature in CPU model (phenom core2duo coreduo n270 Opteron_G3 EPYC Snowridge > Denvert

[PATCH v3 3/4] watchdog/aspeed: Improve watchdog timeout message

2019-11-13 Thread Joel Stanley
Users benefit from knowing which watchdog timer has expired. The address of the watchdog's registers unambiguously indicates which has expired, so log that. Reviewed-by: Cédric Le Goater Reviewed-by: Alex Bennée Signed-off-by: Joel Stanley --- v2: Use HWADDR_PRIx v3: Fix spacing --- hw/watchdo

[PATCH v3 4/4] watchdog/aspeed: Fix AST2600 frequency behaviour

2019-11-13 Thread Joel Stanley
The AST2600 control register sneakily changed the meaning of bit 4 without anyone noticing. It no longer controls the 1MHz vs APB clock select, and instead always runs at 1MHz. The AST2500 was always 1MHz too, but it retained bit 4, making it read only. We can model both using the same fixed 1MHz

[PATCH v3 0/4] arm/aspeed: Watchdog and SDRAM fixes

2019-11-13 Thread Joel Stanley
Three of these are fixes for ast2600 models that I found when testing master. The forth is a usability improvement that is helpful when diagnosing why a watchdog is biting. v3 adds some comments and fixes whitespace, and r-b from Alex. Thanks for the review Alex. v2 fixes some review comments fro

[PATCH v3 1/4] aspeed/sdmc: Make ast2600 default 1G

2019-11-13 Thread Joel Stanley
Most boards have this much. Reviewed-by: Cédric Le Goater Reviewed-by: Alex Bennée Signed-off-by: Joel Stanley --- hw/misc/aspeed_sdmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c index f3a63a2e01db..2df3244b53c8 1006

[PATCH v3 2/4] aspeed/scu: Fix W1C behavior

2019-11-13 Thread Joel Stanley
This models the clock write one to clear registers, and fixes up some incorrect behavior in all of the write to clear registers. There was also a typo in one of the register definitions. Reviewed-by: Cédric Le Goater Reviewed-by: Alex Bennée Signed-off-by: Joel Stanley --- v3: Beef up the comm

Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time

2019-11-13 Thread Eduardo Habkost
On Wed, Nov 13, 2019 at 09:01:29AM +0800, Tao Xu wrote: > On 11/13/2019 4:15 AM, Eduardo Habkost wrote: > > On Fri, Nov 08, 2019 at 09:05:52AM +0100, Markus Armbruster wrote: > > > Tao Xu writes: > > > > > > > On 11/7/2019 9:31 PM, Eduardo Habkost wrote: > > > > > On Thu, Nov 07, 2019 at 02:24:52

Re: [PATCH 0/2] Introducing QMP query-netdevs command

2019-11-13 Thread Alexey Kirillov
That's a good idea, thanks! I'll do this in V2. 14.11.2019, 00:32, "Eric Blake" : > > Can we rewrite the existing HMP command to call into the new QMP command? > -- Alex Kirillov Yandex.Cloud

Re: [PATCH 0/2] Introducing QMP query-netdevs command

2019-11-13 Thread Eric Blake
On 11/13/19 3:25 PM, Alexey Kirillov wrote: This patch introduces a new QMP command "query-netdevs" to get information about currently attached network devices. Potentially, this patch makes the "info_str" field of "struct NetClientState" and HMP command "info network" obsolete as new command giv

Re: [PATCH 1/2] qapi: net: Add query-netdevs command

2019-11-13 Thread Eric Blake
On 11/13/19 3:25 PM, Alexey Kirillov wrote: Add a qmp command that provides information about currently attached network devices and their configuration. Signed-off-by: Alexey Kirillov --- +++ b/qapi/net.json @@ -754,3 +754,88 @@ ## { 'event': 'FAILOVER_NEGOTIATED', 'data': {'device-

Re: [PULL 04/11] target/arm/cpu64: max cpu: Introduce sve properties

2019-11-13 Thread Peter Maydell
On Wed, 13 Nov 2019 at 20:17, Richard Henderson wrote: > > On 11/12/19 11:23 AM, Peter Maydell wrote: > >> +static uint32_t sve_zcr_get_valid_len(ARMCPU *cpu, uint32_t start_len) > >> +{ > >> +uint32_t start_vq = (start_len & 0xf) + 1; > >> + > >> +return arm_cpu_vq_map_next_smaller(cpu, s

[PATCH 2/2] tests: Add tests for query-netdevs command

2019-11-13 Thread Alexey Kirillov
Signed-off-by: Alexey Kirillov --- tests/Makefile.include | 2 + tests/test-query-netdevs.c | 114 + 2 files changed, 116 insertions(+) create mode 100644 tests/test-query-netdevs.c diff --git a/tests/Makefile.include b/tests/Makefile.include index 534e

Re: QEMU for Qualcomm Hexagon - KVM Forum talk and code available

2019-11-13 Thread Peter Maydell
On Wed, 13 Nov 2019 at 10:32, Alex Bennée wrote: > I don't see including flex/bison as a dependency > being a major issue (in fact we have it in our docker images so I guess > something uses it). They're used by the dtc submodule, so only in setups where you need to use the submodule rather than

[PATCH 1/2] qapi: net: Add query-netdevs command

2019-11-13 Thread Alexey Kirillov
Add a qmp command that provides information about currently attached network devices and their configuration. Signed-off-by: Alexey Kirillov --- include/net/net.h | 1 + net/hub.c | 8 +++ net/l2tpv3.c | 19 +++ net/net.c | 80 + net/net

[PATCH 0/2] Introducing QMP query-netdevs command

2019-11-13 Thread Alexey Kirillov
This patch introduces a new QMP command "query-netdevs" to get information about currently attached network devices. Potentially, this patch makes the "info_str" field of "struct NetClientState" and HMP command "info network" obsolete as new command gives out more information in a structured way.

Re: QEMU for Qualcomm Hexagon - KVM Forum talk and code available

2019-11-13 Thread Richard Henderson
On 11/13/19 8:31 PM, Taylor Simpson wrote: > [Taylor] Currently, I have the generator and the generated code sitting in > the source tree. I'm flexible on this if the decision is to regenerate it > every time. I would prefer to regenerate every time, and not store the generated code in the sour

[PATCH] tests: fix modules-test 'duplicate test case' error

2019-11-13 Thread Cole Robinson
./configure --enable-sdl --audio-drv-list=sdl --enable-modules Will generate two identical test names: /$arch/module/load/sdl Which generates an error like: (tests/modules-test:23814): GLib-ERROR **: 18:23:06.359: duplicate test case path: /aarch64//module/load/sdl Add the subsystem prefix in t

Re: [PATCH v9 Kernel 1/5] vfio: KABI for migration interface for device state

2019-11-13 Thread Alex Williamson
On Thu, 14 Nov 2019 01:47:04 +0530 Kirti Wankhede wrote: > On 11/14/2019 1:18 AM, Alex Williamson wrote: > > On Thu, 14 Nov 2019 00:59:52 +0530 > > Kirti Wankhede wrote: > > > >> On 11/13/2019 11:57 PM, Alex Williamson wrote: > >>> On Wed, 13 Nov 2019 11:24:17 +0100 > >>> Cornelia Huck wro

Re: [PATCH v9 Kernel 3/5] vfio iommu: Add ioctl defination to unmap IOVA and return dirty bitmap

2019-11-13 Thread Alex Williamson
On Thu, 14 Nov 2019 01:22:39 +0530 Kirti Wankhede wrote: > On 11/13/2019 4:00 AM, Alex Williamson wrote: > > On Tue, 12 Nov 2019 22:33:38 +0530 > > Kirti Wankhede wrote: > > > >> With vIOMMU, during pre-copy phase of migration, while CPUs are still > >> running, IO virtual address unmap can h

Re: [PULL 04/11] target/arm/cpu64: max cpu: Introduce sve properties

2019-11-13 Thread Richard Henderson
On 11/12/19 11:23 AM, Peter Maydell wrote: >> +static uint32_t sve_zcr_get_valid_len(ARMCPU *cpu, uint32_t start_len) >> +{ >> +uint32_t start_vq = (start_len & 0xf) + 1; >> + >> +return arm_cpu_vq_map_next_smaller(cpu, start_vq + 1) - 1; > > "Subtract operation overflows on operands > arm

Re: [PATCH v9 Kernel 1/5] vfio: KABI for migration interface for device state

2019-11-13 Thread Kirti Wankhede
On 11/14/2019 1:18 AM, Alex Williamson wrote: On Thu, 14 Nov 2019 00:59:52 +0530 Kirti Wankhede wrote: On 11/13/2019 11:57 PM, Alex Williamson wrote: On Wed, 13 Nov 2019 11:24:17 +0100 Cornelia Huck wrote: On Tue, 12 Nov 2019 15:30:05 -0700 Alex Williamson wrote: On Tue, 12 Nov

Re: [PATCH v9 Kernel 2/5] vfio iommu: Add ioctl defination to get dirty pages bitmap.

2019-11-13 Thread Alex Williamson
On Thu, 14 Nov 2019 01:07:21 +0530 Kirti Wankhede wrote: > On 11/13/2019 4:00 AM, Alex Williamson wrote: > > On Tue, 12 Nov 2019 22:33:37 +0530 > > Kirti Wankhede wrote: > > > >> All pages pinned by vendor driver through vfio_pin_pages API should be > >> considered as dirty during migration.

Re: [PATCH v9 Kernel 3/5] vfio iommu: Add ioctl defination to unmap IOVA and return dirty bitmap

2019-11-13 Thread Kirti Wankhede
On 11/13/2019 4:00 AM, Alex Williamson wrote: On Tue, 12 Nov 2019 22:33:38 +0530 Kirti Wankhede wrote: With vIOMMU, during pre-copy phase of migration, while CPUs are still running, IO virtual address unmap can happen while device still keeping reference of guest pfns. Those pages should be

Re: [PATCH v9 Kernel 1/5] vfio: KABI for migration interface for device state

2019-11-13 Thread Alex Williamson
On Thu, 14 Nov 2019 00:59:52 +0530 Kirti Wankhede wrote: > On 11/13/2019 11:57 PM, Alex Williamson wrote: > > On Wed, 13 Nov 2019 11:24:17 +0100 > > Cornelia Huck wrote: > > > >> On Tue, 12 Nov 2019 15:30:05 -0700 > >> Alex Williamson wrote: > >> > >>> On Tue, 12 Nov 2019 22:33:36 +0530 >

Re: [PATCH v9 Kernel 2/5] vfio iommu: Add ioctl defination to get dirty pages bitmap.

2019-11-13 Thread Kirti Wankhede
On 11/13/2019 4:00 AM, Alex Williamson wrote: On Tue, 12 Nov 2019 22:33:37 +0530 Kirti Wankhede wrote: All pages pinned by vendor driver through vfio_pin_pages API should be considered as dirty during migration. IOMMU container maintains a list of all such pinned pages. Added an ioctl defin

RE: QEMU for Qualcomm Hexagon - KVM Forum talk and code available

2019-11-13 Thread Taylor Simpson
Responses below ... Taylor Taylor Simpson writes: > I had discussions with several people at the KVM Forum, and I’ve been > thinking about how to divide up the code for community review. Here is my > proposal for the steps. > > 1. linux-user changes + linux-user/hexagon + skeleton of > t

Re: [PATCH v9 Kernel 1/5] vfio: KABI for migration interface for device state

2019-11-13 Thread Kirti Wankhede
On 11/13/2019 11:57 PM, Alex Williamson wrote: On Wed, 13 Nov 2019 11:24:17 +0100 Cornelia Huck wrote: On Tue, 12 Nov 2019 15:30:05 -0700 Alex Williamson wrote: On Tue, 12 Nov 2019 22:33:36 +0530 Kirti Wankhede wrote: - Defined MIGRATION region type and sub-type. - Used 3 bits to d

Re: [PATCH v9 Kernel 1/5] vfio: KABI for migration interface for device state

2019-11-13 Thread Kirti Wankhede
On 11/13/2019 8:53 AM, Yan Zhao wrote: On Wed, Nov 13, 2019 at 06:30:05AM +0800, Alex Williamson wrote: On Tue, 12 Nov 2019 22:33:36 +0530 Kirti Wankhede wrote: - Defined MIGRATION region type and sub-type. - Used 3 bits to define VFIO device states. Bit 0 => _RUNNING Bit 1 => _S

[PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests

2019-11-13 Thread Pierre Morel
The PONG device accept two commands: PONG_READ and PONG_WRITE which allow to read from and write to an internal buffer of 1024 bytes. The QEMU device is named ccw-pong. Signed-off-by: Pierre Morel --- hw/s390x/Makefile.objs | 1 + hw/s390x/ccw-pong.c | 186 +++

Re: [EXTERNAL]Re: [PATCH v1 5/5] .travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS

2019-11-13 Thread Alex Bennée
Aleksandar Markovic writes: >> From: Philippe Mathieu-Daudé >> > -- >> > MAIN_SOFTMMU_TARGETS="aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" >> > +- >> > MAIN_SOFTMMU_TARGETS="aarch64-softmmu,mips64-so

[PATCH V2] WHPX: refactor load library

2019-11-13 Thread Sunil Muthuswamy
This refactors the load library of WHV libraries to make it more modular. It makes a helper routine that can be called on demand. This allows future expansion of load library/functions to support functionality that is dependent on some feature being available. Signed-off-by: Sunil Muthuswamy ---

Re: [PATCH v2 1/5] MAINTAINERS: Add a section on UI translation

2019-11-13 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 11/13/19 2:47 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic There should be a person who will quickly evaluate new UI translation, and find a way to update existing ones should something changes in UI. I appreciate your trust, but I'm afraid I know next to nothin

[PATCH v7 1/3] block: introduce compress filter driver

2019-11-13 Thread Andrey Shinkevich
Allow writing all the data compressed through the filter driver. The written data will be aligned by the cluster size. Based on the QEMU current implementation, that data can be written to unallocated clusters only. May be used for a backup job. Suggested-by: Max Reitz Signed-off-by: Andrey Shink

[PATCH v7 2/3] qcow2: Allow writing compressed data of multiple clusters

2019-11-13 Thread Andrey Shinkevich
QEMU currently supports writing compressed data of the size equal to one cluster. This patch allows writing QCOW2 compressed data that exceed one cluster. Now, we split buffered data into separate clusters and write them compressed using the existing functionality. Suggested-by: Pavel Butsykin Si

Re: [EXTERNAL]Re: [PATCH v1 5/5] .travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS

2019-11-13 Thread Philippe Mathieu-Daudé
On 11/13/19 6:38 PM, Aleksandar Markovic wrote: From: Philippe Mathieu-Daudé -- MAIN_SOFTMMU_TARGETS="aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" +- MAIN_SOFTMMU_TARGETS="aarch64-softmmu,mips64-softmm

[PATCH v7 3/3] tests/qemu-iotests: add case to write compressed data of multiple clusters

2019-11-13 Thread Andrey Shinkevich
Add the case to the iotest #214 that checks possibility of writing compressed data of more than one cluster size. The test case involves the compress filter driver showing a sample usage of that. Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/214 | 43 +++

[PATCH v7 0/3] qcow2: advanced compression options

2019-11-13 Thread Andrey Shinkevich
The compression filter driver is introduced as suggested by Max. A sample usage of the filter can be found in the test #214. Now, multiple clusters can be written compressed. It is useful for the backup job. v7: 01: The 'zip_' prefix for the compression filter functions replaced with 'compre

Re: [PATCH v9 Kernel 1/5] vfio: KABI for migration interface for device state

2019-11-13 Thread Alex Williamson
On Wed, 13 Nov 2019 11:24:17 +0100 Cornelia Huck wrote: > On Tue, 12 Nov 2019 15:30:05 -0700 > Alex Williamson wrote: > > > On Tue, 12 Nov 2019 22:33:36 +0530 > > Kirti Wankhede wrote: > > > > > - Defined MIGRATION region type and sub-type. > > > - Used 3 bits to define VFIO device states.

[PATCH] migration: Fix the re-run check of the migrate-incoming command

2019-11-13 Thread Yury Kotov
The current check sets an error but doesn't fail the command. This may cause a problem if new connection attempt by the same URI affects the first connection. Signed-off-by: Yury Kotov --- migration/migration.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/migration.c b/migration

Re: [EXTERNAL]Re: [PATCH v1 5/5] .travis.yml: drop 32 bit systems from MAIN_SOFTMMU_TARGETS

2019-11-13 Thread Aleksandar Markovic
> From: Philippe Mathieu-Daudé > > -- > > MAIN_SOFTMMU_TARGETS="aarch64-softmmu,arm-softmmu,i386-softmmu,mips-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s390x-softmmu,x86_64-softmmu" > > +- > > MAIN_SOFTMMU_TARGETS="aarch64-softmmu,mips64-softmmu,ppc64-softmmu,riscv64-softmmu,s

RE: [PATCH] WHPX: refactor load library

2019-11-13 Thread Sunil Muthuswamy
> Making it easier for other people to test WHPX would be nice. Yes, we understand the concerns and I generally agree here. I am trying to connect the different teams involved here (legal, SDK here) and connect the dots for them, to see what can be done here. > But in case this is not sorted ou

RE: [PATCH] WHPX: refactor load library

2019-11-13 Thread Sunil Muthuswamy
> Can we wait for approval from the Microsoft legal department first? > So we can start testing WHPX builds, and reduce the possibilities to > introduce regressions. > > Testing is ready, we are waiting for Microsoft to merge, see: > https://nam06.safelinks.protection.outlook.com/?url=https%3A%

Re: [RFC v4 PATCH 41/49] multi-process/mig: Enable VMSD save in the Proxy object

2019-11-13 Thread Daniel P . Berrangé
On Wed, Nov 13, 2019 at 11:32:09AM -0500, Jag Raman wrote: > > > On 11/13/2019 10:50 AM, Daniel P. Berrangé wrote: > > On Thu, Oct 24, 2019 at 05:09:22AM -0400, Jagannathan Raman wrote: > > > Collect the VMSD from remote process on the source and save > > > it to the channel leading to the destin

Re: [PATCH for 5.0 0/6] linux-user: Add support for real time clock ioctls

2019-11-13 Thread Laurent Vivier
Hi Filip, Le 13/11/2019 à 17:41, Filip Bozuta a écrit : > Add ioctls for all rtc features that are currently supported in linux kernell. > > Filip Bozuta (6): > linux-user: Add support for enabling/disabling rtc features using > ioctls > linux-user: Add set and read for rtc time and alarm

RE: [PATCH] WHPX: refactor load library

2019-11-13 Thread Sunil Muthuswamy
> -Original Message- > From: Paolo Bonzini > Sent: Wednesday, November 13, 2019 7:00 AM > To: Sunil Muthuswamy ; Richard Henderson > ; Eduardo Habkost ; > Stefan Weil > Cc: qemu-devel@nongnu.org; Justin Terry (VM) > Subject: Re: [PATCH] WHPX: refactor load library > > On 08/11/19 21:

Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

2019-11-13 Thread Sam Eiderman
Links to latest commits from archive. You can see all changes in the cover letter. [SeaBIOS] [PATCH v4 0/5] Add Qemu to SeaBIOS LCHS interface https://mail.coreboot.org/hyperkitty/list/seab...@seabios.org/message/VLNFBEERTWLEUO6LM5BYLBNVIFCTP46M/ [SeaBIOS] [PATCH v4 1/5] geometry: Read LCHS from f

[PATCH for 5.0 1/6] linux-user: Add support for enabling/disabling rtc features using ioctls

2019-11-13 Thread Filip Bozuta
Signed-off-by: Filip Bozuta --- linux-user/ioctls.h | 9 + linux-user/syscall.c | 1 + linux-user/syscall_defs.h | 10 ++ 3 files changed, 20 insertions(+) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index c6b9d6a..97741c7 100644 --- a/linux-user/ioctls.h

[PATCH for 5.0 5/6] linux-user: Add get and set for rtc pll correction using ioctls

2019-11-13 Thread Filip Bozuta
Signed-off-by: Filip Bozuta --- linux-user/ioctls.h| 2 ++ linux-user/syscall_defs.h | 14 ++ linux-user/syscall_types.h | 9 + 3 files changed, 25 insertions(+) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index 5830315..eea65e1 100644 --- a/linux-user/i

[PATCH for 5.0 0/6] linux-user: Add support for real time clock ioctls

2019-11-13 Thread Filip Bozuta
Add ioctls for all rtc features that are currently supported in linux kernell. Filip Bozuta (6): linux-user: Add support for enabling/disabling rtc features using ioctls linux-user: Add set and read for rtc time and alarm using ioctls linux-user: Add read and set for rtc periodic interru

Re: [PATCH] WHPX: refactor load library

2019-11-13 Thread Eduardo Habkost
On Wed, Nov 13, 2019 at 05:35:59PM +0100, Philippe Mathieu-Daudé wrote: > On 11/12/19 8:47 PM, Eduardo Habkost wrote: > > On Tue, Nov 12, 2019 at 06:42:00PM +, Sunil Muthuswamy wrote: > > > > > > > > > > -Original Message- > > > > From: Sunil Muthuswamy > > > > Sent: Friday, November

[PATCH for 5.0 6/6] linux-user: Add rtc voltage low detector read and clear using ioctls

2019-11-13 Thread Filip Bozuta
Signed-off-by: Filip Bozuta --- linux-user/ioctls.h | 2 ++ linux-user/syscall_defs.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index eea65e1..330e502 100644 --- a/linux-user/ioctls.h +++ b/linux-user/ioctls.h @@ -89,6 +89,8 @@ IO

  1   2   3   >