[PATCH v16 11/14] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-11-14 Thread Tao Xu
From: Liu Jingqi This structure describes the memory access latency and bandwidth information from various memory access initiator proximity domains. The latency and bandwidth numbers represented in this structure correspond to rated latency and bandwidth for the platform. The software could use

[PATCH v16 06/14] tests: Add test for QAPI builtin type time

2019-11-14 Thread Tao Xu
Add tests for time input such as zero, around limit of precision, signed upper limit, actual upper limit, beyond limits, time suffixes, and etc. Signed-off-by: Tao Xu --- Changes in v16: - Update the test cases Changes in v14: - Drop time unit picosecond (Eric) --- tests/test-keyval.c

[PATCH v16 05/14] qapi: Add builtin type time

2019-11-14 Thread Tao Xu
Add optional builtin type time, fallback is uint64. This type use qemu_strtotime_ns() for pre-converting time suffix to numbers. Signed-off-by: Tao Xu --- No changes in v16. Changes in v14: - Drop time unit picosecond (Eric) --- include/qapi/visitor-impl.h | 4

[PATCH v16 03/14] util/cutils: refactor do_strtosz() to support suffixes list

2019-11-14 Thread Tao Xu
Add do_strtomul() to convert string according to different suffixes. Reviewed-by: Eduardo Habkost Signed-off-by: Tao Xu --- No changes in v16. Changes in v15: - Add a new patch to refactor do_strtosz() (Eduardo) --- util/cutils.c | 72 ++-

[PATCH v16 02/14] util/cutils: Use qemu_strtold_finite to parse size

2019-11-14 Thread Tao Xu
Support full 64bit precision, modify related test cases. Signed-off-by: Tao Xu --- New patch in v16 --- tests/test-cutils.c| 41 +--- tests/test-keyval.c| 47 +++--- tests/test-qemu-opts.c | 39

[PATCH v16 04/14] util/cutils: Add qemu_strtotime_ns()

2019-11-14 Thread Tao Xu
To convert strings with time suffixes to numbers, support time unit are "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" for second. Add test for qemu_strtotime_ns, test the input of basic, time suffixes, float, invaild, trailing and overflow. Reviewed-by: Eduardo Habkost

[PATCH v16 01/14] util/cutils: Add Add qemu_strtold and qemu_strtold_finite

2019-11-14 Thread Tao Xu
Work like qemu_strtod() and qemu_strtold_finite, except store long double. Signed-off-by: Tao Xu --- New patch in v16. --- include/qemu/cutils.h | 3 +++ util/cutils.c | 48 ++- 2 files changed, 50 insertions(+), 1 deletion(-) diff --git

[PATCH v16 00/14] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-11-14 Thread Tao Xu
This series of patches will build Heterogeneous Memory Attribute Table (HMAT) according to the command line. The ACPI HMAT describes the memory attributes, such as memory side cache attributes and bandwidth and latency details, related to the Memory Proximity Domain. The software is expected to

Re: [PATCH] Modify tests to work with clang

2019-11-14 Thread Thomas Huth
On 15/11/2019 05.38, Taylor Simpson wrote: > Signed-off-by: Taylor Simpson > --- > tests/tcg/multiarch/float_helpers.c | 13 - > tests/tcg/multiarch/linux-test.c| 2 +- > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/tests/tcg/multiarch/float_helpers.c >

Re: [SeaBIOS] Re: [PATCH] ahci: zero-initialize port struct

2019-11-14 Thread Gerd Hoffmann
On Thu, Nov 14, 2019 at 11:08:59AM +0200, Sam Eiderman wrote: > Do you want a single commit with the changes? That is the idea, unless it is too messy. I don't have v4 any more, looks like I've deleted v4 instead of v3 while cleaning up my mail folders, so I can't easily check. Do you have v3

Re: [PATCH] Implement backend program convention command for vhost-user-blk

2019-11-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191115060925.12346-1-mic...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] Implement backend program convention command for vhost-user-blk Type: series Message-id:

[PATCH] Implement backend program convention command for vhost-user-blk

2019-11-14 Thread Micky Yun Chan
From: michan Signed-off-by: Micky Yun Chan (michiboo) --- contrib/vhost-user-blk/vhost-user-blk.c | 95 +++-- 1 file changed, 57 insertions(+), 38 deletions(-) diff --git a/contrib/vhost-user-blk/vhost-user-blk.c b/contrib/vhost-user-blk/vhost-user-blk.c index

Re: [PATCH] Modify tests to work with clang

2019-11-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1573792691-398-1-git-send-email-tsimp...@quicinc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] Modify tests to work with clang Type: series Message-id:

RE: [PATCH v9 Kernel 2/5] vfio iommu: Add ioctl defination to get dirty pages bitmap.

2019-11-14 Thread Tian, Kevin
> From: Alex Williamson > Sent: Friday, November 15, 2019 11:22 AM > > On Thu, 14 Nov 2019 21:40:35 -0500 > Yan Zhao wrote: > > > On Fri, Nov 15, 2019 at 05:06:25AM +0800, Alex Williamson wrote: > > > On Fri, 15 Nov 2019 00:26:07 +0530 > > > Kirti Wankhede wrote: > > > > > > > On 11/14/2019

[PULL 4/4] riscv/virt: Increase flash size

2019-11-14 Thread Palmer Dabbelt
From: Alistair Francis Coreboot developers have requested that they have at least 32MB of flash to load binaries. We currently have 32MB of flash, but it is split in two to allow loading two flash binaries. Let's increase the flash size from 32MB to 64MB to ensure we have a single region that is

[PULL 2/4] target/riscv: Remove atomic accesses to MIP CSR

2019-11-14 Thread Palmer Dabbelt
From: Alistair Francis Instead of relying on atomics to access the MIP register let's update our helper function to instead just lock the IO mutex thread before writing. This follows the same concept as used in PPC for handling interrupts Signed-off-by: Alistair Francis Reviewed-by: Richard

[PULL 3/4] opensbi: Upgrade from v0.4 to v0.5

2019-11-14 Thread Palmer Dabbelt
From: Alistair Francis This release has: Lot of critical fixes Hypervisor extension support SBI v0.2 base extension support Debug prints support Handle traps when doing unpriv load/store Allow compiling without FP support Use git describe to generate boot-time banner

[PULL 1/4] remove unnecessary ifdef TARGET_RISCV64

2019-11-14 Thread Palmer Dabbelt
From: "hiroyuki.obinata" Signed-off-by: Hiroyuki Obinata Signed-off-by: Palmer Dabbelt --- target/riscv/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index b26533d4fd78..ab6a891dc381 100644 ---

[PULL] RISC-V Fixes for 4.2-rc2

2019-11-14 Thread Palmer Dabbelt
The following changes since commit aa464db69b40b4b695be31085e6d2f1e90956c89: Update version for v4.2.0-rc1 release (2019-11-12 18:40:02 +) are available in the Git repository at: g...@github.com:palmer-dabbelt/qemu.git tags/riscv-for-master-4.2-rc2 for you to fetch changes up to

[PATCH] Modify tests to work with clang

2019-11-14 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- tests/tcg/multiarch/float_helpers.c | 13 - tests/tcg/multiarch/linux-test.c| 2 +- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/tests/tcg/multiarch/float_helpers.c b/tests/tcg/multiarch/float_helpers.c index 8ee7903..437247c

[RFC PATCH v1 7/8] vfio-ccw: Refactor ccw irq handler

2019-11-14 Thread Eric Farman
Make it easier to add new ones in the future. Signed-off-by: Eric Farman --- hw/vfio/ccw.c | 55 --- 1 file changed, 39 insertions(+), 16 deletions(-) diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index 2b1a83b94c..b16526d5de 100644 ---

[RFC PATCH v1 5/8] vfio-ccw: Add support for the schib region

2019-11-14 Thread Eric Farman
From: Farhan Ali The schib region can be used to obtain the latest SCHIB from the host passthrough subchannel. Since the guest SCHIB is virtualized, we currently only update the path related information so that the guest is aware of any path related changes when it issues the 'stsch'

[RFC PATCH v1 8/8] vfio-ccw: Add support for the CRW irq

2019-11-14 Thread Eric Farman
From: Farhan Ali The CRW irq will be used by vfio-ccw to notify the userspace about any CRWs the userspace needs to handle. Let's add support for it. Signed-off-by: Farhan Ali Signed-off-by: Eric Farman --- Notes: v0->v1: [EF] - Check vcdev->crw_region before registering the irq,

[RFC PATCH v1 4/8] vfio-ccw: Refactor cleanup of regions

2019-11-14 Thread Eric Farman
While we're at it, add a g_free() for the async_cmd_region that is the last thing currently created. g_free() knows how to handle NULL pointers, so this makes it easier to remember what cleanups need to be performed when new regions are added. Signed-off-by: Eric Farman --- hw/vfio/ccw.c | 14

[RFC PATCH v1 1/8] vfio-ccw: Return IOINST_CC_NOT_OPERATIONAL for EIO

2019-11-14 Thread Eric Farman
From: Farhan Ali EIO is returned by vfio-ccw mediated device when the backing host subchannel is not operational anymore. So return cc=3 back to the guest, rather than returning a unit check. This way the guest can take appropriate action such as issue an 'stsch'. Signed-off-by: Farhan Ali ---

[RFC PATCH v1 0/8] s390x/vfio-ccw: Channel Path Handling

2019-11-14 Thread Eric Farman
Here is a first pass at the channel-path handling code for vfio-ccw, to take advantage of the corresponding kernel patches posted here: https://lore.kernel.org/kvm/20191115025620.19593-1-far...@linux.ibm.com/ As with the KVM patches, these were originally written by Farhan Ali this past summer,

[RFC PATCH v1 6/8] vfio-ccw: Add support for the crw region

2019-11-14 Thread Eric Farman
From: Farhan Ali The crw region can be used to obtain information about Channel Report Words (CRW) from vfio-ccw driver. Currently only channel path related CRWs are passed to QEMU from vfio-ccw driver. Signed-off-by: Farhan Ali Signed-off-by: Eric Farman --- Notes: v0->v1: [EF] -

[RFC PATCH v1 3/8] linux-headers: update

2019-11-14 Thread Eric Farman
From: Farhan Ali Signed-off-by: Farhan Ali Signed-off-by: Eric Farman --- Notes: v0->v1: [EF] - Run scripts/update-linux-headers.sh properly, but do not add resulting changes to linux-headers/asm-mips/ linux-headers/linux/vfio.h | 3 +++ linux-headers/linux/vfio_ccw.h |

[RFC PATCH v1 2/8] vfio-ccw: Don't inject an I/O interrupt if the subchannel is not enabled

2019-11-14 Thread Eric Farman
From: Farhan Ali According to PoPs, when the SCHIB.PMCW bit 8 is 0 status presented by the device is not made available to the program. So don't inject an interrupt in the guest if the guest OS has not enabled the subchannel. Signed-off-by: Farhan Ali Signed-off-by: Eric Farman --- Notes:

Re: [PATCH v5] iotests: Test NBD client reconnection

2019-11-14 Thread Andrey Shinkevich
On 14/11/2019 18:09, Eric Blake wrote: > On 11/11/19 9:39 PM, Andrey Shinkevich wrote: >> The test for an NBD client. The NBD server is disconnected after the >> client write request. The NBD client should reconnect and complete >> the write operation. >> >> Suggested-by: Denis V. Lunev >>

Re: [PATCH v9 Kernel 2/5] vfio iommu: Add ioctl defination to get dirty pages bitmap.

2019-11-14 Thread Alex Williamson
On Thu, 14 Nov 2019 21:40:35 -0500 Yan Zhao wrote: > On Fri, Nov 15, 2019 at 05:06:25AM +0800, Alex Williamson wrote: > > On Fri, 15 Nov 2019 00:26:07 +0530 > > Kirti Wankhede wrote: > > > > > On 11/14/2019 1:37 AM, Alex Williamson wrote: > > > > On Thu, 14 Nov 2019 01:07:21 +0530 > > > >

Re: [PATCH v9 Kernel 2/5] vfio iommu: Add ioctl defination to get dirty pages bitmap.

2019-11-14 Thread Yan Zhao
On Fri, Nov 15, 2019 at 05:06:25AM +0800, Alex Williamson wrote: > On Fri, 15 Nov 2019 00:26:07 +0530 > Kirti Wankhede wrote: > > > On 11/14/2019 1:37 AM, Alex Williamson wrote: > > > On Thu, 14 Nov 2019 01:07:21 +0530 > > > Kirti Wankhede wrote: > > > > > >> On 11/13/2019 4:00 AM, Alex

Re: virtio,iommu_platform=on

2019-11-14 Thread Alexey Kardashevskiy
On 14/11/2019 19:42, Michael S. Tsirkin wrote: > On Thu, Nov 14, 2019 at 09:58:47AM +1100, Alexey Kardashevskiy wrote: >> >> >> On 13/11/2019 21:00, Michael S. Tsirkin wrote: >>> On Wed, Nov 13, 2019 at 03:44:28PM +1100, Alexey Kardashevskiy wrote: On 12/11/2019 18:08, Michael S.

9p: requests efficiency

2019-11-14 Thread Christian Schoenebeck
I'm currently reading up on how client requests (T messages) are currently dispatched in general by 9pfs, to understand where potential inefficiencies are that I am encountering. I mean 9pfs is pretty fast on raw I/O (read/write requests), provided that the message payload on guest side was

RE: QEMU for Qualcomm Hexagon - KVM Forum talk and code available

2019-11-14 Thread Taylor Simpson
OK, I changed the code in github and will upstream it that way. -Original Message- From: Richard Henderson Sent: Wednesday, November 13, 2019 3:10 PM To: Taylor Simpson ; Alex Bennée ; qemu-devel@nongnu.org Cc: Alessandro Di Federico ; ni...@rev.ng; Niccolò Izzo ; Aleksandar Markovic

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

2019-11-14 Thread Matti Hameister
I tried the ArchLinux package that includes three patches applied to qemu 4.1 ( see https://git.archlinux.org/svntogit/packages.git/commit/trunk/PKGBUILD?h=packages/qemu=e9707066408de26aa04f8d0ddebe5556aa87e662 ). My Windows 10 qcow2 image got corrupted again after a short time of use. Host

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Keith Packard
Richard Henderson writes: > For semi-hosting, it seems even better if the semi-hosting syscall instruction > is not "real", because you're explicitly requesting services from "unreal" > hardware. It should be specified to generate a SIGILL type of exception > anywhere semi-hosting is not

[ANNOUNCE] QEMU 4.1.1 Stable released

2019-11-14 Thread Michael Roth
Hi everyone, I am pleased to announce that the QEMU v4.1.1 stable release is now available: You can grab the tarball from our download page here: https://www.qemu.org/download/#source v4.1.1 is now tagged in the official qemu.git repository, and the stable-4.1 branch has been updated

[PATCH v3 4/4] tests: More iotest 223 improvements

2019-11-14 Thread Eric Blake
Run the core of the test twice, once without iothreads, and again with, for more coverage of both setups. Suggested-by: Nir Soffer Signed-off-by: Eric Blake Reviewed-by: Max Reitz --- tests/qemu-iotests/223 | 16 ++- tests/qemu-iotests/223.out | 85

[PATCH v3 2/4] iotests: Switch nbd tests to use Unix rather than TCP

2019-11-14 Thread Eric Blake
Up to now, all it took to cause a lot of iotest failures was to have a background process such as 'nbdkit -p 10810 null' running, because we hard-coded the TCP port. Switching to a Unix socket eliminates this contention. We still have TCP coverage in test 233, and that test is more careful to

[PATCH v3 1/4] iotests: Fix 173

2019-11-14 Thread Eric Blake
This test has been broken since 3.0. It used TEST_IMG to influence the name of a file created during _make_test_img, but commit 655ae6bb changed things so that the wrong file name is being created, which then caused _launch_qemu to fail. In the meantime, the set of events issued for the actions

[PATCH v3 3/4] iotests: Include QMP input in .out files

2019-11-14 Thread Eric Blake
We generally include relevant HMP input in .out files, by virtue of the fact that HMP echoes its input. But QMP does not, so we have to explicitly inject it in the output stream (appropriately filtered to keep the tests passing), in order to make it easier to read .out files to see what behavior

[PATCH v3 for-4.2 0/4] tests: More iotest 223 improvements

2019-11-14 Thread Eric Blake
Since v2: - rebase to SOCK_DIR changes - new patch 2 to avoid TCP port 10810 contention [Max] - add imgfmt filtering [Max] As this is limited to iotests, I think it is fair game for -rc2. Eric Blake (4): iotests: Fix 173 iotests: Switch nbd tests to use Unix rather than TCP iotests:

Re: [PATCH v2 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-14 Thread Philippe Mathieu-Daudé
Hi Eric, On 11/8/19 4:56 PM, Eric Blake wrote: On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric Blake Buglink:

Re: [PATCH v2 3/5] MAINTAINERS: Adjust maintainership for Malta board

2019-11-14 Thread Philippe Mathieu-Daudé
+Paul Burton On 11/13/19 2:47 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Change the maintainership for Malta board to improve its quality. Acked-by: Aurelien Jarno Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [PATCH v2 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-14 Thread Philippe Mathieu-Daudé
On 11/8/19 4:58 PM, Eric Blake wrote: On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric Blake Buglink:

Re: [PATCH v9 Kernel 3/5] vfio iommu: Add ioctl defination to unmap IOVA and return dirty bitmap

2019-11-14 Thread Alex Williamson
On Fri, 15 Nov 2019 00:26:26 +0530 Kirti Wankhede wrote: > On 11/14/2019 1:52 AM, Alex Williamson wrote: > > On Thu, 14 Nov 2019 01:22:39 +0530 > > Kirti Wankhede wrote: > > > >> On 11/13/2019 4:00 AM, Alex Williamson wrote: > >>> On Tue, 12 Nov 2019 22:33:38 +0530 > >>> Kirti Wankhede

Re: [PATCH v9 Kernel 2/5] vfio iommu: Add ioctl defination to get dirty pages bitmap.

2019-11-14 Thread Alex Williamson
On Fri, 15 Nov 2019 00:26:07 +0530 Kirti Wankhede wrote: > On 11/14/2019 1:37 AM, Alex Williamson wrote: > > On Thu, 14 Nov 2019 01:07:21 +0530 > > Kirti Wankhede wrote: > > > >> On 11/13/2019 4:00 AM, Alex Williamson wrote: > >>> On Tue, 12 Nov 2019 22:33:37 +0530 > >>> Kirti Wankhede

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 20:52, Richard Henderson wrote: > Yet another reason why I prefer any semi-hosting call to use an encoding that > is otherwise reserved illegal. > > For this, you have to make up your mind: is it important to execute the > instructions as specified by the ISA, or as

Re: [PATCH] pl031: Expose RTCICR as proper WC register

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 20:45, Alexander Graf wrote: > On 14.11.19 15:42, Peter Maydell wrote: > > Is that OK? > > It's much better. Will you just fix it up inline for me please? :) Sure :-) -- PMM

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Richard Henderson
On 11/14/19 8:29 PM, Peter Maydell wrote: > On Thu, 14 Nov 2019 at 19:18, Richard Henderson > wrote: >> - If the sequence crosses a page, then so be it. Because of >> step 1, this only happens when we *must* cross a page, and >> will have recognized any paging exception anyway. >>

Re: [PATCH] pl031: Expose RTCICR as proper WC register

2019-11-14 Thread Alexander Graf
On 14.11.19 15:42, Peter Maydell wrote: On Tue, 12 Nov 2019 at 11:57, Peter Maydell wrote: On Tue, 12 Nov 2019 at 07:28, Alexander Graf wrote: I still think that being consistent with the actual PL031 spec is preferable though. If any real world guest breaks because of this, we can still

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 19:18, Richard Henderson wrote: > - If the sequence crosses a page, then so be it. Because of > step 1, this only happens when we *must* cross a page, and > will have recognized any paging exception anyway. > The generic parts of qemu will handle proper

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 17:47, Peter Maydell wrote: > The ARM semihosting ABI also has a number of warts > which are basically historical legacy. With a clean > sheet you get to avoid some of them. (Notably you could > skip the whole 'negotiate presence of extensions' business > by just getting

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Richard Henderson
On 11/14/19 5:14 PM, Peter Maydell wrote: > On Fri, 25 Oct 2019 at 20:15, Keith Packard wrote: >> There seems to be convergence on a pretty simple interface which uses >> ebreak surrounded by a couple of specific no-ops: >> >> slli x0, x0, 0x1f >> ebreak >> srai x0, x0, 0x7 >>

Re: [PATCH v9 Kernel 3/5] vfio iommu: Add ioctl defination to unmap IOVA and return dirty bitmap

2019-11-14 Thread Kirti Wankhede
On 11/14/2019 1:52 AM, Alex Williamson wrote: On Thu, 14 Nov 2019 01:22:39 +0530 Kirti Wankhede wrote: On 11/13/2019 4:00 AM, Alex Williamson wrote: On Tue, 12 Nov 2019 22:33:38 +0530 Kirti Wankhede wrote: With vIOMMU, during pre-copy phase of migration, while CPUs are still

Re: [PATCH v9 Kernel 2/5] vfio iommu: Add ioctl defination to get dirty pages bitmap.

2019-11-14 Thread Kirti Wankhede
On 11/14/2019 1:37 AM, Alex Williamson wrote: On Thu, 14 Nov 2019 01:07:21 +0530 Kirti Wankhede wrote: On 11/13/2019 4:00 AM, Alex Williamson wrote: On Tue, 12 Nov 2019 22:33:37 +0530 Kirti Wankhede wrote: All pages pinned by vendor driver through vfio_pin_pages API should be

Re: [PATCH v9 Kernel 1/5] vfio: KABI for migration interface for device state

2019-11-14 Thread Kirti Wankhede
+ * Vendor driver should decide whether to partition data section and how to + * partition the data section. Vendor driver should return data_offset + * accordingly. + * + * Sequence to be followed for _SAVING|_RUNNING device state or pre-copy phase + * and for _SAVING device state or

Re: [PATCH v2 00/10] Further bitmaps improvements

2019-11-14 Thread Vladimir Sementsov-Ogievskiy
14.11.2019 21:47, Eric Blake wrote: > On 10/22/19 7:58 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hi! >> >> The main feature here is improvement of _next_dirty_area API, which I'm >> going to use then for backup / block-copy. >> >> v2: >> 01: just use INT64_MAX instead of adding new constant >>

Re: [PATCH v9 Kernel 1/5] vfio: KABI for migration interface for device state

2019-11-14 Thread Kirti Wankhede
On 11/14/2019 2:10 AM, Alex Williamson wrote: On Thu, 14 Nov 2019 01:47:04 +0530 Kirti Wankhede wrote: On 11/14/2019 1:18 AM, Alex Williamson wrote: On Thu, 14 Nov 2019 00:59:52 +0530 Kirti Wankhede wrote: On 11/13/2019 11:57 PM, Alex Williamson wrote: On Wed, 13 Nov 2019 11:24:17

Re: [PATCH v2 00/10] Further bitmaps improvements

2019-11-14 Thread Eric Blake
On 10/22/19 7:58 AM, Vladimir Sementsov-Ogievskiy wrote: Hi! The main feature here is improvement of _next_dirty_area API, which I'm going to use then for backup / block-copy. v2: 01: just use INT64_MAX instead of adding new constant 08: add separate function nbd_extent_array_convert_to_be and

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 18:05, Keith Packard wrote: > > Peter Maydell writes: > > > I had an idle glance at this implementation, and this: > > > >uint32_t pre = opcode_at(>base, ctx->base.pc_next - 4); > >uint32_t ebreak = opcode_at(>base, ctx->base.pc_next); > >uint32_t post =

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Keith Packard
Peter Maydell writes: > I had an idle glance at this implementation, and this: > >uint32_t pre = opcode_at(>base, ctx->base.pc_next - 4); >uint32_t ebreak = opcode_at(>base, ctx->base.pc_next); >uint32_t post = opcode_at(>base, ctx->base.pc_next + 4); > > (where opcode_at() is a

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Thu, 14 Nov 2019 at 17:39, Keith Packard wrote: > > Peter Maydell writes: > > > That defines the instruction sequence used to make a semihosting > > call, but not the specification of what the calls are: > > * what call numbers perform which functions > > * how arguments are passed to the

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Keith Packard
Alistair Francis writes: > This sounds like something that the platform spec should contain. I'm frankly happy with it specifying the semantics by reference to the ARM docs -- that way we can easily share existing code without concern about subtle semantic differences. The only thing that

Re: [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests

2019-11-14 Thread Pierre Morel
On 2019-11-14 14:19, Cornelia Huck wrote: On Thu, 14 Nov 2019 14:02:35 +0100 Halil Pasic wrote: On Thu, 14 Nov 2019 11:38:23 +0100 Cornelia Huck wrote: On Wed, 13 Nov 2019 20:02:33 +0100 Pierre Morel wrote: ...snip... We made some different design decisions, while aiming essentially

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Keith Packard
Peter Maydell writes: > That defines the instruction sequence used to make a semihosting > call, but not the specification of what the calls are: > * what call numbers perform which functions > * how arguments are passed to the call (registers? parameter >blocks in memory? other?) > * the

Re: [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests

2019-11-14 Thread Pierre Morel
On 2019-11-14 14:02, Halil Pasic wrote: On Thu, 14 Nov 2019 11:38:23 +0100 Cornelia Huck wrote: On Wed, 13 Nov 2019 20:02:33 +0100 Pierre Morel wrote: Minor nit for $SUBJECT: this isn't a kvm-unit-tests patch, that's just one consumer :) And subchannel is one word in s390-speak. OK,

Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-14 Thread Alexander Popov
On 07.11.2019 01:05, Alexander Popov wrote: > On 06.11.2019 15:05, Michael S. Tsirkin wrote: >> Do you want to cook up a patch like this then? > > Yes, I will take this task and return with a patch. > > Thanks! I've just sent the v2 of the patch. Looking forward to your feedback. Best regards,

[PATCH v2 1/1] ide: check DMA transfer size in ide_dma_cb() to prevent qemu DoS from quests

2019-11-14 Thread Alexander Popov
The commit a718978ed58a from July 2015 introduced the assertion which implies that the size of successful DMA transfers handled in ide_dma_cb() should be multiple of 512 (the size of a sector). But guest systems can initiate DMA transfers that don't fit this requirement. PoC for Linux that uses

Re: Convert VMDK to RAW

2019-11-14 Thread Max Reitz
On 14.11.19 17:12, janine.schnei...@fau.de wrote: > Ladies and Gentlemen, > >   > > I am a PhD student at the Friedrich-Alexander-University > Erlangen-Nuremberg in Bavaria, Germany and am currently working on a > forensic reconstruction tool. The tool can be used to analyze physical > and

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2019-11-14 Thread Max Reitz
On 14.11.19 18:15, Max Reitz wrote: > On 14.11.19 17:27, Christoph Hellwig wrote: >> On Fri, Nov 01, 2019 at 04:25:10PM +0100, Max Reitz wrote: >>> The XFS kernel driver has a bug that may cause data corruption for qcow2 >>> images as of qemu commit c8bb23cbdbe32f. We can work around it by >>>

Re: [PATCH RFC] virtio-pci: disable vring processing when bus-mastering is disabled

2019-11-14 Thread Michael Roth
Quoting Michael S. Tsirkin (2019-11-14 03:12:00) > On Thu, Nov 14, 2019 at 04:10:36AM -0500, Michael S. Tsirkin wrote: > > On Wed, Nov 13, 2019 at 07:07:36PM -0600, Michael Roth wrote: > > > Quoting Michael S. Tsirkin (2019-11-13 04:09:02) > > > > On Tue, Nov 12, 2019 at 11:43:01PM -0600, Michael

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2019-11-14 Thread Max Reitz
On 14.11.19 17:27, Christoph Hellwig wrote: > On Fri, Nov 01, 2019 at 04:25:10PM +0100, Max Reitz wrote: >> The XFS kernel driver has a bug that may cause data corruption for qcow2 >> images as of qemu commit c8bb23cbdbe32f. We can work around it by >> treating post-EOF fallocates as serializing

Re: [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests

2019-11-14 Thread Pierre Morel
On 2019-11-14 13:33, Thomas Huth wrote: On 14/11/2019 11.38, Cornelia Huck wrote: On Wed, 13 Nov 2019 20:02:33 +0100 Pierre Morel wrote: Minor nit for $SUBJECT: this isn't a kvm-unit-tests patch, that's just one consumer :) The PONG device accept two commands: PONG_READ and PONG_WRITE

Convert VMDK to RAW

2019-11-14 Thread janine.schneider
Ladies and Gentlemen, I am a PhD student at the Friedrich-Alexander-University Erlangen-Nuremberg in Bavaria, Germany and am currently working on a forensic reconstruction tool. The tool can be used to analyze physical and virtual hard disks and to reconstruct files. I would now like to extend

Re: [PATCH v1] s390x: kvm-unit-tests: a PONG device for Sub Channels tests

2019-11-14 Thread Pierre Morel
On 2019-11-14 11:38, Cornelia Huck wrote: On Wed, 13 Nov 2019 20:02:33 +0100 Pierre Morel wrote: Minor nit for $SUBJECT: this isn't a kvm-unit-tests patch, that's just one consumer :) yes, right. The PONG device accept two commands: PONG_READ and PONG_WRITE which allow to read from

Re: [RFC PATCH v2 20/26] qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2()

2019-11-14 Thread Alberto Garcia
On Tue 05 Nov 2019 12:43:16 PM CET, Max Reitz wrote: > Speaking of handle_copied(); both elements of Qcow2COWRegion are of > type unsigned. handle_copied() doesn’t look like it takes any > precautions to limit the range to even UINT_MAX (and it should > probably limit it to INT_MAX). Or rather,

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2019-11-14 Thread Christoph Hellwig
On Fri, Nov 01, 2019 at 04:25:10PM +0100, Max Reitz wrote: > The XFS kernel driver has a bug that may cause data corruption for qcow2 > images as of qemu commit c8bb23cbdbe32f. We can work around it by > treating post-EOF fallocates as serializing up until infinity (INT64_MAX > in practice).

Re: [RFC PATCH v2 16/26] qcow2: Add subcluster support to discard_in_l2_slice()

2019-11-14 Thread Max Reitz
On 14.11.19 16:33, Alberto Garcia wrote: > On Mon 04 Nov 2019 04:07:35 PM CET, Max Reitz wrote: >>> /* First remove L2 entries */ >>> qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); >>> -if (!full_discard && s->qcow_version >= 3) { >>> +if

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Peter Maydell
On Fri, 25 Oct 2019 at 20:15, Keith Packard wrote: > There seems to be convergence on a pretty simple interface which uses > ebreak surrounded by a couple of specific no-ops: > > slli x0, x0, 0x1f > ebreak > srai x0, x0, 0x7 > > There are implementations in rust and openocd, and

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-14 Thread Markus Armbruster
Less than thorough review, because I expect the necessary rebase will require a bit of rewriting here and there. Max Reitz writes: > With this change, it is possible to give default values for struct > members, as follows: > > What you had to do so far: > > # @member: Some description,

Re: [RFC 0/4] POC: Generating realistic block errors

2019-11-14 Thread Tony Asleson
On 9/20/19 12:28 PM, Tony Asleson wrote: > On 9/20/19 4:22 AM, Stefan Hajnoczi wrote: >> blkdebug is purely at the QEMU block layer level. It is not aware of >> storage controller-specific error information or features. If you want >> to inject NVMe- or SCSI-specific errors that make no sense in

Re: [PATCH] Semihost SYS_READC implementation (v4)

2019-11-14 Thread Alistair Francis
On Mon, Nov 11, 2019 at 6:51 AM Peter Maydell wrote: > > On Tue, 5 Nov 2019 at 05:10, Keith Packard wrote: > > > > Peter Maydell writes: > > > > > I'm going to push for somebody actually writing out a > > > document and putting it somewhere that we can point to > > > and say "that's the

Re: [RFC PATCH v2 18/26] qcow2: Add subcluster support to expand_zero_clusters_in_l1()

2019-11-14 Thread Alberto Garcia
On Tue 05 Nov 2019 12:05:02 PM CET, Max Reitz wrote: >> @@ -2102,6 +2103,7 @@ static int expand_zero_clusters_in_l1(BlockDriverState >> *bs, uint64_t *l1_table, >> } else { >> set_l2_entry(s, l2_slice, j, offset); >> } >> +

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-11-14 Thread Denis Plotnikov
On 13.11.2019 16:18, Michael S. Tsirkin wrote: > On Wed, Nov 13, 2019 at 12:38:48PM +, Denis Plotnikov wrote: >> >> On 06.11.2019 15:03, Michael S. Tsirkin wrote: >>> On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: On 10/24/19 12:28 AM, Michael S. Tsirkin wrote: > On

Re: [RFC PATCH v2 16/26] qcow2: Add subcluster support to discard_in_l2_slice()

2019-11-14 Thread Alberto Garcia
On Mon 04 Nov 2019 04:07:35 PM CET, Max Reitz wrote: >> /* First remove L2 entries */ >> qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); >> -if (!full_discard && s->qcow_version >= 3) { >> +if (has_subclusters(s)) { >> +set_l2_entry(s,

Re: [RFC PATCH v2 15/26] qcow2: Add subcluster support to zero_in_l2_slice()

2019-11-14 Thread Alberto Garcia
On Mon 04 Nov 2019 04:10:58 PM CET, Max Reitz wrote: >>> qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice); >>> if (cluster_type == QCOW2_CLUSTER_COMPRESSED || unmap) { >>> -set_l2_entry(s, l2_slice, l2_index + i, QCOW_OFLAG_ZERO); >>>

Re: [PATCH] MAINTAINERS: add more bitmap-related to Dirty Bitmaps section

2019-11-14 Thread Eric Blake
On 10/26/19 11:56 AM, Vladimir Sementsov-Ogievskiy wrote: Let's add bitmaps persistence qcow2 feature and postcopy bitmaps migration to Dirty Bitmaps section. Signed-off-by: Vladimir Sementsov-Ogievskiy --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) I see no reason why this

Braille device (chardev/baum.c) is unable to detect the TTY correctly and does not act on graphic console connect/disconnect

2019-11-14 Thread Teemu Kuusisto
Hello, As a blind developer I would be very happy to use QEMU's baum chardev for a braille display. Unfortunately, this device fails to detect the tty in which the spice client is running. I would like to improve this device but I don't yet know how to achieve a better solution. The current

Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

2019-11-14 Thread chen huacai
Hi, all, On Thu, Nov 14, 2019 at 8:34 PM Aleksandar Markovic wrote: > > Hi, Philippe, > > > From: Philippe Mathieu-Daudé > > > > Hi Aleksandar, > > > > On 11/13/19 2:47 PM, Aleksandar Markovic wrote: > > > From: Aleksandar Markovic > > > > > > Change the maintainership for Fulong 2E board to

[PATCH v2 for 5.0 5/6] linux-user: Add support for get/set RTC PLL correction using ioctls

2019-11-14 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_PLL_GET - Get PLL correction Read the PLL correction for RTCs that support PLL. The PLL correction is returned in the following structure: struct rtc_pll_info { int pll_ctrl;/* placeholder for

[PATCH v2 for 5.0 1/6] linux-user: Add support for enable/disable RTC features using ioctls

2019-11-14 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_AIE_ON, RTC_AIE_OFF - Alarm interrupt enable on/off Enable or disable the alarm interrupt, for RTCs that support alarms. The third ioctl's argument is ignored. RTC_UIE_ON, RTC_UIE_OFF - Update interrupt enable on/off

[PATCH v2 for 5.0 6/6] linux-user: Add support for read/clear RTC voltage low detector using ioctls

2019-11-14 Thread Filip Bozuta
RTC_VL_READ - Read voltage low detection information Read the voltage low for RTCs that support voltage low. The third ioctl's' argument points to an int in which the voltage low is returned. RTC_VL_CLR - Clear voltage low information Clear the information about voltage low for

[PATCH v2 for 5.0 2/6] linux-user: Add support for read/set RTC time and alarm using ioctls

2019-11-14 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_RD_TIME - Read RTC time Returns this RTC's time in the following structure: struct rtc_time { int tm_sec; int tm_min; int tm_hour; int tm_mday; int tm_mon;

[PATCH v2 for 5.0 0/6] linux-user: Add support for real time clock ioctls

2019-11-14 Thread Filip Bozuta
Add ioctls for all RTC features that are currently supported in linux kernel. This series covers following iocts: * RTC_AIE_ON * RTC_AIE_OFF * RTC_UIE_ON * RTC_UIE_OFF * RTC_PIE_ON * RTC_PIE_OFF * RTC_WIE_ON * RTC_WIE_OFF * RTC_ALM_SET * RTC_ALM_READ *

[PATCH v2 for 5.0 3/6] linux-user: Add support for read/set RTC periodic interrupt and epoch using ioctls

2019-11-14 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_IRQP_READ, RTC_IRQP_SET - Read/Set IRQ rate Read and set the frequency for periodic interrupts, for RTCs that support periodic interrupts. The periodic interrupt must be separately enabled or disabled using the

[PATCH v2 for 5.0 4/6] linux-user: Add support for get/set RTC wakeup alarm using ioctls

2019-11-14 Thread Filip Bozuta
This patch implements functionalities of following ioctls: RTC_WKALM_SET, RTC_WKALM_GET - Get/Set wakeup alarm Some RTCs support a more powerful alarm interface, using these ioctls to read or write the RTC's alarm time (respectively) with this structure: struct rtc_wkalrm {

Re: [PATCH v5] iotests: Test NBD client reconnection

2019-11-14 Thread Eric Blake
On 11/11/19 9:39 PM, Andrey Shinkevich wrote: The test for an NBD client. The NBD server is disconnected after the client write request. The NBD client should reconnect and complete the write operation. Suggested-by: Denis V. Lunev Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by:

Re: [PATCH v5 00/20] Add virtual device fuzzing support

2019-11-14 Thread Alexander Bulekov
On 11/14/19 5:55 AM, Darren Kenny wrote: Hi Alexander, A quick comment on the fact that you omitted any Reviewed-by's that you have received so far. Was that intentional? No - I'll find a way to add them. sorry about that -Alex Thanks, Darren. On Wed, Nov 13, 2019 at 10:50:41PM +,

  1   2   >