Re: How to extend QEMU's vhost-user tests after implementing vhost-user-blk device backend

2020-01-03 Thread Coiby Xu
Thank you for the advice! I've skipped test cases regarding resizing the disk. The remaining tests are "indirect" and "basic". vhost-user-blk device has now passed the "basic" test (/x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/vhost-user-blk-pci/vhost-user-blk/vhost-user-blk-tests/basic) as virtio-

Re: [PATCH v10 Kernel 4/5] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2020-01-03 Thread Yan Zhao
On Sat, Jan 04, 2020 at 03:44:34AM +0800, Dr. David Alan Gilbert wrote: > * Yan Zhao (yan.y.z...@intel.com) wrote: > > On Fri, Dec 20, 2019 at 12:21:45AM +0800, Kirti Wankhede wrote: > > > > > > > > > On 12/19/2019 6:27 AM, Yan Zhao wrote: > > > > On Thu, Dec 19, 2019 at 04:05:52AM +0800, Dr. Dav

Re: [PATCH v3 5/7] gpio: Add GPIO Aggregator/Repeater driver

2020-01-03 Thread Linus Walleij
Sorry for slowness... christmas. On Thu, Dec 12, 2019 at 4:24 PM Geert Uytterhoeven wrote: > On Thu, Dec 12, 2019 at 3:34 PM Linus Walleij > wrote: > > > + This can serve the following purposes: > > > + 1. Assign a collection of GPIOs to a user, or export them to a > > > +

Re: [PATCH v3 6/7] docs: gpio: Add GPIO Aggregator/Repeater documentation

2020-01-03 Thread Linus Walleij
On Thu, Dec 12, 2019 at 3:48 PM Geert Uytterhoeven wrote: > On Thu, Dec 12, 2019 at 3:42 PM Linus Walleij > wrote: > > On Wed, Nov 27, 2019 at 9:43 AM Geert Uytterhoeven > > wrote: > > > +The GPIO Aggregator allows access control for individual GPIOs, by > > > aggregating > > > +them into a ne

Re: [PATCH v3 4/4] RISC-V: add vector extension configure instruction

2020-01-03 Thread Richard Henderson
On 1/3/20 2:33 PM, LIU Zhiwei wrote: > vsetvl and vsetvli are two configure instructions for vl, vtype. TB flags > should update after configure instructions. The (ill, lmul, sew ) of vtype > and the bit of (VSTART == 0 && VL == VLMAX) will be placed within tb_flags. > > Signed-off-by: LIU Zhiwei

Re: [PATCH v3 3/4] RISC-V: support vector extension csr

2020-01-03 Thread Richard Henderson
On 1/3/20 2:33 PM, LIU Zhiwei wrote: > Until v0.7.1 specification, vector status is still not defined for > mstatus. Using "until" imples that v0.7.1 *does* define the vector status. Better said as "The v0.7.1 specification does not define vector status within mstatus. A future revision will def

Re: [PATCH v3 2/4] RISC-V: configure and turn on vector extension from command line

2020-01-03 Thread Richard Henderson
On 1/3/20 2:33 PM, LIU Zhiwei wrote: > +if (cpu->cfg.ext_v) { > +target_misa |= RVV; > +if (!is_power_of_2(cpu->cfg.vlen)) { > +error_setg(errp, > + "Vector extension VLEN must be power of 2"); > +return; > +

Re: [PATCH v3 1/4] RISC-V: add vector extension field in CPURISCVState

2020-01-03 Thread Richard Henderson
On 1/3/20 2:33 PM, LIU Zhiwei wrote: > The 32 vector registers will be viewed as a continuous memory block. > It avoids the convension between element index and (regno,offset). > Thus elements can be directly accessed by offset from the first vector > base address. > > Signed-off-by: LIU Zhiwei >

[PATCH v3 01/12] linux-user: Fix some constants in termbits.h

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic Some constants were defined in terms of host, instead of target, as they should be. Some additional trivial changes in this patch were forced by checkpatch.pl. Reviewed-by: Max Filippov Signed-off-by: Aleksandar Markovic --- linux-user/aarch64/termbits.h| 4 +-

[PATCH v3 07/12] linux-user: Add support for FD ioctls

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls are commands for controlling error reporting of a floppy drive. FDSETEMSGTRESH's third agrument is a pointer to the structure: struct floppy_max_errors { unsigned int abort, /* number of errors to be

[PATCH v3 12/12] linux-user: Add support for KCOV_INIT_TRACE ioctl

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic KCOV_INIT_TRACE ioctl plays the role in kernel coverage tracing. This ioctl's third argument is of type 'unsigned long', and the implementation in QEMU is straightforward. Signed-off-by: Aleksandar Markovic --- linux-user/ioctls.h | 1 + linux-user/syscall_defs.

[PATCH v3 02/12] linux-user: mips: Update syscall numbers to kernel 5.5 rc3 level

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic Update mips syscall numbers based on Linux kernel tag v5.5-rc3 (commit 46cf053e). Signed-off-by: Aleksandar Markovic --- linux-user/mips/cpu_loop.c | 69 ++ linux-user/mips/syscall_nr.h | 45 +++ li

[PATCH v3 06/12] linux-user: Add support for FS_IOC_FSXATTR ioctls

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic These ioctls were relatively recently introduced, so the "#ifdef" guards are used in this implementation. Signed-off-by: Aleksandar Markovic --- linux-user/ioctls.h | 7 +++ linux-user/syscall_defs.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/lin

[PATCH v3 08/12] linux-user: Add support for FDFMT ioctls

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic FDFMTBEG, FDFMTTRK, and FDFMTEND ioctls provide means for controlling formatting of a floppy drive. FDFMTTRK's third agrument is a pointer to the structure: struct format_descr { unsigned int device,head,track; }; defined in Linux kernel header . Since all fields

[PATCH v3 10/12] configure: Detect kcov support and introduce CONFIG_KCOV

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic kcov is kernel code coverage tracing tool. It requires kernel 4.4+ compiled with certain kernel options. Its interface consists of three ioctls. This patch checks if kcov support is present on build machine, and stores the result in variable CONFIG_KCOV, meant to be use

[PATCH v3 05/12] linux-user: Add support for FS_IOC32_VERSION ioctls

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic These FS_IOC32_VERSION ioctls are identical to FS_IOC_VERSION ioctls, but without the anomaly of their number defined as if their third argument is of type long, while it is treated internally in kernel as is of type int. Signed-off-by: Aleksandar Markovic --- linux-u

[PATCH v3 03/12] linux-user: Add support for FS_IOC_VERSION ioctls

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic A very specific thing for these two ioctls is that their code implies that their third argument is of type 'long', but the kernel uses that argument as if it is of type 'int'. This anomaly is recognized also in commit 6080723 (linux-user: Implement FS_IOC_GETFLAGS and FS

[PATCH v3 09/12] linux-user: Add support for FDGETFDCSTAT ioctl

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic FDGETFDCSTAT's third agrument is a pointer to the structure: struct floppy_fdc_state { int spec1; int spec2; int dtr; unsigned char version; unsigned char dor; unsigned long address; unsigned int rawcmd:2; unsigned int reset:1; unsign

[PATCH v3 11/12] linux-user: Add support for KCOV_ ioctls

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic KCOV_ENABLE and KCOV_DISABLE play the role in kernel coverage tracing. These ioctls do not use the third argument of ioctl() system call and are straightforward to implement in QEMU. Signed-off-by: Aleksandar Markovic --- linux-user/ioctls.h | 5 + linux-use

[PATCH v3 04/12] linux-user: Add support for FS_IOC32_FLAGS ioctls

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic These FS_IOC32_FLAGS ioctls are identical to FS_IOC_FLAGS ioctls, but without the anomaly of their number defined as if their third argument is of type long, while it is treated internally in kernel as is of type int. Signed-off-by: Aleksandar Markovic --- linux-user/

[PATCH v3 00/12] linux-user: Misc patches for 5.0

2020-01-03 Thread Aleksandar Markovic
From: Aleksandar Markovic This series is a collection of patches I recently accumulated. v2->v3: - added support for seven floppy-drive-related ioctls - added support for three kcov-related ioctls v1->v2: - fixed a constant in xtensa's termbits.h that was missed in v1 - redid syscall

Re: [PATCH v3 09/29] plugins: Include trace/mem.h in api.c

2020-01-03 Thread Richard Henderson
On 1/3/20 5:22 PM, Philippe Mathieu-Daudé wrote: > Hi Richard, > > On 12/29/19 12:11 AM, Richard Henderson wrote: >> Code movement in an upcoming patch will show that this file >> was implicitly depending on trace/mem.h being included beforehand. > > Ah, it uses the TRACE_MEM_* macros from "trace

Re: [PATCH v3 0/3] Update capstone module

2020-01-03 Thread Richard Henderson
On 1/3/20 6:16 PM, Philippe Mathieu-Daudé wrote: >   -0x0010e8f6:  lpswe 160(%r15) >   +0x0010e8f6:   .byte    0xb2, 0xb2, 0xf0, 0xa0 > > Is it possible to fallback to the older disassembler on a per-instruction > basis > if Capstone doesn't know about an instruction? Not as written. But I

Re: [PATCH 0/3] capstone: update to next

2020-01-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200103212500.14384-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/3] capstone: update to next Type: series Message-id: 20200103212500.14384-1-richard.hen

[PATCH 2/3] capstone: Enable disassembly for s390x

2020-01-03 Thread Richard Henderson
Enable s390x, aka SYSZ, in the git submodule build. Set the capstone parameters for both s390x host and guest. Signed-off-by: Richard Henderson --- Makefile | 1 + disas.c| 3 +++ target/s390x/cpu.c | 4 3 files changed, 8 insertions(+) diff --git a/Makefile b/Makefil

[PATCH 0/3] capstone: update to next

2020-01-03 Thread Richard Henderson
I keep hoping that there will be a new official capstone release, but I've now waited all of 2019, so I'm going to suggest updating to the head of the development branch. That, at least, has significant benefits wrt read-only data: writable data down from 1.5MB to 48 bytes. r~ Richard Henderso

[PATCH 3/3] capstone: Add skipdata hook for s390x

2020-01-03 Thread Richard Henderson
Capstone assumes any s390x unknown instruction is 2 bytes. Instead, use the ilen field in the first two bits of the instruction to stay in sync with the insn stream. Reviewed-by: Thomas Huth Signed-off-by: Richard Henderson --- disas.c | 37 + 1 file changed,

[PATCH 1/3] capstone: Update to next

2020-01-03 Thread Richard Henderson
Update to aaffb38c44fa. Choose this over the "current" 4.0.1 tag because next now includes the s390x z13 vector opcodes, and also the insn tables are now read-only. Signed-off-by: Richard Henderson --- Makefile | 1 + capstone | 2 +- configure | 2 +- 3 files changed, 3 insertions(+), 2 dele

Re: [PATCH] virtio: add the queue number check

2020-01-03 Thread Paolo Bonzini
Il ven 3 gen 2020, 16:08 Yang Zhong ha scritto: > I also tried virtio-blk device like below: > https://patchwork.kernel.org/cover/10873193/ > > The virtio-blk can work with this changes, but vhost-user-blk device > failed with this kernel patch. > > in vhost_virtqueue_start() function,

Re: [PATCH v10 Kernel 4/5] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2020-01-03 Thread Dr. David Alan Gilbert
* Yan Zhao (yan.y.z...@intel.com) wrote: > On Fri, Dec 20, 2019 at 12:21:45AM +0800, Kirti Wankhede wrote: > > > > > > On 12/19/2019 6:27 AM, Yan Zhao wrote: > > > On Thu, Dec 19, 2019 at 04:05:52AM +0800, Dr. David Alan Gilbert wrote: > > >> * Yan Zhao (yan.y.z...@intel.com) wrote: > > >>> On Tu

Re: [PATCH 0/2] Speed up QMP stream reading

2020-01-03 Thread Peter Xu
On Fri, Jan 03, 2020 at 02:06:27PM -0500, Peter Xu wrote: > On Fri, Jan 03, 2020 at 11:07:31AM +, Dr. David Alan Gilbert wrote: > > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: > > > Hi! > > > > > > 20.12.2019, 19:09, "Markus Armbruster" : > > > > Yury Kotov writes: > > > > > > > >> Hi, >

Re: [PATCH] riscv: Set xPIE to 1 after xRET

2020-01-03 Thread Alistair Francis
On Fri, Jan 3, 2020 at 12:01 AM Yiting Wang wrote: > > When executing an xRET instruction, supposing xPP holds the > value y, xIE is set to xPIE; the privilege mode is changed to y; > xPIE is set to 1. But QEMU sets xPIE to 0 incorrectly. > > Signed-off-by: Yiting Wang Reviewed-by: Alistair Fran

Re: [PATCH 0/2] Speed up QMP stream reading

2020-01-03 Thread Peter Xu
On Fri, Jan 03, 2020 at 11:07:31AM +, Dr. David Alan Gilbert wrote: > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: > > Hi! > > > > 20.12.2019, 19:09, "Markus Armbruster" : > > > Yury Kotov writes: > > > > > >> Hi, > > >> > > >> This series is continuation of another one: > > >> [PATCH]

Re: [PULL 0/3] Block patches

2020-01-03 Thread Peter Maydell
On Fri, 20 Dec 2019 at 10:25, Stefan Hajnoczi wrote: > > The following changes since commit aceeaa69d28e6f08a24395d0aa6915b687d0a681: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-12-17' into staging (2019-12-17 > 15:55:20 +) > > are available in the Git re

Re: [PATCH v2 01/10] migration: Increase default number of multifd channels to 16

2020-01-03 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Dec 18, 2019 at 03:01:10AM +0100, Juan Quintela wrote: >> We can scale much better with 16, so we can scale to higher numbers. > > What was the test scenario showing such scaling ? On my test hardware, with 2 channels we can saturate around 8Gigabit max, more t

Re: [PATCH v2 07/10] migration: Make no compression operations into its own structure

2020-01-03 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It will be used later. > > Signed-off-by: Juan Quintela > > --- > Move setup of ->ops helper to proper place (wei) > Rename s/none/nocomp/ (dave) > Introduce MULTIFD_FLAG_NOCOMP > --- > migration/migration.c | 9 ++ > migration/migration.h | 1

Re: [kvm-unit-tests PATCH 04/10] arm: pmu: Check Required Event Support

2020-01-03 Thread Andre Przywara
On Mon, 16 Dec 2019 21:47:51 +0100 Eric Auger wrote: Hi Eric, > If event counters are implemented check the common events > required by the PMUv3 are implemented. > > Some are unconditionally required (SW_INCR, CPU_CYCLES, > either INST_RETIRED or INST_SPEC). Some others only are > required if

Re: [kvm-unit-tests PATCH 03/10] arm: pmu: Add a pmu struct

2020-01-03 Thread Andre Przywara
On Mon, 16 Dec 2019 21:47:50 +0100 Eric Auger wrote: > This struct aims at storing information potentially used by > all tests such as the pmu version, the read-only part of the > PMCR, the number of implemented event counters, ... > > Signed-off-by: Eric Auger Reviewed-by: Andre Przywara Ch

Re: [kvm-unit-tests PATCH 02/10] arm: pmu: Let pmu tests take a sub-test parameter

2020-01-03 Thread Andre Przywara
On Mon, 16 Dec 2019 21:47:49 +0100 Eric Auger wrote: > As we intend to introduce more PMU tests, let's add > a sub-test parameter that will allow to categorize > them. Existing tests are in the cycle-counter category. > > Signed-off-by: Eric Auger Reviewed-by: Andre Przywara Cheers, Andre >

Re: [PATCH v2 06/10] migration: Add multifd-compress parameter

2020-01-03 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > > --- > Rename it to NONE > Fix typos (dave) > We don't need to chek values returned by visit_type_MultifdCompress (markus) > Fix yet more typos (wei) > --- > hw/core/qdev-properties.c| 13 + > include/

Re: [PATCH v2 01/10] migration: Increase default number of multifd channels to 16

2020-01-03 Thread Daniel P . Berrangé
On Wed, Dec 18, 2019 at 03:01:10AM +0100, Juan Quintela wrote: > We can scale much better with 16, so we can scale to higher numbers. > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/migration.c b/m

Re: [PATCH v2 01/10] migration: Increase default number of multifd channels to 16

2020-01-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Jan 03, 2020 at 05:01:14PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Wed, Dec 18, 2019 at 03:01:10AM +0100, Juan Quintela wrote: > > > > We can scale much better with 16, so we can

Re: [PATCH v2 05/10] migration: Make multifd_load_setup() get an Error parameter

2020-01-03 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We need to change the full chain to pass the Error parameter. > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 10 +- > migration/migration.h | 2 +- > migration/ram.c | 2 +- > migration/ram.h | 2 +- > migrat

Re: [PULL 0/1] Seabios 20191220 patches

2020-01-03 Thread Peter Maydell
On Fri, 20 Dec 2019 at 06:10, Gerd Hoffmann wrote: > > The following changes since commit aceeaa69d28e6f08a24395d0aa6915b687d0a681: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-12-17' into staging (2019-12-17 > 15:55:20 +) > > are available in the Git repo

Re: [PATCH v2 01/10] migration: Increase default number of multifd channels to 16

2020-01-03 Thread Daniel P . Berrangé
On Fri, Jan 03, 2020 at 05:01:14PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Wed, Dec 18, 2019 at 03:01:10AM +0100, Juan Quintela wrote: > > > We can scale much better with 16, so we can scale to higher numbers. > > > > What was the test scenar

Re: [PATCH v2 01/10] migration: Increase default number of multifd channels to 16

2020-01-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Dec 18, 2019 at 03:01:10AM +0100, Juan Quintela wrote: > > We can scale much better with 16, so we can scale to higher numbers. > > What was the test scenario showing such scaling ? > > In the real world I'm sceptical that virt hosts wil

Re: [PATCH v2 01/10] migration: Increase default number of multifd channels to 16

2020-01-03 Thread Daniel P . Berrangé
On Wed, Dec 18, 2019 at 03:01:10AM +0100, Juan Quintela wrote: > We can scale much better with 16, so we can scale to higher numbers. What was the test scenario showing such scaling ? In the real world I'm sceptical that virt hosts will have 16 otherwise idle CPU cores available that are permissi

Re: [PATCH v2 03/10] migration-test: introduce functions to handle string parameters

2020-01-03 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert (I'm surprised we don't need to quote the %s's in qtest_qmp, but it seems that we never do it in any other of the qtest_qmp calls that I can see when we use %s. Dave > --- > tests/

Re: [PATCH v2 01/10] migration: Increase default number of multifd channels to 16

2020-01-03 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We can scale much better with 16, so we can scale to higher numbers. > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/migration.c b/migration/migration

Re: [PATCH v6 13/21] fuzz: add configure flag --enable-fuzzing

2020-01-03 Thread Philippe Mathieu-Daudé
On 11/29/19 10:34 PM, Oleinik, Alexander wrote: Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi --- configure | 39 +++ 1 file changed, 39 insertions(+) diff --git a/configure b/configure index 6099be1d84..5fb2494a8e 100755 --- a/configure +

Re: [PATCH v2 04/10] migration: Make multifd_save_setup() get an Error parameter

2020-01-03 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > migration/migration.c | 2 +- > migration/ram.c | 2 +- > migration/ram.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > in

Re: [PATCH v6 11/21] libqtest: make bufwrite rely on the TransportOps

2020-01-03 Thread Philippe Mathieu-Daudé
On 11/29/19 10:34 PM, Oleinik, Alexander wrote: When using qtest "in-process" communication, qtest_sendf directly calls a function in the server (qtest.c). Previously, bufwrite used socket_send, which bypasses the TransportOps enabling the call into qtest.c. This change replaces the socket_send c

Re: [PATCH v2 2/3] tpm-ppi: page-align PPI RAM

2020-01-03 Thread Stefan Berger
On 1/3/20 5:02 AM, Dr. David Alan Gilbert wrote: * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: post-copy migration fails on destination with error such as: 2019-12-26T10:22:44.714644Z qemu-kvm: ram_block_discard_range: Unaligned start address: 0x559d2afae9a0 Ah good, we got a sane er

Re: [PATCH v6 10/21] libqos: move useful qos-test funcs to qos_external

2020-01-03 Thread Philippe Mathieu-Daudé
On 11/29/19 10:34 PM, Oleinik, Alexander wrote: The moved functions are not specific to qos-test and might be useful elsewhere. For example the virtual-device fuzzer makes use of them for qos-assisted fuzz-targets. Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi --- tests/Makef

Re: [PATCH v2 1/3] misc: use QEMU_IS_ALIGNED

2020-01-03 Thread Stefan Berger
On 1/3/20 2:43 AM, Philippe Mathieu-Daudé wrote: On 1/3/20 8:39 AM, Marc-André Lureau wrote: Signed-off-by: Marc-André Lureau ---   exec.c    | 4 ++--   roms/SLOF | 2 +-   2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index d4b769d0d4..1feda49ca1 100644 --- a/ex

Re: [PATCH v6 09/21] libqos: split qos-test and libqos makefile vars

2020-01-03 Thread Philippe Mathieu-Daudé
On 11/29/19 10:34 PM, Oleinik, Alexander wrote: Most qos-related objects were specified in the qos-test-obj-y variable. qos-test-obj-y also included qos-test.o which defines a main(). This made it difficult to repurpose qos-test-obj-y to link anything beside tests/qos-test against libqos. This ch

Re: [PATCH v6 06/21] module: check module wasn't already initialized

2020-01-03 Thread Philippe Mathieu-Daudé
On 11/29/19 10:34 PM, Oleinik, Alexander wrote: The virtual-device fuzzer must initialize QOM, prior to running vl:qemu_init, so that it can use the qos_graph to identify the arguments required to initialize a guest for libqos-assisted fuzzing. This change prevents errors when vl:qemu_init tries

Re: [PATCH v6 05/21] libqtest: Add a layer of abstraciton to send/recv

2020-01-03 Thread Philippe Mathieu-Daudé
Hi Aleksander, Typo in patch subject: "abstraction" On 11/29/19 10:34 PM, Oleinik, Alexander wrote: This makes it simple to swap the transport functions for qtest commands to and from the qtest client. For example, now it is possible to directly pass qtest commands to a server handler that exis

Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu - status update

2020-01-03 Thread Stefan Hajnoczi
On Thu, Jan 02, 2020 at 11:03:22AM +, Felipe Franciosi wrote: > > On Jan 2, 2020, at 10:42 AM, Stefan Hajnoczi wrote: > > On Fri, Dec 20, 2019 at 10:22:37AM +, Daniel P. Berrangé wrote: > >> On Fri, Dec 20, 2019 at 09:47:12AM +, Stefan Hajnoczi wrote: > >>> On Thu, Dec 19, 2019 at 12:5

Re: [PULL 0/2] Vga 20191220 patches

2020-01-03 Thread Peter Maydell
On Fri, 20 Dec 2019 at 06:08, Gerd Hoffmann wrote: > > The following changes since commit aceeaa69d28e6f08a24395d0aa6915b687d0a681: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-12-17' into staging (2019-12-17 > 15:55:20 +) > > are available in the Git repo

Re: [PATCH v7 4/6] tpm_spapr: Support suspend and resume

2020-01-03 Thread Stefan Berger
On 1/2/20 7:19 PM, David Gibson wrote: On Thu, Dec 19, 2019 at 09:06:03AM -0500, Stefan Berger wrote: Extend the tpm_spapr frontend with VM suspend and resume support. Signed-off-by: Stefan Berger --- hw/tpm/tpm_spapr.c | 67 - hw/tpm/trace-event

Re: [PATCH 025/104] virtiofsd: Add Makefile wiring for virtiofsd contrib

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:45PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Wire up the building of the virtiofsd in contrib. > > virtiofsd relies on Linux-specific system calls and seccomp. Anyone > wishing to port it to other host operating systems shoul

Re: [PATCH 024/104] virtiofsd: Keep track of replies

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:44PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Keep track of whether we sent a reply to a request; this is a bit > paranoid but it means: > a) We should always recycle an element even if there was an error > in the request

Re: [PATCH 023/104] virtiofsd: Send replies to messages

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:43PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Route fuse out messages back through the same queue elements > that had the command that triggered the request. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/f

Re: [PATCH 022/104] virtiofsd: Start reading commands from queue

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:42PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Pop queue elements off queues, copy the data from them and > pass that to fuse. > > Note: 'out' in a VuVirtqElement is from QEMU > 'in' in libfuse is into the daemon > >

Re: [PATCH 021/104] virtiofsd: Poll kick_fd for queue

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:41PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > In the queue thread poll the kick_fd we're passed. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_virtio.c | 40 ++- > 1 fi

Re: [PATCH v1 0/2] intel_iommu: two fixes to intel scalable vIOMMU

2020-01-03 Thread Peter Xu
On Fri, Jan 03, 2020 at 09:28:04PM +0800, Liu Yi L wrote: > These two fixes are found in vSVA implementation, and could be > upstreamed separately. Please feel free give your comments. Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH 020/104] virtiofsd: Start queue threads

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:40PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Start a thread for each queue when we get notified it's been started. > > Signed-off-by: Dr. David Alan Gilbert > fix by: > Signed-off-by: Jun Piao > Signed-off-by: Stefan Hajnocz

Re: [PATCH 019/104] virtiofsd: get/set features callbacks

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:39PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add the get/set features callbacks. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_virtio.c | 15 ++- > 1 file changed, 14 insertions(+), 1 del

Re: [PATCH 018/104] virtiofsd: Add main virtio loop

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:38PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Processes incoming requests on the vhost-user fd. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_virtio.c | 42 --- > 1 fil

Re: [PATCH 017/104] virtiofsd: Start wiring up vhost-user

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:37PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Listen on our unix socket for the connection from QEMU, when we get it > initialise vhost-user and dive into our own loop variant (currently > dummy). > > Signed-off-by: Dr. David A

Re: [PATCH 016/104] virtiofsd: Open vhost connection instead of mounting

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:36PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When run with vhost-user options we conect to the QEMU instead > via a socket. Start this off by creating the socket. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virt

Re: [PATCH 015/104] virtiofsd: add -o source=PATH to help output

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:35PM +, Dr. David Alan Gilbert (git) wrote: > From: Stefan Hajnoczi > > The -o source=PATH option will be used by most command-line invocations. > Let's document it! > > Signed-off-by: Stefan Hajnoczi > --- > tools/virtiofsd/passthrough_ll.c | 1 + > 1 file ch

Re: [PATCH 014/104] virtiofsd: Add options for virtio

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:34PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add options to specify parameters for virtio-fs paths, i.e. > >./virtiofsd -o vhost_user_socket=/tmp/vhostqemu > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiof

Re: [PATCH 013/104] virtiofsd: Make fsync work even if only inode is passed in

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:33PM +, Dr. David Alan Gilbert (git) wrote: > From: Vivek Goyal > > If caller has not sent file handle in request, then using inode, retrieve > the fd opened using O_PATH and use that to open file again and issue > fsync. This will be needed when dax_flush() call

Re: [PATCH] virtio: add the queue number check

2020-01-03 Thread Yang Zhong
On Mon, Dec 23, 2019 at 06:33:26PM +0100, Paolo Bonzini wrote: > On 23/12/19 15:25, Michael S. Tsirkin wrote: > > On Mon, Dec 23, 2019 at 12:02:18PM +0100, Paolo Bonzini wrote: > >> On 23/12/19 10:18, Yang Zhong wrote: > >>> In this time, the queue number in the front-end block driver is 2, but >

Re: [RFC v4 PATCH 00/49] Initial support of multi-process qemu - status update

2020-01-03 Thread Stefan Hajnoczi
On Thu, Jan 02, 2020 at 08:01:36AM -0800, Elena Ufimtseva wrote: > On Tue, Dec 17, 2019 at 04:33:16PM +, Stefan Hajnoczi wrote: > > On Mon, Dec 16, 2019 at 07:57:32PM +, Felipe Franciosi wrote: > > > > On 16 Dec 2019, at 20:47, Elena Ufimtseva > > > > wrote: > > > > On Fri, Dec 13, 2019

Re: [PATCH] target/i386: kvm: print info when the kernel doesn't support ioctl(KVM_CAP_GET_MSR_FEATURES)

2020-01-03 Thread Philippe Mathieu-Daudé
On 1/3/20 3:32 PM, Li Qiang wrote: The ioctl(KVM_CAP_GET_MSR_FEATURES) is quite new. In old platform that Can you refer to the kernel version? "is quite new (introduced in vX.Y)" doesn't support this ioctl will sometimes make the user confusion. For example, when we do nested virtualiztion us

Re: [PATCH 005/104] virtiofsd: Add passthrough_ll

2020-01-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Jan 03, 2020 at 12:15:35PM +, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Thu, Dec 12, 2019 at 04:37:25PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan

[PATCH] target/i386: kvm: print info when the kernel doesn't support ioctl(KVM_CAP_GET_MSR_FEATURES)

2020-01-03 Thread Li Qiang
The ioctl(KVM_CAP_GET_MSR_FEATURES) is quite new. In old platform that doesn't support this ioctl will sometimes make the user confusion. For example, when we do nested virtualiztion using host-passthrough model the VM will has quite different cpu feature with the host. Signed-off-by: Li Qiang --

Re: [PULL 00/30] Block layer patches

2020-01-03 Thread Peter Maydell
On Thu, 19 Dec 2019 at 17:24, Kevin Wolf wrote: > > The following changes since commit aceeaa69d28e6f08a24395d0aa6915b687d0a681: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-12-17' into staging (2019-12-17 > 15:55:20 +) > > are available in the Git reposit

Re: [PATCH] riscv: Set xPIE to 1 after xRET

2020-01-03 Thread Bin Meng
On Fri, Jan 3, 2020 at 4:03 PM Yiting Wang wrote: > > When executing an xRET instruction, supposing xPP holds the > value y, xIE is set to xPIE; the privilege mode is changed to y; > xPIE is set to 1. But QEMU sets xPIE to 0 incorrectly. > > Signed-off-by: Yiting Wang > --- > target/riscv/op_hel

[PATCH v1 1/2] intel_iommu: a fix to vtd_find_as_from_bus_num()

2020-01-03 Thread Liu Yi L
Ensure the return value of vtd_find_as_from_bus_num() is NULL by enforcing vtd_bus=NULL. This would help caller of vtd_find_as_from_bus_num() to decide if any further operation on the returned vtd_bus. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Yi Sun Signed-off-by: Liu Yi L Signed-off-by:

[PATCH v1 0/2] intel_iommu: two fixes to intel scalable vIOMMU

2020-01-03 Thread Liu Yi L
These two fixes are found in vSVA implementation, and could be upstreamed separately. Please feel free give your comments. Thanks, Yi Liu Liu Yi L (2): intel_iommu: a fix to vtd_find_as_from_bus_num() intel_iommu: add present bit check for pasid table entries hw/i386/intel_iommu.c

[PATCH v1 2/2] intel_iommu: add present bit check for pasid table entries

2020-01-03 Thread Liu Yi L
The present bit check for pasid entry (pe) and pasid directory entry (pdire) were missed in previous commits as fpd bit check doesn't require present bit as "Set". This patch adds the present bit check for callers which wants to get a valid pe/pdire. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc

Re: [PATCH 1/6] tests/boot_linux_console: Add initrd test for the CubieBoard

2020-01-03 Thread Wainer dos Santos Moschetta
On 12/31/19 9:41 AM, Philippe Mathieu-Daudé wrote: On 12/30/19 9:52 PM, Wainer dos Santos Moschetta wrote: On 12/30/19 9:09 AM, Philippe Mathieu-Daudé wrote: This test boots a Linux kernel on a CubieBoard and verify the serial output is working. The kernel image and DeviceTree blob are built

Re: [PATCH 00/86] refactor main RAM allocation to use hostmem backend

2020-01-03 Thread Philippe Mathieu-Daudé
On 1/3/20 2:06 PM, Igor Mammedov wrote: On Tue, 31 Dec 2019 16:58:10 +0100 Philippe Mathieu-Daudé wrote: Hi Igor, On 12/31/19 2:02 PM, Igor Mammedov wrote: Series removes ad hoc RAM allocation API (memory_region_allocate_system_memory) and consolidates it around hostmem backend. It allows to

Re: [PATCH 2/5] hda-codec: fix recording rate control

2020-01-03 Thread Gerd Hoffmann
On Thu, Dec 19, 2019 at 09:04:16PM +0100, Volker Rümelin wrote: > Apply previous commit to hda_audio_input_cb for the same > reasons. This mail is multipart text+html and "git am" can't process it (the others are text only). Can you please resend the patches, preferably with "git send-email" to a

Re: [PATCH 00/86] refactor main RAM allocation to use hostmem backend

2020-01-03 Thread Igor Mammedov
On Tue, 31 Dec 2019 16:58:10 +0100 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 12/31/19 2:02 PM, Igor Mammedov wrote: > > Series removes ad hoc RAM allocation API > > (memory_region_allocate_system_memory) > > and consolidates it around hostmem backend. It allows to > > * resolve conflict

Re: [PATCH] target/arm: Set ISSIs16Bit in make_issinfo

2020-01-03 Thread Peter Maydell
On Thu, 19 Dec 2019 at 18:56, Richard Henderson wrote: > > During the conversion to decodetree, the setting of > ISSIs16Bit got lost. This causes the guest os to > incorrectly adjust trapping memory operations. > > Fixes: 46beb58efbb8a2a32 > Cc: qemu-sta...@nongnu.org > Reported-by: Jeff Kubascik

Re: [PATCH 005/104] virtiofsd: Add passthrough_ll

2020-01-03 Thread Daniel P . Berrangé
On Fri, Jan 03, 2020 at 12:15:35PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Thu, Dec 12, 2019 at 04:37:25PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > passthrough_ll is one of the examples

Re: [PATCH 012/104] virtiofsd: Trim out compatibility code

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:32PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > virtiofsd only supports major=7, minor>=31; trim out a lot of > old compatibility code. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_lowlevel.c | 330 +++

Re: [PATCH 011/104] virtiofsd: Fix common header and define for QEMU builds

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:31PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > All of the fuse files include config.h and define GNU_SOURCE > where we don't have either under our build - remove them. There's a bunch of other random changes in this patch - were

Re: [PATCH 010/104] virtiofsd: Fix fuse_daemonize ignored return values

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:30PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > QEMU's compiler enables warnings/errors for ignored values > and the (void) trick used in the fuse code isn't enough. > Turn all the return values into a return value on the function

Re: [PATCH 005/104] virtiofsd: Add passthrough_ll

2020-01-03 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Dec 12, 2019 at 04:37:25PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > passthrough_ll is one of the examples in the upstream fuse project > > and is the main part of our daemon here. It passes t

Re: [PATCH 009/104] virtiofsd: remove unused notify reply support

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:29PM +, Dr. David Alan Gilbert (git) wrote: > From: Stefan Hajnoczi > > Notify reply support is unused by virtiofsd. The code would need to be > updated to validate input buffer sizes. Remove this unused code since > changes to it are untestable. > > Signed-of

Re: [PATCH 008/104] virtiofsd: remove mountpoint dummy argument

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:28PM +, Dr. David Alan Gilbert (git) wrote: > From: Stefan Hajnoczi > > Classic FUSE file system daemons take a mountpoint argument but > virtiofsd exposes a vhost-user UNIX domain socket instead. The > mountpoint argument is not used by virtiofsd but the user i

Re: [PULL v2 16/16] qga: fence guest-set-time if hwclock not available

2020-01-03 Thread Peter Maydell
On Sat, 14 Dec 2019 at 09:46, Cornelia Huck wrote: > > The Posix implementation of guest-set-time invokes hwclock to > set/retrieve the time to/from the hardware clock. If hwclock > is not available, the user is currently informed that "hwclock > failed to set hardware clock to system time", which

Re: [PATCH 007/104] virtiofsd: Format imported files to qemu style

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:27PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Mostly using a set like: > > indent -nut -i 4 -nlp -br -cs -ce --no-space-after-function-call-names file > clang-format -style=file -i -- file > clang-tidy -fix-errors -checks=reada

Re: [PATCH 006/104] virtiofsd: Trim down imported files

2020-01-03 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:37:26PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > There's a lot of the original fuse code we don't need; trim them down. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse.h| 8 - > tools/vir

  1   2   >