[Bug 1856837] Re: qemu 4.2.0 arm segmentation fault with gcc 9.2

2020-01-05 Thread Fabian Godehardt
Sorry for the delay. I added the sysroot, the binary and the files causing the segfault. Please let me know if there is something missing. I used the following commands to let it run: export LD_LIBRARY_PATH=/opt/qemu-test/test1/lib /opt/qemu-test/test1/bin/qemu-arm "/opt/qemu-test/test1/files/mk

Re: [PATCH 2/2] ppc/pnv: Use the CPU topology to compute the default number of chips

2020-01-05 Thread Cédric Le Goater
On 12/21/19 11:28 AM, Greg Kurz wrote: > On Sat, 21 Dec 2019 11:39:06 +1100 > David Gibson wrote: > >> On Fri, Dec 20, 2019 at 05:51:48PM +0100, Greg Kurz wrote: >>> Multi TCG mandates the CPU topology to be dimensioned to the actual >>> number of CPUs, depending on the number of chips the user a

Re: [Qemu-devel] What should a virtual board emulate?

2020-01-05 Thread Gerd Hoffmann
Hi, > 78c37d88f1b8b0b3ebcc632c458f0c3779fe2951 is the first bad commit > commit 78c37d88f1b8b0b3ebcc632c458f0c3779fe2951 > Author: Paolo Bonzini > Date: Tue Mar 19 15:37:19 2019 +0100 > > mips-fulong2e: obey -vga none > > Do not create an ATI VGA if "-vga none" was passed on the com

[PATCH v2] MAINTAINERS: Replace Claudio Fontana for tcg/aarch64

2020-01-05 Thread Richard Henderson
Claudio's Huawei address has been defunct for quite a while. In https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg06872.html he asked for his personal address to be removed as well. I will take over officially. Cc: Claudio Fontana Cc: Philippe Mathieu-Daudé Cc: Alex Bennée Signed-o

Re: [PATCH qemu v2] spapr: Kill SLOF

2020-01-05 Thread Alexey Kardashevskiy
On 06/01/2020 15:19, David Gibson wrote: > On Mon, Jan 06, 2020 at 10:42:42AM +1100, Alexey Kardashevskiy wrote: >> The Petitboot bootloader is way more advanced than SLOF is ever going to >> be as Petitboot comes with the full-featured Linux kernel with all >> the drivers, and initramdisk with

Re: [PATCH] MAINTAINERS: Remove Claudio Fontana bouncing email

2020-01-05 Thread Richard Henderson
On 12/30/19 9:18 PM, Philippe Mathieu-Daudé wrote: > Claudio Fontana Huawei email is bouncing, remove it. > > The message you sent to claudio.font...@huawei.com couldn't be > delivered due to: Recipient email address is possibly incorrect. > > Further information: > 5.1.1 Error: invalid

Re: [PATCH qemu v2] spapr: Kill SLOF

2020-01-05 Thread David Gibson
On Mon, Jan 06, 2020 at 10:42:42AM +1100, Alexey Kardashevskiy wrote: > The Petitboot bootloader is way more advanced than SLOF is ever going to > be as Petitboot comes with the full-featured Linux kernel with all > the drivers, and initramdisk with quite user friendly interface. > The problem with

Re: [PATCH v2 0/7] configure: Improve PIE and other linkage

2020-01-05 Thread Richard Henderson
On 12/19/19 8:34 AM, Richard Henderson wrote: > This begins by dropping the -Ttext-segment stuff, which Fangrui Song > correctly points out does not work with lld. But it's also obsolete, > so instead of adding support for lld's --image-base, remove it all. > > Then, remove some other legacy rand

Re: [PATCH] arm/translate-a64: fix uninitialized variable warning

2020-01-05 Thread Pan Nengyuan
On 1/6/2020 10:15 AM, Richard Henderson wrote: > On 1/6/20 11:57 AM, pannengy...@huawei.com wrote: >> From: Pan Nengyuan >> >> Fixes: >> target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512': >> target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized >> i

Re: [PATCH] arm/translate-a64: fix uninitialized variable warning

2020-01-05 Thread Richard Henderson
On 1/6/20 11:57 AM, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > Fixes: > target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512': > target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized > in this function [-Werror=maybe-uninitialized] > genfn

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-05 Thread Guoheyi
在 2020/1/5 20:53, Michael S. Tsirkin 写道: On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: According to ACPI spec, _ADR should be used for device which is on a bus that has a standard enumeration algorithm. It does no

[PATCH] arm/translate-a64: fix uninitialized variable warning

2020-01-05 Thread pannengyuan
From: Pan Nengyuan Fixes: target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512': target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized in this function [-Werror=maybe-uninitialized] genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr); ^~

[PATCH] nbd: fix uninitialized variable warning

2020-01-05 Thread pannengyuan
From: Pan Nengyuan Fixes: /mnt/sdb/qemu/nbd/server.c: In function 'nbd_handle_request': /mnt/sdb/qemu/nbd/server.c:2313:9: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] int ret; Reported-by: Euler Robot Signed-off-by: Pan Nengyuan --- nbd/server.c

Re: [Patch v2 0/6] migration/postcopy: enable compress during postcopy

2020-01-05 Thread Wei Yang
On Wed, Dec 18, 2019 at 07:55:38PM +, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> Would this one be picked up in this version? > >I think that one is on Juan's list for the pull he's going to do soon. > >Dave > Happy New Year to all~ May I ask the plan

Re: [PATCH 0/2] not use multifd during postcopy

2020-01-05 Thread Wei Yang
On Mon, Dec 16, 2019 at 10:35:39AM +0800, Wei Yang wrote: >Would this one be picked up this time? Happy new year to all. Can I ask the plan for this patch set? > >On Sat, Oct 26, 2019 at 07:19:58AM +0800, Wei Yang wrote: >>We don't support multifd during postcopy, but user still could enable >>b

Re: [PATCH 08/86] alpha:dp264: use memdev for RAM

2020-01-05 Thread Richard Henderson
On 12/31/19 11:02 PM, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id > and

[PATCH qemu v2] spapr: Kill SLOF

2020-01-05 Thread Alexey Kardashevskiy
The Petitboot bootloader is way more advanced than SLOF is ever going to be as Petitboot comes with the full-featured Linux kernel with all the drivers, and initramdisk with quite user friendly interface. The problem with ditching SLOF is that an unmodified pseries kernel can either start via: 1. k

Re: [RFC PATCH qemu] spapr: Kill SLOF

2020-01-05 Thread Alexey Kardashevskiy
Another version is coming, I'll start putting fewer people in the cc: list, watch qemu-...@nongnu.org for further updates if interested. Thanks, On 03/01/2020 18:44, Alexey Kardashevskiy wrote: > The Petitboot bootloader is way more advanced than SLOF is ever going to > be as Petitboot comes with

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-05 Thread Corey Minyard
On Sun, Jan 05, 2020 at 07:33:55AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: > > According to ACPI spec, _ADR should be used for device which is on a > > bus that has a standard enumeration algorithm. It does not make sense > > to have a _ADR objec

Re: [PATCH] plugins/core: add missing break in cb_to_tcg_flags

2020-01-05 Thread Richard Henderson
On 1/5/20 5:29 PM, Emilio G. Cota wrote: > Reported-by: Robert Henry > Signed-off-by: Emilio G. Cota > --- > plugins/core.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH] RISCV: support riscv vector extension 0.7.1

2020-01-05 Thread Richard Henderson
On 12/30/19 6:11 PM, LIU Zhiwei wrote: > > However It's not clear when use tcg_gen_gvec_*_ptr or tcg_gen_gvec_ool. I > think > the meaning of oprsz is the > the bits of active elements.  Therefore , oprsz is  8 * env->vext.vl in RISC-V > and it can't be fetched  from > TB_FLAGS like SVE. > > Pro

Re: [PATCH v6 12/21] libqtest: add in-process qtest.c tx/rx handlers

2020-01-05 Thread Alexander Bulekov
On 200103 1115, Stefan Hajnoczi wrote: > On Fri, Nov 29, 2019 at 09:34:47PM +, Oleinik, Alexander wrote: > > +QTestState *qtest_inproc_init(QTestState **s, bool log, const char* arch, > > +void (*send)(void*, const char*)) > > +{ > > +QTestState *qts; > > +qts = g_ne

Re: [PATCH v6 02/21] libqos: Rename i2c_send and i2c_recv

2020-01-05 Thread Alexander Bulekov
On 200103 1201, Philippe Mathieu-Daudé wrote: > On 12/9/19 1:02 PM, Thomas Huth wrote: > > On 29/11/2019 22.34, Oleinik, Alexander wrote: > > > The names i2c_send and i2c_recv collide with functions defined in > > > hw/i2c/core.c. This causes an error when linking against libqos and > > > softmmu s

Re: [PATCH v6 01/21] softmmu: split off vl.c:main() into main.c

2020-01-05 Thread Alexander Bulekov
On 200103 0958, Stefan Hajnoczi wrote: > On Fri, Nov 29, 2019 at 09:34:36PM +, Oleinik, Alexander wrote: > > @@ -3853,7 +3834,7 @@ int main(int argc, char **argv, char **envp) > > set_memory_options(&ram_slots, &maxram_size, machine_class); > > > > os_daemonize(); > > -rcu_disab

Re: [Qemu-devel] [PATCH v4 3/7] target/riscv: Create function to test if FP is enabled

2020-01-05 Thread Aurelien Jarno
On 2020-01-05 17:36, Aurelien Jarno wrote: > > diff --git a/target/riscv/csr.c b/target/riscv/csr.c > > index e0d4586760..2789215b5e 100644 > > --- a/target/riscv/csr.c > > +++ b/target/riscv/csr.c > > [ snip ] > > > @@ -307,6 +307,7 @@ static int write_mstatus(CPURISCVState *env, int csrno, > >

Re: [Qemu-devel] [PATCH v4 3/7] target/riscv: Create function to test if FP is enabled

2020-01-05 Thread Aurelien Jarno
Hi, On 2019-08-23 08:21, Alistair Francis wrote: > Let's create a function that tests if floating point support is > enabled. We can then protect all floating point operations based on if > they are enabled. > > This patch so far doesn't change anything, it's just preparing for the > Hypervisor s

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-05 Thread Yuri Benditovich
On Sun, Jan 5, 2020 at 1:39 PM Michael S. Tsirkin wrote: > On Thu, Jan 02, 2020 at 09:09:04AM +0200, Yuri Benditovich wrote: > > > > > > On Thu, Jan 2, 2020 at 1:50 AM Michael S. Tsirkin > wrote: > > > > On Thu, Dec 26, 2019 at 11:29:50AM +0200, Yuri Benditovich wrote: > > > On Thu, Dec

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-05 Thread Yuri Benditovich
On Sun, Jan 5, 2020 at 2:22 PM Michael S. Tsirkin wrote: > On Thu, Dec 26, 2019 at 06:36:48AM +0200, Yuri Benditovich wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1708480 > > Fix leak of region reference that prevents complete > > device deletion on hot unplug. > > > > Signed-off-by: Yu

Re: [PATCH v18 1/7] Wrapper function to wait on condition for the main loop mutex

2020-01-05 Thread Greg Kurz
On Thu, 2 Jan 2020 13:21:05 +0530 Ganesh Goudar wrote: > From: Aravinda Prasad > > Introduce a wrapper function to wait on condition for > the main loop mutex. This function atomically releases > the main loop mutex and causes the calling thread to > block on the condition. This wrapper is req

Re: [PATCH v2] Implement the Screamer sound chip for the mac99 machine type

2020-01-05 Thread Programmingkid
> On Jan 4, 2020, at 8:58 PM, Programmingkid wrote: > > I found the patch that breaks Screamer sound support for qemu-system-ppc. It > is this: > > commit 2ceb8240fa4e4e30fb853565eb2bed3032d74f62 > Author: Kővágó, Zoltán > Date: Thu Sep 19 23:24:11 2019 +0200 > >coreaudio: port to the

[PULL v3 27/32] tests: add virtio-scsi and virtio-blk seg_max_adjust test

2020-01-05 Thread Michael S. Tsirkin
From: Denis Plotnikov It tests proper seg_max_adjust settings for all machine types except 'none', 'isapc', 'microvm' Signed-off-by: Denis Plotnikov Message-Id: <20191220140905.1718-3-dplotni...@virtuozzo.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/accept

[PULL v3 31/32] intel_iommu: a fix to vtd_find_as_from_bus_num()

2020-01-05 Thread Michael S. Tsirkin
From: Liu Yi L Ensure the return value of vtd_find_as_from_bus_num() is NULL by enforcing vtd_bus=NULL. This would help caller of vtd_find_as_from_bus_num() to decide if any further operation on the returned vtd_bus. Cc: qemu-sta...@nongnu.org Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Yi

[PULL v3 29/32] virtio: reset region cache when on queue deletion

2020-01-05 Thread Michael S. Tsirkin
From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1708480 Fix leak of region reference that prevents complete device deletion on hot unplug. Cc: qemu-sta...@nongnu.org Signed-off-by: Yuri Benditovich Message-Id: <20191226043649.14481-2-yuri.benditov...@daynix.com> Reviewed-by:

[PULL v3 25/32] hw: fix using 4.2 compat in 5.0 machine types for i440fx/q35

2020-01-05 Thread Michael S. Tsirkin
From: Denis Plotnikov 5.0 machine type uses 4.2 compats. This seems to be incorrect, since the latests machine type by now is 5.0 and it should use its own compat or shouldn't use any relying on the defaults. Seems, like this appeared because of some problems on merge/rebase. Signed-off-by: Deni

[PULL v3 19/32] ACPI: add expected files for HMAT tests (acpihmat)

2020-01-05 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- tests/bios-tables-test-allowed-diff.h | 8 tests/data/acpi/pc/APIC.acpihmat | Bin 0 -> 128 bytes tests/data/acpi/pc/DSDT.acpihmat | Bin 0 -> 6455 bytes tests/data/acpi/pc/HMAT.acpihmat | Bin 0 -> 280 bytes tests/data/acpi/pc/SRAT.

[PULL v3 16/32] hmat acpi: Build Memory Side Cache Information Structure(s)

2020-01-05 Thread Michael S. Tsirkin
From: Liu Jingqi This structure describes memory side cache information for memory proximity domains if the memory side cache is present and the physical device forms the memory side cache. The software could use this information to effectively place the data in memory to maximize the performance

[PULL v3 13/32] numa: Extend CLI to provide memory side cache information

2020-01-05 Thread Michael S. Tsirkin
From: Liu Jingqi Add -numa hmat-cache option to provide Memory Side Cache Information. These memory attributes help to build Memory Side Cache Information Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). Before using hmat-cache option, enable HMAT with -machine hmat=on. Acked-by

[PULL v3 32/32] intel_iommu: add present bit check for pasid table entries

2020-01-05 Thread Michael S. Tsirkin
From: Liu Yi L The present bit check for pasid entry (pe) and pasid directory entry (pdire) were missed in previous commits as fpd bit check doesn't require present bit as "Set". This patch adds the present bit check for callers which wants to get a valid pe/pdire. Cc: qemu-sta...@nongnu.org Cc:

[PULL v3 30/32] virtio-net: delete also control queue when TX/RX deleted

2020-01-05 Thread Michael S. Tsirkin
From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1708480 If the control queue is not deleted together with TX/RX, it later will be ignored in freeing cache resources and hot unplug will not be completed. Cc: qemu-sta...@nongnu.org Signed-off-by: Yuri Benditovich Message-Id: <2

[PULL v3 24/32] vhost-user-scsi: reset the device if supported

2020-01-05 Thread Michael S. Tsirkin
From: Raphael Norwitz If the vhost-user-scsi backend supports the VHOST_USER_F_RESET_DEVICE protocol feature, then the device can be reset when requested. If this feature is not supported, do not try a reset as this will send a VHOST_USER_RESET_OWNER that the backend is not expecting, potentiall

[PULL v3 11/32] numa: Extend CLI to provide initiator information for numa nodes

2020-01-05 Thread Michael S. Tsirkin
From: Tao Xu In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT), The initiator represents processor which access to memory. And in 5.2.27.3 Memory Proximity Domain Attributes Structure, the attached initiator is defined as where the memory controller responsible for a memory p

[PULL v3 28/32] virtio-mmio: update queue size on guest write

2020-01-05 Thread Michael S. Tsirkin
From: Denis Plotnikov Some guests read back queue size after writing it. Always update the on size write otherwise they might be confused. Cc: qemu-sta...@nongnu.org Signed-off-by: Denis Plotnikov Message-Id: <20191224081446.17003-1-dplotni...@virtuozzo.com> Reviewed-by: Michael S. Tsirkin Sig

[PULL v3 23/32] vhost-user: add VHOST_USER_RESET_DEVICE to reset devices

2020-01-05 Thread Michael S. Tsirkin
From: Raphael Norwitz Add a VHOST_USER_RESET_DEVICE message which will reset the vhost user backend. Disabling all rings, and resetting all internal state, ready for the backend to be reinitialized. A backend has to report it supports this features with the VHOST_USER_PROTOCOL_F_RESET_DEVICE pro

[PULL v3 17/32] tests/numa: Add case for QMP build HMAT

2020-01-05 Thread Michael S. Tsirkin
From: Tao Xu Check configuring HMAT usecase Acked-by: Markus Armbruster Suggested-by: Igor Mammedov Signed-off-by: Tao Xu Message-Id: <20191213011929.2520-8-tao3...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- tests/numa-test.

[PULL v3 10/32] virtio: don't enable notifications during polling

2020-01-05 Thread Michael S. Tsirkin
From: Stefan Hajnoczi Virtqueue notifications are not necessary during polling, so we disable them. This allows the guest driver to avoid MMIO vmexits. Unfortunately the virtio-blk and virtio-scsi handler functions re-enable notifications, defeating this optimization. Fix virtio-blk and virtio-

[PULL v3 22/32] hw/pci/pci_host: Let pci_data_[read/write] use unsigned 'size' argument

2020-01-05 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Both functions are called by MemoryRegionOps.[read/write] handlers with unsigned 'size' argument. Both functions call pci_host_config_[read/write]_common() which expect a uint32_t 'len' parameter (also unsigned). Since it is pointless (and confuse) to use a signed val

[PULL v3 26/32] virtio: make seg_max virtqueue size dependent

2020-01-05 Thread Michael S. Tsirkin
From: Denis Plotnikov Before the patch, seg_max parameter was immutable and hardcoded to 126 (128 - 2) without respect to queue size. This has two negative effects: 1. when queue size is < 128, we have Virtio 1.1 specfication violation: (2.6.5.3.1 Driver Requirements) seq_max must be <= queue

[PULL v3 09/32] Implement backend program convention command for vhost-user-blk

2020-01-05 Thread Michael S. Tsirkin
From: Micky Yun Chan This patch is to add standard commands defined in docs/interop/vhost-user.rst For vhost-user-* program Signed-off-by: Micky Yun Chan (michiboo) Message-Id: <20191209015331.5455-1-chanmicky...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL v3 14/32] hmat acpi: Build Memory Proximity Domain Attributes Structure(s)

2020-01-05 Thread Michael S. Tsirkin
From: Liu Jingqi HMAT is defined in ACPI 6.3: 5.2.27 Heterogeneous Memory Attribute Table (HMAT). The specification references below link: http://www.uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf It describes the memory attributes, such as memory side cache attributes and bandw

[PULL v3 18/32] tests/bios-tables-test: add test cases for ACPI HMAT

2020-01-05 Thread Michael S. Tsirkin
From: Tao Xu ACPI table HMAT has been introduced, QEMU now builds HMAT tables for Heterogeneous Memory with boot option '-numa node'. Add test cases on PC and Q35 machines with 2 numa nodes. Because HMAT is generated when system enable numa, the following tables need to be added for this test:

[PULL v3 21/32] hw/pci/pci_host: Remove redundant PCI_DPRINTF()

2020-01-05 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé In commit 3bf4dfdd111 we introduced the pci_cfg_[read/write] trace events in pci_host_config_[read/write]_common(). We have the following call trace: pci_host_data_[read/write]() - PCI_DPRINTF() - pci_data_[read/write]() - PCI_DPRINTF() - pc

[PULL v3 12/32] numa: Extend CLI to provide memory latency and bandwidth information

2020-01-05 Thread Michael S. Tsirkin
From: Liu Jingqi Add -numa hmat-lb option to provide System Locality Latency and Bandwidth Information. These memory attributes help to build System Locality Latency and Bandwidth Information Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). Before using hmat-lb option, enable HMA

[PULL v3 15/32] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2020-01-05 Thread Michael S. Tsirkin
From: Liu Jingqi This structure describes the memory access latency and bandwidth information from various memory access initiator proximity domains. The latency and bandwidth numbers represented in this structure correspond to rated latency and bandwidth for the platform. The software could use

[PULL v3 08/32] virtio-pci: disable vring processing when bus-mastering is disabled

2020-01-05 Thread Michael S. Tsirkin
From: Michael Roth Currently the SLOF firmware for pseries guests will disable/re-enable a PCI device multiple times via IO/MEM/MASTER bits of PCI_COMMAND register after the initial probe/feature negotiation, as it tends to work with a single device at a time at various stages like probing and ru

[PULL v3 20/32] virtio-mmio: Clear v2 transport state on soft reset

2020-01-05 Thread Michael S. Tsirkin
From: Jean-Philippe Brucker At the moment when the guest writes a status of 0, we only reset the virtio core state but not the virtio-mmio state. The virtio-mmio specification says (v1.1 cs01, 4.2.2.1 Device Requirements: MMIO Device Register Layout): Upon reset, the device MUST clear all bi

[PULL v3 06/32] intel_iommu: fix bug to read DMAR_RTADDR_REG

2020-01-05 Thread Michael S. Tsirkin
From: Yi Sun Should directly read DMAR_RTADDR_REG but not using 's->root'. Because 's->root' is modified in 'vtd_root_table_setup()' so that the first 12 bits are omitted. This causes the guest iommu debugfs cannot show pasid tables. Signed-off-by: Yi Sun Message-Id: <20191205095439.29114-1-yi.

[PULL v3 05/32] virtio-input: convert to new virtio_delete_queue

2020-01-05 Thread Michael S. Tsirkin
Seems cleaner than using VQ index values. Signed-off-by: Michael S. Tsirkin --- hw/input/virtio-input.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/input/virtio-input.c b/hw/input/virtio-input.c index ec54e46ad6..9c013afddb 100644 --- a/hw/input/virtio-input.c +++

[PULL v3 03/32] virtio-balloon: fix memory leak while attach virtio-balloon device

2020-01-05 Thread Michael S. Tsirkin
From: Pan Nengyuan ivq/dvq/svq/free_page_vq is forgot to cleanup in virtio_balloon_device_unrealize, the memory leak stack is as follow: Direct leak of 14336 byte(s) in 2 object(s) allocated from: #0 0x7f99fd9d8560 in calloc (/usr/lib64/libasan.so.3+0xc7560) #1 0x7f99fcb20015 in g_malloc

[PULL v3 07/32] virtio: update queue size on guest write

2020-01-05 Thread Michael S. Tsirkin
Some guests read back queue size after writing it. Update the size immediatly upon write otherwise they get confused. In particular this is the case for seabios. Reported-by: Roman Kagan Suggested-by: Denis Plotnikov Cc: qemu-sta...@nongnu.org Signed-off-by: Michael S. Tsirkin --- hw/virtio/v

[PULL v3 02/32] virtio: make virtio_delete_queue idempotent

2020-01-05 Thread Michael S. Tsirkin
Let's make sure calling this twice is harmless - no known instances, but seems safer. Suggested-by: Pan Nengyuan Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 31dd140990..6de3cfdc2c 1006

[PULL v3 00/32] virtio, pci, pc: fixes, features

2020-01-05 Thread Michael S. Tsirkin
Changes from v2: - rebased on master - a couple more bugfixes The following changes since commit f0dcfddecee8b860e015bb07d67cfcbdfbfd51d9: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-01-03 17:18:08 +) are available in the Git repository at:

[PULL v3 04/32] virtio-serial-bus: fix memory leak while attach virtio-serial-bus

2020-01-05 Thread Michael S. Tsirkin
From: Pan Nengyuan ivqs/ovqs/c_ivq/c_ovq is forgot to cleanup in virtio_serial_device_unrealize, the memory leak stack is as bellow: Direct leak of 1290240 byte(s) in 180 object(s) allocated from: #0 0x7fc9bfc27560 in calloc (/usr/lib64/libasan.so.3+0xc7560) #1 0x7fc9bed6f015 in g_malloc

[PULL v3 01/32] virtio: add ability to delete vq through a pointer

2020-01-05 Thread Michael S. Tsirkin
Devices tend to maintain vq pointers, allow deleting them trough a vq pointer. Signed-off-by: Michael S. Tsirkin Reviewed-by: David Hildenbrand Reviewed-by: David Hildenbrand --- include/hw/virtio/virtio.h | 2 ++ hw/virtio/virtio.c | 15 ++- 2 files changed, 12 insertions

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-05 Thread Michael S. Tsirkin
On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: > > According to ACPI spec, _ADR should be used for device which is on a > > bus that has a standard enumeration algorithm. It does not make sense > > to have a _ADR objec

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-05 Thread Michael S. Tsirkin
On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: > According to ACPI spec, _ADR should be used for device which is on a > bus that has a standard enumeration algorithm. It does not make sense > to have a _ADR object for devices which already have _HID and will be > enumerated by OSPM. > >

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-05 Thread Michael S. Tsirkin
On Thu, Dec 26, 2019 at 06:36:48AM +0200, Yuri Benditovich wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1708480 > Fix leak of region reference that prevents complete > device deletion on hot unplug. > > Signed-off-by: Yuri Benditovich I rebased this on top of my tree. Got this: commit

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-05 Thread Michael S. Tsirkin
On Thu, Jan 02, 2020 at 09:09:04AM +0200, Yuri Benditovich wrote: > > > On Thu, Jan 2, 2020 at 1:50 AM Michael S. Tsirkin wrote: > > On Thu, Dec 26, 2019 at 11:29:50AM +0200, Yuri Benditovich wrote: > > On Thu, Dec 26, 2019 at 10:58 AM Jason Wang wrote: > > > > > > > > > On

Re: [Qemu-devel] What should a virtual board emulate?

2020-01-05 Thread BALATON Zoltan
On Sat, 4 Jan 2020, Philippe Mathieu-Daudé wrote: I insist this patch is incorrect for the particular case of the Fuloong2e board. I plan to revert it when I post the test. I can only repeat my comment from when it last came up: On Wed, 20 Mar 2019, BALATON Zoltan wrote: Thanks, I did not know

[Bug 1839060] Re: HDA device non functional in Windows 10 1903

2020-01-05 Thread Idar Lund
Microsoft has fixed their hda driver ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1839060 Title: HDA device non functional in Windows 10 190

[Bug 1839060] Re: HDA device non functional in Windows 10 1903

2020-01-05 Thread Idar Lund
Microsoft has updated their driver to 10.0.18362.356 and the sound is now working with the audoidev hda. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1839060 Title: HDA device non functional in Wi