Re: [RFC PATCH] hw/arm/virt: Support NMI injection

2020-01-28 Thread Julien Thierry
On 1/29/20 3:46 AM, Gavin Shan wrote: On 1/28/20 7:29 PM, Julien Thierry wrote: Hi Gavin, On 1/28/20 6:48 AM, Gavin Shan wrote: [including more folks into the discussion] On Fri, 17 Jan 2020 at 14:00, Peter Maydell wrote: On Thu, 19 Dec 2019 at 04:06, Gavin Shan wrote: This supports

Re: [PATCH v3 13/14] dp8393x: Don't reset Silicon Revision register

2020-01-28 Thread Finn Thain
On Wed, 29 Jan 2020, Philippe Mathieu-Daudé wrote: > > > > This would allow the host to change the value of the Silicon Revision > > register. > How the guest can modify it? We have: > > 589 static void dp8393x_write(void *opaque, hwaddr addr, uint64_t data, > 590

Re: [PATCH] .travis.yml: Add description to each job

2020-01-28 Thread Thomas Huth
On 28/01/2020 13.55, Alex Bennée wrote: > > Thomas Huth writes: > >> On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: >>> The NAME variable can be used to describe nicely a job (see [*]). >>> As we currently have 32 jobs, use it. This helps for quickly >>> finding a particular job. >>> >>>

Re: [PATCH v2 1/7] block/block-copy: specialcase first copy_range request

2020-01-28 Thread Andrey Shinkevich
On 27/11/2019 21:08, Vladimir Sementsov-Ogievskiy wrote: > In block_copy_do_copy we fallback to read+write if copy_range failed. > In this case copy_size is larger than defined for buffered IO, and > there is corresponding commit. Still, backup copies data cluster by > cluster, and most of

Re: [PATCH rc3 01/30] target/avr: Add basic parameters for new AVR platform

2020-01-28 Thread Philippe Mathieu-Daudé
On 1/28/20 7:01 PM, Aleksandar Markovic wrote: Works for me too. 16:10 Uto, 28.01.2020. Michael Rolnik > је написао/ла: Sounds good to me. On Tue, Jan 28, 2020 at 3:49 PM Aleksandar Markovic mailto:aleksandar.m.m...@gmail.com>> wrote: On

Re: [PATCH] .travis.yml: Add description to each job

2020-01-28 Thread Thomas Huth
On 29/01/2020 08.27, Philippe Mathieu-Daudé wrote: > On 1/29/20 8:20 AM, Thomas Huth wrote: >> On 28/01/2020 14.33, Wainer dos Santos Moschetta wrote: >>> >>> On 1/28/20 11:18 AM, Philippe Mathieu-Daudé wrote: On Tue, Jan 28, 2020 at 1:55 PM Alex Bennée wrote: > Thomas Huth writes:

Re: [PATCH rc3 23/30] hw/core/loader: Let load_elf populate the processor-specific flags

2020-01-28 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 1/28/20 8:25 PM, Aleksandar Markovic wrote: On Tue, Jan 28, 2020 at 2:27 PM Aleksandar Markovic mailto:aleksandar.m.m...@gmail.com>> wrote: On Tuesday, January 28, 2020, BALATON Zoltan mailto:bala...@eik.bme.hu>> wrote: On Tue, 28 Jan 2020, Aleksandar Markovic

Re: [PATCH] .travis.yml: Add description to each job

2020-01-28 Thread Thomas Huth
On 28/01/2020 14.20, Wainer dos Santos Moschetta wrote: > > On 1/26/20 5:54 AM, Thomas Huth wrote: >> On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: >>> The NAME variable can be used to describe nicely a job (see [*]). >>> As we currently have 32 jobs, use it. This helps for quickly >>>

Re: [PATCH] .travis.yml: Add description to each job

2020-01-28 Thread Philippe Mathieu-Daudé
On 1/29/20 8:20 AM, Thomas Huth wrote: On 28/01/2020 14.33, Wainer dos Santos Moschetta wrote: On 1/28/20 11:18 AM, Philippe Mathieu-Daudé wrote: On Tue, Jan 28, 2020 at 1:55 PM Alex Bennée wrote: Thomas Huth writes: On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: The NAME variable

Re: [PATCH] .travis.yml: Add description to each job

2020-01-28 Thread Thomas Huth
On 28/01/2020 14.33, Wainer dos Santos Moschetta wrote: > > On 1/28/20 11:18 AM, Philippe Mathieu-Daudé wrote: >> On Tue, Jan 28, 2020 at 1:55 PM Alex Bennée >> wrote: >>> Thomas Huth writes: On 25/01/2020 19.31, Philippe Mathieu-Daudé wrote: > The NAME variable can be used to describe

[RFC] coreaudio: fix coreaudio_test.diff

2020-01-28 Thread Volker Rümelin
This is an untested patch that tries to fix the problems in the patch found at https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg02142.html. Signed-off-by: Volker Rümelin --- audio/audio_template.h | 16 audio/coreaudio.c | 5 + 2 files changed, 13

Re: [PATCH v2] Implement the Screamer sound chip for the mac99 machine type

2020-01-28 Thread Volker Rümelin
> > Hi Volker, > > I can test for coreaudio. Can you let us know exactly what you fixed in the > patch? Hi Howard, I wrote a patch that tries to fix the problems in Zoltán's patch. The changes in coreaudio.c are untested. I'll send it as a reply to this mail. Please apply Zoltan's patch and

[Bug 1823790] Re: QEMU mishandling of SO_PEERSEC forces systemd into tight loop

2020-01-28 Thread Tobias Koch
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1823790 Title: QEMU mishandling of SO_PEERSEC forces systemd into tight loop Status in QEMU:

Re: [PULL 0/6] MIPS queue for January 28th, 2020

2020-01-28 Thread Philippe Mathieu-Daudé
Hi Peter, On 1/28/20 9:09 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic The following changes since commit 4c60e3289875ae6c516a37523bcecb87f68ce67c: Merge remote-tracking branch 'remotes/rth/tags/pull-pa-20200127' into staging (2020-01-28 15:11:04 +) are available in the

Re: [PATCH v3 13/14] dp8393x: Don't reset Silicon Revision register

2020-01-28 Thread Philippe Mathieu-Daudé
Hi Finn, On 1/28/20 11:28 PM, Finn Thain wrote: On Tue, 28 Jan 2020, Philippe Mathieu-Daud? wrote: On 1/19/20 11:59 PM, Finn Thain wrote: The jazzsonic driver in Linux uses the Silicon Revision register value to probe the chip. The driver fails unless the SR register contains 4.

Re: [PATCH 1/2] ppc/pnv: Add models for POWER9 PHB4 PCIe Host bridge

2020-01-28 Thread David Gibson
On Wed, Jan 29, 2020 at 02:54:19PM +1100, Oliver O'Halloran wrote: > On Wed, Jan 29, 2020 at 2:09 PM David Gibson > wrote: > > > > On Mon, Jan 27, 2020 at 03:45:05PM +0100, Cédric Le Goater wrote: > > > From: Benjamin Herrenschmidt > > > > > *snip* > > > > + > > > +/* > > > + * The CONFIG_DATA

Re: [PATCH 0/2] ppc/pnv: Add models for PHB4 and PHB3 PCIe Host bridges

2020-01-28 Thread David Gibson
On Mon, Jan 27, 2020 at 03:45:04PM +0100, Cédric Le Goater wrote: > Hello, > > These are models for the PCIe Host Bridges, PHB3 and PHB4, as found on > POWER8 and POWER9 processors. It includes the PowerBus logic interface > (PBCQ), IOMMU support, a single PCIe Gen.3/4 Root Complex, and support >

[Bug 1823790] Re: QEMU mishandling of SO_PEERSEC forces systemd into tight loop

2020-01-28 Thread Tobias Koch
I'm a bit surprised that this bug doesn't get more attention, as it makes it very hard to run qemu-emulated containers of Bionic hosted on Bionic. Running such containers is a common way to cross-compile packages for foreign architectures in the absence of sufficiently powerful target HW. The

Re: [PATCH v2 1/4] monitor: Move monitor option parsing to monitor/monitor.c

2020-01-28 Thread Markus Armbruster
Kevin Wolf writes: > Both the system emulators and tools with QMP support (specifically, the > planned storage daemon) will need to parse monitor options, so move that > code to monitor/monitor.c, which can be linked into binaries that aren't > a system emulator. > > Signed-off-by: Kevin Wolf >

[PATCH v8 21/21] fuzz: add documentation to docs/devel/

2020-01-28 Thread Bulekov, Alexander
Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi --- docs/devel/fuzzing.txt | 116 + 1 file changed, 116 insertions(+) create mode 100644 docs/devel/fuzzing.txt diff --git a/docs/devel/fuzzing.txt b/docs/devel/fuzzing.txt new file mode

[PATCH v8 20/21] fuzz: add virtio-scsi fuzz target

2020-01-28 Thread Bulekov, Alexander
The virtio-scsi fuzz target sets up and fuzzes the available virtio-scsi queues. After an element is placed on a queue, the fuzzer can select whether to perform a kick, or continue adding elements. Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi ---

[PATCH v8 14/21] fuzz: support for fork-based fuzzing.

2020-01-28 Thread Bulekov, Alexander
fork() is a simple way to ensure that state does not leak in between fuzzing runs. Unfortunately, the fuzzer mutation engine relies on bitmaps which contain coverage information for each fuzzing run, and these bitmaps should be copied from the child to the parent(where the mutation occurs). These

[PATCH v8 12/21] exec: keep ram block across fork when using qtest

2020-01-28 Thread Bulekov, Alexander
Ram blocks were marked MADV_DONTFORK breaking fuzzing-tests which execute each test-input in a forked process. Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi --- exec.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index

[PATCH v8 18/21] fuzz: add i440fx fuzz targets

2020-01-28 Thread Bulekov, Alexander
These three targets should simply fuzz reads/writes to a couple ioports, but they mostly serve as examples of different ways to write targets. They demonstrate using qtest and qos for fuzzing, as well as using rebooting and forking to reset state, or not resetting it at all. Signed-off-by:

[PATCH v8 15/21] fuzz: add support for qos-assisted fuzz targets

2020-01-28 Thread Bulekov, Alexander
Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi --- tests/qtest/fuzz/Makefile.include | 2 + tests/qtest/fuzz/qos_fuzz.c | 229 ++ tests/qtest/fuzz/qos_fuzz.h | 33 + 3 files changed, 264 insertions(+) create mode 100644

[PATCH v8 19/21] fuzz: add virtio-net fuzz target

2020-01-28 Thread Bulekov, Alexander
The virtio-net fuzz target feeds inputs to all three virtio-net virtqueues, and uses forking to avoid leaking state between fuzz runs. Signed-off-by: Alexander Bulekov --- tests/qtest/fuzz/Makefile.include | 1 + tests/qtest/fuzz/virtio_net_fuzz.c | 195 + 2 files

[PATCH v8 08/21] libqos: rename i2c_send and i2c_recv

2020-01-28 Thread Bulekov, Alexander
The names i2c_send and i2c_recv collide with functions defined in hw/i2c/core.c. This causes an error when linking against libqos and softmmu simultaneously (for example when using qtest inproc). Rename the libqos functions to avoid this. Signed-off-by: Alexander Bulekov Acked-by: Thomas Huth

[PATCH v8 17/21] fuzz: add configure flag --enable-fuzzing

2020-01-28 Thread Bulekov, Alexander
Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé --- configure | 39 +++ 1 file changed, 39 insertions(+) diff --git a/configure b/configure index 08c3a1c1f0..1a1e57eb61 100755 --- a/configure +++ b/configure

[PATCH v8 16/21] fuzz: add target/fuzz makefile rules

2020-01-28 Thread Bulekov, Alexander
Signed-off-by: Alexander Bulekov Reviewed-by: Darren Kenny Reviewed-by: Stefan Hajnoczi --- Makefile| 15 ++- Makefile.objs | 2 +- Makefile.target | 16 3 files changed, 31 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index

[PATCH v8 11/21] fuzz: add fuzzer skeleton

2020-01-28 Thread Bulekov, Alexander
tests/fuzz/fuzz.c serves as the entry point for the virtual-device fuzzer. Namely, libfuzzer invokes the LLVMFuzzerInitialize and LLVMFuzzerTestOneInput functions, both of which are defined in this file. This change adds a "FuzzTarget" struct, along with the fuzz_add_target function, which should

[PATCH v8 10/21] libqos: move useful qos-test funcs to qos_external

2020-01-28 Thread Bulekov, Alexander
The moved functions are not specific to qos-test and might be useful elsewhere. For example the virtual-device fuzzer makes use of them for qos-assisted fuzz-targets. Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé ---

[PATCH v8 04/21] qtest: add qtest_server_send abstraction

2020-01-28 Thread Bulekov, Alexander
qtest_server_send is a function pointer specifying the handler used to transmit data to the qtest client. In the standard configuration, this calls the CharBackend handler, but now it is possible for other types of handlers, e.g direct-function calls if the qtest client and server exist within the

[PATCH v8 06/21] libqtest: make bufwrite rely on the TransportOps

2020-01-28 Thread Bulekov, Alexander
When using qtest "in-process" communication, qtest_sendf directly calls a function in the server (qtest.c). Previously, bufwrite used socket_send, which bypasses the TransportOps enabling the call into qtest.c. This change replaces the socket_send calls with ops->send, maintaining the benefits of

[PATCH v8 13/21] main: keep rcu_atfork callback enabled for qtest

2020-01-28 Thread Bulekov, Alexander
The qtest-based fuzzer makes use of forking to reset-state between tests. Keep the callback enabled, so the call_rcu thread gets created within the child process. Signed-off-by: Alexander Bulekov --- vl.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c

[PATCH v8 07/21] qtest: add in-process incoming command handler

2020-01-28 Thread Bulekov, Alexander
The handler allows a qtest client to send commands to the server by directly calling a function, rather than using a file/CharBackend Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi --- include/sysemu/qtest.h | 1 + qtest.c| 13 + 2 files changed, 14

[PATCH v8 01/21] softmmu: split off vl.c:main() into main.c

2020-01-28 Thread Bulekov, Alexander
A program might rely on functions implemented in vl.c, but implement its own main(). By placing main into a separate source file, there are no complaints about duplicate main()s when linking against vl.o. For example, the virtual-device fuzzer uses a main() provided by libfuzzer, and needs to

[PATCH v8 09/21] libqos: split qos-test and libqos makefile vars

2020-01-28 Thread Bulekov, Alexander
Most qos-related objects were specified in the qos-test-obj-y variable. qos-test-obj-y also included qos-test.o which defines a main(). This made it difficult to repurpose qos-test-obj-y to link anything beside tests/qos-test against libqos. This change separates objects that are libqos-specific

[PATCH v8 02/21] module: check module wasn't already initialized

2020-01-28 Thread Bulekov, Alexander
The virtual-device fuzzer must initialize QOM, prior to running vl:qemu_init, so that it can use the qos_graph to identify the arguments required to initialize a guest for libqos-assisted fuzzing. This change prevents errors when vl:qemu_init tries to (re)initialize the previously initialized QOM

[PATCH v8 00/21] Add virtual device fuzzing support

2020-01-28 Thread Bulekov, Alexander
This series adds a framework for coverage-guided fuzzing of virtual-devices. Fuzzing targets are based on qtest and can make use of the libqos abstractions. V8: * Small fixes to the virtio-net. * Keep rcu_atfork when not using qtest. V7: * virtio-net: add virtio-net-check-used which waits for

[PATCH v8 03/21] fuzz: add FUZZ_TARGET module type

2020-01-28 Thread Bulekov, Alexander
Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi --- include/qemu/module.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/qemu/module.h b/include/qemu/module.h index 65ba596e46..684753d808 100644 --- a/include/qemu/module.h +++

[PATCH v8 05/21] libqtest: add a layer of abstraction to send/recv

2020-01-28 Thread Bulekov, Alexander
This makes it simple to swap the transport functions for qtest commands to and from the qtest client. For example, now it is possible to directly pass qtest commands to a server handler that exists within the same process, without the standard way of writing to a file descriptor. Signed-off-by:

Re: [PATCH 1/2] ppc/pnv: Add models for POWER9 PHB4 PCIe Host bridge

2020-01-28 Thread Oliver O'Halloran
On Wed, Jan 29, 2020 at 2:09 PM David Gibson wrote: > > On Mon, Jan 27, 2020 at 03:45:05PM +0100, Cédric Le Goater wrote: > > From: Benjamin Herrenschmidt > > *snip* > > + > > +/* > > + * The CONFIG_DATA register expects little endian accesses, but as the > > + * region is big endian, we have

Re: [RFC PATCH] hw/arm/virt: Support NMI injection

2020-01-28 Thread Gavin Shan
On 1/28/20 7:29 PM, Julien Thierry wrote: Hi Gavin, On 1/28/20 6:48 AM, Gavin Shan wrote: [including more folks into the discussion] On Fri, 17 Jan 2020 at 14:00, Peter Maydell wrote: On Thu, 19 Dec 2019 at 04:06, Gavin Shan wrote: This supports NMI injection for virtual machine and

Re: [RFC PATCH] hw/arm/virt: Support NMI injection

2020-01-28 Thread Gavin Shan
On 1/29/20 1:44 PM, Alexey Kardashevskiy wrote: On 28/01/2020 17:48, Gavin Shan wrote: [including more folks into the discussion] On Fri, 17 Jan 2020 at 14:00, Peter Maydell wrote: On Thu, 19 Dec 2019 at 04:06, Gavin Shan wrote: This supports NMI injection for virtual machine and

Re: [PATCH qemu] spapr_pci: Create assigned properties for bridges

2020-01-28 Thread David Gibson
On Wed, Jan 29, 2020 at 01:31:11PM +1100, Alexey Kardashevskiy wrote: > QEMU assigns bus numbers so tell the guest about assigned values. > > This also adds an empty "ranges" to let the existing linux kernels proceed > far enough to trigger resource reassignment (which is rather a > hack). That

Re: [RFC PATCH] hw/arm/virt: Support NMI injection

2020-01-28 Thread Gavin Shan
On 1/28/20 9:56 PM, Auger Eric wrote: Hi Marc, On 1/28/20 10:25 AM, Marc Zyngier wrote: Gavin, Eric, On 2020-01-28 08:05, Auger Eric wrote: Hi, On 1/28/20 7:48 AM, Gavin Shan wrote: [including more folks into the discussion] On Fri, 17 Jan 2020 at 14:00, Peter Maydell wrote: On Thu, 19

Re: [PATCH 1/2] ppc/pnv: Add models for POWER9 PHB4 PCIe Host bridge

2020-01-28 Thread David Gibson
On Mon, Jan 27, 2020 at 03:45:05PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > These changes introduces models for the PCIe Host Bridge (PHB4) of the > POWER9 processor. It includes the PowerBus logic interface (PBCQ), > IOMMU support, a single PCIe Gen.4 Root Complex, and

Re: [PATCH qemu] spapr_pci: Create assigned properties for bridges

2020-01-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200129023111.1699-1-...@ozlabs.ru/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has

Re: [PATCH qemu] spapr_pci: Create assigned properties for bridges

2020-01-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200129023111.1699-1-...@ozlabs.ru/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH qemu] spapr_pci: Create assigned properties for bridges

2020-01-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200129023111.1699-1-...@ozlabs.ru/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [RFC PATCH] hw/arm/virt: Support NMI injection

2020-01-28 Thread Alexey Kardashevskiy
On 28/01/2020 17:48, Gavin Shan wrote: > [including more folks into the discussion] > >> On Fri, 17 Jan 2020 at 14:00, Peter Maydell >> wrote: >>> On Thu, 19 Dec 2019 at 04:06, Gavin Shan wrote: This supports NMI injection for virtual machine and currently it's only supported on

[PATCH qemu] spapr_pci: Create assigned properties for bridges

2020-01-28 Thread Alexey Kardashevskiy
QEMU assigns bus numbers so tell the guest about assigned values. This also adds an empty "ranges" to let the existing linux kernels proceed far enough to trigger resource reassignment (which is rather a hack). Signed-off-by: Alexey Kardashevskiy --- This is a part of the "kill CAS reboot"

Re: [PATCH 0/3] ppc/pnv: Add a "hostboot" mode

2020-01-28 Thread David Gibson
On Mon, Jan 27, 2020 at 03:41:51PM +0100, Cédric Le Goater wrote: > Hello, > > The QEMU PowerNV machine was first designed to start with a skiboot > firmware at 0x0, which then loads a kernel and ramfs acting as a boot > loader. Support of the POWER processor improving in QEMU, it has been >

Re: [PATCH v9 0/6] Add vTPM emulator support for ppc64 platform

2020-01-28 Thread David Gibson
On Tue, Jan 21, 2020 at 10:29:29AM -0500, Stefan Berger wrote: > > The following series of patches adds vTPM emulator support for the > ppc64 platform (pSeries). > > It can be tested as follows with swtpm/libtpms: > > mkdir /tmp/mytpm1 > swtpm socket --tpmstate dir=/tmp/mytpm1 \ > --ctrl

Re: Debugging heterogeneous SoC

2020-01-28 Thread Nikita Ermakov
On Wed, 29 Jan 2020 at 03:43, Alistair Francis wrote: > Use these commands to attach GDB to QEMU: > > target extended-remote :1234 > add-inferior > inferior 2 > attach 2 > set schedule-multiple > info threads > > Alistair > Thank you! It is worked!

Re: Debugging heterogeneous SoC

2020-01-28 Thread Alistair Francis
On Tue, Jan 28, 2020 at 4:29 PM Nikita Ermakov wrote: > > Hello, > > I am trying to debug the sifive_u SoC in the QEMU with GDB. > SiFive Unleashed contains one E51 core and four U54 cores. > In the hw/riscv/sifve_u.c E51 and U54 cores are placed in the different CPU > clusters. > In the

Debugging heterogeneous SoC

2020-01-28 Thread Nikita Ermakov
Hello, I am trying to debug the sifive_u SoC in the QEMU with GDB. SiFive Unleashed contains one E51 core and four U54 cores. In the hw/riscv/sifve_u.c E51 and U54 cores are placed in the different CPU clusters. In the gdbstub.c, it is searches only the first cluster and it always finds cluster

Re: [PATCH] riscv: Add semihosting support [v3]

2020-01-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200128231840.508986-1-kei...@keithp.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200128231840.508986-1-kei...@keithp.com Subject: [PATCH] riscv: Add semihosting support

Re: [PATCH] riscv: Separate FPU register size from core register size in gdbstub

2020-01-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200128223955.464556-1-kei...@keithp.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200128223955.464556-1-kei...@keithp.com Subject: [PATCH] riscv: Separate FPU register

Re: [PATCH] riscv: Separate FPU register size from core register size in gdbstub [v2]

2020-01-28 Thread Alistair Francis
On Tue, Jan 28, 2020 at 3:33 PM Keith Packard via wrote: > > The size of the FPU registers is dictated by the 'f' and 'd' features, > not the core processor register size. Processors with the 'd' feature > have 64-bit FPU registers. Processors without the 'd' feature but with > the 'f' feature

Re: [PATCH] riscv: Add semihosting support [v3]

2020-01-28 Thread Keith Packard
Keith Packard writes: > Adapt the arm semihosting support code for RISCV. This implementation > is based on the standard for RISC-V semihosting as documented in Sorry for the noise on the list; I failed to run checkpatch.pl before submitting. I've re-submittd [v4] with the formatting errors

Re: [PATCH] riscv: Separate FPU register size from core register size in gdbstub

2020-01-28 Thread Keith Packard
Alistair Francis writes: > You need brackets around all if statements, besides that: Sorry for the noise; I caught that and sent another version of this patch. > Reviewed-by: Alistair Francis Thanks for your review! -- -keith signature.asc Description: PGP signature

[PATCH] riscv: Separate FPU register size from core register size in gdbstub [v2]

2020-01-28 Thread Keith Packard via
The size of the FPU registers is dictated by the 'f' and 'd' features, not the core processor register size. Processors with the 'd' feature have 64-bit FPU registers. Processors without the 'd' feature but with the 'f' feature have 32-bit FPU registers. Signed-off-by: Keith Packard --- v2:

[PATCH] riscv: Add semihosting support [v4]

2020-01-28 Thread Keith Packard via
Adapt the arm semihosting support code for RISCV. This implementation is based on the standard for RISC-V semihosting as documented in https://riscv.org/specifications/ Signed-off-by: Keith Packard --- v2: Update PC after exception is handled to follow change in the

[PATCH] riscv: Add semihosting support [v3]

2020-01-28 Thread Keith Packard via
Adapt the arm semihosting support code for RISCV. This implementation is based on the standard for RISC-V semihosting as documented in https://riscv.org/specifications/ Signed-off-by: Keith Packard --- v2: Update PC after exception is handled to follow change in the

Re: [PATCH] riscv: Separate FPU register size from core register size in gdbstub

2020-01-28 Thread Alistair Francis
On Tue, Jan 28, 2020 at 2:40 PM Keith Packard via wrote: > > The size of the FPU registers is dictated by the 'f' and 'd' features, > not the core processor register size. Processors with the 'd' feature > have 64-bit FPU registers. Processors without the 'd' feature but with > the 'f' feature

Re: [PULL 4/6] hw/core/loader: Let load_elf() populate the processor-specific flags

2020-01-28 Thread Aleksandar Markovic
21:10 Uto, 28.01.2020. Aleksandar Markovic је написао/ла: > > From: Philippe Mathieu-Daudé > Unfortunately, some spelling errors of mine slipped through the cracks: > While loading the executable, some platforms (like AVR) need to > determine CPU type that executable is built for by reading

Re: [PATCH v3 01/14] dp8393x: Mask EOL bit from descriptor addresses

2020-01-28 Thread Finn Thain
On Tue, 28 Jan 2020, Philippe Mathieu-Daudé wrote: > Hi Finn, > > On 1/19/20 11:59 PM, Finn Thain wrote: > > The Least Significant bit of a descriptor address register is used as > > an EOL flag. It has to be masked when the register value is to be used > > as an actual address for copying

Re: [PATCH] riscv: Separate FPU register size from core register size in gdbstub

2020-01-28 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200128223955.464556-1-kei...@keithp.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200128223955.464556-1-kei...@keithp.com Subject: [PATCH] riscv: Separate FPU register

[PATCH] riscv: Separate FPU register size from core register size in gdbstub

2020-01-28 Thread Keith Packard via
The size of the FPU registers is dictated by the 'f' and 'd' features, not the core processor register size. Processors with the 'd' feature have 64-bit FPU registers. Processors without the 'd' feature but with the 'f' feature have 32-bit FPU registers. Signed-off-by: Keith Packard ---

Re: [PATCH v3 13/14] dp8393x: Don't reset Silicon Revision register

2020-01-28 Thread Finn Thain
On Tue, 28 Jan 2020, Philippe Mathieu-Daud? wrote: > On 1/19/20 11:59 PM, Finn Thain wrote: > > The jazzsonic driver in Linux uses the Silicon Revision register value > > to probe the chip. The driver fails unless the SR register contains 4. > > Unfortunately, reading this register in QEMU

Re: python3 script header and rhel8

2020-01-28 Thread John Snow
On 1/28/20 11:07 AM, Daniel P. Berrangé wrote: > On Tue, Jan 28, 2020 at 03:44:04PM +, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Hmm Qemu dropped support for python2, and anyway python2 is not supported >> now at all. >> >> Still, we have a lot of "#!/usr/bin/env python"

Re: [PATCH v3 16/18] hw/i386: Introduce EPYC mode function handlers

2020-01-28 Thread Babu Moger
On 1/28/20 2:04 PM, Eduardo Habkost wrote: > Hi, > > Sorry for taking so long. I was away from the office for a > month, and now I'm finally back. no worries. > > On Tue, Dec 03, 2019 at 06:38:46PM -0600, Babu Moger wrote: >> Introduce following handlers for new epyc mode. >>

[Bug 1856724] Re: SB.PCI0.SMB0 device drivers unavailable

2020-01-28 Thread Rafal Kupiec
Any progress? When will you provide a Windows driver for this and/or ability to disable this device in Qemu? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1856724 Title: SB.PCI0.SMB0 device

Re: [GSoC/Outreachy QEMU proposal] Extend support for ioctls in QEMU linux-user mode

2020-01-28 Thread Aleksandar Markovic
On Tue, Jan 28, 2020 at 7:00 PM Peter Maydell wrote: > On Tue, 28 Jan 2020 at 17:51, Aleksandar Markovic > wrote: > > > > I am personally interested in both. However, learning about syscalls and > implementation of support for them in QEMU would require more ramp-up time > from student (as is

Re: [PATCH v4 7/7] tests/boot_linux_console: Tag Emcraft Smartfusion2 as running 'u-boot'

2020-01-28 Thread Wainer dos Santos Moschetta
On 1/27/20 2:05 PM, Thomas Huth wrote: On 21/01/2020 00.51, Philippe Mathieu-Daudé wrote: Avocado tags are handy to automatically select tests matching the tags. Since this test also runs U-Boot, tag it. We can run all the tests using U-Boot as once with: $ avocado --show=app run -t

[PULL 4/6] hw/core/loader: Let load_elf() populate the processor-specific flags

2020-01-28 Thread Aleksandar Markovic
From: Philippe Mathieu-Daudé While loading the executable, some platforms (like AVR) need to determine CPU type that executable is built for by reading the field 'e_flags' of the ELF header of tha executable. This patch enables such discovery of that field while using any of the following

[PULL 2/6] disas: Add a field for target-dependant data

2020-01-28 Thread Aleksandar Markovic
From: Aleksandar Markovic This patch adds a field "target_info" to the structure disassemble_info. The purpose of this field is to enable targets to pass to disassembler code any additional data thet deem suitable. Reviewed-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Message-Id:

[PULL 3/6] mips-semi.c: remove 'uhi_done' label in helper_do_semihosting()

2020-01-28 Thread Aleksandar Markovic
From: Daniel Henrique Barboza The label 'uhi_done' is a simple 'return' call and can be removed for a bit more clarity in the code. CC: Aurelien Jarno CC: Aleksandar Markovic CC: Aleksandar Rikalo Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Signed-off-by: Daniel

[PULL 5/6] target/mips: Amend CP0 WatchHi register implementation

2020-01-28 Thread Aleksandar Markovic
From: Yongbok Kim WatchHi is extended by the field MemoryMapID with the GINVT instruction. The field is accessible by MTHC0/MFHC0 in 32-bit architectures and DMTC0/ DMFC0 in 64-bit architectures. Reviewed-by: Aleksandar Rikalo Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic

[PULL 6/6] target/mips: Add implementation of GINVT instruction

2020-01-28 Thread Aleksandar Markovic
From: Yongbok Kim Implement emulation of GINVT instruction. As QEMU doesn't support caches and virtualization, this implementation covers only one instruction (GINVT - Global Invalidate TLB) among all TLB-related MIPS instructions. Reviewed-by: Aleksandar Rikalo Signed-off-by: Yongbok Kim

[PULL 0/6] MIPS queue for January 28th, 2020

2020-01-28 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit 4c60e3289875ae6c516a37523bcecb87f68ce67c: Merge remote-tracking branch 'remotes/rth/tags/pull-pa-20200127' into staging (2020-01-28 15:11:04 +) are available in the git repository at: https://github.com/AMarkovic/qemu

[PULL 1/6] target/mips: Rectify documentation on deprecating r4k machine

2020-01-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Change the documented (in file qemu-deprecated.texi) release since r4k machine is deprecated from 4.2 to 5.0. Fixes: d32dc61421b Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic Message-Id:

Re: [PATCH v4 5/7] tests/boot_linux_console: Test booting U-Boot on the Raspberry Pi 2

2020-01-28 Thread Wainer dos Santos Moschetta
On 1/20/20 9:51 PM, Philippe Mathieu-Daudé wrote: This test runs U-Boot on the Raspberry Pi 2. It is very simple and fast: $ avocado --show=app,console run -t raspi2 -t u-boot tests/acceptance/ JOB LOG: avocado/job-results/job-2020-01-20T23.40-2424777/job.log (1/1)

Re: [PATCH v3 07/18] machine: Add a new function init_apicid_fn in MachineClass

2020-01-28 Thread Eduardo Habkost
On Tue, Jan 28, 2020 at 01:45:31PM -0600, Babu Moger wrote: > > > On 1/28/20 10:29 AM, Igor Mammedov wrote: > > On Tue, 03 Dec 2019 18:37:42 -0600 > > Babu Moger wrote: > > > >> Add a new function init_apicid_fn in MachineClass to initialize the mode > >> specific handlers to decode the apic

Re: [PATCH v4 6/7] tests/boot_linux_console: Test booting U-Boot on the Raspberry Pi 3

2020-01-28 Thread Wainer dos Santos Moschetta
On 1/20/20 9:51 PM, Philippe Mathieu-Daudé wrote: This test runs U-Boot on the Raspberry Pi 3. It is very simple and fast: $ avocado --show=app,console run -t raspi3 -t u-boot tests/acceptance/ JOB LOG: avocado/job-results/job-2020-01-20T23.40-2424777/job.log (1/1)

Re: [PATCH v3 08/13] monitor/hmp: move hmp_nbd_server* to block-hmp-cmds.c

2020-01-28 Thread Eric Blake
On 1/28/20 12:56 PM, Dr. David Alan Gilbert wrote: * Maxim Levitsky (mlevi...@redhat.com) wrote: Signed-off-by: Maxim Levitsky Yes, I think that's OK; I can imagine nbd might want to move on it's own somewhere since it's not really core block code; copying in Eric. I think that

Re: [PATCH v3 16/18] hw/i386: Introduce EPYC mode function handlers

2020-01-28 Thread Eduardo Habkost
Hi, Sorry for taking so long. I was away from the office for a month, and now I'm finally back. On Tue, Dec 03, 2019 at 06:38:46PM -0600, Babu Moger wrote: > Introduce following handlers for new epyc mode. > x86_apicid_from_cpu_idx_epyc: Generate apicid from cpu index. >

Re: [PATCH v4 3/7] Acceptance tests: Add interrupt_interactive_console_until_pattern()

2020-01-28 Thread Wainer dos Santos Moschetta
On 1/20/20 9:51 PM, Philippe Mathieu-Daudé wrote: We need a function to interrupt interactive consoles. Example: Interrupt U-Boot to set different environment values. Tested-by: Niek Linnenbank Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 32

Re: [PATCH v4 2/7] Acceptance tests: Extract _console_interaction()

2020-01-28 Thread Wainer dos Santos Moschetta
On 1/28/20 5:34 PM, Wainer dos Santos Moschetta wrote: On 1/20/20 9:51 PM, Philippe Mathieu-Daudé wrote: Since we are going to re-use the code shared between wait_for_console_pattern() and exec_command_and_wait_for_pattern(), extract the common part into a local function. Tested-by: Niek

Re: [PATCH v3 11/13] monitor: Move hmp_drive_add_node to block-hmp-cmds.c

2020-01-28 Thread Maxim Levitsky
On Tue, 2020-01-28 at 19:03 +, Dr. David Alan Gilbert wrote: > * Maxim Levitsky (mlevi...@redhat.com) wrote: > > Signed-off-by: Maxim Levitsky > > Looks OK to me, I'm not clear on the name for 'bdrv_set_monitor_owned' > I'd want a block person to OK that, but: The name inspiration came

Re: [PATCH v3 03/13] monitor/hmp: rename device-hotplug.c to block/monitor/block-hmp-cmds.c

2020-01-28 Thread Maxim Levitsky
On Tue, 2020-01-28 at 16:56 +, Dr. David Alan Gilbert wrote: > * Maxim Levitsky (mlevi...@redhat.com) wrote: > > These days device-hotplug.c only contains the hmp_drive_add > > In the next patch, rest of hmp_drive* functions will be moved > > there. > > > > Also change the license of that

Re: [PATCH 9/9] monitor/hmp: Prefer to use hmp_handle_error for error reporting in block hmp commands

2020-01-28 Thread Dr. David Alan Gilbert
* Maxim Levitsky (mlevi...@redhat.com) wrote: > On Mon, 2020-01-27 at 14:44 +0100, Markus Armbruster wrote: > > Maxim Levitsky writes: > > > > > On Wed, 2019-11-27 at 09:38 +0100, Markus Armbruster wrote: > > > > Title is too long. blockdev-hmp-cmds.c will become > > > >

Re: [PATCH rc3 23/30] hw/core/loader: Let load_elf populate the processor-specific flags

2020-01-28 Thread Aleksandar Markovic
On Tue, Jan 28, 2020 at 2:27 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Tuesday, January 28, 2020, BALATON Zoltan wrote: > >> On Tue, 28 Jan 2020, Aleksandar Markovic wrote: >> >>> On Sunday, January 26, 2020, Aleksandar Markovic < >>> aleksandar.marko...@rt-rk.com>

Re: [PATCH v3 11/13] monitor: Move hmp_drive_add_node to block-hmp-cmds.c

2020-01-28 Thread Dr. David Alan Gilbert
* Maxim Levitsky (mlevi...@redhat.com) wrote: > Signed-off-by: Maxim Levitsky Looks OK to me, I'm not clear on the name for 'bdrv_set_monitor_owned' I'd want a block person to OK that, but: Reviewed-by: Dr. David Alan Gilbert > --- > block/monitor/block-hmp-cmds.c | 30

Re: [PATCH v3 12/13] add 'error' prefix to vreport

2020-01-28 Thread Maxim Levitsky
On Mon, 2020-01-27 at 12:36 +0200, Maxim Levitsky wrote: > This changes most of qemu's error messages, > but it feels like the right thing to do. > > This is WIP patch, since I updated most of iotests but not all of them, > and will be updated if this patch is accepeted in the review. > Also few

Re: [PATCH v3 07/18] machine: Add a new function init_apicid_fn in MachineClass

2020-01-28 Thread Babu Moger
On 1/28/20 10:29 AM, Igor Mammedov wrote: > On Tue, 03 Dec 2019 18:37:42 -0600 > Babu Moger wrote: > >> Add a new function init_apicid_fn in MachineClass to initialize the mode >> specific handlers to decode the apic ids. >> >> Signed-off-by: Babu Moger >> --- >> include/hw/boards.h |1

Re: [PATCH v3 08/13] monitor/hmp: move hmp_nbd_server* to block-hmp-cmds.c

2020-01-28 Thread Dr. David Alan Gilbert
* Maxim Levitsky (mlevi...@redhat.com) wrote: > Signed-off-by: Maxim Levitsky Yes, I think that's OK; I can imagine nbd might want to move on it's own somewhere since it's not really core block code; copying in Eric. Reviewed-by: Dr. David Alan Gilbert > --- > block/monitor/block-hmp-cmds.c

Re: [PATCH v3 07/13] monitor/hmp: move hmp_snapshot_* to block-hmp-cmds.c

2020-01-28 Thread Dr. David Alan Gilbert
* Maxim Levitsky (mlevi...@redhat.com) wrote: > Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert > --- > block/monitor/block-hmp-cmds.c | 47 ++ > include/block/block-hmp-commands.h | 4 +++ > include/monitor/hmp.h | 3 -- >

Re: [PATCH v3 09/13] monitor/hmp: move remaining hmp_block* functions to block-hmp-cmds.c

2020-01-28 Thread Dr. David Alan Gilbert
* Maxim Levitsky (mlevi...@redhat.com) wrote: > Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert > --- > block/monitor/block-hmp-cmds.c | 138 + > include/block/block-hmp-commands.h | 9 ++ > include/monitor/hmp.h | 6 -- >

  1   2   3   4   5   >