[PATCH v3] virtio: increase virtqueue size for virtio-scsi and virtio-blk

2020-02-13 Thread Denis Plotnikov
The goal is to reduce the amount of requests issued by a guest on 1M reads/writes. This rises the performance up to 4% on that kind of disk access pattern. The maximum chunk size to be used for the guest disk accessing is limited with seg_max parameter, which represents the max amount of pices in

RE: [RFC 2/2] pci-expender-bus:Add pcie-root-port to pxb-pcie under arm.

2020-02-13 Thread miaoyubo
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, February 13, 2020 6:17 PM > To: miaoyubo > Cc: peter.mayd...@linaro.org; shannon.zha...@gmail.com; Xiexiangyou > ; imamm...@redhat.com; qemu- > de...@nongnu.org > Subject: Re: [RFC 2/2] pci-expende

RE: [RFC 1/2] arm: acpi: pci-expender-bus: Make arm to support PXB-PCIE

2020-02-13 Thread miaoyubo
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Thursday, February 13, 2020 6:23 PM > To: miaoyubo > Cc: peter.mayd...@linaro.org; shannon.zha...@gmail.com; Xiexiangyou > ; imamm...@redhat.com; qemu- > de...@nongnu.org > Subject: Re: [RFC 1/2] arm: acpi:

RE: [RFC 2/2] pci-expender-bus:Add pcie-root-port to pxb-pcie under arm.

2020-02-13 Thread miaoyubo
> -Original Message- > From: Daniel P. Berrangé [mailto:berra...@redhat.com] > Sent: Thursday, February 13, 2020 9:52 PM > To: miaoyubo > Cc: peter.mayd...@linaro.org; shannon.zha...@gmail.com; > imamm...@redhat.com; qemu-devel@nongnu.org; Xiexiangyou > ; m...@redhat.com > Subject: Re: [R

[PATCH 3/3] hw/riscv/spike: Allow more than one CPUs

2020-02-13 Thread Anup Patel
Currently, the upstream Spike ISA simulator allows more than one CPUs so we update QEMU Spike machine on similar lines to allow more than one CPUs. The maximum number of CPUs for QEMU Spike machine is kept same as QEMU Virt machine. Signed-off-by: Anup Patel --- hw/riscv/spike.c | 2 +- 1 file

[PATCH 1/3] hw/riscv: Add optional symbol callback ptr to riscv_load_firmware()

2020-02-13 Thread Anup Patel
This patch adds an optional function pointer, "sym_cb", to riscv_load_firmware() which provides the possibility to access the symbol table during kernel loading. The pointer is ignored, if supplied with flat (non-elf) firmware image. The Spike board requires it locate the HTIF symbols from firmwa

[PATCH 0/3] RISC-V Spike machine improvements

2020-02-13 Thread Anup Patel
This series improves QEMU Spike machine to: 1. Allow loading OpenBI firmware using -bios option 2. Allow more than one CPUs Anup Patel (3): hw/riscv: Add optional symbol callback ptr to riscv_load_firmware() hw/riscv/spike: Allow loading firmware separately using -bios option hw/riscv/spike:

[PATCH 2/3] hw/riscv/spike: Allow loading firmware separately using -bios option

2020-02-13 Thread Anup Patel
This patch extends Spike machine support to allow loading OpenSBI firmware (fw_jump.elf) separately using -bios option. Signed-off-by: Anup Patel --- hw/riscv/spike.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c

Re: [PATCH v2 18/30] qapi: Delete all the "foo: dropped in n.n" notes

2020-02-13 Thread Markus Armbruster
Peter Maydell writes: > A handful of QAPI doc comments include lines like > "ppcemb: dropped in 3.1". The doc comment parser will just > put these into whatever the preceding section was; sometimes > that's "Notes", and sometimes it's some random other section, > as with "NetClientDriver" where t

Re: [PATCH v2 01/30] configure: Allow user to specify sphinx-build binary

2020-02-13 Thread Markus Armbruster
Does not work out of the box on my Fedora 30 build host, where sphinx-build gives me sphinx-build-2. I have to specify --sphinx-build=/usr/bin/sphinx-build-3 to unbreak it. Which of course breaks things when I try to build anything before this commit The appended patch makes it work out of the b

Re: [RESEND RFC PATCH v2 2/2] target/arm: Support NMI injection

2020-02-13 Thread Gavin Shan
On 2/13/20 10:11 PM, Peter Maydell wrote: On Wed, 5 Feb 2020 at 11:06, Gavin Shan wrote: This supports QMP/HMP "nmi" command by injecting SError interrupt to guest, which is expected to crash with that. Currently, It's supported on two CPU models: "host" and "max". Signed-off-by: Gavin Shan

[PATCH 3/3] arm: allwinner: Wire up USB EHCI

2020-02-13 Thread Guenter Roeck
Initialize EHCI controllers on Allwinner A10. With this patch applied, USB EHCI ports are discovered when booting the cubieboard machine with a recent Linux kernel. ehci-platform 1c14000.usb: EHCI Host Controller ehci-platform 1c14000.usb: new USB bus registered, assigned bus number 1 ehci-platfor

[PATCH 1/3] hw: usb: hcd-ohci: Move OHCISysBusState and TYPE_SYSBUS_OHCI to include file

2020-02-13 Thread Guenter Roeck
We need to be able to use OHCISysBusState outside hcd-ohci.c, so move it to its include file. Signed-off-by: Guenter Roeck --- hw/usb/hcd-ohci.c | 15 --- hw/usb/hcd-ohci.h | 16 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/hw/usb/hcd-ohci.c b/hw/

[PATCH 2/3] arm: allwinner: Wire up USB OHCI

2020-02-13 Thread Guenter Roeck
Initialize OHCI controllers on Allwinner A10. With this patch applied, USB OHCI ports are discovered when booting the cubieboard machine with a recent Linux kernel. ohci-platform 1c14400.usb: Generic Platform OHCI controller ohci-platform 1c14400.usb: new USB bus registered, assigned bus number 3

[PATCH 2/2] hw/usb/hcd-ehci-sysbus: Remove obsolete xlnx, ps7-usb class

2020-02-13 Thread Guenter Roeck
Xilinx USB devices are now instantiated through TYPE_CHIPIDEA, and xlnx support in the EHCI code is no longer needed. Signed-off-by: Guenter Roeck --- hw/usb/hcd-ehci-sysbus.c | 17 - 1 file changed, 17 deletions(-) diff --git a/hw/usb/hcd-ehci-sysbus.c b/hw/usb/hcd-ehci-sysbus.

[PATCH 1/2] hw/arm/xilinx_zynq: Fix USB port instantiation

2020-02-13 Thread Guenter Roeck
USB ports must be instantiated as TYPE_CHIPIDEA to work. Linux expects and checks various chipidea registers, which do not exist with the basic ehci emulation. Without this patch, USB ports fail to instantiate under Linux. ci_hdrc ci_hdrc.0: doesn't support host ci_hdrc ci_hdrc.0: no supported ro

[PATCH v3 1/2] target/arm: Support SError injection

2020-02-13 Thread Gavin Shan
This supports SError injection, which will be used by "virt" board to simulating the behavior of NMI injection in next patch. As Peter Maydell suggested, this adds a new interrupt (ARM_CPU_SERROR), which is parallel to CPU_INTERRUPT_HARD. The backend depends on if kvm is enabled or not. kvm_vcpu_io

[PATCH v3 2/2] hw/arm/virt: Simulate NMI injection

2020-02-13 Thread Gavin Shan
This implements the backend to support HMP/QMP "nmi" command, which is used to inject NMI interrupt to crash guest for debugging purpose. As ARM architecture doesn't have NMI supported, so we're simulating the behaviour by injecting SError or data abort to guest for "virt" board. An additonal IRQ

[PATCH v3 0/2] hw/arm/virt: Simulate NMI Injection

2020-02-13 Thread Gavin Shan
This series simulates the behavior of receiving NMI interrupt for "virt" board. First of all, a new interrupt (SError) is supported for each CPU. The backend is either sending error events through kvm module or emulating the bahavior when TCG is enabled. The outcome is SError or data abort is raise

Re: [RFC v3 03/25] hw/iommu: introduce IOMMUContext

2020-02-13 Thread David Gibson
On Wed, Feb 12, 2020 at 07:15:13AM +, Liu, Yi L wrote: > Hi Peter, > > > From: Peter Xu > > Sent: Wednesday, February 12, 2020 12:59 AM > > To: Liu, Yi L > > Subject: Re: [RFC v3 03/25] hw/iommu: introduce IOMMUContext > > > > On Fri, Jan 31, 2020 at 11:42:13AM +, Liu, Yi L wrote: > > >

Re: VW ELF loader

2020-02-13 Thread David Gibson
On Mon, Feb 10, 2020 at 12:26:07PM +0100, Paolo Bonzini wrote: > On 10/02/20 08:28, David Gibson wrote: > > On Thu, Feb 06, 2020 at 09:27:01AM +0100, Paolo Bonzini wrote: > >> On 05/02/20 07:06, David Gibson wrote: > >>> On Tue, Feb 04, 2020 at 12:26:32AM +0100, Paolo Bonzini wrote: > >> I'm really

[Bug 1863200] [NEW] Reconnect failed with loopback virtio1.1 server mode test

2020-02-13 Thread xuan
Public bug reported: Issue discription: Packed ring server mode is a new feature to enable the virtio-user or virtio-pmd(in VM) as the server, vhost as the client, then when the vhost-user is killed then re-launched, the vhost-user can connect back to virtio-user/virtio-pmd again. Test with dpd

[PATCH] migration/throttle: Make throttle slower at tail stage

2020-02-13 Thread Keqian Zhu
At the tail stage of throttle, VM is very sensitive to CPU percentage. We just throttle 30% of remaining CPU when throttle is more than 80 percentage. This doesn't conflict with cpu_throttle_increment. This may make migration time longer, and is disabled by default. Signed-off-by: Keqian Zhu --

Re: VW ELF loader

2020-02-13 Thread David Gibson
On Fri, Feb 14, 2020 at 11:01:26AM +1100, Alexey Kardashevskiy wrote: > > > On 13/02/2020 21:17, Paolo Bonzini wrote: > > On 13/02/20 02:43, Alexey Kardashevskiy wrote: > >> > >> Ok. So, I have made a small firmware which does OF CI, loads GRUB and > >> instantiates RTAS: > >> https://github.com/

Re: VW ELF loader

2020-02-13 Thread David Gibson
On Mon, Feb 10, 2020 at 12:25:39PM +0100, Paolo Bonzini wrote: > On 10/02/20 08:30, David Gibson wrote: > >> Anything you put in the host is potential attack surface. > > Ok, it is attack surface you're concerned about. That wasn't totally > > clear before this point. > > Part that, part having t

[PATCH] ppc: free 'fdt' after reset the machine

2020-02-13 Thread pannengyuan
From: Pan Nengyuan 'fdt' forgot to clean both e500 and pnv when we call 'system_reset' on ppc, this patch fix it. The leak stacks are as follow: Direct leak of 4194304 byte(s) in 4 object(s) allocated from: #0 0x7fafe37dd970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970) #1 0x7faf

Re: [PATCH v2 1/5] vhost-user block device backend

2020-02-13 Thread Coiby Xu
Thank you for reviewing this patch! I'm already posted v3 based on your feedback. > > +#include "hw/qdev-properties.h" > > +enum { > > +VHOST_USER_BLK_MAX_QUEUES = 8, > > +}; > The number of queues is hardcoded to 1 so this constant can be removed for now. > > + > > +static QTAILQ_HEAD(, Vub

Re: [PATCH 3/3] spapr: Migrate SpaprDrc::unplug_requested

2020-02-13 Thread David Gibson
On Mon, Feb 03, 2020 at 11:36:22PM +0100, Greg Kurz wrote: > Hot unplugging a device is an asynchronous operation. If the guest is > migrated after the event was sent but before it could release the > device with RTAS, the destination QEMU doesn't know about the pending > unplug operation and doesn

Re: [PATCH 0/3] spapr: Fix device unplug vs CAS or migration

2020-02-13 Thread David Gibson
On Thu, Feb 13, 2020 at 04:10:55PM +0100, Greg Kurz wrote: > Ping ? > > This series fixes actual bugs. Also, I have another patch on top of > that to cold plug (or remove) devices pending hot plug (or unplug) > before CAS, hence removing the need for CAS reboot in these cases. > This requires SLOF

Re: [RESEND RFC PATCH v2 1/2] target/arm: Allow to inject SError interrupt

2020-02-13 Thread Gavin Shan
On 2/13/20 9:31 PM, Peter Maydell wrote: On Thu, 13 Feb 2020 at 03:49, Gavin Shan wrote: On 2/12/20 10:34 PM, Peter Maydell wrote: Yeah, this is on my list to look at; Richard Henderson also could have a look at it. From a quick scan I suspect you may be missing handling for AArch32. Yes, t

Re: [PATCH v2 14/19] target/riscv: progressively load the instruction during decode

2020-02-13 Thread Alistair Francis
On Thu, Feb 13, 2020 at 3:08 PM Alex Bennée wrote: > > The plugin system would throw up a harmless warning when it detected > that a disassembly of an instruction didn't use all it's bytes. Fix > the riscv decoder to only load the instruction bytes it needs as it > needs them. > > This drops opcod

Re: [PATCH v2 11/19] plugins/core: add missing break in cb_to_tcg_flags

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 11:51 PM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Reported-by: Robert Henry > Signed-off-by: Emilio G. Cota > Signed-off-by: Alex Bennée > Reviewed-by: Richard Henderson > Message-Id: <20200105072940.32204-1-c...@braap.org> Fixes: 54cb65d8588 Reviewed-by: Philippe Mathieu

Re: [PATCH v2 18/19] tests/tcg: fix typo in configure.sh test for v8.3

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 11:51 PM, Alex Bennée wrote: > Although most people use the docker images this can trip up on > developer systems with actual valid cross-compilers! > Oops =) Fixes: bb516dfc5b3 Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Alex Bennée > --- > tests/tcg/configure.sh | 2 +-

Re: [PATCH v2 16/19] tests/tcg: give debug builds a little bit longer

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 11:51 PM, Alex Bennée wrote: > When combined with heavy plugins we occasionally hit the timeouts. > > Signed-off-by: Alex Bennée > --- > tests/tcg/Makefile.target | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefi

[PATCH] hw/net/i82596: Correct command bitmask (CID 1419392)

2020-02-13 Thread Philippe Mathieu-Daudé
The command is 32-bit, but we are loading the 16 upper bits with the 'get_uint16(s->scb + 2)' call. Once shifted by 16, the command bits match the status bits: - Command Bit 31 ACK-CX Acknowledges that the CU completed an Action Command. Bit 30 ACK-FR Acknowledges that the RU received a f

Re: [PATCH] target/ppc: Fix typo in comments

2020-02-13 Thread David Gibson
On Fri, Feb 14, 2020 at 12:57:34AM +0100, BALATON Zoltan wrote: > "Deferred" was misspelled as "differed" in some comments, correct this > typo, > > Signed-off-by: BALATON Zoltan Applied to ppc-for-5.0, thanks. > --- > target/ppc/fpu_helper.c| 2 +- > target/ppc/translate/fp-impl.i

Re: [PATCH] target/ppc: Fix typo in comments

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/14/20 12:57 AM, BALATON Zoltan wrote: > "Deferred" was misspelled as "differed" in some comments, correct this > typo, > Fixes: 7c58044c Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: BALATON Zoltan > --- > target/ppc/fpu_helper.c| 2 +- > target/ppc/translate/fp-impl.i

[PATCH 3/5] hw/display/artist: Delay some variables initialization

2020-02-13 Thread Philippe Mathieu-Daudé
We want to have an early exit path. Delay some initializations before the variables are used. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/artist.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index 47f0e9f0bc..9

[RFC PATCH 4/5] hw/display/artist: Avoid drawing line when nothing to display

2020-02-13 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- RFC because untested =) --- hw/display/artist.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/artist.c b/hw/display/artist.c index 97c811b35e..5492079116 100644 --- a/hw/display/artist.c +++ b/hw/display/artist.c @@ -557,90 +557,93 @@

[PATCH 5/5] hw/display/artist: Remove dead code (CID 1419388 & 1419389)

2020-02-13 Thread Philippe Mathieu-Daudé
Coverity reports: *** CID 1419388: Control flow issues (DEADCODE) /hw/display/artist.c: 739 in draw_line_xy() 733 if (endy < 0) { 734 endy = 0; 735 } 736 737 738 if (endx < 0) { >>> CID 1419388: Control flow issues (DEADCODE) >>>

[PATCH 2/5] hw/display/artist: Remove pointless initialization

2020-02-13 Thread Philippe Mathieu-Daudé
We are initializating incy inconditionally: if (y1 <= y2) { incy = 1; } else { incy = -1; } Signed-off-by: Philippe Mathieu-Daudé --- hw/display/artist.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index abacb0e27d..47

[PATCH 0/5] hw/display/artist: Fix Coverity 1419388 & 1419389

2020-02-13 Thread Philippe Mathieu-Daudé
Another easy Coverity fix. Philippe Mathieu-Daudé (5): hw/display/artist: Move trace event to draw_line() hw/display/artist: Remove pointless initialization hw/display/artist: Delay some variables initialization hw/display/artist: Avoid drawing line when nothing to display hw/display/art

[PATCH 1/5] hw/display/artist: Move trace event to draw_line()

2020-02-13 Thread Philippe Mathieu-Daudé
Instead of emitting the trace event before each call to draw_line(), call it once at draw_line() entrance. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/artist.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index 65be9e

Re: VW ELF loader

2020-02-13 Thread Alexey Kardashevskiy
On 13/02/2020 21:17, Paolo Bonzini wrote: > On 13/02/20 02:43, Alexey Kardashevskiy wrote: >> >> Ok. So, I have made a small firmware which does OF CI, loads GRUB and >> instantiates RTAS: >> https://github.com/aik/of1275 >> Quite raw but gives the idea. >> >> It does not contain drivers and sti

[PATCH] target/ppc: Fix typo in comments

2020-02-13 Thread BALATON Zoltan
"Deferred" was misspelled as "differed" in some comments, correct this typo, Signed-off-by: BALATON Zoltan --- target/ppc/fpu_helper.c| 2 +- target/ppc/translate/fp-impl.inc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/ppc/fpu_helper.c b/target

[PATCH 2/4] hw/hppa/dino: Fix reg800_keep_bits[] overrun (CID 1419393 & 1419394)

2020-02-13 Thread Philippe Mathieu-Daudé
Coverity reports: *** CID 1419393: Memory - corruptions (OVERRUN) /hw/hppa/dino.c: 363 in dino_chip_write_with_attrs() 357 /* These registers are read-only. */ 358 break; 359 360 case DINO_GMASK ... DINO_TLTIM: 361 i = (addr - DINO_GMASK

[PATCH 1/4] hw/hppa/dino: Add comments with register name

2020-02-13 Thread Philippe Mathieu-Daudé
Add a comment with the name of each register in the 0x800-0x833 range. Signed-off-by: Philippe Mathieu-Daudé --- hw/hppa/dino.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c index 9797a7f0d9..c237ad3b1b 100644 --- a

[RFC PATCH 4/4] hw/hppa/dino: Do not accept accesses to registers 0x818 and 0x82c

2020-02-13 Thread Philippe Mathieu-Daudé
Register 0x818 is documented as 'undefined', and register 0x82c is not documented. Refuse their access. Signed-off-by: Philippe Mathieu-Daudé --- hw/hppa/dino.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c index be799aad43..2b1b38c58a 100

[RFC PATCH 3/4] hw/hppa/dino: Fix PCIROR register access bitmask

2020-02-13 Thread Philippe Mathieu-Daudé
Only 24 bits of the PCIROR register are documented (see pp. 37 of datasheet referenced in this file header). Signed-off-by: Philippe Mathieu-Daudé --- hw/hppa/dino.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c index 8868e31793..be799aad43 1

[PATCH 0/4] hw/hppa/dino: Fix Coverity 1419393 & 1419394

2020-02-13 Thread Philippe Mathieu-Daudé
Easy fix for the overrun reported by Coverity. Last 2 patches are RFC because I haven't tested them, I simply took note while reviewing the datasheet (I also checked the errata). Philippe Mathieu-Daudé (4): hw/hppa/dino: Add comments with register name hw/hppa/dino: Fix reg800_keep_bits[] ove

Re: [PATCH v12 Kernel 4/7] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2020-02-13 Thread Alex Williamson
On Fri, 14 Feb 2020 01:41:35 +0530 Kirti Wankhede wrote: > > > > +static int vfio_iova_dirty_bitmap(struct vfio_iommu *iommu, dma_addr_t > iova, > + size_t size, uint64_t pgsize, > + unsigned char __

Re: [PATCH v2 00/19] testing and plugin updates

2020-02-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200213225109.13120-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 00/19] testing and plugin updates Message-id: 20200213225109.13120-1-alex.ben...@linaro.org

[PATCH v2 19/19] tests/tcg: take into account expected clashes pauth-4

2020-02-13 Thread Alex Bennée
Pointer authentication isn't perfect so measure the percentage of failed checks. As we want to vary the pointer that is authenticated we recurse down the stack. Signed-off-by: Alex Bennée --- tests/tcg/aarch64/pauth-4.c | 54 + 1 file changed, 37 insertions(+)

[PATCH v2 14/19] target/riscv: progressively load the instruction during decode

2020-02-13 Thread Alex Bennée
The plugin system would throw up a harmless warning when it detected that a disassembly of an instruction didn't use all it's bytes. Fix the riscv decoder to only load the instruction bytes it needs as it needs them. This drops opcode from the ctx in favour if passing the appropriately sized opcod

Re: [PATCH v2 1/2] spapr: Disable legacy virtio devices for pseries-5.0 and later

2020-02-13 Thread David Gibson
On Thu, Feb 13, 2020 at 03:34:25PM +0100, Greg Kurz wrote: > On Thu, 13 Feb 2020 11:58:36 +1100 > David Gibson wrote: > > > PAPR specifies a kind of odd, paravirtualized PCI bus, which looks to > > the guess mostly like classic PCI, even if some of the individual > > devices on the bus are PCI Ex

[PATCH v2 16/19] tests/tcg: give debug builds a little bit longer

2020-02-13 Thread Alex Bennée
When combined with heavy plugins we occasionally hit the timeouts. Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index 3c7421a356e..b3cff3cad1a 100644 --- a/te

Re: [PATCH v5 1/6] hw/hppa/dino.c: Improve emulation of Dino PCI chip

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 12:37 AM, Philippe Mathieu-Daudé wrote: > Hi Sven, Helge. > > On 12/20/19 10:15 PM, Sven Schnelle wrote: >> From: Helge Deller >> >> The tests of the dino chip with the Online-diagnostics CD >> ("ODE DINOTEST") now succeeds. >> Additionally add some qemu trace events. >> >> Signed-off-

Re: [PATCH v2 07/30] qapi/block-core.json: Use literal block for ascii art

2020-02-13 Thread Aleksandar Markovic
6:59 PM Čet, 13.02.2020. Peter Maydell је написао/ла: > > The ascii-art graph Just out of couriousity, are unicode characters allowed in rst files? The boxes could've been rendered in a much more beautifull way using "lines and corners" group of unicode characters. Aleksandar > in the BlockLat

[PATCH v2 17/19] tcg: save vaddr temp for plugin usage

2020-02-13 Thread Alex Bennée
From: Richard Henderson While do_gen_mem_cb does copy (via extu_tl_i64) vaddr into a new temp this won't help if the vaddr temp gets clobbered by the actual load/store op. To avoid this clobbering we explicitly copy vaddr before the op to ensure it is live my the time we do the instrumentation.

[PATCH v2 12/19] tests/plugin: prevent uninitialized warning

2020-02-13 Thread Alex Bennée
From: Chen Qun According to the glibc function requirements, we need initialise the variable. Otherwise there will be compilation warnings: glib-autocleanups.h:28:3: warning: ‘out’ may be used uninitialized in this function [-Wmaybe-uninitialized] g_free (*pp); ^~~~ Reported-by:

[PATCH v2 15/19] tests/plugins: make howvec clean-up after itself.

2020-02-13 Thread Alex Bennée
TCG plugins are responsible for their own memory usage and although the plugin_exit is tied to the end of execution in this case it is still poor practice. Ensure we delete the hash table and related data when we are done to be a good plugin citizen. Signed-off-by: Alex Bennée Reviewed-by: Robert

Re: [PATCH v2 0/2] spapr: Use vIOMMU translation for virtio by default

2020-02-13 Thread David Gibson
On Thu, Feb 13, 2020 at 12:46:43PM +0100, Greg Kurz wrote: > On Thu, 13 Feb 2020 11:58:35 +1100 > David Gibson wrote: > > > Upcoming Secure VM support for pSeries machines introduces some > > complications for virtio, since the transfer buffers need to be > > explicitly shared so that the hypervi

[PATCH v2 18/19] tests/tcg: fix typo in configure.sh test for v8.3

2020-02-13 Thread Alex Bennée
Although most people use the docker images this can trip up on developer systems with actual valid cross-compilers! Signed-off-by: Alex Bennée --- tests/tcg/configure.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index 9eb6

[PATCH v2 09/19] tracing: only allow -trace to override -D if set

2020-02-13 Thread Alex Bennée
Otherwise any -D settings the user may have made get ignored. Signed-off-by: Alex Bennée --- trace/control.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/trace/control.c b/trace/control.c index 6c775e68eba..2ffe0008184 100644 --- a/trace/control.c +++ b/trace/c

Re: [PATCH] spapr: Rework hash<->radix transitions at CAS

2020-02-13 Thread David Gibson
On Thu, Feb 13, 2020 at 04:38:38PM +0100, Greg Kurz wrote: > Until the CAS negotiation is over, an HPT can be allocated on three > different paths: > > 1) during machine reset if the host doesn't support radix, > > 2) during CAS if the guest wants hash and doesn't support HPT resizing, >in wh

[PATCH v2 10/19] docs/devel: document query handle lifetimes

2020-02-13 Thread Alex Bennée
I forgot to document the lifetime of handles in the developer documentation. Do so now. Signed-off-by: Alex Bennée Reviewed-by: Robert Foley Reviewed-by: Robert Foley --- docs/devel/tcg-plugins.rst | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/docs/devel/tc

[PATCH v2 13/19] qemu/bitops.h: Add extract8 and extract16

2020-02-13 Thread Alex Bennée
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-10-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <2

[PATCH v2 05/19] travis.yml: Test the s390-ccw build, too

2020-02-13 Thread Alex Bennée
From: Thomas Huth Since we can now use a s390x host on Travis, we can also build and test the s390-ccw bios images there. For this we have to make sure that roms/SLOF is checked out, too, and then move the generated *.img files to the right location before running the tests. Signed-off-by: Thoma

[PATCH v2 08/19] tests/iotests: be a little more forgiving on the size test

2020-02-13 Thread Alex Bennée
At least on ZFS this was failing as 512 was less than or equal to 512. I suspect the reason is additional compression done by ZFS and however qemu-img gets the actual size. Loosen the criteria to make sure after is not bigger than before and also dump the values in the report. Signed-off-by: Alex

[PATCH v2 07/19] travis.yml: single-thread build-tcg stages

2020-02-13 Thread Alex Bennée
This still seems to be a problem for Travis. Signed-off-by: Alex Bennée --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 0612998958b..f4020dcc6c8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -400,7 +400,7 @@ jobs: - nam

[PATCH v2 03/19] tests/rcutorture: better document locking of stats

2020-02-13 Thread Alex Bennée
This is pure code motion with no functional effect. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tests/rcutorture.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/rcutorture.c b/tests/rcutorture.c index e8b2169e7dd..256d24ed5ba

[PATCH v2 11/19] plugins/core: add missing break in cb_to_tcg_flags

2020-02-13 Thread Alex Bennée
From: "Emilio G. Cota" Reported-by: Robert Henry Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20200105072940.32204-1-c...@braap.org> Cc: qemu-sta...@nongnu.org --- plugins/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/plugi

[PATCH v2 04/19] tests/rcutorture: mild documenting refactor of update thread

2020-02-13 Thread Alex Bennée
This is mainly to help with reasoning what the test is trying to do. We can move rcu_stress_idx to a local variable as there is only ever one updater thread. I've also added an assert to catch the case where we end up updating the current structure to itself which is the only way I can see the mber

[PATCH v2 06/19] travis.yml: Fix Travis YAML configuration warnings

2020-02-13 Thread Alex Bennée
From: Wainer dos Santos Moschetta This fixes the following warnings Travis has detected on the YAML configuration: - 'on root: missing os, using the default "linux"' - 'on root: the key matrix is an alias for jobs, using jobs' - 'on jobs.include.python: unexpected sequence, using the first value

[PATCH v2 01/19] tests/tcg: include a skip runner for pauth3 with plugins

2020-02-13 Thread Alex Bennée
If we have plugins enabled we still need to have built the test to be able to run it. Signed-off-by: Alex Bennée --- tests/tcg/aarch64/Makefile.softmmu-target | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/tcg/aarch64/Makefile.softmmu-target b/tests/tcg/aarch64/Makefile.softmmu-tar

[PATCH v2 02/19] tests/rcutorture: update usage hint

2020-02-13 Thread Alex Bennée
Although documented in the comments we don't display all the various invocations we can in the usage. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tests/rcutorture.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/rcutorture.c b/tests/rcutorture

[PATCH v2 00/19] testing and plugin updates

2020-02-13 Thread Alex Bennée
Hi, I've ended up combining my accumulated testing fixes with the plugin fixes as there is some cross-over between the two. On the testing side I still haven't seen rcutorture trip up on my branches but the final patch that light re-factors it needs to be reviewed. I've also added some fixes for p

Re: [PATCH v2 2/2] tests/tcg/multiarch: Add tests for implemented alsa sound timer ioctls

2020-02-13 Thread Aleksandar Markovic
3:26 PM Čet, 13.02.2020. Filip Bozuta је написао/ла: > > +int main(int argc, char **argv) > +{ > +char ioctls[15][35] = {"SNDRV_TIMER_IOCTL_PVERSION", > + "SNDRV_TIMER_IOCTL_INFO", > + "SNDRV_TIMER_IOCTL_NEXT_DEVICE", > +

Re: [PATCH] migration/postcopy: not necessary to discard all RAM at the beginning

2020-02-13 Thread Wei Yang
On Thu, Feb 13, 2020 at 10:17:04AM +, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> ram_discard_range() unmap page for specific range. To be specific, this >> clears related page table entries so that userfault would be triggered. >> But this step is not ne

[PATCH v6 5/8] multifd: Add zlib compression multifd support

2020-02-13 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Markus Armbruster --- hw/core/qdev-properties.c| 2 +- migration/Makefile.objs | 1 + migration/multifd-zlib.c | 325 +++ migration/multifd.c | 6 + migration/multifd.h | 4 + qapi/migra

[PATCH v6 6/8] configure: Enable test and libs for zstd

2020-02-13 Thread Juan Quintela
Add it to several build systems to make testing good. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- .gitlab-ci.yml| 1 + .travis.yml | 1 + configure | 30 +

[PATCH v6 4/8] multifd: Add multifd-zlib-level parameter

2020-02-13 Thread Juan Quintela
This parameter specifies the zlib compression level. The next patch will put it to use. Signed-off-by: Juan Quintela Acked-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 24 migration/migration.h | 1 + monitor/hmp-cmds.c| 4

[PATCH v6 7/8] multifd: Add multifd-zstd-level parameter

2020-02-13 Thread Juan Quintela
This parameter specifies the zstd compression level. The next patch will put it to use. Signed-off-by: Juan Quintela Acked-by: Markus Armbruster --- migration/migration.c | 24 migration/migration.h | 1 + monitor/hmp-cmds.c| 4 qapi/migration.json | 29 +++

[PATCH v6 8/8] multifd: Add zstd compression multifd support

2020-02-13 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- hw/core/qdev-properties.c| 2 +- migration/Makefile.objs | 1 + migration/multifd-zstd.c | 339 +++ migration/multifd.h | 1 + migration/r

Re: [PATCH] uapi: fix userspace breakage, use __BITS_PER_LONG for swap

2020-02-13 Thread Yury Norov
On Thu, Feb 13, 2020 at 03:21:47PM +0100, Christian Borntraeger wrote: > QEMU has a funny new build error message when I use the upstream kernel > headers: > > CC block/file-posix.o > In file included from /home/cborntra/REPOS/qemu/include/qemu/timer.h:4, > from > /home/c

[PATCH v6 3/8] multifd: Make no compression operations into its own structure

2020-02-13 Thread Juan Quintela
It will be used later. Signed-off-by: Juan Quintela --- No comp value needs to be zero. --- migration/migration.c | 9 ++ migration/migration.h | 1 + migration/multifd.c | 185 -- migration/multifd.h | 26 ++ migration/ram.c | 1 +

[PATCH v6 2/8] migration: Add support for modules

2020-02-13 Thread Juan Quintela
So we don't have to compile everything in, or have ifdefs Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/qemu/module.h | 2 ++ vl.c | 1 + 2 files changed, 3 insertions(+) diff --git a/include/qemu/module.h b/include/qemu/module.h index 65ba596e46

[PATCH v6 0/8] Multifd Migration Compression

2020-02-13 Thread Juan Quintela
Based-on: <20200213132030.57757-1-quint...@redhat.com> [v6] - rebase to latest pull request - move functions that read parameters to the parameters patechs (dave) - require zstd on travis/docker/... (please review) - rename multifd_method to multifd_compression - improve documentation Please revi

[PATCH v6 1/8] multifd: Add multifd-compression parameter

2020-02-13 Thread Juan Quintela
This will store the compression method to use. We start with none. Signed-off-by: Juan Quintela Acked-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- Rename multifd-method to multifd-compression --- hw/core/qdev-properties.c| 13 + include/hw/qdev-properties.h

Re: [PATCH v5 6/8] configure: Enable test and libs for zstd

2020-02-13 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Jan 29, 2020 at 12:56:53PM +0100, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> Reviewed-by: Dr. David Alan Gilbert >> --- >> configure | 30 ++ >> 1 file changed, 30 insertions(+) > > This is adding a new 3rd party libra

Re: [PATCH RFC] memory: Don't allow to resize RAM while migrating

2020-02-13 Thread Peter Xu
On Thu, Feb 13, 2020 at 08:42:23PM +0100, David Hildenbrand wrote: > On 13.02.20 19:32, Peter Xu wrote: > > On Thu, Feb 13, 2020 at 06:20:16PM +0100, David Hildenbrand wrote: > >> Resizing while migrating is dangerous and does not work as expected. > >> The whole migration code works on the usable_

Re: [PATCH v2 00/30] Convert QAPI doc comments to generate rST instead of texinfo

2020-02-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200213175647.17628-1-peter.mayd...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

Re: [PATCH] qemu-doc: Clarify extent of build platform support

2020-02-13 Thread Eduardo Habkost
On Thu, Feb 13, 2020 at 09:43:34AM +0100, Markus Armbruster wrote: > Supporting a build platform beyond its end of life makes no sense. > Spell that out just to be clear. > > Signed-off-by: Markus Armbruster Thanks! Reviewed-by: Eduardo Habkost > --- > qemu-doc.texi | 9 + > 1 file c

Re: [PATCH v5 8/8] multifd: Add zstd compression multifd support

2020-02-13 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> --- >> hw/core/qdev-properties.c| 2 +- >> migration/Makefile.objs | 1 + >> migration/migration.c| 9 + >> migration/migration.h| 1 + >> migration/

Re: [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default

2020-02-13 Thread Wainer dos Santos Moschetta
On 2/12/20 6:36 PM, Philippe Mathieu-Daudé wrote: The www.helenos.org server is slow and downloading the Leon3 binary takes too long [*]. Do not include this test in the default suite. Similarly to commit 471c97a69b: Currently the Avocado framework does not distinct the time spent downl

Re: [PATCH v5 5/8] multifd: Add zlib compression multifd support

2020-02-13 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> --- >> hw/core/qdev-properties.c| 2 +- >> migration/Makefile.objs | 1 + >> migration/migration.c| 9 + >> migration/migration.h| 1 + >> migration/

Re: [PATCH] tests/acceptance/ppc_prep_40p: Use cdn.netbsd.org hostname

2020-02-13 Thread Wainer dos Santos Moschetta
On 2/11/20 11:45 AM, Philippe Mathieu-Daudé wrote: Use NetBSD content delivery network to get faster downloads. Suggested-by: Kamil Rytarowski Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/ppc_prep_40p.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) LGTM. Rev

Re: [PATCH] tests/acceptance/ppc_prep_40p: Do not run NetBSD test by default

2020-02-13 Thread Wainer dos Santos Moschetta
On 2/11/20 11:19 AM, Philippe Mathieu-Daudé wrote: The ftp.netbsd.org server is slow and downloading the NetBSD ISO takes too long. Do not include this test in the default suite. Similarly to commit 471c97a69b: Currently the Avocado framework does not distinct the time spent downloading

Re: [PATCH] tests/acceptance: Add boot tests for sh4 and mips64 QEMU advent calendar images

2020-02-13 Thread Wainer dos Santos Moschetta
On 2/11/20 7:42 AM, Thomas Huth wrote: Now that we can select the second serial console in the acceptance tests (see commit 746f244d9720 "Allow to use other serial consoles than default"), we can also test the sh4 image from the QEMU advent calendar 2018. And another recent commit (ec860426dfb

Re: [PATCH v12 Kernel 4/7] vfio iommu: Implementation of ioctl to for dirty pages tracking.

2020-02-13 Thread Kirti Wankhede
+static int vfio_iova_dirty_bitmap(struct vfio_iommu *iommu, dma_addr_t iova, + size_t size, uint64_t pgsize, + unsigned char __user *bitmap) +{ + struct vfio_dma *dma; + dma_addr_t i = iova, iova_limit; + u

  1   2   3   4   >