Re: [PATCH v7 00/11] error: auto propagated local_err part I

Vladimir Sementsov-Ogievskiy writes: > 03.03.2020 11:01, Markus Armbruster wrote: >> Hi Vladimir, >> >> I've come to rather like your ERRP_AUTO_PROPAGATE() idea. What I >> wouldn't like is a protracted conversion. >> >> Once we're happy with PATCH 1-3, it's a matter of running Coccinelle and >>

Re: [PATCH v3 03/34] docs/devel/qapi-code-gen: Clarify allow-oob introspection

On 3/15/20 9:46 AM, Markus Armbruster wrote: Mention SchemaInfo variant member "allow-oob" defaults to false. Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake diff --git a/docs/devel/qa

Re: [PATCH v3 02/34] qapi: Belatedly update doc comment for @wait deprecation

On 3/15/20 9:46 AM, Markus Armbruster wrote: Commit a9b305ba29 "socket: allow wait=false for client socket" deprecated use of @wait for client socket chardevs, but neglected to update char.json's doc comment. Make up for that. Signed-off-by: Markus Armbruster --- qapi/char.json | 1 + 1 fil

[PULL 38/38] linux-user, openrisc: sync syscall numbers with kernel v5.5

Use helper script scripts/gensyscalls.sh to generate the file. Add TARGET_NR_or1k_atomic Remove useless comments and blank lines. Define diretly the __NR_XXX64 syscalls rather than using the intermediate __NR3264 definition. Remove wrong cut'n'paste (like "#ifdef __ARCH_WANT_SYNC_FILE_RANGE2") A

Re: [PATCH v2 1/4] m25p80: Convert to support tracing

On Mon, 16 Mar 2020 at 14:14, Cédric Le Goater wrote: > > Hello, > > On 2/17/20 4:47 PM, Cédric Le Goater wrote: > > Hello all, > > > > On 2/6/20 7:32 PM, Guenter Roeck wrote: > >> While at it, add some trace messages to help debug problems > >> seen when running the latest Linux kernel. > > > > T

[PULL 14/38] linux-user: introduce parameters to generate syscall_nr.h

This will be used when we'll import syscall.tbl from the kernel Add a script to remove all the dependencies to syscall_nr.h that point to source directory and not to the build directory. The list of arch will be update while the generated files are added. Signed-off-by: Laurent Vivier Reviewed-b

[PATCH v6 39/42] pci: allocate pci id for nvme

From: Klaus Jensen The emulated nvme device (hw/block/nvme.c) is currently using an internal Intel device id. Prepare to change that by allocating a device id under the 1b36 (Red Hat, Inc.) vendor id. Signed-off-by: Klaus Jensen Acked-by: Keith Busch Reviewed-by: Maxim Levitsky --- MAINTAIN

Re: [PATCH 0/5] QEMU Gating CI

On Mon, 16 Mar 2020 at 12:26, Cleber Rosa wrote: > About the runners and the fact that the job is stuck without them, > the message seems straightforward enough, but I can't get to the > project configuration to look at the registered runners with my > current permissions (set as "developer"). I'

[PULL 36/38] linux-user, aarch64: sync syscall numbers with kernel v5.5

Use helper script scripts/gensyscalls.sh to generate the file. This change TARGET_NR_fstatat64 by TARGET_NR_newfstatat that is correct because definitions from linux are: arch/arm64/include/uapi/asm/unistd.h #define __ARCH_WANT_NEW_STAT include/uapi/asm-generic/unistd.h #if defined(__ARCH_

[PATCH v6 38/42] nvme: support multiple namespaces

From: Klaus Jensen This adds support for multiple namespaces by introducing a new 'nvme-ns' device model. The nvme device creates a bus named from the device name ('id'). The nvme-ns devices then connect to this and registers themselves with the nvme device. This changes how an nvme device is cr

Re: [PATCH v9 03/15] s390x: protvirt: Add migration blocker

On Wed, 11 Mar 2020 09:21:39 -0400 Janosch Frank wrote: > Migration is not yet supported. > > Signed-off-by: Janosch Frank > Reviewed-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 18 ++ > 1 file changed, 18 insertions(+) Reviewed-by: Cornelia Huck

[PATCH v6 30/42] nvme: add check for mdts

From: Klaus Jensen Add 'mdts' device parameter to control the Maximum Data Transfer Size of the controller and check that it is respected. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 29 - hw/block/nvme.h | 4 +++- hw/block/trace-events | 1 + 3

[PATCH v6 41/42] nvme: remove redundant NvmeCmd pointer parameter

From: Klaus Jensen The command struct is available in the NvmeRequest that we generally pass around anyway. Signed-off-by: Klaus Jensen Acked-by: Keith Busch Reviewed-by: Maxim Levitsky --- hw/block/nvme.c | 164 +++- 1 file changed, 78 insertions(

[PULL 21/38] linux-user, arm: add syscall table generation support

Copy syscall.tbl and syscallhdr.sh from linux/arch/arm/tools/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Update syscall.c to manage TARGET_NR_arm_sync_file_range as it has replaced TARGET_NR_sync_file_range2 Move existing stuff from linux-user/Makefile.objs to linux-user/arm/

[PATCH v6 34/42] pci: pass along the return value of dma_memory_rw

From: Klaus Jensen The nvme device needs to know the return value of dma_memory_rw to pass block/011 from blktests. So pass it along instead of ignoring it. There are no existing users of the return value, so this patch should be safe. Signed-off-by: Klaus Jensen Reviewed-by: Philippe Mathieu-

[PATCH v6 35/42] nvme: handle dma errors

From: Klaus Jensen Handling DMA errors gracefully is required for the device to pass the block/011 test ("disable PCI device while doing I/O") in the blktests suite. With this patch the device passes the test by retrying "critical" transfers (posting of completion entries and processing of submi

[PATCH v6 40/42] nvme: change controller pci id

From: Klaus Jensen There are two reasons for changing this: 1. The nvme device currently uses an internal Intel device id. 2. Since commits "nvme: fix write zeroes offset and count" and "nvme: support multiple namespaces" the controller device no longer has the quirks that the Lin

[PATCH v6 24/42] nvme: remove redundant has_sg member

From: Klaus Jensen Remove the has_sg member from NvmeRequest since it's redundant. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 18 -- hw/block/nvme.h | 1 - 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 187c816eb6

[PULL 16/38] linux-user, hppa: add syscall table generation support

Copy syscall.tbl and syscallhdr.sh from linux/arch/parisc/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Signed-off-by: Laurent Vivier Reviewed-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <20200310103403.3284090-4-laur...@vivier.eu> Signed-off-by: Laur

[PATCH v6 31/42] nvme: add check for prinfo

From: Klaus Jensen Check the validity of the PRINFO field. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 50 --- hw/block/trace-events | 1 + include/block/nvme.h | 1 + 3 files changed, 44 insertions(+), 8 deletions(-) diff --git a/hw/bloc

[PATCH v6 21/42] nvme: bump supported version to v1.3

From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 74061d08fd2e..26c4b6e69f72 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -44,6 +44,7 @@ #include "trace.h"

[PATCH v6 36/42] nvme: add support for scatter gather lists

From: Klaus Jensen For now, support the Data Block, Segment and Last Segment descriptor types. See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)"). Signed-off-by: Klaus Jensen Acked-by: Keith Busch --- hw/block/nvme.c | 310 +++--- hw/blo

[PATCH v3 17/19] hw/arm: Automatically select the 'virt' machine on KVM

When building a KVM-only QEMU, the 'virt' machine is a good default :) Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index d0903d8544..8e801cd15f 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -1,

[PATCH v6 42/42] nvme: make lba data size configurable

From: Klaus Jensen Signed-off-by: Klaus Jensen Acked-by: Keith Busch --- hw/block/nvme-ns.c | 7 ++- hw/block/nvme-ns.h | 4 +++- hw/block/nvme.c| 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c index 6d975104171d..d7e5c81c5f

[PATCH v6 33/42] nvme: use preallocated qsg/iov in nvme_dma_prp

From: Klaus Jensen Since clean up of the request qsg/iov has been moved to the common nvme_enqueue_req_completion function, there is no need to use a stack allocated qsg/iov in nvme_dma_prp. Signed-off-by: Klaus Jensen Acked-by: Keith Busch Reviewed-by: Maxim Levitsky --- hw/block/nvme.c | 1

[PATCH v3 13/19] target/arm: Restrict ARMv7 R-profile cpus to TCG accel

A KVM-only build won't be able to run R-profile cpus. Only enable the following ARMv7 R-Profile CPUs when TCG is available: - Cortex-R5 - Cortex-R5F Signed-off-by: Philippe Mathieu-Daudé --- default-configs/aarch64-softmmu.mak | 1 - target/arm/cpu.c| 51 --

[PATCH v6 27/42] nvme: add request mapping helper

From: Klaus Jensen Introduce the nvme_map helper to remove some noise in the main nvme_rw function. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 3e9c2ed434c2..850087aac

[PATCH v6 37/42] nvme: refactor identify active namespace id list

From: Klaus Jensen Prepare to support inactive namespaces. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index b89b96990f52..bf9fb500842a 100644 --- a/hw/block/nvme.c +++ b/hw/block/

[PATCH v6 17/42] nvme: add log specific field to trace events

From: Klaus Jensen The LSP field is not used directly now, but include it in the trace. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 3 ++- hw/block/trace-events | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index e56142c4ea

[PATCH v6 29/42] nvme: refactor request bounds checking

From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index eecfad694bf8..ba520c76bae5 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -491,6 +4

[PATCH v3 11/19] target/arm: Restrict ARMv5 cpus to TCG accel

KVM requires a cpu based on (at least) the ARMv7 architecture. Only enable the following ARMv5 CPUs when TCG is available: - ARM926 - ARM946 - ARM1026 - XScale (PXA250/255/260/261/262/270) Signed-off-by: Philippe Mathieu-Daudé --- default-configs/arm-softmmu.mak | 12 -- target/arm/cp

[PATCH v6 11/42] nvme: add temperature threshold feature

From: Klaus Jensen It might seem wierd to implement this feature for an emulated device, but it is mandatory to support and the feature is useful for testing asynchronous event request support, which will be added in a later patch. Signed-off-by: Klaus Jensen Acked-by: Keith Busch --- hw/bloc

[PATCH v6 25/42] nvme: refactor dma read/write

From: Klaus Jensen Refactor the nvme_dma_{read,write}_prp functions into a common function taking a DMADirection parameter. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 89 - 1 file changed, 43 insertions(+), 46 deletions(-) diff --git a/hw

[PATCH v6 22/42] nvme: memset preallocated requests structures

From: Klaus Jensen This is preparatory to subsequent patches that change how QSGs/IOVs are handled. It is important that the qsg and iov members of the NvmeRequest are initially zeroed. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 06/19] target/arm: Move Makefile variable restricted to CONFIG_TCG

Simple code movement which simplifies next commits. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/Makefile.objs | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/arm/Makefile.objs b/target/arm/Makefile.objs index cf26c16f5f..0c6f8c248d 100644 --- a/target/ar

[PATCH v6 01/42] nvme: rename trace events to nvme_dev

From: Klaus Jensen Change the prefix of all nvme device related trace events to 'nvme_dev' to not clash with trace events from the nvme block driver. Signed-off-by: Klaus Jensen Acked-by: Keith Busch Reviewed-by: Maxim Levitsky --- hw/block/nvme.c | 188 +---

[PATCH v6 28/42] nvme: verify validity of prp lists in the cmb

From: Klaus Jensen Before this patch the device already supported this, but it did not check for the validity of it nor announced the support in the LISTS field. If some of the PRPs in a PRP list are in the CMB, then ALL entries must be there. This patch makes sure that is verified as well as pr

[PATCH v6 03/42] nvme: move device parameters to separate struct

From: Klaus Jensen Move device configuration parameters to separate struct to make it explicit what is configurable and what is set internally. Signed-off-by: Klaus Jensen Acked-by: Keith Busch Reviewed-by: Maxim Levitsky --- hw/block/nvme.c | 44 ++--

[PATCH v3 03/19] target/arm: Restrict DC-CVAP instruction to TCG accel

Under KVM the 'Data or unified Cache line Clean by VA to PoP' instruction will trap. Fixes: 0d57b4999 ("Add support for DC CVAP & DC CVADP ins") Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/a

[PATCH v6 14/42] nvme: add missing mandatory features

From: Klaus Jensen Add support for returning a resonable response to Get/Set Features of mandatory features. Signed-off-by: Klaus Jensen Acked-by: Keith Busch --- hw/block/nvme.c | 60 ++- hw/block/trace-events | 2 ++ include/block/nvme.h | 6

[PATCH v6 23/42] nvme: add mapping helpers

From: Klaus Jensen Add nvme_map_addr, nvme_map_addr_cmb and nvme_addr_to_cmb helpers and use them in nvme_map_prp. This fixes a bug where in the case of a CMB transfer, the device would map to the buffer with a wrong length. Fixes: b2b2b67a00574 ("nvme: Add support for Read Data and Write Data

[PATCH v6 06/42] nvme: add identify cns values in header

From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index f716f690a594..b38d7e548a60 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -709,11 +709,11 @@ static uint16_

[PATCH v6 26/42] nvme: pass request along for tracing

From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 67 +-- hw/block/trace-events | 2 +- 2 files changed, 40 insertions(+), 29 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 809d00443369..3e9c2ed434c2 100644 --

[PATCH v6 12/42] nvme: add support for the get log page command

From: Klaus Jensen Add support for the Get Log Page command and basic implementations of the mandatory Error Information, SMART / Health Information and Firmware Slot Information log pages. In violation of the specification, the SMART / Health Information log page does not persist information ov

[PATCH v6 15/42] nvme: additional tracing

From: Klaus Jensen Add additional trace calls for nvme_enqueue_req_completion, mmio and doorbell writes. Also, streamline nvme_identify_ns and nvme_identify_ns_list. They do not need to repeat the command, it is already in the trace name. Signed-off-by: Klaus Jensen Acked-by: Keith Busch ---

[PATCH v6 19/42] nvme: enforce valid queue creation sequence

From: Klaus Jensen Support returning Command Sequence Error if Set Features on Number of Queues is called after queues have been created. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 7 +++ hw/block/nvme.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/block/nvme.c b/hw/bloc

Re: [PATCH v2 1/4] m25p80: Convert to support tracing

On 3/16/20 3:58 PM, Peter Maydell wrote: > On Mon, 16 Mar 2020 at 14:14, Cédric Le Goater wrote: >> >> Hello, >> >> On 2/17/20 4:47 PM, Cédric Le Goater wrote: >>> Hello all, >>> >>> On 2/6/20 7:32 PM, Guenter Roeck wrote: While at it, add some trace messages to help debug problems seen

[PATCH v2 7/8] ppc/spapr: Implement FWNMI System Reset delivery

PAPR requires that if "ibm,nmi-register" succeeds, then the hypervisor delivers all system reset and machine check exceptions to the registered addresses. System Resets are delivered with registers set to the architected state, and with no interlock. Signed-off-by: Nicholas Piggin --- hw/ppc/sp

[PATCH v6 20/42] nvme: provide the mandatory subnqn field

From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index b40d27cddc46..74061d08fd2e 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -1925,6 +1925,9 @@ static void nvme_init_ctrl(NvmeCt

[PATCH v6 10/42] nvme: refactor device realization

From: Klaus Jensen This patch splits up nvme_realize into multiple individual functions, each initializing a different subset of the device. Signed-off-by: Klaus Jensen Acked-by: Keith Busch --- hw/block/nvme.c | 178 ++-- hw/block/nvme.h | 23

Re: [PATCH v3 07/34] tests/test-qmp-cmds: Simplify test data setup

On Sun, Mar 15, 2020 at 3:55 PM Markus Armbruster wrote: > > Building requests with qdict_put() & friends is tedious to write and > hard to read. Parse them from string literals with > qdict_from_vjsonf_nofail() instead. > > Signed-off-by: Markus Armbruster & fixes the leak introduced in patch

[PATCH v2 2/8] ppc/spapr: Change FWNMI names

The option is called "FWNMI", and it involves more than just machine checks, also machine checks can be delivered without the FWNMI option, so re-name various things to reflect that. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c| 28 ++-- hw/ppc/sp

[PATCH v6 04/42] nvme: bump spec data structures to v1.3

From: Klaus Jensen Add missing fields in the Identify Controller and Identify Namespace data structures to bring them in line with NVMe v1.3. This also adds data structures and defines for SGL support which requires a couple of trivial changes to the nvme block driver as well. Signed-off-by: Kl

Re: [PATCH v3 01/34] qemu-doc: Belatedly document QMP command arg & result deprecation

On 3/15/20 9:46 AM, Markus Armbruster wrote: A number of deprecated QMP arguments and results were missed in commit eb22aeca65 "docs: document deprecation policy & deprecated features in appendix" (v2.10.0): Since then, we missed a few more: * Commit 3c605f4074 "commit: Add top-node/base-no

[PATCH v6 18/42] nvme: support identify namespace descriptor list

From: Klaus Jensen Since we are not providing the NGUID or EUI64 fields, we must support the Namespace UUID. We do not have any way of storing a persistent unique identifier, so conjure up a UUID that is just the namespace id. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 38

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

The package from the PPA failed the same way for me: ubuntu@f1:~$ qemu-system-x86_64 --enable-kvm -cpu Penryn,vmx=on -m 512 --nodefaults --nographic qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.01H:ECX.sse4.1 [bit 19] KVM internal error. Suberror: 1 emulation failur

[PATCH v6 08/42] nvme: add support for the abort command

From: Klaus Jensen Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, Section 5.1 ("Abort command"). The Abort command is a best effort command; for now, the device always fails to abort the given command. Signed-off-by: Klaus Jensen Acked-by: Keith Busch --- hw/block/n

Re: [PATCH v3 06/34] tests/test-qmp-cmds: Check responses more thoroughly

On Sun, Mar 15, 2020 at 3:51 PM Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > tests/test-qmp-cmds.c | 23 +-- > 1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-

[PATCH v6 16/42] nvme: make sure ncqr and nsqr is valid

From: Klaus Jensen 0x is not an allowed value for NCQR and NSQR in Set Features on Number of Queues. Signed-off-by: Klaus Jensen Acked-by: Keith Busch Reviewed-by: Maxim Levitsky --- hw/block/nvme.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nv

Re: [PATCH v6 3/4] qcow2: add zstd cluster compression

On 3/12/20 4:22 AM, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. +++ b/docs/in

Re: [PATCH v9] fixup! Fix subcode/pbt

On 3/16/20 3:54 PM, Cornelia Huck wrote: > On Mon, 16 Mar 2020 15:47:41 +0100 > Janosch Frank wrote: > >> On 3/16/20 3:27 PM, Cornelia Huck wrote: >>> On Fri, 13 Mar 2020 05:52:32 -0400 >>> Janosch Frank wrote: >>> Signed-off-by: Janosch Frank --- hw/s390x/ipl.h | 11 +++

[PATCH v6 02/42] nvme: remove superfluous breaks

From: Klaus Jensen These break statements was left over when commit 3036a626e9ef ("nvme: add Get/Set Feature Timestamp support") was merged. Signed-off-by: Klaus Jensen Acked-by: Keith Busch Reviewed-by: Maxim Levitsky --- hw/block/nvme.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH v6 09/42] nvme: add max_ioqpairs device parameter

From: Klaus Jensen The num_queues device paramater has a slightly confusing meaning because it accounts for the admin queue pair which is not really optional. Secondly, it is really a maximum value of queues allowed. Add a new max_ioqpairs parameter that only accounts for I/O queue pairs, but ke

Re: [PATCH v2 4/8] qapi/misc: Move query-uuid command with block code

On 3/16/20 2:09 PM, Igor Mammedov wrote: On Mon, 16 Mar 2020 01:03:44 +0100 Philippe Mathieu-Daudé wrote: here should be why Indeed. Daniel explained on IRC the GUID structure is "standardized by microsoft as a way to detect when a guest has certain operations applied" to a saved snapshot.

Re: [PATCH v9] fixup! Fix subcode/pbt

On Fri, 13 Mar 2020 05:52:32 -0400 Janosch Frank wrote: > Signed-off-by: Janosch Frank > --- > hw/s390x/ipl.h | 11 +++ > target/s390x/diag.c | 2 +- > 2 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h > index 95e3183c9cccf8b6..f799

Re: [PATCH v9] fixup! Fix subcode/pbt

On 16.03.20 15:54, Cornelia Huck wrote: > On Mon, 16 Mar 2020 15:47:41 +0100 > Janosch Frank wrote: > >> On 3/16/20 3:27 PM, Cornelia Huck wrote: >>> On Fri, 13 Mar 2020 05:52:32 -0400 >>> Janosch Frank wrote: >>> Signed-off-by: Janosch Frank --- hw/s390x/ipl.h | 11 +

[PATCH v2 8/8] ppc/spapr: Ignore common "ibm, nmi-interlock" Linux bug

Linux kernels call "ibm,nmi-interlock" in their system reset handlers contrary to PAPR. Returning an error because the CPU does not hold the interlock here causes Linux to print warning messages. PowerVM returns success in this case, so do the same for now. Signed-off-by: Nicholas Piggin --- hw/

[PATCH v6 05/42] nvme: use constant for identify data size

From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 40cb176dea3c..f716f690a594 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -679,7 +679,7 @@ static uint16_t nvme_i

Re: [PULL 0/6] Audio 20200316 patches

> > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/audio-20200316-pull-request > > for you to fetch changes up to 49f77e6faf36cddd84417f9080462413acdbcc27: > > audio: add audiodev format=f3

[PATCH v6 00/42] nvme: support NVMe v1.3d, SGLs and multiple namespaces

From: Klaus Jensen Hi, So this patchset kinda blew up in size (wrt. number of patches) after Maxim's comments (26 -> 42), but Maxim's comments about splitting up a bunch of the patches made a lot of sense. v6 primarily splits up the big nasty patches into more digestible parts. Specifically the

Re: [PATCH v9] fixup! Fix subcode/pbt

On Mon, 16 Mar 2020 15:47:41 +0100 Janosch Frank wrote: > On 3/16/20 3:27 PM, Cornelia Huck wrote: > > On Fri, 13 Mar 2020 05:52:32 -0400 > > Janosch Frank wrote: > > > >> Signed-off-by: Janosch Frank > >> --- > >> hw/s390x/ipl.h | 11 +++ > >> target/s390x/diag.c | 2 +- > >>

[PATCH v2 5/8] ppc/spapr: Allow FWNMI on TCG

There should no longer be a reason to prevent TCG providing FWNMI. System Reset interrupts are generated to the guest with nmi monitor command and H_SIGNAL_SYS_RESET. Machine Checks can not be injected currently, but this could be implemented with the mce monitor cmd similarly to i386. Signed-off-

Re: [PATCH] MAINTAINERS: Mark the LatticeMico32 target as orphan

Am 2020-03-16 13:26, schrieb Philippe Mathieu-Daudé: Michael Walle expressed his desire to orphan the lm32 target [*]: I guess it is time to pull the plug. Mainly, because I have no time for this anymore. I've always worked on this on my spare time and life changed. And secondly, I guess R

[PATCH v2] MAINTAINERS: Mark the LatticeMico32 target as orphan

Michael Walle expressed his desire to orphan the lm32 target [*]: I guess it is time to pull the plug. Mainly, because I have no time for this anymore. I've always worked on this on my spare time and life changed. And secondly, I guess RISC-V is taking over ;) It has a far better ecosystem

Re: [PATCH v3 02/34] qapi: Belatedly update doc comment for @wait deprecation

Hi On Sun, Mar 15, 2020 at 3:48 PM Markus Armbruster wrote: > > Commit a9b305ba29 "socket: allow wait=false for client socket" > deprecated use of @wait for client socket chardevs, but neglected to > update char.json's doc comment. Make up for that. > > Signed-off-by: Markus Armbruster Reviewe

[PATCH v2 0/8] FWNMI fixes / changes

Hi, Since v1, I fixed the intermediate compile error spotted by Greg, and rediffed the series on top of ppc-for-5.0, plus Alexey's patch ("spapr/rtas: Reserve space for RTAS blob and log"). The first 6 patches are otherwise unchanged since last posting. Patch 7 implements fwnim sreset interrupts

[PATCH v2 6/8] target/ppc: allow ppc_cpu_do_system_reset to take an alternate vector

Provide for an alternate delivery location, -1 defaults to the architected address. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c | 2 +- target/ppc/cpu.h | 2 +- target/ppc/excp_helper.c | 5 - 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr

Re: [PATCH v9] fixup! Fix subcode/pbt

On 3/16/20 3:27 PM, Cornelia Huck wrote: > On Fri, 13 Mar 2020 05:52:32 -0400 > Janosch Frank wrote: > >> Signed-off-by: Janosch Frank >> --- >> hw/s390x/ipl.h | 11 +++ >> target/s390x/diag.c | 2 +- >> 2 files changed, 8 insertions(+), 5 deletions(-) >> >> diff --git a/hw/s390x/

Re: [PATCH 1/4] tests/vm: write raw console log

On 3/16/20 3:16 PM, Alex Bennée wrote: Gerd Hoffmann writes: Run "tail -f /var/tmp/*/qemu*console.raw" in another terminal to watch the install console. Signed-off-by: Gerd Hoffmann I suspect this is what's breaking "make check-acceptance" so I've dropped the series from testing/next for

[PATCH v2 4/8] ppc/spapr: Fix FWNMI machine check interrupt delivery

FWNMI machine check delivery misses a few things that will make it fail with TCG at least (which we would like to allow in future to improve testing). It's not nice to scatter interrupt delivery logic around the tree, so move it to excp_helper.c and share code where possible. Signed-off-by: Nicho

[PATCH v6 32/42] nvme: allow multiple aios per command

From: Klaus Jensen This refactors how the device issues asynchronous block backend requests. The NvmeRequest now holds a queue of NvmeAIOs that are associated with the command. This allows multiple aios to be issued for a command. Only when all requests have been completed will the device post a

Re: [PATCH] MAINTAINERS: Mark the LatticeMico32 target as orphan

Hi, Am 2020-03-16 13:26, schrieb Philippe Mathieu-Daudé: Michael Walle expressed his desire to orphan the lm32 target [*]: I guess it is time to pull the plug. Mainly, because I have no time for this anymore. I've always worked on this on my spare time and life changed. And secondly, I g

Re: [PATCH v2 1/4] m25p80: Convert to support tracing

Hello, On 2/17/20 4:47 PM, Cédric Le Goater wrote: > Hello all, > > On 2/6/20 7:32 PM, Guenter Roeck wrote: >> While at it, add some trace messages to help debug problems >> seen when running the latest Linux kernel. > > Through which tree do you think it is best to merge this patchset ? > blo

[PATCH v2 1/8] ppc/spapr: Fix FWNMI machine check failure handling

ppc_cpu_do_system_reset delivers a system rreset interrupt to the guest, which is certainly not what is intended here. Panic the guest like other failure cases here do. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr_events.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a

Re: [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it

On 3/16/20 2:49 PM, Peter Maydell wrote: On Mon, 16 Mar 2020 at 13:45, Philippe Mathieu-Daudé wrote: The semihosting feature is only meaningful when using TCG. So far only the ARM/MIPS/LM32 provide the semihosting feature. Also m68k, nios2, xtensa. riscv eventually but not yet upstream.

[PATCH v6 13/42] nvme: add support for the asynchronous event request command

From: Klaus Jensen Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, Section 5.2 ("Asynchronous Event Request command"). Mostly imported from Keith's qemu-nvme tree. Modified with a max number of queued events (controllable with the aer_max_queued device parameter). The sp

Re: [PATCH 2/2] hw/rdma: Skip data-path mr_id translation

Hi Yuval, On 3/7/20 2:56 PM, Yuval Shaia wrote: With the change made in commit 68b89aee71 ("Utilize ibv_reg_mr_iova for memory registration") the MR emulation is no longer needed in order to translate the guest addresses into host addresses. With that, the next obvious step is to skip entirely t

[PATCH v6 07/42] nvme: refactor nvme_addr_read

From: Klaus Jensen Pull the controller memory buffer check to its own function. The check will be used on its own in later patches. Signed-off-by: Klaus Jensen Acked-by: Keith Busch --- hw/block/nvme.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/hw/bl

Re: [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it

On Mon, 16 Mar 2020 at 13:45, Philippe Mathieu-Daudé wrote: > > The semihosting feature is only meaningful when using TCG. > > So far only the ARM/MIPS/LM32 provide the semihosting feature. Also m68k, nios2, xtensa. riscv eventually but not yet upstream. > > Do not enable it by default, and let

Re: [PATCH 0/2] avoid integer overflow

On Mon, 16 Mar 2020 at 12:25, Yifei Jiang wrote: > > the constant default type is "int", when the constant is shifted to the left, > it may exceed 32 bits, resulting in integer overflowing. So constant type need > change to "long" "long" would not in general be the right type to use in cases wher

[PATCH v2] hw/ide: Do ide_drive_get() within pci_ide_create_devs()

The pci_ide_create_devs() function takes a hd_table parameter but all callers just pass what ide_drive_get() returns so we can do it locally simplifying callers and removing hd_table parameter. Signed-off-by: BALATON Zoltan --- v2: Alternative version that applies without [PATCH 4/8] hw/ide: Move

Re: [PATCH 0/8] Misc hw/ide legacy clean up

On Mon, 16 Mar 2020, BALATON Zoltan wrote: On Mon, 16 Mar 2020, Markus Armbruster wrote: BALATON Zoltan writes: These are some clean ups to remove more legacy init functions and lessen dependence on include/hw/ide.h with some simplifications in board code. There should be no functional change.

[PATCH v2 3/8] ppc/spapr: Add FWNMI System Reset state

The FWNMI option must deliver system reset interrupts to their registered address, and there are a few constraints on the handler addresses specified in PAPR. Add the system reset address state and checks. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c | 2 ++ hw/ppc/spapr_rtas.c

Re: [PATCH v2 8/8] qapi/misc: Restrict device memory commands to machine code

On Mon, 16 Mar 2020 01:03:48 +0100 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Igor Mammedov > --- > qapi/machine.json | 131 +++ > qapi/misc.json | 132 > include/

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

On Fri, 13 Mar 2020 11:26:45 -0400 "Michael S. Tsirkin" wrote: > On Fri, Mar 13, 2020 at 10:36:56AM +0100, Igor Mammedov wrote: > > On Thu, 12 Mar 2020 13:09:51 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Mar 12, 2020 at 05:27:45PM +0100, Igor Mammedov wrote: > > > > On Wed, 11

Re: [PATCH 1/2] hw/rdma: Cosmetic change - no need for two sge arrays

Hi Yuval, On 3/7/20 2:56 PM, Yuval Shaia wrote: The function build_host_sge_array uses two sge arrays, one for input and one for output. Since the size of the two arrays is the same, the function can write directly to the given source array (i.e. input/output argument). Signed-off-by: Yuval Sha

Re: [PATCH 1/4] tests/vm: write raw console log

Gerd Hoffmann writes: > Run "tail -f /var/tmp/*/qemu*console.raw" in another terminal > to watch the install console. > > Signed-off-by: Gerd Hoffmann I suspect this is what's breaking "make check-acceptance" so I've dropped the series from testing/next for now. 2020-03-11 12:12:30,546 sta

Re: [PATCH v2 6/8] qapi/misc: Restrict ACPI commands to machine code

On Mon, 16 Mar 2020 01:03:46 +0100 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Igor Mammedov > --- > qapi/machine.json| 154 +++ > qapi/misc.json | 154 --- > include

[PATCH] MAINTAINERS: Add an entry for the HVF accelerator

Cc: Nikita Leshenko Cc: Sergio Andres Gomez Del Real Cc: Patrick Colp Cc: Cameron Esfahani Cc: Liran Alon Cc: Heiher Signed-off-by: Roman Bolshakov --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 32867bc636..e544f3012e 100644 --- a

Re: [PATCH 1/2] tcg: avoid integer overflow

On Mon, 16 Mar 2020 at 13:15, Yifei Jiang wrote: > > This fixes coverity issues 75234842, etc.,: Where does this issue number come from, by the way? It's not from the online Coverity Scan we use which is the issue ID we usually cite for coverity stuff. > 2221tcg_gen_andi_i64(t, t, dup_co

<    1   2   3   4   5   6   7   >