Re: [question]vhost-user: atuo fix network link broken during migration

2020-03-23 Thread Jason Wang
On 2020/3/23 下午4:17, yangke (J) wrote: We find an issue when host mce trigger openvswitch(dpdk) restart in source host during guest migration, Did you mean the vhost-user netev was deleted from the source host? VM is still link down in frontend after migration, it cause the network in

Re: [PATCH v6 1/2] net: tulip: check frame size and r/w data length

2020-03-23 Thread Jason Wang
On 2020/3/24 上午9:29, Li Qiang wrote: P J P mailto:ppan...@redhat.com>> 于2020年3月23日周一 下午8:24写道: From: Prasad J Pandit mailto:p...@fedoraproject.org>> Tulip network driver while copying tx/rx buffers does not check frame size against r/w data length. This may lead to OOB buffer

Re: [PATCH v6 2/2] net: tulip: add .can_receive routine

2020-03-23 Thread Jason Wang
On 2020/3/24 上午10:04, Li Qiang wrote: P J P mailto:ppan...@redhat.com>> 于2020年3月23日周一 下午8:25写道: From: Prasad J Pandit mailto:p...@fedoraproject.org>> Define .can_receive routine to do sanity checks before receiving packet data. And call qemu_flush_queued_packets to flush

[PULL 4/7] target/ppc: don't byte swap ELFv2 signal handler

2020-03-23 Thread David Gibson
From: Vincent Fazio Previously, the signal handler would be byte swapped if the target and host CPU used different endianness. This would cause a SIGSEGV when attempting to translate the opcode pointed to by the swapped address. Thread 1 "qemu-ppc64" received signal SIGSEGV, Segmentation

[PULL 7/7] ppc/ppc405_boards: Remove unnecessary NULL check

2020-03-23 Thread David Gibson
From: Philippe Mathieu-Daudé This code is inside the "if (dinfo)" condition, so testing again here whether it is NULL is unnecessary. Fixes: dd59bcae7 (Don't size flash memory to match backing image) Reported-by: Coverity (CID 1421917) Suggested-by: Peter Maydell Signed-off-by: Philippe

[PULL 2/7] target/ppc: Fix slbia TLB invalidation gap

2020-03-23 Thread David Gibson
From: Nicholas Piggin slbia must invalidate TLBs even if it does not remove a valid SLB entry, because slbmte can overwrite valid entries without removing their TLBs. As the architecture says, slbia invalidates all lookaside information, not conditionally based on if it removed valid entries.

[PULL 3/7] target/ppc: Fix ISA v3.0 (POWER9) slbia implementation

2020-03-23 Thread David Gibson
From: Nicholas Piggin The new ISA v3.0 slbia variants have not been implemented for TCG, which can lead to crashing when a POWER9 machine boots Linux using the hash MMU, for example ("disable_radix" kernel command line). Add them. Signed-off-by: Nicholas Piggin Message-Id:

[PULL 5/7] spapr: Fix memory leak in h_client_architecture_support()

2020-03-23 Thread David Gibson
From: Greg Kurz This is the only error path that needs to free the previously allocated ov1. Reported-by: Coverity (CID 1421924) Fixes: cbd0d7f36322 "spapr: Fail CAS if option vector table cannot be parsed" Signed-off-by: Greg Kurz Message-Id:

[PULL 0/7] ppc-for-5.0 queue 20200324

2020-03-23 Thread David Gibson
The following changes since commit c532b954d96f96d361ca31308f75f1b95bd4df76: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200323' into staging (2020-03-23 17:41:21 +) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-5.0

[PULL 6/7] hw/ppc: Take QEMU lock when calling ppc_dcr_read/write()

2020-03-23 Thread David Gibson
From: Peter Maydell The ppc_dcr_read() and ppc_dcr_write() functions call into callbacks in device code, so we need to hold the QEMU iothread lock while calling them. This is the case already for the callsites in kvmppc_handle_dcr_read/write(), but we must also take the lock when calling the

[PULL 1/7] ppc/spapr: Set the effective address provided flag in mc error log.

2020-03-23 Thread David Gibson
From: Mahesh Salgaonkar Per PAPR, it is expected to set effective address provided flag in sub_err_type member of mc extended error log (i.e rtas_event_log_v6_mc.sub_err_type). This somehow got missed in original fwnmi-mce patch series. The current code just updates the effective address but

[PATCH v4] target/i386: Add notes for versioned CPU models

2020-03-23 Thread Tao Xu
Add which features are added or removed in this version. Signed-off-by: Tao Xu --- The output is as follows: qemu-system-x86_64 -cpu help | grep "\[" x86 Cascadelake-Server-v2 Intel Xeon Processor (Cascadelake) [ARCH_CAPABILITIES] x86 Cascadelake-Server-v3 Intel Xeon Processor (Cascadelake)

Re: [PULL 11/26] vfio/spapr: Allow backing bigger guest IOMMU pages with smaller physical pages

2020-03-23 Thread David Gibson
On Tue, Mar 24, 2020 at 03:08:22PM +1100, Alexey Kardashevskiy wrote: > > > On 23/03/2020 21:55, Peter Maydell wrote: > > On Tue, 21 Aug 2018 at 05:33, David Gibson > > wrote: > >> > >> From: Alexey Kardashevskiy > >> > >> At the moment the PPC64/pseries guest only supports 4K/64K/16M IOMMU >

[Bug 1592336] Re: mouse is defunct when grabbed

2020-03-23 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1592336 Title: mouse is

[Bug 1661176] Re: [2.8.0] Under VNC CTRL-ALT-2 doesn't get to the monitor

2020-03-23 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1661176 Title: [2.8.0]

[Bug 1660010] Re: AArch64 system emulation cannot execute virt uefi in 2.7 or 2.8

2020-03-23 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1660010 Title: AArch64

[Bug 1639394] Re: Unable to boot Solaris 8/9 x86 under Fedora 24

2020-03-23 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1639394 Title: Unable to

[Bug 1659901] Re: Regression: SIGSEGV running Java

2020-03-23 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1659901 Title:

Re: [PULL 11/26] vfio/spapr: Allow backing bigger guest IOMMU pages with smaller physical pages

2020-03-23 Thread Alexey Kardashevskiy
On 23/03/2020 21:55, Peter Maydell wrote: > On Tue, 21 Aug 2018 at 05:33, David Gibson > wrote: >> >> From: Alexey Kardashevskiy >> >> At the moment the PPC64/pseries guest only supports 4K/64K/16M IOMMU >> pages and POWER8 CPU supports the exact same set of page size so >> so far things

Re: [PATCH v4 0/2] introduction of migration_version attribute for VFIO live migration

2020-03-23 Thread Yan Zhao
On Tue, Mar 24, 2020 at 05:29:59AM +0800, Alex Williamson wrote: > On Mon, 3 Jun 2019 20:34:22 -0400 > Yan Zhao wrote: > > > On Tue, Jun 04, 2019 at 03:29:32AM +0800, Alex Williamson wrote: > > > On Thu, 30 May 2019 20:44:38 -0400 > > > Yan Zhao wrote: > > > > > > > This patchset introduces

Re: [PATCH 1/1] spapr/rtas: Add MinMem to ibm,get-system-parameter RTAS call

2020-03-23 Thread David Gibson
On Mon, Mar 23, 2020 at 07:07:21PM -0300, Leonardo Bras wrote: > On Mon, 2020-03-23 at 14:24 +1100, David Gibson wrote: > > On Fri, Mar 20, 2020 at 09:39:22PM -0300, Leonardo Bras wrote: > > > Add support for MinMem SPLPAR Characteristic on emulated > > > RTAS call ibm,get-system-parameter. > > >

Re: [PATCH v15 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-23 Thread Yan Zhao
On Tue, Mar 24, 2020 at 02:51:14AM +0800, Dr. David Alan Gilbert wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > On Mon, 23 Mar 2020 23:24:37 +0530 > > Kirti Wankhede wrote: > > > > > On 3/21/2020 12:29 AM, Alex Williamson wrote: > > > > On Sat, 21 Mar 2020 00:12:04 +0530 > >

Potential Null dereference

2020-03-23 Thread Mansour Ahmadi
Hi, Nullness of needs to be checked here: https://github.com/qemu/qemu/blob/c532b954d96f96d361ca31308f75f1b95bd4df76/block/commit.c#L221 pstrcpy(bs->exact_filename, sizeof(bs->exact_filename),... While it is done at 2 other locations:

Re: [PATCH v2 1/1] net/colo-compare.c: Fix memory leak in packet_enqueue()

2020-03-23 Thread Jing-Wei Su
Zhang, Chen 於 2020年3月24日 週二 上午3:24寫道: > > > > > -Original Message- > > From: Derek Su > > Sent: Monday, March 23, 2020 1:48 AM > > To: qemu-devel@nongnu.org > > Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; > > jasow...@redhat.com; dere...@qnap.com > > Subject: [PATCH v2 1/1]

Re: [PATCH] ext4: Give 32bit personalities 32bit hashes

2020-03-23 Thread Theodore Y. Ts'o
On Thu, Mar 19, 2020 at 11:23:33PM +0100, Linus Walleij wrote: > OK I guess we can at least take this opportunity to add > some kerneldoc to the include file. > > > As a concrete example, should "give me 32-bit semantics > > via PER_LINUX32" mean "mmap should always return addresses > > within

Re: [PATCH v3 0/3] hw/riscv: Add a serial property to sifive_u

2020-03-23 Thread Bin Meng
Hi Palmer, On Sat, Mar 7, 2020 at 5:45 AM Alistair Francis wrote: > > At present the board serial number is hard-coded to 1, and passed > to OTP model during initialization. Firmware (FSBL, U-Boot) uses > the serial number to generate a unique MAC address for the on-chip > ethernet controller.

Re: [PATCH v6 2/2] net: tulip: add .can_receive routine

2020-03-23 Thread Li Qiang
P J P 于2020年3月23日周一 下午8:25写道: > From: Prasad J Pandit > > Define .can_receive routine to do sanity checks before receiving > packet data. And call qemu_flush_queued_packets to flush queued > packets once they are read in tulip_receive(). > > Suggested-by: Jason Wang > Signed-off-by: Prasad J

[Bug 1868527] Re: alignment may overlap the TLB flags

2020-03-23 Thread Hansni Bu
This is an inspection yet. For ARM SMMU simulation, TARGET_PAGE_BITS_MIN is 10. All low bits of the TLB virtual address are used up by TLB flags and alignment flags. It's a little crowded. /* * ARMv7 and later CPUs have 4K pages minimum, but ARMv5 and v6 * have to support 1K tiny pages. */ #

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-23 Thread tstrike
I can confirm that this bug has been fixed (zapped). Thank you all for your hard work and determination. A job well done indeed! As a former programmer I love you all's zeal for attacking this bug. As a side note, knowing what you all go through, I always look things up, walk through at least

Re: [PATCH v6 1/2] net: tulip: check frame size and r/w data length

2020-03-23 Thread Li Qiang
P J P 于2020年3月23日周一 下午8:24写道: > From: Prasad J Pandit > > Tulip network driver while copying tx/rx buffers does not check > frame size against r/w data length. This may lead to OOB buffer > access. Add check to avoid it. > > Limit iterations over descriptors to avoid potential infinite > loop

Re: [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model

2020-03-23 Thread Tao Xu
On 3/24/2020 2:39 AM, Eduardo Habkost wrote: On Mon, Mar 23, 2020 at 10:58:16AM +0800, Xiaoyao Li wrote: On 3/23/2020 10:32 AM, Tao Xu wrote: Hi Xiaoyao, May be you can add .note for this new version. for example: +    .version = 3, +    .note =

Re: [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-03-23 Thread Alex Williamson
[Cc +dwg who originated this warning] On Mon, 23 Mar 2020 14:16:09 +0530 Bharat Bhushan wrote: > On ARM, the MSI doorbell is translated by the virtual IOMMU. > As such address_space_translate() returns the MSI controller > MMIO region and we get an "iommu map to non memory area" > message.

Re: [PATCH v4 0/2] Replaced locks with lock guard macros

2020-03-23 Thread Richard Henderson
On 3/23/20 2:46 PM, Daniel Brodsky wrote: > On Mon, Mar 23, 2020 at 6:25 AM Stefan Hajnoczi wrote: >> >> On Fri, Mar 20, 2020 at 06:43:23AM -0700, no-re...@patchew.org wrote: >>> /tmp/qemu-test/src/util/thread-pool.c:213:5: error: unused variable >>> 'qemu_lockable_auto1'

Re: [PULL 00/20] Ide patches

2020-03-23 Thread Mark Cave-Ayland
On 19/03/2020 18:02, John Snow wrote: > On 3/19/20 8:33 AM, Peter Maydell wrote: >> On Tue, 17 Mar 2020 at 23:23, John Snow wrote: >>> >>> The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506: >>> >>> qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +) >>>

Re: [PATCH 1/1] spapr/rtas: Add MinMem to ibm,get-system-parameter RTAS call

2020-03-23 Thread Leonardo Bras
On Mon, 2020-03-23 at 14:24 +1100, David Gibson wrote: > On Fri, Mar 20, 2020 at 09:39:22PM -0300, Leonardo Bras wrote: > > Add support for MinMem SPLPAR Characteristic on emulated > > RTAS call ibm,get-system-parameter. > > > > MinMem represents Minimum Memory, that is described in LOPAPR as: >

Re: [PATCH v1 09/22] vfio/common: check PASID alloc/free availability

2020-03-23 Thread Peter Xu
On Sun, Mar 22, 2020 at 05:36:06AM -0700, Liu Yi L wrote: [...] > @@ -1256,11 +1334,19 @@ static int vfio_init_container(VFIOContainer > *container, int group_fd, > } > > if (iommu_type == VFIO_TYPE1_NESTING_IOMMU) { > -/* > - * TODO: config flags per host IOMMU

Potential missing checks

2020-03-23 Thread Mansour Ahmadi
Hi QEMU developers, I noticed the following two potential missing checks by static analysis and detecting inconsistencies on the source code of QEMU. here is the result: 1) Missing check on offset: https://github.com/qemu/qemu/blob/c532b954d96f96d361ca31308f75f1b95bd4df76/disas/arm.c#L2728-L2733

Re: [PATCH v4 0/2] Replaced locks with lock guard macros

2020-03-23 Thread Daniel Brodsky
On Mon, Mar 23, 2020 at 6:25 AM Stefan Hajnoczi wrote: > > On Fri, Mar 20, 2020 at 06:43:23AM -0700, no-re...@patchew.org wrote: > > /tmp/qemu-test/src/util/thread-pool.c:213:5: error: unused variable > > 'qemu_lockable_auto1' [-Werror,-Wunused-variable] > > QEMU_LOCK_GUARD(>lock); > > ^

Re: [PATCH v4 0/2] introduction of migration_version attribute for VFIO live migration

2020-03-23 Thread Alex Williamson
On Mon, 3 Jun 2019 20:34:22 -0400 Yan Zhao wrote: > On Tue, Jun 04, 2019 at 03:29:32AM +0800, Alex Williamson wrote: > > On Thu, 30 May 2019 20:44:38 -0400 > > Yan Zhao wrote: > > > > > This patchset introduces a migration_version attribute under sysfs of VFIO > > > Mediated devices. > > >

Re: [PATCH v1 07/22] intel_iommu: add set/unset_iommu_context callback

2020-03-23 Thread Peter Xu
On Sun, Mar 22, 2020 at 05:36:04AM -0700, Liu Yi L wrote: > This patch adds set/unset_iommu_context() impelementation in Intel > vIOMMU. For Intel platform, pass-through modules (e.g. VFIO) could > set HostIOMMUContext to Intel vIOMMU emulator. > > Cc: Kevin Tian > Cc: Jacob Pan > Cc: Peter Xu

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-23 Thread Boris Derzhavets
Works for me. F31 KVM guest is installing on Q9550 box. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866870 Title: KVM Guest pauses after upgrade to Ubuntu 20.04 Status in QEMU: Invalid

Re: [PATCH v1 06/22] hw/pci: introduce pci_device_set/unset_iommu_context()

2020-03-23 Thread Peter Xu
On Sun, Mar 22, 2020 at 05:36:03AM -0700, Liu Yi L wrote: [...] > +AddressSpace *pci_device_iommu_address_space(PCIDevice *dev) > +{ > +PCIBus *bus; > +uint8_t devfn; > + > +pci_device_get_iommu_bus_devfn(dev, , ); > +if (bus && bus->iommu_ops && > +

Re: [PATCH v15 Kernel 3/7] vfio iommu: Add ioctl definition for dirty pages tracking.

2020-03-23 Thread Auger Eric
Hi Kirti, On 3/19/20 9:16 PM, Kirti Wankhede wrote: > IOMMU container maintains a list of all pages pinned by vfio_pin_pages API. > All pages pinned by vendor driver through this API should be considered as > dirty during migration. When container consists of IOMMU capable device and > all pages

Re: [PULL v2 00/37] Linux user for 5.0 patches

2020-03-23 Thread Richard Henderson
On 3/23/20 1:33 PM, Laurent Vivier wrote: > Le 18/03/2020 à 20:46, Richard Henderson a écrit : >> On 3/18/20 6:57 AM, Peter Maydell wrote: >>> My set of "run ls for various architectures" linux-user tests >>> https://people.linaro.org/~peter.maydell/linux-user-test-pmm-20200114.tgz >>> fails with

Re: [PATCH v1 04/22] hw/iommu: introduce HostIOMMUContext

2020-03-23 Thread Peter Xu
On Sun, Mar 22, 2020 at 05:36:01AM -0700, Liu Yi L wrote: > Currently, many platform vendors provide the capability of dual stage > DMA address translation in hardware. For example, nested translation > on Intel VT-d scalable mode, nested stage translation on ARM SMMUv3, > and etc. In dual stage

Re: [PULL 0/5] target-arm queue

2020-03-23 Thread Peter Maydell
On Mon, 23 Mar 2020 at 17:40, Peter Maydell wrote: > > Just a few minor bugfixes, but we might as well get them in > for rc0 tomorrow. > > -- PMM > > The following changes since commit 787f82407c5056a8b1097e39e53d01dd1abe406b: > > Merge remote-tracking branch 'remotes

Re: [PULL v2 00/37] Linux user for 5.0 patches

2020-03-23 Thread Laurent Vivier
Le 18/03/2020 à 20:46, Richard Henderson a écrit : > On 3/18/20 6:57 AM, Peter Maydell wrote: >> My set of "run ls for various architectures" linux-user tests >> https://people.linaro.org/~peter.maydell/linux-user-test-pmm-20200114.tgz >> fails with this pullreq: >> >>

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-23 Thread Andreas Hasenack
apt-get will be enough once it's published, and looks like it just was published. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866870 Title: KVM Guest pauses after upgrade to Ubuntu 20.04

Re: [PATCH v15 Kernel 2/7] vfio iommu: Remove atomicity of ref_count of pinned pages

2020-03-23 Thread Auger Eric
Hi Kirti, On 3/19/20 9:16 PM, Kirti Wankhede wrote: > vfio_pfn.ref_count is always updated by holding iommu->lock, using atomic > variable is overkill. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia Reviewed-by: Eric Auger Thanks Eric > --- > drivers/vfio/vfio_iommu_type1.c | 9

Re: [PATCH v15 Kernel 1/7] vfio: KABI for migration interface for device state

2020-03-23 Thread Auger Eric
Hi Kirti, On 3/19/20 9:16 PM, Kirti Wankhede wrote: > - Defined MIGRATION region type and sub-type. > > - Defined vfio_device_migration_info structure which will be placed at the > 0th offset of migration region to get/set VFIO device related > information. Defined members of structure and

[Bug 1868617] Re: multiseat: route different spice tablet events to distinct vdagents

2020-03-23 Thread dkg
Here are two different ways i can think of to potentially solve this (i'm not qemu hacker, feel free to correct me or propose a better solution): - the spicevmc chardev's "name" parameter could be used to identify the agent numerically (e.g. "vdagent:1" instead of "vdagent") - the -device

[Bug 1868617] [NEW] multiseat: route different spice tablet events to distinct vdagents

2020-03-23 Thread dkg
Public bug reported: docs/multiseat.txt says: > Note on spice: Spice handles multihead just fine. But it can't do > multiseat. For tablet events the event source is sent to the spice > agent. But qemu can't figure it, so it can't do input routing. > Fixing this needs a new or extended input

Re: [PATCH v41 01/21] target/avr: Add outward facing interfaces and core CPU logic

2020-03-23 Thread Michael Rolnik
thanks Philippe. On Mon, Mar 23, 2020 at 9:20 PM Philippe Mathieu-Daudé wrote: > On 3/23/20 7:03 PM, Richard Henderson wrote: > > On 3/23/20 10:03 AM, Michael Rolnik wrote: > >> Hi Philippe. > >> > >> It's been a while. let me think about it and get back to you. what is > your > >> concern ? >

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-23 Thread tstrike
Can I just apt update && apt upgrade to get this fix or do I need to patch? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866870 Title: KVM Guest pauses after upgrade to Ubuntu 20.04 Status in

[PATCH] i386: Remove unused define's from hax and hvf

2020-03-23 Thread Julio Faracco
Commit acb9f95a removed boundary checks for ID and VCPU ID. After that, the max definitions of that boundaries are not required anymore. This commit is only a code cleanup. Signed-off-by: Julio Faracco --- target/i386/hax-i386.h | 2 -- target/i386/hvf/hvf-i386.h | 2 -- 2 files changed, 4

Re: [PATCH v1 for 5.0 00/11] testing/next

2020-03-23 Thread Richard Henderson
On 3/23/20 9:15 AM, Alex Bennée wrote: > Alex Bennée (2): > tests/vm: fix basevm config > configure: disable MTTCG for MIPS guests > > Gerd Hoffmann (4): > tests/vm: write raw console log > tests/vm: move vga setup > tests/vm: update FreeBSD to 12.1 > tests/vm: update NetBSD to 9.0 >

Re: [PATCH-for-5.0 v3] tests/migration: Reduce autoconverge initial bandwidth

2020-03-23 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > When using max-bandwidth=~100Mb/s, this test fails on Travis-CI > s390x when configured with --disable-tcg: > > $ make check-qtest > TESTcheck-qtest-s390x: tests/qtest/boot-serial-test > qemu-system-s390x: -accel tcg: invalid

Re: [PATCH] hw/ide/sii3112: Use qdev gpio rather than qemu_allocate_irqs()

2020-03-23 Thread BALATON Zoltan
On Mon, 23 Mar 2020, John Snow wrote: On 3/23/20 1:04 PM, BALATON Zoltan wrote: On Mon, 23 Mar 2020, Peter Maydell wrote: Coverity points out (CID 1421984) that we are leaking the memory returned by qemu_allocate_irqs(). We can avoid this leak by switching to using qdev_init_gpio_in(); the

[PATCH] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-03-23 Thread Alberto Garcia
A discard request deallocates the selected clusters so they read back as zeroes. This is done by clearing the cluster offset field and setting QCOW_OFLAG_ZERO in the L2 entry. This flag is however only supported when qcow_version >= 3. In older images the cluster is simply deallocated, exposing

Re: [PATCH v11 00/16] s390x: Protected Virtualization support

2020-03-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200319131921.2367-1-fran...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v11 00/16] s390x: Protected Virtualization support Message-id:

[PATCH v2] hw/misc/allwinner-h3-dramc: enforce 64-bit multiply when calculating row mirror address

2020-03-23 Thread Niek Linnenbank
The allwinner_h3_dramc_map_rows function simulates row addressing behavior when bootloader software attempts to detect the amount of available SDRAM. Currently the line that calculates the 64-bit address of the mirrored row uses a signed 32-bit multiply operation that in theory could result in

Re: [PATCH 2/2] hw/misc/allwinner-h3-dramc: enforce 64-bit multiply when calculating row mirror address

2020-03-23 Thread Niek Linnenbank
Hi Peter, On Sun, Mar 22, 2020 at 10:18 PM Peter Maydell wrote: > On Sun, 22 Mar 2020 at 20:54, Niek Linnenbank > wrote: > > > > The allwinner_h3_dramc_map_rows function simulates row addressing > behavior > > when bootloader software attempts to detect the amount of available > SDRAM. > > > >

RE: [PATCH v2 1/1] net/colo-compare.c: Fix memory leak in packet_enqueue()

2020-03-23 Thread Zhang, Chen
> -Original Message- > From: Derek Su > Sent: Monday, March 23, 2020 1:48 AM > To: qemu-devel@nongnu.org > Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; > jasow...@redhat.com; dere...@qnap.com > Subject: [PATCH v2 1/1] net/colo-compare.c: Fix memory leak in > packet_enqueue() > > The

[PULL for-5.0 0/1] Block patches

2020-03-23 Thread Stefan Hajnoczi
The following changes since commit 29e0855c5af62bbb0b0b6fed792e004dad92ba95: Merge remote-tracking branch 'remotes/elmarco/tags/slirp-pull-request' into staging (2020-03-22 21:00:38 +) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/block-pull-request

[PULL for-5.0 1/1] aio-posix: fix io_uring with external events

2020-03-23 Thread Stefan Hajnoczi
When external event sources are disabled fdmon-io_uring falls back to fdmon-poll. The ->need_wait() callback needs to watch for this so it can return true when external event sources are disabled. It is also necessary to call ->wait() when AioHandlers have changed because io_uring is

Re: [PATCH v41 01/21] target/avr: Add outward facing interfaces and core CPU logic

2020-03-23 Thread Philippe Mathieu-Daudé
On 3/23/20 7:03 PM, Richard Henderson wrote: On 3/23/20 10:03 AM, Michael Rolnik wrote: Hi Philippe. It's been a while. let me think about it and get back to you. what is your concern ? We are using this series with Joaquin for a Google Summit of Code project, so we are noticing some bugs

Re: [PATCH v15 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-23 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Mon, 23 Mar 2020 23:24:37 +0530 > Kirti Wankhede wrote: > > > On 3/21/2020 12:29 AM, Alex Williamson wrote: > > > On Sat, 21 Mar 2020 00:12:04 +0530 > > > Kirti Wankhede wrote: > > > > > >> On 3/20/2020 11:31 PM, Alex Williamson

Re: [PATCH-for-5.0 v2 05/11] hw/ide/sii3112: Remove dead assignment

2020-03-23 Thread John Snow
On 3/21/20 10:41 AM, Philippe Mathieu-Daudé wrote: > Fix warning reported by Clang static code analyzer: > > CC hw/ide/sii3112.o > hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read > val = 0; > ^ ~ > > Fixes: a9dd6604 > Reported-by: Clang

Re: [PATCH v15 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-23 Thread Alex Williamson
On Mon, 23 Mar 2020 23:24:37 +0530 Kirti Wankhede wrote: > On 3/21/2020 12:29 AM, Alex Williamson wrote: > > On Sat, 21 Mar 2020 00:12:04 +0530 > > Kirti Wankhede wrote: > > > >> On 3/20/2020 11:31 PM, Alex Williamson wrote: > >>> On Fri, 20 Mar 2020 23:19:14 +0530 > >>> Kirti Wankhede

Re: [PATCH] ide/sii3112: Avoid leaking irqs array

2020-03-23 Thread John Snow
On 3/23/20 10:32 AM, BALATON Zoltan wrote: > Coverity CID 1421984 reports a leak in allocated irqs, this patch > attempts to plug that. > > Signed-off-by: BALATON Zoltan Dequeueing in favor of Peter Maydell's patch. (Let me know if you feel that is a mistake.)

Re: [PATCH] hw/ide/sii3112: Use qdev gpio rather than qemu_allocate_irqs()

2020-03-23 Thread John Snow
On 3/23/20 1:04 PM, BALATON Zoltan wrote: > On Mon, 23 Mar 2020, Peter Maydell wrote: >> Coverity points out (CID 1421984) that we are leaking the >> memory returned by qemu_allocate_irqs(). We can avoid this >> leak by switching to using qdev_init_gpio_in(); the base >> class finalize will

Re: [PATCH v4 2/2] target/arm: kvm: Handle potential issue with dabt injection

2020-03-23 Thread Richard Henderson
On 3/23/20 4:32 AM, Beata Michalska wrote: > uint8_t ext_dabt_pending; /* Request for injecting ext DABT */ > +uint8_t ext_dabt_raised; /* Tracking/verifying injection of ext DABT */ Is there a reason these are uint8_t and not bool? r~

[PATCH-for-5.0 v3] tests/migration: Reduce autoconverge initial bandwidth

2020-03-23 Thread Philippe Mathieu-Daudé
When using max-bandwidth=~100Mb/s, this test fails on Travis-CI s390x when configured with --disable-tcg: $ make check-qtest TESTcheck-qtest-s390x: tests/qtest/boot-serial-test qemu-system-s390x: -accel tcg: invalid accelerator tcg qemu-system-s390x: falling back to KVM TEST

Re: [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model

2020-03-23 Thread Eduardo Habkost
On Mon, Mar 23, 2020 at 10:58:16AM +0800, Xiaoyao Li wrote: > On 3/23/2020 10:32 AM, Tao Xu wrote: > > Hi Xiaoyao, > > > > May be you can add .note for this new version. > > > > for example: > > > > +    .version = 3, > > +    .note = "ARCH_CAPABILITIES", > > +   

How do I use patchew to be a good block-devel citizen? (was: Re: [PATCH] iotests/026: Move v3-exclusive test to new file)

2020-03-23 Thread John Snow
On 3/23/20 8:23 AM, Max Reitz wrote: > On 12.03.20 23:19, John Snow wrote: >> >> >> On 3/11/20 10:07 AM, Max Reitz wrote: >>> data_file does not work with v2, and we probably want 026 to keep >>> working for v2 images. Thus, open a new file for v3-exclusive error >>> path test cases. >>> >>>

Re: [PATCH v2] target/i386: set the CPUID level to 0x14 on old machine-type

2020-03-23 Thread Eduardo Habkost
On Fri, Mar 13, 2020 at 12:48:06AM +0800, Luwei Kang wrote: > The CPUID level need to be set to 0x14 manually on old > machine-type if Intel PT is enabled in guest. E.g. the > CPUID[0].EAX(level)=7 and CPUID[7].EBX[25](intel-pt)=1 when the > Qemu with "-machine pc-i440fx-3.1 -cpu qemu64,+intel-pt"

Re: [PATCH 3/3] iotests: Increase pause_wait() timeout

2020-03-23 Thread John Snow
On 3/20/20 6:21 AM, Philippe Mathieu-Daudé wrote: > On 3/13/20 9:36 AM, Kevin Wolf wrote: >> Waiting for only 1 second proved to be too short on a loaded system, >> resulting in false positives when testing pull requests. Increase the >> timeout a bit to make this less likely. >> >>

Re: [PATCH v1 11/11] .travis.yml: Add a KVM-only s390x job

2020-03-23 Thread Richard Henderson
On 3/23/20 9:15 AM, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > Add a job to build QEMU on s390x with TCG disabled, so > this configuration won't bitrot over time. > > This job is quick, running check-unit: Ran for 5 min 30 sec > https://travis-ci.org/github/philmd/qemu/jobs/665456423

Re: [PATCH v1 10/11] tests/docker: Add libepoxy and libudev packages to the Fedora image

2020-03-23 Thread Richard Henderson
On 3/23/20 9:15 AM, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > Install optional dependencies of QEMU to get better coverage. > > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > Signed-off-by: Alex Bennée > Message-Id:

Re: [PATCH v1 08/11] tests/docker: Install gcrypt devel package in Debian image

2020-03-23 Thread Richard Henderson
On 3/23/20 9:15 AM, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > In commit 6f8bbb374be we enabled building with the gcrypt library > on the the Debian 'x86 host', which was based on Debian Stretch. > Later in commit 698a71edbed we upgraded the Debian base image to > Buster. > >

Re: [PATCH v1 09/11] tests/docker: Use Python3 PyYAML in the Fedora image

2020-03-23 Thread Richard Henderson
On 3/23/20 9:15 AM, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > The Python2 PyYAML is now pointless, switch to the Python3 version. > > Fixes: bcbf27947 (docker: move tests from python2 to python3) > Signed-off-by: Philippe Mathieu-Daudé > Signed-off-by: Alex Bennée > Message-Id:

Re: [PATCH v1 07/11] tests/docker: Keep package list sorted

2020-03-23 Thread Richard Henderson
On 3/23/20 9:15 AM, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > Keep package list sorted, this eases rebase/cherry-pick. > > Fixes: 3a6784813 > Signed-off-by: Philippe Mathieu-Daudé > Signed-off-by: Alex Bennée > Message-Id: <20200322120104.21267-2-phi...@redhat.com> > --- >

Re: [PATCH v1 06/11] configure: disable MTTCG for MIPS guests

2020-03-23 Thread Richard Henderson
On 3/23/20 9:15 AM, Alex Bennée wrote: > While debugging check-acceptance failures I found an instability in > the mips64el test case. Briefly the test case: > > retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ > -display none -vga none -serial mon:stdio \ > -machine

Re: aio-context question

2020-03-23 Thread Dietmar Maurer
> If it doesn't have any effect because it just does what will be done > later anyway, it can be removed, but that doesn't buy us much. I think that code is simply unnecessary (no effect). But it is quite hard to read and understand, so I think removing that code helps to simplify things. > If

Re: [PATCH v5 3/4] qmp: Move dispatcher to a coroutine

2020-03-23 Thread Marc-André Lureau
Hi On Mon, Mar 23, 2020 at 6:41 PM Kevin Wolf wrote: > > Am 18.03.2020 um 16:36 hat Markus Armbruster geschrieben: > > Kevin Wolf writes: > > > > > This moves the QMP dispatcher to a coroutine and runs all QMP command > > > handlers that declare 'coroutine': true in coroutine context so they >

Re: [PATCH v41 01/21] target/avr: Add outward facing interfaces and core CPU logic

2020-03-23 Thread Richard Henderson
On 3/23/20 10:03 AM, Michael Rolnik wrote: > Hi Philippe. > > It's been a while. let me think about it and get back to you. what is your > concern ?  It shouldn't be there. See commit 1f5c00cfdb81. > > +    memset(env->r, 0, sizeof(env->r)); > > + > > +    tlb_flush(cs); > >

[Bug 1868527] Re: alignment may overlap the TLB flags

2020-03-23 Thread Richard Henderson
That is of course completely dependent on the target page size. So, yes, a target with a very small page size cannot use large alignments. The assert makes sure. Is this comment simply by inspection, or did you have an actual bug to report? ** Changed in: qemu Status: New => Incomplete

Re: [PATCH v15 Kernel 4/7] vfio iommu: Implementation of ioctl for dirty pages tracking.

2020-03-23 Thread Kirti Wankhede
On 3/21/2020 12:29 AM, Alex Williamson wrote: On Sat, 21 Mar 2020 00:12:04 +0530 Kirti Wankhede wrote: On 3/20/2020 11:31 PM, Alex Williamson wrote: On Fri, 20 Mar 2020 23:19:14 +0530 Kirti Wankhede wrote: On 3/20/2020 4:27 AM, Alex Williamson wrote: On Fri, 20 Mar 2020 01:46:41

Re: [PATCH v5 09/60] target/riscv: vector single-width integer add and subtract

2020-03-23 Thread Richard Henderson
On 3/23/20 1:10 AM, LIU Zhiwei wrote: >> static void gen_gvec_rsubi(unsigned vece, uint32_t dofs, >> uint32_t aofs, int64_t c, >> uint32_t oprsz, uint32_t maxsz) >> { >> tcg_debug_assert(vece <= MO_64); >> tcg_gen_gvec_2i(dofs, aofs, oprsz, maxsz, c, _op[vece]); >> } > Hi Richard,

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-23 Thread Launchpad Bug Tracker
This bug was fixed in the package seabios - 1.13.0-1ubuntu1 --- seabios (1.13.0-1ubuntu1) focal; urgency=medium * d/p/lp-1866870-build-use-fcf-protection-none-when-available.patch fix breakage on older chips due to fcf-protection (LP: #1866870) -- Christian Ehrhardt Thu, 19

[PULL 2/5] aspeed/smc: Fix DMA support for AST2600

2020-03-23 Thread Peter Maydell
From: Cédric Le Goater Recent firmwares uses SPI DMA transfers in U-Boot to load the different images (kernel, initrd, dtb) in the SoC DRAM. The AST2600 FMC model is missing the masks to be applied on the DMA registers which resulted in incorrect values. Fix that and wire the SPI controllers

Re: [PATCH v5 3/4] qmp: Move dispatcher to a coroutine

2020-03-23 Thread Kevin Wolf
Am 18.03.2020 um 16:36 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > This moves the QMP dispatcher to a coroutine and runs all QMP command > > handlers that declare 'coroutine': true in coroutine context so they > > can avoid blocking the main loop while doing I/O or waiting for

[PULL 1/5] hw/arm/bcm283x: Correct the license text

2020-03-23 Thread Peter Maydell
From: Philippe Mathieu-Daudé The license is the 'GNU General Public License v2.0 or later', not 'and': This program is free software; you can redistribute it and/ori modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2

[PULL 0/5] target-arm queue

2020-03-23 Thread Peter Maydell
Just a few minor bugfixes, but we might as well get them in for rc0 tomorrow. -- PMM The following changes since commit 787f82407c5056a8b1097e39e53d01dd1abe406b: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20200323' into staging (2020-03-23 15:38:30 +) are available

[PULL 3/5] target/arm: Rearrange disabled check for watchpoints

2020-03-23 Thread Peter Maydell
From: Richard Henderson Coverity rightly notes that ctz32(bas) on 0 will return 32, which makes the len calculation a BAD_SHIFT. A value of 0 in DBGWCR_EL1.BAS is reserved. Simply move the existing check we have for this case. Reported-by: Coverity (CID 1421964) Signed-off-by: Richard

[PULL 4/5] target/arm: Assert immh != 0 in disas_simd_shift_imm

2020-03-23 Thread Peter Maydell
From: Richard Henderson Coverity raised a shed-load of errors cascading from inferring that clz32(immh) might yield 32, from immh might be 0. While immh cannot be 0 from encoding, it is not obvious even to a human how we've checked that: via the filtering provided by data_proc_simd[].

[PULL 5/5] target/arm: Move computation of index in handle_simd_dupe

2020-03-23 Thread Peter Maydell
From: Richard Henderson Coverity reports a BAD_SHIFT with ctz32(imm5), with imm5 == 0. This is an invalid encoding, but we diagnose that just below by rejecting size > 3. Avoid the warning by sinking the computation of index below the check. Reported-by: Coverity (CID 1421965) Signed-off-by:

Re: [PATCH] target/mips: Fix loongson multimedia condition instructions

2020-03-23 Thread Richard Henderson
On 3/20/20 9:56 PM, Jiaxun Yang wrote: > case OPC_SLE_CP2: > -/* > - * ??? Document is unclear: Set FCC[CC]. Does that mean the > - * FD field is the CC field? > - */ > +cond = TCG_COND_LE; > +do_cc_cond: > +{ > +int cc =

Re: [PATCH v11 00/16] s390x: Protected Virtualization support

2020-03-23 Thread Cornelia Huck
On Thu, 19 Mar 2020 09:19:05 -0400 Janosch Frank wrote: > Most of the QEMU changes for PV are related to the new IPL type with > subcodes 8 - 10 and the execution of the necessary Ultravisor calls to > IPL secure guests. Note that we can only boot into secure mode from > normal mode, i.e. stfle

Re: [PATCH] hw/ide/sii3112: Use qdev gpio rather than qemu_allocate_irqs()

2020-03-23 Thread Peter Maydell
On Mon, 23 Mar 2020 at 17:04, BALATON Zoltan wrote: > > On Mon, 23 Mar 2020, Peter Maydell wrote: > > Coverity points out (CID 1421984) that we are leaking the > > memory returned by qemu_allocate_irqs(). We can avoid this > > leak by switching to using qdev_init_gpio_in(); the base > > class

  1   2   3   >