From: Richard Henderson
Coverity reports a BAD_SHIFT with ctz32(imm5), with imm5 == 0.
This is an invalid encoding, but we diagnose that just below
by rejecting size > 3. Avoid the warning by sinking the
computation of index below the check.
Reported-by: Coverity (CID 1421965)
Signed-off-by: Ri
On 3/20/20 9:56 PM, Jiaxun Yang wrote:
> case OPC_SLE_CP2:
> -/*
> - * ??? Document is unclear: Set FCC[CC]. Does that mean the
> - * FD field is the CC field?
> - */
> +cond = TCG_COND_LE;
> +do_cc_cond:
> +{
> +int cc = (ctx->o
On Thu, 19 Mar 2020 09:19:05 -0400
Janosch Frank wrote:
> Most of the QEMU changes for PV are related to the new IPL type with
> subcodes 8 - 10 and the execution of the necessary Ultravisor calls to
> IPL secure guests. Note that we can only boot into secure mode from
> normal mode, i.e. stfle 1
On Mon, 23 Mar 2020 at 17:04, BALATON Zoltan wrote:
>
> On Mon, 23 Mar 2020, Peter Maydell wrote:
> > Coverity points out (CID 1421984) that we are leaking the
> > memory returned by qemu_allocate_irqs(). We can avoid this
> > leak by switching to using qdev_init_gpio_in(); the base
> > class fina
Hi,
Since bd457782b3b0 ("x86/pc: use memdev for RAM") it isn't possible to
start Xen guest anymore.
The error from qemu:
qemu-system-i386: xen: failed to populate ram at 0
that comes from xen_ram_alloc() in hw/i386/xen/xen-hvm.c
xen_ram_alloc() is used to populate ram for PCI rom devices for
Am 19.03.2020 um 09:13 hat Dietmar Maurer geschrieben:
> I just saw commit 30dd65f307b647eef8156c4a33bd007823ef85cb, and noticed that
> a similar pattern in drive_backup_prepare() and blockdev_backup_prepare().
>
> The calls to bdrv_try_set_aio_context() seems useless, because we already do
> tha
On Mon, 23 Mar 2020 at 16:16, yoma sophian wrote:
>
> hi Peter:
> > Is it possible for you to try with a newer version of QEMU? That one
> > is a release candidate snapshot from before a release that we made
> > a year ago.
> With below qemu version, 4.2.0, the latest on the qemu windows download
On Mon, 23 Mar 2020, Peter Maydell wrote:
Coverity points out (CID 1421984) that we are leaking the
memory returned by qemu_allocate_irqs(). We can avoid this
leak by switching to using qdev_init_gpio_in(); the base
class finalize will free the irqs that this allocates under
the hood.
Signed-off
Hi Philippe.
It's been a while. let me think about it and get back to you. what is your
concern ?
Regards,
Michael Rolnik
On Mon, Mar 23, 2020 at 5:55 PM Philippe Mathieu-Daudé
wrote:
> Hi Michael,
>
> On 1/18/20 8:13 PM, Michael Rolnik wrote:
> > This includes:
> > - CPU data structures
> > -
Am 11.03.2020 um 04:29 hat Chen Qun geschrieben:
> Clang static code analyzer show warning:
> block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read
> flags &= ~BDRV_O_RDWR;
> ^
>
> In iscsi_allocmap_init() only checks BDRV_O_NOCACHE, which
> is
The function usbback_packet_complete() currently takes a USBPacket*,
which must be a pointer to the packet field within a struct
usbback_req; the function uses container_of() to get the struct
usbback_req* given the USBPacket*.
This is unnecessarily confusing (and in particular it confuses the
Cov
On 3/23/20 5:35 PM, Aurelien Jarno wrote:
Hi,
Sorry for the delay, I just want to give some more details about the
Debian.
On 2020-03-14 10:09, Philippe Mathieu-Daudé wrote:
IIUC today all distributions supporting MIPS ports are building their MIPS
packages on QEMU instances because it is fast
Hi,
Sorry for the delay, I just want to give some more details about the
Debian.
On 2020-03-14 10:09, Philippe Mathieu-Daudé wrote:
> IIUC today all distributions supporting MIPS ports are building their MIPS
> packages on QEMU instances because it is faster than the native MIPS
> hardware they h
On 3/23/20 5:15 PM, Alex Bennée wrote:
From: Gerd Hoffmann
Move '-device VGA' from basevm.py to the guests, so they have
the chance to opt out and run without display device.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Alex Bennée
Message-Id: <20200310083218.26355-3-kra...@redhat.com>
Alre
ilable in the Git repository at:
>
> https://github.com/cohuck/qemu tags/s390x-20200323
>
> for you to fetch changes up to 7722837369eb1c7e808021d79da68afa0c01c26f:
>
> s390/ipl: fix off-by-one in update_machi
On 3/23/20 5:15 PM, Alex Bennée wrote:
When the patch was merged it was part of a longer series which had
already merged the config changes. Semu-revert the config related
Typo "semi-revert"?
changes for now so things will build.
Fixes: b081986c85fd2
Signed-off-by: Alex Bennée
---
tests/v
On 3/23/20 5:15 PM, Alex Bennée wrote:
While debugging check-acceptance failures I found an instability in
the mips64el test case. Briefly the test case:
retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \
-display none -vga none -serial mon:stdio \
-machine malta -kerne
hi Peter:
> Is it possible for you to try with a newer version of QEMU? That one
> is a release candidate snapshot from before a release that we made
> a year ago.
With below qemu version, 4.2.0, the latest on the qemu windows download page,
Synchronous External Abort still happen with the problem
From: Philippe Mathieu-Daudé
Keep package list sorted, this eases rebase/cherry-pick.
Fixes: 3a6784813
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
Message-Id: <20200322120104.21267-2-phi...@redhat.com>
---
tests/docker/dockerfiles/centos7.docker | 6 --
tests/docker/d
From: Philippe Mathieu-Daudé
Install optional dependencies of QEMU to get better coverage.
Suggested-by: Peter Maydell
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
Message-Id: <20200322120104.21267-5-phi...@redhat.com>
---
tests/docker/dockerfiles/fedora.docker | 2 ++
1
From: Philippe Mathieu-Daudé
Add a job to build QEMU on s390x with TCG disabled, so
this configuration won't bitrot over time.
This job is quick, running check-unit: Ran for 5 min 30 sec
https://travis-ci.org/github/philmd/qemu/jobs/665456423
Acked-by: Cornelia Huck
Signed-off-by: Philippe Mat
From: Philippe Mathieu-Daudé
In commit 6f8bbb374be we enabled building with the gcrypt library
on the the Debian 'x86 host', which was based on Debian Stretch.
Later in commit 698a71edbed we upgraded the Debian base image to
Buster.
Apparently Debian Stretch was listing gcrypt as a QEMU dependen
From: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann
Signed-off-by: Alex Bennée
Message-Id: <20200310083218.26355-4-kra...@redhat.com>
---
tests/vm/freebsd | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/vm/freebsd b/tests/vm/freebsd
index 58166766d91..298967fe9cf 100
While debugging check-acceptance failures I found an instability in
the mips64el test case. Briefly the test case:
retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \
-display none -vga none -serial mon:stdio \
-machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \
-cpu I6400
From: Philippe Mathieu-Daudé
The Python2 PyYAML is now pointless, switch to the Python3 version.
Fixes: bcbf27947 (docker: move tests from python2 to python3)
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
Message-Id: <20200322120104.21267-4-phi...@redhat.com>
---
tests/dock
From: Gerd Hoffmann
Move '-device VGA' from basevm.py to the guests, so they have
the chance to opt out and run without display device.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Alex Bennée
Message-Id: <20200310083218.26355-3-kra...@redhat.com>
---
tests/vm/basevm.py | 1 -
tests/vm/fedor
When the patch was merged it was part of a longer series which had
already merged the config changes. Semu-revert the config related
changes for now so things will build.
Fixes: b081986c85fd2
Signed-off-by: Alex Bennée
---
tests/vm/basevm.py | 16
1 file changed, 8 insertions(+)
Hi,
This is the current testing/next queue. I've re-instated Gerd's VM
patches after I tracked down the failure to a weird interaction
between check-acceptance and the @skipIf changes I had in my tree.
I've re-run all BSD builds with check-unit and it seems sound.
The following still need review:
From: Gerd Hoffmann
Run "tail -f /var/tmp/*/qemu*console.raw" in another terminal
to watch the install console.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Alex Bennée
Message-Id: <20200310083218.26355-2-kra...@redhat.com>
---
tests/vm/basevm.py | 6 ++
1 file changed, 6 insertions(+)
di
From: Gerd Hoffmann
The installer supports GPT now, so the install workflow has changed a
bit. Also: run without VGA device. This works around a bug in the
seabios sercon code and makes the bootloader menu show up on the serial
line, so we can drop the quirk for that.
Signed-off-by: Gerd Hoffm
On Fri, 20 Mar 2020 18:25:18 +0100
Cornelia Huck wrote:
> On Fri, 20 Mar 2020 15:31:01 +0100
> Halil Pasic wrote:
>
> > In update_machine_ipl_properties() the array ascii_loadparm needs to
> > hold the 8 char lodparm and a string terminating zero char.
>
> s/lodparm/loadparm/
>
> > Let's incr
On Mon, Mar 09, 2020 at 06:03:39PM +0800, Coiby Xu wrote:
> diff --git a/util/Makefile.objs b/util/Makefile.objs
> index 6b38b67cf1..d207b5f981 100644
> --- a/util/Makefile.objs
> +++ b/util/Makefile.objs
> @@ -37,6 +37,9 @@ util-obj-y += readline.o
> util-obj-y += rcu.o
> util-obj-$(CONFIG_MEMBA
On Sat, Mar 21, 2020 at 7:50 AM Philippe Mathieu-Daudé
wrote:
>
> pxa2xx_timer_tick4() takes an opaque pointer, then calls
> pxa2xx_timer_update4(), so the static analyzer can not
> verify that the 'n < 8':
>
> 425 static void pxa2xx_timer_tick4(void *opaque)
> 426 {
> 427 PXA2xxTimer4 *
On Sat, Mar 21, 2020 at 7:52 AM Philippe Mathieu-Daudé
wrote:
>
> Fix warning reported by Clang static code analyzer:
>
> CC hw/timer/stm32f2xx_timer.o
> hw/timer/stm32f2xx_timer.c:225:9: warning: Value stored to 'value' is never
> read
> value = timer_val;
> ^
On Sat, Mar 21, 2020 at 7:50 AM Philippe Mathieu-Daudé
wrote:
>
> Fix warnings reported by Clang static code analyzer:
>
> hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never
> read
> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> ^ ~~
23.03.2020 17:25, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.
It is implied that the compression type is set on the image creation and
can be cha
On Sat, Mar 21, 2020 at 7:46 AM Philippe Mathieu-Daudé
wrote:
>
> Rename the unique variable assigned as 'pit' which better
> represents what it holds, to fix a warning reported by the
> Clang static code analyzer:
>
> CC hw/isa/i82378.o
> hw/isa/i82378.c:108:5: warning: Value stored to
On Sat, Mar 21, 2020 at 7:45 AM Philippe Mathieu-Daudé
wrote:
>
> Fix warning reported by Clang static code analyzer:
>
> CC hw/i2c/pm_smbus.o
> hw/i2c/pm_smbus.c:187:17: warning: Value stored to 'ret' is never read
> ret = 0;
> ^ ~
>
> Reported-b
On Sat, Mar 21, 2020 at 7:42 AM Philippe Mathieu-Daudé
wrote:
>
> Fix warning reported by Clang static code analyzer:
>
> block.c:3167:5: warning: Value stored to 'ret' is never read
> ret = bdrv_fill_options(&options, filename, &flags, &local_err);
> ^ ~~
Hi Michael,
On 1/18/20 8:13 PM, Michael Rolnik wrote:
This includes:
- CPU data structures
- object model classes and functions
- migration functions
- GDB hooks
Co-developed-by: Michael Rolnik
Co-developed-by: Sarah Harris
Signed-off-by: Michael Rolnik
Signed-off-by: Sarah Harris
Signed-of
On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote:
On 3/23/20 3:32 PM, BALATON Zoltan wrote:
Coverity CID 1421984 reports a leak in allocated irqs, this patch
attempts to plug that.
Signed-off-by: BALATON Zoltan
---
hw/ide/sii3112.c | 14 +++---
1 file changed, 11 insertions(+), 3 d
On Mon, 23 Mar 2020 at 11:42, Laurent Vivier wrote:
>
> This is mostly a fix for in-tree build.
>
> It removes errors on .d directories:
>
> grep: ./.gitlab-ci.d: Is a directory
> grep: ./scripts/qemu-guest-agent/fsfreeze-hook.d: Is a directory
>
> and improves performance by only checking -li
[AMD Official Use Only - Internal Distribution Only]
> -Original Message-
> From: Igor Mammedov
> Sent: Wednesday, March 18, 2020 5:47 AM
> To: Moger, Babu
> Cc: Eduardo Habkost ; marcel.apfelb...@gmail.com;
> pbonz...@redhat.com; r...@twiddle.net; m...@redhat.com; qemu-
> de...@nongnu.o
On 3/23/20 4:17 PM, Peter Maydell wrote:
Coverity points out (CID 1421984) that we are leaking the
memory returned by qemu_allocate_irqs(). We can avoid this
leak by switching to using qdev_init_gpio_in(); the base
class finalize will free the irqs that this allocates under
the hood.
Signed-off-
On Mon, 23 Mar 2020 at 15:28, BALATON Zoltan wrote:
> Is this documented anywhere?
Unfortunately not. You're quite right that we should document this
(I hadn't realized/had forgotten that the qdev gpio APIs are
entirely undocumented -- they date from a time when we were
much less strict about ask
On Wed, 11 Mar 2020 17:20:13 +
Shameer Kolothum wrote:
SUBJ is pointless,
s/Update.../
arm/virt: test pc-dimm and nvdimm coldplug
> Since we now have both pc-dimm and nvdimm support, update
> test_acpi_virt_tcg_memhp() to include those.
>
> Signed-off-by: Shameer Kolothum
> ---
> v2 -> v3
On 3/23/20 3:46 PM, Peter Maydell wrote:
On Mon, 23 Mar 2020 at 14:43, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Peter Maydell wrote:
On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Peter Maydell wrote:
Coverity has flagged up a lot of leaks involving qemu_allocat
On Mon, 23 Mar 2020, Peter Maydell wrote:
On Mon, 23 Mar 2020 at 14:43, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Peter Maydell wrote:
On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Peter Maydell wrote:
Coverity has flagged up a lot of leaks involving qemu_allocat
On Wed, 11 Mar 2020 17:20:10 +
Shameer Kolothum wrote:
> From: Kwangwoo Lee
>
> This adds support to init nvdimm acpi state and build nvdimm acpi tables.
> Please note nvdimm_support is not yet enabled.
>
> Signed-off-by: Kwangwoo Lee
> Signed-off-by: Eric Auger
> Signed-off-by: Shameer
Coverity points out (CID 1421984) that we are leaking the
memory returned by qemu_allocate_irqs(). We can avoid this
leak by switching to using qdev_init_gpio_in(); the base
class finalize will free the irqs that this allocates under
the hood.
Signed-off-by: Peter Maydell
---
This is how the 'use
On Wed, 11 Mar 2020 17:20:09 +
Shameer Kolothum wrote:
> From: Kwangwoo Lee
>
> This patch makes IO base and size configurable to create NPIO AML for
> ACPI NFIT. Since a different architecture like AArch64 does not use
> port-mapped IO, a configurable IO base is required to create correct
On 3/23/20 3:55 PM, Laurent Vivier wrote:
Le 23/03/2020 à 15:45, Philippe Mathieu-Daudé a écrit :
On 3/23/20 3:32 PM, Laurent Vivier wrote:
Le 21/03/2020 à 15:40, Philippe Mathieu-Daudé a écrit :
Fix trivial warnings reported by the Clang static code analyzer.
Since v1:
- Addressed Markus/Zol
On Wed, 11 Mar 2020 17:20:08 +
Shameer Kolothum wrote:
> As per ACPI spec 6.3, Table 19-419 Object Conversion Rules, if
> the Buffer Field <= to the size of an Integer (in bits), it will
> be treated as an integer. Moreover, the integer size depends on
> DSDT tables revision number. If revisi
Le 23/03/2020 à 15:45, Philippe Mathieu-Daudé a écrit :
> On 3/23/20 3:32 PM, Laurent Vivier wrote:
>> Le 21/03/2020 à 15:40, Philippe Mathieu-Daudé a écrit :
>>> Fix trivial warnings reported by the Clang static code analyzer.
>>>
>>> Since v1:
>>> - Addressed Markus/Zoltan/Aleksandar review comme
On 3/23/20 3:32 PM, BALATON Zoltan wrote:
Coverity CID 1421984 reports a leak in allocated irqs, this patch
attempts to plug that.
Signed-off-by: BALATON Zoltan
---
hw/ide/sii3112.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/hw/ide/sii3112.c b/hw/ide/
On Mon, Mar 09, 2020 at 06:03:38PM +0800, Coiby Xu wrote:
> diff --git a/contrib/libvhost-user/libvhost-user.h
> b/contrib/libvhost-user/libvhost-user.h
> index 6fc8000e99..7e3f0c8598 100644
> --- a/contrib/libvhost-user/libvhost-user.h
> +++ b/contrib/libvhost-user/libvhost-user.h
> @@ -30,6 +30,
On Mon, 23 Mar 2020 at 14:43, BALATON Zoltan wrote:
>
> On Mon, 23 Mar 2020, Peter Maydell wrote:
> > On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote:
> >> On Mon, 23 Mar 2020, Peter Maydell wrote:
> >>> Coverity has flagged up a lot of leaks involving qemu_allocate_irqs();
> >>> most of them
On 3/23/20 3:32 PM, Laurent Vivier wrote:
Le 21/03/2020 à 15:40, Philippe Mathieu-Daudé a écrit :
Fix trivial warnings reported by the Clang static code analyzer.
Since v1:
- Addressed Markus/Zoltan/Aleksandar review comments
Philippe Mathieu-Daudé (11):
block: Avoid dead assignment
bloc
On Mon, Mar 23, 2020 at 7:30 AM Oksana Vohchana wrote:
>
> In the migration test function _get_free_port works only for localhost,
> but in the case to use migration through an RDMA we need to get a free port
> on the configured network RDMA-interface.
> This patch is the start for another migrati
Hi,
On 3/19/20 2:09 PM, Alex Williamson wrote:
> On Thu, 19 Mar 2020 01:05:54 -0400
> Yan Zhao wrote:
>
>> On Thu, Mar 19, 2020 at 11:49:26AM +0800, Alex Williamson wrote:
>>> On Wed, 18 Mar 2020 21:17:03 -0400
>>> Yan Zhao wrote:
>>>
On Thu, Mar 19, 2020 at 03:41:08AM +0800, Kirti Wank
On Mon, 23 Mar 2020, Peter Maydell wrote:
On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Peter Maydell wrote:
Coverity has flagged up a lot of leaks involving qemu_allocate_irqs();
most of them I've for the moment just set as "insignificant, fix
required" because they
Coverity CID 1421984 reports a leak in allocated irqs, this patch
attempts to plug that.
Signed-off-by: BALATON Zoltan
---
hw/ide/sii3112.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c
index 06605d7af2..c886916873 100644
On Mon, 23 Mar 2020 at 14:06, BALATON Zoltan wrote:
> On Mon, 23 Mar 2020, Peter Maydell wrote:
> > Coverity has flagged up a lot of leaks involving qemu_allocate_irqs();
> > most of them I've for the moment just set as "insignificant, fix
> > required" because they're in called-once functions lik
Le 21/03/2020 à 15:41, Philippe Mathieu-Daudé a écrit :
> Fix warning reported by Clang static code analyzer:
>
> CC hw/scsi/esp-pci.o
> hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read
> size = 4;
> ^ ~
>
> Reported-by: Clang Static Analy
Le 21/03/2020 à 15:40, Philippe Mathieu-Daudé a écrit :
> Fix trivial warnings reported by the Clang static code analyzer.
>
> Since v1:
> - Addressed Markus/Zoltan/Aleksandar review comments
>
> Philippe Mathieu-Daudé (11):
> block: Avoid dead assignment
> blockdev: Remove dead assignment
>
zstd significantly reduces cluster compression time.
It provides better compression performance maintaining
the same level of the compression ratio in comparison with
zlib, which, at the moment, is the only compression
method available.
The performance test results:
Test compresses and decompresse
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters (de)compressing.
It is implied that the compression type is set on the image creation and
can be changed only later by image conversion, thus c
v9:
* 01: fix error checking and reporting in qcow2_amend compression type part
[Vladimir]
* 03: replace asserts with -EIO in qcow2_zstd_decompression [Vladimir,
Alberto]
* 03: reword/amend/add comments, fix typos [Vladimir]
v8:
* 03: switch zstd API from simple to stream [Eric]
The patch enables processing the image compression type defined
for the image and chooses an appropriate method for image clusters
(de)compression.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
---
block/qcow2-threads.c | 71 ++
The test checks fulfilling qcow2 requiriements for the compression
type feature and zstd compression type operability.
Signed-off-by: Denis Plotnikov
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/287 | 128 +
tests/qemu-iotests/287.out
On 16.03.20 07:06, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> I faced use-after-free of bs->backing pointer after bdrv_unref_child in
> bdrv_set_backing_hd.
>
> Fix it, and do similar thing for s->data_file in qcow2.c.
>
> I'm not sure that this is the full fix. Is it safe to keep bs->bac
On Mon, 23 Mar 2020, Peter Maydell wrote:
On Mon, 23 Mar 2020 at 13:12, BALATON Zoltan wrote:
On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote:
Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board.
On 3/23/20 12:46 PM, Max Reitz wrote:
Hi,
I was triaging new Coverity block l
> -Original Message-
> From: Igor Mammedov [mailto:imamm...@redhat.com]
> Sent: 23 March 2020 12:35
> To: Shameerali Kolothum Thodi
> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org;
> eric.au...@redhat.com; peter.mayd...@linaro.org;
> xiaoguangrong.e...@gmail.com; da...@redhat.com; m...
On Mon, Mar 23, 2020 at 12:29:40PM +0100, Philippe Mathieu-Daudé wrote:
> Coverity reported a ALLOC_FREE_MISMATCH in vg_handle_cursor(),
> because the memory returned by vu_queue_pop() is allocated with
> malloc(). Fix it.
>
> Similar error occurs with virtio. Document and fix.
I will queue this.
On Mon, 23 Mar 2020 at 13:34, yoma sophian wrote:
> My environment are:
> 1. the versionof qemu-system-aarch64 windows binary is 4.0.92
Is it possible for you to try with a newer version of QEMU? That one
is a release candidate snapshot from before a release that we made
a year ago.
thanks
-- PM
On 18.03.20 23:22, Philippe Mathieu-Daudé wrote:
> bdrv_do_find_format() calls strcmp() using BlockDriver::format_name
> as argument, which must not be NULL. Assert this field is not null
> when we register a block driver in bdrv_register().
>
> Reported-by: Mansour Ahmadi
> Signed-off-by: Philip
On Mon, 23 Mar 2020 at 13:12, BALATON Zoltan wrote:
>
> On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote:
> > Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board.
> > On 3/23/20 12:46 PM, Max Reitz wrote:
> >> Hi,
> >>
> >> I was triaging new Coverity block layer reports today, a
On 20.03.20 19:36, Eric Blake wrote:
> If we fail to get bitmap info, we must not leak the encryption info.
>
> Fixes: b8968c875f403
> Fixes: Coverity CID 1421894
> Signed-off-by: Eric Blake
> ---
> block/qcow2.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block branch:
https
On Sat, Mar 21, 2020 at 11:50:23PM +0100, BALATON Zoltan wrote:
> On Sat, 21 Mar 2020, Peter Maydell wrote:
> > AIUI from Paolo, the intention is to deprecate and eventually
> > stop supporting "in-tree" builds, so that the only option is
> > building in a separate build directory. I thought we sho
hi all:
I try to use qemu-system-aarch64 windows binary for running arm64
defconfig kernel image but get Synchronous External Abort while
booting PCI devices.
The same Image that run on qemu-system-aarch64 linux binary is fine.
Is there any pci related kernel config need to be removed while using
q
the G_IO_HUP is watched in tcp_chr_connect, and the callback
vhost_user_blk_watch is not needed, because tcp_chr_hup is registered as
callback. And it will close the tcp link.
Signed-off-by: Li Feng
---
hw/block/vhost-user-blk.c | 19 ---
include/hw/virtio/vhost-user-blk
On 23.03.20 14:11, BALATON Zoltan wrote:
> On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote:
>> Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board.
>> On 3/23/20 12:46 PM, Max Reitz wrote:
>>> Hi,
>>>
>>> I was triaging new Coverity block layer reports today, and one that
>>> see
On Fri, Mar 20, 2020 at 02:50:29PM -0700, Andrzej Jakowski wrote:
> This patch introduces support for PMR that has been defined as part of NVMe
> 1.4
> spec. User can now specify a pmrdev option that should point to
> HostMemoryBackend.
> pmrdev memory region will subsequently be exposed as PCI B
On Fri, Mar 20, 2020 at 05:31:37AM -0700, dnbrd...@gmail.com wrote:
> From: Daniel Brodsky
>
> - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets
> - replaced result with QEMU_LOCK_GUARD if all unlocks at function end
> - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end
>
On Fri, Mar 20, 2020 at 06:43:23AM -0700, no-re...@patchew.org wrote:
> /tmp/qemu-test/src/util/thread-pool.c:213:5: error: unused variable
> 'qemu_lockable_auto1' [-Werror,-Wunused-variable]
> QEMU_LOCK_GUARD(&pool->lock);
> ^
> /tmp/qemu-test/src/include/qemu/lockable.h:173:29: note: exp
On Fri, Mar 20, 2020 at 05:31:36AM -0700, dnbrd...@gmail.com wrote:
> From: Daniel Brodsky
>
> - __COUNTER__ doesn't work with ## concat
> - replaced ## with glue() macro so __COUNTER__ is evaluated
>
> Fixes: 3284c3ddc4
>
> Signed-off-by: Daniel Brodsky
> ---
> include/qemu/lockable.h | 4 ++
On Mon, 23 Mar 2020, Philippe Mathieu-Daudé wrote:
Cc'ing qemu-ppc since this is restricted to the aCube Sam460ex board.
On 3/23/20 12:46 PM, Max Reitz wrote:
Hi,
I was triaging new Coverity block layer reports today, and one that
seemed like a real bug was CID 1421984:
It complains about a me
On Wed, 11 Mar 2020 17:20:07 +
Shameer Kolothum wrote:
> From: David Hildenbrand
>
> Summarizing the issue:
> 1. Memory regions contain ram blocks with a different size, if the
>size is not properly aligned. While memory regions can have an
>unaligned size, ram blocks can't. This
Philippe Mathieu-Daudé writes:
> Fix warnings reported by Clang static code analyzer:
>
> CC ui/input-linux.o
> ui/input-linux.c:343:9: warning: Value stored to 'rc' is never read
> rc = ioctl(il->fd, EVIOCGBIT(EV_REL, sizeof(relmap)), &relmap);
> ^
On 12.03.20 13:06, Vladimir Sementsov-Ogievskiy wrote:
> 12.03.2020 14:59, Vladimir Sementsov-Ogievskiy wrote:
>> 11.03.2020 14:06, Max Reitz wrote:
>>> On 30.01.20 16:22, Vladimir Sementsov-Ogievskiy wrote:
Prior to the commit the following command lead to crash:
./qemu-io --imag
On 23.03.2020 15:47, Alberto Garcia wrote:
On Mon 23 Mar 2020 11:20:42 AM CET, Denis Plotnikov wrote:
But consider corrupted image: it may contain any data. And we should
not crash because of it. So, we should return error here.
If the image is corrupted we can't continue anyway. If we retur
Create a subdirectory for s390x under docs/system/ and move the
existing vfio-ap documentation there.
Create an initial document describing s390x system emulation.
Suggested-by: Peter Maydell
Signed-off-by: Cornelia Huck
Acked-by: Christian Borntraeger
Message-Id: <20200318103940.1169-1-coh...
The following changes since commit 29e0855c5af62bbb0b0b6fed792e004dad92ba95:
Merge remote-tracking branch 'remotes/elmarco/tags/slirp-pull-request' into
staging (2020-03-22 21:00:38 +)
are available in the Git repository at:
https://github.com/cohuck/qemu tags/s390x-2020032
From: Halil Pasic
In update_machine_ipl_properties() the array ascii_loadparm needs to
hold the 8 char loadparm and a string terminating zero char.
Let's increase the size of ascii_loadparm accordingly.
Signed-off-by: Halil Pasic
Fixes: 0a01e082a428 ("s390/ipl: sync back loadparm")
Fixes: Cove
On Mon 23 Mar 2020 11:20:42 AM CET, Denis Plotnikov wrote:
>> But consider corrupted image: it may contain any data. And we should
>> not crash because of it. So, we should return error here.
> If the image is corrupted we can't continue anyway. If we return -EIO
> on this condition, we need to do
On Mon, Mar 23, 2020 at 11:32:26AM +, Beata Michalska wrote:
> On ARMv7 & ARMv8 some load/store instructions might trigger a data abort
> exception with no valid ISS info to be decoded. The lack of decode info
> makes it at least tricky to emulate those instruction which is one of the
> (many)
On Wed, 11 Mar 2020 17:20:06 +
Shameer Kolothum wrote:
> Any sub-page size update to ACPI table MRs will be lost during
> migration, as we use aligned size in ram_load_precopy() ->
> qemu_ram_resize() path. This will result in inconsistency in sizes
> between source and destination.
I'm not s
On 23.03.2020 15:26, Vladimir Sementsov-Ogievskiy wrote:
23.03.2020 15:22, Denis Plotnikov wrote:
On 23.03.2020 11:00, Vladimir Sementsov-Ogievskiy wrote:
21.03.2020 17:34, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression
type
feature to qcow2 all
23.03.2020 15:22, Denis Plotnikov wrote:
On 23.03.2020 11:00, Vladimir Sementsov-Ogievskiy wrote:
21.03.2020 17:34, Denis Plotnikov wrote:
The patch adds some preparation parts for incompatible compression type
feature to qcow2 allowing the use different compression methods for
image clusters
+-- On Mon, 23 Mar 2020, Jason Wang wrote --+
| Prasad, please fix this and post a new version.
|
| While at it, I prefer to squash patch 3 into patch 2 since patch 3 fixes the
| issue introduced by patch 2.
Sent patch v6.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
8685 545E
101 - 200 of 291 matches
Mail list logo
