[Bug 1649040] Re: Ubuntu 16.04.1 Grub Splash Doesn't Appear

2020-04-11 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1649040 Title: Ubuntu

[Bug 1665389] Re: Nested kvm guest fails to start on a emulated Westmere CPU guest under a Broadwell CPU host

2020-04-11 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1665389 Title: Nested kvm

[Bug 1663079] Re: socket network not working

2020-04-11 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1663079 Title: socket

[PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-11 Thread LIU Zhiwei
As struct target_ucontext will be transfered to signal handler, it must keep pace with struct ucontext_t defined in Linux kernel. Signed-off-by: LIU Zhiwei --- linux-user/riscv/signal.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/riscv/signal.c

[Bug 1821595] Re: Failed to emulate MMIO access with EmulatorReturnStatus: 2

2020-04-11 Thread Russell Morris
Hi, I built against the latest library I could (Windows Insider Preview, SDK) - same failure. Thoughts? Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1821595 Title: Failed to emulate

[Bug 1821595] Re: Failed to emulate MMIO access with EmulatorReturnStatus: 2

2020-04-11 Thread Russell Morris
Should say - I rebuilt (today). Still no joy. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1821595 Title: Failed to emulate MMIO access with EmulatorReturnStatus: 2 Status in QEMU: New Bug

Re: Boot flakiness with QEMU 3.1.0 and Clang built kernels

2020-04-11 Thread Nathan Chancellor
On Sat, Apr 11, 2020 at 11:57:23PM +1000, Nicholas Piggin wrote: > Nicholas Piggin's on April 11, 2020 7:32 pm: > > Nathan Chancellor's on April 11, 2020 10:53 am: > >> The tt.config values are needed to reproduce but I did not verify that > >> ONLY tt.config was needed. Other than that, no, we

Re: [PATCH-for-5.0 1/2] hw/display/sm501: Avoid heap overflow in sm501_2d_operation()

2020-04-11 Thread Peter Maydell
On Sat, 11 Apr 2020 at 20:45, Philippe Mathieu-Daudé wrote: > Buffer overflows are security issues because they allow attacker to > arbitrarily write data in the process memory, and eventually take > control of it. When attacker takes control, it can access underlying > private data. Note that

[Bug 1872237] Re: SysTick reload behavior emulated incorrectly

2020-04-11 Thread Peter Maydell
Yeah, our systick implementation is broken; I've known about this for ages but never got round to trying to work through what the right way to implement the behaviour is. I do have some more time to work on M-profile stuff coming up at some point so I might get round to this if nobody else does

Re: [PATCH for-5.0? 1/3] configure: Honour --disable-werror for Sphinx

2020-04-11 Thread Richard Henderson
On 4/11/20 11:29 AM, Peter Maydell wrote: > If we are not making warnings fatal for compilation, make them > non-fatal when building the Sphinx documentation also. (For instance > Sphinx 3.0 warns about some constructs that older versions were happy > with, which is a build failure if we use the

Re: [PATCH for-5.0? 2/3] scripts/kernel-doc: Add missing close-paren in c:function directives

2020-04-11 Thread Richard Henderson
On 4/11/20 11:29 AM, Peter Maydell wrote: > When kernel-doc generates a 'c:function' directive for a function > one of whose arguments is a function pointer, it fails to print > the close-paren after the argument list of the function pointer > argument, for instance: > .. c:function:: void

[Bug 1872237] [NEW] SysTick reload behavior emulated incorrectly

2020-04-11 Thread Bryan Cantrill
Public bug reported: QEMU's emuation of SysTick on ARM is incorrect with respect to reload behavior. This issue is described here, and also in a repository dedicated to the issue: https://github.com/oxidecomputer/qemu-systick-bug (What follows is in Markdown, which I understand that

Re: [PATCH-for-5.0 1/2] hw/display/sm501: Avoid heap overflow in sm501_2d_operation()

2020-04-11 Thread Philippe Mathieu-Daudé
[Cc'ing Sebastian Bauer & Aurelien Jarno because I'm not sure the problem was introduced by commit debc7e7dad1 or 07d8a50cb0e). On 4/11/20 8:05 PM, BALATON Zoltan wrote: > On Sat, 11 Apr 2020, Philippe Mathieu-Daudé wrote: >> Zhang Zi Ming reported a heap overflow in the Drawing Engine of >> the

[Bug 1872113] Re: qemu docs fails to build with Sphinx 3.0.x

2020-04-11 Thread Peter Maydell
I've sent a proposed fix to the list: https://patchew.org/QEMU/20200411182934.28678-1-peter.mayd...@linaro.org/ ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH 01/31] target/arm: Add ID_AA64ZFR0 fields and isar_feature_aa64_sve2

2020-04-11 Thread Alex Bennée
Richard Henderson writes: > Will be used for SVE2 isa subset enablement. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH] tcg/mips: mips sync* encode error

2020-04-11 Thread Aleksandar Markovic
20:08 Sub, 11.04.2020. Richard Henderson је написао/ла: > > On 4/11/20 5:46 AM, lixinyu wrote: > > OPC_SYNC_WMB, OPC_SYNC_MB, OPC_SYNC_ACQUIRE, OPC_SYNC_RELEASE and > > OPC_SYNC_RMB have wrong encode. According to the mips manual, > > their encode should be 'OPC_SYNC | 0x?? << 6' rather than > >

[PATCH for-5.0? 3/3] kernel-doc: Use c:struct for Sphinx 3.0 and later

2020-04-11 Thread Peter Maydell
The kernel-doc Sphinx plugin and associated script currently emit 'c:type' directives for "struct foo" documentation. Sphinx 3.0 warns about this: /home/petmay01/linaro/qemu-from-laptop/qemu/docs/../include/exec/memory.h:3: WARNING: Type must be either just a name or a typedef-like

[PATCH for-5.0? 1/3] configure: Honour --disable-werror for Sphinx

2020-04-11 Thread Peter Maydell
If we are not making warnings fatal for compilation, make them non-fatal when building the Sphinx documentation also. (For instance Sphinx 3.0 warns about some constructs that older versions were happy with, which is a build failure if we use the warnings-as-errors flag.) This provides a

[PATCH for-5.0? 0/3] Make docs build work with Sphinx 3

2020-04-11 Thread Peter Maydell
Our current docs don't build with Sphinx 3, as noted in https://bugs.launchpad.net/bugs/1872113 -- this is a combination of: (1) we are using the sphinx-build -W option so warnings are treated as errors (3) a kernel-doc script bug meant it was omitting a close-paren when a function

[PATCH for-5.0? 2/3] scripts/kernel-doc: Add missing close-paren in c:function directives

2020-04-11 Thread Peter Maydell
When kernel-doc generates a 'c:function' directive for a function one of whose arguments is a function pointer, it fails to print the close-paren after the argument list of the function pointer argument, for instance: .. c:function:: void memory_region_init_resizeable_ram (MemoryRegion * mr,

Re: [PATCH] tcg/mips: mips sync* encode error

2020-04-11 Thread Richard Henderson
On 4/11/20 5:46 AM, lixinyu wrote: > OPC_SYNC_WMB, OPC_SYNC_MB, OPC_SYNC_ACQUIRE, OPC_SYNC_RELEASE and > OPC_SYNC_RMB have wrong encode. According to the mips manual, > their encode should be 'OPC_SYNC | 0x?? << 6' rather than > 'OPC_SYNC | 0x?? << 5'. Wrong encode can lead illegal instruction >

Re: [PATCH-for-5.0 1/2] hw/display/sm501: Avoid heap overflow in sm501_2d_operation()

2020-04-11 Thread BALATON Zoltan
On Sat, 11 Apr 2020, Philippe Mathieu-Daudé wrote: Zhang Zi Ming reported a heap overflow in the Drawing Engine of the SM501 companion chip model, in particular in the COPY_AREA() macro in sm501_2d_operation(). As I have no idea what this code is supposed to do, add a simple check to avoid the

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

2020-04-11 Thread Philippe Mathieu-Daudé
On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote: > Philippe Mathieu-Daudé (7): > hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to AHB PnP > registers > hw/misc/grlib_ahb_apb_pnp: Fix AHB PnP 8-bit accesses Ping ^^^ for 5.0? > hw/misc/grlib_ahb_apb_pnp: Add trace events on read

colo: qemu 4.2.0 vs. qemu 5.0.0-rc2 performance regression

2020-04-11 Thread Lukas Straub
Hello Everyone, I did some Benchmarking with iperf3 and memtester (to dirty some guest memory) of colo performance in qemu 4.2.0 and in qemu 5.0.0-rc2 with my bugfixes on top.( https://lists.nongnu.org/archive/html/qemu-devel/2020-04/msg01432.html ) I have taken the average over 4 runs.

Re: [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-11 Thread Philippe Mathieu-Daudé
On 4/10/20 3:08 PM, Stefano Garzarella wrote: On Thu, Apr 09, 2020 at 10:15:27PM +0100, Alex Bennée wrote: From: Peter Xu We should only pass in gdb_get_reg16() with the GByteArray* object itself, no need to shift. Without this patch, gdb remote attach will crash QEMU. Fixes: a010bdbe719

Re: [PULL 0/8] Misc patches for QEMU 5.0-rc3

2020-04-11 Thread Peter Maydell
On Sat, 11 Apr 2020 at 14:04, Paolo Bonzini wrote: > > The following changes since commit 53ef8a92eb04ee19640f5aad3bff36cd4a36c250: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200406' into staging (2020-04-06 > 12:36:45 +0100) > > are available in the Git

Re: [PULL for-5.0 0/3] Block patches

2020-04-11 Thread Peter Maydell
On Thu, 9 Apr 2020 at 18:42, Stefan Hajnoczi wrote: > > The following changes since commit 8bac3ba57eecc466b7e73dabf7d19328a59f684e: > > Merge remote-tracking branch 'remotes/rth/tags/pull-rx-20200408' into > staging (2020-04-09 13:23:30 +0100) > > are available in the Git repository at: > >

Re: Boot flakiness with QEMU 3.1.0 and Clang built kernels

2020-04-11 Thread Nicholas Piggin
Nicholas Piggin's on April 11, 2020 7:32 pm: > Nathan Chancellor's on April 11, 2020 10:53 am: >> The tt.config values are needed to reproduce but I did not verify that >> ONLY tt.config was needed. Other than that, no, we are just building >> either pseries_defconfig or powernv_defconfig with

[Bug 1872113] Re: qemu docs fails to build with Sphinx 3.0.x

2020-04-11 Thread Stig-Ørjan Smelror
You are right. Wrong choice of words. However, the change is a breaking change from Sphinx. See https://github.com/sphinx- doc/sphinx/issues/7457#issuecomment-612413080 ** Bug watch added: github.com/sphinx-doc/sphinx/issues #7457 https://github.com/sphinx-doc/sphinx/issues/7457 -- You

Re: [PATCH v5 2/2] lockable: replaced locks with lock guard macros where appropriate

2020-04-11 Thread Paolo Bonzini
On 11/04/20 13:19, Daniel Brodsky wrote: > Just making sure this patch didn't get lost. > ping http://patchwork.ozlabs.org/patch/1266336/ The patch looks good, but it will be included in QEMU only after 5.0 is released. Thanks, Paolo

[PULL 7/8] memory: Do not allow direct write access to rom_device regions

2020-04-11 Thread Paolo Bonzini
From: Alexander Duyck According to the documentation in memory.h a ROM memory region will be backed by RAM for reads, but is supposed to go through a callback for writes. Currently we were not checking for the existence of the rom_device flag when determining if we could perform a direct write

[PULL 3/8] atomics: convert to reStructuredText

2020-04-11 Thread Paolo Bonzini
No attempts to fix or update the text; these are left for the next patch in the series. Signed-off-by: Paolo Bonzini --- docs/devel/atomics.rst | 446 + docs/devel/atomics.txt | 403 - docs/devel/index.rst | 1 + 3

[PULL 5/8] rcu: do not mention atomic_mb_read/set in documentation

2020-04-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/devel/rcu.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devel/rcu.txt b/docs/devel/rcu.txt index d83fed2f79..0ce15ba198 100644 --- a/docs/devel/rcu.txt +++ b/docs/devel/rcu.txt @@ -132,7 +132,7 @@ The core RCU API is small:

[PULL 2/8] oslib-posix: take lock before qemu_cond_broadcast

2020-04-11 Thread Paolo Bonzini
From: Bauerchen In touch_all_pages, if the mutex is not taken around qemu_cond_broadcast, qemu_cond_broadcast may be called before all touch page threads enter qemu_cond_wait. In this case, the touch page threads wait forever for the main thread to wake them up, causing a deadlock.

[PULL 4/8] atomics: update documentation

2020-04-11 Thread Paolo Bonzini
Some of the constraints on operand sizes have been relaxed, so adjust the documentation. Deprecate atomic_mb_read and atomic_mb_set; it is not really possible to use them correctly because they do not interoperate with sequentially-consistent RMW operations. Finally, extend the memory barrier

[PULL 1/8] piix: fix xenfv regression, add compat machine xenfv-4.2

2020-04-11 Thread Paolo Bonzini
From: Olaf Hering With QEMU 4.0 an incompatible change was added to pc_piix, which makes it practical impossible to migrate domUs started with qemu2 or qemu3 to newer qemu versions. Commit 7fccf2a06890e3bc3b30e29827ad3fb93fe88fea added and enabled a new member "smbus_no_migration_support". In

[PULL 6/8] vl.c: error out if -mem-path is used together with -M memory-backend

2020-04-11 Thread Paolo Bonzini
From: Igor Mammedov the former is not actually used by explicit backend, so instead of silently ignoring the option in non valid context, exit with error. Signed-off-by: Igor Mammedov Message-Id: <20200409134133.11339-1-imamm...@redhat.com> Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 5

[PULL 0/8] Misc patches for QEMU 5.0-rc3

2020-04-11 Thread Paolo Bonzini
The following changes since commit 53ef8a92eb04ee19640f5aad3bff36cd4a36c250: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200406' into staging (2020-04-06 12:36:45 +0100) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

[PULL 8/8] module: increase dirs array size by one

2020-04-11 Thread Paolo Bonzini
From: Bruce Rogers With the module upgrades code change, the statically sized dirs array can now overflow. Increase it's size by one, according to the new maximum possible usage. Fixes: bd83c861c0 ("modules: load modules from versioned /var/run dir") Signed-off-by: Bruce Rogers Message-Id:

Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-11 Thread Alex Bennée
Brice Goglin writes: > Le 10/04/2020 à 14:33, Alex Bennée a écrit : >> That was by inspection on my system which seems to truncate a lot >> earlier. It would be nice to find where in the Linux kernel it is >> output but I failed to grep the relevant function last night. > > > It's in

Re: [PATCH v1 09/11] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

2020-04-11 Thread Alex Bennée
Stefano Garzarella writes: > On Thu, Apr 09, 2020 at 10:15:27PM +0100, Alex Bennée wrote: >> From: Peter Xu >> >> We should only pass in gdb_get_reg16() with the GByteArray* object >> itself, no need to shift. Without this patch, gdb remote attach will >> crash QEMU. >> >> Fixes:

Re: [PULL 08/13] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal

2020-04-11 Thread Alex Bennée
Peter Maydell writes: > On Fri, 10 Apr 2020 at 16:17, Richard Henderson > wrote: >> Although why Alex didn't add his own R-b to my patch when merging it to his >> branch, I don't know. > > I think this is one of those areas where different submaintainers > have different work practices.

[PATCH] tcg/mips: mips sync* encode error

2020-04-11 Thread lixinyu
OPC_SYNC_WMB, OPC_SYNC_MB, OPC_SYNC_ACQUIRE, OPC_SYNC_RELEASE and OPC_SYNC_RMB have wrong encode. According to the mips manual, their encode should be 'OPC_SYNC | 0x?? << 6' rather than 'OPC_SYNC | 0x?? << 5'. Wrong encode can lead illegal instruction errors. These instructions often appear with

[Bug 1872113] Re: qemu docs fails to build with Sphinx 3.0.x

2020-04-11 Thread Peter Maydell
I'm a bit confused: you say "however there are still errors" but the build log you quote ends with "build succeeded, 4 warnings" and it looks like it has indeed just produced warnings and continued. -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Bug 1863441] Re: cmd_mode_sense always reports 0x70, no CDROM present

2020-04-11 Thread Thomas Huth
** Changed in: qemu Status: New => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863441 Title: cmd_mode_sense always reports 0x70, no CDROM present Status in QEMU: Won't Fix

Re: [PATCH v5 2/2] lockable: replaced locks with lock guard macros where appropriate

2020-04-11 Thread Daniel Brodsky
On Fri, Apr 3, 2020 at 9:21 PM wrote: > > From: Daniel Brodsky > > - ran regexp "qemu_mutex_lock\(.*\).*\n.*if" to find targets > - replaced result with QEMU_LOCK_GUARD if all unlocks at function end > - replaced result with WITH_QEMU_LOCK_GUARD if unlock not at end > > Signed-off-by: Daniel

[PATCH RESEND v3 2/2] Makefile: remove old compatibility gunks

2020-04-11 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- Makefile | 6 -- 1 file changed, 6 deletions(-) diff --git a/Makefile b/Makefile index 7be15eeb7c..00377f28b9 100644 --- a/Makefile +++ b/Makefile @@ -567,12 +567,6 @@ slirp/all: .git-submodule-status CC="$(CC)" AR="$(AR)" LD="$(LD)"

[PATCH RESEND v3 0/2] Makefile: libfdt: build only the strict necessary

2020-04-11 Thread Claudio Fontana
v2 -> v3: * changed into a 2 patch series; in the second patch we remove the old compatibility gunks that were meant for removal some time after 4.1. * renamed the libfdt PHONY rule to dtc/all, with the intent to make existing working trees forward and backward compatible across the change.

[PATCH RESEND v3 1/2] Makefile: libfdt: build only the strict necessary

2020-04-11 Thread Claudio Fontana
when building dtc/libfdt, we were previously using dtc/Makefile, which tries to build some artifacts that are not needed, and can complain on stderr about the absence of tools that are not required to build just libfdt. Instead, build only the strict necessary to get libfdt.a . Signed-off-by:

[PATCH 1/2] Makefile: libfdt: build only the strict necessary

2020-04-11 Thread Claudio Fontana
when building dtc/libfdt, we were previously using dtc/Makefile, which tries to build some artifacts that are not needed, and can complain on stderr about the absence of tools that are not required to build just libfdt. Instead, build only the strict necessary to get libfdt.a . Signed-off-by:

[PATCH 2/2] Makefile: remove old compatibility gunks

2020-04-11 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- Makefile | 6 -- 1 file changed, 6 deletions(-) diff --git a/Makefile b/Makefile index 7be15eeb7c..00377f28b9 100644 --- a/Makefile +++ b/Makefile @@ -567,12 +567,6 @@ slirp/all: .git-submodule-status CC="$(CC)" AR="$(AR)" LD="$(LD)"

[PATCH v3 0/2] Makefile: libfdt: build only the strict necessary

2020-04-11 Thread Claudio Fontana
v2 -> v3: * changed into a 2 patch series; in the second patch we remove the old compatibility gunks that were meant for removal some time after 4.1. * renamed the libfdt PHONY rule to dtc/all, with the intent to make existing working trees forward and backward compatible across the change.

[PATCH 1/2] Makefile: libfdt: build only the strict necessary

2020-04-11 Thread Claudio Fontana
when building dtc/libfdt, we were previously using dtc/Makefile, which tries to build some artifacts that are not needed, and can complain on stderr about the absence of tools that are not required to build just libfdt. Instead, build only the strict necessary to get libfdt.a . Signed-off-by:

[PATCH-for-5.0 2/2] qtest: Test the Drawing Engine of the SM501 companion

2020-04-11 Thread Philippe Mathieu-Daudé
Run some PCI commands to call the COPY_AREA() macro in sm501_2d_operation(), and verify that there is no more overflow as reported in BZ#1786026 [*]. The SM501 is used by the R2D-PLUS and aCube Sam460ex machines, but since it is a PCI card and we already have an easy way to test PCI daughter

[PATCH-for-5.0 0/2] hw/display/sm501: Avoid heap overflow in sm501_2d_operation()

2020-04-11 Thread Philippe Mathieu-Daudé
I once setup a Bugzilla 'Component Watching' rule on 'QEMU + CVE', and recently found a notification for BZ#1786026 about a heap overflow in sm501_2d_operation(): https://bugzilla.redhat.com/show_bug.cgi?id=1786026 As this is from december I suppose there was some embargo that recently expired.

[PATCH-for-5.0 1/2] hw/display/sm501: Avoid heap overflow in sm501_2d_operation()

2020-04-11 Thread Philippe Mathieu-Daudé
Zhang Zi Ming reported a heap overflow in the Drawing Engine of the SM501 companion chip model, in particular in the COPY_AREA() macro in sm501_2d_operation(). As I have no idea what this code is supposed to do, add a simple check to avoid the heap overflow. This fixes:

[PATCH v2] virtiofsd/passthrough_ll: don't remove O_DIRECT when cache=none

2020-04-11 Thread Catherine Ho
cache=none means to bypass host cache. So we can't remove O_DIRECT flag in unconditionally in update_open_flags(); Signed-off-by: Catherine Ho --- v2: Fix to keep flags unchanged if cache=none, otherwise changed the file without O_DIRECT incorrectly. tools/virtiofsd/passthrough_ll.c | 14

[PATCH] virtiofsd/passthrough_ll: don't remove O_DIRECT when cache=none

2020-04-11 Thread Catherine Ho
cache=none means to bypass host cache. So we can't remove O_DIRECT flag in unconditionally in update_open_flags(); Signed-off-by: Catherine Ho --- tools/virtiofsd/passthrough_ll.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git