Re: hw/net/cadence_gem: TX checksum offload does not work for fragmented packets

2020-04-25 Thread Bin Meng
Hi Jason, On Tue, Apr 21, 2020 at 10:31 PM Bin Meng wrote: > > Hi, > > The cadence_gem does the TX checksum offload by: > > /* Is checksum offload enabled? */ > if (s->regs[GEM_DMACFG] & GEM_DMACFG_TXCSUM_OFFL) { > net_checksum_calculate(tx_pack

Re: [RFC PATCH 0/3] hw/net/tulip: Fix LP#1874539

2020-04-25 Thread Jason Wang
On 2020/4/24 下午11:27, Helge Deller wrote: * Philippe Mathieu-Daudé : Attempt to fix the launchpad bug filled by Helge: In a qemu-system-hppa system, qemu release v5.0.0-rc, the tulip nic driver is broken. The tulip nic is detected, even getting DHCP info does work. But when trying

Re: [PATCH v2] qemu-sockets: add abstract UNIX domain socket support

2020-04-25 Thread xiaoqiang.zhao
Eric , Markus, any comments ? 在 2020/4/23 下午6:51, xiaoqiang.zhao 写道: 在 2020/4/23 下午5:00, Daniel P. Berrangé 写道: Adding Eric & Markus for QAPI modelling questions On Thu, Apr 23, 2020 at 11:56:40AM +0800, xiaoqiang zhao wrote: unix_connect_saddr now support abstract address type By default qe

Re: [PATCH] hw: add compat machines for 5.1

2020-04-25 Thread David Gibson
On Fri, Apr 24, 2020 at 11:03:14AM +0200, Cornelia Huck wrote: > Add 5.1 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck Acked-by: David Gibson > --- > > Still keeping the default cpu model version on x86 at v1. > > I'll queue this to my s390-next branch, as I'

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-25 Thread Yan Zhao
On Sat, Apr 25, 2020 at 03:10:49AM +0800, Dr. David Alan Gilbert wrote: > * Yan Zhao (yan.y.z...@intel.com) wrote: > > On Tue, Apr 21, 2020 at 08:08:49PM +0800, Tian, Kevin wrote: > > > > From: Yan Zhao > > > > Sent: Tuesday, April 21, 2020 10:37 AM > > > > > > > > On Tue, Apr 21, 2020 at 06:56:00

Re: [PATCH v4 1/3] memory: drop guest writes to read-only ram device regions

2020-04-25 Thread Yan Zhao
On Sat, Apr 25, 2020 at 06:55:33PM +0800, Paolo Bonzini wrote: > On 17/04/20 09:44, Yan Zhao wrote: > > for ram device regions, drop guest writes if the regions is read-only. > > > > Cc: Philippe Mathieu-Daudé > > Signed-off-by: Yan Zhao > > Signed-off-by: Xin Zeng > > --- > > memory.c | 7 +++

Re: [PATCH] linux-user: Drop unnecessary check in signalfd4 syscall

2020-04-25 Thread Helge Deller
On 25.04.20 12:03, Laurent Vivier wrote: > Le 25/04/2020 à 11:24, Helge Deller a écrit : >> On 25.04.20 10:39, Laurent Vivier wrote: >>> Le 24/04/2020 à 23:04, Helge Deller a écrit : The signalfd4() syscall takes optional O_NONBLOCK and O_CLOEXEC fcntl flags. If the user gave any other i

[Bug 1875080] [NEW] USB host device data transfer with control endpoint

2020-04-25 Thread Armin
Public bug reported: QEMU emulator version 4.2.0 Host -> Arch Linux kernel version: 5.4.34-1-lts Guest -> Various Linux Distros I sent a control message with data through endpoint zero. On the other side message is received with all fields correct except data buffer. I've tested the data field i

Re: ARM SVE issues with non "standard" vector lengths

2020-04-25 Thread Richard Henderson
On 4/23/20 9:24 AM, Laurent Desnogues wrote: > Looking at the code I think sve_punpk_p is affected too. Got it. Same issue as zip1. r~

Re: ARM SVE issues with non "standard" vector lengths

2020-04-25 Thread Richard Henderson
On 4/25/20 11:49 AM, Richard Henderson wrote: > On 4/23/20 6:59 AM, Laurent Desnogues wrote: >> 2. sve_zip_p >> >> This generates extraneous data in the higher part of the result. >> >> I hit this when I got a wrong result on an instruction that ends up >> using sve_cntp which counts all bits set i

Re: ARM SVE issues with non "standard" vector lengths

2020-04-25 Thread Richard Henderson
On 4/23/20 6:59 AM, Laurent Desnogues wrote: > 2. sve_zip_p > > This generates extraneous data in the higher part of the result. > > I hit this when I got a wrong result on an instruction that ends up > using sve_cntp which counts all bits set in each 64-bit chunk. There > might be some other ins

target/mips: Enable Hardware page table walker and CMGCR features for P5600

2020-04-25 Thread oliveriandrea
Hi, I have discovered that MIPS hardware page table walker is not enabled for any CPU currently available. In this patch I have enable it (and also CMGCR feature) for P5600 which supports both but they are not enabled. This is my first patch to QEMU, I hope it is well formatted and correct. Signe

The -icount option document are confusing

2020-04-25 Thread Yonggang Luo
-icount [shift=N|auto][,rr=record|replay,rrfile=filename,rrsnapshot=snapshot ] When the virtual cpu is sleeping, the virtual time will advance at default speed unless sleep=on|off is specified. With sleep=on|off, the virtual time will jump to the next timer deadline instantly whenever the virtual

Re: [PATCH] linux-user: Drop unnecessary check in dup3 syscall

2020-04-25 Thread Peter Maydell
On Fri, 24 Apr 2020 at 22:33, Eric Blake wrote: > I don't think this is quite correct. target_to_host_bitmask() silently > ignores unknown bits, and a user that was relying on bit 0x4000 to > cause an EINVAL will not fail with this change (unless bit 0x4000 > happens to be one of the bits

[Bug 1875012] [NEW] KVM internal error. Suberror: 1 -- emulation failure

2020-04-25 Thread Juerg Haefliger
Public bug reported: Trying to boot a core20 amd64 image on an amd64 Eoan or Focal host via libvirt leads to: KVM internal error. Suberror: 1 emulation failure RAX= RBX=3bdcd5c0 RCX=3ff1d030 RDX=19a0 RSI=00ff RDI=3bd73ee0 RBP=00

Re: [PATCH v1 PATCH v1 1/1] tests: machine-none-test: Enable MicroBlaze testing

2020-04-25 Thread Paolo Bonzini
On 16/04/20 21:33, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Enable MicroBlaze testing. > > Signed-off-by: Edgar E. Iglesias > --- > tests/qtest/machine-none-test.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/tests/qtest/machine-none-test

Re: [PATCH] hw/i386/amd_iommu: Fix the reserved bits definition of IOMMU commands

2020-04-25 Thread Paolo Bonzini
On 18/04/20 06:28, Wei Huang wrote: > Many reserved bits of amd_iommu commands are defined incorrectly in QEMU. > Because of it, QEMU incorrectly injects lots of illegal commands into guest > VM's IOMMU event log. > > Signed-off-by: Wei Huang > --- > hw/i386/amd_iommu.c | 19 ++-

Re: [PATCH v4 1/3] memory: drop guest writes to read-only ram device regions

2020-04-25 Thread Paolo Bonzini
On 17/04/20 09:44, Yan Zhao wrote: > for ram device regions, drop guest writes if the regions is read-only. > > Cc: Philippe Mathieu-Daudé > Signed-off-by: Yan Zhao > Signed-off-by: Xin Zeng > --- > memory.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/memory.c b/memory.c >

Re: [PATCH v2] chardev/char-socket: Properly make qio connections non blocking

2020-04-25 Thread Paolo Bonzini
On 20/04/20 11:26, Daniel P. Berrangé wrote: > On Sun, Apr 19, 2020 at 03:21:40PM +0530, Sai Pavan Boddu wrote: >> In tcp_chr_sync_read function, there is a possibility of socket >> disconnection during blocking read, then tcp_chr_hup function would clean up >> the qio channel pointers(i.e ioc, sio

CFP: KVM Forum 2020

2020-04-25 Thread Paolo Bonzini
KVM Forum 2020: Call For Participation October 28-30, 2020 - Convention Centre Dublin - Dublin, Ireland (All submissions must be received before June 15, 2020 at 23:59 PST)

Re: [PATCH] linux-user: Drop unnecessary check in signalfd4 syscall

2020-04-25 Thread Laurent Vivier
Le 25/04/2020 à 11:24, Helge Deller a écrit : > On 25.04.20 10:39, Laurent Vivier wrote: >> Le 24/04/2020 à 23:04, Helge Deller a écrit : >>> The signalfd4() syscall takes optional O_NONBLOCK and O_CLOEXEC fcntl >>> flags. If the user gave any other invalid flags, the host syscall will >>> return

Re: [RFC PATCH v1 1/7] contrib/vhost-user-blk: add option to simulate disconnect on init

2020-04-25 Thread Dima Stepanov
On Fri, Apr 24, 2020 at 12:17:54PM +0200, Marc-André Lureau wrote: > Hi > > On Fri, Apr 24, 2020 at 4:32 AM Raphael Norwitz > wrote: > > > > I’m not opposed to adding this kind of debugging functionality to the > > vhost-user-blk sample. It could be helpful to easily test these cases > > in the f

Re: [PATCH v4 1/2] target/arm: kvm: Handle DABT with no valid ISS

2020-04-25 Thread Paolo Bonzini
On 24/04/20 14:16, Dr. David Alan Gilbert wrote: >>> I was trying to work out whether we need to migrate this state, >>> and I'm not sure. Andrew, do you know? I think this comes down >>> to "at what points in QEMU's kvm run loop can migration kick in", >>> and specifically if we get a KVM_EXIT_ARM

Re: [PATCH] linux-user: Drop unnecessary check in signalfd4 syscall

2020-04-25 Thread Helge Deller
On 25.04.20 10:39, Laurent Vivier wrote: > Le 24/04/2020 à 23:04, Helge Deller a écrit : >> The signalfd4() syscall takes optional O_NONBLOCK and O_CLOEXEC fcntl >> flags. If the user gave any other invalid flags, the host syscall will >> return correct error codes, so simply drop the extra check

Re: [PATCH v5 0/2] Replaced locks with lock guard macros

2020-04-25 Thread Paolo Bonzini
On 24/04/20 12:50, Stefan Hajnoczi wrote: > Paolo, hope you don't mind if I use the block-next branch to merge this > and Simran's patch that depends on it. Absolutely not, thanks. Paolo > Thanks, applied to my block-next tree: > https://github.com/stefanha/qemu/commits/block-next signature.

Re: [RFC patch v1 2/3] qemu-file: add buffered mode

2020-04-25 Thread Vladimir Sementsov-Ogievskiy
13.04.2020 14:12, Denis Plotnikov wrote: The patch adds ability to qemu-file to write the data asynchronously to improve the performance on writing. Before, only synchronous writing was supported. Enabling of the asyncronous mode is managed by new "enabled_buffered" callback. Hmm. I don't lik

Re: [PATCH] linux-user: Drop unnecessary check in signalfd4 syscall

2020-04-25 Thread Laurent Vivier
Le 24/04/2020 à 23:04, Helge Deller a écrit : > The signalfd4() syscall takes optional O_NONBLOCK and O_CLOEXEC fcntl > flags. If the user gave any other invalid flags, the host syscall will > return correct error codes, so simply drop the extra check here. > > Signed-off-by: Helge Deller > > d

Re: [PATCH] linux-user: Drop open-coded fcntl flags conversion in eventfd2 syscall

2020-04-25 Thread Laurent Vivier
Le 24/04/2020 à 22:48, Helge Deller a écrit : > Drop the open-coded fcntl flags conversion in the eventfd2 syscall and > replace it with the built-in conversion with fcntl_flags_tbl. > > Signed-off-by: Helge Deller > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 05f03919ff..

Re: [PATCH] linux-user: Add support for /proc/cpuinfo on hppa platform

2020-04-25 Thread Laurent Vivier
Le 24/04/2020 à 23:06, Helge Deller a écrit : > Provide an own /proc/cpuinfo file for the hppa (parisc) platform. > > Signed-off-by: Helge Deller > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 05f03919ff..ebf0d38321 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/sys

Re: [PATCH] linux-user: return target error codes for socket() and prctl()

2020-04-25 Thread Laurent Vivier
Le 25/04/2020 à 00:00, Helge Deller a écrit : > Return target error codes instead of host error codes. > > Signed-off-by: Helge Deller > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 05f03919ff..655a86fa45 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@