[PATCH 07/10] exec: Move all RAMBlock functions to 'exec/ramblock.h'

2020-05-07 Thread Philippe Mathieu-Daudé
The RAMBlock API was dispersed in 3 different headers. One of these headers, "exec/ram_addr.h", is restricted to target dependent code. However these functions are not target specific. Move all functions into a single place. Now all these functions can be accessed by target-agnostic code.

[PATCH 05/10] exec: Move qemu_minrampagesize/qemu_maxrampagesize to 'qemu-common.h'

2020-05-07 Thread Philippe Mathieu-Daudé
Move these generic functions to a more common place, with other functions related to host page size. Document a little. Cc: Alexey Kardashevskiy Signed-off-by: Philippe Mathieu-Daudé --- include/exec/ram_addr.h| 3 --- include/qemu-common.h | 10 ++ hw/ppc/spapr_caps.c

[PATCH 01/10] exec: Rename qemu_ram_writeback() as qemu_ram_msync()

2020-05-07 Thread Philippe Mathieu-Daudé
Rename qemu_ram_writeback() as qemu_ram_msync() to better match what it does. Suggested-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé --- include/exec/ram_addr.h | 4 ++-- exec.c | 2 +- hw/block/nvme.c | 3 +-- memory.c| 2 +- 4 files

[PATCH 00/10] exec: Shear 'exec/ram_addr.h' and make NVMe device target-agnostic

2020-05-07 Thread Philippe Mathieu-Daudé
Stefan suggested to make qemu_ram_writeback() target agnostic, Paolo to add memory_region_msync(), and Peter to remove "exec/ram_addr.h" [*]. I let a single function in this file, cpu_physical_memory_sync_dirty_bitmap(), to let the maintainer have the pleasure to remove this header definitively

[Bug 1877418] Re: qemu-nbd freezes access to VDI file

2020-05-07 Thread Bump
** Attachment added: "shell-commands.txt" https://bugs.launchpad.net/qemu/+bug/1877418/+attachment/5367894/+files/shell-commands.txt ** Description changed: Mounted Oracle Virtualbox .vdi drive, which has GTP+BTRFS: + sudo modprobe nbd max_part=16 sudo qemu-nbd -c /dev/nbd0

[PATCH 4/6] target/ppc: Add missing braces in ppc_radix64_partition_scoped_xlate()

2020-05-07 Thread Greg Kurz
As per CODING_STYLE. Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped translation" Signed-off-by: Greg Kurz --- target/ppc/mmu-radix64.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c index

[Bug 1877418] Re: qemu-nbd freezes access to VDI file

2020-05-07 Thread Bump
** Attachment added: "dmesg-bug-qemu-nbd-btrfs-vdi.txt" https://bugs.launchpad.net/qemu/+bug/1877418/+attachment/5367895/+files/dmesg-bug-qemu-nbd-btrfs-vdi.txt ** Also affects: btrfs-progs (Ubuntu) Importance: Undecided Status: New ** Description changed: Mounted Oracle

[PATCH 3/6] target/ppc: Don't initialize some local variables in ppc_radix64_xlate()

2020-05-07 Thread Greg Kurz
It is the job of the ppc_radix64_get_fully_qualified_addr() function which is called at the beginning of ppc_radix64_xlate() to set both lpid *and* pid. It doesn't buy us anything to initialize them first. Worse, a bug in ppc_radix64_get_fully_qualified_addr(), eg. failing to set either lpid or

[PATCH 5/6] target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate()

2020-05-07 Thread Greg Kurz
The last two arguments have the bool type. Also, we shouldn't raise an exception when using gdbstub. This was found while reading the code. Since it only affects the powernv machine, I didn't dig further to find an actual bug. Fixes: d04ea940c597 "target/ppc: Add support for Radix

[PATCH 6/6] target/ppc: Don't update radix PTE R/C bits with gdbstub

2020-05-07 Thread Greg Kurz
gdbstub shouldn't silently change guest visible state when doing address translation. While here drop a not very useful comment. This was found while reading the code. I could verify that this affects both powernv and pseries, but I failed to observe any actual bug. Fixes: d04ea940c597

[PATCH 2/6] target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr()

2020-05-07 Thread Greg Kurz
This doesn't require write access to the CPU registers. Signed-off-by: Greg Kurz --- target/ppc/mmu-radix64.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c index 1404e53deca8..c76879f65b78 100644 ---

[PATCH v2 4/4] target/arm: Fix tcg_gen_gvec_dup_imm vs DUP (indexed)

2020-05-07 Thread Richard Henderson
DUP (indexed) can duplicate 128-bit elements, so using esz unconditionally can assert in tcg_gen_gvec_dup_imm. Fixes: 8711e71f9cbb Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson --- target/arm/translate-sve.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH 0/6] target/ppc: Various clean-up and fixes for radix64

2020-05-07 Thread Greg Kurz
First three patches of this series are simple cleanups. The other ones fix some regressions introduced by Cedric's recent addition of partition-scoped translation. -- Greg --- Greg Kurz (6): target/ppc: Pass const pointer to ppc_radix64_get_prot_amr() target/ppc: Pass const pointer

[PATCH 1/6] target/ppc: Pass const pointer to ppc_radix64_get_prot_amr()

2020-05-07 Thread Greg Kurz
This doesn't require write access to the CPU structure. Signed-off-by: Greg Kurz --- target/ppc/mmu-radix64.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/ppc/mmu-radix64.h b/target/ppc/mmu-radix64.h index 96228546aa85..f28c5794d071 100644 ---

[PATCH v2 1/4] target/arm: Use tcg_gen_gvec_5_ptr for sve FMLA/FCMLA

2020-05-07 Thread Richard Henderson
Now that we can pass 7 parameters, do not encode register operands within simd_data. Reviewed-by: Alex Bennée Reviewed-by: Taylor Simpson Signed-off-by: Richard Henderson --- v2: Remove gen_helper_sve_fmla typedef (phil). --- target/arm/helper-sve.h| 45 +++

[PATCH v2 3/4] target/arm: Use clear_vec_high more effectively

2020-05-07 Thread Richard Henderson
Do not explicitly store zero to the NEON high part when we can pass !is_q to clear_vec_high. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 59 +++--- 1 file changed, 36 insertions(+), 23 deletions(-) diff --git

Re: [PATCH v2 0/4] target/arm: Misc cleanups

2020-05-07 Thread Richard Henderson
On 5/7/20 10:23 AM, Richard Henderson wrote: > Version 2 adds a fix to a just merged patch. Ho hum. This is actually v4. Sigh. r~

[PATCH v2 2/4] target/arm: Use tcg_gen_gvec_mov for clear_vec_high

2020-05-07 Thread Richard Henderson
The 8-byte store for the end a !is_q operation can be merged with the other stores. Use a no-op vector move to trigger the expand_clr portion of tcg_gen_gvec_mov. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 10 ++ 1 file changed, 2

[PATCH v2 0/4] target/arm: Misc cleanups

2020-05-07 Thread Richard Henderson
Version 2 adds a fix to a just merged patch. r~ Richard Henderson (4): target/arm: Use tcg_gen_gvec_5_ptr for sve FMLA/FCMLA target/arm: Use tcg_gen_gvec_mov for clear_vec_high target/arm: Use clear_vec_high more effectively target/arm: Fix tcg_gen_gvec_dup_imm vs DUP (indexed)

Re: tst-arm-mte bug: PSTATE.TCO is cleared on exceptions

2020-05-07 Thread Richard Henderson
On 5/7/20 2:59 AM, Szabolcs Nagy wrote: > is there some recommended way to turn some form > of tracing on in qemu before i execute the > problematic application? I didn't add any tracing within mte. I can do so if we can guess what we're looking for. > or is it better if i try to extract a

Re: [PULL 04/10] target/arm: Use tcg_gen_gvec_dup_imm

2020-05-07 Thread Richard Henderson
On 5/7/20 7:39 AM, Laurent Desnogues wrote: >> @@ -2044,7 +2044,7 @@ static bool trans_DUP_x(DisasContext *s, arg_DUP_x *a) >> unsigned nofs = vec_reg_offset(s, a->rn, index, esz); >> tcg_gen_gvec_dup_mem(esz, dofs, nofs, vsz, vsz); >> } else { >> -

Re: [PATCH] ppc/pnv: Fix NMI system reset SRR1 value

2020-05-07 Thread Cédric Le Goater
On 5/7/20 1:48 PM, Nicholas Piggin wrote: > Commit a77fed5bd926 ("ppc/pnv: Add support for NMI interface") got the > SRR1 setting wrong for sresets that hit outside of power-save states. > > Fix this, better documenting the source for the bit definitions. > > Fixes: a77fed5bd926 ("ppc/pnv: Add

[Bug 1877418] [NEW] qemu-nbd freezes access to VDI file

2020-05-07 Thread Bump
Public bug reported: Mounted Oracle Virtualbox .vdi drive, which has GTP+BTRFS: sudo qemu-nbd -c /dev/nbd0 /storage/btrfs.vdi Then I am operating on the btrfs filesystem and suddenly it freezes. ** Affects: qemu Importance: Undecided Status: New -- You received this bug

Re: device hotplug & file handles

2020-05-07 Thread Eric Blake
On 5/7/20 9:49 AM, Gerd Hoffmann wrote: Hi, For usb device pass-through (aka -device usb-host) it would be very useful to pass file handles from libvirt to qemu. The workflow would change from ... (1) libvirt enables access to /dev/usb/$bus/$dev (2) libvirt passes $bus + $dev (using

Re: [RFC PATCH] qom: Implement qom-get HMP command

2020-05-07 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Cédric Le Goater writes: > > > From: "Dr. David Alan Gilbert" > > > > Reimplement it based on qmp_qom_get() to avoid converting QObjects back > > to strings. > > > > Inspired-by: Paolo Bonzini > > Signed-off-by: Andreas Färber > > > > Slight

[PULL 09/12] migration/rdma: fix a memleak on error path in rdma_start_incoming_migration

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: Pan Nengyuan 'rdma->host' is malloced in qemu_rdma_data_init, but forgot to free on the error path in rdma_start_incoming_migration(), this patch fix that. The leak stack: Direct leak of 2 byte(s) in 1 object(s) allocated from: #0 0x7fb7add18ae8 in __interceptor_malloc

[PULL 11/12] migration/multifd: fix memleaks in multifd_new_send_channel_async

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: Pan Nengyuan When error happen in multifd_new_send_channel_async, 'sioc' will not be used to create the multifd_send_thread. Let's free it to avoid a memleak. And also do error_free after migrate_set_error() to avoid another leak in the same place. The leak stack: Direct leak of 2880

[PULL 07/12] migration/throttle: Add cpu-throttle-tailslow migration parameter

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: Keqian Zhu At the tail stage of throttling, the Guest is very sensitive to CPU percentage while the @cpu-throttle-increment is excessive usually at tail stage. If this parameter is true, we will compute the ideal CPU percentage used by the Guest, which may exactly make the dirty rate

[PULL 10/12] migration/xbzrle: add encoding rate

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: Wei Wang Users may need to check the xbzrle encoding rate to know if the guest memory is xbzrle encoding-friendly, and dynamically turn off the encoding if the encoding rate is low. Signed-off-by: Yi Sun Signed-off-by: Wei Wang Message-Id:

[PULL 08/12] migration/ram: Consolidate variable reset after placement in ram_load_postcopy()

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: David Hildenbrand Let's consolidate resetting the variables. Cc: "Dr. David Alan Gilbert" Cc: Juan Quintela Cc: Peter Xu Signed-off-by: David Hildenbrand Message-Id: <20200421085300.7734-10-da...@redhat.com> Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert

[PULL 06/12] migration/colo: Add missing error-propagation code

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: Philippe Mathieu-Daudé Running the coccinelle script produced: $ spatch \ --macro-file scripts/cocci-macro-file.h --include-headers \ --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \ --keep-comments --smpl-spacing --dir . HANDLING: ./migration/colo.c

[PULL 05/12] docs/devel/migration: start a debugging section

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: Marc-André Lureau Explain how to use analyze-migration.py, this may help. Signed-off-by: Marc-André Lureau Message-Id: <20200330174852.456148-1-marcandre.lur...@redhat.com> Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Signed-off-by: Dr. David Alan Gilbert ---

[PULL 12/12] migration/multifd: Do error_free after migrate_set_error to avoid memleaks

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: Pan Nengyuan When error happen in multifd_send_thread, it use error_copy to set migrate error in multifd_send_terminate_threads(). We should call error_free after it. Similarly, fix another two places in multifd_recv_thread/multifd_save_cleanup. The leak stack: Direct leak of 48 byte(s)

[PULL 04/12] migration: move the units of migrate parameters from milliseconds to ms

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: Mao Zhongyi Signed-off-by: Mao Zhongyi Reviewed-by: Juan Quintela Message-Id: <474bb6cf67defb8be9de5035c11aee57a680557a.1585641083.git.maozhon...@cmss.chinamobile.com> Reviewed-by: Stefano Garzarella Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 2 +-

[PULL 03/12] monitor/hmp-cmds: add hmp_handle_error() for hmp_migrate_set_speed()

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: Mao Zhongyi Signed-off-by: Mao Zhongyi Reviewed-by: Juan Quintela Message-Id: <305323f835436023c53d759f5ab18af3ec874183.1585641083.git.maozhon...@cmss.chinamobile.com> Signed-off-by: Dr. David Alan Gilbert --- monitor/hmp-cmds.c | 5 - 1 file changed, 4 insertions(+), 1

[PULL 02/12] migration/migration: improve error reporting for migrate parameters

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: Mao Zhongyi use QERR_INVALID_PARAMETER_VALUE instead of "Parameter '%s' expects" for consistency. Signed-off-by: Mao Zhongyi Message-Id: <4ce71da4a5f98ad6ead0806ec71043473dcb4c07.1585641083.git.maozhon...@cmss.chinamobile.com> Reviewed-by: Juan Quintela Signed-off-by: Dr. David Alan

[PULL 00/12] migration queue

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 3c7adbc67d9a5c3e992a4dd13b8704464daaad5b: Merge remote-tracking branch 'remotes/berrange/tags/qcrypto-next-pull-request' into staging (2020-05-07 14:30:12 +0100) are available in the Git repository at:

[PULL 01/12] migration: fix bad indentation in error_report()

2020-05-07 Thread Dr. David Alan Gilbert (git)
From: Mao Zhongyi bad indentation conflicts with CODING_STYLE doc. Signed-off-by: Mao Zhongyi Message-Id: <09f7529c665cac0c6a5e032ac6fdb6ca701f7e37.1585329482.git.maozhon...@cmss.chinamobile.com> Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Dr. David Alan

Re: [PATCH] 9pfs: Fix potential deadlock of QEMU mainloop

2020-05-07 Thread Greg Kurz
On Thu, 07 May 2020 17:03:46 +0200 Christian Schoenebeck wrote: > On Donnerstag, 7. Mai 2020 16:33:28 CEST Greg Kurz wrote: > > > I also haven't reviewed QEMU's lock implementations in very detail, but > > > IIRC CoMutexes are completely handled in user space, while QemuMutex uses > > > regular

Re: [RFC PATCH 6/6] hw/block/nvme: Make device target agnostic

2020-05-07 Thread Paolo Bonzini
On 07/05/20 12:04, Stefan Hajnoczi wrote: >>> (NVME_PMRCAP_PMRWBM(n->bar.pmrcap) & 0x02)) { >>> -qemu_ram_writeback(n->pmrdev->mr.ram_block, >>> - 0, n->pmrdev->size); >>> +memory_region_do_writeback(>pmrdev->mr, 0,

[PATCH] tests/acceptance/boot_linux: Skip slow Aarch64 'virt' machine TCG test

2020-05-07 Thread Philippe Mathieu-Daudé
The BootLinuxAarch64.test_virt_tcg is reported to take >7min to run. Add a possibility to users to skip this particular test, by setting the AVOCADO_SKIP_SLOW_TESTS environment variable: $ AVOCADO_SKIP_SLOW_TESTS=please make check-acceptance ... (05/88)

Re: device hotplug & file handles

2020-05-07 Thread Peter Krempa
On Thu, May 07, 2020 at 16:49:14 +0200, Gerd Hoffmann wrote: > Hi, > > For usb device pass-through (aka -device usb-host) it would be very > useful to pass file handles from libvirt to qemu. The workflow would > change from ... > > (1) libvirt enables access to /dev/usb/$bus/$dev > (2)

[PATCH] target/ppc: Untabify excp_helper.c

2020-05-07 Thread Greg Kurz
Some tabs crept in with a recent change. Fixes: 6dc6b557913f "target/ppc: Improve syscall exception logging" Signed-off-by: Greg Kurz --- target/ppc/excp_helper.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/ppc/excp_helper.c

Re: [PATCH v5 01/14] qcrypto/core: add generic infrastructure for crypto options amendment

2020-05-07 Thread Eric Blake
On 5/7/20 7:54 AM, Maxim Levitsky wrote: This will be used first to implement luks keyslot management. block_crypto_amend_opts_init will be used to convert qemu-img cmdline to QCryptoBlockAmendOptions Signed-off-by: Maxim Levitsky Reviewed-by: Daniel P. Berrangé --- +++ b/qapi/crypto.json

Re: [PATCH v4 6/6] net/colo-compare.c: Correct ordering in complete and finalize

2020-05-07 Thread Lukas Straub
On Thu, 7 May 2020 13:26:11 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub > > Sent: Monday, May 4, 2020 6:28 PM > > To: qemu-devel > > Cc: Zhang, Chen ; Li Zhijian > > ; Jason Wang ; Marc- > > André Lureau ; Paolo Bonzini > > > > Subject: [PATCH v4 6/6]

[PATCH] accel: Move Xen accelerator code under accel/xen/

2020-05-07 Thread Philippe Mathieu-Daudé
This code is not related to hardware emulation. Move it under accel/ with the other hypervisors. Signed-off-by: Philippe Mathieu-Daudé --- We could also move the memory management functions from hw/i386/xen/xen-hvm.c but it is not trivial. Necessary step to remove "exec/ram_addr.h" in the next

Re: [PATCH 0/2] migration/multifd: fix two memleaks

2020-05-07 Thread Dr. David Alan Gilbert
* Pan Nengyuan (pannengy...@huawei.com) wrote: > Fix two memleaks in multifd_send_thread/multifd_new_send_channel_async when > error happen. > > Pan Nengyuan (2): > migration/multifd: fix memleaks in multifd_new_send_channel_async > migration/multifd: Do error_free after migrate_set_error to

Re: [PATCH 2/2] block/block-copy: Simplify block_copy_do_copy()

2020-05-07 Thread Eric Blake
On 5/7/20 7:11 AM, Philippe Mathieu-Daudé wrote: block_copy_do_copy() is static, only used in block_copy_task_entry with the error_is_read argument set. No need to check for it, simplify. Signed-off-by: Philippe Mathieu-Daudé --- block/block-copy.c | 12 +++- 1 file changed, 3

Re: [RFC v1 3/4] vhost-vdpa: implement vhost-vdpa backend

2020-05-07 Thread Cindy Lu
On Thu, May 7, 2020 at 11:30 PM Maxime Coquelin wrote: > > > > On 4/20/20 11:32 AM, Cindy Lu wrote: > > diff --git a/include/hw/virtio/vhost-backend.h > > b/include/hw/virtio/vhost-backend.h > > index 6f6670783f..d81bd9885f 100644 > > --- a/include/hw/virtio/vhost-backend.h > > +++

Re: [PATCH v4 09/13] migration/ram: Consolidate variable reset after placement in ram_load_postcopy()

2020-05-07 Thread David Hildenbrand
On 07.05.20 17:42, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >> * David Hildenbrand (da...@redhat.com) wrote: >>> Let's consolidate resetting the variables. >>> >>> Cc: "Dr. David Alan Gilbert" >>> Cc: Juan Quintela >>> Cc: Peter Xu >>> Signed-off-by:

Re: [PATCH v6 3/5] 9pfs: add new function v9fs_co_readdir_many()

2020-05-07 Thread Greg Kurz
On Thu, 07 May 2020 14:16:43 +0200 Christian Schoenebeck wrote: > On Montag, 4. Mai 2020 11:18:34 CEST Greg Kurz wrote: > > On Fri, 01 May 2020 16:04:41 +0200 > > > > Christian Schoenebeck wrote: > > > On Donnerstag, 30. April 2020 15:30:49 CEST Greg Kurz wrote: > > > > > > I agree that a

Re: [PATCH v4 5/6] net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active

2020-05-07 Thread Lukas Straub
On Thu, 7 May 2020 11:38:04 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub > > Sent: Monday, May 4, 2020 6:28 PM > > To: qemu-devel > > Cc: Zhang, Chen ; Li Zhijian > > ; Jason Wang ; Marc- > > André Lureau ; Paolo Bonzini > > > > Subject: [PATCH v4 5/6]

Re: [PULL 13/32] cpus: Fix configure_icount() error API violation

2020-05-07 Thread Peter Maydell
On Wed, 29 Apr 2020 at 08:34, Markus Armbruster wrote: > > The Error ** argument must be NULL, _abort, _fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer

Re: [PATCH 1/2] block/block-copy: Fix uninitialized variable in block_copy_task_entry

2020-05-07 Thread Eric Blake
On 5/7/20 7:11 AM, Philippe Mathieu-Daudé wrote: Fix when building with -Os: CC block/block-copy.o block/block-copy.c: In function ‘block_copy_task_entry’: block/block-copy.c:428:38: error: ‘error_is_read’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

Re: [RFC v1 3/4] vhost-vdpa: implement vhost-vdpa backend

2020-05-07 Thread Cindy Lu
On Thu, May 7, 2020 at 11:13 PM Maxime Coquelin wrote: > > > > On 4/20/20 11:32 AM, Cindy Lu wrote: > > Currently we have 2 types of vhost backends in QEMU: vhost kernel and > > vhost-user. The above patch provides a generic device for vDPA purpose, > > this vDPA device exposes to user space a

Re: [PULL 24/24] block/block-copy: use aio-task-pool API

2020-05-07 Thread Peter Maydell
On Tue, 5 May 2020 at 13:59, Max Reitz wrote: > > From: Vladimir Sementsov-Ogievskiy > > Run block_copy iterations in parallel in aio tasks. > > Changes: > - BlockCopyTask becomes aio task structure. Add zeroes field to pass > it to block_copy_do_copy > - add call state - it's a state of

Re: [PATCH v3] migration/xbzrle: add encoding rate

2020-05-07 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > Users may need to check the xbzrle encoding rate to know if the guest > memory is xbzrle encoding-friendly, and dynamically turn off the > encoding if the encoding rate is low. > > Signed-off-by: Yi Sun > Signed-off-by: Wei Wang Queued > --- >

Re: [PATCH v4 5/5] block/block-copy: use aio-task-pool API

2020-05-07 Thread Kevin Wolf
Am 29.04.2020 um 15:08 hat Vladimir Sementsov-Ogievskiy geschrieben: > Run block_copy iterations in parallel in aio tasks. > > Changes: > - BlockCopyTask becomes aio task structure. Add zeroes field to pass > it to block_copy_do_copy > - add call state - it's a state of one call of

Re: [PATCH v4 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send

2020-05-07 Thread Lukas Straub
On Thu, 7 May 2020 11:00:26 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub > > Sent: Monday, May 4, 2020 6:28 PM > > To: qemu-devel > > Cc: Zhang, Chen ; Li Zhijian > > ; Jason Wang ; Marc- > > André Lureau ; Paolo Bonzini > > > > Subject: [PATCH v4 3/6]

Re: [RFC v3 6/6] hmp: add x-debug-virtio commands

2020-05-07 Thread Eric Blake
On 5/7/20 6:49 AM, Laurent Vivier wrote: This patch implements HMP version of the virtio QMP commands Signed-off-by: Laurent Vivier Most HMP commands do not use '-' in their name. Also, HMP doesn't promise api compatibility; so we could just name this 'info virtio' or 'debug_virtio'

Re: [PATCH v5 19/31] qcow2: Add subcluster support to calculate_l2_meta()

2020-05-07 Thread Alberto Garcia
On Thu 07 May 2020 05:34:18 PM CEST, Alberto Garcia wrote: > On Wed 06 May 2020 07:39:48 PM CEST, Eric Blake wrote: >> In fact, if we rely on 20/31 checking for invalid subclusters when >> computing nb_clusters, we could probably assert that the start and end >> cluster in this function are not

Re: [RFC v3 3/6] qmp: decode feature bits in virtio-status

2020-05-07 Thread Eric Blake
On 5/7/20 6:49 AM, Laurent Vivier wrote: Display feature names instead of a features bitmap for host, guest and backend. Decode features according device type, transport features are on the first line. Undecoded bits (if any) are stored in a separate field. Signed-off-by: Laurent Vivier ---

Re: [PATCH v4 09/13] migration/ram: Consolidate variable reset after placement in ram_load_postcopy()

2020-05-07 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * David Hildenbrand (da...@redhat.com) wrote: > > Let's consolidate resetting the variables. > > > > Cc: "Dr. David Alan Gilbert" > > Cc: Juan Quintela > > Cc: Peter Xu > > Signed-off-by: David Hildenbrand > > Reviewed-by: Dr. David

Re: [RFC v3 1/6] qmp: add QMP command x-debug-query-virtio

2020-05-07 Thread Eric Blake
On 5/7/20 6:49 AM, Laurent Vivier wrote: This new command lists all the instances of VirtIODevice with their path and virtio type Signed-off-by: Laurent Vivier --- +++ b/qapi/virtio.json @@ -0,0 +1,68 @@ +## +# = Virtio devices +## + +## +# @VirtioType: +# +# An enumeration of Virtio device

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

2020-05-07 Thread Dima Stepanov
On Wed, May 06, 2020 at 06:08:34PM -0400, Raphael Norwitz wrote: > As you correctly point out, this code needs to be looked at more > carefully so that > if the device does disconnect in the background we can handle the migration > path > gracefully. In particular, we need to decide whether a

Re: [PATCH v5 19/31] qcow2: Add subcluster support to calculate_l2_meta()

2020-05-07 Thread Alberto Garcia
On Wed 06 May 2020 07:39:48 PM CEST, Eric Blake wrote: > In fact, if we rely on 20/31 checking for invalid subclusters when > computing nb_clusters, we could probably assert that the start and end > cluster in this function are not invalid, instead of adding the fail: > label. I think you're

Re: [PATCH v3] migration/throttle: Add cpu-throttle-tailslow migration parameter

2020-05-07 Thread Dr. David Alan Gilbert
* Keqian Zhu (zhukeqi...@huawei.com) wrote: > At the tail stage of throttling, the Guest is very sensitive to > CPU percentage while the @cpu-throttle-increment is excessive > usually at tail stage. > > If this parameter is true, we will compute the ideal CPU percentage > used by the Guest, which

Re: [RFC v1 3/4] vhost-vdpa: implement vhost-vdpa backend

2020-05-07 Thread Maxime Coquelin
On 4/20/20 11:32 AM, Cindy Lu wrote: > diff --git a/include/hw/virtio/vhost-backend.h > b/include/hw/virtio/vhost-backend.h > index 6f6670783f..d81bd9885f 100644 > --- a/include/hw/virtio/vhost-backend.h > +++ b/include/hw/virtio/vhost-backend.h > @@ -17,7 +17,8 @@ typedef enum

Re: [PATCH] linux-user/sparc64: Translate flushw opcode

2020-05-07 Thread Artyom Tarasenko
On Thu, May 7, 2020 at 4:17 PM Laurent Vivier wrote: > > Hi, > > could someone with SPARC knowledge review this patch? > I'd like to add it to linux-user queue. > Since it's TCG, I'd really preferred a review from Richard. Regards, Artyom > > Le 17/04/2020 à 13:06, LemonBoy a écrit : > > Ping,

Re: [PATCH v5 00/14] LUKS: encryption slot management using amend interface

2020-05-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200507125414.2151-1-mlevi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200507125414.2151-1-mlevi...@redhat.com Subject: [PATCH v5 00/14] LUKS: encryption slot management

Re: [PATCH v4 11/14] block/core: add generic infrastructure for x-blockdev-amend qmp command

2020-05-07 Thread Eric Blake
On 5/5/20 3:08 PM, Maxim Levitsky wrote: blockdev-amend will be used similiar to blockdev-create to allow on the fly changes of the structure of the format based block devices. Current plan is to first support encryption keyslot management for luks based formats (raw and embedded in qcow2)

Re: [PATCH-for-5.1 v3 4/7] migration/colo: Add missing error-propagation code

2020-05-07 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > Running the coccinelle script produced: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \ > --keep-comments --smpl-spacing --dir . >

[PATCH 5/5] docs/system: Document Musca boards

2020-05-07 Thread Peter Maydell
Provide a minimal documentation of the Musca boards. Signed-off-by: Peter Maydell --- docs/system/arm/musca.rst | 31 +++ docs/system/target-arm.rst | 1 + MAINTAINERS| 1 + 3 files changed, 33 insertions(+) create mode 100644

[PATCH 4/5] docs/system: Document the various MPS2 models

2020-05-07 Thread Peter Maydell
Add basic documentation of the MPS2 board models. Signed-off-by: Peter Maydell --- docs/system/arm/mps2.rst | 29 + docs/system/target-arm.rst | 1 + MAINTAINERS| 1 + 3 files changed, 31 insertions(+) create mode 100644 docs/system/arm/mps2.rst

[PATCH 3/5] docs/system: Document Arm Versatile Express boards

2020-05-07 Thread Peter Maydell
Provide a minimal documentation of the Versatile Express boards (vexpress-a9, vexpress-a15). Signed-off-by: Peter Maydell --- docs/system/arm/vexpress.rst | 60 docs/system/target-arm.rst | 1 + MAINTAINERS | 1 + 3 files changed, 62

[Bug 1877384] [NEW] 9pfs file create with mapped-xattr can fail on overlayfs

2020-05-07 Thread Fishface60
Public bug reported: QEMU Version: 3.1.0 as packaged in debian buster, but the code appears to do the same in master. qemu command-line: qemu-system-x86_64 -m 1G -nographic -nic "user,model=virtio-net-pci,tftp=$(pwd),net=10.0.2.0/24,host=10.0.2.2" -fsdev

Re: [PATCH v2 10/9] qed: Simplify backing reads

2020-05-07 Thread Eric Blake
On 5/7/20 9:45 AM, Eric Blake wrote: The other four drivers that support backing files (qcow, qcow2, parallels, vmdk) all rely on the block layer to populate zeroes when reading beyond EOF of a short backing file. We can simplify the qed code by doing likewise. Signed-off-by: Eric Blake ---

[PATCH 1/5] docs/system: Add 'Arm' to the Integrator/CP document title

2020-05-07 Thread Peter Maydell
Add 'Arm' to the Integrator/CP document title, for consistency with the titling of the other documentation of Arm devboard models (versatile, realview). Signed-off-by: Peter Maydell --- docs/system/arm/integratorcp.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PULL 0/5] Misc crypto subsystem fixes

2020-05-07 Thread Peter Maydell
On Thu, 7 May 2020 at 12:59, Daniel P. Berrangé wrote: > > The following changes since commit 609dd53df540edd72faee705205aceca9c42fea5: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20200506' into stag= > ing (2020-05-07 09:45:54 +0100) > > are available in the Git repository at:

[PATCH 2/5] docs/system: Sort Arm board index into alphabetical order

2020-05-07 Thread Peter Maydell
Sort the board index into alphabetical order. (Note that we need to sort alphabetically by the title text of each file, which isn't the same ordering as sorting by the filename.) Signed-off-by: Peter Maydell --- docs/system/target-arm.rst | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH 0/5] docs/system: Document some arm board models

2020-05-07 Thread Peter Maydell
This patchset adds (minimal) documentation of these Arm board models: vexpress-a15 ARM Versatile Express for Cortex-A15 vexpress-a9 ARM Versatile Express for Cortex-A9 mps2-an385 ARM MPS2 with AN385 FPGA image for Cortex-M35 mps2-an505 ARM MPS2 with AN505 FPGA

Re: [PATCH Kernel v18 6/7] vfio iommu: Add migration capability to report supported features

2020-05-07 Thread Alex Williamson
On Thu, 7 May 2020 11:07:26 +0530 Kirti Wankhede wrote: > On 5/7/2020 3:57 AM, Alex Williamson wrote: > > On Mon, 4 May 2020 21:28:58 +0530 > > Kirti Wankhede wrote: > > > >> Added migration capability in IOMMU info chain. > >> User application should check IOMMU info chain for migration

Re: [PATCH v5 30/31] qcow2: Add subcluster support to qcow2_measure()

2020-05-07 Thread Alberto Garcia
On Wed 06 May 2020 08:13:51 PM CEST, Eric Blake wrote: > On 5/5/20 12:38 PM, Alberto Garcia wrote: >> Extended L2 entries are bigger than normal L2 entries so this has an >> impact on the amount of metadata needed for a qcow2 file. >> >> Signed-off-by: Alberto Garcia >> Reviewed-by: Max Reitz

Re: [PATCH 3/3] iotests: Mirror with different source/target size

2020-05-07 Thread Eric Blake
On 5/7/20 9:52 AM, Kevin Wolf wrote: This tests that the mirror job catches situations where the target node has a different size than the source node. It must also forbid resize operations when the job is already running. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/041 | 45

Re: [RFC v1 3/4] vhost-vdpa: implement vhost-vdpa backend

2020-05-07 Thread Maxime Coquelin
On 4/20/20 11:32 AM, Cindy Lu wrote: > Currently we have 2 types of vhost backends in QEMU: vhost kernel and > vhost-user. The above patch provides a generic device for vDPA purpose, > this vDPA device exposes to user space a non-vendor-specific configuration > interface for setting up a vhost

Re: [PATCH 2/3] mirror: Make sure that source and target size match

2020-05-07 Thread Eric Blake
On 5/7/20 9:52 AM, Kevin Wolf wrote: If the target is shorter than the source, mirror would copy data until it reaches the end of the target and then fail with an I/O error when trying to write past the end. If the target is longer than the source, the mirror job would complete successfully,

Re: [PATCH 1/3] iotests/229: Use blkdebug to inject an error

2020-05-07 Thread Eric Blake
On 5/7/20 9:52 AM, Kevin Wolf wrote: 229 relies on the mirror running into an I/O error when the target is smaller than the source. After changing mirror to catch this condition while starting the job, this test case won't get a job that is paused for an I/O error any more. Use blkdebug instead

Re: [PATCH] 9pfs: Fix potential deadlock of QEMU mainloop

2020-05-07 Thread Christian Schoenebeck
On Donnerstag, 7. Mai 2020 16:33:28 CEST Greg Kurz wrote: > > I also haven't reviewed QEMU's lock implementations in very detail, but > > IIRC CoMutexes are completely handled in user space, while QemuMutex uses > > regular OS mutexes and hence might cost context switches. > > ... since the

Re: Emulating Solaris 10 on SPARC64 sun4u

2020-05-07 Thread Artyom Tarasenko
On Thu, May 7, 2020 at 4:29 PM wrote: > > Just thought I'd chime in with an update. > > We are currently emulating a 16550A UART. The guest sees this as the SU > device, referring to the SuperIO port (a pair of 16550A UARTs). On the > Ultra 5, the machine that Sun4u is modelled against, SuperIO

Re: [PATCH 0/5] target/i386: fxtract, fscale fixes

2020-05-07 Thread Joseph Myers
On Thu, 7 May 2020, no-re...@patchew.org wrote: > === OUTPUT BEGIN === > 1/5 Checking commit 69eed0bcaaaf (target/i386: implement special cases for > fxtract) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? I don't think any MAINTAINERS update is needed for a new

[PATCH 3/3] iotests: Mirror with different source/target size

2020-05-07 Thread Kevin Wolf
This tests that the mirror job catches situations where the target node has a different size than the source node. It must also forbid resize operations when the job is already running. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/041 | 45 ++

[PATCH 2/3] mirror: Make sure that source and target size match

2020-05-07 Thread Kevin Wolf
If the target is shorter than the source, mirror would copy data until it reaches the end of the target and then fail with an I/O error when trying to write past the end. If the target is longer than the source, the mirror job would complete successfully, but the target wouldn't actually be an

[PATCH 1/3] iotests/229: Use blkdebug to inject an error

2020-05-07 Thread Kevin Wolf
229 relies on the mirror running into an I/O error when the target is smaller than the source. After changing mirror to catch this condition while starting the job, this test case won't get a job that is paused for an I/O error any more. Use blkdebug instead to inject an error. Signed-off-by:

[PATCH 0/3] mirror: Make sure that source and target size match

2020-05-07 Thread Kevin Wolf
Same thing as the recent fix for backup, except that mirror already forbids resizing during the job. So what remains is checking that the sizes match at the start of the job. Kevin Wolf (3): iotests/229: Use blkdebug to inject an error mirror: Make sure that source and target size match

[Bug 1877136] Re: Qemu GDB Arm core registers XML description not valid for M-profile

2020-05-07 Thread Peter Maydell
Patch submitted: https://patchew.org/QEMU/20200507134755.13997-1-peter.mayd...@linaro.org/ ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

device hotplug & file handles

2020-05-07 Thread Gerd Hoffmann
Hi, For usb device pass-through (aka -device usb-host) it would be very useful to pass file handles from libvirt to qemu. The workflow would change from ... (1) libvirt enables access to /dev/usb/$bus/$dev (2) libvirt passes $bus + $dev (using hostbus + hostaddr properties) to qemu.

Re: [PATCH] docs/devel/migration: start a debugging section

2020-05-07 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Explain how to use analyze-migration.py, this may help. > > Signed-off-by: Marc-André Lureau Queued > --- > docs/devel/migration.rst | 20 > 1 file changed, 20 insertions(+) > > diff --git

Re: [PATCH v2 0/3] Improved reporting for migrate parameters

2020-05-07 Thread Dr. David Alan Gilbert
* Mao Zhongyi (maozhon...@cmss.chinamobile.com) wrote: > This series mainly improve the report message of migrate parameters > to make it easier to read. Queued > v2->v1 > -p1: avoid using constants, replace it with stringify(). > > Cc: quint...@redhat.com > Cc: dgilb...@redhat.com > > Mao

[Bug 1856335] Re: Cache Layout wrong on many Zen Arch CPUs

2020-05-07 Thread Babu Moger
Yes. Sieger. Please install 5.0 it should work fine. I am not sure about 4.2. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1856335 Title: Cache Layout wrong on many Zen Arch CPUs Status in QEMU:

[PATCH v2 10/9] qed: Simplify backing reads

2020-05-07 Thread Eric Blake
The other four drivers that support backing files (qcow, qcow2, parallels, vmdk) all rely on the block layer to populate zeroes when reading beyond EOF of a short backing file. We can simplify the qed code by doing likewise. Signed-off-by: Eric Blake --- I noticed this during my audit that v1

<    1   2   3   4   >