Re: [RFC] hw: nios2: update interrupt_request when STATUS_PIE disabled

On 05/06/2020 07.59, Wu, Wentong wrote: > Hi all, > > I’m running icount mode on qemu_nios2 with customized  platform(almost > same with 10m50_devboard), > > but cpu abort happened(qemu: fatal: Raised interrupt while not in I/O > function) when guest code changes > > state register with wrctl in

Re: [PATCH v3] ati-vga: check mm_index before recursive call (CVE-2020-13800)

On Thu, Jun 04, 2020 at 03:59:05PM +0200, BALATON Zoltan wrote: > On Thu, 4 Jun 2020, Gerd Hoffmann wrote: > > > +} else if (s->regs.mm_index > MM_DATA + 3) { > > > val = ati_mm_read(s, s->regs.mm_index + addr - MM_DATA, > > > size); > > > > MM_INDEX is 0 > > MM_DATA is 4 >

RE: [RFC] hw: nios2: update interrupt_request when STATUS_PIE disabled

Thanks Thomas! @Chris Wulff @Marek Vasut could you please give some suggestions? Thanks -Original Message- From: Thomas Huth Sent: Friday, June 5, 2020 3:07 PM To: Wu, Wentong ; qemu-devel@nongnu.org Cc: Chris Wulff ; Marek Vasut Subject: Re: [RFC] hw: nios2: update interrupt_request w

Re: [PATCH] hw/display/cirrus_vga: Fix code mis-indentation

On Fri, May 29, 2020 at 06:54:36PM +0200, Philippe Mathieu-Daudé wrote: > While replacing fprintf() by qemu_log_mask() in commit > 2b55f4d3504, we incorrectly used a 'tab = 4 spaces' > alignment, leading to misindented new code. Fix now. > > Reported-by: Peter Maydell > Signed-off-by: Philippe M

Re: [PATCH v4 05/11] rules.mak: Add base-arch() rule

On 6/1/20 9:26 AM, Philippe Mathieu-Daudé wrote: > On 6/1/20 4:13 AM, Richard Henderson wrote: >> On 5/22/20 9:37 AM, Philippe Mathieu-Daudé wrote: >>> + $(if $(call startwith,risc,$1),risc,\ >> >> Should be "riscv" not "risc". Especially the substitution. > > Indeed. > >> >>> +

Re: [PATCH] linux-headers: update to Linux 5.8-rc1

On Thu, 4 Jun 2020 18:41:48 -0400 Paolo Bonzini wrote: Isn't it still a bit early for -rc1? :) Probably wants a commit id... > Signed-off-by: Paolo Bonzini > --- > include/standard-headers/asm-x86/kvm_para.h | 17 ++- > include/standard-headers/drm/drm_fourcc.h | 140 ++-- >

Re: [PATCH] linux-headers: update to Linux 5.8-rc1

Il ven 5 giu 2020, 09:28 Cornelia Huck ha scritto: > On Thu, 4 Jun 2020 18:41:48 -0400 > Paolo Bonzini wrote: > > Isn't it still a bit early for -rc1? :) Probably wants a commit id... > > > Signed-off-by: Paolo Bonzini > > --- > > include/standard-headers/asm-x86/kvm_para.h | 17 ++- > > inc

[PATCH 1/1] target/ppc: add vmsumudm vmsumcud instructions

vmsumudm (Power ISA 3.0) - Vector Multiply-Sum Unsigned Doubleword Modulo VA-form. vmsumcud (Power ISA 3.1) - Vector Multiply-Sum & write Carry-out Unsigned Doubleword VA-form. Signed-off-by: Lijun Pan --- disas/ppc.c | 2 ++ include/qemu/host-utils.h | 2 ++

[PATCH v5 00/11] accel: Allow targets to use Kconfig

Missing review: - 4/11 rules.mak: Add strequal() and startwith() and rules - 5/11 rules.mak: Add base-arch() rule This series include generic patches I took of the KVM/ARM specific series which will follow. - List orphan accelerators in MAINTAINERS - Add accel/Kconfig - Allow targets to use their

[PATCH v5 02/11] MAINTAINERS: Add an 'overall' entry for accelerators

Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Cc: Paolo Bonzini v2: Cover accel/accel.c & accel/Makefile.objs (thuth) --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 948790b433..f725c12161 100644 --- a/

[PATCH 1/4] riscv: Generalize CPU init routine for the base CPU

From: Bin Meng There is no need to have two functions that have exactly the same codes for 32-bit and 64-bit base CPUs. Signed-off-by: Bin Meng --- target/riscv/cpu.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.

[PATCH 3/4] riscv: Generalize CPU init routine for the imacu CPU

From: Bin Meng There is no need to have two functions that have almost the same codes for 32-bit and 64-bit imacu CPUs. Signed-off-by: Bin Meng --- target/riscv/cpu.c | 31 ++- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/target/riscv/cpu.c b/tar

[PATCH v5 01/11] MAINTAINERS: Fix KVM path expansion glob

The KVM files has been moved from target-ARCH to the target/ARCH/ folder in commit fcf5ef2a. Fix the pathname expansion. Fixes: fcf5ef2a ("Move target-* CPU file into a target/ folder") Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINER

[PATCH 2/4] riscv: Generalize CPU init routine for the gcsu CPU

From: Bin Meng There is no need to have two functions that have almost the same codes for 32-bit and 64-bit gcsu CPUs. Signed-off-by: Bin Meng --- target/riscv/cpu.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu

[PATCH v5 04/11] rules.mak: Add strequal() and startwith() and rules

Add a rule to test if two strings are equal, and another to test if a string starts with a substring, Signed-off-by: Philippe Mathieu-Daudé --- rules.mak | 14 ++ 1 file changed, 14 insertions(+) diff --git a/rules.mak b/rules.mak index 694865b63e..ccc1c49604 100644 --- a/rules.mak

[PATCH v5 06/11] Makefile: Remove dangerous EOL trailing backslash

One might get caught trying to understand unexpected Makefile behavior. Trailing backslash can help to split very long lines, but are rather dangerous when nothing follow. Preserve other developers debugging time by removing this one. Reviewed-by: Thomas Huth Reviewed-by: Alistair Francis Signed

[PATCH v5 05/11] rules.mak: Add base-arch() rule

Add a rule to return the base architecture for a QEMU target. The current list of TARGET_BASE_ARCH is: $ git grep TARGET_BASE_ARCH configure configure:7785:TARGET_BASE_ARCH="" configure:7795:TARGET_BASE_ARCH=i386 configure:7813:TARGET_BASE_ARCH=arm configure:7846:TARGET_BAS

Re: [PATCH] docker: update Ubuntu to 20.04

Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini > --- > tests/docker/dockerfiles/ubuntu.docker | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/docker/dockerfiles/ubuntu.docker > b/tests/docker/dockerfiles/ubuntu.docker > index eeb3b22bf2..43872417de 100644

[PATCH 4/4] riscv: Keep the CPU init routine names consistent

From: Bin Meng Adding a _ to keep some consistency among the CPU init routines. Signed-off-by: Bin Meng --- target/riscv/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index c5c2abc..5060534 100644 --- a/target/riscv/c

[PATCH v5 07/11] Makefile: Write MINIKCONF variables as one entry per line

Having one entry per line helps reviews/refactors. As we are going to modify the MINIKCONF variables, split them now to ease further review. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --g

[PATCH v5 03/11] MAINTAINERS: Add an entry for the HAX accelerator

Nobody replied since the first time [*] that patch was posted, so mark HAX as orphan. [*] https://mid.mail-archive.com/20200316120049.11225-4-philmd@redhat.com Signed-off-by: Philippe Mathieu-Daudé --- This patch has been posted 5 times, first time more than 2 months ago: https://www.mail-archiv

[PATCH v5 09/11] accel/Kconfig: Add the TCG selector

Expose the CONFIG_TCG selector to let minikconf.py uses it. When building with --disable-tcg build, this helps to deselect devices that are TCG-dependent. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 1 + accel/Kconfig | 3 +++ 2 files changed, 4 ins

[PATCH v5 10/11] Makefile: Allow target-specific optional Kconfig

Allow use of target-specific Kconfig file. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- v3: Use base-arch() to include TARGET_BASE_ARCH/Kconfig --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index f8a45e1379..d

[PATCH v5 08/11] accel/Kconfig: Extract accel selectors into their own config

Move the accel selectors from the global Kconfig.host to their own Kconfig file. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 1 + Kconfig.host | 7 --- accel/Kconfig | 6 ++ 3 files changed, 7 insertions(+), 7 deletions(-) create mode 10064

Re: [PATCH v5 04/11] rules.mak: Add strequal() and startwith() and rules

Err extra 'and' in patch subject, should be: "rules.mak: Add strequal() and startwith() rules" I can respin the whole if it is easier for the maintainer. On 6/5/20 9:39 AM, Philippe Mathieu-Daudé wrote: > Add a rule to test if two strings are equal, > and another to test if a string starts with a

[PATCH v5 11/11] accel/tcg: Add stub for probe_access()

From: Philippe Mathieu-Daudé The TCG helpers where added in b92e5a22ec3 in softmmu_template.h. probe_write() was added in there in 3b4afc9e75a to be moved out to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored as probe_access() in c25c283df0f. Since it is a TCG specific helper, add a

Re: [PATCH v5 11/11] accel/tcg: Add stub for probe_access()

On 05.06.20 09:39, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > The TCG helpers where added in b92e5a22ec3 in softmmu_template.h. > probe_write() was added in there in 3b4afc9e75a to be moved out > to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored > as probe_acces

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

David: Indeed ! How stupid I am. I missed the root cause inside QUEMU log file. This was clear enough... error: kvm run failed Device or resource busy This is probably because your SMT is enabled. So I switch SMT (Power Simultaneous Multi-Threading) off and now it's OK; VMs are running and instal

Re: [PATCH v4 2/3] hw/acpi/nvdimm: add a helper to augment SRAT generation

On Fri, 5 Jun 2020 00:54:28 + "Verma, Vishal L" wrote: > On Thu, 2020-06-04 at 12:33 +0200, Igor Mammedov wrote: > > On Thu, 28 May 2020 16:34:36 -0600 > > Vishal Verma wrote: > > > > > NVDIMMs can belong to their own proximity domains, as described by the > > > NFIT. In such cases, the S

Re: [PATCH v4] osdep: Make MIN/MAX evaluate arguments only once

On Thursday, 2020-06-04 at 16:52:36 -05, Eric Blake wrote: > /* Minimum function that returns zero only iff both values are zero. Not your change, but "only" is unnecessary here (or iff -> if). dme. -- But uh oh, I love her because, she moves in her own way.

Re: [PATCH] docker: update Ubuntu to 20.04

On 6/5/20 1:17 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > tests/docker/dockerfiles/ubuntu.docker | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/docker/dockerfiles/ubuntu.docker > b/tests/docker/dockerfiles/ubuntu.docker > index eeb3b22bf2..43

Re: [PATCH] numa: forbid '-numa node, mem' for 5.1 and newer machine types

On Thu, 4 Jun 2020 07:22:51 -0500 Eric Blake wrote: > On 6/2/20 3:41 AM, Igor Mammedov wrote: > > Deprecation period is run out and it's a time to flip the switch > > introduced by cd5ff8333a. Disable legacy option for new machine > > types (since 5.1) and amend documentation. > > > > '-numa no

Re: [PATCH v2] hw/sd/sdcard: Verify CMD24 (Block Write) address is valid

On 6/4/20 8:25 PM, Philippe Mathieu-Daudé wrote: > Avoid OOB access by verifying the requested address belong to > the actual card size. Return ADDRESS_ERROR when not in range. > Only move the state machine to ReceivingData if there is no > pending error. > > "SD Specifications Part 1 Physical L

Re: [PATCH v5 03/11] MAINTAINERS: Add an entry for the HAX accelerator

On 6/5/20 9:39 AM, Philippe Mathieu-Daudé wrote: > Nobody replied since the first time [*] that patch was > posted, so mark HAX as orphan. > > [*] https://mid.mail-archive.com/20200316120049.11225-4-philmd@redhat.com > > Signed-off-by: Philippe Mathieu-Daudé > --- > This patch has been posted 5

Re: [PATCH for-5.1 V4 0/7] mips: Add Loongson-3 machine support (with KVM)

уто, 2. јун 2020. у 04:38 Huacai Chen је написао/ла: > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > R1/R2. Hi, Huacai, The documents you kindly provided contain some valuable info on Loongson-3A R1/R2/R3/R4 and Loongson-3B R1/R2. However, I couldn't find detailed ins

Re: [PATCH for-5.1 V4 0/7] mips: Add Loongson-3 machine support (with KVM)

Just adding Jiaxun. пет, 5. јун 2020. у 10:38 Aleksandar Markovic је написао/ла: > > уто, 2. јун 2020. у 04:38 Huacai Chen је написао/ла: > > > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > > R1/R2. > > Hi, Huacai, > > The documents you kindly provided contain some va

Re: [PATCH v4] osdep: Make MIN/MAX evaluate arguments only once

On 6/5/20 10:24 AM, David Edmondson wrote: > On Thursday, 2020-06-04 at 16:52:36 -05, Eric Blake wrote: > >> /* Minimum function that returns zero only iff both values are zero. > > Not your change, but "only" is unnecessary here (or iff -> if). Maybe we should teach checkpatch.pl to refuse the

Re: [PATCH] linux-headers: update to Linux 5.8-rc1

On Fri, 5 Jun 2020 09:35:33 +0200 Paolo Bonzini wrote: > Il ven 5 giu 2020, 09:28 Cornelia Huck ha scritto: > > > On Thu, 4 Jun 2020 18:41:48 -0400 > > Paolo Bonzini wrote: > > > > Isn't it still a bit early for -rc1? :) Probably wants a commit id... > > > > > Signed-off-by: Paolo Bonzini

Re: [PATCH RFC v2 1/5] block: add bitmap-populate job

Am 04.06.2020 um 18:22 hat Peter Krempa geschrieben: > On Thu, Jun 04, 2020 at 13:31:45 +0200, Kevin Wolf wrote: > > Am 04.06.2020 um 11:16 hat Peter Krempa geschrieben: > > > On Thu, Jun 04, 2020 at 11:12:31 +0200, Kevin Wolf wrote: > > > > Am 18.05.2020 um 22:49 hat Eric Blake geschrieben: > > >

Re: [PATCH v2] hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE

On Thu, Jun 04, 2020 at 02:40:22PM +0100, Alex Bennée wrote: > The purpose of vhost_section is to identify RAM regions that need to > be made available to a vhost client. However when running under TCG > all RAM sections have DIRTY_MEMORY_CODE set which leads to problems > down the line. > > Re-fa

Re: [PATCH for-5.1 V4 0/7] mips: Add Loongson-3 machine support (with KVM)

On Fri, 5 Jun 2020 10:38:36 +0200 Aleksandar Markovic wrote: > ??, 2. ?0?6 2020. ?? 04:38 Huacai Chen ?0?6?? > ??/: > > > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and > > Loongson-3B R1/R2. > > Hi, Huacai, > > The documents you kindly provided contain s

Re: [PATCH] docker: update Ubuntu to 20.04

Il ven 5 giu 2020, 10:32 Philippe Mathieu-Daudé ha scritto: > Still not sure how to do. Add ubuntu-old.docker based on 19.04 and then > roll 'ubuntu.docker' -> 'ubuntu-old.docker' for each new releases? > We have an image for 18.04 already, I think we should roll ubuntu.docker every six months a

Re: [PATCH for-5.1 V4 0/7] mips: Add Loongson-3 machine support (with KVM)

Hi, Jiaxun, On Fri, Jun 5, 2020 at 5:06 PM Jiaxun Yang wrote: > > On Fri, 5 Jun 2020 10:38:36 +0200 > Aleksandar Markovic wrote: > > > уто, 2. јун 2020. у 04:38 Huacai Chen је > > написао/ла: > > > > > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and > > > Loongson-3B R1/R2. > > > >

Re: [PATCH RFC v2 1/5] block: add bitmap-populate job

On Fri, Jun 05, 2020 at 11:01:23 +0200, Kevin Wolf wrote: > Am 04.06.2020 um 18:22 hat Peter Krempa geschrieben: > > On Thu, Jun 04, 2020 at 13:31:45 +0200, Kevin Wolf wrote: > > > Am 04.06.2020 um 11:16 hat Peter Krempa geschrieben: > > > > On Thu, Jun 04, 2020 at 11:12:31 +0200, Kevin Wolf wrote:

Re: [PATCH v8 4/4] new qTest case to test the vhost-user-blk-server

On 05/06/2020 08.22, Coiby Xu wrote: > On Fri, Jun 05, 2020 at 07:01:33AM +0200, Thomas Huth wrote: >>> diff --git a/tests/qtest/libqos/vhost-user-blk.h >>> b/tests/qtest/libqos/vhost-user-blk.h >>> new file mode 100644 >>> index 00..ef4ef09cca >>> --- /dev/null >>> +++ b/tests/qtest/libqos

Re: [PATCH v3 00/16] python: add mypy support to python/qemu

Am 04.06.2020 um 22:22 hat John Snow geschrieben: > Based-on: 20200604195252.20739-1-js...@redhat.com > > This series is extracted from my larger series that attempted to bundle > our python module as an installable module. These fixes don't require that, > so they are being sent first as I think

Re: [PATCH v3] migration/xbzrle: add encoding rate

* Wei Wang (wei.w.w...@intel.com) wrote: > On 06/05/2020 12:57 AM, Richard Henderson wrote: > > On 6/4/20 3:27 AM, Wei Wang wrote: > > > On 06/04/2020 05:38 PM, Dr. David Alan Gilbert wrote: > > > > Hmm OK; I'll admit to not liking NaN/Inf in output. > > > > > > > > Dave > > > > > > > OK. To deal

Re: [PATCH for-5.1 V4 0/7] mips: Add Loongson-3 machine support (with KVM)

11:06 Pet, 05.06.2020. Jiaxun Yang је написао/ла: > > On Fri, 5 Jun 2020 10:38:36 +0200 > Aleksandar Markovic wrote: > > > уто, 2. јун 2020. у 04:38 Huacai Chen је > > написао/ла: > > > > > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and > > > Loongson-3B R1/R2. > > > > Hi, Huacai, >

[PATCH v6 00/11] accel: Allow targets to use Kconfig

Missing review: - 4/11 rules.mak: Add strequal() and startwith() rules - 5/11 rules.mak: Add base-arch() rule This series include generic patches I took of the KVM/ARM specific series which will follow. - List orphan accelerators in MAINTAINERS - Add accel/Kconfig - Allow targets to use their how

[PATCH v6 04/11] rules.mak: Add strequal() and startwith() rules

Add a rule to test if two strings are equal, and another to test if a string starts with a substring. Signed-off-by: Philippe Mathieu-Daudé --- rules.mak | 14 ++ 1 file changed, 14 insertions(+) diff --git a/rules.mak b/rules.mak index 694865b63e..ccc1c49604 100644 --- a/rules.mak

[PATCH v6 01/11] MAINTAINERS: Fix KVM path expansion glob

The KVM files has been moved from target-ARCH to the target/ARCH/ folder in commit fcf5ef2a. Fix the pathname expansion. Fixes: fcf5ef2a ("Move target-* CPU file into a target/ folder") Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINER

[PATCH v6 11/11] accel/tcg: Add stub for probe_access()

From: Philippe Mathieu-Daudé The TCG helpers where added in b92e5a22ec3 in softmmu_template.h. probe_write() was added in there in 3b4afc9e75a to be moved out to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored as probe_access() in c25c283df0f. Since it is a TCG specific helper, add a

[PATCH v6 03/11] MAINTAINERS: Add an entry for the HAX accelerator

Nobody replied since the first time [*] that patch was posted, so mark HAX as orphan. [*] https://mid.mail-archive.com/20200316120049.11225-4-philmd@redhat.com Cc: haxm-t...@intel.com Cc: Tao Wu Cc: Colin Xu Cc: Wenchao Wang Cc: Vincent Palatin Cc: Sergio Andres Gomez Del Real Signed-off-by:

[PATCH v6 05/11] rules.mak: Add base-arch() rule

Add a rule to return the base architecture for a QEMU target. The current list of TARGET_BASE_ARCH is: $ git grep TARGET_BASE_ARCH configure configure:7785:TARGET_BASE_ARCH="" configure:7795:TARGET_BASE_ARCH=i386 configure:7813:TARGET_BASE_ARCH=arm configure:7846:TARGET_BAS

[PATCH v6 02/11] MAINTAINERS: Add an 'overall' entry for accelerators

Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 948790b433..f725c12161 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -415,6 +415,17 @@ S: Supported F: target/i38

Re: [PATCH v3 0/3] python/machine.py: refactor shutdown

Am 04.06.2020 um 21:52 hat John Snow geschrieben: > v3: > - Split _post_shutdown refactor into own patch (now 1/3) Feels much easier to read now! > - Re-add sigkill warning squelch (now 3/3) > > NOTE: I re-added the squelch in its own patch for review purposes, but > for the purposes of avoidi

[PATCH v6 06/11] Makefile: Remove dangerous EOL trailing backslash

One might get caught trying to understand unexpected Makefile behavior. Trailing backslash can help to split very long lines, but are rather dangerous when nothing follow. Preserve other developers debugging time by removing this one. Reviewed-by: Thomas Huth Reviewed-by: Alistair Francis Signed

[PATCH v6 09/11] accel/Kconfig: Add the TCG selector

Expose the CONFIG_TCG selector to let minikconf.py uses it. When building with --disable-tcg build, this helps to deselect devices that are TCG-dependent. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 1 + accel/Kconfig | 3 +++ 2 files changed, 4 ins

Re: [PATCH v2] linux-user: support of semtimedop syscall

Le 28/05/2020 à 19:10, Laurent Vivier a écrit : > Le 12/05/2020 à 09:45, Matus Kysel a écrit : >> We should add support of semtimedop syscall as new version of >> glibc 2.31 uses semop based on semtimedop (commit: >> https://gitlab.com/freedesktop-sdk/mirrors/sourceware/glibc/-/commit/765cdd0bffd7

[PATCH v6 07/11] Makefile: Write MINIKCONF variables as one entry per line

Having one entry per line helps reviews/refactors. As we are going to modify the MINIKCONF variables, split them now to ease further review. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --g

Re: [RFC 4/6] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

Hi Stefan, On 6/2/20 6:17 PM, Stefan Berger wrote: > On 6/2/20 12:13 PM, Auger Eric wrote: >> Hi Stefan, >> >> On 6/2/20 3:39 PM, Stefan Berger wrote: >>> On 6/1/20 6:21 AM, Eric Auger wrote: While writing tests for checking the content of TPM2 and DSDT along with TPM-TIS instantiation I

[PATCH v6 08/11] accel/Kconfig: Extract accel selectors into their own config

Move the accel selectors from the global Kconfig.host to their own Kconfig file. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 1 + Kconfig.host | 7 --- accel/Kconfig | 6 ++ 3 files changed, 7 insertions(+), 7 deletions(-) create mode 10064

[PATCH v6 10/11] Makefile: Allow target-specific optional Kconfig

Allow use of target-specific Kconfig file. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index f8a45e1379..d5009cd304 100644 --- a/Makefile +++ b/Makefile @@ -423,11 +4

Re: [PATCH RFC v2 1/5] block: add bitmap-populate job

Am 05.06.2020 um 11:24 hat Peter Krempa geschrieben: > On Fri, Jun 05, 2020 at 11:01:23 +0200, Kevin Wolf wrote: > > Am 04.06.2020 um 18:22 hat Peter Krempa geschrieben: > > > On Thu, Jun 04, 2020 at 13:31:45 +0200, Kevin Wolf wrote: > > > > Am 04.06.2020 um 11:16 hat Peter Krempa geschrieben: > >

Re: [PATCH v1 2/3] linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit

Richard Henderson writes: > On 5/27/20 3:05 AM, Alex Bennée wrote: >> @@ -2145,7 +2145,7 @@ static uintptr_t pgd_find_hole_fallback(uintptr_t >> guest_size, uintptr_t brk, lon >> >> /* Return value for guest_base, or -1 if no hole found. */ >> static uintptr_t pgb_find_hole(uintptr_t guest

[PULL 00/11] Block patches

The following changes since commit 66234fee9c2d37bfbc523aa8d0ae5300a14cc10e: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-202= 00603' into staging (2020-06-04 11:38:48 +0100) are available in the Git repository at: https://github.com/stefanha/qemu.git tags/block-pu

[PULL 02/11] io_uring: use io_uring_cq_ready() to check for ready cqes

From: Stefano Garzarella In qemu_luring_poll_cb() we are not using the cqe peeked from the CQ ring. We are using io_uring_peek_cqe() only to see if there are cqes ready, so we can replace it with io_uring_cq_ready(). Signed-off-by: Stefano Garzarella Message-id: 20200519134942.118178-1-sgarz...

[PULL 01/11] io_uring: retry io_uring_submit() if it fails with errno=EINTR

From: Stefano Garzarella As recently documented [1], io_uring_enter(2) syscall can return an error (errno=EINTR) if the operation was interrupted by a delivery of a signal before it could complete. This should happen when IORING_ENTER_GETEVENTS flag is used, for example during io_uring_submit_an

[PULL 03/11] fuzz: add datadir for oss-fuzz compatability

From: Alexander Bulekov This allows us to keep pc-bios in executable_dir/pc-bios, rather than executable_dir/../pc-bios, which is incompatible with oss-fuzz' file structure. Signed-off-by: Alexander Bulekov Reviewed-by: Darren Kenny Message-id: 20200512030133.29896-2-alx...@bu.edu Signed-off-b

[PULL 04/11] fuzz: fix typo in i440fx-qtest-reboot arguments

From: Alexander Bulekov Signed-off-by: Alexander Bulekov Reviewed-by: Darren Kenny Reviewed-by: Philippe Mathieu-Daudé Message-id: 20200512030133.29896-3-alx...@bu.edu Signed-off-by: Stefan Hajnoczi --- tests/qtest/fuzz/i440fx_fuzz.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PULL 05/11] fuzz: add mangled object name to linker script

From: Alexander Bulekov Previously, we relied on "FuzzerTracePC*(.bss*)" to place libfuzzer's fuzzer::TPC object into our contiguous shared-memory region. This does not work for some libfuzzer builds, so this addition identifies the region by its mangled name: *(.bss._ZN6fuzzer3TPCE); Signed-off

[PULL 06/11] fuzz: run the main-loop in fork-server process

From: Alexander Bulekov Without this, the time since the last main-loop keeps increasing, as the fuzzer runs. The forked children need to handle all the "past-due" timers, slowing them down, over time. With this change, the parent/fork-server process runs the main-loop, while waiting on the child

[PULL 09/11] hw/block: Let the NVMe emulated device be target-agnostic

From: Philippe Mathieu-Daudé Now than the non-target specific memory_region_msync() function is available, use it to make this device target-agnostic. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Acked-by: Paolo Bonzini Message-id: 2020050

[PULL 07/11] memory: Rename memory_region_do_writeback -> memory_region_writeback

From: Philippe Mathieu-Daudé We usually use '_do_' for internal functions. Rename memory_region_do_writeback() as memory_region_writeback(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Acked-by: Paolo Bonzini Message-id: 20200508062456.23

[PULL 08/11] memory: Extract memory_region_msync() from memory_region_writeback()

From: Philippe Mathieu-Daudé Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Acked-by: Paolo Bonzini Message-id: 20200508062456.23344-3-phi...@redhat.com Signed-off-by: Stefan Hajnoczi --- include/exec/memory.h |

[PULL 11/11] block: Factor out bdrv_run_co()

From: Vladimir Sementsov-Ogievskiy We have a few bdrv_*() functions that can either spawn a new coroutine and wait for it with BDRV_POLL_WHILE() or use a fastpath if they are alreeady running in a coroutine. All of them duplicate basically the same code. Factor the common code into a new functio

[PULL 10/11] exec: Rename qemu_ram_writeback() as qemu_ram_msync()

From: Philippe Mathieu-Daudé Rename qemu_ram_writeback() as qemu_ram_msync() to better match what it does. Suggested-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson Acked-by: Paolo Bonzini Message-id: 20200508062456.23344

Re: [PATCH RFC v2 1/5] block: add bitmap-populate job

On Fri, Jun 05, 2020 at 11:44:07 +0200, Kevin Wolf wrote: > Am 05.06.2020 um 11:24 hat Peter Krempa geschrieben: > > On Fri, Jun 05, 2020 at 11:01:23 +0200, Kevin Wolf wrote: > > > Am 04.06.2020 um 18:22 hat Peter Krempa geschrieben: > > > > On Thu, Jun 04, 2020 at 13:31:45 +0200, Kevin Wolf wrote:

Re: [PATCH v4 00/12] iotests: Dump QCOW2 dirty bitmaps metadata

04.06.2020 22:14, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200604174135.11042-1-vsement...@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200604174135.11042-1-vsement...@virtuozzo.com S

[PATCH] tests/qtest: Fix LGPL information in the file headers

It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here. Signed-off-by: Thomas Huth --- tests/qtest/e1000e-test.c| 2

Re: [PATCH RFC v2 1/5] block: add bitmap-populate job

Am 05.06.2020 um 11:58 hat Peter Krempa geschrieben: > On Fri, Jun 05, 2020 at 11:44:07 +0200, Kevin Wolf wrote: > > Am 05.06.2020 um 11:24 hat Peter Krempa geschrieben: > > > On Fri, Jun 05, 2020 at 11:01:23 +0200, Kevin Wolf wrote: > > > > Am 04.06.2020 um 18:22 hat Peter Krempa geschrieben: > >

Re: [PATCH v2] hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE

Stefan Hajnoczi writes: > On Thu, Jun 04, 2020 at 02:40:22PM +0100, Alex Bennée wrote: >> The purpose of vhost_section is to identify RAM regions that need to >> be made available to a vhost client. However when running under TCG >> all RAM sections have DIRTY_MEMORY_CODE set which leads to pro

[PATCH v3 00/11] hw/sd/sdcard: Fix CVE-2020-13253 & cleanups

Patches 2 & 3 fix CVE-2020-13253. The rest are (accumulated) cleanups. Supersedes: <20200604182502.24228-1-f4...@amsat.org> Philippe Mathieu-Daudé (11): MAINTAINERS: Cc qemu-block mailing list hw/sd/sdcard: Update coding style to make checkpatch.pl happy hw/sd/sdcard: Do not switch to Recei

[PATCH v3 04/11] hw/sd/sdcard: Restrict Class 6 commands to SCSD cards

From: Philippe Mathieu-Daudé Only SCSD cards support Class 6 (Block Oriented Write Protection) commands. "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" 4.3.14 Command Functional Difference in Card Capacity Types * Write Protected Group SDHC and SDXC do not support wr

[PATCH v3 05/11] hw/sd/sdcard: Update the SDState documentation

From: Philippe Mathieu-Daudé Add more descriptive comments to keep a clear separation between static property vs runtime changeable. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/sd/s

[PATCH v3 01/11] MAINTAINERS: Cc qemu-block mailing list

We forgot to include the qemu-block mailing list while adding this section in commit 076a0fc32a7. Fix this. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3e7d9cb0a5..20b3a68d0

[PATCH v3 02/11] hw/sd/sdcard: Update coding style to make checkpatch.pl happy

To make the next commit easier to review, clean this code first. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 3c06a0ac6d..f1b12b49db 100644 --- a/hw/sd/sd.c +++ b/h

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

* Alex Williamson (alex.william...@redhat.com) wrote: > On Wed, 3 Jun 2020 01:24:43 -0400 > Yan Zhao wrote: > > > On Tue, Jun 02, 2020 at 09:55:28PM -0600, Alex Williamson wrote: > > > On Tue, 2 Jun 2020 23:19:48 -0400 > > > Yan Zhao wrote: > > > > > > > On Tue, Jun 02, 2020 at 04:55:27PM -06

[PATCH v3 03/11] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid

From: Philippe Mathieu-Daudé Only move the state machine to ReceivingData if there is no pending error. This avoids later OOB access while processing commands queued. "SD Specifications Part 1 Physical Layer Simplified Spec. v3.01" 4.3.3 Data Read Read command is rejected if BLOCK_LEN_E

[PATCH v3 09/11] hw/sd/sdcard: Correctly display the command name in trace events

From: Philippe Mathieu-Daudé Some ACMD were incorrectly displayed. Fix by remembering if we are processing a ACMD (with current_cmd_is_acmd) and add the sd_current_cmd_name() helper, which display to correct name regardless it is a CMD or ACMD. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/s

[PATCH v3 08/11] hw/sd/sdcard: Make iolen unsigned

I/O request length can not be negative. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 2 +- hw/sd/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 9d51138b11..952be36399 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@

[PATCH v3 06/11] hw/sd/sdcard: Simplify cmd_valid_while_locked()

From: Philippe Mathieu-Daudé cmd_valid_while_locked() only needs to read SDRequest->cmd, pass it directly and make it const. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 9bfd65

Re: [PATCH v1 2/3] linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit

Alex Bennée writes: > Richard Henderson writes: > >> On 5/27/20 3:05 AM, Alex Bennée wrote: >>> @@ -2145,7 +2145,7 @@ static uintptr_t pgd_find_hole_fallback(uintptr_t >>> guest_size, uintptr_t brk, lon >>> >>> /* Return value for guest_base, or -1 if no hole found. */ >>> static uintptr_

[PATCH v3 11/11] hw/sd/sdcard: Simplify realize() a bit

From: Philippe Mathieu-Daudé We don't need to check if sd->blk is set twice. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index a1b25ed36f..060ca9d993 100644 --- a/hw/sd/sd.c +++ b/hw

[PATCH v3 07/11] hw/sd/sdcard: Constify sd_crc*()'s message argument

From: Philippe Mathieu-Daudé CRC functions don't modify the buffer argument, make it const. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 7799a3c621..

Re: [PATCH v4 01/12] qcow2.py: python style fixes

Reviewed-by: Andrey Shinkevich From: Vladimir Sementsov-Ogievskiy Sent: Thursday, June 4, 2020 8:41 PM To: qemu-bl...@nongnu.org Cc: qemu-devel@nongnu.org ; mre...@redhat.com ; kw...@redhat.com ; ebl...@redhat.com ; Denis Lunev ; Vladimir Sementsov-Ogievskiy

[PATCH v3 10/11] hw/sd/sdcard: Display offset in read/write_data() trace events

From: Philippe Mathieu-Daudé Having 'base address' and 'relative offset' displayed separately is more helpful than the absolute address. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sd.c | 8 hw/sd/trace-events | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) dif

Re: [RFC v2 18/18] guest memory protection: Alter virtio default properties for protected guests

On Thu, 21 May 2020 13:43:04 +1000 David Gibson wrote: > The default behaviour for virtio devices is not to use the platforms normal > DMA paths, but instead to use the fact that it's running in a hypervisor > to directly access guest memory. That doesn't work if the guest's memory > is protecte

Re: gdbstub.c CPU clusters not handled for ThreadInfo packets

On Tue, Jun 2, 2020 at 7:26 PM Peter Maydell wrote: > When there's multiple clusters, by default gdb will show you all the CPUs in > the first > cluster. Would the behaviour be better if the other cluster in > this machine was the first (default) one? For our use case yes it would be better. I w

[Bug 1882123] Re: ARM cpu emulation regression on QEMU 4.2.0

Could you try current head of git as well please, just in case it's a bug we've already fixed since 5.0? Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1882123 Title: ARM cpu emulation regre

  1   2   3   4   >