Re: [PATCH 1/2] tests: fix "make check-qtest" for modular builds

2020-07-12 Thread Thomas Huth
On 10/07/2020 22.36, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > tests/qtest/Makefile.include | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/Makefile.include b/tests/qtest/Makefile.include > index 98af2c2d9338..6a0276fd42dd 100644 > ---

[Bug 1887318] Re: impossible to install in OSX Yosemite 10.10.5

2020-07-12 Thread Thomas Huth
QEMU only supports the two most recent versions of macOS (see https://www.qemu.org/docs/master/system/build-platforms.html). Support for older versions has been removed (see https://git.qemu.org/?p=qemu.git;a=commitdiff;h=483644c25b93236001), so if you still want to use QEMU on such an old system,

[Bug 1840719] Re: win98se floppy fails to boot with isapc machine

2020-07-12 Thread Roman Bolshakov
The commit fixes the issue in master branch: https://git.qemu.org/?p=qemu.git;a=commit;h=de15df5ead400b7c3d0cf21c8164a7686dc81933 The fix is going to be released in 5.1 ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a

[Bug 1840719] Re: win98se floppy fails to boot with isapc machine

2020-07-12 Thread Philippe Mathieu-Daudé
** Tags removed: x86 ** Tags added: i386 testcase -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1840719 Title: win98se floppy fails to boot with isapc machine Status in QEMU: Fix Committed Bug

Re: [PATCH v3 4/4] spapr: Forbid nested KVM-HV in pre-power9 compat mode

2020-07-12 Thread David Gibson
On Fri, Jul 03, 2020 at 04:19:24PM +0200, Greg Kurz wrote: > On Mon, 15 Jun 2020 11:20:31 +0200 > Greg Kurz wrote: > > > On Sat, 13 Jun 2020 17:18:04 +1000 > > David Gibson wrote: > > > > > On Thu, Jun 11, 2020 at 03:40:33PM +0200, Greg Kurz wrote: > > > > Nested KVM-HV only works on POWER9. >

Re: [PATCH v4 05/11] target/ppc: add vmulld instruction

2020-07-12 Thread David Gibson
On Wed, Jul 01, 2020 at 06:43:40PM -0500, Lijun Pan wrote: > vmulld: Vector Multiply Low Doubleword. > > Signed-off-by: Lijun Pan Applied to ppc-for-5.2. > --- > v4: add missing changes, and split to 5/11, 6/11, 7/11 > v3: use tcg_gen_gvec_mul() > v2: fix coding style > use Power ISA 3.1

Re: [PATCH v4 06/11] Update PowerPC AT_HWCAP2 definition

2020-07-12 Thread David Gibson
On Wed, Jul 01, 2020 at 06:43:41PM -0500, Lijun Pan wrote: > Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions. > > Signed-off-by: Lijun Pan > --- > v4: add missing changes, and split to 5/11, 6/11, 7/11 > v3: use tcg_gen_gvec_mul() > v2: fix coding style > use Power ISA 3.1

Re: [PATCH v8 03/10] qcow2_format.py: change Qcow2BitmapExt initialization method

2020-07-12 Thread Andrey Shinkevich
On 11.07.2020 19:34, Vladimir Sementsov-Ogievskiy wrote: 03.07.2020 16:13, Andrey Shinkevich wrote: There are two ways to initialize a class derived from Qcow2Struct: 1. Pass a block of binary data to the constructor. 2. Pass the file descriptor to allow reading the file from constructor. Let's

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-07-12 Thread Rafael David Tinoco
Worked being done for the Bionic SRU: BUG: https://bugs.launchpad.net/qemu/+bug/1805256 (fix for the bionic regression demonstrated at LP: #1885419) PPA: https://launchpad.net/~rafaeldtinoco/+archive/ubuntu/lp1805256-bionic MERGE: https://tinyurl.com/y8sucs6x Merge proposal currently going under

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-07-12 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/qemu/+git/qemu/+merge/387269 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805256 Title: qemu-img hangs on

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-07-12 Thread Jason Wang
On 2020/7/10 下午9:30, Peter Xu wrote: On Fri, Jul 10, 2020 at 02:34:11PM +0800, Jason Wang wrote: On 2020/7/9 下午10:10, Peter Xu wrote: On Thu, Jul 09, 2020 at 01:58:33PM +0800, Jason Wang wrote: - If we care the performance, it's better to implement the MAP event for vhost, otherwise it

Re: [RFC 12/65] target/riscv: rvv-0.9: update check functions

2020-07-12 Thread Frank Chang
On Sat, Jul 11, 2020 at 1:51 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > > +#define REQUIRE_RVV do {\ > > +if (s->mstatus_vs == 0) \ > > +return false; \ > > +} while (0) > > You've used this macro already

Re: [RFC 13/65] target/riscv: rvv-0.9: configure instructions

2020-07-12 Thread Frank Chang
On Sat, Jul 11, 2020 at 2:07 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > > -static bool trans_vsetvl(DisasContext *ctx, arg_vsetvl *a) > > +static bool trans_vsetvl(DisasContext *s, arg_vsetvl *a) > > Do not mix this change

Re: [RFC 14/65] target/riscv: rvv-0.9: stride load and store instructions

2020-07-12 Thread Frank Chang
On Sat, Jul 11, 2020 at 2:15 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 7/10/20 3:48 AM, frank.ch...@sifive.com wrote: > > # *** Vector loads and stores are encoded within LOADFP/STORE-FP *** > > -vlb_v ... 100 . 0 . 000 . 111 @r2_nfvm > > -vlh_v

Re: [RFC 00/65] target/riscv: support vector extension v0.9

2020-07-12 Thread Frank Chang
On Sat, Jul 11, 2020 at 5:53 AM Alistair Francis wrote: > On Fri, Jul 10, 2020 at 5:59 AM wrote: > > > > From: Frank Chang > > > > This patchset implements the vector extension v0.9 for RISC-V on QEMU. > > > > This patchset is sent as RFC because RVV v0.9 is still in draft state. > > However,

Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u

2020-07-12 Thread Bin Meng
On Sun, Jul 12, 2020 at 1:34 AM Alistair Francis wrote: > > On Thu, Jul 9, 2020 at 10:07 PM Bin Meng wrote: > > > > From: Bin Meng > > > > Update virt and sifive_u machines to use the opensbi fw_dynamic bios > > image built for the generic FDT platform. > > > > Remove the out-of-date no longer

Re: [PATCH v2 01/17] tcg: Introduce target-specific page data for user-only

2020-07-12 Thread Richard Henderson
On 6/25/20 9:20 AM, Peter Maydell wrote: > On Fri, 5 Jun 2020 at 05:17, Richard Henderson >> @@ -787,9 +788,11 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong >> old_size, >> new_addr = -1; >> } else { >> new_addr = h2g(host_addr); >> +/* FIXME: Move page

Re: [PATCH v4 7/7] Makefile: Ship the generic platform bios images for RISC-V

2020-07-12 Thread Bin Meng
On Sun, Jul 12, 2020 at 1:28 AM Alistair Francis wrote: > > On Fri, Jul 10, 2020 at 11:36 AM Alistair Francis > wrote: > > > > On Thu, Jul 9, 2020 at 10:11 PM Bin Meng wrote: > > > > > > From: Bin Meng > > > > > > Update the install blob list to include the generic platform > > > fw_dynamic

Re: [PATCH v2 2/2] hw/riscv: sifive_u: Provide a reliable way for bootloader to detect whether it is running in QEMU

2020-07-12 Thread Bin Meng
Hi Alistair, On Sun, Jul 12, 2020 at 12:04 AM Alistair Francis wrote: > > On Thu, Jul 9, 2020 at 5:50 PM Bin Meng wrote: > > > > Hi Palmer, > > > > On Fri, Jul 10, 2020 at 8:45 AM Palmer Dabbelt > > wrote: > > > > > > On Thu, 09 Jul 2020 15:09:18 PDT (-0700), alistai...@gmail.com wrote: > > >

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-12 Thread David Gibson
On Tue, 07 Jul 2020 14:00:06 +0200 Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 07/07/20 07:33, Markus Armbruster wrote: > >> Philippe Mathieu-Daudé writes: > >> > >>> On 7/7/20 6:45 AM, Thomas Huth wrote: > On 27/05/2020 10.47, Markus Armbruster wrote: > >

Re: [PATCH v2 2/2] hw/riscv: sifive_u: Provide a reliable way for bootloader to detect whether it is running in QEMU

2020-07-12 Thread Bin Meng
Hi Alistair, On Sun, Jul 12, 2020 at 12:03 AM Alistair Francis wrote: > > On Thu, Jul 9, 2020 at 5:48 PM Bin Meng wrote: > > > > Hi Alistair, > > > > On Fri, Jul 10, 2020 at 6:19 AM Alistair Francis > > wrote: > > > > > > On Thu, Jul 9, 2020 at 3:07 AM Bin Meng wrote: > > > > > > > > From:

Re: [PATCH v3 4/4] hw/block/nvme: Align I/O BAR to 4 KiB

2020-07-12 Thread Dmitry Fomichev
On Tue, 2020-06-30 at 13:04 +0200, Philippe Mathieu-Daudé wrote: > Simplify the NVMe emulated device by aligning the I/O BAR to 4 KiB. > > Reviewed-by: Klaus Jensen > Signed-off-by: Philippe Mathieu-Daudé > --- > include/block/nvme.h | 2 ++ > hw/block/nvme.c | 5 ++--- > 2 files changed,

Re: [PATCH v3 3/4] hw/block/nvme: Fix pmrmsc register size

2020-07-12 Thread Dmitry Fomichev
On Tue, 2020-06-30 at 13:04 +0200, Philippe Mathieu-Daudé wrote: > The Persistent Memory Region Controller Memory Space Control > register is 64-bit wide. See 'Figure 68: Register Definition' > of the 'NVM Express Base Specification Revision 1.4'. > > Fixes: 6cf9413229 ("introduce PMR support

Re: [PATCH v3 2/4] hw/block/nvme: Use QEMU_PACKED on hardware/packet structures

2020-07-12 Thread Dmitry Fomichev
On Tue, 2020-06-30 at 13:04 +0200, Philippe Mathieu-Daudé wrote: > These structures either describe hardware registers, or > commands ('packets') to send to the hardware. To forbid > the compiler to optimize and change fields alignment, > mark the structures as packed. > > Reviewed-by: Klaus

[Bug 1887318] Re: impossible to install in OSX Yosemite 10.10.5

2020-07-12 Thread JuanPabloCuervo
https://github.com/Homebrew/brew/issues/7667 https://security.stackexchange.com/questions/232445/https-connection-to- specific-sites-fail-with-curl-on-macos This is a Cat & Mouse game... Catch 22... its Not a Brew problemm is Not a glib problem, is not a git problem, so we dont care... its an

[Bug 1887318] Re: impossible to install in OSX Yosemite 10.10.5

2020-07-12 Thread JuanPabloCuervo
console log i installed Xcode 6.3 as recommended by MacPorts "better than 6.1" for Yosemite ** Attachment added: "console.txt" https://bugs.launchpad.net/qemu/+bug/1887318/+attachment/5392137/+files/console.txt -- You received this bug notification because you are a member of qemu-

[PATCH] target/openrisc: Remove superfluous breaks

2020-07-12 Thread Yi Wang
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang --- target/openrisc/sys_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c index d9fe6c5..d9691d0 100644 ---

[PATCH] hw: Remove superfluous breaks

2020-07-12 Thread Yi Wang
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang --- hw/block/pflash_cfi01.c | 1 - hw/display/cirrus_vga.c | 1 - hw/display/qxl-logger.c | 2 -- hw/gpio/max7310.c | 3 --- hw/i386/intel_iommu.c |

[Bug 1887318] [NEW] impossible to install in OSX Yosemite 10.10.5

2020-07-12 Thread JuanPabloCuervo
Public bug reported: the Brew method has glib problems, glib is impossible to install. the MacPorts method has a very long .log file. ** Affects: qemu Importance: Undecided Status: New ** Attachment added: "main.log"

[PATCH] target/ppc: Remove superfluous breaks

2020-07-12 Thread Yi Wang
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang --- target/ppc/misc_helper.c | 5 - 1 file changed, 5 deletions(-) diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c index 55b68d1..e43a3b4 100644 ---

[PATCH] target/sh4: Remove superfluous breaks

2020-07-12 Thread Yi Wang
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang --- target/sh4/translate.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 6192d83..60c863d 100644 ---

[PATCH] scsi: Remove superfluous breaks

2020-07-12 Thread Yi Wang
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang --- scsi/utils.c | 4 1 file changed, 4 deletions(-) diff --git a/scsi/utils.c b/scsi/utils.c index c50e81f..b37c283 100644 --- a/scsi/utils.c +++ b/scsi/utils.c @@ -32,17

[PATCH] block/vmdk: Remove superfluous breaks

2020-07-12 Thread Yi Wang
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang --- block/vmdk.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 28cec50..8f222e3 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1053,14

[PATCH] target/arm/kvm: Remove superfluous break

2020-07-12 Thread Yi Wang
From: Liao Pingfang Remove superfluous break. Signed-off-by: Liao Pingfang --- target/arm/kvm64.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 1169237..ef1e960 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c @@ -330,7 +330,6 @@ int

[PATCH] migration/migration.c: Remove superfluous breaks

2020-07-12 Thread Yi Wang
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang --- migration/migration.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 92e44e0..2fd5fbb 100644 ---

[PATCH] target/cris: Remove superfluous breaks

2020-07-12 Thread Yi Wang
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang --- target/cris/translate.c | 7 +++ target/cris/translate_v10.inc.c | 2 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/target/cris/translate.c

[PATCH] vnc: Remove the superfluous break

2020-07-12 Thread Yi Wang
From: Liao Pingfang Remove the superfluous break, as there is a "return" before. Signed-off-by: Liao Pingfang --- ui/vnc-enc-tight.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index 1e08518..cebd358 100644 --- a/ui/vnc-enc-tight.c +++

[PATCH] virtfs-proxy-helper: Remove the superfluous break

2020-07-12 Thread Yi Wang
From: Liao Pingfang Remove the superfluous break, as there is a "return" before it. Signed-off-by: Liao Pingfang --- fsdev/virtfs-proxy-helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index de061a8..e68acc1 100644 ---

[PATCH] tcg/riscv: Remove superfluous breaks

2020-07-12 Thread Yi Wang
From: Liao Pingfang Remove superfluous breaks, as there is a "return" before them. Signed-off-by: Liao Pingfang --- tcg/riscv/tcg-target.inc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c index 2bc0ba7..3c11ab8 100644 ---

[RFC PATCH 6/8] fpu/softfloat: define operation for bfloat16

2020-07-12 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- fpu/softfloat.c | 146 +++- include/fpu/softfloat.h | 44 2 files changed, 189 insertions(+), 1 deletion(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 54fc889446..9a58107be3 100644 ---

[RFC PATCH 3/8] fpu/softfloat: add FloatFmt for bfloat16

2020-07-12 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- fpu/softfloat.c | 4 1 file changed, 4 insertions(+) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 79be4f5840..1ef07d9160 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -554,6 +554,10 @@ static const FloatFmt float16_params_ahp = {

[RFC PATCH 2/8] fpu/softfloat: use the similiar logic to recognize sNaN and qNaN

2020-07-12 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- fpu/softfloat-specialize.inc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fpu/softfloat-specialize.inc.c b/fpu/softfloat-specialize.inc.c index 034d18199c..6b778a7830 100644 --- a/fpu/softfloat-specialize.inc.c +++

[RFC PATCH 0/8] Implement blfoat16 in softfloat

2020-07-12 Thread LIU Zhiwei
As bfloat16 is more and more popular in many archs, implement bfloat16 interfaces in softfloat, so that archs can add their bfloat16 insns based on the blfoat16 interfaces here. This patch set is more copy of float16 than really define new interfaces or implementations. Any thoughts are

[RFC PATCH 5/8] fpu/softfloat: define brain floating-point types

2020-07-12 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- include/fpu/softfloat-types.h | 8 1 file changed, 8 insertions(+) diff --git a/include/fpu/softfloat-types.h b/include/fpu/softfloat-types.h index 7680193ebc..8f8fdfeecf 100644 --- a/include/fpu/softfloat-types.h +++ b/include/fpu/softfloat-types.h @@

[RFC PATCH 7/8] fpu/softfloat: define covert operation for bfloat16

2020-07-12 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- fpu/softfloat.c | 223 include/fpu/softfloat.h | 48 + 2 files changed, 271 insertions(+) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 9a58107be3..b6002d6856 100644 --- a/fpu/softfloat.c +++

[RFC PATCH 1/8] fpu/softfloat: fix up float16 nan recognition

2020-07-12 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- fpu/softfloat-specialize.inc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fpu/softfloat-specialize.inc.c b/fpu/softfloat-specialize.inc.c index 44f5b661f8..034d18199c 100644 --- a/fpu/softfloat-specialize.inc.c +++

[RFC PATCH 4/8] fpu/softfloat: add pack and unpack interfaces for bfloat16

2020-07-12 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- fpu/softfloat.c | 20 1 file changed, 20 insertions(+) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 1ef07d9160..54fc889446 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -584,6 +584,11 @@ static inline FloatParts

[RFC PATCH 8/8] fpu/softfloat: define misc operation for bfloat16

2020-07-12 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- fpu/softfloat-specialize.inc.c | 38 +++ include/fpu/softfloat.h| 41 ++ 2 files changed, 79 insertions(+) diff --git a/fpu/softfloat-specialize.inc.c b/fpu/softfloat-specialize.inc.c index

Re: [PATCH for-5.1 0/3] Move and improve qdev API doc comments

2020-07-12 Thread Richard Henderson
On 7/11/20 7:24 AM, Peter Maydell wrote: > Peter Maydell (3): > qdev: Move doc comments from qdev.c to qdev-core.h > qdev: Document qdev_unrealize() > qdev: Document GPIO related functions Reviewed-by: Richard Henderson r~

Re: [Bug 1887309] [NEW] Floating-point exception in ide_set_sector

2020-07-12 Thread Alexander Bulekov
On 200712 2025, Alexander Bulekov wrote: > Public bug reported: > > Hello, > Here is a reproducer: > cat << EOF | ./i386-softmmu/qemu-system-i386 -M pc,accel=qtest\ > -qtest null -nographic -vga qxl -qtest stdio -nodefaults\ > -drive

[Bug 1887309] [NEW] Floating-point exception in ide_set_sector

2020-07-12 Thread Alexander Bulekov
Public bug reported: Hello, Here is a reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 -M pc,accel=qtest\ -qtest null -nographic -vga qxl -qtest stdio -nodefaults\ -drive if=none,id=drive0,file=null-co://,file.read-zeroes=on,format=raw\ -drive

[Bug 1887306] [NEW] qemu-user deadlocks when forked in a multithreaded process

2020-07-12 Thread Alexey Izbyshev
Public bug reported: The following program (also attached) deadlocks when run under QEMU user on Linux. #include #include #include #include #include #include #define NUM_THREADS 100 #define NUM_FORKS 10 pthread_barrier_t barrier; void *t(void *arg) { for (int i = 0; i < NUM_FORKS;

[Bug 1887303] [NEW] Assertion failure in *bmdma_active_if `bmdma->bus->retry_unit != (uint8_t)-1' failed.

2020-07-12 Thread Alexander Bulekov
Public bug reported: Hello, Here is a QTest Reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 -M pc,accel=qtest\ -qtest null -nographic -vga qxl -qtest stdio -nodefaults\ -drive if=none,id=drive0,file=null-co://,file.read-zeroes=on,format=raw\ -drive

Re: [PATCH] tests: improve performance of device-introspect-test

2020-07-12 Thread Thomas Huth
On 10/07/2020 22.03, Markus Armbruster wrote: [...] > With -m slow, we test 2 * #machines * #devices introspections, > i.e. from 132 (tricore) to over 10k (ppc 13046, ppc64 23426, arm > 82708, aarch64 89760). Median is ~1600, sum is ~260k. > > Except we actually test just 89k now,

Re: [PATCH 1/2] tests/acceptance/boot_linux: Truncate SD card image to power of 2

2020-07-12 Thread Niek Linnenbank
On Tue, Jul 7, 2020 at 3:21 PM Philippe Mathieu-Daudé wrote: > In the next commit we won't allow SD card images with invalid > size (not aligned to a power of 2). Prepare the tests: add the > pow2ceil() and image_pow2ceil_truncate() methods and truncate > the images of the tests using SD cards.

[PATCH] docs/system/arm/orangepi: add instructions for resizing SD image to power of two

2020-07-12 Thread Niek Linnenbank
SD cards need to have a size of a power of two. This commit updates the Orange Pi machine documentation to include instructions for resizing downloaded images using the qemu-img command. Signed-off-by: Niek Linnenbank --- docs/system/arm/orangepi.rst | 16 +--- 1 file changed, 13

RE: Seeing a problem in multi cpu runs where memory mapped pcie device register reads are returning incorrect values

2020-07-12 Thread Mark Wood-Patrick
From: Mark Wood-Patrick Sent: Wednesday, July 1, 2020 11:26 AM To: qemu-devel@nongnu.org Cc: Mark Wood-Patrick Subject: Seeing a problem in multi cpu runs where memory mapped pcie device register reads are returning incorrect values Background I have a test environment which runs QEMU 4.2

[PATCH v4 1/3] scripts/simplebench: compare write request performance

2020-07-12 Thread Andrey Shinkevich
The script 'bench_write_req.py' allows comparing performances of write request for two qemu-img binary files. An example with (qemu-img binary 1) and without (qemu-img binary 2) the applied patch "qcow2: skip writing zero buffers to empty COW areas" (git commit ID: c8bb23cbdbe32f5) has the

[PATCH v4 2/3] scripts/simplebench: allow writing to non-empty image

2020-07-12 Thread Andrey Shinkevich
Add 'empty_image' parameter to the function bench_write_req() and to the test cases that will allow writing to the non-empty clusters of the image if the 'empty_image' parameter set to False. Signed-off-by: Andrey Shinkevich --- scripts/simplebench/bench_write_req.py | 27

[PATCH v4 0/3] scripts/simplebench: add bench_write_req.py test

2020-07-12 Thread Andrey Shinkevich
The script 'bench_write_req.py' allows comparing performances of write request for two qemu-img binary files. If you made a change in QEMU code and want to check the write requests performance, you will want to build two qemu-img binary files with and without your change. Then you specify paths

[PATCH v4 3/3] scripts/simplebench: add unaligned data case to bench_write_req

2020-07-12 Thread Andrey Shinkevich
Add a test case with writhing data unaligned to the image clusters. This case does not involve the COW optimization introduced with the patch "qcow2: skip writing zero buffers to empty COW areas" (git commit ID: c8bb23cbdbe32f5). Signed-off-by: Andrey Shinkevich ---

[PATCH v3 1/3] scripts/simplebench: compare write request performance

2020-07-12 Thread Andrey Shinkevich
The script 'bench_write_req.py' allows comparing performances of write request for two qemu-img binary files. An example with (qemu-img binary 1) and without (qemu-img binary 2) the applied patch "qcow2: skip writing zero buffers to empty COW areas" (git commit ID: c8bb23cbdbe32f5) has the

[PATCH v3 2/3] scripts/simplebench: allow writing to non-empty image

2020-07-12 Thread Andrey Shinkevich
Add 'empty_image' parameter to the function bench_write_req() and to the test cases that will allow writing to the non-empty clusters of the image if the 'empty_image' parameter set to False. Signed-off-by: Andrey Shinkevich --- scripts/simplebench/bench_write_req.py | 27

[PATCH v3 0/3] scripts/simplebench: add bench_write_req.py test

2020-07-12 Thread Andrey Shinkevich
The script 'bench_write_req.py' allows comparing performances of write request for two qemu-img binary files. If you made a change in QEMU code and want to check the write requests performance, you will want to build two qemu-img binary files with and without your change. Then you specify paths

[PATCH v3 3/3] scripts/simplebench: add unaligned data case to bench_write_req

2020-07-12 Thread Andrey Shinkevich
Add a test case with writhing data unaligned to the image clusters. This case does not involve the COW optimization introduced with the patch "qcow2: skip writing zero buffers to empty COW areas" (git commit ID: c8bb23cbdbe32f5). Signed-off-by: Andrey Shinkevich ---

Re: [PATCH v2] scripts/simplebench: compare write request performance

2020-07-12 Thread Andrey Shinkevich
On 11.07.2020 16:05, Vladimir Sementsov-Ogievskiy wrote: 26.06.2020 17:31, Andrey Shinkevich wrote: The script 'bench_write_req.py' allows comparing performances of write request for two qemu-img binary files. An example with (qemu-img binary 1) and without (qemu-img binary 2) the applied patch

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-12 Thread Paolo Bonzini
On 12/07/20 12:00, Claudio Fontana wrote: > Note: only the === -blockdev with a backing file === part of test 267 fails. > -blockdev with NBD is ok, like all the rest. > > > Interesting facts about s390 in particular: its save/load code includes the > transfer of "storage keys", > which

QEMU | Pipeline #165708498 has failed for master | d3449830

2020-07-12 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: d3449830 ( https://gitlab.com/qemu-project/qemu/-/commit/d34498309cff7560ac90c422c56e3137e6a64b19 ) Commit Message: Merge

RE: [PATCH v2 1/4] target/nios2: add DISAS_NORETURN case for nothing more to generate

2020-07-12 Thread Wu, Wentong
> -Original Message- > From: Peter Maydell > Sent: Sunday, July 12, 2020 2:50 AM > To: Wu, Wentong > Cc: QEMU Developers ; QEMU Trivial > ; Chris Wulff ; Marek Vasut > > Subject: Re: [PATCH v2 1/4] target/nios2: add DISAS_NORETURN case for nothing > more to generate > > On Fri, 10

Re: [PULL v3 00/32] AVR port

2020-07-12 Thread Peter Maydell
On Sat, 11 Jul 2020 at 10:07, Philippe Mathieu-Daudé wrote: > > Since v2: > > Removed incorrect cpu_to_le32() call. > > Since v1: > > Fixed issue on big-endian host reported by Peter Maydell. > > Possible false-positives from checkpatch: > > WARNING: added, moved or deleted file(s), does

[PATCH] Allow acpi-tmr size=2

2020-07-12 Thread Simon John
macos guests no longer boot after commit 5d971f9e672507210e77d020d89e0e89165c8fc9 acpi-tmr needs 2 byte memory accesses, so breaks as that commit only allows 4 bytes. Fixes: 5d971f9e672507210e7 (memory: Revert "memory: accept mismatching sizes in memory_region_access_valid") Buglink:

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-07-12 Thread Rafael David Tinoco
Started working on this again... ** Changed in: qemu (Ubuntu Bionic) Status: Triaged => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805256 Title: qemu-img hangs on

[Bug 1809665] Re: Xbox One controller USB passthrough disconnections and stops

2020-07-12 Thread Ticketsolve
> This happened to me as well, but I managed to find a solution, if I ban the xpad driver through modprobe.d, then the problem disappear. Thanks, that's very interesting (and useful, although nowadays I use the BT connection). -- You received this bug notification because you are a member of

[Bug 1809665] Re: Xbox One controller USB passthrough disconnections and stops

2020-07-12 Thread Kasper Grubbe
This happened to me as well, but I managed to find a solution, if I ban the xpad driver through modprobe.d, then the problem disappear. I added the following line: blacklist xpad To this file: /etc/modprobe.d/vfio.conf, rebooted, and then I could use my Xbox One S controller with Qemu, I am

[Bug 1886318] Re: Qemu after v5.0.0 breaks macos guests

2020-07-12 Thread Michael Tokarev
I think we should add debugging patch by Mark to qemu too, — I suspect there will be more cases like this, since this check were turned off for a few years. Maybe not as printf's but as logging, I dunno, but the info it collects is really a must-have. -- You received this bug notification

[Bug 1886318] Re: Qemu after v5.0.0 breaks macos guests

2020-07-12 Thread Simon John
urgh, that was complicated, think i got it right! need to look for "[PATCH] Allow acpi-tmr size=2" to show up in qemu- devel -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886318 Title: Qemu

Re: [PATCH] block/amend: Check whether the node exists

2020-07-12 Thread Maxim Levitsky
On Fri, 2020-07-10 at 11:50 +0200, Max Reitz wrote: > We should check whether the user-specified node-name actually refers to > a node. The simplest way to do that is to use bdrv_lookup_bs() instead > of bdrv_find_node() (the former wraps the latter, and produces an error > message if necessary).

[RFC v8 24/25] intel_iommu: process PASID-based Device-TLB invalidation

2020-07-12 Thread Liu Yi L
This patch adds an empty handling for PASID-based Device-TLB invalidation. For now it is enough as it is not necessary to propagate it to host for passthru device and also there is no emulated device has device tlb. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Yi Sun Cc: Paolo Bonzini Cc:

[RFC v8 25/25] intel_iommu: modify x-scalable-mode to be string option

2020-07-12 Thread Liu Yi L
Intel VT-d 3.0 introduces scalable mode, and it has a bunch of capabilities related to scalable mode translation, thus there are multiple combinations. While this vIOMMU implementation wants simplify it for user by providing typical combinations. User could config it by "x-scalable-mode" option.

[RFC v8 22/25] intel_iommu: process PASID-based iotlb invalidation

2020-07-12 Thread Liu Yi L
This patch adds the basic PASID-based iotlb (piotlb) invalidation support. piotlb is used during walking Intel VT-d 1st level page table. This patch only adds the basic processing. Detailed handling will be added in next patch. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Yi Sun Cc: Paolo

[RFC v8 23/25] intel_iommu: propagate PASID-based iotlb invalidation to host

2020-07-12 Thread Liu Yi L
This patch propagates PASID-based iotlb invalidation to host. Intel VT-d 3.0 supports nested translation in PASID granular. Guest SVA support could be implemented by configuring nested translation on specific PASID. This is also known as dual stage DMA translation. Under such configuration,

[RFC v8 20/25] intel_iommu: do not pass down pasid bind for PASID #0

2020-07-12 Thread Liu Yi L
RID_PASID field was introduced in VT-d 3.0 spec, it is used for DMA requests w/o PASID in scalable mode VT-d. It is also known as IOVA. And in VT-d 3.1 spec, there is definition on it: "Implementations not supporting RID_PASID capability (ECAP_REG.RPS is 0b), use a PASID value of 0 to perform

[RFC v8 21/25] vfio: add support for flush iommu stage-1 cache

2020-07-12 Thread Liu Yi L
This patch adds flush_stage1_cache() definition in HostIOMUContextClass. And adds corresponding implementation in VFIO. This is to expose a way for vIOMMU to flush stage-1 cache in host side since guest owns stage-1 translation structures in dual stage DMA translation configuration. Cc: Kevin

[RFC v8 18/25] intel_iommu: bind/unbind guest page table to host

2020-07-12 Thread Liu Yi L
This patch captures the guest PASID table entry modifications and propagates the changes to host to setup dual stage DMA translation. The guest page table is configured as 1st level page table (GVA->GPA) whose translation result would further go through host VT-d 2nd level page table(GPA->HPA)

[RFC v8 19/25] intel_iommu: replay pasid binds after context cache invalidation

2020-07-12 Thread Liu Yi L
This patch replays guest pasid bindings after context cache invalidation. This is a behavior to ensure safety. Actually, programmer should issue pasid cache invalidation with proper granularity after issuing a context cache invalidation. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Yi Sun

[RFC v8 17/25] intel_iommu: sync IOMMU nesting cap info for assigned devices

2020-07-12 Thread Liu Yi L
For assigned devices, Intel vIOMMU which wants to build DMA protection based on physical IOMMU nesting paging should check the IOMMU nesting support in host side. The host will return IOMMU nesting cap info to user-space (e.g. VFIO returns IOMMU nesting cap info for nesting type IOMMU). vIOMMU

[RFC v8 13/25] intel_iommu: add virtual command capability support

2020-07-12 Thread Liu Yi L
This patch adds virtual command support to Intel vIOMMU per Intel VT-d 3.1 spec. And adds two virtual commands: allocate pasid and free pasid. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Yi Sun Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Reviewed-by: Peter Xu

[RFC v8 16/25] vfio: add bind stage-1 page table support

2020-07-12 Thread Liu Yi L
This patch adds bind_stage1_pgtbl() definition in HostIOMMUContextClass, also adds corresponding implementation in VFIO. This is to expose a way for vIOMMU to setup dual stage DMA translation for passthru devices on hardware. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Eric Auger Cc: Yi Sun

[RFC v8 11/25] vfio/common: provide PASID alloc/free hooks

2020-07-12 Thread Liu Yi L
This patch defines vfio_host_iommu_context_info, implements the PASID alloc/free hooks defined in HostIOMMUContextClass. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Eric Auger Cc: Yi Sun Cc: David Gibson Cc: Alex Williamson Signed-off-by: Liu Yi L --- hw/vfio/common.c

[RFC v8 09/25] hw/pci: introduce pci_device_set/unset_iommu_context()

2020-07-12 Thread Liu Yi L
For nesting IOMMU translation capable platforms, vIOMMUs running on such system could be implemented upon physical IOMMU nested paging (VFIO case). vIOMMU advertises such implementation by "want_nested" attribute to PCIe devices (e.g. VFIO PCI). Once "want_nested" is satisfied, device (VFIO case)

[RFC v8 15/25] intel_iommu: add PASID cache management infrastructure

2020-07-12 Thread Liu Yi L
This patch adds a PASID cache management infrastructure based on new added structure VTDPASIDAddressSpace, which is used to track the PASID usage and future PASID tagged DMA address translation support in vIOMMU. struct VTDPASIDAddressSpace { VTDBus *vtd_bus; uint8_t devfn;

[RFC v8 08/25] hw/iommu: introduce HostIOMMUContext

2020-07-12 Thread Liu Yi L
Currently, many platform vendors provide the capability of dual stage DMA address translation in hardware. For example, nested translation on Intel VT-d scalable mode, nested stage translation on ARM SMMUv3, and etc. In dual stage DMA address translation, there are two stages address translation,

[RFC v8 12/25] vfio: init HostIOMMUContext per-container

2020-07-12 Thread Liu Yi L
In this patch, QEMU firstly gets iommu info from kernel to check the supported capabilities by a VFIO_IOMMU_TYPE1_NESTING iommu. And inits HostIOMMUContet instance. For vfio-pci devices, it could use pci_device_set/unset_iommu() to expose host iommu context to vIOMMU emulators. vIOMMU emulators

[RFC v8 14/25] intel_iommu: process PASID cache invalidation

2020-07-12 Thread Liu Yi L
This patch adds PASID cache invalidation handling. When guest enabled PASID usages (e.g. SVA), guest software should issue a proper PASID cache invalidation when caching-mode is exposed. This patch only adds the draft handling of pasid cache invalidation. Detailed handling will be added in

[RFC v8 07/25] vfio: check VFIO_TYPE1_NESTING_IOMMU support

2020-07-12 Thread Liu Yi L
VFIO needs to check VFIO_TYPE1_NESTING_IOMMU support with Kernel before further using it. e.g. requires to check IOMMU UAPI support. Referred patch from Eric Auger: https://patchwork.kernel.org/patch/11040499/ Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Eric Auger Cc: Yi Sun Cc: David

[RFC v8 10/25] intel_iommu: add set/unset_iommu_context callback

2020-07-12 Thread Liu Yi L
This patch adds set/unset_iommu_context() impelementation in Intel vIOMMU. PCIe devices (VFIO case) sets HostIOMMUContext to vIOMMU as an ack of vIOMMU's "want_nested" attribute. Thus vIOMMU could build DMA protection based on nested paging of host IOMMU. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter

[RFC v8 05/25] intel_iommu: add get_iommu_attr() callback

2020-07-12 Thread Liu Yi L
Return vIOMMU attribute to caller. e.g. VFIO call via PCI layer. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Yi Sun Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Liu Yi L --- hw/i386/intel_iommu.c | 23 +++ 1 file changed, 23

[RFC v8 06/25] vfio: pass nesting requirement into vfio_get_group()

2020-07-12 Thread Liu Yi L
This patch passes the nesting requirement into vfio_get_group() to indicate whether VFIO_TYPE1_NESTING_IOMMU is required. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Eric Auger Cc: Yi Sun Cc: David Gibson Cc: Alex Williamson Signed-off-by: Liu Yi L --- hw/vfio/ap.c | 2

[RFC v8 04/25] hw/pci: introduce pci_device_get_iommu_attr()

2020-07-12 Thread Liu Yi L
This patch adds pci_device_get_iommu_attr() to get vIOMMU attributes. e.g. if nesting IOMMU wanted. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Eric Auger Cc: Yi Sun Cc: David Gibson Cc: Michael S. Tsirkin Signed-off-by: Liu Yi L --- hw/pci/pci.c | 35

[RFC v8 03/25] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2020-07-12 Thread Liu Yi L
This patch modifies pci_setup_iommu() to set PCIIOMMUOps instead of setting PCIIOMMUFunc. PCIIOMMUFunc is used to get an address space for a PCI device in vendor specific way. The PCIIOMMUOps still offers this functionality. But using PCIIOMMUOps leaves space to add more iommu related vendor

  1   2   >