Re: [PATCH 3/4] crypto: use QOM macros for declaration/definition of secret types

2020-08-07 Thread Eduardo Habkost
On Fri, Aug 07, 2020 at 12:11:48PM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 06, 2020 at 02:01:54PM -0400, Eduardo Habkost wrote: > > On Fri, Jul 24, 2020 at 10:12:45AM +0100, Daniel P. Berrangé wrote: > > > On Thu, Jul 23, 2020 at 02:50:06PM -0400, Eduardo Habkost wrote: > > > > On

Re: [PATCH] ui/gtk: Fix regression in gd_refresh_rate_milihz

2020-08-07 Thread Nikola Pavlica
Apologies, false alarm. I found out that my testing methodology was flawed. Close this. On Sat, Aug 8, 2020 at 00:25, Nikola Pavlica wrote: From: Nikola Pavlica > In January (I think), I suggested a fix for the constant refresh rate issue in QEMU despite

[Bug 1883984] Re: QEMU S/390x sqxbr (128-bit IEEE 754 square root) crashes qemu-system-s390x

2020-08-07 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:5.0-5ubuntu4 --- qemu (1:5.0-5ubuntu4) groovy; urgency=medium * xen: provide compat links to what libxen-dev reports where to find the binaries (LP: #1890005) * d/p/ubuntu/lp-1883984-target-s390x-Fix-SQXBR.patch: avoid crash on

Re: [PATCH] ide: Get rid of IDEDrive struct

2020-08-07 Thread John Snow
On 8/5/20 4:41 PM, Peter Maydell wrote: On Wed, 5 Aug 2020 at 20:49, Eduardo Habkost wrote: The struct had a single field (IDEDevice dev), and is only used in the QOM type declarations and property lists. We can simply use the IDEDevice struct directly instead. Signed-off-by: Eduardo

[Bug 1888601] Re: QEMU v5.1.0-rc0/rc1 hang with nested virtualization

2020-08-07 Thread Simon Kaegi
Not currently, but let me try and setup just a simple qemu test -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888601 Title: QEMU v5.1.0-rc0/rc1 hang with nested virtualization Status in QEMU:

[PATCH] ui/gtk: Fix regression in gd_refresh_rate_milihz

2020-08-07 Thread Nikola Pavlica
From: Nikola Pavlica > In January (I think), I suggested a fix for the constant refresh rate issue in QEMU despite VMs being able to render graphics at a framerate much higher than that. Here's the link to the patch in question:

Re: [PATCH v1 01/21] accel/tcg: Change interrupt/exception handling to remove implied BQL

2020-08-07 Thread Robert Foley
We found cases where a few of the *_cpu_exec_interrupt per arch functions call CPU class's cc->do_interrupt function pointer (for example arm_cpu_exec_interrupt does this). This is an issue because *_cpu_exec_interrupt will hold the BQL across the call to cc->do_interrupt, and *_do_interrupt will

[Bug 1323758] Re: Mouse stops working when connected usb-storage-device

2020-08-07 Thread Ruben Portier
It's been a very very long time since I've last ran a Windows virtual machine on Ubuntu, so I can't really tell. I do remember I never got it "fixed", but did find a fix for it by disabling the Windows power plan option "Allow Windows to put this device to sleep". Over the years I did get some

Re: [PATCH V1 30/32] vfio-pci: save and restore

2020-08-07 Thread Steven Sistare
On 8/6/2020 6:22 AM, Jason Zeng wrote: > Hi Steve, > > On Thu, Jul 30, 2020 at 08:14:34AM -0700, Steve Sistare wrote: >> @@ -3182,6 +3207,51 @@ static Property vfio_pci_dev_properties[] = { >> DEFINE_PROP_END_OF_LIST(), >> }; >> >> +static int vfio_pci_post_load(void *opaque, int

Re: [Bug 1415181] Re: Access raw partitions from Windows

2020-08-07 Thread Sebastián Lacuesta
Well, it's not an issue for me, but is a nice to have feature. I don't use the tablet in question anymore. The tablet had an uefi that didn't allow pendrive boot, but if it could be done what I proposed with qemu, a linux distro could be booted with qemu and this installed manually in a partition.

Re: [PATCH v2 5/7] target/riscv: Check nanboxed inputs in trans_rvf.inc.c

2020-08-07 Thread Chih-Min Chao
On Fri, Jul 24, 2020 at 8:28 AM Richard Henderson < richard.hender...@linaro.org> wrote: > If a 32-bit input is not properly nanboxed, then the input is replaced > with the default qnan. The only inline expansion is for the sign-changing > set of instructions: FSGNJ.S, FSGNJX.S, FSGNJN.S. > >

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-08-07 Thread dann frazier
Verified w/ over 500 successful iterations on a m6g.metal instance, and over 300 in an armhf chroot on the same. ** Tags removed: verification-needed verification-needed-bionic ** Tags added: verification-done verification-done-bionic -- You received this bug notification because you are a

[Bug 1500265] Re: nested 9p filesystem with security_model=mapped-xattr

2020-08-07 Thread Christian Schoenebeck
The status of this issue is unchanged in QEMU, i.e. user.virtfs.* is still filtered out. If someone wants to see this changed, please use the common way for sending the patch via ML: https://wiki.qemu.org/Contribute/SubmitAPatch -- You received this bug notification because you are a member of

Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-07 Thread Igor Mammedov
On Fri, 07 Aug 2020 11:32:51 -0500 Babu Moger wrote: > Adding a new check to warn the users to configure 'dies' when s/warn .../error out .../ > topology is numa configured. It makes it easy to build the > topology for EPYC models. probably it should mention that will break configs that do not

Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-07 Thread Igor Mammedov
On Fri, 7 Aug 2020 17:52:22 +0100 Daniel P. Berrangé wrote: > On Fri, Aug 07, 2020 at 11:32:51AM -0500, Babu Moger wrote: > > Adding a new check to warn the users to configure 'dies' when > > topology is numa configured. It makes it easy to build the > > topology for EPYC models. > > This

[Bug 1503031] Re: 32-to-64-bit call gate unsupported in IA32e mode

2020-08-07 Thread Peter Maydell
Looking at the commit log it looks like Andrew fixed this in commit 0aca060526d3ff9632aaed in 2018 ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1503031 Title: 32-to-64-bit call gate unsupported

[Bug 1888601] Re: QEMU v5.1.0-rc0/rc1 hang with nested virtualization

2020-08-07 Thread Dr. David Alan Gilbert
If even with that fix it's failing =and giving a similar back trace, then: Thread 4 (LWP 23729): #0 0x7f9ae5fed337 in __strcmp_sse2 () #1 0x7f9ae5d9a8ad in g_str_equal () at pthread_create.c:679 #2 0x7f9ae5d99a9d in g_hash_table_lookup () at pthread_create.c:679 #3 0x7f9ae5ac728f

[Bug 1503031] Re: 32-to-64-bit call gate unsupported in IA32e mode

2020-08-07 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1500265] Re: nested 9p filesystem with security_model=mapped-xattr

2020-08-07 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1505041] Re: Live snapshot revert times increases linearly with snapshot age

2020-08-07 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1478376] Re: PL050 KMIDATA register does not reset

2020-08-07 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1479717] Re: Auto resize VM doesn't work with windows 10 guest

2020-08-07 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1428352] Re: SYSRET instruction incorrectly implemented

2020-08-07 Thread Thomas Huth
If I've got that right, this has been fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ac57622985220de0 ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1462949] Re: vmdk files cause qemu-img to consume lots of time and memory

2020-08-07 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [PATCH v3 1/3] i386: Simplify CPUID_8000_001E for AMD

2020-08-07 Thread Igor Mammedov
On Fri, 07 Aug 2020 11:32:45 -0500 Babu Moger wrote: > apic_id contains all the information required to build CPUID_8000_001E. > Also remove the restriction on number bits on core_id and node_id. > Remove all the hardcoded values and replace with generalized > fields. > > Refer the Processor

[Bug 1423528] Re: setting unsupported timeout for i6300esb watchdog causes hw reset

2020-08-07 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1407808] Re: virtual console gives strange response to ANSI DSR

2020-08-07 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1415181] Re: Access raw partitions from Windows

2020-08-07 Thread Thomas Huth
Looking through old bug tickets... is this still an issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v2 5/5] virtiofsd: Skip setup_capabilities() in sandbox=NONE mode

2020-08-07 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > setup_capabilites() tries to give some of the required capabilities > to act as a full fledged file server in priviliged mode. In unpriviliged > mode we can't get those capabilities and setup_capabilities() will fail. > > So don't setup capabilities when

Re: [PATCH v2 3/5] virtiofsd: open /proc/self/fd/ in sandbox=NONE mode

2020-08-07 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > We need /proc/self/fd descriptor even in sandbox=NONE mode. > > Signed-off-by: Vivek Goyal > --- > tools/virtiofsd/passthrough_ll.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/tools/virtiofsd/passthrough_ll.c

Re: [PATCH v2 8/8] linux-user: Add support for btrfs ioctls used to scrub a filesystem

2020-08-07 Thread Laurent Vivier
Le 03/08/2020 à 11:46, Filip Bozuta a écrit : > This patch implements functionality for following ioctls: > > BTRFS_IOC_SCRUB - Starting a btrfs filesystem scrub > > Start a btrfs filesystem scrub. The third ioctls argument > is a pointer to a following type: > > struct

Re: [PATCH v2 7/8] linux-user: Add support for btrfs ioctls used to manage quota

2020-08-07 Thread Laurent Vivier
Le 03/08/2020 à 11:46, Filip Bozuta a écrit : > This patch implements functionality for following ioctls: > > BTRFS_IOC_QUOTA_CTL - Enabling/Disabling quota support > > Enable or disable quota support for a btrfs filesystem. Quota > support is enabled or disabled using the ioctls third

Re: [PATCH v2 4/8] linux-user: Add support for btrfs ioctls used to get/set features

2020-08-07 Thread Laurent Vivier
Le 03/08/2020 à 11:46, Filip Bozuta a écrit : > This patch implements functionality for following ioctls: > > BTRFS_IOC_GET_FEATURES - Getting feature flags > > Read feature flags for a btrfs filesystem. The feature flags > are returned inside the ioctl's third argument which represents

Re: [PATCH v2 3/8] linux-user: Add support for btrfs ioctls used to manipulate with devices

2020-08-07 Thread Laurent Vivier
Le 03/08/2020 à 11:46, Filip Bozuta a écrit : > This patch implements functionality for following ioctls: > > BTRFS_IOC_SCAN_DEV - Scanning device for a btrfs filesystem > > Scan a device for a btrfs filesystem. The device that is to > be scanned is passed in the ioctl's third argument

Re: [PATCH v2 5/8] linux-user: Add support for a group of btrfs inode ioctls

2020-08-07 Thread Laurent Vivier
Le 03/08/2020 à 11:46, Filip Bozuta a écrit : > This patch implements functionality of following ioctls: > > BTRFS_IOC_INO_LOOKUP - Reading tree root id and path > > Read tree root id and path for a given file or directory. > The name and tree root id are returned in an ioctl's third >

Re: [PATCH v2 6/8] linux-user: Add support for two btrfs ioctls used for subvolume

2020-08-07 Thread Laurent Vivier
Le 03/08/2020 à 11:46, Filip Bozuta a écrit : > This patch implements functionality for following ioctl: > > BTRFS_IOC_DEFAULT_SUBVOL - Setting a default subvolume > > Set a default subvolume for a btrfs filesystem. The third > ioctl's argument is a '__u64' (unsigned long long) which >

Re: [PATCH v2 1/8] linux-user: Add support for a group of btrfs ioctls used for subvolumes

2020-08-07 Thread Laurent Vivier
Le 03/08/2020 à 11:46, Filip Bozuta a écrit : > This patch implements functionality of following ioctls: > > BTRFS_IOC_SUBVOL_CREATE - Creating a btrfs subvolume > > Create a btrfs subvolume. The subvolume is created using the ioctl's > third argument which represents a pointer to a

Re: [PATCH v2 2/8] linux-user: Add support for a group of btrfs ioctls used for snapshots

2020-08-07 Thread Laurent Vivier
Le 03/08/2020 à 11:46, Filip Bozuta a écrit : > This patch implements functionality for following ioctls: > > BTRFS_IOC_SNAP_CREATE - Creating a subvolume snapshot > > Create a snapshot of a btrfs subvolume. The snapshot is created using the > ioctl's third argument that is a pointer to

Re: [PATCH v2 2/5] virtiofsd: create lock/pid file in per user cache dir

2020-08-07 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > Right now we create lock/pid file in /usr/local/var/... and unprivliged > user does not have access to create files there. I *think* the /usr/local there is coming from the build config of your qemu; but I'm not 100% sure whether it's just it's --preifx

Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-07 Thread Babu Moger
On 8/7/20 11:52 AM, Daniel P. Berrangé wrote: > On Fri, Aug 07, 2020 at 11:32:51AM -0500, Babu Moger wrote: >> Adding a new check to warn the users to configure 'dies' when >> topology is numa configured. It makes it easy to build the >> topology for EPYC models. > > This says you're adding a

Re: [PATCH 063/143] meson: convert tests/qtest to meson

2020-08-07 Thread Alexander Bulekov
Thank you, Paolo. I haven't gone through all the other messages yet, so maybe I missed some insights that would help with this. Some notes as I try to build qemu-fuzz-i386. * Needed to do git submodule update --init. IIRC this used to happen automatically for stuff like slirp. I will need to

Re: [PATCH] introduce VFIO-over-socket protocol specificaion

2020-08-07 Thread John G Johnson
Updated doc to address comments. Many changes are typos, but some are more more substantive. JJ Version title is a hyperlink the versioning section Rewrote concurrency section to be less concurrent Removed disconnection

Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-07 Thread Daniel P . Berrangé
On Fri, Aug 07, 2020 at 11:32:51AM -0500, Babu Moger wrote: > Adding a new check to warn the users to configure 'dies' when > topology is numa configured. It makes it easy to build the > topology for EPYC models. This says you're adding a warning > > Signed-off-by: Babu Moger > --- >

[PATCH v3 0/3] Fix couple of issues with AMD topology

2020-08-07 Thread Babu Moger
This series fixes couple of issues with recent topology related code. 1. Warn users to pass the dies information if EPYC cpu is numa configured. 2. Remove the node_id references in topology and use die_id instead. 3. With node_id removed in topology the uninitialized memory issue with

[Bug 1888601] Re: QEMU v5.1.0-rc0/rc1 hang with nested virtualization

2020-08-07 Thread Simon Kaegi
Is there anything more I could do to help track this down? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1888601 Title: QEMU v5.1.0-rc0/rc1 hang with nested virtualization Status in QEMU: New

Re: [PATCH v2 1/5] virtiofsd: Add notion of unprivileged mode

2020-08-07 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > At startup if we are running as non-root user, then internally set > unpriviliged mode set. Also add a notion of sandbox NONE and set > that internally in unprivileged mode. setting up namespaces and > chroot() fails in unpriviliged mode. > >

[PATCH v3 3/3] hw/i386: Remove node_id, nr_nodes and nodes_per_pkg from topology

2020-08-07 Thread Babu Moger
Remove node_id, nr_nodes and nodes_per_pkg from topology. Use die_id, nr_dies and dies_per_pkg which is already available. Removes the confusion over two variables. Signed-off-by: Babu Moger --- hw/i386/pc.c |1 - hw/i386/x86.c |1 - include/hw/i386/topology.h

[PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-07 Thread Babu Moger
Adding a new check to warn the users to configure 'dies' when topology is numa configured. It makes it easy to build the topology for EPYC models. Signed-off-by: Babu Moger --- hw/i386/x86.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/i386/x86.c b/hw/i386/x86.c index

[PATCH v3 1/3] i386: Simplify CPUID_8000_001E for AMD

2020-08-07 Thread Babu Moger
apic_id contains all the information required to build CPUID_8000_001E. Also remove the restriction on number bits on core_id and node_id. Remove all the hardcoded values and replace with generalized fields. Refer the Processor Programming Reference (PPR) documentation available from the bugzilla

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-07 Thread Paolo Bonzini
On 07/08/20 17:26, Peter Maydell wrote: > For instance, I was just glancing through the Meson FAQ, > and "tell the compiler not to use RTTI for C++" is apparently > something that needed a change to Meson to support, which seems > ridiculous. I am not sure why they singled that out in the FAQ,

Re: [PATCH v8 09/20] multi-process: Associate fd of a PCIDevice with its object

2020-08-07 Thread Stefan Hajnoczi
On Fri, Jul 31, 2020 at 02:20:16PM -0400, Jagannathan Raman wrote: > +static void remote_object_set_devid(Object *obj, const char *str, Error > **errp) > +{ > +RemoteObject *o = REMOTE_OBJECT(obj); > + > +o->devid = g_strdup(str); Setter functions can be called multiple times so

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-07 Thread Daniel P . Berrangé
On Fri, Aug 07, 2020 at 05:14:06PM +0200, Paolo Bonzini wrote: > Stuff like automatically cloning git submodules will never be in Meson, > and we can keep Make forever as a small escape hatch for that. However, > using Make as a Turing-complete language to build our own DSLs on top of > is just

Re: [PATCH v2 2/3] virtiofsd: add container-friendly -o sandbox=chroot option

2020-08-07 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > virtiofsd cannot run in a container because CAP_SYS_ADMIN is required to > create namespaces. > > Introduce a weaker sandbox mode that is sufficient in container > environments because the container runtime already sets up namespaces. > Use chroot

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-07 Thread Paolo Bonzini
On 07/08/20 16:29, Daniel P. Berrangé wrote: > New binaries have lost a bunch of libraries they previously linked > to. This isn't neccessarily a bug, if the old make code was incorrectly > adding too many libraries. Yes this is because Meson uses --as-needed. > Comparing 'make install', I see

Re: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an error

2020-08-07 Thread Dr. David Alan Gilbert
* misono.tomoh...@fujitsu.com (misono.tomoh...@fujitsu.com) wrote: > > Subject: [PATCH v2 3/3] virtiofsd: probe unshare(CLONE_FS) and print an > > error > > > > An assertion failure is raised during request processing if > > unshare(CLONE_FS) fails. Implement a probe at startup so the problem

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-07 Thread Peter Maydell
On Fri, 7 Aug 2020 at 16:14, Paolo Bonzini wrote: > > One important difference between Make and Meson is that Meson is by > design limited in what it can do. The idea (which I think has served > them well) is that they want projects to show what they need and work > with them on how to build it.

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-07 Thread Paolo Bonzini
On 07/08/20 14:20, Cornelia Huck wrote: >> - on an s390x system, it mostly builds, but I end up with a bunch of >> link errors for libblock.fa, where it fails to find various ZSTD_ >> symbols > Still happening after switching to the latest version of your branch. > Fixed thusly: diff --git

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-07 Thread Paolo Bonzini
On 07/08/20 16:02, Peter Maydell wrote: > On Fri, 7 Aug 2020 at 14:55, Markus Armbruster wrote: >> I'm notoriously conservative in my choice of tools, and GNU Make is a >> much better tool than some people give it credit for, but I've long felt >> we've pushed it beyond its limits. > > The thing

[Bug 1805256] Autopkgtest regression report (qemu/1:2.11+dfsg-1ubuntu7.30)

2020-08-07 Thread Ubuntu SRU Bot
All autopkgtests for the newly accepted qemu (1:2.11+dfsg-1ubuntu7.30) for bionic have finished running. The following regressions have been reported in tests triggered by the package: systemd/237-3ubuntu10.42 (i386) ubuntu-image/1.9+18.04ubuntu1 (arm64, armhf, i386, s390x, ppc64el, amd64)

Re: [PATCH 111/143] meson: convert hw/i2c

2020-08-07 Thread Corey Minyard
On Thu, Aug 06, 2020 at 09:15:47PM +0200, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini Reviewed-by: Corey Minyard > --- > hw/Makefile.objs | 1 - > hw/i2c/Makefile.objs | 14 -- > hw/i2c/meson.build |

Re: [PATCH 106/143] meson: convert hw/ipmi

2020-08-07 Thread Corey Minyard
On Thu, Aug 06, 2020 at 09:15:42PM +0200, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini I looked at all the configure names and files and everything looks correct. Reviewed-by: Corey Minyard > --- > hw/Makefile.objs

Re: [PATCH 037/143] meson: add qemu-bridge-helper

2020-08-07 Thread Philippe Mathieu-Daudé
On 8/7/20 4:26 PM, Paolo Bonzini wrote: > On 07/08/20 15:20, Philippe Mathieu-Daudé wrote: >>>endif >>> >>> + if host_machine.system() == 'linux' >>> +executable('qemu-bridge-helper', files('qemu-bridge-helper.c'), >>> + dependencies: [qemuutil, libcap_ng], >> Is libcap_ng

Re: [PATCH 068/143] meson: convert most of softmmu/

2020-08-07 Thread Philippe Mathieu-Daudé
On 8/7/20 4:18 PM, Paolo Bonzini wrote: > On 07/08/20 15:36, Philippe Mathieu-Daudé wrote: >> There is still "obj-y += vl.o" in softmmu/Makefile.objs. >> >> Did you meant to squash this into the previous patch? > > This is what I meant: > > diff --git a/meson.build b/meson.build > index

[PATCH-for-5.2 3/3] hw/misc/unimp: Display the offset with width of the region size

2020-08-07 Thread Philippe Mathieu-Daudé
To have a better idea of how big is the region where the offset belongs, display the value with the width of the region size (i.e. a region of 0x1000 bytes uses 0x000 format). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/unimp.h | 1 + hw/misc/unimp.c | 10 ++ 2

[PATCH-for-5.2 2/3] hw/misc/unimp: Display the value with width of the access size

2020-08-07 Thread Philippe Mathieu-Daudé
To quickly notice the access size, display the value with the width of the access (i.e. 16-bit access is displayed 0x, while 8-bit access 0x00). Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/unimp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/unimp.c

[PATCH-for-5.2 0/3] hw/misc/unimp: Improve how offset/value are displayed

2020-08-07 Thread Philippe Mathieu-Daudé
This series aims to ease looking at the '-d unimp' output reported by the UnimplementedDevice. - read/write accesses are now aligned - the value format width uses the access size - the offset (address) uses the size of the memory region it belongs Philippe Mathieu-Daudé (3): hw/misc/unimp:

[PATCH-for-5.2 1/3] hw/misc/unimp: Display value after offset

2020-08-07 Thread Philippe Mathieu-Daudé
To better align the read/write accesses, display the value after the offset (read accesses only display the offset). Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/unimp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c index

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-07 Thread Daniel P . Berrangé
On Thu, Aug 06, 2020 at 09:13:56PM +0200, Paolo Bonzini wrote: > This the more or less final version of the Meson conversion. Due to > the sheer size of the series you have been CCed only on the cover > letter. > > The series reaches the point where Makefile.target and unnest-vars > can be

Re: [PATCH 037/143] meson: add qemu-bridge-helper

2020-08-07 Thread Paolo Bonzini
On 07/08/20 15:20, Philippe Mathieu-Daudé wrote: >>endif >> >> + if host_machine.system() == 'linux' >> +executable('qemu-bridge-helper', files('qemu-bridge-helper.c'), >> + dependencies: [qemuutil, libcap_ng], > Is libcap_ng still optional? > Yes, if a dependency is

Re: [PATCH 070/143] meson: convert block/

2020-08-07 Thread Paolo Bonzini
On 07/08/20 15:37, Philippe Mathieu-Daudé wrote: > On 8/6/20 9:15 PM, Paolo Bonzini wrote: >> From: Marc-André Lureau >> >> Signed-off-by: Marc-André Lureau >> Signed-off-by: Paolo Bonzini >> --- >> Makefile.objs | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git

Re: [PATCH 068/143] meson: convert most of softmmu/

2020-08-07 Thread Paolo Bonzini
On 07/08/20 15:36, Philippe Mathieu-Daudé wrote: > There is still "obj-y += vl.o" in softmmu/Makefile.objs. > > Did you meant to squash this into the previous patch? This is what I meant: diff --git a/meson.build b/meson.build index a7ad3248cc..ef6f811c51 100644 --- a/meson.build +++

[Bug 1219234] Re: -device ide-hd will assign bus with with no free units

2020-08-07 Thread John Snow
I'll re-investigate. I definitely fixed some of this (there is if=IDE for AHCI now), but I recall Markus mentioning recently that there are a lot of weird things quite broken with AHCI and bus assignment. I'm working on several other IDE fixes for the next release, so we can add this one to the

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-07 Thread Peter Maydell
On Fri, 7 Aug 2020 at 14:55, Markus Armbruster wrote: > I'm notoriously conservative in my choice of tools, and GNU Make is a > much better tool than some people give it credit for, but I've long felt > we've pushed it beyond its limits. The thing is, it feels somewhat like we're already pushing

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-07 Thread Markus Armbruster
Paolo Bonzini writes: > On 07/08/20 09:56, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> This the more or less final version of the Meson conversion. Due to >>> the sheer size of the series you have been CCed only on the cover >>> letter. >> >> Perfect timing: right before I drop

Re: [PATCH 003/143] pc-bios/s390-ccw: simplify Makefile

2020-08-07 Thread Paolo Bonzini
On 07/08/20 14:58, Thomas Huth wrote: > As Cornelia already mentioned in another mail, this does not work yet. > I'd also prefer if we could keep the netbook.mak stuff in that separate > file. It won't be possible to keep it separate when it's converted to Meson (unless you add a new directory

Re: [PATCH] docs: Fix broken links

2020-08-07 Thread Philippe Mathieu-Daudé
On 8/7/20 12:17 PM, Han Han wrote: > Signed-off-by: Han Han > --- > docs/amd-memory-encryption.txt | 4 ++-- > docs/pvrdma.txt| 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 111/143] meson: convert hw/i2c

2020-08-07 Thread Philippe Mathieu-Daudé
On 8/6/20 9:15 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > hw/Makefile.objs | 1 - > hw/i2c/Makefile.objs | 14 -- > hw/i2c/meson.build | 16 > hw/meson.build | 1 + >

Re: [PATCH 070/143] meson: convert block/

2020-08-07 Thread Philippe Mathieu-Daudé
On 8/6/20 9:15 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > Makefile.objs | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Makefile.objs b/Makefile.objs > index a5c919d..0f3074b 100644

any virtio-mac80211 (alternative) implementations

2020-08-07 Thread linwei6
I see a project on github https://github.com/ra7narajm/virtio-mac80211 which seems like a implementation of virt-wifi in VM after I dig into the project and try what the author say, I found it was an unfinished project,(maybe, so far as I can tell) Is any one got any ideas about this project or

Re: [PATCH 068/143] meson: convert most of softmmu/

2020-08-07 Thread Philippe Mathieu-Daudé
Hi Paolo, On 8/6/20 9:15 PM, Paolo Bonzini wrote: > Leave out main.c, it's special due to fuzzing. > > Signed-off-by: Paolo Bonzini > --- > softmmu/meson.build | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/softmmu/meson.build b/softmmu/meson.build > index

Re: [PATCH 057/143] meson: convert chardev directory to Meson (tools part)

2020-08-07 Thread Philippe Mathieu-Daudé
On 8/6/20 9:14 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > Makefile | 1 - > Makefile.objs | 4 ++-- > Makefile.target | 2 +- > chardev/Makefile.objs | 19 --- >

[PATCH] Coroutine-aware monitor_cur() with coroutine-specific data

2020-08-07 Thread Markus Armbruster
This is just a sketch. It needs comments and a real commit message. As is, it goes on top of Kevin's series. It is meant to be squashed into PATCH 06. Signed-off-by: Markus Armbruster --- include/qemu/coroutine.h | 4 include/qemu/coroutine_int.h | 2 ++ monitor/monitor.c

[PATCH] Simple & stupid coroutine-aware monitor_cur()

2020-08-07 Thread Markus Armbruster
This is just a sketch. It's incomplete, needs comments and a real commit message. Support for "[PATCH v6 09/12] hmp: Add support for coroutine command handlers" is missing. Marked FIXME. As is, it goes on top of Kevin's series. It is meant to be squashed into PATCH 06, except for the FIXME,

Re: [PATCH 045/143] meson: uncompress edk2 bios

2020-08-07 Thread Philippe Mathieu-Daudé
On 8/6/20 9:14 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > Makefile| 7 --- > meson.build | 1 + > pc-bios/meson.build | 23 +++ > 3 files changed, 24

Re: [PATCH 039/143] meson: add qemu-edid

2020-08-07 Thread Philippe Mathieu-Daudé
On 8/6/20 9:14 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > Makefile| 2 -- > configure | 2 +- > meson.build | 3 +++ > 3 files changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Philippe

Re: [PATCH 007/143] tests/vm: do not pollute configure with --efi-aarch64

2020-08-07 Thread Paolo Bonzini
On 07/08/20 15:06, Philippe Mathieu-Daudé wrote: >> +EFI_AARCH64 = $(wildcard $(SRC_PATH)/pc-bios/edk2-aarch64-code.fd) > I'm not sure this is correct. Shouldn't we use the '?=' operator to > allow override? I think we want to test > $(BUILD_DIR)/pc-bios/edk2-aarch64-code.fd instead. >

Re: [PATCH 037/143] meson: add qemu-bridge-helper

2020-08-07 Thread Philippe Mathieu-Daudé
Hi Paolo, On 8/6/20 9:14 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > Makefile| 4 > meson.build | 8 +++- > 2 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/Makefile b/Makefile >

Re: [PATCH v2 3/3] linux-user: Add strace support for printing arguments for ioctls used for terminals and serial lines

2020-08-07 Thread Laurent Vivier
Le 23/07/2020 à 23:02, Filip Bozuta a écrit : > Functions "print_ioctl()" and "print_syscall_ret_ioctl()" are used > to print arguments of "ioctl()" with "-strace". These functions > use "thunk_print()", which is defined in "thunk.c", to print the > contents of ioctl's third arguments that are not

Re: [PATCH v2 2/3] linux-user: Add missing termbits types and values definitions

2020-08-07 Thread Laurent Vivier
Le 23/07/2020 à 23:02, Filip Bozuta a écrit : > This patch introduces missing target types ('target_flag_t', 'target_cc_t', > 'target_speed_t') in a few 'termibts.h' header files. Also, two missing > values ('TARGET_IUTF8' and 'TARGET_EXTPROC') were also added. These values > were also added in

Re: [PATCH 008/143] tests/vm: check for Python YAML parser in the Makefile

2020-08-07 Thread Philippe Mathieu-Daudé
On 8/6/20 9:14 PM, Paolo Bonzini wrote: > No need to do it in the configure file if it is only used for a help message. > > Signed-off-by: Paolo Bonzini > --- > configure | 9 - > tests/vm/Makefile.include | 4 +++- > 2 files changed, 3 insertions(+), 10 deletions(-) >

Re: [PATCH v2 1/3] linux-user: Add generic 'termbits.h' for some archs

2020-08-07 Thread Laurent Vivier
Le 23/07/2020 à 23:02, Filip Bozuta a écrit : > This patch introduces a generic 'termbits.h' file for following > archs: 'aarch64', 'arm', 'i386, 'm68k', 'microblaze', 'nios2', > 'openrisc', 'riscv', 's390x', 'x86_64'. > > Since all of these archs have the same termios flag values and > same

Ways to do per-coroutine properties (was: [PATCH v6 06/12] monitor: Make current monitor a per-coroutine property)

2020-08-07 Thread Markus Armbruster
I called for a discussion of design alternatives, because I dislike the one I got. Here we go. = Context: the "current monitor" = Output of HMP commands needs to go to the HMP monitor executing the command. Trivial in HMP command handlers: the handler function takes a monitor argument. Not so

Re: [PATCH 009/143] configure: do not include $(...) variables in config-host.mak

2020-08-07 Thread Philippe Mathieu-Daudé
On 8/6/20 9:14 PM, Paolo Bonzini wrote: > This ensures that Meson will be able to reuse the results of > the tests that are performed in the configure script. > > Signed-off-by: Paolo Bonzini > --- > configure | 32 > 1 file changed, 16 insertions(+), 16

Re: [PATCH 007/143] tests/vm: do not pollute configure with --efi-aarch64

2020-08-07 Thread Philippe Mathieu-Daudé
On 8/6/20 9:14 PM, Paolo Bonzini wrote: > Just make EFI_AARCH64 a variable in the makefile that defaults to the efi > firmware included with QEMU. It can be redefined on the "make" command > line. > > Signed-off-by: Paolo Bonzini > --- > configure | 19 --- >

Re: [PATCH v2 0/4] Add dtrace support on macOS

2020-08-07 Thread Stefan Hajnoczi
On Fri, Jul 17, 2020 at 12:35:13PM +0300, Roman Bolshakov wrote: > Hi, > > This is a small series that enables dtrace tracing backend on macOS. > Whether or not it should go to 5.1 is up to discretion of tracing > maintainers. > > Thanks, > Roman > > Changes since v1: > - Fixed a typo ANSI C

Re: [PATCH 003/143] pc-bios/s390-ccw: simplify Makefile

2020-08-07 Thread Thomas Huth
On 06/08/2020 21.13, Paolo Bonzini wrote: > Make it independent from the rules.mak, and clean up to use pattern rules. > > Signed-off-by: Paolo Bonzini > --- > pc-bios/s390-ccw/Makefile| 105 > ++- > pc-bios/s390-ccw/netboot.mak | 62

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-07 Thread Paolo Bonzini
On 07/08/20 14:20, Thomas Huth wrote: > On 07/08/2020 13.04, Paolo Bonzini wrote: >> On 07/08/20 12:52, Thomas Huth wrote: >>> Thanks! Now, both, macOS and FreeBSD builds stop with: >>> >>> ../tests/qtest/meson.build:204:0: ERROR: Unknown variable "dbus_vmstate1". >>>

Re: [PATCH v3 for-5.2 2/3] ppc/xive: Introduce dedicated kvm_irqchip_in_kernel() wrappers

2020-08-07 Thread Cédric Le Goater
On 8/7/20 1:32 PM, Greg Kurz wrote: > Calls to the KVM XIVE device are guarded by kvm_irqchip_in_kernel(). This > ensures that QEMU won't try to use the device if KVM is disabled or if > an in-kernel irqchip isn't required. > > When using ic-mode=dual with the pseries machine, we have two

Re: [DRAFT PATCH 000/143] Meson integration for 5.2

2020-08-07 Thread Paolo Bonzini
On 07/08/20 14:20, Thomas Huth wrote: > Nice, we're getting there, now macOS starts compiling, but then fails here: > > ../contrib/libvhost-user/libvhost-user.c:27:10: fatal error: > 'sys/eventfd.h' file not found > ../contrib/libvhost-user/libvhost-user.h:21:10: fatal error: > 'linux/vhost.h'

Re: [PATCH v3 for-5.2 3/3] spapr/xive: Convert KVM device fd checks to assert()

2020-08-07 Thread Cédric Le Goater
On 8/7/20 1:32 PM, Greg Kurz wrote: > All callers guard these functions with an xive_in_kernel() helper. Make > it clear that they are only to be called when the KVM XIVE device exists. > > Note that the check on xive is dropped in kvmppc_xive_disconnect(). It > really cannot be NULL since it

  1   2   3   >