Re: [PATCH v2] block: Raise an error when backing file parameter is an empty string

2020-08-11 Thread Kevin Wolf
Am 11.08.2020 um 23:23 hat Connor Kuehl geschrieben: > Providing an empty string for the backing file parameter like so: > > qemu-img create -f qcow2 -b '' /tmp/foo > > allows the flow of control to reach and subsequently fail an assert > statement because passing an empty string to > >

[PATCH 2/2] target/arm: Implement an IMPDEF pauth algorithm

2020-08-11 Thread Richard Henderson
Without hardware acceleration, a cryptographically strong algorithm is too expensive for pauth_computepac. Even with hardware accel, we are not currently expecting to link the linux-user binaries to any crypto libraries, and doing so would generally make the --static build fail. So choose XXH64 a

[PATCH 1/2] target/arm: Add cpu property to control pauth

2020-08-11 Thread Richard Henderson
The crypto overhead of emulating pauth can be significant for some workloads. Add an enumeration property that allows the feature to be turned off, on with the architected algorithm, or on with an implementation defined algorithm. The architected algorithm is quite expensive to emulate; using ano

[PATCH 0/2] target/arm: Implement an IMPDEF pauth algorithm

2020-08-11 Thread Richard Henderson
With recent linux kernels, which are built with pauth enabled, boot times have been significantly impacted. It turns out the architected pac algorithm is expensive to implement without hardware accel. I tried replacing this with AES128, which most hosts have in hardware. I did manage to make this

[Bug 1815911] Re: aptitude crashes qemu-m68k with handle_cpu_signal received signal outside vCPU context

2020-08-11 Thread John Paul Adrian Glaubitz
Just verified it with a very recently compiled version of QEMU from git master and, indeed, the bug seems to be fixed as I can no longer reproduce the crash. The command executes correctly. I guess it's safe to mark this as fixed. -- You received this bug notification because you are a member of

[Bug 1886811] Re: systemd complains Failed to enqueue loopback interface start request: Operation not supported

2020-08-11 Thread Christian Ehrhardt 
@Ryutaroh - could you test [1] if it gets you around this bug (1886811) and if bug 1890881 is present in focal as well? [1]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4197 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to Q

[Bug 1366363] Re: qemu-git gravis ultrasound not working

2020-08-11 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1366363 Title: qemu-git gravis ultrasound not working Status in QEMU: Triaged Bug descript

Re: [PATCH] arm: aspeed: add strap define `25HZ` of AST2500

2020-08-11 Thread Cédric Le Goater
On 8/11/20 10:35 PM, Igor Kononenko wrote: > Provide a definition for the "25Hz reference clock input mode" strap > > Signed-off-by: Igor Kononenko Reviewed-by: Cédric Le Goater > --- > include/hw/misc/aspeed_scu.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/hw/misc/aspe

[Bug 1815911] Re: aptitude crashes qemu-m68k with handle_cpu_signal received signal outside vCPU context

2020-08-11 Thread Thomas Huth
John, can you still reproduce it with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815911 Title: aptitude crashes

[Bug 1407808] Re: virtual console gives strange response to ANSI DSR

2020-08-11 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1407808 Title: virtual console gives strange response to ANSI DSR Status in QEMU: Triaged

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-11 Thread Howard Spoelstra
Hi, I just compiled qemu-system-ppc using the the meson-poc-next branch with: git clone -b meson-poc-next http://www.github.com/bonzini/qemu qemu-mesonbuild-next cd qemu-mesonbuild-next mkdir build cd build ../configure --target-list="ppc-softmmu" --enable-sdl --enable-gtk --disable-werror qemu-s

[Bug 1886811] Re: systemd complains Failed to enqueue loopback interface start request: Operation not supported

2020-08-11 Thread Christian Ehrhardt 
** Also affects: qemu (Ubuntu Focal) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886811 Title: systemd complains Failed to enqueue loopback interface

Re: [PATCH v6 0/6] riscv: Switch to use generic platform fw_dynamic type opensbi bios images

2020-08-11 Thread Alistair Francis
On Mon, Aug 3, 2020 at 12:31 AM Bin Meng wrote: > > From: Bin Meng > > The RISC-V generic platform is a flattened device tree (FDT) based > platform where all platform specific functionality is provided based > on FDT passed by previous booting stage. The support was added in > the upstream OpenS

Re: [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u

2020-08-11 Thread Alistair Francis
On Sun, Aug 2, 2020 at 11:51 PM Bin Meng wrote: > > Hi Alistair, > > On Wed, Jul 29, 2020 at 1:10 PM Bin Meng wrote: > > > > Hi Alistair, > > > > On Wed, Jul 29, 2020 at 1:05 PM Alistair Francis > > wrote: > > > > > > On Tue, Jul 28, 2020 at 9:51 PM Bin Meng wrote: > > > > > > > > Hi Alistair,

Re: [PATCH v7 13/13] tests/acceptance: console boot tests for quanta-gsj

2020-08-11 Thread Havard Skinnemoen
On Tue, Aug 11, 2020 at 1:48 AM Philippe Mathieu-Daudé wrote: > > Hi Havard, > > On 8/11/20 2:46 AM, Havard Skinnemoen wrote: > > This adds two acceptance tests for the quanta-gsj machine. > > > > One test downloads a lightly patched openbmc flash image from github and > > verifies that it boots a

Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-11 Thread Jason Wang
On 2020/8/12 上午1:55, Eugenio Pérez wrote: Signed-off-by: Eugenio Pérez --- hw/virtio/vhost.c | 2 +- include/exec/memory.h | 2 ++ softmmu/memory.c | 10 -- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 1a138

Re: [PATCH 7/7] target/arm/cpu: spe: Enable spe to work with host cpu

2020-08-11 Thread Haibo Xu
On Wed, 12 Aug 2020 at 00:50, Andrew Jones wrote: > > On Tue, Aug 11, 2020 at 11:15:42AM +0800, Haibo Xu wrote: > > > > +if (!cpu->has_spe || !kvm_enabled()) { > > > > +unset_feature(env, ARM_FEATURE_SPE); > > > > +} > > > > > > I don't think this should be necessary. > > > > > > >

Re: [PATCH 6/7] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-08-11 Thread Haibo Xu
On Wed, 12 Aug 2020 at 00:40, Andrew Jones wrote: > On Tue, Aug 11, 2020 at 10:38:02AM +0800, Haibo Xu wrote: > > On Mon, 10 Aug 2020 at 19:05, Andrew Jones wrote: > > > > > > On Fri, Aug 07, 2020 at 08:10:36AM +, Haibo Xu wrote: > > > > Add a virtual SPE device for virt machine while using

[Bug 1884684] Re: QEMU 5.0: Guest VM hangs/freeze when unplugging USB device

2020-08-11 Thread TheCatFelix
I do get get the same backtrace in gdb every time every time when we reproduce the hang: (gdb) thread apply all bt Thread 9 (Thread 0x7fd1415ff700 (LWP 3202)): #0 0x7fd323d154bf in __GI___poll (fds=0x7fd1415fe6c0, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29 #1 0x7fd3249

[PATCH 1/2] file-posix: Correctly read max_segments of SG nodes

2020-08-11 Thread Dmitry Fomichev
If scsi-generic driver is in use, an SG node can be specified in the command line in place of a regular SCSI device. In this case, sg_get_max_segments() fails to open max_segments entry in sysfs because /dev/sgX is a character device. As the result, the maximum transfer size for the device may be c

[PATCH 0/2] block;scsi-generic: Fix max transfer size calculation

2020-08-11 Thread Dmitry Fomichev
When a host-managed zoned device is passed through to the guest system using scsi-generic driver, the maximum i/o size for the drive at the guest may end up being larger than at the host, causing i/o errors while accessing the backing zoned drive at the host system. Two problems prevent correct se

[PATCH 2/2] scsi-generic: Fix HM-zoned device scan

2020-08-11 Thread Dmitry Fomichev
Several important steps during device scan depend on SCSI type of the device. For example, max_transfer property is only determined and assigned if the device has the type of TYPE_DISK. Host-managed ZBC disks retain most of the properties of regular SCSI drives, but they have their own SCSI device

[Bug 1884684] Re: QEMU 5.0: Guest VM hangs/freeze when unplugging USB device

2020-08-11 Thread TheCatFelix
Link to bug on the proxmox side: https://bugzilla.proxmox.com/show_bug.cgi?id=2781 ** Bug watch added: bugzilla.proxmox.com/ #2781 https://bugzilla.proxmox.com/show_bug.cgi?id=2781 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[ANNOUNCE] QEMU 5.1.0 is now available

2020-08-11 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the QEMU 5.1.0 release. This release contains 2500+ commits from 235 authors. You can grab the tarball from our download page here: https://www.qemu.org/download/#source The full list of changes are available at: h

[Bug 1883728] Re: address_space_unmap: Assertion `mr != NULL' failed.

2020-08-11 Thread Alexander Bulekov
Here's a qtest reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 \ -device nec-usb-xhci -trace usb\* \ -device usb-audio -device usb-storage,drive=mydrive \ -drive id=mydrive,file=null-co://,size=2M,format=raw,if=none \ -nodefaults -nographic -qtest stdio outl 0xcf8 0x80001016 outl 0xcfc 0x

Re: [PATCH v2 7/8] thunk: supports flexible arrays

2020-08-11 Thread Shu-Chun Weng
Forgot to +riku.voi...@iki.fi when generating v2. On Tue, Aug 11, 2020 at 12:10 AM Shu-Chun Weng wrote: > Flexible arrays may appear in the last field of a struct and are heavily > used in the ioctl(SIOCETHTOOL) system call on Linux. E.g. > > struct ethtool_regs { > __u32 cmd; >

[PATCH v2] block: Raise an error when backing file parameter is an empty string

2020-08-11 Thread Connor Kuehl
Providing an empty string for the backing file parameter like so: qemu-img create -f qcow2 -b '' /tmp/foo allows the flow of control to reach and subsequently fail an assert statement because passing an empty string to bdrv_get_full_backing_filename_from_filename() simply result

Re: [PATCH-for-5.2 1/3] hw/i2c: Fix typo in description

2020-08-11 Thread Corey Minyard
On Tue, Aug 11, 2020 at 05:16:41PM +0200, Philippe Mathieu-Daudé wrote: > Remove the second 'and' introduced in commit 73d5f22ecb > ("hw/i2c: Document the I2C qdev helpers"). > > Signed-off-by: Philippe Mathieu-Daudé Well, it seems rather obvious that this is correct :), so: Reviewed-by: Corey

Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-11 Thread Babu Moger
On 8/7/20 2:11 PM, Igor Mammedov wrote: > On Fri, 7 Aug 2020 17:52:22 +0100 > Daniel P. Berrangé wrote: > >> On Fri, Aug 07, 2020 at 11:32:51AM -0500, Babu Moger wrote: >>> Adding a new check to warn the users to configure 'dies' when >>> topology is numa configured. It makes it easy to build

[RFC v4 12/14] whpx: remove whpx specific functions from global includes

2020-08-11 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- accel/stubs/Makefile.objs | 1 - accel/stubs/whpx-stub.c | 47 --- include/sysemu/whpx.h | 19 --- target/i386/whpx-all.c| 1 + target/i386/whpx-cpus.c | 1 + target/i386/whpx-int.h|

[Bug 1810000] Re: qemu system emulator crashed when using xhci usb controller

2020-08-11 Thread Alexander Bulekov
Here's a QTest reproducer: cat << EOF | ./i386-softmmu/qemu-system-i386 \ -device nec-usb-xhci -trace usb\* \ -device usb-audio -device usb-storage,drive=mydrive \ -drive id=mydrive,file=null-co://,size=2M,format=raw,if=none \ -nodefaults -nographic -qtest stdio outl 0xcf8 0x80001016 outl 0xcfc 0x

[RFC v4 06/14] cpus: extract out hax-specific code to target/i386/

2020-08-11 Thread Claudio Fontana
register a "CpusAccel" interface for HAX as well. Signed-off-by: Claudio Fontana --- softmmu/cpus.c| 80 +--- target/i386/Makefile.objs | 5 +-- target/i386/hax-all.c | 6 +++- target/i386/hax-cpus.c| 85 ++

[RFC v4 07/14] cpus: extract out whpx-specific code to target/i386/

2020-08-11 Thread Claudio Fontana
register a "CpusAccel" interface for WHPX as well. Signed-off-by: Claudio Fontana --- MAINTAINERS | 1 + softmmu/cpus.c| 79 -- target/i386/Makefile.objs | 2 +- target/i386/whpx-all.c| 3 ++ target/i386/whpx-cpus.c | 96

[RFC v4 03/14] cpus: extract out TCG-specific code to accel/tcg

2020-08-11 Thread Claudio Fontana
TCG is the first accelerator to register a "CpusAccel" interface on initialization, providing functions for starting a vcpu, kicking a vcpu, sychronizing state and getting virtual clock and ticks. Signed-off-by: Claudio Fontana --- accel/tcg/Makefile.objs | 1 + accel/tcg/tcg-all.c | 12 +

[RFC v4 14/14] kvm: remove kvm specific functions from global includes

2020-08-11 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- accel/kvm/kvm-all.c| 1 + accel/kvm/kvm-cpus.c | 1 + accel/kvm/kvm-int.h| 23 +++ accel/stubs/kvm-stub.c | 22 -- include/sysemu/kvm.h | 7 --- 5 files changed, 25 insertions(+), 29 deletions(-) create

[RFC v4 13/14] hax: remove hax specific functions from global includes

2020-08-11 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- accel/stubs/hax-stub.c| 10 -- include/sysemu/hax.h | 17 - target/i386/hax-all.c | 2 +- target/i386/hax-cpus.c| 2 +- target/i386/hax-int.h | 41 + target/i386/hax-mem.c

[RFC v4 11/14] hvf: remove hvf specific functions from global includes

2020-08-11 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- accel/stubs/Makefile.objs | 1 - accel/stubs/hvf-stub.c | 30 -- include/sysemu/hvf.h | 8 target/i386/hvf/hvf-cpus.c | 1 + target/i386/hvf/hvf-int.h | 24 target/i386/hvf/hvf.c |

RE: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC

2020-08-11 Thread Babu Moger
> -Original Message- > From: Igor Mammedov > Sent: Friday, August 7, 2020 2:27 PM > To: Moger, Babu > Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com; qemu- > de...@nongnu.org; m...@redhat.com > Subject: Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies f

[RFC v4 01/14] cpu-timers, icount: new modules

2020-08-11 Thread Claudio Fontana
refactoring of cpus.c continues with cpu timer state extraction. cpu-timers: responsible for the softmmu cpu timers state, including cpu clocks and ticks. icount: counts the TCG instructions executed. As such it is specific to the TCG accelerator. Therefore, it is built only under CON

[RFC v4 05/14] cpus: extract out kvm-specific code to accel/kvm

2020-08-11 Thread Claudio Fontana
register a "CpusAccel" interface for KVM as well. Signed-off-by: Claudio Fontana --- accel/kvm/Makefile.objs | 2 ++ accel/kvm/kvm-all.c | 14 +++- accel/kvm/kvm-cpus.c| 88 + accel/kvm/kvm-cpus.h| 17 ++ accel/stubs/kvm-st

[RFC v4 08/14] cpus: extract out hvf-specific code to target/i386/hvf/

2020-08-11 Thread Claudio Fontana
register a "CpusAccel" interface for HVF as well. Signed-off-by: Claudio Fontana Reviewed-by: Roman Bolshakov --- softmmu/cpus.c| 66 - target/i386/hvf/Makefile.objs | 2 +- target/i386/hvf/hvf-cpus.c| 131 ++ ta

[RFC v4 04/14] cpus: extract out qtest-specific code to accel/qtest

2020-08-11 Thread Claudio Fontana
register a "CpusAccel" interface for qtest as well. Signed-off-by: Claudio Fontana --- MAINTAINERS | 2 +- accel/Makefile.objs | 2 +- accel/qtest/Makefile.objs | 2 ++ accel/qtest/qtest-cpus.c | 91 +++ accel/qtest/qtest-cpus.h

[RFC v4 00/14] QEMU cpus.c refactoring part2

2020-08-11 Thread Claudio Fontana
Motivation and higher level steps: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg04628.html RFC v3 -> v4: * added patch 9: cleanup unneeded includes * added patch 10: add handle_interrupt to the interface (Roman) * added patch 11-14: remove accelerator specific internal functions

[RFC v4 09/14] cpus: cleanup now unneeded includes

2020-08-11 Thread Claudio Fontana
Signed-off-by: Claudio Fontana --- softmmu/cpus.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index f99942fd9d..1125fb5fc9 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -29,20 +29,13 @@ #include "qapi/qapi-commands-misc.h" #include "qapi/qapi-

[RFC v4 10/14] cpus: add handle_interrupt to the CpusAccel interface

2020-08-11 Thread Claudio Fontana
kvm: uses the generic handler qtest: uses the generic handler whpx: changed to use the generic handler (identical implementation) hax: changed to use the generic handler (identical implementation) hvf: changed to use the generic handler (identical implementation) tcg: adapt tcg-cpus to point to the

[RFC v4 02/14] cpus: prepare new CpusAccel cpu accelerator interface

2020-08-11 Thread Claudio Fontana
The new interface starts unused, will start being used by the next patches. It provides methods for each accelerator to start a vcpu, kick a vcpu, synchronize state, get cpu virtual clock and elapsed ticks. In qemu_wait_io_event, make it clear that APC is used only for HAX on Windows. Signed-off

[PATCH] hw: add a number of SPI-flash's of m25p80 family

2020-08-11 Thread Igor Kononenko
Support a following SPI flashes: * mx66l51235f * mt25ql512ab Signed-off-by: Igor Kononenko --- hw/block/m25p80.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 8227088441..bf1f833784 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -219

[PATCH] arm: aspeed: add strap define `25HZ` of AST2500

2020-08-11 Thread Igor Kononenko
Provide a definition for the "25Hz reference clock input mode" strap Signed-off-by: Igor Kononenko --- include/hw/misc/aspeed_scu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/misc/aspeed_scu.h b/include/hw/misc/aspeed_scu.h index a6739bb846..9cd530afa2 100644 --- a/include/hw

Re: [PATCH v2 2/8] linux-user: add missing UDP get/setsockopt option

2020-08-11 Thread Shu-Chun Weng
It does look like something that can be improved. The lines have been there for 14 years though: https://github.com/qemu/qemu/commit/53a5960aadd542dd27b8705ac30df154557d5ffc The potential bug is triggered when the user passes in a 2-byte integer in getsockopt(), which seems uncommon -- do we have

Re: [RFC v3 0/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-11 Thread Peter Xu
Hi, Eugenio, On Tue, Aug 11, 2020 at 08:10:44PM +0200, Eugenio Perez Martin wrote: > Using this patch as a reference, I'm having problems to understand: > > - I'm not sure that the flag name expresses clearly the notifier capability. The old code is kind of messed up for dev-iotlb invalidations,

Re: [PATCH V1 00/32] Live Update

2020-08-11 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Jul 31, 2020 at 11:27:45AM -0400, Steven Sistare wrote: > > On 7/31/2020 4:53 AM, Daniel P. Berrangé wrote: > > > On Thu, Jul 30, 2020 at 02:48:44PM -0400, Steven Sistare wrote: > > >> On 7/30/2020 12:52 PM, Daniel P. Berrangé wrote: >

[Bug 1825002] Re: "qemu: Unexpected FPU mode" since 0c1bbedc10e86ea9366b6af8c5520fafa3266b2f

2020-08-11 Thread Carlo Marcelo Arenas Belón
FWIW I am still seeing a similar failure with 5.1.0rc3 (using a "Hello World" like program in Ubuntu 20.04 x86_64 built statically): $ mipsisa32r6el-linux-gnu-gcc --static -o h h.c $ ./qemu-mipsn32el ./h qemu: Unexpected FPU mode big endian also seems to be affected -- You received this bug not

Re: [PATCH 2/4] qom: provide convenient macros for declaring and defining types

2020-08-11 Thread Eduardo Habkost
I've just noticed this: On Thu, Jul 23, 2020 at 07:14:08PM +0100, Daniel P. Berrangé wrote: > When creating new QOM types, there is a lot of boilerplate code that > must be repeated using a standard pattern. This is tedious to write > and liable to suffer from subtle inconsistencies. Thus it woul

Re: [RFC PATCH 3/3] util/vfio-helpers: Let qemu_vfio_pci_init_irq take IRQ index argument

2020-08-11 Thread Alex Williamson
On Tue, 11 Aug 2020 19:28:45 +0200 Philippe Mathieu-Daudé wrote: > Add a new 'index' argument to qemu_vfio_pci_init_irq() to be able > to initialize other IRQs than IRQ #0. Adapt the single user of this > API in nvme_init(). This is actually addressing the what the vfio uAPI refers to as the sub

Re: [RFC PATCH 2/3] util/vfio-helpers: Add trace event to display device IRQs available

2020-08-11 Thread Alex Williamson
On Tue, 11 Aug 2020 19:28:44 +0200 Philippe Mathieu-Daudé wrote: > Add a trace event to display the amount of IRQs available > on the device. > > Signed-off-by: Philippe Mathieu-Daudé > --- > util/vfio-helpers.c | 1 + > util/trace-events | 1 + > 2 files changed, 2 insertions(+) > > diff -

Re: [RFC v3 0/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-11 Thread Eugenio Perez Martin
On Tue, Aug 11, 2020 at 7:56 PM Eugenio Pérez wrote: > > I am able to hit this assertion when a Red Hat 7 guest virtio_net device > raises an "Invalidation" of all the TLB entries. This happens in the > guest's startup if 'intel_iommu=on' argument is passed to the guest > kernel and right IOMMU/AT

[RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

2020-08-11 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/virtio/vhost.c | 2 +- include/exec/memory.h | 2 ++ softmmu/memory.c | 10 -- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 1a1384e7a6..e74ad9e09b 100644 --- a/hw/virtio/vhost.c +

[RFC v3 0/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-11 Thread Eugenio Pérez
I am able to hit this assertion when a Red Hat 7 guest virtio_net device raises an "Invalidation" of all the TLB entries. This happens in the guest's startup if 'intel_iommu=on' argument is passed to the guest kernel and right IOMMU/ATS devices are declared in qemu's command line. Command line: /h

Re: [PATCH 2/2] spapr/nvram: Allocate enough space for all -prom-env options

2020-08-11 Thread Greg Kurz
On Tue, 11 Aug 2020 19:27:50 +0200 Laurent Vivier wrote: > On 11/08/2020 18:36, Greg Kurz wrote: > > On Tue, 11 Aug 2020 18:05:21 +0200 > > Laurent Vivier wrote: > > > >> On 11/08/2020 17:30, Greg Kurz wrote: > >>> Since commit 61f20b9dc5b7 ("spapr_nvram: Pre-initialize the NVRAM to > >>> suppo

Re: [RFC PATCH 0/3] util/vfio-helpers: Fixes to allow using multiple IRQs

2020-08-11 Thread Philippe Mathieu-Daudé
On 8/11/20 7:28 PM, Philippe Mathieu-Daudé wrote: > A pair of fixes to allow binding notifiers on different IRQs > (NVMe block driver series will follow). > > Philippe Mathieu-Daudé (3): > util/vfio-helpers: Store eventfd using int32_t type > util/vfio-helpers: Add trace event to display devic

[RFC PATCH 3/3] util/vfio-helpers: Let qemu_vfio_pci_init_irq take IRQ index argument

2020-08-11 Thread Philippe Mathieu-Daudé
Add a new 'index' argument to qemu_vfio_pci_init_irq() to be able to initialize other IRQs than IRQ #0. Adapt the single user of this API in nvme_init(). Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/vfio-helpers.h | 2 +- block/nvme.c| 2 +- util/vfio-helpers.c

[RFC PATCH 2/3] util/vfio-helpers: Add trace event to display device IRQs available

2020-08-11 Thread Philippe Mathieu-Daudé
Add a trace event to display the amount of IRQs available on the device. Signed-off-by: Philippe Mathieu-Daudé --- util/vfio-helpers.c | 1 + util/trace-events | 1 + 2 files changed, 2 insertions(+) diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c index 6defefcc01..3ad7e6be52 100644 --

[RFC PATCH 0/3] util/vfio-helpers: Fixes to allow using multiple IRQs

2020-08-11 Thread Philippe Mathieu-Daudé
A pair of fixes to allow binding notifiers on different IRQs (NVMe block driver series will follow). Philippe Mathieu-Daudé (3): util/vfio-helpers: Store eventfd using int32_t type util/vfio-helpers: Add trace event to display device IRQs available util/vfio-helpers: Let qemu_vfio_pci_init_i

[RFC PATCH 1/3] util/vfio-helpers: Store eventfd using int32_t type

2020-08-11 Thread Philippe Mathieu-Daudé
Per the documentation in linux-headers/linux/vfio.h: VFIO_DEVICE_SET_IRQS * DATA_EVENTFD binds the specified ACTION to the provided __s32 eventfd. Replace the 'int' by an 'int32_t' to match the documentation. Fixes: 418026ca43 ("util: Introduce vfio helpers") Signed-off-by: Philippe Mathieu-D

Re: [PATCH 2/2] spapr/nvram: Allocate enough space for all -prom-env options

2020-08-11 Thread Laurent Vivier
On 11/08/2020 18:36, Greg Kurz wrote: > On Tue, 11 Aug 2020 18:05:21 +0200 > Laurent Vivier wrote: > >> On 11/08/2020 17:30, Greg Kurz wrote: >>> Since commit 61f20b9dc5b7 ("spapr_nvram: Pre-initialize the NVRAM to >>> support the -prom-env parameter"), pseries machines can pre-initialize >>> the

Re: [PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-11 Thread Alexander Bulekov
On 200811 1916, Paolo Bonzini wrote: > On 11/08/20 19:12, Alexander Bulekov wrote: > > On 200811 1825, Philippe Mathieu-Daudé wrote: > >> On 8/11/20 6:20 PM, Philippe Mathieu-Daudé wrote: > >>> On 8/10/20 7:08 PM, Paolo Bonzini wrote: > Move the create-config logic to meson.build; create a > >

Re: [PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-11 Thread Paolo Bonzini
On 11/08/20 18:25, Philippe Mathieu-Daudé wrote: > Alexander reported [*] a problem when ARRAY_SIZE(whitelist_rw) == 0 you > access an undefined address: But that's not accessing an undefined address, it's taking the address past the last item---which should be okay. And I cannot reproduce it wit

Re: [PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-11 Thread Paolo Bonzini
On 11/08/20 19:12, Alexander Bulekov wrote: > On 200811 1825, Philippe Mathieu-Daudé wrote: >> On 8/11/20 6:20 PM, Philippe Mathieu-Daudé wrote: >>> On 8/10/20 7:08 PM, Paolo Bonzini wrote: Move the create-config logic to meson.build; create a configuration_data object and let meson handl

Re: [PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-11 Thread Alexander Bulekov
On 200811 1825, Philippe Mathieu-Daudé wrote: > On 8/11/20 6:20 PM, Philippe Mathieu-Daudé wrote: > > On 8/10/20 7:08 PM, Paolo Bonzini wrote: > >> Move the create-config logic to meson.build; create a > >> configuration_data object and let meson handle the > >> quoting and output. > >> > >> Signed

Re: [PATCH] iotests/259: Fix reference output

2020-08-11 Thread Eric Blake
On 8/11/20 10:54 AM, Nir Soffer wrote: On Tue, Aug 11, 2020 at 11:08 AM Max Reitz wrote: The error message has changed recently, breaking the test. Fix it. Fixes: a2b333c01880f56056d50c238834d62e32001e54 ("block: nbd: Fix convert qcow2 compressed to nbd") Thanks for fixing this. I

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-11 Thread Eugenio Perez Martin
On Tue, Aug 11, 2020 at 7:01 PM Eugenio Perez Martin wrote: > > On Fri, Jun 26, 2020 at 11:29 PM Peter Xu wrote: > > > > Hi, Eugenio, > > > > (CCing Eric, Yan and Michael too) > > > > On Fri, Jun 26, 2020 at 08:41:22AM +0200, Eugenio Pérez wrote: > > > diff --git a/memory.c b/memory.c > > > index

Re: [PATCH v4 6/9] spapr_pci: add spapr msi read method

2020-08-11 Thread P J P
+-- On Tue, 11 Aug 2020, Philippe Mathieu-Daudé wrote --+ | Cc'ing PCI maintainers ... | > +.read = spapr_msi_read, | | Shouldn't this be a read_with_attrs handler returning MEMTX_ERROR | instead? Maybe we need another MemTxResult which does not yet exist. Could this be a subsequent new patch

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-11 Thread Eugenio Perez Martin
On Fri, Jun 26, 2020 at 11:29 PM Peter Xu wrote: > > Hi, Eugenio, > > (CCing Eric, Yan and Michael too) > > On Fri, Jun 26, 2020 at 08:41:22AM +0200, Eugenio Pérez wrote: > > diff --git a/memory.c b/memory.c > > index 2f15a4b250..7f789710d2 100644 > > --- a/memory.c > > +++ b/memory.c > > @@ -1915

Re: [PATCH 7/7] target/arm/cpu: spe: Enable spe to work with host cpu

2020-08-11 Thread Andrew Jones
On Tue, Aug 11, 2020 at 11:15:42AM +0800, Haibo Xu wrote: > > > +if (!cpu->has_spe || !kvm_enabled()) { > > > +unset_feature(env, ARM_FEATURE_SPE); > > > +} > > > > I don't think this should be necessary. > > > > Yes, I have tried to remove this check, and the vSPE can still work >

[PATCH v4 1/5] linux-user: Make cpu_env accessible in strace.c

2020-08-11 Thread Filip Bozuta
Variable "cpu_env" is used in file "syscall.c" to store the information about the cpu environment. This variable is used because values of some syscalls can vary between cpu architectures. This patch makes the "cpu_env" accessible in "strace.c" so it can enable aproppriate "-strace" argument printi

[PATCH v4 3/5] linux-user: Add strace support for printing arguments of syscalls used to lock and unlock memory

2020-08-11 Thread Filip Bozuta
This patch implements strace argument printing functionality for following syscalls: * mlock, munlock, mlockall, munlockall - lock and unlock memory int mlock(const void *addr, size_t len) int munlock(const void *addr, size_t len) int mlockall(int flags) int munlo

[PATCH v4 5/5] linux-user: Add strace support for printing arguments of some clock and time functions

2020-08-11 Thread Filip Bozuta
This patch implements strace argument printing functionality for following syscalls: * clock_getres, clock_gettime, clock_settime - clock and time functions int clock_getres(clockid_t clockid, struct timespec *res) int clock_gettime(clockid_t clockid, struct timespec *tp)

[PATCH v4 4/5] linux-user: Add an api to print enumareted argument values with strace

2020-08-11 Thread Filip Bozuta
This patch introduces a type 'struct enums' and function 'print_enums()' that can be used to print enumerated argument values of some syscalls in strace. This can be used in future strace implementations. Also, macros 'ENUM_GENERIC()', 'ENUM_TARGET()' and 'ENUM_END', are introduced to enable autom

[PATCH v4 0/5] Add strace support for printing arguments for a group of selected syscalls

2020-08-11 Thread Filip Bozuta
This series covers strace support for following syscalls: *truncate() *munlock() *clock_gettimeofday() *ftruncate()*munlockall() *clock_getitimer() *getsid() *clock_getres() *clock_setitimer() *mlock()*clock_gettime() *mlockall() *clock_s

[PATCH v4 2/5] linux-user: Add strace support for printing arguments of truncate()/ftruncate() and getsid()

2020-08-11 Thread Filip Bozuta
This patch implements strace argument printing functionality for following syscalls: * truncate, ftruncate - truncate a file to a specified length int truncate/truncate64(const char *path, off_t length) int ftruncate/ftruncate64(int fd, off_t length) man page: https:/

Re: [PATCH 6/7] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-08-11 Thread Andrew Jones
On Tue, Aug 11, 2020 at 10:38:02AM +0800, Haibo Xu wrote: > On Mon, 10 Aug 2020 at 19:05, Andrew Jones wrote: > > > > On Fri, Aug 07, 2020 at 08:10:36AM +, Haibo Xu wrote: > > > Add a virtual SPE device for virt machine while using PPI > > > 5 for SPE overflow interrupt number. > > > > Any rea

Re: [PATCH 2/2] spapr/nvram: Allocate enough space for all -prom-env options

2020-08-11 Thread Greg Kurz
On Tue, 11 Aug 2020 18:05:21 +0200 Laurent Vivier wrote: > On 11/08/2020 17:30, Greg Kurz wrote: > > Since commit 61f20b9dc5b7 ("spapr_nvram: Pre-initialize the NVRAM to > > support the -prom-env parameter"), pseries machines can pre-initialize > > the "system" partition in the NVRAM with the dat

Re: [PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-11 Thread Philippe Mathieu-Daudé
On 8/11/20 6:20 PM, Philippe Mathieu-Daudé wrote: > On 8/10/20 7:08 PM, Paolo Bonzini wrote: >> Move the create-config logic to meson.build; create a >> configuration_data object and let meson handle the >> quoting and output. >> >> Signed-off-by: Paolo Bonzini >> --- >> Makefile

Re: [PATCH 139/147] meson: replace create-config with meson configure_file

2020-08-11 Thread Philippe Mathieu-Daudé
On 8/10/20 7:08 PM, Paolo Bonzini wrote: > Move the create-config logic to meson.build; create a > configuration_data object and let meson handle the > quoting and output. > > Signed-off-by: Paolo Bonzini > --- > Makefile | 2 +- > block.c| 4 +-

Re: [PATCH 131/147] meson: link emulators without Makefile.target

2020-08-11 Thread Philippe Mathieu-Daudé
On 8/11/20 4:59 PM, Alexander Bulekov wrote: > Hi Paolo, > I looked through the code changes related to fuzzing and tested the > following builds: > - qemu-fuzz-i386 > - qemu-fuzz-arm > - qemu-system-i386 (with --enable-fuzzing) > - configure --enable-fuzzing with GCC (should fail) > - ./scrip

Re: [PATCH 114/147] meson: convert hw/gpio

2020-08-11 Thread Philippe Mathieu-Daudé
On 8/10/20 7:08 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé > --- > hw/Makefile.objs | 1 - > hw/gpio/Makefile.objs | 12 > hw/gpio/meson.build | 12 ++

Re: [PATCH v2] CODING_STYLE.rst: flesh out our naming conventions.

2020-08-11 Thread Cornelia Huck
On Tue, 11 Aug 2020 17:55:08 +0200 Philippe Mathieu-Daudé wrote: > Hi Alex, > > On 8/10/20 12:51 PM, Alex Bennée wrote: > > Mention a few of the more common naming conventions we follow in the > > code base including common variable names and function prefix and > > suffix examples. > > > > Sig

Re: [PATCH 096/147] meson: convert hw/sd

2020-08-11 Thread Philippe Mathieu-Daudé
On 8/10/20 7:08 PM, Paolo Bonzini wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini This one already has: Reviewed-by: Philippe Mathieu-Daudé https://www.mail-archive.com/qemu-devel@nongnu.org/msg728253.html > --- > hw/Makefile.objs|

Re: [PATCH 2/2] spapr/nvram: Allocate enough space for all -prom-env options

2020-08-11 Thread Laurent Vivier
On 11/08/2020 17:30, Greg Kurz wrote: > Since commit 61f20b9dc5b7 ("spapr_nvram: Pre-initialize the NVRAM to > support the -prom-env parameter"), pseries machines can pre-initialize > the "system" partition in the NVRAM with the data passed to all -prom-env > parameters on the QEMU command line. >

Re: [PATCH 007/147] tests/vm: do not pollute configure with --efi-aarch64

2020-08-11 Thread Philippe Mathieu-Daudé
+Robert in case. On 8/10/20 7:06 PM, Paolo Bonzini wrote: > Just make EFI_AARCH64 a variable in the makefile that defaults to the efi > firmware included with QEMU. It can be redefined on the "make" command > line. > > Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH] iotests/259: Fix reference output

2020-08-11 Thread Nir Soffer
On Tue, Aug 11, 2020 at 11:08 AM Max Reitz wrote: > The error message has changed recently, breaking the test. Fix it. > > Fixes: a2b333c01880f56056d50c238834d62e32001e54 >("block: nbd: Fix convert qcow2 compressed to nbd") > Thanks for fixing this. I thought that I ran all the tests wh

Re: [PATCH v2] CODING_STYLE.rst: flesh out our naming conventions.

2020-08-11 Thread Philippe Mathieu-Daudé
Hi Alex, On 8/10/20 12:51 PM, Alex Bennée wrote: > Mention a few of the more common naming conventions we follow in the > code base including common variable names and function prefix and > suffix examples. > > Signed-off-by: Alex Bennée > > --- ... > +Function Naming Conventions > +---

Re: [PATCH-for-5.2 0/3] trivial: Remove 'and and' in descriptions

2020-08-11 Thread Li Qiang
Philippe Mathieu-Daudé 于2020年8月11日周二 下午11:17写道: > > Remove duplicated 'and' in comments. > > Philippe Mathieu-Daudé (3): > hw/i2c: Fix typo in description > util/qemu-timer: Fix typo in description > util/vfio-helpers: Fix typo in description > For this series: Reviewed-by: Li Qiang > i

Re: [PATCH v4 4/9] prep: add ppc-parity write method

2020-08-11 Thread Li Qiang
P J P 于2020年8月11日周二 下午7:44写道: > > From: Prasad J Pandit > > Add ppc-parity mmio write method to avoid NULL pointer dereference > issue. > > Reported-by: Lei Sun > Acked-by: David Gibson > Signed-off-by: Prasad J Pandit Reviewed-by: Li Qiang > --- > hw/ppc/prep_systemio.c | 8 > 1

Re: [PATCH 000/147] Meson integration for 5.2

2020-08-11 Thread Stefano Garzarella
On Mon, Aug 10, 2020 at 07:06:38PM +0200, Paolo Bonzini wrote: > This version is substantially less "draft-like", and the diffstat > is actually quite large with Thursday's draft. > > The changes are as follows: > - updated oss-fuzz build script > - various cases fixed that broke depending on pres

Re: [PATCH v4 5/9] nvram: add nrf51_soc flash read method

2020-08-11 Thread Li Qiang
P J P 于2020年8月11日周二 下午7:44写道: > > From: Prasad J Pandit > > Add nrf51_soc mmio read method to avoid NULL pointer dereference > issue. > > Reported-by: Lei Sun > Reviewed-by: Peter Maydell > Signed-off-by: Prasad J Pandit Reviewed-by: Li Qiang > --- > hw/nvram/nrf51_nvm.c | 10 ++ >

Re: [PATCH v4 7/9] tz-ppc: add dummy read/write methods

2020-08-11 Thread Li Qiang
P J P 于2020年8月11日周二 下午7:44写道: > > From: Prasad J Pandit > > Add tz-ppc-dummy mmio read/write methods to avoid assert failure > during initialisation. > > Reviewed-by: Peter Maydell > Signed-off-by: Prasad J Pandit Reviewed-by: Li Qiang > --- > hw/misc/tz-ppc.c | 14 ++ > 1 file

[PATCH v2] target/ppc: Integrate icount to purr, vtb, and tbu40

2020-08-11 Thread Gustavo Romero
Currently if option '-icount auto' is passed to the QEMU TCG to enable counting instructions the VM crashes with the following error report when Linux runs on it: qemu-system-ppc64: Bad icount read This happens because read/write access to the SPRs PURR, VTB, and TBU40 is not integrated to the ic

[PATCH 2/2] spapr/nvram: Allocate enough space for all -prom-env options

2020-08-11 Thread Greg Kurz
Since commit 61f20b9dc5b7 ("spapr_nvram: Pre-initialize the NVRAM to support the -prom-env parameter"), pseries machines can pre-initialize the "system" partition in the NVRAM with the data passed to all -prom-env parameters on the QEMU command line. In this cases it is assumed that all the data f

[PATCH 0/2] spapr/nvram: Fix QEMU crash

2020-08-11 Thread Greg Kurz
This series fixes the following crash: $ qemu-system-ppc64 -M pseries $(for ((x=0;x<128;x++)); do \ echo -n " -prom-env "$(for ((y=0;y<1024;y++)); do echo -n x ; done) ; \ done) # this requires ~128 Kib malloc(): corrupted top size Aborted (core dumped) This also affects g3beige and mac99 mac

  1   2   3   >