Re: [PATCH v2 07/12] hw/arm/virt: Move post cpu realize check into its own function

2020-09-08 Thread Haibo Xu
On Tue, 8 Sep 2020 at 19:03, Andrew Jones wrote: > > On Tue, Sep 08, 2020 at 08:13:25AM +, Haibo Xu wrote: > > From: Andrew Jones > > > > We'll add more to this new function in coming patches so we also > > state the gic must be created and call it below create_gic(). > > > > No functional ch

When running test-io-channel-socket on win32, the qemu_aio_context not inited

2020-09-08 Thread Yonggang Luo
qemu_fd_register (c:\work\xemu\qemu\util\main-loop.c:336) qemu_try_set_nonblock (c:\work\xemu\qemu\util\oslib-win32.c:224) qemu_set_nonblock (c:\work\xemu\qemu\util\oslib-win32.c:230) socket_can_bind_connect (c:\work\xemu\qemu\tests\socket-helpers.c:93) socket_check_protocol_support (c:\work\xemu\q

[PATCH] char: the test-char.c are stuck randomly on win32 at function char_socket_client_test

2020-09-08 Thread Yonggang Luo
The line I modified is the place that entering and line exit. And when step into the function main_loop_wait(false); the stack-trace are like this: NtWaitForMultipleObjects (@NtWaitForMultipleObjects:8) WaitForMultipleObjectsEx (@WaitForMultipleObjectsEx:59) g_pattern_match_simple (@g_pattern_matc

[Bug 1894869] Re: Chelsio T4 has old MSIX PBA offset bug

2020-09-08 Thread Nick Bauer
** Description changed: There exists a bug with Chelsio NICs T4 that causes the following error: kvm: -device vfio- pci,host=:83:00.7,id=hostpci1.7,bus=pci.0,addr=0x11.7: vfio :83:00.7: hardware reports invalid configuration, MSIX PBA outside of specified BAR - I was workin

Re: [PULL 28/41] gitlab: add acceptance testing to system builds

2020-09-08 Thread Thomas Huth
On 08/09/2020 21.54, Philippe Mathieu-Daudé wrote: > On Tue, Jul 7, 2020 at 9:14 AM Alex Bennée wrote: >> >> As part of migrating things from Travis to GitLab add the acceptance >> tests. [...] > > Apparently our acceptance image misses netcat: > (22/45) tests/acceptance/migration.py:Migration.t

Re: device compatibility interface for live migration with assigned devices

2020-09-08 Thread Yan Zhao
hi All, Per our previous discussion, there are two main concerns to the previous proposal: (1) it's currently hard for openstack to match mdev types. (2) complicated. so, we further propose below changes: (1) requiring two compatible mdevs to have the same mdev type for now. (though kernel sti

Re: [RFC 1/4] memory: add memory_region_init_io_with_dev interface

2020-09-08 Thread Li Qiang
Gerd Hoffmann 于2020年9月9日周三 下午12:49写道: > > On Wed, Sep 09, 2020 at 10:15:47AM +0800, Jason Wang wrote: > > > > On 2020/9/9 上午12:41, Li Qiang wrote: > > > Currently the MR is not explicitly connecting with its device instead of > > > a opaque. In most situation this opaque is the deivce but it is no

Re: [PATCH 04/16] curses: Fixes curses compiling errors.

2020-09-08 Thread Gerd Hoffmann
On Wed, Sep 09, 2020 at 03:48:08AM +0800, Yonggang Luo wrote: > This is the compiling error: > ../ui/curses.c: In function 'curses_refresh': > ../ui/curses.c:256:5: error: 'next_maybe_keycode' may be used uninitialized > in this function [-Werror=maybe-uninitialized] > 256 | curses2foo(_curs

Re: [PATCH 03/16] configure: Fixes ncursesw detection under msys2/mingw and enable curses

2020-09-08 Thread Gerd Hoffmann
On Wed, Sep 09, 2020 at 03:48:07AM +0800, Yonggang Luo wrote: > The mingw pkg-config are showing following absolute path and contains : as > the separator, > so we must handling : properly. > > -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=199506L > -IC:/CI-Tools/msys64/mingw64/include/ncursesw:-I/usr/i

Re: [RFC 1/4] memory: add memory_region_init_io_with_dev interface

2020-09-08 Thread Gerd Hoffmann
On Wed, Sep 09, 2020 at 10:15:47AM +0800, Jason Wang wrote: > > On 2020/9/9 上午12:41, Li Qiang wrote: > > Currently the MR is not explicitly connecting with its device instead of > > a opaque. In most situation this opaque is the deivce but it is not an > > enforcement. This patch adds a DeviceStat

Re: [RFC 1/4] memory: add memory_region_init_io_with_dev interface

2020-09-08 Thread Li Qiang
Jason Wang 于2020年9月9日周三 上午10:16写道: > > > On 2020/9/9 上午12:41, Li Qiang wrote: > > Currently the MR is not explicitly connecting with its device instead of > > a opaque. In most situation this opaque is the deivce but it is not an > > enforcement. This patch adds a DeviceState member of to MemoryRe

Re: [RFC 0/4] Add a 'in_mmio' device flag to avoid the DMA to MMIO

2020-09-08 Thread Li Qiang
Jason Wang 于2020年9月9日周三 上午10:17写道: > > > On 2020/9/9 上午12:41, Li Qiang wrote: > > Currently the qemu device fuzzer find some DMA to MMIO issue. If the > > device handling MMIO currently trigger a DMA which the address is MMIO, > > this will reenter the device MMIO handler. As some of the device do

Re: [PATCH v2 12/12] target/arm: spe: Add corresponding doc and test.

2020-09-08 Thread Haibo Xu
On Tue, 8 Sep 2020 at 19:41, Andrew Jones wrote: > > On Tue, Sep 08, 2020 at 08:13:30AM +, Haibo Xu wrote: > > Signed-off-by: Haibo Xu > > --- > > docs/system/arm/cpu-features.rst | 20 > > target/arm/monitor.c | 2 +- > > tests/qtest/arm-cpu-features.c |

答复: [PATCH] ide:do nothing for identify cmd if no any device attached

2020-09-08 Thread RockCui-oc
Hi John & Max, 1. Follow my Log,there are 1 read 0x1x7 ops. On my Intel I5 platform, if down the frequency to 1.2G, you can see a obviously lag during WINDOWS LOGO animation playing. 2. We must supply a CD-ROM to our VDI users. 3. In ide_ioport_read() : ---

Re: [PATCH v2 11/12] target/arm/kvm: spe: Enable userspace irqchip support.

2020-09-08 Thread Haibo Xu
On Tue, 8 Sep 2020 at 19:35, Andrew Jones wrote: > > On Tue, Sep 08, 2020 at 08:13:29AM +, Haibo Xu wrote: > > Since the current kernel patches haven't enabled the > > userspace irqchip support, this patch is not verified yet! > > > > Signed-off-by: Haibo Xu > > --- > > linux-headers/linux/k

Re: [PATCH v4 7/7] tests/qtest/vhost-user-test: enable the reconnect tests

2020-09-08 Thread Raphael Norwitz
This works for me, and looks good, but I figure those who added the check should confirm that these tests are reliable now. Marc-Andre - thoughts? On Fri, Sep 4, 2020 at 5:36 AM Dima Stepanov wrote: > > For now a QTEST_VHOST_USER_FIXME environment variable is used to > separate reconnect tests f

Re: [PATCH v4 6/7] tests/qtest/vhost-user-test: add migrate_reconnect test

2020-09-08 Thread Raphael Norwitz
On Fri, Sep 4, 2020 at 5:36 AM Dima Stepanov wrote: > > Add new migrate_reconnect test for the vhost-user-blk device. Perform a > disconnect after sending response for the VHOST_USER_SET_LOG_BASE > command. > > Signed-off-by: Dima Stepanov Reviewed-by: Raphael Norwitz > --- > tests/qtest/vho

Re: [PATCH v4 5/7] tests/qtest/vhost-user-test: add support for the vhost-user-blk device

2020-09-08 Thread Raphael Norwitz
On Fri, Sep 4, 2020 at 5:35 AM Dima Stepanov wrote: > > Add vhost_user_ops structure for the vhost-user-blk device class. Add > the test_reconnect and test_migrate tests for this device. > > Signed-off-by: Dima Stepanov Reviewed-by: Raphael Norwitz Just one small suggestion. > --- > tests/qt

Re: [PATCH v4 4/7] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

2020-09-08 Thread Raphael Norwitz
On Fri, Sep 4, 2020 at 5:34 AM Dima Stepanov wrote: > > Add support for the vhost-user-blk-pci device. This node can be used by > the vhost-user-blk tests. Tests for the vhost-user-blk device are added > in the following patches. > > Signed-off-by: Dima Stepanov > --- > tests/qtest/libqos/virtio

Re: [PATCH v4 3/7] tests/qtest/vhost-user-test: prepare the tests for adding new dev class

2020-09-08 Thread Raphael Norwitz
On Fri, Sep 4, 2020 at 5:32 AM Dima Stepanov wrote: > > For now only vhost-user-net device is supported by the test. Other > vhost-user devices are not tested. As a first step make source code > refactoring so new devices can reuse the same test routines. To make > this provide a new vhost_user_op

Re: [PATCH V2 for-5.2] hw/null-machine: Add the kvm_type() hook for MIPS

2020-09-08 Thread chen huacai
Hi, all, On Wed, Sep 9, 2020 at 1:25 AM Thomas Huth wrote: > > On 24/08/2020 10.11, Huacai Chen wrote: > > MIPS has two types of KVM: TE & VZ, and TE is the default type. Now, > > libvirt uses a null-machine to detect the kvm capability. In the MIPS > > case, it will return "KVM not supported" on

Re: [PATCH v4 2/7] vhost: check queue state in the vhost_dev_set_log routine

2020-09-08 Thread Raphael Norwitz
On Fri, Sep 4, 2020 at 5:32 AM Dima Stepanov wrote: > > If the vhost-user-blk daemon provides only one virtqueue, but device was > added with several queues, then QEMU will send more VHOST-USER command > than expected by daemon side. The vhost_virtqueue_start() routine > handles such case by check

[Bug 1894818] Re: COLO's guest VNC client hang after failover

2020-09-08 Thread Derek Su
Hi, I also tested some emulated nic devices and virtio network devices (in the attachment). The VNC client's screen cannot be recovered while using all virtio network devices and the emulated e1000e nic. Thanks. Regards, Derek ** Attachment added: "截圖 2020-09-09 上午10.39.09.png" https://bu

Re: [PATCH v2 05/12] target/arm/kvm: spe: Unify device attr operation helper

2020-09-08 Thread Haibo Xu
On Tue, 8 Sep 2020 at 18:56, Andrew Jones wrote: > > On Tue, Sep 08, 2020 at 08:13:23AM +, Haibo Xu wrote: > > From: Andrew Jones > > > > Rename kvm_arm_pmu_set_attr() to kvm_arm_set_device_attr(), > > So both the vPMU and vSPE device can share the same API. > > > > Signed-off-by: Andrew Jone

Re: [RFC 0/4] Add a 'in_mmio' device flag to avoid the DMA to MMIO

2020-09-08 Thread Jason Wang
On 2020/9/9 上午12:41, Li Qiang wrote: Currently the qemu device fuzzer find some DMA to MMIO issue. If the device handling MMIO currently trigger a DMA which the address is MMIO, this will reenter the device MMIO handler. As some of the device doesn't consider this it will sometimes crash the qe

Re: [RFC 1/4] memory: add memory_region_init_io_with_dev interface

2020-09-08 Thread Jason Wang
On 2020/9/9 上午12:41, Li Qiang wrote: Currently the MR is not explicitly connecting with its device instead of a opaque. In most situation this opaque is the deivce but it is not an enforcement. This patch adds a DeviceState member of to MemoryRegion we will use it in later patch. I don't hav

Re: device compatibility interface for live migration with assigned devices

2020-09-08 Thread Yan Zhao
> > still, I'd like to put it more explicitly to make ensure it's not missed: > > the reason we want to specify compatible_type as a trait and check > > whether target compatible_type is the superset of source > > compatible_type is for the consideration of backward compatibility. > > e.g. > > an o

Re: [PATCH 2/2] vhost-vdpa: improve error reporting

2020-09-08 Thread Jason Wang
On 2020/9/4 上午2:53, Laurent Vivier wrote: Use Error framework to report the id of the device and the details of the error (vhostdev name and errno). For instance: qemu-system-x86_64 ... -netdev vhost-vdpa,id=hostnet1 ... hostnet1: Cannot open '/dev/vhost-vdpa-0': No such file or directory

Re: [PATCH 1/2] vhost-vdpa: define and use default value for vhostdev

2020-09-08 Thread Jason Wang
On 2020/9/4 上午2:53, Laurent Vivier wrote: vhostdev is defined as optional in net.json, and if not set /dev/vhost-vdpa-0 should be used. The default value is not set and if vhostdev is not provided QEMU crashes with a SIGSEGV exception. Fixes: 1e0a84ea49b6 ("vhost-vdpa: introduce vhost-vdpa ne

Re: [PATCH v8 00/14] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines

2020-09-08 Thread Havard Skinnemoen
On Tue, Sep 8, 2020 at 12:52 PM Havard Skinnemoen wrote: > > On Tue, Sep 8, 2020 at 9:58 AM Philippe Mathieu-Daudé wrote: > > > > On 9/8/20 5:52 PM, Philippe Mathieu-Daudé wrote: > > > On 9/8/20 5:02 PM, Alexander Bulekov wrote: > > >> Hi Havard, > > >> I fuzzed the npcm750-evb machine until I hi

[PATCH 39/43] tcg/ppc: Convert to tcg-constr.c.inc

2020-09-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target-constr.h | 37 ++ tcg/ppc/tcg-target.c.inc| 135 +++- 2 files changed, 94 insertions(+), 78 deletions(-) create mode 100644 tcg/ppc/tcg-target-constr.h diff --git a/tcg/ppc/tcg-target-constr.h b

[PATCH 38/43] tcg/mips: Convert to tcg-constr.c.inc

2020-09-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/mips/tcg-target-constr.h | 31 tcg/mips/tcg-target.c.inc| 95 2 files changed, 61 insertions(+), 65 deletions(-) create mode 100644 tcg/mips/tcg-target-constr.h diff --git a/tcg/mips/tcg-target-constr

[PATCH 43/43] tcg/tci: Convert to tcg-constr.c.inc

2020-09-08 Thread Richard Henderson
This does require finishing the conversion to tcg_target_op_def. Remove quite a lot of ifdefs, since we can reference opcodes even if they are not implemented. Signed-off-by: Richard Henderson --- tcg/tci/tcg-target-constr.h | 28 +++ tcg/tci/tcg-target.c.inc| 360 ++

[PATCH 37/43] tcg/arm: Convert to tcg-constr.c.inc

2020-09-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/arm/tcg-target-constr.h | 30 tcg/arm/tcg-target.c.inc| 93 + 2 files changed, 63 insertions(+), 60 deletions(-) create mode 100644 tcg/arm/tcg-target-constr.h diff --git a/tcg/arm/tcg-target-constr.h

[PATCH 42/43] tcg/sparc: Convert to tcg-constr.c.inc

2020-09-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target-constr.h | 27 + tcg/sparc/tcg-target.c.inc| 74 --- 2 files changed, 51 insertions(+), 50 deletions(-) create mode 100644 tcg/sparc/tcg-target-constr.h diff --git a/tcg/sparc/tcg-target-co

[PATCH 36/43] tcg/aarch64: Convert to tcg-constr.c.inc

2020-09-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target-constr.h | 31 tcg/aarch64/tcg-target.c.inc| 85 +++-- 2 files changed, 60 insertions(+), 56 deletions(-) create mode 100644 tcg/aarch64/tcg-target-constr.h diff --git a/tcg/aarch64/tcg-targ

[PATCH 41/43] tcg/s390: Convert to tcg-constr.c.inc

2020-09-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/s390/tcg-target-constr.h | 24 +++ tcg/s390/tcg-target.c.inc| 119 +++ 2 files changed, 76 insertions(+), 67 deletions(-) create mode 100644 tcg/s390/tcg-target-constr.h diff --git a/tcg/s390/tcg-target-constr.h b

[PATCH 35/43] tcg/i386: Convert to tcg-constr.c.inc

2020-09-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target-constr.h | 55 +++ tcg/i386/tcg-target.c.inc| 187 +-- 2 files changed, 121 insertions(+), 121 deletions(-) create mode 100644 tcg/i386/tcg-target-constr.h diff --git a/tcg/i386/tcg-target-cons

[PATCH 31/43] tcg: Remove tcg_gen_dup{8,16,32,64}i_vec

2020-09-08 Thread Richard Henderson
These interfaces have been replaced by tcg_gen_dupi_vec and tcg_constant_vec. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/tcg/tcg-op.h | 4 tcg/tcg-op-vec.c | 20 2 files changed, 24 deletions(-) diff --git a/include/tcg/tcg-op.h b/inclu

[PATCH 33/43] tcg/aarch64: Use tcg_constant_vec with tcg vec expanders

2020-09-08 Thread Richard Henderson
Improve rotrv_vec to reduce "t1 = -v2, t2 = t1 + c" to "t1 = -v, t2 = c - v2". This avoids a serial dependency between t1 and t2. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c.inc | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tcg/aarch64/tcg-targ

[PATCH 40/43] tcg/riscv: Convert to tcg-constr.c.inc

2020-09-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target-constr.h | 25 +++ tcg/riscv/tcg-target.c.inc| 82 ++- 2 files changed, 49 insertions(+), 58 deletions(-) create mode 100644 tcg/riscv/tcg-target-constr.h diff --git a/tcg/riscv/tcg-target-cons

[PATCH 30/43] tcg/i386: Use tcg_constant_vec with tcg vec expanders

2020-09-08 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tcg/i386/tcg-target.c.inc b/tcg/i386/tcg-target.c.inc index 819ee25cff..36a90e7ef3 100644 --- a/tcg/i386/tcg-ta

[PATCH 23/43] tcg: Use tcg_constant_i32 with icount expander

2020-09-08 Thread Richard Henderson
We must do this before we adjust tcg_out_movi_i32, lest the under-the-hood poking that we do for icount be broken. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --gi

[PATCH 29/43] tcg: Add tcg_reg_alloc_dup2

2020-09-08 Thread Richard Henderson
There are several ways we can expand a vector dup of a 64-bit element on a 32-bit host. Signed-off-by: Richard Henderson --- tcg/tcg.c | 97 +++ 1 file changed, 97 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c index f9c6450837..507c95cd39 1

[PATCH 27/43] tcg/tci: Add special tci_movi_{i32,i64} opcodes

2020-09-08 Thread Richard Henderson
The normal movi opcodes are going away. We need something for TCI to use internally. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/tcg/tcg-opc.h| 8 tcg/tci.c| 4 ++-- tcg/tci/tcg-target.c.inc | 4 ++-- 3 files changed, 12 insertions(+), 4 d

[PATCH 17/43] tcg: Expand TempOptInfo to 64-bits

2020-09-08 Thread Richard Henderson
This propagates the extended value of TCGTemp.val that we did before. In addition, it will be required for vector constants. Signed-off-by: Richard Henderson --- tcg/optimize.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/tcg/opti

[PATCH 32/43] tcg/ppc: Use tcg_constant_vec with tcg vec expanders

2020-09-08 Thread Richard Henderson
Improve expand_vec_shi to use sign-extraction for MO_32. This allows a single VSPLTISB instruction to load all of the valid shift constants. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c.inc | 44 1 file changed, 27 insertions(+), 17 deletions

[PATCH 22/43] tcg: Convert tcg_gen_dupi_vec to TCG_CONST

2020-09-08 Thread Richard Henderson
Because we now store uint64_t in TCGTemp, we can now always store the full 64-bit duplicate immediate. So remove the difference between 32- and 64-bit hosts. Signed-off-by: Richard Henderson --- tcg/optimize.c | 9 - tcg/tcg-op-vec.c | 39 ++- tcg/

[PATCH 20/43] tcg/optimize: Adjust TempOptInfo allocation

2020-09-08 Thread Richard Henderson
Do not allocate a large block for indexing. Instead, allocate for each temporary as they are seen. In general, this will use less memory, if we consider that most TBs do not touch every target register. This also allows us to allocate TempOptInfo for new temps created during optimization. Revie

[PATCH 13/43] tcg: Consolidate 3 bits into enum TCGTempKind

2020-09-08 Thread Richard Henderson
The temp_fixed, temp_global, temp_local bits are all related. Combine them into a single enumeration. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 20 +--- tcg/optimize.c| 8 +-- tcg/tcg.c | 122

[PATCH 26/43] tcg: Use tcg_constant_{i32, i64, vec} with gvec expanders

2020-09-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 1 + tcg/tcg-op-gvec.c | 125 ++ tcg/tcg.c | 8 +++ 3 files changed, 58 insertions(+), 76 deletions(-) diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h index aa7b0ba163..309460704a

[PATCH 19/43] tcg/optimize: Improve find_better_copy

2020-09-08 Thread Richard Henderson
Prefer TEMP_CONST over anything else. Signed-off-by: Richard Henderson --- tcg/optimize.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index c0fd65d2e4..bf2c2a3ce5 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.

[PATCH 09/43] tcg/optimize: Fold dup2_vec

2020-09-08 Thread Richard Henderson
When the two arguments are identical, this can be reduced to dup_vec or to mov_vec from a tcg_constant_vec. Signed-off-by: Richard Henderson --- tcg/optimize.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 53aa8e5329..220f4601d5 100644

[PATCH 34/43] tcg: Add tcg-constr.c.inc

2020-09-08 Thread Richard Henderson
Begin conversion of constraints to pre-validated, read-only entities. To begin, create a simple method by which sets of TCGTargetOpDef structures may be declared and used. This simplifies each host's tcg_target_op_def function and ensures that we have a collected set of constraints. Signed-off-by

[PATCH 25/43] tcg: Use tcg_constant_{i32,i64} with tcg plugins

2020-09-08 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- accel/tcg/plugin-gen.c | 49 +++--- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 51580d51a0..e5dc9d0ca9 100644 --- a/accel/tc

[PATCH 28/43] tcg: Remove movi and dupi opcodes

2020-09-08 Thread Richard Henderson
These are now completely covered by mov from a TYPE_CONST temporary. Reviewed-by: Alex Bennée Reviewed-by: Aleksandar Markovic Signed-off-by: Richard Henderson --- include/tcg/tcg-opc.h| 3 --- tcg/optimize.c | 4 tcg/tcg-op-vec.c | 1 - tcg/tcg.c

[PATCH 08/43] tcg: Fix generation of dupi_vec for 32-bit host

2020-09-08 Thread Richard Henderson
The definition of INDEX_op_dupi_vec is that it operates on units of tcg_target_ulong -- in this case 32 bits. It does not work to use this for a uint64_t value that happens to be small enough to fit in tcg_target_ulong. Fixes: d2fd745fe8b Fixes: db432672dc5 Cc: qemu-sta...@nongnu.org Signed-off-b

[PATCH 16/43] tcg: Rename struct tcg_temp_info to TempOptInfo

2020-09-08 Thread Richard Henderson
Fix this name vs our coding style. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/optimize.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 3cffd

[PATCH 21/43] tcg/optimize: Use tcg_constant_internal with constant folding

2020-09-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/optimize.c | 108 ++--- 1 file changed, 49 insertions(+), 59 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index e269962932..1eda7dc419 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -178,37 +17

[PATCH 24/43] tcg: Use tcg_constant_{i32,i64} with tcg int expanders

2020-09-08 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/tcg/tcg-op.h | 13 +-- tcg/tcg-op.c | 227 --- 2 files changed, 109 insertions(+), 131 deletions(-) diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h index 5abf17fecc..b4fba35e87 100644 --- a/inc

[PATCH 14/43] tcg: Add temp_readonly

2020-09-08 Thread Richard Henderson
In most, but not all, places that we check for TEMP_FIXED, we are really testing that we do not modify the temporary. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 5 + tcg/tcg.c | 21 ++--- 2

[PATCH 07/43] tcg/i386: Fix dupi for avx2 32-bit hosts

2020-09-08 Thread Richard Henderson
The previous change wrongly stated that 32-bit avx2 should have used VPBROADCASTW. But that's a 16-bit broadcast and we want a 32-bit broadcast. Fixes: 7b60ef3264e Cc: qemu-sta...@nongnu.org Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 18/43] tcg: Introduce TYPE_CONST temporaries

2020-09-08 Thread Richard Henderson
These will hold a single constant for the duration of the TB. They are hashed, so that each value has one temp across the TB. Not used yet, this is all infrastructure. Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 24 +- tcg/optimize.c| 13 +++- tcg/tcg.c | 195

[PATCH 10/43] tcg: Remove TCG_TARGET_HAS_cmp_vec

2020-09-08 Thread Richard Henderson
The cmp_vec opcode is mandatory; this symbol is unused. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 1 - tcg/i386/tcg-target.h| 1 - tcg/ppc/tcg-target.h | 1 - 3 files changed, 3 deletions(-) diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h index 9bc

[PATCH 12/43] tcg: Increase tcg_out_dupi_vec immediate to int64_t

2020-09-08 Thread Richard Henderson
While we don't store more than tcg_target_long in TCGTemp, we shouldn't be limited to that for code generation. We will be able to use this for INDEX_op_dup2_vec with 2 constants. Also pass along the minimal vece that may be said to apply to the constant. This allows some simplification in the v

[PATCH 06/43] tcg: Remove TCGOpDef.used

2020-09-08 Thread Richard Henderson
The last user of this field disappeared in f69d277ece4. Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h index e8629b58c8..8804a8c4a2 100644 --- a/include/tcg/tcg.h +++ b/include/tcg/tcg.h @@ -1015,

[PATCH 15/43] tcg: Expand TCGTemp.val to 64-bits

2020-09-08 Thread Richard Henderson
This will reduce the differences between 32-bit and 64-bit hosts, allowing full 64-bit constants to be created with the same interface. Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 2 +- tcg/tcg.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/

[PATCH 05/43] tcg: Move some TCG_CT_* bits to TCGArgConstraint bitfields

2020-09-08 Thread Richard Henderson
These are easier to set and test when they have their own fields. Reduce the size of alias_index and sort_index to 4 bits, which is sufficient for TCG_MAX_OP_ARGS. This leaves only the bits indicating constants within the ct field. Move all initialization to allocation time, rather than init indi

[PATCH 11/43] tcg: Use tcg_out_dupi_vec from temp_load

2020-09-08 Thread Richard Henderson
Having dupi pass though movi is confusing and arguably wrong. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/tcg.c| 6 +++- tcg/aarch64/tcg-target.c.inc | 7 tcg/i386/tcg-target.c.inc| 63 tcg/ppc/tcg-target.

[PATCH 02/43] tcg: Drop union from TCGArgConstraint

2020-09-08 Thread Richard Henderson
The union is unused; let "regs" appear in the main structure without the "u.regs" wrapping. Signed-off-by: Richard Henderson --- include/tcg/tcg.h| 4 +--- tcg/tcg.c| 22 +++--- tcg/aarch64/tcg-target.c.inc | 14 +++--- tcg/arm/tcg-target.

[PATCH 03/43] tcg: Move sorted_args into TCGArgConstraint.sort_index

2020-09-08 Thread Richard Henderson
This uses an existing hole in the TCGArgConstraint structure and will be convenient for keeping the data in one place. Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 2 +- tcg/tcg.c | 35 +-- 2 files changed, 18 insertions(+), 19 deletions(-) d

[PATCH 04/43] tcg: Remove TCG_CT_REG

2020-09-08 Thread Richard Henderson
This wasn't actually used for anything, really. All variable operands must accept registers, and which are indicated by the set in TCGArgConstraint.regs. Signed-off-by: Richard Henderson --- include/tcg/tcg.h| 1 - tcg/tcg.c| 15 --- tcg/aarch64/tcg-

[PATCH 00/43] tcg patch queue

2020-09-08 Thread Richard Henderson
This patch collection contains: * A couple of fixes for i386 host vector support. * Some random cleanups cherry-picked from some inactive branches. * A reposting (with fix) of my "better handling of constants" set: https://lists.nongnu.org/archive/html/qemu-devel/2020-05/msg02152.html

[PATCH 01/43] tcg: Adjust simd_desc size encoding

2020-09-08 Thread Richard Henderson
With larger vector sizes, it turns out oprsz == maxsz, and we only need to represent mismatch for oprsz <= 32. We do, however, need to represent larger oprsz and do so without reducing SIMD_DATA_BITS. Reduce the size of the oprsz field and increase the maxsz field. Steal the oprsz value of 24 to

[REPORT] Nightly Performance Tests - Tuesday, September 8, 2020

2020-09-08 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-09-08 22:30:02 End Time (UTC) : 2020-09-08 23:03:19 Execution Time : 0:33:16.914858 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%. -

Re: [PULL 0/3] Sirius/ipxe 20200908 patches

2020-09-08 Thread Peter Maydell
> > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/sirius/ipxe-20200908-pull-request > > for you to fetch changes up to 3e570a9ae9b966362596fd649f2cbcff0b2199c9: > > ipxe: update binaries (2020-09-08 08:08:30 +0200) > > -

[PULL 33/34] vhost-user-vga: Use typedef name for instance_size

2020-09-08 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost Message-Id: <20200824215936.2961951-6-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/display/vhost-user-vga.c | 2 +

[PULL 31/34] lpc_ich9: Use typedef name for instance_size

2020-09-08 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost Message-Id: <20200824215936.2961951-4-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/isa/lpc_ich9.c | 2 +- 1 file

[PULL 19/34] vmgenid: Rename VMGENID_DEVICE to TYPE_VMGENID

2020-09-08 Thread Eduardo Habkost
This will make the type name constant consistent with the name of the type checking macro. Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200902224311.1321159-11-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/acpi/vmgenid.h | 6 +++--- hw/

[PULL 34/34] virtio-vga: Use typedef name for instance_size

2020-09-08 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost Reviewed-by: Gerd Hoffmann Message-Id: <20200824215936.2961951-7-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/di

[PULL 18/34] vfio: Rename VFIO_AP_DEVICE_TYPE to TYPE_VFIO_AP_DEVICE

2020-09-08 Thread Eduardo Habkost
This will make the type name constant consistent with the name of the type checking macro. Signed-off-by: Eduardo Habkost Reviewed-by: Thomas Huth Message-Id: <20200902224311.1321159-9-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/vfio/ap.c | 8 1 file changed, 4 insertio

[PULL 30/34] omap_intc: Use typedef name for instance_size

2020-09-08 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost Message-Id: <20200824215936.2961951-3-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/intc/omap_intc.c | 2 +- 1 fil

[PULL 12/34] Use OBJECT_DECLARE_TYPE where possible

2020-09-08 Thread Eduardo Habkost
Replace DECLARE_OBJ_CHECKERS with OBJECT_DECLARE_TYPE where the typedefs can be safely removed. Generated running: $ ./scripts/codeconverter/converter.py -i \ --pattern=DeclareObjCheckers $(git grep -l '' -- '*.[ch]') Reviewed-by: Daniel P. Berrangé Message-Id: <20200831210740.126168-16-ehabk

[PULL 29/34] xilinx_axidma: Use typedef name for instance_size

2020-09-08 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost Message-Id: <20200824215936.2961951-2-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/dma/xilinx_axidma.c | 4 ++--

[PULL 14/34] gpex: Fix type checking function name

2020-09-08 Thread Eduardo Habkost
This looks like a copy/paste mistake: the instance type checking macro for TYPE_GPEX_ROOT_DEVICE was named MCH_PCI_DEVICE. Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200902224311.1321159-2-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw

[PULL 32/34] xilinx_axienet: Use typedef name for instance_size

2020-09-08 Thread Eduardo Habkost
This makes the code consistent with the rest of QOM code in QEMU, and will make automated conversion to type declaration macros simpler. Signed-off-by: Eduardo Habkost Reviewed-by: Alistair Francis Message-Id: <20200824215936.2961951-5-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw

[PULL 24/34] sabre: Rename SABRE_DEVICE to SABRE

2020-09-08 Thread Eduardo Habkost
Make the type checking macro name consistent with the TYPE_* constant. Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200902224311.1321159-49-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/pci-host/sabre.h | 2 +- hw/pci-host/sabre.c

[PULL 13/34] Use OBJECT_DECLARE_SIMPLE_TYPE when possible

2020-09-08 Thread Eduardo Habkost
Generated using: $ ./scripts/codeconverter/converter.py -i \ --pattern=ObjectDeclareType $(git grep -l '' -- '*.[ch]') Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Message-Id: <20200831210740.126168-19-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/authz

[PULL 27/34] pc87312: Rename TYPE_PC87312_SUPERIO to TYPE_PC87312

2020-09-08 Thread Eduardo Habkost
This will make the type name constant consistent with the name of the type checking macro. Signed-off-by: Eduardo Habkost Reviewed-by: Hervé Poussineau Message-Id: <20200902224311.1321159-21-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/isa/pc87312.h | 4 ++-- hw/isa/pc873

[PULL 23/34] rs6000_mc: Rename RS6000MC_DEVICE to RS6000MC

2020-09-08 Thread Eduardo Habkost
Make the type checking macro name consistent with the TYPE_* constant. Signed-off-by: Eduardo Habkost Reviewed-by: Hervé Poussineau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200902224311.1321159-48-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/ppc/rs6000_mc.c | 4 ++-- 1

[PULL 25/34] usb: Rename USB_SERIAL_DEV to USB_SERIAL

2020-09-08 Thread Eduardo Habkost
Make the type checking macro name consistent with the TYPE_* constant. Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200902224311.1321159-54-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/usb/dev-serial.c | 4 ++-- 1 file changed, 2 insertions(+)

[PULL 28/34] tusb6010: Rename TUSB to TUSB6010

2020-09-08 Thread Eduardo Habkost
Make type checking function name consistent with the TYPE_TUSB6010 constant and QOM type name ("tusb6010"). Suggested-by: Philippe Mathieu-Daudé Suggested-by: "Daniel P. Berrangé" Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200903180128.1523959-9-ehabk...@

[PULL 03/34] qom: provide convenient macros for declaring and defining types

2020-09-08 Thread Eduardo Habkost
From: Daniel P. Berrangé When creating new QOM types, there is a lot of boilerplate code that must be repeated using a standard pattern. This is tedious to write and liable to suffer from subtle inconsistencies. Thus it would benefit from some simple automation. QOM was loosely inspired by GLib'

[PULL 21/34] esp: Rename ESP_STATE to ESP

2020-09-08 Thread Eduardo Habkost
Make the type checking macro name consistent with the TYPE_* constant. Signed-off-by: Eduardo Habkost Reviewed-by: Hervé Poussineau Message-Id: <20200902224311.1321159-40-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/scsi/esp.h | 2 +- hw/dma/sparc32_dma.c | 2 +- hw/m68k

[PULL 22/34] filter-rewriter: Rename FILTER_COLO_REWRITER to FILTER_REWRITER

2020-09-08 Thread Eduardo Habkost
Make the type checking macro name consistent with the TYPE_* constant. Signed-off-by: Eduardo Habkost Reviewed-by: Zhang Chen Message-Id: <20200902224311.1321159-41-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- net/filter-rewriter.c | 18 +- 1 file changed, 9 insertio

[PULL 26/34] vfio: Rename PCI_VFIO to VFIO_PCI

2020-09-08 Thread Eduardo Habkost
Make the type checking macro name consistent with the TYPE_* constant. Signed-off-by: Eduardo Habkost Reviewed-by: Eric Auger Message-Id: <20200902224311.1321159-56-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- hw/vfio/pci.h | 2 +- hw/vfio/pci.c | 22 +++--- 2 files

[PULL 08/34] Delete duplicate QOM typedefs

2020-09-08 Thread Eduardo Habkost
Generated using: $ ./scripts/codeconverter/converter.py -i \ --pattern=QOMDuplicatedTypedefs $(git grep -l '' -- '*.[ch]') Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Message-Id: <20200831210740.126168-8-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/cr

[PULL 16/34] ap-device: Rename AP_DEVICE_TYPE to TYPE_AP_DEVICE

2020-09-08 Thread Eduardo Habkost
This will make the type name constant consistent with the name of the type checking macro. Signed-off-by: Eduardo Habkost Reviewed-by: Thomas Huth Message-Id: <20200902224311.1321159-6-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/s390x/ap-device.h | 4 ++-- hw/s390x/ap-de

[PULL 06/34] qom: Make type checker functions accept const pointers

2020-09-08 Thread Eduardo Habkost
The existing type check macros all unconditionally drop const qualifiers from their arguments. Keep this behavior in the macros generated by DECLARE_*CHECKER* by now. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost Message-Id: <20200831210740.

[PULL 20/34] ahci: Rename ICH_AHCI to ICH9_AHCI

2020-09-08 Thread Eduardo Habkost
Make the type checking macro name consistent with the TYPE_* constant. Signed-off-by: Eduardo Habkost Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200902224311.1321159-33-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- include/hw/ide/ahci.h | 2 +- hw/ide/ahci.c | 4 ++--

  1   2   3   4   5   6   >