From: Lukas Straub
If we remove the child with the highest index from the quorum,
decrement s->next_child_index. This way we get stable children
names as long as we only remove the last child.
Signed-off-by: Lukas Straub
Fixes: https://bugs.launchpad.net/bugs/1881231
Reviewed-by: Zhang Chen
From: Alberto Garcia
The current text corresponds to an earlier, simpler version of this
function and it does not explain how it works now.
Signed-off-by: Alberto Garcia
Message-Id:
Signed-off-by: Max Reitz
---
block/qcow2-cluster.c | 24 ++--
1 file changed, 14
14.09.2020 15:35, Greg Kurz wrote:
As recommended in "qapi/error.h", return true on success and false on
failure. This allows to reduce error propagation overhead in the callers.
Signed-off-by: Greg Kurz
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
From: John Snow
Introduced by d85f4222b468,
These were seemingly never used at all.
Signed-off-by: John Snow
Message-Id: <20200806211345.2925343-3-js...@redhat.com>
Signed-off-by: Max Reitz
---
block/qcow.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/block/qcow.c
From: Nir Soffer
Use list comprehension instead of append loop.
Signed-off-by: Nir Soffer
Reviewed-by: Max Reitz
Message-Id: <20200828232152.205833-6-nsof...@redhat.com>
Signed-off-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
From: Alberto Garcia
When a write request needs to allocate new clusters (or change the L2
bitmap of existing ones) a QCowL2Meta structure is created so the L2
metadata can be later updated and any copy-on-write can be performed
if necessary.
A write request can span a region consisting of an
From: Swapnil Ingle
block/vhdx uses qemu block layer where sector size is always 512 bytes.
This may have issues with 4K logical sector sized vhdx image.
For e.g qemu-img convert on such images fails with following assert:
$qemu-img convert -f vhdx -O raw 4KTest1.vhdx test.raw
qemu-img:
From: Alberto Garcia
This function checks the current status of a (sub)cluster in order to
see if an unaligned 'write zeroes' request can be done efficiently by
simply updating the L2 metadata and without having to write actual
zeroes to disk.
If the situation does not allow using the fast path
From: Nir Soffer
Accept variable number of names instead of a sequence:
with FilePaths("a", "b", "c") as (a, b, c):
The disadvantage is that base_dir must be used as kwarg:
with FilePaths("a", "b", base_dir=soc_dir) as (sock1, sock2):
But this is more clear and calling optional
From: Nir Soffer
FilePath creates now one temporary file:
with FilePath("a") as a:
Or more:
with FilePath("a", "b", "c") as (a, b, c):
This is also the behavior of the file_path() helper, used by some of the
tests. Now we have only 2 helpers for creating temporary files instead
of 3.
From: Peter Lieven
in case of large continous areas that share the same allocation status
it happens that the value of s->sector_next_status is unaligned to the
cluster size or even request alignment of the source. Avoid this by
stripping down the s->sector_next_status position to cluster
From: Alberto Garcia
This function takes an L2 entry and a number of clusters to free.
Although in principle it can free any type of cluster (using the L2
entry to determine its type) in practice the API is broken because
compressed clusters have a variable size and there is no way to free
more
From: Nir Soffer
When this class was extracted from FilePath, the docstring was not
updated for generating multiple files, and the example usage was
referencing unrelated file.
While fixing the docstring, add example for creating sockets, which
should use iotests.sock_dir instead of the default
The following changes since commit 2d2c73d0e3d504a61f868e46e6abd5643f38091b:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20200914-1' into staging (2020-09-14
16:03:08 +0100)
are available in the Git repository at:
https://github.com/XanClic/qemu.git
From: Nir Soffer
If os.remove() fails to remove one of the paths, for example if the file
was removed by the test, the cleanup loop would exit silently, without
removing the rest of the files.
Fixes: de263986b5dc
Signed-off-by: Nir Soffer
Reviewed-by: Max Reitz
Message-Id:
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1882851
Title:
QEMU video freezes with "Guest disabled display" (virtio driver)
Status in
14.09.2020 15:35, Greg Kurz wrote:
As recommended in "qapi/error.h", add a bool return value to
spapr_realize_vcpu() and use it in spapr_cpu_core_realize()
in order to get rid of the error propagation overhead.
Signed-off-by: Greg Kurz
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best
On Mon, 14 Sep 2020 18:29:28 -0400
Matthew Rosato wrote:
> The underlying host may be limiting the number of outstanding DMA
> requests for type 1 IOMMU. Add helper functions to check for the
> DMA available capability and retrieve the current number of DMA
> mappings allowed.
>
>
14.09.2020 15:35, Greg Kurz wrote:
As recommended in "qapi/error.h", return true on success and false on
failure. This allows to reduce error propagation overhead in the callers.
Signed-off-by: Greg Kurz
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
Thanks for testing! So I'm closing the ticket now.
** Changed in: qemu
Status: Incomplete => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1717414
Title:
Sending certain
14.09.2020 15:34, Greg Kurz wrote:
Use the return value of visit_check_struct() and visit_check_list()
for error checking instead of local_err. This allows to get rid of
the error propagation overhead.
Signed-off-by: Greg Kurz
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
14.09.2020 15:34, Greg Kurz wrote:
As recommended in "qapi/error.h", return true on success and false on
failure. This allows to reduce error propagation overhead in the callers.
Signed-off-by: Greg Kurz
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
14.09.2020 15:34, Greg Kurz wrote:
Use the return value of spapr_irq_findone() and spapr_irq_claim()
to detect failures. This allows to reduce the error propagation
overhead.
Signed-off-by: Greg Kurz
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On Tue, 15 Sep 2020 08:14:24 +0200
Philippe Mathieu-Daudé wrote:
> Hi Matthew,
>
> On 9/15/20 12:29 AM, Matthew Rosato wrote:
> > The underlying host may be limiting the number of outstanding DMA
> > requests for type 1 IOMMU. Add helper functions to check for the
> > DMA available capability
On 14/09/2020 03.59, Michael Roth wrote:
> From: Tomáš Golembiovský
>
> Add command for reporting devices on Windows guest. The intent is not so
> much to report the devices but more importantly the driver (and its
> version) that is assigned to the device. This gives caller the
> information
14.09.2020 15:34, Greg Kurz wrote:
Use the return value of ppc_set_compat_all() to check failures,
which is preferred over hijacking local_err.
Signed-off-by: Greg Kurz
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
14.09.2020 15:34, Greg Kurz wrote:
The cas_check_pvr() function has two purposes:
- finding the "best" logical PVR, ie. the most recent one supported by
the guest for this CPU type
- checking if the guest supports the real PVR of this CPU type, which
is just an optional extra information
14.09.2020 15:34, Greg Kurz wrote:
Now that ppc_set_compat() indicates success/failure with a return
value, use it and reduce error propagation overhead.
Signed-off-by: Greg Kurz
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
14.09.2020 15:34, Greg Kurz wrote:
VMState handlers are supposed to return negative errno values on failure.
Even vmstate_load_state() itself hase both "return -EINVAL" and "return -1"..
So, all it's a mess)
Signed-off-by: Greg Kurz
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best
On Tue 15 Sep 2020 11:29:22 AM CEST, Max Reitz wrote:
> On 11.09.20 16:09, Alberto Garcia wrote:
>> This function preallocates metadata structures and then extends the
>> image to its new size, but that new size calculation is wrong because
>> it doesn't take into account that the host_offset
On Mon, Sep 14, 2020 at 06:37:55PM +0200, Thomas Huth wrote:
> We simply want to ignore certain queries here, so let's rather
> use the term 'ignore' to express this intention.
>
> Signed-off-by: Thomas Huth
> ---
> v2: Changed naming according to suggestions
>
> tests/qtest/qmp-cmd-test.c |
On Tue, 15 Sep 2020 12:18:35 +0300
Vladimir Sementsov-Ogievskiy wrote:
> 14.09.2020 15:34, Greg Kurz wrote:
> > As recommended in "qapi/error.h", indicate success / failure with a
> > return value. Since ppc_set_compat() is called from a VMState handler,
>
> What handler do you mean? You don't
On 11.09.20 16:09, Alberto Garcia wrote:
> This function preallocates metadata structures and then extends the
> image to its new size, but that new size calculation is wrong because
> it doesn't take into account that the host_offset variable is always
> cluster-aligned.
>
> This problem can be
Peter Maydell writes:
> On Mon, 14 Sep 2020 at 16:27, Alex Bennée wrote:
>>
>> Now the user has to make an even more deliberate decision to
>> enable a deprecated target rather than getting it as a side effect of
>> using --target-exclude-list.
>>
>> Signed-off-by: Alex Bennée
>> ---
>>
14.09.2020 15:34, Greg Kurz wrote:
As recommended in "qapi/error.h", indicate success / failure with a
return value. Since ppc_set_compat() is called from a VMState handler,
What handler do you mean? You don't update any handlers here..
let's make it an int so that it propagates any negative
On Mon, Sep 14, 2020 at 3:25 PM Stefan Reiter wrote:
>
> Hi list,
>
> following command fails since 5.1 (tested on kernel 5.4.60):
>
> # qemu-img convert -p -f raw -O raw /dev/zvol/pool/disk-1 /dev/vg/disk-1
> qemu-img: error while writing at byte 2157968896: Device or resource busy
>
> (source
14.09.2020 15:34, Greg Kurz wrote:
If spapr_irq_cpu_intc_create() fails, local_err isn't propagated and
thus leaked.
Fixes: 992861fb1e4c ("error: Eliminate error_propagate() manually")
Cc: arm...@redhat.com
Signed-off-by: Greg Kurz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
On 14.09.20 21:05, Stefano Garzarella wrote:
> Commit 19ae9ae014 ("block/rbd: Add support for ceph namespaces")
> introduced namespace support for RBD, but we forgot to add the
> new 'namespace' options to qemu_rbd_strong_runtime_opts[].
>
> The 'namespace' is used to identify the image, so it is
On 14.09.20 21:10, Eric Blake wrote:
> If you have the chain 'base.qcow2 <- top.qcow2' and want to merge a
> bitmap from top into base, qemu-img was failing with:
>
> qemu-img: Could not open 'top.qcow2': Could not open backing file: Failed to
> get shared "write" lock
> Is another process using
On Mon, Sep 14, 2020 at 8:32 PM Daniel P. Berrangé wrote:
>
> On Mon, Aug 31, 2020 at 05:01:27PM +0300, Nir Soffer wrote:
> > If fallocate() is not supported, posix_fallocate() falls back to
> > inefficient allocation, writing one byte for every 4k bytes[1]. This is
> > very slow compared with
Philippe Mathieu-Daudé writes:
> This is the second part of a series reducing user-mode
> dependencies. By stripping out unused code, the build
> and testing time is reduced (as is space used by objects).
>
> Series is fully Acked.
Queued, thanks!
Tested-by: Lei YU
Tested on ast2500-evb with 64MiB flash on fmc and it works as expected.
On Tue, Sep 15, 2020 at 1:49 PM Cédric Le Goater wrote:
>
> Some machines don't have much differences a part from the flash model
> being used. Introduce new machine properties to change them from the
>
On Tue, Sep 15, 2020 at 11:03:59AM +0800, Chuan Zheng wrote:
> Since multifd creation is async with migration_channel_connect, we should
> pass the hostname from MigrationState to MultiFDSendParams.
>
> Signed-off-by: Chuan Zheng
> Signed-off-by: Yan Jin
> ---
> migration/multifd.c | 5 +
>
On Tue, Sep 15, 2020 at 11:03:57AM +0800, Chuan Zheng wrote:
> hostname is need in multifd-tls, save hostname into MigrationState.
>
> Signed-off-by: Chuan Zheng
> Signed-off-by: Yan Jin
> ---
> migration/channel.c | 1 +
> migration/migration.c | 1 +
> migration/migration.h | 5 +
>
On 09/10/20 12:23, Philippe Mathieu-Daudé wrote:
> Cc'ing qemu-trivial@
Thanks!
The patch was posted a week ago (and reviewed as well, by you, thanks!)
-- is there something I need to do for getting this merged?
Thank you
Laszlo
> On 9/8/20 7:21 PM, Laszlo Ersek wrote:
>> According to
>>
Daniel P. Berrangé writes:
> When debugging QEMU it is often useful to put a breakpoint on the
> error_setg_internal method impl.
>
> Unfortunately the object_property_add / object_class_property_add
> methods call object_property_find / object_class_property_find methods
> to check if a
On Monday, September 14, 2020 10:45 PM
Alex Williamson wrote:
> To: Zeng, Xin
> Cc: Zhao, Yan Y ; Sean Mooney
> ; Cornelia Huck ; Daniel
> P.Berrangé ; k...@vger.kernel.org; libvir-
> l...@redhat.com; Jason Wang ; qemu-
> de...@nongnu.org; kwankh...@nvidia.com; eau...@redhat.com; Wang,
>
On Sep 13 07:54, Dmitry Fomichev wrote:
> v1 -> v2:
>
> - Incorporated feedback from Klaus and Alistair.
Since it's been a while since I reviewed this, it would have been nice
if you had listed what feedback you incorporated ;)
signature.asc
Description: PGP signature
On Sep 14 07:14, Dmitry Fomichev wrote:
> From: Ajay Joshi
>
> A new write command, Zone Append, is added as a part of Zoned
> Namespace Command Set. Upon successful completion of this command,
> the controller returns the start LBA of the performed write operation
> in cqe.result field.
On Sep 14 07:14, Dmitry Fomichev wrote:
> Calculate the data shift value to report based on the set value of
> logical_block_size device property.
>
> In the process, use a local variable to calculate the LBA format
> index instead of the hardcoded value 0. This makes the code more
> readable and
On Tue, 15 Sep 2020 at 15:31, Andrew Jones wrote:
>
> On Tue, Sep 15, 2020 at 03:03:49PM +0800, Haibo Xu wrote:
> > On Tue, 15 Sep 2020 at 14:22, Andrew Jones wrote:
> > >
> > > On Tue, Sep 15, 2020 at 03:11:43AM +, Haibo Xu wrote:
> > > > From: Andrew Jones
> > > >
> > > > We'll add more
On Tue, 15 Sep 2020 at 14:11, Andrew Jones wrote:
>
> On Tue, Sep 15, 2020 at 03:11:39AM +, Haibo Xu wrote:
> > Adds a spe=[on/off] option to enable/disable vSPE support in
> > guest vCPU.
> >
> > Reviewed-by: Andrew Jones
> > Signed-off-by: Haibo Xu
> > ---
> > target/arm/cpu.c | 6
On Tue, Sep 15, 2020 at 03:03:49PM +0800, Haibo Xu wrote:
> On Tue, 15 Sep 2020 at 14:22, Andrew Jones wrote:
> >
> > On Tue, Sep 15, 2020 at 03:11:43AM +, Haibo Xu wrote:
> > > From: Andrew Jones
> > >
> > > We'll add more to this new function in coming patches so we also
> > > state the
On 11.09.20 16:09, Alberto Garcia wrote:
> preallocate_co() does not resize the image correctly if the original
> size was not cluster-aligned.
>
> This series should be applied on top of Max's block branch (I tested
> it with commit 8e66c829eda997dad661d49d73668b1fd3e6043d).
>
>
On 14.09.20 18:42, Alberto Garcia wrote:
> On Mon 14 Sep 2020 02:14:36 PM CEST, Max Reitz wrote:
>
>> However, I wonder what you think about “cluster_offset” in
>> qcow2_alloc_host_offset. It isn’t a cluster offset anymore.
>> Can/should we rename it?
>
> That variable was not a cluster offset
On 9/15/20 8:29 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
>> This is the second part of a series reducing user-mode
>> dependencies. By stripping out unused code, the build
>> and testing time is reduced (as is space used by objects).
>>
>> Series is fully Acked.
>
> One
On Tue, 15 Sep 2020 at 14:22, Andrew Jones wrote:
>
> On Tue, Sep 15, 2020 at 03:11:43AM +, Haibo Xu wrote:
> > From: Andrew Jones
> >
> > We'll add more to this new function in coming patches so we also
> > state the gic must be created and call it below create_gic().
> >
> > No functional
On Mon, Sep 14, 2020 at 9:11 PM Ani Sinha wrote:
>
> On Mon, Sep 14, 2020 at 8:51 PM Ani Sinha wrote:
> >
> > On Mon, Sep 14, 2020 at 8:20 PM Ani Sinha wrote:
> > >
> > > On Mon, Sep 14, 2020 at 7:39 PM Igor Mammedov wrote:
> > > >
> > > > On Mon, 14 Sep 2020 18:58:19 +0530
> > > > Ani Sinha
+-- On Fri, 11 Sep 2020, Alexander Bulekov wrote --+
| > On 200911 2257, Li Qiang wrote:
| > > Could you also provide the reproducer?
* Sorry, we can not share reproducers on the list, I'm afraid.
* Thank you Alex for the -qtests.
| > > I think it is better to split this patch to 2 or three as
On Tue, Sep 15, 2020 at 03:11:46AM +, Haibo Xu wrote:
> Turn on the spe cpu property by default if host cpu
> support it, i.e. we can now do '-cpu max|host' to add
> the vSPE, and '-cpu max|host,spe=off' to remove it.
>
> Signed-off-by: Haibo Xu
> ---
> target/arm/cpu.c | 1 +
>
Philippe Mathieu-Daudé writes:
> This is the second part of a series reducing user-mode
> dependencies. By stripping out unused code, the build
> and testing time is reduced (as is space used by objects).
>
> Series is fully Acked.
One more:
Acked-by: Markus Armbruster
I suggested commit
Philippe Mathieu-Daudé writes:
> +Laurent + qemu-block@
>
> On 9/14/20 11:14 AM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> Acked-by: Markus Armbruster
>>> Acked-by: Paolo Bonzini
>>> Signed-off-by: Philippe Mathieu-Daudé
>>
>> Unlike the other patches that move code
Looks good. Can you just add a "# Submodules" heading above the test?
I would also like to remove the "yes" value (that is, the default fails if
the internal copy is not there) but it can be done later for all submodules.
Paolo
Il mar 15 set 2020, 01:06 Richard Henderson
ha scritto:
> On
Philippe Mathieu-Daudé writes:
> On 9/14/20 1:21 PM, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
Am 14.09.2020 um 11:42 schrieb Philippe Mathieu-Daudé :
+Laurent and David
> On 9/14/20 11:16 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé
On 9/9/20 12:16 PM, Stefan Hajnoczi wrote:
> The vbootrom module is needed for the new NPCM7xx ARM SoCs. The
> vbootrom.git repo is now mirrored on qemu.org. QEMU mirrors third-party
> code to ensure that users can always build QEMU even if the dependency
> goes offline and so QEMU meets its
On Tue, Sep 15, 2020 at 03:11:43AM +, Haibo Xu wrote:
> From: Andrew Jones
>
> We'll add more to this new function in coming patches so we also
> state the gic must be created and call it below create_gic().
>
> No functional change intended.
>
> Signed-off-by: Andrew Jones
> Reviewed-by:
Yeah, I figured out that the logic behind that patch was failed and
corrected it to get the same error again already. Just to clarify, it is
two of the same card giving the same error. I ran dmesg --level=err, but
got no output. In the full output of dmesg, though, I noticed that there
are some
On 9/14/20 11:07 PM, Richard Henderson wrote:
> On 9/13/20 11:23 PM, Philippe Mathieu-Daudé wrote:
>> The old disassembler is easier to follow:
>>
>>
>> IN:
>> -0x4000d214: lda [ %g3 ] #ASI_M_FLUSH_PROBE, %g6
>> -0x4000d218: sta %g6, [ %g4 ] #ASI_M_FLUSH_PROBE
>>
On 9/15/20 12:29 AM, Matthew Rosato wrote:
> Rather than duplicating the same loop in multiple locations,
> create a static function to do the work.
Why not do that first in your series?
>
> Signed-off-by: Matthew Rosato
> ---
> hw/vfio/common.c | 33 +++--
> 1
Hi Matthew,
On 9/15/20 12:29 AM, Matthew Rosato wrote:
> The underlying host may be limiting the number of outstanding DMA
> requests for type 1 IOMMU. Add helper functions to check for the
> DMA available capability and retrieve the current number of DMA
> mappings allowed.
>
> Signed-off-by:
On Tue, Sep 15, 2020 at 03:11:39AM +, Haibo Xu wrote:
> Adds a spe=[on/off] option to enable/disable vSPE support in
> guest vCPU.
>
> Reviewed-by: Andrew Jones
> Signed-off-by: Haibo Xu
> ---
> target/arm/cpu.c | 6 ++
> target/arm/cpu.h | 13
> target/arm/cpu64.c |
On 15/09/2020 01.02, Richard Henderson wrote:
> There are better ways to do this, e.g. meson cmake subproject,
> but that requires cmake 3.7 and some of our CI environments
> only provide cmake 3.5.
>
> Nor can we add a meson.build file to capstone/, because the git
> submodule would then always
401 - 472 of 472 matches
Mail list logo
