[Bug 1603970] Re: KVM freezes after live migration (AMD 4184 -> 4234)

2020-09-16 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1603970 Title: KVM

[Bug 1629483] Re: Build fails on optionrom

2020-09-16 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1629483 Title: Build

[Bug 1852781] Re: qemu s390x on focal - applications breaking

2020-09-16 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1852781 Title: qemu s390x

[Bug 1816805] Re: Cannot create cdrom device with open tray and cache option

2020-09-16 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1816805 Title: Cannot

[Bug 1852781] Re: qemu s390x on focal - applications breaking

2020-09-16 Thread Launchpad Bug Tracker
[Expired for Ubuntu on IBM z Systems because there has been no activity for 60 days.] ** Changed in: ubuntu-z-systems Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH V2 00/10] fix some comment spelling errors

2020-09-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200917035413.701-1-zhaolich...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at

[PATCH V2 03/10] docs/: fix some comment spelling errors

2020-09-16 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the docs folder. Signed-off-by: zhaolichang Reviewed-by: Peter Maydell --- docs/COLO-FT.txt | 6 +++---

[PATCH V2 10/10] contrib/: fix some comment spelling errors

2020-09-16 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the contrib folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennée --- contrib/gitdm/filetypes.txt | 6

[PATCH V2 06/10] linux-user/: fix some comment spelling errors

2020-09-16 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the linux-user folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennée --- linux-user/aarch64/signal.c | 2

[PATCH V2 02/10] migration/: fix some comment spelling errors

2020-09-16 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the migration folder. Signed-off-by: zhaolichang Reviewed-by: Peter Maydell --- migration/colo-failover.c | 2 +-

[PATCH V2 08/10] disas/: fix some comment spelling errors

2020-09-16 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the disas folder. Signed-off-by: zhaolichang --- disas/hppa.c | 2 +- disas/m68k.c | 8 disas/ppc.c | 2 +- 3 files

[PATCH V2 01/10] qemu/: fix some comment spelling errors

2020-09-16 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennée --- Changelog | 2 +-

[PATCH V2 07/10] block/: fix some comment spelling errors

2020-09-16 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the block folder. Signed-off-by: zhaolichang --- block/block-copy.c | 2 +- block/linux-aio.c | 2 +- block/mirror.c | 2

[PATCH V2 09/10] qapi/: fix some comment spelling errors

2020-09-16 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the qapi folder. Signed-off-by: zhaolichang Reviewed-by: Markus Armbruster --- qapi/block-core.json | 4 ++--

[PATCH V2 05/10] util/: fix some comment spelling errors

2020-09-16 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the util folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennée --- util/osdep.c | 2 +-

[PATCH V2 00/10] fix some comment spelling errors

2020-09-16 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors, this series fixed this spelling errors. v1 -> v2: address Peter Maydell's comments address Alex Benn¨¦e's comments add reviewed-by for patch 1,2,3,4,5,6,9,10

[PATCH V2 04/10] scripts/: fix some comment spelling errors

2020-09-16 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the scripts folder. Signed-off-by: zhaolichang Reviewed-by: Peter Maydell --- scripts/checkpatch.pl | 2 +-

[RFC PATCH 12/12] hw/arm/virt-acpi-build: Enable CPU cache topology

2020-09-16 Thread Ying Fang
A helper struct AcpiCacheOffset is introduced to describe the offset of three level caches. The cache hierarchy is built according to ACPI spec v6.3 5.2.29.2. Let's enable CPU cache topology now. Signed-off-by: Ying Fang Signed-off-by: Henglong Fan --- hw/acpi/aml-build.c | 19

[RFC PATCH 11/12] hw/acpi/aml-build: build ACPI CPU cache topology information

2020-09-16 Thread Ying Fang
To build cache information, An AcpiCacheInfo structure is defined to hold the Type 1 cache structure according to ACPI spec v6.3 5.2.29.2. A helper function build_cache_hierarchy is introduced to encode the cache information. Signed-off-by: Ying Fang --- hw/acpi/aml-build.c | 26

[RFC PATCH 10/12] hw/arm/virt: add fdt cache information

2020-09-16 Thread Ying Fang
Support devicetree CPU cache information descriptions Signed-off-by: Ying Fang --- hw/arm/virt.c | 91 +++ 1 file changed, 91 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 71f7dbb317..74b748ae35 100644 --- a/hw/arm/virt.c +++

[RFC PATCH 08/12] hw/arm/virt-acpi-build: add PPTT table

2020-09-16 Thread Ying Fang
Add the Processor Properties Topology Table (PPTT) to present CPU topology information to the guest. Signed-off-by: Andrew Jones Signed-off-by: Ying Fang --- hw/arm/virt-acpi-build.c | 42 1 file changed, 42 insertions(+) diff --git

[RFC PATCH 00/12] hw/arm/virt: Introduce cpu and cache topology support

2020-09-16 Thread Ying Fang
An accurate cpu topology may help improve the cpu scheduler's decision making when dealing with multi-core system. So cpu topology description is helpful to provide guest with the right view. Cpu cache information may also have slight impact on the sched domain, and even userspace software may

[RFC PATCH 07/12] hw/acpi/aml-build: add processor hierarchy node structure

2020-09-16 Thread Ying Fang
Add the processor hierarchy node structures to build ACPI information for CPU topology. Three helpers are introduced: (1) build_socket_hierarchy for socket description structure (2) build_processor_hierarchy for processor description structure (3) build_smt_hierarchy for thread (logic processor)

[RFC PATCH 06/12] hw/arm/virt-acpi-build: distinguish possible and present cpus

2020-09-16 Thread Ying Fang
When building ACPI tables regarding CPUs we should always build them for the number of possible CPUs, not the number of present CPUs. We then ensure only the present CPUs are enabled. Signed-off-by: Andrew Jones Signed-off-by: Ying Fang --- hw/arm/virt-acpi-build.c | 17 - 1

[RFC PATCH 09/12] target/arm/cpu: Add CPU cache description for arm

2020-09-16 Thread Ying Fang
Add the CPUCacheInfo structure to hold CPU cache information for ARM cpus. A classic three level cache topology is used here. The default cache capacity is given and userspace can overwrite these values. Signed-off-by: Ying Fang --- target/arm/cpu.c | 42

[RFC PATCH 01/12] linux headers: Update linux header with KVM_ARM_SET_MP_AFFINITY

2020-09-16 Thread Ying Fang
Signed-off-by: Ying Fang --- linux-headers/linux/kvm.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index a28c366737..461a2302e7 100644 --- a/linux-headers/linux/kvm.h +++ b/linux-headers/linux/kvm.h @@ -1031,6 +1031,7 @@ struct

[RFC PATCH 04/12] device_tree: add qemu_fdt_add_path

2020-09-16 Thread Ying Fang
From: Andrew Jones qemu_fdt_add_path works like qemu_fdt_add_subnode, except it also recursively adds any missing parent nodes. Cc: Peter Crosthwaite Cc: Alexander Graf Signed-off-by: Andrew Jones --- device_tree.c| 24 include/sysemu/device_tree.h |

[RFC PATCH 05/12] hw/arm/virt: DT: add cpu-map

2020-09-16 Thread Ying Fang
From: Andrew Jones Support devicetree CPU topology descriptions. Signed-off-by: Andrew Jones --- hw/arm/virt.c | 37 - include/hw/arm/virt.h | 1 + 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index

[RFC PATCH 02/12] target/arm/kvm64: make MPIDR consistent with CPU Topology

2020-09-16 Thread Ying Fang
MPIDR helps to provide an additional PE identification in a multiprocessor system. This patch adds support for setting MPIDR from userspace, so that MPIDR is consistent with CPU topology configured. Signed-off-by: Ying Fang --- target/arm/kvm64.c | 46

[RFC PATCH 03/12] target/arm/kvm32: make MPIDR consistent with CPU Topology

2020-09-16 Thread Ying Fang
MPIDR helps to provide an additional PE identification in a multiprocessor system. This patch adds support for setting MPIDR from userspace, so that MPIDR is consistent with CPU topology configured. Signed-off-by: Ying Fang --- target/arm/kvm32.c | 46

[PATCH v2 2/2] qom: Use DECLARE_INTERFACE_CHECKER macro

2020-09-16 Thread Eduardo Habkost
Mechanical search/replace to use the new DECLARE_INTERFACE_CHECKER macro instead of manually defining macros using INTERFACE_CHECK. Acked-by: David Gibson Signed-off-by: Eduardo Habkost --- This is an alternative to the patches submitted at

[PATCH v2 1/2] qom: DECLARE_INTERFACE_CHECKER macro

2020-09-16 Thread Eduardo Habkost
The new macro will be similar to DECLARE_INSTANCE_CHECKER, but for interface types (that use INTEFACE_CHECK instead of OBJECT_CHECK). Signed-off-by: Eduardo Habkost --- Changes series v1 -> v2: none --- Cc: Paolo Bonzini Cc: "Daniel P. Berrangé" Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org

[PATCH v2 0/2] qom: DECLARE_INTERFACE_CHECKER macro

2020-09-16 Thread Eduardo Habkost
This is an alternative to the series: Subject: [PATCH 0/3] qom: Replace INTERFACE_CHECK with OBJECT_CHECK https://lore.kernel.org/qemu-devel/20200916193101.511600-1-ehabk...@redhat.com/ Instead of removing INTERFACE_CHECK completely, keep it but use a DECLARE_INTERFACE_CHECKER macro to

Re: [PATCH 2/2] qom: Use DECLARE_INTERFACE_CHECKER macro

2020-09-16 Thread Eduardo Habkost
On Thu, Sep 17, 2020 at 10:44:34AM +1000, David Gibson wrote: [...] > > diff --git a/include/hw/acpi/acpi_dev_interface.h > > b/include/hw/acpi/acpi_dev_interface.h > > index 9adf1e4706..96aa63919a 100644 > > --- a/include/hw/acpi/acpi_dev_interface.h > > +++

Re: [PATCH 2/2] qom: Use DECLARE_INTERFACE_CHECKER macro

2020-09-16 Thread David Gibson
On Wed, Sep 16, 2020 at 06:32:58PM -0400, Eduardo Habkost wrote: > Mechanical search/replace to use the new > DECLARE_INTERFACE_CHECKER macro instead of manually defining > macros using INTERFACE_CHECK. > > Signed-off-by: Eduardo Habkost ppc parts Acked-by: David Gibson > --- > This is an

Re: [PATCH 00/15] spapr: Error handling fixes and cleanups (round 2)

2020-09-16 Thread David Gibson
On Wed, Sep 16, 2020 at 12:49:38PM +1000, David Gibson wrote: > On Mon, Sep 14, 2020 at 02:34:50PM +0200, Greg Kurz wrote: > > Yet another round of sanitizing the error handling in spapr. I've > > identified locations that needed fixing with the errp-guard.cocci > > coccinelle script. It turns out

Re: [PATCH 10/15] spapr: Add a return value to spapr_set_vcpu_id()

2020-09-16 Thread David Gibson
On Tue, Sep 15, 2020 at 03:53:52PM +0200, Greg Kurz wrote: > On Tue, 15 Sep 2020 15:08:05 +0200 > Philippe Mathieu-Daudé wrote: > > > On 9/14/20 2:35 PM, Greg Kurz wrote: > > > As recommended in "qapi/error.h", return true on success and false on > > > failure. This allows to reduce error

Re: [SPAM] Re: [PATCH 14/15] spapr: Simplify error handling in spapr_memory_plug()

2020-09-16 Thread David Gibson
On Tue, Sep 15, 2020 at 01:43:40PM +0200, Greg Kurz wrote: > On Tue, 15 Sep 2020 13:58:53 +0300 > Vladimir Sementsov-Ogievskiy wrote: > > > 14.09.2020 15:35, Greg Kurz wrote: > > > As recommended in "qapi/error.h", add a bool return value to > > > spapr_add_lmbs() and spapr_add_nvdimm(), and use

Re: Should we apply for GitLab's open source program?

2020-09-16 Thread Bradley M. Kuhn
> On Fri, Sep 04, 2020 at 04:35:34PM +0100, Alex Bennée wrote: >> Given our growing reliance on GitLab and the recent announcement about >> free tier minutes: >> >> https://about.gitlab.com/pricing/faq-consumption-cicd/ >> >> is it time we officially apply for GitLab's Open Source Program: >>

Re: eMMC support

2020-09-16 Thread Joel Stanley
On Wed, 16 Sep 2020 at 18:35, Sai Pavan Boddu wrote: > > Hi Philippe, > > > > We are looking to add eMMC support, I searched the mailing list and found a > series posted on eMMC by “Vincent Palatin” > > https://lists.gnu.org/archive/html/qemu-devel/2011-07/msg02833.html I would be interested in

Re: [PATCH 00/13] dma: Let the DMA API take MemTxAttrs argument and propagate MemTxResult

2020-09-16 Thread Edgar E. Iglesias
On Wed, 16 Sep 2020, 15:48 Philippe Mathieu-Daudé, wrote: > On 9/4/20 5:44 PM, Philippe Mathieu-Daudé wrote: > > Salvaging cleanups patches from the RFC series "Forbid DMA write > > accesses to MMIO regions" [*], propagating MemTxResult and > > adding documentation. > > > > Philippe

[PATCH 2/2] qom: Use DECLARE_INTERFACE_CHECKER macro

2020-09-16 Thread Eduardo Habkost
Mechanical search/replace to use the new DECLARE_INTERFACE_CHECKER macro instead of manually defining macros using INTERFACE_CHECK. Signed-off-by: Eduardo Habkost --- This is an alternative to the patches submitted at

[PATCH 0/2] qom: DECLARE_INTERFACE_CHECKER macro

2020-09-16 Thread Eduardo Habkost
This is an alternative to the series: Subject: [PATCH 0/3] qom: Replace INTERFACE_CHECK with OBJECT_CHECK https://lore.kernel.org/qemu-devel/20200916193101.511600-1-ehabk...@redhat.com/ Instead of removing INTERFACE_CHECK completely, keep it but use a DECLARE_INTERFACE_CHECKER macro to

Re: [PATCH 00/37] qapi: static typing conversion, pt1

2020-09-16 Thread John Snow
On 9/15/20 6:39 PM, John Snow wrote: Hi, this series starts adding static type hints to the QAPI module. As you can see, the series started getting quite a bit long, so this is only a partial conversion that focuses on a handful of the easier files. Updated series with current feedback and

[PATCH 1/2] qom: DECLARE_INTERFACE_CHECKER macro

2020-09-16 Thread Eduardo Habkost
The new macro will be similar to DECLARE_INSTANCE_CHECKER, but for interface types (that use INTEFACE_CHECK instead of OBJECT_CHECK). Signed-off-by: Eduardo Habkost --- Cc: Paolo Bonzini Cc: "Daniel P. Berrangé" Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- include/qom/object.h | 14

Re: [PATCH 09/37] qapi/common.py: Add indent manager

2020-09-16 Thread John Snow
On 9/16/20 11:13 AM, Markus Armbruster wrote: John Snow writes: Code style tools really dislike the use of global keywords, because it generally involves re-binding the name at runtime which can have strange effects depending on when and how that global name is referenced in other modules.

Re: [PATCH 0/3] qom: Replace INTERFACE_CHECK with OBJECT_CHECK

2020-09-16 Thread Eduardo Habkost
On Thu, Sep 17, 2020 at 01:31:50AM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Sep 16, 2020 at 11:35 PM Eduardo Habkost > wrote: > > > This series replaces INTERFACE_CHECK with OBJECT_CHECK because > > both macros are exactly the same. > > > > The last patch is a new run of the

Re: [PATCH v5 4/7] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

2020-09-16 Thread Dima Stepanov
On Mon, Sep 14, 2020 at 09:23:42PM -0400, Raphael Norwitz wrote: > On Fri, Sep 11, 2020 at 4:43 AM Dima Stepanov wrote: > > > > Add support for the vhost-user-blk-pci device. This node can be used by > > the vhost-user-blk tests. Tests for the vhost-user-blk device are added > > in the following

[REPORT] Nightly Performance Tests - Wednesday, September 16, 2020

2020-09-16 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-09-16 21:35:02 End Time (UTC) : 2020-09-16 22:07:32 Execution Time : 0:32:29.941492 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%.

Re: [PATCH 0/3] qom: Replace INTERFACE_CHECK with OBJECT_CHECK

2020-09-16 Thread Marc-André Lureau
Hi On Wed, Sep 16, 2020 at 11:35 PM Eduardo Habkost wrote: > This series replaces INTERFACE_CHECK with OBJECT_CHECK because > both macros are exactly the same. > > The last patch is a new run of the OBJECT_CHECK -> > DECLARE*_CHECKER* converter script that will convert the former >

[Bug 1895895] [NEW] Attaching SD-Card to specific SD-Bus Sabrelite (ARM)

2020-09-16 Thread David Aghaian
Public bug reported: Currently, I am looking for a method of attaching an sd-card to a specific bus as opposed to defaulting to the first. QEMU Version: 5.0.0 Specifically trying to use qemu-system-arm binary Running an "info qtree" shows the output seen in the attached image. I have

Re: riscv32 wait() problem, qemu or glibc?

2020-09-16 Thread Alistair Francis
On Wed, Sep 16, 2020 at 2:09 PM Andreas K. Hüttel wrote: > > > My guess is that somewhere in QEMU the types don't match what RV32 is > > using. It's probably worth printing out the size, alignment and value > > of everything at every stage and see what breaks. > > Thanks. Sorry I can't be more

Re: riscv32 wait() problem, qemu or glibc?

2020-09-16 Thread Andreas K . Hüttel
> My guess is that somewhere in QEMU the types don't match what RV32 is > using. It's probably worth printing out the size, alignment and value > of everything at every stage and see what breaks. Thanks. > AFAIK RV32 linux-user mode is pretty much un-tested. So their might be > all sorts of

[PATCH 1/3] block/nvme: Initialize constant values with const_le32()

2020-09-16 Thread Philippe Mathieu-Daudé
To avoid multiple endianess conversion, as we know the device registers are in little-endian, directly use const_le32() with constant values. Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH 3/3] block/nvme: Align NVMeRegs structure to 4KiB and mark it packed

2020-09-16 Thread Philippe Mathieu-Daudé
In commit e5ff22ba9fc we changed the doorbells register declaration but forgot to mark the structure packed (as MMIO registers), allowing the compiler to optimize it. Fix by marking it packed, and align it to avoid: block/nvme.c: In function ‘nvme_create_queue_pair’: block/nvme.c:252:22:

[PATCH 0/3] block/nvme: Fix NVMeRegs alignment/packing and use atomic operations

2020-09-16 Thread Philippe Mathieu-Daudé
Fix a compiler optimization problem introduced in commit e5ff22ba9fc ("block/nvme: Pair doorbell registers"), use atomic operations. For some not understood yet reason using atomic_and triggers a NMI on x86 arch. Using the following snippet on top of this series: -- >8 -- -

[PATCH 2/3] block/nvme: Use atomic operations instead of 'volatile' keyword

2020-09-16 Thread Philippe Mathieu-Daudé
Follow docs/devel/atomics.rst guidelines and use atomic operations. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Dr. David Alan Gilbert Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff

Re: [PATCH v3 3/5] sev/i386: Allow AP booting under SEV-ES

2020-09-16 Thread Tom Lendacky
On 9/16/20 4:23 AM, Laszlo Ersek wrote: > Hi Tom, Hi Laszlo, > > sorry for the random feedback -- I haven't followed (and don't really > intend to follow) the QEMU side of the feature. Just one style idea: > > On 09/15/20 23:29, Tom Lendacky wrote: >> From: Tom Lendacky >> >> When SEV-ES is

[PATCH] meson: report accelerator support

2020-09-16 Thread Paolo Bonzini
Note that the "real" support is reported. A configuration like --disable-system --enable-kvm will report "no" for "KVM support" because no KVM-supported target is being compiled. Reported-by: Andrew Jones Signed-off-by: Paolo Bonzini --- meson.build | 35 --- 1

[PATCH 2/3] qom: Replace INTERFACE_CHECK with OBJECT_CHECK

2020-09-16 Thread Eduardo Habkost
INTERFACE_CHECK and OBJECT_CHECK do exactly the same. There's no need to have two different methods for declaring the type checker macro for interface types. Signed-off-by: Eduardo Habkost --- Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Corey Minyard Cc: "Cédric Le Goater" Cc: David

[PATCH 1/3] qom: Correct object_class_dynamic_cast_assert() documentation

2020-09-16 Thread Eduardo Habkost
object_class_dynamic_cast_assert() is not used by INTERFACE_CHECK, remove misleading mention of that function in the documentation. Signed-off-by: Eduardo Habkost --- Cc: Paolo Bonzini Cc: "Daniel P. Berrangé" Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- include/qom/object.h | 2 +- 1

[PATCH 0/3] qom: Replace INTERFACE_CHECK with OBJECT_CHECK

2020-09-16 Thread Eduardo Habkost
This series replaces INTERFACE_CHECK with OBJECT_CHECK because both macros are exactly the same. The last patch is a new run of the OBJECT_CHECK -> DECLARE*_CHECKER* converter script that will convert the former INTERFACE_CHECK-based macros. Eduardo Habkost (3): qom: Correct

[PATCH 3/3] [automated] Use DECLARE_*CHECKER* macros

2020-09-16 Thread Eduardo Habkost
New round of conversion of type checking macros to DECLARE_*CHECKER, in the files that were previously using INTERFACE_CHECK. Genereated using: $ ./scripts/codeconverter/converter.py --passes=3 -i \ --pattern=QOMStructTypedefSplit,MoveSymbols,TypeCheckMacro \

Re: [RFC PATCH v2 4/4] hw/acpi/ich9: Enable ACPI PCI hot-plug

2020-09-16 Thread Julia Suvorova
On Fri, Aug 21, 2020 at 2:24 PM Igor Mammedov wrote: > > On Tue, 18 Aug 2020 23:52:27 +0200 > Julia Suvorova wrote: > > > Add acpi_pcihp to ich9_pm and use ACPI PCI hot-plug by default. > > I don't see anything related to migrating hotplug state within series, > > see VMSTATE_PCI_HOTPLUG for

Re: [RFC PATCH v2 2/4] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-09-16 Thread Julia Suvorova
On Wed, Aug 19, 2020 at 5:21 AM Philippe Mathieu-Daudé wrote: > > Hi Julia, > > On 8/18/20 11:52 PM, Julia Suvorova wrote: > > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. > > > > Signed-off-by: Julia Suvorova > >

Re: [RFC PATCH v2 3/4] hw/i386/acpi-build: Turn off support of PCIe native hot-plug and SHPC in _OSC

2020-09-16 Thread Julia Suvorova
On Wed, Sep 16, 2020 at 8:03 PM Julia Suvorova wrote: > > On Fri, Aug 21, 2020 at 2:13 PM Igor Mammedov wrote: > > > > On Tue, 18 Aug 2020 23:52:26 +0200 > > Julia Suvorova wrote: > > > > > Other methods may be used if the system is capable of this and the _OSC > > > bit > > > is set. Disable

Re: [RFC PATCH v2 2/4] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35

2020-09-16 Thread Julia Suvorova
On Fri, Aug 21, 2020 at 2:08 PM Igor Mammedov wrote: > > On Tue, 18 Aug 2020 23:52:25 +0200 > Julia Suvorova wrote: > > > Implement notifications and gpe to support q35 ACPI PCI hot-plug. > > Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. > > in addition to comment from Philippe > > >

eMMC support

2020-09-16 Thread Sai Pavan Boddu
Hi Philippe, We are looking to add eMMC support, I searched the mailing list and found a series posted on eMMC by "Vincent Palatin" https://lists.gnu.org/archive/html/qemu-devel/2011-07/msg02833.html I would like to consider the above work and mix-up with more changes to start adding support

[PATCH 1/5] scripts/codeconverter: Update to latest version

2020-09-16 Thread Eduardo Habkost
I'm not documenting every single change in the codeconverter script because most of that code will be deleted once we finish the QOM code conversion. This patch updates the script to the latest version that was used to perform changes in the QOM code. Signed-off-by: Eduardo Habkost ---

[PATCH 2/5] qom: Remove ParentClassType argument from OBJECT_DECLARE_SIMPLE_TYPE

2020-09-16 Thread Eduardo Habkost
The requirement to specify the parent class type makes the macro harder to use and easy to misuse (silent bugs can be introduced if the wrong struct type is specified). Simplify the macro by just not declaring any class struct, allowing us to remove the class_size field from the TypeInfo

[PATCH 4/5] [automated] Use OBJECT_DECLARE_TYPE when possible

2020-09-16 Thread Eduardo Habkost
This converts existing DECLARE_OBJ_CHECKERS usage to OBJECT_DECLARE_TYPE when possible. $ ./scripts/codeconverter/converter.py -i \ --pattern=AddObjectDeclareType $(git grep -l '' -- '*.[ch]') Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: Andrzej Zaborowski Cc: Alistair Francis

[PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros

2020-09-16 Thread Eduardo Habkost
One of the goals of having less boilerplate on QOM declarations is to avoid human error. Requiring an extra argument that is never used is an opportunity for mistakes. Remove the unused argument from OBJECT_DECLARE_TYPE and OBJECT_DECLARE_SIMPLE_TYPE. Coccinelle patch used to convert all users

[PATCH 0/5] qom: Convert more declarations to OBJECT_DECLARE*

2020-09-16 Thread Eduardo Habkost
This converts many QOM types to use OBJECT_DECLARE* instead of manually using DECLARE*_CHECKER*. Before doing that, I'm simplifying the OBJECT_DECLARE* API to make it easier to use and more difficult to misuse. The module_obj_name and ParentClassType parameters were removed because they are not

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-09-16 Thread sean mooney
hum i was hoping to indicate this affect focal in some what but not sure how to do that but this issue happens with the ubunutu 20.04 version of qemu 4.2 it does not seam to happen with the centos 8 build of the same qemu so i dont know if there is a delta in packages or if its just a case that

Re: [RFC PATCH v2 3/4] hw/i386/acpi-build: Turn off support of PCIe native hot-plug and SHPC in _OSC

2020-09-16 Thread Julia Suvorova
On Fri, Aug 21, 2020 at 2:13 PM Igor Mammedov wrote: > > On Tue, 18 Aug 2020 23:52:26 +0200 > Julia Suvorova wrote: > > > Other methods may be used if the system is capable of this and the _OSC bit > > is set. Disable them explicitly to force ACPI PCI hot-plug use. The older > > versions will

[PATCH v2] sd: Exhibit support for CMD23

2020-09-16 Thread Sai Pavan Boddu
Update 'SCR.CMD_SUPPORT' register with support of CMD23. Signed-off-by: Sai Pavan Boddu Reported-by: Rahul Thati --- Changes for V2: Fix commit message hw/sd/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 0012882..16d1b61 100644

Re: [PATCH] migration: Silence compiler warning in global_state_store_running()

2020-09-16 Thread Eric Blake
On 9/16/20 12:19 PM, Thomas Huth wrote: GCC 9.3.0 on Ubuntu complains: In file included from /usr/include/string.h:495, from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, from ../migration/global_state.c:13: In function ‘strncpy’, inlined from

[PATCH] sd: Exibit support for CMD23

2020-09-16 Thread Sai Pavan Boddu
Update SCR.CMD_SUPPORT register with support of CMD23. Signed-off-by: Sai Pavan Boddu Reported-by: Rahul Thati --- hw/sd/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 0012882..16d1b61 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -335,7

Re: [PATCH v2] hw/ide: check null block before _cancel_dma_sync

2020-09-16 Thread P J P
+-- On Fri, 4 Sep 2020, P J P wrote --+ | From: Prasad J Pandit | | When cancelling an i/o operation via ide_cancel_dma_sync(), | a block pointer may be null. Add check to avoid null pointer | dereference. | | -> https://ruhr-uni-bochum.sciebo.de/s/NNWP2GfwzYKeKwE?path=%2Fide_nullptr1 |

[PATCH] migration: Silence compiler warning in global_state_store_running()

2020-09-16 Thread Thomas Huth
GCC 9.3.0 on Ubuntu complains: In file included from /usr/include/string.h:495, from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, from ../migration/global_state.c:13: In function ‘strncpy’, inlined from ‘global_state_store_running’ at

Re: [PATCH 2/2] meson: move libmpathpersist test

2020-09-16 Thread Paolo Bonzini
Yes, or easier the "false" assignment can be moved out of the "if". Paolo Il mer 16 set 2020, 19:09 Thomas Huth ha scritto: > On 16/09/2020 18.26, Paolo Bonzini wrote: > > This is the first compiler/linker test that has been moved to Meson. > > Add more section headings to keep things clearer.

Re: [PATCH v6 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

2020-09-16 Thread Collin Walling
On 9/16/20 11:53 AM, Cornelia Huck wrote: [...] >> > > Thanks, applied. > > Thanks Conny. Much appreciated for everyone's patience and review. The only thing I'd like to hold out on for now is for someone to take a peek at patch #3 with respect to the protected virtualization stuff. I don't

Re: [PATCH 2/2] meson: move libmpathpersist test

2020-09-16 Thread Thomas Huth
On 16/09/2020 18.26, Paolo Bonzini wrote: > This is the first compiler/linker test that has been moved to Meson. > Add more section headings to keep things clearer. > > Signed-off-by: Paolo Bonzini > --- > configure | 77 +++-- > meson.build

[RFC DOCUMENT 11/12] kubevirt-and-kvm: Add Backpropagation page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Backpropagation.md # Backpropagation Whenever a partial VM configuration is submitted to libvirt, any missing information is automatically filled in to obtain a configuration that's complete enough to guarantee long-term guest ABI

[RFC DOCUMENT 12/12] kubevirt-and-kvm: Add Contacts page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Contacts.md # Contacts and credits # Contacts The following people have agreed to serve as points of contact for follow-up discussion around the topics included in these documents. ## Overall * Andrea Bolognani <> (KVM user space) *

[RFC DOCUMENT 10/12] kubevirt-and-kvm: Add Upgrades page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Upgrades.md # Upgrades The KubeVirt installation and upgrade process are entirely controlled by an [operator][], which is a common pattern in the Kubernetes world. The operator is a piece of software running in the cluster and managing

Re: [PATCH-for-5.2] hw/i386/q35: Remove unreachable Xen code on Q35 machine

2020-09-16 Thread Paolo Bonzini
On 22/07/20 10:25, Philippe Mathieu-Daudé wrote: > Xen accelerator requires specific changes to a machine to be able > to use it. See for example the 'Xen PC' machine configure its PCI > bus calling pc_xen_hvm_init_pci(). There is no 'Xen Q35' machine > declared. This code was probably added while

[RFC DOCUMENT 09/12] kubevirt-and-kvm: Add Isolation page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Isolation.md # Isolation How is the QEMU process isolated from the host and from other VMs? ## Traditional virtualization cgroups * managed by libvirt SELinux * libvirt is privileged and QEMU is protected by SELinux policies set

[RFC DOCUMENT 08/12] kubevirt-and-kvm: Add NUMA Pinning page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/NUMA-Pinning.md # NUMA pinning KubeVirt doesn't currently implement NUMA pinning due to Kubernetes limitation. ## Kubernetes Topology Manager Allows aligning CPU and peripheral device allocations by NUMA node. Many limitations: * Not

[RFC DOCUMENT 07/12] kubevirt-and-kvm: Add CPU Pinning page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/CPU-Pinning.md # CPU pinning As is the case for many of KubeVirt's features, CPU pinning is partially achieved using standard Kubernetes components: this both reduces the amount of new code that has to be written and guarantees better

Re: [PATCH 07/14] block/blklogwrites: drop error propagation

2020-09-16 Thread Ari Sundholm
Hi, On 9/11/20 11:03 AM, Markus Armbruster wrote: Ari Sundholm writes: Hi Vladimir! Thank you for working on this. My comments below. On 9/9/20 9:59 PM, Vladimir Sementsov-Ogievskiy wrote: It's simple to avoid error propagation in blk_log_writes_open(), we just need to refactor

[RFC DOCUMENT 06/12] kubevirt-and-kvm: Add Live Migration page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Live-Migration.md # Live Migration There are two scenarios where live migration is triggered in KubeVirt * As per user request, by posting a `VirtualMachineInstanceMigration` to the cluster * As per cluster request, for instance on a

[RFC DOCUMENT 02/12] kubevirt-and-kvm: Add Components page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Components.md # Components This document describes the various components of the KubeVirt architecture, how they fit together, and how they compare to the traditional virtualization architecture (QEMU + libvirt). ## Traditional

[RFC DOCUMENT 05/12] kubevirt-and-kvm: Add Networking page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Networking.md # Networking ## Problem description Service meshes (such as [Istio][], [Linkerd][]) typically expect application processes to run on the same physical host, usually in a separate user namespace. Network namespaces might be

[RFC DOCUMENT 03/12] kubevirt-and-kvm: Add Hotplug page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Hotplug.md # Hotplug In Kubernetes, pods are defined to be immutable, so it's not possible to perform hotplug of devices in the same way as with the traditional virtualization stack. This limitation is a result of KubeVirt's guiding

[RFC DOCUMENT 04/12] kubevirt-and-kvm: Add Storage page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Storage.md # Storage This document describes the known use-cases and architecture options we have for Linux Virtualization storage in [KubeVirt][]. ## Problem description The main goal of Kubevirt is to leverage the storage subsystem

[RFC DOCUMENT 01/12] kubevirt-and-kvm: Add Index page

2020-09-16 Thread Andrea Bolognani
https://gitlab.com/abologna/kubevirt-and-kvm/-/blob/master/Index.md # KubeVirt and the KVM user space This is the entry point to a series of documents which, together, detail the current status of KubeVirt and how it interacts with the KVM user space. The intended audience is people who are

Re: QEMU 5.0 virtio-blk performance regression with high queue depths

2020-09-16 Thread Denis V. Lunev
On 9/16/20 5:07 PM, Denis V. Lunev wrote: > On 9/16/20 4:32 PM, Stefan Hajnoczi wrote: >> On Thu, Aug 27, 2020 at 3:24 PM Stefan Hajnoczi wrote: >>> Hi Denis, >>> A performance regression was found after the virtio-blk queue-size >>> property was increased from 128 to 256 in QEMU 5.0 in commit

[RFC DOCUMENT 00/12] kubevirt-and-kvm: Add documents

2020-09-16 Thread Andrea Bolognani
Hello there! Several weeks ago, a group of Red Hatters working on the virtualization stack (primarily QEMU and libvirt) started a conversation with developers from the KubeVirt project with the goal of better understanding and documenting the interactions between the two. Specifically, we were

Re: Python docstrings and licensing/authorship

2020-09-16 Thread Daniel P . Berrangé
On Wed, Sep 16, 2020 at 12:22:37PM -0400, John Snow wrote: > On 9/16/20 12:05 PM, Christophe de Dinechin wrote: > > > > > > > On 16 Sep 2020, at 17:47, John Snow wrote: > > > > > > For some of the Python cleanup work I am doing, I am moving preamble > > > comments into docstrings. These

  1   2   3   4   5   >