The following changes since commit 0fc0142828b5bc965790a1c5c6e241897d3387cb:
Merge remote-tracking branch
'remotes/kraxel/tags/input-20200921-pull-request' into staging (2020-09-22
21:11:10 +0100)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-
From: Halil Pasic
Wire up the CCW device for vhost-user-fs.
Reviewed-by: Cornelia Huck
Signed-off-by: Halil Pasic
Message-id: 20200901150019.29229-2-mhart...@linux.ibm.com
Signed-off-by: Stefan Hajnoczi
---
hw/s390x/vhost-user-fs-ccw.c | 75
hw/s390x/meso
Development of the userspace NVMe block driver picked up again recently.
After talking with Fam I am stepping up as block/nvme.c maintainer.
Patches will be merged through my 'block' tree.
Cc: Kevin Wolf
Cc: Klaus Jensen
Cc: Fam Zheng
Signed-off-by: Stefan Hajnoczi
Acked-by: Kevin Wolf
Acked-
Fuzzing discovered that virtqueue_unmap_sg() is being called on modified
req->in/out_sg iovecs. This means dma_memory_map() and
dma_memory_unmap() calls do not have matching memory addresses.
Fuzzing discovered that non-RAM addresses trigger a bug:
void address_space_unmap(AddressSpace *as, voi
The sentence explaining the deprecation schedule is ambiguous. Make it
clear that a feature deprecated in the Nth release is guaranteed to
remain available in the N+1th release. Removal can occur in the N+2nd
release or later.
As an example of this in action, see commit
25956af3fe5dd0385ad8017bc76
QEMU now hosts a mirror of meson.git. QEMU mirrors third-party code to
ensure that users can always build QEMU even if the dependency goes
offline and so QEMU meets its responsibilities to provide full source
code under software licenses.
Suggested-by: Peter Maydell
Signed-off-by: Stefan Hajnoczi
From: Marc Hartmayer
Since virtio existed even before it got standardized, the virtio
standard defines the following types of virtio devices:
+ legacy device (pre-virtio 1.0)
+ non-legacy or VIRTIO 1.0 device
+ transitional device (which can act both as legacy and non-legacy)
Virtio 1.0 defi
QEMU now hosts a mirror of qboot.git. QEMU mirrors third-party code to
ensure that users can always build QEMU even if the dependency goes
offline and so QEMU meets its responsibilities to provide full source
code under software licenses.
Suggested-by: Peter Maydell
Signed-off-by: Stefan Hajnoczi
The vbootrom module is needed for the new NPCM7xx ARM SoCs. The
vbootrom.git repo is now mirrored on qemu.org. QEMU mirrors third-party
code to ensure that users can always build QEMU even if the dependency
goes offline and so QEMU meets its responsibilities to provide full
source code under softwa
Test aio_disable_external(), which switches from fdmon-epoll back to
fdmon-poll. This resulted in an assertion failure that was fixed in the
previous patch.
Signed-off-by: Stefan Hajnoczi
Message-Id: <20200915120339.702938-3-stefa...@redhat.com>
---
MAINTAINERS | 1 +
tests/test-fd
The iov_discard_front/back() operations are useful for parsing iovecs
but they modify the array elements. If the original array is needed
after parsing finishes there is currently no way to restore it.
Although g_memdup() can be used before performing destructive
iov_discard_front/back() operation
npfd keeps track of how many pollfds are currently being monitored. It
must be reset to 0 when fdmon_poll_wait() returns.
When npfd reaches a treshold we switch to fdmon-epoll because it scales
better.
This patch resets npfd in the case where we switch to fdmon-epoll.
Forgetting to do so results
On Tue, Sep 22, 2020 at 05:00:34PM -0400, John Snow wrote:
> Signed-off-by: John Snow
Reviewed-by: Cleber Rosa
signature.asc
Description: PGP signature
On Tue, Sep 22, 2020 at 05:00:53PM -0400, John Snow wrote:
> Typing arbitrarily shaped dicts with mypy is difficult prior to Python
> 3.8; using explicit structures is nicer.
>
> Since we always define an Extra type now, the return type of _make_tree
> simplifies and always returns the tuple.
>
>
Am 10.09.2020 um 17:34 hat Max Reitz geschrieben:
> On 07.09.20 20:20, Kevin Wolf wrote:
> > These QMP commands are replaced by block-export-add/del.
> >
> > Signed-off-by: Kevin Wolf
> > ---
> > qapi/block-export.json | 11 +--
> > docs/system/deprecated.rst | 8
> > 2 fil
On Wed 16 Sep 2020 02:20:05 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
> -for (p = backing_bs(bs); p != base; p = backing_bs(p)) {
> +for (p = backing_bs(bs); include_base || p != base; p = backing_bs(p)) {
> ret = bdrv_co_block_status(p, want_zero, offset, bytes, pnum, map,
>
On 23/09/20 18:04, Thomas Huth wrote:
> On 23/09/2020 17.10, Paolo Bonzini wrote:
>> The TCI test is already performed on gitlab CI, and it fails because
>> Travis tests (generally) disable tools and therefore do not have
>> "make check-qtest". Just remove it.
> Huh? Where is it failing? It curren
On Tue, Sep 22, 2020 at 05:00:35PM -0400, John Snow wrote:
> Remove qapi/common.py from the pylintrc ignore list.
>
> Signed-off-by: John Snow
$ pylint scripts/qapi/ --rcfile=scripts/qapi/pylintrc
Your code has been r
All our supported build platforms have Python 3.6 or newer nowadays, and
there are some useful features in Python 3.6 which are not available in
3.5 yet (e.g. the type hint annotations which will allow us to statically
type the QAPI parser), so let's bump the minimum Python version to 3.6 now.
Sig
On Wed 16 Sep 2020 02:20:06 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
> We are going to reuse bdrv_common_block_status_above in
> bdrv_is_allocated_above. bdrv_is_allocated_above may be called with
> include_base == false and still bs == base (for ex. from img_rebase()).
>
> So, support this cor
Am 23.09.2020 um 17:59 hat Alberto Garcia geschrieben:
> On Wed 23 Sep 2020 05:55:22 PM CEST, Kevin Wolf wrote:
> >> +A throttle-group can also be created with the -object command line
> >> +option but at the moment there is no way to pass a 'limits' parameter
> >> +that contains a ThrottleLimits s
On 9/23/20 12:18 PM, Cleber Rosa wrote:
I still think we should record (and maybe I'm missing it) the pylint
version used though. Anyway:
Cover letter for all six parts mentions pylint 2.6.0!
In the future this will be pinned in the CI mechanisms.
--js
On 23/09/2020 18.26, Paolo Bonzini wrote:
> On 23/09/20 18:04, Thomas Huth wrote:
>> On 23/09/2020 17.10, Paolo Bonzini wrote:
>>> The TCI test is already performed on gitlab CI, and it fails because
>>> Travis tests (generally) disable tools and therefore do not have
>>> "make check-qtest". Just
On Tue, Sep 22, 2020 at 05:00:54PM -0400, John Snow wrote:
> _make_tree doesn't know if it is receiving an object or some other type;
> adding features information should arguably be performed by the caller.
>
> This will help us refactor _make_tree more gracefully in the next patch.
>
> Signed-o
Should we also warning it in meson.build, cause configure finally shoud be
removed.
On Thu, Sep 24, 2020 at 12:32 AM Thomas Huth wrote:
>
> All our supported build platforms have Python 3.6 or newer nowadays, and
> there are some useful features in Python 3.6 which are not available in
> 3.5 yet
On 23/09/2020 18.34, 罗勇刚(Yonggang Luo) wrote:
> Should we also warning it in meson.build, cause configure finally shoud
> be removed.
Sounds like a good idea for a separate patch (let's do one issue at a
time...).
Thomas
On 09/23/20 11:46, Igor Mammedov wrote:
> v6:
> - [9/10] Add comment explaining why while_ctx2 restarts from the last
> processed CPU.
> - rebase on top of current master, due to non trivial conflict
> caused by microvm series, which moved/renamed pc_cpu_pre_plug()
So, I went back to my l
On 9/23/20 5:24 PM, John Snow wrote:
> On 9/4/20 11:44 AM, Philippe Mathieu-Daudé wrote:
>> Salvaging cleanups patches from the RFC series "Forbid DMA write
>> accesses to MMIO regions" [*], propagating MemTxResult and
>> adding documentation.
>>
>> [*] https://www.mail-archive.com/qemu-block@nongn
On 9/22/20 7:43 PM, Cleber Rosa wrote:
On Tue, Sep 22, 2020 at 05:00:24PM -0400, John Snow wrote:
This adds some really childishly simple debugging tools. Maybe they're
interesting for someone else, too?
Signed-off-by: John Snow
---
scripts/qapi/debug.py | 78
On 9/23/20 5:37 PM, Eduardo Habkost wrote:
> On Wed, Sep 23, 2020 at 11:17:01AM -0400, John Snow wrote:
>> On 9/23/20 11:14 AM, Markus Armbruster wrote:
>>> John Snow writes:
>>>
I'm proposing that I split the actual Python library off from the other
miscellaneous python scripts we have
Hi Will,
On 9/23/20 6:45 PM, Will Senn wrote:
> Long time user, first time poster :)
>
> So, I'd like to be able to run Minix 1.1 on my Macbook Pro mid-2012
> w/16gb RAM (MacOS 10.14.6 Mojave). Qemu will run pretty ancient OS'es
> such as DOS 2.0, which I use all of the time. However, I'm having
On 9/23/20 4:53 PM, John Snow wrote:
> On 8/17/20 7:17 AM, Kevin Wolf wrote:
>> Am 14.08.2020 um 10:28 hat Philippe Mathieu-Daudé geschrieben:
>>> Use self-explicit definitions instead of magic '512' value.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé
>>
>> BDRV_SECTOR_SIZE is the arbitrary unit
On 9/22/20 8:00 PM, Cleber Rosa wrote:
On Tue, Sep 22, 2020 at 05:00:25PM -0400, John Snow wrote:
This is a minor re-work of the entrypoint script. It isolates a
generate() method from the actual command-line mechanism.
Signed-off-by: John Snow
---
scripts/qapi-gen.py | 87 ++
Le 17/09/2020 à 16:07, Laurent Vivier a écrit :
> 'static build:' must display value of CONFIG_STATIC rather than value of
> CONFIG_TOOLS.
>
> Signed-off-by: Laurent Vivier
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> i
Le 16/09/2020 à 17:48, Laurent Vivier a écrit :
> Le 16/09/2020 à 17:26, Stefano Garzarella a écrit :
>> This patch fixes wrong indentation of some vdpa_ops fields introduced
>> with the initial commit 108a64818e ("vhost-vdpa: introduce vhost-vdpa
>> backend")
>>
>> Signed-off-by: Stefano Garzarell
Le 18/09/2020 à 14:53, Laurent Vivier a écrit :
> On 19/08/2020 16:43, Li Qiang wrote:
>> If g_malloc fails, the application will be terminated.
>> No need to check the return value of g_malloc.
>>
>> Signed-off-by: Li Qiang
>> ---
>> hw/virtio/vhost-vdpa.c | 7 +--
>> 1 file changed, 1 inser
Le 19/09/2020 à 12:18, Thomas Huth a écrit :
> Python still dumps its bytecode into the source directory, so
> we should continue to ignore the *.pyc files.
>
> Fixes: 0e72b7df4d ("Simplify the .gitignore file")
> Reported-by: Peter Maydell
> Signed-off-by: Thomas Huth
> ---
> .gitignore | 1 +
On 9/22/20 5:23 PM, Eduardo Habkost wrote:
+from qapi.commands import gen_commands
+from qapi.doc import gen_doc
+from qapi.error import QAPIError
+from qapi.events import gen_events
+from qapi.introspect import gen_introspect
+from qapi.schema import QAPISchema
+from qapi.types import gen_types
On 9/23/20 9:18 AM, Cleber Rosa wrote:
Relative imports are a source of heated debates, but when properly
used in a self contained module like here, they are very posititive
IMO.
Still? I know they were loathed pre-3.5, but in my subjective experience
they behave the nicest overall in the mode
23.09.2020 19:18, Alberto Garcia wrote:
On Wed 16 Sep 2020 02:20:05 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
-for (p = backing_bs(bs); p != base; p = backing_bs(p)) {
+for (p = backing_bs(bs); include_base || p != base; p = backing_bs(p)) {
ret = bdrv_co_block_status(p, wan
Le 21/09/2020 à 06:02, Philippe Mathieu-Daudé a écrit :
> checkpatch.pl report superfluous semicolons since commit
> ee0f3c09e01, but this one was missed:
>
> scripts/checkpatch.pl d32ca5ad798~..d32ca5ad798
> ERROR: superfluous trailing semicolon
> #498: FILE: migration/multifd.c:308:
> +
Le 20/09/2020 à 17:50, Philippe Mathieu-Daudé a écrit :
> timer_mod_anticipate() will be scaled to the timer unit,
> which is not always nanosecond. Fix the documentation.
>
> Fixes: add40e9777d ("timer: add timer_mod_anticipate*")
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/qemu/tim
Le 20/09/2020 à 17:59, Philippe Mathieu-Daudé a écrit :
> Cc'ing qemu-trivial@
>
> On 9/20/20 5:20 PM, Laurent Vivier wrote:
>> in vhost_vdpa_listener_region_del(), try_unmap is always true and so,
>> vhost_vdpa_dma_unmap() is always called. We can remove the variable
>>
>> Signed-off-by: Laurent
On 09/23/20 11:46, Igor Mammedov wrote:
> There were reports of guest crash on CPU hotplug, when using q35 machine
> type and OVMF with SMM, due to hotplugged CPU trying to process SMI at
> default SMI handler location without it being relocated by firmware first.
>
> Fix it by refusing hotplug if
It is currently unclear whether anybody is still using the 'moxie' CPU,
and there are no images for testing available this CPU, so the code has
likely bit-rotten in the course of time. When I asked the maintainer
for information, I did not get a reply within four weeks yet (see
https://lists.gnu.or
Le 23/09/2020 à 10:00, Thomas Huth a écrit :
> lm32 and unicore32 are softmmut targets, and not linux-user targets.
>
> Signed-off-by: Thomas Huth
> ---
> docs/system/deprecated.rst | 32
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/docs/
On 9/23/20 9:27 AM, Cleber Rosa wrote:
On Tue, Sep 22, 2020 at 05:00:28PM -0400, John Snow wrote:
Wildcard includes become hard to manage when refactoring and dealing
with circular dependencies with strictly typed mypy.
flake8 also flags each one as a warning, as it is not smart enough to
know
On 9/23/20 9:42 AM, Cleber Rosa wrote:
On Tue, Sep 22, 2020 at 05:00:30PM -0400, John Snow wrote:
Using `pylint --generate-rcfile > pylintrc`, generate a skeleton
pylintrc file. Sections that are not presently relevant (by the end of
this series) are removed leaving just the empty section as a s
On 9/22/20 6:22 PM, Eduardo Habkost wrote:
On Tue, Sep 22, 2020 at 05:00:32PM -0400, John Snow wrote:
Code style tools really dislike the use of global keywords, because it
generally involves re-binding the name at runtime which can have strange
effects depending on when and how that global name
On 9/23/20 10:55 AM, Cleber Rosa wrote:
Do you have a use case for returning the level? If not, I'd go
without it, and add a "level" property instead, as it'd serve more
cases.
__int__ is doing that lifting. I can remove the return.
--js
On 9/23/20 12:01 PM, Cleber Rosa wrote:
On Tue, Sep 22, 2020 at 05:00:33PM -0400, John Snow wrote:
At this point, that just means using a consistent strategy for constant names.
constants get UPPER_CASE and names not used externally get a leading underscore.
As a preference, while renaming cons
* Peter Xu (pet...@redhat.com) wrote:
> v2:
Queued
> - add r-bs for Dave
> - add patch "migration: Properly destroy variables on incoming side" as patch
> 1
> - destroy page_request_mutex in migration_incoming_state_destroy() too [Dave]
> - use WITH_QEMU_LOCK_GUARD in two places where we can [Da
Hello Paolo,
On Wednesday 23 of September 2020 17:48:09 Paolo Bonzini wrote:
> On 03/09/20 23:48, Pavel Pisa wrote:
> > The original CAN_PCI config option enables multiple SJA1000 PCI boards
> > emulation build. These boards bridge SJA1000 into I/O or memory
> > address space of the host CPU and d
This patch starts making the hcd-xhci.c pci free, as part of this
restructuring dma read/writes are handled without passing pci object.
Signed-off-by: Sai Pavan Boddu
Reviewed-by: Edgar E. Iglesias
---
hw/usb/hcd-xhci.c | 24 +++-
hw/usb/hcd-xhci.h | 1 +
2 files changed, 1
Use XHCI as sysbus device, add memory region property to get the
address space instance for dma read/write.
Signed-off-by: Sai Pavan Boddu
---
hw/usb/Kconfig | 5 +++
hw/usb/hcd-xhci-sysbus.c | 109 +++
hw/usb/hcd-xhci-sysbus.h | 32 ++
From: Vikram Garhwal
Connect dwc3 controller and usb2-reg module to xlnx-versal SOC, its placed
in iou of lpd domain and configure it as dual port host controller. Add the
respective guest dts nodes for "xlnx-versal-virt" machine.
Signed-off-by: Vikram Garhwal
Signed-off-by: Sai Pavan Boddu
--
On Wed 16 Sep 2020 02:20:05 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
> In order to reuse bdrv_common_block_status_above in
> bdrv_is_allocated_above, let's support include_base parameter.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
This patch series attempts to make 'hcd-xhci' an independent model so
it can be used by both pci and system-bus interface.
Changes for V2:
Make XHCIState non-qom
Use container_of functions for retriving pci device instance
Initialize the AddressSpace pointer in PATCH 1/3 itself
Changes
This patch sets the base to use xhci as sysbus model, for which pci
specific hooks are moved to hcd-xhci-pci.c. As a part of this requirment
msi/msix interrupts handling is moved under XHCIPCIState. Made required
changes for qemu-xhci-nec.
Signed-off-by: Sai Pavan Boddu
---
hw/usb/hcd-xhci-nec.c
This module emulates control registers of versal usb2 controller, this is added
just to make guest happy. In general this module would control the phy-reset
signal from usb controller, data coherency of the transactions, signals
the host system errors received from controller.
Signed-off-by: Sai P
Move pci specific devices to new file. This set the environment to move all
pci specific hooks in hcd-xhci.c to hcd-xhci-pci.c.
Signed-off-by: Sai Pavan Boddu
---
hw/usb/Kconfig| 6 +
hw/usb/hcd-xhci-pci.c | 66 +++
hw/usb/hcd-xhci.c
From: Vikram Garhwal
This patch adds skeleton model of dwc3 usb controller attached to
xhci-sysbus device. It defines global register space of DWC3 controller,
global registers control the AXI/AHB interfaces properties, external FIFO
support and event count support. All of which are unimplemented
On 9/23/20 11:53 AM, Philippe Mathieu-Daudé wrote:
Hi Will,
On 9/23/20 6:45 PM, Will Senn wrote:
Long time user, first time poster :)
So, I'd like to be able to run Minix 1.1 on my Macbook Pro mid-2012
w/16gb RAM (MacOS 10.14.6 Mojave). Qemu will run pretty ancient OS'es
such as DOS 2.0, which
On Wed 23 Sep 2020 07:11:57 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
>> BlockDriverState *last_bs = include_base ? base : backing_bs(base);
>
> hmm, in case when include_base is false, last bs is not
> backing_bs(base) but the parent of base.
Oops, yes, it should be the other way around %-
On 9/22/20 6:44 PM, Eduardo Habkost wrote:
Does this need to require a Sequence? It looks like it could be
Iterable.
I don't think this should block the patch, though, so:
Reviewed-by: Eduardo Habkost
gen_if can take an Iterator, gen_endif needs a Sequence because it uses
reversed().
I ha
Hi Gerd,
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, September 23, 2020 3:44 PM
> To: Sai Pavan Boddu
> Cc: Peter Maydell ; Markus Armbruster
> ; 'Marc-André Lureau'
> ; Paolo Bonzini ;
> Edgar Iglesias ; Francisco Eduardo Iglesias
> ; qemu-devel@nongnu.org; Alistair Fr
Queued
* Chuan Zheng (zhengch...@huawei.com) wrote:
> v9 -> v10:
> rename find_page_matched as find_block_matched
> fix wrong termination condition in find_block_matched
> add review-by for patches
>
> v8 -> v9:
> fix wrong index return of record_ramblock_hash_info
> optimize
On 9/18/20 8:12 AM, Alex Bennée wrote:
Li Qiang writes:
Philippe Mathieu-Daudé 于2020年8月19日周三 下午11:07写道:
On 8/19/20 4:43 PM, Li Qiang wrote:
If g_malloc fails, the application will be terminated.
Which we don't want... better to use g_try_malloc() instead?
I don't think so. If g_malloc
On 23/09/20 19:44, Pavel Pisa wrote:
>
> If you have not pushed code to the mainline yet,
> consider v3 which should follow better actual
> mainline state. The list of updates to v3 follows.
I actually queued v3 (I just use patchew to queue patches).
Paolo
Hello Paolo,
On Wednesday 23 of September 2020 20:11:08 Paolo Bonzini wrote:
> On 23/09/20 19:44, Pavel Pisa wrote:
> > If you have not pushed code to the mainline yet,
> > consider v3 which should follow better actual
> > mainline state. The list of updates to v3 follows.
>
> I actually queued v3
On Fri 04 Sep 2020 10:25:13 AM CEST, Kevin Wolf wrote:
>> Test 030 is still occasionally failing in the CI ... so for the
>> time being, let's disable it in the "auto" group. We can add it
>> back once it got more stable.
>>
>> Signed-off-by: Thomas Huth
>
> I would rather just disable this one t
On 9/23/20 1:04 PM, Dr. David Alan Gilbert wrote:
Queued
* Chuan Zheng (zhengch...@huawei.com) wrote:
v9 -> v10:
rename find_page_matched as find_block_matched
fix wrong termination condition in find_block_matched
add review-by for patches
Sorry for a late review, but I suggest
The Zoned Namespace Command Set / Namespace Types implementation that
is being introduced in this series adds a good number of trace events.
Combine all tracepoint definitions into a separate patch to make
reviewing more convenient.
Signed-off-by: Dmitry Fomichev
---
hw/block/trace-events | 26 +
On Wed, Sep 23, 2020 at 01:57:25PM -0400, John Snow wrote:
> On 9/22/20 6:44 PM, Eduardo Habkost wrote:
> > Does this need to require a Sequence? It looks like it could be
> > Iterable.
> >
> > I don't think this should block the patch, though, so:
> >
> > Reviewed-by: Eduardo Habkost
>
> gen_i
On 9/16/20 1:22 AM, Chuan Zheng wrote:
Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be
called
Signed-off-by: Chuan Zheng
---
+++ b/qapi/migration.json
@@ -1737,3 +1737,53 @@
##
{ 'enum': 'DirtyRateStatus',
'data': [ 'unstarted', 'measuring', 'measured'] }
A few trace events are defined that are relevant to implementing
Namespace Types (NVMe TP 4056).
Signed-off-by: Dmitry Fomichev
Reviewed-by: Klaus Jensen
Reviewed-by: Philippe Mathieu-Daudé
---
hw/block/trace-events | 10 ++
1 file changed, 10 insertions(+)
diff --git a/hw/block/trace
The emulation code has been changed to advertise NVM Command Set when
"zoned" device property is not set (default) and Zoned Namespace
Command Set otherwise.
Handlers for three new NVMe commands introduced in Zoned Namespace
Command Set specification are added, namely for Zone Management
Receive,
Calculate the data shift value to report based on the set value of
logical_block_size device property.
In the process, use a local variable to calculate the LBA format
index instead of the hardcoded value 0. This makes the code more
readable and it will make it easier to add support for multiple L
Define values and structures that are needed to support Zoned
Namespace Command Set (NVMe TP 4053) in PCI NVMe controller emulator.
All new protocol definitions are located in include/block/nvme.h
and everything added that is specific to this implementation is kept
in hw/block/nvme.h.
In order to
v3 -> v4
- Fix bugs introduced in v2/v3 for QD > 1 operation. Now, all writes
to a zone happen at the new write pointer variable, zone->w_ptr,
that is advanced right after submitting the backend i/o. The existing
zone->d.wp variable is updated upon the successful write completion
and
From: Niklas Cassel
Namespace Types introduce a new command set, "I/O Command Sets",
that allows the host to retrieve the command sets associated with
a namespace. Introduce support for the command set and enable
detection for the NVM Command Set.
The new workflows for identify commands rely hea
A ZNS drive that is emulated by this module is currently initialized
with all zones Empty upon startup. However, actual ZNS SSDs save the
state and condition of all zones in their internal NVRAM in the event
of power loss. When such a drive is powered up again, it closes or
finishes all zones that
This log page becomes necessary to implement to allow checking for
Zone Append command support in Zoned Namespace Command Set.
This commit adds the code to report this log page for NVM Command
Set only. The parts that are specific to zoned operation will be
added later in the series.
Signed-off-b
Added two module properties, "max_active" and "max_open" to control
the maximum number of zones that can be active or open. Once these
variables are set to non-default values, these limits are checked
during I/O and Too Many Active or Too Many Open command status is
returned if they are exceeded.
From: Niklas Cassel
In NVMe, a namespace is active if it exists and is attached to the
controller.
CAP.CSS (together with the I/O Command Set data structure) defines what
command sets are supported by the controller.
CC.CSS (together with Set Profile) can be set to enable a subset of the
availa
Added brief descriptions of the new device properties that are
now available to users to configure features of Zoned Namespace
Command Set in the emulator.
This patch is for documentation only, no functionality change.
Signed-off-by: Dmitry Fomichev
---
hw/block/nvme.c | 43
From: Niklas Cassel
Define the structures and constants required to implement
Namespace Types support.
Signed-off-by: Niklas Cassel
Signed-off-by: Dmitry Fomichev
---
hw/block/nvme.c | 2 +-
hw/block/nvme.h | 3 ++
include/block/nvme.h | 74 +++-
On 9/23/20 10:50 AM, Eduardo Habkost wrote:
On Tue, Sep 22, 2020 at 05:00:43PM -0400, John Snow wrote:
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Oops, I didn't use my consistent type hint commit message for this one.
Changing that to avoid my invented word "notational".
--j
On Wed, Sep 23, 2020 at 05:19:00PM +0200, Philippe Mathieu-Daudé wrote:
> To limit the number of checkpatch errors in the next commit,
> clean coding style issues first.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> False positive:
>
> ERROR: Use of volatile is usually wrong, please add a c
Zone Descriptor Extension is a label that can be assigned to a zone.
It can be set to an Empty zone and it stays assigned until the zone
is reset.
This commit adds a new optional module property, "zone_descr_ext_size".
Its value must be a multiple of 64 bytes. If this value is non-zero,
it becomes
On 9/23/20 11:44 AM, Eduardo Habkost wrote:
On Tue, Sep 22, 2020 at 05:00:52PM -0400, John Snow wrote:
'fp' and 'fd' are self-evident in context, add them to the list of OK
names.
_top and _bottom also need to stay class methods because some users
override the method and need to use `self`. Tel
On Wed, Sep 23, 2020 at 03:42:30PM +0200, Markus Armbruster wrote:
> Stefan Hajnoczi writes:
>
> > Use the new QAPI block exports API instead of defining our own QOM
> > objects.
> >
> > This is a large change because the lifecycle of VuBlockDev needs to
> > follow BlockExportDriver. QOM properti
ZNS specification defines two zone conditions for the zones that no
longer can function properly, possibly because of flash wear or other
internal fault. It is useful to be able to "inject" a small number of
such zones for testing purposes.
This commit defines two optional device properties, "offl
On 9/23/20 11:17 AM, Eduardo Habkost wrote:
This changes behavior if name=='', and I guess this is OK, but
I'm not sure. I miss documentation on `visit_module()`,
`visit_include()`, and `_is_user_module()`. I don't know what
`name` means here, and what is a "user module".
Good spot, I missed
On Wed, Sep 23, 2020 at 02:29:28PM -0400, John Snow wrote:
> On 9/23/20 11:17 AM, Eduardo Habkost wrote:
> > This changes behavior if name=='', and I guess this is OK, but
> > I'm not sure. I miss documentation on `visit_module()`,
> > `visit_include()`, and `_is_user_module()`. I don't know what
On 9/23/20 10:48 AM, Eduardo Habkost wrote:
On Tue, Sep 22, 2020 at 05:00:41PM -0400, John Snow wrote:
Signed-off-by: John Snow
---
scripts/qapi/events.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi/events.py b/scripts/qapi/events.py
index 00a9513c16..
On Tue, Sep 22, 2020 at 05:00:55PM -0400, John Snow wrote:
> Replacing the un-typed tuple, add a typed Node that we can add typed
> metadata to.
>
> Signed-off-by: John Snow
This is the most complex patch so far, and it's very hard to
understand what it does without type annotations.
Have you c
On 9/23/20 11:26 AM, Eduardo Habkost wrote:
On Tue, Sep 22, 2020 at 05:00:51PM -0400, John Snow wrote:
Make the file handling here just a tiny bit more idiomatic.
(I realize this is heavily subjective.)
Use exist_ok=True for os.makedirs and remove the exception,
use fdopen() to wrap the file de
Patchew URL: https://patchew.org/QEMU/20200923151901.745277-1-phi...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200923151901.745277-1-phi...@redhat.com
Subject: [PATCH v4 0/2] qemu/atomic.h: rename ato
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
> * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote:
> > When running the xen-save-devices-state QMP command, if the filename
> > already exists it will be truncated before dumping the devices' state
> > into it.
> >
> > Signed-off-by: Dov Murik
201 - 300 of 424 matches
Mail list logo