[PULL 12/15] goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN

2020-10-12 Thread Laurent Vivier
From: Laurent Vivier The doc [1] doesn't define the endianness, but the kernel driver uses readl() to access the registers, so we can guess it depends on the architecture endianness. As riscv architecture endianness is little it might not change anything for it. Moreover, android implementation

[PULL 09/15] hw/pci: Fix typo in PCI hot-plug error message

2020-10-12 Thread Laurent Vivier
From: Julia Suvorova 'occupied' is spelled like 'ocuppied' in the message. Signed-off-by: Julia Suvorova Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201006133958.600932-1-jus...@redhat.com> Signed-off-by: Laurent Vivier --- hw/pci/pci.c | 2 +- hw/ppc/spapr_pci.c | 2 +- 2 files

[PULL 07/15] hw/acpi/piix4: Rename piix4_pm_add_propeties() to piix4_pm_add_properties()

2020-10-12 Thread Laurent Vivier
From: Greg Kurz Signed-off-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang Message-Id: <160165476743.57452.2128307974125615413.st...@bahia.lan> Signed-off-by: Laurent Vivier --- hw/acpi/piix4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw

[PULL 08/15] softmmu/memory: Log invalid memory accesses

2020-10-12 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Log invalid memory accesses with as GUEST_ERROR. This is particularly useful since commit 5d971f9e67 which reverted ("memory: accept mismatching sizes in memory_region_access_valid"). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Message-Id

[PULL 05/15] tests/test-char: Use a proper fallthrough comment

2020-10-12 Thread Laurent Vivier
From: Thomas Huth For being able to compile with -Werror=implicit-fallthrough we need to use comments that the compiler recognizes. Use "fallthrough" instead of "no break" here. Signed-off-by: Thomas Huth Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe M

[PULL 02/15] target/i386/cpu: Update comment that mentions Texinfo

2020-10-12 Thread Laurent Vivier
From: Markus Armbruster Missed in commit 41fba1618b "docs/system: convert the documentation of deprecated features to rST." Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200929075824.1517969-3-arm...@redhat.com> Signed-off-by: Laurent Vivier --- target/i

[PULL 10/15] block/blkdebug: fix memory leak

2020-10-12 Thread Laurent Vivier
From: Elena Afanasova Spotted by PVS-Studio Signed-off-by: Elena Afanasova Reviewed-by: Eric Blake Message-Id: <1e903f928eb3da332cc95e2a6f87243bd9fe66e4.ca...@gmail.com> Signed-off-by: Laurent Vivier --- block/blkdebug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blkdebug.c b/

[PULL 03/15] hw/rtc/twl92230: Silence warnings about missing fallthrough statements

2020-10-12 Thread Laurent Vivier
From: Thomas Huth When compiling with -Werror=implicit-fallthrough, gcc complains about missing fallthrough annotations in this file. Looking at the code, the fallthrough is indeed wanted here, but instead of adding the annotations, it can be done more efficiently by simply calculating the offset

[PULL 00/15] Trivial branch for 5.2 patches

2020-10-12 Thread Laurent Vivier
The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int= o staging (2020-10-12 11:29:42 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2

[PULL 01/15] qemu-img-cmds.hx: Update comment that mentions Texinfo

2020-10-12 Thread Laurent Vivier
From: Markus Armbruster Missed in 3c95fdef94 "Update comments in .hx files that mention Texinfo". Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200929075824.1517969-2-arm...@redhat.com> Signed-off-by: Laurent Vivier --- qemu-img-cmds.hx | 2 +- 1 file ch

Re: Why guest physical addresses are not the same as the corresponding host virtual addresses in QEMU/KVM? Thanks!

2020-10-12 Thread Paolo Bonzini
On 13/10/20 07:46, harry harry wrote: > Now, let's assume array[0]'s GPA is different from its corresponding > HVA. I think there might be one issue like this: I think MMU's hardware > logic to translate ``GPA ->[extended/nested page tables] -> HPA''[1] > should be the same as ``VA-> [page tables]

[Bug 1775702] Re: High host CPU load and slower guest after upgrade guest OS Windows 10 to ver 1803

2020-10-12 Thread Thomas Huth
Gannet, SPICE Guest Tools is certainly a different problem, you should report that to the spice project instead. And since the original problem was apparently fixed via hv_synic / hv_stimer (if I got the comments right), I'm closing this ticket now. ** Changed in: qemu Status: New => Fix Re

Re: [RFC PATCH 14/21] contrib/gitdm: Add Samsung to the domain map

2020-10-12 Thread Klaus Jensen
On Oct 4 20:04, Philippe Mathieu-Daudé wrote: > There is a number of contributors from this domain, > add its own entry to the gitdm domain map. > > Cc: Alexey Perevalov > Cc: Bartlomiej Zolnierkiewicz > Cc: Evgeny Voevodin > Cc: Igor Mitsyanko > Cc: Igor Skalkin > Cc: Ilya Maximets > Cc: J

Re: [PATCH] tests/migration: Allow longer timeouts

2020-10-12 Thread Thomas Huth
On 12/10/2020 15.13, Thomas Huth wrote: > On 08/10/2020 18.03, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" >> >> In travis, with gcov and gprof we're seeing timeouts; hopefully fix >> this by increasing the test timeouts a bit, but for xbzrle ensure it >> really does get

Re: Why guest physical addresses are not the same as the corresponding host virtual addresses in QEMU/KVM? Thanks!

2020-10-12 Thread harry harry
BTW, I assume the software logic for KVM to find the HPA with a given HVA (as you said like below) should be the same as the hardware logic in MMU to translate ``GPA -> [extended/nested page tables] -> HPA''. If this is true, I cannot understand how KVM can find a correct HPA with an HVA (e.g., ar

Re: [PATCH] hw/net: move allocation to the heap due to very large stack frame

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 03:45:02PM +0200, Paolo Bonzini wrote: > On 12/10/20 12:44, Thomas Huth wrote: > > I think this is one of the tasks from: > > > > https://wiki.qemu.org/Contribute/BiteSizedTasks#Compiler-driven_cleanups > > > > It has been added by Paolo in 2016: > > > > > > https://wi

Re: Why guest physical addresses are not the same as the corresponding host virtual addresses in QEMU/KVM? Thanks!

2020-10-12 Thread harry harry
Hi Sean, Thanks for the prompt reply. Please see my following reply. Thanks. On Tue, Oct 13, 2020 at 12:52 AM Sean Christopherson < sean.j.christopher...@intel.com> wrote: > > On Tue, Oct 13, 2020 at 12:30:39AM -0400, harry harry wrote: > > Hi Sean, > > > > Thank you very much for your thorough e

[Qemu-devel][PATCH v6 6/6] x86/cpu: Advise CET bits in CPU/MSR feature words

2020-10-12 Thread Yang Weijiang
CET SHSTK and IBT feature are enumerated via CPUID.(EAX=07H,ECX=0H):ECX[bit 7] and EDX[bit 20]. CET state load/restore at vmentry/vmexit are enabled via VMX_ENTRY_CTLS[bit 20] and VMX_EXIT_CTLS[bit 28]. Signed-off-by: Yang Weijiang --- target/i386/cpu.c | 8 1 file changed, 4 insertions

[Qemu-devel][PATCH v6 5/6] x86/cpu: Add CET state support for guest migration

2020-10-12 Thread Yang Weijiang
Save the MSRs being used on source machine and restore them on destination machine. Signed-off-by: Yang Weijiang --- target/i386/machine.c | 161 ++ 1 file changed, 161 insertions(+) diff --git a/target/i386/machine.c b/target/i386/machine.c index b1acf7d

[Qemu-devel][PATCH v6 1/6] x86/cpu: Rename XSAVE related feature words.

2020-10-12 Thread Yang Weijiang
With more components in XSS being developed on Intel platform, it's necessary to clean up existing XSAVE related feature words to make the name clearer. It's to prepare for adding CET related support in following patches. Signed-off-by: Yang Weijiang --- target/i386/cpu.c| 60 +++

[Qemu-devel][PATCH v6 3/6] x86/cpu: Enable CET components support for XSAVE

2020-10-12 Thread Yang Weijiang
CET Shadow Stack(SHSTK) and Indirect Branch Tracking(IBT) are enumerated via CPUID.(EAX=07H,ECX=0H):ECX[bit 7] and EDX[bit 20] respectively. Two CET bits (bit 11 and 12) are defined in MSR_IA32_XSS for XSAVE. They correspond to CET states in user and supervisor mode respectively. Signed-off-by: Ya

[Qemu-devel][PATCH v6 2/6] x86/cpuid: Enable XSS feature enumeration for CPUID

2020-10-12 Thread Yang Weijiang
Currently, CPUID.(EAX=0DH,ECX=01H) doesn't enumerate features in XSS properly, add the support here. XCR0 bits indicate user-mode XSAVE components, and XSS bits indicate supervisor-mode XSAVE components. Signed-off-by: Yang Weijiang --- target/i386/cpu.c | 48

[Qemu-devel][PATCH v6 4/6] x86/cpu: Add user-space MSR access interface for CET

2020-10-12 Thread Yang Weijiang
CET states are divided into user-mode and supervisor-mode states, MSR_KVM_GUEST_SSP stores current SHSTK pointer in use, MSR_IA32_U_CET and MSR_IA32_PL3_SSP are for user-mode states, others are for supervisor-mode states. Expose the access according to current CET supported bits in CPUID and XSS.

[Qemu-devel][PATCH v6 0/6] Enable CET support for guest

2020-10-12 Thread Yang Weijiang
Control-flow Enforcement Technology (CET) provides protection against Return/Jump-Oriented Programming (ROP/JOP). It includes two sub-features: Shadow Stack(SHSTK) and Indirect Branch Tracking(IBT). This patchset is for guest CET enabling. It enclosed patches for XSS feature report and CET CPUID en

Re: Why guest physical addresses are not the same as the corresponding host virtual addresses in QEMU/KVM? Thanks!

2020-10-12 Thread harry harry
BTW, I still have one more question as follows. Thanks! On Mon, Oct 12, 2020 at 12:54 PM Sean Christopherson wrote: > > No, the guest physical address spaces is not intrinsically tied to the host > virtual address spaces. The fact that GPAs and HVAs are related in KVM is a > property KVM's archi

Re: Why guest physical addresses are not the same as the corresponding host virtual addresses in QEMU/KVM? Thanks!

2020-10-12 Thread Sean Christopherson
On Tue, Oct 13, 2020 at 12:30:39AM -0400, harry harry wrote: > Hi Sean, > > Thank you very much for your thorough explanations. Please see my > inline replies as follows. Thanks! > > On Mon, Oct 12, 2020 at 12:54 PM Sean Christopherson > wrote: > > > > No, the guest physical address spaces is no

Re: Why guest physical addresses are not the same as the corresponding host virtual addresses in QEMU/KVM? Thanks!

2020-10-12 Thread harry harry
Hi Sean, Thank you very much for your thorough explanations. Please see my inline replies as follows. Thanks! On Mon, Oct 12, 2020 at 12:54 PM Sean Christopherson wrote: > > No, the guest physical address spaces is not intrinsically tied to the host > virtual address spaces. The fact that GPAs

Re: [PATCH v3 34/81] target/arm: Implement SVE2 WHILERW, WHILEWR

2020-10-12 Thread LIU Zhiwei
On 2020/9/19 2:37, Richard Henderson wrote: Signed-off-by: Richard Henderson --- v2: Fix decodetree typo --- target/arm/sve.decode | 3 ++ target/arm/translate-sve.c | 62 ++ 2 files changed, 65 insertions(+) diff --git a/target/arm/sve.decode b/t

[PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-10-12 Thread Alexey Kardashevskiy
The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of the firmware (RTAS) has been implemented as a 2

Re: [PATCH 00/10] iOS and Apple Silicon host support

2020-10-12 Thread Joelle van Dyne
I did run the style check tool. Of the errors/warnings, a few are from code moved from one place to another, re-formatting the moved code seems to break another rule (don't include irrelevant changes). On Mon, Oct 12, 2020 at 6:21 PM wrote: > > Patchew URL: https://patchew.org/QEMU/202010122329

Re: [PATCH qemu v9] spapr: Implement Open Firmware client interface

2020-10-12 Thread Alexey Kardashevskiy
On 12/10/2020 22:51, Greg Kurz wrote: On Mon, 12 Oct 2020 13:40:33 +0200 BALATON Zoltan via wrote: On Mon, 12 Oct 2020, Alexey Kardashevskiy wrote: On 29/09/2020 20:35, Alexey Kardashevskiy wrote: On 16/07/2020 23:22, David Gibson wrote: On Thu, Jul 16, 2020 at 07:04:56PM +1000, Alexey

Re: [PATCH] migration/block-dirty-bitmap: fix uninitialized variable warning

2020-10-12 Thread Li Qiang
Laurent Vivier 于2020年10月12日周一 下午11:33写道: > > Le 10/10/2020 à 13:07, Chen Qun a écrit : > > This if statement judgment is redundant and it will cause a warning: > > > > migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ may be used > > uninitialized in this function [-Wmaybe-uninitiali

Re: [PATCH 00/10] iOS and Apple Silicon host support

2020-10-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201012232939.48481-...@getutm.app/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201012232939.48481-...@getutm.app Subject: [PATCH 00/10] iOS and Apple Silicon host support ==

[PATCH 07/10] tcg: implement bulletproof JIT

2020-10-12 Thread Joelle van Dyne
From: osy On iOS, we cannot allocate RWX pages without special entitlements. As a workaround, we can a RX region and then mirror map it to a separate RX region. Then we can write to one region and execute from the other one. To better keep track of pointers to RW/RX memory, we mark any tcg_insn_

Re: [PATCH] hw/core/qdev-properties: Fix pci bus range in set_pci_host_devaddr()

2020-10-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201012225831.72920-1-kher...@inbox.lv/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201012225831.72920-1-kher...@inbox.lv Subject: [PATCH] hw/core/qdev-properties: Fix pci bus

[PATCH 2/2] gcrypt: Enable crypto tests under msys2/mingw

2020-10-12 Thread Yonggang Luo
Fixes following tests on msys2/mingw 'test-crypto-tlscredsx509' test-crypto-tlssession' 'test-io-channel-tls' These tests are failure with: ERROR test-crypto-tlscredsx509 - missing test plan ERROR test-crypto-tlssession - missing test plan ERROR test-io-channel-tls - missing test plan Because on

[PATCH 09/10] tcg: support JIT on Apple Silicon

2020-10-12 Thread Joelle van Dyne
From: osy https://developer.apple.com/documentation/apple_silicon/porting_just-in-time_compilers_to_apple_silicon For < iOS 14, reverse engineered functions from libsystem_pthread.dylib is implemented to handle APRR supported SoCs. The following rules apply for JIT write protect: * JIT write-

[PATCH 1/2] gcrypt: test_tls_psk_init should write binary file instead text file.

2020-10-12 Thread Yonggang Luo
On windows, if open file with "w", it's will automatically convert "\n" to "\r\n" when writing to file. Signed-off-by: Yonggang Luo --- tests/crypto-tls-psk-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/crypto-tls-psk-helpers.c b/tests/crypto-tls-psk-helpers

Re: Which qemu change corresponds to RedHat bug 1655408

2020-10-12 Thread Jakob Bohm
On 2020-10-12 13:47, Max Reitz wrote: On 09.10.20 14:55, Jakob Bohm wrote: On 2020-10-09 10:48, Max Reitz wrote: On 08.10.20 18:49, Jakob Bohm wrote: (Top posting because previous reply did so): If the bug was closed as "can't reproduce", why was a very similar bug listed as fixed in RHSA-201

[PATCH 0/2] Fixes gcrypt testing on msys2/mingw

2020-10-12 Thread Yonggang Luo
gcrypt: test_tls_psk_init should write binary file instead text file. gcrypt: Enable crypto tests under msys2/mingw by implement custom qemu_socket= pair Yonggang Luo (2): gcrypt: test_tls_psk_init should write binary file instead text file. gcrypt: Enable crypto tests under msys2/mingw incl

[Bug 1899539] Re: keyboard errors in DOS, found links to similar errors for reference

2020-10-12 Thread p kirkham
Also seems similar to https://bugs.launchpad.net/qemu/+bug/1897568 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1899539 Title: keyboard errors in DOS, found links to similar errors for reference

[PATCH 06/10] coroutine: add libucontext as external library

2020-10-12 Thread Joelle van Dyne
From: osy iOS does not support ucontext natively for aarch64 and the sigaltstack is also unsupported (even worse, it fails silently, see: https://openradar.appspot.com/13002712 ) As a workaround we include a library implementation of ucontext and add it as a build option. Signed-off-by: Joelle

[PATCH 05/10] slirp: update for iOS resolv fix

2020-10-12 Thread Joelle van Dyne
From: osy We cannot access /etc/resolv.conf on iOS so libslirp is modified to use libresolv instead. Signed-off-by: Joelle van Dyne --- .gitmodules | 2 +- meson.build | 2 ++ slirp | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.gitmodules b/.gitmodules index 2bd

[PATCH 10/10] block: check availablity for preadv/pwritev on mac

2020-10-12 Thread Joelle van Dyne
From: osy macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 12 +

[PATCH 02/10] configure: cross-compiling without cross_prefix

2020-10-12 Thread Joelle van Dyne
From: osy The iOS toolchain does not use the host prefix naming convention. We add a new option `--enable-cross-compile` that forces cross-compile even without a cross_prefix. Signed-off-by: Joelle van Dyne --- configure | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff

[PATCH] hw/core/qdev-properties: Fix pci bus range in set_pci_host_devaddr()

2020-10-12 Thread Klaus Herman
--- hw/core/qdev-properties-system.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c index 49bdd12..e3dca56 100644 --- a/hw/core/qdev-properties-system.c +++ b/hw/core/qdev-properties-system.c @@ -903,7 +903,7

[PATCH 04/10] meson: option to build as shared library

2020-10-12 Thread Joelle van Dyne
From: osy On iOS, we cannot fork() new processes, so the best way to load QEMU into an app is through a shared library. We add a new configure option `--enable-shared-lib` that will build the bulk of QEMU into a shared lib. The usual executables will then link to the library. Signed-off-by: Joel

[PATCH 08/10] tcg: mirror mapping RWX pages for iOS optional

2020-10-12 Thread Joelle van Dyne
From: osy This allows jailbroken devices with entitlements to switch the option off. Signed-off-by: Joelle van Dyne --- accel/tcg/tcg-all.c | 27 +- accel/tcg/translate-all.c | 60 +-- bsd-user/main.c | 2 +- include/sysemu/t

[PATCH 00/10] iOS and Apple Silicon host support

2020-10-12 Thread Joelle van Dyne
These set of changes brings QEMU TCG to iOS devices and future Apple Silicon devices. They were originally developed last year and have been working in the UTM app. Recently, we ported the changes to master, re-wrote a lot of the build script changes for meson, and broke up the patches into more di

[PATCH 01/10] configure: option to disable host block devices

2020-10-12 Thread Joelle van Dyne
From: osy Some hosts (iOS) have a sandboxed filesystem and do not provide low-level APIs for interfacing with host block devices. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 8 +++- configure | 4 meson.build| 1 + 3 files changed, 12 insertions(+), 1 dele

[PATCH 03/10] qemu: add support for iOS host

2020-10-12 Thread Joelle van Dyne
From: osy This introduces support for building for iOS hosts. When the correct Xcode toolchain is used, iOS host will be detected automatically. block: disable features not supported by iOS sandbox slirp: disable SMB features for iOS target: disable system() calls for iOS tcg: use sys_icache_inv

Re: [PATCH 4/5] hw: Use the PCI_SLOT() macro from 'hw/pci/pci.h'

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 02:45:05PM +0200, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > We already have a generic PCI_SLOT() macro in "hw/pci/pci.h" > to extract the PCI slot identifier, use it. > > Signed-off-by: Philippe Mathieu-Daudé ppc parts Acked-by: David Gibson > -

Re: [PATCH 2/5] hw/pci-host: Use the PCI_BUILD_BDF() macro from 'hw/pci/pci.h'

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 02:45:03PM +0200, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > We already have a generic PCI_BUILD_BDF() macro in "hw/pci/pci.h" > to pack these values, use it. > > Signed-off-by: Philippe Mathieu-Daudé pnv part Acked-by: David Gibson > --- > hw/

Re: [PATCH 3/5] hw/pci-host/uninorth: Use the PCI_FUNC() macro from 'hw/pci/pci.h'

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 02:45:04PM +0200, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > We already have a generic PCI_FUNC() macro in "hw/pci/pci.h" to > extract the PCI function identifier, use it. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: David Gibson > --- >

Re: [PATCH 5/5] hw: Use the PCI_DEVFN() macro from 'hw/pci/pci.h'

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 02:45:06PM +0200, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > We already have a generic PCI_DEVFN() macro in "hw/pci/pci.h" > to pack the PCI slot/function identifiers, use it. > > Signed-off-by: Philippe Mathieu-Daudé ppc part Acked-by: David Gibs

Re: [PATCH] spapr: Clarify why DR connectors aren't user creatable

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 01:26:39PM +0200, Greg Kurz wrote: > DR connector is a device that emulates a firmware abstraction used by PAPR > compliant guests to manage hotplug/dynamic-reconfiguration of PHBs, PCI > devices, memory, and CPUs. > > It is internally created by the spapr platform and requ

Re: [PATCH] spapr: Move spapr_create_nvdimm_dr_connectors() to core machine code

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 12:15:21PM +0200, Greg Kurz wrote: > The spapr_create_nvdimm_dr_connectors() function doesn't need to access > any internal details of the sPAPR NVDIMM implementation. Also, pretty > much like for the LMBs, only spapr_machine_init() is responsible for the > creation of DR co

Re: [PATCH v6 0/5] Enable plugin support on msys2/mingw

2020-10-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201013002806.1447-1-luoyongg...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201013002806.1447-1-luoyongg...@gmail.com Subject: [PATCH v6 0/5] Enable plugin suppor

[PATCH v6 5/5] cirrus: Enable plugins in cirrus for windows

2020-10-12 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- .cirrus.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.cirrus.yml b/.cirrus.yml index 2c6bf45e6d..56ccb25bec 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -129,6 +129,7 @@ windows_msys2_task: script: - C:\tools\msys64\usr\bin\bash.exe -lc "mkdir b

[PATCH v6 4/5] plugins: Getting qemu-plugin.h can be included in multiple source file

2020-10-12 Thread Yonggang Luo
If we only have a single .c file in a plugin, then define QEMU_PLUGIN_EXTERN to empty is OK, but if we have multiple .c files in a plugin, then we need distinguish the implementation and the deceleration. only the main .c file should define the macro QEMU_PLUGIN_IMPLEMENTATION other sources are us

[PATCH v6 3/5] plugins: Getting qemu-plugin works under win32.

2020-10-12 Thread Yonggang Luo
Define QEMU_PLUGIN_API_IMPLEMENTATION in api.c and core.c We removed the need of .symbols file, so is the configure script, if we one expose a function to qemu-plugin just need prefix the function with QEMU_PLUGIN_EXPORT We use QEMU_PLUGIN_EXPORT export the functions in api.c and core.c and loadin

[PATCH v6 0/5] Enable plugin support on msys2/mingw

2020-10-12 Thread Yonggang Luo
V5-V6 Skip merged patches V3-V4 Split plugin: Fixes typo in qemu-plugin.h out Trying to explain the design of plugin: Getting qemu-plugin works under win32. V1-V2 1. Fixes review comments 2. Increase QEMU_PLUGIN_VERSION to 1 for compat QEMU_PLUGIN_VERSION 0 3. Revise the loader to support for v

[PATCH v6 2/5] plugins: Fixes typo in qemu-plugin.h

2020-10-12 Thread Yonggang Luo
Getting the comment consistence with the function name Signed-off-by: Yonggang Luo --- include/qemu/qemu-plugin.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index bab8b0d4b3..daac8291b8 100644 --- a/include/qemu

[PATCH v6 1/5] plugins: getting qemu_plugin_get_hwaddr only expose one function prototype

2020-10-12 Thread Yonggang Luo
This is used for counting how much function are export to qemu plugin. Signed-off-by: Yonggang Luo Reviewed-by: Alex Bennée --- plugins/api.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/plugins/api.c b/plugins/api.c index bbdc5a4eb4..13177d3578 100644 --- a/plugi

[PATCH v2 2/2] block: enable libnfs on msys2/mingw in cirrus.yml

2020-10-12 Thread Yonggang Luo
At the begging libnfs are not enabled because of compiling error, now it's fixed so enable it Signed-off-by: Yonggang Luo --- .cirrus.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.cirrus.yml b/.cirrus.yml index f42ccb956a..2c6bf45e6d 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -109,

[PATCH v2 1/2] block: Fixes nfs compiling error on msys2/mingw

2020-10-12 Thread Yonggang Luo
These compiling errors are fixed: ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory 27 | #include | ^~~~ compilation terminated. ../block/nfs.c:63:5: error: unknown type name 'blkcnt_t' 63 | blkcnt_t st_blocks; | ^~~~ ../block/nfs.c: I

[PATCH v2 0/2] Fixes building nfs on msys2/mingw

2020-10-12 Thread Yonggang Luo
V1-V2 Apply suggestion from Peter Lieven Yonggang Luo (2): block: Fixes nfs compiling error on msys2/mingw block: enable libnfs on msys2/mingw in cirrus.yml .cirrus.yml | 1 + block/nfs.c | 15 +++ 2 files changed, 16 insertions(+) -- 2.28.0.windows.1

Re: [PATCH v3 RESEND] fcntl: Add 32bit filesystem mode

2020-10-12 Thread Eric Blake
On 10/12/20 5:06 PM, Linus Walleij wrote: It was brought to my attention that this bug from 2018 was still unresolved: 32 bit emulators like QEMU were given 64 bit hashes when running 32 bit emulation on 64 bit systems. This adds a flag to the fcntl() F_GETFD and F_SETFD operations to set the un

Re: [PULL v2 00/30] Block patches

2020-10-12 Thread Eric Blake
On 10/12/20 4:48 PM, Peter Maydell wrote: Build failures, OSX and the BSDs: I'll let you find and fix those... Build failure, Windows: ../../qemu-nbd.c:158:5: error: "CONFIG_POSIX" is not defined [-Werror=undef] #if CONFIG_POSIX ^ but this one is easy. In 22/30 block: move blo

[PATCH v9 4/5] win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/mingw

2020-10-12 Thread Yonggang Luo
We remove the CONFIG_LOCALTIME_R detection option in configure, and move the check existence of gmtime_r from configure into C header and source directly by using macro `_POSIX_THREAD_SAFE_FUNCTIONS`. Before this patch, the configure script are always assume the compiler doesn't define _POSIX_C_

[PATCH v9 3/5] curses: Fixes curses compiling errors.

2020-10-12 Thread Yonggang Luo
This is the compiling error: ../ui/curses.c: In function 'curses_refresh': ../ui/curses.c:256:5: error: 'next_maybe_keycode' may be used uninitialized in this function [-Werror=maybe-uninitialized] 256 | curses2foo(_curses2keycode, _curseskey2keycode, chr, maybe_keycode) | ^~~~

[PATCH v9 5/5] configure: Fixes ncursesw detection under msys2/mingw by convert them to meson

2020-10-12 Thread Yonggang Luo
The mingw pkg-config are showing following absolute path and contains : as the separator, -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=199506L -IC:/CI-Tools/msys64/mingw64/include/ncursesw:-I/usr/include/ncursesw: -DNCURSES_WIDECHAR -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=199506L -IC -pipe -lncursesw -l

[PATCH v9 2/5] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-12 Thread Yonggang Luo
msys2/mingw lacks the POSIX-required langinfo.h. gcc test.c -DNCURSES_WIDECHAR -I/mingw64/include/ncursesw -pipe -lncursesw -lgnurx -ltre -lintl -liconv test.c:4:10: fatal error: langinfo.h: No such file or directory 4 | #include | ^~~~ compilation terminated. So we u

[PATCH v9 1/5] configure: fixes indent of $meson setup

2020-10-12 Thread Yonggang Luo
convert these line from tab to space Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- configure | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/configure b/configure index b553288c5e..1b63488521 100755 --- a/configure +++ b/configure @@ -7211,13

[PATCH v9 0/5] Fixes curses on msys2/mingw

2020-10-12 Thread Yonggang Luo
V8-V9 Rebase to resolve conflict. Add configure: Fixes ncursesw detection under msys2/mingw by convert them to = meson, because we don't know when upstream to be fixed. we can revise the script onc= e upstream done V7-V8 Rebase to master and resolve conflict of *configure: fixes indent of $meson

[PATCH v7 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-12 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 9

[PATCH v7 3/4] docs: Fixes build docs on msys2/mingw

2020-10-12 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- scripts/rst-sanitize.py | 21 + tests/qapi-schema/meson.build | 5 +++-- 4 files changed, 26 insertions(+), 4 deletions(-) create mode 100644 scripts/rst-sanit

[PATCH v7 0/4] Improve cirrus msys2

2020-10-12 Thread Yonggang Luo
Fixes the broken msys2/mingw ci and speed it up. V6-V7 * cirrus: Enable doc build on msys2/mingw * docs: Fixes build docs on msys2/mingw * gitignore: ignore a bit more * scripts: Convert qemu-version.sh to qemu-version.py V5-V6 Remove the university mirror, the main repo are back. rename to setup

[PATCH v7 1/4] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-12 Thread Yonggang Luo
The sh script are harder to maintain for compatible different xsh environment so convert it to python script Also incorporate the fixes in https://patchew.org/QEMU/20200929143654.518157-1-marcandre.lur...@redhat.com/ According to https://github.com/msys2/MSYS2-packages/issues/2176 We need use CYGW

[PATCH v7 2/4] gitignore: ignore a bit more

2020-10-12 Thread Yonggang Luo
Enable the creating multiple build directory at the source root. Ignore /meson/ and /roms/ for better search experience. Signed-off-by: Yonggang Luo --- .gitignore | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index b32bca1315..f78ee9f297 100644 -

Re: Using virtio-vhost-user or vhost-pci

2020-10-12 Thread Nikos Dragazis
On 12/10/20 10:22 μ.μ., Cosmin Chenaru wrote: Hi, Could you please tell me if there has been any more work on virtio-vhost-user or vhost-pci? The last messages that I could find were from January 2018, from this thread [1], and from what I see the latest Qemu code does not have that included

Re: [PATCH v4 4/5] spapr_numa: consider user input when defining associativity

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 07:44:14PM +0200, Philippe Mathieu-Daudé wrote: > On 10/7/20 7:28 PM, Daniel Henrique Barboza wrote: > > A new function called spapr_numa_define_associativity_domains() > > is created to calculate the associativity domains and change > > the associativity arrays considering

Re: [PATCH v2 3/3] replay: do not build if TCG is not available

2020-10-12 Thread Paolo Bonzini
On 12/10/20 23:45, Claudio Fontana wrote: > +ctx = blk_get_aio_context(blk); > +if (!replay_bh_schedule_oneshot_event(ctx, error_callback_bh, acb)) { > +/* regular case without replay */ > +aio_bh_schedule_oneshot(ctx, error_callback_bh, acb); > +} Why can't the stub ju

[Bug 1899539] [NEW] keyboard errors in DOS, found links to similar errors for reference

2020-10-12 Thread p kirkham
Public bug reported: OS: slackware 14.2, updated. qemu version: 4.1.0 (from slackbuild script) command line: qemu-system-i386 -hda msdos.vhd Description of problem: MSDOS 6.22 disk image running gwbasic 3.23. Cursor keys and sometimes letter keys are repeated. Cursor keys seemingly always, lette

[PATCH v3 RESEND] fcntl: Add 32bit filesystem mode

2020-10-12 Thread Linus Walleij
It was brought to my attention that this bug from 2018 was still unresolved: 32 bit emulators like QEMU were given 64 bit hashes when running 32 bit emulation on 64 bit systems. This adds a flag to the fcntl() F_GETFD and F_SETFD operations to set the underlying filesystem into 32bit mode even if

Re: [PULL v2 00/30] Block patches

2020-10-12 Thread Peter Maydell
On Mon, 12 Oct 2020 at 19:28, Stefan Hajnoczi wrote: > > The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' > into staging (2020-10-12 11:29:42 +0100) > > are available in the Git repository at

[PATCH v2 3/3] replay: do not build if TCG is not available

2020-10-12 Thread Claudio Fontana
this fixes non-TCG builds broken recently by replay reverse debugging. stub the needed functions in stub/, including errors for hmp and qmp. change hooks for the case when replay code is disabled (!CONFIG_TCG), as we need to avoid sinking all the events in replay in this case. Surprisingly, only

[PATCH v2 1/3] tests/Makefile.include: unbreak non-tcg builds

2020-10-12 Thread Claudio Fontana
From: Paolo Bonzini remove dependency of check-block from non-native archs Signed-off-by: Claudio Fontana --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 5aca98e60c..4037490b69 100644 --- a/tes

[PATCH v2 2/3] qtest: unbreak non-TCG builds in bios-tables-test

2020-10-12 Thread Claudio Fontana
the tests assume TCG is available, thus breaking for TCG-only tests, where only the TCG accelerator option is passed to the QEMU binary. Suggested-by: Paolo Bonzini Acked-by: Paolo Bonzini Signed-off-by: Claudio Fontana --- tests/qtest/bios-tables-test.c | 10 ++ 1 file changed, 10 ins

[PATCH v2 0/3] unbreak non-tcg builds

2020-10-12 Thread Claudio Fontana
This series now unbreaks current non-tcg builds (!CONFIG_TCG). tests Makefiles need to avoid relying on all non-native archs binaries to be present, bios-tables-test needs to skip tests that are tcg-only, and notably the replay framework needs to consider that it might not be functional (or its

Re: [PATCH 3/3] Acceptance tests: show test report on GitLab CI

2020-10-12 Thread Cleber Rosa
On Mon, Oct 12, 2020 at 02:09:22PM +0100, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > On 10/9/20 10:55 PM, Cleber Rosa wrote: > >> Avocado will, by default, produce JUnit files. Let's ask GitLab > >> to present those in the web UI. > > > > https://gitlab.com/philmd/qemu/-/pipeli

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-10-12 Thread Laurent Vivier
Le 30/09/2020 à 13:25, Laurent Vivier a écrit : > Le 14/09/2020 à 12:24, Philippe Mathieu-Daudé a écrit : >> As the 'io_base' argument of m48t59_init() is unused (set to 0), >> remove it to simplify. >> To create a device on the ISA bus, m48t59_init_isa() is the >> preferred function to use. >> >>

Re: [PULL v2 00/38] SCSI, qdev, qtest, meson patches for 2020-10-10

2020-10-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201012203343.1105018-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201012203343.1105018-1-pbonz...@redhat.com Subject: [PULL v2 00/38] SCSI, qdev, qtest

Re: [RFC] Don't lookup full CPU state in the indirect branch fast path on AArch64 when running in user mode.

2020-10-12 Thread Owen Anderson
Ping. I'd like to get feedback on how/whether this could be developed into a landable version. Thanks, --Owen On Tue, Sep 29, 2020 at 2:32 PM Owen Anderson wrote: > > Hello, > > I would like to request feedback on the following patch, which I do > not believe should be applied to master as-is.

[PATCH 1/1] mips: add 34Kf-64tlb fictitious cpu type like 34Kf but with 64 TLBs

2020-10-12 Thread Victor Kamensky
In Yocto Project CI runs it was observed that test run of 32 bit mips image takes almost twice longer than 64 bit mips image with the same logical load and CI execution hits timeout. See https://bugzilla.yoctoproject.org/show_bug.cgi?id=13992 Yocto project uses 34Kf cpu type to run 32 bit mips im

Re: [PATCH] hw/usb/hcd-dwc2: fix divide-by-zero in dwc2_handle_packet()

2020-10-12 Thread Paul Zimmerman
On Mon, Oct 12, 2020 at 8:05 AM Mauro Matteo Cascella wrote: > > Check the value of mps before it is used as divisor. Since HCCHAR_MPS is guest > controllable, this prevents a malicious/buggy guest from crashing the QEMU > process on the host. > > Signed-off-by: Mauro Matteo Cascella > Reported-b

[PULL 35/38] scsi/scsi_bus: Add scsi_device_get

2020-10-12 Thread Paolo Bonzini
From: Maxim Levitsky Add scsi_device_get which finds the scsi device and takes a reference to it. Suggested-by: Stefan Hajnoczi Signed-off-by: Maxim Levitsky Message-Id: <20200913160259.32145-8-mlevi...@redhat.com> Signed-off-by: Paolo Bonzini Message-Id: <20201006123904.610658-12-mlevi...@re

[PULL 34/38] scsi/scsi-bus: scsi_device_find: don't return unrealized devices

2020-10-12 Thread Paolo Bonzini
The device core first places a device on the bus and then realizes it. Make scsi_device_find avoid returing such devices to avoid races in drivers that use an iothread (currently virtio-scsi) Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1812399 Suggested-by: Paolo Bonzini Signed-off-by:

[PULL 37/38] scsi/scsi_bus: fix races in REPORT LUNS

2020-10-12 Thread Paolo Bonzini
From: Maxim Levitsky Currently scsi_target_emulate_report_luns iterates over the child device list twice, and there is no guarantee that this list is the same in both iterations. The reason for iterating twice is that the first iteration calculates how much memory to allocate. However if we use

[PULL 23/38] qtest: remove qtest_qmp_receive_success

2020-10-12 Thread Paolo Bonzini
From: Maxim Levitsky The purpose of qtest_qmp_receive_success was mostly to process events that arrived between the issueing of a command and the "return" line from QMP. This is now handled by the buffering of events that libqtest performs automatically. Signed-off-by: Paolo Bonzini Signed-off

  1   2   3   4   5   >