Re: [PATCH 16/24] virt: Register "its" as class property

2020-11-02 Thread Peter Maydell
On Mon, 21 Sep 2020 at 23:11, Eduardo Habkost wrote: > > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Note: "its" is currently registered conditionally, but this makes > the feature be registered unconditionally. The only

VFIO Migration

2020-11-02 Thread Stefan Hajnoczi
There is discussion about VFIO migration in the "Re: Out-of-Process Device Emulation session at KVM Forum 2020" thread. The current status is that Kirti proposed a VFIO device region type for saving and loading device state. There is currently no guidance on migrating between different device

Re: [PATCH 01/14] target/arm: add arm_is_el2_enabled() helper

2020-11-02 Thread Peter Maydell
On Mon, 2 Nov 2020 at 10:58, wrote: > > From: Rémi Denis-Courmont > > This checks if EL2 is enabled (meaning EL2 registers take effects) in > the current security context. > > Signed-off-by: Rémi Denis-Courmont > --- > target/arm/cpu.h | 14 ++ > 1 file changed, 14 insertions(+) >

RE: [Bug 1902470] Re: migration with TLS-MultiFD is stuck when the dst-libvirtd service restarts

2020-11-02 Thread zhengchuan
Anyone who could help this would be appreciated since we have stuck for three days:( IIUC, the client (Src) has sent first hello message to sever(Dst), however due to something happened while restarted libvirtd, The messages is lost, and both of them are waiting which leading to hang forever,

Re: [PULL v3 00/32] VFIO updates 2020-11-01 (for QEMU 5.2 soft-freeze)

2020-11-02 Thread Peter Maydell
On Sun, 1 Nov 2020 at 21:01, Alex Williamson wrote: > > Aggregated interdiff versus v1 pull request below. Thanks, > > Alex > > The following changes since commit 700d20b49e303549b32d3a7a3efbfcee8c7a4f6c: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging >

[PATCH V2] util: Remove redundant checks in the openpty()

2020-11-02 Thread AlexChen
As we can see from the following function call stack, amaster and aslave can not be NULL: char_pty_open() -> qemu_openpty_raw() -> openpty(). In addition, according to the API specification for openpty(): https://www.gnu.org/software/libc/manual/html_node/Pseudo_002dTerminal-Pairs.html, the

[PATCH-for-5.2 v3] hw/rx/rx-gdbsim: Fix memory leak

2020-11-02 Thread Philippe Mathieu-Daudé
As load_device_tree() returns allocated memory, we need to free it. Cc: Yoshinori Sato Fixes: bda19d7bb56 ("hw/rx: Add RX GDB simulator") Reported-by: Coverity (CID 1432307: RESOURCE_LEAK) Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- v3: Directly initialize the

Re: [PATCH 00/12] block/export: vhost-user-blk server cleanups and tests

2020-11-02 Thread Michael S. Tsirkin
On Fri, Oct 30, 2020 at 08:42:22AM -0400, Michael S. Tsirkin wrote: > On Tue, Oct 27, 2020 at 05:35:16PM +, Stefan Hajnoczi wrote: > > This patch series solves some issues with the new vhost-user-blk-server and > > adds the qtest test case. The test case was not included in the pull request >

Re: [PATCH v2] pc: comment style fixup

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 11:28 AM, Michael S. Tsirkin wrote: > Fix up checkpatch comment style warnings. > > Signed-off-by: Michael S. Tsirkin > --- > > changes from v1: > address philippe's comments > :w > > hw/i386/pc.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) Thanks!

[PATCH-for-5.2] MAINTAINERS: Demote Renesas target & hardware to 'Odd Fixes'

2020-11-02 Thread Philippe Mathieu-Daudé
To be fair with other subsystems listed as 'Odd Fixes' but having maintainers more present, demote the Renesas sections from being 'Maintained' to 'Odd Fixes' (has a maintainer but they don't have time to do much other than throw the odd patch in.) This matches Magnus's possibilities so far:

Re: Out-of-Process Device Emulation session at KVM Forum 2020

2020-11-02 Thread Michael S. Tsirkin
On Mon, Nov 02, 2020 at 10:27:54AM +, Stefan Hajnoczi wrote: > On Mon, Nov 02, 2020 at 11:00:12AM +0800, Jason Wang wrote: > > > > On 2020/10/30 下午7:13, Stefan Hajnoczi wrote: > > > > I still don't get why it must be opaque. > > > If the device state format needs to be in the VMM then each

Re: [PATCH] vhost: fix up trailing whitespace

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 11:13 AM, Michael S. Tsirkin wrote: > Drop trailing whitespace in vhost.c > > Signed-off-by: Michael S. Tsirkin > --- > hw/virtio/vhost.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v2] pc: comment style fixup

2020-11-02 Thread Michael S. Tsirkin
Fix up checkpatch comment style warnings. Signed-off-by: Michael S. Tsirkin --- changes from v1: address philippe's comments :w hw/i386/pc.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 416fb0e0f6..aae45ba779 100644 ---

Re: Out-of-Process Device Emulation session at KVM Forum 2020

2020-11-02 Thread Stefan Hajnoczi
On Mon, Nov 02, 2020 at 11:00:12AM +0800, Jason Wang wrote: > > On 2020/10/30 下午7:13, Stefan Hajnoczi wrote: > > > I still don't get why it must be opaque. > > If the device state format needs to be in the VMM then each device > > needs explicit enablement in each VMM (QEMU, cloud-hypervisor,

[PATCH-for-5.2] hw/mips: Remove the 'r4k' machine

2020-11-02 Thread Philippe Mathieu-Daudé
We deprecated the support for the 'r4k' machine for the 5.0 release (commit d32dc61421), which means that our deprecation policy allows us to drop it in release 5.2. Remove the code. To repeat the rationale from the deprecation note: - this virtual machine has no specification - the Linux kernel

Re: [PATCH] pc: comment stule fixup

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 11:09 AM, Michael S. Tsirkin wrote: > Fix up checkpatch comment style warnings. Typo stule -> style in subject ;) > > Signed-off-by: Michael S. Tsirkin > --- > hw/i386/pc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/i386/pc.c b/hw/i386/pc.c >

[PATCH V3] hw/display/exynos4210_fimd: Fix potential NULL pointer dereference

2020-11-02 Thread AlexChen
In exynos4210_fimd_update(), the pointer 's' is dereferenced before checking it is valid, which may lead to NULL pointer dereference. So move the assignment to global_width after checking 's' is valid. Reported-by: Euler Robot Signed-off-by: Alex Chen Reviewed-by: Philippe Mathieu-Daudé ---

[PATCH] vhost: fix up trailing whitespace

2020-11-02 Thread Michael S. Tsirkin
Drop trailing whitespace in vhost.c Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index f2482378c6..2e904bbd62 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@

target/mips: Deprecate nanoMIPS ISA?

2020-11-02 Thread Philippe Mathieu-Daudé
Hi Richard, Cc'ing developers who introduced nanoMIPS. On 9/11/20 7:23 PM, Philippe Mathieu-Daudé wrote: > On 9/11/20 6:55 PM, Richard Henderson wrote: >> On 9/11/20 3:41 AM, Peter Maydell wrote: +/* Detect store by reading the instruction at the program counter. */ +uint32_t

Re: Out-of-Process Device Emulation session at KVM Forum 2020

2020-11-02 Thread Stefan Hajnoczi
On Mon, Nov 02, 2020 at 10:51:18AM +0800, Jason Wang wrote: > > On 2020/10/30 下午9:15, Stefan Hajnoczi wrote: > > On Fri, Oct 30, 2020 at 12:08 PM Jason Wang wrote: > > > On 2020/10/30 下午7:13, Stefan Hajnoczi wrote: > > > > On Fri, Oct 30, 2020 at 9:46 AM Jason Wang wrote: > > > > > On

Re: [PATCH V2] hw/display/exynos4210_fimd: Fix potential NULL pointer dereference

2020-11-02 Thread AlexChen
On 2020/11/2 17:16, Philippe Mathieu-Daudé wrote: > On 11/2/20 5:39 AM, AlexChen wrote: >> In exynos4210_fimd_update(), the pointer s is dereferinced before > > Typo dereferinced -> dereferenced. > >> being check if it is valid, which may lead to NULL pointer dereference. >> So move the

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Nov 02, 2020 at 09:44:49AM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Fri, Oct 30, 2020 at 11:11:19AM +0100, Markus Armbruster wrote: >> >> Marc-André Lureau writes: >> >> >> >> > Hi Markus, >> >> > >> >> > On Thu, Oct 29,

[PATCH] pc: comment stule fixup

2020-11-02 Thread Michael S. Tsirkin
Fix up checkpatch comment style warnings. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 416fb0e0f6..5872ae6095 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1150,9 +1150,9 @@ void

Re: [PATCH v6 0/7] hw/misc: Add LED device

2020-11-02 Thread Cédric Le Goater
On 10/26/20 11:00 PM, Philippe Mathieu-Daudé wrote: > On 10/16/20 5:29 PM, Philippe Mathieu-Daudé wrote: >> On 9/19/20 2:30 PM, Philippe Mathieu-Daudé wrote: >>> On 9/12/20 3:40 PM, Philippe Mathieu-Daudé wrote: Hello, These patches are part of the GSoC unselected 'QEMU visualizer'

Re: [PULL 00/15] pc,pci,vhost,virtio: misc fixes

2020-11-02 Thread Michael S. Tsirkin
On Sun, Nov 01, 2020 at 02:03:56PM +, Peter Maydell wrote: > On Fri, 30 Oct 2020 at 14:33, wrote: > > > > Patchew URL: > > https://patchew.org/QEMU/20201030141136.1013521-1-...@redhat.com/ > > I'll apply this pullreq (unless it has other more serious > issues), but could you look at the

[PULL v3 17/17] tests/9pfs: add local Tunlinkat hard link test

2020-11-02 Thread Christian Schoenebeck
This test case uses a Tunlinkat request to remove a previously hard linked file by using the 9pfs 'local' fs driver. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: <9bec33a7d8f006ef8f80517985d0d6ac48650d53.1603285620.git.qemu_...@crudebyte.com> Signed-off-by: Christian

[PULL v3 12/17] tests/9pfs: add local Tlcreate test

2020-11-02 Thread Christian Schoenebeck
This test case uses a Tlcreate 9p request to create a regular file inside host's test directory. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: <269cae0c00af941a3a4ae78f1e319f93462a7eb4.1603285620.git.qemu_...@crudebyte.com> Signed-off-by: Christian Schoenebeck ---

[PULL v3 16/17] tests/9pfs: add local Tlink test

2020-11-02 Thread Christian Schoenebeck
This test case uses a Tlink request to create a hard link to a regular file using the 9pfs 'local' fs driver. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 71

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Daniel P . Berrangé
On Mon, Nov 02, 2020 at 10:59:43AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Nov 02, 2020 at 09:44:49AM +0100, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Fri, Oct 30, 2020 at 11:11:19AM +0100, Markus Armbruster wrote: > >> >>

[PULL v3 10/17] tests/9pfs: simplify do_mkdir()

2020-11-02 Thread Christian Schoenebeck
Split out walking a directory path to a separate new utility function do_walk() and use that function in do_mkdir(). The code difference saved this way is not much, but we'll use that new do_walk() function in the upcoming patches, so it will avoid quite some code duplication after all.

[PULL v3 14/17] tests/9pfs: add local Tsymlink test

2020-11-02 Thread Christian Schoenebeck
This test case uses a Tsymlink 9p request to create a symbolic link using the 9pfs 'local' fs driver. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: <84ac76937855bf441242372cc3e62df42f0a3dc4.1603285620.git.qemu_...@crudebyte.com> Signed-off-by: Christian Schoenebeck

[PATCH] hw/arm: Fix bad print format specifiers

2020-11-02 Thread AlexChen
We should use printf format specifier "%u" instead of "%i" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen --- hw/arm/pxa2xx.c | 2 +- hw/arm/spitz.c | 2 +- hw/arm/tosa.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PULL v3 13/17] tests/9pfs: add local Tunlinkat file test

2020-11-02 Thread Christian Schoenebeck
This test case uses a Tunlinkat request to remove a regular file using the 9pfs 'local' fs driver. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: <4eabeed7f662721dd5664cb77fe36ea0aa08b1ec.1603285620.git.qemu_...@crudebyte.com> Signed-off-by: Christian Schoenebeck ---

[PULL v3 15/17] tests/9pfs: add local Tunlinkat symlink test

2020-11-02 Thread Christian Schoenebeck
This test case uses a Tunlinkat request to remove a symlink using the 9pfs 'local' fs driver. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 28 1 file changed, 28

Re: [PATCH] util: Remove redundant checks in the openpty()

2020-11-02 Thread Peter Maydell
On Mon, 2 Nov 2020 at 05:12, AlexChen wrote: > Thanks for your review, I will add this description to my commit message in > my patch V2. > In addition, since the amaster and the aslave are not allow to be NULL, > do we need to check that the amaster and the aslave are NULL in the beginning >

[PULL v3 09/17] tests/9pfs: Turn fs_mkdir() into a helper

2020-11-02 Thread Christian Schoenebeck
From: Greg Kurz fs_mkdir() isn't a top level test function and thus shouldn't take the "void *obj, void *data, QGuestAllocator *t_alloc" arguments. Turn it into a helper to be used by test functions. Signed-off-by: Greg Kurz Message-Id:

[PULL v3 11/17] tests/9pfs: add local Tunlinkat directory test

2020-11-02 Thread Christian Schoenebeck
This test case uses a Tunlinkat 9p request with flag AT_REMOVEDIR (see 'man 2 unlink') to remove a directory from host's test directory. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: <3c7c65b476ba44bea6afd0b378b5287e1c671a32.1603285620.git.qemu_...@crudebyte.com>

[PULL v3 08/17] tests/9pfs: Turn fs_readdir_split() into a helper

2020-11-02 Thread Christian Schoenebeck
From: Greg Kurz fs_readdir_split() isn't a top level test function and thus shouldn't take the "void *obj, void *data, QGuestAllocator *t_alloc" arguments. Turn it into a helper to be used by test functions. Signed-off-by: Greg Kurz Message-Id:

Re: [PULL v2 00/12] NBD patches for 2020-10-27 soft-freeze

2020-11-02 Thread Peter Maydell
On Fri, 30 Oct 2020 at 20:34, Eric Blake wrote: > > The following changes since commit 9a2ea4f4a7230fe224dee91d9adf2ef872c3d226: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-branch-for-5.2-pull-request' into staging > (2020-10-30 15:49:35 +) > > are available in the

[PULL v3 02/17] tests/9pfs: fix test dir for parallel tests

2020-11-02 Thread Christian Schoenebeck
Use mkdtemp() to generate a unique directory for the 9p 'local' tests. This fixes occasional 9p test failures when running 'make check -jN' if QEMU was compiled for multiple target architectures, because the individual architecture's test suites would run in parallel and interfere with each

[PULL v3 06/17] tests/9pfs: Set alloc in fs_create_dir()

2020-11-02 Thread Christian Schoenebeck
From: Greg Kurz fs_create_dir() is a top level test function. It should set alloc. Signed-off-by: Greg Kurz Message-Id: <160321016764.266767.3763279057643874020.st...@bahia.lan> Signed-off-by: Christian Schoenebeck --- tests/qtest/virtio-9p-test.c | 1 + 1 file changed, 1 insertion(+) diff

[PULL v3 05/17] tests/9pfs: Factor out do_version() helper

2020-11-02 Thread Christian Schoenebeck
From: Greg Kurz fs_version() is a top level test function. Factor out the reusable code to a separate helper instead of hijacking it in other tests. Signed-off-by: Greg Kurz Message-Id: <160321015403.266767.4533967728943968456.st...@bahia.lan> Signed-off-by: Christian Schoenebeck ---

[PULL v3 07/17] tests/9pfs: Factor out do_attach() helper

2020-11-02 Thread Christian Schoenebeck
From: Greg Kurz fs_attach() is a top level test function. Factor out the reusable code to a separate helper instead of hijacking it in other tests. Signed-off-by: Greg Kurz Message-Id: <160321017450.266767.17377192504263871186.st...@bahia.lan> Signed-off-by: Christian Schoenebeck ---

[PULL v3 04/17] tests/9pfs: Force removing of local 9pfs test directory

2020-11-02 Thread Christian Schoenebeck
From: Greg Kurz No need to get a complaint from "rm" if some path disappeared for some reason. Signed-off-by: Greg Kurz Message-Id: <160406199444.312256.8319835906008559151.st...@bahia.lan> Signed-off-by: Christian Schoenebeck --- tests/qtest/libqos/virtio-9p.c | 2 +- 1 file changed, 1

[PATCH v2 09/11] char-socket: Fix qemu_chr_socket_address() for abstract sockets

2020-11-02 Thread Markus Armbruster
Commit 776b97d360 "qemu-sockets: add abstract UNIX domain socket support" neglected to update qemu_chr_socket_address(). It shows shows neither @abstract nor @tight. Fix that. Reviewed-by: Paolo Bonzini Signed-off-by: Markus Armbruster --- chardev/char-socket.c | 10 +- 1 file

[PULL v3 01/17] tests/9pfs: make create/remove test dir public

2020-11-02 Thread Christian Schoenebeck
Make functions create_local_test_dir() and remove_local_test_dir() public. They're going to be used in the next patch. Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: Signed-off-by: Christian Schoenebeck --- tests/qtest/libqos/virtio-9p.c | 10 --

[PULL v3 03/17] tests/9pfs: fix coverity error in create_local_test_dir()

2020-11-02 Thread Christian Schoenebeck
Coverity wants the return value of mkdir() to be checked: /qemu/tests/qtest/libqos/virtio-9p.c: 48 in create_local_test_dir() 42 /* Creates the directory for the 9pfs 'local' filesystem driver to access. */ 43 static void create_local_test_dir(void) 44 { 45 struct

[PATCH v2 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets

2020-11-02 Thread Markus Armbruster
unix_listen_saddr() replaces empty @path by unique value. It obtains the value by creating and deleting a unique temporary file with mkstemp(). This is racy, as the comment explains. It's also entirely undocumented as far as I can tell. Goes back to commit d247d25f18 "sockets: helper functions

[PULL v3 00/17] 9p queue (previous 2020-10-30)

2020-11-02 Thread Christian Schoenebeck
-9p-20201102 for you to fetch changes up to 4d0746e2135f56c59c6e61ef42d700b7139065b4: tests/9pfs: add local Tunlinkat hard link test (2020-11-01 19:44:29 +0100) 9pfs: only test case changes this time * Fix occasional test

[PATCH v2 11/11] sockets: Make abstract UnixSocketAddress depend on CONFIG_LINUX

2020-11-02 Thread Markus Armbruster
The abstract socket namespace is a non-portable Linux extension. An attempt to use it elsewhere should fail with ENOENT (the abstract address looks like a "" pathname, which does not resolve). We report this failure like Failed to connect socket abc: No such file or directory Tolerable,

[PATCH v2 07/11] sockets: Fix default of UnixSocketAddress member @tight

2020-11-02 Thread Markus Armbruster
An optional bool member of a QAPI struct can be false, true, or absent. The previous commit demonstrated that socket_listen() and socket_connect() are broken for absent @tight, and indeed QMP chardev- add also defaults absent member @tight to false instead of true. In C, QAPI members are

[PATCH v2 08/11] sockets: Fix socket_sockaddr_to_address_unix() for abstract sockets

2020-11-02 Thread Markus Armbruster
Commit 776b97d360 "qemu-sockets: add abstract UNIX domain socket support" neglected to update socket_sockaddr_to_address_unix(). The function returns a non-abstract socket address for abstract sockets (wrong) with a null @path (also wrong; a non-optional QAPI str member must never be null). The

Re: [PATCH v2] target/s390x: fix execution with icount

2020-11-02 Thread David Hildenbrand
On 02.11.20 10:41, Pavel Dovgalyuk wrote: On 02.11.2020 12:34, David Hildenbrand wrote: On 02.11.20 10:26, Pavel Dovgalyuk wrote: This patch adds some gen_io_start() calls to allow execution of s390x targets in icount mode with -smp 1. It enables deterministic timers and record/replay

[PATCH v2 03/11] test-util-sockets: Clean up SocketAddress construction

2020-11-02 Thread Markus Armbruster
The thread functions build the SocketAddress from global variable @abstract_sock_name and the tight flag passed as pointer argument (either NULL or (gpointer)1). There is no need for such hackery; simply pass the SocketAddress instead. While there, dumb down g_rand_int_range() to g_random_int().

[PATCH v2 05/11] test-util-sockets: Synchronize properly, don't sleep(1)

2020-11-02 Thread Markus Armbruster
The abstract sockets test spawns a thread to listen and accept, and a second one to connect, with a sleep(1) in between to "ensure" the former is listening when the latter tries to connect. Review fail. Risks spurious test failure, say when a heavily loaded machine doesn't schedule the first

[PATCH v2 06/11] test-util-sockets: Test the complete abstract socket matrix

2020-11-02 Thread Markus Armbruster
The test covers only two out of nine combinations. Test all nine. Four turn out to be broken. Marked /* BUG */. Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --- tests/test-util-sockets.c | 87 --- 1 file changed, 63

[PATCH v2 01/11] test-util-sockets: Plug file descriptor leak

2020-11-02 Thread Markus Armbruster
Fixes: 4d3a329af59ef8acd076f99f05e82531d8129b34 Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --- tests/test-util-sockets.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-util-sockets.c b/tests/test-util-sockets.c index

[PATCH v2 04/11] test-util-sockets: Factor out test_socket_unix_abstract_one()

2020-11-02 Thread Markus Armbruster
Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --- tests/test-util-sockets.c | 48 --- 1 file changed, 20 insertions(+), 28 deletions(-) diff --git a/tests/test-util-sockets.c b/tests/test-util-sockets.c index

[PATCH v2 02/11] test-util-sockets: Correct to set has_abstract, has_tight

2020-11-02 Thread Markus Armbruster
The code tested doesn't care, which is a bug I will fix shortly. Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --- tests/test-util-sockets.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/test-util-sockets.c b/tests/test-util-sockets.c

[PATCH v2 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Markus Armbruster
In my opinion, the Linux-specific abstract UNIX domain socket feature introduced in 5.1 should have been rejected. The feature is niche, the interface clumsy, the implementation buggy and incomplete, and the test coverage insufficient. Review fail. Fixing the parts we can still fix now is

Re: [PATCH v2] target/s390x: fix execution with icount

2020-11-02 Thread Pavel Dovgalyuk
On 02.11.2020 12:34, David Hildenbrand wrote: On 02.11.20 10:26, Pavel Dovgalyuk wrote: This patch adds some gen_io_start() calls to allow execution of s390x targets in icount mode with -smp 1. It enables deterministic timers and record/replay features. Why do we have to set it for SIGP?

Re: [PATCH v2] target/s390x: fix execution with icount

2020-11-02 Thread David Hildenbrand
On 02.11.20 10:26, Pavel Dovgalyuk wrote: This patch adds some gen_io_start() calls to allow execution of s390x targets in icount mode with -smp 1. It enables deterministic timers and record/replay features. Why do we have to set it for SIGP? Signed-off-by: Pavel Dovgalyuk --- v2: -

Re: [PATCH v2] target/s390x: fix execution with icount

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 10:26 AM, Pavel Dovgalyuk wrote: > This patch adds some gen_io_start() calls to allow execution > of s390x targets in icount mode with -smp 1. > It enables deterministic timers and record/replay features. > > Signed-off-by: Pavel Dovgalyuk > > --- > > v2: > - added IF_IO flag to

Re: [PATCH-for-5.2] hw/smbios: Fix leaked fd in save_opt_one() error path

2020-11-02 Thread Stefano Garzarella
On Fri, Oct 30, 2020 at 04:27:42PM +0100, Philippe Mathieu-Daudé wrote: Fix the following Coverity issue (RESOURCE_LEAK): CID 1432879: Resource leak Handle variable fd going out of scope leaks the handle. Replace a close() call by qemu_close() since the handle is opened with qemu_open().

[PATCH v2] target/s390x: fix execution with icount

2020-11-02 Thread Pavel Dovgalyuk
This patch adds some gen_io_start() calls to allow execution of s390x targets in icount mode with -smp 1. It enables deterministic timers and record/replay features. Signed-off-by: Pavel Dovgalyuk --- v2: - added IF_IO flag to reuse icount code in translate_one() (suggested by Richard

Re: [PATCH] target/s390x: fix execution with icount

2020-11-02 Thread Pavel Dovgalyuk
On 30.10.2020 19:21, Richard Henderson wrote: On 10/30/20 1:36 AM, Pavel Dovgalyuk wrote: This patch adds some gen_io_start() calls to allow execution of s390x targets in icount mode with -smp 1. It enables deterministic timers and record/replay features. Thanks for pointing this out. There

[PATCH-for-5.2 v2] tools/virtiofsd: Check vu_init() return value (CID 1435958)

2020-11-02 Thread Philippe Mathieu-Daudé
Since commit 6f5fd837889, vu_init() can fail if malloc() returns NULL. This fixes the following Coverity warning: CID 1435958 (#1 of 1): Unchecked return value (CHECKED_RETURN) Fixes: 6f5fd837889 ("libvhost-user: support many virtqueues") Reviewed-by: Dr. David Alan Gilbert Signed-off-by:

Re: [PATCH 1/2] target/arm: Fix float16 pairwise Neon ops on big-endian hosts

2020-11-02 Thread Philippe Mathieu-Daudé
On 10/28/20 8:45 PM, Philippe Mathieu-Daudé wrote: > On 10/28/20 8:17 PM, Peter Maydell wrote: >> In the neon_padd/pmax/pmin helpers for float16, a cut-and-paste error >> meant we were using the H4() address swizzler macro rather than the >> H2() which is required for 2-byte data. This had no

Re: [PATCH] hw/input/ps2.c: Remove remnants of printf debug

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/1/20 2:32 PM, Peter Maydell wrote: > In commit 5edab03d4040 we added tracepoints to the ps2 keyboard > and mouse emulation. However we didn't remove all the debug-by-printf > support. In fact there is only one printf() remaining, and it is > redundant with the trace_ps2_write_mouse() event

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Daniel P . Berrangé
On Mon, Nov 02, 2020 at 09:44:49AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Fri, Oct 30, 2020 at 11:11:19AM +0100, Markus Armbruster wrote: > >> Marc-André Lureau writes: > >> > >> > Hi Markus, > >> > > >> > On Thu, Oct 29, 2020 at 5:43 PM Markus Armbruster > >>

Re: [PATCH V2] hw/display/exynos4210_fimd: Fix potential NULL pointer dereference

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 5:39 AM, AlexChen wrote: > In exynos4210_fimd_update(), the pointer s is dereferinced before Typo dereferinced -> dereferenced. > being check if it is valid, which may lead to NULL pointer dereference. > So move the assignment to global_width after checking that the s is valid.

Re: [PATCH 1/2] MAINTAINERS: Add QAPI schema modules to their subsystems

2020-11-02 Thread Philippe Mathieu-Daudé
On 11/2/20 9:15 AM, Markus Armbruster wrote: > Add the relevant QAPI schema modules to section Audio, QMP, Tracing, > Cryptography. > > Cc: Gerd Hoffmann > Cc: Stefan Hajnoczi > Cc: Daniel P. Berrange > Signed-off-by: Markus Armbruster > --- > MAINTAINERS | 6 ++ > 1 file changed, 6

[PATCH] qemu-img: Make sure @sn_opts can be deleted in all error cases

2020-11-02 Thread Tuguoyi
@sn_opts is initialized at the beginning, so it should be deleted after jumping to the lable 'fail_getopt' Signed-off-by: Guoyi Tu --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 2103507..229cdf9 100644 --- a/qemu-img.c +++

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Paolo Bonzini
On 02/11/20 09:44, Markus Armbruster wrote: >>> Reverting the feature requires rough consensus and a patch. >>> >>> I can provide a patch, but let's give everybody a chance to object >>> first. > Daniel, do you object, yes or no? I think we should keep the patch, especially since you have cleaned

Re: [PATCH 7/30] non-virt: Fix Lesser GPL version number

2020-11-02 Thread Cédric Le Goater
On 10/19/20 12:39 PM, Thomas Huth wrote: > On 16/10/2020 16.53, Chetan Pant wrote: >> There is no "version 2" of the "Lesser" General Public License. >> It is either "GPL version 2.0" or "Lesser GPL version 2.1". >> This patch replaces all occurrences of "Lesser GPL version 2" with >> "Lesser GPL

Re: [PATCH 00/11] sockets: Attempt to drain the abstract socket swamp

2020-11-02 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Oct 30, 2020 at 11:11:19AM +0100, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >> > Hi Markus, >> > >> > On Thu, Oct 29, 2020 at 5:43 PM Markus Armbruster >> > wrote: >> > >> >> In my opinion, the Linux-specific abstract UNIX domain socket

Re: [PATCH v2 0/2] Assorted fixes to tests that were broken by recent scsi changes

2020-11-02 Thread Paolo Bonzini
On 01/11/20 17:15, Maxim Levitsky wrote: > While most of the patches in V1 of this series are already merged upstream, > the patch that fixes iotest 240 was broken on s390 and was not accepted. > > This is an updated version of this patch, based on Paulo's suggestion, > that hopefully makes

Re: [PATCH-for-5.2] scripts/oss-fuzz: rename bin/qemu-fuzz-i386

2020-11-02 Thread Paolo Bonzini
On 01/11/20 22:22, Alexander Bulekov wrote: > OSS-Fuzz changed the way it scans for fuzzers in $DEST_DIR. The new code > also scans subdirectories for fuzzers. This means that OSS-Fuzz is > considering bin/qemu-fuzz-i386 as an independent fuzzer (it is not - it > requires a --fuzz-target

Re: [PATCH] target/i386: seg_helper: Correct segement selector nullification in the RET/IRET helper

2020-11-02 Thread Bin Meng
On Thu, Oct 22, 2020 at 6:16 PM Bin Meng wrote: > > From: Bin Meng > > Per the SDM, when returning to outer privilege level, for segment > registers (ES, FS, GS, and DS) if the check fails, the segment > selector becomes null, but QEMU clears the base/limit/flags as well > as nullifying the

[PATCH 2/2] qapi: Fix missing headers in QMP Reference Manual

2020-11-02 Thread Markus Armbruster
Audio stuff is under "Miscellanea", and authorization stuff is under "Input". Add suitable header doc comments to correct that. Cc: Gerd Hoffmann Cc: Daniel P. Berrange Signed-off-by: Markus Armbruster --- qapi/audio.json | 4 qapi/authz.json | 6 -- 2 files changed, 8

[PATCH 0/2] qapi: Doc & MAINTAINERS tweaks

2020-11-02 Thread Markus Armbruster
Markus Armbruster (2): MAINTAINERS: Add QAPI schema modules to their subsystems qapi: Fix missing headers in QMP Reference Manual qapi/audio.json | 4 qapi/authz.json | 6 -- MAINTAINERS | 6 ++ 3 files changed, 14 insertions(+), 2 deletions(-) -- 2.26.2

[PATCH 1/2] MAINTAINERS: Add QAPI schema modules to their subsystems

2020-11-02 Thread Markus Armbruster
Add the relevant QAPI schema modules to section Audio, QMP, Tracing, Cryptography. Cc: Gerd Hoffmann Cc: Stefan Hajnoczi Cc: Daniel P. Berrange Signed-off-by: Markus Armbruster --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH] target/s390x: fix execution with icount

2020-11-02 Thread David Hildenbrand
On 30.10.20 17:21, Richard Henderson wrote: On 10/30/20 1:36 AM, Pavel Dovgalyuk wrote: This patch adds some gen_io_start() calls to allow execution of s390x targets in icount mode with -smp 1. It enables deterministic timers and record/replay features. Thanks for pointing this out. There

<    1   2   3   4