[PATCH 11/11] hw/m68k/next-cube: Add missing header comment to next-cube.h

2021-01-15 Thread Peter Maydell
The next-cube.h file is missing the usual copyright-and-license header; add it (same as the next-cube.c one). Signed-off-by: Peter Maydell --- include/hw/m68k/next-cube.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/hw/m68k/next-cube.h b/include/hw/m68k/next-cube.h

[PATCH 08/11] hw/m68k/next-cube: Move rtc into NeXTPC struct

2021-01-15 Thread Peter Maydell
Move the rtc into the NeXTPC struct. Since this is the last use of the 'backdoor' NextState pointer we can now remove that. Probably the RTC should be its own device at some point: in hardware there is a separate MCS1850 RTC chip connected to the Peripheral Controller via a 1-bit serial

[PATCH 10/11] hw/m68k/next-cube: Add vmstate for NeXTPC device

2021-01-15 Thread Peter Maydell
Add the vmstate for the new NeXTPC devic; this is in theory a migration compatibility break, but this machine doesn't have working migration currently anyway. Signed-off-by: Peter Maydell --- hw/m68k/next-cube.c | 34 +- 1 file changed, 33 insertions(+), 1

[PATCH 05/11] hw/m68k/next-cube: Make next_irq take NeXTPC* as its opaque

2021-01-15 Thread Peter Maydell
Make the next_irq function take a NeXTPC* as its opaque rather than the M68kCPU*. This will make it simpler to turn the next_irq function into a gpio input line of the NeXTPC device in the next commit. For this to work we have to pass the CPU to the NeXTPC device via a link property, in the same

[PATCH 06/11] hw/m68k/next-cube: Move int_status and int_mask to NeXTPC struct

2021-01-15 Thread Peter Maydell
All the code which accesses int_status and int_mask is now doing so via the NeXTPC->NeXTState indirection, so we can move these fields into the NeXTPC struct where they belong. Signed-off-by: Peter Maydell --- hw/m68k/next-cube.c | 33 - 1 file changed, 16

[PATCH 07/11] hw/m68k/next-cube: Make next_irq GPIO inputs to NEXT_PC device

2021-01-15 Thread Peter Maydell
Make the next_irq function be GPIO inputs to the NEXT_PC device, rather than a freestanding set of qemu_irq lines. This fixes a minor Coverity issue where it correctly points out the trivial memory leak of the memory allocated in the call to qemu_allocate_irqs(). Fixes: CID 1421962

[PATCH 02/11] hw/m68k/next-cube: Move register/interrupt functionality into a device

2021-01-15 Thread Peter Maydell
Currently the next-cube board code open-codes a lot of handling of interrupts and some miscellaneous registers. Move this into a proper QOM device. In the real hardware this functionality seems to be the responsibility of the Peripheral Controller (PC) chip, so name the device that. There are

[PATCH 03/11] hw/m68k/next-cube: Move mmio_ops into NeXTPC device

2021-01-15 Thread Peter Maydell
Move the registers handled by the mmio_ops struct into the NeXTPC device. This allows us to also move the scr1 and scr2 data fields. Signed-off-by: Peter Maydell --- hw/m68k/next-cube.c | 80 + 1 file changed, 44 insertions(+), 36 deletions(-) diff

[PATCH 09/11] hw/m68k/next-cube: Remove unused fields from NeXTState

2021-01-15 Thread Peter Maydell
The fields scsi_irq, scsi_dma, scsi_reset and fd_irq in NeXTState are all unused, except in commented out "this should do something like this" code. Remove the unused fields. As and when the functionality that might use them is added, we can put in the correct kind of wiring (which might or might

[PATCH 00/11] hw/m68k/next-cube: refactor to fix Coverity issue

2021-01-15 Thread Peter Maydell
Currently the next-cube board code open-codes a lot of handling of interrupts and some miscellaneous registers. This series refactors that to move most of it into a proper QOM device. (The main motivation here is to fix the Coverity issue CID 1421962 which is a trivial memory leak of the memory

[PATCH 01/11] hw/m68k/next-cube: Make next_irq() function static

2021-01-15 Thread Peter Maydell
The next_irq() function is global, but isn't actually used anywhere outside next-cube.c. Make it static. Signed-off-by: Peter Maydell --- include/hw/m68k/next-cube.h | 2 -- hw/m68k/next-cube.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 04/11] hw/m68k/next-cube: Move scr_ops into NeXTPC device

2021-01-15 Thread Peter Maydell
Move the registers handled by the scr_ops struct into the NeXTPC device. Signed-off-by: Peter Maydell --- hw/m68k/next-cube.c | 50 ++--- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index

Re: [PULL 00/11] Ui 20210115 patches

2021-01-15 Thread Peter Maydell
in the Git repository at: > > git://git.kraxel.org/qemu tags/ui-20210115-pull-request > > for you to fetch changes up to 763deea7e906321f8ba048c359f168f60d51c14e: > > vnc: add support for extended desktop resize (2021-01-15 11:22:43 +0100) > >

Re: [PATCH 1/4] tests/qtest: Remove TPM tests

2021-01-15 Thread Stefan Berger
On 1/15/21 1:40 PM, Stefan Berger wrote: On 1/15/21 11:06 AM, Philippe Mathieu-Daudé wrote: On 1/15/21 4:53 PM, Stefan Berger wrote: On 1/15/21 10:52 AM, Philippe Mathieu-Daudé wrote: Subject is incorrect, this is not a removal of the tests, but removal of their execution. The tests are still

Re: [PATCH 03/15] arc: Opcode definitions table

2021-01-15 Thread Richard Henderson
On 1/15/21 7:11 AM, Cupertino Miranda wrote: > As you know, we reused the code from binutils to implement the decoder. > In that sense, we kindly request to allow us to do it through binutils > development flow later on. We will change the tables in binutils > and those changes will also be

Re: [PATCH v4 02/10] iotests/297: Rewrite in Python and extend reach

2021-01-15 Thread Willian Rampazzo
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote: > > Instead of checking iotests.py only, check all Python files in the > qemu-iotests/ directory. Of course, most of them do not pass, so there > is an extensive skip list for now. (The only files that do pass are > 209, 254, 283, and

[PATCH 3/4] pvpanic : update pvpanic spec document

2021-01-15 Thread Mihai Carabas
Add pvpanic PCI device support details in docs/specs/pvpanic.txt. Signed-off-by: Mihai Carabas --- docs/specs/pvpanic.txt | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt index a90fbca..974aafd 100644 ---

[PATCH 1/4] hw/misc/pvpanic: split-out generic and bus dependent code

2021-01-15 Thread Mihai Carabas
To ease the PCI device addition in next patches, split the code as follows: - generic code (read/write/setup) is being kept in pvpanic.c - ISA dependent code moved to pvpanic-isa.c Also, rename: - ISA_PVPANIC_DEVICE -> PVPANIC_ISA_DEVICE. - TYPE_PVPANIC -> TYPE_PVPANIC_ISA. - MemoryRegion io ->

[PATCH 2/4] hw/misc/pvpanic: add PCI interface support

2021-01-15 Thread Mihai Carabas
Add PCI interface support for PVPANIC device. Create a new file pvpanic-pci.c where the PCI specific routines reside and update the build system with the new files and config structure. Signed-off-by: Mihai Carabas --- docs/specs/pci-ids.txt| 1 + hw/misc/Kconfig | 6 +++

[PATCH 4/4] tests/qtest: add a test case for pvpanic-pci

2021-01-15 Thread Mihai Carabas
Add a test case for pvpanic-pci device. The scenario is the same as pvpapnic ISA device, but is using the PCI bus. Signed-off-by: Mihai Carabas --- tests/qtest/meson.build| 1 + tests/qtest/pvpanic-pci-test.c | 62 ++ 2 files changed, 63

[PATCH v3] Add support for pvpanic pci device

2021-01-15 Thread Mihai Carabas
This patchset adds support for pvpanic pci device. v3 applied feedback: - patch 1: made pvpanic isa device available only for PC, compile pvpanic-test only when isa device is present - patch 2: fixed device id to 0x0011, used OBJECT_DECLARE_TYPE, PVPANIC_PCI_DEVICE, added

Re: Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-15 Thread Ram Pai
On Wed, Jan 13, 2021 at 09:06:29AM +0100, Cornelia Huck wrote: > On Tue, 12 Jan 2021 10:55:11 -0800 > Ram Pai wrote: > > > On Tue, Jan 12, 2021 at 09:19:43AM +0100, Cornelia Huck wrote: > > > On Mon, 11 Jan 2021 11:58:30 -0800 > > > Ram Pai wrote: > > > > > > > On Mon, Jan 11, 2021 at

Re: [PATCH v2 10/25] tests/docker: fix mistakes in ubuntu package lists

2021-01-15 Thread Wainer dos Santos Moschetta
On 1/14/21 10:02 AM, Daniel P. Berrangé wrote: librados-dev is not required by QEMU directly, only librbd-dev. glusterfs-common is not directly needed by QEMU. QEMU uses ncursesw only on non-Windows hosts. The clang package is clang 10. flex and bison are not required by QEMU. Standardize

Re: [RFC PATCH] meson: Only install ROMs when building system emulation binaries

2021-01-15 Thread Paolo Bonzini
On 15/01/21 18:51, Philippe Mathieu-Daudé wrote: It is pointless to install ROM blobs for user emulation. Signed-off-by: Philippe Mathieu-Daudé --- RFC because I think it would be better to make the 'blobs' option a 'feature' instead of a boolean so we can set it as 'auto' and then in that

Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

2021-01-15 Thread Daniel Henrique Barboza
On 1/15/21 2:22 PM, Greg Kurz wrote: On Thu, 14 Jan 2021 15:06:28 -0300 Daniel Henrique Barboza wrote: The only restriction we have when unplugging CPUs is to forbid unplug of the boot cpu core. spapr_core_unplug_possible() does not contemplate the I'll look into it. I can't remember

Re: [PATCH v4 01/10] iotests.py: Assume a couple of variables as given

2021-01-15 Thread Willian Rampazzo
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote: > > There are a couple of environment variables that we fetch with > os.environ.get() without supplying a default. Clearly they are required > and expected to be set by the ./check script (as evidenced by > execute_setup_common(), which checks for

Re: [PATCH 1/4] tests/qtest: Remove TPM tests

2021-01-15 Thread Stefan Berger
On 1/15/21 11:06 AM, Philippe Mathieu-Daudé wrote: On 1/15/21 4:53 PM, Stefan Berger wrote: On 1/15/21 10:52 AM, Philippe Mathieu-Daudé wrote: Subject is incorrect, this is not a removal of the tests, but removal of their execution. The tests are still in the repository. This is more of a

Re: [PATCH v2 09/25] tests/docker: fix mistakes in fedora package list

2021-01-15 Thread Wainer dos Santos Moschetta
On 1/14/21 10:02 AM, Daniel P. Berrangé wrote: llvm is not required by QEMU, just clang. libblockdev-mpath-devel is not used by QEMU, rather it wants device-mapper-multipath-devel. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé ---

Re: [RFC PATCH 0/5] hw/block/nvme: support multi-path for ctrl/ns

2021-01-15 Thread Minwoo Im
On 21-01-15 18:47:20, Klaus Jensen wrote: > On Jan 15 09:35, Keith Busch wrote: > > On Fri, Jan 15, 2021 at 02:57:45PM +0100, Klaus Jensen wrote: > > > > > > As you already mentioned, the problem I see with this approach is that > > > we have separate namespaces attached to separate controllers.

Re: [PATCH 05/15] arc: TCG instruction generator and hand-definitions

2021-01-15 Thread Cupertino Miranda
> On 11/11/20 10:17 AM, cupertinomira...@gmail.com wrote: >> +/* >> + * The macro to add boiler plate code for conditional execution. >> + * It will add tcg_gen codes only if there is a condition to >> + * be checked (ctx->insn.cc != 0). This macro assumes that there >> + * is a "ctx" variable of

Re: [PATCH v2 08/25] tests/docker: fix mistakes in centos package lists

2021-01-15 Thread Wainer dos Santos Moschetta
On 1/14/21 10:02 AM, Daniel P. Berrangé wrote: dbus-daemon doesn't exist in centos7, it is part of dbus. snappy is used by QEMU, not csnappy. mesa-libEGL-devel is not used in QEMU at all, but mesa-libgbm-devel is. vte291-devel is required for GTK3, not vte-devel. spice-glib-devel is not

Re: [PATCH 04/15] arc: TCG and decoder glue code and helpers

2021-01-15 Thread Cupertino Miranda
>> +void QEMU_NORETURN helper_halt(CPUARCState *env, uint32_t npc) >> +{ >> +CPUState *cs = env_cpu(env); >> +if (env->stat.Uf) { >> +cs->exception_index = EXCP_PRIVILEGEV; >> +env->causecode = 0; >> +env->param = 0; >> + /* Restore PC such that we point at

Re: [PATCH 06/15] arc: TCG instruction definitions

2021-01-15 Thread Cupertino Miranda
>> + >> +assert(ctx->insn.limm_p == 0 && !in_delay_slot); >> + >> +if (ctx->insn.limm_p == 0 && !in_delay_slot) { >> +in_delay_slot = true; >> +uint32_t cpc = ctx->cpc; >> +uint32_t pcl = ctx->pcl; >> +insn_t insn = ctx->insn; >> + >> +ctx->cpc =

Re: [PATCH 03/15] arc: Opcode definitions table

2021-01-15 Thread Cupertino Miranda
Hi Richard, Sorry to take so long to get through the changes after your review. I am still going through the improving process and waiting for some internal company approval to publish the generator of the TCG instruction definitions, as we have discussed. Nevertheless, there are some

Re: [PATCH v4 03/10] iotests: Move try_remove to iotests.py

2021-01-15 Thread Willian Rampazzo
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote: > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/124| 8 +--- > tests/qemu-iotests/iotests.py | 11 +++ > 2 files changed, 8 insertions(+), 11

Re: [PATCH v4 05/10] iotests/129: Do not check @busy

2021-01-15 Thread Willian Rampazzo
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote: > > @busy is false when the job is paused, which happens all the time > because that is how jobs yield (e.g. for mirror at least since commit > 565ac01f8d3). > > Back when 129 was added (2015), perhaps there was no better way of > checking whether

Re: [PATCH v4 06/10] iotests/129: Use throttle node

2021-01-15 Thread Willian Rampazzo
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote: > > Throttling on the BB has not affected block jobs in a while, so it is > possible that one of the jobs in 129 finishes before the VM is stopped. > We can fix that by running the job from a throttle node. > > Signed-off-by: Max Reitz >

Re: [PATCH v4 07/10] iotests/129: Actually test a commit job

2021-01-15 Thread Willian Rampazzo
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote: > > Before this patch, test_block_commit() performs an active commit, which > under the hood is a mirror job. If we want to test various different > block jobs, we should perhaps run an actual commit job instead. > > Doing so requires adding an

Re: [PATCH v4 10/10] iotests/300: Clean up pylint and mypy complaints

2021-01-15 Thread Willian Rampazzo
On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote: > > And consequentially drop it from 297's skip list. > > Signed-off-by: Max Reitz > Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/297 | 2 +- > tests/qemu-iotests/300 | 18 +++--- > 2 files changed, 16

RE: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-15 Thread Ram Pai
On Thu, Jan 14, 2021 at 10:36:43AM +, Dr. David Alan Gilbert wrote: > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: > > > > > > On 13.01.21 13:42, Dr. David Alan Gilbert wrote: > > > * Cornelia Huck (coh...@redhat.com) wrote: > > >> On Tue, 5 Jan 2021 12:41:25 -0800 > > >> Ram Pai

Re: [PATCH v19 08/20] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers

2021-01-15 Thread Jag Raman
> On Jan 15, 2021, at 4:20 AM, Stefan Hajnoczi wrote: > > On Thu, Jan 14, 2021 at 01:24:37PM -0500, Jag Raman wrote: >> >> >>> On Jan 14, 2021, at 1:00 PM, Daniel P. Berrangé wrote: >>> >>> On Thu, Jan 14, 2021 at 12:55:58PM -0500, Jag Raman wrote: > On Jan 14, 2021, at

Re: About 'qemu-security' list subscription process

2021-01-15 Thread Daniel P . Berrangé
On Thu, Jan 14, 2021 at 07:33:32PM +0530, P J P wrote: > Hello, > > * We have received quite a few subscription requests for the 'qemu-security' > list in the last few weeks. Majority of them are rejected because we could > not identify the user from merely their email-id. > > * I have

Re: [PATCH v2 07/25] tests/docker: fix sorting in package lists

2021-01-15 Thread Wainer dos Santos Moschetta
On 1/14/21 10:02 AM, Daniel P. Berrangé wrote: This will make diffs in later patches clearer. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/centos7.docker | 4 ++-- tests/docker/dockerfiles/fedora.docker| 4 ++--

Re: Windows installer builds apparently broken since October?

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 4:34 PM, Stefan Weil wrote: > Am 15.01.21 um 15:01 schrieb Peter Maydell: > >> I was just trying to see what updates the qemu.nsi file needed for >> the merge-all-the-manuals-into-one-place change, and I discovered >> that it's been broken since October when we removed the Changelog

[RFC PATCH] meson: Only install ROMs when building system emulation binaries

2021-01-15 Thread Philippe Mathieu-Daudé
It is pointless to install ROM blobs for user emulation. Signed-off-by: Philippe Mathieu-Daudé --- RFC because I think it would be better to make the 'blobs' option a 'feature' instead of a boolean so we can set it as 'auto' and then in that case we could do something blobs = have_system

[PATCH v4 08/10] iotests/129: Limit mirror job's buffer size

2021-01-15 Thread Max Reitz
Issuing 'stop' on the VM drains all nodes. If the mirror job has many large requests in flight, this may lead to significant I/O that looks a bit like 'stop' would make the job try to complete (which is what 129 should verify not to happen). We can limit the I/O in flight by limiting the buffer

Re: [RFC PATCH 0/5] hw/block/nvme: support multi-path for ctrl/ns

2021-01-15 Thread Keith Busch
On Fri, Jan 15, 2021 at 06:47:20PM +0100, Klaus Jensen wrote: > Cool! I thought so too :) > Question: NSIDs must be the same on each controller for shared > namespaces, but can private namespaces "share" nsid across controllers > in the subsystem? I don't think the spec is clear on that point.

[PATCH v4 05/10] iotests/129: Do not check @busy

2021-01-15 Thread Max Reitz
@busy is false when the job is paused, which happens all the time because that is how jobs yield (e.g. for mirror at least since commit 565ac01f8d3). Back when 129 was added (2015), perhaps there was no better way of checking whether the job was still actually running. Now we have the @status

Re: [RFC PATCH 0/5] hw/block/nvme: support multi-path for ctrl/ns

2021-01-15 Thread Klaus Jensen
On Jan 15 09:35, Keith Busch wrote: > On Fri, Jan 15, 2021 at 02:57:45PM +0100, Klaus Jensen wrote: > > > > As you already mentioned, the problem I see with this approach is that > > we have separate namespaces attached to separate controllers. So we are > > faking it to the max and if I/O starts

[PATCH v4 03/10] iotests: Move try_remove to iotests.py

2021-01-15 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/124| 8 +--- tests/qemu-iotests/iotests.py | 11 +++ 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/tests/qemu-iotests/124

[PATCH v4 09/10] iotests/129: Clean up pylint and mypy complaints

2021-01-15 Thread Max Reitz
And consequentially drop it from 297's skip list. Signed-off-by: Max Reitz Reviewed-by: Willian Rampazzo Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/129 | 4 ++-- tests/qemu-iotests/297 | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v4 04/10] iotests/129: Remove test images in tearDown()

2021-01-15 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Willian Rampazzo --- tests/qemu-iotests/129 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129 index 0e13244d85..2fc65ada6a 100755 ---

[PATCH v4 07/10] iotests/129: Actually test a commit job

2021-01-15 Thread Max Reitz
Before this patch, test_block_commit() performs an active commit, which under the hood is a mirror job. If we want to test various different block jobs, we should perhaps run an actual commit job instead. Doing so requires adding an overlay above the source node before the commit is done (and

[PATCH v4 10/10] iotests/300: Clean up pylint and mypy complaints

2021-01-15 Thread Max Reitz
And consequentially drop it from 297's skip list. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/297 | 2 +- tests/qemu-iotests/300 | 18 +++--- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/297

[PATCH v4 06/10] iotests/129: Use throttle node

2021-01-15 Thread Max Reitz
Throttling on the BB has not affected block jobs in a while, so it is possible that one of the jobs in 129 finishes before the VM is stopped. We can fix that by running the job from a throttle node. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy ---

[PATCH v4 02/10] iotests/297: Rewrite in Python and extend reach

2021-01-15 Thread Max Reitz
Instead of checking iotests.py only, check all Python files in the qemu-iotests/ directory. Of course, most of them do not pass, so there is an extensive skip list for now. (The only files that do pass are 209, 254, 283, and iotests.py.) (Alternatively, we could have the opposite, i.e. an

[PATCH v4 00/10] iotests: Fix 129 and expand 297’s reach

2021-01-15 Thread Max Reitz
Cover letters: v1: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00254.html v2: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00296.html v3: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00371.html git: https://github.com/XanClic/qemu.git fix-129-2-v4

[PATCH v4 01/10] iotests.py: Assume a couple of variables as given

2021-01-15 Thread Max Reitz
There are a couple of environment variables that we fetch with os.environ.get() without supplying a default. Clearly they are required and expected to be set by the ./check script (as evidenced by execute_setup_common(), which checks for test_dir and qemu_default_machine to be set, and aborts if

Re: [RFC PATCH 0/5] hw/block/nvme: support multi-path for ctrl/ns

2021-01-15 Thread Keith Busch
On Fri, Jan 15, 2021 at 02:57:45PM +0100, Klaus Jensen wrote: > > As you already mentioned, the problem I see with this approach is that > we have separate namespaces attached to separate controllers. So we are > faking it to the max and if I/O starts going through the other > controller we end

Re: Windows installer builds apparently broken since October?

2021-01-15 Thread Paolo Bonzini
On 15/01/21 16:57, Peter Maydell wrote: On Fri, 15 Jan 2021 at 15:52, Stefan Weil wrote: I forgot to mention that some of the problems with the Meson build also occur on macOS with Homebrew: they always happen when a software package requires special compiler flags to find its include files or

Re: [RFC PATCH v0 1/1] target/ppc: Support for H_RPT_INVALIDATE hcall

2021-01-15 Thread Greg Kurz
On Fri, 15 Jan 2021 14:01:28 +0530 Bharata B Rao wrote: > On Wed, Jan 13, 2021 at 05:22:56PM +0100, Greg Kurz wrote: > > Hi Bharata, > > > > On Wed, 6 Jan 2021 14:29:10 +0530 > > Bharata B Rao wrote: > > > > > If KVM_CAP_RPT_INVALIDATE KVM capability is enabled, then > > > > > > - indicate

Re: [PATCH] qtest/npcm7xx_pwm-test: Fix memleak in pwm_qom_get

2021-01-15 Thread Hao Wu via
On Fri, Jan 15, 2021 at 9:17 AM Havard Skinnemoen wrote: > +Hao Wu > > On Fri, Jan 15, 2021 at 1:15 AM Philippe Mathieu-Daudé > wrote: > > > > On 1/15/21 8:56 AM, Gan Qixin wrote: > > > The pwm_qom_get function didn't free "response", which caused an > indirect > > > memory leak. So use

Re: [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug

2021-01-15 Thread Greg Kurz
On Thu, 14 Jan 2021 15:06:28 -0300 Daniel Henrique Barboza wrote: > The only restriction we have when unplugging CPUs is to forbid unplug of > the boot cpu core. spapr_core_unplug_possible() does not contemplate the I can't remember why this restriction was introduced in the first place... This

Re: [PATCH 3/3] tests/acceptance: Add a test for the virtex-ml507 ppc machine

2021-01-15 Thread Willian Rampazzo
On Tue, Jan 12, 2021 at 1:45 PM Thomas Huth wrote: > > The "And a hippo new year" image from the QEMU advent calendar 2020 > can be used to test the virtex-ml507 ppc machine. > > Signed-off-by: Thomas Huth > --- > tests/acceptance/machine_ppc.py | 18 ++ > 1 file changed, 18

Re: [PATCH 2/3] tests/acceptance: Test the mpc8544ds machine

2021-01-15 Thread Willian Rampazzo
On Tue, Jan 12, 2021 at 1:44 PM Thomas Huth wrote: > > We can use the "Stupid creek" image to test the mpc8544ds ppc machine. > > Signed-off-by: Thomas Huth > --- > tests/acceptance/machine_ppc.py | 17 + > 1 file changed, 17 insertions(+) Reviewed-by: Willian Rampazzo

Re: [PATCH] qtest/npcm7xx_pwm-test: Fix memleak in pwm_qom_get

2021-01-15 Thread Havard Skinnemoen via
+Hao Wu On Fri, Jan 15, 2021 at 1:15 AM Philippe Mathieu-Daudé wrote: > > On 1/15/21 8:56 AM, Gan Qixin wrote: > > The pwm_qom_get function didn't free "response", which caused an indirect > > memory leak. So use qobject_unref() to fix it. > > > > ASAN shows memory leak stack: > > > > Indirect

Re: [PATCH] util/cacheflush: Fix error generated by clang

2021-01-15 Thread Richard Henderson
On 1/14/21 9:56 PM, Gan Qixin wrote: > When compiling qemu-fuzz-i386 on aarch64 host, clang reported the following > error: > > ../util/cacheflush.c:38:44: error: value size does not match register size > specified by the constraint and modifier [-Werror,-Wasm-operand-widths] > asm

Re: [PATCH v7 13/13] s390: Recognize confidential-guest-support option

2021-01-15 Thread Cornelia Huck
On Thu, 14 Jan 2021 10:58:11 +1100 David Gibson wrote: > At least some s390 cpu models support "Protected Virtualization" (PV), > a mechanism to protect guests from eavesdropping by a compromised > hypervisor. > > This is similar in function to other mechanisms like AMD's SEV and > POWER's PEF,

Re: Call for Google Summer of Code 2021 project ideas

2021-01-15 Thread Kashyap Chamarthy
On Thu, Jan 14, 2021 at 11:36:23AM -0500, John Snow wrote: > On 1/14/21 7:29 AM, Markus Armbruster wrote: [...] > So I see two possible options for "not inventing a language": > > 1. Raw QMP > 2. The existing qmp-shell syntax, warts and all. > > I don't see a tremendous problem with doing

Re: [PULL 0/1] 9p security fix 2021-01-15

2021-01-15 Thread Peter Maydell
On Fri, 15 Jan 2021 at 09:05, Greg Kurz wrote: > > The following changes since commit 7c79721606be11b5bc556449e5bcbc331ef6867d: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210113' > into staging (2021-01-14 09:54:29 +) > > are available in the Git repository at: >

[Bug 1906693] Re: Assertion Failure in bdrv_co_write_req_prepare through megasas

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1906693 Title: Assertion Failure in bdrv_co_write_req_prepare through megasas Status in QEMU: New Bug description:

[Bug 1904652] Re: Assertion failure in usb-ohci

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1904652 Title: Assertion failure in usb-ohci Status in QEMU: New Bug description: Hello, Using hypervisor fuzzer,

[Bug 1901532] Re: Assertion failure `mr != NULL' failed through usb-ehci

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1901532 Title: Assertion failure `mr != NULL' failed through usb-ehci Status in QEMU: Confirmed Bug description: Hello,

[Bug 1909247] Re: QEMU: use after free vulnerability in esp_do_dma() in hw/scsi/esp.c

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1909247 Title: QEMU: use after free vulnerability in esp_do_dma() in hw/scsi/esp.c Status in QEMU: New Bug description: A

[Bug 1907817] Re: qemu-aarch64 tcg assertion v5.2.0

2021-01-15 Thread Peter Maydell
Fix now in master as commit 6d3ef04893bde -- will be in next QEMU release. ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1907817

[Bug 1905444] Re: [OSS-Fuzz] Issue 27796 in oss-fuzz: qemu:qemu-fuzz-i386-target-generic-fuzz-xhci: Stack-overflow in address_space_stl_internal

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1905444 Title: [OSS-Fuzz] Issue 27796 in oss-fuzz: qemu:qemu-fuzz-i386-target- generic-fuzz-xhci: Stack-overflow in

[Bug 1904954] Re: lan9118 bug peeked received message size not equal to actual received message size

2021-01-15 Thread Peter Maydell
Fix now in master: commit e7e29fdbbe07f. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1904954 Title: lan9118 bug peeked received

[Bug 1907909] Re: assertion failure in am53c974

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1907909 Title: assertion failure in am53c974 Status in QEMU: New Bug description: Hello, Using hypervisor fuzzer,

[Bug 1907497] Re: [OSS-Fuzz] Issue 28435 qemu:qemu-fuzz-i386-target-generic-fuzz-intel-hda: Stack-overflow in ldl_le_dma

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1907497 Title: [OSS-Fuzz] Issue 28435 qemu:qemu-fuzz-i386-target-generic-fuzz-intel- hda: Stack-overflow in ldl_le_dma Status

[Bug 1907938] Re: [OSS-Fuzz] Issue 28524 virtio-blk: ASSERT: !s->dataplane_started

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1907938 Title: [OSS-Fuzz] Issue 28524 virtio-blk: ASSERT: !s->dataplane_started Status in QEMU: New Bug description:

[Bug 1908062] Re: qemu-system-i386 virtio-vga: Assertion in address_space_stw_le_cached failed again

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908062 Title: qemu-system-i386 virtio-vga: Assertion in address_space_stw_le_cached failed again Status in QEMU: New Bug

[Bug 1908515] Re: assertion failure in lsi53c810 emulator

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908515 Title: assertion failure in lsi53c810 emulator Status in QEMU: New Bug description: Hello, Using hypervisor

[Bug 1908513] Re: assertion failure in mptsas1068 emulator

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908513 Title: assertion failure in mptsas1068 emulator Status in QEMU: New Bug description: Using hypervisor fuzzer,

[Bug 1910603] Re: [OSS-Fuzz] Issue 29174 sb16: Abrt in audio_bug

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1910603 Title: [OSS-Fuzz] Issue 29174 sb16: Abrt in audio_bug Status in QEMU: New Bug description: === Reproducer ===

[Bug 1910826] Re: [OSS-Fuzz] Issue 29224 rtl8139: Stack-overflow in rtlNUMBER_transmit_one

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1910826 Title: [OSS-Fuzz] Issue 29224 rtl8139: Stack-overflow in rtlNUMBER_transmit_one Status in QEMU: New Bug

[Bug 1909261] Re: [OSS-Fuzz] Issue 28929 xhci: ASSERT: xfer->packet.status != USB_RET_NAK

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1909261 Title: [OSS-Fuzz] Issue 28929 xhci: ASSERT: xfer->packet.status != USB_RET_NAK Status in QEMU: New Bug

[Bug 1910941] Re: Assertion `addr < cache->len && 2 <= cache->len - addr' in virtio-blk

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1910941 Title: Assertion `addr < cache->len && 2 <= cache->len - addr' in virtio-blk Status in QEMU: New Bug description:

[Bug 1911075] Re: [OSS-Fuzz] ahci: stack overflow in ahci_cond_start_engines

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1911075 Title: [OSS-Fuzz] ahci: stack overflow in ahci_cond_start_engines Status in QEMU: Confirmed Bug description: ===

[Bug 1911839] Re: [OSS-Fuzz] Issue 29586 e1000e: Memcpy-param-overlap in flatview_write_continue

2021-01-15 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1911839 Title: [OSS-Fuzz] Issue 29586 e1000e: Memcpy-param-overlap in flatview_write_continue Status in QEMU: New Bug

Re: [PATCH 1/4] tests/qtest: Remove TPM tests

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 5:06 PM, Philippe Mathieu-Daudé wrote: > On 1/15/21 4:53 PM, Stefan Berger wrote: >> On 1/15/21 10:52 AM, Philippe Mathieu-Daudé wrote: >>> Subject is incorrect, this is not a removal of the tests, but >>> removal of their execution. The tests are still in the repository. >>> This is

Re: [PATCH 3/3] net/colo-compare: Add handler for passthrough connection

2021-01-15 Thread Lukas Straub
On Fri, 15 Jan 2021 09:07:47 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub > > Sent: Thursday, January 14, 2021 9:45 PM > > To: Zhang, Chen > > Cc: Jason Wang ; qemu-dev > de...@nongnu.org>; Eric Blake ; Dr. David Alan > > Gilbert ; Markus Armbruster ; > >

Re: [PATCH 1/4] tests/qtest: Remove TPM tests

2021-01-15 Thread Philippe Mathieu-Daudé
On 1/15/21 4:53 PM, Stefan Berger wrote: > On 1/15/21 10:52 AM, Philippe Mathieu-Daudé wrote: >> Subject is incorrect, this is not a removal of the tests, but >> removal of their execution. The tests are still in the repository. >> This is more of a disablement. > > How do you compile / run them

Re: Windows installer builds apparently broken since October?

2021-01-15 Thread Peter Maydell
On Fri, 15 Jan 2021 at 15:52, Stefan Weil wrote: > I forgot to mention that some of the problems with the Meson build also > occur on macOS with Homebrew: they always happen when a software package > requires special compiler flags to find its include files or libraries, > but the Meson build

Re: [PATCH 1/4] tests/qtest: Remove TPM tests

2021-01-15 Thread Stefan Berger
On 1/15/21 10:52 AM, Philippe Mathieu-Daudé wrote: Subject is incorrect, this is not a removal of the tests, but removal of their execution. The tests are still in the repository. This is more of a disablement. How do you compile / run them to have the LeakSanitizer checks?

Re: Windows installer builds apparently broken since October?

2021-01-15 Thread Stefan Weil
Am 15.01.21 um 16:19 schrieb Peter Maydell: On Fri, 15 Jan 2021 at 14:01, Peter Maydell wrote: I was just trying to see what updates the qemu.nsi file needed for the merge-all-the-manuals-into-one-place change, and I discovered that it's been broken since October when we removed the Changelog

Re: [PATCH 1/4] tests/qtest: Remove TPM tests

2021-01-15 Thread Philippe Mathieu-Daudé
Subject is incorrect, this is not a removal of the tests, but removal of their execution. The tests are still in the repository. This is more of a disablement. On 1/15/21 4:09 PM, Philippe Mathieu-Daudé wrote: > The TPM tests are failing, and no further tests are run, > making the rest of the

Re: Realize methods realizing "sideways" in the composition tree

2021-01-15 Thread Peter Maydell
On Fri, 15 Jan 2021 at 15:45, Markus Armbruster wrote: > > The .realize() method realizes the child at (1). It should use > qdev_realize() like we do everywhere else, since commit ce189ab230 > "qdev: Convert bus-less devices to qdev_realize() with Coccinelle". > > It sets a link property from

Re: Windows installer builds apparently broken since October?

2021-01-15 Thread Peter Maydell
On Fri, 15 Jan 2021 at 15:34, Stefan Weil wrote: > although I have some local fixes (available for example in > https://github.com/stweil/qemu/) I am still struggling with 5.2.0. > > One problem which was recently discussed on the list is the directory > structure of the installation (especially

Re: [PATCH 7/7] block/rbd: change request alignment to 1 byte

2021-01-15 Thread Peter Lieven
Am 15.01.21 um 16:27 schrieb Jason Dillaman: > On Thu, Jan 14, 2021 at 2:59 PM Peter Lieven wrote: >> Am 14.01.21 um 20:19 schrieb Jason Dillaman: >>> On Sun, Dec 27, 2020 at 11:42 AM Peter Lieven wrote: since we implement byte interfaces and librbd supports aio on byte granularity we

Re: [PATCH] fuzz: Add virtio-9p configurations for fuzzing

2021-01-15 Thread Alexander Bulekov
On 210115 1351, Christian Schoenebeck wrote: > On Freitag, 15. Januar 2021 13:23:08 CET Greg Kurz wrote: > > On Thu, 14 Jan 2021 17:17:48 -0500 > > > > Alexander Bulekov wrote: > > > Signed-off-by: Alexander Bulekov > > > --- > > > > No changelog at all ? > > Yeah, that's indeed quite short.

<    1   2   3   4   5   >