[PULL 23/56] hw/block/nvme: merge implicitly/explicitly opened processing masks

2021-02-08 Thread Klaus Jensen
From: Klaus Jensen Implicitly and explicitly opended zones are always bulk processed together, so merge the two processing masks. Signed-off-by: Klaus Jensen Tested-by: Dmitry Fomichev Reviewed-by: Dmitry Fomichev --- hw/block/nvme.c | 27 +++ 1 file changed, 11 inser

[PULL 14/56] hw/block/nvme: Support allocated CNS command variants

2021-02-08 Thread Klaus Jensen
From: Niklas Cassel Many CNS commands have "allocated" command variants. These include a namespace as long as it is allocated, that is a namespace is included regardless if it is active (attached) or not. While these commands are optional (they are mandatory for controllers supporting the namesp

[PULL 12/56] hw/block/nvme: Add Commands Supported and Effects log

2021-02-08 Thread Klaus Jensen
From: Dmitry Fomichev This log page becomes necessary to implement to allow checking for Zone Append command support in Zoned Namespace Command Set. This commit adds the code to report this log page for NVM Command Set only. The parts that are specific to zoned operation will be added later in t

[PULL 07/56] hw/block/nvme: fix bad clearing of CAP

2021-02-08 Thread Klaus Jensen
From: Klaus Jensen Commit 37712e00b1f0 ("hw/block/nvme: factor out pmr setup") changed the control flow such that the CAP register is erronously cleared after nvme_init_pmr() has configured it. Since the entire NvmeCtrl structure is zero-filled initially, there is no need for the explicit clearin

[PULL 15/56] nvme: Make ZNS-related definitions

2021-02-08 Thread Klaus Jensen
From: Dmitry Fomichev Define values and structures that are needed to support Zoned Namespace Command Set (NVMe TP 4053). Signed-off-by: Dmitry Fomichev Acked-by: Stefan Hajnoczi Reviewed-by: Keith Busch Signed-off-by: Klaus Jensen --- include/block/nvme.h | 114

[PULL 11/56] hw/block/nvme: Combine nvme_write_zeroes() and nvme_write()

2021-02-08 Thread Klaus Jensen
From: Dmitry Fomichev Move write processing to nvme_do_write() that now handles both WRITE and WRITE ZEROES. Both nvme_write() and nvme_write_zeroes() become inline helper functions. Signed-off-by: Dmitry Fomichev Reviewed-by: Niklas Cassel Reviewed-by: Keith Busch Signed-off-by: Klaus Jensen

[PULL 05/56] hw/block/nvme: add the dataset management command

2021-02-08 Thread Klaus Jensen
From: Klaus Jensen Add support for the Dataset Management command and the Deallocate attribute. Deallocation results in discards being sent to the underlying block device. Whether of not the blocks are actually deallocated is affected by the same factors as Write Zeroes (see previous commit).

[PULL 09/56] hw/block/nvme: Generate namespace UUIDs

2021-02-08 Thread Klaus Jensen
From: Dmitry Fomichev In NVMe 1.4, a namespace must report an ID descriptor of UUID type if it doesn't support EUI64 or NGUID. Add a new namespace property, "uuid", that provides the user the option to either specify the UUID explicitly or have a UUID generated automatically every time a namespac

[PULL 10/56] hw/block/nvme: Separate read and write handlers

2021-02-08 Thread Klaus Jensen
From: Dmitry Fomichev The majority of code in nvme_rw() is becoming read- or write-specific. Move these parts to two separate handlers, nvme_read() and nvme_write() to make the code more readable and to remove multiple is_write checks that has been present in the i/o path. This is a refactoring

[PULL 03/56] hw/block/nvme: add dulbe support

2021-02-08 Thread Klaus Jensen
From: Klaus Jensen Add support for reporting the Deallocated or Unwritten Logical Block Error (DULBE). Rely on the block status flags reported by the block layer and consider any block with the BDRV_BLOCK_ZERO flag to be deallocated. Multiple factors affect when a Write Zeroes command result in

[PULL 04/56] nvme: add namespace I/O optimization fields to shared header

2021-02-08 Thread Klaus Jensen
From: Klaus Jensen This adds the NPWG, NPWA, NPDG, NPDA and NOWS family of fields to the shared nvme.h header for use by later patches. Signed-off-by: Klaus Jensen Cc: Stefan Hajnoczi Cc: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Minwoo Im --- include/block/nvme.h | 7 ++- 1

[PULL 06/56] hw/block/nvme: add compare command

2021-02-08 Thread Klaus Jensen
From: Gollu Appalanaidu Add the Compare command. This implementation uses a bounce buffer to read in the data from storage and then compare with the host supplied buffer. Signed-off-by: Gollu Appalanaidu [k.jensen: rebased] Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im Reviewed-by: Keit

[PULL 08/56] hw/block/nvme: Process controller reset and shutdown differently

2021-02-08 Thread Klaus Jensen
From: Dmitry Fomichev Controller reset ans subsystem shutdown are handled very much the same in the current code, but some of the steps should be different in these two cases. Introduce two new functions, nvme_reset_ctrl() and nvme_shutdown_ctrl(), to separate some portions of the code from nvme

[PULL 02/56] hw/block/nvme: pull aio error handling

2021-02-08 Thread Klaus Jensen
From: Klaus Jensen Add a new function, nvme_aio_err, to handle errors resulting from AIOs and use this from the callbacks. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 61 + 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/hw/

[PULL 00/56] emulated nvme patches

2021-02-08 Thread Klaus Jensen
From: Klaus Jensen The following changes since commit 4f799257b323e1238a900fd0c71c2057863e0308: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-02-08' into staging (2021-02-08 16:12:21 +) are available in the Git repository at: git://git.infradead.org/qemu-nvme.git ta

[PULL 01/56] hw/block/nvme: remove superfluous NvmeCtrl parameter

2021-02-08 Thread Klaus Jensen
From: Klaus Jensen nvme_check_bounds has no use of the NvmeCtrl parameter; remove it. Signed-off-by: Klaus Jensen Reviewed-by: Minwoo Im --- hw/block/nvme.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 27d2c72716eb..b0816d

Re: [RFC PATCH v2 0/4] Allow changing bs->file on reopen

2021-02-08 Thread Vladimir Sementsov-Ogievskiy
08.02.2021 21:44, Alberto Garcia wrote: Hi, this series allows changing bs->file using x-blockdev-reopen. Read here for more details: https://lists.gnu.org/archive/html/qemu-block/2021-01/msg00437.html Version 2 of the series introduces a very significant change: x-blockdev-reopen now rece

Re: [PATCH 0/3] fix build failures from incorrectly skipped container build jobs

2021-02-08 Thread Thomas Huth
On 09/02/2021 07.01, Stefan Weil wrote: Am 08.02.21 um 19:12 schrieb Daniel P. Berrangé: On Mon, Feb 08, 2021 at 07:08:39PM +0100, Philippe Mathieu-Daudé wrote: On 2/8/21 6:22 PM, Daniel P. Berrangé wrote: On Mon, Feb 08, 2021 at 04:33:36PM +, Daniel P. Berrangé wrote: This series fixes

Re: [PATCH 2/3] gitlab: add fine grained job deps for all build jobs

2021-02-08 Thread Thomas Huth
On 08/02/2021 17.33, Daniel P. Berrangé wrote: This allows the build jobs to start running as soon as their respective container image is ready, instead of waiting for all container builds to finish. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 58 +++

Re: [PATCH 1/3] gitlab: always build container images

2021-02-08 Thread Thomas Huth
On 08/02/2021 17.33, Daniel P. Berrangé wrote: [...] For example, consider pushing 5 commits, one of which contains a dockerfile change. This will trigger a CI pipeline for the containers. Now consider you do some more work on the branch and push 3 further commits, so you now have a branch of 8 c

Re: [PULL v3 00/27] Block patches

2021-02-08 Thread Thomas Huth
On 08/02/2021 21.21, Stefan Hajnoczi wrote: On Mon, Feb 08, 2021 at 11:02:57AM +0100, Philippe Mathieu-Daudé wrote: On 2/8/21 10:27 AM, Stefan Hajnoczi wrote: On Sat, Feb 06, 2021 at 05:03:20PM +, Peter Maydell wrote: On Fri, 5 Feb 2021 at 22:53, Peter Maydell wrote: On Fri, 5 Feb 2021

Re: [PATCH 0/3] fix build failures from incorrectly skipped container build jobs

2021-02-08 Thread Stefan Weil
Am 08.02.21 um 19:12 schrieb Daniel P. Berrangé: On Mon, Feb 08, 2021 at 07:08:39PM +0100, Philippe Mathieu-Daudé wrote: On 2/8/21 6:22 PM, Daniel P. Berrangé wrote: On Mon, Feb 08, 2021 at 04:33:36PM +, Daniel P. Berrangé wrote: This series fixes a problem with our gitlab CI rules that c

Re: [PATCH 3/5] target/ppc: Drop use of gdb_get_float64() and ldfq_p()

2021-02-08 Thread David Gibson
On Mon, Feb 08, 2021 at 11:34:26AM +, Peter Maydell wrote: > We used to make a distinction between 'float64'/'float32' types and > the 'uint64_t'/'uint32_t' types, requiring special conversion > operations to go between them. We've now dropped this distinction as > unnecessary, and the 'float*

[PATCH v2] char: don't fail when client is not connected

2021-02-08 Thread Pavel Dovgalyuk
This patch checks that ioc is not null before using it in tcp socket tcp_chr_add_watch function. The failure occurs in replay mode of the execution, when monitor and serial port are tcp servers, and there are no clients connected to them: -monitor tcp:127.0.0.1:8081,server,nowait -serial tcp:127.

Re: [PATCH v2] hw/net: fsl_etsec: Reverse the RCTRL.RSF logic

2021-02-08 Thread David Gibson
On Tue, Feb 09, 2021 at 09:22:41AM +0800, Bin Meng wrote: > From: Bin Meng > > Per MPC8548ERM [1] chapter 14.5.3.4.1: > > When RCTRL.RSF is 1, frames less than 64 bytes are accepted upon > a DA match. But currently QEMU does the opposite. > > When RCTRL.RSF is 0, short frames are silently dropp

[Bug 1580586] Re: Qemu WinXP SP3 second loadvm freezes Guest OS

2021-02-08 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1580586 Title: Qemu WinXP

[Bug 1597138] Re: Deadlock on Windows 10 pop-up

2021-02-08 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1597138 Title: Deadlock on

[Bug 1598612] Re: Windows for Workgroups 3.11 installer crashes with a general protection fault

2021-02-08 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1598612 Title: Windows for

[Bug 1598029] Re: failed to boot a customized kernel if emulating Broadwell/Skylake

2021-02-08 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1598029 Title: failed to b

[Bug 1877384] Re: 9pfs file create with mapped-xattr can fail on overlayfs

2021-02-08 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1877384 Title: 9pfs file c

Re: [PATCH RFC] pvrdma: wean code off pvrdma_ring.h kernel header

2021-02-08 Thread Jason Wang
On 2021/2/9 上午1:28, Paolo Bonzini wrote: On 08/02/21 18:17, Cornelia Huck wrote: On Fri, 29 Jan 2021 16:27:19 +0100 Cornelia Huck wrote: On Fri, 22 Jan 2021 19:00:29 +0100 Cornelia Huck wrote: The pvrdma code relies on the pvrdma_ring.h kernel header for some basic ring buffer handling.

Re: [PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev

2021-02-08 Thread Jason Wang
On 2021/2/9 上午3:59, Yuri Benditovich wrote: On Mon, Feb 8, 2021 at 6:11 AM Jason Wang wrote: On 2021/2/5 上午4:29, Yuri Benditovich wrote: Currently virtio-net silently clears features if they are not supported by respective vhost. This may create migration problems in future if vhost feature

Re: [PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev

2021-02-08 Thread Jason Wang
On 2021/2/9 上午3:46, Yuri Benditovich wrote: On Mon, Feb 8, 2021 at 5:15 AM Jason Wang wrote: On 2021/2/5 下午9:38, Michael S. Tsirkin wrote: On Thu, Feb 04, 2021 at 10:29:15PM +0200, Yuri Benditovich wrote: Currently virtio-net silently clears features if they are not supported by respective

Re: [PATCH] vhost: Unbreak SMMU and virtio-iommu on dev-iotlb support

2021-02-08 Thread Jason Wang
On 2021/2/9 上午2:37, Peter Xu wrote: On Mon, Feb 08, 2021 at 11:21:23AM +0800, Jason Wang wrote: [...] I'm not sure I remember it right, but we seem to have similar discussion previously on "what if the user didn't specify ats=on" - I think at that time the conclusion was that we ignore the f

Re: [PATCH v2 2/2] hw/ssi: xilinx_spips: Implement basic QSPI DMA support

2021-02-08 Thread Bin Meng
Hi Edgar, On Mon, Feb 8, 2021 at 11:17 PM Edgar E. Iglesias wrote: > > > > On Mon, Feb 8, 2021 at 3:45 PM Bin Meng wrote: >> >> Hi Edgar, >> >> On Mon, Feb 8, 2021 at 10:34 PM Edgar E. Iglesias >> wrote: >> > >> > >> > >> > On Mon, 8 Feb 2021, 15:10 Bin Meng, wrote: >> >> >> >> Hi Edgar, >> >>

Re: [PATCH v1 1/1] MAINTAINERS: Add a SiFIve machine section

2021-02-08 Thread Palmer Dabbelt
"SiFive", not "SiFIve", in the subject. On Mon, 08 Feb 2021 18:11:27 PST (-0800), Alistair Francis wrote: Signed-off-by: Alistair Francis Acked-by: Bin Meng --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8d8b0bf966..c347d49bd2 1006

Re: [PATCH v1 1/1] MAINTAINERS: Add a SiFIve machine section

2021-02-08 Thread Bin Meng
On Tue, Feb 9, 2021 at 10:11 AM Alistair Francis wrote: nits: SiFIve => SiFive in the title > > Signed-off-by: Alistair Francis > Acked-by: Bin Meng > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > Regards, Bin

[PATCH v1 1/1] MAINTAINERS: Add a SiFIve machine section

2021-02-08 Thread Alistair Francis
Signed-off-by: Alistair Francis Acked-by: Bin Meng --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8d8b0bf966..c347d49bd2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1359,6 +1359,15 @@ F: include/hw/misc/mchp_pfsoc_dmc.h F: include

Booting nuvoton qemu machine with -kernel

2021-02-08 Thread Joel Stanley
Hello nuvoton qemu people, I was attempting to use the npcm750-evb machine to boot test some Linux kernel changes, by running the kernel directly without a filesystem (and therefore not running the bootrom or u-boot). I do this with the Aspeed machines quite often, and it's really useful. The mac

[PATCH v3 3/3] tests/qtests: Add npcm7xx emc model test

2021-02-08 Thread Doug Evans via
Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans --- Differences from v2: - remove use of C99 mixed decls/statements tests/qtest/meson.build| 1 + tests/qtest/npcm7xx_emc-test.c | 812 + 2 files change

[PATCH v3 2/3] hw/arm: Add npcm7xx emc model

2021-02-08 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Reviewed-by: Peter Maydell Signed-off-by: Doug Evans --- Differences

[PATCH v3 1/3] hw/net: Add npcm7xx emc model

2021-02-08 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Signed-off-by: Doug Evans --- Differences from v2: - move call to qem

[PATCH v3 0/3] Add npcm7xx emc model

2021-02-08 Thread Doug Evans via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Doug Evans (3): hw/net: Add npcm7xx emc model hw/arm: Add npcm7xx emc model tests/qtests: Add npcm7xx emc model

Re: [PATCH v3 3/9] hw/ssi: Add SiFive SPI controller support

2021-02-08 Thread Palmer Dabbelt
On Mon, 08 Feb 2021 17:44:17 PST (-0800), alistai...@gmail.com wrote: On Mon, Jan 25, 2021 at 11:34 PM Philippe Mathieu-Daudé wrote: On 1/26/21 7:00 AM, Bin Meng wrote: > From: Bin Meng > > This adds the SiFive SPI controller model for the FU540 SoC. > The direct memory-mapped SPI flash mode

Re: [PATCH v2 6/7] goldfish_rtc: re-arm the alarm after migration

2021-02-08 Thread Alistair Francis
On Sat, Feb 6, 2021 at 6:46 AM Laurent Vivier wrote: > > Le 26/01/2021 à 00:44, Alistair Francis a écrit : > > On Sat, Jan 23, 2021 at 7:06 AM Laurent Vivier wrote: > >> > >> Is there someone to merge this? > > > > Do you mean just this patch or the whole series? > > Sorry, I missed your mail. >

Re: [PATCH v3 3/9] hw/ssi: Add SiFive SPI controller support

2021-02-08 Thread Bin Meng
On Tue, Feb 9, 2021 at 9:44 AM Alistair Francis wrote: > > On Mon, Jan 25, 2021 at 11:34 PM Philippe Mathieu-Daudé > wrote: > > > > On 1/26/21 7:00 AM, Bin Meng wrote: > > > From: Bin Meng > > > > > > This adds the SiFive SPI controller model for the FU540 SoC. > > > The direct memory-mapped SP

Re: [PATCH v3 3/9] hw/ssi: Add SiFive SPI controller support

2021-02-08 Thread Alistair Francis
On Mon, Jan 25, 2021 at 11:34 PM Philippe Mathieu-Daudé wrote: > > On 1/26/21 7:00 AM, Bin Meng wrote: > > From: Bin Meng > > > > This adds the SiFive SPI controller model for the FU540 SoC. > > The direct memory-mapped SPI flash mode is unsupported. > > > > Signed-off-by: Bin Meng > > > > --- >

Re: [PATCH v3 3/9] hw/ssi: Add SiFive SPI controller support

2021-02-08 Thread Alistair Francis
On Mon, Jan 25, 2021 at 10:03 PM Bin Meng wrote: > > From: Bin Meng > > This adds the SiFive SPI controller model for the FU540 SoC. > The direct memory-mapped SPI flash mode is unsupported. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > > --- > > Changes in v3: > - Sim

Re: KVM Guest

2021-02-08 Thread Huacai Chen
I think it can be removed. Huacai On Tue, Feb 9, 2021 at 12:40 AM Jiaxun Yang wrote: > > > > On Mon, Feb 8, 2021, at 3:39 AM, Thomas Bogendoerfer wrote: > > On Wed, Feb 03, 2021 at 08:52:34PM +0800, Jiaxun Yang wrote: > > > > > > > > > On Wed, Feb 3, 2021, at 8:34 PM, Thomas Bogendoerfer wrote:

Re: [PATCH v2 1/3] hw/net: Add npcm7xx emc model

2021-02-08 Thread Doug Evans
On Mon, Feb 8, 2021 at 9:17 AM Peter Maydell wrote: > On Tue, 2 Feb 2021 at 23:29, Doug Evans wrote: > > > > This is a 10/100 ethernet device that has several features. > > Only the ones needed by the Linux driver have been implemented. > > See npcm7xx_emc.c for a list of unimplemented features.

[PATCH v2] hw/net: fsl_etsec: Reverse the RCTRL.RSF logic

2021-02-08 Thread Bin Meng
From: Bin Meng Per MPC8548ERM [1] chapter 14.5.3.4.1: When RCTRL.RSF is 1, frames less than 64 bytes are accepted upon a DA match. But currently QEMU does the opposite. When RCTRL.RSF is 0, short frames are silently dropped, however we cannot drop such frames in QEMU as of today, due to both sl

Re: [RFC 0/1] vhost-vdmabuf: Add virtio based Dmabuf device

2021-02-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210208233225.2084469-1-vivek.kasire...@intel.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210208233225.2084469-1-vivek.kasire...@intel.com Subject: [RFC 0/1] vhost-vdmab

Re: [Bug 1914849] Re: mprotect fails after MacOS 11.2 on arm mac

2021-02-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/161280769492.2878.8851519112088854609.mal...@chaenomeles.canonical.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 161280769492.2878.8851519112088854609.mal...@chaenomeles.can

Re: [RFC PATCH v2 5/6] accel/tcg: Refactor debugging tlb_assert_iotlb_entry_for_ptr_present()

2021-02-08 Thread Richard Henderson
On 2/8/21 5:52 AM, Philippe Mathieu-Daudé wrote: > On 2/8/21 9:42 AM, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> Refactor debug code as tlb_assert_iotlb_entry_for_ptr_present() helper. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> What this code does is out of my l

Re: [PATCH v2 13/15] tcg/arm: Implement TCG_TARGET_HAS_shv_vec

2021-02-08 Thread Richard Henderson
On 2/8/21 12:50 PM, Peter Maydell wrote: > On Mon, 8 Feb 2021 at 03:28, Richard Henderson > wrote: >> >> The three vector shift by vector operations are all implemented via >> expansion. Therefore do not actually set TCG_TARGET_HAS_shv_vec, >> as none of shlv_vec, shrv_vec, sarv_vec may actually

[PATCH v2 6/9] hw/i386: declare ACPI mother board resource for MMCONFIG region

2021-02-08 Thread isaku . yamahata
From: Isaku Yamahata Declare PNP0C01 device to reserve MMCONFIG region to conform to the spec better and play nice with guest BIOSes/OSes. According to PCI Firmware Specification, MMCONFIG region must be reserved by declaring a motherboard resource. It's optional to reserve the region in memory

[PATCH v2 5/9] acpi: add test case for smm unsupported -machine smm=off

2021-02-08 Thread isaku . yamahata
From: Isaku Yamahata Signed-off-by: Isaku Yamahata --- tests/qtest/bios-tables-test.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 669202fc95..096d15db68 100644 --- a/tests/qtest/bios-tables-test.c +++ b/

[PATCH v2 4/9] acpi: set fadt.smi_cmd to zero when SMM is not supported

2021-02-08 Thread isaku . yamahata
From: Isaku Yamahata >From table 5.9 SMI_CMD of ACPI spec > This field is reserved and must be zero on system > that does not support System Management mode. When smm is not enabled, set it to zero to comform to the spec. When -machine smm=off is passed, the change to FACP is as follows. @@ -1,

[PATCH v2 2/9] qtest: update tests/qtest/bios-tables-test-allowed-diff.h

2021-02-08 Thread isaku . yamahata
From: Isaku Yamahata The following tests will modify acpi tables. prepare qtests to allow acpi table change. add new tables for new tests. - tests/data/acpi/q35/DSDT.nosmm - tests/data/acpi/q35/FACP.nosmm - tests/data/acpi/q35/DSDT.nohpet Signed-off-by: Isaku Yamahata --- tests/data/acpi/q35/D

Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations

2021-02-08 Thread John Snow
On 2/8/21 4:39 PM, John Snow wrote: I'm once again terminally confused about when to use _lower_case and when to use CamelCase for such variables. That's my fault for not using them consistently. Generally: TitleCase: Classes, Real Type Names :tm: lowercase: instance names (and certain buil

Re: [PATCH 1/1] acpi: Implement ACPI ERST support for guests

2021-02-08 Thread Eric Devolder
Paolo, Thanks for the feedback. I've posted v2 with changes based on Igor's feedback. I've also included a qtest per your feedback. Eric From: Paolo Bonzini Sent: Tuesday, November 3, 2020 3:16 PM To: Eric DeVolder ; qemu-devel@nongnu.org Cc: m...@redhat.com ; i

Re: [PATCH 0/1] acpi: Implement ACPI ERST support for guests

2021-02-08 Thread Eric Devolder
Igor, Thanks for the feedback. Please see EJD: inline below. I've posted v2 of this patch based on your feedback. eric From: Igor Mammedov Sent: Tuesday, November 3, 2020 8:57 AM To: Eric DeVolder Cc: qemu-devel@nongnu.org ; m...@redhat.com ; marcel.apfelb...@gm

[PATCH v2 3/7] ACPI ERST: support for ACPI ERST feature

2021-02-08 Thread Eric DeVolder
This change implements the support for the ACPI ERST feature[1,2]. The size of the ACPI ERST storage is declared via the QEMU global parameter acpi-erst.size. The size can range from 64KiB to to 64MiB. The default is 64KiB. The location of the ACPI ERST storage backing file is delared via the QEM

Re: [PATCH RESEND] hw/net: fsl_etsec: Do not reject short frames

2021-02-08 Thread Bin Meng
Cc'ing libSLiRP Hi Peter, On Tue, Feb 9, 2021 at 12:09 AM Peter Maydell wrote: > > On Mon, 8 Feb 2021 at 14:53, Bin Meng wrote: > > > > From: Bin Meng > > > > As of today both slirp and tap networking do not pad short frames > > (e.g.: an ARP packet) to the minimum frame size of 60 bytes. > >

[RFC 1/1] vhost-vdmabuf: Add virtio based Dmabuf device

2021-02-08 Thread Vivek Kasireddy
This patch provides the implementation of the virtio dmabuf device that is used to share a dmabuf created in the Guest with the Host. Once the vhost vdmabuf kernel driver on the Host alerts Qemu about a new dmabuf from the Guest, it is first imported and then converted into a texture using EGL and

[PATCH v2 2/7] ACPI ERST: header file for erst

2021-02-08 Thread Eric DeVolder
This change introduces the defintions for ACPI ERST support. Signed-off-by: Eric DeVolder --- include/hw/acpi/erst.h | 77 ++ 1 file changed, 77 insertions(+) create mode 100644 include/hw/acpi/erst.h diff --git a/include/hw/acpi/erst.h b/include

[PATCH 2/4] accel/tcg: Create io_recompile_replay_branch hook

2021-02-08 Thread Richard Henderson
Create a hook in which to split out the mips and sh4 ifdefs from cpu_io_recompile. Signed-off-by: Richard Henderson --- include/hw/core/tcg-cpu-ops.h | 10 ++ accel/tcg/translate-all.c | 17 + 2 files changed, 23 insertions(+), 4 deletions(-) diff --git a/include/hw/

[RFC 0/1] vhost-vdmabuf: Add virtio based Dmabuf device

2021-02-08 Thread Vivek Kasireddy
The Virtio based Dmabuf (Vdmabuf) device provides a way to transfer a dmabuf created in the Guest to the Host. This patch is still a WIP but is still posted to the ML to provide additional details and context for the discussion associated with the vhost-vdmabuf and virtio-vdmabuf kernel drivers her

Re: [PATCH v5 09/15] qapi/introspect.py: create a typed 'Annotated' data strutcure

2021-02-08 Thread John Snow
On 2/8/21 9:36 AM, Markus Armbruster wrote: John Snow writes: Presently, we use a tuple to attach a dict containing annotations (comments and compile-time conditionals) to a tree node. This is undesirable because dicts are difficult to strongly type; promoting it to a real class allows us to n

[PATCH 1/4] exec: Move TranslationBlock typedef to qemu/typedefs.h

2021-02-08 Thread Richard Henderson
This also means we don't need an extra declaration of the structure in hw/core/cpu.h. Signed-off-by: Richard Henderson --- include/exec/tb-context.h | 1 - include/hw/core/cpu.h | 4 +--- include/hw/core/tcg-cpu-ops.h | 3 +-- include/qemu/typedefs.h | 1 + target/arm/internals

[PATCH 3/4] target/mips: Create mips_io_recompile_replay_branch

2021-02-08 Thread Richard Henderson
Move the code from accel/tcg/translate-all.c to target/mips/cpu.c. Signed-off-by: Richard Henderson --- Cc: Philippe Mathieu-Daudé Cc: Aurelien Jarno Cc: Jiaxun Yang --- accel/tcg/translate-all.c | 12 ++-- target/mips/cpu.c | 18 ++ 2 files changed, 20 inserti

Re: [PATCH v2 15/15] tcg/arm: Implement TCG_TARGET_HAS_rotv_vec

2021-02-08 Thread Peter Maydell
On Mon, 8 Feb 2021 at 04:03, Richard Henderson wrote: > > Implement via expansion, so don't actually set TCG_TARGET_HAS_rotv_vec. > > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.c.inc | 35 ++- > 1 file changed, 34 insertions(+), 1 deletion(-) > R

[PATCH 0/4] accel/tcg: Create io_recompile_replay_branch hook

2021-02-08 Thread Richard Henderson
I noticed this today while Alex and I were discussing cpu_io_recompile. This cleanup seems much easier now that Claudio has split out TCGCPUOps. I see that mips has a ReplayKernel test, but sh4 does not, so this probably has non-zero testing. r~ Richard Henderson (4): exec: Move TranslationB

Re: [PATCH v4 02/10] iotests/297: Rewrite in Python and extend reach

2021-02-08 Thread Willian Rampazzo
On 1/18/21 7:09 AM, Max Reitz wrote: On 15.01.21 20:27, Willian Rampazzo wrote: On Fri, Jan 15, 2021 at 2:43 PM Max Reitz wrote: Instead of checking iotests.py only, check all Python files in the qemu-iotests/ directory.  Of course, most of them do not pass, so there is an extensive skip l

Re: [PULL v3 00/27] Block patches

2021-02-08 Thread Stefan Hajnoczi
On Mon, Feb 08, 2021 at 11:02:57AM +0100, Philippe Mathieu-Daudé wrote: > On 2/8/21 10:27 AM, Stefan Hajnoczi wrote: > > On Sat, Feb 06, 2021 at 05:03:20PM +, Peter Maydell wrote: > >> On Fri, 5 Feb 2021 at 22:53, Peter Maydell > >> wrote: > >>> > >>> On Fri, 5 Feb 2021 at 16:45, Stefan Hajno

Re: [PATCH v5] qga: Utilize QAPI_LIST_APPEND in qmp_guest_network_get_interfaces

2021-02-08 Thread Michael Roth
On Mon, Feb 08, 2021 at 02:23:59PM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > I found another spot that can benefit from using our macros instead of > > open-coding qapi list creation. > > > > Signed-off-by: Eric Blake > > --- > > Reviewed-by: Markus Armbruster > > Mike, would

Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls

2021-02-08 Thread Richard Henderson
On 2/8/21 11:04 AM, Stefan Weil wrote: > > Am 08.02.21 um 18:39 schrieb Richard Henderson: >> On 2/8/21 5:07 AM, Stefan Weil wrote: >>> Richard, this commit is also the one which breaks qemu-system-i386 on >>> sparc64 >>> for me: >> You'll have to give me more details than that, because qemu-syst

Re: [PATCH] hw/sd/sdhci: Do not modify BlockSizeRegister if transaction in progress

2021-02-08 Thread Mauro Matteo Cascella
On Mon, Feb 8, 2021 at 8:35 PM Philippe Mathieu-Daudé wrote: > > Per the "SD Host Controller Simplified Specification Version 2.00" > spec. 'Table 2-4 : Block Size Register': > > Transfer Block Size [...] can be accessed only if no > transaction is executing (i.e., after a transaction has stop

[PATCH v3 0/2] viritofsd: Add support for FUSE_HANDLE_KILLPRIV_V2

2021-02-08 Thread Vivek Goyal
Hi, This is V3 of the patches. V2 had been posted here. https://listman.redhat.com/archives/virtio-fs/2020-November/msg00084.html These patches add support for FUSE_HANDLE_KILLPRIV_V2. This is basically a feature file server can opt-in. And with xattr enabled, this improves write performance man

Re: Emulating sd card with hifive_u risc-v machine

2021-02-08 Thread Alistair Francis
On Mon, Feb 8, 2021 at 12:00 PM Pascal Scholz wrote: > > Hi all, > > I'm hoping that I addressed the right mailing lists. Hello Pascal, Yep, this is the right place :) > > I'm working a bit with qemu's risc-v emulation. My current goal is to > simulate a complete boot process for the SiFive Unl

Re: [PATCH v2 12/15] tcg/arm: Implement TCG_TARGET_HAS_bitsel_vec

2021-02-08 Thread Peter Maydell
On Mon, 8 Feb 2021 at 04:02, Richard Henderson wrote: > > NEON has 3 instructions implementing this 4 argument operation, > with each insn overlapping a different logical input onto the > destination register. > > Signed-off-by: Richard Henderson > @@ -2899,6 +2904,18 @@ static void tcg_out_vec_o

[PATCH v3 1/2] virtiofsd: Save error code early at the failure callsite

2021-02-08 Thread Vivek Goyal
Change error code handling slightly in lo_setattr(). Right now we seem to jump to out_err and assume that "errno" is valid and use that to send reply. But if caller has to do some other operations before jumping to out_err, then it does the dance of first saving errno to saverr and the restore err

Re: [PATCH v2 11/15] tcg/arm: Implement TCG_TARGET_HAS_minmax_vec

2021-02-08 Thread Peter Maydell
On Mon, 8 Feb 2021 at 03:41, Richard Henderson wrote: > > This is minimum and maximu, signed and unsigned. "maximum" Otherwise Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 12/15] tcg/arm: Implement TCG_TARGET_HAS_bitsel_vec

2021-02-08 Thread Richard Henderson
On 2/8/21 11:55 AM, Peter Maydell wrote: > On Mon, 8 Feb 2021 at 04:02, Richard Henderson > wrote: >> >> NEON has 3 instructions implementing this 4 argument operation, >> with each insn overlapping a different logical input onto the >> destination register. >> >> Signed-off-by: Richard Henderson

Re: [PATCH v2 09/15] tcg/arm: Implement TCG_TARGET_HAS_mul_vec

2021-02-08 Thread Peter Maydell
On Mon, 8 Feb 2021 at 03:35, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.h | 2 +- > tcg/arm/tcg-target.c.inc | 6 ++ > 2 files changed, 7 insertions(+), 1 deletion(-) > Reviewed-by: Peter Maydell thanks -- PMM

[PATCH v3 2/2] viriofsd: Add support for FUSE_HANDLE_KILLPRIV_V2

2021-02-08 Thread Vivek Goyal
This patch adds basic support for FUSE_HANDLE_KILLPRIV_V2. virtiofsd can enable/disable this by specifying option "-o killpriv_v2/no_killpriv_v2". By default this is enabled as long as client supports it Enabling this option helps with performance in write path. Without this option, currently ever

Re: [PATCH v2 02/15] tcg/arm: Add host vector framework

2021-02-08 Thread Richard Henderson
On 2/8/21 11:30 AM, Peter Maydell wrote: > On Mon, 8 Feb 2021 at 18:58, Richard Henderson > wrote: >> >> On 2/8/21 10:28 AM, Peter Maydell wrote: >>> On Mon, 8 Feb 2021 at 17:53, Peter Maydell wrote: The AAPCS says that q4-q7 are preserved across calls. >>> >>> Speaking of which, doesn't tha

Re: [PATCH v2 08/15] tcg/arm: Implement TCG_TARGET_HAS_shi_vec

2021-02-08 Thread Peter Maydell
On Mon, 8 Feb 2021 at 03:57, Richard Henderson wrote: > > This consists of the three immediate shifts: shli, shri, sari. > > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.h | 2 +- > tcg/arm/tcg-target.c.inc | 27 +++ > 2 files changed, 28 insertions(+)

[PATCH v2 8/9] acpi: add test case for -no-hpet

2021-02-08 Thread isaku . yamahata
From: Isaku Yamahata Signed-off-by: Isaku Yamahata --- tests/qtest/bios-tables-test.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 096d15db68..72c8765baf 100644 --- a/tests/qtest/bios-tables-test.c +++ b/

[PATCH v2 7/9] i386: acpi: Don't build HPET ACPI entry if HPET is disabled

2021-02-08 Thread isaku . yamahata
From: Sean Christopherson Omit HPET AML if the HPET is disabled, QEMU is not emulating it and the guest may get confused by seeing HPET in the ACPI tables without a "physical" device present. The change of DSDT when -no-hpet is as follows. @@ -141,47 +141,6 @@ DefinitionBlock ("", "DSDT", 1, "B

[PATCH v2 3/9] acpi/core: always set SCI_EN when SMM isn't supported

2021-02-08 Thread isaku . yamahata
From: Isaku Yamahata If SMM is not supported, ACPI fixed hardware doesn't support legacy-mode. ACPI-only platform. Where SCI_EN in PM1_CNT register is always set. The bit tells OS legacy mode(SCI_EN cleared) or ACPI mode(SCI_EN set). ACPI spec 4.8.10.1 PM1 Event Grouping PM1 Eanble Registers > F

[PATCH v2 1/9] checkpatch: don't emit warning on newly created acpi data files

2021-02-08 Thread isaku . yamahata
From: Isaku Yamahata Newly created acpi data files(tests/data/acpi/) cause false positive warning. If file names are acpi expected file, don't emit warning. Fixes: e625ba2a41 ("checkpatch: fix acpi check with multiple file name") Signed-off-by: Isaku Yamahata --- scripts/checkpatch.pl | 4 +++-

Re: [PULL v3 00/27] Block patches

2021-02-08 Thread Alex Bennée
Jag Raman writes: >> On Feb 8, 2021, at 5:02 AM, Philippe Mathieu-Daudé wrote: >> >> On 2/8/21 10:27 AM, Stefan Hajnoczi wrote: >>> On Sat, Feb 06, 2021 at 05:03:20PM +, Peter Maydell wrote: On Fri, 5 Feb 2021 at 22:53, Peter Maydell wrote: > > On Fri, 5 Feb 2021 at 1

Re: [PATCH 1/2] hw/block/nvme: use locally assigned QEMU IEEE OUI

2021-02-08 Thread Klaus Jensen
On Feb 8 19:56, Philippe Mathieu-Daudé wrote: > On 2/8/21 3:10 PM, Klaus Jensen wrote: > > From: Gollu Appalanaidu > > > > Commit 6eb7a071292a ("hw/block/nvme: change controller pci id") changed > > the controller to use a Red Hat assigned PCI Device and Vendor ID, but > > did not change the IEE

[PATCH v2 0/9] ACPI related fixes

2021-02-08 Thread isaku . yamahata
From: Isaku Yamahata Miscellaneous bug fixes related to ACPI to play nice with guest BIOSes/OSes by conforming to ACPI spec better. Changes from v1: - fixed style issue with fixes to checkpatch.pl - fixed make check breakage - added ACPI table tests - update comment message to include acpi table

[RFC PATCH v2 4/4] iotests: Test reopening multiple devices at the same time

2021-02-08 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- tests/qemu-iotests/245 | 40 ++ tests/qemu-iotests/245.out | 4 ++-- 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245 index 850c9f070b..d18dbbe638 100755 --- a

[PATCH v2 0/7] acpi: Error Record Serialization Table, ERST, support for QEMU

2021-02-08 Thread Eric DeVolder
This patchset introduces support for the ACPI Error Record Serialization Table, ERST. Linux uses the persistent storage filesystem, pstore, to record information (eg. dmesg tail) upon panics and shutdowns. Pstore is independent of, and runs before, kdump. In certain scenarios (ie. hosts/guests w

[RFC PATCH v2 3/4] block: Support multiple reopening with x-blockdev-reopen

2021-02-08 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- qapi/block-core.json | 2 +- include/block/block.h | 1 + block.c| 16 +-- blockdev.c | 85 +- tests/qemu-iotests/155 | 9 ++-- tests/qemu-iotests/165 | 4 +- tests

[PATCH v2 6/7] ACPI ERST: qtest for ERST

2021-02-08 Thread Eric DeVolder
This change provides a qtest that locates and then does a simple interrogation of the ERST feature within the guest. Signed-off-by: Eric DeVolder --- tests/qtest/erst-test.c | 106 tests/qtest/meson.build | 2 + 2 files changed, 108 insertions(+

[RFC PATCH v2 0/4] Allow changing bs->file on reopen

2021-02-08 Thread Alberto Garcia
Hi, this series allows changing bs->file using x-blockdev-reopen. Read here for more details: https://lists.gnu.org/archive/html/qemu-block/2021-01/msg00437.html Version 2 of the series introduces a very significant change: x-blockdev-reopen now receives a list of BlockdevOptions instead of j

  1   2   3   4   5   >