Re: [PATCH] virtio-net: Add check for mac address while peer is vdpa

2021-02-23 Thread Michael S. Tsirkin
> [PATCH] virtio-net: Add check for mac address while peer is vdpa please do keep numbering patch versions. On Wed, Feb 24, 2021 at 03:33:33PM +0800, Cindy Lu wrote: > Sometime vdpa get an all zero mac address from the hardware, this will cause > the > traffic down, So we add the check for in pa

Re: [PATCH 1/2] gitlab-ci.yml: Allow custom make parallelism

2021-02-23 Thread Paolo Bonzini
On 23/02/21 20:34, Daniele Buono wrote: This works, but setting this value to 1 for everybody seems a bit too restrictive. While the gitlab ci runners don't have enough memory for this, that's not necessarily true for every build platform, and linking multiple targets in parallel with LTO can res

Re: [PATCH] disas: Fix build with glib2.0 >=2.67.3

2021-02-23 Thread Christian Ehrhardt
On Tue, Feb 23, 2021 at 5:12 PM Daniel P. Berrangé wrote: > > On Tue, Feb 23, 2021 at 03:43:48PM +, Peter Maydell wrote: > > On Tue, 23 Feb 2021 at 15:03, Christian Ehrhardt > > wrote: > > > > > > glib2.0 introduced a change in 2.67.3 and later which triggers an > > > issue [1] for anyone inc

[PATCH] virtio-net: Add check for mac address while peer is vdpa

2021-02-23 Thread Cindy Lu
Sometime vdpa get an all zero mac address from the hardware, this will cause the traffic down, So we add the check for in part.if we get an zero mac address we will use the default/cmdline mac address instead Signed-off-by: Cindy Lu --- hw/net/virtio-net.c | 7 ++- 1 file changed, 6 inserti

Re: [PATCH 3/6] dp8393x: switch to use qemu_receive_packet() for loopback packet

2021-02-23 Thread Stefan Weil
Am 24.02.21 um 06:53 schrieb Jason Wang: This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. Signed-off-by: Jason Wang --- hw/net/dp8393x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c inde

Re: What prevents discarding a cluster during rewrite?

2021-02-23 Thread Vladimir Sementsov-Ogievskiy
23.02.2021 19:29, Kevin Wolf wrote: Am 23.02.2021 um 16:23 hat Vladimir Sementsov-Ogievskiy geschrieben: On 23.02.2021 13:35, Kevin Wolf wrote: Am 22.02.2021 um 22:42 hat Vladimir Sementsov-Ogievskiy geschrieben: 23.02.2021 00:30, Vladimir Sementsov-Ogievskiy wrote: Thinking of how to preve

Re: [PATCH 0/6] Detect reentrant RX casue by loopback

2021-02-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210224055401.492407-1-jasow...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210224055401.492407-1-jasow...@redhat.com Subject: [PATCH 0/6] Detect reentrant RX cas

[PATCH 5/6] sungem: switch to use qemu_receive_packet() for loopback

2021-02-23 Thread Jason Wang
This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. Signed-off-by: Jason Wang --- hw/net/sungem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/sungem.c b/hw/net/sungem.c index 33c3722df6..3684a4d733 100644 --- a/hw/net/sung

[PATCH 4/6] msf2-mac: switch to use qemu_receive_packet() for loopback

2021-02-23 Thread Jason Wang
This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. Signed-off-by: Jason Wang --- hw/net/msf2-emac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/msf2-emac.c b/hw/net/msf2-emac.c index 32ba9e8412..3e6206044f 100644 --- a/hw

[PATCH 1/6] net: introduce qemu_receive_packet()

2021-02-23 Thread Jason Wang
Some NIC supports loopback mode and this is done by calling nc->info->receive() directly which in fact suppresses the effort of reentrancy check that is done in qemu_net_queue_send(). Unfortunately we can use qemu_net_queue_send() here since for loop back there's no sender as peer, so this patch i

[PATCH 6/6] tx_pkt: switch to use qemu_receive_packet_iov() for loopback

2021-02-23 Thread Jason Wang
This patch switches to use qemu_receive_receive_iov() which can detect reentrancy and return early. Signed-off-by: Jason Wang --- hw/net/net_tx_pkt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/net_tx_pkt.c b/hw/net/net_tx_pkt.c index da262edc3e..1f9aa59eca 100644

[PATCH 3/6] dp8393x: switch to use qemu_receive_packet() for loopback packet

2021-02-23 Thread Jason Wang
This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. Signed-off-by: Jason Wang --- hw/net/dp8393x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 205c0decc5..019d4fe435 100644 --- a/hw/net/d

[PATCH 2/6] e1000: switch to use qemu_receive_packet() for loopback

2021-02-23 Thread Jason Wang
This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. Signed-off-by: Jason Wang --- hw/net/e1000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index 4345d863e6..4f75b44cfc 100644 --- a/hw/net/e1000.c

[PATCH 0/6] Detect reentrant RX casue by loopback

2021-02-23 Thread Jason Wang
Hi All: Followed by commit 22dc8663d9 ("net: forbid the reentrant RX"), we still need to fix the issues casued by loopback mode where the NIC usually it via calling nc->info->receive() directly. The fix is to introduce new network helper and check the queue->delivering. Thanks Jason Wang (6):

[Bug 1914535] Re: PL110 8-bit mode is not emulated correctly

2021-02-23 Thread Vadim Averin
Well... I don't have any ARM Versatile Express board. Also, documentation and manuals are not saying much about it -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914535 Title: PL110 8-bit mode is n

Re: [PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-02-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210224054130.4540-1-...@ozlabs.ru/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210224054130.4540-1-...@ozlabs.ru Subject: [PATCH qemu v14] spapr: Implement Open Firmware clie

[PATCH] e1000: fail early for evil descriptor

2021-02-23 Thread Jason Wang
During procss_tx_desc(), driver can try to chain data descriptor with legacy descriptor, when will lead underflow for the following calculation in process_tx_desc() for bytes: if (tp->size + bytes > msh) bytes = msh - tp->size; This will lead a infinite loop. So check

[PATCH qemu v14] spapr: Implement Open Firmware client interface

2021-02-23 Thread Alexey Kardashevskiy
The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of the firmware (RTAS) has been implemented as a 2

[REBASE] [PATCH v5] qga: Correct loop count in qmp_guest_get_vcpus()

2021-02-23 Thread Lin Ma
The guest-get-vcpus returns incorrect vcpu info in case we hotunplug vcpus(not the last one). e.g.: A VM has 4 VCPUs: cpu0 + 3 hotunpluggable online vcpus(cpu1, cpu2 and cpu3). Hotunplug cpu2, Now only cpu0, cpu1 and cpu3 are present & online. ./qmp-shell /tmp/qmp-monitor.sock (QEMU) query-hotplu

Re: [PATCH v2 0/6] testing/next (meson check-tcg, fedora bump, docs)

2021-02-23 Thread Richard Henderson
On 2/22/21 2:14 AM, Alex Bennée wrote: > Alex Bennée (5): > meson.build: expose TCG cross compiler information in summary > tests/acceptance: allow a "graceful" failing for virtio-gpu test > docs/devel: expand on use of containers to build tests > docs/devel: update the container based test

Re: [PATCH v3 10/10] target/mips: Extract MXU code to new mxu_translate.c file

2021-02-23 Thread Richard Henderson
On 2/22/21 2:39 PM, Philippe Mathieu-Daudé wrote: > Extract 1600+ lines from the big translate.c into a new file. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/mxu_translate.c | 1625 +++ > target/mips/translate.c | 1613 ---

Re: [PATCH v3 09/10] target/mips: Simplify 64-bit ifdef'ry of MXU code

2021-02-23 Thread Richard Henderson
On 2/22/21 2:39 PM, Philippe Mathieu-Daudé wrote: > +#else /* !defined(TARGET_MIPS64) */ > + > +bool decode_ase_mxu(DisasContext *ctx, uint32_t insn) > +{ > +return false; Also seems suspect, but harmless. > -#if !defined(TARGET_MIPS64) > -if (ctx->insn_flags & ASE_MXU) { > +i

Re: [PATCH v3 08/10] target/mips: Make mxu_translate_init() / decode_ase_mxu() proto public

2021-02-23 Thread Richard Henderson
On 2/22/21 2:38 PM, Philippe Mathieu-Daudé wrote: > +#else /* !defined(TARGET_MIPS64) */ > +void mxu_translate_init(void) > +{ > +g_assert_not_reached(); > +} This is suspect, see next patch. The rest of it seems ok. r~

Re: [PATCH v3 07/10] target/mips: Introduce mxu_translate_init() helper

2021-02-23 Thread Richard Henderson
On 2/22/21 2:38 PM, Philippe Mathieu-Daudé wrote: > Extract the MXU register initialization code from mips_tcg_init() > as a new mxu_translate_init() helper > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 26 +++--- > 1 file changed, 15 insertions(

Re: [PATCH v3 06/10] target/mips: Use OPC_MUL instead of OPC__MXU_MUL

2021-02-23 Thread Richard Henderson
On 2/22/21 2:38 PM, Philippe Mathieu-Daudé wrote: > We already have a macro and definition to extract / check > the Special2 MUL opcode. Use it instead of the unnecessary > OPC__MXU_MUL macro. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 3 +-- > 1 file changed, 1

Re: [PATCH v3 05/10] target/mips: Extract decode_ase_mxu() from decode_opc_mxu()

2021-02-23 Thread Richard Henderson
On 2/22/21 2:38 PM, Philippe Mathieu-Daudé wrote: > To easily convert MXU code to decodetree, extract decode_ase_mxu() > from decode_opc_mxu(), making it return a boolean. > We will keep decode_opc_mxu() in the translate.c unit because it > calls gen_arith(). > > Signed-off-by: Philippe Mathieu-Da

Re: [PATCH v3 04/10] target/mips: Pass instruction opcode to decode_opc_mxu()

2021-02-23 Thread Richard Henderson
On 2/22/21 2:38 PM, Philippe Mathieu-Daudé wrote: > In the next commit we'll make decode_opc_mxu() match decodetree > prototype by returning a boolean. First pass ctx->opcode as an > argument. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 14 +++--- > 1 file

Re: [PATCH v3 03/10] target/mips: Remove unused CPUMIPSState* from MXU functions

2021-02-23 Thread Richard Henderson
On 2/22/21 2:38 PM, Philippe Mathieu-Daudé wrote: > None of these MXU functions use their CPUMIPSState* env argument, > remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) Reviewed-by

Re: [PATCH v3 01/10] target/mips: Rewrite complex ifdef'ry

2021-02-23 Thread Richard Henderson
On 2/22/21 2:38 PM, Philippe Mathieu-Daudé wrote: > No need for this obfuscated ifdef'ry, KISS. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/translate.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2] target/riscv: fix TB_FLAGS bits overlapping bug for rvv/rvh

2021-02-23 Thread Frank Chang
On Wed, Feb 24, 2021 at 2:24 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 2/23/21 12:19 AM, frank.ch...@sifive.com wrote: > > From: Frank Chang > > > > TB_FLAGS mem_idx bits was extended from 2 bits to 3 bits in > > commit: c445593, but other TB_FLAGS bits for rvv and rvh were

Re: [PATCH v2 2/2] target/riscv: Call check_access() before tcg_temp_new()

2021-02-23 Thread Richard Henderson
On 2/22/21 10:49 AM, Alex Richardson wrote: > --- > target/riscv/insn_trans/trans_rvh.c.inc | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Any particular reason? At first I thought this was a macro with a hidden return, but it isn't. I would understand a cleanup like

Re: who's using the ozlabs patchwork install for QEMU patches ?

2021-02-23 Thread Jeremy Kerr
Hi Alexey, > Jeremy or Stephen (cc-ing) do definitely know if there is a better > way. The standard process is to send me an email :) You're wanting to add user 'groug' to the qemu project, is that correct? Cheers, Jeremy

Re: [PATCH v2 1/2] target/riscv: Reduce duplicated code in trans_rvh.c.inc

2021-02-23 Thread Richard Henderson
On 2/22/21 10:49 AM, Alex Richardson wrote: > I rencently merged CHERI QEMU up to 5.2, and we have to modify all > functions that perform memory accesses. Factoring these almost-indentical > functions into two shared helpers makes our changes a lot smaller and > should also make this code easier to

Re: softmmu vs sysemu [Was: Re: [RFC v1 06/38] target/arm: split off cpu-softmmu.c]

2021-02-23 Thread Richard Henderson
On 2/23/21 3:43 PM, Philippe Mathieu-Daudé wrote: > On 2/23/21 7:51 PM, Richard Henderson wrote: >> I just want the file naming done correctly, while you're renaming. That is >> something you are actively changing in this patch set, so we should get it >> right. > > So what is the new directory

Re: softmmu vs sysemu [Was: Re: [RFC v1 06/38] target/arm: split off cpu-softmmu.c]

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/23/21 7:51 PM, Richard Henderson wrote: > On 2/23/21 10:18 AM, Claudio Fontana wrote: >> I am all for "just getting it done", but here the i386 and the arm series >> become a mixture of things that I am not comfortable with, >> I'd prefer a dedicated series.. > > You're thinking too deeply a

Re: [PATCH v4] net/macos: implement vmnet-based netdev

2021-02-23 Thread Roman Bolshakov
On Thu, Feb 18, 2021 at 02:49:47PM +0100, phillip.en...@gmail.com wrote: > From: Phillip Tennen > > This patch implements a new netdev device, reachable via -netdev > vmnet-macos, that’s backed by macOS’s vmnet framework. > > The vmnet framework provides native bridging support, and its usage in

[PATCH v2 2/2] hw/net/allwinner-sun8i-emac: traverse transmit queue using TX_CUR_DESC register value

2021-02-23 Thread Niek Linnenbank
Currently the emulated EMAC for sun8i always traverses the transmit queue from the head when transferring packets. It searches for a list of consecutive descriptors whichs are flagged as ready for processing and transmits their payloads accordingly. The controller stops processing once it finds a

[PATCH v2 0/2] Allwinner H3 fixes for EMAC and acceptance tests

2021-02-23 Thread Niek Linnenbank
The following are maintenance patches for the Allwinner H3. The first patch is a proposal to relocate the binary artifacts of the acceptance tests away from the apt.armbian.com domain. In the past we had problems with artifacts being removed, and now the recently added Armbian 20.08.1 image has be

[PATCH v3 0/2] virtiofsd: Enable posix_acl by default

2021-02-23 Thread Vivek Goyal
Hi, This is V3 of the patches. Changes since v2 are. - I dropped the patch to give user an option to enable/disable acls. Now acls are enabled by default if xattrs are enabled and fuse client offers FUSE_POSIX_ACL capability. Miklos mentioned that ACLS might not have lot of overhead as thes

[PATCH v2 1/2] tests/acceptance: replace unstable apt.armbian.com URLs for orangepi-pc, cubieboard

2021-02-23 Thread Niek Linnenbank
Currently the automated acceptance tests for the Orange Pi PC and cubieboard machines are disabled by default. The tests for both machines require artifacts that are stored on the apt.armbian.com domain. Unfortunately, some of these artifacts have been removed from apt.armbian.com and it is uncert

[PATCH v3 2/2] virtiofsd: Enable posix_acls by default if xattrs are enabled

2021-02-23 Thread Vivek Goyal
Fuse protocl wants file server to opt in for FUSE_POSIX_ACL if posix acls are to be enabled. Right now virtiofsd does not enable it. This patch opts in for FUSE_POSIX_ACL if xattr support is enabled. When parent directory has default acl and a file is created in that directory, then umask is ignor

[PATCH v3 1/2] virtiofsd: Add umask to seccom allow list

2021-02-23 Thread Vivek Goyal
Patches in this series are going to make use of "umask" syscall. So allow it. Signed-off-by: Vivek Goyal --- tools/virtiofsd/passthrough_seccomp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrough_seccomp.c index 62441cfcdb.

Re: [PULL 38/46] cpu: move cc->transaction_failed to tcg_ops

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/5/21 11:56 PM, Richard Henderson wrote: > From: Claudio Fontana > > Signed-off-by: Claudio Fontana > Reviewed-by: Alex Bennée > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Richard Henderson > > [claudio: wrap target code around CONFIG_TCG and !CONFIG_USER_ONLY] > > avoiding its

Re: [PATCH v5 1/4] Jobs based on custom runners: documentation and configuration placeholder

2021-02-23 Thread Wainer dos Santos Moschetta
Hi, On 2/23/21 2:45 PM, Daniel P. Berrangé wrote: On Tue, Feb 23, 2021 at 11:47:18AM -0500, Cleber Rosa wrote: On Tue, Feb 23, 2021 at 05:37:04PM +0100, Philippe Mathieu-Daudé wrote: On 2/23/21 12:25 PM, Thomas Huth wrote: On 19/02/2021 22.58, Cleber Rosa wrote: As described in the included

Re: [PATCH v2 00/42] esp: consolidate PDMA transfer buffers and other fixes

2021-02-23 Thread Philippe Mathieu-Daudé
Hi Mark, On 2/9/21 8:29 PM, Mark Cave-Ayland wrote: > This patch series comes from an experimental branch that I've been working on > to try and boot a MacOS toolbox ROM under the QEMU q800 machine. The effort is > far from complete, but it seems worth submitting these patches separately > since

Re: [PATCH v2 23/42] esp: use ti_wptr/ti_rptr to manage the current FIFO position for PDMA

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/9/21 8:29 PM, Mark Cave-Ayland wrote: > This eliminates the last user of the PDMA-specific pdma_cur variable which can > now be removed. > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 23 --- > include/hw/scsi/esp.h | 1 - > 2 files changed, 8 inser

Re: [PATCH v2 18/42] esp: accumulate SCSI commands for PDMA transfers in cmdbuf instead of pdma_buf

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/9/21 8:29 PM, Mark Cave-Ayland wrote: > ESP SCSI commands are already accumulated in cmdbuf and so there is no need to > keep a separate pdma_buf buffer. Accumulate SCSI commands for PDMA transfers > in > cmdbuf instead of pdma_buf so update cmdlen accordingly and change pdma_origin > for PDM

Re: [PATCH v2 17/42] esp: move pdma_len and TC logic into esp_pdma_read()/esp_pdma_write()

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/9/21 8:29 PM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 50 -- > 1 file changed, 32 insertions(+), 18 deletions(-) > > diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c > index cfeba2feb0..7134c0aff4 100644 > -

Re: [PATCH v2 13/42] esp: remove dma_left from ESPState

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/9/21 8:29 PM, Mark Cave-Ayland wrote: > The ESP device already keeps track of the remaining bytes left to transfer via > its TC (transfer counter) register which is decremented for each byte that > is transferred across the SCSI bus. > > Switch the transfer logic to use the value of TC instea

[PATCH v2] tests/docker: Use --arch-only when building Debian cross image

2021-02-23 Thread Philippe Mathieu-Daudé
When building a Docker image based on debian10.docker on a non-x86 host, we get: [2/4] RUN apt update && DEBIAN_FRONTEND=noninteractive eatmydata apt build-dep -yy qemu Reading package lists... Done Building dependency tree Reading state information... Done Some packages could not be

Re: Plugin Address Translations Inconsistent/Incorrect?

2021-02-23 Thread Aaron Lindsay via
On Feb 22 15:48, Aaron Lindsay wrote: > On Feb 22 19:30, Alex Bennée wrote: > > Aaron Lindsay writes: > > That said I think we could add an additional helper to translate a > > hwaddr to a global address space address. I'm open to suggestions of the > > best way to structure this. > > Haven't put

[Bug 1916655] [NEW] Compilation fails due to zstd qcow2 compression

2021-02-23 Thread Dantali0n
Public bug reported: Compilation of QEMU fails when using recent versions of zstd. I use the following commands to compile QEMU: $ mkdir build $ cd build $ ../configure --enable-debug --target-list=x86_64-softmmu $ make -j $(nproc) Here is a paste from the ../configure output: https://paste.ubun

RE: [PATCH] target/hexagon/opcodes: Add missing varargs cleanup

2021-02-23 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Tuesday, February 23, 2021 5:13 AM > To: qemu-devel@nongnu.org > Cc: Richard Henderson ; Taylor Simpson > ; Philippe Mathieu-Daudé > Subject: [PATCH] target/hexagon/opcodes: Add missing var

Re: [PATCH v5 1/5] slirp: Advance libslirp submodule to add ipv6 host-forward support

2021-02-23 Thread Doug Evans
On Fri, Feb 19, 2021 at 4:20 PM Philippe Mathieu-Daudé wrote: > Hi Doug, > > On 2/20/21 1:13 AM, Doug Evans via wrote: > > When updating submodules, the commit description is a good > good place to include the output of: > > $ git shortlog 8f43a99..26ae658 > > See for example QEMU commit f350d7

Re: [PATCH v5 2/4] Jobs based on custom runners: build environment docs and playbook

2021-02-23 Thread Cleber Rosa
On Tue, Feb 23, 2021 at 06:23:25PM +, Alex Bennée wrote: > > Cleber Rosa writes: > > > On Tue, Feb 23, 2021 at 03:01:50PM +, Alex Bennée wrote: > >> > >> Alex Bennée writes: > >> > >> > Cleber Rosa writes: > >> > > >> >> To run basic jobs on custom runners, the environment needs to b

Re: [PATCH 1/2] gitlab-ci.yml: Allow custom make parallelism

2021-02-23 Thread Daniele Buono
This works, but setting this value to 1 for everybody seems a bit too restrictive. While the gitlab ci runners don't have enough memory for this, that's not necessarily true for every build platform, and linking multiple targets in parallel with LTO can result in a big save in time, so I'd prefer

Re: [PATCH] tests/docker: Use --arch-only when building Debian cross images

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/23/21 7:28 PM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: > >> When building a Docker image based on debian10.docker on >> a non-x86 host, we get: >> >> [2/4] RUN apt update && DEBIAN_FRONTEND=noninteractive eatmydata >> apt build-dep -yy qemu >> Reading package lists...

Re: [PATCH v2 30/42] esp: add 4 byte PDMA read and write transfers

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/23/21 9:24 AM, Mark Cave-Ayland wrote: > On 16/02/2021 07:30, Philippe Mathieu-Daudé wrote: > >>> Are you planning to review any more of this series? I'm keen to put out >>> a (hopefully final) v3 soon, but I'll hold off for little while if you >>> want more time to look over the remaining pa

Re: softmmu vs sysemu [Was: Re: [RFC v1 06/38] target/arm: split off cpu-softmmu.c]

2021-02-23 Thread Richard Henderson
On 2/23/21 10:18 AM, Claudio Fontana wrote: > I am all for "just getting it done", but here the i386 and the arm series > become a mixture of things that I am not comfortable with, > I'd prefer a dedicated series.. You're thinking too deeply about the problem that I'm reporting to you about this

Re: [PATCH v2 40/42] esp: add trivial implementation of the ESP_RFLAGS register

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/9/21 8:30 PM, Mark Cave-Ayland wrote: > The bottom 5 bits contain the number of bytes remaining in the FIFO which is > trivial to implement with Fifo8 (the remaining bits are unimplemented and left > as 0 for now). > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 4 > 1 file

Re: [PATCH v2 38/42] esp: convert ti_buf from array to Fifo8

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/9/21 8:30 PM, Mark Cave-Ayland wrote: > Rename TI_BUFSZ to ESP_FIFO_SZ since this constant is really describing the > size > of the FIFO and is not directly related to the TI size. > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 117 ++---

Re: [PATCH] target/hexagon/opcodes: Add missing varargs cleanup

2021-02-23 Thread Richard Henderson
On 2/23/21 3:12 AM, Philippe Mathieu-Daudé wrote: > Fix a trivial incorrect usage of variable argument macros detected > by Coverity (missing_va_end: va_end was not called for ap). > > Fixes: Coverity CID 1446720 (VARARGS) > Fixes: e3c00c2ed75 ("Hexagon (target/hexagon) opcode data structures") >

Re: [PATCH] target/riscv: fix vs() to return proper error code

2021-02-23 Thread Richard Henderson
On 2/22/21 10:59 PM, frank.ch...@sifive.com wrote: > From: Frank Chang > > vs() should return -RISCV_EXCP_ILLEGAL_INST instead of -1 if rvv feature > is not enabled. > > If -1 is returned, exception will be raised and cs->exception_index will > be set to the negative return value. The exception

Re: [PATCH v2 36/42] esp: add maxlen parameter to get_cmd()

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/9/21 8:30 PM, Mark Cave-Ayland wrote: > Some guests use a mixture of DMA and non-DMA transfers in combination with the > SATN and stop command to transfer message out phase and command phase bytes to > the target. Prepare for the next commit by adding a maxlen parameter to > get_cmd() to allow

Re: [PATCH v2 25/42] esp: remove CMD pdma_origin

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/9/21 8:30 PM, Mark Cave-Ayland wrote: > The cmdbuf is really just a copy of FIFO data (including extra message phase > bytes) so its pdma_origin is effectively TI. Fortunately we already know when > we are receiving a SCSI command since do_cmd == 1 which enables us to > distinguish between the

Re: [PATCH v2 24/42] esp: use in-built TC to determine PDMA transfer length

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/9/21 8:30 PM, Mark Cave-Ayland wrote: > Real hardware simply counts down using the in-built TC to determine when the > the PDMA request is complete. Use the TC to determine the PDMA transfer length > which then enables us to remove the redundant pdma_len variable. > > Signed-off-by: Mark Cave

Re: [PATCH v2] i386: Add the support for AMD EPYC 3rd generation processors

2021-02-23 Thread Babu Moger
Hi Pankaj, On 2/23/21 10:32 AM, Pankaj Gupta wrote: > Hello Babu, > > Have below doubt about exposed CPU flags between EPYC-Rome & EPYC-Milan > family. > Please see below. > >> Adds the support for AMD 3rd generation processors. The model >> display for the new processor will be EPYC-Milan. >>

Re: [PATCH] tests/docker: Use --arch-only when building Debian cross images

2021-02-23 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > When building a Docker image based on debian10.docker on > a non-x86 host, we get: > > [2/4] RUN apt update && DEBIAN_FRONTEND=noninteractive eatmydata apt > build-dep -yy qemu > Reading package lists... Done > Building dependency tree > Reading sta

Re: [PATCH v5 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-02-23 Thread Cleber Rosa
On Tue, Feb 23, 2021 at 03:56:19PM +, Daniel P. Berrangé wrote: > > Urgh, well that's a big problem. We certainly don't want *anything* being > placed on the custom runners without explicit opt-in, otherwise jobs run > in the main repo have a different environment from when users run on their

Re: [PATCH v2 19/42] esp: remove buf parameter from do_cmd()

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/9/21 8:29 PM, Mark Cave-Ayland wrote: > Now that all SCSI commands are accumulated in cmdbuf, remove the buf parameter > from do_cmd() since this always points to cmdbuf. > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 delet

Re: [PATCH v2] target/riscv: fix TB_FLAGS bits overlapping bug for rvv/rvh

2021-02-23 Thread Richard Henderson
On 2/23/21 12:19 AM, frank.ch...@sifive.com wrote: > From: Frank Chang > > TB_FLAGS mem_idx bits was extended from 2 bits to 3 bits in > commit: c445593, but other TB_FLAGS bits for rvv and rvh were > not shift as well so these bits may overlap with each other when > rvv is enabled. > > Signed-o

Re: [PATCH v2 16/42] esp: use pdma_origin directly in esp_pdma_read()/esp_pdma_write()

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/9/21 8:29 PM, Mark Cave-Ayland wrote: > This is the first step in removing get_pdma_buf() from esp.c. > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 34 -- > 1 file changed, 28 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 14/42] esp: remove minlen restriction in handle_ti

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/9/21 8:29 PM, Mark Cave-Ayland wrote: > The limiting of DMA transfers to the maximum size of the available data is > already > handled by esp_do_dma() and do_dma_pdma_cb(). > > Signed-off-by: Mark Cave-Ayland > --- > hw/scsi/esp.c | 12 ++-- > 1 file changed, 2 insertions(+), 10 de

Re: [PATCH v5 2/4] Jobs based on custom runners: build environment docs and playbook

2021-02-23 Thread Alex Bennée
Cleber Rosa writes: > On Tue, Feb 23, 2021 at 03:01:50PM +, Alex Bennée wrote: >> >> Alex Bennée writes: >> >> > Cleber Rosa writes: >> > >> >> To run basic jobs on custom runners, the environment needs to be >> >> properly set up. The most common requirement is having the right >> >>

Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse

2021-02-23 Thread Doug Evans
On Mon, Feb 22, 2021 at 1:39 AM Daniel P. Berrangé wrote: > On Fri, Feb 19, 2021 at 02:17:42PM -0800, Doug Evans wrote: > > On Fri, Feb 19, 2021 at 2:00 AM Daniel P. Berrangé > > wrote: > > > > > On Thu, Feb 18, 2021 at 12:15:36PM -0800, Doug Evans wrote: > > > > The parsing is moved into new fu

Re: [PATCH v5 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

2021-02-23 Thread Cleber Rosa
On Tue, Feb 23, 2021 at 04:17:23PM +0100, Philippe Mathieu-Daudé wrote: > On 2/19/21 10:58 PM, Cleber Rosa wrote: > > The QEMU project has two machines (aarch64 and s390x) that can be used > > for jobs that do build and run tests. This introduces those jobs, > > which are a mapping of custom scrip

Re: [PATCH v5 2/4] Jobs based on custom runners: build environment docs and playbook

2021-02-23 Thread Alex Bennée
Cleber Rosa writes: > On Tue, Feb 23, 2021 at 03:17:24PM +, Alex Bennée wrote: >> >> Erik Skultety writes: >> >> > On Tue, Feb 23, 2021 at 02:01:53PM +, Alex Bennée wrote: >> >> >> >> Cleber Rosa writes: >> >> >> >> > To run basic jobs on custom runners, the environment needs to b

softmmu vs sysemu [Was: Re: [RFC v1 06/38] target/arm: split off cpu-softmmu.c]

2021-02-23 Thread Claudio Fontana
On 2/23/21 10:35 AM, Claudio Fontana wrote: > On 2/23/21 10:16 AM, Philippe Mathieu-Daudé wrote: >> On 2/23/21 9:55 AM, Claudio Fontana wrote: >>> On 2/22/21 6:29 PM, Alex Bennée wrote: Claudio Fontana writes: > From: Claudio Fontana > > Signed-off-by: Claudio Fontana

Re: [PATCH v5 2/4] Jobs based on custom runners: build environment docs and playbook

2021-02-23 Thread Alex Bennée
Cleber Rosa writes: > On Tue, Feb 23, 2021 at 02:01:53PM +, Alex Bennée wrote: >> >> Cleber Rosa writes: >> >> > To run basic jobs on custom runners, the environment needs to be >> > properly set up. The most common requirement is having the right >> > packages installed. >> > >> > The

Re: [PATCH v5 1/4] Jobs based on custom runners: documentation and configuration placeholder

2021-02-23 Thread Cleber Rosa
On Tue, Feb 23, 2021 at 06:34:07PM +0100, Philippe Mathieu-Daudé wrote: > On 2/23/21 6:24 PM, Philippe Mathieu-Daudé wrote: > > On 2/23/21 5:47 PM, Cleber Rosa wrote: > >> On Tue, Feb 23, 2021 at 05:37:04PM +0100, Philippe Mathieu-Daudé wrote: > >>> On 2/23/21 12:25 PM, Thomas Huth wrote: > On

Re: [PATCH 2/3] scripts/ci/gitlab-pipeline-status: give more information on failures

2021-02-23 Thread Alex Bennée
Cleber Rosa writes: > When an HTTP GET request fails, it's useful to go beyond the "not > successful" message, and show the code returned by the server. > > Signed-off-by: Cleber Rosa Reviewed-by: Alex Bennée > --- > scripts/ci/gitlab-pipeline-status | 4 +++- > 1 file changed, 3 insertion

Re: [PATCH 1/3] scripts/ci/gitlab-pipeline-status: split utlity function for HTTP GET

2021-02-23 Thread Alex Bennée
Cleber Rosa writes: > This simply splits out the code that does an HTTP GET so that it > can be used for other API requests. > > Signed-off-by: Cleber Rosa fix sp as per Wainer, otherwise: Reviewed-by: Alex Bennée > --- > scripts/ci/gitlab-pipeline-status | 17 - > 1 file

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-23 Thread Vitaly Kuznetsov
Igor Mammedov writes: > On Tue, 23 Feb 2021 16:46:50 +0100 > Vitaly Kuznetsov wrote: > >> Igor Mammedov writes: >> >> > On Mon, 22 Feb 2021 11:20:34 +0100 >> > Vitaly Kuznetsov wrote: >> > >> >> Vitaly Kuznetsov writes: >> >> >> >> > Igor Mammedov writes: >> >> > >> >> >>> >> >> >

[Bug 1916394] Re: [git] Cannot build qemu: FAILED: target/hexagon/semantics_generated.pyinc

2021-02-23 Thread briancain
** Changed in: qemu Assignee: (unassigned) => briancain (brian-cain) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1916394 Title: [git] Cannot build qemu: FAILED: target/hexagon/semantics_ge

Re: [PATCH v4 16/21] i386: track explicit 'hv-*' features enablement/disablement

2021-02-23 Thread Igor Mammedov
On Tue, 23 Feb 2021 16:46:50 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Mon, 22 Feb 2021 11:20:34 +0100 > > Vitaly Kuznetsov wrote: > > > >> Vitaly Kuznetsov writes: > >> > >> > Igor Mammedov writes: > >> > > >> >>> > >> >>> We need to distinguish because that w

Re: [PATCH v5 1/4] Jobs based on custom runners: documentation and configuration placeholder

2021-02-23 Thread Daniel P . Berrangé
On Tue, Feb 23, 2021 at 11:47:18AM -0500, Cleber Rosa wrote: > On Tue, Feb 23, 2021 at 05:37:04PM +0100, Philippe Mathieu-Daudé wrote: > > On 2/23/21 12:25 PM, Thomas Huth wrote: > > > On 19/02/2021 22.58, Cleber Rosa wrote: > > >> As described in the included documentation, the "custom runner" job

Re: [PATCH v5 2/4] Jobs based on custom runners: build environment docs and playbook

2021-02-23 Thread Cleber Rosa
On Tue, Feb 23, 2021 at 03:01:50PM +, Alex Bennée wrote: > > Alex Bennée writes: > > > Cleber Rosa writes: > > > >> To run basic jobs on custom runners, the environment needs to be > >> properly set up. The most common requirement is having the right > >> packages installed. > >> > > > >

RE: [PATCH v2 01/22] block: add eMMC block device type

2021-02-23 Thread Sai Pavan Boddu
Hi Philippe, > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Monday, February 22, 2021 5:34 PM > To: Sai Pavan Boddu ; Markus Armbruster > ; Kevin Wolf ; Max Reitz > ; Vladimir Sementsov-Ogievskiy > ; Eric Blake ; Joel Stanley > ; Cédric Le Goater ; Vincent Palatin > ; Dr. Dav

Re: [PATCH v5 1/4] Jobs based on custom runners: documentation and configuration placeholder

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/23/21 6:24 PM, Philippe Mathieu-Daudé wrote: > On 2/23/21 5:47 PM, Cleber Rosa wrote: >> On Tue, Feb 23, 2021 at 05:37:04PM +0100, Philippe Mathieu-Daudé wrote: >>> On 2/23/21 12:25 PM, Thomas Huth wrote: On 19/02/2021 22.58, Cleber Rosa wrote: > As described in the included documenta

Re: [PATCH v5 2/4] Jobs based on custom runners: build environment docs and playbook

2021-02-23 Thread Cleber Rosa
On Tue, Feb 23, 2021 at 03:17:24PM +, Alex Bennée wrote: > > Erik Skultety writes: > > > On Tue, Feb 23, 2021 at 02:01:53PM +, Alex Bennée wrote: > >> > >> Cleber Rosa writes: > >> > >> > To run basic jobs on custom runners, the environment needs to be > >> > properly set up. The mos

Re: [PATCH v5 1/4] Jobs based on custom runners: documentation and configuration placeholder

2021-02-23 Thread Philippe Mathieu-Daudé
On 2/23/21 5:47 PM, Cleber Rosa wrote: > On Tue, Feb 23, 2021 at 05:37:04PM +0100, Philippe Mathieu-Daudé wrote: >> On 2/23/21 12:25 PM, Thomas Huth wrote: >>> On 19/02/2021 22.58, Cleber Rosa wrote: As described in the included documentation, the "custom runner" jobs extend the GitLab CI

Re: [PATCH v2 0/2] block: Use 'read-zeroes=true' mode by default with 'null-co' driver

2021-02-23 Thread Fam Zheng
On 2021-02-23 17:01, Max Reitz wrote: > On 23.02.21 10:21, Fam Zheng wrote: > > On 2021-02-22 18:55, Philippe Mathieu-Daudé wrote: > > > On 2/22/21 6:35 PM, Fam Zheng wrote: > > > > On 2021-02-19 15:09, Philippe Mathieu-Daudé wrote: > > > > > On 2/19/21 12:07 PM, Max Reitz wrote: > > > > > > On 13.

Re: [PATCH v2 4/4] utils: Deprecate inexact fractional suffix sizes

2021-02-23 Thread Daniel P . Berrangé
On Thu, Feb 11, 2021 at 02:44:38PM -0600, Eric Blake wrote: > The value '1.1k' is inexact; 1126.4 bytes is not possible, so we > happen to truncate it to 1126. Our use of fractional sizes is > intended for convenience, but when a user specifies a fraction that is > not a clean translation to binar

Re: [PATCH v2 3/4] utils: Deprecate hex-with-suffix sizes

2021-02-23 Thread Daniel P . Berrangé
On Thu, Feb 11, 2021 at 02:44:37PM -0600, Eric Blake wrote: > Supporting '0x20M' looks odd, particularly since we have a 'B' suffix > that is ambiguous for bytes, as well as a less-frequently-used 'E' > suffix for extremely large exibytes. In practice, people using hex > inputs are specifying valu

Re: [PATCH v5 2/4] Jobs based on custom runners: build environment docs and playbook

2021-02-23 Thread Cleber Rosa
On Tue, Feb 23, 2021 at 02:01:53PM +, Alex Bennée wrote: > > Cleber Rosa writes: > > > To run basic jobs on custom runners, the environment needs to be > > properly set up. The most common requirement is having the right > > packages installed. > > > > The playbook introduced here covers th

Re: [PATCH v5 2/4] Jobs based on custom runners: build environment docs and playbook

2021-02-23 Thread Cleber Rosa
On Tue, Feb 23, 2021 at 03:51:33PM +0100, Erik Skultety wrote: > On Tue, Feb 23, 2021 at 02:01:53PM +, Alex Bennée wrote: > > > > Cleber Rosa writes: > > > > > To run basic jobs on custom runners, the environment needs to be > > > properly set up. The most common requirement is having the r

Re: [PATCH v5 1/4] Jobs based on custom runners: documentation and configuration placeholder

2021-02-23 Thread Cleber Rosa
On Tue, Feb 23, 2021 at 05:37:04PM +0100, Philippe Mathieu-Daudé wrote: > On 2/23/21 12:25 PM, Thomas Huth wrote: > > On 19/02/2021 22.58, Cleber Rosa wrote: > >> As described in the included documentation, the "custom runner" jobs > >> extend the GitLab CI jobs already in place.  One of their prim

Re: [PATCH v2 2/4] utils: Improve qemu_strtosz() to have 64 bits of precision

2021-02-23 Thread Daniel P . Berrangé
On Thu, Feb 11, 2021 at 02:44:36PM -0600, Eric Blake wrote: > We have multiple clients of qemu_strtosz (qemu-io, the opts visitor, > the keyval visitor), and it gets annoying that edge-case testing is > impacted by implicit rounding to 53 bits of precision due to parsing > with strtod(). As an exa

[PATCH] tests/docker: Use --arch-only when building Debian cross images

2021-02-23 Thread Philippe Mathieu-Daudé
When building a Docker image based on debian10.docker on a non-x86 host, we get: [2/4] RUN apt update && DEBIAN_FRONTEND=noninteractive eatmydata apt build-dep -yy qemu Reading package lists... Done Building dependency tree Reading state information... Done Some packages could not be

Re: [PATCH v2 1/4] utils: Enhance testsuite for do_strtosz()

2021-02-23 Thread Daniel P . Berrangé
On Thu, Feb 11, 2021 at 02:44:35PM -0600, Eric Blake wrote: > Enhance our testsuite coverage of do_strtosz() to cover some things we > know that existing users want to continue working (hex bytes), as well > as some things that accidentally work but shouldn't (hex fractions) or > accidentally fail

  1   2   3   >