Re: [PATCH 2/5] hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias

2021-04-15 Thread Philippe Mathieu-Daudé
On 3/17/21 7:46 PM, Cédric Le Goater wrote: > On 3/13/21 1:05 PM, Philippe Mathieu-Daudé wrote: >> Incorrect subject prefix, should be "hw/ssi/aspeed_smc" > > Is this just good practice or something that was agreed upon ? Not sure, maybe "good practice"? Anyway here I only meant to correct my

Re: [PATCH v3] hw/block/nvme: align with existing style

2021-04-15 Thread Klaus Jensen
On Apr 16 09:22, Gollu Appalanaidu wrote: Use lower case hexadecimal format for the constants and in comments use the same format as used in Spec. ("h") Signed-off-by: Gollu Appalanaidu --- -v3: Add Suggestions (Philippe) Describe the NVMe subsystem style in nvme.c header -v2: Address

Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 11:51 PM, Cleber Rosa wrote: > These tests' setUp do not do anything beyong what their base class do. > And while they do decorate the setUp() we can decorate the classes > instead, so no functionality is lost here. This is what I did first when adding this test, but it was not

[PATCH] block/file-posix: Fix problem with fallocate(PUNCH_HOLE) on GPFS

2021-04-15 Thread Thomas Huth
A customer reported that running qemu-img convert -t none -O qcow2 -f qcow2 input.qcow2 output.qcow2 fails for them with the following error message when the images are stored on a GPFS file system: qemu-img: error while writing sector 0: Invalid argument After analyzing the strace output,

Re: [PATCH 8/8] Tests: add custom test jobs

2021-04-15 Thread Philippe Mathieu-Daudé
Hi Cleber, On 4/15/21 11:51 PM, Cleber Rosa wrote: > Different users (or even companies) have different interests, and > may want to run a reduced set of tests during development, or a > larger set of tests during QE. > > To cover these use cases, some example (but functional) jobs are >

Re: [PATCH 5/8] tests/acceptance/cpu_queries.py: use the proper logging channels

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 11:51 PM, Cleber Rosa wrote: > The test contains methods for the proper log of test related "The Test class ..."? > information. Let's use that and remove the print and the unused > logging import. > > Reference: >

Re: [PATCH 4/8] tests/acceptance/migration.py: cancel test if migration is not supported

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 11:51 PM, Cleber Rosa wrote: > FIXME: check if there's a way to query migration support before > actually requesting migration. > > Some targets/machines contain devices that do not support migration. > Let's acknowledge that and cancel the test as early as possible. > >

Re: [PING^2] [PATCH] [NFC] Mark locally used symbols as static.

2021-04-15 Thread Palmer Dabbelt
On Thu, 15 Apr 2021 10:27:42 PDT (-0700), tetra2...@gmail.com wrote: Hi all, This patch makes locally used symbols static to enable more compiler optimizations on them. Some of the symbols turned out to not be used at all so I marked them with ATTRIBUTE_UNUSED (as I wasn't sure if they were ok

Re: [PATCH 2/8] Acceptance tests: do not try to reuse packages from the system

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 11:51 PM, Cleber Rosa wrote: > The premise behind the original behavior is that it would save people > from downloading Avocado (and other dependencies) if already installed > on the system. To be honest, I think it's extremely rare that the > same versions described as dependencies

Re: [PING^2] [PATCH] [NFC] Mark locally used symbols as static.

2021-04-15 Thread Philippe Mathieu-Daudé
Hi Yuri, On 4/15/21 7:27 PM, Yuri Gribov wrote: > Hi all, > > This patch makes locally used symbols static to enable more compiler > optimizations on them. Some of the symbols turned out to not be used > at all so I marked them with ATTRIBUTE_UNUSED (as I wasn't sure if > they were ok to

Re: [PATCH] target/riscv: fix wfi exception behavior

2021-04-15 Thread Alistair Francis
On Sun, Apr 11, 2021 at 5:41 AM Jose Martins wrote: > > The wfi exception trigger behavior was not taking into account the fact > that user mode is not allowed to execute wfi instructions or the effect > of the hstatus.vtw bit. It was also always generating virtual instruction > exceptions when

Re: [RFC PATCH v2 1/6] device_tree: Add qemu_fdt_add_path

2021-04-15 Thread David Gibson
On Tue, Apr 13, 2021 at 04:07:40PM +0800, Yanan Wang wrote: > From: Andrew Jones > > qemu_fdt_add_path() works like qemu_fdt_add_subnode(), except > it also adds any missing subnodes in the path. We also tweak > an error message of qemu_fdt_add_subnode(). > > We'll make use of this new function

Re: [PATCH v4 09/12] qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 06:33:01PM +0200, Philippe Mathieu-Daudé wrote: > We might have a s390x/ppc64 QEMU binary built without the KVM > accelerator (configured with --disable-kvm). > Checking for /dev/kvm accessibility isn't enough, also check for the > accelerator in the binary. > >

Re: [EXTERNAL] [PATCH v2 2/4] target/ppc: POWER10 supports scv

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 09:43:23AM +0200, Cédric Le Goater wrote: > On 4/15/21 7:42 AM, Nicholas Piggin wrote: > > This must have slipped through the cracks between adding POWER10 support > > and scv support. > > > > Signed-off-by: Nicholas Piggin > > Reviewed-by: Cédric Le Goater Applied to

Re: [PATCH v2 4/4] target/ppc: Add POWER10 exception model

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 03:42:27PM +1000, Nicholas Piggin wrote: > POWER10 adds a new bit that modifies interrupt behaviour, LPCR[HAIL], > and it removes support for the LPCR[AIL]=0b10 mode. > > Reviewed-by: Cédric Le Goater > Tested-by: Cédric Le Goater > Signed-off-by: Nicholas Piggin > ---

Re: [PATCH v2 3/4] target/ppc: Rework AIL logic in interrupt delivery

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 03:42:26PM +1000, Nicholas Piggin wrote: > The AIL logic is becoming unmanageable spread all over powerpc_excp(), > and it is slated to get even worse with POWER10 support. > > Move it all to a new helper function. > > Reviewed-by: Cédric Le Goater > Tested-by: Cédric Le

Re: [PATCH v2 1/4] target/ppc: Fix POWER9 radix guest HV interrupt AIL behaviour

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 09:12:21AM -0300, Fabiano Rosas wrote: > Nicholas Piggin writes: > > > ISA v3.0 radix guest execution has a quirk in AIL behaviour such that > > the LPCR[AIL] value can apply to hypervisor interrupts. > > > > This affects machines that emulate HV=1 mode (i.e., powernv9).

[PATCH v3] hw/block/nvme: align with existing style

2021-04-15 Thread Gollu Appalanaidu
Use lower case hexadecimal format for the constants and in comments use the same format as used in Spec. ("h") Signed-off-by: Gollu Appalanaidu --- -v3: Add Suggestions (Philippe) Describe the NVMe subsystem style in nvme.c header -v2: Address review comments (Klaus) use lower case

Re: [RFC PATCH 1/3] tests/docker: gcc-10 based images for ppc64{, le} tests

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 06:41:36PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > A newer compiler is needed to build tests for Power10 instructions. As > done for arm64 on c729a99d2701, new '-test-cross' images are created for > ppc64 and ppc64le. As done on 936fda4d771f,

Re: [PATCH v3] target/ppc: code motion from translate_init.c.inc to gdbstub.c

2021-04-15 Thread David Gibson
On Wed, Apr 14, 2021 at 01:09:19PM -0700, Richard Henderson wrote: > On 4/14/21 7:59 AM, Bruno Larsen (billionai) wrote: > > All the code related to gdb has been moved from translate_init.c.inc > > file to the gdbstub.c file, where it makes more sense. > > > > This new version puts the prototypes

Re: [RFC PATCH 0/3] tests/tcg/ppc64le: paddi tests

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 06:41:35PM -0300, matheus.fe...@eldorado.org.br wrote: > From: Matheus Ferst > > Based-on: <20210413211129.457272-1-luis.pi...@eldorado.org.br> First things first: it's unclear to me if this is testing stuff that's already merged, or it's speculative tests for the

Re: [PATCH 1/8] Acceptance Jobs: preserve the cache for pip on GitLab CI

2021-04-15 Thread Thomas Huth
On 15/04/2021 23.51, Cleber Rosa wrote: The acceptance jobs (via `make check-venv`) will setup a virtual environment, and after that install packages defined in tests/requirements.txt via pip. Let's enable pip's default cache directory, so that we can save a bit on time/bandwidth.

[Bug 1924669] [NEW] VFP code cannot see CPACR write in the same TB

2021-04-15 Thread Hansni Bu
Public bug reported: If FPU is enabled by writing to CPACR, and the code is in the same translation block as the following VFP code, qemu generates "v7M NOCP UsageFault". This can be reproduced with git HEAD (commit 8fe9f1f891eff4e37f82622b7480ee748bf4af74). The target binary is attached. The

[PATCH v5] i386/cpu_dump: support AVX512 ZMM regs dump

2021-04-15 Thread Robert Hoo
Since commit fa4518741e (target-i386: Rename struct XMMReg to ZMMReg), CPUX86State.xmm_regs[] has already been extended to 512bit to support AVX512. Also, other qemu level supports for AVX512 registers are there for years. But in x86_cpu_dump_state(), still only dump XMM registers no matter

Re: [PATCH v2] hw/block/nvme: align with existing style

2021-04-15 Thread Gollu Appalanaidu
On Thu, Apr 15, 2021 at 07:18:50PM +0200, Klaus Jensen wrote: On Apr 15 15:13, Philippe Mathieu-Daudé wrote: On 4/15/21 2:00 PM, Gollu Appalanaidu wrote: Make uniform hexadecimal numbers format. Signed-off-by: Gollu Appalanaidu --- -v2: Address review comments (Klaus) use lower case hexa

RE: [PATCH V4 4/7] hmp-commands: Add new HMP command for COLO passthrough

2021-04-15 Thread Zhang, Chen
> -Original Message- > From: Dr. David Alan Gilbert > Sent: Wednesday, March 24, 2021 6:40 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Markus Armbruster > ; Li Zhijian ; Zhang Chen > ; Lukas Straub > Subject: Re: [PATCH V4 4/7] hmp-commands: Add

Re: [RFC PATCH 0/9] migration/snap-tool: External snapshot utility

2021-04-15 Thread Peter Xu
On Wed, Mar 17, 2021 at 07:32:13PM +0300, Andrey Gruzdev wrote: > This series is a kind of PoC for asynchronous snapshot reverting. This is > about external snapshots only and doesn't involve block devices. Thus, it's > mainly intended to be used with the new 'background-snapshot' migration >

Re: [PATCH v2 1/2] exec/memory: Extract address_space_set() from dma_memory_set()

2021-04-15 Thread Richard Henderson
On 4/15/21 3:04 AM, Philippe Mathieu-Daudé wrote: dma_memory_set() does a DMA barrier, set the address space with a constant value. The constant value filling code is not specific to DMA and can be used for AddressSpace. Extract it as a new helper: address_space_set(). Signed-off-by: Philippe

Re: [PATCH] docs: Add documentation for shakti_c machine

2021-04-15 Thread Alistair Francis
On Tue, Apr 13, 2021 at 3:44 AM Vijai Kumar K wrote: > > Add documentation for Shakti C reference platform. > > Signed-off-by: Vijai Kumar K Thanks! Applied to riscv-to-apply.next Alistair > --- > docs/system/riscv/shakti-c.rst | 82 ++ > 1 file changed, 82

Re: [PATCH] target/xtensa: don't generate extra EXCP_DEBUG on exception

2021-04-15 Thread Richard Henderson
On 4/15/21 1:55 PM, Max Filippov wrote: target/xtensa used to generate an extra EXCP_DEBUG exception before the first instruction executed after an interrupt or an exception is taken to allow single-stepping that instruction in the debugger. This is no longer needed after the following commits:

Re: [PATCH v2 2/2] hw/elf_ops: clear uninitialized segment space

2021-04-15 Thread Richard Henderson
On 4/15/21 3:04 AM, Philippe Mathieu-Daudé wrote: From: Laurent Vivier When the mem_size of the segment is bigger than the file_size, and if this space doesn't overlap another segment, it needs to be cleared. This bug is very similar to the one we had for linux-user, 22d113b52f41 ("linux-user:

[RFC PATCH 1/3] tests/docker: gcc-10 based images for ppc64{, le} tests

2021-04-15 Thread matheus . ferst
From: Matheus Ferst A newer compiler is needed to build tests for Power10 instructions. As done for arm64 on c729a99d2701, new '-test-cross' images are created for ppc64 and ppc64le. As done on 936fda4d771f, a test for compiler support is added to verify that the toolchain in use has

[RFC PATCH 0/3] tests/tcg/ppc64le: paddi tests

2021-04-15 Thread matheus . ferst
From: Matheus Ferst Based-on: <20210413211129.457272-1-luis.pi...@eldorado.org.br> This series adds gcc-10 based images to enable the build of tests with Power10 instructions. Then two tests for paddi are added: - The first one checks a weird behavior observed on POWER10 Functional Simulator

[RFC PATCH 2/3] tests/tcg/ppc64le: load 33-bits constant with paddi

2021-04-15 Thread matheus . ferst
From: Matheus Ferst This test checks that we can correctly load a 33-bit constant and its two's complement. At least until version 1.1-0, POWER10 Functional Simulation fails this test, processing the immediate as if it were 32-bits instead of 34, so it's probably something to keep an eye on.

[RFC PATCH 3/3] tests/tcg/ppc64le: R=1 test for paddi

2021-04-15 Thread matheus . ferst
From: Matheus Ferst This test exercise the R=1 path of paddi implementation using the extended mnemonic "pla". Signed-off-by: Matheus Ferst --- tests/tcg/ppc64/Makefile.target | 3 ++- tests/tcg/ppc64le/Makefile.target | 3 ++- tests/tcg/ppc64le/pla.c | 26

Re: [PATCH for-6.0?] hw/arm/armsse: Give SSE-300 its own Property array

2021-04-15 Thread Richard Henderson
On 4/15/21 11:23 AM, Peter Maydell wrote: SSE-300 currently shares the SSE-200 Property array. This is bad principally because the default values of the CPU0_FPU and CPU0_DSP properties disable the FPU and DSP on the CPU. That is correct for the SSE-300 but not the SSE-200. Give the SSE-300 its

[PATCH 8/8] Tests: add custom test jobs

2021-04-15 Thread Cleber Rosa
Different users (or even companies) have different interests, and may want to run a reduced set of tests during development, or a larger set of tests during QE. To cover these use cases, some example (but functional) jobs are introduced here: 1) acceptance-all-targets.py: runs all arch agnostic

[PATCH 6/8] Acceptance tests: prevent shutdown on non-specific target tests

2021-04-15 Thread Cleber Rosa
When running tests that are not target specific with various target binaries, some specific behavior appears. For s390x, when there's no guest code running, it will produce GUEST_PANICKED events as the firmware will shutdown the machine. With this change, no GUEST_PANICKED *event* will be

[PATCH 7/8] tests/acceptance/migration.py: cancel test on s390x

2021-04-15 Thread Cleber Rosa
Because s390x targets it can not currently migrate without a guest running. Future work may provide a proper guest, but for now, it's safer to cancel the test. Signed-off-by: Cleber Rosa --- tests/acceptance/migration.py | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 4/8] tests/acceptance/migration.py: cancel test if migration is not supported

2021-04-15 Thread Cleber Rosa
FIXME: check if there's a way to query migration support before actually requesting migration. Some targets/machines contain devices that do not support migration. Let's acknowledge that and cancel the test as early as possible. Signed-off-by: Cleber Rosa --- tests/acceptance/migration.py | 6

[PATCH 5/8] tests/acceptance/cpu_queries.py: use the proper logging channels

2021-04-15 Thread Cleber Rosa
The test contains methods for the proper log of test related information. Let's use that and remove the print and the unused logging import. Reference: https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.html#avocado.Test.log Signed-off-by: Cleber Rosa ---

[PATCH 1/8] Acceptance Jobs: preserve the cache for pip on GitLab CI

2021-04-15 Thread Cleber Rosa
The acceptance jobs (via `make check-venv`) will setup a virtual environment, and after that install packages defined in tests/requirements.txt via pip. Let's enable pip's default cache directory, so that we can save a bit on time/bandwidth. Signed-off-by: Cleber Rosa --- .gitlab-ci.yml | 1 +

[PATCH 0/8] Tests: introduce custom jobs

2021-04-15 Thread Cleber Rosa
Different users (or even companies) have different interests, and may want to run a reduced set of tests during development, or a larger set of tests during QE. To cover these use cases, this introduces some example (but functional) jobs. It's expected that some common jobs will come up from

[PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp

2021-04-15 Thread Cleber Rosa
These tests' setUp do not do anything beyong what their base class do. And while they do decorate the setUp() we can decorate the classes instead, so no functionality is lost here. Signed-off-by: Cleber Rosa --- tests/acceptance/linux_ssh_mips_malta.py | 7 ++- 1 file changed, 2

[PATCH 2/8] Acceptance tests: do not try to reuse packages from the system

2021-04-15 Thread Cleber Rosa
The premise behind the original behavior is that it would save people from downloading Avocado (and other dependencies) if already installed on the system. To be honest, I think it's extremely rare that the same versions described as dependencies will be available on most systems. But, the

[PATCH] target/xtensa: don't generate extra EXCP_DEBUG on exception

2021-04-15 Thread Max Filippov
target/xtensa used to generate an extra EXCP_DEBUG exception before the first instruction executed after an interrupt or an exception is taken to allow single-stepping that instruction in the debugger. This is no longer needed after the following commits: a7ba744f4082 ("tcg/cpu-exec: precise

Re: [PATCH v3 3/3] accel/tcg: Assert that tb->size != 0 after translation

2021-04-15 Thread Max Filippov
On Thu, Apr 15, 2021 at 8:03 AM Peter Maydell wrote: > > On Thu, 15 Apr 2021 at 02:24, Max Filippov wrote: > > I see a few places where target/xtensa may do that. E.g. it does that on > > entry > > to an exception handler to allow for debugging its first instruction. > > That should now be

Re: [PATCH v4 3/4] target/xtensa: Make sure that tb->size != 0

2021-04-15 Thread Max Filippov
On Thu, Apr 15, 2021 at 6:03 AM Ilya Leoshkevich wrote: > > tb_gen_code() assumes that tb->size must never be zero, otherwise it > may produce spurious exceptions. For xtensa this may happen when > decoding an unknown instruction, when handling a write into the > CCOUNT or CCOMPARE special

Re: [PATCH for-6.0?] hw/arm/armsse: Give SSE-300 its own Property array

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 8:23 PM, Peter Maydell wrote: > SSE-300 currently shares the SSE-200 Property array. This is > bad principally because the default values of the CPU0_FPU > and CPU0_DSP properties disable the FPU and DSP on the CPU. > That is correct for the SSE-300 but not the SSE-200. > Give the

Re: [PATCH 0/5] block, migration: improve debugging of migration bdrv_flush failure

2021-04-15 Thread Connor Kuehl
On 4/15/21 8:58 AM, Daniel P. Berrangé wrote: I spent a while debugging a tricky migration failure today which was ultimately caused by fdatasync() getting EACCESS. The existing probes were not sufficient to diagnose this, so I had to resort to GDB. This improves probes and block error reporting

Re: [PATCH 0/2] i386: Fix interrupt based Async PF enablement

2021-04-15 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 06/04/21 13:42, Vitaly Kuznetsov wrote: > > older machine types are still available (I disable it for <= 5.1 but we > > can consider disabling it for 5.2 too). The feature is upstream since > > Linux 5.8, I know that QEMU supports much older

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 6:56 PM, Greg Kurz wrote: > On Thu, 15 Apr 2021 18:45:45 +0200 > Philippe Mathieu-Daudé wrote: > >> On 4/15/21 3:30 PM, Greg Kurz wrote: >>> On Thu, 15 Apr 2021 14:39:55 +0200 >>> Philippe Mathieu-Daudé wrote: >>> On 4/9/21 6:03 PM, Greg Kurz wrote: > Despite its simple name

about mirror cancel

2021-04-15 Thread Vladimir Sementsov-Ogievskiy
Hi all! Recently I've implemented fast-cancelling of mirror job: do bdrv_cancel_in_flight() in mirror_cancel(). Now I'm in doubt: is it a correct thing? I heard, that mirror-cancel is a kind of valid mirror completion.. Looking at documentation: # Note that if you issue 'block-job-cancel'

[Bug 1923861] Re: Hardfault when accessing FPSCR register

2021-04-15 Thread Peter Maydell
The bug fix for the QEMU part of this is https://patchew.org/QEMU/20210415182353.8173-1-peter.mayd...@linaro.org/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1923861 Title: Hardfault when

Re: [PATCH for-6.0?] hw/arm/armsse: Give SSE-300 its own Property array

2021-04-15 Thread Peter Maydell
On Thu, 15 Apr 2021 at 19:23, Peter Maydell wrote: > > SSE-300 currently shares the SSE-200 Property array. This is > bad principally because the default values of the CPU0_FPU > and CPU0_DSP properties disable the FPU and DSP on the CPU. > That is correct for the SSE-300 but not the SSE-200.

[Bug 1923861] Re: Hardfault when accessing FPSCR register

2021-04-15 Thread Peter Maydell
Thanks. This is a bug in the AN547 model -- we were accidentally turning off the FPU. I'll write a patch. NB that with that bug fixed your code then hits an UNDEF trying to do: 0x0996: eef7 1a10 vmrs r1, mvfr0 Only A-profile CPUs have MVFR0 accessible via the vmrs instruction. For

[Bug 1924603] Re: Incorrect feature negotiation for vhost-vdpa netdevice

2021-04-15 Thread Gautam Dawar
QEMU version: 5.1.0 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1924603 Title: Incorrect feature negotiation for vhost-vdpa netdevice Status in QEMU: New Bug description: QEMU cmdline:

Re: [RFC PATCH] accel/tcg: avoid re-translating one-shot instructions

2021-04-15 Thread Peter Maydell
On Thu, 15 Apr 2021 at 19:13, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Thu, 15 Apr 2021 at 17:25, Alex Bennée wrote: > >> > >> By definition a single instruction is capable of being an IO > >> instruction. This avoids a problem of triggering a cpu_io_recompile on > >> a

[Bug 1924603] [NEW] Incorrect feature negotiation for vhost-vdpa netdevice

2021-04-15 Thread Gautam Dawar
Public bug reported: QEMU cmdline: = ./x86_64-softmmu/qemu-system-x86_64 -machine accel=kvm -m 2G -hda /gautam/centos75_1.qcow2 -name gautam,process=gautam -enable-kvm -netdev vhost-vdpa,id=mynet0,vhostdev=/dev/vhost-vdpa-0 -device

[PATCH for-6.0?] hw/arm/armsse: Give SSE-300 its own Property array

2021-04-15 Thread Peter Maydell
SSE-300 currently shares the SSE-200 Property array. This is bad principally because the default values of the CPU0_FPU and CPU0_DSP properties disable the FPU and DSP on the CPU. That is correct for the SSE-300 but not the SSE-200. Give the SSE-300 its own Property array with the correct SSE-300

Re: [RFC PATCH] accel/tcg: avoid re-translating one-shot instructions

2021-04-15 Thread Alex Bennée
Peter Maydell writes: > On Thu, 15 Apr 2021 at 17:25, Alex Bennée wrote: >> >> By definition a single instruction is capable of being an IO >> instruction. This avoids a problem of triggering a cpu_io_recompile on >> a non-recorded translation which then fails because it expects >>

Re: [RFC PATCH] accel/tcg: avoid re-translating one-shot instructions

2021-04-15 Thread Richard Henderson
On 4/15/21 9:24 AM, Alex Bennée wrote: By definition a single instruction is capable of being an IO instruction. This avoids a problem of triggering a cpu_io_recompile on a non-recorded translation which then fails because it expects tcg_tb_lookup() to succeed unconditionally. The normal use

Re: [RFC PATCH] accel/tcg: avoid re-translating one-shot instructions

2021-04-15 Thread Peter Maydell
On Thu, 15 Apr 2021 at 17:25, Alex Bennée wrote: > > By definition a single instruction is capable of being an IO > instruction. This avoids a problem of triggering a cpu_io_recompile on > a non-recorded translation which then fails because it expects > tcg_tb_lookup() to succeed unconditionally.

[PING^2] [PATCH] [NFC] Mark locally used symbols as static.

2021-04-15 Thread Yuri Gribov
Hi all, This patch makes locally used symbols static to enable more compiler optimizations on them. Some of the symbols turned out to not be used at all so I marked them with ATTRIBUTE_UNUSED (as I wasn't sure if they were ok to delete). The symbols have been identified with a pet project of

Re: [EXTERNAL] Re: [PULL 18/23] accel/tcg: re-factor non-RAM execution code

2021-04-15 Thread Cédric Le Goater
On 4/15/21 5:55 PM, Philippe Mathieu-Daudé wrote: > On 4/15/21 4:54 PM, Peter Maydell wrote: >> On Thu, 15 Apr 2021 at 15:32, Alex Bennée wrote: >>> --8<---cut here---start->8--- >>> accel/tcg: avoid re-translating one-shot instructions >>> >>> By definition a

Re: [PATCH v4 0/4] hw/i2c: Adds pca954x i2c mux switch device

2021-04-15 Thread Patrick Venture
On Thu, Apr 15, 2021 at 5:13 AM Corey Minyard wrote: > > On Mon, Apr 12, 2021 at 12:45:18PM -0700, Patrick Venture wrote: > > The i2c mux device pca954x implements two devices: > > - the pca9546 and pca9548. > > This looks good, I have pulled it into my queue. 6.0 is about to be > released,

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-15 Thread Daniel P . Berrangé
On Thu, Apr 15, 2021 at 05:40:40PM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 15, 2021 at 12:30:11PM -0400, Eduardo Habkost wrote: > > On Thu, Apr 15, 2021 at 12:04 PM Daniel P. Berrangé > > wrote: > > > > > > Is it possible to query the migration blockers via QMP ? > > > > I don't think it

Re: [EXTERNAL] Re: [PULL 18/23] accel/tcg: re-factor non-RAM execution code

2021-04-15 Thread Peter Maydell
On Thu, 15 Apr 2021 at 18:18, Cédric Le Goater wrote: > > On 4/15/21 5:55 PM, Philippe Mathieu-Daudé wrote: > > On 4/15/21 4:54 PM, Peter Maydell wrote: > >> On Thu, 15 Apr 2021 at 15:32, Alex Bennée wrote: > >>> --8<---cut here---start->8--- > >>> accel/tcg:

Re: [PATCH v4 07/12] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for TCG

2021-04-15 Thread Andrew Jones
On Thu, Apr 15, 2021 at 06:32:59PM +0200, Philippe Mathieu-Daudé wrote: > Now than we can probe if the TCG accelerator is available > at runtime with a QMP command, only run these tests if TCG > is built into the QEMU binary. > > Suggested-by: Andrew Jones > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Apr 15, 2021 at 05:44:02PM +0200, Vitaly Kuznetsov wrote: > > When a migration blocker is added nothing is reported to the user, > > inability to migrate such guest may come as a late surprise. As a bare > > minimum, we can print a

Re: [PATCH 0/2] osdep: allow including qemu/osdep.h outside extern "C"

2021-04-15 Thread Aleksandar Rikalo
Hi Paolo, Can you specify how to reproduce the issue ? We need more details about environment. In my case, everything seems to work fine for the newest version of glib (2.68). Thank you, Aleksandar > qemu/osdep.h is quite special in that, despite being part of QEMU sources, > it is included

[PATCH v4 07/12] target/hexagon: expose next PC in DisasContext

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/translate.c | 3 ++- target/hexagon/translate.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index

Re: [PATCH v2] hw/block/nvme: align with existing style

2021-04-15 Thread Klaus Jensen
On Apr 15 15:13, Philippe Mathieu-Daudé wrote: On 4/15/21 2:00 PM, Gollu Appalanaidu wrote: Make uniform hexadecimal numbers format. Signed-off-by: Gollu Appalanaidu --- -v2: Address review comments (Klaus) use lower case hexa format for the code and in comments use the same format as used in

Re: [PATCH 5/5] target/ppc: Implement paddi and replace addi insns

2021-04-15 Thread Richard Henderson
On 4/14/21 12:11 PM, Richard Henderson wrote: This approach seems like it will work fine for MLS and MMIR prefixes.  For 8LS, 8RR, and MRR prefixes, we'll need some extra help within ppc_tr_translate_insn.  E.g.     insn = translator_ldl_swap(env, ctx->base.pc_next,

[PATCH v4 01/12] tcg: expose TCGCond manipulation routines

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit moves into a separate file routines used to manipulate TCGCond. These will be employed by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- include/tcg/tcg-cond.h | 101 +

[Bug 1923861] Re: Hardfault when accessing FPSCR register

2021-04-15 Thread ml-0
Command line is qemu-system-arm -machine mps3-an547 -nographic -kernel test.elf -semihosting -semihosting-config enable=on,target=native Binary is attached. It does int main(int argc, char* argv[]) { SCB->NSACR |= (3U << 10U);/* enable Non-secure access to CP10 and CP11

Re: [PATCH v4 06/12] qtest/arm-cpu-features: Remove TCG fallback to KVM specific tests

2021-04-15 Thread Andrew Jones
On Thu, Apr 15, 2021 at 06:32:58PM +0200, Philippe Mathieu-Daudé wrote: > sve_tests_sve_off_kvm() and test_query_cpu_model_expansion_kvm() > tests are now only being run if KVM is available. Drop the TCG > fallback. > > Suggested-by: Andrew Jones > Signed-off-by: Philippe Mathieu-Daudé > --- >

[PATCH v4 04/12] target/hexagon: make slot number an unsigned

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 6 -- target/hexagon/macros.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-15 Thread Greg Kurz
On Thu, 15 Apr 2021 18:45:45 +0200 Philippe Mathieu-Daudé wrote: > On 4/15/21 3:30 PM, Greg Kurz wrote: > > On Thu, 15 Apr 2021 14:39:55 +0200 > > Philippe Mathieu-Daudé wrote: > > > >> On 4/9/21 6:03 PM, Greg Kurz wrote: > >>> Despite its simple name and common usage of "getting a pointer to

Re: [PATCH 1/2] qdev: Separate implementations of qdev_get_machine() for user and system

2021-04-15 Thread Philippe Mathieu-Daudé
On 4/15/21 3:30 PM, Greg Kurz wrote: > On Thu, 15 Apr 2021 14:39:55 +0200 > Philippe Mathieu-Daudé wrote: > >> On 4/9/21 6:03 PM, Greg Kurz wrote: >>> Despite its simple name and common usage of "getting a pointer to >>> the machine" in system-mode emulation, qdev_get_machine() has some >>>

[PATCH v4 02/12] target/hexagon: update MAINTAINERS for idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 36055f14c5..158badbd18 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -193,11 +193,19 @@ Hexagon TCG CPUs M: Taylor

Re: [PATCH v4 04/12] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM

2021-04-15 Thread Andrew Jones
On Thu, Apr 15, 2021 at 06:32:56PM +0200, Philippe Mathieu-Daudé wrote: > Use the recently added generic qtest_has_accel() method to > check if KVM is available. > > Suggested-by: Claudio Fontana > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/qtest/arm-cpu-features.c | 25

Re: [PATCH v4 05/12] qtest/arm-cpu-features: Restrict sve_tests_sve_off_kvm test to KVM

2021-04-15 Thread Andrew Jones
On Thu, Apr 15, 2021 at 06:32:57PM +0200, Philippe Mathieu-Daudé wrote: > The sve_tests_sve_off_kvm() test is KVM specific. > Only run it if KVM is available. > > Suggested-by: Andrew Jones > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/qtest/arm-cpu-features.c | 4 ++-- > 1 file

[PATCH v4 11/12] target/hexagon: call idef-parser functions

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_tcg_funcs.py | 28 ++-- target/hexagon/hex_common.py| 10 ++

Re: [PATCH 5/5] block: remove duplicate trace.h include

2021-04-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > Signed-off-by: Daniel P. Berrangé Reviewed-by: Dr. David Alan Gilbert > --- > block/file-posix.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/block/file-posix.c b/block/file-posix.c > index 6aafeda44f..2538e43299 100644 > ---

[PATCH v4 11/12] tests/qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore

2021-04-15 Thread Philippe Mathieu-Daudé
Since commit 82bf7ae84ce ("target/arm: Remove KVM support for 32-bit Arm hosts") we can remove the comment / check added in commit ab6b6a4 and directly run the bios-tables-test. Reviewed-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/meson.build | 3 +-- 1 file

Re: [PATCH RFC] migration: warn about non-migratable configurations unless '--no-migration' was specified

2021-04-15 Thread Daniel P . Berrangé
On Thu, Apr 15, 2021 at 12:30:11PM -0400, Eduardo Habkost wrote: > On Thu, Apr 15, 2021 at 12:04 PM Daniel P. Berrangé > wrote: > > > > On Thu, Apr 15, 2021 at 05:44:02PM +0200, Vitaly Kuznetsov wrote: > > > When a migration blocker is added nothing is reported to the user, > > > inability to

[PATCH v4 10/12] target/hexagon: import parser for idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.y | 947 +++ target/hexagon/idef-parser/parser-helpers.c | 2374 + target/hexagon/idef-parser/parser-helpers.h | 347 +++

[PATCH v4 09/12] target/hexagon: import lexer for idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 254 target/hexagon/idef-parser/idef-parser.lex| 611 ++ target/hexagon/meson.build| 4 +

[PATCH v4 09/12] qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64

2021-04-15 Thread Philippe Mathieu-Daudé
We might have a s390x/ppc64 QEMU binary built without the KVM accelerator (configured with --disable-kvm). Checking for /dev/kvm accessibility isn't enough, also check for the accelerator in the binary. Signed-off-by: Philippe Mathieu-Daudé --- Cc: David Gibson Cc: Greg Kurz Cc: Halil Pasic

[PATCH v4 12/12] target/hexagon: import additional tests

2021-04-15 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 36 - tests/tcg/hexagon/crt.S| 28 + tests/tcg/hexagon/test_abs.S | 20 ++ tests/tcg/hexagon/test_add.S |

[PATCH v4 06/12] target/hexagon: introduce new helper functions

2021-04-15 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.c | 188 target/hexagon/genptr.h | 22 + target/hexagon/macros.h |

[PATCH v4 08/12] target/hexagon: prepare input for the idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 ++ target/hexagon/idef-parser/macros.inc | 150

[PATCH v4 05/12] qtest/arm-cpu-features: Restrict sve_tests_sve_off_kvm test to KVM

2021-04-15 Thread Philippe Mathieu-Daudé
The sve_tests_sve_off_kvm() test is KVM specific. Only run it if KVM is available. Suggested-by: Andrew Jones Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/arm-cpu-features.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/arm-cpu-features.c

[PATCH v4 05/12] target/hexagon: make helper functions non-static

2021-04-15 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/genptr.c | 7 ---

[PATCH v4 00/12] target/hexagon: introduce idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the fourth iteration of the patchset and includes fixes suggested in previous iterations. `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part of the

[PATCH v4 03/12] target/hexagon: import README for idef-parser

2021-04-15 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/README | 5 + target/hexagon/idef-parser/README.rst | 447 ++ 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v4 04/12] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM

2021-04-15 Thread Philippe Mathieu-Daudé
Use the recently added generic qtest_has_accel() method to check if KVM is available. Suggested-by: Claudio Fontana Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/arm-cpu-features.c | 25 + 1 file changed, 1 insertion(+), 24 deletions(-) diff --git

[PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected

2021-04-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The previous attempt (commit f77147cd4de) doesn't work as expected, as we still have CONFIG_TCG=1 when using: configure --disable-system --disable-user Now than we have removed the use of CONFIG_TCG from target-dependent files in tests/qtest/, we can remove the

Re: [PATCH 4/5] block: add trace point when fdatasync fails

2021-04-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > A flush failure is a critical failure scenario for some operations. > For example, it will prevent migration from completing, as it will > make vm_stop() report an error. Thus it is important to have a > trace point present for debugging. > >

  1   2   3   >