Re: The latest Qemu release can't bootup VM with latest guest kernel.

On Sun, May 23, 2021 at 03:23:30PM +0300, Gal Hammer wrote: > Hi Yang, > > On Thu, 20 May 2021 at 11:27, Yang Zhong wrote: > > > Hello all, > > > > I found the latest Qemu release can't bootup the VM with latest guest > > kernel(>5.13). > > > > The normal v6.0.0 release is good to bootup the

Re: [PATCH 16/24] target/ppc: Remove PowerPCCPUClass.handle_mmu_fault

On Sun, May 23, 2021 at 11:36:44PM -0500, Richard Henderson wrote: 65;6401;1c> On 5/23/21 10:28 PM, David Gibson wrote: > > On Tue, May 18, 2021 at 03:11:38PM -0500, Richard Henderson wrote: > > > Instead, use a switch on env->mmu_model. This avoids some > > > replicated information in cpu setup.

[PATCH 5/5] linux-user: Implement pivot_root

Used by runc. Signed-off-by: YAMAMOTO Takashi --- linux-user/syscall.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 2947e79dc0..e739921e86 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -35,6

[PATCH 3/5] linux-user: Fix the execfd case of /proc/self/exe open

It's problematic to return AT_EXECFD as it is because the user app would close it. This patch opens it via /proc/self/fd instead. Signed-off-by: YAMAMOTO Takashi --- linux-user/syscall.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c

[PATCH 2/5] linux-uesr: make exec_path realpath

Otherwise, it can be easily fooled by the user app using chdir(). Signed-off-by: YAMAMOTO Takashi --- linux-user/main.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index 4dfc47ad3b..1f9f4e3820 100644 --- a/linux-user/main.c +++

[PATCH 4/5] linux-user: dup the execfd on start up

So that it can be used for other purposes (e.g. syscall.c) after the elf loader closed it. Signed-off-by: YAMAMOTO Takashi --- linux-user/main.c| 8 linux-user/qemu.h| 2 ++ linux-user/syscall.c | 5 ++--- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git

[PATCH 1/5] linux-user: handle /proc/self/exe for execve

It seems somehow common to execve /proc/self/exe in docker or golang community these days. At least, moby "reexec" and runc "libcontainer" do that. Signed-off-by: YAMAMOTO Takashi --- linux-user/syscall.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH 0/5] linux-user changes to run docker

These patches, along with a few more hacks [1] I didn't include in this patchset, allowed me to run arm64 and armv7 version of dind image on amd64. [1] https://github.com/yamt/qemu/tree/linux-user-for-docker You can find my test setup here:

Re: [PATCH] target/ppc: Implement ISA v3.1 wait variants

On Mon, May 17, 2021 at 05:19:06PM +1000, Nicholas Piggin wrote: > Excerpts from David Gibson's message of May 17, 2021 3:39 pm: > > On Mon, May 17, 2021 at 12:46:51PM +1000, Nicholas Piggin wrote: > >> ISA v3.1 adds new variations of wait, specified by the WC field. These > >> are not compatible

Re: [PATCH v5 1/3] spapr: nvdimm: Forward declare and move the definitions

On Tue, May 18, 2021 at 08:03:17AM -0400, Shivaprasad G Bhat wrote: > The subsequent patches add definitions which tend to get > the compilation to cyclic dependency. So, prepare with > forward declarations, move the definitions and clean up. > > Signed-off-by: Shivaprasad G Bhat This is a

Re: [PATCH qemu v19] spapr: Implement Open Firmware client interface

On Mon, May 17, 2021 at 02:17:36PM +0200, BALATON Zoltan wrote: > On Mon, 17 May 2021, Alexey Kardashevskiy wrote: > > On 5/16/21 01:04, BALATON Zoltan wrote: > > > On Thu, 22 Apr 2021, Alexey Kardashevskiy wrote: > > > > [snip] > > > > > > +/* Defined as Big Endian */ > > > > +struct prom_args

Re: [PATCH 00/24] target/ppc: Clean up mmu translation

On 5/23/21 10:26 PM, David Gibson wrote: On Wed, May 19, 2021 at 05:47:05PM -0500, Richard Henderson wrote: On 5/19/21 3:37 PM, Richard Henderson wrote: On 5/18/21 9:52 PM, David Gibson wrote: I've applied 1..15, still looking at the rest. Please dequeue.  I want to create a new

Re: [PATCH 07/38] target/riscv: SIMD 8-bit Shift Instructions

On Fri, 12 Feb 2021 07:02:25 PST (-0800), zhiwei_...@c-sky.com wrote: Signed-off-by: LIU Zhiwei I know it's always kind of akward for this type of patches, but IIUC they're all supposed to have some sort of description. --- target/riscv/helper.h | 9 +++

Re: [PATCH 16/24] target/ppc: Remove PowerPCCPUClass.handle_mmu_fault

On 5/23/21 10:28 PM, David Gibson wrote: On Tue, May 18, 2021 at 03:11:38PM -0500, Richard Henderson wrote: Instead, use a switch on env->mmu_model. This avoids some replicated information in cpu setup. I have mixed feelings about this, since I introduced pcc->handle_mmu_fault specifically

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

On 5/23/21 21:24, BALATON Zoltan wrote: On Sun, 23 May 2021, Alexey Kardashevskiy wrote: On 23/05/2021 01:02, BALATON Zoltan wrote: On Sat, 22 May 2021, BALATON Zoltan wrote: On Sat, 22 May 2021, Alexey Kardashevskiy wrote: VOF itself does not prints anything in this patch. However it

Re: [PATCH 16/24] target/ppc: Remove PowerPCCPUClass.handle_mmu_fault

On Tue, May 18, 2021 at 03:11:38PM -0500, Richard Henderson wrote: > Instead, use a switch on env->mmu_model. This avoids some > replicated information in cpu setup. I have mixed feelings about this, since I introduced pcc->handle_mmu_fault specifically to get rid of the nasty mega-switch, with

Re: [PATCH 09/11] include/exec: added functions to the stubs in exec-all.h

On Mon, May 17, 2021 at 08:07:24AM -0300, Bruno Piazera Larsen wrote: > > On 17/05/2021 00:55, David Gibson wrote: > > On Thu, May 13, 2021 at 11:03:24AM -0300, Lucas Mateus Martins Araujo e > > Castro wrote: > > > On 12/05/2021 15:34, Richard Henderson wrote: > > > > On 5/12/21 9:08 AM, Bruno

Re: [PATCH 00/24] target/ppc: Clean up mmu translation

On Wed, May 19, 2021 at 05:47:05PM -0500, Richard Henderson wrote: > On 5/19/21 3:37 PM, Richard Henderson wrote: > > On 5/18/21 9:52 PM, David Gibson wrote: > > > I've applied 1..15, still looking at the rest. > > > > Please dequeue.  I want to create a new mmu-internal.h, which affects > > all

Re: [PATCH 22/24] target/ppc: Split out ppc_jumbo_xlate

On Wed, May 19, 2021 at 03:40:15PM -0300, Bruno Piazera Larsen wrote: > > On 18/05/2021 17:11, Richard Henderson wrote: > > Mirror the interface of ppc_radix64_xlate (mostly), putting all > > of the logic for older mmu translation into a single entry point. > > For booke, we need to add mmu_idx

Re: [PATCH v3] spapr: Fix EEH capability issue on KVM guest for PCI passthru

On Fri, May 21, 2021 at 01:35:51PM +0530, Mahesh Salgaonkar wrote: > With upstream kernel, especially after commit 98ba956f6a389 > ("powerpc/pseries/eeh: Rework device EEH PE determination") we see that KVM > guest isn't able to enable EEH option for PCI pass-through devices anymore. > >

Re: [PATCH] spapr: Don't hijack current_machine->boot_order

On Fri, May 21, 2021 at 06:07:35PM +0200, Greg Kurz wrote: > QEMU 6.0 moved all the -boot variables to the machine. Especially, the > removal of the boot_order static changed the handling of '-boot once' > from: > > if (boot_once) { > qemu_boot_set(boot_once, _fatal); >

Re: [PATCH 09/11] include/exec: added functions to the stubs in exec-all.h

On Mon, May 17, 2021 at 01:59:35PM -0300, Lucas Mateus Martins Araujo e Castro wrote: > > On 17/05/2021 00:58, David Gibson wrote: > > On Thu, May 13, 2021 at 06:44:01PM -0500, Richard Henderson wrote: > > 65;6401;1c> On 5/13/21 9:03 AM, Lucas Mateus Martins Araujo e Castro wrote: > > > >

Re: [PATCH v3 8/9] target/ppc: created tcg-stub.c file

On Fri, May 21, 2021 at 05:17:58PM -0300, Bruno Larsen (billionai) wrote: > Created a file with stubs needed to compile disabling TCG. *_ppc_opcodes > were created to make cpu_init.c have a few less ifdefs, since they are > not needed. coftmmu_resize_hpt_* have to be created because the compiler >

Re: [PATCH v3 4/9] target/ppc: overhauled and moved logic of storing fpscr

On Fri, May 21, 2021 at 05:17:54PM -0300, Bruno Larsen (billionai) wrote: 65;6401;1c> Followed the suggested overhaul to store_fpscr logic, and moved it to > cpu.c where it can be accessed in !TCG builds. > > The overhaul was suggesting because storing a value to fpscr should > never raise an

Re: [PATCH v3 3/9] target/ppc: reduce usage of fpscr_set_rounding_mode

On Fri, May 21, 2021 at 05:17:53PM -0300, Bruno Larsen (billionai) wrote: > It is preferable to store the current rounding mode and retore from that > than recalculating from fpscr, so we changed the behavior of do_fri and > VSX_ROUND to do it like that. > > Suggested-by: Richard Henderson >

Re: [PATCH v3 6/9] target/ppc: moved ppc_cpu_do_interrupt to cpu.c

On Fri, May 21, 2021 at 05:17:56PM -0300, Bruno Larsen (billionai) wrote: > Moved the ppc_cpu_do_interrupt function to cpu.c file, where it makes > more sense, and turned powerpc_excp not static, as it now needs to be > accessed from outside of excp_helper.c > > Signed-off-by: Bruno Larsen

Re: [PATCH v3 1/9] target/ppc: cleaned error_report from ppc_store_sdr1

On Fri, May 21, 2021 at 05:17:51PM -0300, Bruno Larsen (billionai) wrote: > Changed how the function ppc_store_sdr1, from error_report(...) to > qemu_log_mask(LOG_GUEST_ERROR, ...). > > Signed-off-by: Bruno Larsen (billionai) > Suggested-by: Richard Henderson Applied to ppc-for-6.1, thanks. >

Re: [PATCH v3 7/9] target/ppc: Added options to disable many TCG-only functions

On Fri, May 21, 2021 at 05:17:57PM -0300, Bruno Larsen (billionai) wrote: > Wrapped some function calls in cpu_init.c, gdbstub.c, mmu-hash64.c, > mmu_helper.c and excp_helper.c that were TCG only with ifdef > CONFIG_TCG, > to support building without TCG. > > for excp_helper we also moved the

Re: [PATCH v3 2/9] target/ppc: moved ppc_store_lpcr and ppc_store_msr to cpu.c

On Fri, May 21, 2021 at 05:17:52PM -0300, Bruno Larsen (billionai) wrote: > These functions are used in hw/ppc logic, during machine startup, which > means it must be compiled when --disable-tcg is selected, and so it has > been moved into a common code file > > Signed-off-by: Bruno Larsen

Re: [PATCH v3 5/9] target/ppc: removed unnecessary inclusion of helper-proto.h

On Fri, May 21, 2021 at 05:17:55PM -0300, Bruno Larsen (billionai) wrote: > These files included helper-proto.h, but didn't use or declare any > helpers, so the #include has been removed > > Signed-off-by: Bruno Larsen (billionai) > Reviewed-by: Richard Henderson Applied to ppc-for-6.1,

[RFC v4 13/14] target/s390x: split sysemu part of cpu models

also create a tiny _user.c with just the (at least for now), empty implementation of apply_cpu_model. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- target/s390x/cpu_models.c| 417 +- target/s390x/cpu_models_sysemu.c | 426

[RFC v4 14/14] MAINTAINERS: update s390x directories

After the reshuffling, update MAINTAINERS accordingly. Make use of the new directories: target/s390x/kvm/ target/s390x/tcg/ Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- MAINTAINERS | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS

[RFC v4 10/14] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m

this will allow to remove the kvm stubs. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- target/s390x/diag.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/s390x/diag.c b/target/s390x/diag.c index c17a2498a7..8405f69df0 100644 ---

[RFC v4 12/14] target/s390x: move kvm files into kvm/

Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- hw/intc/s390_flic_kvm.c| 2 +- hw/s390x/s390-stattrib-kvm.c | 2 +- hw/s390x/tod-kvm.c | 2 +- hw/vfio/ap.c | 2 +- meson.build| 1 +

[RFC v4 09/14] target/s390x: make helper.c sysemu-only

Now that we have moved cpu-dump functionality out of helper.c, we can make the module sysemu-only. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- target/s390x/helper.c| 4 target/s390x/meson.build | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git

[RFC v4 11/14] target/s390x: remove kvm-stub.c

all function calls are protected by kvm_enabled(), so we should not need the stubs. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- target/s390x/kvm-stub.c | 126 --- target/s390x/meson.build | 2 +- 2 files changed, 1 insertion(+), 127

[RFC v4 07/14] target/s390x: move sysemu-only code out to cpu-sysemu.c

Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- target/s390x/cpu-sysemu.c | 304 ++ target/s390x/cpu.c| 282 ++- target/s390x/meson.build | 1 + target/s390x/trace-events | 2 +- 4 files changed, 318

[RFC v4 08/14] target/s390x: split cpu-dump from helper.c

Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- target/s390x/cpu-dump.c | 131 +++ target/s390x/helper.c| 107 target/s390x/meson.build | 1 + 3 files changed, 132 insertions(+), 107 deletions(-) create

[RFC v4 06/14] target/s390x: start moving TCG-only code to tcg/

move everything related to translate, as well as HELPER code in tcg/ mmu_helper.c stays put for now, as it contains both TCG and KVM code. The internal.h file is renamed to s390x-internal.h, because of the risk of collision with other files with the same name. Signed-off-by: Claudio Fontana

[RFC v4 03/14] hw/s390x: only build tod-tcg from the CONFIG_TCG build

this will allow in later patches to remove unneeded stubs in target/s390x. Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen --- hw/s390x/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[RFC v4 04/14] hw/s390x: tod: make explicit checks for accelerators when initializing

replace general "else" with specific checks for each possible accelerator. Handle qtest as a NOP, and error out for an unknown accelerator used in combination with tod. Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen ---

[RFC v4 05/14] target/s390x: remove tcg-stub.c

now that we protect all calls to the tcg-specific functions with if (tcg_enabled()), we do not need the TCG stub anymore. Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen --- target/s390x/meson.build | 2 +-

[RFC v4 01/14] target/s390x: meson: add target_user_arch

the lack of target_user_arch makes it hard to fully leverage the build system in order to separate user code from sysemu code. Provide it, so that we can avoid the proliferation of #ifdef in target code. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen --- target/s390x/meson.build |

[RFC v4 02/14] hw/s390x: rename tod-qemu.c to tod-tcg.c

we stop short of renaming the actual qom object though, so type remains TYPE_QEMU_S390_TOD, ie "s390-tod-qemu". Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen --- hw/s390x/meson.build | 2 +-

[PATCH] linux-user: make process_pending_signals thread-safe

Use pthread_sigmask instead of sigprocmask inside process_pending_signals to ensure that race conditions aren't possible. Signed-off-by: Hamza Mahfooz --- linux-user/signal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index

Re: About the performance of hyper-v

> >> > Analyze events for all VMs, all VCPUs: > >> > VM-EXITSamples Samples% Time%Min TimeMax > >> > Time Avg time > >> > EXTERNAL_INTERRUPT 47183159.89%68.58% 0.64us > >> > 65.42us 2.34us ( +- 0.11% ) > >> >MSR_WRITE

[Bug 1891748] Re: qemu-arm-static 5.1 can't run gcc

Anyone? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1891748 Title: qemu-arm-static 5.1 can't run gcc Status in QEMU: Fix Released Status in Juju Charms Collection: New Bug description:

Re: [PATCH 05/38] target/riscv: 8-bit Addition & Subtraction Instruction

On Mon, 15 Mar 2021 14:22:58 PDT (-0700), alistai...@gmail.com wrote: On Fri, Feb 12, 2021 at 10:14 AM LIU Zhiwei wrote: Signed-off-by: LIU Zhiwei Acked-by: Alistair Francis I saw some reviews on the other ones, but since others (like this) just have acks and haven't had any other

Re: [PATCH] linux-user/syscall: zero-init msghdr in do_sendrecvmsg_locked

Doing a ping for this patch. https://patchew.org/QEMU/20210516091536.1042693-1-ke...@lithdew.net/ Best regards, Kenta Iwasaki On Sun, 16 May 2021 at 21:57, Kenta Iwasaki wrote: > Sure, > > The bytes of `msghdr` need to be cleared because the `msghdr` struct > layout specified in QEMU appears

Re: notdirty_write thrashing in simple for loop

On Sun, 23 May 2021, Mark Watson wrote: Hi On Sun, 23 May 2021 at 15:41, BALATON Zoltan wrote: I think you need to be more specific about details or even better provide a way to reproduce it without your hardware if possible otherwise people will not get what you're seeing. From the above

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

On Sun, 23 May 2021, BALATON Zoltan wrote: On Sun, 23 May 2021, Alexey Kardashevskiy wrote: One thing to note about PCI is that normally I think the client expects the firmware to do PCI probing and SLOF does it. But VOF does not and Linux scans PCI bus(es) itself. Might be a problem for you

Re: notdirty_write thrashing in simple for loop

Hi On Sun, 23 May 2021 at 15:41, BALATON Zoltan wrote: > I think you need to be more specific about details or even better provide > a way to reproduce it without your hardware if possible otherwise people > will not get what you're seeing. From the above it's not clear to me if > you're

Re: notdirty_write thrashing in simple for loop

Hello, On Tue, 18 May 2021, Mark Watson wrote: I'm trying to implement my own machine for amiga emulation using a software cpu and fpga hardware. For this I have built my own machine which consists of a large malloced ram block and some fpga hardware mmapped elsewhere into the memory space.

Re: The latest Qemu release can't bootup VM with latest guest kernel.

Hi Yang, On Thu, 20 May 2021 at 11:27, Yang Zhong wrote: > Hello all, > > I found the latest Qemu release can't bootup the VM with latest guest > kernel(>5.13). > > The normal v6.0.0 release is good to bootup the latest guest kernel. > > There are two issues were found > 1. Guest kernel panic.

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

On Sun, 23 May 2021, Alexey Kardashevskiy wrote: On 22/05/2021 23:08, BALATON Zoltan wrote: On Sat, 22 May 2021, Alexey Kardashevskiy wrote: On 22/05/2021 05:57, BALATON Zoltan wrote: On Fri, 21 May 2021, BALATON Zoltan wrote: On Fri, 21 May 2021, Alexey Kardashevskiy wrote: On 21/05/2021

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

On Sun, 23 May 2021, Alexey Kardashevskiy wrote: On 23/05/2021 02:46, BALATON Zoltan wrote: On Sat, 22 May 2021, BALATON Zoltan wrote: On Sat, 22 May 2021, BALATON Zoltan wrote: On Sat, 22 May 2021, Alexey Kardashevskiy wrote: VOF itself does not prints anything in this patch. However it

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

On Sun, 23 May 2021, Alexey Kardashevskiy wrote: On 23/05/2021 01:02, BALATON Zoltan wrote: On Sat, 22 May 2021, BALATON Zoltan wrote: On Sat, 22 May 2021, Alexey Kardashevskiy wrote: VOF itself does not prints anything in this patch. However it seems to be needed for linux as the first

Re: [PATCH qemu v20] spapr: Implement Open Firmware client interface

On Sun, 23 May 2021, Alexey Kardashevskiy wrote: On 22/05/2021 23:01, BALATON Zoltan wrote: On Sat, 22 May 2021, Alexey Kardashevskiy wrote: On 21/05/2021 19:05, BALATON Zoltan wrote: On Fri, 21 May 2021, Alexey Kardashevskiy wrote: On 21/05/2021 07:59, BALATON Zoltan wrote: On Thu, 20 May

[Bug 1887306] Re: qemu-user deadlocks when forked in a multithreaded process

Still reproduces with QEMU 6.0.0. ** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1887306 Title: qemu-user deadlocks when forked in a

[PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock()

Such comments make reviewing this file somehow easier. Signed-off-by: Philippe Mathieu-Daudé --- v2: only one space before end of comment (mst) --- hw/virtio/virtio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index e02544b2df7..130e3568409

Re:Re:Re: set qemu support serial crtscts

Hi, Peter and all developers Do you solve this question? I am looking forward to your reply. Thank you very much At 2021-04-15 13:38:08, "付小明" wrote: Hi， Peter and all developers Yes， I need to describe it clearly. 1、I want make the qemu serial support crtscts 2、Problem: the

Re: [RFC PATCH v4 0/7] Use ACPI PCI hot-plug for Q35

On Thu, May 13, 2021 at 08:26:35AM +0200, Julia Suvorova wrote: > The patch set consists of two parts: > patches 1-4: introduce new feature > 'acpi-pci-hotplug-with-bridge-support' on Q35 > patches 5-7: make the feature default along with changes in ACPI tables > > This way

Re: [PATCH] hw/virtio: Have virtio_bus_get_vdev_bad_features() return 64-bit value

On Thu, May 20, 2021 at 12:28:22PM +0200, Philippe Mathieu-Daudé wrote: > In commit 019a3edbb25 ("virtio: make features 64bit wide") we > increased the 'features' field to 64-bit, but forgot to update > the virtio_bus_get_vdev_bad_features() helper. The 'bad features' > are truncated to 32-bit.

Re: [PATCH] hw/virtio: Document *_should_notify() are called within rcu_read_lock()

On Thu, May 20, 2021 at 08:49:00AM +0200, Philippe Mathieu-Daudé wrote: > Such comments make reviewing this file somehow easier. > > Signed-off-by: Philippe Mathieu-Daudé ok but > --- > hw/virtio/virtio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/virtio/virtio.c