As Alexander already wrote, this triggered the same bug as #1919036
which got fixed by commit 0ebb5fd80589835153a0c2baa1b8cc7a04e67a93.
Since this is not reproducible anymore, I'm closing this bug now. If you
still can reproduce it somehow, please open a new ticket in the new
gitlab issue tracker.
Daniel Henrique Barboza writes:
> On 6/11/21 9:12 AM, Markus Armbruster wrote:
>> Daniel Henrique Barboza writes:
>>
>>> At this moment we only provide one event to report a hotunplug error,
>>> MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries
>>> machine is now able to rep
On 17/06/2021 10:47, Lei Rao wrote:
> From: "Rao, Lei"
>
> This patch fixed as follows:
> Thread 1 (Thread 0x7f34ee738d80 (LWP 11212)):
> #0 __pthread_clockjoin_ex (threadid=139847152957184,
> thread_return=0x7f30b1febf30, clockid=, abstime= out>, block=) at pthread_join_common.c:145
Hi,
> >> However, please correct me if I'm wrong, I understand that an accelerator
> >> as a
> >> module will add an overhead that some user won't be willing to pay. So,
> >> give
> >> them the option to have built-in accelerators seems a good idea.
> >
> > Modules add some overhead, yes, a
Valeriy Vdovin writes:
> Introducing new qapi method 'query-kvm-cpuid'. This method can be used to
It's actually a QMP command. There are no "qapi methods".
> get virtualized cpu model info generated by QEMU during VM initialization in
> the form of cpuid representation.
>
> Diving into more d
On Wed, Jun 16, 2021 at 10:43:28PM +0200, Philippe Mathieu-Daudé wrote:
> When building the 'microvm' machine stand-alone we get:
>
> $ qemu-system-x86_64 -M microvm
> **
> ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type !=
> NULL)
> Bail out! ERROR:qom/object.c:714:o
On Wed, Jun 16, 2021 at 10:43:27PM +0200, Philippe Mathieu-Daudé wrote:
> The 'microvm' machine misses various dependencies:
>
> /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in
> function `acpi_setup_microvm':
> hw/i386/acpi-microvm.c:247: undefined reference to `acpi_buil
On 16/06/2021 03.47, Eric Farman wrote:
Let's move this logic into its own routine,
so it can be reused later.
Signed-off-by: Eric Farman
---
hw/s390x/css.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index 8be21efb
在 2021/6/16 23:22, Peter Xu 写道:
On Wed, Jun 16, 2021 at 09:12:28AM +0800, huang...@chinatelecom.cn wrote:
diff --git a/include/exec/memory.h b/include/exec/memory.h
index b114f54..e31eef2 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -55,7 +55,11 @@ static inline void fuzz
> -Original Message-
> From: Markus Armbruster
> Sent: Wednesday, June 16, 2021 9:26 PM
> To: Zhang, Chen
> Cc: Lukas Straub ; Daniel P.Berrangé
> ; Li Zhijian ; Jason Wang
> ; qemu-dev ; Dr. David
> Alan Gilbert ; Gerd Hoffmann ;
> Zhang Chen ; Eric Blake
> Subject: Re: [PATCH V8 1/6]
From: "Rao, Lei"
When we first stated the COLO, the last-mode is as follows:
{ "execute": "query-colo-status" }
{"return": {"last-mode": "primary", "mode": "primary", "reason": "none"}}
The last-mode is unreasonable. After the patch, will be changed to the
following:
{ "execute": "query-colo-sta
From: "Rao, Lei"
This patch fixed as follows:
Thread 1 (Thread 0x7f34ee738d80 (LWP 11212)):
#0 __pthread_clockjoin_ex (threadid=139847152957184,
thread_return=0x7f30b1febf30, clockid=, abstime=,
block=) at pthread_join_common.c:145
#1 0x563401998e36 in qemu_thread_join (thread=0
From: "Rao, Lei"
When a PVM completed its SVM failover steps and begins to run in
the simplex mode, QEMU would encounter a 'Segmentation fault' if
the guest poweroff with the following calltrace:
Program received signal SIGSEGV, Segmentation fault.
This is because primary_vm_do_failover() would
From: "Rao, Lei"
Remove some unnecessary code to improve the performance of
the filter-rewriter module.
Signed-off-by: Lei Rao
---
net/colo-compare.c| 2 +-
net/colo.c| 31 ---
net/colo.h| 6 +++---
net/filter-rewriter.c | 10 +-
From: "Rao, Lei"
This patch fixes the following:
qemu-system-x86_64: invalid runstate transition: 'shutdown' -> 'running'
Aborted (core dumped)
The gdb bt as following:
0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
1 0x7faa3d613859 in __GI_abort () at abort.c:79
2
From: "Rao, Lei"
After the live migration, the related fd will be cleanup in
migration_incoming_state_destroy(). So, the qemu_close()
in colo_process_incoming_thread is not necessary.
Signed-off-by: Lei Rao
---
migration/colo.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/migration/
From: Rao, Lei
The series of patches include:
Fixed some bugs of qemu crash and segment fault.
Optimized the function of fill_connection_key.
Remove some unnecessary code to improve COLO.
Rao, Lei (7):
Some minor optimizations for COLO
Fixed qemu crash when guest powe
From: "Rao, Lei"
Signed-off-by: Lei Rao
---
migration/colo.c | 2 +-
net/colo-compare.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index 79fa1f6..616dc00 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -152,7 +152,7 @@ st
On 16/06/2021 20:26, BALATON Zoltan wrote:
On Wed, 16 Jun 2021, Alexey Kardashevskiy wrote:
On 6/16/21 07:09, BALATON Zoltan wrote:
On Tue, 15 Jun 2021, Alexey Kardashevskiy wrote:
The PAPR platform describes an OS environment that's presented by
a combination of a hypervisor and firmware.
This patch adds two QKeyCodes. The corresponding path for ui/keycodemapdb
is titled as "Add QEMU QKeyCode 'lang1' and 'lang2'". This patch should be
applied *before* applying the patch for ui/keycodemapdb, or it causes
build failures.
v1 -> v2:
- Documented the new QKeyCodes as available "since
lang1 and lang2 represents the keys with the same names in the
keyboard/keypad usage page (0x07) included in the "HID Usage Tables for
Universal Serial Bus (USB)" version 1.22. Although the keys are
described as "Hangul/English toggle key" and "Hanja conversion key" in
the specification, the meanin
-display gtk,monitor=
Signed-off-by: sweeaun
---
qapi/ui.json| 4 +++-
qemu-options.hx | 2 +-
ui/gtk.c| 15 +++
3 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/qapi/ui.json b/qapi/ui.json
index 1052ca9c38..1616f3ffbd 100644
--- a/qapi/ui.json
+++ b/qap
On 16/06/2021 20:34, BALATON Zoltan wrote:
On Wed, 16 Jun 2021, Alexey Kardashevskiy wrote:
On 6/15/21 20:29, BALATON Zoltan wrote:
On Tue, 15 Jun 2021, Alexey Kardashevskiy wrote:
The PAPR platform describes an OS environment that's presented by
a combination of a hypervisor and firmware.
We had a single ATOMIC_MMU_LOOKUP macro that probed for
read+write on all atomic ops. This is incorrect for
plain atomic load and atomic store.
For user-only, we rely on the host page permissions.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/390
Reviewed-by: Alex Bennée
Signed-off-by
This fixes some bugs reported against 128-bit atomic operations.
Just a note that the ppc insns that uses this, LQ and STQ, do not require
atomic operations if the address is unaligned, or if the address does not
resolve to ram. So for some things we are working harder than required.
I've also h
On Tue, Jun 15, 2021 at 06:12:02PM -0700, Richard Henderson wrote:
> Create and record the rt signal trampoline.
>
> Cc: Stafford Horne
> Signed-off-by: Richard Henderson
Reviewed-by: Stafford Horne
> ---
> linux-user/openrisc/target_signal.h | 2 ++
> linux-user/openrisc/signal.c|
On 6/16/21 2:42 PM, Philippe Mathieu-Daudé wrote:
To ease reviewing code using the I2C bus API, introduce the
i2c_start_recv() and i2c_start_send() helpers which don't
take the confusing 'is_recv' boolean argument.
Use these new helpers in the SMBus / AUX bus models.
Suggested-by: Richard Hende
On 6/16/21 2:42 PM, Philippe Mathieu-Daudé wrote:
+static int i2c_do_start_transfer(I2CBus *bus, uint8_t address,
+ enum i2c_event event)
{
I2CSlaveClass *sc;
I2CNode *node;
bool bus_scanned = false;
+assert(event == I2C_START_RECV || eve
On Thu, Jun 17, 2021 at 01:09:05AM +0200, BALATON Zoltan wrote:
> On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote:
> > On 6/16/21 10:01 PM, BALATON Zoltan wrote:
> > > On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote:
> > > > On 6/16/21 9:16 PM, Corey Minyard wrote:
> > > > > On Wed, Jun 16, 202
On 6/16/21 2:37 PM, Taylor Simpson wrote:
Yes, I'm confused. Why is signal frame unwinding in libgcc?
Because it's tied to the compiler, and it was a decent solution back in 1997.
I see llvm calls it libunwind, and only has special signal frame support for aarch64. I
wonder if ever other ta
On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote:
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: BALATON Zoltan
---
hw/display/sm501.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/display/sm501.c b/h
On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote:
On 6/16/21 10:01 PM, BALATON Zoltan wrote:
On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote:
On 6/16/21 9:16 PM, Corey Minyard wrote:
On Wed, Jun 16, 2021 at 06:14:11PM +0200, Philippe Mathieu-Daudé wrote:
Instead of using the confuse i2c_se
To allow further simplications, extract i2c_do_start_transfer()
from i2c_start_transfer(). This is mostly the same function,
but the former is static and takes an enum argument.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i2c/core.c | 14 --
1 file changed, 12 insertions(+), 2 delet
From: BALATON Zoltan
Make the argument representing the direction of the transfer a
boolean type.
Rename the boolean argument as 'is_recv' to match i2c_recv_send().
Document the function prototype.
Signed-off-by: BALATON Zoltan
Message-Id: <20200621145235.9e241745...@zero.eik.bme.hu>
[PMD: Spli
Other functions from I2C slave API are named "i2c_slave_XXX()".
Follow that pattern with set_address(). Add docstring along.
No logical change.
Patch created mechanically using:
$ sed -i s/i2c_set_slave_address/i2c_slave_set_address/ \
$(git grep -l i2c_set_slave_address)
Reviewed-by: Rich
To allow further simplifications in the following commits,
start copying WRITE_I2C code to the READ_I2C, and READ_I2C_MOT
to WRITE_I2C_MOT. No logical change.
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/auxbus.c | 53
Instead of using the confuse i2c_send_recv(), rewrite to directly
call i2c_recv() & i2c_send(), resulting in code easier to review.
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/sm501.c | 9 +
1 file changed, 5 insertions(+)
To ease reviewing code using the I2C bus API, introduce the
i2c_start_recv() and i2c_start_send() helpers which don't
take the confusing 'is_recv' boolean argument.
Use these new helpers in the SMBus / AUX bus models.
Suggested-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
in
Instead of using the confuse i2c_send_recv(), rewrite to directly
call i2c_recv() & i2c_send(), resulting in code easier to review.
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i2c/ppc4xx_i2c.c | 13 -
1 file changed, 8 inserti
Define TYPE_LM8323 in the public "hw/input/lm832x.h"
header and use it in hw/arm/nseries.c.
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/input/lm832x.h | 2 ++
hw/arm/nseries.c | 2 +-
hw/input/lm832x.c | 1 -
3 fi
We replaced all the i2c_send_recv() calls by the clearer i2c_recv()
and i2c_send(), so we can remove this confusing API.
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i2c/i2c.h | 1 -
hw/i2c/core.c| 50 +++--
Remove the 'is_write' boolean by directly using its value in place.
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/auxbus.c | 28 +++-
1 file changed, 11 insertions(+), 17 deletions(-)
diff --git a/hw/misc/auxbu
It took me a while to find this model datasheet, since it is
an OCR scan. Add a reference to save other developers time.
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i2c/ppc4xx_i2c.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw
lm832x_key_event() is specific go LM832x devices, not to the
I2C bus API. Move it out of "i2c.h" to a new header.
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/i2c/i2c.h | 3 ---
include/hw/input/lm832x.h | 26
Instead of using the confuse i2c_send_recv(), replace
i2c_send_recv(send = true) by i2c_send() and
i2c_send_recv(send = false) by i2c_recv().
During the replacement we also change a while() statement by for().
The resulting code is easier to review.
Reviewed-by: Richard Henderson
Acked-by: Co
Since its introduction in commit 6fc7f77fd2 i2c_start_transfer()
uses incorrectly the direction of the transfer (the last argument
is called 'is_recv'). Fix by inverting the argument, we now have
is_recv = !is_write.
Fixes: 6fc7f77fd2 ("introduce aux-bus")
Reported-by: BALATON Zoltan
Reviewed-by:
Reviewed-by: Richard Henderson
Acked-by: Corey Minyard
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/sm501.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 8789722ef27..f276276f7f1 100644
--- a/hw/display/sm501.c
+++
This is a respin of Zoltan's patch:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg714711.html
Patches 1-13 reviewed (could be queued)
Missing review: 14-15 (but optionals)
Since v3:
- addressed minor review comments from Richard/Corey
- added R-b/A-b tags
- implemented Richard suggestion
> -Original Message-
> From: Richard Henderson
> Sent: Wednesday, June 16, 2021 9:51 AM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: laur...@vivier.eu; alex.ben...@linaro.org
> Subject: Re: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp
>
> On 6/16/21 8:05 AM, Richard
Richard Henderson writes:
> We cannot use a raw sigtramp page for hppa,
> but must wait for full vdso support.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> linux-user/hppa/target_signal.h | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/linu
Hi Eric,
Have accepted all comments with responses inline (below):-
On Sun, 2021-06-13 at 18:26 +0200, Eric Auger wrote:
> Hi Shashi,
>
> On 6/2/21 8:00 PM, Shashi Mallela wrote:
> > Implemented lpi processing at redistributor to get lpi config info
> s/Implemented/Implement here are elsewhere.
pc_madt_cpu_entry() is specific to QEMU 'PC' machines,
move it to acpi-pc.c.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/acpi-common.c | 40
hw/i386/acpi-pc.c | 39 +++
2 files changed, 39 insertions(+), 40 de
Hi Eric,
Please find my responses inline (below):-
On Sun, 2021-06-13 at 16:13 +0200, Eric Auger wrote:
> Hi Sashi,
>
> On 6/2/21 8:00 PM, Shashi Mallela wrote:
> > Added functionality to trigger ITS command queue processing on
> > write to CWRITE register and process each command queue entry to
Move qmp_query_sev_launch_measure() from monitor.c to sev.c
and make sev_get_launch_measurement() static. We don't need the
stub anymore, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev_i386.h| 1 -
target/i386/monitor.c | 17 -
target/i386/s
Hi Eric,
Please find my responses inline (below):-
On Sun, 2021-06-13 at 17:55 +0200, Eric Auger wrote:
> Hi Shashi,
>
> On 6/2/21 8:00 PM, Shashi Mallela wrote:
> > Added ITS command queue handling for MAPTI,MAPI commands,handled
> > ITS
> > translation which triggers an LPI via INT command as
Hi Eric,
Please find my responses inline (below):-
On Sat, 2021-06-12 at 08:08 +0200, Eric Auger wrote:
>
> On 6/2/21 8:00 PM, Shashi Mallela wrote:
> > Defined descriptors for ITS device table,collection table and ITS
> > command queue entities.Implemented register read/write functions,
> > ext
The 'microvm' machine misses various dependencies:
/usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in function
`acpi_setup_microvm':
hw/i386/acpi-microvm.c:247: undefined reference to `acpi_build_tables_init'
/usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o:
Move qmp_query_sev_capabilities() from monitor.c to sev.c
and make sev_get_capabilities() static. We don't need the
stub anymore, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev_i386.h| 1 -
target/i386/monitor.c | 5 -
target/i386/sev-sysemu-stub.c | 4 +
ACPI core routines (in core.c) are not really x86-specific.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/acpi/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/meson.build b/hw/acpi/meson.build
index dd69577212a..c23c67f4283 100644
--- a/hw/acpi/meson.buil
We had a single ATOMIC_MMU_LOOKUP macro that probed for
read+write on all atomic ops. This is incorrect for
plain atomic load and atomic store.
For user-only, we rely on the host page permissions.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/390
Reviewed-by: Alex Bennée
Signed-off-by
Move qmp_sev_inject_launch_secret() from monitor.c to sev.c
and make sev_inject_launch_secret() static. We don't need the
stub anymore, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/monitor.c | 31 ---
target/i386/sev-sysemu-stub.c | 6 +++-
Signed-off-by: Philippe Mathieu-Daudé
---
include/monitor/hmp-target.h | 1 +
include/monitor/hmp.h | 1 -
target/i386/sev-sysemu-stub.c | 2 +-
target/i386/sev.c | 2 +-
4 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/monitor/hmp-target.h b/include/mon
When building the 'microvm' machine stand-alone we get:
$ qemu-system-x86_64 -M microvm
**
ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type != NULL)
Bail out! ERROR:qom/object.c:714:object_new_with_type: assertion failed:
(type != NULL)
Aborted (core dumped)
Looking
Move qmp_query_sev_attestation_report() from monitor.c to sev.c
and make sev_get_attestation_report() static. We don't need the
stub anymore, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev_i386.h| 2 --
target/i386/monitor.c | 6 --
target/i386/sev-sys
Introduce the X86_FW_OVMF Kconfig symbol for OVMF-specific code.
Move the OVMF-specific code from pc_sysfw.c to pc_sysfw_ovmf.c,
adding a pair of stubs.
Update MAINTAINERS to reach OVMF maintainers when these new
files are modified.
This fixes when building the microvm machine standalone:
/usr/
Move qmp_query_sev() & hmp_info_sev()() from monitor.c to sev.c
and make sev_get_info() static. We don't need the stub anymore,
remove it. Add a stub for hmp_info_sev().
Signed-off-by: Philippe Mathieu-Daudé
---
Note: what is left in sev_i386.h eventually belong to "sysemu/sev.h"
meaning we
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/acpi-common.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/i386/acpi-common.c b/hw/i386/acpi-common.c
index 1f5947fcf96..77afebd9e1f 100644
--- a/hw/i386/acpi-common.c
+++ b/hw/i386/acpi-common.c
@@ -21,15 +21,10 @@
*/
#include
SEV is irrelevant on user emulation, so restrict it to sysemu.
Some stubs are still required because used in cpu.c by
x86_register_cpudef_types(), so move the sysemu specific stubs
to sev-sysemu-stub.c instead. This will allow us to simplify
monitor.c (which is not available in user emulation) in t
The acpi-build.c file contains routines common to the QEMU "PC"
machines (Q35+ICH & i440FX+PIIX), rename it as acpi-pc.c.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/{acpi-build.c => acpi-pc.c} | 0
hw/i386/meson.build | 2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
If the management layer tries to inject a secret, it gets an empty
response in case the binary built without SEV:
{ "execute": "sev-inject-launch-secret",
"arguments": { "packet-header": "mypkt", "secret": "mypass", "gpa":
4294959104 }
}
{
"return": {
}
}
Make it clearer
From: "Dr. David Alan Gilbert"
Removes a whole bunch of g_free's and a goto.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Connor Kuehl
Reviewed-by: Brijesh Singh
Message-Id: <20210603113017.34922-1-dgilb...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev.c | 11 +
There is already a section with various SEV commands / types,
so move the SEV guest attestation together.
Signed-off-by: Philippe Mathieu-Daudé
---
qapi/misc-target.json | 81 +--
1 file changed, 40 insertions(+), 41 deletions(-)
diff --git a/qapi/misc-ta
Hi,
Here is the implementation for the remote blocking posix locks in
virtiofsd.
This patch series also addresses the issues that were not fixed in:
[Virtio-fs] [PATCH v2 0/5] [RFC] virtiofsd, vhost-user-fs: Add support
for notification queue
https://patchwork.kernel.org/project/qemu-devel/cover/
Commit 00b81053244 ("target-i386: Remove assert_no_error usage")
forgot to add the "qapi/error.h" for &error_abort, add it now.
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Connor Kuehl
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.c | 1 +
1 file changed, 1 insertion(+)
diff
The unique sev_encrypt_flash() invocation (in pc_system_flash_map)
is protected by the "if (sev_enabled())" check, so is not
reacheable.
Replace the abort() call in sev_es_save_reset_vector() by
g_assert_not_reached() which meaning is clearer.
Reviewed-by: Connor Kuehl
Signed-off-by: Philippe Mat
Wrap long lines before 70 characters for legibility.
Suggested-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
Note: it would be nice if checkpatch enforce 70 char for json
(or at least QAPI json), that would save future
developer modifying QAPI definitions reformatin
Stop virtiofsd thread from sending any notifications/messages through
the virtqueue while the guest hard-reboots.
If a guest attempts to hard reboot while a virtiofsd thread blocks
waiting for a lock held by another guest's virtiofsd process, then
QEMU will block the guest from rebooting until the
From: Connor Kuehl
It may not be appropriate for me to take over as a maintainer at this time,
but I would consider myself familiar with AMD SEV and what this code is
meant to be doing as part of a VMM for launching SEV-protected guests.
To that end, I would be happy to volunteer as a reviewer f
Unused dead code makes review harder, so remove it.
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Connor Kuehl
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev_i386.h | 1 -
target/i386/sev-stub.c | 5 -
target/i386/sev.c | 9 -
3 files changed, 15 deletions(-)
di
On 6/10/21 5:19 PM, Connor Kuehl wrote:
> On 6/10/21 1:45 AM, Philippe Mathieu-Daudé wrote:
>> Having the HMP/QMP commands defined in monitor.c makes the stubs
>> rather complicated when SEV is not built in. To simplify, move the
>> SEV functions to sev.c, and remove a layer of stubs.
>>
>> Also ma
Hi,
While testing James & Dov patch:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg810571.html
I wasted some time trying to figure out how OVMF was supposed to
behave until realizing the binary I was using was built without SEV
support... Then wrote this series to help other developers to
From: Vivek Goyal
We are emulating posix locks for guest using open file description locks
in virtiofsd. When any of the fd is closed in guest, we find associated
OFD lock fd (if there is one) and close it to release all the locks.
Assumption here is that there is no other thread using lo_inode_
Declarations don't require these headers, remove them.
Reviewed-by: Connor Kuehl
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/sev_i386.h | 4
target/i386/sev-stub.c | 1 +
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/target/i386/sev_i386.h b/target/i386/sev_i386.h
From: Vivek Goyal
Daemon specifies size of notification buffer needed and that should be
done using config space.
Only ->notify_buf_size value of config space comes from daemon. Rest of
it is filled by qemu device emulation code.
Signed-off-by: Vivek Goyal
Signed-off-by: Ioannis Angelakopoulos
Add a new custom threadpool using posix threads that specifically
service locking requests.
In the case of a fcntl(SETLKW) request, if the guest is waiting
for a lock or locks and issues a hard-reboot through SYSRQ then virtiofsd
unblocks the blocked threads by sending a signal to them and waking
From: Vivek Goyal
Add a notification queue which will be used to send async notifications
for file lock availability.
Signed-off-by: Vivek Goyal
Signed-off-by: Ioannis Angelakopoulos
---
hw/virtio/vhost-user-fs.c | 30 ++--
include/hw/virtio/vhost-user-fs.h | 2
From: Vivek Goyal
As of now we don't support fcntl(F_SETLKW) and if we see one, we return
-EOPNOTSUPP.
Change that by accepting these requests and returning a reply
immediately asking caller to wait. Once lock is available, send a
notification to the waiter indicating lock is available.
Signed-
On 6/16/21 10:01 PM, BALATON Zoltan wrote:
> On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote:
>> On 6/16/21 9:16 PM, Corey Minyard wrote:
>>> On Wed, Jun 16, 2021 at 06:14:11PM +0200, Philippe Mathieu-Daudé wrote:
Instead of using the confuse i2c_send_recv(), rewrite to directly
call i2
On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote:
On 6/16/21 8:46 PM, Richard Henderson wrote:
On 6/16/21 9:14 AM, Philippe Mathieu-Daudé wrote:
@@ -161,12 +157,11 @@ AUXReply aux_request(AUXBus *bus, AUXCommand
cmd, uint32_t address,
}
ret = AUX_I2C_ACK;
- while (
On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote:
On 6/16/21 9:16 PM, Corey Minyard wrote:
On Wed, Jun 16, 2021 at 06:14:11PM +0200, Philippe Mathieu-Daudé wrote:
Instead of using the confuse i2c_send_recv(), rewrite to directly
call i2c_recv() & i2c_send(), resulting in code easire to review.
MTE3 introduces an asymmetric tag checking mode, in which loads are
checked synchronously and stores are checked asynchronously. Add
support for it.
Signed-off-by: Peter Collingbourne
Reviewed-by: Richard Henderson
---
v2:
- remove unused argument
target/arm/cpu64.c | 2 +-
target/arm/mt
On Wed, Jun 16, 2021 at 06:14:05PM +0200, Philippe Mathieu-Daudé wrote:
> This is a respin of Zoltan's patch:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg714711.html
>
> Since v2, tried to address Corey's review comments resulting
> in a i2c_send_recv() removal and code easier to revie
On 6/16/21 8:46 PM, Richard Henderson wrote:
> On 6/16/21 9:14 AM, Philippe Mathieu-Daudé wrote:
>> @@ -161,12 +157,11 @@ AUXReply aux_request(AUXBus *bus, AUXCommand
>> cmd, uint32_t address,
>> }
>> ret = AUX_I2C_ACK;
>> - while (len > 0) {
>> - if (i2c_sen
On 6/16/21 9:16 PM, Corey Minyard wrote:
> On Wed, Jun 16, 2021 at 06:14:11PM +0200, Philippe Mathieu-Daudé wrote:
>> Instead of using the confuse i2c_send_recv(), rewrite to directly
>> call i2c_recv() & i2c_send(), resulting in code easire to review.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>
On 6/16/21 8:38 PM, Richard Henderson wrote:
> On 6/16/21 9:14 AM, Philippe Mathieu-Daudé wrote:
>> lm832x_key_event() is specific go LM832x devices, not to the
>> I2C bus API. Move it out of "i2c.h" to a new header.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> include/hw/i2c/i2c.h
On 6/16/21 9:12 PM, Richard Henderson wrote:
> On 6/16/21 9:22 AM, Philippe Mathieu-Daudé wrote:
>> Introduce the qcrypto_tls_creds_check_endpoint() helper
>> to avoid accessing QCryptoTLSCreds internal 'endpoint' field
>> directly.
>
> I don't understand this one. Comment ...
>
>> +bool qcrypto
On Tue, 15 Jun 2021 at 17:29, Alex Bennée wrote:
>
> Peter Maydell writes:
>
> > These days the Arm architecture has a wide range of fine-grained
> > optional extra architectural features. We implement quite a lot
> > of these but by no means all of them. Document what we do implement,
> > so tha
:
>
> https://git.linaro.org/people/pmaydell/qemu-arm.git
> tags/pull-target-arm-20210616
>
> for you to fetch changes up to 703235a303d6862a7e3f5c6aa9eff7471cb138b2:
>
> include/qemu/int128.h: Add function to create Int128 from int64_t
> (2021-06-16 14:33:52 +0100)
>
On Wed, Jun 16, 2021 at 06:14:11PM +0200, Philippe Mathieu-Daudé wrote:
> Instead of using the confuse i2c_send_recv(), rewrite to directly
> call i2c_recv() & i2c_send(), resulting in code easire to review.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/i2c/ppc4xx_i2c.c | 13 -
On Wed, Jun 16, 2021 at 06:14:09PM +0200, Philippe Mathieu-Daudé wrote:
> Instead of using the confuse i2c_send_recv(), rewrite to directly
> call i2c_recv() & i2c_send(), resulting in code easire to review.
^easier
>
> Signed-off-by: Philippe M
1 - 100 of 314 matches
Mail list logo
