Re: [PATCH v4] failover: unregister ROM on unplug

2021-07-21 Thread Laurent Vivier
On 21/07/2021 18:19, Michael S. Tsirkin wrote: > On Wed, Jul 21, 2021 at 06:09:05PM +0200, Laurent Vivier wrote: >> The intend of failover is to allow to migrate a VM with a VFIO >> networking card without disrupting the network operation by switching >> to a virtio-net device during the

Re: [PATCH v3 4/4] docs: Add documentation for vhost based RNG implementation

2021-07-21 Thread Alex Bennée
Mathieu Poirier writes: > Add description and example for the vhost-user based RNG implementation. > Tailored on Viresh Kumar's vhost-user-i2c documentation. > > Signed-off-by: Mathieu Poirier > --- > docs/tools/index.rst | 1 + > docs/tools/vhost-user-rng.rst | 74

Re: [PATCH] meson: fix dependencies for modinfo

2021-07-21 Thread Daniel P . Berrangé
On Wed, Jul 21, 2021 at 06:52:06PM +0200, Paolo Bonzini wrote: > modinfo runs the preprocessor and therefore needs all generated input files > to be there. Add a "depends" clause. > > Signed-off-by: Paolo Bonzini > --- > meson.build | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel

Re: [PATCH v2] target/i386: Added consistency checks for EFER

2021-07-21 Thread Paolo Bonzini
On 21/07/21 17:26, Lara Lazier wrote: EFER.SVME has to be set, and EFER reserved bits must be zero. In addition the combinations * EFER.LMA or EFER.LME is non-zero and the processor does not support LM * non-zero EFER.LME and CR0.PG and zero CR4.PAE * non-zero EFER.LME and CR0.PG and zero

[PATCH] meson: fix dependencies for modinfo

2021-07-21 Thread Paolo Bonzini
modinfo runs the preprocessor and therefore needs all generated input files to be there. Add a "depends" clause. Signed-off-by: Paolo Bonzini --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 8817706d08..18e6cb0a8c 100644 --- a/meson.build +++

Re: [PATCH for-6.1 v6 17/17] accel/tcg: Record singlestep_enabled in tb->cflags

2021-07-21 Thread Alex Bennée
Richard Henderson writes: > On 7/21/21 12:38 AM, Alex Bennée wrote: >> Richard Henderson writes: >> >>> Set CF_SINGLE_STEP when single-stepping is enabled. >>> This avoids the need to flush all tb's when turning >>> single-stepping on or off. >>> >>> Signed-off-by: Richard Henderson >>> ---

[PATCH] docs: convert writing-qmp-commands.txt to writing-qmp-commands.rst

2021-07-21 Thread John Snow
This does about the bare minimum, converting section headers to ReST ones and adding an indent for code blocks. Signed-off-by: John Snow --- docs/devel/index.rst | 1 + ...-commands.txt => writing-qmp-commands.rst} | 581 +- 2 files changed, 304

Re: [PATCH for-6.1] qemu-config: restore "machine" in qmp_query_command_line_options()

2021-07-21 Thread Paolo Bonzini
On 21/07/21 17:10, Stefan Hajnoczi wrote: Commit d8fb7d0969d5c32b3d1b9e20b63ec6c0abe80be4 ("vl: switch -M parsing to keyval") stopped adding the "machine" QemuOptsList. This causes "machine" options to not show up in QMP query-command-line-options output. For example, libvirt cannot detect that

Re: [PATCH for-6.1 v6 17/17] accel/tcg: Record singlestep_enabled in tb->cflags

2021-07-21 Thread Richard Henderson
On 7/21/21 12:38 AM, Alex Bennée wrote: Richard Henderson writes: Set CF_SINGLE_STEP when single-stepping is enabled. This avoids the need to flush all tb's when turning single-stepping on or off. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 1 + accel/tcg/cpu-exec.c

Re: [PULL v3 05/19] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-07-21 Thread Michael S. Tsirkin
On Wed, Jul 21, 2021 at 06:27:33PM +0200, Igor Mammedov wrote: > On Wed, 21 Jul 2021 12:09:01 -0400 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 21, 2021 at 05:49:16PM +0200, Laurent Vivier wrote: > > > On 21/07/2021 16:59, Igor Mammedov wrote: > > > > On Tue, 20 Jul 2021 14:56:06 +0200 > >

Re: [PULL v3 05/19] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-07-21 Thread Igor Mammedov
On Wed, 21 Jul 2021 12:09:01 -0400 "Michael S. Tsirkin" wrote: > On Wed, Jul 21, 2021 at 05:49:16PM +0200, Laurent Vivier wrote: > > On 21/07/2021 16:59, Igor Mammedov wrote: > > > On Tue, 20 Jul 2021 14:56:06 +0200 > > > Laurent Vivier wrote: > > > > > >> On 20/07/2021 13:38, Laurent

Re: [PATCH v5 10/10] ACPI ERST: step 6 of bios-tables-test.c

2021-07-21 Thread Eric DeVolder
On 7/20/21 8:24 AM, Igor Mammedov wrote: On Wed, 30 Jun 2021 15:07:21 -0400 Eric DeVolder wrote: Following the guidelines in tests/qtest/bios-tables-test.c, this is step 6, the re-generated ACPI tables binary blobs. looks like test case itself got lost somewhere along the way. I now

Re: [PATCH v4] failover: unregister ROM on unplug

2021-07-21 Thread Michael S. Tsirkin
On Wed, Jul 21, 2021 at 06:09:05PM +0200, Laurent Vivier wrote: > The intend of failover is to allow to migrate a VM with a VFIO > networking card without disrupting the network operation by switching > to a virtio-net device during the migration. > > This simple change allows to test failover

Re: [PATCH v5 09/10] ACPI ERST: qtest for ERST

2021-07-21 Thread Eric DeVolder
On 7/20/21 8:38 AM, Igor Mammedov wrote: On Wed, 30 Jun 2021 15:07:20 -0400 Eric DeVolder wrote: This change provides a qtest that locates and then does a simple interrogation of the ERST feature within the guest. Signed-off-by: Eric DeVolder --- tests/qtest/erst-test.c | 129

Re: [PATCH v4] failover: unregister ROM on unplug

2021-07-21 Thread Philippe Mathieu-Daudé
On 7/21/21 6:09 PM, Laurent Vivier wrote: > The intend of failover is to allow to migrate a VM with a VFIO > networking card without disrupting the network operation by switching > to a virtio-net device during the migration. > > This simple change allows to test failover with a simulated device

Re: [PATCH v5 08/10] ACPI ERST: create ACPI ERST table for pc/x86 machines.

2021-07-21 Thread Eric DeVolder
On 7/20/21 8:19 AM, Igor Mammedov wrote: On Wed, 30 Jun 2021 15:07:19 -0400 Eric DeVolder wrote: This change exposes ACPI ERST support for x86 guests. Signed-off-by: Eric DeVolder looks good to me, maybe move find_erst_dev() impl. here as well if it's the patch it's first used. I've

Re: [PATCH v5 07/10] ACPI ERST: trace support

2021-07-21 Thread Eric DeVolder
On 7/20/21 8:15 AM, Igor Mammedov wrote: On Wed, 30 Jun 2021 15:07:18 -0400 Eric DeVolder wrote: Provide the definitions needed to support tracing in ACPI ERST. trace points should be introduced in patches that use them for the first time, as it stands now series breaks bisection. Are

Re: [PATCH v5 06/10] ACPI ERST: build the ACPI ERST table

2021-07-21 Thread Eric DeVolder
On 7/20/21 8:16 AM, Igor Mammedov wrote: On Wed, 30 Jun 2021 15:07:17 -0400 Eric DeVolder wrote: This code is called from the machine code (if ACPI supported) to generate the ACPI ERST table. should be along lines: This builds ACPI ERST table /spec ref/ to inform OSMP how to communicate

Re: [PULL for-6.1 0/3] Block patches

2021-07-21 Thread Peter Maydell
On Wed, 21 Jul 2021 at 14:13, Stefan Hajnoczi wrote: > > The following changes since commit 801f3db7564dcce8a37a70833c0abe40ec19f8ce: > > Merge remote-tracking branch 'remotes/philmd/tags/kconfig-20210720' into > staging (2021-07-20 19:30:28 +0100) > > are available in the Git repository at: >

[PATCH v4] failover: unregister ROM on unplug

2021-07-21 Thread Laurent Vivier
The intend of failover is to allow to migrate a VM with a VFIO networking card without disrupting the network operation by switching to a virtio-net device during the migration. This simple change allows to test failover with a simulated device like e1000e rather than a vfio device, even if it's

Re: [PULL v3 05/19] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-07-21 Thread Michael S. Tsirkin
On Wed, Jul 21, 2021 at 05:49:16PM +0200, Laurent Vivier wrote: > On 21/07/2021 16:59, Igor Mammedov wrote: > > On Tue, 20 Jul 2021 14:56:06 +0200 > > Laurent Vivier wrote: > > > >> On 20/07/2021 13:38, Laurent Vivier wrote: > >>> On 16/07/2021 17:15, Michael S. Tsirkin wrote: > From:

Re: [PULL v3 05/19] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-07-21 Thread Philippe Mathieu-Daudé
On 7/21/21 4:59 PM, Igor Mammedov wrote: > On Tue, 20 Jul 2021 14:56:06 +0200 > Laurent Vivier wrote: >> On 20/07/2021 13:38, Laurent Vivier wrote: >>> On 16/07/2021 17:15, Michael S. Tsirkin wrote: From: Julia Suvorova Q35 has three different types of PCI devices hot-plug: PCIe

Re: [PATCH v5 05/10] ACPI ERST: support for ACPI ERST feature

2021-07-21 Thread Eric DeVolder
On 7/20/21 7:17 AM, Igor Mammedov wrote: On Wed, 30 Jun 2021 15:07:16 -0400 Eric DeVolder wrote: This change implements the support for the ACPI ERST feature. Drop this Done This implements a PCI device for ACPI ERST. This implments the s/implments/implements/ Corrected

Re: [PATCH 2/5] migration: Shutdown src in await_return_path_close_on_source()

2021-07-21 Thread Daniel P . Berrangé
On Wed, Jul 21, 2021 at 10:55:00AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > We have a logic in await_return_path_close_on_source() that we will > > explicitly > > shutdown the socket when migration encounters errors. However it could be > > racy > >

Re: [PULL v3 05/19] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-07-21 Thread Laurent Vivier
On 21/07/2021 16:59, Igor Mammedov wrote: > On Tue, 20 Jul 2021 14:56:06 +0200 > Laurent Vivier wrote: > >> On 20/07/2021 13:38, Laurent Vivier wrote: >>> On 16/07/2021 17:15, Michael S. Tsirkin wrote: From: Julia Suvorova Q35 has three different types of PCI devices hot-plug:

Re: [PATCH 2/5] migration: Shutdown src in await_return_path_close_on_source()

2021-07-21 Thread Peter Xu
On Wed, Jul 21, 2021 at 10:55:00AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > We have a logic in await_return_path_close_on_source() that we will > > explicitly > > shutdown the socket when migration encounters errors. However it could be > > racy > >

Re: [PATCH 5/5] migration: Move the yank unregister of channel_close out

2021-07-21 Thread Peter Xu
On Wed, Jul 21, 2021 at 11:39:37AM +0100, Dr. David Alan Gilbert wrote: > > +/* > > + * Return the ioc object if it's a migration channel. Note: it can return > > NULL > > + * for callers passing in a non-migration qemufile. E.g. see > > qemu_fopen_bdrv() > > + * and its usage in e.g.

Re: [PATCH v5 03/10] ACPI ERST: PCI device_id for ERST

2021-07-21 Thread Eric DeVolder
On 7/19/21 10:06 AM, Igor Mammedov wrote: On Wed, 30 Jun 2021 15:07:14 -0400 Eric DeVolder wrote: This change declares the PCI device_id for the new ACPI ERST s/This change declares/Reserve/ Corrected device. Signed-off-by: Eric DeVolder --- include/hw/pci/pci.h | 1 + 1 file

Re: [PATCH v5 02/10] ACPI ERST: specification for ERST support

2021-07-21 Thread Eric DeVolder
On 7/19/21 10:02 AM, Igor Mammedov wrote: On Wed, 30 Jun 2021 19:26:39 + Eric DeVolder wrote: Oops, at the end of the 4th paragraph, I meant to state that "Linux does not support the NVRAM mode." rather than "non-NVRAM mode", which contradicts everything I stated prior. Eric.

Re: [PATCH] failover: unregister ram on unplug

2021-07-21 Thread Philippe Mathieu-Daudé
On 7/21/21 12:49 PM, Laurent Vivier wrote: > On 21/07/2021 12:41, Michael S. Tsirkin wrote: >> On Wed, Jul 21, 2021 at 10:58:17AM +0200, Igor Mammedov wrote: >>> On Tue, 20 Jul 2021 20:16:44 +0200 >>> Laurent Vivier wrote: >>> This simple change allows to test failover with a simulated

[PATCH v2] target/i386: Added consistency checks for EFER

2021-07-21 Thread Lara Lazier
EFER.SVME has to be set, and EFER reserved bits must be zero. In addition the combinations * EFER.LMA or EFER.LME is non-zero and the processor does not support LM * non-zero EFER.LME and CR0.PG and zero CR4.PAE * non-zero EFER.LME and CR0.PG and zero CR0.PE * non-zero EFER.LME, CR0.PG,

[PATCH v2] target/i386: Added consistency checks for CR4

2021-07-21 Thread Lara Lazier
All MBZ bits in CR4 must be zero. (APM2 15.5) Added reserved bitmask and added checks in both helper_vmrun and helper_write_crN. Signed-off-by: Lara Lazier --- target/i386/cpu.h| 31 target/i386/tcg/sysemu/misc_helper.c | 3 +++

Re: [PATCH v5 00/10] acpi: Error Record Serialization Table, ERST, support for QEMU

2021-07-21 Thread Eric DeVolder
On 7/20/21 9:57 AM, Igor Mammedov wrote: On Wed, 30 Jun 2021 15:07:11 -0400 Eric DeVolder wrote: = I believe I have corrected for all feedback on v4, but with responses to certain feedback below. In patch 1/6, Igor asks: "you are adding empty template files

[PATCH] target/i386: Added V_INTR_PRIO check to virtual interrupts

2021-07-21 Thread Lara Lazier
The APM2 states that The processor takes a virtual INTR interrupt if V_IRQ and V_INTR_PRIO indicate that there is a virtual interrupt pending whose priority is greater than the value in V_TPR. Signed-off-by: Lara Lazier --- target/i386/tcg/sysemu/svm_helper.c | 12 +++- 1 file changed,

Re: [PATCH v5 00/10] acpi: Error Record Serialization Table, ERST, support for QEMU

2021-07-21 Thread Eric DeVolder
On 7/13/21 3:38 PM, Michael S. Tsirkin wrote: On Wed, Jun 30, 2021 at 03:07:11PM -0400, Eric DeVolder wrote: = I believe I have corrected for all feedback on v4, but with responses to certain feedback below. In patch 1/6, Igor asks: "you are adding empty template

[PATCH for-6.1] qemu-config: restore "machine" in qmp_query_command_line_options()

2021-07-21 Thread Stefan Hajnoczi
Commit d8fb7d0969d5c32b3d1b9e20b63ec6c0abe80be4 ("vl: switch -M parsing to keyval") stopped adding the "machine" QemuOptsList. This causes "machine" options to not show up in QMP query-command-line-options output. For example, libvirt cannot detect that kernel_irqchip support is available. Adjust

Re: vulkan support in qemu with virgil

2021-07-21 Thread Gerd Hoffmann
On Wed, Jul 21, 2021 at 03:09:21PM +0200, Tomeu Vizoso wrote: > Hi all, > > At Collabora we have started looking at Vulkan support in QEMU with Virgil. > > We have seen the work that Vivek has submitted to support the new virtio-gpu > BLOB API (thanks!) and have identified a few holes that are

Re: [PATCH v1 27/29] gitlab: enable a very minimal build with the tricore container

2021-07-21 Thread Willian Rampazzo
On Tue, Jul 20, 2021 at 8:34 PM Alex Bennée wrote: > > Rather than base of the shared Debian 10 container which would require > us to bring in even more dependencies just bring in what is needed for > building tricore-softmmu in GitLab. We don't even remove the container > from the

Re: [PULL v3 05/19] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-07-21 Thread Igor Mammedov
On Tue, 20 Jul 2021 14:56:06 +0200 Laurent Vivier wrote: > On 20/07/2021 13:38, Laurent Vivier wrote: > > On 16/07/2021 17:15, Michael S. Tsirkin wrote: > >> From: Julia Suvorova > >> > >> Q35 has three different types of PCI devices hot-plug: PCIe Native, > >> SHPC Native and ACPI hot-plug.

Re: [PATCH 2/2] qom: use correct field name when getting/setting alias properties

2021-07-21 Thread Markus Armbruster
Paolo Bonzini writes: > On 20/07/21 03:00, Eric Blake wrote: >> Deceptively simple; all the work was in the previous patch writing up >> the forwarding visitor. I still wonder if Kevin's QAPI aliases will >> do this more gracefully, but if we're trying to justify this as a bug >> fix worthy of

[Bug 1890160] Re: Abort in vmxnet3_validate_queues

2021-07-21 Thread Thomas Huth
Suggested fix: https://lore.kernel.org/qemu-devel/20210721141559.3647945-1-th...@redhat.com/ ** Changed in: qemu Status: Confirmed => In Progress ** Changed in: qemu Assignee: (unassigned) => Thomas Huth (th-huth) -- You received this bug notification because you are a member of

Re: [RFC] Fix rocker device null pointer crash. qemu config r->fp_ports with "-device rocker, len-ports=10" when guest config port larget then r->fp_ports(10) r->fp_port[port] is null-pointer, qemu wi

2021-07-21 Thread Peter Maydell
On Wed, 21 Jul 2021 at 15:23, NAME wrote: > > From: sohu0106 Hi; you seem to have a misformatted commit message here -- everything has ended up in the Subject line. The first line of the commit should be a short summary, usually preceded by an indication of the area of the code being fixed,

[RFC] Fix rocker device null pointer crash. qemu config r->fp_ports with "-device rocker, len-ports=10" when guest config port larget then r->fp_ports(10) r->fp_port[port] is null-pointer, qemu will c

2021-07-21 Thread NAME
From: sohu0106 Signed-off-by: sohu0106 --- hw/net/rocker/rocker.c| 10 +- hw/net/rocker/rocker_fp.c | 5 +++-- hw/net/rocker/rocker_fp.h | 2 +- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c index

[PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-21 Thread Ani Sinha
All existing code using acpi_get_i386_pci_host() checks for a non-null return from this function call. This change brings the same check to acpi_pcihp_disable_root_bus() function. Also adds a comment describing why we unconditionally pass a truth value to the last argument when calling

[PATCH] hw/net/vmxnet3: Do not abort QEMU if guest specified bad queue numbers

2021-07-21 Thread Thomas Huth
QEMU should never terminate unexpectedly just because the guest is doing something wrong like specifying wrong queue numbers. Let's simply refuse to set the device active in this case. Buglink: https://bugs.launchpad.net/qemu/+bug/1890160 Signed-off-by: Thomas Huth --- hw/net/vmxnet3.c | 34

Re: [PATCH 2/2] Revert "qxl: add migration blocker to avoid pre-save assert"

2021-07-21 Thread Markus Armbruster
Gerd Hoffmann writes: > This reverts commit 86dbcdd9c7590d06db89ca256c5eaf0b4aba8858. > > The pre-save assert is gone now, so the migration blocker > is not needed any more. > > Signed-off-by: Gerd Hoffmann > --- > hw/display/qxl.h | 1 - > hw/display/qxl.c | 31

Re: [PATCH 07/16] vfio: Avoid error_propagate() after migrate_add_blocker()

2021-07-21 Thread Markus Armbruster
Paolo Bonzini writes: > On 20/07/21 14:53, Markus Armbruster wrote: >> When migrate_add_blocker(blocker, ) is followed by > > Just a nit, Wll fix, thanks! > Paolo > >> error_propagate(errp, err), we can often just as well do >> migrate_add_blocker(..., errp). This is the case in >>

Re: [PATCH 10/16] migration: Handle migration_incoming_setup() errors consistently

2021-07-21 Thread Markus Armbruster
Eric Blake writes: > On Tue, Jul 20, 2021 at 02:54:02PM +0200, Markus Armbruster wrote: >> Commit b673eab4e2 "multifd: Make multifd_load_setup() get an Error >> parameter" changed migration_incoming_setup() to take an Error ** >> argument, and adjusted the callers accordingly. It neglected to

Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-21 Thread Ani Sinha
Please scratch this. I will resend with my nokia email removed. This work does not involve Nokia. Ani On Wed, 21 Jul 2021, Ani Sinha wrote: > From: Ani Sinha > > All existing code using acpi_get_i386_pci_host() checks for a non-null > return from this function call. This change brings the

[PATCH v2 3/6] block: share writes on backing child of fleecing node

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
By default, we share writes on backing child only if our parents share write permission on us. Still, with fleecing scheme we want to be able to unshare writes on fleecing node, which is a kind of immutable snapshot (copy-before-write operations are write-unchanged). So, let's detect fleecing

[PATCH v2 6/6] iotests/image-fleecing: test push backup with fleecing

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
Add test for push backup with fleecing: - start fleecing with copy-before-write filter - start a backup job from temporary fleecing node to actual backup target Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/image-fleecing | 105 +++-

[PATCH v2 5/6] qapi: backup: add immutable-source paramter

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
We are on the way to implement internal-backup with fleecing scheme, which includes backup job copying from temporary node (which is target of copy-before-write filter) to final target of backup. This job doesn't need own filter, as temporary node is a kind of snapshot, it's immutable. Let's add

[PATCH v2 for-6.2 0/6] push backup with fleecing

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is push-backup with fleecing. What is it: 1. Make fleecing scheme guest blk | |root v copy-before-write filter ---> temp qcow2 | | |file | backing V | active disk

[PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-21 Thread Ani Sinha
From: Ani Sinha All existing code using acpi_get_i386_pci_host() checks for a non-null return from this function call. This change brings the same check to acpi_pcihp_disable_root_bus() function. Also adds a comment describing why we unconditionally pass a truth value to the last argument when

[PATCH v2 2/6] block/copy-before-write: require BLK_PERM_WRITE_UNCHANGED for fleecing

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
Now block-copy detects fleecing scheme and do write-unchanged operations if detected. So, let's require appropriate permissions. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-before-write.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[PATCH v2 4/6] block: blk_root(): return non-const pointer

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
In the following patch we'll want to pass blk children to block-copy. Const pointers are not enough. So, return non const pointer from blk_root(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/sysemu/block-backend.h | 2 +- block/block-backend.c | 2 +- 2 files changed, 2

[PATCH v2 1/6] block/block-copy: use write-unchanged for fleecing scheme

2021-07-21 Thread Vladimir Sementsov-Ogievskiy
We are going to use fleecing scheme for push-backup, so that copy-before-write filter does copy before write operations to temporary image and backup job copies data from (immutable from backup's point of view) temporary image to actual backup target. For this to work properly, backup job should

Re: [PATCH v3] failover: unregister ROM on unplug

2021-07-21 Thread Philippe Mathieu-Daudé
On 7/21/21 3:45 PM, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert" wrote: >>> * Laurent Vivier (lviv...@redhat.com) wrote: The intend of failover is to allow to migrate a VM with a VFIO networking card without disrupting the

Re: [PATCH] qom/object.c 'if (type_table == NULL)' statement is redundant , delete it.

2021-07-21 Thread Daniel P . Berrangé
On Wed, Jul 21, 2021 at 05:55:44PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Jul 21, 2021 at 5:22 PM zhuguanghong > wrote: > > > Signed-off-by: zhuguanghong > > --- > > qom/object.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/qom/object.c

Re: [PATCH v3] failover: unregister ROM on unplug

2021-07-21 Thread Juan Quintela
Laurent Vivier wrote: > The intend of failover is to allow to migrate a VM with a VFIO > networking card without disrupting the network operation by switching > to a virtio-net device during the migration. > > This simple change allows to test failover with a simulated device > like e1000e rather

Re: [PATCH] qom/object.c 'if (type_table == NULL)' statement is redundant , delete it.

2021-07-21 Thread Marc-André Lureau
Hi On Wed, Jul 21, 2021 at 5:22 PM zhuguanghong wrote: > Signed-off-by: zhuguanghong > --- > qom/object.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/qom/object.c b/qom/object.c > index 6a01d56546..c8f5481afe 100644 > --- a/qom/object.c > +++ b/qom/object.c >

Re: [PATCH for-6.2 v2 00/11] machine: smp parsing fixes and improvement

2021-07-21 Thread Pankaj Gupta
> > On Mon, Jul 19 2021, Yanan Wang wrote: > > > >> Hi, > >> > >> This is v2 of the series [1] that I have posted to introduce some smp > >> parsing > >> fixes and improvement, much more work has been processed compared to RFC > >> v1. > >> > >> [1]

Re: [PATCH] chardev/socket: print a more correct command-line address

2021-07-21 Thread Philippe Mathieu-Daudé
On 7/21/21 3:04 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Better reflect the command line version of the socket address arguments, > following the now recommended long-form opt=on syntax. > > Complement/fixes commit 9d902d51 "chardev: do not use short form boolean >

Re: [PATCH v3] failover: unregister ROM on unplug

2021-07-21 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Laurent Vivier (lviv...@redhat.com) wrote: > >> The intend of failover is to allow to migrate a VM with a VFIO > >> networking card without disrupting the network operation by switching > >> to a virtio-net

Re: [PATCH v3] failover: unregister ROM on unplug

2021-07-21 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Laurent Vivier (lviv...@redhat.com) wrote: >> The intend of failover is to allow to migrate a VM with a VFIO >> networking card without disrupting the network operation by switching >> to a virtio-net device during the migration. >> >> This simple change

Re: [PATCH v1 02/29] docs: collect the disparate device emulation docs into one section

2021-07-21 Thread Markus Armbruster
Alex Bennée writes: > While we are at it add a brief preamble that explains some of the > common concepts in QEMU's device emulation which will hopefully lead > to less confusing about our dizzying command line options. > > Signed-off-by: Alex Bennée > Message-Id:

Re: [RFC 3/3] qom: Improve error message in module_object_class_by_name()

2021-07-21 Thread Jose R. Ziviani
On Wed, Jul 21, 2021 at 10:57:37AM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 21, 2021 at 11:54:45AM +0200, Gerd Hoffmann wrote: > > > ObjectClass *module_object_class_by_name(const char *typename) > > > { > > > ObjectClass *oc; > > > @@ -1031,8 +1049,20 @@ ObjectClass

Re: [PATCH 0/1]

2021-07-21 Thread Jose R. Ziviani
On Wed, Jul 21, 2021 at 07:24:02AM +0200, Thomas Huth wrote: > On 21/07/2021 00.13, Jose R. Ziviani wrote: > > Hello! > > > > This patch gives the ability to build TCG builtin even if > > --enable-modules is selected. This is useful to have a base > > QEMU with TCG native product but still using

[PATCH v4 3/3] target/ppc: moved store_40x_sler to helper_regs.c

2021-07-21 Thread Lucas Mateus Castro (alqotel)
moved store_40x_sler from mmu_common.c to helper_regs.c as it was more appropriate Signed-off-by: Lucas Mateus Castro (alqotel) --- target/ppc/helper_regs.c | 12 target/ppc/mmu_common.c | 10 -- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git

[PATCH v4 2/3] target/ppc: moved ppc_store_sdr1 to mmu_common.c

2021-07-21 Thread Lucas Mateus Castro (alqotel)
ppc_store_sdr1 was at first in mmu_helper.c and was moved as part the patches to enable the disable-tcg option, now it's being moved back to a file that will be compiled with that option Signed-off-by: Lucas Mateus Castro (alqotel) --- target/ppc/cpu.c| 28

[PATCH v4 0/3] target/ppc: MMU clean up

2021-07-21 Thread Lucas Mateus Castro (alqotel)
This patch series aims to clean up some of the code mmu_helper.c, including removing the #includes inside ifdef. This version of the patch has been rebased on the current ppc-for-6.2 branch as adapted accordingly. v4: Moved functions declarations from cpu.h to internal.h when possible. Comments

Re: [PATCH] chardev/socket: print a more correct command-line address

2021-07-21 Thread Daniel P . Berrangé
On Wed, Jul 21, 2021 at 05:04:53PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Better reflect the command line version of the socket address arguments, > following the now recommended long-form opt=on syntax. > > Complement/fixes commit 9d902d51 "chardev: do not use

[PATCH v4 1/3] target/ppc: divided mmu_helper.c in 2 files

2021-07-21 Thread Lucas Mateus Castro (alqotel)
Divided mmu_helper.c in 2 files, functions inside #ifdef CONFIG_SOFTMMU stayed in mmu_helper.c, other functions moved to mmu_common.c. Updated meson.build to compile mmu_common.c and only compile mmu_helper.c when CONFIG_TCG is set. Moved function declarations, #define and structs used by both

[PATCH] hw/char/virtio-serial-bus: fix: Unpop throttled VirtQueueElement to queue before discard vq data

2021-07-21 Thread AIERPATIJIANG1 [艾尔帕提江·阿布都赛买提]
Ports enter a "throttled" state when writing to the chardev would block. The current output VirtQueueElement is kept around until the chardev becomes writable again. Because closing the virtio serial device does not reset the queue, we cannot directly discard this element, otherwise the control

[PATCH] qom/object.c 'if (type_table == NULL)' statement is redundant , delete it.

2021-07-21 Thread zhuguanghong
Signed-off-by: zhuguanghong --- qom/object.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qom/object.c b/qom/object.c index 6a01d56546..c8f5481afe 100644 --- a/qom/object.c +++ b/qom/object.c @@ -78,9 +78,7 @@ static GHashTable *type_table_get(void) { static

[PATCH RFC]Fix rocker device null-pointer crash.

2021-07-21 Thread sohu0106
From 503b08d3b8d8faa93c3f5d2bc9eb8b52a7772b85 Mon Sep 17 00:00:00 2001 From: sohu0106 Date: Wed, 21 Jul 2021 10:07:07 +0800 Subject: [RFC] Fix rocker device null pointer crash. qemu config r->fp_ports with "-device rocker,len-ports=10" when guest config port larget then r->fp_ports(10)

[PATCH] hw/i386: fix phys-bits on cpus with AMD SEV/SMD

2021-07-21 Thread Jörg Thalheim
On AMD machines with SEV/SMD the physical address space needs to be reduced by a number of bits. Linux does this correctly and shows this information in /proc/cpuinfo. CPUID set by qemu however reports too big physical addresses i.e. 48 bit instead of 43. This patch has been tested on both Intel

[PULL for-6.1 2/3] iothread: add aio-max-batch parameter

2021-07-21 Thread Stefan Hajnoczi
From: Stefano Garzarella The `aio-max-batch` parameter will be propagated to AIO engines and it will be used to control the maximum number of queued requests. When there are in queue a number of requests equal to `aio-max-batch`, the engine invokes the system call to forward the requests to the

Re: [PATCH for-6.1? v2 0/3] linux-aio: limit the batch size to reduce queue latency

2021-07-21 Thread Stefan Hajnoczi
On Wed, Jul 21, 2021 at 11:42:08AM +0200, Stefano Garzarella wrote: > Since it's a performance regression, if possible we could include it in > 6.1-rc1. > There shouldn't be any particular criticism. > > v1: https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01526.html > v2: > -

[PULL for-6.1 3/3] linux-aio: limit the batch size using `aio-max-batch` parameter

2021-07-21 Thread Stefan Hajnoczi
From: Stefano Garzarella When there are multiple queues attached to the same AIO context, some requests may experience high latency, since in the worst case the AIO engine queue is only flushed when it is full (MAX_EVENTS) or there are no more queues plugged. Commit 2558cb8dd4 ("linux-aio:

[PULL for-6.1 1/3] iothread: generalize iothread_set_param/iothread_get_param

2021-07-21 Thread Stefan Hajnoczi
From: Stefano Garzarella Changes in preparation for next patches where we add a new parameter not related to the poll mechanism. Let's add two new generic functions (iothread_set_param and iothread_get_param) that we use to set and get IOThread parameters. Signed-off-by: Stefano Garzarella

[PULL for-6.1 0/3] Block patches

2021-07-21 Thread Stefan Hajnoczi
The following changes since commit 801f3db7564dcce8a37a70833c0abe40ec19f8ce: Merge remote-tracking branch 'remotes/philmd/tags/kconfig-20210720' into staging (2021-07-20 19:30:28 +0100) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request

vulkan support in qemu with virgil

2021-07-21 Thread Tomeu Vizoso
Hi all, At Collabora we have started looking at Vulkan support in QEMU with Virgil. We have seen the work that Vivek has submitted to support the new virtio-gpu BLOB API (thanks!) and have identified a few holes that are still needed for Vulkan support. We would like to know if anybody else

Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP

2021-07-21 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Jul 20, 2021 at 02:42:12PM -0500, Michael Roth wrote: >> On Tue, Jul 13, 2021 at 03:46:19PM +0200, Markus Armbruster wrote: [...] >> > I recommend to do exactly what we've done before for complex >> > configuration: define it in the QAPI schema, so we can

Re: [PULL for 6.1 0/7] Python and Acceptance Tests

2021-07-21 Thread Peter Maydell
On Wed, 21 Jul 2021 at 00:30, Cleber Rosa wrote: > > The following changes since commit c04b4d9e6b596ead3cf6046a9243fbfee068ef33: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2021-07-20 16:59:33 +0100) > > are available in the Git repository at: > >

[Bug 1796520] Re: autogen crashes on qemu-sh4-user after 61dedf2af7

2021-07-21 Thread John Paul Adrian Glaubitz
The patch suggested by Thorsten Glaser glibc Bugzilla #27543 fixes the issue for me: > https://sourceware.org/bugzilla/show_bug.cgi?id=27543#c2 ** Bug watch added: Sourceware.org Bugzilla #27543 https://sourceware.org/bugzilla/show_bug.cgi?id=27543 -- You received this bug notification

[PATCH] chardev/socket: print a more correct command-line address

2021-07-21 Thread marcandre . lureau
From: Marc-André Lureau Better reflect the command line version of the socket address arguments, following the now recommended long-form opt=on syntax. Complement/fixes commit 9d902d51 "chardev: do not use short form boolean options in non-QemuOpts character device descriptions".

Re: [PATCH for-6.2 v2 00/11] machine: smp parsing fixes and improvement

2021-07-21 Thread wangyanan (Y)
On 2021/7/20 0:57, Cornelia Huck wrote: On Mon, Jul 19 2021, Yanan Wang wrote: Hi, This is v2 of the series [1] that I have posted to introduce some smp parsing fixes and improvement, much more work has been processed compared to RFC v1. [1]

Re: [PATCH for 6.1 1/2] ui/gtk: add a keyboard fifo to the VTE consoles

2021-07-21 Thread Gerd Hoffmann
Hi, > +static void gd_vc_send_chars(VirtualConsole *vc) > +{ > +uint32_t len, avail; > +const uint8_t *buf; > + > +len = qemu_chr_be_can_write(vc->vte.chr); > +avail = fifo8_num_used(>vte.out_fifo); > +if (len > avail) { > +len = avail; > +} > +while (len >

Re: [PATCH for-6.2 v2 01/11] machine: Disallow specifying topology parameters as zero

2021-07-21 Thread wangyanan (Y)
On 2021/7/20 0:46, Daniel P. Berrangé wrote: On Mon, Jul 19, 2021 at 11:20:33AM +0800, Yanan Wang wrote: In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU will calculate its value.

Re: [PATCH for-6.2 v2 01/11] machine: Disallow specifying topology parameters as zero

2021-07-21 Thread wangyanan (Y)
On 2021/7/20 0:11, Andrew Jones wrote: On Mon, Jul 19, 2021 at 11:20:33AM +0800, Yanan Wang wrote: In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it omitted and QEMU will calculate its value.

Re: [PATCH 5/6] tests/acceptance/virtio-gpu.py: use virtio-vga-gl

2021-07-21 Thread Gerd Hoffmann
On Wed, Jul 14, 2021 at 01:40:50PM -0400, Cleber Rosa wrote: > Since 49afbca3b, the use of an optional virgl renderer is not > available anymore, and since b36eb8860f, the way to choose a GL based > rendered is to use the "virtio-vga-gl" device. > > Signed-off-by: Cleber Rosa > --- >

Re: [PATCH 0/2] qapi/qom: use correct field name when getting/setting alias properties

2021-07-21 Thread Paolo Bonzini
On 20/07/21 17:54, Markus Armbruster wrote: First, let me describe what's wrong in my own words, because that's how I understand stuff. [snip] All correct. Next, the solution. I get the idea of a wrapper visitor which gives you "pflash0" when you ask for "drive", but oh boy do I wish we

Re: [PATCH v3 3/4] vhost-user-rng: backend: Add RNG vhost-user daemon implementation

2021-07-21 Thread Alex Bennée
Mathieu Poirier writes: > This patch provides the vhost-user backend implementation to work > in tandem with the vhost-user-rng implementation of the QEMU VMM. > > It uses the vhost-user API so that other VMM can re-use the interface > without having to write the driver again. > >

Re: [PATCH] hw/usb/hcd-dwc2: Enforce epnum to 0 for the control endpoint to avoid the assertion failure in usb_ep_get()

2021-07-21 Thread Gerd Hoffmann
> > > * https://gitlab.com/qemu-project/qemu/-/issues/119 > > > * https://gitlab.com/qemu-project/qemu/-/issues/303 > diff --git a/hw/usb/core.c b/hw/usb/core.c > index 975f762..a29b378 100644 > --- a/hw/usb/core.c > +++ b/hw/usb/core.c > @@ -735,10 +735,11 @@ void usb_ep_dump(USBDevice *dev) >

Re: [PATCH v2 00/13] Clipboard fixes (for 6.1?)

2021-07-21 Thread Marc-André Lureau
Hi Gerd, On Wed, Jul 21, 2021 at 12:41 PM wrote: > From: Marc-André Lureau > > Hi, > > Here is a few fixes I have collected while working on clipboard-related > code. > > There are some obvious code improvements/fixes, and better handling of > release & > unregister to avoid dangling pointers

Re: [PATCH v3] failover: unregister ROM on unplug

2021-07-21 Thread Laurent Vivier
On 21/07/2021 13:10, Dr. David Alan Gilbert wrote: > * Laurent Vivier (lviv...@redhat.com) wrote: >> The intend of failover is to allow to migrate a VM with a VFIO >> networking card without disrupting the network operation by switching >> to a virtio-net device during the migration. >> >> This

Re: [PATCH v3] failover: unregister ROM on unplug

2021-07-21 Thread Dr. David Alan Gilbert
* Laurent Vivier (lviv...@redhat.com) wrote: > The intend of failover is to allow to migrate a VM with a VFIO > networking card without disrupting the network operation by switching > to a virtio-net device during the migration. > > This simple change allows to test failover with a simulated

Re: QEMU modules improvements objective (Was: Re: [RFC 0/3] Improve module accelerator error message)

2021-07-21 Thread Claudio Fontana
On 7/21/21 12:47 PM, Claudio Fontana wrote: > On 7/21/21 12:35 PM, Gerd Hoffmann wrote: >> Hi, >> >>> Open question to all, >>> >>> why don't we have/add the ability to configure >>> >>> CONFIG_XXX=m >>> >>> for all potentially modular pieces? >>> >>> It should be possible to say, I want to

Re: [PATCH for-6.1 v6 17/17] accel/tcg: Record singlestep_enabled in tb->cflags

2021-07-21 Thread Alex Bennée
Richard Henderson writes: > Set CF_SINGLE_STEP when single-stepping is enabled. > This avoids the need to flush all tb's when turning > single-stepping on or off. > > Signed-off-by: Richard Henderson > --- > include/exec/exec-all.h | 1 + > accel/tcg/cpu-exec.c | 7 ++- >

<    1   2   3   4   >