[PATCH v3 09/12] ui/console: optionally update after gfx switch

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau When switching to the dummy surface, we should also call gfx_update. But when using GL, we shouldn't call it. By making it an argument to displaychangelistener_gfx_switch(), it will be explicit, and cannot be forgotten that easily. Fixes: commit ebced091 ("console: save

Re: [PATCH 2/2] ui/cocoa: add option to swap Option and Command

2022-03-06 Thread Akihiko Odaki
On 2022/03/07 16:17, Markus Armbruster wrote: BALATON Zoltan writes: On Sun, 6 Mar 2022, Akihiko Odaki wrote: From: Gustavo Noronha Silva On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change swaps them around so that Alt is the key closer to the space bar and Meta/S

[PATCH v3 04/12] ui/dbus: associate the DBusDisplayConsole listener with the given console

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau DBusDisplayConsole is specific to a given QemuConsole. Fixes: commit 142ca628 ("ui: add a D-Bus display backend") Reported-by: Akihiko Odaki Signed-off-by: Marc-André Lureau --- ui/dbus.h | 3 +++ ui/dbus-console.c | 27 +-- ui/dbus.c

[PATCH v3 08/12] ui/console: add a dpy_gfx_switch callback helper

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau Slight code improvement. Signed-off-by: Marc-André Lureau --- ui/console.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/ui/console.c b/ui/console.c index d3ecbb215736..102fcf0a5068 100644 --- a/ui/console.c +++ b/ui/conso

[PATCH v3 06/12] ui/shader: fix potential leak of shader on error

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau Value of 0 for program and shaders are silently ignored and indicate error. Signed-off-by: Marc-André Lureau --- ui/shader.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ui/shader.c b/ui/shader.c index e8b8d321b7c7..4c80fc831f68 100644 --- a

[PATCH v3 10/12] ui/dbus: fix texture sharing

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau The DBus listener naively create, update and destroy textures without taking into account other listeners. The texture were shared, but texture update was unnecessarily duplicated. Teach DisplayGLCtx to do optionally shared texture handling. This is only implemented for D

[PATCH v3 01/12] ui/console: move check for compatible GL context

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau Move GL context compatibility check in dpy_compatible_with(), and use recommended error reporting. Signed-off-by: Marc-André Lureau --- ui/console.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/ui/console.c b/ui/console.c in

[PATCH v3 03/12] ui/console: egl-headless is compatible with non-gl listeners

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau Fix a regression introduced by commit 5e79d516e ("ui: split the GL context in a different object"). Reported-by: Akihiko Odaki Signed-off-by: Marc-André Lureau --- ui/egl-headless.c | 8 1 file changed, 8 insertions(+) diff --git a/ui/egl-headless.c b/ui/egl-

[PATCH v3 05/12] ui/console: move console compatibility check to dcl_display_console()

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau The current checks are done at registration time only. However, if a DCL has no specific console specified, it may be switched dynamically with console_select() later on. Let's move the checks when displaychangelistener_display_console() is called, which includes registra

[PATCH v3 07/12] ui/shader: free associated programs

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/shader.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/shader.c b/ui/shader.c index 4c80fc831f68..ab448c41d4c6 100644 --- a/ui/shader.c +++ b/ui/shader.c @@ -172,5 +172,8 @@ void qemu_gl_fini_shader(QemuGLShader *gls)

Re: [PATCH v2 10/14] vdpa: Add custom IOTLB translations to SVQ

2022-03-06 Thread Eugenio Perez Martin
On Mon, Mar 7, 2022 at 5:24 AM Jason Wang wrote: > > > 在 2022/3/3 下午7:35, Eugenio Perez Martin 写道: > > On Thu, Mar 3, 2022 at 8:33 AM Jason Wang wrote: > >> > >> 在 2022/3/1 下午4:50, Eugenio Perez Martin 写道: > >>> On Mon, Feb 28, 2022 at 8:37 AM Jason Wang wrote: > 在 2022/2/27 下午9:41, Eugenio

[PATCH v3 02/12] ui/console: move dcl compatiblity check to a callback

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau As expected from the "compatible_dcl" comment, a simple comparison of ops isn't enough. The following patch will fix a regression introduced by this limited check by extending the compatibility callback for egl-headless. For now, this patch simply replaces the the "compat

[PATCH v3 00/12] GL & D-Bus display related fixes

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau Hi, Here are pending fixes related to D-Bus and GL, most of them reported thanks to Akihiko Odaki. v3: - rebased - add "ui/dbus: do not send 2d scanout until gfx_update" & "ui/console: call gfx_switch() even if the current scanout is GL" Marc-André Lureau (12): u

[PATCH 0/6] aspeed/smc: 'num_cs' cleanup

2022-03-06 Thread Cédric Le Goater
Hi, This series removes a redudant 'num_cs' field in the Aspeed SMC model and does a few cleanups on the way. Thanks, C. Cédric Le Goater (6): aspeed/smc: Use max number of CE instead of 'num_cs' aspeed: Rework aspeed_board_init_flashes() interface aspeed/smc: Remove 'num_cs' field aspe

Re: [PATCH v3 2/5] qtest: replace gettimeofday with GTimer

2022-03-06 Thread Thomas Huth
On 07/03/2022 08.03, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau glib provides a convenience helper to measure elapsed time. It isn't subject to wall-clock time changes. Note that this changes the initial OPENED time, which used to print the current time. [...] @@ -846,21 +828

[PATCH 1/6] aspeed/smc: Use max number of CE instead of 'num_cs'

2022-03-06 Thread Cédric Le Goater
The Aspeed SMC model uses the 'num_cs' field to allocate resources fitting the number of devices of the machine. This is a small optimization without real need in the controller. Simplify modelling and use the max_peripherals field instead. Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c

Re: [PATCH 11/18] tests: expand the migration precopy helper to support failures

2022-03-06 Thread Peter Xu
On Wed, Mar 02, 2022 at 05:49:25PM +, Daniel P. Berrangé wrote: > The migration precopy testing helper function always expects the > migration to run to a completion state. There will be test scenarios > for TLS where expect either the client or server to fail the migration. > This expands the

[PATCH 4/6] aspeed/smc: Rename 'max_peripherals' to 'max_cs'

2022-03-06 Thread Cédric Le Goater
The naming makes more sense in a SPI controller model. Signed-off-by: Cédric Le Goater --- include/hw/ssi/aspeed_smc.h | 2 +- hw/ssi/aspeed_smc.c | 42 ++--- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/include/hw/ssi/aspeed_smc.h b/i

[PATCH 5/6] aspeed/smc: Let the SSI core layer define the bus name

2022-03-06 Thread Cédric Le Goater
If no id is provided, qdev automatically assigns a unique ename with the following pattern ".". Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index f194182beacf..113f31899a6b 1

Re: [PATCH v4 2/2] target/riscv: Enable Zicbo[m,z,p] instructions

2022-03-06 Thread Frank Chang
Christoph Müllner 於 2022年2月17日 週四 下午12:00寫道: > > > On Thu, Feb 17, 2022 at 3:15 AM Weiwei Li wrote: > >> >> 在 2022/2/16 下午11:48, Christoph Muellner 写道: >> > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c >> > index 39ffb883fc..04500fe352 100644 >> > --- a/target/riscv/cpu.c >> > +++ b/targ

[PATCH 6/6] aspeed/smc: Fix error log

2022-03-06 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ssi/aspeed_smc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 113f31899a6b..f410248938c9 100644 --- a/hw/ssi/aspeed_smc.c +++ b/hw/ssi/aspeed_smc.c @@ -327,7 +327,7 @@ static void aspeed_

Re: [PATCH 10/18] tests: switch migration FD passing test to use common precopy helper

2022-03-06 Thread Peter Xu
On Wed, Mar 02, 2022 at 05:49:24PM +, Daniel P. Berrangé wrote: > The combination of the start and finish hooks allow the FD passing > code to use the precopy helper > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH v2 RESEND] qga: Introduce disk smart

2022-03-06 Thread Marc-André Lureau
Hi On Mon, Mar 7, 2022 at 10:24 AM zhenwei pi wrote: > After assigning a NVMe/SCSI controller to guest by VFIO, we lose > everything on the host side. A guest uses these devices exclusively, > we usually don't care the actions on these devices. But there is a > low probability that hitting physi

[PATCH 2/6] aspeed: Rework aspeed_board_init_flashes() interface

2022-03-06 Thread Cédric Le Goater
Currently, the allocation of the flash devices uses the number of slave selects configured in the SoC realize routine. It is simpler to use directly the number of FMC devices defined in the machine class and 1 for spi devices (which is what the SoC does in the back of the machine). Signed-off-by:

Re: [PATCH 2/2] ui/cocoa: add option to swap Option and Command

2022-03-06 Thread Markus Armbruster
BALATON Zoltan writes: > On Sun, 6 Mar 2022, Akihiko Odaki wrote: >> From: Gustavo Noronha Silva >> >> On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change >> swaps them around so that Alt is the key closer to the space bar and >> Meta/Super >> is between Control and Al

Re: [PATCH 09/18] tests: introduce ability to provide hooks for migration precopy test

2022-03-06 Thread Peter Xu
On Wed, Mar 02, 2022 at 05:49:23PM +, Daniel P. Berrangé wrote: > There are alot of different scenarios to test with migration due to the > wide number of parameters and capabilities available. To enable sharing > of the basic precopy test scenario, we need to be able to set arbitrary > paramet

[PATCH 3/6] aspeed/smc: Remove 'num_cs' field

2022-03-06 Thread Cédric Le Goater
It is not used anymore. Signed-off-by: Cédric Le Goater --- include/hw/ssi/aspeed_smc.h | 1 - hw/arm/aspeed.c | 2 -- hw/arm/aspeed_ast2600.c | 2 -- hw/arm/aspeed_soc.c | 2 -- hw/ssi/aspeed_smc.c | 7 --- 5 files changed, 14 deletions(-) diff --git a/inclu

Re: [PATCH 08/18] tests: merge code for UNIX and TCP migration pre-copy tests

2022-03-06 Thread Peter Xu
On Wed, Mar 02, 2022 at 05:49:22PM +, Daniel P. Berrangé wrote: > The test cases differ only in the URI they provide to the migration > commands, and the ability to set the dirty_ring mode. This code is > trivially merged into a common helper. > > Signed-off-by: Daniel P. Berrangé Reviewed-b

Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node

2022-03-06 Thread Shan Gavin
Hi Laszlo, Yes, I think it's enough to provide the user-friendly error message in EDK2. The command lines to start the VM/guest can be adjusted to have more than 128MB memory associated for NUMA node#0 when it's seen by users. Thanks, Gavin Laszlo Ersek 于2022年3月4日周五 22:24写道: > > Gerd, > > On 03

Re: [PATCH 07/18] migration: fix use of TLS PSK credentials with a UNIX socket

2022-03-06 Thread Peter Xu
On Wed, Mar 02, 2022 at 05:49:21PM +, Daniel P. Berrangé wrote: > The migration TLS code has a check mandating that a hostname be > available when starting a TLS session. This is expected when using > x509 credentials, but is bogus for PSK and anonymous credentials > as neither involve hostname

[PATCH v3 5/5] oslib: drop qemu_gettimeofday()

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau No longer used after the previous patches. Signed-off-by: Marc-André Lureau Reviewed-by: Laurent Vivier Reviewed-by: Stefan Weil Reviewed-by: Richard Henderson --- include/sysemu/os-posix.h | 3 --- include/sysemu/os-win32.h | 6 -- util/oslib-win32.c|

[PATCH v3 3/5] qga: replace qemu_gettimeofday() with g_get_real_time()

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau GLib g_get_real_time() is an alternative to gettimeofday() which allows to simplify our code. Signed-off-by: Marc-André Lureau Reviewed-by: Laurent Vivier --- qga/commands-posix.c | 14 -- qga/commands-win32.c | 19 --- qga/commands.c

[PATCH v3 2/5] qtest: replace gettimeofday with GTimer

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau glib provides a convenience helper to measure elapsed time. It isn't subject to wall-clock time changes. Note that this changes the initial OPENED time, which used to print the current time. Signed-off-by: Marc-André Lureau Reviewed-by: Laurent Vivier --- softmmu/qtes

[PATCH v3 4/5] Replace qemu_gettimeofday() with g_get_real_time()

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau GLib g_get_real_time() is an alternative to gettimeofday() which allows to simplify our code. For semihosting, a few bits are lost on POSIX host, but this shouldn't be a big concern. Signed-off-by: Marc-André Lureau Reviewed-by: Laurent Vivier --- blockdev.c

[PATCH v3 1/5] m68k/nios2-semi: fix gettimeofday() result check

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau gettimeofday() returns 0 for success. Signed-off-by: Marc-André Lureau Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson --- target/m68k/m68k-semi.c | 2 +- target/nios2/nios2-semi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tar

[PATCH v3 0/5] Remove qemu_gettimeofday()

2022-03-06 Thread marcandre . lureau
From: Marc-André Lureau Hi, Here is a few patches to replace qemu_gettimeofday() helper with functions provided by GLib. v3: - fix wrong qdict_from_jsonf() format change v2: - fix return of get-time in nanoseconds - qga: replace with a common get-time function for qga posix/win32 - split qga p

[PATCH v3 4/4] spapr: Add SPAPR_CAP_AIL_MODE_3 for AIL mode 3 support for H_SET_MODE hcall

2022-03-06 Thread Nicholas Piggin
The behaviour of the Address Translation Mode on Interrupt resource is not consistently supported by all CPU versions or all KVM versions: KVM-HV does not support mode 2, and does not support mode 3 on POWER7 or early POWER9 processesors. KVM PR only supports mode 0. TCG supports all modes (0, 2, 3

[PATCH v3 0/4] Fix PVR matching, add AIL cap compatibility

2022-03-06 Thread Nicholas Piggin
Ended up running into some interesting PVR matching issues which I think are now fixed (although have not tested full matrix of all CPUs affected by patch 1). Since last post, I have dropped the KVM cap for now. The KVM CAP is allocated in kvm.git next but it won't be a big deal to wait until it h

[PATCH v3 3/4] target/ppc: Add POWER9 DD2.2 model

2022-03-06 Thread Nicholas Piggin
POWER9 DD2.1 and earlier had significant limitations when running KVM, including lack of "mixed mode" MMU support (ability to run HPT and RPT mode on threads of the same core), and a translation prefetch issue which is worked around by disabling "AIL" mode for the guest. These processors are not w

[PATCH v3 2/4] target/ppc: Remove chip type field from POWER9 DD2.0 PVR

2022-03-06 Thread Nicholas Piggin
The POWER9 DD2.0 PVR does not follow the same format as the other POWER9/10 PVRs, it includes a non-zero value in the "chip type" field. This does not cause problems because the pvr check is masks it out and matches against the base, but it's a small inconsistency. Zero the field. Signed-off-by: N

[PATCH v3 1/4] target/ppc: Fix masked PVR matching

2022-03-06 Thread Nicholas Piggin
The pvr_match for a CPU class is not supposed to just match for any CPU in the family, but rather whether this particular CPU class is the best match in the family. Prior to this fix, e.g., a POWER9 DD2.3 KVM host matches to the power9_v1.0 class (because that's first in the list). After the patch

Re: [PATCH v15 3/8] net/vmnet: implement shared mode (vmnet-shared)

2022-03-06 Thread Akihiko Odaki
On Mon, Mar 7, 2022 at 1:52 PM Jason Wang wrote: > > On Mon, Mar 7, 2022 at 12:25 PM Akihiko Odaki wrote: > > > > On Mon, Mar 7, 2022 at 12:59 PM Jason Wang wrote: > > > > > > On Fri, Mar 4, 2022 at 12:37 PM Akihiko Odaki > > > wrote: > > > > > > > > On 2022/03/04 10:37, Jason Wang wrote: > >

Re: [PATCH 03/18] tests: support QTEST_TRACE env variable

2022-03-06 Thread Peter Xu
On Wed, Mar 02, 2022 at 05:49:17PM +, Daniel P. Berrangé wrote: > When debugging failing qtests it is useful to be able to turn on trace > output to stderr. The QTEST_TRACE env variable contents get injected > as a '-trace ' command line arg > > Signed-off-by: Daniel P. Berrangé Reviewed-by:

Re: [PATCH 02/18] tests: improve error message when saving TLS PSK file fails

2022-03-06 Thread Peter Xu
On Wed, Mar 02, 2022 at 05:49:16PM +, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

2022-03-06 Thread Peter Xu
On Wed, Mar 02, 2022 at 05:49:18PM +, Daniel P. Berrangé wrote: > The QMP commands have a trailing newline, but the response does not. > This makes the qtest logs hard to follow as the next QMP command > appears in the same line as the previous QMP response. > > Signed-off-by: Daniel P. Berran

Re: [PATCH v2 1/4] hyperv: SControl is optional to enable SynIc

2022-03-06 Thread Jon Doron
Thanks! is there an estimate when will this patchset be merged? On Thu, Feb 24, 2022, 18:36 Emanuele Giuseppe Esposito wrote: > > > On 16/02/2022 11:24, Jon Doron wrote: > > SynIc can be enabled regardless of the SControl mechanisim which can > > register a GSI for a given SintRoute. > > > > Thi

Re: Re: [PATCH] qga: Introduce disk smart

2022-03-06 Thread zhenwei pi
On 3/4/22 10:51 PM, Keith Busch wrote: On Fri, Mar 04, 2022 at 04:54:07PM +0800, zhenwei pi wrote: +smart->u.nvme.temperature = le16_to_cpu(log.temperature); The 'temperature' offset is not properly aligned, so I think you need to use an unaligned le accessor like 'stw_le_p()'. Than

[PATCH v2 RESEND] qga: Introduce disk smart

2022-03-06 Thread zhenwei pi
After assigning a NVMe/SCSI controller to guest by VFIO, we lose everything on the host side. A guest uses these devices exclusively, we usually don't care the actions on these devices. But there is a low probability that hitting physical hardware warning, we need a chance to get the basic smart lo

Re: [PATCH v15 3/8] net/vmnet: implement shared mode (vmnet-shared)

2022-03-06 Thread Jason Wang
On Mon, Mar 7, 2022 at 12:25 PM Akihiko Odaki wrote: > > On Mon, Mar 7, 2022 at 12:59 PM Jason Wang wrote: > > > > On Fri, Mar 4, 2022 at 12:37 PM Akihiko Odaki > > wrote: > > > > > > On 2022/03/04 10:37, Jason Wang wrote: > > > > On Thu, Mar 3, 2022 at 11:43 PM Vladislav Yaroshchuk > > > > wr

[PATCH v1] ui/gtk-egl: Check for a valid context before making EGL calls

2022-03-06 Thread Vivek Kasireddy
Since not all listeners (i.e VirtualConsoles) of GL events have a valid EGL context, make sure that there is a valid context before making EGL calls. This fixes the following crash seen while launching the VM with "-device virtio-gpu-pci,max_outputs=1,blob=true -display gtk,gl=on" No provider of

Re: [PATCH v15 3/8] net/vmnet: implement shared mode (vmnet-shared)

2022-03-06 Thread Akihiko Odaki
On Mon, Mar 7, 2022 at 12:59 PM Jason Wang wrote: > > On Fri, Mar 4, 2022 at 12:37 PM Akihiko Odaki wrote: > > > > On 2022/03/04 10:37, Jason Wang wrote: > > > On Thu, Mar 3, 2022 at 11:43 PM Vladislav Yaroshchuk > > > wrote: > > >> > > >> > > >> > > >> On Tue, Mar 1, 2022 at 11:21 AM Akihiko Od

[PULL SUBSYSTEM qemu-pnv] ppc/pnv: Update skiboot firmware image

2022-03-06 Thread Joel Stanley
The following changes since commit 9d662a6b22a0838a85c5432385f35db2488a33a5: Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220305' into staging (2022-03-05 18:03:15 +) are available in the Git repository at: https://github.com/shenki/qemu tags/qemu-rom-skiboot-v7.0 for

Re: [PATCH v2 10/14] vdpa: Add custom IOTLB translations to SVQ

2022-03-06 Thread Jason Wang
在 2022/3/3 下午7:35, Eugenio Perez Martin 写道: On Thu, Mar 3, 2022 at 8:33 AM Jason Wang wrote: 在 2022/3/1 下午4:50, Eugenio Perez Martin 写道: On Mon, Feb 28, 2022 at 8:37 AM Jason Wang wrote: 在 2022/2/27 下午9:41, Eugenio Pérez 写道: Use translations added in VhostIOVATree in SVQ. Only introduce

Re: [PATCH v7 17/22] ui/cocoa: Constify qkeycode translation arrays

2022-03-06 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki On Mon, Mar 7, 2022 at 8:19 AM Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > Reported-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- > ui/cocoa.m | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletion

Re: [PATCH v7 16/22] configure: Pass filtered QEMU_OBJCFLAGS to meson

2022-03-06 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki On Mon, Mar 7, 2022 at 8:19 AM Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > Filter unsupported Objective-C options, to avoid > 'unknown-warning-option' warnings when using Clang: > > [34/373] Compiling Objective-C obje

Re: [PATCH v7 15/22] meson: Log QEMU_CXXFLAGS content in summary

2022-03-06 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki On Mon, Mar 7, 2022 at 8:19 AM Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > Signed-off-by: Philippe Mathieu-Daudé > --- > meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meson.build b/meson.build >

Re: [PATCH v7 14/22] meson: Resolve the entitlement.sh script once for good

2022-03-06 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki On Mon, Mar 7, 2022 at 8:19 AM Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > Commit 235b523dba ("meson: Use find_program() to resolve the > entitlement.sh script") didn't correctly fixed the issue, as > the script is stil

Re: [PATCH v7 13/22] osdep: Avoid using Clang-specific __builtin_available()

2022-03-06 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki On Mon, Mar 7, 2022 at 8:19 AM Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > Remove the Clang specific __builtin_available() to allow building > with GCC, otherwise we get: > > include/qemu/osdep.h: In function 'qemu_th

Re: [PATCH v15 3/8] net/vmnet: implement shared mode (vmnet-shared)

2022-03-06 Thread Jason Wang
On Fri, Mar 4, 2022 at 12:37 PM Akihiko Odaki wrote: > > On 2022/03/04 10:37, Jason Wang wrote: > > On Thu, Mar 3, 2022 at 11:43 PM Vladislav Yaroshchuk > > wrote: > >> > >> > >> > >> On Tue, Mar 1, 2022 at 11:21 AM Akihiko Odaki > >> wrote: > >>> > >>> On 2022/03/01 17:09, Vladislav Yaroshchuk

Re: [PATCH v7 0/4] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-03-06 Thread Ani Sinha
On Mon, Mar 7, 2022 at 3:06 AM Michael S. Tsirkin wrote: > > On Fri, Mar 04, 2022 at 09:10:28PM +0530, Ani Sinha wrote: > > This can allow the guest OS to determine more easily if i8042 controller > > is present in the system or not, so it doesn't need to do probing of the > > controller, but just

Re: [PATCH v2 09/14] vhost: Add VhostIOVATree

2022-03-06 Thread Jason Wang
On Fri, Mar 4, 2022 at 4:02 PM Eugenio Perez Martin wrote: > > On Fri, Mar 4, 2022 at 3:04 AM Jason Wang wrote: > > > > On Fri, Mar 4, 2022 at 12:33 AM Eugenio Perez Martin > > wrote: > > > > > > On Mon, Feb 28, 2022 at 8:06 AM Jason Wang wrote: > > > > > > > > > > > > 在 2022/2/27 下午9:41, Eugen

[PATCH] checkpatch: Check .m, .build, .hx, .json and .plist

2022-03-06 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index ddd8148d87e..bd666129d3f 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -12,7 +12,7 @@ use Term::ANSICo

[Bug 1735049] Re: Need MTTCG support for x86 guests

2022-03-06 Thread Emilio G. Cota
OK, looks like I cannot reopen the bug, probably because the bug tracker moved to gitlab. If you care about this feature, please file a bug over there: https://gitlab.com/qemu-project/qemu/-/issues -- You received this bug notification because you are a member of qemu- devel-ml, which is subscri

[Bug 1735049] Re: Need MTTCG support for x86 guests

2022-03-06 Thread Emilio G. Cota
Looks like support for this was not fully added; my apologies for closing this bug too early. Adding full support for strong-on-weak emulation would be simple, at least when it comes to memory ordering. The slowdown would be huge though, see Figure 12 in http://www.cs.columbia.edu/~cota/pubs/cota_

[PATCH v2] qga: Introduce disk smart

2022-03-06 Thread zhenwei pi
After assigning a NVMe/SCSI controller to guest by VFIO, we lose everything on the host side. A guest uses these devices exclusively, we usually don't care the actions on these devices. But there is a low probability that hitting physical hardware warning, we need a chance to get the basic smart lo

Re: [PATCH v5 0/6] Privilege version update

2022-03-06 Thread Alistair Francis
On Mon, Mar 7, 2022 at 12:14 PM Alistair Francis wrote: > > On Fri, Mar 4, 2022 at 4:59 AM Atish Patra wrote: > > > > RISC-V International (RVI) has ratified many RISC-V ISA extensions > > recently[1]. > > The privileged specification version is also upgraded to v1.12. It means > > certain CSRs

Re: [PATCH v5 0/6] Privilege version update

2022-03-06 Thread Alistair Francis
On Fri, Mar 4, 2022 at 4:59 AM Atish Patra wrote: > > RISC-V International (RVI) has ratified many RISC-V ISA extensions > recently[1]. > The privileged specification version is also upgraded to v1.12. It means > certain CSRs introduced in v1.12 should only be accessible only if the > priv specif

Re: [PATCH v3 2/2] riscv: opentitan: Connect opentitan SPI Host

2022-03-06 Thread Alistair Francis
On Thu, Mar 3, 2022 at 2:55 PM Alistair Francis wrote: > > From: Wilfred Mallawa > > Connect spi host[1/0] to opentitan. > > Signed-off-by: Wilfred Mallawa > Reviewed-by: Alistair Francis > Reviewed-by: Philippe Mathieu-Daudé Thanks! Applied to riscv-to-apply.next Alistair > --- > V2 -> V3

[PATCH v2 7/7] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

2022-03-06 Thread David Miller
* tests/tcg/s390x/vxeh2_vcvt.c : vector convert * tests/tcg/s390x/vxeh2_vs.c: vector shift * tests/tcg/s390x/vxeh2_vlstr.c : vector load/store reversed Signed-off-by: David Miller --- tests/tcg/s390x/Makefile.target | 8 ++ tests/tcg/s390x/vxeh2_vcvt.c| 97 + test

[PATCH v2 5/7] target/s390x: vxeh2: vector {load, store} reversed elements [and {zero, replicate}]

2022-03-06 Thread David Miller
Signed-off-by: David Miller --- target/s390x/tcg/insn-data.def | 16 +++ target/s390x/tcg/translate_vx.c.inc | 161 2 files changed, 177 insertions(+) diff --git a/target/s390x/tcg/insn-data.def b/target/s390x/tcg/insn-data.def index 3a7f15a0b5..dc6daa6c10 1006

[PATCH v2 6/7] target/s390x: add S390_FEAT_VECTOR_ENH2 to cpu max

2022-03-06 Thread David Miller
Signed-off-by: David Miller --- target/s390x/gen-features.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 22846121c4..499a3b10a8 100644 --- a/target/s390x/gen-features.c +++ b/target/s390x/gen-features.c @@ -740,7 +740,9 @@ s

[PATCH v2 4/7] target/s390x: vxeh2: vector {load, store} elements reversed

2022-03-06 Thread David Miller
Signed-off-by: David Miller --- target/s390x/helper.h | 4 ++- target/s390x/tcg/insn-data.def | 4 +++ target/s390x/tcg/translate_vx.c.inc | 39 + target/s390x/tcg/vec.h | 24 ++ target/s390x/tcg/vec_helper.c | 31

[PATCH v2 3/7] target/s390x: vxeh2: vector shift {double by bit, left, right {logical, arithmetic}}

2022-03-06 Thread David Miller
Signed-off-by: David Miller --- include/qemu/bitops.h | 25 +++ target/s390x/helper.h | 3 + target/s390x/tcg/insn-data.def | 6 +- target/s390x/tcg/translate_vx.c.inc | 108 ++-- target/s390x/tcg/vec_int_helper.c | 58 +

[PATCH v2 1/7] target/s390x: vxeh2: vector convert short/32b

2022-03-06 Thread David Miller
Signed-off-by: David Miller --- target/s390x/helper.h | 4 +++ target/s390x/tcg/translate_vx.c.inc | 44 ++--- target/s390x/tcg/vec_fpu_helper.c | 31 3 files changed, 75 insertions(+), 4 deletions(-) diff --git a/target/s390x/helper.

[PATCH v2 2/7] target/s390x: vxeh2: vector string search

2022-03-06 Thread David Miller
Signed-off-by: David Miller --- target/s390x/helper.h| 1 + target/s390x/tcg/insn-data.def | 2 + target/s390x/tcg/translate.c | 3 +- target/s390x/tcg/translate_vx.c.inc | 17 target/s390x/tcg/vec_string_helper.c | 65 5 fil

[PATCH v2 0/7] s390x/tcg: Implement Vector-Enhancements Facility 2

2022-03-06 Thread David Miller
Implement Vector-Enhancements Facility 2 for s390x resolves: https://gitlab.com/qemu-project/qemu/-/issues/738 implements: VECTOR LOAD ELEMENTS REVERSED (VLER) VECTOR LOAD BYTE REVERSED ELEMENTS (VLBR) VECTOR LOAD BYTE REVERSED ELEMENT (VLEBRH, VL

Re: [PATCH v1 1/2] s390x/tcg: Implement Vector-Enhancements Facility 2 for s390x

2022-03-06 Thread David Miller
> Just use a little-endian load: MO_LE | es. > While we use MO_TE all over, it's no secret that it's always big-endian. > And everywhere else you do load then swap, or swap then store. This is not working as expected... I tried it in two places, both with a swap [removed] after and the tests fail

Re: [PATCH v3 0/7] isa: Resolve unneeded IRQ attributes from ISADevice

2022-03-06 Thread Philippe Mathieu-Daudé
On 1/3/22 23:00, Bernhard Beschow wrote: The IRQ attributes are mostly used for printing ('info qtree') and there is one user, hw/ppc/pnv, to use the attributes directly. As it turns out, the printing is redundant if the IRQ numbers are exposed as QOM properties and hw/ppc/pnv can be easily port

Re: [PATCH] [RESEND] docs: Add spec of OVMF GUIDed table for SEV guests

2022-03-06 Thread Philippe Mathieu-Daudé
On 15/2/22 07:21, Dov Murik wrote: On 04/01/2022 20:07, Daniel P. Berrangé wrote: On Mon, Jan 03, 2022 at 11:14:13AM +0200, Dov Murik wrote: Add docs/specs/sev-guest-firmware.rst which describes the GUIDed table in the end of OVMF's image which is parsed by QEMU, and currently used to describe

Re: [PATCH v3 0/9] This patch series contains updates to PMBus in QEMU along with some PMBus device models for Renesas regulators. I have also added myself to MAINTAINERS as this code is in use daily,

2022-03-06 Thread Philippe Mathieu-Daudé
On 5/3/22 00:42, Titus Rwantare wrote: On Fri, 4 Mar 2022 at 13:43, Corey Minyard wrote: On Tue, Mar 01, 2022 at 05:50:44PM -0800, Titus Rwantare wrote: v2: - split PMBus commit with updates into individual fixes - renamed isl_pmbus[.ch] adding _vr for voltage regulators v3: - split

Re: [PATCH 5/9] tests/avocado/linux_ssh_mips_malta.py: add missing accel (tcg) tag

2022-03-06 Thread Philippe Mathieu-Daudé
On 3/3/22 13:13, Cleber Rosa wrote: Philippe Mathieu-Daudé writes: On 25/2/22 22:01, Cleber Rosa wrote: Being explicit about the accelerator used on these tests is a good thing in itself, but it will also be used in the filtering rules applied on "make check-avocado". Signed-off-by: Cleber R

Re: [PATCH v2] qemu-binfmt-conf.sh: allow elf EI_ABIVERSION=1 for mips

2022-03-06 Thread Philippe Mathieu-Daudé
(Cc'ing Richard) On 5/3/22 01:18, Philippe Mathieu-Daudé wrote: Cc'ing Laurent: $ ./scripts/get_maintainer.pl -f scripts/qemu-binfmt-conf.sh Laurent Vivier (maintainer:Linux user) qemu-devel@nongnu.org (open list:All patches CC here) On 5/3/22 01:06, Andreas K. Hüttel wrote: With the command

Re: [PATCH 1/3] linux-user/elfload: Remove pointless CPUArchState cast

2022-03-06 Thread Philippe Mathieu-Daudé
On 7/3/22 00:40, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Not sure if "Remove pointless non-const CPUArchState cast" as subject is clearer? fill_thread_info() takes a pointer to const. Signed-off-by: Philippe Mathieu-Daudé --- linux-user/elfload.c | 2 +- 1 file change

[PATCH 3/3] linux-user: Remove pointless CPU{ARCH}State casts

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- linux-user/syscall.c| 49 + linux-user/uname.c | 2 +- linux-user/user-internals.h | 2 +- 3 files changed, 25 insertions(+), 28 deletions(-) diff --git a/linux-user/sy

[PATCH 2/3] linux-user: Have do_syscall() use CPUArchState* instead of void*

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- linux-user/strace.c | 202 ++-- linux-user/strace.h | 4 +- linux-user/syscall.c| 32 +++--- linux-user/uname.c | 2 +- linux-user/uname.h | 2

[PATCH 1/3] linux-user/elfload: Remove pointless CPUArchState cast

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé fill_thread_info() takes a pointer to const. Signed-off-by: Philippe Mathieu-Daudé --- linux-user/elfload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 9628a38361..d3d1d9acae 100644 --- a/lin

[PATCH 0/3] linux-user: Use CPUArchState* instead of void* when possible

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Based-on: <20220306232750.41671-1-philippe.mathieu.da...@gmail.com> "Abstract ArchCPU" pull request v2 Philippe Mathieu-Daudé (3): linux-user/elfload: Remove pointless CPUArchState cast linux-user: Have do_syscall() use CPUArchState* instead of void* linux-user

[PULL v2 28/33] target: Use forward declared type instead of structure type

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The CPU / CPU state are forward declared. $ git grep -E 'struct [A-Za-z]+CPU\ \*' target/arm/hvf_arm.h:16:void hvf_arm_set_cpu_features_from_host(struct ARMCPU *cpu); target/openrisc/cpu.h:234:int (*cpu_openrisc_map_address_code)(struct OpenRISCCPU *cpu,

[PULL v2 00/33] Abstract ArchCPU

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The following changes since commit 9d662a6b22a0838a85c5432385f35db2488a33a5: Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220305' into staging (2022-03-05 18:03:15 +) are available in the Git repository at: https://github.com/philmd/qemu.

[PATCH v7 16/22] configure: Pass filtered QEMU_OBJCFLAGS to meson

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Filter unsupported Objective-C options, to avoid 'unknown-warning-option' warnings when using Clang: [34/373] Compiling Objective-C object libcommon.fa.p/audio_coreaudio.m.o warning: unknown warning option '-Wold-style-declaration'; did you mean '-Wout-of-line-d

[PATCH v7 17/22] ui/cocoa: Constify qkeycode translation arrays

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- ui/cocoa.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 8ab9ab5e84..a6db8ebfb6 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -671,7 +671,7 @@

[PATCH v7 21/22] ui/cocoa: add option to swap Option and Command

2022-03-06 Thread Philippe Mathieu-Daudé
From: Gustavo Noronha Silva On Mac OS X the Option key maps to Alt and Command to Super/Meta. This change swaps them around so that Alt is the key closer to the space bar and Meta/Super is between Control and Alt, like on non-Mac keyboards. It is a cocoa display option, disabled by default. Ack

[PATCH v7 14/22] meson: Resolve the entitlement.sh script once for good

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Commit 235b523dba ("meson: Use find_program() to resolve the entitlement.sh script") didn't correctly fixed the issue, as the script is still resolved for each target. Move the check earlier, before processing each target. Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v7 22/22] gitlab-ci: Support macOS 12 via cirrus-run

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Add support for macOS 12 build on Cirrus-CI, similarly to commit 0e103a65ba1 ("gitlab: support for ... macOS 11 via cirrus-run"), but with the following differences: - Enable modules (configure --enable-modules) - Do not run softfloat3 tests (make check-softfloat)

[PATCH v7 15/22] meson: Log QEMU_CXXFLAGS content in summary

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 8ca2b7c8c2..0d38b2e72a 100644 --- a/meson.build +++ b/meson.build @@ -3470,6 +3470,7 @@ if link_args.length() > 0 summary_inf

[PATCH v7 13/22] osdep: Avoid using Clang-specific __builtin_available()

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Remove the Clang specific __builtin_available() to allow building with GCC, otherwise we get: include/qemu/osdep.h: In function 'qemu_thread_jit_write': include/qemu/osdep.h:787:9: warning: implicit declaration of function '__builtin_available'; did you mean '__

[PATCH v7 20/22] ui/cocoa: capture all keys and combos when mouse is grabbed

2022-03-06 Thread Philippe Mathieu-Daudé
From: Gustavo Noronha Silva Applications such as Gnome may use Alt-Tab and Super-Tab for different purposes, some use Ctrl-arrows so we want to allow qemu to handle everything when it captures the mouse/keyboard. However, Mac OS handles some combos like Command-Tab and Ctrl-arrows at an earlier

[PATCH v7 12/22] audio: Rename coreaudio extension to use Objective-C compiler

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The coreaudio library includes Objective-C declarations (using the caret '^' symbol to declare block references [*]). When building with a C compiler we get: [175/839] Compiling C object libcommon.fa.p/audio_coreaudio.c.o In file included from /Library/Develop

[PATCH v7 10/22] audio: Log context for audio bug

2022-03-06 Thread Philippe Mathieu-Daudé
From: Akihiko Odaki Without this change audio_bug aborts when the bug condition is met, which discards following useful logs. Call abort after such logs. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220306063202.27331-1-akihiko.od...@gmail.com> Signed-off-by:

[PATCH v7 09/22] audio/dbus: Fix building with modules on macOS

2022-03-06 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé When configuring QEMU with --enable-modules we get on macOS: --- stderr --- Dependency ui-dbus cannot be satisfied ui-dbus depends on pixman and opengl, so add these dependencies to audio-dbus. Fixes: 739362d420 ("audio: add "dbus" audio backend") Reviewed-by:

  1   2   3   >