Re: [PATCH v6 1/5] target/riscv: Add smstateen support

On Mon, 2022-07-25 at 15:11 +0800, Weiwei Li wrote: > 在 2022/7/24 下午11:39, Mayuresh Chitale 写道: > > On Fri, 2022-07-22 at 08:31 +0800, Weiwei Li wrote: > > > 在 2022/7/21 下午11:31, Mayuresh Chitale 写道: > > > > Smstateen extension specifies a mechanism to close > > > > the potential covert channels

Re: VIRTIO_NET_F_MTU not negotiated

On Thu, Jul 28, 2022 at 1:39 PM Eli Cohen wrote: > > > From: Jason Wang > > Sent: Thursday, July 28, 2022 5:09 AM > > To: Eli Cohen > > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; > > Michael S. Tsirkin ; > > virtualizat...@lists.linux-foundation.org > > Subject: Re: VIRTIO_NET_F_MTU not

RE: VIRTIO_NET_F_MTU not negotiated

> From: Jason Wang > Sent: Thursday, July 28, 2022 5:09 AM > To: Eli Cohen > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; > Michael S. Tsirkin ; > virtualizat...@lists.linux-foundation.org > Subject: Re: VIRTIO_NET_F_MTU not negotiated > > On Wed, Jul 27, 2022 at 2:52 PM Eli Cohen wrote:

Re: [PATCH v3] target/ppc: Implement new wait variants

On Wed, 27 Jul 2022 at 13:49, Daniel Henrique Barboza wrote: > > > > On 7/20/22 10:33, Nicholas Piggin wrote: > > ISA v2.06 adds new variations of wait, specified by the WC field. These > > are not all compatible with the prior wait implementation, because they > > add additional conditions that

Re: [RFC patch 0/1] block: vhost-blk backend

On 7/27/22 16:06, Stefano Garzarella wrote: On Tue, Jul 26, 2022 at 04:15:48PM +0200, Denis V. Lunev wrote: On 26.07.2022 15:51, Michael S. Tsirkin wrote: On Mon, Jul 25, 2022 at 11:55:26PM +0300, Andrey Zhadchenko wrote: Although QEMU virtio-blk is quite fast, there is still some room for

Re: [PATCH 08/16] vhost: add op to enable or disable a single vring

On Wed, Jul 27, 2022 at 3:05 PM Kangjie Xu wrote: > > > 在 2022/7/27 12:55, Jason Wang 写道: > > On Tue, Jul 26, 2022 at 2:39 PM Kangjie Xu > > wrote: > >> > >> 在 2022/7/26 11:49, Jason Wang 写道: > >>> 在 2022/7/18 19:17, Kangjie Xu 写道: > The interface to set enable status for a single vring is

Re: VIRTIO_NET_F_MTU not negotiated

On Wed, Jul 27, 2022 at 2:52 PM Eli Cohen wrote: > > I found out that the reason why I could not enforce the mtu stems from the > fact that I did not configure max mtu for the net device (e.g. through > libvirt ). > Libvirt does not allow this configuration for vdpa devices and probably for a

Re: [RFC v4 2/9] qemu-io: add zoned block device operations.

On 7/27/22 23:13, Stefan Hajnoczi wrote: > On Mon, 11 Jul 2022 at 22:17, Sam Li wrote: >> +int bdrv_co_zone_report(BlockDriverState *bs, int64_t offset, >> +int64_t *nr_zones, >> +BlockZoneDescriptor *zones) >> +{ >> +BlockDriver *drv = bs->drv;

Re: virtio: why no full reset on virtio_set_status 0 ?

On Wed, Jul 27, 2022 at 11:32 PM Michael S. Tsirkin wrote: > > On Wed, Jul 27, 2022 at 12:51:31PM +0200, Claudio Fontana wrote: > > Hi Michael and all, > > > > I have started researching a qemu / ovs / dpdk bug: > > > > https://inbox.dpdk.org/dev/322122fb-619d-96f6-5c3e-9eabdbf38...@redhat.com/T/

[PULL 0/2] riscv-to-apply queue

From: Alistair Francis The following changes since commit 7b17a1a841fc2336eba53afade9cadb14bd3dd9a: Update version for v7.1.0-rc0 release (2022-07-26 18:03:16 -0700) are available in the Git repository at: g...@github.com:alistair23/qemu.git tags/pull-riscv-to-apply-20220728 for you to

[PULL 2/2] hw/intc: sifive_plic: Fix multi-socket plic configuraiton

From: Atish Patra Since commit 40244040a7ac, multi-socket configuration with plic is broken as the hartid for second socket is calculated incorrectly. The hartid stored in addr_config already includes the offset for the base hartid for that socket. Adding it again would lead to segfault while

[PULL 1/2] RISC-V: Allow both Zmmul and M

From: Palmer Dabbelt We got to talking about how Zmmul and M interact with each other https://github.com/riscv/riscv-isa-manual/issues/869 , and it turns out that QEMU's behavior is slightly wrong: having Zmmul and M is a legal combination, it just means that the multiplication instructions are

Re: [PATCH v11 2/6] target/riscv: Simplify counter predicate function

在 2022/7/28 上午5:40, Atish Kumar Patra 写道: On Wed, Jul 27, 2022 at 1:35 AM Weiwei Li > wrote: 在 2022/7/27 下午2:49, Atish Patra 写道: > All the hpmcounters and the fixed counters (CY, IR, TM) can be represented > as a unified counter. Thus, the

Re: [PATCH v11 5/6] target/riscv: Update the privilege field for sscofpmf CSRs

On Wed, Jul 27, 2022 at 1:27 AM Weiwei Li wrote: > > 在 2022/7/27 下午2:49, Atish Patra 写道: > > The sscofpmf extension was ratified as a part of priv spec v1.12. > > Mark the csr_ops accordingly. > > > > Reviewed-by: Alistair Francis > > Signed-off-by: Atish Patra > > --- > > target/riscv/csr.c

Re: add qemu_fdt_setprop_strings() and use it in most places

On Wed, Jul 27, 2022 at 11:39:00PM +0100, Ben Dooks wrote: > Add a helper for qemu_fdt_setprop_strings() to take a set of strings > to put into a device-tree, which removes several open-coded methods > such as setting an char arr[] = {..} or setting char val[] = "str\0str2"; > > This is for

[PATCH v3 4/5] hw/mips: use qemu_fdt_setprop_strings()

Change to using qemu_fdt_setprop_strings() helper in hw/mips. Signed-off-by: Ben Dooks --- hw/mips/boston.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/mips/boston.c b/hw/mips/boston.c index d2ab9da1a0..759f6daafe 100644 --- a/hw/mips/boston.c +++

[PATCH v3 2/5] hw/riscv: use qemu_fdt_setprop_strings() for string arrays

Use the qemu_fdt_setprop_strings() in sifve_u.c to simplify the code. Signed-off-by: Ben Dooks --- hw/riscv/sifive_u.c | 18 +- hw/riscv/spike.c| 7 ++- hw/riscv/virt.c | 32 3 files changed, 15 insertions(+), 42 deletions(-) diff

add qemu_fdt_setprop_strings() and use it in most places

Add a helper for qemu_fdt_setprop_strings() to take a set of strings to put into a device-tree, which removes several open-coded methods such as setting an char arr[] = {..} or setting char val[] = "str\0str2"; This is for hw/arm, hw/mips and hw/riscv as well as a couple of cores. It is not fully

[PATCH v3 1/5] device_tree: add qemu_fdt_setprop_strings() helper

Add a helper to set a property from a set of strings to reduce the following code: static const char * const clint_compat[2] = { "sifive,clint0", "riscv,clint0" }; qemu_fdt_setprop_string_array(fdt, nodename, "compatible", (char **)_compat, ARRAY_SIZE(clint_compat));

[PATCH v3 5/5] hw/arm: change to use qemu_fdt_setprop_strings()

Change to using qemu_fdt_setprop_strings() instead of using \0 separated string arrays. Signed-off-by: Ben Dooks --- hw/arm/boot.c | 8 +++--- hw/arm/virt.c | 28 + hw/arm/xlnx-versal-virt.c | 51 --- 3 files

[PATCH v3 3/5] hw/core: use qemu_fdt_setprop_strings()

Change to using the qemu_fdt_setprop_strings() helper in hw/core code. Signed-off-by: Ben Dooks --- hw/core/guest-loader.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/hw/core/guest-loader.c b/hw/core/guest-loader.c index 391c875a29..203090503e 100644 ---

Re: [PATCH v11 2/6] target/riscv: Simplify counter predicate function

On Wed, Jul 27, 2022 at 1:35 AM Weiwei Li wrote: > > 在 2022/7/27 下午2:49, Atish Patra 写道: > > All the hpmcounters and the fixed counters (CY, IR, TM) can be > represented > > as a unified counter. Thus, the predicate function doesn't need handle > each > > case separately. > > > > Simplify the

Re: [PATCH v11 1/6] target/riscv: Add sscofpmf extension support

On Wed, Jul 27, 2022 at 1:11 AM Weiwei Li wrote: > > 在 2022/7/27 下午2:49, Atish Patra 写道: > > The Sscofpmf ('Ss' for Privileged arch and Supervisor-level extensions, > > and 'cofpmf' for Count OverFlow and Privilege Mode Filtering) > > extension allows the perf to handle overflow interrupts and

Re: [RFC PATCH 8/8] tests/docker: Selective line reading by python script

+Erik/Daniel On Wed, Jul 27, 2022 at 6:37 PM Lucas Mateus Castro(alqotel) wrote: > > Building some images failed on ppc64le because the dockerfile tried to > install some packages that are only available in x86 and arm64, to solve > this while still having those packages be available in those

Re: When create a new qemu fork, can not run pipeline, what I need to do?

Cc'ing build and test automation maintainers. On Wed, Jul 27, 2022 at 1:22 PM 罗勇刚(Yonggang Luo) wrote: > > ··· > Pipeline cannot be run. > > No stages / jobs for this pipeline. > > The form contains the following warning: > > 121 warnings found: showing first 25 > > jobs:amd64-centos8-container

[PATCH 0/2] linux-user: Improve strace output

Two patches which improve the linux-user strace output: a) Add some missing signal names b) Add missing clock_gettime64() syscall Helge Deller (2): linux-user: Add missing signals in strace output linux-user: Add missing clock_gettime64() syscall strace linux-user/signal-common.h | 46

[PATCH 1/2] linux-user: Add missing signals in strace output

Some of the guest signal numbers are currently not converted to their representative names in the strace output, e.g. SIGVTALRM. This patch introduces a smart way to generate and keep in sync the host-to-guest and guest-to-host signal conversion tables for usage in the qemu signal and strace

[PATCH 2/2] linux-user: Add missing clock_gettime64() syscall strace

Allow linux-user to strace the clock_gettime64() syscall. This syscall is used a lot on 32-bit guest architectures which use newer glibc versions. Signed-off-by: Helge Deller --- linux-user/strace.c| 53 ++ linux-user/strace.list | 4 2 files

[PATCH] WHPX: Add support for device backed memory regions

Due to skipping the mapping of read only device memory, Windows Hypervisor Platform would fail to emulate such memory accesses when booting OVMF EDK2 firmware. This patch adds ROM device memory region support for WHPX since the Windows Hypervisor Platform supports mapping read-only device memory,

Re: [PULL 14/15] qdev: Base object creation on QDict rather than QemuOpts

Am 07.07.2022 um 22:24 hat Peter Maydell geschrieben: > On Mon, 4 Jul 2022 at 05:50, Markus Armbruster wrote: > > My initial (knee-jerk) reaction to breaking array properties: Faster, > > Pussycat! Kill! Kill! > > In an ideal world, what would you replace them with? The next (and final) patch

Re: [RFC v3 1/8] blkio: add io_uring block driver using libblkio

Am 08.07.2022 um 06:17 hat Stefan Hajnoczi geschrieben: > libblkio (https://gitlab.com/libblkio/libblkio/) is a library for > high-performance disk I/O. It currently supports io_uring and > virtio-blk-vhost-vdpa with additional drivers under development. > > One of the reasons for developing

[PULL 2/2] iotests/131: Add parallels regression test

From: Hanna Reitz Test an allocating write to a parallels image that has a backing node. Before HEAD^, doing so used to give me a failed assertion (when the backing node contains only `42` bytes; the results varies with the value chosen, for `0` bytes, for example, all I get is EIO).

[PULL 1/2] block/parallels: Fix buffer-based write call

From: Hanna Reitz Commit a4072543ccdddbd241d5962d9237b8b41fd006bf has changed the I/O here from working on a local one-element I/O vector to just using the buffer directly (using the bdrv_co_pread()/bdrv_co_pwrite() helper functions introduced shortly before). However, it only changed the

[PULL 0/2] block: fix parallels block driver

The following changes since commit f6cce6bcb2ef959cdd4da0e368f7c72045f21d6d: Merge tag 'pull-target-arm-20220726' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-07-26 08:32:01 -0700) are available in the Git repository at: https://gitlab.com/vsementsov/qemu.git

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

Am 18.07.2022 um 11:49 hat Markus Armbruster geschrieben: > Hao Wu writes: > > > This type is used to represent block devs that are not suitable to > > be represented by other existing types. > > > > A sample use is to represent an at24c eeprom device defined in > > hw/nvram/eeprom_at24c.c. The

Re: [PATCH] hw/intc: sifive_plic: Fix multi-socket plic configuraiton

On Wed, Jul 27, 2022 at 5:23 AM Alistair Francis wrote: > On Sat, Jul 23, 2022 at 7:22 PM Atish Patra wrote: > > > > Since commit 40244040a7ac, multi-socket configuration with plic is > > broken as the hartid for second socket is calculated incorrectly. > > The hartid stored in addr_config

Re: [PATCH v4 04/17] dump: Rework get_start_block

On 7/26/22 11:22, Janosch Frank wrote: > get_start_block() returns the start address of the first memory block > or -1. > > With the GuestPhysBlock iterator conversion we don't need to set the > start address and can therefore remove that code. The only > functionality left is the validation of

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

On Mon, 25 Jul 2022, Ani Sinha wrote: > > > On Sat, 16 Jul 2022, Michael S. Tsirkin wrote: > > > On Sat, Jul 16, 2022 at 12:06:00PM +0530, Ani Sinha wrote: > > > > > > > > > On Fri, Jul 15, 2022 at 11:20 Michael S. Tsirkin wrote: > > > > > > On Fri, Jul 15, 2022 at 09:47:27AM +0530, Ani

Re: [PATCH v4 03/17] dump: Convert GuestPhysBlock iterators and use the filter functions

On 7/26/22 11:22, Janosch Frank wrote: > The iteration over the memblocks is hard to understand so it's about > time to clean it up. Instead of manually grabbing the next memblock we > can use QTAILQ_FOREACH to iterate over all memblocks. > > Additionally we move the calculation of the offset and

Re: [PATCH v4 01/17] dump: Rename write_elf_loads to write_elf_phdr_loads

On 7/26/22 11:22, Janosch Frank wrote: > Let's make it a bit clearer that we write the program headers of the > PT_LOAD type. > > Signed-off-by: Janosch Frank > Reviewed-by: Marc-André Lureau Reviewed-by: Janis Schoetterl-Glausch > --- > dump/dump.c | 6 +++--- > 1 file changed, 3

Re: [PATCH v3 05/12] ppc/pnv: turn PnvPHB4 into a PnvPHB backend

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 1df91971b8..b7273f386e 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -672,7 +672,14 @@ static void pnv_chip_power8_pic_print_info(PnvChip *chip, Monitor *mon) static int

Re: [PATCH for 7.1 2/2] aspeed/fby35: Fix owner of the BMC RAM memory region

On Wed, Jul 27, 2022 at 12:27:14PM +0200, Cédric Le Goater wrote: > A MachineState object is used as a owner of the RAM region and this > asserts in memory_region_init_ram() when QEMU is built with > CONFIG_QOM_CAST_DEBUG : > > /* This will assert if owner is neither NULL nor a DeviceState. >

Re: [PATCH v2 6/9] aspeed: Add AST2600 (BMC) to fby35

On Wed, Jul 27, 2022 at 12:05:58PM +0200, Cédric Le Goater wrote: > On 7/5/22 21:13, Peter Delevoryas wrote: > > You can test booting the BMC with both '-device loader' and '-drive > > file'. This is necessary because of how the fb-openbmc boot sequence > > works (jump to 0x2000 after U-Boot

Re: [PATCH v3 10/12] ppc/pnv: remove pecc->rp_model

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: The attribute is unused. Signed-off-by: Daniel Henrique Barboza --- Reviewed-by: Frederic Barrat Fred hw/pci-host/pnv_phb4_pec.c | 2 -- include/hw/pci-host/pnv_phb4.h | 1 - 2 files changed, 3 deletions(-) diff --git

Re: [PATCH v3 09/12] ppc/pnv: remove root port name from pnv_phb_attach_root_port()

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: We support only a single root port, PNV_PHB_ROOT_PORT. Signed-off-by: Daniel Henrique Barboza --- Reviewed-by: Frederic Barrat Fred hw/pci-host/pnv_phb.c | 7 +-- hw/ppc/pnv.c | 9 + include/hw/ppc/pnv.h

Re: [PATCH v3 06/12] ppc/pnv: add pnv-phb-root-port device

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: We have two very similar root-port devices, pnv-phb3-root-port and pnv-phb4-root-port. Both consist of a wrapper around the PCIESlot device that, until now, has no additional attributes. The main difference between the PHB3 and PHB4 root

Re: [PATCH v3 12/12] ppc/pnv: move attach_root_port helper to pnv-phb.c

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: The helper is only used in this file. Signed-off-by: Daniel Henrique Barboza --- Reviewed-by: Frederic Barrat Fred hw/pci-host/pnv_phb.c | 24 hw/ppc/pnv.c | 25 -

Re: [PATCH v3 08/12] ppc/pnv: remove pnv-phb4-root-port

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: The unified pnv-phb-root-port can be used instead. The phb4-root-port device isn't exposed to the user in any official QEMU release so there's no ABI breakage in removing it. Signed-off-by: Daniel Henrique Barboza --- Reviewed-by:

Re: [PATCH v3 11/12] ppc/pnv: remove PnvPHB4.version

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: It's unused. Signed-off-by: Daniel Henrique Barboza --- Reviewed-by: Frederic Barrat Fred include/hw/pci-host/pnv_phb4.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/pci-host/pnv_phb4.h

Re: [PATCH] virtio-pci: don't touch pci on virtio reset

Hmm, no that's not it, still segfault in ovs, but I'll try to see if I can merge that and the workaround I am currently using... On 7/27/22 19:14, Claudio Fontana wrote: > testing it now... > > Thanks! > > C > > > On 7/27/22 18:14, Michael S. Tsirkin wrote: >> virtio level reset should not

Re: [PATCH v3 02/12] ppc/pnv: add PnvPHB base/proxy device

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: The PnvPHB device is going to be the base device for all other powernv PHBs. It consists of a device that has the same user API as the other PHB, namely being a PCIHostBridge and having chip-id and index properties. It also has a 'backend'

Re: [PATCH v3 07/12] ppc/pnv: remove pnv-phb3-root-port

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: The unified pnv-phb-root-port can be used in its place. There is no ABI breakage in doing so because no official QEMU release introduced user creatable pnv-phb3-root-port devices. Signed-off-by: Daniel Henrique Barboza --- Reviewed-by:

Re: [PATCH v3 04/12] ppc/pnv: add PHB4 bus init helper

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: Similar to what we already did for the PnvPHB3 device, let's add a helper to init the bus when using a PnvPHB4. This helper will be used by PnvPHb when PnvPHB4 turns into a backend. Signed-off-by: Daniel Henrique Barboza ---

Re: [PATCH v3 01/12] ppc/pnv: add PHB3 bus init helper

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: The PnvPHB3 bus init consists of initializing the pci_io and pci_mmio regions, registering it via pci_register_root_bus() and then setup the iommu. We'll want to init the bus from outside pnv_phb3.c when the bus is removed from the PnvPHB3

Re: [PATCH v3 03/12] ppc/pnv: turn PnvPHB3 into a PnvPHB backend

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: We need a handful of changes that needs to be done in a single swoop to turn PnvPHB3 into a PnvPHB backend. In the PnvPHB3, since the PnvPHB device implements PCIExpressHost and will hold the PCI bus, change PnvPHB3 parent to TYPE_DEVICE.

Re: [PATCH v3 00/12] powernv: introduce pnv-phb base/proxy devices

On 24/06/2022 10:49, Daniel Henrique Barboza wrote: Hi, This is the version 3 of the pnv-phb proxy device which has the following main differences from v2: - it's rebased on top of "[PATCH v3 0/8] pnv-phb related cleanups" - it doesn't have any patches related to user-created devices There

Re: [PATCH] contrib/vhost-user-blk: Clean up deallocation of VuVirtqElement

On Tue, Jul 26, 2022 at 03:57:42PM +0100, Peter Maydell wrote: > On Fri, 1 Jul 2022 at 06:41, Markus Armbruster wrote: > > Could we use a contrib/README with an explanation what "contrib" means, > > and how to build and use the stuff there? > > I would rather we got rid of contrib/ entirely. Our

Re: [PATCH 1/8] tests/docker: Fix alpine dockerfile

On 27/07/2022 14:09, Daniel P. Berrangé wrote: On Wed, Jul 27, 2022 at 01:36:25PM -0300, Lucas Mateus Castro(alqotel) wrote: Currently the run script uses 'readlink -e' but the image only has the busybox readlink, this commit add the coreutils package which contains the readlink with the '-e'

Re: [PATCH] virtio-pci: don't touch pci on virtio reset

testing it now... Thanks! C On 7/27/22 18:14, Michael S. Tsirkin wrote: > virtio level reset should not affect pci express > registers such as PM, error or link. > > Fixes: 27ce0f3afc ("hw/virtio: fix Power Management Control Register for PCI > Express virtio devices") > Fixes: d584f1b9ca

Re: [PATCH] block/io_uring: add missing include file

Am 21.07.2022 um 09:09 hat Stefano Garzarella geschrieben: > On Thu, Jul 21, 2022 at 02:56:45PM +0800, Jinhao Fan wrote: > > The commit "Use io_uring_register_ring_fd() to skip fd operations" uses > > warn_report but did not include the header file "qemu/error-report.h". > > This causes "error:

Re: [PATCH 1/8] tests/docker: Fix alpine dockerfile

On Wed, Jul 27, 2022 at 01:36:25PM -0300, Lucas Mateus Castro(alqotel) wrote: > Currently the run script uses 'readlink -e' but the image only has the > busybox readlink, this commit add the coreutils package which > contains the readlink with the '-e' option. Use of 'readlink' is discouraged in

[RFC PATCH 8/8] tests/docker: Selective line reading by python script

Building some images failed on ppc64le because the dockerfile tried to install some packages that are only available in x86 and arm64, to solve this while still having those packages be available in those architectures a comment was put before the installation command to instruct the python script

[PATCH 6/8] scripts/ci/setup: Add Fedora to build-environment.yml

Minicloud doesn't have a RHEL image, but it does have Fedora 34 and 35 images and both use DNF as package manager, so just change the ansible facts to check if it's RHEL or Fedora Signed-off-by: Lucas Mateus Castro(alqotel) --- scripts/ci/setup/build-environment.yml | 12 1 file

[PATCH 2/8] scripts/ci/setup: ninja missing from build-environment

ninja-build is missing from the RHEL environment, so a system prepared with that script would still fail to compile QEMU. Tested on a Fedora 36 Signed-off-by: Lucas Mateus Castro(alqotel) --- scripts/ci/setup/build-environment.yml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 3/8] scripts/ci/setup: Fix libxen requirements

XEN hypervisor is only available in ARM and x86, but the yaml only checked if the architecture is different from s390x, changed it to a more accurate test. Tested this change on a Ubuntu 20.04 ppc64le. Signed-off-by: Lucas Mateus Castro(alqotel) --- scripts/ci/setup/build-environment.yml | 2 +-

[PATCH 7/8] scripts/ci/setup: Added debian to build-environment.yml

Minicloud has a PPC64 BE Debian11 image which can be used for the CI, so add Debian to the build-environment.yml so it can be configured with ansible-playbook. Signed-off-by: Lucas Mateus Castro(alqotel) --- scripts/ci/setup/build-environment.yml | 31 +- 1 file changed,

[PATCH 5/8] scripts/ci/setup: Add ppc64le to vars.yml template

Added ppc64le so that the gitlab-runner.yml could be used to set up ppc64le runners. Signed-off-by: Lucas Mateus Castro(alqotel) --- scripts/ci/setup/vars.yml.template | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/ci/setup/vars.yml.template b/scripts/ci/setup/vars.yml.template

[PATCH 1/8] tests/docker: Fix alpine dockerfile

Currently the run script uses 'readlink -e' but the image only has the busybox readlink, this commit add the coreutils package which contains the readlink with the '-e' option. Signed-off-by: Lucas Mateus Castro(alqotel) --- tests/docker/dockerfiles/alpine.docker | 1 + 1 file changed, 1

Re: [PATCH v3 05/21] block/vhost-user-blk-server: don't expose VHOST_USER_F_PROTOCOL_FEATURES

Am 26.07.2022 um 21:21 hat Alex Bennée geschrieben: > This bit is unused in actual VirtIO feature negotiation and should > only appear in the vhost-user messages between master and slave. > > [AJB: experiment, this doesn't break the tests but I'm not super > confident of the range of tests] > >

[PATCH 4/8] scripts/ci/setup: spice-server only on x86 aarch64

Changed build-environment.yml to only install spice-server on x86_64 and aarch64 as this package is only available on those architectures. Signed-off-by: Lucas Mateus Castro(alqotel) --- scripts/ci/setup/build-environment.yml | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-)

[PATCH 0/8] Patch series to set up a ppc64le CI

This patch series aim to make easier to set up a compilation and CI environment in PPC64 and PPC64LE machines. The first 2 patches is a fix not related to ppc64. Patch 3 and 4 also affect some other architectures. Patches 5 to 7 are adding Power specific additions. Patch 8 is a RFC for a current

Re: virtio: why no full reset on virtio_set_status 0 ?

On Wed, Jul 27, 2022 at 12:51:31PM +0200, Claudio Fontana wrote: > Hi Michael and all, > > I have started researching a qemu / ovs / dpdk bug: > > https://inbox.dpdk.org/dev/322122fb-619d-96f6-5c3e-9eabdbf38...@redhat.com/T/ > > that seems to be affecting multiple parties in the telco space, >

[PATCH] virtio-pci: don't touch pci on virtio reset

virtio level reset should not affect pci express registers such as PM, error or link. Fixes: 27ce0f3afc ("hw/virtio: fix Power Management Control Register for PCI Express virtio devices") Fixes: d584f1b9ca ("hw/virtio: fix Link Control Register for PCI Express virtio devices") Fixes: c2cabb3422

Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

On 7/25/22 15:21, Emanuele Giuseppe Esposito wrote: The aim of this series is to reorganize bdrv_try_set_aio_context and drop BDS ->set_aio_context and ->can_set_aio_ctx callbacks in favour of a new one, ->change_aio_ctx. More informations in patch 3 (which is also RFC, due to the doubts I have

Re: [RFC v4 5/9] qemu-iotests: test new zone operations.

On Wed, Jul 27, 2022 at 10:34:56AM -0400, Stefan Hajnoczi wrote: > On Mon, 11 Jul 2022 at 22:21, Sam Li wrote: > > > > We have added new block layer APIs of zoned block devices. Test it with: > > (1) Create a null_blk device, run each zone operation on it and see > > whether reporting right zone

[PATCH v1 3/5] hw/virtio: gracefully handle unset vhost_dev vdev

I've noticed asserts firing because we query the status of vdev after a vhost connection is closed down. Rather than faulting on the NULL indirect just quietly reply false. Signed-off-by: Alex Bennée Message-Id: <20220726192150.2435175-8-alex.ben...@linaro.org> --- hw/virtio/vhost.c | 10

[PATCH v1 2/5] hw/virtio: incorporate backend features in features

There are some extra bits used over a vhost-user connection which are hidden from the device itself. We need to set them here to ensure we enable things like the protocol extensions. Currently net/vhost-user.c has it's own inscrutable way of persisting this data but it really should live in the

[PATCH v1 5/5] hw/virtio: fix vhost_user_read tracepoint

As reads happen in the callback we were never seeing them. We only really care about the header so move the tracepoint to when the header is complete. Fixes: 6ca6d8ee9d (hw/virtio: add vhost_user_[read|write] trace points) Signed-off-by: Alex Bennée Message-Id:

[PATCH v1 4/5] hw/virtio: handle un-configured shutdown in virtio-pci

The assert() protecting against leakage is a little aggressive and causes needless crashes if a device is shutdown without having been configured. In this case no descriptors are lost because none have been assigned. Signed-off-by: Alex Bennée Message-Id:

[PATCH v1 1/5] block/vhost-user-blk-server: don't expose VHOST_USER_F_PROTOCOL_FEATURES

This bit is unused in actual VirtIO feature negotiation and should only appear in the vhost-user messages between master and slave. [AJB: experiment, this doesn't break the tests but I'm not super confident of the range of tests] Signed-off-by: Alex Bennée Message-Id:

[PATCH for 7.1 v1 0/5] virtio fixes (split from virtio-gpio series)

Hi, This is just a split out series based on: Subject: [PATCH v3 for 7.2 00/21] virtio-gpio and various virtio cleanups Date: Tue, 26 Jul 2022 20:21:29 +0100 Message-Id: <20220726192150.2435175-1-alex.ben...@linaro.org> with the patches identified by mst: Right. Still I think some

Re: [PATCH v10 18/21] job.c: enable job lock/unlock and remove Aiocontext locks

On 7/25/22 10:38, Emanuele Giuseppe Esposito wrote: Change the job_{lock/unlock} and macros to use job_mutex. Now that they are not nop anymore, remove the aiocontext to avoid deadlocks. Therefore: - when possible, remove completely the aiocontext lock/unlock pair - if it is used by some other

Re: [PATCH v2 07/11] vfio/migration: Implement VFIO migration protocol v2

On 7/18/2022 6:12 PM, Jason Gunthorpe wrote: On Mon, May 30, 2022 at 08:07:35PM +0300, Avihai Horon wrote: +/* Returns 1 if end-of-stream is reached, 0 if more data and -1 if error */ +static int vfio_save_block(QEMUFile *f, VFIOMigration *migration) +{ +ssize_t data_size; + +

Re: VIRTIO_NET_F_MTU not negotiated

On Wed, Jul 27, 2022 at 10:16:19AM +, Eli Cohen wrote: > > -Original Message- > > From: Michael S. Tsirkin > > Sent: Wednesday, July 27, 2022 12:35 PM > > To: Eli Cohen > > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; > > Jason Wang ; > >

Re: virtio: why no full reset on virtio_set_status 0 ?

On Wed, Jul 27, 2022 at 12:51:31PM +0200, Claudio Fontana wrote: > Hi Michael and all, > > I have started researching a qemu / ovs / dpdk bug: > > https://inbox.dpdk.org/dev/322122fb-619d-96f6-5c3e-9eabdbf38...@redhat.com/T/ > > that seems to be affecting multiple parties in the telco space, >

Re: [PATCH v10 17/21] blockjob: protect iostatus field in BlockJob struct

On 7/25/22 10:38, Emanuele Giuseppe Esposito wrote: iostatus is the only field (together with .job) that needs protection using the job mutex. It is set in the main loop (GLOBAL_STATE functions) but read in I/O code (block_job_error_action). Hmm, block_job_error_action doesn't read iostatus..

Re: fu740 target

On 27/07/2022 15:38, Bin Meng wrote: On Wed, Jul 27, 2022 at 10:24 PM Ben Dooks wrote: Is anyone working on adding a sifive-u74 core to the list of supported CPU types? I was looking at full emulation of the Unmatched but at the moment the best we have is sifive-u54 and I think that misses at

Re: [PATCH v10 14/21] jobs: protect job.aio_context with BQL and job_mutex

On 7/25/22 10:38, Emanuele Giuseppe Esposito wrote: In order to make it thread safe, implement a "fake rwlock", where we allow reads under BQL *or* job_mutex held, but writes only under BQL *and* job_mutex. The only write we have is in child_job_set_aio_ctx, which always happens under drain (so

Re: [RFC] hw/nvme: Use irqfd to send interrupts

On Wed, 27 Jul 2022 at 03:18, Klaus Jensen wrote: > > On Jul 21 09:29, Stefan Hajnoczi wrote: > > On Wed, Jul 20, 2022, 22:36 Jinhao Fan wrote: > > > > > Hi Stefan, > > > > > > Thanks for the detailed explanation! > > > > > > at 6:21 PM, Stefan Hajnoczi wrote: > > > > > > > Hi Jinhao, > > > >

Re: [RFC v4 0/9] Add support for zoned device

Stefan Hajnoczi 于2022年7月27日周三 23:06写道： > > This patch series introduces the concept of zoned storage to the QEMU > block layer. Documentation is needed so that users and developers know > how to use and maintain this feature. > > As a minimum, let's document how to pass through zoned block

Re: [RFC v4 5/9] qemu-iotests: test new zone operations.

On Wed, 27 Jul 2022 at 11:00, Ming Lei wrote: > > On Wed, Jul 27, 2022 at 10:34:56AM -0400, Stefan Hajnoczi wrote: > > On Mon, 11 Jul 2022 at 22:21, Sam Li wrote: > > > > > > We have added new block layer APIs of zoned block devices. Test it with: > > > (1) Create a null_blk device, run each

Re: [PATCH v4] hw/nvme: Use ioeventfd to handle doorbell updates

After digging through the source code, I found event_notifier_cleanup() only closes the eventfd, but does not de-register the event from QEMU’s event loop. event_notifier_set_handler() actually interacts with the event loop. It is a wrapper around aio_set_event_notifier(), which is again a wrapper

Re: [RFC v4 0/9] Add support for zoned device

This patch series introduces the concept of zoned storage to the QEMU block layer. Documentation is needed so that users and developers know how to use and maintain this feature. As a minimum, let's document how to pass through zoned block devices on Linux: diff --git

Re: [PATCH] target/riscv: Ensure opcode is saved for every instruction

On 7/26/22 21:06, Anup Patel wrote: I see that decode_save_opc() only saves opcode in an array through tcg_set_insn_start_param(). Which brings me to the question about how much are we saving by distributing decode_save_opc() calls ? It's not about tcg_set_insn_start_param(), but later when it

Re: fu740 target

On Wed, Jul 27, 2022 at 10:44 PM Ben Dooks wrote: > > On 27/07/2022 15:38, Bin Meng wrote: > > On Wed, Jul 27, 2022 at 10:24 PM Ben Dooks wrote: > >> > >> Is anyone working on adding a sifive-u74 core to the list of supported > >> CPU types? I was looking at full emulation of the Unmatched but

Re: [RFC v4 9/9] qapi: add support for zoned host device

On Mon, 11 Jul 2022 at 22:31, Sam Li wrote: > > --- > block/file-posix.c | 8 +++- > qapi/block-core.json | 7 +-- > 2 files changed, 12 insertions(+), 3 deletions(-) Please squash this into the patch that adds zoned_host_device. Stefan

Re: [RFC v4 0/9] Add support for zoned device

On Mon, 11 Jul 2022 at 22:17, Sam Li wrote: > > This patch series adds support for zoned device to virtio-blk emulation. Zoned > Storage can support sequential writes, which reduces write amplification in > SSD, > leading to higher write throughput and increased capacity. Please use "git rebase

Re: [RFC v4 6/9] raw-format: add zone operations

On Mon, 11 Jul 2022 at 22:21, Sam Li wrote: > > Signed-off-by: Sam Li > --- > block/raw-format.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/block/raw-format.c b/block/raw-format.c > index 69fd650eaf..96bdb6c1e2 100644 > --- a/block/raw-format.c > +++

Re: [RFC v4 7/9] config: add check to block layer

On Mon, 11 Jul 2022 at 22:22, Sam Li wrote: > > Putting zoned/non-zoned BlockDrivers on top of each other is not > allowed. > > Signed-off-by: Sam Li > --- > block.c | 7 +++ > block/file-posix.c | 2 ++ > include/block/block_int-common.h | 5 + >

Re: [RFC v4 8/9] include: add support for zoned block devices

On Mon, 11 Jul 2022 at 22:21, Sam Li wrote: > > This is the virtio_blk.h header file from Dmitry's "virtio-blk: add > support for zoned block devices" patch. It introduces > virtio_blk_zoned_characteristics struct from Dmitry's virtio-blk zoned > storage spec. > > Signed-off-by: Dmitry Fomichev

  1   2   3   >