Re: [PATCH] util: remove support -chardev tty and -chardev parport

2022-12-17 Thread Marc-André Lureau
On Sun, Dec 18, 2022 at 4:08 AM Paolo Bonzini wrote: > > These were deprecated in 6.0 and can now be removed. > > Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau > --- > chardev/char.c | 33 ++--- > docs/about/deprecated.rst | 6

Re: Plugin Memory Callback Debugging

2022-12-17 Thread Emilio Cota
On Tue, Nov 29, 2022 at 15:37:51 -0500, Aaron Lindsay wrote: (snip) > > Does this hint that there are cases where reset cpu->plugin_mem_cbs to NULL > > is > > getting optimized away, but not the code to set it in the first place? > > Is there anyone who could help take a look at this from the cod

[PATCH] KVM: remove support for kernel-irqchip=off

2022-12-17 Thread Paolo Bonzini
-machine kernel-irqchip=off is broken for many guest OSes; kernel-irqchip=split is the replacement that works, so remove the deprecated support for the former. Signed-off-by: Paolo Bonzini --- docs/about/deprecated.rst | 7 --- docs/about/removed-features.rst | 7 +++ hw/i386/amd

[PATCH] util: remove support for hex numbers with a scaling suffix

2022-12-17 Thread Paolo Bonzini
This was deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini --- docs/about/deprecated.rst | 8 docs/about/removed-features.rst | 8 tests/unit/test-cutils.c| 8 util/cutils.c | 14 +++--- 4 files changed, 1

[PATCH] util: remove support -chardev tty and -chardev parport

2022-12-17 Thread Paolo Bonzini
These were deprecated in 6.0 and can now be removed. Signed-off-by: Paolo Bonzini --- chardev/char.c | 33 ++--- docs/about/deprecated.rst | 6 -- docs/about/removed-features.rst | 5 + docs/qdev-device-use.txt| 4 ++-- qemu-o

[PATCH] i386: SGX: remove deprecated member of SGXInfo

2022-12-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/about/deprecated.rst | 13 - docs/about/removed-features.rst | 13 + hw/i386/sgx.c | 15 ++- qapi/misc-target.json | 12 ++-- 4 files changed, 21 insertions(+), 32 deletions(-) dif

[PATCH] MIPS: remove support for trap and emulate KVM

2022-12-17 Thread Paolo Bonzini
This support was limited to the Malta board, drop it. I do not have a machine that can run VZ KVM, so I am assuming that it works for -M malta as well. Signed-off-by: Paolo Bonzini --- docs/about/deprecated.rst | 9 --- docs/about/removed-features.rst | 9 +++ hw/mips/malta.c

Re: [PATCH v2 7/7] hw/ppc/Kconfig: Remove unused dependencies from PEGASOS2

2022-12-17 Thread Philippe Mathieu-Daudé
On 16/12/22 14:03, Bernhard Beschow wrote: Removes the following dependencies from ppc-softmmu: - CONFIG_ACPI_CPU_HOTPLUG - CONFIG_ACPI_CXL - CONFIG_ACPI_HMAT - CONFIG_ACPI_MEMORY_HOTPLUG - CONFIG_ACPI_NVDIMM - CONFIG_ACPI_PCIHP - CONFIG_ACPI_X86 - CONFIG_MEM_DEVICE Signed-off-by: Bernhard Besch

Re: [PATCH v2 6/7] i386, mips: Resolve redundant ACPI and APM dependencies

2022-12-17 Thread Philippe Mathieu-Daudé
On 16/12/22 14:03, Bernhard Beschow wrote: Now that all ACPI controllers select the ACPI and APM dependencies themselves, these explicit dependencies became redundant. Remove them. Signed-off-by: Bernhard Beschow --- configs/devices/mips-softmmu/common.mak | 3 --- hw/i386/Kconfig

Re: [PATCH v2 5/7] hw/isa/Kconfig: Add missing dependency to VT82C686

2022-12-17 Thread Philippe Mathieu-Daudé
On 16/12/22 14:03, Bernhard Beschow wrote: The ACPIREGS are provided by TYPE_VIA_PM, so needs to select ACPI. Signed-off-by: Bernhard Beschow --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 4/7] hw/acpi/Kconfig: Add missing dependencies to ACPI_PIIX4

2022-12-17 Thread Philippe Mathieu-Daudé
On 16/12/22 14:03, Bernhard Beschow wrote: piix4_pm_realize() uses apm_init() and pm_smbus_init(), so both APM and ACPI_SMBUS are provided by the device model managed by ACPI_PIIX4. The ACPIREGS are also provided by ACPI_PIIX4, so needs to select ACPI. Signed-off-by: Bernhard Beschow --- hw/

Re: [PATCH v2 0/7] Clean up dependencies of ACPI controllers

2022-12-17 Thread Bernhard Beschow
Am 16. Dezember 2022 13:03:48 UTC schrieb Bernhard Beschow : >This small series establishes consistency between ICH9, PIIX4 and VT82C686 ACPI > >controllers to select ACPI, ACPI_SMBUS and APM since they are provided by the > >device models. > > > >Due to the PIIX4 PM cleanup PEGASOS2's dependenc

Re: [PULL 00/21] Hexagon update: bug fixes, performance, idef-parser

2022-12-17 Thread Peter Maydell
On Fri, 16 Dec 2022 at 20:49, Taylor Simpson wrote: > > The following changes since commit 4208e6ae114ac8266dcacc9696a443ce5c37b04e: > > Merge tag 'pull-request-2022-12-15' of https://gitlab.com/thuth/qemu into > staging (2022-12-15 21:39:56 +) > > are available in the Git repository at: >

Re: [PULL v2 0/6] QEMU Guest Agent misc patches

2022-12-17 Thread Peter Maydell
On Sat, 17 Dec 2022 at 09:07, Konstantin Kostiuk wrote: > > The following changes since commit d038d2645acabf6f52fd61baeaa021c3ebe97714: > > Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging > (2022-12-16 13:26:09 +) > > are available in the Git repository at: > > g..

Re: [PULL 00/36] reset refactoring patches

2022-12-17 Thread Peter Maydell
On Fri, 16 Dec 2022 at 21:42, Peter Maydell wrote: > > This pull request collects up various reset-related patches > that I sent out and had reviewed during freeze. I've sent > them all here because they touch various devices across > the tree, and this seems more efficient than splitting them > a

Re: [PATCH v2] linux-user: fix getgroups/setgroups allocations

2022-12-17 Thread Richard Henderson
On 12/17/22 01:31, Michael Tokarev wrote: linux-user getgroups(), setgroups(), getgroups32() and setgroups32() used alloca() to allocate grouplist arrays, with unchecked gidsetsize coming from the "guest". With NGROUPS_MAX being 65536 (linux, and it is common for an application to allocate NGROU

[PATCH] accel/tcg: Drop PAGE_RESERVED for CONFIG_BSD

2022-12-17 Thread Richard Henderson
Make bsd-user match linux-user in not marking host pages as reserved. This isn't especially effective anyway, as it doesn't take into account any heap memory that qemu may allocate after startup. Cc: Warner Losh Signed-off-by: Richard Henderson --- I started to simply fix up this code to match

[PATCH v2] linux-user: fix getgroups/setgroups allocations

2022-12-17 Thread Michael Tokarev
linux-user getgroups(), setgroups(), getgroups32() and setgroups32() used alloca() to allocate grouplist arrays, with unchecked gidsetsize coming from the "guest". With NGROUPS_MAX being 65536 (linux, and it is common for an application to allocate NGROUPS_MAX for getgroups()), this means a typica

Re: [PATCH v2 6/9] target/riscv/cpu: Move Floating-Point fields closer

2022-12-17 Thread Richard Henderson
On 12/17/22 09:29, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/cpu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 5/9] target/ppc/kvm: Remove unused "sysbus.h" header

2022-12-17 Thread Richard Henderson
On 12/17/22 09:29, Philippe Mathieu-Daudé wrote: Nothing requires SysBus declarations here. Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/kvm.c | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 1/9] target/alpha: Remove obsolete STATUS document

2022-12-17 Thread Richard Henderson
On 12/17/22 09:28, Philippe Mathieu-Daudé wrote: Likely out of sync: last update is from 2008 (commit d1412eb240), 12 years ago. Signed-off-by: Philippe Mathieu-Daudé --- target/alpha/STATUS | 28 1 file changed, 28 deletions(-) delete mode 100644 target/alpha/S

Re: [PATCH v12 08/61] target/riscv: add fault-only-first unit stride load

2022-12-17 Thread Richard Henderson
On 12/17/22 10:21, Philippe Mathieu-Daudé wrote: (unburying an old patch) On 1/7/20 17:24, LIU Zhiwei wrote: The unit-stride fault-only-fault load instructions are used to vectorize loops with data-dependent exit conditions(while loops). These instructions execute as a regular load except that

Re: [PATCH 2/2] target/hppa: Extract system helpers to sys_helper.c

2022-12-17 Thread Richard Henderson
On 12/17/22 09:32, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- target/hppa/meson.build | 1 + target/hppa/op_helper.c | 77 --- target/hppa/sys_helper.c | 99 3 files changed, 100 insertions(+

Re: [PATCH 1/2] target/hppa: Extract FPU helpers to fpu_helper.c

2022-12-17 Thread Richard Henderson
On 12/17/22 09:32, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- target/hppa/fpu_helper.c | 450 +++ target/hppa/meson.build | 1 + target/hppa/op_helper.c | 427 - 3 files changed, 451 inse

Re: [PATCH v12 08/61] target/riscv: add fault-only-first unit stride load

2022-12-17 Thread Philippe Mathieu-Daudé
(unburying an old patch) On 1/7/20 17:24, LIU Zhiwei wrote: The unit-stride fault-only-fault load instructions are used to vectorize loops with data-dependent exit conditions(while loops). These instructions execute as a regular load except that they will only take a trap on element 0. Signed-o

[PATCH 2/2] linux-user: Replace use of lfs64 related functions and macros

2022-12-17 Thread Khem Raj
Builds defines -D_FILE_OFFSET_BITS=64 which makes the original functions anf macros behave same as their 64 suffixed counterparts. This also helps in compiling with latest musl C library, where these macros and functions are no more available under _GNU_SOURCE feature macro Signed-off-by: Khem Raj

[PATCH 1/2] contrib/vhost-user-blk: Replace lseek64 with lseek

2022-12-17 Thread Khem Raj
64bit off_t is already in use since build uses _FILE_OFFSET_BITS=64 already. Using lseek/off_t also makes it work with latest must without using _LARGEFILE64_SOURCE macro. This macro is implied with _GNU_SOURCE when using glibc but not with musl. Signed-off-by: Khem Raj Cc: Michael S. Tsirkin CC

Re: [PATCH v2 7/9] target/riscv/cpu: Restrict some sysemu-specific fields from CPUArchState

2022-12-17 Thread Philippe Mathieu-Daudé
On 17/12/22 18:29, Philippe Mathieu-Daudé wrote: The 'hwaddr' type is only available / meaningful on system emulation. Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/cpu.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/target/riscv/cpu.h b/targ

Re: [PATCH v2 5/5] target/s390x/tcg/excp_helper: Restrict system headers to sysemu

2022-12-17 Thread Richard Henderson
On 12/17/22 07:24, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/tcg/excp_helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~ diff --git a/target/s390x/tcg/excp_helper.c b/target/s390x/tcg/excp_h

Re: [PATCH v2 3/5] hw/s390x/pv: Restrict Protected Virtualization to sysemu

2022-12-17 Thread Richard Henderson
On 12/17/22 07:24, Philippe Mathieu-Daudé wrote: Protected Virtualization is irrelevant in user emulation. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/cpu_features.c | 4 target/s390x/cpu_models.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Rich

Re: [PATCH v2 2/5] hw/s390x/pv: Un-inline s390_pv_init()

2022-12-17 Thread Richard Henderson
On 12/17/22 07:24, Philippe Mathieu-Daudé wrote: @@ -251,7 +251,9 @@ struct S390PVGuestClass { int s390_pv_kvm_init(ConfidentialGuestSupport *cgs, Error **errp) { -if (!object_dynamic_cast(OBJECT(cgs), TYPE_S390_PV_GUEST)) { +assert(kvm_enabled()); + +if (!cgs || !object_dynam

[PATCH 2/2] target/hppa: Extract system helpers to sys_helper.c

2022-12-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/hppa/meson.build | 1 + target/hppa/op_helper.c | 77 --- target/hppa/sys_helper.c | 99 3 files changed, 100 insertions(+), 77 deletions(-) create mode 100644 target/hppa/sys

[PATCH 1/2] target/hppa: Extract FPU helpers to fpu_helper.c

2022-12-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/hppa/fpu_helper.c | 450 +++ target/hppa/meson.build | 1 + target/hppa/op_helper.c | 427 - 3 files changed, 451 insertions(+), 427 deletions(-) create mode 100644 target

[PATCH v2 9/9] target/xtensa/cpu: Include missing "memory.h" header

2022-12-17 Thread Philippe Mathieu-Daudé
Under system emulation, xtensa_cpu_initfn() calls memory_region_init_io(), itself declared in "exec/memory.h". Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/xtensa/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/xtensa/cpu.c b/target/xtensa/

[PATCH v2 8/9] target/sparc/sysemu: Remove pointless CONFIG_USER_ONLY guard

2022-12-17 Thread Philippe Mathieu-Daudé
Commit caac44a52a ("target/sparc: Make sparc_cpu_tlb_fill sysemu only") restricted mmu_helper.c to system emulation. Checking whether CONFIG_USER_ONLY is defined is now pointless. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/sparc/mmu_helper.c | 2 -- 1 file c

[PATCH 0/2] target/hppa: Extract System/FPU helpers from op_helper.c

2022-12-17 Thread Philippe Mathieu-Daudé
Extract 500 lines of op_helper.c into 2 new files: sys_helper.c and fpu_helper.c, easing my life with "cpu.h" header cleanup. Philippe Mathieu-Daudé (2): target/hppa: Extract FPU helpers to fpu_helper.c target/hppa: Extract system helpers to sys_helper.c target/hppa/fpu_helper.c | 450 ++

[PATCH v2 1/9] target/alpha: Remove obsolete STATUS document

2022-12-17 Thread Philippe Mathieu-Daudé
Likely out of sync: last update is from 2008 (commit d1412eb240), 12 years ago. Signed-off-by: Philippe Mathieu-Daudé --- target/alpha/STATUS | 28 1 file changed, 28 deletions(-) delete mode 100644 target/alpha/STATUS diff --git a/target/alpha/STATUS b/target/alph

[PATCH v2 6/9] target/riscv/cpu: Move Floating-Point fields closer

2022-12-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/cpu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index fc1f72e5c3..05fafebff7 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -143,7 +143,6 @@ typedef struct P

[PATCH v2 0/9] target/misc: Header cleanups around "cpu.h"

2022-12-17 Thread Philippe Mathieu-Daudé
These patches are part of a big refactor cleanup around "cpu.h". Most changes should be trivial IMHO. Since v1: - dropped patches including "cpu.h" in multiply included 'helper.h' - dropped Hexagon patch - better split sysemu fields in RISC-V's CPUArchState Bernhard Beschow (1): target/loongarc

[PATCH v2 5/9] target/ppc/kvm: Remove unused "sysbus.h" header

2022-12-17 Thread Philippe Mathieu-Daudé
Nothing requires SysBus declarations here. Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/kvm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 7c25348b7b..78f6fc50cd 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -32,7 +32,6 @@ #inclu

[PATCH v2 7/9] target/riscv/cpu: Restrict some sysemu-specific fields from CPUArchState

2022-12-17 Thread Philippe Mathieu-Daudé
The 'hwaddr' type is only available / meaningful on system emulation. Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/cpu.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 05fafebff7..71ea1bb411 100644 --

[PATCH v2 4/9] target/ppc/internal: Restrict MMU declarations to sysemu

2022-12-17 Thread Philippe Mathieu-Daudé
The 'hwaddr' type is only available / meaningful on system emulation. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/internal.h | 5 + 1 file changed, 5 insertions(+) diff --git a/target/ppc/internal.h b/target/ppc/internal.h index 337a362205..901bae6d3

[PATCH v2 2/9] target/loongarch/cpu: Remove unused "sysbus.h" header

2022-12-17 Thread Philippe Mathieu-Daudé
From: Bernhard Beschow The cpu is used in both user and system emulation context while sysbus.h is system-only. Remove it since it's not needed anyway. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v2 3/9] target/loongarch/cpu: Restrict "memory.h" header to sysemu

2022-12-17 Thread Philippe Mathieu-Daudé
Missed in 0093b9a5ee ("target/loongarch: Adjust functions and structure to support user-mode") while cleaning commit f84a2aacf5 ("target/loongarch: Add LoongArch IOCSR instruction"). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/loongarch/cpu.h | 2 ++ 1 file c

Re: [PATCH 4/4] coroutine: Break inclusion loop

2022-12-17 Thread Philippe Mathieu-Daudé
On 13/12/22 01:34, Paolo Bonzini wrote: On 12/8/22 15:23, Markus Armbruster wrote: > qemu/coroutine.h and qemu/lockable.h include each other.  Neither > header actually needs the other one. qemu/lockable.h wants qemu/coroutine.h because of the reference to qemu_co_mutex_loc

[PATCH v2 3/5] hw/s390x/pv: Restrict Protected Virtualization to sysemu

2022-12-17 Thread Philippe Mathieu-Daudé
Protected Virtualization is irrelevant in user emulation. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/cpu_features.c | 4 target/s390x/cpu_models.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c

Re: [QEMU][PATCH v2 10/11] hw/arm: introduce xenpv machine

2022-12-17 Thread Julien Grall
Hi, On 02/12/2022 22:36, Stefano Stabellini wrote: Do you know what Xen version your build env has? I think Alex is just building against upstream Xen. GUEST_TPM_BASE is not defined there yet. I think we would need to introduce in xen_common.h something like: #ifndef GUEST_TPM_BASE #define GU

[PATCH v2 4/5] target/s390x/tcg/misc_helper: Remove unused "memory.h" include

2022-12-17 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/tcg/misc_helper.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/s390x/tcg/misc_helper.c b/target/s390x/tcg/misc_helper.c index 71388a7119..576157b1f3 100644 --- a/target/s390x/tcg/misc_helper.c +++

[PATCH v2 2/5] hw/s390x/pv: Un-inline s390_pv_init()

2022-12-17 Thread Philippe Mathieu-Daudé
There is no point in having s390_pv_init() inlined. Directly call s390_pv_kvm_init() guarded by kvm_enabled() so the compiler can elide when CONFIG_KVM is not set. Signed-off-by: Philippe Mathieu-Daudé --- hw/s390x/pv.c | 4 +++- hw/s390x/s390-virtio-ccw.c | 6 -- include/hw/s

[PATCH v2 0/5] target/s390x: Header cleanups around "cpu.h"

2022-12-17 Thread Philippe Mathieu-Daudé
These patches are part of a big refactor cleanup around "cpu.h". Most changes should be trivial IMHO. Since v1: - Fixed s390_pv_init() on non-KVM hosts - Keep "exec/cpu_ldst.h" in user-emu (rth) Philippe Mathieu-Daudé (5): exec/memory: Expose memory_region_access_valid() hw/s390x/pv: Un-inlin

[PATCH v2 1/5] exec/memory: Expose memory_region_access_valid()

2022-12-17 Thread Philippe Mathieu-Daudé
Instead of having hardware device poking into memory internal API, expose memory_region_access_valid(). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- hw/s390x/s390-pci-inst.c | 2 +- include/exec/memory-internal.h | 4 include/exec/memory.h | 4 +++

[PATCH v2 5/5] target/s390x/tcg/excp_helper: Restrict system headers to sysemu

2022-12-17 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/tcg/excp_helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x/tcg/excp_helper.c b/target/s390x/tcg/excp_helper.c index fe02d82201..bc767f0443 100644 --- a/target/s390x/tcg/excp_helper.c +++ b/targe

Re: [PATCH] exec: Rename NEED_CPU_H -> CONFIG_TARGET

2022-12-17 Thread Peter Maydell
On Fri, 16 Dec 2022 at 22:09, Philippe Mathieu-Daudé wrote: > > 'NEED_CPU_H' guard target-specific code; it is defined by meson > altogether with the 'CONFIG_TARGET' definition. Since the latter > name is more meaningful, directly use it. > > Inspired-by: Peter Maydell > Signed-off-by: Philippe M

Re: [PULL 00/13] accel/tcg: Rewrite user-only vma tracking

2022-12-17 Thread Peter Maydell
On Fri, 16 Dec 2022 at 18:53, Richard Henderson wrote: > > The following changes since commit 4208e6ae114ac8266dcacc9696a443ce5c37b04e: > > Merge tag 'pull-request-2022-12-15' of https://gitlab.com/thuth/qemu into > staging (2022-12-15 21:39:56 +) > > are available in the Git repository at:

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-17 Thread Paolo Bonzini
On 12/16/22 20:07, Helge Deller wrote: @@ -3581,7 +3581,7 @@ subdir('qga') # Don't build qemu-keymap if xkbcommon is not explicitly enabled # when we don't build tools or system -if xkbcommon.found() +if xkbcommon.found() and have_system # used for the update-keymaps target, so include r

Re: [PATCH 03/10] target/loongarch/cpu: Remove unused "sysbus.h" header

2022-12-17 Thread Philippe Mathieu-Daudé
On 17/12/22 13:26, Bernhard Beschow wrote: Am 16. Dezember 2022 22:05:32 UTC schrieb "Philippe Mathieu-Daudé" : Nothing requires SysBus declarations here. Signed-off-by: Philippe Mathieu-Daudé --- target/loongarch/cpu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/target/loongarch/cpu.

Re: [PATCH for-8.0 00/30] Meson changes for QEMU 8.0

2022-12-17 Thread Paolo Bonzini
On 12/16/22 16:35, Daniel P. Berrangé wrote: So after applying this series, at least on Fedora, I barely needed configure at all, in so muc as the following successfully built AFAICT: $ mkdir build $ cat > build/config-host.mak < Yep. It wouldn't build the firmwares though, or be able to run T

Re: [PATCH 4/4] coroutine: Break inclusion loop

2022-12-17 Thread Paolo Bonzini
On 12/15/22 07:49, Markus Armbruster wrote: linux-user/ does not use coroutines, so I'd like to avoid that it includes qemu/coroutine.h. They include it even before the patch, via lockable.h. They do but there's a difference between "including lockable.h and implictly getting coroutine.h due

Re: [PATCH 03/10] target/loongarch/cpu: Remove unused "sysbus.h" header

2022-12-17 Thread Bernhard Beschow
Am 16. Dezember 2022 22:05:32 UTC schrieb "Philippe Mathieu-Daudé" : >Nothing requires SysBus declarations here. > >Signed-off-by: Philippe Mathieu-Daudé >--- > target/loongarch/cpu.h | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/target/loongarch/cpu.h b/target/loongarch/cpu.h >index e

Re: [PATCH 5/5] target/s390x/tcg/excp_helper: Restrict system headers to sysemu

2022-12-17 Thread Philippe Mathieu-Daudé
On 17/12/22 01:45, Richard Henderson wrote: On 12/16/22 14:04, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé ---   target/s390x/tcg/excp_helper.c | 10 +-   1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/s390x/tcg/excp_helper.c b/target/s390x/

Re: [PATCH 3/5] hw/s390x/pv: Simplify s390_is_pv() for user emulation

2022-12-17 Thread Philippe Mathieu-Daudé
On 16/12/22 23:04, Philippe Mathieu-Daudé wrote: Protected Virtualization is irrelevant in user emulation. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/s390x/pv.h | 8 1 file changed, 8 insertions(+) diff --git a/include/hw/s390x/pv.h b/include/hw/s390x/pv.h index 5bca5bcaf

Re: [PATCH 07/10] target/ppc/internal: Restrict MMU declarations to sysemu

2022-12-17 Thread Philippe Mathieu-Daudé
On 17/12/22 01:38, Richard Henderson wrote: On 12/16/22 14:05, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé ---   target/ppc/internal.h | 5 +   1 file changed, 5 insertions(+) diff --git a/target/ppc/internal.h b/target/ppc/internal.h index 337a362205..901bae6d39 100

Re: [PATCH 2/2] sysemu/kvm: Reduce target-specific declarations

2022-12-17 Thread Philippe Mathieu-Daudé
On 17/12/22 01:28, Richard Henderson wrote: On 12/16/22 14:07, Philippe Mathieu-Daudé wrote: Only the declarations using the target_ulong type are target specific. Signed-off-by: Philippe Mathieu-Daudé ---   include/sysemu/kvm.h | 25 -   1 file changed, 12 insertions(+)

Re: [PULL 0/8] QEMU Guest Agent misc patches

2022-12-17 Thread Konstantin Kostiuk
On Fri, Dec 16, 2022 at 11:47 PM Peter Maydell wrote: > On Fri, 16 Dec 2022 at 13:54, Konstantin Kostiuk > wrote: > > > > The following changes since commit > edc93f455fa823a9a5fcb3a8da430104c7375a0a: > > > > Revert "hw/loongarch/virt: Add cfi01 pflash device" (2022-12-05 > 11:24:35 -0500) > >

[PULL v2 2/6] qga:/qga-win: skip getting pci info for USB disks

2022-12-17 Thread Konstantin Kostiuk
From: Kfir Manor Skip getting PCI info from disks type USB and give them an empty PCI address instead. Signed-off-by: Kfir Manor Reviewed-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau Signed-off-by: Konstantin Kostiuk --- qga/commands-win32.c | 12 1 file changed, 8 in

[PULL v2 4/6] qga-win: add logging to Windows event log

2022-12-17 Thread Konstantin Kostiuk
From: Andrey Drobyshev via This commit allows QGA to write to Windows event log using Win32 API's ReportEvent() [1], much like syslog() under *nix guests. In order to generate log message definitions we use a very basic message text file [2], so that every QGA's message gets ID 1. The tools "wi

[PULL v2 1/6] qga:/qga-win: adding a empty PCI address creation function

2022-12-17 Thread Konstantin Kostiuk
From: Kfir Manor Refactoring code to avoid duplication of creating an empty PCI address code. Signed-off-by: Kfir Manor Reviewed-by: Konstantin Kostiuk Reviewed-by: Marc-André Lureau Signed-off-by: Konstantin Kostiuk --- qga/commands-win32.c | 20 +--- 1 file changed, 13 ins

[PULL v2 0/6] QEMU Guest Agent misc patches

2022-12-17 Thread Konstantin Kostiuk
The following changes since commit d038d2645acabf6f52fd61baeaa021c3ebe97714: Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2022-12-16 13:26:09 +) are available in the Git repository at: g...@github.com:kostyanf14/qemu.git tags/qga-pull-2022-12-17 for you to fe

[PULL v2 5/6] qga: map GLib log levels to system levels

2022-12-17 Thread Konstantin Kostiuk
From: Andrey Drobyshev via This patch translates GLib-specific log levels to system ones, so that they may be used by both *nix syslog() (as a "priority" argument) and Windows ReportEvent() (as a "wType" argument). Currently the only codepath to write to "syslog" domain is slog() function. Howe

[PULL v2 3/6] qga: Add initial OpenBSD and NetBSD support

2022-12-17 Thread Konstantin Kostiuk
From: Brad Smith qga: Add initial OpenBSD and NetBSD support Signed-off-by: Brad Smith Reviewed-by: Konstantin Kostiuk Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Konstantin Kostiuk --- meson.build | 2 +- qga/commands-bsd.c | 5 + qga/commands-posix.c | 9 +++-- q

[PULL v2 6/6] qga-win: choose the right libpcre version to include in MSI package

2022-12-17 Thread Konstantin Kostiuk
From: Andrey Drobyshev via According to GLib changelog [1], since version 2.73.2 GLib is using libpcre2 instead of libpcre. As a result, qemu-ga MSI installation fails due to missing DLL when linked with the newer GLib. This commit makes wixl to put the right libpcre version into the MSI bundle