Alex Williamson writes:
> On Mon, 27 Feb 2023 16:24:16 +
> Alex Bennée wrote:
>
>> Alex Williamson writes:
>>
>> > On Mon, 27 Feb 2023 11:32:57 +0100
>> > Philippe Mathieu-Daudé wrote:
>> >
>> >> Signed-off-by: Philippe Mathieu-Daudé
>> >
>> > Empty commit logs are a pet peeve of min
On Wed, Mar 1, 2023, 12:36 AM Markus Armbruster wrote:
> "Michael S. Tsirkin" writes:
>
> > On Tue, Feb 28, 2023 at 09:05:16PM +0100, Thomas Huth wrote:
> >> Well, without CI, I assume that the code will bitrot quite fast
> (considering
> >> that there are continuous improvements to TCG, for exa
On 28/2/23 20:06, Alex Bennée wrote:
To avoid lots of copy and paste lets deal with artefacts in a
template. This way we can filter out most of the pre-binary object and
library files we no longer need as we have the final binaries.
build-system-alpine also saved .git-submodule-status so for sim
"Michael S. Tsirkin" writes:
> On Tue, Feb 28, 2023 at 09:05:16PM +0100, Thomas Huth wrote:
>> Well, without CI, I assume that the code will bitrot quite fast (considering
>> that there are continuous improvements to TCG, for example).
>
> We have lots of hosts which we don't test with CI. They
On Wed, Mar 1, 2023 at 12:48 AM Daniel Xu wrote:
>
> When building with `--enable-sanitizers`, I was getting quite a few
> memory leak crashes from ASAN:
>
> [21/574] Generating pc-bios/keymaps/fr-ch with a custom command
> FAILED: pc-bios/keymaps/fr-ch
> /home/dxu/dev/qemu
On 1/3/23 07:51, Thomas Huth wrote:
On 28/02/2023 22.41, Philippe Mathieu-Daudé wrote:
On 28/2/23 20:06, Alex Bennée wrote:
To avoid lots of copy and paste lets deal with artefacts in a
template. This way we can filter out most of the pre-binary object and
library files we no longer need as we
On Thu, Jan 5, 2023 at 8:14 AM Laszlo Ersek wrote:
>
> On 1/4/23 13:35, Michael S. Tsirkin wrote:
> > On Wed, Jan 04, 2023 at 10:01:38AM +0100, Laszlo Ersek wrote:
> >> The modern ACPI CPU hotplug interface was introduced in the following
> >> series (aa1dd39ca307..679dd1a957df), released in v2.7.
On 28/02/2023 20.06, Alex Bennée wrote:
This test is exceptionally heavyweight (nearly 330s) compared to the
two (both endians) TuxRun baseline tests which complete in under 160s.
The coverage is slightly reduced but a more directed test could make
up the difference.
tests/avocado/tuxrun_baselin
On Mon, Feb 27, 2023 at 8:04 AM Jason Wang wrote:
>
>
> 在 2023/2/24 23:54, Eugenio Pérez 写道:
> > Only create iova_tree if and when it is needed.
> >
> > The cleanup keeps being responsible of last VQ but this change allows it
> > to merge both cleanup functions.
> >
> > Signed-off-by: Eugenio Pére
On 28/02/2023 22.41, Philippe Mathieu-Daudé wrote:
On 28/2/23 20:06, Alex Bennée wrote:
To avoid lots of copy and paste lets deal with artefacts in a
template. This way we can filter out most of the pre-binary object and
library files we no longer need as we have the final binaries.
build-syste
On Tue, Feb 28, 2023 at 8:05 PM Daniel P. Berrangé
wrote:
> On Tue, Feb 28, 2023 at 11:56:27AM +0200, Yuri Benditovich wrote:
> > On Mon, Feb 20, 2023 at 11:50 AM Daniel P. Berrangé >
> > wrote:
> >
> > > On Sun, Feb 19, 2023 at 06:20:58PM +0200, Andrew Melnychenko wrote:
> > > > Added a functio
Am 1. März 2023 00:17:11 UTC schrieb BALATON Zoltan :
>MorphOS sets the ISA PIC to level sensitive mode but QEMU does not
>support that so this causes a freeze if multiple devices try to raise
>a shared interrupt. Work around it by lowering the interrupt before
>raising it again if it is already
Am 1. März 2023 00:33:28 UTC schrieb BALATON Zoltan :
>On Wed, 1 Mar 2023, BALATON Zoltan wrote:
>> This partially reverts commit bb98e0f59cde84d9fddc60ae74ef7ddfca17
>> keeping the rename of a state field but reverting other cahanges which
>> break interrupts on pegasos2.
>
>I've found this
Am 1. März 2023 00:17:09 UTC schrieb BALATON Zoltan :
>The real VIA south bridges implement a PCI IRQ router which is configured
>by the BIOS or the OS. In order to respect these configurations, QEMU
>needs to implement it as well. The real chip may allow routing IRQs from
>internal functions in
On 28/02/2023 22.32, Michael S. Tsirkin wrote:
On Tue, Feb 28, 2023 at 09:05:16PM +0100, Thomas Huth wrote:
Well, without CI, I assume that the code will bitrot quite fast (considering
that there are continuous improvements to TCG, for example).
We have lots of hosts which we don't test with C
Optimize the virtio-balloon feature on the ARM platform by adding
a variable to keep track of the current hot-plugged pc-dimm size,
instead of traversing the virtual machine's memory modules to count
the current RAM size during the balloon inflation or deflation
process. This variable can be update
Hi Philippe:
We're checking it internally.
I'm sorry for the late response.
Thank you.
Regards,
Tyrone
-Original Message-
From: Philippe Mathieu-Daudé
Sent: Thursday, February 23, 2023 6:44 PM
To: Havard Skinnemoen ; peter.mayd...@linaro.org
Cc: qemu-...@nongnu.org; qemu-devel@nongnu.
On Mon, Feb 27, 2023 at 12:43:55PM -0500, Stefan Hajnoczi wrote:
> - Personally, I don't think this should exclude other efforts like
> Eldon's. We can always add more private runners!
Hi!
Thanks so much to Alex, Thomas, Gerd, et al for the pointers.
Although the month has passed and presumably g
On 2023/02/28 21:57, Michael S. Tsirkin wrote:
On Mon, Jan 30, 2023 at 11:55:18PM +0100, Philippe Mathieu-Daudé wrote:
On 30/1/23 14:50, Akihiko Odaki wrote:
The expiration time provided for timer_mod() can overflow if a
ridiculously large value is set to the comparator register. The
resulting
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h
index 839d91c0c7..66b1461caa 100644
--- a/include/tcg/tcg-op.h
+++ b/include/tcg/tcg-op.h
@@ -1285,6
These symbols are now unused.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op.h | 2 --
include/tcg/tcg.h| 28
tcg/tcg.c| 16
3 files changed, 46 deletions(-)
diff --git a/include/tcg/tcg
This is now equivalent to gen_tmp.
Reviewed-by: Taylor Simpson
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
target/hexagon/idef-parser/parser-helpers.c | 24 ++---
1 file changed, 2 insertions(+), 22 deletions(-)
diff --git a/target/hexagon/idef-par
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel Henrique Barboza
Signed-off-by: Richard Henderson
---
include/exec/gen-icount.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/exec/gen-icount.h b/include/exec/gen-icount.h
index 166170b08e..5b1794188f 10064
While the argument can only be TEMP_EBB or TEMP_TB,
it's more obvious this way.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/tcg/tcg.h | 18 +-
tcg/tcg.c | 8
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/i
Since tcg_temp_new is now identical, use that.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
target/mips/tcg/translate.c | 57 ++--
target/mips/tcg/nanomips_translate.c.inc | 4 +-
2 files changed, 16 insertions(+), 45 deletions(-)
d
Guest front-ends now get temps that span the lifetime of
the translation block by default, which avoids accidentally
using the temp across branches and invalidating the data.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/tcg/tcg.h | 8
1 file changed,
Since tcg_temp_new is now identical, use that.
In some cases we can avoid a copy from A0 or T0.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
target/i386/tcg/translate.c | 27 +--
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/t
Since tcg_temp_new_* is now identical, use those.
Reviewed-by: Taylor Simpson
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
target/hexagon/idef-parser/README.rst | 4 ++--
target/hexagon/gen_tcg.h| 4 ++--
target/hexagon/genptr.c
Since we now get TEMP_TB temporaries by default, we no longer
need to make copies across these loops. These were the only
uses of new_tmp_a64_local(), so remove that as well.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/tcg/translate-a64.h | 1 -
target/arm/tcg/t
Since tcg_temp_new_* is now identical, use those.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
target/xtensa/translate.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 8
Since tcg_temp_new is now identical, use that.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
target/ppc/translate.c | 6 +++---
target/ppc/translate/spe-impl.c.inc | 8
target/ppc/translate/vmx-impl.c.inc | 4 ++--
3 files changed, 9 insertions(+
All of these uses have quite local scope.
Avoid tcg_const_*, because we haven't added a corresponding
interface for TEMP_EBB. Use explicit tcg_gen_movi_* instead.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
accel/tcg/plugin-gen.c | 24 ++--
1 fi
All of these have obvious and quite local scope.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tcg-op-gvec.c | 186 -
tcg/tcg-op.c | 258 +++---
tcg/tcg.c | 2 +-
3 files change
Since tcg_temp_new_* is now identical, use those.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
target/arm/tcg/translate-sve.c | 6 +++---
target/arm/tcg/translate.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/target/arm/tcg/translat
Reusing TEMP_TB interferes with detecting whether the
temp can be adjusted to TEMP_EBB.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
include/tcg/tcg.h | 2 +-
tcg/tcg.c | 101 --
2 files changed, 53 insertions(+), 50 deletio
Use TEMP_TB as that is more explicit about the default
lifetime of the data. While "global" and "local" used
to be contrasting, we have more lifetimes than that now.
Do not yet rename tcg_temp_local_new_*, just the enum.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
Since tcg_temp_new is now identical, use that.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
target/cris/translate.c | 6 +++---
target/cris/translate_v10.c.inc | 10 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/target/cris/transl
Rewrite the sections which talked about 'local temporaries'.
Remove some assumptions which no longer hold.
Reviewed-by: Daniel Henrique Barboza
Signed-off-by: Richard Henderson
---
docs/devel/tcg-ops.rst | 230 +++--
1 file changed, 129 insertions(+), 101 del
Here we are creating a temp whose value needs to be replaced,
but always storing NULL into CPUState.plugin_mem_cbs.
Use tcg_constant_ptr(0) explicitly.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
accel/tcg/plugin-gen.c | 8 ++--
1 file changed, 2 insertions(+),
TCG internals will want to be able to allocate and reuse
explicitly life-limited temporaries.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/tcg/tcg.h | 28
1 file changed, 28 insertions(+)
diff --git a/include/tcg/tcg.h b/include/
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel Henrique Barboza
Signed-off-by: Richard Henderson
---
tcg/tcg-op-gvec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tcg/tcg-op-gvec.c b/tcg/tcg-op-gvec.c
index a42e13a773..291a65c4bf 100644
--- a/tcg/tcg-op-gvec.c
Since tcg_temp_new_i32 is now identical, use that.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/exec/gen-icount.h | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/include/exec/gen-icount.h b/include/exec/gen-icount.h
index 5b1794188f
This wasn't actually used at all, just some unused
macro re-definitions.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
target/hppa/translate.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 0102cf451b..cee
From: Anton Johansson via
tb-jmp-cache.h contains a few small functions that only exist to hide a
CF_PCREL check, however the caller often already performs such a check.
This patch moves CF_PCREL checks from the callee to the caller, and also
removes these functions which now only hide an access
In preparation for returning the number of insns generated
via the same pointer. Adjust only the prototypes so far.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/exec/translator.h | 4 ++--
accel/tcg/translate-all.c | 2 +-
accel/tcg/translator.c
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Taylor Simpson
Message-Id: <20230227135202.9710-25-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/hexagon/cpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-26-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/avr/cpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/avr/cpu.c b/target/a
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-23-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/i386/tcg/tcg-cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/i386/tcg/tcg-
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-22-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/loongarch/cpu.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/loongarch/
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-20-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/mips/tcg/exception.c | 3 ++-
target/mips/tcg/sysemu/special_helper.c | 2 +-
2 files changed,
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-10-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/arm/cpu-param.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/target/arm/cpu-param.h b/target/arm/cp
TEMP_NORMAL is a subset of TEMP_EBB. Promote single basic
block temps to single extended basic block.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/tcg/tcg.h | 2 --
tcg/tcg.c | 19 +++
2 files changed, 3 insertions(+), 18 deletions(-
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-13-a...@rev.ng>
Signed-off-by: Richard Henderson
---
accel/tcg/internal.h | 2 +-
accel/tcg/cpu-exec.c | 6 +++---
accel/tcg/tb-maint.c | 8
ac
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-28-a...@rev.ng>
Signed-off-by: Richard Henderson
---
include/exec/exec-all.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/include/exec/exec-all.h b/includ
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-6-a...@rev.ng>
Signed-off-by: Richard Henderson
---
include/exec/exec-all.h | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
diff -
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-21-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/microblaze/cpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/microblaze/c
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-8-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/i386/helper.c| 2 +-
target/i386/tcg/tcg-cpu.c | 6 +++---
target/i386/tcg/translate.c | 26
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-19-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/openrisc/cpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/openrisc/cpu.c
Just because the label reference count is more than 1 does
not mean we cannot remove a branch-to-next. By doing this
first, the label reference count may drop to 0, and then
the label itself gets removed as before.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tc
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-11-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/i386/cpu-param.h | 4
1 file changed, 4 deletions(-)
diff --git a/target/i386/cpu-param.h b/target/i3
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-4-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/arm/cpu.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Palmer Dabbelt
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-18-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/riscv/cpu.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-17-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/rx/cpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/rx/cpu.c b/target/rx/
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-27-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/arm/cpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/arm/cpu.c b/target
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-15-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/sparc/cpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/sparc/cpu.c b/tar
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-24-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/hppa/cpu.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/target/hppa/cpu.c b/
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-9-a...@rev.ng>
Signed-off-by: Richard Henderson
---
include/exec/cpu-defs.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/exec/cpu-defs.h b/include/exe
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-7-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/arm/tcg/translate.h | 2 +-
target/arm/cpu.c | 8
target/arm/tcg/translate-a64.c
Change the temps_in_use check to use assert not fprintf.
Move the assert for double-free before the check for count,
since that is the more immediate problem.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 12 +---
1 file changed, 5 insertions(+), 7
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-3-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/i386/cpu.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
in
Write back the number of insns that we attempt to translate,
so that if we longjmp out we have a more accurate limit for
the next attempt. This results in fewer restarts when some
limit is consumed by few instructions.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
ac
Attempt to reduce the lifetime of TEMP_TB.
Reviewed-by: Alex Bennée
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 70 +++
1 file changed, 70 insertions(+)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 71b6843eb1..1dbb24294e 100644
--- a/tcg/tcg
From: Daniel Henrique Barboza
probe_access_flags() as it is today uses probe_access_full(), which in
turn uses probe_access_internal() with size = 0. probe_access_internal()
then uses the size to call the tlb_fill() callback for the given CPU.
This size param ('fault_size' as probe_access_interna
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-14-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/tricore/cpu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/tricore/cpu.c b/
This makes it easier to assign blame with perf.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 1a31a30a0d..71b6843eb1 100644
-
From: Philippe Mathieu-Daudé
'dh_ctype_f32' is defined as 'float32', itself declared
in "fpu/softfloat-types.h". Include this header to avoid
when refactoring other headers:
In file included from include/exec/helper-proto.h:7,
from include/tcg/tcg-op.h:29,
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-16-a...@rev.ng>
Signed-off-by: Richard Henderson
---
target/sh4/cpu.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/sh4/cpu.c b/targ
From: Anton Johansson via
Adds a new field to TranslationBlock.cflags denoting whether or not the
instructions of a given translation block are pc-relative. This field
aims to replace the macro `TARGET_TB_PCREL`.
Signed-off-by: Anton Johansson
Reviewed-by: Richard Henderson
Reviewed-by: Philip
s/pull-tcg-20230228
for you to fetch changes up to c7fbf10db8718d2eba87712bc3410b671157a377:
tcg: Update docs/devel/tcg-ops.rst for temporary changes (2023-02-28 10:36:19
-1000)
helper-head: Add fpu/softfloat-types.h
softmmu: Use
From: Anton Johansson via
Signed-off-by: Anton Johansson
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20230227135202.9710-5-a...@rev.ng>
Signed-off-by: Richard Henderson
---
accel/tcg/internal.h | 10
accel/tcg/tb-jmp-cache.h | 48 +++
ac
Change to match the recent change to probe_access_flags.
All existing callers updated to supply 0, so no change in behaviour.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel Henrique Barboza
Signed-off-by: Richard Henderson
---
include/exec/exec-all.h | 2 +-
accel/tcg/cpu
From: Akihiko Odaki
We found a case where the source passed to flatview_write_continue() may
overlap with the destination when fuzzing igb, a new proposed network
device with sanitizers.
igb uses pci_dma_map() to get Tx packet, and pci_dma_write() to write Rx
buffer. While pci_dma_write() is usu
On 2/28/23 22:58, Michael S. Tsirkin wrote:
On Tue, Feb 28, 2023 at 02:21:17PM +, Daniel P. Berrangé wrote:
On Tue, Feb 28, 2023 at 09:13:30AM -0500, Michael S. Tsirkin wrote:
On Tue, Feb 28, 2023 at 01:17:52PM +, Daniel P. Berrangé wrote:
On Tue, Feb 28, 2023 at 07:56:14AM -0500, M
Now we have a QMP command to query crypto devices:
virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq
{
"return": [
{
"service": [
"akcipher",
"mac",
"hash",
"cipher"
],
"id": "cryptodev1",
"client": [
{
v5 -> v6:
- Rebase code against the latest version:
627634031092e1514f363fd8659a579398de0f0e
- Markus has already separated HMP commands from monitor/* into subsystems, so
rework patch '0007-hmp-add-cryptodev-info-command.patch', move cryptodev HMP
command implements into backends/cryptodev-hm
Account OPS/BPS for crypto device, this will be used for 'query-stats'
QEMU monitor command and QoS in the next step.
Note that a crypto device may support symmetric mode, asymmetric mode,
both symmetric and asymmetric mode. So we use two structure to
describe the statistics of a crypto device.
S
Example of this command:
# virsh qemu-monitor-command vm --hmp info cryptodev
cryptodev1: service=[akcipher|mac|hash|cipher]
queue 0: type=builtin
cryptodev0: service=[akcipher]
queue 0: type=lkcf
Signed-off-by: zhenwei pi
---
backends/cryptodev-hmp-cmds.c | 54 +
Now we can use "query-stats" QMP command to query statistics of
crypto devices. (Originally this was designed to show statistics
by '{"execute": "query-cryptodev"}'. Daniel Berrangé suggested that
querying configuration info by "query-cryptodev", and querying
runtime performance info by "query-stat
I developed the akcipher service, QoS setting, QMP/HMP commands and
statistics accounting for crypto device. Making myself as the
maintainer for QEMU's cryptodev.
Cc: Gonglei
Signed-off-by: zhenwei pi
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
Move queue_index, CryptoDevCompletionFunc and opaque into struct
CryptoDevBackendOpInfo, then cryptodev_backend_crypto_operation()
needs an argument CryptoDevBackendOpInfo *op_info only. And remove
VirtIOCryptoReq from cryptodev. It's also possible to hide
VirtIOCryptoReq into virtio-crypto.c in th
Introduce cryptodev service type in cryptodev.json, then apply this
to related codes. Now we can remove VIRTIO_CRYPTO_SERVICE_xxx
dependence from QEMU cryptodev.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: zhenwei pi
---
backends/cryptodev-builtin.c| 8
backends/cryptodev-lkcf.
Rather than exposing akcipher service/RSA algorithm to virtio crypto
device unconditionally, detect akcipher capability from akcipher
crypto framework. This avoids unsuccessful requests.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: zhenwei pi
---
backends/cryptodev-builtin.c | 18
Add 'throttle-bps' and 'throttle-ops' limitation to set QoS. The
two arguments work with both QEMU command line and QMP command.
Example of QEMU command line:
-object cryptodev-backend-builtin,id=cryptodev1,throttle-bps=1600,\
throttle-ops=100
Example of QMP command:
virsh qemu-monitor-command bu
We have already used qapi to generate crypto device types, this allows
to convert type to a string 'model', so the 'model' field is not
needed.
And the 'name' field is not used by any backend driver, drop it.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: zhenwei pi
---
backends/cryptodev-buil
Introduce QCryptodevBackendType in cryptodev.json, also apply this to
related codes. Then we can drop 'enum CryptoDevBackendOptionsType'.
Note that `CRYPTODEV_BACKEND_TYPE_NONE` is *NOT* used by anywhere, so
drop it(no 'none' enum in QCryptodevBackendType).
Reviewed-by: Daniel P. Berrangé
Signed
Introduce cryptodev alg type in cryptodev.json, then apply this to
related codes, and drop 'enum CryptoDevBackendAlgType'.
There are two options:
1, { 'enum': 'QCryptodevBackendAlgType',
'prefix': 'CRYPTODEV_BACKEND_ALG',
'data': ['sym', 'asym']}
Then we can keep 'CRYPTODEV_BACKEND_ALG_SYM' an
Do this in cpu_tb_exec (normal exit) and cpu_loop_exit (exception),
adjacent to where we reset can_do_io.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1381
Signed-off-by: Richard Henderson
---
accel/tcg/cpu-exec-common.c | 4
accel/tcg/cpu-exec.c| 5 +++--
2 files changed
Supercedes: <20230222043204.941336-1-c...@braap.org>
("[PATCH] plugin: fix clearing of plugin_mem_cbs before TB exit")
Let's handle this as we do can_do_io, and reset the value in C.
r~
Richard Henderson (2):
tcg: Clear plugin_mem_cbs on TB exit
include/qemu/plugin: Remove QEMU_PLUGIN_ASSE
This macro is no longer used.
Signed-off-by: Richard Henderson
---
include/qemu/plugin.h | 4
1 file changed, 4 deletions(-)
diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h
index fb338ba576..e0ebedef84 100644
--- a/include/qemu/plugin.h
+++ b/include/qemu/plugin.h
@@ -59,8 +59,6
On 2/24/2023 7:54 AM, Eugenio Pérez wrote:
The function vhost.c:vhost_dev_stop fetches the vring base so the vq
state can be migrated to other devices. However, this is unreliable in
vdpa, since we didn't signal the device to suspend the queues, making
the value fetched useless.
Suspend the
1 - 100 of 391 matches
Mail list logo
