[PATCH v5 13/21] hw/xen: do not set is_external=true on evtchn fds

is_external=true suspends fd handlers between aio_disable_external() and aio_enable_external(). The block layer's drain operation uses this mechanism to prevent new I/O from sneaking in between bdrv_drained_begin() and bdrv_drained_end(). The previous commit converted the xen-block device to use

[PATCH v5 12/21] xen-block: implement BlockDevOps->drained_begin()

Detach event channels during drained sections to stop I/O submission from the ring. xen-block is no longer reliant on aio_disable_external() after this patch. This will allow us to remove the aio_disable_external() API once all other code that relies on it is converted. Extend

[PATCH v5 09/21] hw/xen: do not use aio_set_fd_handler(is_external=true) in xen_xenstore

There is no need to suspend activity between aio_disable_external() and aio_enable_external(), which is mainly used for the block layer's drain operation. This is part of ongoing work to remove the aio_disable_external() API. Reviewed-by: David Woodhouse Reviewed-by: Paul Durrant

[PATCH v5 18/21] virtio-blk: implement BlockDevOps->drained_begin()

Detach ioeventfds during drained sections to stop I/O submission from the guest. virtio-blk is no longer reliant on aio_disable_external() after this patch. This will allow us to remove the aio_disable_external() API once all other code that relies on it is converted. Take extra care to avoid

[PATCH v5 01/21] block: Fix use after free in blockdev_mark_auto_del()

From: Kevin Wolf job_cancel_locked() drops the job list lock temporarily and it may call aio_poll(). We must assume that the list has changed after this call. Also, with unlucky timing, it can end up freeing the job during job_completed_txn_abort_locked(), making the job pointer invalid, too.

[PATCH v5 00/21] block: remove aio_disable_external() API

v5: - Use atomic accesses for in_flight counter in vhost-user-server.c [Kevin] - Stash SCSIDevice id/lun values for VIRTIO_SCSI_T_TRANSPORT_RESET event before unrealizing the SCSIDevice [Kevin] - Keep vhost-user-blk export .detach() callback so ctx is set to NULL [Kevin] - Narrow BdrvChildClass

[PATCH v3 3/5] hw/display/virtio-gpu-virgl: define callbacks in realize function

This reduces the amount of renderer backend specific needed to be exposed to the GL device. We only need one realize function per renderer backend. This may seem a bit odd to traditional QOM users since we mutate class function pointers, but the distinction between .instance_init and .realize is

[PATCH v3 1/5] hw/display/virtio-gpu-virgl: virtio_gpu_gl -> virtio_gpu_virgl

The virtio-gpu GL device has a heavy dependence on virgl. Acknowledge this by naming functions accurately. Signed-off-by: Gurchetan Singh Reviewed-by: Philippe Mathieu-Daudé --- v1: - (Philippe) virtio_gpu_virglrenderer_reset --> virtio_gpu_virgl_reset_renderer v2: - (Akihiko) Fix unnecessary

[PATCH v3 4/5] virtio: Add shared memory capability

From: "Dr. David Alan Gilbert" Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' to allow defining shared memory regions with sizes and offsets of 2^32 and more. Multiple instances of the capability are allowed and distinguished by a device-specific 'id'. Signed-off-by: Dr. David

[PATCH v3 2/5] hw/display/virtio-gpu-virgl: make GL device more library agnostic

Rather than create a virtio-gpu-gfxstream device and it's associated variants (vga, pci), let's just extend the GL device. We need to: - Move all virgl functions to their own file - Only all needed class callbacks in the generic GL device Signed-off-by: Gurchetan Singh Reviewed-by:

[PATCH v3 0/5] virtio-gpu cleanups and obvious definitions

From: Gurchetan Singh v3 of "virtio-gpu cleanups and obvious definitions" https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg05392.html All patches have been reviewed, though there was a question from Bernhard Beschow about patch (3) and how it fits with the QOM:

[PATCH v3 5/5] virtio-gpu: CONTEXT_INIT feature

From: Antonio Caggiano The feature can be enabled when a backend wants it. Signed-off-by: Antonio Caggiano Reviewed-by: Marc-André Lureau Signed-off-by: Gurchetan Singh Reviewed-by: Philippe Mathieu-Daudé --- hw/display/virtio-gpu-base.c | 3 +++ include/hw/virtio/virtio-gpu.h | 3 +++ 2

ssl fips self check fails with 7.2.0 on x86 TCG

Hi, I just finished rebasing my team onto 7.2.0 and now I'm seeing https://boringssl.googlesource.com/boringssl/+/master/crypto/fipsmodule/self_check/self_check.c#361 fail. I applied https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00260.html and it's still failing. Is anyone else

[PATCH] Hexagon (decode): look for pkts with multiple insns at the same slot

Each slot in a packet can be assigned to at most one instruction. Although the assembler generally ought to enforce this rule, we better be safe than sorry and also do some check to properly throw an "invalid packet" exception on wrong slot assignments. This should also make it easier to debug

[PATCH 0/2] Hexagon: improve output for arch version debugging

If we run qemu with an Hexagon binary compiled to an arch version that is higher than the threshold modeled by qemu, we will get the following error: qemu-hexagon: unable to find CPU model 'unknown' This can be confusing ("Was qemu unable to read the arch version from this binary? Or did it

[PATCH 2/2] Hexagon: append eflags to unknown cpu model string

Running qemu-hexagon with a binary that was compiled for an arch version unknown by qemu can produce a somewhat confusing message: qemu-hexagon: unable to find CPU model 'unknown' Let's give a bit more info by appending the eflags so that the message becomes: qemu-hexagon: unable to find

[PATCH 1/2] Hexagon: list available CPUs with `-cpu help`

Currently, qemu-hexagon only models the v67 cpu. Nonetheless if we try to get this information with `-cpu help`, qemu just exists with an error code and no output. Let's correct that. The code is basically a copy from target/alpha/cpu.h, but we strip the "-hexagon-cpu" suffix before printing.

Re: [PATCH v2 2/6] detect physical address space size

On Wed, May 03, 2023 at 11:20:54AM +0200, Gerd Hoffmann wrote: > Check for pae and long mode using cpuid. If present also read the > physical address bits. Apply some qemu sanity checks (see below). > Record results in PhysBits and LongMode variables. In case we are not > sure what the address

[PATCH] hw/ppc/Kconfig: NVDIMM is a hard requirement for the pseries machine

When building QEMU with "--without-default-devices", the pseries machine fails to start even when running with the --nodefaults option: $ ./qemu-system-ppc64 --nodefaults -M pseries Type 'spapr-nvdimm' is missing its parent 'nvdimm' Aborted (core dumped) Looks like NVDIMM is a hard

Re: [PATCH v2 01/12] simpletrace: Improve parsing of sys.argv; fix files never closed.

On Tue, May 02, 2023 at 11:23:28AM +0200, Mads Ynddal wrote: > From: Mads Ynddal > > The arguments extracted from `sys.argv` named and unpacked to make it > clear what the arguments are and what they're used for. > > The two input files were opened, but never explicitly closed. File usage >

Re: [PATCH v2 00/12] simpletrace: refactor and general improvements

On Thu, May 4, 2023, 1:48 PM Stefan Hajnoczi wrote: > On Tue, May 02, 2023 at 11:23:27AM +0200, Mads Ynddal wrote: > > From: Mads Ynddal > > > > I wanted to use simpletrace.py for an internal project, so I tried to > update > > and polish the code. Some of the commits resolve specific issues,

Re: [PATCH 0/9] QEMU file cleanups

On Thu, May 04, 2023 at 01:38:32PM +0200, Juan Quintela wrote: > - convince and review code to see that everything is uint64_t. One general question to patches regarding this - what's the major benefit of using uint64_t? It doubles the possible numbers to hold, but it's already 64bits so I don't

Re: [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush()

Peter Xu wrote: > On Thu, May 04, 2023 at 01:38:41PM +0200, Juan Quintela wrote: >> That is the moment we know we have transferred something. >> >> Signed-off-by: Juan Quintela > > There'll be a slight side effect that qemu_file_rate_limit() can be > triggered later than before because data

[PATCH] Hexagon (target/hexagon/*.py): raise exception on reg parsing error

Currently, the python scripts used for the hexagon building will not abort the compilation when there is an error parsing a register. Let's make the compilation properly fail in such cases by rasing an exception instead of just printing a warning message, which might get lost in the output. This

Re: [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush()

On Thu, May 04, 2023 at 01:38:41PM +0200, Juan Quintela wrote: > That is the moment we know we have transferred something. > > Signed-off-by: Juan Quintela There'll be a slight side effect that qemu_file_rate_limit() can be triggered later than before because data cached in the qemufile won't

[PATCH v2 2/2] target/arm: Fix handling of SW and NSW bits for stage 2 walks

We currently don't correctly handle the VSTCR_EL2.SW and VTCR_EL2.NSW configuration bits. These allow configuration of whether the stage 2 page table walks for Secure IPA and NonSecure IPA should do their descriptor reads from Secure or NonSecure physical addresses. (This is separate from how the

Re: [PATCH v2 1/2] tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat and xorriso

On 04/05/2023 17.46, Ani Sinha wrote: Pull in the following changes from lcitool: * tests/lcitool/libvirt-ci 85487e1...c8971e9 (18): > mappings: add new package mappings for mformat and xorriso > docs: testing: Update contents with tox > .gitlab-ci.yml: Always test against installed

Re: [PATCH v7 1/1] arm/kvm: add support for MTE

On Tue, May 02 2023, Richard Henderson wrote: > On 5/2/23 10:03, Cornelia Huck wrote: >> Has anyone been able to access a real system with MTE? (All the systems >> where I had hoped that MTE would be available didn't have MTE in the end >> so far, so I'd be interested to hear if anybody else

Re: [PATCH v2 00/12] simpletrace: refactor and general improvements

On Tue, May 02, 2023 at 11:23:27AM +0200, Mads Ynddal wrote: > From: Mads Ynddal > > I wanted to use simpletrace.py for an internal project, so I tried to update > and polish the code. Some of the commits resolve specific issues, while some > are more subjective. An internal project based on

Re: [PATCH v4 04/57] accel/tcg: Reorg system mode load helpers

On Wed, 3 May 2023 at 08:11, Richard Henderson wrote: > > Instead of trying to unify all operations on uint64_t, pull out > mmu_lookup() to perform the basic tlb hit and resolution. > Create individual functions to handle access by size. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard

Re: [PATCH v2 2/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies

On 04/05/2023 17.46, Ani Sinha wrote: Bios bits avocado tests need mformat (provided by the mtools package) and xorriso tools in order to run within gitlab CI containers. Add those dependencies within the Dockerfiles so that containers can be built with those tools present and bios bits avocado

[PATCH v2 2/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies

Bios bits avocado tests need mformat (provided by the mtools package) and xorriso tools in order to run within gitlab CI containers. Add those dependencies within the Dockerfiles so that containers can be built with those tools present and bios bits avocado tests can be run there. xorriso package

Re: [PATCH 1/3] target/arm: Use CONFIG_SEMIHOSTING instead of TCG for semihosting

Paolo Bonzini writes: > On 5/3/23 21:38, Fabiano Rosas wrote: >> When building --without-default-devices, the semihosting code will not >> be available, so check the proper config. > > Acked-by: Paolo Bonzini > > for this change; however, there are two more related issues: > > 1) you still

Re: [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush()

On Thu, May 04, 2023 at 01:38:41PM +0200, Juan Quintela wrote: > That is the moment we know we have transferred something. > > Signed-off-by: Juan Quintela > --- > migration/qemu-file.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/migration/qemu-file.c

Re: [PATCH 0/9] QEMU file cleanups

Peter Xu wrote: > On Thu, May 04, 2023 at 01:38:32PM +0200, Juan Quintela wrote: >> - convince and review code to see that everything is uint64_t. > > One general question to patches regarding this - what's the major benefit > of using uint64_t? > > It doubles the possible numbers to hold, but

Re: [PATCH v4 01/57] include/exec/memop: Add bits describing atomicity

On Wed, 3 May 2023 at 08:11, Richard Henderson wrote: > > These bits may be used to describe the precise atomicity > requirements of the guest, which may then be used to > constrain the methods by which it may be emulated by the host. > > For instance, the AArch64 LDP (32-bit) instruction changes

Re: [PATCH 7/9] qemu-file: Make total_transferred an uint64_t

On Thu, May 04, 2023 at 01:38:39PM +0200, Juan Quintela wrote: > Change all the functions that use it. It was already passed as > uint64_t. > > Signed-off-by: Juan Quintela > --- > migration/block.c | 5 ++--- > migration/qemu-file.c | 8 > migration/qemu-file.h | 4 ++-- >

[PATCH v2 0/2] target/arm: Fix handling of VSTCR_EL2.SW and VTCR_EL2.NSW

When FEAT_SEL2 (secure EL2) is implemented, the bits VSTCR_EL2.SW and VTCR_EL2.NSW allow the guest to set things up so that the stage 2 walk for an IPA is done to the other address space, eg * a stage 2 walk for an NS IPA done to secure physical memory (where the translation table base address

Re: [PATCH 1/2] migration: Document all migration_stats

David Edmondson wrote: > Juan Quintela writes: > >> Signed-off-by: Juan Quintela > > Reviewed-by: David Edmondson Thanks. >> --- >> migration/migration-stats.h | 43 + >> 1 file changed, 43 insertions(+) >> >> diff --git a/migration/migration-stats.h

Re: [PATCH 6/9] qemu-file: remove shutdown member

On Thu, May 04, 2023 at 01:38:38PM +0200, Juan Quintela wrote: > The first thing that we do after setting the shutdown value is set the > error as -EIO if there is not a previous error. > > So this value is reduntant. Just remove it and use s/reduntant/redundant/ > qemu_file_get_error() in

Re: [PATCH v10 0/8] memory: prevent dma-reentracy issues

28.04.2023 00:10, Alexander Bulekov wrote: .. These patches aim to solve two types of DMA-reentrancy issues: 1.) mmio -> dma -> mmio case To solve this, we track whether the device is engaged in io by checking/setting a reentrancy-guard within APIs used for MMIO access. 2.) bh -> dma write ->

Re: [PATCH 1/5] migration: Make RAM_SAVE_FLAG_HOOK a normal case entry

On Thu, May 04, 2023 at 01:44:39PM +0200, Juan Quintela wrote: > Fixes this commit, clearly a bad merge after a rebase or similar, it > should have been its own case since that point. > > commit 5b0e9dd46fbda5152566a4a26fd96bc0d0452bf7 > Author: Peter Lieven > Date: Tue Jun 24 11:32:36 2014

[PATCH v4 4/5] igb: add IPv6 extended headers traffic detection

Signed-off-by: Tomasz Dzieciol --- hw/net/igb_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index dbd09b9b46..8c0291665f 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1400,7 +1400,9 @@

[PATCH v4 2/5] igb: rename E1000E_RingInfo_st

Rename E1000E_RingInfo_st and E1000E_RingInfo according to qemu typdefs guide. Signed-off-by: Tomasz Dzieciol --- hw/net/igb_core.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index

Re: [PATCH 1/2] migration: Document all migration_stats

Juan Quintela writes: > Signed-off-by: Juan Quintela Reviewed-by: David Edmondson > --- > migration/migration-stats.h | 43 + > 1 file changed, 43 insertions(+) > > diff --git a/migration/migration-stats.h b/migration/migration-stats.h > index

[PATCH v5 36/44] target/loongarch: Implement vfcmp

This patch includes: - VFCMP.cond.{S/D}. Reviewed-by: Richard Henderson Signed-off-by: Song Gao --- target/loongarch/disas.c| 94 + target/loongarch/helper.h | 5 ++ target/loongarch/insn_trans/trans_lsx.c.inc | 32 +++

Re: [Capstone] TriCore support in Capstone

Hello bastian, I'm excited to inform you that the TriCore support in Capstone has been successfully merged! The pull request can be found here: https://github.com/capstone-engine/capstone/pull/1973 With this update, you can now utilize Capstone's TriCore disassembly capabilities in QEMU. I

[PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies

mformat and xorriso tools are needed by biosbits avocado tests. This patchset adds those two tools in the docker container images. xorriso package conflicts with genisoimage package on some distributions. Therefore, it is not possible to have both the packages at the same time in the container

Re: [PATCH 2/2] migration: Put zero_pages in alphabetical order

On Thu, May 04, 2023 at 12:33:57PM +0200, Juan Quintela wrote: > I forgot to move it when I rename it from duplicated_pages. > > Signed-off-by: Juan Quintela > --- > migration/migration-stats.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé

Re: [PATCH 8/9] qemu-file: Make ram_control_save_page() use accessors for rate_limit

On Thu, May 04, 2023 at 01:38:40PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/qemu-file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

[PATCH v3 6/6] Hexagon (linux-user/hexagon): handle breakpoints

This enables LLDB to work with hexagon linux-user mode through the GDB remote protocol. Helped-by: Richard Henderson Signed-off-by: Matheus Tavares Bernardino --- linux-user/hexagon/cpu_loop.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/hexagon/cpu_loop.c

Re: [PATCH 5/9] qemu-file: No need to check for shutdown in qemu_file_rate_limit

On Thu, May 04, 2023 at 01:38:37PM +0200, Juan Quintela wrote: > After calling qemu_file_shutdown() we set the error as -EIO if there > is no another previous error, so no need to check it here. > > Signed-off-by: Juan Quintela Reviewed-by: Peter Xu -- Peter Xu

[PATCH] scripts/coverity-scan: Add xtensa and openrisc components

We have two target architectures which don't have Coverity components defined for them: xtensa and openrisc. Add them. Signed-off-by: Peter Maydell --- As usual with coverity components, these will need to be added manually via the scanner UI, since it has no import-from-file...

Re: [PATCH 0/8] migration: Add precopy initial data capability and VFIO precopy support

On Thu, May 04, 2023 at 01:18:04PM +0300, Avihai Horon wrote: > > On 03/05/2023 18:49, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > On Wed, May 03, 2023 at 06:22:59PM +0300, Avihai Horon wrote: > > > On 03/05/2023 1:49, Peter Xu wrote: > > > >

Re: [PATCH] target: ppc: Correctly initialize HILE in HID-0 for book3s processors

On 4/28/23 20:00, Fabiano Rosas wrote: Vaibhav Jain writes: Hi Fabiano, Thanks for looking into this patch and apologies for the delayed reponse. Fabiano Rosas writes: Narayana Murty N writes: On PPC64 the HILE(Hypervisor Interrupt Little Endian) bit in HID-0 register needs to be

Re: [PATCH v4 05/57] accel/tcg: Reorg system mode store helpers

On Wed, 3 May 2023 at 08:23, Richard Henderson wrote: > > Instead of trying to unify all operations on uint64_t, use > mmu_lookup() to perform the basic tlb hit and resolution. > Create individual functions to handle access by size. > > Signed-off-by: Richard Henderson Reviewed-by: Peter

[PATCH v3 3/6] Hexagon: add core gdbstub xml data for LLDB

Signed-off-by: Matheus Tavares Bernardino --- MAINTAINERS| 1 + configs/targets/hexagon-linux-user.mak | 1 + target/hexagon/cpu.c | 3 +- gdb-xml/hexagon-core.xml | 84 ++ 4 files changed, 88 insertions(+), 1

Re: [PATCH v4] linux-user: fix getgroups/setgroups allocations

09.04.2023 13:53, Michael Tokarev wrote: linux-user getgroups(), setgroups(), getgroups32() and setgroups32() used alloca() to allocate grouplist arrays, with unchecked gidsetsize coming from the "guest". With NGROUPS_MAX being 65536 (linux, and it is common for an application to allocate

Re: [PATCH 5/9] qemu-file: No need to check for shutdown in qemu_file_rate_limit

On Thu, May 04, 2023 at 01:38:37PM +0200, Juan Quintela wrote: > After calling qemu_file_shutdown() we set the error as -EIO if there > is no another previous error, so no need to check it here. > > Signed-off-by: Juan Quintela > --- > migration/qemu-file.c | 3 --- > 1 file changed, 3

Re: [PATCH v4 2/2] meson: Deserialize the man pages and html builds

On Thu, 4 May 2023 at 13:06, Fabiano Rosas wrote: > > Peter Maydell writes: > > > On Wed, 3 May 2023 at 21:39, Fabiano Rosas wrote: > >> Since they can now run in parallel, separate the Sphinx cache > >> directory of the two builds. We need this not only for data > >> consistency but also

[PATCH v3 4/6] Hexagon (gdbstub): fix p3:0 read and write via stub

From: Brian Cain Signed-off-by: Brian Cain Co-authored-by: Sid Manning Signed-off-by: Sid Manning Co-authored-by: Matheus Tavares Bernardino Signed-off-by: Matheus Tavares Bernardino Reviewed-by: Taylor Simpson --- target/hexagon/gdbstub.c | 16 1 file changed, 16

Re: [PATCH v2] target/hexagon: fix = vs. == mishap

On 4/28/23 22:44, Taylor Simpson wrote: From: Paolo Bonzini Changes in v2 Fix yyassert's for sign and zero extends Coverity reports a parameter that is "set but never used". This is caused by an assignment operator being used instead of equality. Co-authored-by: Taylor Simpson

Re: [PATCH 3/5] migration/rdma: We can calculate the rioc from the QEMUFile

On Thu, May 04, 2023 at 01:44:41PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/rdma.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

[PATCH v5 16/44] target/loongarch: Implement vdiv/vmod

This patch includes: - VDIV.{B/H/W/D}[U]; - VMOD.{B/H/W/D}[U]. Reviewed-by: Richard Henderson Signed-off-by: Song Gao --- target/loongarch/disas.c| 17 ++ target/loongarch/helper.h | 17 ++ target/loongarch/insn_trans/trans_lsx.c.inc | 17

Re: [PATCH 1/2] migration: Document all migration_stats

Daniel P. Berrangé wrote: > On Thu, May 04, 2023 at 12:33:56PM +0200, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> migration/migration-stats.h | 43 + >> 1 file changed, 43 insertions(+) >> >> diff --git a/migration/migration-stats.h

[PATCH v2 1/2] tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat and xorriso

Pull in the following changes from lcitool: * tests/lcitool/libvirt-ci 85487e1...c8971e9 (18): > mappings: add new package mappings for mformat and xorriso > docs: testing: Update contents with tox > .gitlab-ci.yml: Always test against installed lcitool > gitlab-ci.yml: Start using tox

Re: [PATCH 1/2] target/arm: Move translate-a32.h, arm_ldst.h, sve_ldst_internal.h to tcg/

Richard Henderson writes: > These files got missed when populating tcg/. > Because they are included with "", no change to the users required. > > Signed-off-by: Richard Henderson Reviewed-by: Fabiano Rosas

Re: [PATCH 1/3] target/arm: Use CONFIG_SEMIHOSTING instead of TCG for semihosting

Paolo Bonzini writes: > Il gio 4 mag 2023, 10:59 Peter Maydell ha > scritto: > >> On Thu, 4 May 2023 at 08:33, Paolo Bonzini wrote: >> > >> > On 5/3/23 21:38, Fabiano Rosas wrote: >> > > When building --without-default-devices, the semihosting code will not >> > > be available, so check the

Re: [PATCH] softfloat: Fix the incorrect computation in float32_exp2()

02.05.2023 18:25, Shivaprasad G Bhat wrote: The float32_exp2() is computing wrong exponent of 2. For example, with the following set of values {0.1, 2.0, 2.0, -1.0}, the expected output would be {1.071773, 4.00, 4.00, 0.50}. Instead, the function is computing {1.119102, 3.382044,

[PATCH v5 38/44] target/loongarch: Implement vinsgr2vr vpickve2gr vreplgr2vr

This patch includes: - VINSGR2VR.{B/H/W/D}; - VPICKVE2GR.{B/H/W/D}[U]; - VREPLGR2VR.{B/H/W/D}. Reviewed-by: Richard Henderson Signed-off-by: Song Gao --- target/loongarch/disas.c| 33 ++ target/loongarch/insn_trans/trans_lsx.c.inc | 110

[PATCH v3 5/6] Hexagon (gdbstub): add HVX support

From: Taylor Simpson Signed-off-by: Taylor Simpson Co-authored-by: Brian Cain Signed-off-by: Brian Cain Co-authored-by: Matheus Tavares Bernardino Signed-off-by: Matheus Tavares Bernardino --- configs/targets/hexagon-linux-user.mak | 2 +- target/hexagon/internal.h | 2 +

Re: [PATCH v2 0/2] tests/lcitool: Add mtools and xorriso and remove genisoimage as dependencies

> On 04-May-2023, at 9:16 PM, Ani Sinha wrote: > > mformat and xorriso tools are needed by biosbits avocado tests. This patchset > adds those two tools in the docker container images. > xorriso package conflicts with genisoimage package on some distributions. > Therefore, it is not possible

Re: [PATCH 2/5] migration/rdma: simplify ram_control_load_hook()

On Thu, May 04, 2023 at 01:44:40PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/qemu-file.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH 6/9] qemu-file: remove shutdown member

On Thu, May 04, 2023 at 01:38:38PM +0200, Juan Quintela wrote: > The first thing that we do after setting the shutdown value is set the > error as -EIO if there is not a previous error. > > So this value is reduntant. Just remove it and use > qemu_file_get_error() in the places that it was

[PATCH v4 5/5] igb: packet-split descriptors support

Packet-split descriptors are used by Linux VF driver for MTU values from 2048 Signed-off-by: Tomasz Dzieciol --- hw/net/igb_core.c | 368 ++-- hw/net/igb_regs.h | 8 + hw/net/trace-events | 2 +- 3 files changed, 332 insertions(+), 46 deletions(-)

[PATCH v5 10/44] target/loongarch: Implement vavg/vavgr

This patch includes: - VAVG.{B/H/W/D}[U]; - VAVGR.{B/H/W/D}[U]. Reviewed-by: Richard Henderson Signed-off-by: Song Gao --- target/loongarch/disas.c| 17 ++ target/loongarch/helper.h | 18 ++ target/loongarch/insn_trans/trans_lsx.c.inc | 197

Re: [PATCH v2 12/20] mirror: Require GRAPH_RDLOCK for accessing a node's parent list

On Thu, May 04, 2023 at 01:57:42PM +0200, Kevin Wolf wrote: > This adds GRAPH_RDLOCK annotations to declare that functions accessing > the parent list of a node need to hold a reader lock for the graph. As > it happens, they already do. > > Signed-off-by: Kevin Wolf > --- > block/mirror.c | 2

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

Paolo Bonzini writes: > On 5/3/23 20:32, Peter Maydell wrote: >> Do we really want to build a QEMU that then barfs unless >> you pass -nodefaults, though ? That doesn't seem very useful. >> Something somewhere ought to be saying "if you want the >> virt board then you almost certainly want

Re: [PATCH] target/ppc: Fix fallback to MFSS for MFFSCRN, MFFSCRNI, MFFSCE and MFFSL

On 04/05/2023 08:01, Richard Purdie wrote: The following commits changed the code such that these instructions became invalid on pre 3.0 ISAs: bf8adfd88b547680aa857c46098f3a1e94373160 - target/ppc: Move mffscrn[i] to decodetree 394c2e2fda70da722f20fb60412d6c0ca4bfaa03 - target/ppc: Move

[PATCH v3 2/6] gdbstub: add test for untimely stop-reply packets

In the previous commit, we modified gdbstub.c to only send stop-reply packets as a response to GDB commands that accept it. Now, let's add a test for this intended behavior. Running this test before the fix from the previous commit fails as QEMU sends a stop-reply packet asynchronously, when GDB

Re: [PATCH 1/2] migration: Document all migration_stats

On Thu, May 04, 2023 at 12:33:56PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration/migration-stats.h | 43 + > 1 file changed, 43 insertions(+) > > diff --git a/migration/migration-stats.h b/migration/migration-stats.h > index

Re: [PATCH 2/2] migration: Put zero_pages in alphabetical order

Juan Quintela writes: > I forgot to move it when I rename it from duplicated_pages. > > Signed-off-by: Juan Quintela Reviewed-by: David Edmondson > --- > migration/migration-stats.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/migration/migration-stats.h

Re: [PATCH v4] acpi: pcihp: allow repeating hot-unplug requests

On Wed, Apr 26, 2023 at 07:20:08PM +0200, Kashyap Chamarthy wrote: > On Wed, Apr 26, 2023 at 07:40:02PM +0300, Michael Tokarev wrote: > > 18.04.2023 12:04, Igor Mammedov wrote: > > > with Q35 using ACPI PCI hotplug by default, user's request to unplug > > > device is ignored when it's issued

Re: [PATCH v4 3/5] igb: RX descriptors handling cleanup

On 2023/05/04 22:10, Tomasz Dzieciol wrote: Refactoring is done in preparation for support of multiple advanced descriptors RX modes, especially packet-split modes. > Signed-off-by: Tomasz Dzieciol I guess the refactoring of igb_write_rx_descr() and igb_write_packet_to_guest() can be split.

Re: [PATCH 02/84] tcg: Widen gen_insn_data to uint64_t

On 5/3/23 09:22, Richard Henderson wrote: We already pass uint64_t to restore_state_to_opc; this changes all of the other uses from insn_start through the encoding to decoding. Signed-off-by: Richard Henderson --- include/tcg/tcg-op.h | 39 +--

Re: [PATCH v4 3/5] parallels: Add checking and repairing duplicate offsets in BAT

Yes, there is a bug. Thank you. On 4/29/23 00:15, Mike Maslenkin wrote: There is another issue with host_cluster_index() function. After this patchset applied `qemu-img check -f parallels some_disk` aborts for empty (just created) disk image. The problem is that host_cluster_index() returns 0

Re: [PATCH] migration: Rename xbzrle_enabled xbzrle_started

On Thu, May 04, 2023 at 01:53:23PM +0200, Juan Quintela wrote: > Otherwise it is confusing with the function xbzrle_enabled(). > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Juan Quintela > --- > migration/ram.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-)

[PATCH v4 1/5] igb: remove TCP ACK detection

TCP ACK detection is no longer present in igb. Signed-off-by: Tomasz Dzieciol --- hw/net/igb_core.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 96b7335b31..012eb1e1b9 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1327,11

Re: [PATCH 2/9] migration: qemu_file_total_transferred() function is monotonic

On Thu, May 04, 2023 at 01:38:34PM +0200, Juan Quintela wrote: > So delta_bytes can only be greater or equal to zero. Never negative. > > Signed-off-by: Juan Quintela > --- > migration/block.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé

Re: [PATCH v4 03/57] accel/tcg: Introduce tlb_read_idx

On Wed, 3 May 2023 at 08:15, Richard Henderson wrote: > > Instead of playing with offsetof in various places, use > MMUAccessType to index an array. This is easily defined > instead of the previous dummy padding array in the union. > > Reviewed-by: Alex Bennée > Reviewed-by: Philippe

[PATCH v4 0/5] igb: packet-split descriptors support

Based-on: <20230423041833.5302-1-akihiko.od...@daynix.com> ("[PATCH v3 00/47] igb: Fix for DPDK") Purposes of this series of patches: * introduce packet-split RX descriptors support. This feature is used by Linux VF driver for MTU values from 2048. * refactor RX descriptor handling for

[PATCH v3 0/6] Hexagon: add lldb support

This series allows hexagon programs to be debugged under qemu user-mode through LLDB and qemu's gdbstub. LLDB implements the GDB remote serial protocol, so most of the necessary changes are in the Hexagon part itself. However, one fix is needed at the arch-independent side too. Changes in v3: -

Re: [PATCH 1/9] migration: max_postcopy_bandwidth is a size parameter

On Thu, May 04, 2023 at 01:38:33PM +0200, Juan Quintela wrote: > So make everything that uses it uint64_t no int64_t. > > Signed-off-by: Juan Quintela > --- > migration/migration.c | 4 ++-- > migration/options.c | 2 +- > migration/options.h | 2 +- > 3 files changed, 4 insertions(+), 4

[PATCH v3 1/6] gdbstub: only send stop-reply packets when allowed to

GDB's remote serial protocol allows stop-reply messages to be sent by the stub either as a notification packet or as a reply to a GDB command (provided that the cmd accepts such a response). QEMU currently does not implement notification packets, so it should only send stop-replies synchronously

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

> On 04-May-2023, at 3:43 PM, Thomas Huth wrote: > > On 04/05/2023 11.35, Daniel P. Berrangé wrote: >> On Thu, May 04, 2023 at 02:19:21PM +0530, Ani Sinha wrote: >>> >>> On 04-May-2023, at 1:32 PM, Daniel P. Berrangé wrote: On Thu, May 04, 2023 at 08:35:53AM +0200, Thomas

Re: [PATCH v4 0/2] docs: Speedup docs build

Queued, thanks. Paolo

Re: [PATCH v4 2/5] igb: rename E1000E_RingInfo_st

On 2023/05/04 22:10, Tomasz Dzieciol wrote: Rename E1000E_RingInfo_st and E1000E_RingInfo according to qemu typdefs guide. Please make the same change for e1000e to make it easy to compare it with igb. Signed-off-by: Tomasz Dzieciol --- hw/net/igb_core.c | 42

Re: [PATCH v4 06/57] accel/tcg: Honor atomicity of loads

On Wed, 3 May 2023 at 08:08, Richard Henderson wrote: > > Create ldst_atomicity.c.inc. > > Not required for user-only code loads, because we've ensured that > the page is read-only before beginning to translate code. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- >

Re: [PATCH 4/5] migration/rdma: It makes no sense to recive that flag without RDMA

In $SUBJECT s/recive/receive/ On Thu, May 04, 2023 at 01:44:42PM +0200, Juan Quintela wrote: > This could only happen if the source send s/send/sent/ > RAM_SAVE_FLAG_HOOK (i.e. rdma) and destination don't have CONFIG_RDMA. > > Signed-off-by: Juan Quintela > --- > migration/qemu-file.c | 8

Re: [PATCH] include/qemu/osdep.h: Bump _WIN32_WINNT to the Windows 8 API

On 2023/05/04 17:13, Thomas Huth wrote: Commit cf60ccc330 ("cutils: Introduce bundle mechanism") abandoned compatibility with Windows older than 8 - we should reflect this in our _WIN32_WINNT and set it to the value that corresponds to Windows 8. Signed-off-by: Thomas Huth Reviewed-by:

<    1   2   3   4   5   >