[PATCH 0/9] QEMU file cleanups

2023-05-04 Thread Juan Quintela
Hi While I am trying to put order in the atomic counters, I made in this series: - convince and review code to see that everything is uint64_t. - f->shutdown is not needed. When we shutdown the file we put an error there if there is none. So remove it. - Make more clear how we use rate_limit

[PATCH 6/9] qemu-file: remove shutdown member

2023-05-04 Thread Juan Quintela
The first thing that we do after setting the shutdown value is set the error as -EIO if there is not a previous error. So this value is reduntant. Just remove it and use qemu_file_get_error() in the places that it was tested. Signed-off-by: Juan Quintela --- migration/qemu-file.c | 10 +++-

[PATCH 2/9] migration: qemu_file_total_transferred() function is monotonic

2023-05-04 Thread Juan Quintela
So delta_bytes can only be greater or equal to zero. Never negative. Signed-off-by: Juan Quintela --- migration/block.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/migration/block.c b/migration/block.c index 6d532ac7a2..3499f75e37 100644 --- a/migration/block.c ++

Re: [RFC PATCH v4 00/44] Add LoongArch LSX instructions

2023-05-04 Thread Song Gao
在 2023/5/4 下午5:41, Richard Henderson 写道: On 5/4/23 09:25, Richard Henderson wrote: On 5/4/23 02:26, Song Gao wrote: V4:    - R-b and rebase;    - Migrate the upper half lsx regs;    - Remove tcg_gen_mulus2_*;    - Vsetallnez use !do_match2;    - Use tcg_gen_concat_i64_i128/tcg_gen_extr_i128_i6

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-04 Thread Ani Sinha
> On 04-May-2023, at 1:55 PM, Daniel P. Berrangé wrote: > > On Thu, May 04, 2023 at 01:52:36PM +0530, Ani Sinha wrote: >> >> >>> On 04-May-2023, at 1:32 PM, Daniel P. Berrangé wrote: >>> >>> On Thu, May 04, 2023 at 08:35:53AM +0200, Thomas Huth wrote: On 03/05/2023 16.55, Ani Sinha wr

Re: [PULL 0/6] Misc QGA patches

2023-05-04 Thread Konstantin Kostiuk
Thanks, Richard. It was ok to use git@ URL last time but not a problem to fix. Best Regards, Konstantin Kostiuk. On Thu, May 4, 2023 at 2:10 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 5/4/23 10:56, Konstantin Kostiuk wrote: > > From: Kostiantyn Kostiuk > > > > > > The fol

Re: [PATCH 03/20] block: bdrv/blk_co_unref() for calls in coroutine context

2023-05-04 Thread Kevin Wolf
Am 27.04.2023 um 22:49 hat Paolo Bonzini geschrieben: > Il gio 27 apr 2023, 19:00 Kevin Wolf ha scritto: > > > By the way, and slightly unrelated, can vrc somehow help with finding > > places that call coroutine wrappers without holding the AioContext lock? > > (This results in an abort() when AI

Re: [PATCH 15/20] block: Mark bdrv_co_debug_event() GRAPH_RDLOCK

2023-05-04 Thread Kevin Wolf
Am 25.04.2023 um 23:14 hat Eric Blake geschrieben: > On Tue, Apr 25, 2023 at 07:31:53PM +0200, Kevin Wolf wrote: > > From: Emanuele Giuseppe Esposito > > > > This adds GRAPH_RDLOCK annotations to declare that callers of > > bdrv_co_debug_event() need to hold a reader lock for the graph. > > > >

Re: [PULL 0/6] Misc QGA patches

2023-05-04 Thread Richard Henderson
On 5/4/23 10:56, Konstantin Kostiuk wrote: From: Kostiantyn Kostiuk The following changes since commit 044f8cf70a2fdf3b9e4c4d849c66e7855d2c446a: Merge tag 'migration-20230428-pull-request' ofhttps://gitlab.com/juan.quintela/qemu into staging (2023-05-03 10:29:30 +0100) are available in

Re: [PULL 0/2] NBD pull request for 2023-05-03

2023-05-04 Thread Richard Henderson
On 5/3/23 20:02, Eric Blake wrote: The following changes since commit 044f8cf70a2fdf3b9e4c4d849c66e7855d2c446a: Merge tag 'migration-20230428-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-05-03 10:29:30 +0100) are available in the Git repository at: https://r

Re: [PATCH v2 0/2] tcg: ppc64: Fix mask generation for vextractdm

2023-05-04 Thread Daniel Henrique Barboza
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Daniel On 5/4/23 06:35, Shivaprasad G Bhat wrote: While debugging gitlab issue[1] 1536, I happen to try the vextract[X]m instructions on the real hardware. The test used in [1] is failing for vextractdm. On debugging it is seen, in fun

Re: [PATCH v20 06/21] s390x/cpu topology: interception of PTF instruction

2023-05-04 Thread Nina Schoetterl-Glausch
On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote: > When the host supports the CPU topology facility, the PTF > instruction with function code 2 is interpreted by the SIE, > provided that the userland hypervisor activates the interpretation > by using the KVM_CAP_S390_CPU_TOPOLOGY KVM extensio

[PATCH 0/2] target/arm: Move more files to tcg/

2023-05-04 Thread Richard Henderson
Move 7 files to tcg/. r~ Richard Henderson (2): target/arm: Move translate-a32.h, arm_ldst.h, sve_ldst_internal.h to tcg/ target/arm: Move helper-{a64,mve,sme,sve}.h to tcg/ target/arm/helper.h | 8 target/arm/{ => tcg}/arm_ldst.h | 0 target/arm/

[PATCH 1/2] target/arm: Move translate-a32.h, arm_ldst.h, sve_ldst_internal.h to tcg/

2023-05-04 Thread Richard Henderson
These files got missed when populating tcg/. Because they are included with "", no change to the users required. Signed-off-by: Richard Henderson --- target/arm/{ => tcg}/arm_ldst.h | 0 target/arm/{ => tcg}/sve_ldst_internal.h | 0 target/arm/{ => tcg}/translate-a32.h | 0 3 files

[PATCH 2/2] target/arm: Move helper-{a64,mve,sme,sve}.h to tcg/

2023-05-04 Thread Richard Henderson
While we cannot move the main "helper.h" out of target/arm/, due to usage by generic code, we can move the sub-includes. Signed-off-by: Richard Henderson --- target/arm/helper.h | 8 target/arm/{ => tcg}/helper-a64.h | 0 target/arm/{ => tcg}/helper-mve.h | 0 target/arm/{

[PATCH] target/ppc: Fix fallback to MFSS for MFFSCRN, MFFSCRNI, MFFSCE and MFFSL

2023-05-04 Thread Richard Purdie
The following commits changed the code such that these instructions became invalid on pre 3.0 ISAs: bf8adfd88b547680aa857c46098f3a1e94373160 - target/ppc: Move mffscrn[i] to decodetree 394c2e2fda70da722f20fb60412d6c0ca4bfaa03 - target/ppc: Move mffsce to decodetree 3e5bce70efe6bd1f684efbb

Re: [PATCH] tests/9p: fix potential leak in v9fs_rreaddir()

2023-05-04 Thread Christian Schoenebeck
On Saturday, April 29, 2023 11:25:33 AM CEST Christian Schoenebeck wrote: > Free allocated directory entries in v9fs_rreaddir() if argument > `entries` was passed as NULL, to avoid a memory leak. It is > explicitly allowed by design for `entries` to be NULL. [1] > > [1] https://lore.kernel.org/all

Re: [PATCH 13/20] block: Mark bdrv_co_get_allocated_file_size() and callers GRAPH_RDLOCK

2023-05-04 Thread Kevin Wolf
Am 01.05.2023 um 21:03 hat Stefan Hajnoczi geschrieben: > On Tue, Apr 25, 2023 at 07:31:51PM +0200, Kevin Wolf wrote: > > @@ -5778,6 +5779,7 @@ int64_t coroutine_fn > > bdrv_co_get_allocated_file_size(BlockDriverState *bs) > > { > > BlockDriver *drv = bs->drv; > > IO_CODE(); > > +as

Re: [PATCH v3] Don't require libcap-ng for virtfs support

2023-05-04 Thread Christian Schoenebeck
On Wednesday, May 3, 2023 3:07:56 PM CEST Peter Foley wrote: > It's only required for the proxy helper. > > Add a new option for the proxy helper rather than enabling it > implicitly. > > Change-Id: I95b73fca625529e99d16b0a64e01c65c0c1d43f2 > Signed-off-by: Peter Foley > --- LGTM now, queued on

[PATCH] target/arm: Fix vd == vm overlap in sve_ldff1_z

2023-05-04 Thread Richard Henderson
If vd == vm, copy vm to scratch, so that we can pre-zero the output and still access the gather indicies. Cc: qemu-sta...@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1612 Signed-off-by: Richard Henderson --- target/arm/tcg/sve_helper.c | 6 ++ 1 file changed, 6 inserti

[PATCH 1/2] migration: Document all migration_stats

2023-05-04 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration-stats.h | 43 + 1 file changed, 43 insertions(+) diff --git a/migration/migration-stats.h b/migration/migration-stats.h index 149af932d7..0e49c236fa 100644 --- a/migration/migration-stats.h +++ b/migration/m

[PATCH 0/2] More migration stats

2023-05-04 Thread Juan Quintela
Hi Just updating documentation for migration stats and sorting them. Please review. Juan Quintela (2): migration: Document all migration_stats migration: Put zero_pages in alphabetical order migration/migration-stats.h | 45 - 1 file changed, 44 insertio

[PATCH 2/2] migration: Put zero_pages in alphabetical order

2023-05-04 Thread Juan Quintela
I forgot to move it when I rename it from duplicated_pages. Signed-off-by: Juan Quintela --- migration/migration-stats.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/migration/migration-stats.h b/migration/migration-stats.h index 0e49c236fa..b87ba30ea8 100644 --- a

Re: [PATCH 0/8] migration: Add precopy initial data capability and VFIO precopy support

2023-05-04 Thread Avihai Horon
On 03/05/2023 18:49, Peter Xu wrote: External email: Use caution opening links or attachments On Wed, May 03, 2023 at 06:22:59PM +0300, Avihai Horon wrote: On 03/05/2023 1:49, Peter Xu wrote: External email: Use caution opening links or attachments On Mon, May 01, 2023 at 05:01:33PM +0300

[PATCH] virtio-net: not enable vq reset feature unconditionally

2023-05-04 Thread Eugenio Pérez
The commit 93a97dc5200a ("virtio-net: enable vq reset feature") enables unconditionally vq reset feature as long as the device is emulated. This makes impossible to actually disable the feature, and it causes migration problems from qemu version previous than 7.2. The entire final commit is unneed

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-04 Thread Thomas Huth
On 04/05/2023 11.35, Daniel P. Berrangé wrote: On Thu, May 04, 2023 at 02:19:21PM +0530, Ani Sinha wrote: On 04-May-2023, at 1:32 PM, Daniel P. Berrangé wrote: On Thu, May 04, 2023 at 08:35:53AM +0200, Thomas Huth wrote: On 03/05/2023 16.55, Ani Sinha wrote: mformat and xorriso tools are

Re: [PULL 11/18] migration: Create migrate_block_bitmap_mapping() function

2023-05-04 Thread Juan Quintela
Kevin Wolf wrote: > Am 03.05.2023 um 19:15 hat Juan Quintela geschrieben: >> Kevin Wolf wrote: >> > Am 27.04.2023 um 17:22 hat Juan Quintela geschrieben: >> >> Notice that we changed the test of ->has_block_bitmap_mapping >> >> for the test that block_bitmap_mapping is not NULL. >> >> >> >> Sign

[PULL 2/6] qga: Refactor guest-exec capture-output to take enum

2023-05-04 Thread Konstantin Kostiuk
From: Daniel Xu Previously capture-output was an optional boolean flag that either captured all output or captured none. While this is OK in most cases, it lacks flexibility for more advanced capture cases, such as wanting to only capture stdout. This commits refactors guest-exec qapi to take an

[PULL 5/6] qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0601

2023-05-04 Thread Konstantin Kostiuk
From: Thomas Huth All current versions of glib require _WIN32_WINNT set to 0x0601 or higher already, and we also use this value as a minimum in our osdep.h header file, so there is no way to still compile this code with an older version of the Windows ABI. Thus we can drop this check now. Signed

[PULL 6/6] qga: Fix suspend on Linux guests without systemd

2023-05-04 Thread Konstantin Kostiuk
From: Mark Somerville Allow the Linux guest agent to attempt each of the suspend methods (systemctl, pm-* and writing to /sys) in turn. Prior to this guests without systemd failed to suspend due to `guest_suspend` returning early regardless of the return value of `systemd_supports_mode`. Signed

[PULL 0/6] Misc QGA patches

2023-05-04 Thread Konstantin Kostiuk
From: Kostiantyn Kostiuk The following changes since commit 044f8cf70a2fdf3b9e4c4d849c66e7855d2c446a: Merge tag 'migration-20230428-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-05-03 10:29:30 +0100) are available in the Git repository at: g...@github.com:kost

[PULL 1/6] qga/linux: add usb support to guest-get-fsinfo

2023-05-04 Thread Konstantin Kostiuk
From: Kfir Manor Signed-off-by: Kfir Manor Reviewed-by: Konstantin Kostiuk Signed-off-by: Konstantin Kostiuk --- qga/commands-posix.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 079689d79a..97754930c1 100644 --- a/

[PULL 4/6] qga: test: Add tests for `merged` flag

2023-05-04 Thread Konstantin Kostiuk
From: Daniel Xu This commit adds a test to ensure `merged` functions as expected. We also add a negative test to ensure we haven't regressed previous functionality. Reviewed-by: Daniel P. Berrangé Signed-off-by: Daniel Xu Signed-off-by: Konstantin Kostiuk --- tests/unit/test-qga.c | 158

[PULL 3/6] qga: Add `merged` variant to GuestExecCaptureOutputMode

2023-05-04 Thread Konstantin Kostiuk
From: Daniel Xu Currently, any captured output (via `capture-output`) is segregated into separate GuestExecStatus fields (`out-data` and `err-data`). This means that downstream consumers have no way to reassemble the captured data back into the original stream. This is relevant for chatty and se

Re: [RFC PATCH v4 00/44] Add LoongArch LSX instructions

2023-05-04 Thread Richard Henderson
On 5/4/23 09:25, Richard Henderson wrote: On 5/4/23 02:26, Song Gao wrote: V4:    - R-b and rebase;    - Migrate the upper half lsx regs;    - Remove tcg_gen_mulus2_*;    - Vsetallnez use !do_match2;    - Use tcg_gen_concat_i64_i128/tcg_gen_extr_i128_i64 to replace TCGV128_LOW(val)/TCGV128_

Re: [PATCH] migration: Fix block_bitmap_mapping migration

2023-05-04 Thread Kevin Wolf
Am 03.05.2023 um 20:10 hat Juan Quintela geschrieben: > It is valid that params->has_block_bitmap_mapping is true and > params->block_bitmap_mapping is NULL. So we can't use the trick of > having a single function. > > Move to two functions one for each value and the tests are fixed. > > Fixes:

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-04 Thread Daniel P . Berrangé
On Thu, May 04, 2023 at 02:19:21PM +0530, Ani Sinha wrote: > > > > On 04-May-2023, at 1:32 PM, Daniel P. Berrangé wrote: > > > > On Thu, May 04, 2023 at 08:35:53AM +0200, Thomas Huth wrote: > >> On 03/05/2023 16.55, Ani Sinha wrote: > >>> mformat and xorriso tools are needed by biosbits avocado

[PATCH v2 2/2] block/blkio: add 'fd' option to virtio-blk-vhost-vdpa driver

2023-05-04 Thread Stefano Garzarella
The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the new 'fd' property. Let's expose this to the user, so the management layer can pass the file descriptor of an already opened vhost-vdpa character device. This is useful especially when the device can only be accessed with certain privil

[PATCH v2 1/2] stubs/monitor: add monitor_fd_param()

2023-05-04 Thread Stefano Garzarella
The blkio block driver will use monitor_fd_param() to support file descriptor passing. This is possible in builds (e.g. softmmu) where the monitor API is available. Add the monitor_fd_param() stub so tools and tests that link the block layer can build successfully. Signed-off-by: Stefano Garzarel

[PATCH v2 0/2] block/blkio: add 'fd' option to virtio-blk-vhost-vdpa driver

2023-05-04 Thread Stefano Garzarella
v2: - added patch 01 to use monitor_fd_param() in the blkio module - use monitor_fd_param() to parse the fd like vhost devices [Stefan] v1: https://lore.kernel.org/qemu-devel/20230502145050.224615-1-sgarz...@redhat.com/ The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the new 'fd' pro

RE: [PATCH v4 10/10] migration: block incoming colo when capability is disabled

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [PATCH v4 10/10] migration: bl

Re: [PATCH v2] qga: Fix suspend on Linux guests without systemd

2023-05-04 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Thu, Apr 6, 2023 at 3:42 PM Mark Somerville wrote: > Allow the Linux guest agent to attempt each of the suspend methods > (systemctl, pm-* and writing to /sys) in turn. > > Prior to this guests without systemd failed to suspend due to > `guest_suspend` return

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-04 Thread Ani Sinha
> On 04-May-2023, at 2:19 PM, Ani Sinha wrote: > > > >> On 04-May-2023, at 1:32 PM, Daniel P. Berrangé wrote: >> >> On Thu, May 04, 2023 at 08:35:53AM +0200, Thomas Huth wrote: >>> On 03/05/2023 16.55, Ani Sinha wrote: mformat and xorriso tools are needed by biosbits avocado tests. Th

Re: [PATCH] meson: leave unnecessary modules out of the build

2023-05-04 Thread Michael Tokarev
04.05.2023 11:21, Paolo Bonzini wrote: meson.build files choose whether to build modules based on foo.found() expressions. If a feature is enabled (e.g. --enable-gtk), these expressions are true even if the code is not used by any emulator, and this results in an unexpected difference between mo

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-04 Thread Ani Sinha
> On 04-May-2023, at 2:28 PM, Daniel P. Berrangé wrote: > > On Thu, May 04, 2023 at 12:40:12PM +0530, Ani Sinha wrote: >> >> >>> On 04-May-2023, at 12:05 PM, Thomas Huth wrote: >>> >>> On 03/05/2023 16.55, Ani Sinha wrote: mformat and xorriso tools are needed by biosbits avocado tests

RE: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Thursday, May 4, 2023 4:23 PM > To: Zhang, Chen ; qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Peter Xu > ; Leonardo Bras > Subject: Re: [PATCH v4 09/10] migration: disallow change capabilities in

Re: [PATCH] qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0601

2023-05-04 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Thu, May 4, 2023 at 11:19 AM Daniel P. Berrangé wrote: > On Thu, May 04, 2023 at 09:54:09AM +0200, Thomas Huth wrote: > > All current versions of glib require _WIN32_WINNT set to 0x0601 > > or higher already, and we also use this value as a minimum in our > >

Re: [PATCH 1/3] target/arm: Use CONFIG_SEMIHOSTING instead of TCG for semihosting

2023-05-04 Thread Peter Maydell
On Thu, 4 May 2023 at 08:33, Paolo Bonzini wrote: > > On 5/3/23 21:38, Fabiano Rosas wrote: > > When building --without-default-devices, the semihosting code will not > > be available, so check the proper config. I think the changes to the ifdeffery are conceptually fine (only do semihosting if i

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-04 Thread Daniel P . Berrangé
On Thu, May 04, 2023 at 12:40:12PM +0530, Ani Sinha wrote: > > > > On 04-May-2023, at 12:05 PM, Thomas Huth wrote: > > > > On 03/05/2023 16.55, Ani Sinha wrote: > >> mformat and xorriso tools are needed by biosbits avocado tests. This > >> patchset > >> adds those two tools in the docker conta

Re: [PATCH v4 2/2] meson: Deserialize the man pages and html builds

2023-05-04 Thread Peter Maydell
On Wed, 3 May 2023 at 21:39, Fabiano Rosas wrote: > > For the documentation builds (man pages & manual), we let Sphinx > decide when to rebuild and use a depfile to know when to trigger the > make target. > > We currently use a trick of having the man pages custom_target take as > input the html p

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-04 Thread Ani Sinha
> On 04-May-2023, at 1:32 PM, Daniel P. Berrangé wrote: > > On Thu, May 04, 2023 at 08:35:53AM +0200, Thomas Huth wrote: >> On 03/05/2023 16.55, Ani Sinha wrote: >>> mformat and xorriso tools are needed by biosbits avocado tests. This >>> patchset >>> adds those two tools in the docker contai

Re: [PATCH] block/blkio: add 'fd' option to virtio-blk-vhost-vdpa driver

2023-05-04 Thread Stefano Garzarella
On Thu, May 4, 2023 at 9:38 AM Stefano Garzarella wrote: > > On Wed, May 3, 2023 at 5:57 PM Stefan Hajnoczi wrote: > > > > On Wed, May 03, 2023 at 11:15:56AM +0200, Stefano Garzarella wrote: > > > On Tue, May 02, 2023 at 03:02:32PM -0400, Stefan Hajnoczi wrote: > > > > On Tue, May 02, 2023 at 04:

Re: [PULL 11/18] migration: Create migrate_block_bitmap_mapping() function

2023-05-04 Thread Kevin Wolf
Am 03.05.2023 um 19:15 hat Juan Quintela geschrieben: > Kevin Wolf wrote: > > Am 27.04.2023 um 17:22 hat Juan Quintela geschrieben: > >> Notice that we changed the test of ->has_block_bitmap_mapping > >> for the test that block_bitmap_mapping is not NULL. > >> > >> Signed-off-by: Juan Quintela >

Re: [PATCH] softfloat: Fix the incorrect computation in float32_exp2()

2023-05-04 Thread Richard Henderson
On 5/4/23 06:21, Shivaprasad G Bhat wrote: Hi Richard, On 5/3/23 01:11, Richard Henderson wrote: On 5/2/23 16:25, Shivaprasad G Bhat wrote: The float32_exp2() is computing wrong exponent of 2. For example, with the following set of values {0.1, 2.0, 2.0, -1.0}, the expected output would be {1

Re: [RFC PATCH v4 00/44] Add LoongArch LSX instructions

2023-05-04 Thread Richard Henderson
On 5/4/23 02:26, Song Gao wrote: V4:    - R-b and rebase;    - Migrate the upper half lsx regs;    - Remove tcg_gen_mulus2_*;    - Vsetallnez use !do_match2;    - Use tcg_gen_concat_i64_i128/tcg_gen_extr_i128_i64 to replace TCGV128_LOW(val)/TCGV128_High(val); One minor nit, everything revi

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-04 Thread Daniel P . Berrangé
On Thu, May 04, 2023 at 01:52:36PM +0530, Ani Sinha wrote: > > > > On 04-May-2023, at 1:32 PM, Daniel P. Berrangé wrote: > > > > On Thu, May 04, 2023 at 08:35:53AM +0200, Thomas Huth wrote: > >> On 03/05/2023 16.55, Ani Sinha wrote: > >>> mformat and xorriso tools are needed by biosbits avocado

Re: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-04 Thread Vladimir Sementsov-Ogievskiy
On 04.05.23 11:09, Zhang, Chen wrote: -Original Message- From: Vladimir Sementsov-Ogievskiy Sent: Saturday, April 29, 2023 3:49 AM To: qemu-devel@nongnu.org Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen ; vsement...@yandex-team.ru; Peter Xu ; Leonardo Bras Subject: [PATCH

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-04 Thread Ani Sinha
> On 04-May-2023, at 1:32 PM, Daniel P. Berrangé wrote: > > On Thu, May 04, 2023 at 08:35:53AM +0200, Thomas Huth wrote: >> On 03/05/2023 16.55, Ani Sinha wrote: >>> mformat and xorriso tools are needed by biosbits avocado tests. This >>> patchset >>> adds those two tools in the docker contai

Re: [PATCH] include/qemu/osdep.h: Bump _WIN32_WINNT to the Windows 8 API

2023-05-04 Thread Daniel P . Berrangé
On Thu, May 04, 2023 at 10:13:51AM +0200, Thomas Huth wrote: > Commit cf60ccc330 ("cutils: Introduce bundle mechanism") abandoned > compatibility with Windows older than 8 - we should reflect this > in our _WIN32_WINNT and set it to the value that corresponds to > Windows 8. Reference for this cl

[PATCH] meson: leave unnecessary modules out of the build

2023-05-04 Thread Paolo Bonzini
meson.build files choose whether to build modules based on foo.found() expressions. If a feature is enabled (e.g. --enable-gtk), these expressions are true even if the code is not used by any emulator, and this results in an unexpected difference between modular and non-modular builds. For non-mo

Re: [PATCH] qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0601

2023-05-04 Thread Daniel P . Berrangé
On Thu, May 04, 2023 at 09:54:09AM +0200, Thomas Huth wrote: > All current versions of glib require _WIN32_WINNT set to 0x0601 > or higher already, and we also use this value as a minimum in our > osdep.h header file, so there is no way to still compile this code > with an older version of the Wind

Re: [RFC 1/1] migration: Update error description whenever migration fails

2023-05-04 Thread Daniel P . Berrangé
On Wed, May 03, 2023 at 08:31:16PM +, tejus.gk wrote: > There are places in the code where the migration is marked failed with > MIGRATION_STATUS_FAILED, but the failiure reason is never updated. Hence > libvirt doesn't know why the migration failed when it queries for it. > > Signed-off-by: t

[PATCH] include/qemu/osdep.h: Bump _WIN32_WINNT to the Windows 8 API

2023-05-04 Thread Thomas Huth
Commit cf60ccc330 ("cutils: Introduce bundle mechanism") abandoned compatibility with Windows older than 8 - we should reflect this in our _WIN32_WINNT and set it to the value that corresponds to Windows 8. Signed-off-by: Thomas Huth --- include/qemu/osdep.h | 2 +- 1 file changed, 1 insertion(+

RE: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [PATCH v4 09/10] migration: di

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-04 Thread Daniel P . Berrangé
On Thu, May 04, 2023 at 08:35:53AM +0200, Thomas Huth wrote: > On 03/05/2023 16.55, Ani Sinha wrote: > > mformat and xorriso tools are needed by biosbits avocado tests. This > > patchset > > adds those two tools in the docker container images. > > tests/qtest/cdrom-test.c already uses genisoimage

Re: [PATCH 4/9] target/m68k: Finish conversion to tcg_gen_qemu_{ld,st}_*

2023-05-04 Thread Richard Henderson
On 5/3/23 14:08, Anton Johansson wrote: @@ -971,23 +958,16 @@ static void gen_load_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp,   tmp = tcg_temp_new();   switch (opsize) {   case OS_BYTE: -    tcg_gen_qemu_ld8s(tmp, addr, index); -    gen_helper_exts32(cpu_env, fp,

Re: [PATCH 7/9] target/sparc: Finish conversion to tcg_gen_qemu_{ld, st}_*

2023-05-04 Thread Richard Henderson
On 5/3/23 21:11, Mark Cave-Ayland wrote: @@ -5390,7 +5399,8 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn)   lo = gen_load_gpr(dc, rd + 1);   t64 = tcg_temp_new_i64();   tcg_gen_concat_tl_i64(t64, lo,

[PATCH] qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0601

2023-05-04 Thread Thomas Huth
All current versions of glib require _WIN32_WINNT set to 0x0601 or higher already, and we also use this value as a minimum in our osdep.h header file, so there is no way to still compile this code with an older version of the Windows ABI. Thus we can drop this check now. Signed-off-by: Thomas Huth

RE: [PATCH v4 07/10] migration: split migration_incoming_co

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Thursday, May 4, 2023 6:52 AM > To: Peter Xu > Cc: qemu-devel@nongnu.org; lukasstra...@web.de; quint...@redhat.com; > Zhang, Chen ; Zhang, Hailiang > ; Leonardo Bras > Subject: Re: [PATCH v4 07/10] migration: split migra

RE: [PATCH v4 06/10] migration: process_incoming_migration_co: simplify code flow around ret

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [PATCH v4 06/10] migration: pr

RE: [PATCH v4 05/10] migration: drop colo_incoming_thread from MigrationIncomingState

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Peter Xu > ; Leonardo Bras > Subject: [PATCH v4 05/10] migration: dr

RE: [PATCH v4 04/10] configure: add --disable-colo-proxy option

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Paolo Bonzini > ; Marc-André Lureau > ; Daniel P. Berrangé > ; Thomas

Re: [PATCH] block/blkio: add 'fd' option to virtio-blk-vhost-vdpa driver

2023-05-04 Thread Stefano Garzarella
On Wed, May 3, 2023 at 5:57 PM Stefan Hajnoczi wrote: > > On Wed, May 03, 2023 at 11:15:56AM +0200, Stefano Garzarella wrote: > > On Tue, May 02, 2023 at 03:02:32PM -0400, Stefan Hajnoczi wrote: > > > On Tue, May 02, 2023 at 04:50:50PM +0200, Stefano Garzarella wrote: > > > > The virtio-blk-vhost-

RE: [PATCH v3 1/2] igb: RX descriptors handling cleanup

2023-05-04 Thread Tomasz Dzieciol/VIM Integration (NC) /SRPOL/Engineer/Samsung Electronics
I will remove checking RXCSUM.IPPCSE flag then. -Original Message- From: Akihiko Odaki Sent: środa, 3 maja 2023 17:11 To: Sriram Yagnaraman ; Tomasz Dzieciol/VIM Integration (NC) /SRPOL/Engineer/Samsung Electronics ; qemu-devel@nongnu.org Cc: jasow...@redhat.com; k.kwiec...@samsung.com

RE: [PATCH v4 02/10] colo: make colo_checkpoint_notify static and provide simpler API

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Zhang, Hailiang > ; Peter Xu ; Leonardo > Bras > Subject: [PATCH v4

Re: [PATCH 1/3] target/arm: Use CONFIG_SEMIHOSTING instead of TCG for semihosting

2023-05-04 Thread Paolo Bonzini
On 5/3/23 21:38, Fabiano Rosas wrote: When building --without-default-devices, the semihosting code will not be available, so check the proper config. Acked-by: Paolo Bonzini for this change; however, there are two more related issues: 1) you still want to leave out the code if !TCG, because

RE: [PATCH v4 01/10] block/meson.build: prefer positive condition for replication

2023-05-04 Thread Zhang, Chen
> -Original Message- > From: Vladimir Sementsov-Ogievskiy > Sent: Saturday, April 29, 2023 3:49 AM > To: qemu-devel@nongnu.org > Cc: lukasstra...@web.de; quint...@redhat.com; Zhang, Chen > ; vsement...@yandex-team.ru; Philippe Mathieu- > Daudé ; Kevin Wolf ; Hanna Reitz > ; open list:Blo

Re: [PATCH 3/3] tests/qtest: Don't run cdrom tests if no accelerator is present

2023-05-04 Thread Paolo Bonzini
On 5/3/23 21:38, Fabiano Rosas wrote: On a build configured with: --disable-tcg --enable-xen it is possible to produce a QEMU binary with no TCG nor KVM support. Skip the test if that's the case. Fixes: 0c1ae3ff9d ("tests/qtest: Fix tests when no KVM or TCG are present") Signed-off-by: Fabiano R

Re: [PATCH 2/3] target/arm: Add CONFIG_ARM_V7M back to default.mak

2023-05-04 Thread Paolo Bonzini
On 5/3/23 21:38, Fabiano Rosas wrote: We cannot allow this config to be disabled at the moment as not all of the relevant code is protected by it. Commit 29d9efca16 ("arm/Kconfig: Do not build TCG-only boards on a KVM-only build") moved the CONFIGs of several boards to Kconfig, so it is now poss

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-04 Thread Paolo Bonzini
On 5/3/23 20:32, Peter Maydell wrote: Do we really want to build a QEMU that then barfs unless you pass -nodefaults, though ? That doesn't seem very useful. Something somewhere ought to be saying "if you want the virt board then you almost certainly want these". Well, the point is that --withou

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-04 Thread Thomas Huth
On 04/05/2023 09.10, Ani Sinha wrote: On 04-May-2023, at 12:05 PM, Thomas Huth wrote: On 03/05/2023 16.55, Ani Sinha wrote: mformat and xorriso tools are needed by biosbits avocado tests. This patchset adds those two tools in the docker container images. tests/qtest/cdrom-test.c already u

Re: [PULL 11/35] arm/Kconfig: Do not build TCG-only boards on a KVM-only build

2023-05-04 Thread Thomas Huth
On 02/05/2023 14.14, Peter Maydell wrote: From: Fabiano Rosas Move all the CONFIG_FOO=y from default.mak into "default y if TCG" statements in Kconfig. That way they won't be selected when CONFIG_TCG=n. I'm leaving CONFIG_ARM_VIRT in default.mak because it allows us to keep the two default.mak

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-04 Thread Alex Bennée
Thomas Huth writes: > On 03/05/2023 20.32, Peter Maydell wrote: >> On Wed, 3 May 2023 at 18:06, Paolo Bonzini wrote: >>> >>> On 5/3/23 17:35, Alex Bennée wrote: > You should select a device only if you cannot even start > the machine without --nodefaults. Which is the case he

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-04 Thread Ani Sinha
> On 04-May-2023, at 12:05 PM, Thomas Huth wrote: > > On 03/05/2023 16.55, Ani Sinha wrote: >> mformat and xorriso tools are needed by biosbits avocado tests. This patchset >> adds those two tools in the docker container images. > > tests/qtest/cdrom-test.c already uses genisoimage to create

<    1   2   3   4   5