Re: [PATCH] Revert "hw/sparc64/niagara: Use blk_name() instead of open-coding it"

2023-05-16 Thread Philippe Mathieu-Daudé
On 16/5/23 10:04, Markus Armbruster wrote: Mark Cave-Ayland writes: On 15/05/2023 16:11, Markus Armbruster wrote: This reverts commit 1881f336a33a8a99cb17ab1c57ed953682e8e107. This commit breaks "-drive if=pflash,readonly=on,file=image.iso". It claims to merely replace an open-coded

Re: [PATCH v4 2/6] ui: add the infrastructure to support MT events

2023-05-16 Thread Markus Armbruster
Sergio Lopez writes: > Add the required infrastructure to support generating multitouch events. > > Signed-off-by: Sergio Lopez > Reviewed-by: Marc-André Lureau > --- > include/ui/input.h| 3 +++ > qapi/ui.json | 58 --- >

Re: [RFC] cxl: Multi-headed device design

2023-05-16 Thread Gregory Price
On Mon, May 15, 2023 at 05:18:07PM +0100, Jonathan Cameron wrote: > On Tue, 21 Mar 2023 21:50:33 -0400 > Gregory Price wrote: > > > > > Ambiguity #1: > > > > * An SLD contains 1 Logical Device. > > * An MH-SLD presents multiple SLDs, one per head. > > > > Ergo an MH-SLD contains multiple LDs

Re: [PATCH v2 5/6] qmp: Added new command to retrieve eBPF blob.

2023-05-16 Thread Daniel P . Berrangé
On Tue, May 16, 2023 at 05:06:24PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, May 16, 2023 at 04:04:39PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Tue, May 16, 2023 at 12:23:28PM +0200, Markus Armbruster wrote: > >> >> Daniel

Re: [PATCH] migration: Fix duplicated included in meson.build

2023-05-16 Thread Daniel P . Berrangé
On Tue, May 09, 2023 at 07:02:17PM +0200, Juan Quintela wrote: > This is the commint with the merge error (not in the submited patch). > > commit 52623f23b0d114837a0d6278180b3e3ae8947117 > Author: Lukas Straub > Date: Thu Apr 20 11:48:35 2023 +0200 > > ram-compress.c: Make target

Re: Resources on deeper understanding of Translation blocks

2023-05-16 Thread Peter Maydell
On Tue, 16 May 2023 at 16:27, Alex Bennée wrote: > Gautam Bhat writes: > > 3. Do you have more information or a visual diagram of sorts for > > TARGET_PAGE_* and PAGE_* and the relation between translation blocks > > and pages? Also how > > should one handle where architectures don't have any

Re: Question about QMP and BQL

2023-05-16 Thread Fabiano Rosas
Kevin Wolf writes: > Am 12.05.2023 um 20:01 hat Fabiano Rosas geschrieben: >> Is there a way to execute a long-standing QMP command outside of the >> BQL? >> >> The situation we're seeing is a slow query-block due to a slow system >> call (fstat over NFS) causing the main thread to spend too

Re: Resources on deeper understanding of Translation blocks

2023-05-16 Thread Alex Bennée
Gautam Bhat writes: > On Mon, May 15, 2023 at 7:22 PM Alex Bennée wrote: >> >> >> Gautam Bhat writes: >> >> > Hi, >> > >> > I am going through some translation code for existing targets. >> > >> > I would like to know if there are any good resources on deeper >> > understanding of

Re: [PATCH] hw/scsi/lsi53c895a: Fix reentrancy issues in the LSI controller (CVE-2023-0330)

2023-05-16 Thread Stefan Hajnoczi
On Tue, 16 May 2023 at 10:50, Thomas Huth wrote: > > On 16/05/2023 15.40, Stefan Hajnoczi wrote: > > On Tue, 16 May 2023 at 06:20, Thomas Huth wrote: > >> > >> We cannot use the generic reentrancy guard in the LSI code, so > >> we have to manually prevent endless reentrancy here. The problematic

Re: [PATCH v2 5/6] qmp: Added new command to retrieve eBPF blob.

2023-05-16 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, May 16, 2023 at 04:04:39PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Tue, May 16, 2023 at 12:23:28PM +0200, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Tue, May 16, 2023 at 10:47:52AM +0200,

RE: [Qemu RFC 0/7] Early enabling of DCD emulation in Qemu

2023-05-16 Thread Singh, Navneet
-Original Message- From: Jonathan Cameron Sent: Monday, May 15, 2023 6:31 PM To: Fan Ni Cc: qemu-devel@nongnu.org; linux-...@vger.kernel.org; gregory.pr...@memverge.com; hch...@avery-design.com.tw; Browy, Christopher ; Weiny, Ira ; Williams, Dan J ; Adam Manzanares ;

Re: How to communicate 2 guest machines over serial in qemu?

2023-05-16 Thread Alex Bennée
Sidhartha Reddy Kaliki writes: > Hi, > > We have 2 independent devices running openbmc software on each of > them. These devices can communicate with each other over a serial line > using SLIP protocol. Now we would like to emulate the same using qemu. > > Do we have any provision to

Re: [PATCH] hw/scsi/lsi53c895a: Fix reentrancy issues in the LSI controller (CVE-2023-0330)

2023-05-16 Thread Thomas Huth
On 16/05/2023 15.40, Stefan Hajnoczi wrote: On Tue, 16 May 2023 at 06:20, Thomas Huth wrote: We cannot use the generic reentrancy guard in the LSI code, so we have to manually prevent endless reentrancy here. The problematic lsi_execute_script() function has already a way to detect whether

Re: [PATCH v5 12/21] xen-block: implement BlockDevOps->drained_begin()

2023-05-16 Thread Anthony PERARD via
On Thu, May 04, 2023 at 03:53:18PM -0400, Stefan Hajnoczi wrote: > @@ -819,11 +841,9 @@ void xen_block_dataplane_start(XenBlockDataPlane > *dataplane, > blk_set_aio_context(dataplane->blk, dataplane->ctx, NULL); > aio_context_release(old_context); > > -/* Only reason for failure

RE: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

2023-05-16 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: 16 May 2023 15:28 > To: Shameerali Kolothum Thodi > Cc: Jason Gunthorpe ; Avihai Horon ; > qemu-devel@nongnu.org; Juan Quintela ; Dr. David > Alan Gilbert ; Michael S. Tsirkin ; > Cornelia Huck ;

Re: [PATCH v2 5/6] qmp: Added new command to retrieve eBPF blob.

2023-05-16 Thread Daniel P . Berrangé
On Tue, May 16, 2023 at 04:04:39PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, May 16, 2023 at 12:23:28PM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Tue, May 16, 2023 at 10:47:52AM +0200, Markus Armbruster wrote: > >> > >>

Re: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

2023-05-16 Thread Alex Williamson
On Tue, 16 May 2023 13:57:22 + Shameerali Kolothum Thodi wrote: > > -Original Message- > > From: Jason Gunthorpe [mailto:j...@nvidia.com] > > Sent: 16 May 2023 13:00 > > To: Shameerali Kolothum Thodi > > Cc: Avihai Horon ; qemu-devel@nongnu.org; Alex > > Williamson ; Juan Quintela >

Re: [PATCH v5 13/21] hw/xen: do not set is_external=true on evtchn fds

2023-05-16 Thread Anthony PERARD via
On Thu, May 04, 2023 at 03:53:19PM -0400, Stefan Hajnoczi wrote: > is_external=true suspends fd handlers between aio_disable_external() and > aio_enable_external(). The block layer's drain operation uses this > mechanism to prevent new I/O from sneaking in between > bdrv_drained_begin() and

Re: [PATCH v5 12/21] xen-block: implement BlockDevOps->drained_begin()

2023-05-16 Thread Anthony PERARD via
On Thu, May 04, 2023 at 03:53:18PM -0400, Stefan Hajnoczi wrote: > Detach event channels during drained sections to stop I/O submission > from the ring. xen-block is no longer reliant on aio_disable_external() > after this patch. This will allow us to remove the > aio_disable_external() API once

Re: [PATCH] coverity: the definitive COMPONENTS.md update

2023-05-16 Thread Peter Maydell
On Mon, 15 May 2023 at 15:00, Paolo Bonzini wrote: > > The ordering here tries to be logical and matches the one in the > website. > > Signed-off-by: Paolo Bonzini Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v5 2/3] hw/mem: Use memory_region_size() in cxl_type3

2023-05-16 Thread Gregory Price
On Fri, Apr 21, 2023 at 05:08:26PM +0100, Jonathan Cameron wrote: > Accessors prefered over direct use of int128_get64() as they > clamp out of range values. None are expected here but > cleaner to always use the accessor than mix and match. > > Signed-off-by: Jonathan Cameron > > --- > v5:

Re: [PATCH v5 11/54] accel/tcg: Add aarch64 specific support in ldst_atomicity

2023-05-16 Thread Richard Henderson
On 5/16/23 06:56, Peter Maydell wrote: On Tue, 16 May 2023 at 14:51, Richard Henderson wrote: On 5/16/23 06:29, Peter Maydell wrote: On Mon, 15 May 2023 at 15:38, Richard Henderson wrote: We have code in atomic128.h noting that through GCC 8, there was no support for atomic operations on

Re: [PATCH v2 5/6] qmp: Added new command to retrieve eBPF blob.

2023-05-16 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, May 16, 2023 at 12:23:28PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Tue, May 16, 2023 at 10:47:52AM +0200, Markus Armbruster wrote: >> >> [...] >> >> >> So, this is basically a way to retrieve an eBPF program by some >> >>

Re: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

2023-05-16 Thread Jason Gunthorpe
On Tue, May 16, 2023 at 01:57:22PM +, Shameerali Kolothum Thodi wrote: > > What happens on your platform if a guest tries to do P2P? Does the > > platform crash? > > I am not sure. Since the devices are behind SMMU, I was under the assumption > that we do have the guarantee of isolation

Re: [PULL v2 12/17] qapi: Rewrite parsing of doc comment section symbols and tags

2023-05-16 Thread Markus Armbruster
Igor Mammedov writes: > On Wed, 10 May 2023 10:12:22 +0200 > Markus Armbruster wrote: > >> To recognize a line starting with a section symbol and or tag, we >> first split it at the first space, then examine the part left of the >> space. We can just as well examine the unsplit line, so do

RE: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

2023-05-16 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Jason Gunthorpe [mailto:j...@nvidia.com] > Sent: 16 May 2023 13:00 > To: Shameerali Kolothum Thodi > Cc: Avihai Horon ; qemu-devel@nongnu.org; Alex > Williamson ; Juan Quintela > ; Dr. David Alan Gilbert ; > Michael S. Tsirkin ; Cornelia Huck ; > Paolo

Re: [PATCH v5 11/54] accel/tcg: Add aarch64 specific support in ldst_atomicity

2023-05-16 Thread Peter Maydell
On Tue, 16 May 2023 at 14:51, Richard Henderson wrote: > > On 5/16/23 06:29, Peter Maydell wrote: > > On Mon, 15 May 2023 at 15:38, Richard Henderson > > wrote: > >> > >> We have code in atomic128.h noting that through GCC 8, there > >> was no support for atomic operations on __uint128. This

Re: [PATCH v5 36/54] tcg: Introduce tcg_out_movext3

2023-05-16 Thread Richard Henderson
On 5/16/23 03:03, Peter Maydell wrote: On Mon, 15 May 2023 at 15:43, Richard Henderson wrote: With x86_64 as host, we do not have any temporaries with which to resolve cycles, but we do have xchg. As a side bonus, the set of graphs that can be made with 3 nodes and all nodes conflicting is

Re: [PATCH v5 11/54] accel/tcg: Add aarch64 specific support in ldst_atomicity

2023-05-16 Thread Richard Henderson
On 5/16/23 06:29, Peter Maydell wrote: On Mon, 15 May 2023 at 15:38, Richard Henderson wrote: We have code in atomic128.h noting that through GCC 8, there was no support for atomic operations on __uint128. This has been fixed in GCC 10. But we can still improve over any basic

Re: [PATCH v5 10/54] accel/tcg: Use have_atomic16 in ldst_atomicity.c.inc

2023-05-16 Thread Richard Henderson
On 5/16/23 03:38, Peter Maydell wrote: On Mon, 15 May 2023 at 15:37, Richard Henderson wrote: Hosts using Intel and AMD AVX cpus are quite common. Add fast paths through ldst_atomicity using this. Only enable with CONFIG_INT128; some older clang versions do not support __int128_t, and the

Re: [PATCH v5 02/54] accel/tcg: Honor atomicity of loads

2023-05-16 Thread Richard Henderson
On 5/16/23 06:13, Peter Maydell wrote: On Mon, 15 May 2023 at 15:35, Richard Henderson wrote: Create ldst_atomicity.c.inc. Not required for user-only code loads, because we've ensured that the page is read-only before beginning to translate code. Signed-off-by: Richard Henderson --- v5:

Re: [PATCH v7 1/1] arm/kvm: add support for MTE

2023-05-16 Thread Peter Maydell
On Fri, 28 Apr 2023 at 10:55, Cornelia Huck wrote: > > Extend the 'mte' property for the virt machine to cover KVM as > well. For KVM, we don't allocate tag memory, but instead enable the > capability. > > If MTE has been enabled, we need to disable migration, as we do not > yet have a way to

Re: Resources on deeper understanding of Translation blocks

2023-05-16 Thread Gautam Bhat
On Mon, May 15, 2023 at 7:22 PM Alex Bennée wrote: > > > Gautam Bhat writes: > > > Hi, > > > > I am going through some translation code for existing targets. > > > > I would like to know if there are any good resources on deeper > > understanding of translation blocks? Also some advice on the

Re: [PATCH v5 54/54] tcg/s390x: Support 128-bit load/store

2023-05-16 Thread Peter Maydell
On Mon, 15 May 2023 at 15:43, Richard Henderson wrote: > > Use LPQ/STPQ when 16-byte atomicity is required. > Note that these instructions require 16-byte alignment. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell (at least it looks the right shape; I'm not an s390 expert :-))

Re: [PATCH] hw/scsi/lsi53c895a: Fix reentrancy issues in the LSI controller (CVE-2023-0330)

2023-05-16 Thread Stefan Hajnoczi
On Tue, 16 May 2023 at 06:20, Thomas Huth wrote: > > We cannot use the generic reentrancy guard in the LSI code, so > we have to manually prevent endless reentrancy here. The problematic > lsi_execute_script() function has already a way to detect whether > too many instructions have been executed

Re: Performance improvement with 58a2e3f5c37be02dac3086b81bdda9414b931edf

2023-05-16 Thread Stefan Hajnoczi
Thanks! Stefan

How to communicate 2 guest machines over serial in qemu?

2023-05-16 Thread Sidhartha Reddy Kaliki
Hi, We have 2 independent devices running openbmc software on each of them. These devices can communicate with each other over a serial line using SLIP protocol. Now we would like to emulate the same using qemu. Do we have any provision to communicate 2 guest machines over a serial interface

Re: Performance improvement with 58a2e3f5c37be02dac3086b81bdda9414b931edf

2023-05-16 Thread Lukáš Doktor
Dne 16. 05. 23 v 15:19 Stefan Hajnoczi napsal(a): > On Tue, 16 May 2023 at 08:56, Lukáš Doktor wrote: >> >> Hello Stefan, folks, >> >> the perf-ci detected and bisected the 58a2e3f5c37 - block: compile out >> assert_bdrv_graph_readable() by default - as a performance improvement >> especially

Re: [PATCH] qapi/parser: Fix type hints

2023-05-16 Thread Richard Henderson
On 5/15/23 22:22, Markus Armbruster wrote: https://gitlab.com/qemu-project/qemu/-/jobs/4289613692#L574 File "/builds/qemu-project/qemu/scripts/qapi/parser.py", line 566, in QAPIDoc def _match_at_name_colon(string: str) -> Optional[re.Match[str]]: TypeError: 'type' object is not

Re: [PATCH v5 11/54] accel/tcg: Add aarch64 specific support in ldst_atomicity

2023-05-16 Thread Peter Maydell
On Mon, 15 May 2023 at 15:38, Richard Henderson wrote: > > We have code in atomic128.h noting that through GCC 8, there > was no support for atomic operations on __uint128. This has > been fixed in GCC 10. But we can still improve over any > basic compare-and-swap loop using the ldxp/stxp

Re: Performance improvement with 58a2e3f5c37be02dac3086b81bdda9414b931edf

2023-05-16 Thread Stefan Hajnoczi
On Tue, 16 May 2023 at 08:56, Lukáš Doktor wrote: > > Hello Stefan, folks, > > the perf-ci detected and bisected the 58a2e3f5c37 - block: compile out > assert_bdrv_graph_readable() by default - as a performance improvement > especially with 4K reads with multiple jobs (but minor improvements

Re: [PATCH v5 14/54] accel/tcg: Add have_lse2 support in ldst_atomicity

2023-05-16 Thread Peter Maydell
On Mon, 15 May 2023 at 15:37, Richard Henderson wrote: > > Add fast paths for FEAT_LSE2, using the detection in tcg. > > Signed-off-by: Richard Henderson > --- > accel/tcg/ldst_atomicity.c.inc | 37 ++ > 1 file changed, 33 insertions(+), 4 deletions(-) >

Re: [PATCH v5 02/54] accel/tcg: Honor atomicity of loads

2023-05-16 Thread Peter Maydell
On Mon, 15 May 2023 at 15:35, Richard Henderson wrote: > > Create ldst_atomicity.c.inc. > > Not required for user-only code loads, because we've ensured that > the page is read-only before beginning to translate code. > > Signed-off-by: Richard Henderson > --- > v5: Dropped r-b because of

Performance improvement with 58a2e3f5c37be02dac3086b81bdda9414b931edf

2023-05-16 Thread Lukáš Doktor
Hello Stefan, folks, the perf-ci detected and bisected the 58a2e3f5c37 - block: compile out assert_bdrv_graph_readable() by default - as a performance improvement especially with 4K reads with multiple jobs (but minor improvements were observed in other variants)

[PULL 1/9] linux-user: Emulate /proc/cpuinfo output for riscv

2023-05-16 Thread Laurent Vivier
From: Afonso Bordado RISC-V does not expose all extensions via hwcaps, thus some userspace applications may want to query these via /proc/cpuinfo. Currently when querying this file the host's file is shown instead which is slightly confusing. Emulate a basic /proc/cpuinfo file with mmu info and

Re: [PATCH 2/3] ACPI: i386: bump to MADT to revision 3

2023-05-16 Thread Ani Sinha
On Tue, May 16, 2023 at 6:01 PM Igor Mammedov wrote: > > On Mon, 15 May 2023 16:33:10 -0400 > Eric DeVolder wrote: > > > Currently i386 QEMU generates MADT revision 3, and reports > > MADT revision 1. Set .revision to 3 to match reality. > > > > Link: > >

[PULL 6/9] linux-user: Add new flag VERIFY_NONE

2023-05-16 Thread Laurent Vivier
From: Thomas Weißschuh This can be used to validate that an address range is mapped but without being readable or writable. It will be used by an updated implementation of mincore(). Signed-off-by: Thomas Weißschuh Reviewed-by: Laurent Vivier Message-Id:

[PULL 0/9] Linux user for 8.1 patches

2023-05-16 Thread Laurent Vivier
The following changes since commit 7c18f2d663521f1b31b821a13358ce38075eaf7d: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-04-29 23:07:17 +0100) are available in the Git repository at: https://github.com/vivier/qemu.git tags/linux-user-for-8.1-pull-request

[PULL 3/9] linux-user: Add move_mount() syscall

2023-05-16 Thread Laurent Vivier
From: Thomas Weißschuh Signed-off-by: Thomas Weißschuh Reviewed-by: Laurent Vivier [lv: define syscall] Message-Id: <20230424153429.276788-1-tho...@t-8ch.de> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 33 + 1 file changed, 33 insertions(+) diff

[PULL 8/9] linux-user: Fix mips fp64 executables loading

2023-05-16 Thread Laurent Vivier
From: Daniil Kovalev If a program requires fr1, we should set the FR bit of CP0 control status register and add F64 hardware flag. The corresponding `else if` branch statement is copied from the linux kernel sources (see `arch_check_elf` function in linux/arch/mips/kernel/elf.c). Signed-off-by:

[PULL 5/9] linux-user/main: Use list_cpus() instead of cpu_list()

2023-05-16 Thread Laurent Vivier
From: Thomas Huth This way we can get rid of the if'deffery and the XXX comment here (it's repeated in the list_cpus() function anyway). Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230424122126.236586-1-th...@redhat.com>

[PULL 4/9] linux-user: Add open_tree() syscall

2023-05-16 Thread Laurent Vivier
From: Thomas Weißschuh Signed-off-by: Thomas Weißschuh Reviewed-by: Laurent Vivier Message-Id: <20230424153429.276788-2-tho...@t-8ch.de> [lv: move declaration at the beginning of the block, define syscall] Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 33

Re: [PATCH v3 5/6] qemu: log reservations in fw_cfg e820 table

2023-05-16 Thread Philippe Mathieu-Daudé
On 5/5/23 09:11, Gerd Hoffmann wrote: With loglevel 1 (same we use for RAM entries), so it is included in the firmware log by default. Signed-off-by: Gerd Hoffmann --- src/fw/paravirt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

[PULL 7/9] linux-user: Don't require PROT_READ for mincore

2023-05-16 Thread Laurent Vivier
From: Thomas Weißschuh The kernel does not require PROT_READ for addresses passed to mincore. For example the fincore(1) tool from util-linux uses PROT_NONE and currently does not work under qemu-user. Example (with fincore(1) from util-linux 2.38): $ fincore /proc/self/exe RES PAGES SIZE

[PULL 2/9] linux-user: report ENOTTY for unknown ioctls

2023-05-16 Thread Laurent Vivier
From: Thomas Weißschuh The correct error number for unknown ioctls is ENOTTY. ENOSYS would mean that the ioctl() syscall itself is not implemented, which is very improbable and unexpected for userspace. ENOTTY means "Inappropriate ioctl for device". This is what the kernel returns on unknown

[PULL 9/9] linux-user: fix getgroups/setgroups allocations

2023-05-16 Thread Laurent Vivier
From: Michael Tokarev linux-user getgroups(), setgroups(), getgroups32() and setgroups32() used alloca() to allocate grouplist arrays, with unchecked gidsetsize coming from the "guest". With NGROUPS_MAX being 65536 (linux, and it is common for an application to allocate NGROUPS_MAX for

Re: [PATCH v2 01/16] migration: Don't use INT64_MAX for unlimited rate

2023-05-16 Thread Cédric Le Goater
On 5/16/23 11:24, Juan Quintela wrote: David Edmondson wrote: Juan Quintela writes: Define and use RATE_LIMIT_MAX instead. Suggest "RATE_LIMIT_MAX_NONE". Then even better RATE_LIMIT_DISABLED? I'd vote for RATE_LIMIT_DISABLED. RATE_LIMIT_NONE? Using MAX and NONE at the same time

Re: [PATCH v2 05/16] migration: Move rate_limit_max and rate_limit_used to migration_stats

2023-05-16 Thread Cédric Le Goater
On 5/15/23 21:56, Juan Quintela wrote: These way we can make them atomic and use this functions from any place. I also moved all functions that use rate_limit to migration-stats. Functions got renamed, they are not qemu_file anymore. qemu_file_rate_limit -> migration_rate_exceeded

Re: [PATCH 2/3] ACPI: i386: bump to MADT to revision 3

2023-05-16 Thread Igor Mammedov
On Mon, 15 May 2023 16:33:10 -0400 Eric DeVolder wrote: > Currently i386 QEMU generates MADT revision 3, and reports > MADT revision 1. Set .revision to 3 to match reality. > > Link: > https://lore.kernel.org/linux-acpi/20230327191026.3454-1-eric.devolder@ora > cle.com/T/#t > Signed-off-by:

Re: [PULL v2 12/17] qapi: Rewrite parsing of doc comment section symbols and tags

2023-05-16 Thread Igor Mammedov
On Wed, 10 May 2023 10:12:22 +0200 Markus Armbruster wrote: > To recognize a line starting with a section symbol and or tag, we > first split it at the first space, then examine the part left of the > space. We can just as well examine the unsplit line, so do that. this makes build fail on

Re: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

2023-05-16 Thread Jason Gunthorpe
On Tue, May 16, 2023 at 10:03:54AM +, Shameerali Kolothum Thodi wrote: > > Currently VFIO migration doesn't implement some kind of intermediate > > quiescent state in which P2P DMAs are quiesced before stopping or > > running the device. This can cause problems in multi-device migration > >

[PULL v2 02/21] sysemu/kvm: Remove unused headers

2023-05-16 Thread Thomas Huth
From: Philippe Mathieu-Daudé All types used are forward-declared in "qemu/typedefs.h". Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20230405160454.97436-2-phi...@linaro.org> [thuth: Add hw/core/cpu.h to migration/dirtyrate.c to fix compile failure] Signed-off-by: Thomas Huth ---

[PULL v2 00/21] Tests, docs, s390x and misc patches

2023-05-16 Thread Thomas Huth
Hi Richard! The following changes since commit ab4c44d657aeca7e1da6d6dcb1741c8e7d357b8b: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2023-05-15 13:54:33 -0700) are available in the Git repository at: https://gitlab.com/thuth/qemu.git

Re: [PATCH v3 1/6] better kvm detection

2023-05-16 Thread Gerd Hoffmann
On Fri, May 05, 2023 at 09:11:12AM +0200, Gerd Hoffmann wrote: > > In case kvm emulates features of another hypervisor (for example hyperv) > two VMM CPUID blocks will be present, one for the emulated hypervisor > and one for kvm itself. > > This patch makes seabios loop over the VMM CPUID

Re: [PATCH v2 03/16] migration: Move setup_time to mig_stats

2023-05-16 Thread David Edmondson
Juan Quintela writes: > David Edmondson wrote: >> Juan Quintela writes: >> >>> It is a time that needs to be cleaned each time cancel migration. >>> Once there create migration_time_since() to calculate how time since a >>> time in the past. >>> >>> Signed-off-by: Juan Quintela >>> >>> ---

Re: [PATCH v3 2/9] target/ppc: Fix PMU MMCR0[PMCjCE] bit in hflags calculation

2023-05-16 Thread Daniel Henrique Barboza
On 5/16/23 07:44, Nicholas Piggin wrote: On Tue May 16, 2023 at 7:32 PM AEST, Daniel Henrique Barboza wrote: On 5/15/23 06:26, Nicholas Piggin wrote: A store to MMCR0 with PMCjCE=1 fails to update hflags correctly and results in hflags mismatch: qemu: fatal: TCG hflags mismatch

[PATCH v2 03/27] python: add mkvenv.py

2023-05-16 Thread Paolo Bonzini
From: John Snow This script will be responsible for building a lightweight Python virtual environment at configure time. It works with Python 3.6 or newer. It has been designed to: - work *offline*, no PyPI required. - work *quickly*, The fast path is only ~65ms on my machine. - work

[PATCH v2 19/27] qemu.git: drop meson git submodule

2023-05-16 Thread Paolo Bonzini
From: John Snow Now that meson is installed from a vendored wheel, we don't need the git submodule anymore. Drop it. Signed-off-by: John Snow Message-Id: <20230511035435.734312-19-js...@redhat.com> Signed-off-by: Paolo Bonzini --- .gitmodules | 3 --- meson | 1 - 2 files changed, 4

[PATCH v2 21/27] configure: move --enable-docs and --disable-docs back to configure

2023-05-16 Thread Paolo Bonzini
From: John Snow Move this option back from meson into configure for the purposes of using the configuration value to bootstrap Sphinx in different ways based on this value. Signed-off-by: John Snow Message-Id: <20230511035435.734312-21-js...@redhat.com> Signed-off-by: Paolo Bonzini ---

[PATCH v2 24/27] Python: Drop support for Python 3.6

2023-05-16 Thread Paolo Bonzini
Python 3.6 was EOL 2021-12-31. Newer versions of upstream libraries have begun dropping support for this version and it is becoming more cumbersome to support. Avocado-framework and qemu.qmp each have their own reasons for wanting to drop Python 3.6, but won't until QEMU does. Versions of Python

[PATCH v2 10/27] mkvenv: avoid ensurepip if pip is installed

2023-05-16 Thread Paolo Bonzini
From: John Snow Signed-off-by: Paolo Bonzini --- python/scripts/mkvenv.py | 67 ++-- 1 file changed, 64 insertions(+), 3 deletions(-) diff --git a/python/scripts/mkvenv.py b/python/scripts/mkvenv.py index 9e50bfb1778b..7fc30dc1b3e8 100644 ---

[PATCH v2 04/27] mkvenv: add better error message for broken or missing ensurepip

2023-05-16 Thread Paolo Bonzini
From: John Snow Debian debundles ensurepip for python; NetBSD debundles pyexpat but ensurepip needs pyexpat. Try our best to offer a helpful error message instead of just failing catastrophically. Signed-off-by: John Snow Message-Id: <20230511035435.734312-5-js...@redhat.com> Signed-off-by:

[PATCH v2 06/27] mkvenv: add ensure subcommand

2023-05-16 Thread Paolo Bonzini
From: John Snow This command is to be used to add various packages (or ensure they're already present) into the configure-provided venv in a modular fashion. Examples: mkvenv ensure --online --dir "${source_dir}/python/wheels/" "meson>=0.61.5" mkvenv ensure --online "sphinx>=1.6.0" mkvenv

[PATCH v2 25/27] configure: Add courtesy hint to Python version failure message

2023-05-16 Thread Paolo Bonzini
From: John Snow If we begin requiring Python 3.7+, a few platforms are going to need to install an additional Python interpreter package. As a courtesy to the user, suggest the optional package they might need to install. This will hopefully minimize any downtime caused by the change in Python

[PATCH v2 16/27] configure: create a python venv unconditionally

2023-05-16 Thread Paolo Bonzini
From: John Snow This patch changes the configure script so that it always creates and uses a python virtual environment unconditionally. Meson bootstrapping is temporarily altered to force the use of meson from git or vendored source (as packaged in our source tarballs). A subsequent commit

[PATCH v2 20/27] tests: Use configure-provided pyvenv for tests

2023-05-16 Thread Paolo Bonzini
From: John Snow This patch changes how the avocado tests are provided, ever so slightly. Instead of creating a new testing venv, use the configure-provided 'pyvenv' instead, and install optional packages into that. Signed-off-by: John Snow Message-Id:

[PATCH v2 08/27] mkvenv: add console script entry point generation

2023-05-16 Thread Paolo Bonzini
From: John Snow When creating a virtual environment that inherits system packages, script entry points (like "meson", "sphinx-build", etc) are not re-generated with the correct shebang. When you are *inside* of the venv, this is not a problem, but if you are *outside* of it, you will not have a

Re: [RFC PATCH 1/1] virtio-balloon: Add Working Set Reporting feature

2023-05-16 Thread Dr. David Alan Gilbert
* T.J. Alumbaugh (talum...@google.com) wrote: > Working Set Reporting supported in virtio-balloon. > - adds working set reporting and notification vqueues > - QMP API additions: >- guest-ws property on balloon >- generates QMP WS_EVENT when new reports available >- ws_config,

[PATCH v2 22/27] configure: bootstrap sphinx with mkvenv

2023-05-16 Thread Paolo Bonzini
From: John Snow When docs are explicitly requested, require Sphinx>=1.6.0. When docs are explicitly disabled, don't bother to check for Sphinx at all. If docs are set to "auto", attempt to locate Sphinx, but continue onward if it wasn't located. Signed-off-by: Paolo Bonzini Signed-off-by: John

[PATCH v2 23/27] configure: add --enable-pypi and --disable-pypi

2023-05-16 Thread Paolo Bonzini
From: John Snow In the event that there's no vendored source present and no sufficient version of $package can be found, we will attempt to connect to PyPI to install the package if '--disable-pypi' was not passed. This means that PyPI access is "enabled by default", but there are some

[PATCH v2 14/27] tests/vm: add py310-expat to NetBSD

2023-05-16 Thread Paolo Bonzini
From: John Snow NetBSD cannot successfully run "ensurepip" without access to the pyexpat module, which NetBSD debundles. Like the Debian patch, it would be strictly faster long term to install pip/setuptools, and I recommend developers at their workstations take that approach instead. For the

[PATCH v2 11/27] mkvenv: work around broken pip installations on Debian 10

2023-05-16 Thread Paolo Bonzini
From: John Snow This is a workaround intended for Debian 10, where the debian-patched pip does not function correctly if accessed from within a virtual environment. We don't support Debian 10 as a build platform any longer, though we do still utilize it for our build-tricore-softmmu CI test.

[PATCH v2 12/27] tests/docker: add python3-venv dependency

2023-05-16 Thread Paolo Bonzini
From: John Snow Several debian-based tests need the python3-venv dependency as a consequence of Debian debundling the "ensurepip" module normally included with Python. As mkvenv.py stands as of this commit, Debian requires EITHER: (A) setuptools and pip, or (B) ensurepip mkvenv is a few

[PATCH v2 26/27] mkvenv: mark command as required

2023-05-16 Thread Paolo Bonzini
This is only available in Python 3.7+. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Message-Id: <20230511035435.734312-26-js...@redhat.com> Signed-off-by: Paolo Bonzini --- python/scripts/mkvenv.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/scripts/mkvenv.py

[PATCH v2 15/27] python: add vendor.py utility

2023-05-16 Thread Paolo Bonzini
From: John Snow This is a teeny-tiny script that just downloads any packages we want to vendor from PyPI and stores them in qemu.git/python/wheels/. If I'm hit by a meteor, it'll be easy to replicate what I have done in order to udpate the vendored source. We don't really care which python runs

[PATCH v2 27/27] python: bump some of the dependencies

2023-05-16 Thread Paolo Bonzini
The version of pyflakes that is listed in python/tests/minreqs.txt breaks on Python 3.8 with the following message: AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT' Now that we do not support EOL'd Python versions anymore, we can update to newer, fixed versions. It is a good

[PATCH v2 18/27] configure: use 'mkvenv ensure meson' to bootstrap meson

2023-05-16 Thread Paolo Bonzini
From: John Snow This commit changes how we detect and install meson. It notably removes '--meson='. Currently, configure creates a lightweight Python virtual environment unconditionally using the user's configured $python that inherits system packages. Temporarily, we forced the use of meson

[PATCH v2 05/27] mkvenv: add nested venv workaround

2023-05-16 Thread Paolo Bonzini
From: John Snow Python virtual environments do not typically nest; they may inherit from the top-level system packages or not at all. For our purposes, it would be convenient to emulate "nested" virtual environments to allow callers of the configure script to install specific versions of python

[PATCH v2 13/27] tests/vm: Configure netbsd to use Python 3.10

2023-05-16 Thread Paolo Bonzini
From: John Snow NetBSD removes some packages from the Python stdlib, but only re-packages them for Python 3.10. Switch to using Python 3.10. Signed-off-by: John Snow Reviewed-by: Daniel P. Berrangé Message-Id: <20230511035435.734312-13-js...@redhat.com> Signed-off-by: Paolo Bonzini ---

[PATCH v2 09/27] mkvenv: use pip's vendored distlib as a fallback

2023-05-16 Thread Paolo Bonzini
From: John Snow distlib is usually not installed on Linux distribution, but it is vendored into pip. Because the virtual environment has pip via ensurepip, we can piggy-back on pip's vendored version. This could break if they move our cheese in the future, but the fix would be simply to

[PATCH v2 01/27] python: shut up "pip install" during "make check-minreqs"

2023-05-16 Thread Paolo Bonzini
"make check-minreqs" runs pip without the --disable-pip-version-check option, which causes the obnoxious "A new release of pip available" message. Recent versions of pip also complain that some of the dependencies in our virtual environment rely on "setup.py install" instead of providing a

[PATCH v2 07/27] mkvenv: add --diagnose option to explain "ensure" failures

2023-05-16 Thread Paolo Bonzini
From: John Snow This is a routine that is designed to print some usable info for human beings back out to the terminal if/when "mkvenv ensure" fails to locate or install a package during configure time, such as meson or sphinx. Since we are requiring that "meson" and "sphinx" are installed to

[PATCH v2 02/27] python: update pylint configuration

2023-05-16 Thread Paolo Bonzini
From: John Snow Pylint 2.17.x decided that SocketAddrT was a bad name for a Type Alias for some reason. Sure, fine, whatever. Signed-off-by: John Snow Reviewed-by: Daniel P. Berrangé Message-Id: <20230511035435.734312-3-js...@redhat.com> Signed-off-by: Paolo Bonzini --- python/setup.cfg | 1

[PATCH v2 00/27] configure: create a python venv and ensure meson, sphinx

2023-05-16 Thread Paolo Bonzini
This patch series creates a mandatory python virtual environment ("venv") during configure time and uses it to ensure the availability of meson and sphinx. See https://www.qemu.org/2023/03/24/python/ for motivations. The summary is that the goal of this series is to ensure that the `python` used

Re: [PATCH v5 29/54] tcg/sparc64: Use standard slow path for softmmu

2023-05-16 Thread Peter Maydell
On Mon, 15 May 2023 at 15:38, Richard Henderson wrote: > > Drop the target-specific trampolines for the standard slow path. > This lets us use tcg_out_helper_{ld,st}_args, and handles the new > atomicity bits within MemOp. > > At the same time, use the full load/store helpers for user-only mode.

Re: [PULL 0/9] Linux user for 8.1 patches

2023-05-16 Thread Laurent Vivier
Le 16/05/2023 à 12:20, Afonso Bordado a écrit : Hey Laurent, I was having some issues reproducing this bug, but that looks like a likely explanation! Should I resubmit the patch with that diff applied? No, I'm going to update it. Thanks, Laurent Thanks! On 5/16/2023 10:11 AM, Laurent

[RFC PATCH] target/arm: add RAZ/WI handling for DBGDTR[TX|RX]

2023-05-16 Thread Alex Bennée
The commit b3aa2f2128 (target/arm: provide stubs for more external debug registers) was added to handle HyperV's unconditional usage of Debug Communications Channel. It turns out that Linux will similarly break if you enable CONFIG_HVC_DCC "ARM JTAG DCC console". Extend the registers we RAZ/WI

Re: [PATCH v3 2/9] target/ppc: Fix PMU MMCR0[PMCjCE] bit in hflags calculation

2023-05-16 Thread Nicholas Piggin
On Tue May 16, 2023 at 7:32 PM AEST, Daniel Henrique Barboza wrote: > > > On 5/15/23 06:26, Nicholas Piggin wrote: > > A store to MMCR0 with PMCjCE=1 fails to update hflags correctly and > > results in hflags mismatch: > > > >qemu: fatal: TCG hflags mismatch (current:0x2408003d

Re: [PATCH v5 10/54] accel/tcg: Use have_atomic16 in ldst_atomicity.c.inc

2023-05-16 Thread Peter Maydell
On Mon, 15 May 2023 at 15:37, Richard Henderson wrote: > > Hosts using Intel and AMD AVX cpus are quite common. > Add fast paths through ldst_atomicity using this. > > Only enable with CONFIG_INT128; some older clang versions do not > support __int128_t, and the inline assembly won't work on

Re: [PATCH v4 0/8] migration: Modified 'migrate' and 'migrate-incoming' QAPI commands for migration

2023-05-16 Thread Markus Armbruster
Doesn't apply to current master anymore, and patchew couldn't apply it, either[*]. I'll look at v5. Thanks! [*] https://patchew.org/QEMU/20230512143240.192504-1-het.g...@nutanix.com/

<    1   2   3   4   >