Re: [PATCH 2/2] hw/pci-host/pam: Remove northbridge-specific PAM_REGIONS_COUNT

2024-03-09 Thread Philippe Mathieu-Daudé
On 9/3/24 14:40, Bernhard Beschow wrote: PAM_REGIONS_COUNT being 13 seems to be Intel-specific. There are VIA 82cXX northbridges having only 10, for example. Communicate this by having northbridge-specific constants. Signed-off-by: Bernhard Beschow -- Do we need the constants or can we omit t

Re: [PATCH v9 00/21] Introduce smp.modules for x86 in QEMU

2024-03-09 Thread Philippe Mathieu-Daudé
Hi Zhao, On 9/3/24 01:49, Zhao Liu wrote: On Fri, Mar 08, 2024 at 05:36:38PM +0100, Philippe Mathieu-Daudé wrote: Date: Fri, 8 Mar 2024 17:36:38 +0100 From: Philippe Mathieu-Daudé Subject: Re: [PATCH v9 00/21] Introduce smp.modules for x86 in QEMU On 27/2/24 11:32, Zhao Liu wrote: --- Zhao

Re: [PATCH v2 00/13] Cleanup on SMP and its test

2024-03-09 Thread Philippe Mathieu-Daudé
On 9/3/24 01:46, Zhao Liu wrote: Hi Philippe, Can you share your base commit please? Applying: hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations Applying: hw/core/machine-smp: Deprecate unsupported "parameter=1" SMP configurations error: patch failed: docs/about/deprecat

Re: [PATCH v9 08/21] i386/cpu: Consolidate the use of topo_info in cpu_x86_cpuid()

2024-03-09 Thread Xiaoyao Li
On 2/27/2024 6:32 PM, Zhao Liu wrote: From: Zhao Liu In cpu_x86_cpuid(), there are many variables in representing the cpu topology, e.g., topo_info, cs->nr_cores and cs->nr_threads. Since the names of cs->nr_cores/cs->nr_threads does not accurately Again as in v7, please changes to "cs->nr_co

[PATCH 1/2] hw/pci-host/pam: Free PAMMemoryRegion from Intel-specific bit handling

2024-03-09 Thread Bernhard Beschow
The PAM bit extraction is currently spread across pam.c and the northbridge device models, making the extraction logic harder to comprehend. Also note how pam_update() deals with PAM_REGIONS_COUNT, even though it handles exactly one region. Fix this (at the cost of minor code duplication) by moving

Re: [PATCH v9 07/21] i386/cpu: Use APIC ID info get NumSharingCache for CPUID[0x8000001D].EAX[bits 25:14]

2024-03-09 Thread Xiaoyao Li
On 2/27/2024 6:32 PM, Zhao Liu wrote: From: Zhao Liu The commit 8f4202fb1080 ("i386: Populate AMD Processor Cache Information for cpuid 0x801D") adds the cache topology for AMD CPU by encoding the number of sharing threads directly. From AMD's APM, NumSharingCache (CPUID[0x801D].EAX[b

[PATCH 2/2] hw/pci-host/pam: Remove northbridge-specific PAM_REGIONS_COUNT

2024-03-09 Thread Bernhard Beschow
PAM_REGIONS_COUNT being 13 seems to be Intel-specific. There are VIA 82cXX northbridges having only 10, for example. Communicate this by having northbridge-specific constants. Signed-off-by: Bernhard Beschow -- Do we need the constants or can we omit them, given they're just used once? --- inc

[PATCH 0/2] Make PAMMemoryRegion less Intel-specific

2024-03-09 Thread Bernhard Beschow
This series makes pam_update() more self-contained by removing some Intel assumptions. As a result, the purpose of PAMMemoryRegion becomes clearer and, as a side effect, makes it reusable for northbridges other than Intel, e.g. VIA. Testing done: * `make check` * `make check-avocado` * This series

Re: [PATCH v9 06/21] i386/cpu: Use APIC ID info to encode cache topo in CPUID[4]

2024-03-09 Thread Xiaoyao Li
On 2/27/2024 6:32 PM, Zhao Liu wrote: From: Zhao Liu Refer to the fixes of cache_info_passthrough ([1], [2]) and SDM, the CPUID.04H:EAX[bits 25:14] and CPUID.04H:EAX[bits 31:26] should use the nearest power-of-2 integer. The nearest power-of-2 integer can be calculated by pow2ceil() or by usin

Re: [PATCH] disas/riscv: Further correction to LUI disassembly

2024-03-09 Thread Andrew Jones
On Fri, Mar 08, 2024 at 08:22:01PM -0800, Richard Bagley wrote: > post-nack, one further comment: > > One could argue that this change also aligns QEMU with supporting tools (as > Andrew observed), and it makes sense to merge this change into QEMU until > those tools update to supporting signed de

[RFC PATCH] tests/vm: ensure we build everything by default

2024-03-09 Thread Alex Bennée
The "check" target by itself is not enough to ensure we build the user mode binaries. While we can't test them with check-tcg we can at least include them in the build. Signed-off-by: Alex Bennée Cc: Richard Henderson Cc: Gustavo Romero --- tests/vm/basevm.py | 2 +- 1 file changed, 1 insertio

Re: [PATCH v2 3/5] gdbstub: Save target's siginfo

2024-03-09 Thread Alex Bennée
Richard Henderson writes: > On 3/8/24 09:25, Alex Bennée wrote: >>make vm-build-[open|net|free]bsd >> see make vm-help for details. > > That won't build freebsd user. > Something I've mentioned to you before... make vm-build-freebsd BUILD_TARGET=all I guess the default "check" target does

Re: [PATCH v7 02/10] target/ppc: Readability improvements in exception handlers

2024-03-09 Thread BALATON Zoltan
On Thu, 29 Feb 2024, Nicholas Piggin wrote: On Wed Feb 28, 2024 at 6:24 AM AEST, BALATON Zoltan wrote: On Tue, 27 Feb 2024, BALATON Zoltan wrote: On Tue, 27 Feb 2024, Peter Maydell wrote: On Tue, 27 Feb 2024 at 15:10, BALATON Zoltan wrote: Improve readability by shortening some long comment

Re: [PATCH] hw/ppc/sam460ex: Support short options for adding drives

2024-03-09 Thread BALATON Zoltan
On Tue, 5 Mar 2024, BALATON Zoltan wrote: Having to use -drive if=none,... and -device ide-[cd,hd] is inconvenient. Add support for shorter convenience options such as -cdrom and -drive media=disk. Also adjust two nearby comments for code style. Signed-off-by: BALATON Zoltan Ping for freeze?

Re: [PATCH v3] docs/system/ppc: Document running Linux on AmigaNG machines

2024-03-09 Thread BALATON Zoltan
On Thu, 29 Feb 2024, BALATON Zoltan wrote: On Wed, 21 Feb 2024, BALATON Zoltan wrote: Documentation on how to run Linux on the amigaone, pegasos2 and sam460ex machines is currently buried in the depths of the qemu-devel mailing list and in the source code. Let's collect the information in the QE

Re: Unmapping KVM Guest Memory from Host Kernel

2024-03-09 Thread Mike Rapoport
On Fri, Mar 08, 2024 at 03:22:50PM -0800, Sean Christopherson wrote: > On Fri, Mar 08, 2024, James Gowans wrote: > > However, memfd_secret doesn’t work out the box for KVM guest memory; the > > main reason seems to be that the GUP path is intentionally disabled for > > memfd_secret, so if we use a

[PATCH v3] hw/m68k/mcf5208: add support for reset

2024-03-09 Thread Angelo Dureghello
Add reset support for mcf5208. Signed-off-by: Angelo Dureghello --- hw/m68k/mcf5208.c | 44 ++-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c index 0cfb806c20..ec14096aa4 100644 --- a/hw/m68k/mcf5208.

Re: [PATCH v2] hw/m68k/mcf5208: add support for reset

2024-03-09 Thread Angelo Dureghello
Hi Thomas, On 09/03/24 10:06 AM, Thomas Huth wrote: Am Fri, 8 Mar 2024 10:08:12 +0100 schrieb Angelo Dureghello : Add reset support for mcf5208. Signed-off-by: Angelo Dureghello --- hw/m68k/mcf5208.c | 49 --- 1 file changed, 46 insertions(+),

Re: [PATCH v2] hw/m68k/mcf5208: add support for reset

2024-03-09 Thread Thomas Huth
Am Fri, 8 Mar 2024 10:08:12 +0100 schrieb Angelo Dureghello : > Add reset support for mcf5208. > > Signed-off-by: Angelo Dureghello > --- > hw/m68k/mcf5208.c | 49 --- > 1 file changed, 46 insertions(+), 3 deletions(-) > > diff --git a/hw/m68k/mcf52

Re: [PATCH v4 7/7] Update maintainer contact for migration multifd zero page checking acceleration.

2024-03-09 Thread hao . xiang
> > On Sun, Mar 3, 2024 at 11:34 PM Peter Xu wrote: > > > > > On Fri, Mar 01, 2024 at 02:28:29AM +, Hao Xiang wrote: > > > > Add myself to maintain multifd zero page checking acceleration function. > > > > Signed-off-by: Hao Xiang > > > > --- > > > > MAINTAINERS | 5 + > > > >

Re: [PATCH v4 2/7] migration/multifd: Implement zero page transmission on the multifd thread.

2024-03-09 Thread hao . xiang
> > On Mon, Mar 4, 2024 at 10:24 AM Fabiano Rosas wrote: > > > > > > Fabiano Rosas writes: > > > > Peter Xu writes: > > > > On Fri, Mar 01, 2024 at 02:28:24AM +, Hao Xiang wrote: > > > > -GlobalProperty hw_compat_8_2[] = {}; > > > > +GlobalProperty hw_compat_8_2[

[PATCH v5 3/7] migration/multifd: Add new migration option zero-page-detection.

2024-03-09 Thread Hao Xiang
From: Hao Xiang This new parameter controls where the zero page checking is running. 1. If this parameter is set to 'legacy', zero page checking is done in the migration main thread. 2. If this parameter is set to 'none', zero page checking is disabled. Signed-off-by: Hao Xiang Reviewed-by: Pet

<    1   2