On 7/12/24 18:27, Philippe Mathieu-Daudé wrote:
Tag to test Aspeed tree:
https://gitlab.com/philmd/qemu/-/tags/aspeed_emmc-v9
Updated aspeed9.1 branch. LGTM.
Thanks,
C.
Since v48:
- Dropped "Implement 'boot-mode' reset timing" patch
- Re-introduce Joel "Support boot area in emmc image"
On 7/12/24 04:02, Edgar E. Iglesias wrote:
From: "Edgar E. Iglesias"
The following changes since commit 23901b2b721c0576007ab7580da8aa855d6042a9:
Merge tag 'pull-target-arm-20240711'
ofhttps://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-07-11
12:00:00 -0700)
are available
https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240712
for you to fetch changes up to 3ef4b21a5c767ff0b15047e709762abef490ad07:
target/loongarch: Fix cpu_reset set wrong CSR_CRMD (2024-07-12 09:41:18
+0800)
pull
On 7/12/24 01:03, Simon Hamelin wrote:
This new plugin allows to stop emulation using conditions on the
emulation state. By setting this plugin arguments, it is possible
to set an instruction count limit and/or trigger address(es) to stop at.
The code returned at emulation exit can be customized.
Hello Simon,
On 7/12/24 00:53, Simon Hamelin wrote:
On 7/11/24 12:03, Alex Bennée wrote:
+static void exit_emulation(int return_code)
+{
+exit(return_code);
+}
+
+static void exit_icount_reached(unsigned int cpu_index, void *udata)
+{
+qemu_plugin_outs("icount reached, exiting\n");
+
On 7/12/24 07:51, Alex Bennée wrote:
Pierrick Bouvier writes:
On 7/8/24 12:15, Alex Bennée wrote:
Pierrick Bouvier writes:
Add an explicit test to check expected memory values are read/written.
For sizes 8, 16, 32, 64 and 128, we generate a load/store operation.
For size 8 -> 64, we genera
On 7/11/24 11:04, Klaus Jensen wrote:
From: Klaus Jensen
Hi,
The following changes since commit 59084feb256c617063e0dbe7e64821ae8852d7cf:
Merge tag 'pull-aspeed-20240709' ofhttps://github.com/legoater/qemu into
staging (2024-07-09 07:13:55 -0700)
are available in the Git repository at:
On Fri, 12 Jul 2024 at 17:36, Cédric Le Goater wrote:
>
> Coverity reports a possible integer overflow because routine
> aspeeed_smc_hclk_divisor() has a codepath returning 0, which could
> lead to an integer overflow when computing variable 'hclk_shift' in
> the caller aspeed_smc_dma_calibration(
Coverity reports a possible integer overflow because routine
aspeeed_smc_hclk_divisor() has a codepath returning 0, which could
lead to an integer overflow when computing variable 'hclk_shift' in
the caller aspeed_smc_dma_calibration().
The value passed to aspeed_smc_hclk_divisor() is always betwe
On 28/6/24 20:27, Gregor Haas wrote:
The read() syscall is not guaranteed to return all data from a file. The
default ROM loader implementation currently does not take this into account,
instead failing if all bytes are not read at once. This change loads the ROM
using g_file_get_contents() inste
On 8/7/24 17:33, Peter Maydell wrote:
The doc comments for the functions for named GPIO inputs and
outputs had a couple of problems:
* some copy-and-paste errors meant the qdev_connect_gpio_out_named()
doc comment had references to input GPIOs that should be to
output GPIOs
* it wasn'
From: Cédric Le Goater
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Cédric Le Goater
Tested-by: Andrew Jeffery
Signed-off-by: Philippe Mathieu-Daudé
Tested-by: Cédric Le Goater
---
hw/sd/sd.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
Signed-off-by: Philippe Mathieu-Daudé
Tested-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Tested-by: Andrew Jeffery
---
hw/sd/sd.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 09077f0154..a90612af58 100644
--- a/hw/sd/sd.c
+
From: Joel Stanley
This assumes a specially constructed image:
dd if=/dev/zero of=mmc-bootarea.img count=2 bs=1M
dd if=u-boot-spl.bin of=mmc-bootarea.img conv=notrunc
dd if=u-boot.bin of=mmc-bootarea.img conv=notrunc count=64 bs=1K
cat mmc-bootarea.img obmc-phosphor-image.wic > mmc.img
Tag to test Aspeed tree:
https://gitlab.com/philmd/qemu/-/tags/aspeed_emmc-v9
Since v48:
- Dropped "Implement 'boot-mode' reset timing" patch
- Re-introduce Joel "Support boot area in emmc image" patch
- Comment magic CSD values
Cédric Le Goater (2):
hw/sd/sdcard: Add emmc_cmd_SET_RELATIVE_AD
Avoid hardcoding 1MiB boot size in EXT_CSD_BOOT_MULT,
expose it as 'boot-partition-size' QOM property.
By default, do not use any size. The board is responsible
to set the boot partition size property.
Signed-off-by: Philippe Mathieu-Daudé
Tested-by: Cédric Le Goater
---
hw/sd/sd.c | 5 -
From: Sai Pavan Boddu
switch operation in mmc cards, updated the ext_csd register to
request changes in card operations. Here we implement similar
sequence but requests are mostly dummy and make no change.
Implement SWITCH_ERROR if the write operation offset goes beyond
length of ext_csd.
Signe
From: Philippe Mathieu-Daudé
Since eMMC are soldered on boards, it is not user-creatable.
RCA register is initialized to 0x0001, per spec v4.3,
chapter 8.5 "RCA register":
The default value of the RCA register is 0x0001.
The value 0x is reserved to set all cards into
the Stand-by Stat
From: Vincent Palatin
The parameters mimick a real 4GB eMMC, but it can be set to various
sizes.
Signed-off-by: Vincent Palatin
Signed-off-by: Cédric Le Goater
Signed-off-by: Sai Pavan Boddu
Signed-off-by: Edgar E. Iglesias
Signed-off-by: Cédric Le Goater
EXT_CSD values from Vincent's patc
From: Luc Michel
The JEDEC standards specifies a sleep state where the eMMC won't
answer any command appart from RESET and WAKEUP and go to low power
state. Implement this state and the corresponding command number 5.
Signed-off-by: Luc Michel
Signed-off-by: Francisco Iglesias
Signed-off-by:
From: Cédric Le Goater
The number of blocks is defined in the lower bits [15:0].
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Cédric Le Goater
Tested-by: Andrew Jeffery
Signed-off-by: Philippe Mathieu-Daudé
Tested-by: Cédric Le Goater
---
hw/sd/sd.c | 3 +++
1 file changed, 3 inserti
Per the spec v4.3 these commands are mandatory,
but we don't implement them.
Reviewed-by: Cédric Le Goater
Tested-by: Cédric Le Goater
Tested-by: Andrew Jeffery
Signed-off-by: Philippe Mathieu-Daudé
Tested-by: Cédric Le Goater
---
hw/sd/sd.c | 9 +
1 file changed, 9 insertions(+)
di
Tested-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Tested-by: Andrew Jeffery
Signed-off-by: Philippe Mathieu-Daudé
Tested-by: Cédric Le Goater
---
hw/sd/sd.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index ea01bf6e28..0093bbab3
On 7/12/24 16:39, Peter Maydell wrote:
On Fri, 13 Sept 2019 at 16:50, Peter Maydell wrote:
From: Cédric Le Goater
When doing calibration, the SPI clock rate in the CE0 Control Register
and the read delay cycles in the Read Timing Compensation Register are
set using bit[11:4] of the DMA Contr
On Fri, 12 Jul 2024 at 16:39, Stefano Garzarella wrote:
>
> Coverity reported:
>
> >>> CID 1549454: Integer handling issues (OVERFLOW_BEFORE_WIDEN)
> >>> Potentially overflowing expression
> "le32_to_cpu(desc->num_sectors) << 9" with type "uint32_t"
> (32 bits, un
Coverity reported:
>>> CID 1549454: Integer handling issues (OVERFLOW_BEFORE_WIDEN)
>>> Potentially overflowing expression
"le32_to_cpu(desc->num_sectors) << 9" with type "uint32_t"
(32 bits, unsigned) is evaluated using 32-bit arithmetic, and
then used
On Fri, Jul 12, 2024 at 09:44:02AM -0300, Fabiano Rosas wrote:
> Do you have a reference for that kubevirt issue I could look at? It
> maybe interesting to investigate further. Where's the throttling coming
> from? And doesn't less vcpu time imply less dirtying and therefore
> faster convergence?
On Fri, Jul 12, 2024 at 10:02:43PM +1000, Nicholas Piggin wrote:
> This factors the CPU pause function from pause_all_vcpus() into a
> new cpu_pause() function, similarly to cpu_resume(). cpu_resume()
> is moved to keep it next to cpu_pause().
>
> Cc: Philippe Mathieu-Daudé
> Cc: Peter Xu
> Cc:
On Fri, 12 Jul 2024 at 16:18, Stefano Garzarella wrote:
>
> On Fri, Jul 12, 2024 at 03:24:47PM GMT, Peter Maydell wrote:
> >On Wed, 3 Jul 2024 at 23:48, Michael S. Tsirkin wrote:
> >> #if defined(__linux__) && defined(BLKDISCARD) && defined(BLKZEROOUT)
> >> VubDev *vdev_blk = req->vdev_
On Fri, Jul 12, 2024 at 03:24:47PM GMT, Peter Maydell wrote:
On Wed, 3 Jul 2024 at 23:48, Michael S. Tsirkin wrote:
From: Stefano Garzarella
Let's replace the calls to le*toh() and htole*() with qemu/bswap.h
helpers to make the code more portable.
Suggested-by: Philippe Mathieu-Daudé
Revie
On 12.07.24 17:07, Fiona Ebner wrote:
Allow overlapping request by removing the assert that made it
impossible. There are only two callers:
1. block_copy_task_create()
It already asserts the very same condition before calling
reqlist_init_req().
2. cbw_snapshot_read_lock()
There is no need to
On Tue, Jun 18, 2024 at 01:17:03PM +0200, Clément Léger wrote:
> Since commit 03e471c41d8b ("qemu_init: increase NOFILE soft limit on
> POSIX"), the maximum number of file descriptors that can be opened are
> raised to nofile.rlim_max. On recent debian distro, this yield a maximum
> of 1073741816 f
On 7/12/24 04:39, Peter Maydell wrote:
TheTCGCPUOps::cpu_exec_interrupt hook is currently not mandatory; if
it is left NULL then we treat it as if it had returned false. However
since pretty much every architecture needs to handle interrupts,
almost every target we have provides the hook. The on
Peter Maydell writes:
> The TCGCPUOps::cpu_exec_interrupt hook is currently not mandatory; if
> it is left NULL then we treat it as if it had returned false. However
> since pretty much every architecture needs to handle interrupts,
> almost every target we have provides the hook. The one excepti
Pierrick Bouvier writes:
> On 7/8/24 12:15, Alex Bennée wrote:
>> Pierrick Bouvier writes:
>>
>>> Add an explicit test to check expected memory values are read/written.
>>> For sizes 8, 16, 32, 64 and 128, we generate a load/store operation.
>>> For size 8 -> 64, we generate an atomic __sync_va
On Fri, 13 Sept 2019 at 16:50, Peter Maydell wrote:
>
> From: Cédric Le Goater
>
> When doing calibration, the SPI clock rate in the CE0 Control Register
> and the read delay cycles in the Read Timing Compensation Register are
> set using bit[11:4] of the DMA Control Register.
>
> Signed-off-by:
On 12/7/24 14:02, Nicholas Piggin wrote:
This factors the CPU pause function from pause_all_vcpus() into a
new cpu_pause() function, similarly to cpu_resume(). cpu_resume()
is moved to keep it next to cpu_pause().
Cc: Philippe Mathieu-Daudé
Cc: Peter Xu
Cc: Richard Henderson
Signed-off-by: Ni
On Fri, Jul 12, 2024 at 03:25:23PM +0100, Alex Bennée wrote:
> Daniel P. Berrangé writes:
>
> > On Thu, Jul 11, 2024 at 07:44:39PM +0200, Thomas Huth wrote:
> >> On 11/07/2024 16.39, Fabiano Rosas wrote:
> >> > Thomas Huth writes:
> >> ...
> >> > > Things that need further attention though:
> >>
On 12/7/24 13:39, Peter Maydell wrote:
The TCGCPUOps::cpu_exec_interrupt hook is currently not mandatory; if
it is left NULL then we treat it as if it had returned false. However
since pretty much every architecture needs to handle interrupts,
almost every target we have provides the hook. The on
Daniel P. Berrangé writes:
> On Thu, Jul 11, 2024 at 07:44:39PM +0200, Thomas Huth wrote:
>> On 11/07/2024 16.39, Fabiano Rosas wrote:
>> > Thomas Huth writes:
>> ...
>> > > Things that need further attention though:
>> > >
>> > > - All tests that use the LinuxTest / LinuxDistro classes (e.g. b
On Wed, 3 Jul 2024 at 23:48, Michael S. Tsirkin wrote:
>
> From: Stefano Garzarella
>
> Let's replace the calls to le*toh() and htole*() with qemu/bswap.h
> helpers to make the code more portable.
>
> Suggested-by: Philippe Mathieu-Daudé
> Reviewed-by: Philippe Mathieu-Daudé
> Tested-by: Philip
Manos Pitsidianakis writes:
> Hi Daniel, Alex,
>
> I will pick this patch up with all the reviewed-by trailers for my
> next Rust RFC series if that's alright with you,
Absolutely - I made it for you ;-)
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
On Fri, 5 Jul 2024 at 16:37, Alex Bennée wrote:
>
> From: Gustavo Romero
>
> This commit implements the stubs to handle the qIsAddressTagged,
> qMemTag, and QMemTag GDB packets, allowing all GDB 'memory-tag'
> subcommands to work with QEMU gdbstub on aarch64 user mode. It also
> implements the ge
Yichen Wang writes:
> From: Bryan Zhang
>
> Adds support for 'qatzip' as an option for the multifd compression
> method parameter, and implements using QAT for 'qatzip' compression and
> decompression.
>
> Signed-off-by: Bryan Zhang
> Signed-off-by: Hao Xiang
> Signed-off-by: Yichen Wang
> --
Allow overlapping request by removing the assert that made it
impossible. There are only two callers:
1. block_copy_task_create()
It already asserts the very same condition before calling
reqlist_init_req().
2. cbw_snapshot_read_lock()
There is no need to have read requests be non-overlapping i
Add the proposed vdpa kernel interfaces for CPR:
VHOST_NEW_OWNER: new ioctl
VHOST_BACKEND_F_NEW_OWNER: new capability
VHOST_IOTLB_REMAP: new iotlb message
VHOST_BACKEND_F_IOTLB_REMAP: new capability
Signed-off-by: Steve Sistare
---
include/standard-headers/linux/vhost_types.h | 7 +++
Support vdpa devices with the cpr-exec live migration mode.
This series depends on the QEMU series
Live update: cpr-exec
https://lore.kernel.org/qemu-devel/1719776434-435013-1-git-send-email-steven.sist...@oracle.com/
and depends on the kernel series:
vdpa live update
https://lore.ker
Define a vmstate "needed" helper. This will be moved to the preceding patch
series "Live update: cpr-exec" because it is needed by multiple devices.
Signed-off-by: Steve Sistare
---
include/migration/cpr.h | 1 +
migration/cpr.c | 5 +
2 files changed, 6 insertions(+)
diff --git a/
Pass a parameter to the dma mapping functions that indicates if the
memory backs rings or buffers for svq's. No functional change.
Signed-off-by: Steve Sistare
---
hw/virtio/vhost-vdpa.c | 19 ++-
include/hw/virtio/vhost-vdpa.h | 4 ++--
net/vhost-vdpa.c |
Preserve dma mappings during CPR restart by suppressing dma_map and
dma_unmap calls. For devices with capability VHOST_BACKEND_F_IOTLB_REMAP,
convert dma_map calls to VHOST_IOTLB_REMAP to set the new userland VA for
the existing mapping.
However, map and unmap shadow vq buffers normally. Their p
Save the vdpa device fd in CPR state when it is created, and fetch the fd
from that state after CPR. Remember that the fd was reused, for subsequent
patches.
Signed-off-by: Steve Sistare
---
include/hw/virtio/vhost-vdpa.h | 3 +++
net/vhost-vdpa.c | 24 ++--
2
Block CPR if the kernel does not support VHOST_NEW_OWNER.
After CPR, call VHOST_NEW_OWNER in new QEMU.
Signed-off-by: Steve Sistare
---
hw/virtio/trace-events| 1 +
hw/virtio/vhost-vdpa.c| 24 ++--
include/hw/virtio/vhost.h | 1 +
3 files changed, 24 insertions(+),
CPR preserves memory in place, so there is no need to track dirty memory.
By skipping it, CPR can support devices that do not support tracking.
Signed-off-by: Steve Sistare
---
system/memory.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/system/memory.c b/system/memory.c
inde
On Sat, Jul 06, 2024 at 08:12:26PM +, Yao Zi wrote:
> libgcrypt starts providing correct pkg-config configuration and dropping
> libgcrypt-config since 1.11.0. So use auto method for detection of
> libgcrypt, in which meson will try both pkg-config and libgcrypt-config.
The pkg-config file see
On Fri, 5 Jul 2024 at 23:06, Philippe Mathieu-Daudé wrote:
>
> "General command" (GEN_CMD, CMD56) is described as:
>
> GEN_CMD is the same as the single block read or write
> commands (CMD24 or CMD17). The difference is that [...]
> the data block is not a memory payload data but has a
> v
On Fri, 12 Jul 2024 13:51:04 +0100
Daniel P. Berrangé wrote:
> On Fri, Jul 12, 2024 at 02:43:19PM +0200, Igor Mammedov wrote:
> > On Mon, 8 Jul 2024 17:17:32 +0530
> > Sunil V L wrote:
> >
> > > This series adds few updates to RISC-V ACPI namespace for virt platform.
> > > Additionally, it h
Add common function to help unregister the GDB register space. This shall be
done in context to the CPU unrealization.
Note: These are common functions exported to arch specific code. For example,
for ARM this code is being referred in associated arch specific patch-set:
Link:
https://lore.kerne
Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also
involves destruction of the CPU AddressSpace. Add common function to help
destroy the CPU AddressSpace.
Signed-off-by: Salil Mehta
Tested-by: Vishnu Pajjuri
Reviewed-by: Gavin Shan
Tested-by: Xianglai Li
Tested-by: Miguel
CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is IO port
based and existing CPUs AML code assumes _CRS objects would evaluate to a system
resource which describes IO Port address. But on ARM arch CPUs control
device(\\_SB.PRES) register interface is memory-mapped hence _CRS ob
OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually
results in start of the CPU scan. Scan figures out the CPU and the kind of
event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT
method with the call to method \\_SB.CPUS.CSCN (via \\_SB.GED.CSCN)
ACPI GED (as described in the ACPI 6.4 spec) uses an interrupt listed in the
_CRS object of GED to intimate OSPM about an event. Later then demultiplexes the
notified event by evaluating ACPI _EVT method to know the type of event. Use
ACPI GED to also notify the guest kernel about any CPU hot(un)pl
KVM vCPU creation is done once during the vCPU realization when Qemu vCPU thread
is spawned. This is common to all the architectures as of now.
Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the
corresponding KVM vCPU object in the Host KVM is not destroyed as KVM doesn't
CPU ctrl-dev MMIO region length could be used in ACPI GED and various other
architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more
appropriate common header file.
Signed-off-by: Salil Mehta
Reviewed-by: Alex Bennée
Reviewed-by: Jonathan Cameron
Reviewed-by: Gavin Shan
Review
[Note: References are present at the last after the revision history]
Virtual CPU hotplug support is being added across various architectures [1][3].
This series adds various code bits common across all architectures:
1. vCPU creation and Parking code refactor [Patch 1]
2. Update ACPI GED framewo
On 7/12/24 14:02, Nicholas Piggin wrote:
The timebase state machine is per per-core state and can be driven
by any thread in the core. It is currently implemented as a hack
where the state is in a CPU structure and only thread 0's state is
accessed by the chiptod, which limits programming the tim
On Tue, Feb 20, 2024 at 12:04:42AM +0800, Hyman Huang wrote:
> Signed-off-by: Hyman Huang
> ---
> MAINTAINERS | 1 +
> docs/devel/luks-detached-header.rst | 182
> 2 files changed, 183 insertions(+)
> create mode 100644 docs/devel/luks-detac
Upcoming AMD uarch will support Bus Lock Detect (called Bus Lock Trap
in AMD docs). Bus Lock Detect is enumerated with cpuid Fn_0007_ECX_x0
bit [24 / BUSLOCKTRAP]. It can be enabled through MSR_IA32_DEBUGCTLMSR.
When enabled, hardware clears DR6[11] and raises a #DB exception on
occurrence of B
Rather than creating stubs for every comamnd that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the network interface command on
POSIX platforms lacking getifaddrs().
The command will be rejected at QMP dispatch time instead,
avoiding reimpleme
The qmp_guest_{diskstats,cpustats} command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
This also removes a "#ifdef CONFIG_LINUX" that was nested inside
a "#ifdef __linux__".
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Konstantin
The qmp_guest_{set,get}_{memory_blocks,block_info} command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
This also removes a "#ifdef CONFIG_LINUX" that was nested inside
a "#ifdef __linux__".
Reviewed-by: Philippe Mathieu-Daudé
Reviewed
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the schema to fully
exclude generation of the filesystem freezing commands on POSIX
platforms lacking the required APIs.
The command will be rejected at QMP dispatch time instead,
avoiding reimpl
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the get-users command on POSIX
platforms lacking required APIs.
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing r
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the commands on Windows.
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub commands.
Allowing the user to set the QGA_CONF environment variable to change
the default configuration file path is very unusual practice, made
more obscure since this ability is not documented.
This introduces the more normal '-c PATH' / '--config=PATH' command
line argument approach. This requires that
It is confusing having many different pieces of code enabling and
disabling commands, and it is not clear that they all have the same
semantics, especially wrt prioritization of the block/allow lists.
The code attempted to prevent the user from setting both the block
and allow lists concurrently, h
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the schema to fully
exclude generation of the filesystem trimming commands on POSIX
platforms lacking required APIs.
The command will be rejected at QMP dispatch time instead,
avoiding reimplemen
The fsfreeze commands are already written to report an error if
vss_init() fails. Reporting a more specific error message is more
helpful than a generic "command is disabled" message, which cannot
between an admin config decision and lack of platform support.
Reviewed-by: Manos Pitsidianakis
Sign
This variable was used to support back compat for the old config
file key name, and became redundant after the following change:
commit a7a2d636ae4549ef0551134d4bf8e084a14431c4
Author: Philippe Mathieu-Daudé
Date: Thu May 30 08:36:43 2024 +0200
qga: Remove deprecated 'blacklist' argu
Some commands were blocked based on CONFIG_FSFREEZE, but their
impl had nothing todo with CONFIG_FSFREEZE, and were instead
either Linux-only, or Win+Linux-only.
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the commands on other UNIX.
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub comma
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the commands on non-Windows.
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking the stub comma
It is referenced by QGAState already, and it is clearer to declare all
data types at the top of the file, rather than have them mixed with
code later.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Daniel P. Berrangé
---
qga/main.c | 44 +
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the commands on non-Linux POSIX
platforms
The command will be rejected at QMP dispatch time instead,
avoiding reimplementing rejection by blocking t
The qmp_guest_suspend_{disk,ram,hybrid} command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
Reviewed-by: Manos Pitsidianakis
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Daniel P. Berrangé
---
The qmp_guest_{fstrim, get_fsinfo, get_disks} command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
Reviewed-by: Manos Pitsidianakis
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Daniel P. Berrangé
Rather than creating stubs for every command that just return
QERR_UNSUPPORTED, use 'if' conditions in the QAPI schema to
fully exclude generation of the filesystem trimming commands
on POSIX platforms lacking required APIs.
The command will be rejected at QMP dispatch time instead,
avoiding reimp
The qmp_guest_set_vcpus and qmp_guest_get_vcpus command impls in
commands-posix.c are surrounded by '#ifdef __linux__' so should
instead live in commands-linux.c
Reviewed-by: Manos Pitsidianakis
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Daniel P. Berrang
Defining these at the meson level allows them to be used a conditional
tests in the QAPI schemas.
Signed-off-by: Daniel P. Berrangé
---
meson.build | 15 +++
qga/commands-common.h | 9 -
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/meson.build b/
This command has never existed in tree, since it was renamed to
guest-get-memory-block-info before being merged.
Reviewed-by: Manos Pitsidianakis
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Daniel P. Berrangé
---
qga/commands-posix.c | 2 +-
qga/commands-win32.c | 2 +-
2 files changed, 2 i
This series is a side effect of other work I started, to attempt to
make the QGA safe to use in confidential VMs by automatically
restricting the permitted commands. Since this cleanup stands on
its own, I'm sending it now.
The QGA codebase has a very complicated maze of #ifdefs to create
stubs fo
Hi Daniel, Alex,
I will pick this patch up with all the reviewed-by trailers for my
next Rust RFC series if that's alright with you,
Manos
On Fri, 12 Jul 2024 at 13:12, Daniel P. Berrangé wrote:
>
> On Wed, Jul 10, 2024 at 04:43:35PM +0100, Alex Bennée wrote:
> > For rust development we need ca
On Fri, 5 Jul 2024 13:30:38 +0100
Jonathan Cameron wrote:
> From: Shiju Jose
>
> CXL spec 3.1 section 8.2.9.9.11.2 describes the DDR5 Error Check Scrub (ECS)
> control feature.
Hi Michael / all,
Silly stray white space issue inline that checkpatch will catch.
> diff --git a/hw/mem/cxl_type3.
Testing OS kernel ACPI APEI CPER support is tricky, as one depends on
having hardware with special-purpose BIOS and/or hardware.
With QEMU, it becomes a lot easier, as it can be done via QMP.
This series add support for ARM Processor CPER error injection,
according with ACPI 6.x and UEFI 2.9A/2.1
From: Jonathan Cameron
Creates a GED - Generic Event Device and set a GPIO to
be used or error injection.
[mchehab: use a define for the generic event pin number and do some cleanups]
Signed-off-by: Jonathan Cameron
Signed-off-by: Mauro Carvalho Chehab
---
hw/arm/virt-acpi-build.c | 30 ++
From: Jonathan Cameron
1. Some GHES functions require handling addresses. Add a helper function
to support it.
2. Add support for ACPI CPER (firmware-first) ARM processor error injection.
Compliance with N.2.4.4 ARM Processor Error Section in UEFI 2.6 and
upper specs, using error type bit en
Having magic numbers inside the code is not a good idea, as it
is error-prone. So, instead, create a macro with the number
definition.
Signed-off-by: Mauro Carvalho Chehab
---
hw/arm/virt-acpi-build.c | 6 +++---
hw/arm/virt.c| 3 ++-
include/hw/arm/virt.h| 3 +++
3 files changed
There is one reference to ACPI 4.0 and several references
to ACPI 6.x versions.
Update them to point to ACPI 6.5 whenever possible.
There's one reference that was kept pointing to ACPI 6.4,
though, with HEST revision 1.
ACPI 6.5 now defines HEST revision 2, and defined a new
way to handle source
Enrich CPER error injection logic for ARM processor to allow
setting values to from UEFI 2.10 tables N.16 and N.17.
It should be noticed that, with such change, all arguments are
now optional, so, once QMP is negotiated with:
{ "execute": "qmp_capabilities" }
the simplest way to generat
There is a logic at helper to properly fill the mpidr information.
This is needed for ARM Processor error injection, so store the
value inside a cpu opaque value, to allow it to be used.
Signed-off-by: Mauro Carvalho Chehab
---
target/arm/cpu.h| 1 +
target/arm/helper.c | 10 --
2 f
From: Jonathan Cameron
Add error notification to GHES v2 using the GPIO source.
Signed-off-by: Jonathan Cameron
Signed-off-by: Mauro Carvalho Chehab
---
hw/acpi/ghes.c | 8 ++--
include/hw/acpi/ghes.h | 1 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/acpi/gh
1 - 100 of 234 matches
Mail list logo
