Re: [PATCH 0/9] Add Qualcomm BMC machines

2025-09-29 Thread Cédric Le Goater
On 6/22/22 19:28, Jae Hyun Yoo wrote: Hello, I'm sending a series to add Qualcomm BMC machines that are equipped with Aspeed AST2600 SoC. Also, this series adds MAX31785 fan controller device emulation. Please help to review. Thanks, Jae Graeme Gregory (2): hw/arm/aspeed: qcom-dc-scm-v1: a

Re: [PATCH v3 2/2] aspeed: Add support for the g220a-bmc board

2025-09-29 Thread Cédric Le Goater
On 10/25/20 14:14, John Wang wrote: G220A is a 2 socket x86 motherboard supported by OpenBMC. Strapping configuration was obtained from hardware. Signed-off-by: John Wang Reviewed-by: Cédric Le Goater Reviewed-by: Joel Stanley Hello John Would it be possible to contribute a functional test

Re: [PATCH] aspeed: Add support for the quanta-q7l1-bmc board

2025-09-29 Thread Cédric Le Goater
Hello Patrick, On 4/16/21 18:24, Patrick Venture wrote: The Quanta-Q71l BMC board is a board supported by OpenBMC. Tested: Booted quanta-q71l firmware. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm/aspeed.c | 62 + 1 file chan

Re: [PATCH] aspeed: Add Supermicro X11 SPI machine type

2025-09-29 Thread Cédric Le Goater
On 10/25/22 18:51, Guenter Roeck wrote: supermicrox11-bmc is configured with ast2400-a1 SoC. This does not match the Supermicro documentation for X11 BMCs, and it does not match the devicetree file in the Linux kernel. As it turns out, some Supermicro X11 motherboards use AST2400 SoCs, while oth

Re: [PATCH v3] aspeed: Add support for the sonorapass-bmc board

2025-09-29 Thread Cédric Le Goater
Hello Patrick On 5/6/20 20:32, Patrick Williams wrote: Sonora Pass is a 2 socket x86 motherboard designed by Facebook and supported by OpenBMC. Strapping configuration was obtained from hardware and i2c configuration is based on dts found at: https://github.com/facebook/openbmc-linux/blob/1633

[PATCH v15 07/26] migration: push Error **errp into qemu_loadvm_state()

2025-09-29 Thread Arun Menon
This is an incremental step in converting vmstate loading code to report error via Error objects instead of directly printing it to console/monitor. It is ensured that qemu_loadvm_state() must report an error in errp, in case of failure. When postcopy live migration runs, the device states are loa

Re: [PATCH v2 02/17] system/memory: Better describe @plen argument of flatview_translate()

2025-09-29 Thread Thomas Huth
On 30/09/2025 06.13, Philippe Mathieu-Daudé wrote: flatview_translate()'s @plen argument is output-only and can be NULL. Signed-off-by: Philippe Mathieu-Daudé --- include/system/memory.h | 5 +++-- system/physmem.c| 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --

[PATCH 1/5] hw/pcie: Support enabling flit mode

2025-09-29 Thread Davidlohr Bueso
PCIe Flit Mode, introduced with the PCIe 6.0 specification, is a fundamental change in how data is transmitted over the bus to improve transfer rates. It shifts from variable-sized Transaction Layer Packets (TLPs) to fixed 256-byte Flow Control Units (FLITs). As with the link speed and width train

[PATCH v15 04/26] migration: push Error **errp into vmstate_load()

2025-09-29 Thread Arun Menon
This is an incremental step in converting vmstate loading code to report error via Error objects instead of directly printing it to console/monitor. It is ensured that vmstate_load() must report an error in errp, in case of failure. The errors are temporarily reported using error_report_err(). Thi

[PATCH v2 12/17] target/i386/nvmm: Inline cpu_physical_memory_rw() in nvmm_mem_callback

2025-09-29 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/i386/nvmm/nvmm-all.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index ed424251673..2e442baf4b7 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nv

[PATCH v4 06/13] target/loongarch: Add MMUContext parameter in fill_tlb_entry()

2025-09-29 Thread Bibo Mao
Function fill_tlb_entry() can be used with hardware PTW in future, here add input parameter MMUContext in fill_tlb_entry(). Signed-off-by: Bibo Mao --- target/loongarch/tcg/tlb_helper.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/target/loongarch/tc

[PATCH v4 00/13] target/loongarch: Add hardware page table walk support

2025-09-29 Thread Bibo Mao
Hardware page table walk (PTW for short) is one feature supported in Loongson 3C6000 system. With hardware PTW supported, if there is an TLB miss, hardware will take PTW and fill it in TLB if matched, report TLB exception if not matched. With hardware PTW supported, bit Present and Write in pte en

[PATCH v4 11/13] target/loongarch: Add basic hardware PTW support

2025-09-29 Thread Bibo Mao
However with hardware PTW supported, hardware will search page table with TLB miss. Also if there is no TLB miss however bit Present is not set, hardware PTW will happen also. Because there is odd/even page in one TLB entry on LoongArch system, for example in the first time odd TLB entry is valid a

[PATCH v4 01/13] target/loongarch: Use auto method with PTW feature

2025-09-29 Thread Bibo Mao
PTW is short for page table walker, it is hardware page table walker function. With PTW supported, hardware MMU will parse page table table and update TLB entries automatically. This patch adds type OnOffAuto for PTW feature setting. Signed-off-by: Bibo Mao --- target/loongarch/cpu.c | 25 +

[PATCH 4/5] hw/cxl: Support type3 HDM-DB

2025-09-29 Thread Davidlohr Bueso
Add basic plumbing for memory expander devices that support Back Invalidation. This introduces a 'hdm-db=on|off' parameter and exposes the relevant BI RT/Decoder component cachemem registers. Some noteworthy properties: - Devices require enabling Flit mode. - Explicit BI-ID commit is required.

RE: [PATCH 5/7] hw/pci-host: enable MSI on npcm PCIe root complex

2025-09-29 Thread kft...@nuvoton.com
Loop in more Nuvoton folks. -Original Message- From: Yubin Zou Sent: Wednesday, September 10, 2025 6:11 AM To: qemu-devel@nongnu.org Cc: Paolo Bonzini ; CS20 KFTing ; Hao Wu ; qemu-...@nongnu.org; Peter Maydell ; Yubin Zou ; Titus Rwantare Subject: [PATCH 5/7] hw/pci-host: enable MSI

Re: [PATCH v4 06/27] hw/arm/smmuv3-accel: Restrict accelerated SMMUv3 to vfio-pci endpoints with iommufd

2025-09-29 Thread Nicolin Chen
On Mon, Sep 29, 2025 at 02:36:22PM +0100, Shameer Kolothum wrote: > Accelerated SMMUv3 is only useful when the device can take advantage of > the host's SMMUv3 in nested mode. To keep things simple and correct, we > only allow this feature for vfio-pci endpoint devices that use the iommufd > backen

Re: [PATCH 07/10] target/arm: Implement SPAD, NSPAD, RLPAD

2025-09-29 Thread Pierrick Bouvier
On 9/25/25 5:11 PM, Richard Henderson wrote: These bits disable all access to a particular address space. Signed-off-by: Richard Henderson --- target/arm/ptw.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) Reviewed-by: Pierrick Bouvier

Re: [PATCH 06/10] target/arm: Implement GPT_NonSecureOnly

2025-09-29 Thread Pierrick Bouvier
On 9/25/25 5:11 PM, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/arm/ptw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) Reviewed-by: Pierrick Bouvier

Re: [PATCH v4 04/27] hw/arm/smmu-common:Make iommu ops part of SMMUState

2025-09-29 Thread Nicolin Chen via
On Mon, Sep 29, 2025 at 02:36:20PM +0100, Shameer Kolothum wrote: > And set to the current default smmu_ops. No functional change intended. > This will allow SMMUv3 accel implementation to set a different iommu ops > later. > > Signed-off-by: Shameer Kolothum Reviewed-by: Nicolin Chen

Re: [PULL 18/27] hw/intc/xics: Add missing call to register vmstate_icp_server

2025-09-29 Thread Michael Tokarev
On 9/28/25 22:26, Harsh Prateek Bora wrote: From: Fabian Vogt An obsolete wrapper function with a workaround was removed entirely, without restoring the call it wrapped. Without this, the guest is stuck after savevm/loadvm. Fixes: 24ee9229fe31 ("ppc/spapr: remove deprecated machine pseries-2.

Re: [RFC PATCH] .gitpublish: use origin/master as default base

2025-09-29 Thread Stefan Hajnoczi
On Mon, Sep 29, 2025 at 02:43:48PM +0100, Alex Bennée wrote: > This is very much the result of my recent fat finger but I think it's > safer to assume that origin/master points to a recent commit (or at > least a commit a given branch is based on) than master. > > Signed-off-by: Alex Bennée > ---

[PATCH 0/3] rcu: Detect accidental reuse of rcu head

2025-09-29 Thread Peter Xu
This is an idea suggested by Peter Maydell: https://lore.kernel.org/all/CAFEAcA--K0=EJNNvj98i=ewGY=tn3u4s0+fnb9kjpyynzjh...@mail.gmail.com/ After this small series applied, we should be able to assert on misuse of accidental (wrong) re-use on a rcu head. Please review, thanks. Peter Xu (3): q

Re: [PATCH v14 25/27] migration: Rename post_save() to cleanup_save() and make it void

2025-09-29 Thread Peter Xu
On Thu, Sep 18, 2025 at 08:53:42PM +0530, Arun Menon wrote: > The post_save() function call is responsible for cleaning up resources > after the device state has been saved. > Currently it is infallible, and does not return an error. > > It is called regardless of whether there is a preceding erro

Re: [PATCH v8 3/7] vhost_user.rst: Add SHMEM_MAP/_UNMAP to spec

2025-09-29 Thread Stefan Hajnoczi
On Wed, Sep 10, 2025 at 01:54:16PM +0200, Albert Esteve wrote: > Add SHMEM_MAP/_UNMAP request to the vhost-user > spec documentation. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Albert Esteve > --- > docs/interop/vhost-user.rst | 58 + > 1 file changed,

[PATCH 04/15] hw/s390x/sclp: Use address_space_memory_is_io() in sclp_service_call()

2025-09-29 Thread Philippe Mathieu-Daudé
When cpu_address_space_init() isn't called during vCPU creation, its single address space is the global &address_space_memory. As s390x boards don't call cpu_address_space_init(), cpu_get_address_space(CPU(cpu), 0) returns &address_space_memory. We can then replace cpu_physical_memory_is_io() by

Re: [PATCH v6 28/28] docs/system/s390x: Add secure IPL documentation

2025-09-29 Thread Thomas Huth
On 18/09/2025 01.21, Zhuoying Cai wrote: Add documentation for secure IPL Signed-off-by: Collin Walling Signed-off-by: Zhuoying Cai --- docs/system/s390x/secure-ipl.rst | 96 1 file changed, 96 insertions(+) diff --git a/docs/system/s390x/secure-ipl.rst b/d

Re: [PATCH v6 25/28] pc-bios/s390-ccw: Handle secure boot with multiple boot devices

2025-09-29 Thread Thomas Huth
On 18/09/2025 01.21, Zhuoying Cai wrote: The current approach to enable secure boot relies on providing secure-boot and boot-certs parameters of s390-ccw-virtio machine type option, which apply to all boot devices. With the possibility of multiple boot devices, secure boot expects all provided d

[PULL 19/32] hw/pci-host/aspeed: Add MSI support and per-RC IOMMU address space

2025-09-29 Thread Cédric Le Goater
From: Jamin Lin Add MSI support to the ASPEED PCIe RC/Config model and introduce a per-RC "IOMMU root" address space to correctly route MSI writes. On AST2700 all RCs use the same MSI address, and the MSI target is PCI system memory (not normal DRAM). If the MSI window were mapped into real syst

[PULL 24/32] hw/pci-host/aspeed: Disable Root Device and place Root Port at 00:00.0 to AST2700

2025-09-29 Thread Cédric Le Goater
From: Jamin Lin AST2700 does not implement a PCIe Root Device; each RC exposes a single PCIe Root Port at devfn 0:0.0. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/qemu-devel/20250919093017.338309-12-jamin_...@aspeedtech.com Signed-off-by: Cédric Le Goa

[PULL 16/32] hw/pci-host/aspeed: Add AST2600 PCIe config space and host bridge

2025-09-29 Thread Cédric Le Goater
From: Jamin Lin Introduce PCIe config and host bridge model for the AST2600 platform. This patch adds support for the H2X (AHB to PCIe Bus Bridge) controller with a 0x100 byte register space. The register layout is shared between two root complexes: 0x00–0x7f is common, 0x80–0xbf for RC_L, and 0

Re: [PATCH 2/6] system/ramblock: Move ram_block_is_pmem() declaration

2025-09-29 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Move ramblock_is_pmem() along with the RAM Block API > exposed by the "system/ramblock.h" header. Rename as > ram_block_is_pmem() to keep API prefix consistency. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/system/ram_addr.h | 2 -- > include/system

[PULL 15/32] hw/pci-host/aspeed: Add AST2600 PCIe PHY model

2025-09-29 Thread Cédric Le Goater
From: Jamin Lin This patch introduces an initial ASPEED PCIe PHY/host controller model to support the AST2600 SoC. It provides a simple register block with MMIO read/write callbacks, integration into the build system, and trace events for debugging. Key changes: 1. PCIe PHY MMIO read/write call

[PULL 32/32] hw/arm/aspeed_ast27x0-fc: Make sub-init functions return bool with errp

2025-09-29 Thread Cédric Le Goater
From: Jamin Lin Refactor ast2700fc_ca35_init(), ast2700fc_ssp_init(), and ast2700fc_tsp_init() to take an Error **errp parameter and return a bool. Each function now reports failure through the error object and returns false. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater Link: https:

[PULL 05/32] hw/nvram/aspeed_otp: Add OTP programming semantics and tracing

2025-09-29 Thread Cédric Le Goater
From: Kane-Chen-AS Implement correct OTP programming behavior for Aspeed OTP: - Support read-modify-write flow with one-way bit programming: * prog_bit uses 0s as the "to-be-programmed" mask. * Even-indexed words: 0->1, odd-indexed words: 1->0. * Reject non-programmable requests and log con

[PULL 18/32] hw/pci-host/aspeed: Add AST2600 PCIe Root Port and make address configurable

2025-09-29 Thread Cédric Le Goater
From: Jamin Lin Introduce an ASPEED PCIe Root Port and wire it under the RC. The root port is modeled as TYPE_ASPEED_PCIE_ROOT_PORT (subclass of TYPE_PCIE_ROOT_PORT). Key changes: - Add TYPE_ASPEED_PCIE_ROOT_PORT (PCIESlot-based) with vendor/device IDs and AER capability offset. - Extend Aspee

[PULL 22/32] hw/pci-host/aspeed: Add AST2700 PCIe PHY

2025-09-29 Thread Cédric Le Goater
From: Jamin Lin Introduce a PCIe Host Controller PHY model for AST2700. This adds an AST2700 specific PHY type (TYPE_ASPEED_2700_PCIE_PHY) with a 0x800 byte register space and link-status bits compatible with the firmware’s expectations. AST2700 provides three PCIe RCs; PCIe0 and PCIe1 are GEN4,

[PULL 10/32] hw/arm/aspeed Move ast2700-evb alias to ast2700a1-evb

2025-09-29 Thread Cédric Le Goater
From: Jamin Lin This patch moves the "ast2700-evb" alias from the A0 to A1. The A0 machine remains available via its explicit name ("ast2700a0-evb"), while functional tests are updated to target A0 by name instead of relying on the generic alias. Signed-off-by: Jamin Lin Reviewed-by: Cédric Le

[PULL 06/32] hw/arm: Integrate ASPEED OTP memory support into AST1030 SoCs

2025-09-29 Thread Cédric Le Goater
From: Kane-Chen-AS The has_otp attribute is enabled in the SBC subclasses for AST1030 to control the presence of OTP support per SoC type. Signed-off-by: Kane-Chen-AS Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/qemu-devel/20250812094011.2617526-7-kane_c...@aspeedtech.com Signe

[PULL 00/32] aspeed queue

2025-09-29 Thread Cédric Le Goater
The following changes since commit 4975b64efb5aa4248cbc3760312bbe08d6e71638: Merge tag 'pull-loongarch-20250928' of https://github.com/bibo-mao/qemu into staging (2025-09-28 09:01:35 -0700) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-aspee

[PULL 11/32] tests/functional/arm: Add helper to generate OTP images

2025-09-29 Thread Cédric Le Goater
From: Kane-Chen-AS Add a small helper that generates OTP images at test time. This lets multiple test cases create default OTP contents without shipping prebuilt fixtures and keeps the tests self-contained. Signed-off-by: Kane-Chen-AS Reviewed-by: Cédric Le Goater Link: https://lore.kernel.or

Re: [PATCH v4 12/27] hw/arm/smmuv3-accel: Make use of get_msi_address_space() callback

2025-09-29 Thread Jonathan Cameron via
On Mon, 29 Sep 2025 14:36:28 +0100 Shameer Kolothum wrote: > Here we return the IOMMU address space if the device has S1 translation > enabled by Guest. Otherwise return system address space. > > Signed-off-by: Shameer Kolothum > Signed-off-by: Shameer Kolothum Naming question inline. > --- >

Re: [RFC PATCH] link principle license to COPYING

2025-09-29 Thread Tom Rini
On Mon, Sep 29, 2025 at 04:51:42PM +0100, Alex Bennée wrote: > Some license scanners are particularly dumb and when combined with > automatic license scanning for FLOSS accreditation on forges cause > problems on renewal. As GPL 2.0 applies to the core code link the main > licence text to COPYING

Re: [PULL 00/27] ppc-for-20250928 queue

2025-09-29 Thread Richard Henderson
https://gitlab.com/harshpb/qemu.git tags/pull-ppc-for-20250928-20250929 for you to fetch changes up to 6c51df580d2a64b4e1ef7bdbffeb3615ffe25d43: target/ppc: use MAKE_64BIT_MASK for mcrfs exception clear mask (2025-09-28 23:50:36 +0530) --

Re: [PATCH v4 10/27] hw/arm/smmuv3-accel: Allocate a vDEVICE object for device

2025-09-29 Thread Jonathan Cameron via
On Mon, 29 Sep 2025 14:36:26 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Allocate and associate a vDEVICE object for the Guest device with the > vIOMMU. This will help the host kernel to make a virtual SID --> physical > SID mapping. Since we pass the raw invalidation commands(eg: CM

Re: [PATCH v4 08/27] hw/arm/smmuv3-accel: Add set/unset_iommu_device callback

2025-09-29 Thread Jonathan Cameron via
On Mon, 29 Sep 2025 14:36:24 +0100 Shameer Kolothum wrote: > From: Nicolin Chen > > Implement a set_iommu_device callback: > -If found an existing viommu reuse that. > -Else, > Allocate a vIOMMU with the nested parent S2 hwpt allocated by VFIO. > Though, iommufd’s vIOMMU model support

[PATCH 16/16] tracetool/syslog: add Rust support

2025-09-29 Thread Paolo Bonzini
From: Tanish Desai The syslog backend needs the syslog function from libc and the LOG_INFO enum value; they are re-exported as "::trace::syslog" and "::trace::LOG_INFO" so that device crates do not all have to add the libc dependency, but otherwise there is nothing special. Signed-off-by: Tanish

[PATCH 08/16] tracetool: Add Rust format support

2025-09-29 Thread Paolo Bonzini
From: Tanish Desai Generating .rs files makes it possible to support tracing in rust. This support comprises a new format, and common code that converts the C expressions in trace-events to Rust. In particular, types need to be converted, and PRI macros expanded. As of this commit no backend ge

[PATCH 10/16] rust: qdev: add minimal clock bindings

2025-09-29 Thread Paolo Bonzini
Add the minimal support that is needed by pl011's event and tracepoint. Reviewed-by: Zhao Liu Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- rust/hw/core/src/qdev.rs | 33 + 1 file changed, 33 insertions(+) diff --git a/rust/hw/core/src/qdev.rs b

[PATCH 15/16] tracetool/ftrace: add Rust support

2025-09-29 Thread Paolo Bonzini
From: Tanish Desai Signed-off-by: Tanish Desai Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- scripts/tracetool/backend/ftrace.py | 8 +- tests/tracetool/ftrace.rs | 40 + tests/tracetool/tracetool-test.py | 2 +- 3 files changed, 4

[PATCH 14/16] tracetool/log: add Rust support

2025-09-29 Thread Paolo Bonzini
From: Tanish Desai Signed-off-by: Tanish Desai Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- scripts/tracetool/backend/log.py | 10 ++- tests/tracetool/log.rs| 44 +++ tests/tracetool/tracetool-test.py | 2 +- 3 files changed, 54 i

[PATCH 3/6] system/ramblock: Move ram_block_discard_*_range() declarations

2025-09-29 Thread Philippe Mathieu-Daudé
Keep RAM blocks API in the same header: "system/ramblock.h". Signed-off-by: Philippe Mathieu-Daudé --- include/exec/cpu-common.h | 3 --- include/system/ramblock.h | 4 accel/kvm/kvm-all.c | 1 + hw/hyperv/hv-balloon-our_range_memslots.c

[PATCH 1/6] system/ramblock: Remove obsolete comment

2025-09-29 Thread Philippe Mathieu-Daudé
This comment was added almost 5 years ago in commit 41aa4e9fd84 ("ram_addr: Split RAMBlock definition"). Clearly it got ignored: $ git grep -l system/ramblock.h hw/display/virtio-gpu-udmabuf.c hw/hyperv/hv-balloon.c hw/virtio/vhost-user.c migration/dirtyrate.c migration/file.c migrat

[PATCH 4/6] system/ramblock: Use ram_addr_t in ram_block_discard_guest_memfd_range

2025-09-29 Thread Philippe Mathieu-Daudé
Rename @start as @offset. Since it express an offset within a RAMBlock, use the ram_addr_t type to make emphasis on the QEMU intermediate address space represented. Signed-off-by: Philippe Mathieu-Daudé --- include/system/ramblock.h | 3 ++- system/physmem.c | 12 ++-- 2 files

Re: [PATCH v4 04/27] hw/arm/smmu-common:Make iommu ops part of SMMUState

2025-09-29 Thread Jonathan Cameron via
On Mon, 29 Sep 2025 14:36:20 +0100 Shameer Kolothum wrote: Space between : and Make I'd repeat the patch title bit of the sentence in here just to make it more readable. > And set to the current default smmu_ops. No functional change intended. > This will allow SMMUv3 accel implementation to set

[PATCH 0/6] system/ramblock: Sanitize header

2025-09-29 Thread Philippe Mathieu-Daudé
Usual API cleanups, here focusing on RAMBlock API: move few prototypes out of "exec/cpu-common.h" and "system/ram_addr.h" to "system/ramblock.h". Philippe Mathieu-Daudé (6): system/ramblock: Remove obsolete comment system/ramblock: Move ram_block_is_pmem() declaration system/ramblock: Move r

Re: [PATCH v14 00/27] migration: propagate vTPM errors using Error objects

2025-09-29 Thread Peter Xu
On Mon, Sep 29, 2025 at 11:30:20AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Sep 29, 2025 at 02:19:48PM +0530, Arun Menon wrote: > >> Hi, > >> Gentle ping for the series. > >> Is there something more to be done to improve this before queueing it? > >> TIA. > > > > Arun, don't w

Re: [PATCH] target/riscv: Fix endianness swap on compressed instructions

2025-09-29 Thread Philippe Mathieu-Daudé
On 29/9/25 17:12, Anton Johansson wrote: On 29/09/25, Philippe Mathieu-Daudé wrote: Hi, On 29/9/25 13:55, Valentin Haudiquet wrote: From: vhaudiquet Three instructions were not using the endianness swap flag, which resulted in a bug on big-endian architectures. I suppose you mean "big-en

Re: [PATCH 3/3] docs/code-provenance: AI exceptions are in addition to DCO

2025-09-29 Thread Paolo Bonzini
On 9/29/25 11:35, Kevin Wolf wrote: It's mentioned earlier, since the responsibility is not limited to exceptions: "To satisfy the DCO, the patch contributor has to fully understand the copyright and license status of content they are contributing to QEMU". I find this sentence to be already a b

Re: [PATCH 0/3] system: Don't leak CPU AddressSpaces

2025-09-29 Thread Philippe Mathieu-Daudé
Cc'ing Salil for previous discussions on https://lore.kernel.org/qemu-devel/20230918160257.30127-1-phi...@linaro.org/ On 29/9/25 16:42, Peter Maydell wrote: When a vCPU is created, it typically calls cpu_address_space_init() one or more times to set up its address spaces. We don't currently do a

Re: [PATCH V1 04/11] tests/qtest: qtest_qemu_spawn_func

2025-09-29 Thread Fabiano Rosas
Steve Sistare writes: > Allow the qtest_qemu_spawn caller to pass the function to be called > to perform the spawn. The opaque argument is needed by a new spawn > function in a subsequent patch. > > Signed-off-by: Steve Sistare Reviewed-by: Fabiano Rosas

Re: [PATCH V1 02/11] tests/qtest: qtest_qemu_args

2025-09-29 Thread Fabiano Rosas
Steve Sistare writes: > Define an accessor that returns all the arguments used to exec QEMU. > Collect the arguments that were passed to qtest_spawn_qemu, plus the trace > arguments that were composed inside qtest_spawn_qemu, and move them to a > new function qtest_qemu_args. > > This will be nee

Re: [PATCH V1 01/11] tests/qtest: export qtest_qemu_binary

2025-09-29 Thread Fabiano Rosas
Steve Sistare writes: > Signed-off-by: Steve Sistare > --- > tests/qtest/libqtest.h | 9 + > tests/qtest/libqtest.c | 2 +- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h > index b3f2e7f..6d3199f 100644 > --- a/tests/q

[PATCH 3/3] physmem: Destroy all CPU AddressSpaces on unrealize

2025-09-29 Thread Peter Maydell
When we unrealize a CPU object (which happens on vCPU hot-unplug), we should destroy all the AddressSpace objects we created via calls to cpu_address_space_init() when the CPU was realized. Commit 24bec42f3d6eae added a function to do this for a specific AddressSpace, but did not add any places wh

[PATCH 2/3] memory: New AS helper to serialize destroy+free

2025-09-29 Thread Peter Maydell
From: Peter Xu If an AddressSpace has been created in its own allocated memory, cleaning it up requires first destroying the AS and then freeing the memory. Doing this doesn't work: address_space_destroy(as); g_free_rcu(as, rcu); because both address_space_destroy() and g_free_rcu() try

[PATCH 1/3] include/system/memory.h: Clarify address_space_destroy() behaviour

2025-09-29 Thread Peter Maydell
address_space_destroy() doesn't actually immediately destroy the AS; it queues it to be destroyed via RCU. This means you can't g_free() the memory the AS struct is in until that has happened. Clarify this in the documentation. Signed-off-by: Peter Maydell --- include/system/memory.h | 11 +

Re: [PATCH v6 22/28] Add secure-boot to s390-ccw-virtio machine type option

2025-09-29 Thread Thomas Huth
On 18/09/2025 01.21, Zhuoying Cai wrote: Add secure-boot as a parameter of s390-ccw-virtio machine type option. The `secure-boot=on|off` parameter is implemented to enable secure IPL. By default, secure-boot is set to false if not specified in the command line. Signed-off-by: Zhuoying Cai ---

[PATCH v4 20/27] hw/arm/smmuv3: Add accel property for SMMUv3 device

2025-09-29 Thread Shameer Kolothum
Introduce an “accel” property to enable accelerator mode. Live migration is currently unsupported when accelerator mode is enabled, so a migration blocker is added. Because this mode relies on IORT RMR for MSI support, accelerator mode is not supported for device tree boot. Signed-off-by: Shamee

[PATCH v4 12/27] hw/arm/smmuv3-accel: Make use of get_msi_address_space() callback

2025-09-29 Thread Shameer Kolothum
Here we return the IOMMU address space if the device has S1 translation enabled by Guest. Otherwise return system address space. Signed-off-by: Shameer Kolothum Signed-off-by: Shameer Kolothum --- hw/arm/smmuv3-accel.c | 21 + 1 file changed, 21 insertions(+) diff --git a/h

[PATCH v4 13/27] hw/arm/smmuv3-accel: Add support to issue invalidation cmd to host

2025-09-29 Thread Shameer Kolothum
Provide a helper and use that to issue the invalidation cmd to host SMMUv3. We only issue one cmd at a time for now. Support for batching of commands will be added later after analysing the impact. Signed-off-by: Shameer Kolothum --- hw/arm/smmuv3-accel.c | 38 ++

[PATCH v4 11/27] hw/pci/pci: Introduce optional get_msi_address_space() callback

2025-09-29 Thread Shameer Kolothum
On ARM, when a device is behind an IOMMU, its MSI doorbell address is subject to translation by the IOMMU. This behavior affects vfio-pci passthrough devices assigned to guests using an accelerated SMMUv3. In this setup, we configure the host SMMUv3 in nested mode, where VFIO sets up the Stage-2 (

[PATCH v4 24/27] backends/iommufd: Retrieve PASID width from iommufd_backend_get_device_info()

2025-09-29 Thread Shameer Kolothum
And store it in HostIOMMUDeviceCaps for later use. Signed-off-by: Shameer Kolothum --- backends/iommufd.c | 6 +- hw/arm/smmuv3-accel.c | 3 ++- hw/vfio/iommufd.c | 7 +-- include/system/host_iommu_device.h | 2 ++ include/system/iommufd.h

[PATCH v4 22/27] hw/arm/smmuv3-accel: Add support for ATS

2025-09-29 Thread Shameer Kolothum
QEMU SMMUv3 does not enable ATS (Address Translation Services) by default. When accelerated mode is enabled and the host SMMUv3 supports ATS, it can be useful to report ATS capability to the guest so it can take advantage of it if the device also supports ATS. Note: ATS support cannot be reliably

[RFC PATCH] .gitpublish: use origin/master as default base

2025-09-29 Thread Alex Bennée
This is very much the result of my recent fat finger but I think it's safer to assume that origin/master points to a recent commit (or at least a commit a given branch is based on) than master. Signed-off-by: Alex Bennée --- .gitpublish | 16 1 file changed, 8 insertions(+), 8 d

[PATCH v4 14/27] hw/arm/smmuv3-accel: Get host SMMUv3 hw info and validate

2025-09-29 Thread Shameer Kolothum
Just before the device gets attached to the SMMUv3, make sure QEMU SMMUv3 features are compatible with the host SMMUv3. Not all fields in the host SMMUv3 IDR registers are meaningful for userspace. Only the following fields can be used: - IDR0: ST_LEVEL, TERM_MODEL, STALL_MODEL, TTENDIAN, CD2L,

[PATCH v4 04/27] hw/arm/smmu-common:Make iommu ops part of SMMUState

2025-09-29 Thread Shameer Kolothum
And set to the current default smmu_ops. No functional change intended. This will allow SMMUv3 accel implementation to set a different iommu ops later. Signed-off-by: Shameer Kolothum --- hw/arm/smmu-common.c | 7 +-- include/hw/arm/smmu-common.h | 1 + 2 files changed, 6 insertions(

Re: [RFC PATCH 02/34] target/riscv: Fix size of trivial CPUArchState fields

2025-09-29 Thread a...@rev.ng
On 29/09/25, Alistair Francis wrote: > On Thu, Sep 25, 2025 at 7:37 AM Richard Henderson > wrote: > > > > On 9/24/25 00:20, Anton Johansson via wrote: > > > +++ b/target/riscv/machine.c > > > @@ -84,13 +84,13 @@ static const VMStateDescription vmstate_hyper = { > > > .minimum_version_id = 4,

Re: [PATCH v6 46/47] hw/arm/xlnx-versal-virt: add the xlnx-versal2-virt machine

2025-09-29 Thread Philippe Mathieu-Daudé
On 26/9/25 09:08, Luc Michel wrote: Add the Versal Gen 2 Virtual development machine embedding a versal2 SoC. This machine follows the same principle than the xlnx-versal-virt machine. It creates its own DTB and feeds it to the software payload. This way only implemented devices are exposed to th

Re: [PATCH v6 38/47] hw/arm/xlnx-versal: add the target field in IRQ descriptor

2025-09-29 Thread Philippe Mathieu-Daudé
On 26/9/25 09:07, Luc Michel wrote: Add the target field in the IRQ descriptor. This allows to target an IRQ to another IRQ controller than the GIC(s). Other supported targets are the PMC PPU1 CPU interrupt controller and the EAM (Error management) device. Those two devices are currently not impl

Re: [PATCH 0/7] Register API leaks fixes

2025-09-29 Thread Philippe Mathieu-Daudé
Hi Luc, On 17/9/25 13:44, Luc Michel wrote: Based-on: 20250912100059.103997-1-luc.mic...@amd.com ([PATCH v5 00/47] AMD Versal Gen 2 support) Note: this series is based on my Versal 2 series. It modifies the CRL device during the register API refactoring. It can easily be rebased on master i

Re: [PATCH v2 07/14] hw/arm/smmuv3: Make Configuration Cache security-state aware

2025-09-29 Thread Eric Auger
On 9/25/25 6:26 PM, Tao Tang wrote: > This patch adapts the Configuration Cache (STE/CD caches) to support > multiple security states. > > The cache key, previously just the SMMUDevice, is now a composite key > of the SMMUDevice and the security index (sec_idx). This allows for > separate cache

Re: [PATCH] virtio: vhost-user-device: Make user creatable again

2025-09-29 Thread Christian Speich
On Mon, Sep 22, 2025 at 04:14:55PM +0100, Alex Bennée wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Sep 22, 2025 at 03:26:23PM +0200, Christian Speich wrote: > >> On Mon, Sep 22, 2025 at 09:08:47AM -0400, Michael S. Tsirkin wrote: > >> > On Mon, Sep 22, 2025 at 01:49:55PM +0100, Daniel P. B

Re: [PATCH 3/3] docs/code-provenance: AI exceptions are in addition to DCO

2025-09-29 Thread Kevin Wolf
Am 22.09.2025 um 17:48 hat Paolo Bonzini geschrieben: > Using phrasing from https://openinfra.org/legal/ai-policy (with just > "commit" replaced by "submission", because we do not submit changes > as commits but rather emails), clarify that the contributor remains > responsible for its copyright or

Re: [PATCH v2 06/14] hw/arm/smmuv3: Add separate address space for secure SMMU accesses

2025-09-29 Thread Eric Auger
Hi Tao, On 9/25/25 6:26 PM, Tao Tang wrote: > According to the Arm architecture, SMMU-originated memory accesses, > such as fetching commands or writing events for a secure stream, must > target the Secure Physical Address (PA) space. The existing model sends > all DMA to the global address_space_