ping
On Tue, Jul 30, 2024 at 04:15:52PM +0200, Alberto Garcia wrote:
> This tool converts a disk image to qcow2, writing the result directly
> to stdout. This can be used for example to send the generated file
> over the network.
On Tue, Jul 30, 2024 at 04:15:52PM +0200, Alberto Garcia wrote:
> This tool converts a disk image to qcow2, writing the result directly
> to stdout. This can be used for example to send the generated file
> over the network.
ping
ping
On Tue, Jul 30, 2024 at 04:15:52PM +0200, Alberto Garcia wrote:
> This tool converts a disk image to qcow2, writing the result directly
> to stdout. This can be used for example to send the generated file
> over the network.
formats. Alternatively the user can also run qemu-nbd
or qemu-storage-daemon manually instead.
Signed-off-by: Alberto Garcia
Signed-off-by: Madeeha Javed
---
scripts/qcow2-to-stdout.py | 449 +
1 file changed, 449 insertions(+)
create mode 100755 scripts
On Mon 29 Jul 2024 03:20:18 PM -05, Eric Blake wrote:
> On Mon, Jul 29, 2024 at 05:02:26PM GMT, Alberto Garcia wrote:
>> +# qcow2 files produced by this script are always arranged like this:
>> +#
>> +# - qcow2 header
>> +# - refcount table
>> +# - refcount b
formats. Alternatively the user can also run qemu-ndb
or qemu-storage-daemon manually instead.
Signed-off-by: Alberto Garcia
Signed-off-by: Madeeha Javed
---
scripts/qcow2-to-stdout.py | 400 +
1 file changed, 400 insertions(+)
create mode 100755 scripts
On Sun 28 Jul 2024 01:01:07 AM +03, Nir Soffer wrote:
>> +def bitmap_set(bitmap, idx):
>> +bitmap[int(idx / 8)] |= 1 << (idx % 8)
>
> Should use floor division operator (//):
>
> bitmap[idx // 8] |= 1 << (idx % 8)
>
> Same for bitmap_test().
Right, also for all other cases of int(foo / bar
ping
On Mon, Jul 01, 2024 at 05:11:40PM +0200, Alberto Garcia wrote:
> This tool converts a disk image to qcow2, writing the result directly
> to stdout. This can be used for example to send the generated file
> over the network.
formats. Alternatively the user can also run qemu-ndb
or qemu-storage-daemon manually instead.
Signed-off-by: Alberto Garcia
Signed-off-by: Madeeha Javed
---
scripts/qcow2-to-stdout.py | 377 +
1 file changed, 377 insertions(+)
create mode 100755 scripts
On Mon 01 Jul 2024 02:07:01 PM +03, Manos Pitsidianakis wrote:
>> and I'm not sure what benefits using pathlib brings in this case.
>
> implicit type requirement, argument value validations, path
> normalization etc.
Do you have a specific example? I don't see any difference in behavior
if I make
On Wed 12 Jun 2024 02:00:19 PM +03, Manos Pitsidianakis wrote:
Hi, thanks for the review and sorry for taking so long to reply, I was
on vacation.
>> scripts/qcow2-to-stdout.py | 330 +
>> 1 file changed, 330 insertions(+)
>> create mode 100755 scripts/qcow2-to-
On Wed 12 Jun 2024 09:01:01 AM +03, Manos Pitsidianakis wrote:
> Hello Alberto,
Hello Manos!
> > This is equivalent to using qemu-img to convert a file to qcow2 and
> > then writing the result to stdout, with the difference that this
> > tool does not need to create this temporary qcow2 file and
qemu-ndb
or qemu-storage-daemon manually instead.
Signed-off-by: Alberto Garcia
Signed-off-by: Madeeha Javed
---
scripts/qcow2-to-stdout.py | 330 +
1 file changed, 330 insertions(+)
create mode 100755 scripts/qcow2-to-stdout.py
diff --git a/scripts/qcow2
e
> (i.e. fallocate(FALLOC_FL_PUNCH_HOLE|FALLOC_FL_KEEP_SIZE) is called for
> both) and that with the option enabled cluster is still marked as
> allocated in "qemu-img map" output. We also check that the option
> doesn't work with qcow2 v2 images.
>
> Signed-off-by: Andrey Drobyshev
Reviewed-by: Alberto Garcia
Berto
v
Reviewed-by: Alberto Garcia
Berto
On Mon 13 May 2024 09:31:56 AM +03, Andrey Drobyshev wrote:
> This would ease debugging of write zeroes and discard operations.
>
> Signed-off-by: Andrey Drobyshev
Reviewed-by: Alberto Garcia
Berto
option is the new entry simply to contain the same host cluster offset,
> no matter whether we unmap or zeroize the cluster. For that OR'ing with
> the old entry is enough.
>
> This patch doesn't change the logic and is pure refactoring.
>
> Signed-off-by: Andrey Drobyshev
Reviewed-by: Alberto Garcia
Berto
;
> Signed-off-by: Andrey Drobyshev
> Reviewed-by: Hanna Czenczek
Reviewed-by: Alberto Garcia
Berto
On Fri 22 Dec 2023 11:31:12 AM +01, Markus Armbruster wrote:
>> This allows returning a tree of all object properties under a given
>> path, in a way similar to scripts/qmp/qom-tree.
>
> Use case? We already have that script, and also HMP info qom-tree.
The main use case is convenience.
Manageme
This allows returning a tree of all object properties under a given
path, in a way similar to scripts/qmp/qom-tree.
Signed-off-by: Alberto Garcia
---
qapi/qom.json | 10 +-
qom/qom-hmp-cmds.c | 4 ++--
qom/qom-qmp-cmds.c | 22 +-
3 files changed, 32 insertions
On Mon, Nov 20, 2023 at 05:23:27PM -0600, Eric Blake wrote:
> > I'm interested in this use case, and I think that the method would be
> > as simple as this:
> >
> > 1. Decide a cluster size for the output qcow2 file.
> > 2. Read the input file once to determine which clusters need to be
> >all
Hi,
I haven't written here in a while :) but I have something small that I
would like to discuss.
Using qemu-img to convert an image and writing the result directly to
stdout is a question that has already been raised in the past (see
[1] for an example) and it's clear that it's generally not pos
w]
> ThrottleConfig cfg;
> ^
> tests/unit/test-throttle.c:28:23: note: previous declaration is here
> static ThrottleConfig cfg;
> ^
>
> Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Alberto Garcia
Berto
Fixes build with -Wshadow=local
Signed-off-by: Alberto Garcia
---
tests/unit/test-throttle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/unit/test-throttle.c b/tests/unit/test-throttle.c
index cb587e33e7..ac35d65d19 100644
--- a/tests/unit/test-throttle.c
+++ b
On Tue 27 Jun 2023 03:24:30 PM +08, zhenwei pi wrote:
> Signed-off-by: zhenwei pi
Reviewed-by: Alberto Garcia
Berto
-by: zhenwei pi
Reviewed-by: Alberto Garcia
Berto
ite* timer(read timer callback is defined, but never invoked).
>
> Allow a single direction in throttle, this reduces memory, and uplayer
> does not need a dummy callback any more.
>
> Signed-off-by: zhenwei pi
Reviewed-by: Alberto Garcia
Berto
On Tue 27 Jun 2023 03:24:28 PM +08, zhenwei pi wrote:
> Use enum ThrottleType instead in the throttle test codes.
>
> Signed-off-by: zhenwei pi
Reviewed-by: Alberto Garcia
Berto
On Tue 27 Jun 2023 03:24:27 PM +08, zhenwei pi wrote:
> Use enum ThrottleType instead of number index.
>
> Signed-off-by: zhenwei pi
Reviewed-by: Alberto Garcia
Berto
On Sun 25 Jun 2023 04:56:29 PM +08, zhenwei pi wrote:
> void throttle_timers_attach_aio_context(ThrottleTimers *tt,
> AioContext *new_context)
> {
> -tt->timers[THROTTLE_TIMER_READ] =
> -aio_timer_new(new_context, tt->clock_type, SCALE_NS,
> -
On Sun 25 Jun 2023 04:56:30 PM +08, zhenwei pi wrote:
> Signed-off-by: zhenwei pi
Reviewed-by: Alberto Garcia
Berto
-by: zhenwei pi
Reviewed-by: Alberto Garcia
Berto
On Sun 25 Jun 2023 04:56:28 PM +08, zhenwei pi wrote:
> Use enum ThrottleTimerType instead in the throttle test codes.
>
> Signed-off-by: zhenwei pi
Reviewed-by: Alberto Garcia
Berto
On Sun 25 Jun 2023 04:56:27 PM +08, zhenwei pi wrote:
> Use enum ThrottleTimerType instead of number index.
> +typedef enum {
> +THROTTLE_TIMER_READ = 0,
> +THROTTLE_TIMER_WRITE,
> +THROTTLE_TIMER_MAX
> +} ThrottleTimerType;
If you're doing this I suppose you could also change 'bool i
gned-off-by: Thomas Huth
Reviewed-by: Alberto Garcia
Berto
On Wed 21 Sep 2022 09:47:32 AM +08, Wang Liang wrote:
>> > -return limit->slice_end_time - now;
>> > +return MAX(limit->slice_end_time - now, 0);
>>
>> How can this be negative? slice_end_time is guaranteed to be larger
>> than
>> now:
>>
>> if (limit->slice_end_time < now) {
>>
On Tue 20 Sep 2022 08:33:50 PM +08, wanglian...@126.com wrote:
> From: Wang Liang
>
> The delay time should never be a negative value.
>
> -return limit->slice_end_time - now;
> +return MAX(limit->slice_end_time - now, 0);
How can this be negative? slice_end_time is guaranteed to be large
t; Signed-off-by: Vladimir Sementsov-Ogievskiy
> Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
Berto
On Tue 04 May 2021 11:45:09 AM CEST, Vladimir Sementsov-Ogievskiy
wrote:
> All existing parent types (block nodes, block devices, jobs) has the
> realization. So, drop unreachable code.
s/has/have/ , and I'm not sure what "have the realization" means
> static char *bdrv_child_user_desc(BdrvChi
utput is updated.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
n your reply to the
patch,
Reviewed-by: Alberto Garcia
Berto
ed.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
ing tran_new() call below that loop.
>
> Reported-by: Coverity (CID 1452772)
> Reported-by: Peter Maydell
> Suggested-by: Peter Maydell
> Fixes: 72373e40fbc7e4218061a8211384db362d3e7348
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
On Mon 03 May 2021 01:33:57 PM CEST, Vladimir Sementsov-Ogievskiy
wrote:
> @@ -2918,12 +2918,18 @@ BdrvChild *bdrv_root_attach_child(BlockDriverState
> *child_bs,
> child_role, perm, shared_perm, opaque,
> &child, tran, errp
(check that change is correct).
>
> New check will substitute bdrv_check_update_perm() in following
> permissions refactoring, so keep error messages the same to avoid
> unit test result changes.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
On Wed 17 Mar 2021 03:34:58 PM CET, Vladimir Sementsov-Ogievskiy
wrote:
> Add new handler to get aio context and implement it in all child
> classes. Add corresponding public interface to be used soon.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
ff-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
le of abort)
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
> @@ -4645,36 +4640,22 @@ int bdrv_replace_node(BlockDriverState *from,
> BlockDriverState *to,
> * bs_new must not be attached to a BlockBackend.
> *
> * This function does
one. Still,
> let's be precise.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
On Thu 18 Mar 2021 03:25:07 PM CET, Vladimir Sementsov-Ogievskiy
wrote:
>> static int bdrv_reopen_prepare(BDRVReopenState *reopen_state,
>> BlockReopenQueue *queue,
>> - Transaction *set_backings_tran, Error
>> **errp);
>> +
;
> This is caused by buf[512] left uninitialized and passed to
> bdrv_save_vmstate() that expects a const uint8_t *, so the compiler
> assumes it will be read and expects the parameter to be initialized.
>
> Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Alberto Garcia
Berto
Signed-off-by: Alberto Garcia
---
qapi/block-core.json | 18 +
blockdev.c | 78 +++---
tests/qemu-iotests/155 | 9 +++--
tests/qemu-iotests/165 | 4 +-
tests/qemu-iotests/245 | 27 +++--
tests/qemu-iotests/248
lacing the 'file' option. This is
similar to replacing the backing file and the user is likewise
responsible for the correctness of the resulting graph, otherwise this
can lead to data corruption.
Signed-off-by: Alberto Garcia
---
include/block/block.h | 1 +
block.c
This patch drops the 'x-' prefix from x-blockdev-reopen.
Signed-off-by: Alberto Garcia
---
qapi/block-core.json | 6 +++---
blockdev.c | 2 +-
tests/qemu-iotests/155 | 2 +-
tests/qemu-iotests/165 | 2 +-
tests/qemu-iotests/245 | 10 +-
#x27;iotests: Test replacing files with x-blockdev-reopen'
004/6:[0071] [FC] 'block: Support multiple reopening with x-blockdev-reopen'
005/6:[] [--] 'iotests: Test reopening multiple devices at the same time'
006/6:[] [-C] 'block: Make blockdev-reopen stable AP
Move the code to free a BlockReopenQueue to a separate function.
It will be used in a subsequent patch.
Signed-off-by: Alberto Garcia
---
include/block/block.h | 1 +
block.c | 16
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/include/block
This patch adds new tests in which we use x-blockdev-reopen to change
bs->file
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/245 | 109 -
tests/qemu-iotests/245.out | 11 +++-
2 files changed, 117 insertions(+), 3 deletions(-)
diff --git a/te
This test swaps the images used by two active block devices.
This is now possible thanks to the new ability to run
x-blockdev-reopen on multiple devices at the same time.
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/245 | 41 ++
tests/qemu
On Wed 17 Mar 2021 03:35:06 PM CET, Vladimir Sementsov-Ogievskiy
wrote:
> Rewrite bdrv_check_perm(), bdrv_abort_perm_update() and bdrv_set_perm()
> to update nodes in topological sort order instead of simple DFS. With
> topologically sorted nodes, we update a node only when all its parents
> alre
rrors gracefully and just fail starting the block job.
>
> Reported-by: Nini Gu
> Signed-off-by: Kevin Wolf
Reviewed-by: Alberto Garcia
Berto
Test replacing files with x-blockdev-reopen'
004/6:[0042] [FC] 'block: Support multiple reopening with x-blockdev-reopen'
005/6:[0015] [FC] 'iotests: Test reopening multiple devices at the same time'
006/6:[down] 'block: Make blockdev-reopen stable API'
Alberto Gar
Signed-off-by: Alberto Garcia
---
qapi/block-core.json | 18
blockdev.c | 85 +-
tests/qemu-iotests/155 | 9 ++--
tests/qemu-iotests/165 | 4 +-
tests/qemu-iotests/245 | 27 +++-
tests/qemu-iotests/248
This patch drops the 'x-' prefix from x-blockdev-reopen.
Signed-off-by: Alberto Garcia
---
qapi/block-core.json | 6 +++---
blockdev.c | 2 +-
tests/qemu-iotests/155 | 2 +-
tests/qemu-iotests/165 | 2 +-
tests/qemu-iotests/245 | 10 +-
Move the code to free a BlockReopenQueue to a separate function.
It will be used in a subsequent patch.
Signed-off-by: Alberto Garcia
---
include/block/block.h | 1 +
block.c | 16
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/include/block
This test swaps the images used by two active block devices.
This is now possible thanks to the new ability to run
x-blockdev-reopen on multiple devices at the same time.
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/245 | 41 ++
tests/qemu
lacing the 'file' option. This is
similar to replacing the backing file and the user is likewise
responsible for the correctness of the resulting graph, otherwise this
can lead to data corruption.
Signed-off-by: Alberto Garcia
---
include/block/block.h | 1 +
block.c
This patch adds new tests in which we use x-blockdev-reopen to change
bs->file
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/245 | 109 -
tests/qemu-iotests/245.out | 11 +++-
2 files changed, 117 insertions(+), 3 deletions(-)
diff --git a/te
On Mon 01 Mar 2021 01:11:55 PM CET, Peter Lieven wrote:
> Why we talk about throttling I still do not understand the following part in
> util/throttle.c function throttle_compute_wait
>
>
> if (!bkt->max) {
> /* If bkt->max is 0 we still want to allow short bursts of I/O
> *
On Wed 24 Feb 2021 01:33:05 PM CET, Kevin Wolf wrote:
>> > { 'command': 'x-blockdev-reopen',
>> > - 'data': 'BlockdevOptions', 'boxed': true }
>> > + 'data': { 'options': ['BlockdevOptions'] } }
>>
>> Do we also want to drop x- prefix?
>
> libvirt really wants to have a stable blockdev-reopen
On Thu 25 Feb 2021 06:34:48 PM CET, Peter Lieven wrote:
> I was wondering if there is a way to check from outside (qmp etc.) if
> a throttled block device has exceeded the iops_max_length seconds of
> time bursting up to iops_max and is now hard limited to the iops limit
> that is supplied?
>
> Wo
Signed-off-by: Alberto Garcia
---
v2: Don't use the x-* interface to specify limits [Kevin]
tests/qemu-iotests/087 | 8 ++--
tests/qemu-iotests/184 | 18 ++
tests/qemu-iotests/218 | 2 +-
tests/qemu-iotests/235 | 2 +-
tests/qemu-iotests/245
On Fri 19 Feb 2021 01:21:49 PM CET, Kevin Wolf wrote:
>> log(vm.qmp('object-add', qom_type='throttle-group', id='tg0',
>> - props={ 'x-bps-total': size }))
>> + x_bps_total=size))
>
> x-bps-total isn't a stable interface, I'd prefer to use limits.
>
> My patch from November [1
On Fri 19 Feb 2021 01:04:00 PM CET, Max Reitz wrote:
> Two Python syntax nit picks below.
>> ret = vm.qmp('object-add', qom_type='throttle-group', id='tg',
>> - props={'x-bps-read': 4096})
>> + x_bps_read = 4096)
>
> To stay consistent, I think there shouldn’
On Tue 16 Feb 2021 05:48:07 PM CET, Kevin Wolf wrote:
>> There is no problem with removing the filter anymore. See here for a
>> description of the original problem:
>>
>> https://lists.gnu.org/archive/html/qemu-block/2020-12/msg00090.html
>
> Ah, nice. Can we just add removing the filter again t
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/087 | 8 ++--
tests/qemu-iotests/184 | 18 ++
tests/qemu-iotests/218 | 2 +-
tests/qemu-iotests/235 | 2 +-
tests/qemu-iotests/245 | 4 ++--
tests/qemu-iotests/258 | 7 +++
tests/qemu
On Wed 10 Feb 2021 06:26:57 PM CET, Kevin Wolf wrote:
> You have a test case for adding a throttling filter. Can we also
> remove it again or is there still a problem with that? I seem to
> remember that that was a bit trickier, though I'm not sure what it
> was. Was it that we can't have the thro
On Tue 09 Feb 2021 09:03:02 AM CET, Vladimir Sementsov-Ogievskiy wrote:
>> { 'command': 'x-blockdev-reopen',
>> - 'data': 'BlockdevOptions', 'boxed': true }
>> + 'data': { 'options': ['BlockdevOptions'] } }
>
> Do we also want to drop x- prefix?
I think we can drop it once it's clear the the A
On Wed 10 Feb 2021 05:52:47 PM CET, Kevin Wolf wrote:
>> +/* The 'file' option only allows strings */
>> +assert(qobject_type(value) == QTYPE_QSTRING);
>
> This is true, but not entirely obvious: The QAPI schema has
> BlockdevRef, which can be either a string or a dict. However, we're
> dea
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/245 | 40 ++
tests/qemu-iotests/245.out | 4 ++--
2 files changed, 42 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245
index 850c9f070b..d18dbbe638 100755
Signed-off-by: Alberto Garcia
---
qapi/block-core.json | 2 +-
include/block/block.h | 1 +
block.c| 16 +--
blockdev.c | 85 +-
tests/qemu-iotests/155 | 9 ++--
tests/qemu-iotests/165 | 4
apply on top of Vladimir's branch:
git: https://src.openvz.org/scm/~vsementsov/qemu.git
tag: up-block-topologic-perm-v2
Regards,
Berto
Alberto Garcia (4):
block: Allow changing bs->file on reopen
iotests: Update 245 to support replacing files with x-blockdev-reopen
block: Support mu
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/245 | 54 +-
tests/qemu-iotests/245.out | 4 +--
2 files changed, 55 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245
index f9d68b3958..bad6911f0c 100755
--- a
lacing the 'file' option. This is
similar to replacing the backing file and the user is likewise
responsible for the correctness of the resulting graph, otherwise this
can lead to data corruption.
Signed-off-by: Alberto Garcia
---
include/block/block.h | 1 +
block.c
On Thu 21 Jan 2021 11:52:17 AM CET, Kevin Wolf wrote:
>> Hmm, still, removing a filter which want to unshare WRITE even when
>> doesn't have any parents will be a problem anyway, so we'll need a
>> new command to drop filter with a logic like in bdrv_drop_filter in
>> my series.
>>
>> Or, we can i
alue and a local variable that you use to iterate over the list.
Anyway,
Reviewed-by: Alberto Garcia
Berto
On Tue 02 Feb 2021 01:49:50 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> -Qcow2BitmapInfoList *qcow2_get_bitmap_info_list(BlockDriverState *bs,
> -Error **errp)
> +bool qcow2_get_bitmap_info_list(BlockDriverState *bs,
> +
> overhead in further patches.
>
> Choose int return status, because bdrv_replace_node_common() has call
> to bdrv_check_update_perm(), which reports int status, which seems
> correct to propagate.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
I had already reviewed this o
> overhead in further patches.
>
> Choose int return status, because bdrv_replace_node_common() has call
> to bdrv_check_update_perm(), which reports int status, which seems
> correct to propagate.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
On Mon 18 Jan 2021 11:22:49 AM CET, Vladimir Sementsov-Ogievskiy wrote:
>> This is still an RFC but you can see the idea.
>
> Good idea and I glad to see that my patches help:)
>
> Hmm, still, removing a filter which want to unshare WRITE even when
> doesn't have any parents will be a problem anywa
On Mon 18 Jan 2021 11:15:17 AM CET, Vladimir Sementsov-Ogievskiy wrote:
>> +static int bdrv_reopen_parse_file(BDRVReopenState *reopen_state,
>> + GSList **tran,
>> + Error **errp)
>> +{
>> +BlockDriverState *bs = reopen_state->bs
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/245 | 54 +-
tests/qemu-iotests/245.out | 4 +--
2 files changed, 55 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245
index f9d68b3958..bad6911f0c 100755
--- a
welcome!
Berto
Alberto Garcia (2):
block: Allow changing bs->file on reopen
iotests: Update 245 to support replacing files with x-blockdev-reopen
include/block/block.h | 1 +
block.c| 61 ++
tests/qemu-i
lacing the 'file' option. This is
similar to replacing the backing file and the user is likewise
responsible for the correctness of the resulting graph, otherwise this
can lead to data corruption.
Signed-off-by: Alberto Garcia
---
include/block/block.h | 1 +
block.c
On Sat 09 Jan 2021 01:57:59 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> Now bdrv_append returns status and we can drop all the local_err things
> around it.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
On Sat 09 Jan 2021 01:57:58 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> -void bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd,
> +int bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd,
> Error **errp)
The indentation of the se
Signed-off-by: Alberto Garcia
Suggested-by: Maxim Levitsky
Reviewed-by: Maxim Levitsky
---
v2: Rebase on top of the latest master
tests/qemu-iotests/313 | 103 +
tests/qemu-iotests/313.out | 29 +++
tests/qemu-iotests/group | 1 +
3 files
al_err);
ret = -EINVAL;
goto fail;
}
But otherwise your solution is correct, so you can keep it if you
prefer:
Reviewed-by: Alberto Garcia
Berto
On Fri 27 Nov 2020 03:45:00 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> Each of them has only one caller. Open-coding simplifies further
> pemission-update system changes.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
On Fri 27 Nov 2020 03:44:55 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> Functions with errp argument are not recommened to be void-functions.
> Improve bdrv_replace_node().
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
On Fri 27 Nov 2020 03:44:54 PM CET, Vladimir Sementsov-Ogievskiy via wrote:
> These functions are called only from bdrv_reopen_multiple() in block.c.
> No reason to publish them.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
1 - 100 of 3601 matches
Mail list logo
